Re: [PATCH v1 4/4] vhost-vdpa:add callback function for configure interrupt

2021-01-13 Thread Cindy Lu
On Thu, Jan 14, 2021 at 12:17 AM Michael S. Tsirkin wrote: > > On Wed, Jan 13, 2021 at 11:45:40PM +0800, Cindy Lu wrote: > > Add call back function for configure interrupt. > > Set the notifier's fd to the kernel driver when vdpa start. > > also set -1 when vdpa stop. then the kernel will release

[PATCH v3 4/4] hw/blocl/nvme: trigger async event during injecting smart warning

2021-01-13 Thread zhenwei pi
During smart critical warning injection by setting property from QMP command, also try to trigger asynchronous event. Signed-off-by: zhenwei pi --- hw/block/nvme.c | 47 --- 1 file changed, 40 insertions(+), 7 deletions(-) diff --git

Re: [PATCH v6 08/11] iotests: add testenv.py

2021-01-13 Thread Vladimir Sementsov-Ogievskiy
14.01.2021 09:14, Vladimir Sementsov-Ogievskiy wrote: 12.01.2021 20:36, Kevin Wolf wrote: Am 09.01.2021 um 13:26 hat Vladimir Sementsov-Ogievskiy geschrieben: Add TestEnv class, which will handle test environment in a new python iotests running framework. Difference with current ./check

Re: [PATCH v1 0/4] vhost-vdpa: add support for configure interrupt

2021-01-13 Thread Cindy Lu
On Thu, Jan 14, 2021 at 12:36 PM Jason Wang wrote: > > > On 2021/1/13 下午11:45, Cindy Lu wrote: > > Add configure interrupt support in vdpa_vhost. qemu will use the irqfd > > process to support this feature. > > > > These code are all tested in vp-vdpa (support configure interrupt) > > vdpa_sim

[PATCH v3 3/4] hw/block/nvme: add smart_critical_warning property

2021-01-13 Thread zhenwei pi
There is a very low probability that hitting physical NVMe disk hardware critical warning case, it's hard to write & test a monitor agent service. For debugging purposes, add a new 'smart_critical_warning' property to emulate this situation. The orignal version of this change is implemented by

[PATCH v3 0/4] support NVMe smart critial warning injection

2021-01-13 Thread zhenwei pi
v2 -> v3: - Introduce "Persistent Memory Region has become read-only or unreliable" - Fix overwritten bar.cap - Check smart critical warning value from QOM. - Trigger asynchronous event during smart warning injection. v1 -> v2: - Suggested by Philippe & Klaus, set/get smart_critical_warning

[PATCH v3 1/4] block/nvme: introduce bit 5 for critical warning

2021-01-13 Thread zhenwei pi
According to NVMe spec 1.4 section , introduce bit 5 for "Persistent Memory Region has become read-only or unreliable". Signed-off-by: zhenwei pi --- include/block/nvme.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/block/nvme.h b/include/block/nvme.h index 3e02d9ca98..f68a88c712

[PATCH v3 2/4] hw/block/nvme: fix overwritten bar.cap

2021-01-13 Thread zhenwei pi
After PMR initialization, bar.cap should not be clear in function nvme_init_ctrl. Otherwise the PMR cap would be always disabled. Signed-off-by: zhenwei pi --- hw/block/nvme.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 27d2c72716..f361103bb4

Re: [PATCH v1 4/4] vhost-vdpa:add callback function for configure interrupt

2021-01-13 Thread Cindy Lu
On Thu, Jan 14, 2021 at 12:46 PM Jason Wang wrote: > > > On 2021/1/13 下午11:45, Cindy Lu wrote: > > Add call back function for configure interrupt. > > Set the notifier's fd to the kernel driver when vdpa start. > > also set -1 when vdpa stop. then the kernel will release > > the related聽resource聽

Re: [PATCH v2] osdep.h: Remove include

2021-01-13 Thread Thomas Huth
On 13/01/2021 22.56, Michael Forney wrote: Prior to 2a4b472c3c, sys/signal.h was only included on OpenBSD (apart from two .c files). The POSIX standard location for this header is just and in fact, OpenBSD's signal.h includes sys/signal.h itself. Unconditionally including on musl causes

[PATCH v3 1/2] Fix net.c warning on GCC 11

2021-01-13 Thread Miroslav Rezanina
When building qemu with GCC 11, compiling eth.c file produce following warning: warning: array subscript 'struct ip6_ext_hdr_routing[0]' is partly outside array bounds of 'struct ip6_ext_hdr[1]' [-Warray-bounds] This is caused by retyping from ip6_ext_hdr to ip6_ext_hdr_routing that has more

[PATCH v3 0/2] Fixing several GCC 11 warnings

2021-01-13 Thread Miroslav Rezanina
Compiling qemu using GCC 11 we got several new warnings. To allow build with --enable-werror, we need to solve issues generating these warnings. Signed-of-by: Miroslav Rezanina v2: - Patch 2 rewrite to use strpadcpy - removed Patch 3 (different version sent by Philippe Mathieu-Daudé) v3:

[PATCH v3 2/2] s390x: Use strpadcpy for copying vm name

2021-01-13 Thread Miroslav Rezanina
Using strncpy with length equal to the size of target array, GCC 11 reports following warning: warning: '__builtin_strncpy' specified bound 256 equals destination size [-Wstringop-truncation] We can prevent this warning by using strpadcpy that copies string up to specified length, zeroes

Re: [PATCH v1 2/4] virtio-pci:add support for configure interrupt

2021-01-13 Thread Cindy Lu
On Thu, Jan 14, 2021 at 12:43 PM Jason Wang wrote: > > > On 2021/1/13 下午11:45, Cindy Lu wrote: > > Add support for configure interrupt, use kvm_irqfd_assign and set the > > gsi to kernel. When the configure notifier was eventfd_signal by host > > kernel, this will finally inject an msix interrupt

Re: [PATCH v6 08/11] iotests: add testenv.py

2021-01-13 Thread Vladimir Sementsov-Ogievskiy
12.01.2021 20:36, Kevin Wolf wrote: Am 09.01.2021 um 13:26 hat Vladimir Sementsov-Ogievskiy geschrieben: Add TestEnv class, which will handle test environment in a new python iotests running framework. Difference with current ./check interface: - -v (verbose) option dropped, as it is unused -

Re: [PATCH v6 07/11] iotests: add findtests.py

2021-01-13 Thread Vladimir Sementsov-Ogievskiy
12.01.2021 19:42, Kevin Wolf wrote: +def find_tests(self, groups: Optional[List[str]] = None, + exclude_groups: Optional[List[str]] = None, + tests: Optional[List[str]] = None, group and tests seem to be read-only, so this can be simplified to 'groups:

Re: [PATCH v1 1/4] virtio:add support in configure interrupt

2021-01-13 Thread Cindy Lu
On Thu, Jan 14, 2021 at 12:34 PM Jason Wang wrote: > > > On 2021/1/13 下午11:45, Cindy Lu wrote: > > Add configure notifier and virtio_set_config_notifier_fd_handler > > in virtio > > > > Signed-off-by: Cindy Lu > > --- > > hw/virtio/virtio.c | 25 + > >

Re: [PATCH V3 0/4] bsd-user: Fix some code style problems

2021-01-13 Thread shiliyang
On 2021/1/14 6:03, Warner Losh wrote: > While these changes look good, can you submit this against the bsd-user > repository? White space changes like this in mainline make rebasing harder > than needed. > > https://github.com/qemu-bsd-user/qemu-bsd-user >

Re: [PATCH v2 00/12] qapi: static typing conversion, pt1.5

2021-01-13 Thread Markus Armbruster
John Snow writes: > Hi, this patchset enables strict optional checking in mypy for > everything we have typed so far. > > In general, this patchset seeks to eliminate Optional[T] in favor of T > wherever possible. Optional types used for object properties, > function/method parameters and return

[PATCH v17 16/20] multi-process: PCI BAR read/write handling for proxy & remote endpoints

2021-01-13 Thread Jagannathan Raman
Proxy device object implements handler for PCI BAR writes and reads. The handler uses BAR_WRITE/BAR_READ message to communicate to the remote process with the BAR address and value to be written/read. The remote process implements handler for BAR_WRITE/BAR_READ message. Signed-off-by: Jagannathan

[PATCH v17 20/20] multi-process: perform device reset in the remote process

2021-01-13 Thread Jagannathan Raman
From: Elena Ufimtseva Perform device reset in the remote process when QEMU performs device reset. This is required to reset the internal state (like registers, etc...) of emulated devices Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman

[PATCH v17 17/20] multi-process: Synchronize remote memory

2021-01-13 Thread Jagannathan Raman
Add ProxyMemoryListener object which is used to keep the view of the RAM in sync between QEMU and remote process. A MemoryListener is registered for system-memory AddressSpace. The listener sends SYNC_SYSMEM message to the remote process when memory listener commits the changes to memory, the

[PATCH v17 11/20] multi-process: Associate fd of a PCIDevice with its object

2021-01-13 Thread Jagannathan Raman
Associate the file descriptor for a PCIDevice in remote process with DeviceState object. Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi --- hw/remote/remote-obj.c | 203

[qemu-web PATCH] Use GitLab repo URLs instead of git.qemu.org URLs

2021-01-13 Thread Stefan Hajnoczi
Switch to GitLab repo URLs to reduce qemu.org bandwidth. Note that there is still one git.qemu.org remaining in _posts/2018-06-28-tcg-testing.md. The git object doesn't exist in GitLab and it's hard to use master since the link was to a Makefile that has since changed significantly. Nevermind.

Re: [PATCH 17/22] hw/riscv: sifive_u: Add QSPI0 controller and connect a flash

2021-01-13 Thread Alistair Francis
On Thu, Dec 31, 2020 at 3:51 AM Bin Meng wrote: > > From: Bin Meng > > This adds the QSPI0 controller to the SoC, and connnects an ISSI > 25WP256 flash to it. The generation of corresponding device tree > source fragment is also added. > > With this commit, upstream U-Boot for the SiFive HiFive

Re: [PATCH v1 4/4] vhost-vdpa:add callback function for configure interrupt

2021-01-13 Thread Michael S. Tsirkin
On Wed, Jan 13, 2021 at 11:45:40PM +0800, Cindy Lu wrote: > Add call back function for configure interrupt. > Set the notifier's fd to the kernel driver when vdpa start. > also set -1 when vdpa stop. then the kernel will release > the related聽resource聽 Something weird happened to the commit log

[PATCH v17 01/20] multi-process: add the concept description to docs/devel/qemu-multiprocess

2021-01-13 Thread Jagannathan Raman
From: John G Johnson Signed-off-by: John G Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi --- docs/devel/index.rst | 1 + docs/devel/multi-process.rst | 966 +++ MAINTAINERS

[PATCH v17 04/20] multi-process: Add config option for multi-process QEMU

2021-01-13 Thread Jagannathan Raman
Add configuration options to enable or disable multiprocess QEMU code Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Signed-off-by: Elena Ufimtseva Reviewed-by: Stefan Hajnoczi --- configure | 10 ++ meson.build | 4 +++- Kconfig.host | 4

[PATCH v17 06/20] multi-process: setup a machine object for remote device process

2021-01-13 Thread Jagannathan Raman
x-remote-machine object sets up various subsystems of the remote device process. Instantiate PCI host bridge object and initialize RAM, IO & PCI memory regions. Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Signed-off-by: Elena Ufimtseva Reviewed-by: Stefan Hajnoczi ---

[PATCH v17 10/20] multi-process: Initialize message handler in remote device

2021-01-13 Thread Jagannathan Raman
Initializes the message handler function in the remote process. It is called whenever there's an event pending on QIOChannel that registers this function. Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi ---

Re: [PATCH 08/22] hw/sd: ssi-sd: Support multiple block read (CMD18)

2021-01-13 Thread Alistair Francis
On Thu, Dec 31, 2020 at 3:41 AM Bin Meng wrote: > > From: Bin Meng > > In the case of a multiple block read operation every transfered > block has its suffix of CRC16. Update the state machine logic to > handle multiple block read. > > This also fixed the wrong command index for

Re: [PATCH 6/7] iotests/129: Limit mirror job's buffer size

2021-01-13 Thread Vladimir Sementsov-Ogievskiy
13.01.2021 17:06, Max Reitz wrote: Issuing 'stop' on the VM drains all nodes. If the mirror job has many large requests in flight, this may lead to significant I/O that looks a bit like the job is being drained. what do you mean by "looks like the job is being drained"? If "drain" in Qemu

[PATCH v17 18/20] multi-process: create IOHUB object to handle irq

2021-01-13 Thread Jagannathan Raman
IOHUB object is added to manage PCI IRQs. It uses KVM_IRQFD ioctl to create irqfd to injecting PCI interrupts to the guest. IOHUB object forwards the irqfd to the remote process. Remote process uses this fd to directly send interrupts to the guest, bypassing QEMU. Signed-off-by: John G Johnson

Re: [PULL 18/21] hw/misc: Add a PWM module for NPCM7XX

2021-01-13 Thread Hao Wu
On Wed, Jan 13, 2021 at 8:03 AM Peter Maydell wrote: > On Tue, 12 Jan 2021 at 16:58, Peter Maydell > wrote: > > > > From: Hao Wu > > > > The PWM module is part of NPCM7XX module. Each NPCM7XX module has two > > identical PWM modules. Each module contains 4 PWM entries. Each PWM has > > two

[PATCH v2 2/6] tcg/arm: Replace goto statement by fall through comment

2021-01-13 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tcg/arm/tcg-target.c.inc | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tcg/arm/tcg-target.c.inc b/tcg/arm/tcg-target.c.inc index 59bd196994f..0ffb2b13d14 100644 --- a/tcg/arm/tcg-target.c.inc +++ b/tcg/arm/tcg-target.c.inc @@

[PATCH v2 1/6] tcg/arm: Hoist common argument loads in tcg_out_op()

2021-01-13 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tcg/arm/tcg-target.c.inc | 192 +++ 1 file changed, 92 insertions(+), 100 deletions(-) diff --git a/tcg/arm/tcg-target.c.inc b/tcg/arm/tcg-target.c.inc index 0fd11264544..59bd196994f 100644 ---

Re: [PULL 0/7] Yank patches patches for 2021-01-13

2021-01-13 Thread Lukas Straub
On Wed, 13 Jan 2021 17:25:50 +0100 Markus Armbruster wrote: > Peter Maydell writes: > > > On Wed, 13 Jan 2021 at 09:31, Markus Armbruster wrote: > >> > >> This pull request is on behalf of Lukas. Hope that's okay. > >> > >> The following changes since commit > >>

Re: [PATCH v1 9/9] gitlab: move docs and tools build across from Travis

2021-01-13 Thread Wainer dos Santos Moschetta
On 1/13/21 12:14 PM, Alex Bennée wrote: While we are at it we might as well check the tag generation. For bonus points we run GNU globals htags into the public pages directory for publishing with the auto generated pages. Signed-off-by: Alex Bennée --- .gitlab-ci.yml | 22

[PATCH v2 2/8] iotests: Move try_remove to iotests.py

2021-01-13 Thread Max Reitz
Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- tests/qemu-iotests/124| 8 +--- tests/qemu-iotests/iotests.py | 11 +++ 2 files changed, 8 insertions(+), 11 deletions(-) diff --git a/tests/qemu-iotests/124 b/tests/qemu-iotests/124 index 3705cbb6b3..e40eeb50b9 100755

[PATCH v2 6/8] iotests/129: Actually test a commit job

2021-01-13 Thread Max Reitz
Before this patch, test_block_commit() performs an active commit, which under the hood is a mirror job. If we want to test various different block jobs, we should perhaps run an actual commit job instead. Doing so requires adding an overlay above the source node before the commit is done (and

Re: minimal "zero conf" build dockerfiles for fedora:latest and alpine:latest

2021-01-13 Thread John Snow
On 1/13/21 1:48 AM, Thomas Huth wrote: On 12/01/2021 23.37, John Snow wrote: I wanted to know what the minimal setup required was to replicate the compilation instructions featured on https://www.qemu.org/download/#source [...] >  pixman-devel \ pixman is only required for the softmmu

Re: minimal "zero conf" build dockerfiles for fedora:latest and alpine:latest

2021-01-13 Thread John Snow
On 1/13/21 3:20 AM, Paolo Bonzini wrote: On 12/01/21 23:37, John Snow wrote: - our configure file suggests bzip2 is an optional dependency (It's set to 'auto') but meson will error out if it is not present at configuration time: ../pc-bios/meson.build:5:2: ERROR: Program 'bzip2' not

Re: [PULL 0/7] Yank patches patches for 2021-01-13

2021-01-13 Thread Markus Armbruster
Peter Maydell writes: > On Wed, 13 Jan 2021 at 09:31, Markus Armbruster wrote: >> >> This pull request is on behalf of Lukas. Hope that's okay. >> >> The following changes since commit f8e1d8852e393b3fd524fb005e38590063d99bc0: >> >> Merge remote-tracking branch >>

[PATCH v17 05/20] multi-process: setup PCI host bridge for remote device

2021-01-13 Thread Jagannathan Raman
PCI host bridge is setup for the remote device process. It is implemented using remote-pcihost object. It is an extension of the PCI host bridge setup by QEMU. Remote-pcihost configures a PCI bus which could be used by the remote PCI device to latch on to. Signed-off-by: Jagannathan Raman

[PATCH v17 14/20] multi-process: add proxy communication functions

2021-01-13 Thread Jagannathan Raman
From: Elena Ufimtseva Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John G Johnson Reviewed-by: Stefan Hajnoczi --- include/hw/remote/mpqemu-link.h | 4 hw/remote/mpqemu-link.c | 34 ++ 2 files changed, 38

[PATCH v17 09/20] multi-process: define MPQemuMsg format and transmission functions

2021-01-13 Thread Jagannathan Raman
From: Elena Ufimtseva Defines MPQemuMsg, which is the message that is sent to the remote process. This message is sent over QIOChannel and is used to command the remote process to perform various tasks. Define transmission functions used by proxy and by remote. Signed-off-by: Jagannathan Raman

[PATCH v17 07/20] io: add qio_channel_writev_full_all helper

2021-01-13 Thread Jagannathan Raman
From: Elena Ufimtseva Adds qio_channel_writev_full_all() to transmit both data and FDs. Refactors existing code to use this helper. Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi Acked-by: Daniel P. Berrangé ---

[PATCH v17 12/20] multi-process: setup memory manager for remote device

2021-01-13 Thread Jagannathan Raman
SyncSysMemMsg message format is defined. It is used to send file descriptors of the RAM regions to remote device. RAM on the remote device is configured with a set of file descriptors. Old RAM regions are deleted and new regions, each with an fd, is added to the RAM. Signed-off-by: Jagannathan

Re: [PATCH 5/7] iotests/129: Actually test a commit job

2021-01-13 Thread Vladimir Sementsov-Ogievskiy
13.01.2021 17:06, Max Reitz wrote: Before this patch, test_block_commit() performs an active commit, which under the hood is a mirror job. If we want to test various different block jobs, we should perhaps run an actual commit job instead. Doing so requires adding an overlay above the source

Re: [PATCH 09/22] hw/sd: ssi-sd: Use macros for the dummy value and tokens in the transfer

2021-01-13 Thread Alistair Francis
On Thu, Dec 31, 2020 at 3:38 AM Bin Meng wrote: > > From: Bin Meng > > At present the codes use hardcoded numbers (0xff/0xfe) for the dummy > value and block start token. Replace them with macros, and add more > tokens for multiple block write. > > Signed-off-by: Bin Meng Reviewed-by: Alistair

[PATCH v17 19/20] multi-process: Retrieve PCI info from remote process

2021-01-13 Thread Jagannathan Raman
Retrieve PCI configuration info about the remote device and configure the Proxy PCI object based on the returned information Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi --- hw/remote/proxy.c | 84

[PATCH v2 5/6] tcg: Restrict tcg_out_op() to arrays of TCG_MAX_OP_ARGS elements

2021-01-13 Thread Philippe Mathieu-Daudé
tcg_reg_alloc_op() allocates arrays of TCG_MAX_OP_ARGS elements. The Aarch64 target already does this since commit 8d8db193f25 ("tcg-aarch64: Hoist common argument loads in tcg_out_op"), SPARC since commit b357f902bff ("tcg-sparc: Hoist common argument loads in tcg_out_op"). RISCV missed it upon

Re: [PATCH 13/22] hw/sd: Introduce receive_ready() callback

2021-01-13 Thread Alistair Francis
On Thu, Dec 31, 2020 at 3:44 AM Bin Meng wrote: > > From: Bin Meng > > At present there is a data_ready() callback for the SD data read > path. Let's add a receive_ready() for the SD data write path. > > Signed-off-by: Bin Meng Acked-by: Alistair Francis Alistair > --- > >

[PATCH v2 0/6] tcg: Restrict tcg_out_op() to arrays of TCG_MAX_OP_ARGS elements

2021-01-13 Thread Philippe Mathieu-Daudé
Since v1: - Redo the whole change, only hoisting when variable is used 10+ times - Remove goto statement/label - Take care of the following pattern: case INDEX_op_bswap64_i64: a2 =3D TCG_REG_R0; if (a0 =3D=3D a1) { a0 =3D TCG_REG_R0; a2 =3D a1;

[PATCH v2 0/8] iotests: Fix 129 and expand 297’s reach

2021-01-13 Thread Max Reitz
v1 cover letter: https://lists.nongnu.org/archive/html/qemu-block/2021-01/msg00254.html Hi, See the cover letter above for the main point of this series (it’s just that all patch indices are shifted up by one in v2). In addition to that, I’ve added patch 1 that makes some changes to 297 so it

[PATCH v2 4/8] iotests/129: Do not check @busy

2021-01-13 Thread Max Reitz
@busy is false when the job is paused, which happens all the time because that is how jobs yield (e.g. for mirror at least since commit 565ac01f8d3). Back when 129 was added (2015), perhaps there was no better way of checking whether the job was still actually running. Now we have the @status

[PATCH v2 8/8] iotests/129: Clean up pylint and mypy complaints

2021-01-13 Thread Max Reitz
Signed-off-by: Max Reitz --- tests/qemu-iotests/129 | 6 -- tests/qemu-iotests/297 | 2 +- tests/qemu-iotests/297.out | 1 + 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/tests/qemu-iotests/129 b/tests/qemu-iotests/129 index 6d21470cd7..64578493c1 100755 ---

Re: [PATCH 14/22] hw/sd: ssi-sd: Support single block write

2021-01-13 Thread Alistair Francis
On Thu, Dec 31, 2020 at 3:43 AM Bin Meng wrote: > > From: Bin Meng > > Add 2 more states for the block write operation. The SPI host needs > to send a data start tocken to start the transfer, and the data block > written to the card will be acknowledged by a data response tocken. > >

Re: [PATCH 15/22] hw/sd: ssi-sd: Support multiple block write

2021-01-13 Thread Alistair Francis
On Thu, Dec 31, 2020 at 3:47 AM Bin Meng wrote: > > From: Bin Meng > > For a multiple block write operation, each block begins with a multi > write start token. Unlike the SD mode that the multiple block write > ends when receiving a STOP_TRAN command (CMD12), a special stop tran > tocken is

Re: [PATCH 16/22] hw/ssi: Add SiFive SPI controller support

2021-01-13 Thread Alistair Francis
On Thu, Dec 31, 2020 at 3:36 AM Bin Meng wrote: > > From: Bin Meng > > This adds the SiFive SPI controller model for the FU540 SoC. > The direct memory-mapped SPI flash mode is unsupported. > > Signed-off-by: Bin Meng > --- > > include/hw/ssi/sifive_spi.h | 47 ++ > hw/ssi/sifive_spi.c

Re: [PATCH 20/22] docs/system: Sort targets in alphabetical order

2021-01-13 Thread Alistair Francis
On Thu, Dec 31, 2020 at 3:50 AM Bin Meng wrote: > > From: Bin Meng > > Signed-off-by: Bin Meng Reviewed-by: Alistair Francis Alistair > --- > > docs/system/targets.rst | 19 --- > 1 file changed, 12 insertions(+), 7 deletions(-) > > diff --git a/docs/system/targets.rst

Re: minimal "zero conf" build dockerfiles for fedora:latest and alpine:latest

2021-01-13 Thread John Snow
On 1/13/21 5:09 AM, Gerd Hoffmann wrote: Hi, I don't like Perl really, but there's a chicken-and-egg problem between detecting Python and using it to print the configure help script. For configure-time tasks, Perl has the advantage that "#! /usr/bin/env perl" just works. Assuming perl is

Re: [qemu-web PATCH] Use GitLab repo URLs instead of git.qemu.org URLs

2021-01-13 Thread Alex Bennée
Stefan Hajnoczi writes: > Switch to GitLab repo URLs to reduce qemu.org bandwidth. > > Note that there is still one git.qemu.org remaining in > _posts/2018-06-28-tcg-testing.md. The git object doesn't exist in GitLab > and it's hard to use master since the link was to a Makefile that has >

Re: [PATCH v1 9/9] gitlab: move docs and tools build across from Travis

2021-01-13 Thread Alex Bennée
Daniel P. Berrangé writes: > On Wed, Jan 13, 2021 at 03:14:08PM +, Alex Bennée wrote: >> While we are at it we might as well check the tag generation. For >> bonus points we run GNU globals htags into the public pages directory >> for publishing with the auto generated pages. >> >>

Re: [PATCH v1 9/9] gitlab: move docs and tools build across from Travis

2021-01-13 Thread Daniel P . Berrangé
On Wed, Jan 13, 2021 at 04:27:54PM +, Alex Bennée wrote: > > Daniel P. Berrangé writes: > > > On Wed, Jan 13, 2021 at 03:14:08PM +, Alex Bennée wrote: > >> While we are at it we might as well check the tag generation. For > >> bonus points we run GNU globals htags into the public pages

[PATCH v17 02/20] multi-process: add configure and usage information

2021-01-13 Thread Jagannathan Raman
From: Elena Ufimtseva Adds documentation explaining the command-line arguments needed to use multi-process. Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John G Johnson Reviewed-by: Stefan Hajnoczi --- docs/multi-process.rst | 64

[PATCH v17 13/20] multi-process: introduce proxy object

2021-01-13 Thread Jagannathan Raman
From: Elena Ufimtseva Defines a PCI Device proxy object as a child of TYPE_PCI_DEVICE. Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John G Johnson Reviewed-by: Stefan Hajnoczi --- include/hw/remote/proxy.h | 33 hw/remote/proxy.c |

Re: [PATCH 07/22] hw/sd: ssi-sd: Suffix a data block with CRC16

2021-01-13 Thread Alistair Francis
On Thu, Dec 31, 2020 at 3:38 AM Bin Meng wrote: > > From: Bin Meng > > Per the SD spec, a valid data block is suffixed with a 16-bit CRC > generated by the standard CCITT polynomial x16+x12+x5+1. This part > is currently missing in the ssi-sd state machine. Without it, all > data block transfer

Re: [PATCH 4/7] iotests/129: Use throttle node

2021-01-13 Thread Max Reitz
On 13.01.21 17:46, Vladimir Sementsov-Ogievskiy wrote: 13.01.2021 17:06, Max Reitz wrote: Throttling on the BB has not affected block jobs in a while, so it is possible that one of the jobs in 129 finishes before the VM is stopped. We can fix that by running the job from a throttle node.

[PATCH v17 15/20] multi-process: Forward PCI config space acceses to the remote process

2021-01-13 Thread Jagannathan Raman
From: Elena Ufimtseva The Proxy Object sends the PCI config space accesses as messages to the remote process over the communication channel Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John G Johnson Reviewed-by: Stefan Hajnoczi ---

Re: [PATCH 4/7] iotests/129: Use throttle node

2021-01-13 Thread Vladimir Sementsov-Ogievskiy
13.01.2021 20:02, Max Reitz wrote: On 13.01.21 17:46, Vladimir Sementsov-Ogievskiy wrote: 13.01.2021 17:06, Max Reitz wrote: Throttling on the BB has not affected block jobs in a while, so it is possible that one of the jobs in 129 finishes before the VM is stopped. We can fix that by running

[PATCH v5] block: report errno when flock fcntl fails

2021-01-13 Thread David Edmondson
When a call to fcntl(2) for the purpose of adding file locks fails with an error other than EAGAIN or EACCES, report the error returned by fcntl. EAGAIN or EACCES are elided as they are considered to be common failures, indicating that a conflicting lock is held by another process. No errors are

Re: [PATCH 11/22] hw/sd: sd: Allow single/multiple block write for SPI mode

2021-01-13 Thread Alistair Francis
On Thu, Dec 31, 2020 at 3:42 AM Bin Meng wrote: > > From: Bin Meng > > At present the single/multiple block write in SPI mode is blocked > by sd_normal_command(). Remove the limitation. > > Signed-off-by: Bin Meng Acked-by: Alistair Francis Alistair > --- > > hw/sd/sd.c | 3 --- > 1 file

Re: [PATCH] spapr: Improve handling of memory unplug with old guests

2021-01-13 Thread Greg Kurz
On Wed, 13 Jan 2021 12:20:58 +1100 David Gibson wrote: > On Fri, Jan 08, 2021 at 06:31:27PM +0100, Greg Kurz wrote: > > Since commit 1e8b5b1aa16b ("spapr: Allow memory unplug to always succeed") > > trying to unplug memory from a guest that doesn't support it (eg. rhel6) > > no longer generates

[PATCH v2 6/6] tcg: Restrict tcg_out_vec_op() to arrays of TCG_MAX_OP_ARGS elements

2021-01-13 Thread Philippe Mathieu-Daudé
tcg_reg_alloc_op() allocates arrays of TCG_MAX_OP_ARGS elements. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- tcg/tcg.c| 14 -- tcg/aarch64/tcg-target.c.inc | 3 ++- tcg/i386/tcg-target.c.inc| 3 ++- tcg/ppc/tcg-target.c.inc

Re: [PATCH 17/19] target/arm: add ARMv8.4-SEL2 extension

2021-01-13 Thread Richard Henderson
On 1/13/21 3:12 AM, Rémi Denis-Courmont wrote: >> if (arm_dc_feature(s, ARM_FEATURE_AARCH64) && >> dc_isar_feature(aa64_sel2, s)) { >> ... >> > > Hmm, yeah. Should this be an ifdef on TARGET_AARCH64 instead? No, I don't think so. It's not performance critical that we avoid a

Re: [PATCH 18/22] hw/riscv: sifive_u: Add QSPI2 controller and connect an SD card

2021-01-13 Thread Alistair Francis
On Thu, Dec 31, 2020 at 3:45 AM Bin Meng wrote: > > From: Bin Meng > > This adds the QSPI2 controller to the SoC, and connnects an SD > card to it. The generation of corresponding device tree source > fragment is also added. > > Specify machine property `msel` to 11 to boot the same upstream >

Re: [PATCH 19/22] hw/riscv: sifive_u: Change SIFIVE_U_GEM_IRQ to decimal value

2021-01-13 Thread Alistair Francis
On Thu, Dec 31, 2020 at 3:38 AM Bin Meng wrote: > > From: Bin Meng > > All other peripherals' IRQs are in the format of decimal value. > Change SIFIVE_U_GEM_IRQ to be consistent. > > Signed-off-by: Bin Meng Reviewed-by: Alistair Francis Alistair > --- > > include/hw/riscv/sifive_u.h | 2 +-

Re: [PATCH 0/5] tcg: Restrict tcg_out_op() to arrays of TCG_MAX_OP_ARGS elements

2021-01-13 Thread Richard Henderson
On 1/13/21 5:07 AM, Philippe Mathieu-Daudé wrote: > On 1/11/21 6:22 PM, Richard Henderson wrote: >> On 1/11/21 5:01 AM, Philippe Mathieu-Daudé wrote: >>> Attempt to fix the warning reported by Miroslav using GCC 10: >>> https://www.mail-archive.com/qemu-devel@nongnu.org/msg771520.html >>> >>>

Re: [RFC PATCH v0 1/1] target/ppc: Support for H_RPT_INVALIDATE hcall

2021-01-13 Thread Greg Kurz
Hi Bharata, On Wed, 6 Jan 2021 14:29:10 +0530 Bharata B Rao wrote: > If KVM_CAP_RPT_INVALIDATE KVM capability is enabled, then > > - indicate the availability of H_RPT_INVALIDATE hcall to the guest via > ibm,hypertas-functions property. > - Enable the hcall > > Both the above are done only

[PATCH v17 03/20] memory: alloc RAM from file at offset

2021-01-13 Thread Jagannathan Raman
Allow RAM MemoryRegion to be created from an offset in a file, instead of allocating at offset of 0 by default. This is needed to synchronize RAM between QEMU & remote process. Signed-off-by: Jagannathan Raman Signed-off-by: John G Johnson Signed-off-by: Elena Ufimtseva Reviewed-by: Stefan

[PATCH v17 00/20] Initial support for multi-process Qemu

2021-01-13 Thread Jagannathan Raman
Hi, This is the v17 of the patchset. Thank you for your time reviewing v16. This version has the following changes: [PATCH v17 08/20] io: add qio_channel_readv_full_all_eof & qio_channel_readv_full_all helpers - Addresses operator precedence issues based on feedback -

[PATCH v17 08/20] io: add qio_channel_readv_full_all_eof & qio_channel_readv_full_all helpers

2021-01-13 Thread Jagannathan Raman
From: Elena Ufimtseva Adds qio_channel_readv_full_all_eof() and qio_channel_readv_full_all() to read both data and FDs. Refactors existing code to use these helpers. Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- include/io/channel.h | 51

Re: [PATCH v16 00/20] Initial support for multi-process Qemu

2021-01-13 Thread Jag Raman
> On Jan 11, 2021, at 3:13 PM, 罗勇刚(Yonggang Luo) wrote: > > > > On Tue, Jan 12, 2021 at 2:02 AM Jag Raman wrote: > > > > > > > > > On Jan 11, 2021, at 12:20 AM, 罗勇刚(Yonggang Luo) > > > wrote: > > > > > > I have a question, does this support/test on Windows? > > > > Hi Yonggang, we have

Re: [PATCH 4/7] iotests/129: Use throttle node

2021-01-13 Thread Vladimir Sementsov-Ogievskiy
13.01.2021 17:06, Max Reitz wrote: Throttling on the BB has not affected block jobs in a while, so it is possible that one of the jobs in 129 finishes before the VM is stopped. We can fix that by running the job from a throttle node. Signed-off-by: Max Reitz --- tests/qemu-iotests/129 | 39

Re: [PATCH 10/22] hw/sd: sd: Remove duplicated codes in single/multiple block read/write

2021-01-13 Thread Alistair Francis
On Thu, Dec 31, 2020 at 3:42 AM Bin Meng wrote: > > From: Bin Meng > > The single block read (CMD17) codes are the same as the multiple > block read (CMD18). Merge them into one. The same applies to single > block write (CMD24) and multiple block write (CMD25). > > Signed-off-by: Bin Meng

[PATCH v2 4/6] tcg/s390: Hoist common argument loads in tcg_out_op()

2021-01-13 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tcg/s390/tcg-target.c.inc | 222 ++ 1 file changed, 107 insertions(+), 115 deletions(-) diff --git a/tcg/s390/tcg-target.c.inc b/tcg/s390/tcg-target.c.inc index d7ef0790556..ec202e79cfc 100644 ---

[PATCH v2 3/6] tcg/ppc: Hoist common argument loads in tcg_out_op()

2021-01-13 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tcg/ppc/tcg-target.c.inc | 188 ++- 1 file changed, 85 insertions(+), 103 deletions(-) diff --git a/tcg/ppc/tcg-target.c.inc b/tcg/ppc/tcg-target.c.inc index 19a4a12f155..70b747a8a30 100644 ---

Re: [RFC PATCH v6 00/11] hw/ssi: imx_spi: Fix various bugs in the imx_spi model

2021-01-13 Thread Philippe Mathieu-Daudé
On 1/13/21 2:27 PM, Bin Meng wrote: > Hi Philippe, > > On Wed, Jan 13, 2021 at 3:53 PM Philippe Mathieu-Daudé > wrote: >> >> Hi Ben, >> >> On 1/13/21 4:29 AM, Bin Meng wrote: >>> On Wed, Jan 13, 2021 at 2:35 AM Philippe Mathieu-Daudé >>> wrote: Hi, As it is sometimes

[PATCH v2 3/8] iotests/129: Remove test images in tearDown()

2021-01-13 Thread Max Reitz
Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- tests/qemu-iotests/129 | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/qemu-iotests/129 b/tests/qemu-iotests/129 index 0e13244d85..2fc65ada6a 100755 --- a/tests/qemu-iotests/129 +++

[PATCH v2 1/8] iotests/297: Allow checking all Python test files

2021-01-13 Thread Max Reitz
I.e., all Python files in the qemu-iotests/ directory. Most files of course do not pass, so there is an extensive skip list for now. (The only files that do pass are 209, 254, 283, and iotests.py.) (Alternatively, we could have the opposite, i.e. an explicit list of files that we do want to

Re: [PATCH 12/22] hw/sd: sd.h: Cosmetic change of using spaces

2021-01-13 Thread Alistair Francis
On Thu, Dec 31, 2020 at 3:46 AM Bin Meng wrote: > > From: Bin Meng > > QEMU conding convention prefers spaces over tabs. > > Signed-off-by: Bin Meng Reviewed-by: Alistair Francis Alistair > --- > > include/hw/sd/sd.h | 42 +- > 1 file changed, 21

[PATCH v2 7/8] iotests/129: Limit mirror job's buffer size

2021-01-13 Thread Max Reitz
Issuing 'stop' on the VM drains all nodes. If the mirror job has many large requests in flight, this may lead to significant I/O that looks a bit like 'stop' would make the job try to complete (which is what 129 should verify not to happen). We can limit the I/O in flight by limiting the buffer

[PATCH v2 5/8] iotests/129: Use throttle node

2021-01-13 Thread Max Reitz
Throttling on the BB has not affected block jobs in a while, so it is possible that one of the jobs in 129 finishes before the VM is stopped. We can fix that by running the job from a throttle node. Signed-off-by: Max Reitz --- tests/qemu-iotests/129 | 37 +

[qemu-web PATCH v2] Use GitLab repo URLs instead of git.qemu.org URLs

2021-01-13 Thread Stefan Hajnoczi
Switch to GitLab repo URLs to reduce qemu.org bandwidth. Signed-off-by: Stefan Hajnoczi --- v2: * Added missing URL in _posts/2018-06-28-tcg-testing.md. Mark Cave-Ayland and Alex Bennée figured out the issue was that the gitweb link referenced a blob object (not a commit) whereas

qmp-shell TUI (was: Re: Call for Google Summer of Code 2021 project ideas)

2021-01-13 Thread John Snow
On 1/13/21 3:53 AM, Stefan Hajnoczi wrote: On Tue, Jan 12, 2021 at 9:10 PM John Snow wrote: I have one that is probably way too ambitious, but requires a particular skillset that might be of good interest to a student that has some experience in the area already. The idea is for a TUI

Re: [PATCH v2 5/8] iotests/129: Use throttle node

2021-01-13 Thread Eric Blake
On 1/13/21 11:57 AM, Max Reitz wrote: > Throttling on the BB has not affected block jobs in a while, so it is > possible that one of the jobs in 129 finishes before the VM is stopped. > We can fix that by running the job from a throttle node. > > Signed-off-by: Max Reitz > --- >

Re: [PATCH v2 1/8] iotests/297: Allow checking all Python test files

2021-01-13 Thread Vladimir Sementsov-Ogievskiy
13.01.2021 20:57, Max Reitz wrote: I.e., all Python files in the qemu-iotests/ directory. Most files of course do not pass, so there is an extensive skip list for now. (The only files that do pass are 209, 254, 283, and iotests.py.) (Alternatively, we could have the opposite, i.e. an explicit

Re: [PATCH v2 1/8] iotests/297: Allow checking all Python test files

2021-01-13 Thread Vladimir Sementsov-Ogievskiy
13.01.2021 22:27, Vladimir Sementsov-Ogievskiy wrote: 13.01.2021 20:57, Max Reitz wrote: I.e., all Python files in the qemu-iotests/ directory. Most files of course do not pass, so there is an extensive skip list for now.  (The only files that do pass are 209, 254, 283, and iotests.py.)

[PATCH v18 03/20] memory: alloc RAM from file at offset

2021-01-13 Thread Jagannathan Raman
Allow RAM MemoryRegion to be created from an offset in a file, instead of allocating at offset of 0 by default. This is needed to synchronize RAM between QEMU & remote process. Signed-off-by: Jagannathan Raman Signed-off-by: John G Johnson Signed-off-by: Elena Ufimtseva Reviewed-by: Stefan

  1   2   3   4   5   >