Re: [PATCH] target/mips: fetch code with translator_ld

2021-01-22 Thread Philippe Mathieu-Daudé
On 1/18/21 6:40 PM, Richard Henderson wrote: > On 1/16/21 8:13 AM, Philippe Mathieu-Daudé wrote: >> +++ b/target/mips/tlb_helper.c >> @@ -21,7 +21,7 @@ >> #include "cpu.h" >> #include "internal.h" >> #include "exec/exec-all.h" >> -#include "exec/cpu_ldst.h" >> +#include "exec/translator.h" >>

RE: [PATCH v7 15/35] Hexagon (target/hexagon/arch.[ch]) utility functions

2021-01-22 Thread Taylor Simpson
> -Original Message- > From: Philippe Mathieu-Daudé On > Behalf Of Philippe Mathieu-Daudé > Sent: Friday, January 22, 2021 12:09 PM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: richard.hender...@linaro.org; alex.ben...@linaro.org; > laur...@vivier.eu; a...@rev.ng; Brian Cain >

Re: [PATCH v7 04/11] slirp: feature detection for smbd

2021-01-22 Thread Peter Maydell
On Fri, 22 Jan 2021 at 20:16, Joelle van Dyne wrote: > > Replace Windows specific macro with a more generic feature detection > macro. Allows slirp smb feature to be disabled manually as well. > > Signed-off-by: Joelle van Dyne > --- > +if test "$slirp_smbd" = "yes" ; then > + echo

Re: [PATCH v7 05/11] osdep: build with non-working system() function

2021-01-22 Thread Peter Maydell
On Fri, 22 Jan 2021 at 20:13, Joelle van Dyne wrote: > > Build without error on hosts without a working system(). An assertion > will trigger if system() is called. > > Signed-off-by: Joelle van Dyne configure| 19 +++ Can we do the "does system() exist?" check in

Re: [PATCH 1/1] os_find_datadir: search as in version 4.2

2021-01-22 Thread Brian Norris
Just to follow-up here, since nobody followed up for months... On Mon, Aug 10, 2020 at 2:41 PM Brian Norris wrote: > On Mon, Aug 10, 2020 at 12:29 AM Marc-André Lureau > wrote: > > On Sat, Aug 8, 2020 at 7:34 PM Peter Maydell > > wrote: > > > On Sat, 8 Aug 2020 at 02:35, Brian Norris > > >

[PATCH v8 11/11] darwin: remove 64-bit build detection on 32-bit OS

2021-01-22 Thread Joelle van Dyne
A workaround added in early days of 64-bit OSX forced x86_64 if the host machine had 64-bit support. This creates issues when cross- compiling for ARM64. Additionally, the user can always use --cpu=* to manually set the host CPU and therefore this workaround should be removed. Reviewed-by: Peter

Re: [PATCH v7 34/35] Hexagon build infrastructure

2021-01-22 Thread Philippe Mathieu-Daudé
On 1/22/21 11:41 PM, Philippe Mathieu-Daudé wrote: > On 1/22/21 11:34 PM, Philippe Mathieu-Daudé wrote: >> On 1/20/21 4:29 AM, Taylor Simpson wrote: >>> Add file to default-configs >>> Add hexagon to meson.build >>> Add hexagon to target/meson.build >>> Add target/hexagon/meson.build >>> Change

[Bug 1912857] Re: virtio-serial blocks hostfwd ssh on windows 10 host

2021-01-22 Thread Ven Karri
** Description changed: - qemu-system-x86_64 -display none -hda archlinux.qcow2 -m 4G -netdev - user,id=n1,hostfwd=tcp::-:22 -device virtio-net-pci,netdev=n1 --> - WORKS - meaning I can ssh into the vm via port + qemu-system-x86_64 + -display none + -hda archlinux.qcow2 + -m 4G

Re: [PATCH v2 1/3] target/arm: Remove PSTATE_SS from cpsr and move it into env->pstate.

2021-01-22 Thread Rebecca Cran
On 1/22/21 2:03 PM, Richard Henderson wrote: On 1/21/21 6:45 PM, Rebecca Cran wrote: cpsr_write(env, spsr, mask, CPSRWriteRaw); -if (!arm_singlestep_active(env)) { -env->uncached_cpsr &= ~PSTATE_SS; -} +env->pstate &= ~PSTATE_SS; Why are you

Re: [PATCH v2 1/1] spapr_caps.c: check user input before warning about TCG only caps

2021-01-22 Thread David Gibson
On Wed, Jan 20, 2021 at 07:54:06AM -0300, Daniel Henrique Barboza wrote: > Commit 006e9d361869 added warning messages for cap-cfpc, cap-ibs and > cap-sbbc when enabled under TCG. Commit 8ff43ee404d3 did the same thing > when introducing cap-ccf-assist. > > These warning messages, although benign

Re: [PATCH v7 11/11] darwin: remove 64-bit build detection on 32-bit OS

2021-01-22 Thread Peter Maydell
On Fri, 22 Jan 2021 at 20:16, Joelle van Dyne wrote: > > A workaround added in early days of 64-bit OSX forced x86_64 if the > host machine had 64-bit support. This creates issues when cross- > compiling for ARM64. Additionally, the user can always use --cpu=* to > manually set the host CPU and

[Bug 1912857] Re: virtio-serial blocks hostfwd ssh on windows 10 host

2021-01-22 Thread Ven Karri
** Description changed: qemu-system-x86_64   -display none   -hda archlinux.qcow2   -m 4G   -netdev user,id=n1,hostfwd=tcp::-:22   -device virtio-net-pci,netdev=n1 --> THIS WORKS - meaning I can ssh into the vm via port qemu-system-x86_64   -display none   -hda

Re: [PATCH] coroutine-sigaltstack: Keep SIGUSR2 handler up

2021-01-22 Thread Laszlo Ersek
On 01/22/21 22:26, Laszlo Ersek wrote: > I'm drifting towards an overhaul of coroutine-sigaltstack, based on my > personal understanding of POSIX, but given that I can absolutely not > *test* coroutine-sigaltstack on the platforms where it actually matters, > an "overhaul" by me would be

[Bug 1800156] Re: windows 8.1 loose grab/leave window on windowed

2021-01-22 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1800156 Title: windows

Re: [PATCH v7 06/11] darwin: remove redundant dependency declaration

2021-01-22 Thread Peter Maydell
On Fri, 22 Jan 2021 at 20:20, Joelle van Dyne wrote: > > Meson will find CoreFoundation, IOKit, and Cocoa as needed. > > Signed-off-by: Joelle van Dyne > --- > configure | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/configure b/configure > index 82ce28c660..4c485dd962 100755 > ---

Re: Thread safety of coroutine-sigaltstack

2021-01-22 Thread Laszlo Ersek
On 01/22/21 11:14, Peter Maydell wrote: > On Fri, 22 Jan 2021 at 08:50, Max Reitz wrote: >> >> On 20.01.21 18:25, Laszlo Ersek wrote: >> >> [...] >> >>> A simple grep for SIGUSR2 seems to indicate that SIGUSR2 is not used by >>> system emulation for anything else, in practice. Is it possible to

Re: [PATCH v7 34/35] Hexagon build infrastructure

2021-01-22 Thread Philippe Mathieu-Daudé
On 1/20/21 4:29 AM, Taylor Simpson wrote: > Add file to default-configs > Add hexagon to meson.build > Add hexagon to target/meson.build > Add target/hexagon/meson.build > Change scripts/qemu-binfmt-conf.sh > > We can build a hexagon-linux-user target and run programs on the Hexagon > scalar

Re: [PATCH v7 34/35] Hexagon build infrastructure

2021-01-22 Thread Philippe Mathieu-Daudé
On 1/22/21 11:34 PM, Philippe Mathieu-Daudé wrote: > On 1/20/21 4:29 AM, Taylor Simpson wrote: >> Add file to default-configs >> Add hexagon to meson.build >> Add hexagon to target/meson.build >> Add target/hexagon/meson.build >> Change scripts/qemu-binfmt-conf.sh >> >> We can build a

[Bug 1912857] Re: virtio-serial blocks hostfwd ssh on windows 10 host

2021-01-22 Thread Ven Karri
** Description changed: qemu-system-x86_64 -display none -hda archlinux.qcow2 -m 4G -netdev user,id=n1,hostfwd=tcp::-:22 -device virtio-net-pci,netdev=n1 --> WORKS - meaning I can ssh into the vm via port qemu-system-x86_64 -display none -hda archlinux.qcow2 -m 4G -netdev

Re: [PATCHv9 0/3] arm-virt: add secure pl061 for reset/power down

2021-01-22 Thread Peter Maydell
On Fri, 22 Jan 2021 at 21:52, Maxim Uvarov wrote: > > v9: - cosmetic changes (move if from patch2 to patch3, rename function name >and define). > v8: - use gpio 0 and 1, align dtb with kernel gpio-restart, gpio-poweroff, >change define names, trigger on upper front. (Peter

Re: [PATCH v2 3/3] target/arm: Set ID_AA64PFR0.DIT and ID_PFR0.DIT to 1 for "max" AA64 CPU

2021-01-22 Thread Rebecca Cran
On 1/22/21 2:06 PM, Richard Henderson wrote: On 1/21/21 6:45 PM, Rebecca Cran wrote: Enable FEAT_DIT for the "max" AARCH64 CPU. Signed-off-by: Rebecca Cran Reviewed-by: Richard Henderson --- target/arm/cpu64.c | 5 + 1 file changed, 5 insertions(+) There is also a 32-bit "max" cpu

Re: [PATCH 8/8] configure: automatically parse command line for meson -D options

2021-01-22 Thread Yonggang Luo
On Sat, Jan 23, 2021 at 4:44 AM Paolo Bonzini wrote: > > > > Il ven 22 gen 2021, 09:00 罗勇刚(Yonggang Luo) ha scritto: >> >> Hi Paolo, as python and meson are required dependencies to building qemu now, >> can we detecting python/meson at the very begining of configure, >> even before the --help

[PATCH v8 04/11] slirp: feature detection for smbd

2021-01-22 Thread Joelle van Dyne
Replace Windows specific macro with a more generic feature detection macro. Allows slirp smb feature to be disabled manually as well. Signed-off-by: Joelle van Dyne --- configure | 22 +- meson.build | 2 +- net/slirp.c | 16 3 files changed, 30

[PATCH v8 02/11] configure: cross-compiling with empty cross_prefix

2021-01-22 Thread Joelle van Dyne
The iOS toolchain does not use the host prefix naming convention. So we need to enable cross-compile options while allowing the PREFIX to be blank. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Joelle van Dyne --- configure | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

[PATCH v8 01/11] block: feature detection for host block support

2021-01-22 Thread Joelle van Dyne
On Darwin (iOS), there are no system level APIs for directly accessing host block devices. We detect this at configure time. Signed-off-by: Joelle van Dyne --- meson.build | 6 +- qapi/block-core.json | 10 +++--- block/file-posix.c | 33 ++--- 3

[PATCH v8 00/11] iOS and Apple Silicon host support

2021-01-22 Thread Joelle van Dyne
These set of changes brings QEMU TCG to iOS devices and future Apple Silicon devices. They were originally developed last year and have been working in the UTM app. Recently, we ported the changes to master, re-wrote a lot of the build script changes for meson, and broke up the patches into more

RE: [PATCH v7 12/35] Hexagon (target/hexagon) instruction attributes

2021-01-22 Thread Taylor Simpson
> -Original Message- > From: Philippe Mathieu-Daudé On > Behalf Of Philippe Mathieu-Daudé > Sent: Friday, January 22, 2021 11:54 AM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: richard.hender...@linaro.org; alex.ben...@linaro.org; > laur...@vivier.eu; a...@rev.ng; Brian Cain >

[Bug 1745895] Re: Unable to migrate vhost-net to virtio-1.0-capable kernel

2021-01-22 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1745895 Title: Unable to

[PATCH v8 10/11] darwin: detect CoreAudio for build

2021-01-22 Thread Joelle van Dyne
On iOS there is no CoreAudio, so we should not assume Darwin always has it. Signed-off-by: Joelle van Dyne --- configure | 35 +-- 1 file changed, 33 insertions(+), 2 deletions(-) diff --git a/configure b/configure index b8ae4609fd..70061e195d 100755 ---

Re: [PATCH v7 07/11] darwin: fix cross-compiling for Darwin

2021-01-22 Thread Peter Maydell
On Fri, 22 Jan 2021 at 20:18, Joelle van Dyne wrote: > > Add objc to the Meson cross file as well as detection of Darwin. > > Signed-off-by: Joelle van Dyne Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v7 04/11] slirp: feature detection for smbd

2021-01-22 Thread Joelle van Dyne
On Fri, Jan 22, 2021 at 2:49 PM Peter Maydell wrote: > > On Fri, 22 Jan 2021 at 20:16, Joelle van Dyne wrote: > > > > Replace Windows specific macro with a more generic feature detection > > macro. Allows slirp smb feature to be disabled manually as well. > > > > Signed-off-by: Joelle van Dyne

[PATCH] hvf: Fetch cr4 before evaluating CPUID(1)

2021-01-22 Thread Alexander Graf
The CPUID function 1 has a bit called OSXSAVE which tells user space the status of the CR4.OSXSAVE bit. Our generic CPUID function injects that bit based on the status of CR4. With Hypervisor.framework, we do not synchronize full CPU state often enough for this function to see the CR4 update

Re: [PATCH V5 4/6] hw/block/nvme: support for multi-controller in subsystem

2021-01-22 Thread Minwoo Im
On 21-01-22 10:42:36, Keith Busch wrote: > On Fri, Jan 22, 2021 at 09:07:34PM +0900, Minwoo Im wrote: > > index b525fca14103..3dedefb8ebba 100644 > > --- a/hw/block/nvme.c > > +++ b/hw/block/nvme.c > > @@ -4435,6 +4435,9 @@ static void nvme_init_ctrl(NvmeCtrl *n, PCIDevice > > *pci_dev) > >

[PATCH v8 09/11] block: check availablity for preadv/pwritev on mac

2021-01-22 Thread Joelle van Dyne
macOS 11/iOS 14 added preadv/pwritev APIs. Due to weak linking, configure will succeed with CONFIG_PREADV even when targeting a lower OS version. We therefore need to check at run time if we can actually use these APIs. Signed-off-by: Joelle van Dyne --- block/file-posix.c | 33

[PATCH v8 08/11] configure: cross compile should use x86_64 cpu_family

2021-01-22 Thread Joelle van Dyne
Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Joelle van Dyne --- configure | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/configure b/configure index d4588ed892..b8ae4609fd 100755 --- a/configure +++ b/configure @@ -6445,9 +6445,12 @@ if test "$cross_compile" =

Re: [PATCH v7 03/11] configure: check for sys/disk.h

2021-01-22 Thread Peter Maydell
On Fri, 22 Jan 2021 at 20:13, Joelle van Dyne wrote: > > Some BSD platforms do not have this header. > > Signed-off-by: Joelle van Dyne > --- > configure | 9 + > block.c| 2 +- > block/file-posix.c | 2 +- > 3 files changed, 11 insertions(+), 2 deletions(-) > >

[Bug 1912857] Re: virtio-serial blocks hostfwd ssh on windows 10 host

2021-01-22 Thread Ven Karri
** Description changed: qemu-system-x86_64 -display none -hda archlinux.qcow2 -m 4G -netdev user,id=n1,hostfwd=tcp::-:22 -device virtio-net-pci,netdev=n1 --> WORKS - meaning I can ssh into the vm via port qemu-system-x86_64 -display none -hda archlinux.qcow2 -m 4G -netdev

Re: [PATCH v7 05/11] osdep: build with non-working system() function

2021-01-22 Thread Peter Maydell
On Fri, 22 Jan 2021 at 23:12, Peter Maydell wrote: > > On Fri, 22 Jan 2021 at 20:13, Joelle van Dyne wrote: > > > > Build without error on hosts without a working system(). An assertion > > will trigger if system() is called. > > > > Signed-off-by: Joelle van Dyne > > configure| 19

Re: [PATCH] spapr: Adjust firmware path of PCI devices

2021-01-22 Thread Alexey Kardashevskiy
On 23/01/2021 04:01, Greg Kurz wrote: It is currently not possible to perform a strict boot from USB storage: $ qemu-system-ppc64 -accel kvm -nodefaults -nographic -serial stdio \ -boot strict=on \ -device qemu-xhci \ -device usb-storage,drive=disk,bootindex=0 \

Re: [PATCH v7 05/11] osdep: build with non-working system() function

2021-01-22 Thread Joelle van Dyne
Unfortunately, this doesn't work for iOS, which defines system() but throws a compile time error if you try to call it. -j On Fri, Jan 22, 2021 at 3:17 PM Peter Maydell wrote: > > On Fri, 22 Jan 2021 at 23:12, Peter Maydell wrote: > > > > On Fri, 22 Jan 2021 at 20:13, Joelle van Dyne wrote: >

[PATCH v8 06/11] darwin: remove redundant dependency declaration

2021-01-22 Thread Joelle van Dyne
Meson will find CoreFoundation, IOKit, and Cocoa as needed. Reviewed-by: Peter Maydell Signed-off-by: Joelle van Dyne --- configure | 1 - 1 file changed, 1 deletion(-) diff --git a/configure b/configure index de7487a0c7..0fd3f14c5e 100755 --- a/configure +++ b/configure @@ -781,7 +781,6 @@

[PATCH v8 05/11] osdep: build with non-working system() function

2021-01-22 Thread Joelle van Dyne
Build without error on hosts without a working system(). If system() is called, return -1 with ENOSYS. Signed-off-by: Joelle van Dyne --- configure| 20 include/qemu/osdep.h | 12 2 files changed, 32 insertions(+) diff --git a/configure b/configure

[PATCH v8 03/11] configure: check for sys/disk.h

2021-01-22 Thread Joelle van Dyne
Some BSD platforms do not have this header. Signed-off-by: Joelle van Dyne --- meson.build| 1 + block.c| 2 +- block/file-posix.c | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 27110075df..6818d97df5 100644 ---

[PATCH v8 07/11] darwin: fix cross-compiling for Darwin

2021-01-22 Thread Joelle van Dyne
Add objc to the Meson cross file as well as detection of Darwin. Reviewed-by: Peter Maydell Signed-off-by: Joelle van Dyne --- configure | 4 1 file changed, 4 insertions(+) diff --git a/configure b/configure index 0fd3f14c5e..d4588ed892 100755 --- a/configure +++ b/configure @@ -6422,6

Re: [PATCH] linux-user/mmap: Avoid asserts for out of range mremap calls

2021-01-22 Thread Richard Purdie
On Fri, 2021-01-08 at 17:42 +, Richard Purdie wrote: > If mremap() is called without the MREMAP_MAYMOVE flag with a start address > just before the end of memory (reserved_va) where new_size would exceed > it (and GUEST_ADDR_MAX), the assert(end - 1 <= GUEST_ADDR_MAX) in  > page_set_flags()

Re: [RFC PATCH] linux-user/mmap: Return EFAULT for invalid addresses

2021-01-22 Thread Richard Purdie
On Fri, 2021-01-08 at 17:46 +, Richard Purdie wrote: > When using qemu-i386 to run gobject introspection parts of a webkitgtk  > build using musl as libc on a 64 bit host, it sits in an infinite loop  > of mremap calls of ever decreasing/increasing addresses. > > I suspect something in the

Re: [PATCH 8/8] configure: automatically parse command line for meson -D options

2021-01-22 Thread Yonggang Luo
Hi Paolo, as python and meson are required dependencies to building qemu now, can we detecting python/meson at the very begining of configure, even before the --help parameter. On Wed, Jan 13, 2021 at 6:08 AM Paolo Bonzini wrote: > > On 13/01/21 11:31, Daniel P. Berrangé wrote: > >>

Re: [RFC PATCH 2/2] gitlab-ci: Add a job building TCI with Clang

2021-01-22 Thread Thomas Huth
On 21/01/2021 21.46, Wainer dos Santos Moschetta wrote: On 1/21/21 3:28 PM, Thomas Huth wrote: On 21/01/2021 19.13, Daniel P. Berrangé wrote: On Thu, Jan 21, 2021 at 03:05:43PM -0300, Wainer dos Santos Moschetta wrote: Hi, On 1/21/21 7:08 AM, Thomas Huth wrote: On 10/01/2021 17.27,

[PATCH 0/2] meson: Try to clarify TCG / TCI options for new users

2021-01-22 Thread Philippe Mathieu-Daudé
Some new users get confused between 'TCG' and 'TCI' and enable TCI when TCG is better for they needs. Try to clarify it is better to not use TCI when native backend is available. Note, before Meson, warnings were summarized at the end of ./configure. Now they are displayed earlier, and likely

[PATCH 2/2] meson: Warn when TCI is selected but TCG backend is available

2021-01-22 Thread Philippe Mathieu-Daudé
Some new users get confused with 'TCG' and 'TCI', and enable TCI support expecting to enable TCG. Emit a warning when native TCG backend is available on the host architecture, mentioning this is a suboptimal configuration. Signed-off-by: Philippe Mathieu-Daudé --- meson.build | 3 +++ 1 file

Re: [PATCHv8 3/3] arm-virt: add secure pl061 for reset/power down

2021-01-22 Thread Andrew Jones
On Wed, Jan 20, 2021 at 12:27:48PM +0300, Maxim Uvarov wrote: > Add secure pl061 for reset/power down machine from > the secure world (Arm Trusted Firmware). Connect it > with gpio-pwr driver. > > Signed-off-by: Maxim Uvarov > --- > hw/arm/Kconfig| 1 + > hw/arm/virt.c | 47

Re: [PULL 10/11] vnc: move initialization to framebuffer_update_request

2021-01-22 Thread Gerd Hoffmann
> This patch breaks QEMU for me. > The symptom is the following: in virt-manager, the display remains dead > (black), when I start an OVMF guest. At the same time, unusually high > CPU load can be seen on the host; it makes me think that virt-manager is > trying, in a busy loop, to complete the

[PATCH] vnc: drop vnc_colordepth() call.

2021-01-22 Thread Gerd Hoffmann
With gtk-vnc (which supports VNC_FEATURE_WMVI) this results in sending a VNC_ENCODING_WMVi message to the client. Which in turn seems to make gtk-vnc respond with another non-incremental update request. Hello endless loop ... Drop the call. Fixes: 9e1632ad07ca ("vnc: move initialization to

Re: [PATCH 1/2] meson: Explicit TCG backend used

2021-01-22 Thread Thomas Huth
On 22/01/2021 10.22, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- meson.build | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 8535a83fb70..0a645e54662 100644 --- a/meson.build +++ b/meson.build @@ -2419,8

Re: [PATCH 2/2] meson: Warn when TCI is selected but TCG backend is available

2021-01-22 Thread Thomas Huth
On 22/01/2021 10.22, Philippe Mathieu-Daudé wrote: Some new users get confused with 'TCG' and 'TCI', and enable TCI support expecting to enable TCG. Emit a warning when native TCG backend is available on the host architecture, mentioning this is a suboptimal configuration. Signed-off-by:

Re: [PATCHv8 2/3] arm-virt: refactor gpios creation

2021-01-22 Thread Andrew Jones
On Wed, Jan 20, 2021 at 12:27:47PM +0300, Maxim Uvarov wrote: > No functional change. Just refactor code to better > support secure and normal world gpios. > > Signed-off-by: Maxim Uvarov > --- > hw/arm/virt.c | 64 ++- > 1 file changed, 43

Re: [PATCH 04/25] keyval: accept escaped commas in implied option

2021-01-22 Thread Markus Armbruster
Paolo Bonzini writes: [...] > diff --git a/util/keyval.c b/util/keyval.c > index be34928813..eb9b9c55ec 100644 > --- a/util/keyval.c > +++ b/util/keyval.c > @@ -16,8 +16,8 @@ > * key-vals = [ key-val { ',' key-val } [ ',' ] ] > * key-val = key '=' val | help > * key

Re: Thread safety of coroutine-sigaltstack

2021-01-22 Thread Max Reitz
On 20.01.21 18:25, Laszlo Ersek wrote: [...] A simple grep for SIGUSR2 seems to indicate that SIGUSR2 is not used by system emulation for anything else, in practice. Is it possible to dedicate SIGUSR2 explicitly to coroutine-sigaltstack, and set up the action beforehand, from some init

[PATCH 1/2] meson: Explicit TCG backend used

2021-01-22 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- meson.build | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 8535a83fb70..0a645e54662 100644 --- a/meson.build +++ b/meson.build @@ -2419,8 +2419,12 @@ endif summary_info += {'TCG support':

Re: [PATCH 2/2] meson: Warn when TCI is selected but TCG backend is available

2021-01-22 Thread Thomas Huth
On 22/01/2021 10.46, Philippe Mathieu-Daudé wrote: On Fri, Jan 22, 2021 at 10:43 AM Thomas Huth wrote: On 22/01/2021 10.22, Philippe Mathieu-Daudé wrote: Some new users get confused with 'TCG' and 'TCI', and enable TCI support expecting to enable TCG. Emit a warning when native TCG backend

Re: [PATCH 2/2] meson: Warn when TCI is selected but TCG backend is available

2021-01-22 Thread Philippe Mathieu-Daudé
On Fri, Jan 22, 2021 at 10:43 AM Thomas Huth wrote: > On 22/01/2021 10.22, Philippe Mathieu-Daudé wrote: > > Some new users get confused with 'TCG' and 'TCI', and enable TCI > > support expecting to enable TCG. > > > > Emit a warning when native TCG backend is available on the > > host

Re: Thread safety of coroutine-sigaltstack

2021-01-22 Thread Max Reitz
On 22.01.21 11:14, Peter Maydell wrote: On Fri, 22 Jan 2021 at 08:50, Max Reitz wrote: On 20.01.21 18:25, Laszlo Ersek wrote: [...] A simple grep for SIGUSR2 seems to indicate that SIGUSR2 is not used by system emulation for anything else, in practice. Is it possible to dedicate SIGUSR2

Re: [PATCH] util/log: flush TB cache when log level changes

2021-01-22 Thread Philippe Mathieu-Daudé
Hi Pavel, On 1/22/21 11:03 AM, Pavel Dovgalyuk wrote: > Sometimes we need to collect the translation logs starting > from some point of the execution. Some TB listings may > be missed in this case, when blocks were translated before. > This patch clears TB cache to allow re-translation of such >

Re: [PATCH v2 2/8] nbd: allow reconnect on open, with corresponding new options

2021-01-22 Thread Vladimir Sementsov-Ogievskiy
21.01.2021 04:44, Eric Blake wrote: On 11/30/20 7:40 AM, Vladimir Sementsov-Ogievskiy wrote: Note: currently, using new option with long timeout in qmp command blockdev-add is not good idea, as qmp interface is blocking, so, don't add it now, let's add it later after "monitor: Optionally run

Re: [Qemu-devel] [PATCH v2 07/11] chardev: Let IOReadHandler use unsigned type

2021-01-22 Thread Richard Purdie
On Fri, 2018-10-12 at 02:22 +0200, Philippe Mathieu-Daudé wrote: > The number of bytes can not be negative nor zero. > > Fixed 2 format string: > - hw/char/spapr_vty.c > - hw/usb/ccid-card-passthru.c > > Suggested-by: Paolo Bonzini > Signed-off-by: Philippe Mathieu-Daudé > Acked-by: Alberto

Re: [PATCH v2 06/36] block: BdrvChildClass: add .get_parent_aio_context handler

2021-01-22 Thread Vladimir Sementsov-Ogievskiy
22.01.2021 14:18, Kevin Wolf wrote: Am 22.01.2021 um 12:04 hat Vladimir Sementsov-Ogievskiy geschrieben: 19.01.2021 19:38, Kevin Wolf wrote: Am 18.01.2021 um 18:36 hat Vladimir Sementsov-Ogievskiy geschrieben: 18.01.2021 18:13, Kevin Wolf wrote: Am 27.11.2020 um 15:44 hat Vladimir

Re: [RFC PATCH v2 4/4] configure: Reword --enable-tcg-interpreter as --disable-native-tcg

2021-01-22 Thread Thomas Huth
On 22/01/2021 11.58, Philippe Mathieu-Daudé wrote: Users might want to enable all features, without realizing some features have negative effect. Rename '--enable-tcg-interpreter' as '--disable-native-tcg' to avoid user selecting this feature without understanding it. '--enable-tcg-interpreter'

Re: [PATCH v7 07/11] iotests: add findtests.py

2021-01-22 Thread Kevin Wolf
Am 16.01.2021 um 14:44 hat Vladimir Sementsov-Ogievskiy geschrieben: > +if 'disabled' not in groups and 'disabled' not in exclude_groups: > +# Don't want to modify function argument, so create new list. > +exclude_groups = exclude_groups + ['disabled'] Oops, forgot

Re: [PATCH v3 12/21] linux-user/aarch64: Implement PR_TAGGED_ADDR_ENABLE

2021-01-22 Thread Peter Maydell
On Fri, 22 Jan 2021 at 11:53, Peter Maydell wrote: > The kernel's "untagged_addr()" implementation: > https://elixir.bootlin.com/linux/latest/source/arch/arm64/include/asm/memory.h#L203 > slightly confusingly does "untag the addr if it's in the userspace > half, leave the tag bits alone if in the

[PATCH V5 4/6] hw/block/nvme: support for multi-controller in subsystem

2021-01-22 Thread Minwoo Im
We have nvme-subsys and nvme devices mapped together. To support multi-controller scheme to this setup, controller identifier(id) has to be managed. Earlier, cntlid(controller id) used to be always 0 because we didn't have any subsystem scheme that controller id matters. This patch introduced

[PATCH V5 6/6] hw/block/nvme: support for shared namespace in subsystem

2021-01-22 Thread Minwoo Im
nvme-ns device is registered to a nvme controller device during the initialization in nvme_register_namespace() in case that 'bus' property is given which means it's mapped to a single controller. This patch introduced a new property 'subsys' just like the controller device instance did to map a

[PATCH V5 2/6] hw/block/nvme: support to map controller to a subsystem

2021-01-22 Thread Minwoo Im
nvme controller(nvme) can be mapped to a NVMe subsystem(nvme-subsys). This patch maps a controller to a subsystem by adding a parameter 'subsys' to the nvme device. To map a controller to a subsystem, we need to put nvme-subsys first and then maps the subsystem to the controller: -device

[PATCH 1/4] hw/riscv: Drop 'struct MemmapEntry'

2021-01-22 Thread Bin Meng
From: Bin Meng There is already a MemMapEntry type defined in hwaddr.h. Let's drop the RISC-V defined `struct MemmapEntry` and use the existing one. Signed-off-by: Bin Meng --- hw/riscv/microchip_pfsoc.c | 9 +++-- hw/riscv/opentitan.c | 9 +++-- hw/riscv/sifive_e.c|

[PATCH 0/4] hw/riscv: Clean-ups and map high mmio for PCIe of 'virt' machine

2021-01-22 Thread Bin Meng
From: Bin Meng This series does the following clean-ups: - Drop 'struct MemmapEntry' - virt: Drop the 'link_up' parameter of gpex_pcie_init() It also adds the following small enhancement to 'virt' machine: - Limit RAM size in a 32-bit system - Map high mmio for PCIe Bin Meng (4): hw/riscv:

Re: [PATCH 2/2] meson: Warn when TCI is selected but TCG backend is available

2021-01-22 Thread Stefan Weil
Am 22.01.21 um 10:47 schrieb Thomas Huth: On 22/01/2021 10.46, Philippe Mathieu-Daudé wrote: On Fri, Jan 22, 2021 at 10:43 AM Thomas Huth wrote: On 22/01/2021 10.22, Philippe Mathieu-Daudé wrote: Some new users get confused with 'TCG' and 'TCI', and enable TCI support expecting to enable

Re: [PATCH] gitlab-ci.yml: Use the whole tree as artifacts to speed up the CI

2021-01-22 Thread Daniel P . Berrangé
On Fri, Jan 22, 2021 at 10:18:33AM +, Daniel P. Berrangé wrote: > On Fri, Jan 22, 2021 at 11:07:22AM +0100, Thomas Huth wrote: > > Currently, our check-system-* jobs are recompiling the whole sources > > again. This happens due to the fact that the jobs are checking out > > the whole source

Re: [PATCH] gitlab-ci.yml: Use the whole tree as artifacts to speed up the CI

2021-01-22 Thread Philippe Mathieu-Daudé
On 1/22/21 11:18 AM, Daniel P. Berrangé wrote: > On Fri, Jan 22, 2021 at 11:07:22AM +0100, Thomas Huth wrote: >> Currently, our check-system-* jobs are recompiling the whole sources >> again. This happens due to the fact that the jobs are checking out >> the whole source tree and required

[PATCH v2 3/4] configure: Improve TCI feature description

2021-01-22 Thread Philippe Mathieu-Daudé
Users might want to enable all features, without realizing some features have negative effect. Mention the TCI feature is slow and experimental, hoping it will be selected knowingly. Suggested-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- configure | 2 +- 1 file changed, 1

Re: [PATCH v7 07/11] iotests: add findtests.py

2021-01-22 Thread Kevin Wolf
Am 16.01.2021 um 14:44 hat Vladimir Sementsov-Ogievskiy geschrieben: > Add python script with new logic of searching for tests: > > Current ./check behavior: > - tests are named [0-9][0-9][0-9] > - tests must be registered in group file (even if test doesn't belong >to any group, like 142)

Re: [PATCH v3 12/21] linux-user/aarch64: Implement PR_TAGGED_ADDR_ENABLE

2021-01-22 Thread Peter Maydell
On Fri, 15 Jan 2021 at 22:47, Richard Henderson wrote: > > This is the prctl bit that controls whether syscalls accept tagged > addresses. See Documentation/arm64/tagged-address-abi.rst in the > linux kernel. > +#ifdef TARGET_TAGGED_ADDRESSES > +/** > + * cpu_untagged_addr: > + * @cs: CPU

[PATCH V5 1/6] hw/block/nvme: introduce nvme-subsys device

2021-01-22 Thread Minwoo Im
To support multi-path in QEMU NVMe device model, We need to have NVMe subsystem hierarchy to map controllers and namespaces to a NVMe subsystem. This patch introduced a simple nvme-subsys device model. The subsystem will be prepared with subsystem NQN with provided in nvme-subsys device: ex)

[PATCH V5 0/6] hw/block/nvme: support multi-path for ctrl/ns

2021-01-22 Thread Minwoo Im
Hello, Here's fifth patch series for the support of NVMe subsystem scheme with multi-controller and namespace sharing in a subsystem. This series has applied review comments from the previous series, mostly from Keith's review. Thanks Keith! Here's test result with a simple 'nvme list -v'

Re: [PATCH] gitlab-ci.yml: Use the whole tree as artifacts to speed up the CI

2021-01-22 Thread Daniel P . Berrangé
On Fri, Jan 22, 2021 at 11:07:22AM +0100, Thomas Huth wrote: > Currently, our check-system-* jobs are recompiling the whole sources > again. This happens due to the fact that the jobs are checking out > the whole source tree and required submodules again, and only try > to use the "build"

Re: [PULL 0/9] s390x updates

2021-01-22 Thread Peter Maydell
On Thu, 21 Jan 2021 at 12:16, Cornelia Huck wrote: > > The following changes since commit 954b83f13236d21b4116b93a726ea36b5dc2d303: > > Merge remote-tracking branch > 'remotes/huth-gitlab/tags/pull-request-2021-01-20' into staging (2021-01-20 > 17:44:31 +) > > are available in the Git

Re: [PATCH] replay: fix replay of the interrupts

2021-01-22 Thread Philippe Mathieu-Daudé
On 1/19/21 1:39 PM, Pavel Dovgalyuk wrote: > Sometimes interrupt event comes at the same time with > the virtual timers. In this case replay tries to proceed > the timers, because deadline for them is zero. > This patch allows processing interrupts and exceptions > by entering the vCPU execution

Re: [PATCH v7 00/11] Rework iotests/check

2021-01-22 Thread Vladimir Sementsov-Ogievskiy
22.01.2021 14:27, Kevin Wolf wrote: Am 20.01.2021 um 21:52 hat Eric Blake geschrieben: On 1/16/21 7:44 AM, Vladimir Sementsov-Ogievskiy wrote: Hi all! These series has 3 goals: - get rid of group file (to forget about rebase and in-list conflicts) - introduce human-readable names for

Re: [PATCH] util/log: flush TB cache when log level changes

2021-01-22 Thread Alex Bennée
Pavel Dovgalyuk writes: > Sometimes we need to collect the translation logs starting > from some point of the execution. Some TB listings may > be missed in this case, when blocks were translated before. > This patch clears TB cache to allow re-translation of such > code blocks. > >

Re: [Qemu-devel] [PATCH v2 07/11] chardev: Let IOReadHandler use unsigned type

2021-01-22 Thread P J P
+-- On Fri, 22 Jan 2021, Richard Purdie wrote --+ | If so can anyone point me at that change? | | I ask since CVE-2018-18438 is marked as affecting all qemu versions | (https://nvd.nist.gov/vuln/detail/CVE-2018-18438). | | If it was fixed, the version mask could be updated. If the fix wasn't

Re: [PATCH v7 07/11] iotests: add findtests.py

2021-01-22 Thread Vladimir Sementsov-Ogievskiy
22.01.2021 14:49, Kevin Wolf wrote: Am 16.01.2021 um 14:44 hat Vladimir Sementsov-Ogievskiy geschrieben: +if 'disabled' not in groups and 'disabled' not in exclude_groups: +# Don't want to modify function argument, so create new list. +exclude_groups =

[PATCH V5 5/6] hw/block/nvme: add NMIC enum value for Identify Namespace

2021-01-22 Thread Minwoo Im
Added Namespace Multi-path I/O and Namespace Sharing Capabilities (NMIC) field to support shared namespace from controller(s). This field is in Identify Namespace data structure in [30]. Signed-off-by: Minwoo Im --- include/block/nvme.h | 4 1 file changed, 4 insertions(+) diff --git

[PATCH] hw/mips: loongson3: Drop 'struct MemmapEntry'

2021-01-22 Thread Bin Meng
From: Bin Meng There is already a MemMapEntry type defined in hwaddr.h. Let's drop the loongson3 defined `struct MemmapEntry` and use the existing one. Signed-off-by: Bin Meng --- hw/mips/loongson3_bootp.h | 7 +-- hw/mips/loongson3_virt.c | 6 +++--- 2 files changed, 4 insertions(+), 9

[PATCH] gitlab-ci.yml: Use the whole tree as artifacts to speed up the CI

2021-01-22 Thread Thomas Huth
Currently, our check-system-* jobs are recompiling the whole sources again. This happens due to the fact that the jobs are checking out the whole source tree and required submodules again, and only try to use the "build" directory with the binaries and object files as an artifact from the previous

Re: Thread safety of coroutine-sigaltstack

2021-01-22 Thread Peter Maydell
On Fri, 22 Jan 2021 at 08:50, Max Reitz wrote: > > On 20.01.21 18:25, Laszlo Ersek wrote: > > [...] > > > A simple grep for SIGUSR2 seems to indicate that SIGUSR2 is not used by > > system emulation for anything else, in practice. Is it possible to > > dedicate SIGUSR2 explicitly to

[PATCH] coroutine-sigaltstack: Keep SIGUSR2 handler up

2021-01-22 Thread Max Reitz
Modifying signal handlers is a process-global operation. When two threads run coroutine-sigaltstack's qemu_coroutine_new() concurrently, they may interfere with each other: One of them may revert the SIGUSR2 handler back to the default between the other thread setting up coroutine_trampoline() as

Re: [PATCH v2 06/36] block: BdrvChildClass: add .get_parent_aio_context handler

2021-01-22 Thread Vladimir Sementsov-Ogievskiy
19.01.2021 19:38, Kevin Wolf wrote: Am 18.01.2021 um 18:36 hat Vladimir Sementsov-Ogievskiy geschrieben: 18.01.2021 18:13, Kevin Wolf wrote: Am 27.11.2020 um 15:44 hat Vladimir Sementsov-Ogievskiy geschrieben: Add new handler to get aio context and implement it in all child classes. Add

Re: [PATCH v7 07/11] iotests: add findtests.py

2021-01-22 Thread Vladimir Sementsov-Ogievskiy
22.01.2021 14:48, Kevin Wolf wrote: Am 16.01.2021 um 14:44 hat Vladimir Sementsov-Ogievskiy geschrieben: Add python script with new logic of searching for tests: Current ./check behavior: - tests are named [0-9][0-9][0-9] - tests must be registered in group file (even if test doesn't

Re: [PATCH v3 17/21] linux-user/aarch64: Signal SEGV_MTESERR for sync tag check fault

2021-01-22 Thread Peter Maydell
On Fri, 15 Jan 2021 at 22:47, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > linux-user/aarch64/target_signal.h | 2 ++ > linux-user/aarch64/cpu_loop.c | 3 +++ > 2 files changed, 5 insertions(+) > > diff --git a/linux-user/aarch64/target_signal.h >

[PATCH 4/4] hw/riscv: virt: Map high mmio for PCIe

2021-01-22 Thread Bin Meng
From: Bin Meng Some peripherals require 64-bit PCI address, so let's map the high mmio space for PCIe. For RV32, the address is hardcoded to below 4 GiB from the highest accessible physical address. For RV64, the base address depends on top of RAM and is aligned to its size which is using 16

Re: [PATCHv8 3/3] arm-virt: add secure pl061 for reset/power down

2021-01-22 Thread Peter Maydell
On Fri, 22 Jan 2021 at 08:29, Andrew Jones wrote: > > On Wed, Jan 20, 2021 at 12:27:48PM +0300, Maxim Uvarov wrote: > > Add secure pl061 for reset/power down machine from > > the secure world (Arm Trusted Firmware). Connect it > > with gpio-pwr driver. > > > > Signed-off-by: Maxim Uvarov > > ---

Re: [RFC PATCH] linux-user/mmap: Return EFAULT for invalid addresses

2021-01-22 Thread Philippe Mathieu-Daudé
Cc'ing maintainer On 1/22/21 10:37 AM, Richard Purdie wrote: > On Fri, 2021-01-08 at 17:46 +, Richard Purdie wrote: >> When using qemu-i386 to run gobject introspection parts of a webkitgtk  >> build using musl as libc on a 64 bit host, it sits in an infinite loop  >> of mremap calls of ever

  1   2   3   4   >