Re: [PATCH 12/12] configure: bump min required CLang to 7.0.0 / XCode 10.2

2021-05-11 Thread Richard Henderson
On 5/11/21 8:26 AM, Daniel P. Berrangé wrote: Several distros have been dropped since the last time we bumped the minimum required CLang version. Per repology, currently shipping versions are: RHEL-8: 10.0.1 Debian Stretch: 7.0.1 Debian Buster: 7.0.1 openSUSE Leap

Re: [PULL 00/10] Net patches

2021-05-11 Thread Jason Wang
在 2021/5/12 上午4:20, Peter Maydell 写道: On Sat, 8 May 2021 at 08:18, Jason Wang wrote: The following changes since commit d90f154867ec0ec22fd719164b88716e8fd48672: Merge remote-tracking branch 'remotes/dg-gitlab/tags/ppc-for-6.1-20210504' into staging (2021-05-05 20:29:14 +0100) are

Re: [RFC PATCH 1/5] hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on'

2021-05-11 Thread Philippe Mathieu-Daudé
On 5/12/21 4:24 AM, David Gibson wrote: > On Tue, May 11, 2021 at 05:53:50PM +0200, Philippe Mathieu-Daudé wrote: >> Per the kconfig.rst: >> >> A device should be listed [...] ``imply`` if (depending on >> the QEMU command line) the board may or may not be started >> without it. >> >> This

Re: [PATCH 1/1] gitlab-ci: Add KVM x86 cross-build jobs

2021-05-11 Thread Philippe Mathieu-Daudé
On 5/12/21 6:57 AM, Thomas Huth wrote: > On 12/05/2021 06.42, Philippe Mathieu-Daudé wrote: >> Add a new job to cross-build the x86 target without the >> TCG/XEN accelerators (IOW: only KVM accelerator enabled). >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >>   .gitlab-ci.d/crossbuilds.yml

[PATCH v2 4/6] gitlab-ci: Add ccache in $PATH and display statistics

2021-05-11 Thread Philippe Mathieu-Daudé
If a runner has ccache installed, use it and display statistics at the end of the build. Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.d/buildtest-template.yml | 5 + 1 file changed, 5 insertions(+) diff --git a/.gitlab-ci.d/buildtest-template.yml

Re: [PATCH] configure: Only clone softfloat-3 repositories if TCG is enabled

2021-05-11 Thread Philippe Mathieu-Daudé
On 5/12/21 7:12 AM, Thomas Huth wrote: > On 12/05/2021 06.58, Philippe Mathieu-Daudé wrote: >> Signed-off-by: Philippe Mathieu-Daudé >> --- >>   configure | 7 +-- >>   1 file changed, 5 insertions(+), 2 deletions(-) >> >> diff --git a/configure b/configure >> index 5877a6b2bfe..e0e02623e3e

[PATCH v2 5/6] gitlab-ci: Simplify before/after script for Avocado based jobs

2021-05-11 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.d/buildtest-template.yml | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.gitlab-ci.d/buildtest-template.yml b/.gitlab-ci.d/buildtest-template.yml index a625c697d3b..f968fa1ad99 100644 ---

Re: [PATCH RESEND v8 2/6] [RISCV_PM] Support CSRs required for RISC-V PM extension except for the h-mode

2021-05-11 Thread Alistair Francis
On Wed, Apr 28, 2021 at 2:19 PM Alexey Baturo wrote: > > Signed-off-by: Alexey Baturo > --- > resend: > minor codestyle fix > > target/riscv/cpu.c | 5 + > target/riscv/cpu.h | 12 ++ > target/riscv/cpu_bits.h | 66 +++ > target/riscv/csr.c | 240

Re: [PATCH 07/12] crypto: drop used conditional check

2021-05-11 Thread Richard Henderson
On 5/11/21 8:26 AM, Daniel P. Berrangé wrote: The condition being tested has never been set since the day the code was first introduced. Signed-off-by: Daniel P. Berrangé --- crypto/tlscredsx509.c | 2 -- 1 file changed, 2 deletions(-) Reviewed-by: Richard Henderson r~

Re: [RFC PATCH 4/5] hw/ppc/fdt: Drop dependency on libfdt

2021-05-11 Thread David Gibson
On Tue, May 11, 2021 at 05:53:53PM +0200, Philippe Mathieu-Daudé wrote: > hw/ppc/fdt.c defines the ppc_create_page_sizes_prop() function, > which is unrelated to the libfdt. Remove the incorrect library > dependency on the file. > > Signed-off-by: Philippe Mathieu-Daudé This is definitely wrong

Re: making a qdev bus available from a (non-qtree?) device

2021-05-11 Thread Philippe Mathieu-Daudé
On 5/11/21 8:17 PM, Klaus Jensen wrote: > Hi all, > > I need some help with grok'ing qdev busses. Stefan, Michael - David > suggested on IRC that I CC'ed you guys since you might have solved a > similar issue with virtio devices. I've tried to study how that works, > but I'm not exactly sure how

Re: [PATCH v2 29/30] cirrus.yml: Fix the MSYS2 task

2021-05-11 Thread Philippe Mathieu-Daudé
Hi Yonggang Luo, Does this look OK to you? On 5/4/21 12:02 PM, Alex Bennée wrote: > From: Thomas Huth > > The MSYS2 task in the Cirrus-CI is currently failing with error messages > like this: > > warning: database file for 'ucrt64' does not exist (use '-Sy' to download) > :: Starting core

[PATCH] configure: Only clone softfloat-3 repositories if TCG is enabled

2021-05-11 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- configure | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 5877a6b2bfe..e0e02623e3e 100755 --- a/configure +++ b/configure @@ -257,8 +257,6 @@ if test -e "$source_path/.git" then

Re: [PATCH] configure: Only clone softfloat-3 repositories if TCG is enabled

2021-05-11 Thread Thomas Huth
On 12/05/2021 06.58, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- configure | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 5877a6b2bfe..e0e02623e3e 100755 --- a/configure +++ b/configure @@ -257,8 +257,6 @@ if

[PATCH 1/2] target/i386: Make sure that vsyscall's tb->size != 0

2021-05-11 Thread Ilya Leoshkevich
tb_gen_code() assumes that tb->size must never be zero, otherwise it may produce spurious exceptions. For x86_64 this may happen when creating a translation block for the vsyscall page. Fix by pretending that vsyscall translation blocks have at least one instruction. Signed-off-by: Ilya

[PATCH 1/1] gitlab-ci: Add KVM x86 cross-build jobs

2021-05-11 Thread Philippe Mathieu-Daudé
Add a new job to cross-build the x86 target without the TCG/XEN accelerators (IOW: only KVM accelerator enabled). Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.d/crossbuilds.yml | 8 1 file changed, 8 insertions(+) diff --git a/.gitlab-ci.d/crossbuilds.yml

Re: [RFC PATCH 1/5] hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on'

2021-05-11 Thread Thomas Huth
On 12/05/2021 05.57, Philippe Mathieu-Daudé wrote: On 5/12/21 4:24 AM, David Gibson wrote: On Tue, May 11, 2021 at 05:53:50PM +0200, Philippe Mathieu-Daudé wrote: Per the kconfig.rst: A device should be listed [...] ``imply`` if (depending on the QEMU command line) the board may or may

Re: [PATCH v2 29/30] cirrus.yml: Fix the MSYS2 task

2021-05-11 Thread Yonggang Luo
LGTM, Thanks, forget to update this On Wed, May 12, 2021 at 12:49 PM Philippe Mathieu-Daudé wrote: > Hi Yonggang Luo, > > Does this look OK to you? > > On 5/4/21 12:02 PM, Alex Bennée wrote: > > From: Thomas Huth > > > > The MSYS2 task in the Cirrus-CI is currently failing with error messages

[PATCH v2 6/6] gitlab-ci: Add FreeBSD jobs

2021-05-11 Thread Philippe Mathieu-Daudé
Add system/user emulation jobs on FreeBSD host. To build these jobs, you need to add a FreeBSD runner and add 'freebsd' to the QEMU_CUSTOM_RUNNER variable in your GitLab project. Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.d/buildtest-freebsd.yml | 59 ++

Re: GICv3 for MTTCG

2021-05-11 Thread Zenghui Yu
[+Shashi] On 2021/5/12 1:51, Andrey Shinkevich wrote: Dear colleagues, I am looking for ways to accelerate the MTTCG for ARM guest on x86-64 host. The maximum number of CPUs for MTTCG that uses GICv2 is limited by 8: include/hw/intc/arm_gic_common.h:#define GIC_NCPU 8 The version 3 of the

Re: [RFC PATCH 0/5] buildsys: Do not use internal fdt library when asked for the system one

2021-05-11 Thread Philippe Mathieu-Daudé
Hi Paolo, On 5/11/21 5:57 PM, Philippe Mathieu-Daudé wrote: > On 5/11/21 5:53 PM, Philippe Mathieu-Daudé wrote: >> Attempt to fix the issue reported by John when building >> with an outdated libfdt. > > Unencoded version of this cover: > > For now it changes: > > hw/ppc/spapr_hcall.c: In

Re: [PATCH qemu v19] spapr: Implement Open Firmware client interface

2021-05-11 Thread Alexey Kardashevskiy
On 4/22/21 22:58, Alexey Kardashevskiy wrote: The PAPR platform describes an OS environment that's presented by a combination of a hypervisor and firmware. The features it specifies require collaboration between the firmware and the hypervisor. Ping? Thanks, Since the beginning, the

Re: [PATCH v2 30/30] configure: use cc, not host_cc to set cross_cc for build arch

2021-05-11 Thread Philippe Mathieu-Daudé
On 5/4/21 12:02 PM, Alex Bennée wrote: > Otherwise you run into hilarity like trying when cross compiling a 32 > bit ARM build on a 64 bit system trying to use host_cc to build 32 bit > test cases. > > Signed-off-by: Alex Bennée > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH 11/12] configure: bump min required GCC to 6.3.0

2021-05-11 Thread Richard Henderson
On 5/11/21 8:26 AM, Daniel P. Berrangé wrote: Several distros have been dropped since the last time we bumped the minimum required GCC version. Per repology, currently shipping versions are: RHEL-8: 8.3.1 Debian Stretch: 6.3.0 Debian Buster: 8.3.0 openSUSE Leap

Re: [PATCH 3/3] virtio-net: Constify VirtIOFeature feature_sizes[]

2021-05-11 Thread Jason Wang
在 2021/5/11 下午6:41, Philippe Mathieu-Daudé 写道: Signed-off-by: Philippe Mathieu-Daudé --- hw/net/virtio-net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 66b9ff45118..6b7e8dd04ef 100644 --- a/hw/net/virtio-net.c +++

Re: [PATCH 2/3] virtio-blk: Constify VirtIOFeature feature_sizes[]

2021-05-11 Thread Jason Wang
在 2021/5/11 下午6:41, Philippe Mathieu-Daudé 写道: Signed-off-by: Philippe Mathieu-Daudé --- hw/block/virtio-blk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c index d28979efb8d..f139cd7cc9c 100644 --- a/hw/block/virtio-blk.c

[PATCH 0/1] gitlab-ci: Add KVM x86 cross-build jobs

2021-05-11 Thread Philippe Mathieu-Daudé
Add a job to avoid breaking x86 KVM-only builds (the feature recently added by Claudio): https://gitlab.com/philmd/qemu/-/jobs/1255115665 Paolo, (assuming Thomas Acks the patch), could you queue it on top of your current pull request? Based-on: <20210511081350.419428-1-pbonz...@redhat.com>

Re: [PATCH v2 29/30] cirrus.yml: Fix the MSYS2 task

2021-05-11 Thread Yonggang Luo
Reviewed-by: Yonggang Luo On Tue, May 4, 2021 at 6:09 PM Alex Bennée wrote: > > From: Thomas Huth > > The MSYS2 task in the Cirrus-CI is currently failing with error messages > like this: > > warning: database file for 'ucrt64' does not exist (use '-Sy' to download) > :: Starting core system

Re: [PATCH 1/1] gitlab-ci: Add KVM x86 cross-build jobs

2021-05-11 Thread Thomas Huth
On 12/05/2021 06.42, Philippe Mathieu-Daudé wrote: Add a new job to cross-build the x86 target without the TCG/XEN accelerators (IOW: only KVM accelerator enabled). Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.d/crossbuilds.yml | 8 1 file changed, 8 insertions(+) diff

[Bug 1883729] Re: xhci_find_stream: Assertion `streamid != 0' failed.

2021-05-11 Thread Thomas Huth
Ok, with the new attachment from comment #5, I can also reporoduce the bug again. It does not reproduce with the attachments from comment #1 or #2 anymore, so this now seems to be a different way to run into this assert. Anyway, setting the status back to Confirmed since it is reproducible again.

[PATCH v2 3/6] gitlab-ci: Run GNU make via the $MAKE variable

2021-05-11 Thread Philippe Mathieu-Daudé
Add the $MAKE variable to call GNU make, and set it to 'gmake' on FreeBSD to avoid: $ make -j"$JOBS" make: Unknown modifier ',' make: "/builds/dTyar424/0/qemu/build/Makefile" line 3: Need an operator make: "/builds/dTyar424/0/qemu/build/Makefile" line 4: Missing dependency operator

Re: [PATCH 04/12] crypto: drop back compatibility typedefs for nettle

2021-05-11 Thread Richard Henderson
On 5/11/21 8:26 AM, Daniel P. Berrangé wrote: Now that we only support modern nettle, we don't need to have local typedefs to mask the real nettle types. Signed-off-by: Daniel P. Berrangé --- crypto/cipher-nettle.c.inc | 60 -- crypto/hash-nettle.c |

Re: [PATCH 00/72] Convert floatx80 and float128 to FloatParts

2021-05-11 Thread Richard Henderson
On 5/10/21 8:36 AM, Alex Bennée wrote: Richard Henderson writes: Reorg everything using QEMU_GENERIC and multiple inclusion to reduce the amount of code duplication between the formats. The use of QEMU_GENERIC means that we need to use pointers instead of structures, which means that even

Re: [PATCH 1/3] hw/virtio: Pass virtio_feature_get_config_size() a const argument

2021-05-11 Thread Jason Wang
在 2021/5/11 下午6:41, Philippe Mathieu-Daudé 写道: The VirtIOFeature structure isn't modified, mark it const. Signed-off-by: Philippe Mathieu-Daudé Acked-by: Jason Wang --- include/hw/virtio/virtio.h | 2 +- hw/virtio/virtio.c | 2 +- 2 files changed, 2 insertions(+), 2

Re: [RFC PATCH 3/5] hw/ppc: Have pSeries depends on libfdt (via host Kconfig FDT symbol)

2021-05-11 Thread David Gibson
On Tue, May 11, 2021 at 05:53:52PM +0200, Philippe Mathieu-Daudé wrote: > Since commit fea35ca4b8e ("ppc/spapr: Receive and store device > tree blob from SLOF") the pSeries machine depends on the libfdt > fdt_check_full() call, which is available in libfdt v1.4.7. > > Add the corresponding

Re: [PULL 0/1] NBD patches for 2021-05-11

2021-05-11 Thread Philippe Mathieu-Daudé
Hi Eric, On 5/11/21 9:28 PM, Eric Blake wrote: > The following changes since commit f9a576a818044133f8564e0d243ebd97df0b3280: > > Merge remote-tracking branch > 'remotes/dgilbert-gitlab/tags/pull-virtiofs-20210506' into staging > (2021-05-11 13:03:44 +0100) > > are available in the Git

Re: [PATCH v2 01/30] checkpatch: Fix use of uninitialized value

2021-05-11 Thread Philippe Mathieu-Daudé
On 5/4/21 12:01 PM, Alex Bennée wrote: > From: Greg Kurz > > checkfilename() doesn't always set $acpi_testexpected. Fix the following > warning: > > Use of uninitialized value $acpi_testexpected in string eq at > ./scripts/checkpatch.pl line 1529. > > Fixes: d2f1af0e4120 ("checkpatch: don't

Re: [PATCH v8] introduce vfio-user protocol specification

2021-05-11 Thread John Johnson
> On May 10, 2021, at 3:25 PM, John Levon wrote: > > On Mon, May 10, 2021 at 05:57:37PM +0100, Stefan Hajnoczi wrote: > > >>> +VFIO_USER_VM_INTERRUPT >>> +-- >>> + >>> +Message format >>> +^^ >>> + >>> ++++ >>> +| Name

[Bug 1883728] Re: address_space_unmap: Assertion `mr != NULL' failed.

2021-05-11 Thread Thomas Huth
Ok, thanks for checking! So seems like this has been fixed, thus I'm closing the bug. If it happens again, please open a new ticket in our new gitlab issue tracker. ** Changed in: qemu Status: Incomplete => Fix Released -- You received this bug notification because you are a member of

Re: [RFC PATCH 1/5] hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on'

2021-05-11 Thread Thomas Huth
On 12/05/2021 07.08, Philippe Mathieu-Daudé wrote: On 5/12/21 6:53 AM, Thomas Huth wrote: On 12/05/2021 05.57, Philippe Mathieu-Daudé wrote: On 5/12/21 4:24 AM, David Gibson wrote: On Tue, May 11, 2021 at 05:53:50PM +0200, Philippe Mathieu-Daudé wrote: Per the kconfig.rst:    A device

Re: [RFC PATCH 1/5] hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on'

2021-05-11 Thread David Gibson
On Tue, May 11, 2021 at 05:53:50PM +0200, Philippe Mathieu-Daudé wrote: > Per the kconfig.rst: > > A device should be listed [...] ``imply`` if (depending on > the QEMU command line) the board may or may not be started > without it. > > This is the case with the NVDIMM device, so use the

Re: [PATCH v4 2/2] ui/cocoa: add option to swap Option and Command

2021-05-11 Thread Akihiko Odaki
Reviewed-by: Akihiko Odaki I applied them to my personal tree: https://github.com/akihikodaki/qemu/tree/macos 2021年5月12日(水) 3:56 : > > From: Gustavo Noronha Silva > > On Mac OS X the Option key maps to Alt and Command to Super/Meta. This change > swaps them around so that Alt is the key closer

Re: [PATCH] ppc/spapr: advertise secure boot in the guest device tree

2021-05-11 Thread Daniel Axtens
> So.. what's the point? AFAIK we have no secure boot support in SLOF, > so what would advertising it in the device tree accomplish? Linux reads the property and enters secure boot mode: commit 61f879d97ce4 ("powerpc/pseries: Detect secure and trusted boot state of the system.") grub patches

Re: [RFC PATCH 1/5] hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on'

2021-05-11 Thread Philippe Mathieu-Daudé
On 5/12/21 6:53 AM, Thomas Huth wrote: > On 12/05/2021 05.57, Philippe Mathieu-Daudé wrote: >> On 5/12/21 4:24 AM, David Gibson wrote: >>> On Tue, May 11, 2021 at 05:53:50PM +0200, Philippe Mathieu-Daudé wrote: Per the kconfig.rst:    A device should be listed [...] ``imply`` if

[PATCH v2 08/32] i386: Add SGX CPUID leaf FEAT_SGX_12_0_EBX

2021-05-11 Thread Yang Zhong
From: Sean Christopherson CPUID leaf 12_0_EBX is an Intel-defined feature bits leaf enumerating the platform's SGX extended capabilities. Currently there is a single capabilitiy: - EXINFO: record information about #PFs and #GPs in the enclave's SSA Signed-off-by: Sean Christopherson

[PULL 16/33] i386: split off sysemu part of cpu.c

2021-05-11 Thread Paolo Bonzini
From: Claudio Fontana Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson Message-Id: <20210322132800.7470-19-cfont...@suse.de> Signed-off-by: Paolo Bonzini --- target/i386/cpu-internal.h | 70 +++ target/i386/cpu-sysemu.c | 352 +

[PULL 20/33] accel: move call to accel_init_interfaces

2021-05-11 Thread Paolo Bonzini
From: Claudio Fontana move the call for sysemu specifically in machine_run_board_init, mirror the calling sequence for user mode too. Suggested-by: Paolo Bonzini Signed-off-by: Claudio Fontana Message-Id: <20210322132800.7470-23-cfont...@suse.de> Signed-off-by: Paolo Bonzini ---

[PULL 27/33] target/i386: allow customizing the next phase of the translation

2021-05-11 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- target/i386/tcg/sysemu/excp_helper.c | 30 +--- 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/target/i386/tcg/sysemu/excp_helper.c b/target/i386/tcg/sysemu/excp_helper.c index 2b7baa0193..082ddbb911 100644 ---

[PULL 32/33] configure: fix detection of gdbus-codegen

2021-05-11 Thread Paolo Bonzini
"pkg-config --variable=gdbus_codegen gio-2.0" returns "gdbus-codegen", and it does not pass test -x (which does not walk the path). Meson 0.58.0 notices that something is iffy, as the dbus_vmstate1 assignment in tests/qtest/meson.build uses an empty string as the command, and fails very

Re: [PATCH 0/3] vhost-user-blk-test: add tests for the vhost-user-blk server

2021-05-11 Thread Stefan Hajnoczi
On Mon, Mar 22, 2021 at 09:23:24AM +, Stefan Hajnoczi wrote: > These patches add a qtest for the vhost-user-blk server. CI found several > issues that caused these patches to be dropped from Michael Tsirkin and Kevin > Wolf's pull requests in the past. Hopefully they will go in smoothly this

[PATCH v3 00/20] virtio-gpu: Add support for Blob resources

2021-05-11 Thread Vivek Kasireddy
Enabling this feature would eliminate data copies from the resource object in the Guest to the shadow resource in Qemu. This patch series however adds support only for Blobs of type VIRTIO_GPU_BLOB_MEM_GUEST with property VIRTIO_GPU_BLOB_FLAG_USE_SHAREABLE. Most of the patches in this series are

[PATCH v3 11/20] virtio-gpu: Factor out update scanout

2021-05-11 Thread Vivek Kasireddy
Creating a small helper function for updating the scanout will be useful in the next patch where this needs to be done early in do_set_scanout before returning. Cc: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- hw/display/virtio-gpu.c | 35 +++ 1 file

[PATCH v3 20/20] virtio-gpu: Add gl_flushed callback

2021-05-11 Thread Vivek Kasireddy
Adding this callback provides a way to determine when the UI has submitted the buffer to the Host windowing system. Making the guest wait for this event will ensure that the dmabuf/buffer updates are synchronized. Cc: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- hw/display/virtio-gpu.c

Re: [PATCH 6/6] aiopool: protect with a mutex

2021-05-11 Thread Paolo Bonzini
On 10/05/21 13:56, Vladimir Sementsov-Ogievskiy wrote: +    } -    if (task->ret < 0 && pool->status == 0) { -    pool->status = task->ret; +    if (ret < 0) { +    qatomic_cmpxchg(>status, 0, ret);   } Can we just do it inside critical section above and avoid extra cmpxchg?

Re: [PATCH v2 5/5] blkdebug: protect rules and suspended_reqs with a lock

2021-05-11 Thread Emanuele Giuseppe Esposito
On 11/05/2021 10:37, Paolo Bonzini wrote: On 07/05/21 17:29, Eric Blake wrote: +    qemu_mutex_lock(>lock);   QLIST_FOREACH(r, >suspended_reqs, next) {   if (!strcmp(r->tag, tag)) { +    qemu_mutex_unlock(>lock);   return true;   }   } +   

Re: [PATCH] scripts: add a script to list virtio devices in a system

2021-05-11 Thread Michael S. Tsirkin
On Fri, May 07, 2021 at 08:17:33AM +0200, Laurent Vivier wrote: > On 06/05/2021 21:50, Philippe Mathieu-Daudé wrote: > > On 5/6/21 9:33 PM, Laurent Vivier wrote: > >> Add "lsvirtio" that lists all virtio devices in a system > >> the same way lspci does for the PCI cards. > >> > >> For instance: >

[PATCH v3 17/20] ui: Add egl helpers for synchronization

2021-05-11 Thread Vivek Kasireddy
These egl helpers will be useful for creating a sync object and waiting on it when called from the virtio-gpu wait_flush API. Cc: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- include/ui/console.h | 2 ++ include/ui/egl-helpers.h | 4 ui/egl-helpers.c | 44

Re: [PATCH v6 12/82] target/arm: Implement SVE2 integer add/subtract wide

2021-05-11 Thread Peter Maydell
On Fri, 30 Apr 2021 at 21:38, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > v2: Fix select offsets (laurent desnogues). > --- > target/arm/helper-sve.h| 16 > target/arm/sve.decode | 12 > target/arm/sve_helper.c| 30

Re: [PATCH 01/72] qemu/host-utils: Use __builtin_bitreverseN

2021-05-11 Thread David Hildenbrand
On 08.05.21 03:46, Richard Henderson wrote: Clang has added some builtins for these operations; use them if available. Signed-off-by: Richard Henderson --- include/qemu/host-utils.h | 16 1 file changed, 16 insertions(+) diff --git a/include/qemu/host-utils.h

Re: [PATCH v2 5/5] sockets: Support multipath TCP

2021-05-11 Thread Daniel P . Berrangé
On Wed, Apr 21, 2021 at 12:28:34PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Multipath TCP allows combining multiple interfaces/routes into a single > socket, with very little work for the user/admin. > > It's enabled by 'mptcp' on most socket addresses: >

Re: [PATCH 07/72] softfloat: Inline float_raise

2021-05-11 Thread David Hildenbrand
On 08.05.21 03:46, Richard Henderson wrote: Signed-off-by: Richard Henderson --- include/fpu/softfloat.h| 5 - fpu/softfloat-specialize.c.inc | 12 2 files changed, 4 insertions(+), 13 deletions(-) diff --git a/include/fpu/softfloat.h b/include/fpu/softfloat.h

Re: [PATCH 12/72] softfloat: fix return_nan vs default_nan_mode

2021-05-11 Thread David Hildenbrand
On 08.05.21 03:47, Richard Henderson wrote: Do not call parts_silence_nan when default_nan_mode is in effect. This will avoid an assert in a later patch. Signed-off-by: Richard Henderson --- fpu/softfloat.c | 19 +++ 1 file changed, 7 insertions(+), 12 deletions(-) diff

Re: [for-6.1 v3 3/3] virtiofsd: Add support for FUSE_SYNCFS request

2021-05-11 Thread Greg Kurz
On Mon, 10 May 2021 15:15:02 -0400 Vivek Goyal wrote: > On Mon, May 10, 2021 at 05:55:39PM +0200, Greg Kurz wrote: > > Honor the expected behavior of syncfs() to synchronously flush all data > > and metadata on linux systems. Simply loop on all known submounts and > > call syncfs() on them. > >

[PULL v3 04/42] hw/riscv: sifive_e: Add 'const' to sifive_e_memmap[]

2021-05-11 Thread Alistair Francis
From: Bin Meng This was accidentally dropped before. Add it back. Fixes: 732612856a8 ("hw/riscv: Drop 'struct MemmapEntry'") Reported-by: Emmanuel Blot Signed-off-by: Bin Meng Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Message-id:

[PULL v3 00/42] riscv-to-apply queue

2021-05-11 Thread Alistair Francis
-to-apply-20210511 for you to fetch changes up to c30a0757f094c107e491820e3d35224eb68859c7: target/riscv: Fix the RV64H decode comment (2021-05-11 20:02:07 +1000) A large collection of RISC-V fixes, improvements and features

[PULL v3 03/42] target/riscv: Align the data type of reset vector address

2021-05-11 Thread Alistair Francis
From: Dylan Jhong Use target_ulong to instead of uint64_t on reset vector address to adapt on both 32/64 machine. Signed-off-by: Dylan Jhong Signed-off-by: Ruinland ChuanTzu Tsai Reviewed-by: Bin Meng Reviewed-by: Alistair Francis Message-id: 20210329034801.22667-1-dy...@andestech.com

Re: [PATCH 16/72] softfloat: Move type-specific pack/unpack routines

2021-05-11 Thread David Hildenbrand
On 08.05.21 03:47, Richard Henderson wrote: In preparation from moving sf_canonicalize. Signed-off-by: Richard Henderson --- fpu/softfloat.c | 109 +--- 1 file changed, 56 insertions(+), 53 deletions(-) diff --git a/fpu/softfloat.c

[PULL v3 14/42] MAINTAINERS: Update the RISC-V CPU Maintainers

2021-05-11 Thread Alistair Francis
Update the RISC-V maintainers by removing Sagar and Bastian who haven't been involved recently. Also add Bin who has been helping with reviews. Signed-off-by: Alistair Francis Acked-by: Bin Meng Acked-by: Bastian Koppelmann Reviewed-by: Philippe Mathieu-Daudé Message-id:

[PULL v3 27/42] target/riscv: Add ePMP support for the Ibex CPU

2021-05-11 Thread Alistair Francis
The physical Ibex CPU has ePMP support and it's enabled for the OpenTitan machine so let's enable ePMP support for the Ibex CPU in QEMU. Signed-off-by: Alistair Francis Reviewed-by: Bin Meng Message-id: d426baabab0c9361ed2e989dbe416e417a551fd1.1618812899.git.alistair.fran...@wdc.com ---

[PULL v3 40/42] target/riscv: Consolidate RV32/64 32-bit instructions

2021-05-11 Thread Alistair Francis
This patch removes the insn32-64.decode decode file and consolidates the instructions into the general RISC-V insn32.decode decode tree. This means that all of the instructions are avaliable in both the 32-bit and 64-bit builds. This also means that we run a check to ensure we are running a

Re: [PATCH v3 16/33] nbd/client-connection: add possibility of negotiation

2021-05-11 Thread Roman Kagan
On Fri, Apr 16, 2021 at 11:08:54AM +0300, Vladimir Sementsov-Ogievskiy wrote: > Add arguments and logic to support nbd negotiation in the same thread > after successful connection. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > include/block/nbd.h | 9 +++- > block/nbd.c

[PULL v3 36/42] target/riscv: Remove the hardcoded MSTATUS_SD macro

2021-05-11 Thread Alistair Francis
Signed-off-by: Alistair Francis Reviewed-by: Richard Henderson Message-id: fcc125d96da941b56c817c9dd6068dc36478fc53.1619234854.git.alistair.fran...@wdc.com --- target/riscv/cpu_bits.h | 10 -- target/riscv/csr.c | 12 ++-- target/riscv/translate.c | 19

[PULL v3 38/42] target/riscv: Remove the unused HSTATUS_WPRI macro

2021-05-11 Thread Alistair Francis
Signed-off-by: Alistair Francis Reviewed-by: Richard Henderson Reviewed-by: Bin Meng Message-id: e095b57af0d419c8ed822958f04dfc732d7beb7e.1619234854.git.alistair.fran...@wdc.com --- target/riscv/cpu_bits.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/target/riscv/cpu_bits.h

Re: [PATCH v3 03/20] virtio-gpu: Add udmabuf helpers

2021-05-11 Thread Gerd Hoffmann
Hi, > +void virtio_gpu_fini_udmabuf(struct virtio_gpu_simple_resource *res) > +{ > +uint32_t size = res->width * res->height * 4; Hmm, no. We'll go use udmabufs for blob resources only, so this should not be needed. Maybe squash this with patch #8? take care, Gerd

Re: [PATCH 2/2] QOMify sifive_uart model

2021-05-11 Thread Luc Michel
On 5/4/21 5:34 PM, Lukas Jünger wrote: Signed-off-by: Lukas Jünger Reviewed-by: Luc Michel --- include/hw/char/sifive_uart.h | 6 +-- hw/char/sifive_uart.c | 72 ++- 2 files changed, 65 insertions(+), 13 deletions(-) diff --git

[PULL 05/33] accel: introduce new accessor functions

2021-05-11 Thread Paolo Bonzini
From: Claudio Fontana avoid open coding the accesses to cpu->accel_cpu interfaces, and instead introduce: accel_cpu_instance_init, accel_cpu_realizefn to be used by the targets/ initfn code, and by cpu_exec_realizefn respectively. Signed-off-by: Claudio Fontana Reviewed-by: Alex Bennée

[PULL 23/33] target/i386: move paging mode constants from SVM to cpu.h

2021-05-11 Thread Paolo Bonzini
We will reuse the page walker for both SVM and regular accesses. To do so we will build a function that receives the currently active paging mode; start by including in cpu.h the constants and the function to go from cr4/hflags/efer to the paging mode. Signed-off-by: Paolo Bonzini ---

[PULL 31/33] qemu-option: support accept-any QemuOptsList in qemu_opts_absorb_qdict

2021-05-11 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- util/qemu-option.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/util/qemu-option.c b/util/qemu-option.c index 9678d5b682..4944015a25 100644 --- a/util/qemu-option.c +++ b/util/qemu-option.c @@ -1056,7 +1056,8 @@ bool

[PULL 21/33] accel: add init_accel_cpu for adapting accel behavior to CPU type

2021-05-11 Thread Paolo Bonzini
From: Claudio Fontana while on x86 all CPU classes can use the same set of TCGCPUOps, on ARM the right accel behavior depends on the type of the CPU. So we need a way to specialize the accel behavior according to the CPU. Therefore, add a second initialization, after the

[PULL 26/33] target/i386: extend pg_mode to more CR0 and CR4 bits

2021-05-11 Thread Paolo Bonzini
In order to unify the two stages of page table lookup, we need mmu_translate to use either the host CR0/EFER/CR4 or the guest's. To do so, make mmu_translate use the same pg_mode constants that were used for the NPT lookup. This also prepares for adding 5-level NPT support, which however does not

[PATCH v3 04/20] virtio-gpu: Add virtio_gpu_find_check_resource

2021-05-11 Thread Vivek Kasireddy
Move finding the resource and validating its backing storage into one function. Based-on-patch-by: Gerd Hoffmann Cc: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- hw/display/virtio-gpu.c | 66 + 1 file changed, 47 insertions(+), 19 deletions(-) diff

[PATCH v3 10/20] virtio-gpu: Add helpers to create and destroy dmabuf objects

2021-05-11 Thread Vivek Kasireddy
These helpers can be useful for creating dmabuf objects from blobs and submitting them to the UI. Cc: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- hw/display/virtio-gpu-udmabuf.c | 74 + include/hw/virtio/virtio-gpu.h | 15 +++ 2 files changed, 89

[PATCH v3 05/20] virtio-gpu: Refactor virtio_gpu_set_scanout

2021-05-11 Thread Vivek Kasireddy
Store the meta-data associated with a FB in a new object (struct virtio_gpu_framebuffer) and pass the object to set_scanout. Also move code in set_scanout into a do_set_scanout function. This will be helpful when adding set_scanout_blob API. Based-on-patch-by: Gerd Hoffmann Cc: Gerd Hoffmann

Re: [PATCH 5/6] co-shared-resource: protect with a mutex

2021-05-11 Thread Paolo Bonzini
On 10/05/21 13:40, Vladimir Sementsov-Ogievskiy wrote: co-shared-resource is currently not thread-safe, as also reported in co-shared-resource.h. Add a QemuMutex because co_try_get_from_shres can also be invoked from non-coroutine context. But it doesn't. It's called only from

[PATCH v3 19/20] ui/gtk: Create a common release_dmabuf helper

2021-05-11 Thread Vivek Kasireddy
Since the texture release mechanism is same for both gtk-egl and gtk-glarea, move the helper from gtk-egl into common gtk area so that it can be shared by both gtk backends. Cc: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- include/ui/gtk.h | 2 -- ui/gtk-egl.c | 8 ui/gtk.c

[PATCH v3 08/20] virtio-gpu: Add virtio_gpu_resource_create_blob

2021-05-11 Thread Vivek Kasireddy
This API allows Qemu to register the blob allocated by the Guest as a new resource and map its backing storage. Based-on-patch-by: Gerd Hoffmann Cc: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- hw/display/trace-events | 1 + hw/display/virtio-gpu-udmabuf.c | 4 ++

Re: [PATCH v2] block: Improve backing file validation

2021-05-11 Thread Daniel P . Berrangé
On Tue, May 11, 2021 at 01:55:18PM +0800, Li Zhijian wrote: > Image below user cases: > case 1: > ``` > $ qemu-img create -f raw source.raw 1G > $ qemu-img create -f qcow2 -F raw -b source.raw ./source.raw > qemu-img info source.raw > image: source.raw > file format: qcow2 > virtual size: 193K

[Bug 1892604] Re: qemu-system-arm: ../hw/usb/hcd-dwc2.c:666: dwc2_glbreg_read: Assertion `addr <= GINTSTS2' failed.

2021-05-11 Thread Philippe Mathieu-Daudé
Fixed in commit 69958d8a3d9 ("usb: hcd-dwc2: change assert()s to qemu_log_mask(LOG_GUEST_ERROR...)") ** Changed in: qemu Status: Incomplete => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [PULL 30/33] migration: do not restart VM after successful snapshot-load

2021-05-11 Thread Daniel P . Berrangé
On Tue, May 11, 2021 at 04:13:47AM -0400, Paolo Bonzini wrote: > The HMP loadvm code is calling load_snapshot rather than > qmp_snapshot_load, in order to bypass the job infrastructure. The code > around it is almost the same, with one difference: hmp_loadvm is > restarting the VM if

Re: [PATCH v6 08/82] target/arm: Implement SVE2 integer pairwise arithmetic

2021-05-11 Thread Peter Maydell
On Fri, 30 Apr 2021 at 21:33, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > v2: Load all inputs before writing any output (laurent desnogues) > --- > target/arm/helper-sve.h| 45 ++ > target/arm/sve.decode | 8 > target/arm/sve_helper.c

Re: [PATCH v4 0/2] Some modification about ram_save_host_page()

2021-05-11 Thread Dr. David Alan Gilbert
* Kunkun Jiang (jiangkun...@huawei.com) wrote: > Hi all, Queued; sorry for the delay > This series include patches as below: > Patch 1: > - reduce unnecessary rate limiting in ram_save_host_page() > > Patch 2: > - optimized ram_save_host_page() by using migration_bitmap_find_dirty() to > find

[PULL v3 16/42] hw/riscv: Enable VIRTIO_VGA for RISC-V virt machine

2021-05-11 Thread Alistair Francis
imply VIRTIO_VGA for the virt machine, this fixes the following error when specifying `-vga virtio` as a command line argument: qemu-system-riscv64: Virtio VGA not available Signed-off-by: Alistair Francis Reviewed-by: Bin Meng Message-id:

[PATCH] Constify bitmask_transtbl fcntl/mmap flags_tlb[]

2021-05-11 Thread Philippe Mathieu-Daudé
Keep bitmask_transtbl in .rodata by marking the arrays const. Signed-off-by: Philippe Mathieu-Daudé --- linux-user/syscall.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 95d79ddc437..64f486743a9 100644 ---

[PULL v3 25/42] target/riscv: Add a config option for ePMP

2021-05-11 Thread Alistair Francis
From: Hou Weiying Add a config option to enable experimental support for ePMP. This is disabled by default and can be enabled with 'x-epmp=true'. Signed-off-by: Hongzheng-Li Signed-off-by: Hou Weiying Signed-off-by: Myriad-Dreamin Signed-off-by: Alistair Francis Reviewed-by: Bin Meng

Re: [PATCH 17/72] softfloat: Use pointers with parts_default_nan

2021-05-11 Thread David Hildenbrand
On 08.05.21 03:47, Richard Henderson wrote: At the same time, rename to parts64_default_nan and define a macro for parts_default_nan using QEMU_GENERIC. All I can spot is "#define parts_default_nan parts64_default_nan" -- what am I missing? apart from that Reviewed-by: David Hildenbrand

[PULL v3 31/42] fpu/softfloat: set invalid excp flag for RISC-V muladd instructions

2021-05-11 Thread Alistair Francis
From: Frank Chang In IEEE 754-2008 spec: Invalid operation exception is signaled when doing: fusedMultiplyAdd(0, Inf, c) or fusedMultiplyAdd(Inf, 0, c) unless c is a quiet NaN; if c is a quiet NaN then it is implementation defined whether the invalid operation exception is signaled.

[PATCH 2/3] virtio-blk: Constify VirtIOFeature feature_sizes[]

2021-05-11 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/block/virtio-blk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c index d28979efb8d..f139cd7cc9c 100644 --- a/hw/block/virtio-blk.c +++ b/hw/block/virtio-blk.c @@ -40,7 +40,7 @@ *

[PULL 12/33] i386: split misc helper user stubs and sysemu part

2021-05-11 Thread Paolo Bonzini
From: Claudio Fontana Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson [claudio]: Rebased on da3f3b02("target/i386: fail if toggling LA57 in 64-bitmode") Signed-off-by: Claudio Fontana Message-Id: <20210322132800.7470-15-cfont...@suse.de> Signed-off-by: Paolo Bonzini ---

[PULL 11/33] i386: move TCG bpt_helper into sysemu/

2021-05-11 Thread Paolo Bonzini
From: Claudio Fontana for user-mode, assert that the hidden IOBPT flags are not set while attempting to generate io_bpt helpers. Signed-off-by: Claudio Fontana Cc: Paolo Bonzini Reviewed-by: Richard Henderson Message-Id: <20210322132800.7470-14-cfont...@suse.de> Signed-off-by: Paolo Bonzini

[PULL 33/33] coverity-scan: list components, move model to scripts/coverity-scan

2021-05-11 Thread Paolo Bonzini
Place all files that can be useful to rebuild the Coverity configuration in scripts/coverity-scan: the existing model file, and the components setup. The Markdown syntax was tested with Pandoc (but in any case is meant more as a human-readable reference than as a part of documentation).

  1   2   3   4   5   6   >