Re: Failing iotest 206

2021-07-20 Thread Thomas Huth
On 20/07/2021 03.12, Eric Blake wrote: On Mon, Jul 19, 2021 at 10:06:01AM +0200, Thomas Huth wrote: Hi, iotest 206 fails for me with: --- 206.out +++ 206.out.bad @@ -99,55 +99,19 @@ {"execute": "blockdev-create", "arguments": {"job-id": "job0", "options": {"driver": "qcow2",

Re: [PATCH v1 2/9] s390x: toplogy: adding drawers and books to smp parsing

2021-07-20 Thread Cornelia Huck
On Tue, Jul 20 2021, Pierre Morel wrote: > On 7/19/21 5:50 PM, Cornelia Huck wrote: >> On Fri, Jul 16 2021, Daniel P. Berrangé wrote: >>> Is the book/drawer thing architecture specific, or is it machine >>> type / CPU specific. ie do /all/ the s390x machine types / CPUS >>> QEMU support the

Re: [PATCH] io_uring: move LuringState typedef to block/aio.h

2021-07-20 Thread Stefano Garzarella
On Mon, Jul 12, 2021 at 03:10:30PM +0200, Paolo Bonzini wrote: The LuringState typedef is defined twice, in include/block/raw-aio.h and block/io_uring.c. Move it in include/block/aio.h, which is included everywhere the typedef is needed, since include/block/aio.h already has to define the

Re: Error in accel/tcg?

2021-07-20 Thread Peter Maydell
On Mon, 19 Jul 2021 at 23:20, Kenneth Adam Miller wrote: > > Hello, > > I get the following error: > > -c ../accel/tcg/cputlb.c > ../qemu/accel/tcg/cputlb.c: In function 'tlb_flush_page_by_mmuidx': > ../qemu/accel/tcg/cputlb.c:602:23: error: comparison is always true due to > limited range of

Re: Failing iotest 206

2021-07-20 Thread Daniel P . Berrangé
On Mon, Jul 19, 2021 at 08:12:58PM -0500, Eric Blake wrote: > On Mon, Jul 19, 2021 at 10:06:01AM +0200, Thomas Huth wrote: > > Hi, > > > > iotest 206 fails for me with: > > > > > --- 206.out > > +++ 206.out.bad > > @@ -99,55 +99,19 @@ > > > > {"execute": "blockdev-create", "arguments":

Re: [PATCH v1 1/2] hw/tricore: fix inclusion of tricore_testboard

2021-07-20 Thread Peter Maydell
On Tue, 20 Jul 2021 at 10:47, Alex Bennée wrote: > > > Peter Maydell writes: > > > On Mon, 19 Jul 2021 at 20:52, Alex Bennée wrote: > >> > >> We inadvertently added a symbol clash causing the build not to include > >> the testboard needed for check-tcg. > >> > >> Fixes: f4063f9c31 ("meson:

Re: [PATCH for-6.2 17/34] target/arm: Implement MVE VMLAS

2021-07-20 Thread Peter Maydell
On Sat, 17 Jul 2021 at 21:40, Richard Henderson wrote: > > On 7/17/21 3:06 AM, Peter Maydell wrote: > > On Fri, 16 Jul 2021 at 23:12, Richard Henderson > > wrote: > >> > >> On 7/13/21 6:37 AM, Peter Maydell wrote: > >>> Implement the MVE VMLAS insn, which multiplies a vector by a vector > >>>

Re: random crash in migration-test, i386 guest, x86-64 host:

2021-07-20 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Mon, 19 Jul 2021 at 13:43, Peter Maydell wrote: > > > > Random crash in migration-tests: > > > > MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} > > QTEST_QEMU_IMG=./qemu-img G_TEST_DBUS_DAEMON=/mnt/nvmedisk/linaro/qem > >

Re: [PATCH v1 1/9] s390x: smp: s390x dedicated smp parsing

2021-07-20 Thread Pierre Morel
On 7/19/21 5:52 PM, Daniel P. Berrangé wrote: On Mon, Jul 19, 2021 at 05:43:29PM +0200, Cornelia Huck wrote: (restored cc:s) On Fri, Jul 16 2021, Pierre Morel wrote: On 7/16/21 11:14 AM, Daniel P. Berrangé wrote: I increasingly worry that we're making a mistake by going down the route

Re: [PATCH v1 2/9] s390x: toplogy: adding drawers and books to smp parsing

2021-07-20 Thread Pierre Morel
On 7/20/21 10:20 AM, Cornelia Huck wrote: On Tue, Jul 20 2021, Pierre Morel wrote: On 7/19/21 5:50 PM, Cornelia Huck wrote: On Fri, Jul 16 2021, Daniel P. Berrangé wrote: Is the book/drawer thing architecture specific, or is it machine type / CPU specific. ie do /all/ the s390x machine

Re: [PATCH 5/6] tests/acceptance/virtio-gpu.py: use virtio-vga-gl

2021-07-20 Thread Marc-André Lureau
On Wed, Jul 14, 2021 at 9:47 PM Cleber Rosa wrote: > Since 49afbca3b, the use of an optional virgl renderer is not > available anymore, and since b36eb8860f, the way to choose a GL based > rendered is to use the "virtio-vga-gl" device. > > Signed-off-by: Cleber Rosa > Reviewed-by: Marc-André

Re: [PATCH v2 2/2] gitlab: enable a very minimal build with the tricore container

2021-07-20 Thread Alex Bennée
Richard Henderson writes: > On 7/19/21 11:48 AM, Alex Bennée wrote: >> diff --git a/tests/docker/dockerfiles/debian-tricore-cross.docker >> b/tests/docker/dockerfiles/debian-tricore-cross.docker >> index 985925134c..4ea9112289 100644 >> ---

Re: [PATCH v1 1/2] hw/tricore: fix inclusion of tricore_testboard

2021-07-20 Thread Alex Bennée
Peter Maydell writes: > On Tue, 20 Jul 2021 at 10:47, Alex Bennée wrote: >> >> >> Peter Maydell writes: >> >> > On Mon, 19 Jul 2021 at 20:52, Alex Bennée wrote: >> >> >> >> We inadvertently added a symbol clash causing the build not to include >> >> the testboard needed for check-tcg. >> >>

Re: [PATCH v1 1/9] s390x: smp: s390x dedicated smp parsing

2021-07-20 Thread Pierre Morel
On 7/20/21 9:37 AM, Pierre Morel wrote: On 7/19/21 5:52 PM, Daniel P. Berrangé wrote: On Mon, Jul 19, 2021 at 05:43:29PM +0200, Cornelia Huck wrote: (restored cc:s) On Fri, Jul 16 2021, Pierre Morel wrote: On 7/16/21 11:14 AM, Daniel P. Berrangé wrote: I increasingly worry that we're

Re: [PULL 0/6] Block patches for 6.1-rc0

2021-07-20 Thread Peter Maydell
On Mon, 19 Jul 2021 at 18:27, Max Reitz wrote: > > The following changes since commit 7457b407edd6e8555e4b46488aab2f13959fccf8: > > Merge remote-tracking branch > 'remotes/thuth-gitlab/tags/pull-request-2021-07-19' into staging (2021-07-19 > 11:34:08 +0100) > > are available in the Git

Re: [PATCH v1 1/2] hw/tricore: fix inclusion of tricore_testboard

2021-07-20 Thread Alex Bennée
Peter Maydell writes: > On Mon, 19 Jul 2021 at 20:52, Alex Bennée wrote: >> >> We inadvertently added a symbol clash causing the build not to include >> the testboard needed for check-tcg. >> >> Fixes: f4063f9c31 ("meson: Introduce target-specific Kconfig") >> Signed-off-by: Alex Bennée >>

Re: [PATCH 3/3] linux-aio: limit the batch size using `aio-max-batch` parameter

2021-07-20 Thread Stefan Hajnoczi
On Mon, Jul 19, 2021 at 12:35:53PM +0200, Stefano Garzarella wrote: > On Tue, Jul 13, 2021 at 03:58:04PM +0100, Stefan Hajnoczi wrote: > > On Wed, Jul 07, 2021 at 05:00:19PM +0200, Stefano Garzarella wrote: > > > @@ -371,7 +375,7 @@ static int laio_do_submit(int fd, struct qemu_laiocb > > >

Re: [PATCH v3 0/3] vhost-user: warn when guest RAM is not shared

2021-07-20 Thread Kevin Wolf
Am 14.07.2021 um 11:29 hat Stefan Hajnoczi geschrieben: > v3: > * Rebased > v2: > * Clarify that object-memory-memfd enables share=on by default [Marc-André] > * Rebased > > vhost-user requires -object memory-backend-*,share=on option so that QEMU uses > mmap(MAP_SHARED) on guest RAM that is

Re: [PATCH v1 2/9] s390x: toplogy: adding drawers and books to smp parsing

2021-07-20 Thread Pierre Morel
On 7/19/21 5:50 PM, Cornelia Huck wrote: On Fri, Jul 16 2021, Daniel P. Berrangé wrote: On Fri, Jul 16, 2021 at 12:44:49PM +0200, Cornelia Huck wrote: On Fri, Jul 16 2021, Daniel P. Berrangé wrote: On Fri, Jul 16, 2021 at 11:10:04AM +0200, Cornelia Huck wrote: On Thu, Jul 15 2021,

[RFC] Rust vhost-user-scsi implementation

2021-07-20 Thread Gaelan Steele
Hi all, I've been working as one of QEMU's Google Summer of Code interns to implement a vhost-user-scsi daemon in Rust. That work's now reached a point where it's usable to attach read-only raw disk images to a VM, and I'd like to get some feedback from the QEMU community, especially anyone with

Re: random crash in migration-test, i386 guest, x86-64 host:

2021-07-20 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Mon, 19 Jul 2021 at 13:43, Peter Maydell wrote: > > > > Random crash in migration-tests: > > > > MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} > > QTEST_QEMU_IMG=./qemu-img G_TEST_DBUS_DAEMON=/mnt/nvmedisk/linaro/qem > >

Re: [PATCH v1 2/9] s390x: toplogy: adding drawers and books to smp parsing

2021-07-20 Thread Cornelia Huck
On Tue, Jul 20 2021, Pierre Morel wrote: > On 7/20/21 10:20 AM, Cornelia Huck wrote: >> On Tue, Jul 20 2021, Pierre Morel wrote: >> >>> On 7/19/21 5:50 PM, Cornelia Huck wrote: On Fri, Jul 16 2021, Daniel P. Berrangé wrote: > Is the book/drawer thing architecture specific, or is it

Re: [PATCH 0/4] Add support for Fujitsu A64FX processor

2021-07-20 Thread Peter Maydell
On Tue, 20 Jul 2021 at 08:35, ishii.shuuic...@fujitsu.com wrote: > > Hi, peter > Thank you for your comment. > > > Hi; it looks like something with your outgoing email setup still disagrees > > with QEMU's mailing list server :-( As far as I can tell these emails > > didn't > > make it to the

Re: [PATCH v1 1/2] hw/tricore: fix inclusion of tricore_testboard

2021-07-20 Thread Alex Bennée
Alex Bennée writes: > Peter Maydell writes: > >> On Tue, 20 Jul 2021 at 10:47, Alex Bennée wrote: >>> >>> >>> Peter Maydell writes: >>> >>> > On Mon, 19 Jul 2021 at 20:52, Alex Bennée wrote: >>> >> >>> >> We inadvertently added a symbol clash causing the build not to include >>> >> the

Re: [PATCH v1 2/9] s390x: toplogy: adding drawers and books to smp parsing

2021-07-20 Thread Daniel P . Berrangé
On Tue, Jul 20, 2021 at 10:46:31AM +0200, Pierre Morel wrote: > > > On 7/20/21 10:20 AM, Cornelia Huck wrote: > > On Tue, Jul 20 2021, Pierre Morel wrote: > > > > > On 7/19/21 5:50 PM, Cornelia Huck wrote: > > > > On Fri, Jul 16 2021, Daniel P. Berrangé wrote: > > > > > Is the book/drawer

RE: [PATCH 0/4] Add support for Fujitsu A64FX processor

2021-07-20 Thread ishii.shuuic...@fujitsu.com
Hi, peter Thank you for your comment. > Hi; it looks like something with your outgoing email setup still disagrees > with QEMU's mailing list server :-( As far as I can tell these emails didn't > make it to the list, so only people on the direct-cc list will have > seen them :-( As you said, it

Re: [PATCH] tests/qtest/migration-test.c: use 127.0.0.1 instead of 0

2021-07-20 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > OpenBSD doesn't like :0 as an address, switch to using 127.0.0.1 > in baddest; it's really testing the :0 port number that isn't allowed > on anything. > > (The test doesn't currently run anyway because of the userfault >

Re: [PATCH 0/4] Add support for Fujitsu A64FX processor

2021-07-20 Thread Philippe Mathieu-Daudé
Hi Ishii, On 7/20/21 9:34 AM, ishii.shuuic...@fujitsu.com wrote: > Hi, peter > Thank you for your comment. > >> Hi; it looks like something with your outgoing email setup still disagrees >> with QEMU's mailing list server :-( As far as I can tell these emails didn't >> make it to the list, so

Re: [PATCH v2 2/2] hw/registerfields: Use 64-bit bitfield for FIELD_DP64

2021-07-20 Thread Philippe Mathieu-Daudé
On 7/20/21 12:02 AM, Joe Komlodi wrote: > If we have a field that's wider than 32-bits, we need a data type wide enough > to > be able to create the bitfield used to deposit the value. > > Signed-off-by: Joe Komlodi > --- > include/hw/registerfields.h | 2 +- > 1 file changed, 1 insertion(+),

[PATCH v6 01/12] target/hexagon: update MAINTAINERS for idef-parser

2021-07-20 Thread Alessandro Di Federico via
From: Alessandro Di Federico Signed-off-by: Alessandro Di Federico Reviewed-by: Richard Henderson --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4256ad1adb..6c825a9eb4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -194,6 +194,8 @@

[PATCH v6 05/12] target/hexagon: introduce new helper functions

2021-07-20 Thread Alessandro Di Federico via
From: Niccolò Izzo These helpers will be employed by the idef-parser generated code. Signed-off-by: Alessandro Di Federico Signed-off-by: Niccolò Izzo --- target/hexagon/genptr.h | 15 +- target/hexagon/macros.h | 9 target/hexagon/genptr.c | 113

[PATCH v6 03/12] target/hexagon: make slot number an unsigned

2021-07-20 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel Acked-by: Richard Henderson --- target/hexagon/macros.h | 2 +- target/hexagon/genptr.c | 24 +--- 2 files changed, 14 insertions(+), 12 deletions(-) diff --git

[PATCH v6 06/12] target/hexagon: expose next PC in DisasContext

2021-07-20 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel Reviewed-by: Richard Henderson Reviewed-by: Taylor Simpson --- target/hexagon/translate.h | 1 + target/hexagon/translate.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH v6 10/12] target/hexagon: call idef-parser functions

2021-07-20 Thread Alessandro Di Federico via
From: Alessandro Di Federico Extend gen_tcg_funcs.py in order to emit calls to the functions emitted by the idef-parser, if available. Signed-off-by: Alessandro Di Federico Reviewed-by: Taylor Simpson --- target/hexagon/gen_helper_funcs.py | 5 +- target/hexagon/gen_helper_protos.py | 5

[PATCH v6 08/12] target/hexagon: import lexer for idef-parser

2021-07-20 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/idef-parser/idef-parser.h | 258 +++ target/hexagon/idef-parser/idef-parser.lex| 642 ++ target/hexagon/meson.build| 4 +

[PATCH 06/16] i386: Never free migration blocker objects instead of sometimes

2021-07-20 Thread Markus Armbruster
invtsc_mig_blocker has static storage duration. When a CPU with certain features is initialized, and invtsc_mig_blocker is still null, we add a migration blocker and store it in invtsc_mig_blocker. The object is freed when migrate_add_blocker() fails, leaving invtsc_mig_blocker dangling. It is

[PATCH 09/16] migration: Unify failure check for migrate_add_blocker()

2021-07-20 Thread Markus Armbruster
Most callers check the return value. Some check whether it set an error. Functionally equivalent, but the former tends to be easier on the eyes, so do that everywhere. Prior art: commit c6ecec43b2 "qemu-option: Check return value instead of @err where convenient". Signed-off-by: Markus

[PATCH 16/16] vl: Don't continue after -smp help.

2021-07-20 Thread Markus Armbruster
We continue after -smp help: $ qemu-system-x86_64 -smp help -display none -monitor stdio smp-opts options: cores= cpus= dies= maxcpus= sockets= threads= QEMU 6.0.50 monitor - type 'help' for more information (qemu) Other options, such as

[PATCH 00/16] Various error handling fixes and cleanups

2021-07-20 Thread Markus Armbruster
I doubt the fixes are 6.1 material at this late stage. If you disagree, let me know. Cc: Alex Williamson Cc: Aravinda Prasad Cc: Cornelia Huck Cc: Daniel P. Berrangé Cc: David Gibson Cc: Dr. David Alan Gilbert Cc: Eduardo Habkost Cc: Elena Ufimtseva Cc: Ganesh Goudar Cc: Gerd Hoffmann

[PATCH resend v2 0/5] softmmu/memory_mapping: optimize dump/tpm for virtio-mem

2021-07-20 Thread David Hildenbrand
This is a resend of v2, now that RamDiscardManager is upstream. I retested dumping with virtio-mem on shmem and it works as expected now. --- Minor fixes and cleanups, followed by an optimization for virtio-mem regarding guest dumps and tpm. virtio-mem logically plugs/unplugs memory within a

Re: [PATCH v6 2/2] tests/tcg/s390x: Test SIGILL and SIGSEGV handling

2021-07-20 Thread jonathan.albrecht
Ping. Could this patch be reviewed? The other code fix patch in this series has been reviewed so if these tests can be reviewed then both this series: https://lore.kernel.org/qemu-devel/20210705210434.45824-1-...@linux.ibm.com/ and the dependent series:

[PATCH v2 03/17] iotests: drop qemu_img_verbose() helper

2021-07-20 Thread Vladimir Sementsov-Ogievskiy
qemu_img_verbose() has a drawback of not going through generic qemu_img_pipe_and_status(). qemu_img_verbose() is not very popular, so update the only two users to qemu_img_log() and drop qemu_img_verbose() at all. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/044| 5

[PATCH v2 06/17] iotest 065: explicit compression type

2021-07-20 Thread Vladimir Sementsov-Ogievskiy
The test checks different options. It of course fails if set IMGOPTS='compression_type=zstd'. So, let's be explicit in what compression type we want and independent of IMGOPTS. Test both existing compression types. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/065 | 16

[PATCH v2 02/17] iotests.py: qemu_img*("create"): support IMGOPTS='compression_type=zstd'

2021-07-20 Thread Vladimir Sementsov-Ogievskiy
Adding support of IMGOPTS (like in bash tests) allows user to pass a lot of different options. Still, some may require additional logic. Now we want compression_type option, so add some smart logic around it: ignore compression_type=zstd in IMGOPTS, if test want qcow2 in compatibility mode. As

[PATCH v2 12/17] iotests: massive use _qcow2_dump_header

2021-07-20 Thread Vladimir Sementsov-Ogievskiy
We are going to add filtering in _qcow2_dump_header and want all tests use it. The patch is generated by commands: cd tests/qemu-iotests sed -ie 's/$PYTHON qcow2.py "$TEST_IMG" dump-header\($\| \)/_qcow2_dump_header\1/' ??? tests/* (the difficulty is to avoid converting dump-header-exts)

[PATCH v3 1/3] hw/tricore: fix inclusion of tricore_testboard

2021-07-20 Thread Alex Bennée
We inadvertently added a symbol clash causing the build not to include the testboard needed for check-tcg. Fixes: f4063f9c31 ("meson: Introduce target-specific Kconfig") Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée

Re: [PATCH for-6.1 v5 03/15] target/alpha: Drop goto_tb path in gen_call_pal

2021-07-20 Thread Philippe Mathieu-Daudé
On 7/20/21 3:17 AM, Richard Henderson wrote: > We are certain of a page crossing here, entering the > PALcode image, so the call to use_goto_tb that should > have been here will never succeed. > > We are shortly going to add an assert to tcg_gen_goto_tb > that would trigger for this case. > >

Re: [PATCH for-6.1 v5 14/15] accel/tcg: Hoist tb_cflags to a local in translator_loop

2021-07-20 Thread Philippe Mathieu-Daudé
On 7/20/21 3:17 AM, Richard Henderson wrote: > The access internal to tb_cflags() is atomic. > Avoid re-reading it as such for the multiple uses. > > Reviewed-by: Alex Bennée > Signed-off-by: Richard Henderson > --- > accel/tcg/translator.c | 9 - > 1 file changed, 4 insertions(+), 5

Re: [PATCH RFC server 01/11] vfio-user: build library

2021-07-20 Thread Marc-André Lureau
Hi On Tue, Jul 20, 2021 at 4:12 PM Jag Raman wrote: > > > > On Jul 19, 2021, at 4:24 PM, John Levon wrote: > > > > On Mon, Jul 19, 2021 at 04:00:03PM -0400, Jagannathan Raman wrote: > > > >> add the libvfio-user library as a submodule. build it as part of QEMU > >> > >> diff --git

[PATCH v6 12/12] gitlab-ci: do not use qemu-project Docker registry

2021-07-20 Thread Alessandro Di Federico via
From: Alessandro Di Federico This commit is necessary in order to use container built by the current run of the CI. If we don't do this, we use official containers which are not affected by the additional dependencies we're introducing. This should be considered as a temporary solution in order

[PATCH 04/16] multi-process: Fix pci_proxy_dev_realize() error handling

2021-07-20 Thread Markus Armbruster
The Error ** argument must be NULL, _abort, _fatal, or a pointer to a variable containing NULL. Passing an argument of the latter kind twice without clearing it in between is wrong: if the first call sets an error, it no longer points to NULL for the second call. pci_proxy_dev_realize() is wrong

[PATCH resend v2 1/5] tpm: mark correct memory region range dirty when clearing RAM

2021-07-20 Thread David Hildenbrand
We might not start at the beginning of the memory region. We could also calculate via the difference in the host address; however, memory_region_set_dirty() also relies on memory_region_get_ram_addr() internally, so let's just use that. Acked-by: Stefan Berger Fixes: ffab1be70692 ("tpm: clear

Re: [PATCH v5 07/10] ACPI ERST: trace support

2021-07-20 Thread Igor Mammedov
On Wed, 30 Jun 2021 15:07:18 -0400 Eric DeVolder wrote: > Provide the definitions needed to support tracing in ACPI ERST. trace points should be introduced in patches that use them for the first time, as it stands now series breaks bisection. > > Signed-off-by: Eric DeVolder > --- >

Re: [PATCH resend v2 4/5] softmmu/memory_mapping: factor out adding physical memory ranges

2021-07-20 Thread Stefan Berger
On 7/20/21 9:03 AM, David Hildenbrand wrote: Let's factor out adding a MemoryRegionSection to the list, to be reused in RamDiscardManager context next. Cc: Marc-André Lureau Cc: Paolo Bonzini Cc: "Michael S. Tsirkin" Cc: Eduardo Habkost Cc: Alex Williamson Cc: Dr. David Alan Gilbert Cc:

[PATCH] block: drop BLK_PERM_GRAPH_MOD

2021-07-20 Thread Vladimir Sementsov-Ogievskiy
First, this permission never protected node from being changed, as generic child-replacing functions don't check it. Second, it's a strange thing: it presents a permission of parent node to change its child. But generally, children are replaced by different mechanisms, like jobs or qmp commands,

Re: [PATCH v1 3/3] util/oslib-posix: Support concurrent os_mem_prealloc() invocation

2021-07-20 Thread Daniel P . Berrangé
On Wed, Jul 14, 2021 at 01:23:06PM +0200, David Hildenbrand wrote: > Add a mutext to protect the SIGBUS case, as we cannot mess concurrently typo s/mutext/mutex/ > with the sigbus handler and we have to manage the global variable > sigbus_memset_context. The MADV_POPULATE_WRITE path can run >

[PATCH v2 07/17] iotests.py: filter out successful output of qemu-img crate

2021-07-20 Thread Vladimir Sementsov-Ogievskiy
The only "feature" of this "Formatting ..." line is that we have to update it every time we add new option. Let's drop it. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/255.out| 4 tests/qemu-iotests/274.out| 29 -

[PATCH v3 3/3] gitlab: enable a very minimal build with the tricore container

2021-07-20 Thread Alex Bennée
Rather than base of the shared Debian 10 container which would require us to bring in even more dependencies just bring in what is needed for building tricore-softmmu in GitLab. We don't even remove the container from the DOCKER_PARTIAL_IMAGES lest we cause more confusion. Signed-off-by: Alex

Re: [PATCH 0/6] plugins/cache: multicore cache emulation and minor

2021-07-20 Thread Alex Bennée
Mahmoud Mandour writes: > Hello, > > This series introduce some minor improvements/bug fixes in the cache > plugins and multicore cache modelling. Queued patches 1,2 and 6 for-6.1/fixes-for-rc1 as they are bug fixes, thanks. -- Alex Bennée

Re: [RFC] Rust vhost-user-scsi implementation

2021-07-20 Thread Alex Bennée
Gaelan Steele writes: > Hi all, > > I've been working as one of QEMU's Google Summer of Code interns to > implement a vhost-user-scsi daemon in Rust. That work's now reached a > point where it's usable to attach read-only raw disk images to a VM, > and I'd like to get some feedback from the

[PATCH 12/16] vhost: Clean up how VhostOpts method vhost_get_config() fails

2021-07-20 Thread Markus Armbruster
vhost_user_get_config() can fail without setting an error. Unclean. Its caller vhost_dev_get_config() compensates by substituting a generic error then. Goes back to commit 50de51387f "vhost: Distinguish errors in vhost_dev_get_config()". Clean up by moving the generic error from

[PATCH 11/16] microvm: Drop dead error handling in microvm_machine_state_init()

2021-07-20 Thread Markus Armbruster
Stillborn in commit 0ebf007dda "hw/i386: Introduce the microvm machine type". Cc: Sergio Lopez Signed-off-by: Markus Armbruster --- hw/i386/microvm.c | 5 - 1 file changed, 5 deletions(-) diff --git a/hw/i386/microvm.c b/hw/i386/microvm.c index aba0c83219..f257ec5a0b 100644 ---

[PATCH 14/16] Remove superfluous ERRP_GUARD()

2021-07-20 Thread Markus Armbruster
Macro ERRP_GUARD() is only needed when we want to dereference @errp or pass it to error_prepend() or error_append_hint(). Delete superfluous ones. Signed-off-by: Markus Armbruster --- hw/remote/mpqemu-link.c | 3 --- qga/commands-posix-ssh.c | 17 - qga/commands-win32.c |

Re: [PATCH v5 06/10] ACPI ERST: build the ACPI ERST table

2021-07-20 Thread Igor Mammedov
On Wed, 30 Jun 2021 15:07:17 -0400 Eric DeVolder wrote: > This code is called from the machine code (if ACPI supported) > to generate the ACPI ERST table. should be along lines: This builds ACPI ERST table /spec ref/ to inform OSMP how to communicate with ... device. > > Signed-off-by: Eric

Re: [PATCH v2 02/21] docs: collect the disparate device emulation docs into one section

2021-07-20 Thread Markus Armbruster
Alex Bennée writes: > Markus Armbruster writes: > >> Cc: QOM maintainers for additional eyes. >> >> Alex Bennée writes: >> >>> While we are at it add a brief preamble that explains some of the >>> common concepts in QEMU's device emulation which will hopefully lead >>> to less confusing about

Re: [PATCH resend v2 3/5] softmmu/memory_mapping: never merge ranges accross memory regions

2021-07-20 Thread Stefan Berger
On 7/20/21 9:03 AM, David Hildenbrand wrote: Let's make sure to not merge when different memory regions are involved. Unlikely, but theoretically possible. Cc: Marc-André Lureau Cc: Paolo Bonzini Cc: "Michael S. Tsirkin" Cc: Eduardo Habkost Cc: Alex Williamson Cc: Dr. David Alan Gilbert

Re: [PATCH] mips/tlb_helper: Add support for 'info tlb' cmd

2021-07-20 Thread Peter Maydell
On Tue, 20 Jul 2021 at 13:10, Arkadiy wrote: > > From: NDNF > > This adds hmp 'info tlb' command support for the mips platform. > 1k pages are not supported. > > Signed-off-by: NDNF Hi; for QEMU contributions we request that the signed-off-by line is your real name, not a pseudonym; we follow

Re: [PATCH 1/2] ui/gtk: detach_all option for making all VCs detached upon starting

2021-07-20 Thread Thomas Huth
On 19/07/2021 23.41, Dongwon Kim wrote: With "detach-all=on" for display, all VCs are detached from the beginning. This is useful when there are multiple displays assigned to a guest OS. Can you elaborate? (i.e. why is it useful? Do you just want to avoid having multiple things opened at

Re: [PATCH 01/16] error: Use error_fatal to simplify obvious fatal errors (again)

2021-07-20 Thread Eric Blake
On Tue, Jul 20, 2021 at 02:53:53PM +0200, Markus Armbruster wrote: > We did this with scripts/coccinelle/use-error_fatal.cocci before, in > commit 50beeb68094 and 007b06578ab. This commit cleans up rarer > variations that don't seem worth matching with Coccinelle. > > Cc: Thomas Huth > Cc:

Re: [PATCH] block: drop BLK_PERM_GRAPH_MOD

2021-07-20 Thread Vladimir Sementsov-Ogievskiy
Forget to mention in subject: for-6.2 20.07.2021 17:22, Vladimir Sementsov-Ogievskiy wrote: First, this permission never protected node from being changed, as generic child-replacing functions don't check it. Second, it's a strange thing: it presents a permission of parent node to change its

[PATCH v2 11/17] iotests/common.rc: introduce _qcow2_dump_header helper

2021-07-20 Thread Vladimir Sementsov-Ogievskiy
We'll use it in tests instead of explicit qcow2.py. Then we are going to add some filtering in _qcow2_dump_header. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- tests/qemu-iotests/common.rc | 10 ++ 1 file changed, 10 insertions(+) diff --git

[PATCH v2 08/17] iotests.py: filter compression type out

2021-07-20 Thread Vladimir Sementsov-Ogievskiy
We want iotests pass with both the default zlib compression and with IMGOPTS='compression_type=zstd'. Actually the only test that is interested in real compression type in test output is 287 (test for qcow2 compression type) and it's in bash. So for now we can safely filter out compression type

Re: [RFC] Rust vhost-user-scsi implementation

2021-07-20 Thread Philippe Mathieu-Daudé
On 7/20/21 11:55 AM, Gaelan Steele wrote: > Hi all, > > I've been working as one of QEMU's Google Summer of Code interns to > implement a vhost-user-scsi daemon in Rust. That work's now reached a > point where it's usable to attach read-only raw disk images to a VM, > and I'd like to get some

[PATCH v2 16/17] iotest 214: explicit compression type

2021-07-20 Thread Vladimir Sementsov-Ogievskiy
The test-case "Corrupted size field in compressed cluster descriptor" heavily depends on zlib compression type. So, make it explicit. This way test passes with IMGOPTS='compression_type=zstd'. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- tests/qemu-iotests/214 | 2 +-

[PATCH v2 15/17] iotests 60: more accurate set dirty bit in qcow2 header

2021-07-20 Thread Vladimir Sementsov-Ogievskiy
Don't touch other incompatible bits, like compression-type. This makes the test pass with IMGOPTS='compression_type=zstd'. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- tests/qemu-iotests/060 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH for 6.1 v3 0/3] tricore fixes

2021-07-20 Thread Alex Bennée
Hi, This fixes check-tcg for tricore and adds a test to the gitlab matrix so we don't miss it breaking again. v3 - added new patch for configure.sh - changed symbol for board The following need review: - gitlab: enable a very minimal build with the tricore container -

[PATCH v6 07/12] target/hexagon: prepare input for the idef-parser

2021-07-20 Thread Alessandro Di Federico via
From: Alessandro Di Federico Introduce infrastructure necessary to produce a file suitable for being parsed by the idef-parser. Signed-off-by: Alessandro Di Federico --- target/hexagon/gen_idef_parser_funcs.py | 114 ++ target/hexagon/idef-parser/macros.inc | 153

[PATCH 10/16] migration: Handle migration_incoming_setup() errors consistently

2021-07-20 Thread Markus Armbruster
Commit b673eab4e2 "multifd: Make multifd_load_setup() get an Error parameter" changed migration_incoming_setup() to take an Error ** argument, and adjusted the callers accordingly. It neglected to change adjust multifd_load_setup(): it still exit()s on error. Clean that up. The error now gets

[PATCH 07/16] vfio: Avoid error_propagate() after migrate_add_blocker()

2021-07-20 Thread Markus Armbruster
When migrate_add_blocker(blocker, ) is followed by error_propagate(errp, err), we can often just as well do migrate_add_blocker(..., errp). This is the case in vfio_migration_probe(). Prior art: commit 386f6c07d2 "error: Avoid error_propagate() after migrate_add_blocker()". Cc: Kirti Wankhede

[PATCH 13/16] vhost: Clean up how VhostOpts method vhost_backend_init() fails

2021-07-20 Thread Markus Armbruster
vhost_user_backend_init() can fail without setting an error. Unclean. Its caller vhost_dev_init() compensates by substituting a generic error then. Goes back to commit 28770ff935 "vhost: Distinguish errors in vhost_backend_init()". Clean up by moving the generic error from vhost_dev_init() to

[PATCH resend v2 3/5] softmmu/memory_mapping: never merge ranges accross memory regions

2021-07-20 Thread David Hildenbrand
Let's make sure to not merge when different memory regions are involved. Unlikely, but theoretically possible. Cc: Marc-André Lureau Cc: Paolo Bonzini Cc: "Michael S. Tsirkin" Cc: Eduardo Habkost Cc: Alex Williamson Cc: Dr. David Alan Gilbert Cc: Igor Mammedov Cc: Claudio Fontana Cc:

Re: [PATCH v5 4/5] hw/nvme: fix mmio read

2021-07-20 Thread Philippe Mathieu-Daudé
On 7/20/21 12:46 AM, Klaus Jensen wrote: > From: Klaus Jensen > > The new PMR test unearthed a long-standing issue with MMIO reads on > big-endian hosts. > > Fix this by unconditionally storing all controller registers in little > endian. > > Cc: Gollu Appalanaidu > Reported-by: Peter Maydell

Re: [PATCH RFC server 01/11] vfio-user: build library

2021-07-20 Thread John Levon
On Tue, Jul 20, 2021 at 04:20:13PM +0400, Marc-André Lureau wrote: > > >> + libvfiouser = static_library('vfiouser', > > >> + build_by_default: false, > > >> + sources: vfiouser_files, > > >> +

Re: [PATCH v5 4/5] hw/nvme: fix mmio read

2021-07-20 Thread Peter Maydell
On Tue, 20 Jul 2021 at 13:58, Philippe Mathieu-Daudé wrote: > > On 7/20/21 12:46 AM, Klaus Jensen wrote: > > From: Klaus Jensen > > > > The new PMR test unearthed a long-standing issue with MMIO reads on > > big-endian hosts. > > > > Fix this by unconditionally storing all controller registers

Re: [PATCH v5 4/5] hw/nvme: fix mmio read

2021-07-20 Thread Peter Maydell
On Mon, 19 Jul 2021 at 23:47, Klaus Jensen wrote: > > From: Klaus Jensen > > The new PMR test unearthed a long-standing issue with MMIO reads on > big-endian hosts. > > Fix this by unconditionally storing all controller registers in little > endian. > > Cc: Gollu Appalanaidu > Reported-by:

Re: [PATCH v1 0/3] util/oslib-posix: Support MADV_POPULATE_WRITE for os_mem_prealloc()

2021-07-20 Thread Pankaj Gupta
> #1 adds support for MADV_POPULATE_WRITE, #2 cleans up the code to avoid > global variables and prepare for concurrency and #3 makes os_mem_prealloc() > safe to be called from multiple threads concurrently. > > Details regarding MADV_POPULATE_WRITE can be found in introducing upstream > Linux

[PATCH v2] target/ppc: Ease L=0 requirement on cmp/cmpi/cmpl/cmpli for ppc32

2021-07-20 Thread matheus . ferst
From: Matheus Ferst In commit 8f0a4b6a9b, we started to require L=0 for ppc32 to match what The Programming Environments Manual say: "For 32-bit implementations, the L field must be cleared, otherwise the instruction form is invalid." The stricter behavior, however, broke AROS boot on

Re: R: R: [PULL 0/3] ppc-for-6.1 queue 20210713

2021-07-20 Thread BALATON Zoltan
Hello, On Tue, 20 Jul 2021, luigi burdo wrote: i was able to build on my quad qemu, a ram bank was die and make me the issue with gcc.. this is what happening if i run pegasos 2 with --enable-kvm. OK. Can you also show the full command so we know what options you used? via_superio_cfg:

[PATCH v2 10/17] qcow2: simple case support for downgrading of qcow2 images with zstd

2021-07-20 Thread Vladimir Sementsov-Ogievskiy
If image doesn't have any compressed cluster we can easily switch to zlib compression, which may allow to downgrade the image. That's mostly needed to support IMGOPTS='compression_type=zstd' in some iotests which do qcow2 downgrade. While being here also fix checkpatch complain against '#' in

[PATCH v2 05/17] iotest 303: explicit compression type

2021-07-20 Thread Vladimir Sementsov-Ogievskiy
The test prints qcow2 header fields which depends on chosen compression type. So, let's be explicit in what compression type we want and independent of IMGOPTS. Test both existing compression types. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- tests/qemu-iotests/303

Re: [PATCH for-6.1 v5 08/15] hw/core: Introduce TCGCPUOps.debug_check_breakpoint

2021-07-20 Thread Philippe Mathieu-Daudé
On 7/20/21 3:17 AM, Richard Henderson wrote: > New hook to return true when an architectural breakpoint is > to be recognized and false when it should be suppressed. > > First use must wait until other pieces are in place. > > Signed-off-by: Richard Henderson > --- >

Re: [PATCH RFC server 01/11] vfio-user: build library

2021-07-20 Thread Jag Raman
> On Jul 19, 2021, at 4:24 PM, John Levon wrote: > > On Mon, Jul 19, 2021 at 04:00:03PM -0400, Jagannathan Raman wrote: > >> add the libvfio-user library as a submodule. build it as part of QEMU >> >> diff --git a/meson.build b/meson.build >> index 6e4d2d8..f2f9f86 100644 >> ---

Re: [PATCH v1 2/9] s390x: toplogy: adding drawers and books to smp parsing

2021-07-20 Thread Pierre Morel
On 7/20/21 11:19 AM, Daniel P. Berrangé wrote: On Tue, Jul 20, 2021 at 10:46:31AM +0200, Pierre Morel wrote: On 7/20/21 10:20 AM, Cornelia Huck wrote: On Tue, Jul 20 2021, Pierre Morel wrote: On 7/19/21 5:50 PM, Cornelia Huck wrote: On Fri, Jul 16 2021, Daniel P. Berrangé wrote: Is

[PATCH v6 04/12] target/hexagon: make helper functions non-static

2021-07-20 Thread Alessandro Di Federico via
From: Paolo Montesel Make certain helper functions non-static, making them available outside genptr.c. These functions are required by code generated by the idef-parser. This commit also makes some op_helper.c non-static in order to avoid having them marked as unused when using the idef-parser

[PATCH v6 11/12] target/hexagon: import additional tests

2021-07-20 Thread Alessandro Di Federico via
From: Niccolò Izzo Signed-off-by: Alessandro Di Federico Signed-off-by: Niccolò Izzo --- tests/tcg/hexagon/Makefile.target | 30 +- tests/tcg/hexagon/crt.S| 26 tests/tcg/hexagon/test_abs.S | 20 ++ tests/tcg/hexagon/test_bitcnt.S| 42

[PATCH v6 00/12] target/hexagon: introduce idef-parser

2021-07-20 Thread Alessandro Di Federico via
From: Alessandro Di Federico This patchset introduces the idef-parser for target/hexagon. It's the sixth iteration of the patchset and includes fixes suggested in previous iterations. `idef-parser` is a build-time tool built using flex and bison. Its aim is to generate a large part of the tiny

[PATCH 08/16] whpx nvmm: Drop useless migrate_del_blocker()

2021-07-20 Thread Markus Armbruster
There is nothing to delete after migrate_add_blocker() failed. Trying anyway is safe, but useless. Don't. Cc: Sunil Muthuswamy Cc: Kamil Rytarowski Cc: Reinoud Zandijk Signed-off-by: Markus Armbruster --- target/i386/nvmm/nvmm-all.c | 1 - target/i386/whpx/whpx-all.c | 1 - 2 files

[PATCH 02/16] spapr: Plug memory leak when we can't add a migration blocker

2021-07-20 Thread Markus Armbruster
Fixes: 2500fb423adb17995485de0b4d507cf2f09e3a7f Cc: Aravinda Prasad Cc: Ganesh Goudar Cc: David Gibson Signed-off-by: Markus Armbruster --- hw/ppc/spapr_events.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/ppc/spapr_events.c b/hw/ppc/spapr_events.c index

[PATCH 15/16] vl: Clean up -smp error handling

2021-07-20 Thread Markus Armbruster
The Error ** argument must be NULL, _abort, _fatal, or a pointer to a variable containing NULL. Passing an argument of the latter kind twice without clearing it in between is wrong: if the first call sets an error, it no longer points to NULL for the second call. machine_parse_property_opt() is

[PATCH 01/16] error: Use error_fatal to simplify obvious fatal errors (again)

2021-07-20 Thread Markus Armbruster
We did this with scripts/coccinelle/use-error_fatal.cocci before, in commit 50beeb68094 and 007b06578ab. This commit cleans up rarer variations that don't seem worth matching with Coccinelle. Cc: Thomas Huth Cc: Cornelia Huck Cc: Peter Xu Cc: Juan Quintela Cc: Stefan Hajnoczi Cc: Paolo

  1   2   3   4   >