Re: [PATCH v3 0/2] x86/sev: Measured Linux SEV guest with kernel/initrd/cmdline

2021-07-30 Thread Connor Kuehl
On Fri Jul 30, 2021 at 1:02 PM CDT, Dov Murik wrote: > > > > Awesome! Unfortunately, it's looking like we'll have to wait[1] for QEMU to > > thaw before this series goes in. > > > > Thanks for explaining this. Do I need to do anything after 6.1 is > released? Ping? Rebase and re-send? Rebase and

Re: [PATCH for-6.2 10/53] target/arm: Fix VPT advance when ECI is non-zero

2021-07-30 Thread Richard Henderson
On 7/29/21 1:14 AM, Peter Maydell wrote: We were not paying attention to the ECI state when advancing the VPT state. Architecturally, VPT state advance happens for every beat (see the pseudocode VPTAdvance()), so on every beat the 4 bits of VPR.P0 corresponding to the current beat are inverted

RE: [PATCH for-6.2 5/8] arch_init.h: Add QEMU_ARCH_HEXAGON

2021-07-30 Thread Taylor Simpson
> -Original Message- > From: Qemu-devel bounces+tsimpson=quicinc@nongnu.org> On Behalf Of Peter Maydell > Sent: Friday, July 30, 2021 5:00 AM > To: qemu-devel@nongnu.org > Cc: Paolo Bonzini ; Markus Armbruster > ; Eduardo Habkost > Subject: [PATCH for-6.2 5/8] arch_init.h: Add

Re: [PATCH for-6.2 41/53] target/arm: Implement MVE VMAXNMA and VMINNMA

2021-07-30 Thread Richard Henderson
On 7/29/21 1:15 AM, Peter Maydell wrote: Implement the MVE VMAXNMA and VMINNMA insns; these are 2-operand, but the destination register must be the same as one of the source registers. We defer the decode of the size in bit 28 to the individual insn patterns rather than doing it in the format,

[PATCH] target/mips: Remove JR opcode unused arguments

2021-07-30 Thread Philippe Mathieu-Daudé
JR opcode (Jump Register) only takes 1 argument, $rs. JALR (Jump And Link Register) takes 3: $rs, $rd and $hint. Commit 6af0bf9c7c3 added their processing into decode_opc() as: case 0x08 ... 0x09: /* Jumps */ gen_compute_branch(ctx, op1 | EXT_SPECIAL, rs, rd, sa); having both

Re: [PATCH for-6.2 07/43] target/ppc: Set fault address in ppc_cpu_do_unaligned_access

2021-07-30 Thread Cédric Le Goater
On 7/29/21 2:46 AM, Richard Henderson wrote: > We ought to have been recording the virtual address for reporting > to the guest trap handler. > > Cc: qemu-...@nongnu.org > Signed-off-by: Richard Henderson Reviewed-by: Cédric Le Goater > --- > target/ppc/excp_helper.c | 2 ++ > 1 file

Re: [PATCH for-6.2 39/53] target/arm: Implement MVE VFMA and VFMS

2021-07-30 Thread Richard Henderson
On 7/29/21 1:14 AM, Peter Maydell wrote: Implement the MVE VFMA and VFMS insns. Signed-off-by: Peter Maydell --- target/arm/helper-mve.h| 6 ++ target/arm/mve.decode | 3 +++ target/arm/mve_helper.c| 36 target/arm/translate-mve.c |

Re: [PATCH for-6.2 42/53] target/arm: Implement MVE scalar fp insns

2021-07-30 Thread Richard Henderson
On 7/29/21 1:15 AM, Peter Maydell wrote: Implement the MVE scalar floating point insns VADD, VSUB and VMUL. Signed-off-by: Peter Maydell --- target/arm/helper-mve.h| 9 + target/arm/mve.decode | 27 +-- target/arm/mve_helper.c| 34

[PATCH v3 11/13] python/aqmp-tui: Add ability to highlight messages

2021-07-30 Thread G S Niteesh Babu
Adds ability to highlight messages in the history box. The messages can be selected using up/down arrow keys. This can be enhanced in the future to apply specific settings to a particular message. Signed-off-by: G S Niteesh Babu --- python/qemu/aqmp/aqmp_tui.py | 50

[PATCH v3 08/13] python/aqmp-tui: add syntax highlighting

2021-07-30 Thread G S Niteesh Babu
Add syntax highlighting for the incoming and outgoing QMP messages. This is achieved using the pygments module which was added in a previous commit. The current implementation is a really simple one which doesn't allow for any configuration. In future this has to be improved to allow for easier

Re: [PATCH for-6.2 47/53] target/arm: Implement MVE fp scalar comparisons

2021-07-30 Thread Richard Henderson
On 7/29/21 1:15 AM, Peter Maydell wrote: Implement the MVE fp scalar comparisons VCMP and VPT. Signed-off-by: Peter Maydell --- target/arm/helper-mve.h| 18 +++ target/arm/mve.decode | 61 + target/arm/mve_helper.c| 62

[PATCH v3 05/13] python: add entry point for aqmp-tui

2021-07-30 Thread G S Niteesh Babu
Add an entry point for aqmp-tui. This will allow it to be run from the command line using "aqmp-tui localhost:1234" More options available in the TUI can be found using "aqmp-tui -h" Signed-off-by: G S Niteesh Babu --- python/setup.cfg | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 0/2] cocoa.m: keyboard quality of life reborn

2021-07-30 Thread John Arbuckle
These patches can really help improve keyboard usage with a guest. Based on patches by Gustavo Noronha Silva . John Arbuckle (2): Add full keyboard grab support Add ability to swap command/meta and options keys ui/cocoa.m | 178 ++--- 1 file

[PATCH 1/2] ui/cocoa.m: Add full keyboard grab support

2021-07-30 Thread John Arbuckle
There are keyboard shortcuts that are vital for use in a guest that runs Mac OS. These shortcuts are reserved for Mac OS use only which makes having the guest see them impossible on a Mac OS host - until now. This patch will enable the user to decide if the guest should see all keyboard shortcuts

[PATCH 2/2] ui/cocoa.m: Add ability to swap command/meta and options keys

2021-07-30 Thread John Arbuckle
For users who are use to using a Macintosh keyboard having to use a PC keyboard can be a pain because the Command/meta and Option/Alt keys are switched. To make life easier this option is added to allow the user to switch how the guest reacts to each of these keys being pushed. It can make a

Re: [PATCH v3 0/2] x86/sev: Measured Linux SEV guest with kernel/initrd/cmdline

2021-07-30 Thread Dov Murik
On 30/07/2021 17:47, Connor Kuehl wrote: > On Thu Jul 29, 2021 at 2:31 PM CDT, Dov Murik wrote: >> The OVMF companion series has been reviewed by the new OVMF maintainer >> and merged to edk2 master branch as of edk2 commit 514b3aa08ece [1]. >> >> [1]

Re: [PATCH for-6.2 37/53] target/arm: Implement MVE VSUB, VMUL, VABD, VMAXNM, VMINNM

2021-07-30 Thread Richard Henderson
On 7/29/21 1:14 AM, Peter Maydell wrote: Implement more simple 2-operand floating point MVE insns. Signed-off-by: Peter Maydell --- target/arm/helper-mve.h| 15 +++ target/arm/mve.decode | 6 ++ target/arm/mve_helper.c| 24

Re: [PATCH for-6.2 39/53] target/arm: Implement MVE VFMA and VFMS

2021-07-30 Thread Richard Henderson
On 7/29/21 1:14 AM, Peter Maydell wrote: +r = FN(n[H##ESIZE(e)], m[H##ESIZE(e)], d[H##ESIZE(e)], \ + 0, fpst);\ +mergemask([H##ESIZE(e)], r, mask);\ +}

[PATCH v3 13/13] python/aqmp-tui: Allow copying message from TUI

2021-07-30 Thread G S Niteesh Babu
This commit adds a feature that enables use to copy messages from the TUI after highlighting the message in the history box using up/down arrow keys and pressing alt-c. Signed-off-by: G S Niteesh Babu --- python/qemu/aqmp/aqmp_tui.py | 9 + 1 file changed, 9 insertions(+) diff --git

Re: [PATCH for-6.2 52/53] target/arm: Implement MVE VRINT insns

2021-07-30 Thread Richard Henderson
On 7/29/21 1:15 AM, Peter Maydell wrote: Implement the MVE VRINT insns, which round floating point inputs to integer values, leaving them in floating point format. Signed-off-by: Peter Maydell --- target/arm/helper-mve.h| 6 + target/arm/mve.decode | 7 ++

Re: [PATCH for-6.2 53/53] target/arm: Enable MVE in Cortex-M55

2021-07-30 Thread Richard Henderson
On 7/29/21 1:15 AM, Peter Maydell wrote: We now have a complete MVE emulation, so we can enable it in our Cortex-M55 model by setting the ID registers to match those of a Cortex-M55 with full MVE support. Signed-off-by: Peter Maydell --- docs/system/arm/emulation.rst | 1 +

Re: [PATCH for-6.2 07/43] target/ppc: Set fault address in ppc_cpu_do_unaligned_access

2021-07-30 Thread Cédric Le Goater
On 7/30/21 7:13 PM, Cédric Le Goater wrote: > On 7/29/21 8:05 PM, Richard Henderson wrote: >> On 7/29/21 3:44 AM, Peter Maydell wrote: >>> On Thu, 29 Jul 2021 at 01:51, Richard Henderson >>> wrote: We ought to have been recording the virtual address for reporting to the guest trap

Re: QEMU on x64

2021-07-30 Thread Peter Maydell
On Fri, 30 Jul 2021 at 19:05, Christopher Caulfield wrote: > This is Christopher from the debugging experiences team at Microsoft focused > on kernel debugging. I am reaching out with a few questions about QEMU on x64. > > Is it possible for the QEMU-x86-64 GDB Server to send the full set of x64

Re: [PATCH for-6.2 3/8] softmmu/arch_init.c: Trim down include list

2021-07-30 Thread Richard Henderson
On 7/30/21 12:59 AM, Peter Maydell wrote: arch_init.c does very little but has a long list of #include lines. Remove all the unnecessary ones. Signed-off-by: Peter Maydell --- softmmu/arch_init.c | 7 --- 1 file changed, 7 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH for-6.2 5/8] arch_init.h: Add QEMU_ARCH_HEXAGON

2021-07-30 Thread Richard Henderson
On 7/30/21 12:59 AM, Peter Maydell wrote: When Hexagon was added we forgot to add it to the QEMU_ARCH_* enumeration. This doesn't cause a visible effect because at the moment Hexagon is linux-user only and the QEMU_ARCH_* constants are only used in softmmu, but we might as well add it in, since

Re: [PATCH for-6.2 7/8] arch_init.h: Don't include arch_init.h unnecessarily

2021-07-30 Thread Richard Henderson
On 7/30/21 12:59 AM, Peter Maydell wrote: arch_init.h only defines the QEMU_ARCH_* enumeration and the arch_type global. Don't include it in files that don't use those. Signed-off-by: Peter Maydell --- Reviewed-by: Richard Henderson r~

Re: [PATCH for-6.2 6/8] arch_init.h: Move QEMU_ARCH_VIRTIO_* to qdev-monitor.c

2021-07-30 Thread Richard Henderson
On 7/30/21 12:59 AM, Peter Maydell wrote: The QEMU_ARCH_VIRTIO_* defines are used only in one file, qdev-monitor.c. Move them to that file. Signed-off-by: Peter Maydell --- include/sysemu/arch_init.h | 9 - softmmu/qdev-monitor.c | 9 + 2 files changed, 9 insertions(+),

Re: [PATCH for-6.2 4/8] meson.build: Define QEMU_ARCH in config-target.h

2021-07-30 Thread Richard Henderson
On 7/30/21 12:59 AM, Peter Maydell wrote: Instead of using an ifdef ladder in arch_init.c (which we then have to manually update every time we add or remove a target architecture), have meson.build put "#define QEMU_ARCH QEMU_ARCH_FOO" in the config-target.h file. Signed-off-by: Peter Maydell

Re: [PATCH for-6.2 38/53] target/arm: Implement MVE VCADD

2021-07-30 Thread Richard Henderson
On 7/29/21 1:14 AM, Peter Maydell wrote: Implement the MVE VCADD insn. Note that here the size bit is the opposite sense to the other 2-operand fp insns. We don't check for the sz == 1 && Qd == Qm UNPREDICTABLE case, because that would mean we can't use the DO_2OP_FP macro in translate-mve.c.

[PATCH v3 06/13] python/aqmp-tui: Added type annotations for aqmp-tui

2021-07-30 Thread G S Niteesh Babu
This patch adds type annotations for aqmp-tui using the mypy library. Signed-off-by: G S Niteesh Babu --- python/qemu/aqmp/aqmp_tui.py | 79 python/setup.cfg | 3 -- 2 files changed, 43 insertions(+), 39 deletions(-) diff --git

[PATCH v3 02/13] python: disable pylint errors for aqmp-tui

2021-07-30 Thread G S Niteesh Babu
Disable missing-docstring and fixme pylint warnings. This is because since the AQMP is just a prototype it is currently not documented properly and lot of todo and fixme's are still in place. Signed-off-by: G S Niteesh Babu --- python/setup.cfg | 2 ++ 1 file changed, 2 insertions(+) diff

[PATCH v3 12/13] python/aqmp-tui: Add pyperclip dependency

2021-07-30 Thread G S Niteesh Babu
This dependency is required to enable copying from the TUI using special keys to the system clipboard. pyperclip works out of the box on windows and macos but requires xsel/xclip to be installed on linux machines. Signed-off-by: G S Niteesh Babu --- python/Pipfile.lock | 22

[PATCH v3 07/13] python: add optional pygments dependency

2021-07-30 Thread G S Niteesh Babu
Added pygments as optional dependency for AQMP TUI. This is required for the upcoming syntax highlighting feature in AQMP TUI. The dependency has also been added in the devel optional group. Added mypy 'ignore_missing_imports' for pygments since it does not have any type stubs. Signed-off-by: G

Re: need help with my config

2021-07-30 Thread Cédric Le Goater
Hello, On 7/30/21 3:25 PM, Philippe Mathieu-Daudé wrote: > Cc'ing qemu-ppc@ > > On 7/30/21 6:25 AM, Lindsay Ryan wrote: >> Hi >> I'm trying to emulate some physical IBM Power 9's that we have. There >> seems to be plenty of examples of using x86_64 qemu, but slightly less >> for Power. For

Re: [PATCH for-6.2 07/53] target/arm: Fix MVE 48-bit SQRSHRL for small right shifts

2021-07-30 Thread Richard Henderson
On 7/29/21 1:14 AM, Peter Maydell wrote: We got an edge case wrong in the 48-bit SQRSHRL implementation: if the shift is to the right, although it always makes the result smaller than the input value it might not be within the 48-bit range the result is supposed to be if the input had some bits

[PATCH v3 01/13] python/aqmp: Fix wait_closed work-around for python 3.6

2021-07-30 Thread G S Niteesh Babu
Before this patch the wait_closed work-around for python 3.6 fails during disconnect. This is a temproray work around for which might be fixed in the future or will be completely removed when the minimum python version is raised to 3.7. This patch was originally written by John Snow

[PATCH v3 00/13] AQMP TUI Draft

2021-07-30 Thread G S Niteesh Babu
Hello all, Gitlab: https://gitlab.com/niteesh.gs/qemu/-/commits/aqmp-tui-prototype-v3 CI: https://gitlab.com/niteesh.gs/qemu/-/pipelines/345738265 Major revision since V2: 1) Refined QMP connection manager. 2) Added static typing. 3) Allow highlighting specific messages in history box. 4) Allow

[PULL 0/2] tcg patch queue for rc2

2021-07-30 Thread Richard Henderson
-20210730 for you to fetch changes up to 236f6709ae0da224314c3344c339ed0dc07c15cf: target/nios2: Mark raise_exception() as noreturn (2021-07-30 08:23:12 -1000) Fix double bswap in 16-byte atomic store Mark nios2 raise_exception

[PULL 1/2] accel/tcg: Remove double bswap for helper_atomic_sto_*_mmu

2021-07-30 Thread Richard Henderson
This crept in as either a cut-and-paste error, or rebase error. Fixes: cfec388518d ("atomic_template: add inline trace/plugin helpers") Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210729004647.282017-24-richard.hender...@linaro.org> Signed-off-by: Richard Henderson ---

[PULL 2/2] target/nios2: Mark raise_exception() as noreturn

2021-07-30 Thread Richard Henderson
From: Philippe Mathieu-Daudé Raised exceptions don't return, so mark the helper with noreturn. Fixes: 032c76bc6f9 ("nios2: Add architecture emulation support") Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20210729101315.2318714-1-f4...@amsat.org>

Re: [PATCH for-6.2 40/53] target/arm: Implement MVE VCMUL and VCMLA

2021-07-30 Thread Richard Henderson
On 7/29/21 1:14 AM, Peter Maydell wrote: +#define DO_VCMULH(N, M, D, S) float16_mul(N, M, S) +#define DO_VCMULS(N, M, D, S) float32_mul(N, M, S) + +#define DO_VCMLAH(N, M, D, S) float16_muladd(N, M, D, 0, S) +#define DO_VCMLAS(N, M, D, S) float32_muladd(N, M, D, 0, S) + +DO_VCMLA(vcmul0h, 2,

Re: [PATCH for-6.2 43/53] target/arm: Implement MVE fp-with-scalar VFMA, VFMAS

2021-07-30 Thread Richard Henderson
On 7/29/21 1:15 AM, Peter Maydell wrote: Implement the MVE fp-with-scalar VFMA and VFMAS insns. Signed-off-by: Peter Maydell --- target/arm/helper-mve.h| 6 ++ target/arm/mve.decode | 14 +++--- target/arm/mve_helper.c| 37 +

[PATCH v3 09/13] python/aqmp-tui: Add QMP connection manager

2021-07-30 Thread G S Niteesh Babu
Instead of manually connecting and disconnecting from the server. We now rely on the runstate to manage the QMP connection. Along with this the ability to reconnect on certain exceptions has also been added. Signed-off-by: G S Niteesh Babu --- python/qemu/aqmp/aqmp_tui.py | 109

[PATCH v3 04/13] python/aqmp-tui: Add AQMP TUI draft

2021-07-30 Thread G S Niteesh Babu
Added a draft of AQMP TUI. Implements the follwing basic features: 1) Command transmission/reception. 2) Shows events asynchronously. 3) Shows server status in the bottom status bar. Also added necessary pylint, mypy configurations Signed-off-by: G S Niteesh Babu ---

[PATCH v3 03/13] python: Add dependencies for AQMP TUI

2021-07-30 Thread G S Niteesh Babu
Added dependencies for the upcoming AQMP TUI under the optional 'tui' group. The same dependencies have also been added under the devel group since no work around has been found for optional groups to imply other optional groups. Signed-off-by: G S Niteesh Babu --- python/Pipfile.lock | 12

[PATCH v3 10/13] python/aqmp-tui: Add scrolling to history box

2021-07-30 Thread G S Niteesh Babu
Adds scroll support to history box. The list can now be scrolled using arrow keys, page up/down and the mouse. The current implementation requires the widget to be in focus to enable scrolling. Therefore the user has to click on the widget before scrolling. Signed-off-by: G S Niteesh Babu ---

[PATCH 1/1] hw/arm/smmu: Add access flag handling

2021-07-30 Thread Joe Komlodi
The SMMU should access fault if AF == 0 in a TTD, and if AFFD == 0 in the CD. Per the spec, an access fault has a higher priority over a permission fault. For instance, a write to a writable clean (temporarily non-writable) page with AF == 0 && AFFD == 0 will cause an access fault. If AF == 1 in

[PATCH 0/1] hw/arm/smmu: Add access flag handling

2021-07-30 Thread Joe Komlodi
Hi all, This adds a check in SMMU PTW to see if the access flag bit is set in a PTE, and if we should fault accordingly or not. Since we do not support HTTU, the check itself is pretty simple: If AFFD == 0 in the context descriptor and AF == 0 in the PTE, we fault. Otherwise, we do not have an

QEMU on x64

2021-07-30 Thread Christopher Caulfield
Hi QEMU community, This is Christopher from the debugging experiences team at Microsoft focused on kernel debugging. I am reaching out with a few questions about QEMU on x64. 1. Is it possible for the QEMU-x86-64 GDB Server to send the full set of x64 system registers (whether they are

Misc questions

2021-07-30 Thread Kenneth Adam Miller
Hello, I think I need a concurrent radix tree that is written to work with atomic updates. I would like to ask if anyone knows of one within qemu? Or at least to efficiently obtain the page address/mmu index corresponding for a given address. Is there any documentation on cpu_mmu_index? Each

Re: [PATCH for-6.2 1/8] softmmu: Use accel_find("xen") instead of xen_available()

2021-07-30 Thread Richard Henderson
On 7/30/21 12:59 AM, Peter Maydell wrote: The xen_available() function is used only to produce an error for some Xen-specific command line options in QEMU binaries where Xen support was not compiled in: it just returns the value of the CONFIG_XEN define. Now that accelerators are QOM classes,

Re: [PATCH for-6.2 03/53] target/arm: Fix MVE VSLI by 0 and VSRI by

2021-07-30 Thread Richard Henderson
On 7/29/21 1:14 AM, Peter Maydell wrote: In the MVE shift-and-insert insns, we special case VSLI by 0 and VSRI by . VSRI by means "don't update the destination", which is what we've implemented. However VSLI by 0 is "set destination to the input", so we don't want to use the same special-casing

Re: [PATCH for-6.2 44/53] softfloat: Remove assertion preventing silencing of NaN in default-NaN mode

2021-07-30 Thread Richard Henderson
On 7/29/21 1:15 AM, Peter Maydell wrote: In commit a777d6033447a we added an assertion to parts_silence_nan() that prohibits calling float*_silence_nan() when in default-NaN mode. This ties together a property of the output ("do we generate a default NaN when the result is a NaN?") with an

Re: [PATCH for-6.2 46/53] target/arm: Implement MVE fp vector comparisons

2021-07-30 Thread Richard Henderson
On 7/29/21 1:15 AM, Peter Maydell wrote: Implement the MVE fp vector comparisons VCMP and VPT. Signed-off-by: Peter Maydell --- target/arm/helper-mve.h| 18 +++ target/arm/mve.decode | 39 +++ target/arm/mve_helper.c| 64

Re: [PATCH for-6.2 48/53] target/arm: Implement MVE VCVT between floating and fixed point

2021-07-30 Thread Richard Henderson
On 7/29/21 1:15 AM, Peter Maydell wrote: Implement the MVE VCVT insns which convert between floating and fixed point. As with the Neon equivalents, these use essentially the same constant encoding as right-shift-by-immediate. Signed-off-by: Peter Maydell --- target/arm/helper-mve.h| 9

Re: [PATCH for-6.2 49/53] target/arm: Implement MVE VCVT between fp and integer

2021-07-30 Thread Richard Henderson
On 7/29/21 1:15 AM, Peter Maydell wrote: Implement the MVE "VCVT (between floating-point and integer)" insn. Signed-off-by: Peter Maydell --- target/arm/mve.decode | 7 +++ target/arm/translate-mve.c | 32 2 files changed, 39 insertions(+)

Re: [PATCH for-6.2 12/43] target/sh4: Implement do_unaligned_access for user-only

2021-07-30 Thread Rob Landley
On 7/29/21 8:52 AM, Peter Maydell wrote: > On Thu, 29 Jul 2021 at 02:01, Richard Henderson > wrote: >> >> Cc: Yoshinori Sato >> Signed-off-by: Richard Henderson >> --- >> linux-user/sh4/cpu_loop.c | 8 >> target/sh4/cpu.c | 2 +- >> target/sh4/op_helper.c| 3 --- >> 3

Re: Problem with trace of x86 binary on x86_64 system with PANDA

2021-07-30 Thread Peter Maydell
On Fri, 30 Jul 2021 at 17:19, Nikita Gnilozub-Volobuev wrote: > I'm a student and I'm writing my term paper. Part of it is the record > the trace of x86 ELF on x86_64 Linux. For record I use PANDA. Hi; PANDA is based on a fork of an older version of QEMU, with considerable alterations. You are

Re: [PATCH for-6.2 07/43] target/ppc: Set fault address in ppc_cpu_do_unaligned_access

2021-07-30 Thread Cédric Le Goater
On 7/29/21 8:05 PM, Richard Henderson wrote: > On 7/29/21 3:44 AM, Peter Maydell wrote: >> On Thu, 29 Jul 2021 at 01:51, Richard Henderson >> wrote: >>> >>> We ought to have been recording the virtual address for reporting >>> to the guest trap handler. >>> >>> Cc: qemu-...@nongnu.org >>>

Re: [PATCH] MAINTAINERS: Added myself as a reviewer for acpi/smbios subsystem

2021-07-30 Thread Philippe Mathieu-Daudé
On 7/30/21 7:55 PM, Ani Sinha wrote: > I have developed an interest in this space and hopefully can lend some > helping hand to Igor and Michael in reviewing simpler patches. Help is welcome IMHO, so: Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Ani Sinha > --- > MAINTAINERS | 1 + >

Re: [PATCH for-6.2 8/8] stubs: Remove unused arch_type.c stub

2021-07-30 Thread Richard Henderson
On 7/30/21 12:59 AM, Peter Maydell wrote: We added a stub for the arch_type global in commit 5964ed56d9a1 so that we could compile blockdev.c into the tools. However, in commit 9db1d3a2be9bf we removed the only use of arch_type from blockdev.c. The stub is therefore no longer needed, and we can

Re: [PATCH for-6.2 26/53] target/arm: Implement MVE VMLA

2021-07-30 Thread Richard Henderson
On 7/29/21 1:14 AM, Peter Maydell wrote: Implement the MVE VMLA insn, which multiplies a vector by a scalar and accumulates into another vector. Signed-off-by: Peter Maydell --- Changes v1->v2: don't decode U bit --- target/arm/helper-mve.h| 4 target/arm/mve.decode | 1 +

Re: [PATCH for-6.2 21/53] target/arm: Implement MVE integer min/max across vector

2021-07-30 Thread Richard Henderson
On 7/29/21 1:14 AM, Peter Maydell wrote: Implement the MVE integer min/max across vector insns VMAXV, VMINV, VMAXAV and VMINAV, which find the maximum from the vector elements and a general purpose register, and store the maximum back into the general purpose register. These insns overlap with

Re: [PATCH for-6.2 45/53] target/arm: Implement MVE FP max/min across vector

2021-07-30 Thread Richard Henderson
On 7/29/21 1:15 AM, Peter Maydell wrote: { + VMAXNMAV 1110 1110 1110 11 00 0 0 . 0 ... 0 @vmaxnmv size=2 + VMINNMAV 1110 1110 1110 11 00 1 0 . 0 ... 0 @vmaxnmv size=2 + VMAXNMV1110 1110 1110 11 10 0 0 . 0 ... 0 @vmaxnmv size=2 +

[PATCH v3] target/i386: Added VGIF feature

2021-07-30 Thread Lara Lazier
v2->v3: moved guest check into virtual_gif_enabled VGIF allows STGI and CLGI to execute in guest mode and control virtual interrupts in guest mode. When the VGIF feature is enabled then: * executing STGI in the guest sets bit 9 of the VMCB offset 60h. * executing CLGI in the guest clears bit 9

[PATCH 1/1] migration: Terminate multifd threads on yank

2021-07-30 Thread Leonardo Bras
>From source host viewpoint, losing a connection during migration will cause the sockets to get stuck in sendmsg() syscall, waiting for the receiving side to reply. In migration, yank works by shutting-down the migration QIOChannel fd. This causes a failure in the next sendmsg() for that fd, and

[Bug 1891748] Re: qemu-arm-static 5.1 can't run gcc

2021-07-30 Thread Maxim Devaev
Sorry, an error in previous message. Fixed and detailed diagnostics: [0... 53248] - working [53249 ... 61440] - Cannot allocate memory [61441 ... 65536 and higher] - Operation not permitted -- You received this bug notification because you are a member of qemu- devel-ml, which is

Re: [PATCH for-6.2 06/10] docs: qom: Remove unnecessary class typedefs from example

2021-07-30 Thread Markus Armbruster
Eduardo Habkost writes: > When there's no specific class struct used for a QOM type, we > normally don't define a typedef for it. Remove the typedef from > the minimal example, as it is unnecessary. > > Signed-off-by: Eduardo Habkost > --- > docs/devel/qom.rst | 3 --- > 1 file changed, 3

[Bug 1891748] Re: qemu-arm-static 5.1 can't run gcc

2021-07-30 Thread Maxim Devaev
I mean [0...52348] is working. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1891748 Title: qemu-arm-static 5.1 can't run gcc Status in QEMU: Fix Released Status in Juju Charms Collection:

Re: [PATCH for-6.2 09/43] target/riscv: Implement do_unaligned_access for user-only

2021-07-30 Thread Alistair Francis
On Thu, Jul 29, 2021 at 10:55 AM Richard Henderson wrote: > > Cc: qemu-ri...@nongnu.org > Signed-off-by: Richard Henderson Reviewed-by: Alistair Francis Alistair > --- > linux-user/riscv/cpu_loop.c | 7 +++ > target/riscv/cpu.c | 2 +- > target/riscv/cpu_helper.c | 8 +++-

Re: [PULL 0/7] Usb 20210729 patches

2021-07-30 Thread Peter Maydell
On Thu, 29 Jul 2021 at 13:58, Gerd Hoffmann wrote: > > The following changes since commit f2da205cb4142259d9bc6b9d4596ebbe2426fe49: > > Update version for v6.1.0-rc1 release (2021-07-27 18:07:52 +0100) > > are available in the Git repository at: > > git://git.kraxel.org/qemu

[Bug 1891748] Re: qemu-arm-static 5.1 can't run gcc

2021-07-30 Thread Maxim Devaev
Okay, it was found experimentally that the problem is reproduced if vm.mmap_min_addr is greater than 53249. If from 0 to 53249 - everything works. What can this be related to? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[PATCH v3 7/7] migration/ram: Handle RAMBlocks with a RamDiscardManager on background snapshots

2021-07-30 Thread David Hildenbrand
We already don't ever migrate memory that corresponds to discarded ranges as managed by a RamDiscardManager responsible for the mapped memory region of the RAMBlock. virtio-mem uses this mechanism to logically unplug parts of a RAMBlock. Right now, we still populate zeropages for the whole usable

[PATCH v3 5/7] virtio-mem: Drop precopy notifier

2021-07-30 Thread David Hildenbrand
Migration code now properly handles RAMBlocks which are indirectly managed by a RamDiscardManager. No need for manual handling via the free page optimization interface, let's get rid of it. Acked-by: Michael S. Tsirkin Acked-by: Peter Xu Signed-off-by: David Hildenbrand ---

Re: [PATCH v2 2/8] virtio-gpu: hostmem [wip]

2021-07-30 Thread Gerd Hoffmann
Hi, > +/* > + * shared memory > + */ > +#define VIRTIO_GPU_F_HOSTMEM 5 Leftover from early interface design attempts. The blob resources (with VIRTIO_GPU_BLOB_MEM_HOST3D_GUEST) should cover that now. take care, Gerd

Re: [PATCH v2 6/8] virtio-gpu: Support Venus capset

2021-07-30 Thread Gerd Hoffmann
Looks sane on a quick glance, but please have a more verbose commit message. I can only guess this is a capset for vulkan support, but readers of the patch should not need guess in the first place ;) take care, Gerd

Re: [PATCH v2 1/3] target-arm: delete ARM_FEATURE_A64FX

2021-07-30 Thread Peter Maydell
On Fri, 30 Jul 2021 at 04:08, Shuuichirou Ishii wrote: > > The ARM_FEATURE_A64FX property was added, > but there is no function that uses this property yet, > so it will be removed until a function that uses it is added. > > Signed-off-by: Shuuichirou Ishii > --- > target/arm/cpu.h | 1 - >

[PATCH for-6.2 1/8] softmmu: Use accel_find("xen") instead of xen_available()

2021-07-30 Thread Peter Maydell
The xen_available() function is used only to produce an error for some Xen-specific command line options in QEMU binaries where Xen support was not compiled in: it just returns the value of the CONFIG_XEN define. Now that accelerators are QOM classes, we can check for "does this binary have Xen

[PATCH for-6.2 6/8] arch_init.h: Move QEMU_ARCH_VIRTIO_* to qdev-monitor.c

2021-07-30 Thread Peter Maydell
The QEMU_ARCH_VIRTIO_* defines are used only in one file, qdev-monitor.c. Move them to that file. Signed-off-by: Peter Maydell --- include/sysemu/arch_init.h | 9 - softmmu/qdev-monitor.c | 9 + 2 files changed, 9 insertions(+), 9 deletions(-) diff --git

Re: [PULL for-6.1 0/3] Block patches

2021-07-30 Thread Peter Maydell
On Thu, 29 Jul 2021 at 17:23, Stefan Hajnoczi wrote: > > The following changes since commit 3521ade3510eb5cefb2e27a101667f25dad89935: > > Merge remote-tracking branch > 'remotes/thuth-gitlab/tags/pull-request-2021-07-29' into staging (2021-07-29 > 13:17:20 +0100) > > are available in the Git

[PATCH v3 0/7] migration/ram: Optimize for virtio-mem via RamDiscardManager

2021-07-30 Thread David Hildenbrand
virtio-mem exposes a dynamic amount of memory within RAMBlocks by coordinating with the VM. Memory within a RAMBlock can either get plugged and consequently used by the VM, or unplugged and consequently no longer used by the VM. Logical unplug is realized by discarding the physical memory backing

[PATCH v3 2/7] virtio-mem: Implement replay_discarded RamDiscardManager callback

2021-07-30 Thread David Hildenbrand
Implement it similar to the replay_populated callback. Acked-by: Peter Xu Signed-off-by: David Hildenbrand --- hw/virtio/virtio-mem.c | 58 ++ 1 file changed, 58 insertions(+) diff --git a/hw/virtio/virtio-mem.c b/hw/virtio/virtio-mem.c index

[PATCH v3 1/7] memory: Introduce replay_discarded callback for RamDiscardManager

2021-07-30 Thread David Hildenbrand
Introduce replay_discarded callback similar to our existing replay_populated callback, to be used my migration code to never migrate discarded memory. Acked-by: Peter Xu Signed-off-by: David Hildenbrand --- include/exec/memory.h | 21 + softmmu/memory.c | 11

Re: [PATCH v2 1/8] virtio-gpu: CONTEXT_INIT feature

2021-07-30 Thread Gerd Hoffmann
Hi, > +/* > + * VIRTIO_GPU_CMD_CREATE_CONTEXT with > + * context_init > + */ > +#define VIRTIO_GPU_F_CONTEXT_INIT4 Where is the virtio spec update for this? take care, Gerd

Re: [PATCH v2 4/8] virtio-gpu: Shared memory capability

2021-07-30 Thread Gerd Hoffmann
> -virtio_pci_add_shm_cap(vpci_dev, 4, 0, g->conf.hostmem, 0); > +virtio_pci_add_shm_cap(vpci_dev, 4, 0, g->conf.hostmem, > VIRTIO_GPU_SHM_ID_HOST_VISIBLE); Squash that into patch #2 > --- a/include/standard-headers/linux/virtio_pci.h > +++

Re: [PATCH v2 5/8] virtio-gpu: Resource UUID

2021-07-30 Thread Gerd Hoffmann
On Wed, Jul 28, 2021 at 03:46:31PM +0200, Antonio Caggiano wrote: > Enable resource UUID feature and implement command resource assign UUID. > For the moment, use the resource ID as UUID. No, please do that properly right from start. Needs a uuid -> resource-id table or hash in qemu.

[PATCH for-6.2 5/8] arch_init.h: Add QEMU_ARCH_HEXAGON

2021-07-30 Thread Peter Maydell
When Hexagon was added we forgot to add it to the QEMU_ARCH_* enumeration. This doesn't cause a visible effect because at the moment Hexagon is linux-user only and the QEMU_ARCH_* constants are only used in softmmu, but we might as well add it in, since it's the only architecture currently

[PATCH for-6.2 4/8] meson.build: Define QEMU_ARCH in config-target.h

2021-07-30 Thread Peter Maydell
Instead of using an ifdef ladder in arch_init.c (which we then have to manually update every time we add or remove a target architecture), have meson.build put "#define QEMU_ARCH QEMU_ARCH_FOO" in the config-target.h file. Signed-off-by: Peter Maydell --- meson.build | 2 ++

Re: [PATCH for-6.2 06/10] docs: qom: Remove unnecessary class typedefs from example

2021-07-30 Thread Peter Maydell
On Fri, 30 Jul 2021 at 09:18, Markus Armbruster wrote: > > Eduardo Habkost writes: > > > When there's no specific class struct used for a QOM type, we > > normally don't define a typedef for it. Remove the typedef from > > the minimal example, as it is unnecessary. > > > > Signed-off-by:

[PATCH v3 6/7] migration/postcopy: Handle RAMBlocks with a RamDiscardManager on the destination

2021-07-30 Thread David Hildenbrand
Currently, when someone (i.e., the VM) accesses discarded parts inside a RAMBlock with a RamDiscardManager managing the corresponding mapped memory region, postcopy will request migration of the corresponding page from the source. The source, however, will never answer, because it refuses to

Re: [PATCH for-6.2 06/10] docs: qom: Remove unnecessary class typedefs from example

2021-07-30 Thread Daniel P . Berrangé
On Fri, Jul 30, 2021 at 09:43:55AM +0100, Peter Maydell wrote: > On Fri, 30 Jul 2021 at 09:18, Markus Armbruster wrote: > > > > Eduardo Habkost writes: > > > > > When there's no specific class struct used for a QOM type, we > > > normally don't define a typedef for it. Remove the typedef from >

Re: [PATCH v2 7/8] virtio-gpu: Initialize Venus

2021-07-30 Thread Gerd Hoffmann
On Wed, Jul 28, 2021 at 03:46:33PM +0200, Antonio Caggiano wrote: > Enable VirGL unstable APIs and request Venus when initializing VirGL. I guess having a runtime switch for that would be a good idea, and probably have default it off while the API is unstable still. take care, Gerd

Re: [PATCH v2 8/8] virtio-gpu: Handle resource blob commands

2021-07-30 Thread Gerd Hoffmann
Hi, > +region = g_new0(MemoryRegion, 1); > +memory_region_init_ram_device_ptr(region, OBJECT(g), NULL, size, data); > +memory_region_add_subregion(>parent_obj.hostmem, mblob.offset, > region); > +memory_region_set_enabled(region, true); You leak the region instead of properly

Re: [PATCH v2 3/3] target-arm: Add A64FX processor support to virt machine

2021-07-30 Thread Peter Maydell
On Fri, 30 Jul 2021 at 04:08, Shuuichirou Ishii wrote: > > Fix for patch consistency. > https://lists.gnu.org/archive/html/qemu-devel/2021-07/msg06993.html Commit messages should describe what the patch is doing and why, so the reader can understand it without having to cross-reference old

Re: [PATCH v2 0/3] Add support for Fujitsu A64FX processor

2021-07-30 Thread Peter Maydell
On Fri, 30 Jul 2021 at 04:08, Shuuichirou Ishii wrote: > > This is the v2 patch series. > > v2: > No features have been added or removed from the v1 patch series. Removal > of unused definitions that were added in excess, and consolidation of > patches for the purpose of functional consistency. >

[PATCH for-6.2 7/8] arch_init.h: Don't include arch_init.h unnecessarily

2021-07-30 Thread Peter Maydell
arch_init.h only defines the QEMU_ARCH_* enumeration and the arch_type global. Don't include it in files that don't use those. Signed-off-by: Peter Maydell --- blockdev.c| 1 - hw/i386/pc.c | 1 - hw/i386/pc_piix.c | 1 - hw/i386/pc_q35.c | 1 -

[PATCH for-6.2 8/8] stubs: Remove unused arch_type.c stub

2021-07-30 Thread Peter Maydell
We added a stub for the arch_type global in commit 5964ed56d9a1 so that we could compile blockdev.c into the tools. However, in commit 9db1d3a2be9bf we removed the only use of arch_type from blockdev.c. The stub is therefore no longer needed, and we can delete it again, together with the

[PATCH v3 3/7] migration/ram: Don't passs RAMState to migration_clear_memory_region_dirty_bitmap_*()

2021-07-30 Thread David Hildenbrand
The parameter is unused, let's drop it. Signed-off-by: David Hildenbrand --- migration/ram.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 7a43bfd7af..bb908822d5 100644 --- a/migration/ram.c +++ b/migration/ram.c @@

[PATCH v3 4/7] migration/ram: Handle RAMBlocks with a RamDiscardManager on the migration source

2021-07-30 Thread David Hildenbrand
We don't want to migrate memory that corresponds to discarded ranges as managed by a RamDiscardManager responsible for the mapped memory region of the RAMBlock. The content of these pages is essentially stale and without any guarantees for the VM ("logically unplugged"). Depending on the

Re: modular tcg

2021-07-30 Thread Gerd Hoffmann
Hi, On Thu, Jul 29, 2021 at 06:40:17PM +0200, Paolo Bonzini wrote: > On 29/07/21 11:14, Gerd Hoffmann wrote: > > The common functions could be added TCGCPUOps to allow them being called via > > CPUClass->tcg_ops->$name instead of a direct symbol reference. Not sure > > this > > is a good idea

  1   2   >