Re: [RESEND PATCH 1/3] hw/intc: openpic: Correct the reset value of IPIDR for FSL chipset

2021-09-22 Thread Bin Meng
On Tue, Sep 21, 2021 at 4:13 PM Philippe Mathieu-Daudé wrote: > > On 9/21/21 05:25, David Gibson wrote: > > On Sat, Sep 18, 2021 at 11:26:51AM +0800, Bin Meng wrote: > >> The reset value of IPIDR should be zero for Freescale chipset, per > >> the following 2 manuals I checked: > >> > >> - P2020RM

Re: [PATCH] spapr_numa.c: fixes in spapr_numa_FORM2_write_rtas_tables()

2021-09-22 Thread Greg Kurz
On Tue, 21 Sep 2021 16:43:47 -0300 Daniel Henrique Barboza wrote: > This patch has a handful of modifications for the recent added > FORM2 support: > > - there is no particular reason for both 'lookup_index_table' and > 'distance_table' to be allocated in the heap, since their sizes are > known

Re: [PATCH v3 21/35] acpi: madt: arm/x86: use acpi_table_begin()/acpi_table_end() instead of build_header()

2021-09-22 Thread Eric Auger
On 9/7/21 4:48 PM, Igor Mammedov wrote: > it replaces error-prone pointer arithmetic for build_header() API, > with 2 calls to start and finish table creation, > which hides offsets magic from API user. > > Signed-off-by: Igor Mammedov > --- > v3: > *

Re: [PATCH v4 02/20] nubus-device: expose separate super slot memory region

2021-09-22 Thread Mark Cave-Ayland
On 20/09/2021 20:54, Laurent Vivier wrote: Le 17/09/2021 à 09:50, Mark Cave-Ayland a écrit : According to "Designing Cards and Drivers for the Macintosh Family" each physical nubus slot can access 2 separate address ranges: a super slot memory region which is 256MB and a standard slot memory

Re: [PATCH v4 09/20] macfb: don't register declaration ROM

2021-09-22 Thread BALATON Zoltan
On Wed, 22 Sep 2021, Mark Cave-Ayland wrote: On 20/09/2021 21:01, Laurent Vivier wrote: Le 17/09/2021 à 09:50, Mark Cave-Ayland a écrit : The macfb device is an on-board framebuffer and so is initialised by the system declaration ROM included within the MacOS toolbox ROM. Signed-off-by: Mark

Re: [PATCH] spapr_numa.c: fixes in spapr_numa_FORM2_write_rtas_tables()

2021-09-22 Thread Philippe Mathieu-Daudé
On 9/21/21 21:43, Daniel Henrique Barboza wrote: This patch has a handful of modifications for the recent added FORM2 support: - there is no particular reason for both 'lookup_index_table' and 'distance_table' to be allocated in the heap, since their sizes are known right at the start of the

[PATCH 3/3] docs: rSTify the "SubmitAPatch" wiki

2021-09-22 Thread Kashyap Chamarthy
- The original wiki is here[1]. I copied the wiki source[2] into a .wiki file, and used `pandoc` to convert it to rST: $> pandoc -f Mediawiki -t rst submitting-a-patch.wiki -o submitting-a-patch.rst - The only minor touch-ups I did was to fix URLs. But 99%, it is a 1-1

[PATCH 2/3] docs: rSTify the "TrivialPatches" wiki

2021-09-22 Thread Kashyap Chamarthy
The original wiki is here[1]. I converted by copying the wiki source into a .wiki file and convert to rST using `pandoc`: $ pandoc -f Mediawiki -t rst trivial-patches.wiki -o trivial-patches.rst [1] https://wiki.qemu.org/Contribute/TrivialPatches Signed-off-by: Kashyap Chamarthy ---

Re: [PATCH v6 00/21] Add LoongArch linux-user emulation support

2021-09-22 Thread WANG Xuerui
Hi Song, On 9/22/21 14:22, Song Gao wrote: Hi, Richard. On 09/21/2021 05:17 AM, Richard Henderson wrote: On 9/17/21 1:12 AM, Song Gao wrote: The 'o32' code has been deleted at the latest kernel [1]. This series only support linux-user emulation. I have now reviewed all but the linux-user/

Re: [PATCH v3 26/35] acpi: build_dsdt_microvm: use acpi_table_begin()/acpi_table_end() instead of build_header()

2021-09-22 Thread Eric Auger
On 9/7/21 4:48 PM, Igor Mammedov wrote: > it replaces error-prone pointer arithmetic for build_header() API, > with 2 calls to start and finish table creation, > which hides offsets magic from API user. > > Signed-off-by: Igor Mammedov Reviewed-by: Eric Auger Eric > --- > v3: > *

Re: [PATCH 0/2] virtiofsd: Add capability to block xattrs

2021-09-22 Thread Dr. David Alan Gilbert
* Vivek Goyal (vgo...@redhat.com) wrote: > As of now we have a knob "-o xattr/no_xattr" which either enables > all xattrs or disables all xattrs. Hi Vivek, Thanks for this. > We need something more fine grained where we can selectively disable > only certain xattrs (and not all). > > For

Re: [PATCH v3 01/15] target/ppc: add user read functions for MMCR0 and MMCR2

2021-09-22 Thread Matheus K. Ferst
On 03/09/2021 17:31, Daniel Henrique Barboza wrote: [E-MAIL EXTERNO] Não clique em links ou abra anexos, a menos que você possa confirmar o remetente e saber que o conteúdo é seguro. Em caso de e-mail suspeito entre imediatamente em contato com o DTI. From: Gustavo Romero We're going to add

Re: [PATCH v4 09/20] macfb: don't register declaration ROM

2021-09-22 Thread Mark Cave-Ayland
On 22/09/2021 12:15, BALATON Zoltan wrote: On Wed, 22 Sep 2021, Mark Cave-Ayland wrote: On 20/09/2021 21:01, Laurent Vivier wrote: Le 17/09/2021 à 09:50, Mark Cave-Ayland a écrit : The macfb device is an on-board framebuffer and so is initialised by the system declaration ROM included within

Re: ensuring a machine's buses have unique names

2021-09-22 Thread BALATON Zoltan
On Wed, 22 Sep 2021, Markus Armbruster wrote: BALATON Zoltan writes: On Tue, 21 Sep 2021, Peter Maydell wrote: On Wed, 15 Sept 2021 at 05:28, Markus Armbruster wrote: Peter Maydell writes: I'm not sure how best to sort this tangle out. We could: * make controller devices pass in NULL

Re: [PATCH v3 18/35] acpi: build_dmar_q35: use acpi_table_begin()/acpi_table_end() instead of build_header()

2021-09-22 Thread Igor Mammedov
On Wed, 22 Sep 2021 11:19:05 +0200 Eric Auger wrote: > On 9/7/21 4:47 PM, Igor Mammedov wrote: > > it replaces error-prone pointer arithmetic for build_header() API, > > with 2 calls to start and finish table creation, > > which hides offsets magic from API user. > > > > While at it switch to

Re: [PATCH v3 24/35] acpi: x86: madt: use build_append_int_noprefix() API to compose MADT table

2021-09-22 Thread Eric Auger
On 9/7/21 4:48 PM, Igor Mammedov wrote: > Drop usage of packed structures and explicit endian conversions > when building MADT table for arm/x86 and use endian agnostic > build_append_int_noprefix() API to build it. > > Signed-off-by: Igor Mammedov > --- > CC: marcel.apfelb...@gmail.com > CC:

Re: [PATCH v4 05/20] nubus: move slot bitmap checks from NubusDevice realize() to BusClass check_address()

2021-09-22 Thread Mark Cave-Ayland
On 20/09/2021 20:56, Laurent Vivier wrote: Le 17/09/2021 à 09:50, Mark Cave-Ayland a écrit : Allow Nubus to manage the slot allocations itself using the BusClass check_address() virtual function rather than managing this during NubusDevice realize(). Signed-off-by: Mark Cave-Ayland ---

Re: [PATCH] spapr_numa.c: fixes in spapr_numa_FORM2_write_rtas_tables()

2021-09-22 Thread Daniel Henrique Barboza
On 9/22/21 06:51, BALATON Zoltan wrote: On Wed, 22 Sep 2021, Greg Kurz wrote: On Tue, 21 Sep 2021 16:43:47 -0300 Daniel Henrique Barboza wrote: This patch has a handful of modifications for the recent added FORM2 support: - there is no particular reason for both 'lookup_index_table' and

Re: [PATCH v11 06/10] hvf: arm: Implement -cpu host

2021-09-22 Thread Ard Biesheuvel
On Thu, 16 Sept 2021 at 18:17, Peter Maydell wrote: > > On Thu, 16 Sept 2021 at 17:05, Ard Biesheuvel wrote: > > I'd argue that compliance with the architecture means that the > > software should not clear RES1 bits > > Architecturally, RES1 means that "software > * Must not rely on the bit

Re: [PATCH v7 0/7] DEVICE_UNPLUG_GUEST_ERROR QAPI event

2021-09-22 Thread Markus Armbruster
Not yet merged. David, would you like to do the pull request?

Re: [PATCH v7 0/7] DEVICE_UNPLUG_GUEST_ERROR QAPI event

2021-09-22 Thread Markus Armbruster
Markus Armbruster writes: > Not yet merged. David, would you like to do the pull request? Oops, there's v8. Take that one of course.

Re: [PATCH v1] monitor: Consider "id" when rate-limiting MEMORY_DEVICE_SIZE_CHANGE qapi events

2021-09-22 Thread David Hildenbrand
On 22.09.21 14:11, Markus Armbruster wrote: David Hildenbrand writes: We have to consider the device id, otherwise we'll lose some events for unrelated devices. If the device does not have a device id (very unlikely), the target of the notifications has to update the size of all devices

[PATCH 08/14] bsd-user/target_os_elf: If ELF_HWCAP2 is defined, publish it

2021-09-22 Thread Warner Losh
Some architecutres publish AT_HWCAP2 as well as AT_HWCAP. Those architectures will define this in their target_arch_elf.h files. If it is defined, then publish it. Signed-off-by: Warner Losh --- bsd-user/freebsd/target_os_elf.h | 4 1 file changed, 4 insertions(+) diff --git

Re: [PATCH v3 15/35] acpi: build_tpm_tcpa: use acpi_table_begin()/acpi_table_end() instead of build_header()

2021-09-22 Thread Eric Auger
On 9/7/21 4:47 PM, Igor Mammedov wrote: > it replaces error-prone pointer arithmetic for build_header() API, > with 2 calls to start and finish table creation, > which hides offsets magic from API user. > > While at it switch to build_append_int_noprefix() to build > table entries (which also

Re: [PATCH v3 12/35] acpi: vmgenid_build_acpi: use acpi_table_begin()/acpi_table_end() instead of build_header()

2021-09-22 Thread Eric Auger
On 9/7/21 4:47 PM, Igor Mammedov wrote: > it replaces error-prone pointer arithmetic for build_header() API, > with 2 calls to start and finish table creation, > which hides offsets magic from API user. > > Signed-off-by: Igor Mammedov > --- > v3: > *

Re: [PATCH v2 00/19] Make image fleecing more usable

2021-09-22 Thread Vladimir Sementsov-Ogievskiy
ping ) 27.08.2021 21:17, Vladimir Sementsov-Ogievskiy wrote: Hi all! That continues "[PATCH RFC DRAFT 00/11] Make image fleecing more usable" and supersedes "[PATCH v2 for-6.2 0/6] push backup with fleecing" Supersedes: <20210804131750.127574-1-vsement...@virtuozzo.com> Supersedes:

Re: [PATCH v3 19/35] acpi: build_waet: use acpi_table_begin()/acpi_table_end() instead of build_header()

2021-09-22 Thread Eric Auger
On 9/7/21 4:47 PM, Igor Mammedov wrote: > it replaces error-prone pointer arithmetic for build_header() API, > with 2 calls to start and finish table creation, > which hides offsets magic from API user. > > Signed-off-by: Igor Mammedov > --- > v3: > *

Re: [PATCH] spapr_numa.c: fixes in spapr_numa_FORM2_write_rtas_tables()

2021-09-22 Thread BALATON Zoltan
On Wed, 22 Sep 2021, Greg Kurz wrote: On Tue, 21 Sep 2021 16:43:47 -0300 Daniel Henrique Barboza wrote: This patch has a handful of modifications for the recent added FORM2 support: - there is no particular reason for both 'lookup_index_table' and 'distance_table' to be allocated in the

Re: Change TCG cache size?

2021-09-22 Thread Alex Bennée
Kenneth Adam Miller writes: > Hello all, > > I just want to ask this one question: if I change the qemu tcg cache > size (TB_JMP_CACHE_SIZE), will that force any errors at run time? Hopefully not - for both user-mode and softmmu we take some care to ensure tb_jmp_cache_hash_func and

Re: [PATCH] spapr_numa.c: fixes in spapr_numa_FORM2_write_rtas_tables()

2021-09-22 Thread Daniel Henrique Barboza
On 9/22/21 08:17, Philippe Mathieu-Daudé wrote: On 9/21/21 21:43, Daniel Henrique Barboza wrote: This patch has a handful of modifications for the recent added FORM2 support: - there is no particular reason for both 'lookup_index_table' and 'distance_table' to be allocated in the heap,

Re: [PATCH v4 17/20] nubus-bridge: make slot_available_mask a qdev property

2021-09-22 Thread Mark Cave-Ayland
On 20/09/2021 21:12, Laurent Vivier wrote: Le 17/09/2021 à 09:50, Mark Cave-Ayland a écrit : This is to allow Macintosh machines to further specify which slots are available since the number of addressable slots may not match the number of physical slots present in the machine. Signed-off-by:

Re: [RFC 0/5] VirtIO RDMA

2021-09-22 Thread Junji Wei
> On Sep 15, 2021, at 9:43 PM, Jason Gunthorpe wrote: > > On Thu, Sep 02, 2021 at 09:06:20PM +0800, Junji Wei wrote: >> Hi all, >> >> This RFC aims to reopen the discussion of Virtio RDMA. >> Now this is based on Yuval Shaia's RFC "VirtIO RDMA" >> which implemented a frame for Virtio RDMA and a

Re: [PATCH v3 18/35] acpi: build_dmar_q35: use acpi_table_begin()/acpi_table_end() instead of build_header()

2021-09-22 Thread Eric Auger
On 9/7/21 4:47 PM, Igor Mammedov wrote: > it replaces error-prone pointer arithmetic for build_header() API, > with 2 calls to start and finish table creation, > which hides offsets magic from API user. > > While at it switch to build_append_int_noprefix() to build > table entries tables. > >

Re: [RFC v7] virtio/vsock: add two more queues for datagram types

2021-09-22 Thread Stefano Garzarella
On Wed, Sep 22, 2021 at 12:00:24AM +, Jiang Wang wrote: Datagram sockets are connectionless and unreliable. The sender does not know the capacity of the receiver and may send more packets than the receiver can handle. Add two more dedicate virtqueues for datagram sockets, so that it will

Re: [PATCH v3 17/35] acpi: use build_append_int_noprefix() API to compose SRAT table

2021-09-22 Thread Igor Mammedov
On Wed, 22 Sep 2021 10:55:20 +0200 Eric Auger wrote: > On 9/7/21 4:47 PM, Igor Mammedov wrote: > > Drop usage of packed structures and explicit endian conversions > > when building SRAT tables for arm/x86 and use endian agnostic > > build_append_int_noprefix() API to build it. > > > >

Re: [PATCH v4 09/20] macfb: don't register declaration ROM

2021-09-22 Thread Mark Cave-Ayland
On 20/09/2021 21:01, Laurent Vivier wrote: Le 17/09/2021 à 09:50, Mark Cave-Ayland a écrit : The macfb device is an on-board framebuffer and so is initialised by the system declaration ROM included within the MacOS toolbox ROM. Signed-off-by: Mark Cave-Ayland --- hw/display/macfb.c | 6

Re: [PATCH] spapr_numa.c: fixes in spapr_numa_FORM2_write_rtas_tables()

2021-09-22 Thread BALATON Zoltan
On Wed, 22 Sep 2021, Daniel Henrique Barboza wrote: On 9/22/21 06:51, BALATON Zoltan wrote: On Wed, 22 Sep 2021, Greg Kurz wrote: On Tue, 21 Sep 2021 16:43:47 -0300 Daniel Henrique Barboza wrote: This patch has a handful of modifications for the recent added FORM2 support: - there is no

Re: [PATCH] spapr_numa.c: fixes in spapr_numa_FORM2_write_rtas_tables()

2021-09-22 Thread Greg Kurz
On Wed, 22 Sep 2021 13:17:32 +0200 Philippe Mathieu-Daudé wrote: > On 9/21/21 21:43, Daniel Henrique Barboza wrote: > > This patch has a handful of modifications for the recent added > > FORM2 support: > > > > - there is no particular reason for both 'lookup_index_table' and > >

Re: [PATCH v1] monitor: Consider "id" when rate-limiting MEMORY_DEVICE_SIZE_CHANGE qapi events

2021-09-22 Thread Markus Armbruster
David Hildenbrand writes: > We have to consider the device id, otherwise we'll lose some events for > unrelated devices. If the device does not have a device id (very unlikely), > the target of the notifications has to update the size of all devices > manually either way. > > This was noticed by

Re: [PATCH v3 17/35] acpi: use build_append_int_noprefix() API to compose SRAT table

2021-09-22 Thread Eric Auger
On 9/7/21 4:47 PM, Igor Mammedov wrote: > Drop usage of packed structures and explicit endian conversions > when building SRAT tables for arm/x86 and use endian agnostic > build_append_int_noprefix() API to build it. > > Signed-off-by: Igor Mammedov > --- > v3: > * rebase on top of

Re: [PATCH v3 20/35] acpi: build_amd_iommu: use acpi_table_begin()/acpi_table_end() instead of build_header()

2021-09-22 Thread Eric Auger
On 9/7/21 4:47 PM, Igor Mammedov wrote: > it replaces error-prone pointer arithmetic for build_header() API, > with 2 calls to start and finish table creation, > which hides offsets magic from API user. > > Signed-off-by: Igor Mammedov > --- > v3: > *

Re: [PATCH v3 22/35] acpi: x86: remove dead code

2021-09-22 Thread Eric Auger
On 9/7/21 4:48 PM, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov > --- > include/hw/acpi/acpi-defs.h | 13 - > 1 file changed, 13 deletions(-) > > diff --git a/include/hw/acpi/acpi-defs.h b/include/hw/acpi/acpi-defs.h > index c7fa5caa06..af4fa412a5 100644 > ---

Re: [PATCH v3 23/35] acpi: x86: set enabled when composing _MAT entries

2021-09-22 Thread Eric Auger
On 9/7/21 4:48 PM, Igor Mammedov wrote: > Instead of composing disabled _MAT entry and then later on > patching it to enabled for hotpluggbale CPUs in DSDT, > set it to enabled at the time _MAT entry is built. > > It will allow to drop usage of packed structures in > following patches when

Re: [PATCH v3 03/15] target/ppc: PMU basic cycle count for pseries TCG

2021-09-22 Thread Matheus K. Ferst
On 03/09/2021 17:31, Daniel Henrique Barboza wrote: [E-MAIL EXTERNO] Não clique em links ou abra anexos, a menos que você possa confirmar o remetente e saber que o conteúdo é seguro. Em caso de e-mail suspeito entre imediatamente em contato com o DTI. This patch adds the barebones of the PMU

[PATCH 1/3] docs: rSTify the "SpellCheck" wiki

2021-09-22 Thread Kashyap Chamarthy
The original wiki is here[1]. I converted by copying the wiki source[2] into a .wiki file and convert to rST using `pandoc`: $ pandoc -f Mediawiki -t rst spell-check.wiki -o spell-check.rst [1] https://wiki.qemu.org/Contribute/SpellCheck [2]

[PATCH 0/3] rSTify SubmitAPatch, TrivialPatches, and SpellCheck wiki pages

2021-09-22 Thread Kashyap Chamarthy
As of writing this, qemu.org is down, so I've used a one-month old copy[1] of the wiki from 27Aug2021 to do the rST conversion. My main motivation was to convert SubmitAPatch (when Peter Maydell pointed out on IRC that it's still on the wiki). But it links to a couple more small wiki pages; so I

[PATCH 07/14] bsd-user/target_os_elf.h: Remove fallback ELF_HWCAP and reorder

2021-09-22 Thread Warner Losh
All architectures have a ELF_HWCAP, so remove the fallback ifdef. Place ELF_HWCAP in the same order as on native FreeBSD. Signed-off-by: Warner Losh --- bsd-user/freebsd/target_os_elf.h | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/bsd-user/freebsd/target_os_elf.h

[PATCH 04/14] bsd-user: export get_errno and is_error from syscall.c

2021-09-22 Thread Warner Losh
Make get_errno and is_error global so files other than syscall.c can use them. Signed-off-by: Warner Losh --- bsd-user/qemu.h| 4 bsd-user/syscall.c | 10 +- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h index

Re: [PATCH v2] spapr/xive: Fix kvm_xive_source_reset trace event

2021-09-22 Thread Cédric Le Goater
On 9/22/21 09:06, Greg Kurz wrote: On Wed, 22 Sep 2021 09:02:05 +0200 Cédric Le Goater wrote: The trace event was placed in the wrong routine. Move it under kvmppc_xive_source_reset_one(). Fixes: 4e960974d4ee ("xive: Add trace events") Signed-off-by: Cédric Le Goater --- Reviewed-by: Greg

[PATCH 03/14] bsd-user: TARGET_RESET define is unused, remove it

2021-09-22 Thread Warner Losh
Signed-off-by: Warner Losh --- bsd-user/i386/target_arch_cpu.h | 2 -- bsd-user/x86_64/target_arch_cpu.h | 2 -- 2 files changed, 4 deletions(-) diff --git a/bsd-user/i386/target_arch_cpu.h b/bsd-user/i386/target_arch_cpu.h index 978e8066af..b28602adbb 100644 ---

[PATCH v2] spapr/xive: Fix kvm_xive_source_reset trace event

2021-09-22 Thread Cédric Le Goater
The trace event was placed in the wrong routine. Move it under kvmppc_xive_source_reset_one(). Fixes: 4e960974d4ee ("xive: Add trace events") Signed-off-by: Cédric Le Goater --- hw/intc/spapr_xive_kvm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v2] iotests/check: move long options to double dash

2021-09-22 Thread Vladimir Sementsov-Ogievskiy
ping. Patch is reviewed) 03.09.2021 15:00, Vladimir Sementsov-Ogievskiy wrote: So, the change: -makecheck -> --makecheck -gdb -> --gdb -valgrind -> --valgrind -misalign -> --misalign -nocache -> --nocache -qcow2 (and other formats) -> --qcow2 -file (and other

[PATCH 11/14] bsd-user/sysarch: Move to using do_freebsd_arch_sysarch interface

2021-09-22 Thread Warner Losh
Convert the #ifdef'd i386 code to calling the i386 sysarch code we have living in i386,x86_64/target_arch_sysarch.h do_freebsd_arch_sysarch rather than having a separate copy. This is in preparation to remove it entirely. Signed-Off-By: Warner Losh --- bsd-user/syscall.c | 45

Re: ensuring a machine's buses have unique names

2021-09-22 Thread Cédric Le Goater
On 9/22/21 09:02, Markus Armbruster wrote: Peter Maydell writes: On Wed, 15 Sept 2021 at 05:28, Markus Armbruster wrote: Peter Maydell writes: I'm not sure how best to sort this tangle out. We could: * make controller devices pass in NULL as bus name; this means that some bus names

[PATCH 02/14] bsd-user/strace.list: Remove support for FreeBSD versions older than 12.0

2021-09-22 Thread Warner Losh
Signed-off-by: Warner Losh --- bsd-user/freebsd/strace.list | 11 --- 1 file changed, 11 deletions(-) diff --git a/bsd-user/freebsd/strace.list b/bsd-user/freebsd/strace.list index b01b5f36e8..275d2dbe27 100644 --- a/bsd-user/freebsd/strace.list +++ b/bsd-user/freebsd/strace.list @@

[PATCH 12/14] bsd-user/sysarch: Provide a per-arch framework for sysarch syscall

2021-09-22 Thread Warner Losh
Add the missing glue to pull in do_freebsd_sysarch to call do_freebsd_arch_sysarch. Put it in os-sys.c, which will be used for sysctl and sysarch system calls because they are mostly arch specific. Signed-off-by: Stacey Son Signed-off-by: Warner Losh --- bsd-user/freebsd/meson.build | 3 +++

[PATCH 09/14] bsd-user: Remove used from TaskState

2021-09-22 Thread Warner Losh
The used field of TaskState is write only. Eliminate it. Signed-off-by: Warner Losh --- bsd-user/main.c | 1 - bsd-user/qemu.h | 1 - 2 files changed, 2 deletions(-) diff --git a/bsd-user/main.c b/bsd-user/main.c index 48643eeabc..ee84554854 100644 --- a/bsd-user/main.c +++ b/bsd-user/main.c

[PATCH 14/14] bsd-user/signal: Create a dummy signal queueing function

2021-09-22 Thread Warner Losh
Create dummy signal queueing function so we can start to integrate other architectures (at the cost of signals remaining broken) to tame the dependency graph a bit and to bring in signals in a more controlled fashion. Signed-off-by: Warner Losh --- bsd-user/qemu.h | 1 + bsd-user/signal.c | 8

Re: [PATCH v2] spapr/xive: Fix kvm_xive_source_reset trace event

2021-09-22 Thread Greg Kurz
On Wed, 22 Sep 2021 09:02:05 +0200 Cédric Le Goater wrote: > The trace event was placed in the wrong routine. Move it under > kvmppc_xive_source_reset_one(). > > Fixes: 4e960974d4ee ("xive: Add trace events") > Signed-off-by: Cédric Le Goater > --- Reviewed-by: Greg Kurz >

Re: [PATCH v15] qapi: introduce 'query-x86-cpuid' QMP command.

2021-09-22 Thread Vladimir Sementsov-Ogievskiy
Ping. Hi! Any chance for this to land? The solution is very simple now: we don't modify any logic and just export kvm_cpuid2 entries as simple and flat QAPI list. What's the problem with it? If any doubts, we can go with x- prefix for a new command. 16.08.2021 17:51, Valeriy Vdovin wrote:

Re: [PATCH v6 00/11] 64bit block-layer: part II

2021-09-22 Thread Vladimir Sementsov-Ogievskiy
Ping) Not reviewed: 6,7,10 03.09.2021 13:27, Vladimir Sementsov-Ogievskiy wrote: Hi all! Sorry for a long delay:( Finally, here is v6. v6: rebase on new rbd handlers and backup-top renamed to copy-before-write. Also: 01: add Eric's r-b tweak commit msg to not mention sheepdog 02: add

[PATCH 05/14] bsd-user/errno_defs.h: Add internal error numbers

2021-09-22 Thread Warner Losh
From: Stacey Son To emulate signals and interrupted system calls, we need to have the same mechanisms we have in the kernel, including these errno values. Signed-off-by: Stacey Son Signed-off-by: Warner Losh --- bsd-user/errno_defs.h | 14 +++--- 1 file changed, 11 insertions(+), 3

Re: [PATCH] nvdimm: release the correct device list

2021-09-22 Thread Michael S. Tsirkin
On Fri, Sep 17, 2021 at 02:59:33PM +0200, Igor Mammedov wrote: > On Mon, 13 Sep 2021 06:40:01 + > "lizhij...@fujitsu.com" wrote: > > > ping again > > Michael, > > can you include this in your next pull req, please? ok > > > > > > > > On 30/08/2021 09:04, Li Zhijian wrote: > > > ping >

Re: [PATCH v2] block: drop BLK_PERM_GRAPH_MOD

2021-09-22 Thread Vladimir Sementsov-Ogievskiy
Ping) Patch is reviewed. 02.09.2021 12:37, Vladimir Sementsov-Ogievskiy wrote: First, this permission never protected a node from being changed, as generic child-replacing functions don't check it. Second, it's a strange thing: it presents a permission of parent node to change its child. But

[PATCH 00/14] bsd-user: misc cleanup for aarch64 import

2021-09-22 Thread Warner Losh
Prepare for aarch64 support (the next architecture to be upstreamed). As the aarch64 emulation is more complete, it relies on a number of different items. In some cases, I've pulled in the full support from bsd-user fork. In other cases I've created a simple stub (as is the case for signals, which

Re: [PATCH v6 00/21] Add LoongArch linux-user emulation support

2021-09-22 Thread Song Gao
Hi, Richard. On 09/21/2021 05:17 AM, Richard Henderson wrote: > On 9/17/21 1:12 AM, Song Gao wrote: >> The 'o32' code has been deleted at the latest kernel [1]. This series only >> support >> linux-user emulation. > > I have now reviewed all but the linux-user/ portion. > Thank you! > I see

Re: [PATCH] nbd/client: Request larger block status by default

2021-09-22 Thread Vladimir Sementsov-Ogievskiy
21.09.2021 23:00, Eric Blake wrote: On Tue, Sep 21, 2021 at 10:12:02PM +0300, Vladimir Sementsov-Ogievskiy wrote: 21.09.2021 21:08, Eric Blake wrote: On Tue, Sep 21, 2021 at 08:25:11PM +0300, Vladimir Sementsov-Ogievskiy wrote: 21.09.2021 19:17, Eric Blake wrote: Now that commit 5a1cfd21 has

Re: [PATCH v6 0/5] block/nbd: drop connection_co

2021-09-22 Thread Vladimir Sementsov-Ogievskiy
ping) Only one patch is not reviewed. But the biggest one :( 02.09.2021 13:38, Vladimir Sementsov-Ogievskiy wrote: v6: 01,02: add Eric's r-b 03: make new interface clearer 04,05: rebased on updated 03 Vladimir Sementsov-Ogievskiy (5): block/nbd: nbd_channel_error() shutdown channel

[PATCH 01/14] bsd-user/target_os-user.h: Remove support for FreeBSD older than 12.0

2021-09-22 Thread Warner Losh
Signed-off-by: Warner Losh --- bsd-user/freebsd/target_os_user.h | 100 +- 1 file changed, 1 insertion(+), 99 deletions(-) diff --git a/bsd-user/freebsd/target_os_user.h b/bsd-user/freebsd/target_os_user.h index 95b1fa9f99..19892c5071 100644 ---

[PATCH 06/14] bsd-user: move TARGET_MC_GET_CLEAR_RET to target_os_signal.h

2021-09-22 Thread Warner Losh
Move TARGET_MC_GET_CLEAR_RET to freebsd/target_os_signal.h since it's FreeBSD-wide. Signed-off-by: Warner Losh --- bsd-user/freebsd/target_os_signal.h | 3 +++ bsd-user/i386/target_arch_signal.h | 2 -- bsd-user/x86_64/target_arch_signal.h | 2 -- 3 files changed, 3 insertions(+), 4

[PATCH 13/14] bsd-user: Rename sigqueue to qemu_sigqueue

2021-09-22 Thread Warner Losh
To avoid a name clash with FreeBSD's sigqueue data structure in signalvar.h, rename sigqueue to qemu_sigqueue. This sturcture is currently defined, but unused. Signed-off-by: Warner Losh --- bsd-user/qemu.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

[PATCH 10/14] bsd-user: Add stop_all_tasks

2021-09-22 Thread Warner Losh
Similar to the same function in linux-user: this stops all the current tasks. Signed-off-by: Stacey Son Signed-off-by: Warner Losh --- bsd-user/main.c | 9 + bsd-user/qemu.h | 1 + 2 files changed, 10 insertions(+) diff --git a/bsd-user/main.c b/bsd-user/main.c index

Re: ensuring a machine's buses have unique names

2021-09-22 Thread Markus Armbruster
Peter Maydell writes: > On Wed, 15 Sept 2021 at 05:28, Markus Armbruster wrote: >> >> Peter Maydell writes: >> > I'm not sure how best to sort this tangle out. We could: >> > * make controller devices pass in NULL as bus name; this >> >means that some bus names will change, which is an

Re: [PATCH v3 16/35] acpi: arm/x86: build_srat: use acpi_table_begin()/acpi_table_end() instead of build_header()

2021-09-22 Thread Eric Auger
Hi Igor, On 9/7/21 4:47 PM, Igor Mammedov wrote: > it replaces error-prone pointer arithmetic for build_header() API, > with 2 calls to start and finish table creation, > which hides offsets magic from API user. nit: also removes AcpiSystemResourceAffinityTable and use build_append_int_noprefix

Re: [PATCH v7 00/11] qcow2: fix parallel rewrite and discard (reqlist)

2021-09-22 Thread Vladimir Sementsov-Ogievskiy
Ping. Hi Kevin! Could you look at description in cover-letter and 07-09, and say do you like the approach in general? Then I can resend with reqlist included and without "Based-on". Or do you still prefer the solution with RWLock? I don't like RWLock-based blocking solution, because: 1.

Re: [PATCH v3 28/35] acpi: arm: virt: build_iort: use acpi_table_begin()/acpi_table_end() instead of build_header()

2021-09-22 Thread Eric Auger
Hi Igor, On 9/7/21 4:48 PM, Igor Mammedov wrote: > it replaces error-prone pointer arithmetic for build_header() API, > with 2 calls to start and finish table creation, > which hides offsets magic from API user. > > Signed-off-by: Igor Mammedov > --- > v3: > * fix conflicts due to >

Re: [PATCH 2/3] docs: rSTify the "TrivialPatches" wiki

2021-09-22 Thread Philippe Mathieu-Daudé
Hi Kashyap, On 9/22/21 14:10, Kashyap Chamarthy wrote: The original wiki is here[1]. I converted by copying the wiki source into a .wiki file and convert to rST using `pandoc`: $ pandoc -f Mediawiki -t rst trivial-patches.wiki -o trivial-patches.rst [1]

[RFC PATCH] spapr/xive: Allocate vCPU IPIs from local context

2021-09-22 Thread Cédric Le Goater
When QEMU switches to the XIVE interrupt mode, it creates all possible guest interrupts at the level of the KVM device. These interrupts are backed by real HW interrupts from the IPI interrupt pool of the XIVE controller. Currently, this is done from the QEMU main thread, which results in

Re: [PATCH v2 14/30] tcg/loongarch64: Implement bswap32_i32/bswap32_i64/bswap64_i64

2021-09-22 Thread Richard Henderson
On 9/21/21 1:18 PM, WANG Xuerui wrote: +case INDEX_op_bswap32_i32: +/* All 32-bit values are computed sign-extended in the register. */ +a2 = TCG_BSWAP_OS; +/* fallthrough */ +case INDEX_op_bswap32_i64: +tcg_out_opc_revb_2w(s, a0, a1); +if (a2 &

Re: [PATCH v2 15/30] tcg/loongarch64: Implement clz/ctz ops

2021-09-22 Thread Richard Henderson
On 9/21/21 1:19 PM, WANG Xuerui wrote: Signed-off-by: WANG Xuerui --- tcg/loongarch64/tcg-target-con-set.h | 1 + tcg/loongarch64/tcg-target.c.inc | 42 2 files changed, 43 insertions(+) Reviewed-by: Richard Henderson r~

Re: [PATCH v2 16/30] tcg/loongarch64: Implement shl/shr/sar/rotl/rotr ops

2021-09-22 Thread Richard Henderson
On 9/21/21 1:19 PM, WANG Xuerui wrote: Signed-off-by: WANG Xuerui --- tcg/loongarch64/tcg-target-con-set.h | 1 + tcg/loongarch64/tcg-target.c.inc | 91 2 files changed, 92 insertions(+) Reviewed-by: Richard Henderson r~

Re: [PATCH v2 20/30] tcg/loongarch64: Implement setcond ops

2021-09-22 Thread Richard Henderson
On 9/21/21 1:19 PM, WANG Xuerui wrote: +static void tcg_out_setcond(TCGContext *s, TCGCond cond, TCGReg ret, +TCGReg arg1, TCGReg arg2, bool c1, bool c2) +{ +TCGReg tmp; + +if (c1) { +tcg_debug_assert(arg1 == 0); +} +if (c2) { +

Re: [PATCH v2 3/3] dump-guest-memory: Block live migration

2021-09-22 Thread Marc-André Lureau
Hi On Thu, Aug 26, 2021 at 11:01 PM Peter Xu wrote: > Both dump-guest-memory and live migration caches vm state at the beginning. > Either of them entering the other one will cause race on the vm state, and > even > more severe on that (please refer to the crash report in the bug link). > >

Re: [PATCH v2 09/30] tcg/loongarch64: Implement tcg_out_mov and tcg_out_movi

2021-09-22 Thread Richard Henderson
On 9/22/21 8:16 AM, WANG Xuerui wrote: Hi Richard, On 9/22/21 12:25, Richard Henderson wrote: On 9/21/21 1:18 PM, WANG Xuerui wrote: +    /* Test for PC-relative values that can be loaded faster.  */ +    intptr_t pc_offset = val - (uintptr_t)s->code_ptr; This isn't quite right for split

Re: [PATCH v3 17/35] acpi: use build_append_int_noprefix() API to compose SRAT table

2021-09-22 Thread Eric Auger
On 9/22/21 12:02 PM, Igor Mammedov wrote: > On Wed, 22 Sep 2021 10:55:20 +0200 > Eric Auger wrote: > >> On 9/7/21 4:47 PM, Igor Mammedov wrote: >>> Drop usage of packed structures and explicit endian conversions >>> when building SRAT tables for arm/x86 and use endian agnostic >>>

[PATCH v2 0/1] fixes in spapr_numa_FORM2_write_rtas_tables()

2021-09-22 Thread Daniel Henrique Barboza
Hi, This new version contains suggestions from Greg, Phillipe and Zoltan that were made in the v1. Changes from v1: - keep the heap allocation of both arrays; - use stl_be_p(); - use sizeof(uint32_t) instead of hardcoding '4' when skipping the length; - use the existing NUMA_DISTANCE_MIN macro.

Re: [PATCH] spapr_numa.c: fixes in spapr_numa_FORM2_write_rtas_tables()

2021-09-22 Thread Philippe Mathieu-Daudé
On 9/22/21 13:52, Greg Kurz wrote: On Wed, 22 Sep 2021 13:17:32 +0200 Philippe Mathieu-Daudé wrote: On 9/21/21 21:43, Daniel Henrique Barboza wrote: This patch has a handful of modifications for the recent added FORM2 support: - there is no particular reason for both 'lookup_index_table'

Re: ensuring a machine's buses have unique names

2021-09-22 Thread Markus Armbruster
BALATON Zoltan writes: > On Wed, 22 Sep 2021, Markus Armbruster wrote: >> BALATON Zoltan writes: >>> To me it looks like device code can't really set a globally unique >>> name on creating the bus without getting some help from upper >>> levels. So maybe naming busses should be done by qdev (or

Re: [PATCH v6 00/11] 64bit block-layer: part II

2021-09-22 Thread Eric Blake
On Wed, Sep 22, 2021 at 10:52:20AM +0300, Vladimir Sementsov-Ogievskiy wrote: > Ping) > > Not reviewed: 6,7,10 Also on my list to see what I can get in this week's NBD pull request. > > 03.09.2021 13:27, Vladimir Sementsov-Ogievskiy wrote: > > Hi all! > > > > Sorry for a long delay:(

[PATCH] 9pfs: fix wrong I/O block size in Rgetattr

2021-09-22 Thread Christian Schoenebeck
When client sent a 9p Tgetattr request then the wrong I/O block size value was returned by 9p server; instead of host file system's I/O block size it should rather return an I/O block size according to 9p session's 'msize' value, because the value returned to client should be an "optimum" block

Re: [PATCH v3 29/35] acpi: arm/virt: convert build_iort() to endian agnostic build_append_FOO() API

2021-09-22 Thread Igor Mammedov
On Wed, 22 Sep 2021 15:26:49 +0200 Eric Auger wrote: I'll fix patch up as suggested, though there is a question, see below > On 9/7/21 4:48 PM, Igor Mammedov wrote: > > Signed-off-by: Igor Mammedov > > --- > > v3: > > * practically rewritten, due to conflicts wiht bypass iommu feature > > >

Re: [PATCH v3 11/35] acpi: nvdimm_build_ssdt: use acpi_table_begin()/acpi_table_end() instead of build_header()

2021-09-22 Thread Igor Mammedov
On Mon, 20 Sep 2021 18:41:30 +0200 Eric Auger wrote: > Hi Igor, > > On 9/7/21 4:47 PM, Igor Mammedov wrote: > > it replaces error-prone pointer arithmetic for build_header() API, > > with 2 calls to start and finish table creation, > > which hides offsets magic from API user. > > > >

[RFC PATCH] tests/docker: add a debian-native image and make available

2021-09-22 Thread Alex Bennée
This image is intended for building whatever the native versions of QEMU are for the host architecture. This will hopefully be an aid for 3rd parties who want to be able to build QEMU themselves without redoing all the dependencies themselves. We disable the registry because we currently don't

Re: [PATCH v11 06/10] hvf: arm: Implement -cpu host

2021-09-22 Thread Peter Maydell
On Wed, 22 Sept 2021 at 12:41, Ard Biesheuvel wrote: > > On Thu, 16 Sept 2021 at 18:17, Peter Maydell wrote: > > > > On Thu, 16 Sept 2021 at 17:05, Ard Biesheuvel wrote: > > > I'd argue that compliance with the architecture means that the > > > software should not clear RES1 bits > > > >

[PATCH 2/2] tests/qapi-schema: Make test-qapi.py -u work when files are absent

2021-09-22 Thread Markus Armbruster
test-qapi.py -u updates the expected files. Since it fails when they are absent, users have to create them manually before they can use test-qapi.py to fill in the contents, say for a new test. Silly. Improve -u to create them. Signed-off-by: Markus Armbruster ---

[PATCH 1/2] tests/qapi-schema: Use Python OSError instead of outmoded IOError

2021-09-22 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- tests/qapi-schema/test-qapi.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qapi-schema/test-qapi.py b/tests/qapi-schema/test-qapi.py index 73cffae2b6..2e384f5efd 100755 --- a/tests/qapi-schema/test-qapi.py +++

Re: [PATCH 1/3] docs: rSTify the "SpellCheck" wiki

2021-09-22 Thread Peter Maydell
On Wed, 22 Sept 2021 at 13:11, Kashyap Chamarthy wrote: > > The original wiki is here[1]. I converted by copying the wiki source[2] > into a .wiki file and convert to rST using `pandoc`: > > $ pandoc -f Mediawiki -t rst spell-check.wiki -o spell-check.rst > > [1]

Re: [PATCH 0/3] rSTify SubmitAPatch, TrivialPatches, and SpellCheck wiki pages

2021-09-22 Thread Kashyap Chamarthy
On Wed, Sep 22, 2021 at 02:05:24PM +0100, Peter Maydell wrote: > On Wed, 22 Sept 2021 at 13:11, Kashyap Chamarthy wrote: > > > > As of writing this, qemu.org is down, so I've used a one-month old > > copy[1] of the wiki from 27Aug2021 to do the rST conversion. > > The wiki is now back up, and it

Re: [PATCH v3 29/35] acpi: arm/virt: convert build_iort() to endian agnostic build_append_FOO() API

2021-09-22 Thread Eric Auger
On 9/7/21 4:48 PM, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov > --- > v3: > * practically rewritten, due to conflicts wiht bypass iommu feature > > CC: drjo...@redhat.com > CC: peter.mayd...@linaro.org > CC: shannon.zha...@gmail.com > CC: qemu-...@nongnu.org > CC:

Re: [PATCH v3 34/35] acpi: remove no longer used build_header()

2021-09-22 Thread Eric Auger
On 9/7/21 4:48 PM, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov Reviewed-by: Eric Auger Eric > --- > include/hw/acpi/acpi-defs.h | 25 - > include/hw/acpi/aml-build.h | 4 > hw/acpi/aml-build.c | 23 --- > 3 files changed, 52

  1   2   3   4   >