Re: [PATCH 1/2] hw/dma: sifive_pdma: Improve code readability for "!!foo & bar"

2021-09-27 Thread Markus Armbruster
Bin Meng writes: > Hi Markus, > > On Mon, Sep 27, 2021 at 2:51 PM Markus Armbruster wrote: >> >> Bin Meng writes: >> >> > GCC seems to be strict about processing pattern like "!!for & bar". >> > When 'bar' is not 0 or 1, it complains with -Werror=parentheses: >> > >> > suggest parentheses

[PATCH v2 1/2] hw/dma: sifive_pdma: Fix Control.claim bit detection

2021-09-27 Thread Bin Meng
At present the codes detect whether the DMA channel is claimed by: claimed = !!s->chan[ch].control & CONTROL_CLAIM; As ! has higher precedence over & (bitwise and), this is essentially claimed = (!!s->chan[ch].control) & CONTROL_CLAIM; which is wrong, as any non-zero bit set in the control

[PATCH v2 2/2] hw/dma: sifive_pdma: Don't run DMA when channel is disclaimed

2021-09-27 Thread Bin Meng
If Control.run bit is set while not preserving the Control.claim bit, the DMA transfer shall not be started. The following result is PDMA tested in U-Boot on Unleashed board: => mw.l 0x300 0x0 <= Disclaim channel 0 => mw.l 0x300 0x1 <= Claim

Re: gitlab-ci: amd64-opensuse-leap-container job failing

2021-09-27 Thread Daniel P . Berrangé
On Sun, Sep 26, 2021 at 07:23:56PM +0200, Philippe Mathieu-Daudé wrote: > Hi, > > FYI the OpenSUSE job is failing since few days, i.e.: > https://gitlab.com/qemu-project/qemu/-/jobs/1622345026 > > Retrieving repository 'Main Repository' metadata >

[PULL 3/5] hmp: Unbreak "change vnc"

2021-09-27 Thread Laurent Vivier
From: Markus Armbruster HMP command "change vnc" can take the password as argument, or prompt for it: (qemu) change vnc password 123 (qemu) change vnc password Password: *** (qemu) This regressed in commit cfb5387a1d "hmp: remove "change vnc TARGET" command", v6.0.0.

Re: [PATCH v2] target/i386: Use assert() to sanity-check b1 in SSE decode

2021-09-27 Thread Peter Maydell
Ping^2 ! thanks -- PMM On Mon, 13 Sept 2021 at 13:34, Peter Maydell wrote: > > Ping? (this has been reviewed) > > thanks > -- PMM > > On Wed, 1 Sept 2021 at 15:10, Peter Maydell wrote: > > > > In the SSE decode function gen_sse(), we combine a byte > > 'b' and a value 'b1' which can be [0..3],

Re: [PATCH 06/11] qdev: Add Error parameter to qdev_set_id()

2021-09-27 Thread Damien Hedde
Hi Kevin, I proposed a very similar patch in our rfc series because we needed some of the cleaning you do here. https://lists.gnu.org/archive/html/qemu-devel/2021-09/msg05679.html I've added a bit of doc for the function, feel free to take it if you want. On 9/24/21 16:09, Vladimir

Re: [PATCH] allwinner-h3: Switch to SMC as PSCI conduit

2021-09-27 Thread Philippe Mathieu-Daudé
On 9/20/21 22:39, Alexander Graf wrote: > The Allwinner H3 SoC uses Cortex-A7 cores which support virtualization. > However, today we are configuring QEMU to use HVC as PSCI conduit. > > That means HVC calls get trapped into QEMU instead of the guest's own > emulated CPU and thus break the

Re: [PATCH v3 05/27] linux-user/arm: Implement setup_sigtramp

2021-09-27 Thread Peter Maydell
On Fri, 24 Sept 2021 at 17:59, Richard Henderson wrote: > > Update the trampoline code to match the kernel: this uses > sp-relative accesses rather than pc-relative. > > Signed-off-by: Richard Henderson These functions must write at most 8 bytes: > +static void write_arm_sigreturn(uint32_t

Re: [PATCH v3 0/9] hw/nvram: hw/arm: Introduce Xilinx eFUSE and BBRAM

2021-09-27 Thread Peter Maydell
On Fri, 17 Sept 2021 at 06:24, Tong Ho wrote: > > This series implements the Xilinx eFUSE and BBRAM devices for > the Versal and ZynqMP product families. > > Furthermore, both new devices are connected to the xlnx-versal-virt > board and the xlnx-zcu102 board. > > See changes in

Re: [PATCH v3 1/3] hw/virtio: Comment virtqueue_flush() must be called with RCU read lock

2021-09-27 Thread Cornelia Huck
On Mon, Sep 27 2021, Philippe Mathieu-Daudé wrote: > On 9/27/21 12:18, Cornelia Huck wrote: >> On Mon, Sep 06 2021, Philippe Mathieu-Daudé wrote: >> >>> Reported-by: Stefano Garzarella >>> Suggested-by: Stefan Hajnoczi >>> Signed-off-by: Philippe Mathieu-Daudé >>> --- >>>

Re: [PATCH 11/11] Deprecate stable non-JSON -device and -object

2021-09-27 Thread Daniel P . Berrangé
On Mon, Sep 27, 2021 at 12:17:03PM +0200, Kevin Wolf wrote: > Am 27.09.2021 um 10:21 hat Daniel P. Berrangé geschrieben: > > On Mon, Sep 27, 2021 at 10:15:43AM +0200, Paolo Bonzini wrote: > > > On 24/09/21 11:04, Kevin Wolf wrote: > > > > We want to switch both from QemuOpts to the keyval parser

Re: [PATCH 1/2] bsd-user: Only process meson rules on BSD host

2021-09-27 Thread Warner Losh
On Mon, Sep 27, 2021 at 4:08 AM Peter Maydell wrote: > On Mon, 27 Sept 2021 at 10:59, Daniel P. Berrangé > wrote: > > If we look at linux-user/meson.build though things are more complex. > > There we have alot of sub-dirs, and meson.biuld in those dirs adds > > generators for various files. So

Re: [PATCH 09/11] qdev: Avoid QemuOpts in QMP device_add

2021-09-27 Thread Damien Hedde
On 9/24/21 11:04, Kevin Wolf wrote: Directly call qdev_device_add_from_qdict() for QMP device_add instead of first going through QemuOpts and converting back to QDict. Note that this changes the behaviour of device_add, though in ways that should be considered bug fixes: QemuOpts ignores

Re: [PATCH v3 1/3] hw/virtio: Comment virtqueue_flush() must be called with RCU read lock

2021-09-27 Thread Philippe Mathieu-Daudé
On 9/27/21 12:18, Cornelia Huck wrote: > On Mon, Sep 06 2021, Philippe Mathieu-Daudé wrote: > >> Reported-by: Stefano Garzarella >> Suggested-by: Stefan Hajnoczi >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> include/hw/virtio/virtio.h | 7 +++ >> hw/virtio/virtio.c | 1 + >>

Re: [PATCH v3 2/9] qapi: make blockdev-add a coroutine command

2021-09-27 Thread Vladimir Sementsov-Ogievskiy
07.09.2021 09:14, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: 06.09.2021 22:28, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: We are going to support nbd reconnect on open in a next commit. This means that we want to do several connection attempts during

Re: [question] VFIO Device Migration: The vCPU may be paused during vfio device DMA in iommu nested stage mode && vSVA

2021-09-27 Thread Kunkun Jiang
Hi Kevin: On 2021/9/24 14:47, Tian, Kevin wrote: From: Kunkun Jiang Sent: Friday, September 24, 2021 2:19 PM Hi all, I encountered a problem in vfio device migration test. The vCPU may be paused during vfio-pci DMA in iommu nested stage mode && vSVA. This may lead to migration fail and other

Re: [PULL 00/25] QAPI patches patches for 2021-09-25

2021-09-27 Thread Markus Armbruster
Peter Maydell writes: > On Sat, 25 Sept 2021 at 07:25, Markus Armbruster wrote: >> >> The following changes since commit 11a11998460ed84d9a127c025f50f7234e5a483f: >> >> Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20210921' into >> staging (2021-09-24 13:21:18 -0400) >> >> are

Re: [PATCH v1 1/1] hw/riscv: shakti_c: Mark as not user creatable

2021-09-27 Thread Bin Meng
On Mon, Sep 27, 2021 at 3:13 PM Alistair Francis wrote: > > From: Alistair Francis > > Mark the shakti_c machine as not user creatable as it uses serial_hd. > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/639 > Signed-off-by: Alistair Francis > --- > hw/riscv/shakti_c.c | 2 ++ > 1

Re: [PATCH] hw/misc: Add a virtual pci device to dynamically attach memory to QEMU

2021-09-27 Thread Stefan Hajnoczi
On Sun, Sep 26, 2021 at 10:16:14AM +0800, David Dai wrote: > Add a virtual pci to QEMU, the pci device is used to dynamically attach memory > to VM, so driver in guest can apply host memory in fly without virtualization > management software's help, such as libvirt/manager. The attached memory is

Re: [PATCH 1/2] bsd-user: Only process meson rules on BSD host

2021-09-27 Thread Philippe Mathieu-Daudé
On Mon, Sep 27, 2021 at 11:15 AM Peter Maydell wrote: > On Sun, 26 Sept 2021 at 23:04, Philippe Mathieu-Daudé wrote: > > Reported-by: Warner Losh > > Signed-off-by: Philippe Mathieu-Daudé > > --- > > bsd-user/meson.build | 4 > > 1 file changed, 4 insertions(+) > > > > diff --git

Re: gitlab-ci: amd64-opensuse-leap-container job failing

2021-09-27 Thread Philippe Mathieu-Daudé
On 9/27/21 10:35, Daniel P. Berrangé wrote: > On Sun, Sep 26, 2021 at 07:23:56PM +0200, Philippe Mathieu-Daudé wrote: >> Hi, >> >> FYI the OpenSUSE job is failing since few days, i.e.: >> https://gitlab.com/qemu-project/qemu/-/jobs/1622345026 > It isn't confined to only SuSE. In libvirt we've had

Re: [PATCH 1/2] bsd-user: Only process meson rules on BSD host

2021-09-27 Thread Peter Maydell
On Mon, 27 Sept 2021 at 10:59, Daniel P. Berrangé wrote: > If we look at linux-user/meson.build though things are more complex. > There we have alot of sub-dirs, and meson.biuld in those dirs adds > generators for various files. So conceivably skipping linux-user > will mean we won't

Re: [PATCH v3 1/3] hw/virtio: Comment virtqueue_flush() must be called with RCU read lock

2021-09-27 Thread Cornelia Huck
On Mon, Sep 06 2021, Philippe Mathieu-Daudé wrote: > Reported-by: Stefano Garzarella > Suggested-by: Stefan Hajnoczi > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/virtio/virtio.h | 7 +++ > hw/virtio/virtio.c | 1 + > 2 files changed, 8 insertions(+) > > diff --git

Re: [PATCH v3 0/5] introduce QArray

2021-09-27 Thread Greg Kurz
On Mon, 27 Sep 2021 12:35:16 +0200 Christian Schoenebeck wrote: > On Dienstag, 31. August 2021 14:25:04 CEST Christian Schoenebeck wrote: > > On Dienstag, 31. August 2021 13:58:02 CEST Greg Kurz wrote: > > > On Thu, 26 Aug 2021 14:47:26 +0200 > > > > > > Christian Schoenebeck wrote: > > > >

Re: [PATCH 11/11] Deprecate stable non-JSON -device and -object

2021-09-27 Thread Kevin Wolf
Am 27.09.2021 um 11:00 hat Peter Maydell geschrieben: > On Fri, 24 Sept 2021 at 10:14, Kevin Wolf wrote: > > > > We want to switch both from QemuOpts to the keyval parser in the future, > > which results in some incompatibilities, mainly around list handling. > > Mark the non-JSON version of both

Re: [PATCH 09/11] qdev: Avoid QemuOpts in QMP device_add

2021-09-27 Thread Kevin Wolf
Am 27.09.2021 um 13:06 hat Damien Hedde geschrieben: > On 9/24/21 11:04, Kevin Wolf wrote: > > Directly call qdev_device_add_from_qdict() for QMP device_add instead of > > first going through QemuOpts and converting back to QDict. > > > > Note that this changes the behaviour of device_add, though

Re: [PATCH] hw/misc: Add a virtual pci device to dynamically attach memory to QEMU

2021-09-27 Thread david.dai
On Mon, Sep 27, 2021 at 10:27:06AM +0200, Stefan Hajnoczi (stefa...@redhat.com) wrote: > On Sun, Sep 26, 2021 at 10:16:14AM +0800, David Dai wrote: > > Add a virtual pci to QEMU, the pci device is used to dynamically attach > > memory > > to VM, so driver in guest can apply host memory in fly

Re: [PATCH v3 0/5] introduce QArray

2021-09-27 Thread Christian Schoenebeck
On Dienstag, 31. August 2021 14:25:04 CEST Christian Schoenebeck wrote: > On Dienstag, 31. August 2021 13:58:02 CEST Greg Kurz wrote: > > On Thu, 26 Aug 2021 14:47:26 +0200 > > > > Christian Schoenebeck wrote: > > > Patches 1 and 2 introduce include/qemu/qarray.h which implements a deep > > >

Re: [PATCH v12 10/10] arm: tcg: Adhere to SMCCC 1.3 section 5.2

2021-09-27 Thread Peter Maydell
On Thu, 16 Sept 2021 at 16:54, Alexander Graf wrote: > > The SMCCC 1.3 spec section 5.2 says > > The Unknown SMC Function Identifier is a sign-extended value of (-1) > that is returned in the R0, W0 or X0 registers. An implementation must > return this error code when it receives: > > *

Re: [PATCH] hw: Add a 'Sensor devices' qdev category

2021-09-27 Thread Corey Minyard
On Mon, Sep 27, 2021 at 12:15:18AM +0200, Philippe Mathieu-Daudé wrote: > Sensors models are listed in the 'Misc devices' category. > Move them to their own category. > > For the devices in the hw/sensor/ directory, the category > is obvious. > > hw/arm/z2.c models the AER915 model which is

Re: [PATCH v6 4/5] block/nbd: drop connection_co

2021-09-27 Thread Vladimir Sementsov-Ogievskiy
24.09.2021 20:44, Eric Blake wrote: On Thu, Sep 02, 2021 at 01:38:04PM +0300, Vladimir Sementsov-Ogievskiy wrote: OK, that's a big rewrite of the logic. And a time-consuming review on my part! Pre-patch we have an always running coroutine - connection_co. It does reply receiving and

Re: [PATCH] hw/misc: Add a virtual pci device to dynamically attach memory to QEMU

2021-09-27 Thread david.dai
On Mon, Sep 27, 2021 at 11:07:43AM +0200, David Hildenbrand (da...@redhat.com) wrote: > > CAUTION: This email originated from outside of the organization. Do not > click links or open attachments unless you recognize the sender and know the > content is safe. > > > On 27.09.21 10:27, Stefan

Re: [PATCH v7 12/40] accel/qtest: Implement AccelOpsClass::has_work()

2021-09-27 Thread Laurent Vivier
On 25/09/2021 18:01, Philippe Mathieu-Daudé wrote: On 9/25/21 17:32, Richard Henderson wrote: On 9/25/21 11:27 AM, Philippe Mathieu-Daudé wrote: +static bool qtest_cpu_has_work(CPUState *cpu) +{ +    g_assert_not_reached(); +} Sigh, this triggers: Running test qtest-i386/cpu-plug-test **

[PULL 1/5] docs/nvdimm: Update nvdimm option value in machine example

2021-09-27 Thread Laurent Vivier
From: Pankaj Gupta Update nvdimm option value in example command from "-machine pc,nvdimm" to "-machine pc,nvdimm=on" as former complains with the below error: "qemu-system-x86_64: -machine pc,nvdimm: Expected '=' after parameter 'nvdimm'" Reviewed-by: Laurent Vivier Signed-off-by: Pankaj

Re: [PATCH 1/2] bsd-user: Only process meson rules on BSD host

2021-09-27 Thread Peter Maydell
On Mon, 27 Sept 2021 at 10:40, Philippe Mathieu-Daudé wrote: > > On Mon, Sep 27, 2021 at 11:15 AM Peter Maydell > wrote: > > On Sun, 26 Sept 2021 at 23:04, Philippe Mathieu-Daudé > > wrote: > > > Reported-by: Warner Losh > > > Signed-off-by: Philippe Mathieu-Daudé > > > --- > > >

[PULL 4/5] hmp: Drop a bogus sentence from set_password's documentation

2021-09-27 Thread Laurent Vivier
From: Markus Armbruster Signed-off-by: Markus Armbruster Reviewed-by: Daniel P. Berrangé Reviewed-by: Gerd Hoffmann Message-Id: <20210909081219.308065-3-arm...@redhat.com> Signed-off-by: Laurent Vivier --- hmp-commands.hx | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-)

Re: [PATCH v10 11/14] machine: Make smp_parse generic enough for all arches

2021-09-27 Thread Daniel P . Berrangé
On Sun, Sep 26, 2021 at 04:45:38PM +0800, Yanan Wang wrote: > Currently the only difference between smp_parse and pc_smp_parse > is the support of dies parameter and the related error reporting. > With some arch compat variables like "bool dies_supported", we can > make smp_parse generic enough

Re: [PATCH 11/11] Deprecate stable non-JSON -device and -object

2021-09-27 Thread Kevin Wolf
Am 27.09.2021 um 10:21 hat Daniel P. Berrangé geschrieben: > On Mon, Sep 27, 2021 at 10:15:43AM +0200, Paolo Bonzini wrote: > > On 24/09/21 11:04, Kevin Wolf wrote: > > > We want to switch both from QemuOpts to the keyval parser in the future, > > > which results in some incompatibilities, mainly

Re: [PATCH v5 03/26] hostmem: Add hostmem-epc as a backend for SGX EPC

2021-09-27 Thread Philippe Mathieu-Daudé
On 9/24/21 13:24, Paolo Bonzini wrote: > From: Sean Christopherson > > EPC (Enclave Page Cahe) is a specialized type of memory used by Intel Typo "Enclave Page Cache". > SGX (Software Guard Extensions). The SDM desribes EPC as: > > The Enclave Page Cache (EPC) is the secure storage used

Re: [PATCH v15] qapi: introduce 'query-x86-cpuid' QMP command.

2021-09-27 Thread Thomas Huth
On 22/09/2021 09.41, Vladimir Sementsov-Ogievskiy wrote: Ping. Hi! Any chance for this to land? Sorry if I missed the outcome of the discussion - but what about the idea to introduce this with a "x-" prefix first, since there was no 100% certainty that we really fully want to support this

[PATCH v1 1/1] hw/riscv: shakti_c: Mark as not user creatable

2021-09-27 Thread Alistair Francis
From: Alistair Francis Mark the shakti_c machine as not user creatable as it uses serial_hd. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/639 Signed-off-by: Alistair Francis --- hw/riscv/shakti_c.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/riscv/shakti_c.c

Re: [PATCH] configure: Loosen GCC requirement from 7.5.0 to 7.4.0

2021-09-27 Thread Daniel P . Berrangé
On Sun, Sep 26, 2021 at 07:22:14AM +, nia wrote: > As discussed in issue 614, we're shipping GCC 7.4.0 as the > system compiler in NetBSD 9, the most recent stable branch, > and are still actively interested in QEMU on this platform. > > The differences between GCC 7.5.0 and 7.4.0 are

Re: [PATCH v2 0/6] iotests: update environment and linting configuration

2021-09-27 Thread Kevin Wolf
Am 24.09.2021 um 20:13 hat John Snow geschrieben: > On Thu, Sep 23, 2021 at 2:07 PM John Snow wrote: > > > GitLab: https://gitlab.com/jsnow/qemu/-/commits/python-package-iotest-pt1 > > CI: https://gitlab.com/jsnow/qemu/-/pipelines/376236687 > > > > This series partially supersedes: > > [PATCH

Re: [PATCH 1/2] bsd-user: Only process meson rules on BSD host

2021-09-27 Thread Daniel P . Berrangé
On Mon, Sep 27, 2021 at 12:01:02AM +0200, Philippe Mathieu-Daudé wrote: > Reported-by: Warner Losh > Signed-off-by: Philippe Mathieu-Daudé > --- > bsd-user/meson.build | 4 > 1 file changed, 4 insertions(+) > > diff --git a/bsd-user/meson.build b/bsd-user/meson.build > index

Re: [PULL 1/5] hw/pcie-root-port: Fix hotplug for PCI devices requiring IO

2021-09-27 Thread Michael S. Tsirkin
On Mon, Sep 27, 2021 at 10:33:42AM +0100, Daniel P. Berrangé wrote: > On Tue, Aug 03, 2021 at 04:52:03PM -0400, Michael S. Tsirkin wrote: > > From: Marcel Apfelbaum > > > > Q35 has now ACPI hotplug enabled by default for PCI(e) devices. > > As opposed to native PCIe hotplug, guests like Fedora

Re: [PATCH v5 04/26] qom: Add memory-backend-epc ObjectOptions support

2021-09-27 Thread Yang Zhong
On Fri, Sep 24, 2021 at 08:56:40AM -0500, Eric Blake wrote: > On Fri, Sep 24, 2021 at 01:24:47PM +0200, Paolo Bonzini wrote: > > From: Yang Zhong > > > > Add the new 'memory-backend-epc' user creatable QOM object in > > the ObjectOptions to support SGX since v6.1, or the sgx backend > > object

Re: [PATCH 1/2] hw/dma: sifive_pdma: Improve code readability for "!!foo & bar"

2021-09-27 Thread Bin Meng
Hi Philippe, On Mon, Sep 27, 2021 at 12:47 PM Philippe Mathieu-Daudé wrote: > > On 9/27/21 04:21, Bin Meng wrote: > > GCC seems to be strict about processing pattern like "!!for & bar". > > When 'bar' is not 0 or 1, it complains with -Werror=parentheses: > > > > suggest parentheses around

Re: [PATCH 1/2] hw/dma: sifive_pdma: Improve code readability for "!!foo & bar"

2021-09-27 Thread Bin Meng
Hi Markus, On Mon, Sep 27, 2021 at 2:51 PM Markus Armbruster wrote: > > Bin Meng writes: > > > GCC seems to be strict about processing pattern like "!!for & bar". > > When 'bar' is not 0 or 1, it complains with -Werror=parentheses: > > > > suggest parentheses around operand of ‘!’ or change

Re: [PATCH 11/11] Deprecate stable non-JSON -device and -object

2021-09-27 Thread Paolo Bonzini
On 24/09/21 11:04, Kevin Wolf wrote: We want to switch both from QemuOpts to the keyval parser in the future, which results in some incompatibilities, mainly around list handling. Mark the non-JSON version of both as unstable syntax so that management tools switch to JSON and we can later make

Re: [PATCH 1/2] bsd-user: Only process meson rules on BSD host

2021-09-27 Thread Peter Maydell
On Sun, 26 Sept 2021 at 23:04, Philippe Mathieu-Daudé wrote: > > Reported-by: Warner Losh > Signed-off-by: Philippe Mathieu-Daudé > --- > bsd-user/meson.build | 4 > 1 file changed, 4 insertions(+) > > diff --git a/bsd-user/meson.build b/bsd-user/meson.build > index

Re: [PULL 1/5] hw/pcie-root-port: Fix hotplug for PCI devices requiring IO

2021-09-27 Thread Daniel P . Berrangé
On Tue, Aug 03, 2021 at 04:52:03PM -0400, Michael S. Tsirkin wrote: > From: Marcel Apfelbaum > > Q35 has now ACPI hotplug enabled by default for PCI(e) devices. > As opposed to native PCIe hotplug, guests like Fedora 34 > will not assign IO range to pcie-root-ports not supporting > native

[PULL 2/5] hw/loader: Restrict PC_ROM_* definitions to hw/i386/pc

2021-09-27 Thread Laurent Vivier
From: Philippe Mathieu-Daudé The PC_ROM_* definitions are only used by the PC machine, and are irrelevant to the other architectures / machines. Reduce their scope by moving them to hw/i386/pc.c. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier Message-Id:

Re: [PATCH 1/1] hw: aspeed_gpio: Fix GPIO array indexing

2021-09-27 Thread Cédric Le Goater
On 9/25/21 16:28, Peter Delevoryas wrote: On Sep 25, 2021, at 4:03 AM, Philippe Mathieu-Daudé wrote: Hi Peter, On 9/24/21 08:19, p...@fb.com wrote: From: Peter Delevoryas The gpio array is declared as a dense array: ... qemu_irq gpios[ASPEED_GPIO_NR_PINS]; (AST2500 has 228, AST2400 has

Re: [PATCH 11/11] Deprecate stable non-JSON -device and -object

2021-09-27 Thread Daniel P . Berrangé
On Mon, Sep 27, 2021 at 10:15:43AM +0200, Paolo Bonzini wrote: > On 24/09/21 11:04, Kevin Wolf wrote: > > We want to switch both from QemuOpts to the keyval parser in the future, > > which results in some incompatibilities, mainly around list handling. > > Mark the non-JSON version of both as

Re: [PATCH] hw/arm/virt: Allow additions to the generated device tree

2021-09-27 Thread Peter Maydell
On Sun, 26 Sept 2021 at 19:55, Simon Glass wrote: > In the case of U-Boot at least, it uses the devicetree for > configuration (it is a boot loader, so there is no user space to > provide configuration). So the current setup is not sufficient to boot > it correctly in all cases. On the other

Re: gitlab-ci: amd64-opensuse-leap-container job failing

2021-09-27 Thread Al Cho
On Mon, 2021-09-27 at 09:35 +0100, Daniel P. Berrangé wrote: > On Sun, Sep 26, 2021 at 07:23:56PM +0200, Philippe Mathieu-Daudé wrote: > > Hi, > > > > FYI the OpenSUSE job is failing since few days, i.e.: > > https://gitlab.com/qemu-project/qemu/-/jobs/1622345026 > > > >   Retrieving repository

[PULL 0/5] Trivial branch for 6.2 patches

2021-09-27 Thread Laurent Vivier
-request for you to fetch changes up to 45b09cb12f5440971b321fc255e3930f38366ace: multi-process: fix usage information (2021-09-27 10:57:21 +0200) Trivial patches pull request 20210927

[PULL 5/5] multi-process: fix usage information

2021-09-27 Thread Laurent Vivier
From: Dongli Zhang >From source code, the 'devid' of x-remote-object should be one of devices in remote QEMU process. Signed-off-by: Dongli Zhang Reviewed-by: Jagannathan Raman Reviewed-by: Laurent Vivier Message-Id: <20210713004718.20381-1-dongli.zh...@oracle.com> Signed-off-by: Laurent

Re: [PATCH 1/2] hw/dma: sifive_pdma: Improve code readability for "!!foo & bar"

2021-09-27 Thread Markus Armbruster
Bin Meng writes: > GCC seems to be strict about processing pattern like "!!for & bar". > When 'bar' is not 0 or 1, it complains with -Werror=parentheses: > > suggest parentheses around operand of ‘!’ or change ‘&’ to ‘&&’ or ‘!’ to > ‘~’ [-Werror=parentheses] > > Add a () around "foo && bar",

[PATCH v3] migration/rdma: Fix out of order wrid

2021-09-27 Thread Li Zhijian
destination: ../qemu/build/qemu-system-x86_64 -enable-kvm -netdev tap,id=hn0,script=/etc/qemu-ifup,downscript=/etc/qemu-ifdown -device e1000,netdev=hn0,mac=50:52:54:00:11:22 -boot c -drive if=none,file=./Fedora-rdma-server-migration.qcow2,id=drive-virtio-disk0 -device

Re: [PATCH] hw/misc: Add a virtual pci device to dynamically attach memory to QEMU

2021-09-27 Thread David Hildenbrand
On 27.09.21 10:27, Stefan Hajnoczi wrote: On Sun, Sep 26, 2021 at 10:16:14AM +0800, David Dai wrote: Add a virtual pci to QEMU, the pci device is used to dynamically attach memory to VM, so driver in guest can apply host memory in fly without virtualization management software's help, such as

Re: [PATCH v4 29/35] acpi: arm/virt: convert build_iort() to endian agnostic build_append_FOO() API

2021-09-27 Thread Eric Auger
On 9/24/21 2:27 PM, Igor Mammedov wrote: > Drop usage of packed structures and explicit endian conversions > when building IORT table use endian agnostic build_append_int_noprefix() > API to build it. > > Signed-off-by: Igor Mammedov > --- > CC: Eric Auger > > v4: > - (Eric Auger ) > *

virtio-gpu: Get FD for texture

2021-09-27 Thread Antonio Caggiano
Hi, I am trying to support a Vulkan application in the guest (GTKGlArea+VirGL+venus) which needs to import a GL texture from a GL context. Before doing that, I need to get a FD for that texture, therefore I tried with calling egl-helpers.h:egl_get_fd_for_texture() but I get an epoxy error:

Re: [PATCH] allwinner-h3: Switch to SMC as PSCI conduit

2021-09-27 Thread Peter Maydell
On Wed, 22 Sept 2021 at 20:41, Niek Linnenbank wrote: > > Hi Alexander, > > I've tested your patch on the acceptance tests and they all pass: > > ARMBIAN_ARTIFACTS_CACHED=yes AVOCADO_ALLOW_LARGE_STORAGE=yes avocado > --show=app,console run -t machine:orangepi-pc >

Re: Add LoongArch support to RISU?

2021-09-27 Thread Stefan Hajnoczi
On Sun, Sep 26, 2021 at 04:35:37PM +0200, Philippe Mathieu-Daudé wrote: > Hi, I meant to include the qemu-devel@ mailing list in Cc but forgot to... > Doing that now. > > On Sun, Sep 26, 2021 at 11:25 AM Song Gao wrote: > > > > Hi, Phil > > > > On 09/26/2021 04:25 PM, Philippe Mathieu-Daudé

Re: [PATCH 11/11] Deprecate stable non-JSON -device and -object

2021-09-27 Thread Peter Maydell
On Fri, 24 Sept 2021 at 10:14, Kevin Wolf wrote: > > We want to switch both from QemuOpts to the keyval parser in the future, > which results in some incompatibilities, mainly around list handling. > Mark the non-JSON version of both as unstable syntax so that management > tools switch to JSON

Re: [PATCH 00/16] Acceptance Tests: use Avocado 91.0 features and other improvements

2021-09-27 Thread Pavel Dovgalyuk
Hi, Cleber! What about record/replay tests from 25.06? On 24.09.2021 21:54, Cleber Rosa wrote: This is a collection of patches for the Acceptance Tests to leverage some of the features of Avocado 91.0. With the Avocado version bump by itself, there would be a change in the default "test

Re: [PATCH] hw: Add a 'Sensor devices' qdev category

2021-09-27 Thread Cédric Le Goater
On 9/27/21 00:15, Philippe Mathieu-Daudé wrote: Sensors models are listed in the 'Misc devices' category. Move them to their own category. For the devices in the hw/sensor/ directory, the category is obvious. hw/arm/z2.c models the AER915 model which is described on [*] as: The 14-pin chip

Re: [PATCH v3 11/27] linux-user/x86_64: Raise SIGSEGV if SA_RESTORER not set

2021-09-27 Thread Peter Maydell
On Fri, 24 Sept 2021 at 17:59, Richard Henderson wrote: > > This has been a fixme for some time. The effect of > returning -EFAULT from the kernel code is to raise SIGSEGV. > > Signed-off-by: Richard Henderson > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2] nbd/server: Add --selinux-label option

2021-09-27 Thread Daniel P . Berrangé
On Wed, Aug 25, 2021 at 02:35:04PM -0500, Eric Blake wrote: > On Fri, Jul 23, 2021 at 05:38:06PM +0100, Daniel P. Berrangé wrote: > > On Fri, Jul 23, 2021 at 06:18:55PM +0200, Kevin Wolf wrote: > > > Am 23.07.2021 um 12:33 hat Richard W.M. Jones geschrieben: > > > > Under SELinux, Unix domain

[PULL v2 25/25] tests/qapi-schema: Make test-qapi.py -u work when files are absent

2021-09-27 Thread Markus Armbruster
test-qapi.py -u updates the expected files. Since it fails when they are absent, users have to create them manually before they can use test-qapi.py to fill in the contents, say for a new test. Silly. Improve -u to create them. Signed-off-by: Markus Armbruster Message-Id:

[PULL v2 24/25] tests/qapi-schema: Use Python OSError instead of outmoded IOError

2021-09-27 Thread Markus Armbruster
https://docs.python.org/3.6/library/exceptions.html has Changed in version 3.3: EnvironmentError, IOError, WindowsError, socket.error, select.error and mmap.error have been merged into OSError, and the constructor may return a subclass. and The following exceptions are kept for

[PULL v2 07/25] qapi: Convert simple union ChardevBackend to flat one

2021-09-27 Thread Markus Armbruster
Simple unions predate flat unions. Having both complicates the QAPI schema language and the QAPI generator. We haven't been using simple unions in new code for a long time, because they are less flexible and somewhat awkward on the wire. To prepare for their removal, convert simple union

[PULL v2 20/25] tests/qapi-schema: Purge simple unions from tests

2021-09-27 Thread Markus Armbruster
Drop tests that are specifically about simple unions: * SugaredUnion in doc-good: flat unions are covered by @Object. * union-branch-case and union-clash-branches: branch naming for flat unions is enforced for the tag enum instead, which is covered by enum-member-case and enum-clash-member.

[PULL v2 23/25] test-clone-visitor: Correct an accidental rename

2021-09-27 Thread Markus Armbruster
Commit b359f4b203 "tests: Rename UserDefNativeListUnion to UserDefListUnion" renamed test_clone_native_list() to test_clone_list_union(). The function has nothing to do with unions. Rename it to test_clone_list(). Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-Id:

Re: [PATCH v3 16/27] linux-user/nios2: Properly emulate EXCP_TRAP

2021-09-27 Thread Peter Maydell
On Fri, 24 Sept 2021 at 17:59, Richard Henderson wrote: > > The real kernel has to load the instruction and extract > the imm5 field; for qemu, modify the translator to do this. > > The use of R_AT for this in cpu_loop was a bug. Handle > the other trap numbers as per the kernel's trap_table. >

Re: [PATCH v3 21/27] linux-user/ppc: Implement setup_sigtramp

2021-09-27 Thread Peter Maydell
On Fri, 24 Sept 2021 at 17:59, Richard Henderson wrote: > > Create and record the two signal trampolines. > > Cc: qemu-...@nongnu.org > Signed-off-by: Richard Henderson > --- > linux-user/ppc/target_signal.h | 2 ++ > linux-user/ppc/signal.c| 34 ++ > 2

Re: [PATCH v3 17/27] linux-user/nios2: Map a real kuser page

2021-09-27 Thread Peter Maydell
On Fri, 24 Sept 2021 at 17:59, Richard Henderson wrote: > > The first word of page1 is data, so the whole thing > can't be implemented with emulation of addresses. > > Hijack trap number 31 to implement cmpxchg. 31 is used -- it's "breakpoint". We need to pick something else... > > Set

[PATCH v2 0/2] modules: Improve modinfo.c support

2021-09-27 Thread Jose R. Ziviani
This patchset introduces the modinfo_need and changes modinfo-generate.py/meson.build to generate/link one modinfo per target. modinfo-generate.py will know, thanks to modinfo_need, which modules are currently enabled for a given target before adding it in the array of modules. It will give a

Re: [PATCH 4/6] avocado_qemu: tweak ssh connect method

2021-09-27 Thread Philippe Mathieu-Daudé
On 9/20/21 22:49, Willian Rampazzo wrote: > The current implementation will crash if the connection fails as the > `time` module is not imported. This fixes the import problem and tweaks > the connection to wait progressively when the connection fails. > > Signed-off-by: Willian Rampazzo > --- >

[PATCH 0/1] virtio-gpu: CONTEXT_INIT feature

2021-09-27 Thread Antonio Caggiano
This is a different attempt at upstreaming the work I have been doing to enable support for the Venus Virtio-GPU Vulkan driver. I believe the previous one [0] was a bit too much stuff in one place, therefore with this I would like to try a more fine-grained approach. I will just start by the

Re: gitlab-ci: amd64-opensuse-leap-container job failing

2021-09-27 Thread Daniel P . Berrangé
On Mon, Sep 27, 2021 at 04:35:04PM +0200, Philippe Mathieu-Daudé wrote: > On 9/27/21 15:47, Daniel P. Berrangé wrote: > > On Mon, Sep 27, 2021 at 09:35:22AM +0100, Daniel P. Berrangé wrote: > >> On Sun, Sep 26, 2021 at 07:23:56PM +0200, Philippe Mathieu-Daudé wrote: > >>> Hi, > >>> > >>> FYI the

Re: [PATCH] hw: Add a 'Sensor devices' qdev category

2021-09-27 Thread Philippe Mathieu-Daudé
On 9/27/21 13:33, Corey Minyard wrote: > On Mon, Sep 27, 2021 at 12:15:18AM +0200, Philippe Mathieu-Daudé wrote: >> Sensors models are listed in the 'Misc devices' category. >> Move them to their own category. >> >> For the devices in the hw/sensor/ directory, the category >> is obvious. >> >>

[PULL v2 14/25] test-clone-visitor: Wean off UserDefListUnion

2021-09-27 Thread Markus Armbruster
test_clone_complex1() uses simple union UserDefListUnion to cover unions. Use UserDefFlatUnion instead. Arrays are still covered by test_clone_complex3(). Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-Id: <20210917143134.412106-15-arm...@redhat.com> ---

[PULL v2 15/25] tests/qapi-schema: Wean off UserDefListUnion

2021-09-27 Thread Markus Armbruster
Command boxed-union uses simple union UserDefListUnion to cover unions. Use UserDefFlatUnion instead. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-Id: <20210917143134.412106-16-arm...@redhat.com> --- tests/unit/test-qmp-cmds.c | 2 +-

[PULL v2 09/25] qapi: Convert simple union ImageInfoSpecific to flat one

2021-09-27 Thread Markus Armbruster
Simple unions predate flat unions. Having both complicates the QAPI schema language and the QAPI generator. We haven't been using simple unions in new code for a long time, because they are less flexible and somewhat awkward on the wire. To prepare for their removal, convert simple union

[PULL v2 22/25] tests/qapi-schema: Rename flat-union-* test cases to union-*

2021-09-27 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Message-Id: <20210917143134.412106-23-arm...@redhat.com> Reviewed-by: Eric Blake union-array-branch.json} | 0 ...rray-branch.out => union-array-branch.out} | 0 tests/qapi-schema/union-bad-base.err | 2 ++ ...nion-bad-base.json =>

[PULL v2 16/25] tests/qapi-schema: Simple union UserDefListUnion is now unused, drop

2021-09-27 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-Id: <20210917143134.412106-17-arm...@redhat.com> --- tests/qapi-schema/qapi-schema-test.json | 17 --- tests/qapi-schema/qapi-schema-test.out | 64 - 2 files changed, 81 deletions(-) diff --git

Re: [PATCH] tcg/riscv: Fix potential bug in clobbered call register set

2021-09-27 Thread Richard Henderson
On 9/27/21 1:36 AM, Philippe Mathieu-Daudé wrote: There are not 64 registers, so this is incorrect. Currently there are 32 registers, but I was looking at this draft: https://five-embeddev.com/riscv-v-spec/draft/v-spec.html#_vector_registers "The vector extension adds 32 architectural vector

[PATCH v3 1/3] tests/acpi: Add void table for virt/DBG2 bios-tables-test

2021-09-27 Thread Eric Auger
Add placeholders for DBG2 reference table for virt tests and ignore till reference blob is added. Signed-off-by: Eric Auger Acked-by: Igor Mammedov --- v2 -> v3: - commit msg rewording according to Igor's suggestion and added Igor's A-b. --- tests/qtest/bios-tables-test-allowed-diff.h | 1 +

[PATCH v3 2/3] hw/arm/virt_acpi_build: Generate DBG2 table

2021-09-27 Thread Eric Auger
ARM SBBR specification mandates DBG2 table (Debug Port Table 2) since v1.0 (ARM DEN0044F 8.3.1.7 DBG2). The DBG2 table allows to describe one or more debug ports. Generate an DBG2 table featuring a single debug port, the PL011. The DBG2 specification can be found at "Microsoft Debug Port Table

Re: gitlab-ci: amd64-opensuse-leap-container job failing

2021-09-27 Thread Daniel P . Berrangé
On Mon, Sep 27, 2021 at 09:35:22AM +0100, Daniel P. Berrangé wrote: > On Sun, Sep 26, 2021 at 07:23:56PM +0200, Philippe Mathieu-Daudé wrote: > > Hi, > > > > FYI the OpenSUSE job is failing since few days, i.e.: > > https://gitlab.com/qemu-project/qemu/-/jobs/1622345026 > > > > Retrieving

[PATCH v2 0/2] modules: Improve modinfo.c support

2021-09-27 Thread Jose R. Ziviani
This patchset introduces the modinfo_need and changes modinfo-generate.py/meson.build to generate/link one modinfo per target. modinfo-generate.py will know, thanks to modinfo_need, which modules are currently enabled for a given target before adding it in the array of modules. It will give a

Re: Need to merge - QEMU patch for booting eMMC image for AST2600 machine

2021-09-27 Thread Cédric Le Goater
Hello, On 9/26/21 09:59, Philippe Mathieu-Daudé wrote: Hi, On 9/25/21 19:07, Shitalkumar Gandhi via wrote: Hi, I am attaching a patch that will fix eMMC image booting on QEMU for AST2600 machine, without this patch it will be stuck after SPL saying, "booting from RAM". Please review and

Re: [PATCH] hw/arm/virt: Allow additions to the generated device tree

2021-09-27 Thread Peter Maydell
On Mon, 27 Sept 2021 at 16:18, Simon Glass wrote: > On Mon, 27 Sept 2021 at 02:48, Peter Maydell wrote: > > So what is missing in the QEMU-provided DTB that it needs? > > Quite a lot. Here are some examples: > > U-Boot has limited pre-relocation memory so tries to avoid > binding/probing devices

Re: [PATCH] hw: Add a 'Sensor devices' qdev category

2021-09-27 Thread Hao Wu
On Mon, Sep 27, 2021 at 3:03 AM Cédric Le Goater wrote: > On 9/27/21 00:15, Philippe Mathieu-Daudé wrote: > > Sensors models are listed in the 'Misc devices' category. > > Move them to their own category. > > > > For the devices in the hw/sensor/ directory, the category > > is obvious. > > > >

[PULL v2 04/25] qapi: Convert simple union InputEvent to flat one

2021-09-27 Thread Markus Armbruster
Simple unions predate flat unions. Having both complicates the QAPI schema language and the QAPI generator. We haven't been using simple unions in new code for a long time, because they are less flexible and somewhat awkward on the wire. To prepare for their removal, convert simple union

[PULL v2 02/25] qapi: Stop enforcing "type name should not end in 'Kind'

2021-09-27 Thread Markus Armbruster
I'm about to convert simple unions to flat unions, then drop simple union support. The conversion involves making the implict enum types explicit. To reduce churn, I'd like to name them exactly like the implicit types they replace. However, these names are reserved for the generator's use.

[PULL v2 11/25] tests/qapi-schema: Prepare for simple union UserDefListUnion removal

2021-09-27 Thread Markus Armbruster
Simple unions predate flat unions. Having both complicates the QAPI schema language and the QAPI generator. We haven't been using simple unions in new code for a long time, because they are less flexible and somewhat awkward on the wire. To prepare for their removal, simple union

  1   2   3   4   >