On 23/09/21 02:49, John Snow wrote:
This is a wrapper around the async QMPClient that mimics the old,
synchronous QEMUMonitorProtocol class. It is designed to be
interchangeable with the old implementation.
It does not, however, attempt to mimic Exception compatibility.
Signed-off-by: John
From: Vladimir Sementsov-Ogievskiy
Add version of bdrv_new_open_driver() that supports QDict options.
We'll use it in further commit.
Simply add one more argument to bdrv_new_open_driver() is worse, as
there are too many invocations of bdrv_new_open_driver() to update
then.
Signed-off-by:
Hi Drew,
On 10/6/21 9:35 PM, Andrew Jones wrote:
On Wed, Oct 06, 2021 at 06:22:08PM +0800, Gavin Shan wrote:
The following option is used to specify the distance map. It's
possible the option isn't provided by user. In this case, the
distance map isn't populated and exposed to platform. On the
From: John Snow
1. Ignore the new f-strings warning, we're not interested in doing a
full conversion at this time.
2. Just mute the unbalanced-tuple-unpacking warning, it's not a real
error in this case and muting the dozens of callsites is just not
worth it.
3. Add encodings to
On 10/6/21 13:49, Philippe Mathieu-Daudé wrote:
On 10/6/21 13:37, Damien Hedde wrote:
Right now, we cannot load some binary file if it is bigger than the
machine's ram size. This limitation only occurs when loading a
binary file: we can load a corresponding elf file without this
limitation.
Convert blk_pdiscard, blk_pwrite_compressed, blk_pwrite_zeroes.
These are just wrappers for functions with int64_t argument, so allow
passing int64_t as well. Parameter type becomes wider so all callers
should be OK with it.
Note that requests exceeding INT_MAX are still restricted by
On 2021-09-30 at 11:30 -04, Vivek Goyal wrote...
> Add helpers to create/cleanup virtuqueues and use those helpers. I will
Typo, virtuqueues -> virtqueues
Also, while I'm nitpicking, virtqueue could be plural in commit description ;-)
> need to reconfigure queues in later patches and using
On Wed, Oct 06, 2021 at 02:50:07PM +0200, Christian Schoenebeck wrote:
> On Mittwoch, 6. Oktober 2021 13:06:55 CEST Stefan Hajnoczi wrote:
> > On Tue, Oct 05, 2021 at 06:32:46PM +0200, Christian Schoenebeck wrote:
> > > On Dienstag, 5. Oktober 2021 17:10:40 CEST Stefan Hajnoczi wrote:
> > > > On
From: Philipp Tomsich
dup_const always generates a uint64_t, which may exceed the size of a
target_long (generating warnings with recent-enough compilers).
To ensure that we can use dup_const both for 64bit and 32bit targets,
this adds dup_const_tl, which either maps back to dup_const (for
Kevin Wolf writes:
> Am 05.10.2021 um 15:49 hat Markus Armbruster geschrieben:
>> Kevin Wolf writes:
>>
>> > Am 02.10.2021 um 15:33 hat Markus Armbruster geschrieben:
>> >> I apologize for this wall of text. It's a desparate attempt to cut
>> >> through the complexity and my confusion, and
blk_check_bytes_request is called from blk_co_do_preadv,
blk_co_do_pwritev_part, blk_co_do_pdiscard and blk_co_copy_range
before (maybe) calling throttle_group_co_io_limits_intercept() (which
has int64_t argument) and then calling corresponding bdrv_co_ function.
bdrv_co_ functions are OK with
To be consistent with declarations in include/sysemu/block-backend.h.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/block-backend.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/block/block-backend.c b/block/block-backend.c
index
For both updated functions type of bytes becomes wider, so all callers
should be OK with it.
blk_co_preadv() only pass its arguments to blk_do_preadv().
blk_do_preadv() pass bytes to:
- trace_blk_co_preadv, which is updated too
- blk_check_byte_request, throttle_group_co_io_limits_intercept,
On 10/6/21 2:27 AM, Paolo Bonzini wrote:
This makes it possible to see what is happening, even if the output of
"make check-block" is not sent to a tty (for example if it is sent to
grep or tee).
Signed-off-by: Paolo Bonzini
---
tests/qemu-iotests/testrunner.py | 1 +
1 file changed, 1
On Wed, Oct 6, 2021 at 6:14 AM Paolo Bonzini wrote:
> On 23/09/21 02:49, John Snow wrote:
> > Based-on: <20210915162955.333025-1-js...@redhat.com>
> >[PATCH v4 00/27] python: introduce Asynchronous QMP package
> > GitLab:
>
On 23/09/21 02:49, John Snow wrote:
Based-on: <20210915162955.333025-1-js...@redhat.com>
[PATCH v4 00/27] python: introduce Asynchronous QMP package
GitLab: https://gitlab.com/jsnow/qemu/-/commits/python-aqmp-iotest-wrapper
CI: https://gitlab.com/jsnow/qemu/-/pipelines/375637927
On Wed, Oct 06, 2021 at 06:22:08PM +0800, Gavin Shan wrote:
> The following option is used to specify the distance map. It's
> possible the option isn't provided by user. In this case, the
> distance map isn't populated and exposed to platform. On the
> other hand, the empty NUMA node, where no
Am 06.10.2021 um 11:20 hat Laurent Vivier geschrieben:
> On 06/10/2021 10:21, Juan Quintela wrote:
> > Kevin Wolf wrote:
> > > Am 05.10.2021 um 17:52 hat Damien Hedde geschrieben:
> >
> > Hi
> >
> > > > > Usage
> > > > > -
> > > > >
> > > > > The primary device can be hotplugged or be part
From: Emanuele Giuseppe Esposito
There are a couple of errors in bdrv_drained_begin header comment:
- block_job_pause does not exist anymore, it has been replaced
with job_pause in b15de82867
- job_pause is automatically invoked as a .drained_begin callback
(child_job_drained_begin) by the
From: John Snow
We can drop the sys.path hacking in various places by doing
this. Additionally, by doing it in one place right up top, we can print
interesting warnings in case the environment does not look correct. (See
next commit.)
If we ever decide to change how the environment is crafted,
From: Vladimir Sementsov-Ogievskiy
Now test fails if copy-before-write is not white-listed.
Let's skip test instead.
Fixes: c0605985696a19ef034fa25d04f53f3b3b383896
Signed-off-by: Vladimir Sementsov-Ogievskiy
Message-Id: <20210920115538.264372-6-vsement...@virtuozzo.com>
Signed-off-by: Kevin
On 06/10/2021 12:53, Kevin Wolf wrote:
Am 06.10.2021 um 11:20 hat Laurent Vivier geschrieben:
On 06/10/2021 10:21, Juan Quintela wrote:
Kevin Wolf wrote:
Am 05.10.2021 um 17:52 hat Damien Hedde geschrieben:
Hi
Usage
-
The primary device can be hotplugged or be part of the startup
On Wed, Oct 06, 2021 at 12:13:14PM +0200, Cornelia Huck wrote:
> On Mon, Oct 04 2021, "Michael S. Tsirkin" wrote:
>
> > On Mon, Oct 04, 2021 at 05:50:44PM +0200, Cornelia Huck wrote:
> >> On Mon, Oct 04 2021, "Michael S. Tsirkin" wrote:
> >>
> >> > On Mon, Oct 04, 2021 at 04:33:21PM +0200,
On Wed, Oct 06, 2021 at 02:29:37PM +0100, Dr. David Alan Gilbert wrote:
> * Michael S. Tsirkin (m...@redhat.com) wrote:
> > On Wed, Oct 06, 2021 at 09:43:52AM +0100, Dr. David Alan Gilbert wrote:
> > > * Michael S. Tsirkin (m...@redhat.com) wrote:
> > > > On Wed, Oct 06, 2021 at 09:28:50AM +0100,
The virtio specification virtio-v1.1-cs01 states: Transitional devices
MUST detect Legacy drivers by detecting that VIRTIO_F_VERSION_1 has not
been acknowledged by the driver. This is exactly what QEMU as of 6.1
has done relying solely on VIRTIO_F_VERSION_1 for detecting that.
However, the
On Wed, Oct 06, 2021 at 03:17:07PM +0200, Vladimir Sementsov-Ogievskiy wrote:
> Rename size and make it int64_t to correspond to modern block layer,
> which always uses int64_t for offset and bytes (not in blk layer yet,
> which is a task for following commits).
>
> All callers pass int or
As of HEAD^, there is no meaning to s->synced other than whether the job
is READY or not. job_is_ready() gives us that information, too.
Suggested-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Hanna Reitz
Reviewed-by: Eric Blake
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Kevin
Hi,
v1 cover letter:
https://lists.nongnu.org/archive/html/qemu-block/2021-07/msg00705.html
v2 cover letter:
https://lists.nongnu.org/archive/html/qemu-block/2021-07/msg00747.html
v3 cover letter:
https://lists.nongnu.org/archive/html/qemu-block/2021-08/msg00127.html
v4 cover letter:
Hi,
On 10/6/21 11:15 AM, Andrew Jones wrote:
> On Mon, Sep 27, 2021 at 03:17:31PM +0200, Eric Auger wrote:
>> ARM SBBR specification mandates DBG2 table (Debug Port Table 2)
>> since v1.0 (ARM DEN0044F 8.3.1.7 DBG2).
>>
>> The DBG2 table allows to describe one or more debug ports.
>>
>> Generate
The following changes since commit e3acc2c1961cbe22ca474cd5da4163b7bbf7cea3:
tests/docker/dockerfiles: Bump fedora-i386-cross to fedora 34 (2021-10-05
16:40:39 -0700)
are available in the Git repository at:
git://repo.or.cz/qemu/kevin.git tags/for-upstream
for you to fetch changes up to
On Wed, 6 Oct 2021 20:52:00 +1100
Alexey Kardashevskiy wrote:
>
>
> On 30/09/2021 11:15, David Gibson wrote:
> > On Mon, Sep 27, 2021 at 02:48:01PM +1000, David Gibson wrote:
> >> Greg Kurz and myself have been co-maintainers for the ppc and ppc64
> >> targets for some time now. However, both
Le 05/10/2021 à 17:33, Mark Cave-Ayland a écrit :
> On 05/10/2021 16:08, Laurent Vivier wrote:
>
>> Le 05/10/2021 à 13:38, Mark Cave-Ayland a écrit :
>>> On 05/10/2021 10:50, Laurent Vivier wrote:
>>>
Le 04/10/2021 à 23:19, Mark Cave-Ayland a écrit :
> The monitor modes table is found by
Hi jean,
On 9/30/21 8:50 PM, Jean-Philippe Brucker wrote:
> Currently the virtio-iommu device must be programmed before it allows
> DMA from any PCI device. This can make the VM entirely unusable when a
> virtio-iommu driver isn't present, for example in a bootloader that
> loads the OS from
Test 297 in qemu-iotests folder currently fails: pylint has
learned new things to check, or we simply missed them.
All fixes in this patch are related to additional spaces used
or wrong indentation.
No functional change intended.
Signed-off-by: Emanuele Giuseppe Esposito
---
The problem here is that some variables are formatted with
unnecessary spaces to make it prettier and easier to read.
However, pylint complains about those additional spaces.
A solution is to transform them as string with arbitrary spaces,
and then convert it back into a tuple.
Removing the
Hi jean,
On 9/30/21 8:50 PM, Jean-Philippe Brucker wrote:
> The driver can create a bypass domain by passing the
> VIRTIO_IOMMU_ATTACH_F_BYPASS flag on the ATTACH request. Bypass domains
> perform slightly better than domains with identity mappings since they
> skip translation.
>
>
On Wed, 6 Oct 2021 11:57:07 +0200
Eric Auger wrote:
> Hi,
>
> On 10/6/21 11:15 AM, Andrew Jones wrote:
> > On Mon, Sep 27, 2021 at 03:17:31PM +0200, Eric Auger wrote:
> >> ARM SBBR specification mandates DBG2 table (Debug Port Table 2)
> >> since v1.0 (ARM DEN0044F 8.3.1.7 DBG2).
> >>
> >>
Hi,
On 10/6/21 3:46 PM, Igor Mammedov wrote:
> On Wed, 6 Oct 2021 11:57:07 +0200
> Eric Auger wrote:
>
>> Hi,
>>
>> On 10/6/21 11:15 AM, Andrew Jones wrote:
>>> On Mon, Sep 27, 2021 at 03:17:31PM +0200, Eric Auger wrote:
ARM SBBR specification mandates DBG2 table (Debug Port Table 2)
On Thu, 2 Sep 2021 07:35:36 -0400
Igor Mammedov wrote:
ping
> Changelog:
> v2:
> * rebase and update expected blobs on top of 6.1
> * drop ARM/IORT test case, whihc with current master
>requires KVM, but we can't run ACPI tests since
>virt machine on KVM changes
An error does not take us out of the READY phase, which is what
s->synced signifies. It does of course mean that source and target are
no longer in sync, but that is what s->actively_sync is for -- s->synced
never meant that source and target are in sync, only that they were at
some point (and at
On 30/09/2021 11:15, David Gibson wrote:
> On Mon, Sep 27, 2021 at 02:48:01PM +1000, David Gibson wrote:
>> Greg Kurz and myself have been co-maintainers for the ppc and ppc64
>> targets for some time now. However, both our day job responsibilities
>> and interests are leading us towards other
The empty NUMA node, where no memory resides, are allowed. For
example, the following command line specifies two empty NUMA nodes.
With this, QEMU fails to boot because of the conflicting device-tree
node names, as the following error message indicates.
The empty NUMA nodes, where no memory resides, are allowed on ARM64 virt
platform. However, QEMU fails to boot because the device-tree can't be
populated due to the conflicting device-tree node names of these empty
NUMA nodes. For example, QEMU fails to boot and the following error
message
The following option is used to specify the distance map. It's
possible the option isn't provided by user. In this case, the
distance map isn't populated and exposed to platform. On the
other hand, the empty NUMA node, where no memory resides, is
allowed on ARM64 virt platform. For these empty
On Tue, Oct 05, 2021 at 04:09:35PM -0400, Vivek Goyal wrote:
> On Mon, Oct 04, 2021 at 03:54:31PM +0100, Stefan Hajnoczi wrote:
> > On Thu, Sep 30, 2021 at 11:30:34AM -0400, Vivek Goyal wrote:
> > > Add a new custom threadpool using posix threads that specifically
> > > service locking requests.
>
From: Philippe Mathieu-Daudé
When configuring QEMU with --disable-fuse, the qemu-storage-daemon
still reports FUSE command line options in its help:
$ qemu-storage-daemon -h
Usage: qemu-storage-daemon [options]
QEMU storage daemon
--export [type=]fuse,id=,node-name=,mountpoint=
From: Paolo Bonzini
Linux limits the size of iovecs to 1024 (UIO_MAXIOV in the kernel
sources, IOV_MAX in POSIX). Because of this, on some host adapters
requests with many iovecs are rejected with -EINVAL by the
io_submit() or readv()/writev() system calls.
In fact, the same limit applies to
On Mittwoch, 6. Oktober 2021 13:06:55 CEST Stefan Hajnoczi wrote:
> On Tue, Oct 05, 2021 at 06:32:46PM +0200, Christian Schoenebeck wrote:
> > On Dienstag, 5. Oktober 2021 17:10:40 CEST Stefan Hajnoczi wrote:
> > > On Tue, Oct 05, 2021 at 03:15:26PM +0200, Christian Schoenebeck wrote:
> > > > On
This is a preparation to the following commit, to use automatic
coroutine wrapper generation.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/block-backend.c | 52 +--
1 file changed, 26 insertions(+), 26 deletions(-)
diff --git
On Tue, 5 Oct 2021 11:40:35 -0500
Eric DeVolder wrote:
> Igor, again thanks for the detailed review. Inline responses below.
> eric
>
> On 10/5/21 6:39 AM, Igor Mammedov wrote:
> > On Mon, 4 Oct 2021 16:13:09 -0500
> > Eric DeVolder wrote:
> >
> >> Igor, thanks for the close examination.
On Wed, Oct 6, 2021 at 10:32 AM Paolo Bonzini wrote:
> On 06/10/21 16:24, John Snow wrote:
> >
> > I had plans at one point to make a sync.py, but with an interface that
> > matched async QMP itself more closely. I spent some time trying to
> > research how to make a "magic" sync wrapper around
On Tue, Oct 05, 2021 at 01:28:21PM -0400, Vivek Goyal wrote:
> On Tue, Oct 05, 2021 at 04:50:43PM +0100, Stefan Hajnoczi wrote:
> > On Tue, Oct 05, 2021 at 11:16:18AM -0400, Vivek Goyal wrote:
> > > On Tue, Oct 05, 2021 at 01:22:58PM +0100, Stefan Hajnoczi wrote:
> > > > On Thu, Sep 30, 2021 at
On Wed, Oct 06, 2021 at 06:22:09PM +0800, Gavin Shan wrote:
> The empty NUMA node, where no memory resides, are allowed. For
> example, the following command line specifies two empty NUMA nodes.
> With this, QEMU fails to boot because of the conflicting device-tree
> node names, as the following
On Tue, Oct 05, 2021 at 06:32:46PM +0200, Christian Schoenebeck wrote:
> On Dienstag, 5. Oktober 2021 17:10:40 CEST Stefan Hajnoczi wrote:
> > On Tue, Oct 05, 2021 at 03:15:26PM +0200, Christian Schoenebeck wrote:
> > > On Dienstag, 5. Oktober 2021 14:45:56 CEST Stefan Hajnoczi wrote:
> > > > On
On 10/6/21 13:37, Damien Hedde wrote:
> Right now, we cannot load some binary file if it is bigger than the
> machine's ram size. This limitation only occurs when loading a
> binary file: we can load a corresponding elf file without this
> limitation.
>
> This is an issue for machines that have
On Wed, Oct 06, 2021 at 09:43:52AM +0100, Dr. David Alan Gilbert wrote:
> * Michael S. Tsirkin (m...@redhat.com) wrote:
> > On Wed, Oct 06, 2021 at 09:28:50AM +0100, Dr. David Alan Gilbert wrote:
> > > To me it feels the same as the distinction between vhost-kernel and qemu
> > > backended virtio
Hi all!
That's a new part of 64bit block-layer story, now to update
blk_* io functions.
Vladimir Sementsov-Ogievskiy (12):
block-backend: blk_check_byte_request(): int64_t bytes
block-backend: make blk_co_preadv() 64bit
block-backend: convert blk_co_pwritev_part to int64_t bytes
* Michael S. Tsirkin (m...@redhat.com) wrote:
> On Wed, Oct 06, 2021 at 02:29:37PM +0100, Dr. David Alan Gilbert wrote:
> > * Michael S. Tsirkin (m...@redhat.com) wrote:
> > > On Wed, Oct 06, 2021 at 09:43:52AM +0100, Dr. David Alan Gilbert wrote:
> > > > * Michael S. Tsirkin (m...@redhat.com)
On Wed, Oct 06, 2021 at 03:27:59PM +0100, Dr. David Alan Gilbert wrote:
> * Michael S. Tsirkin (m...@redhat.com) wrote:
> > On Wed, Oct 06, 2021 at 02:29:37PM +0100, Dr. David Alan Gilbert wrote:
> > > * Michael S. Tsirkin (m...@redhat.com) wrote:
> > > > On Wed, Oct 06, 2021 at 09:43:52AM +0100,
The only job that supports a soft cancel mode is the mirror job, and in
such a case it resets its .cancelled field before it leaves its .run()
function, so it does not really count as cancelled.
However, it is possible to cancel the job after .run() returns and
before job_exit() (which is run in
Finalizing the job may cause its AioContext to change. This is noted by
job_exit(), which points at job_txn_apply() to take this fact into
account.
However, job_completed() does not necessarily invoke job_txn_apply()
(through job_completed_txn_success()), but potentially also
Move this code from tcg/tcg.h to its own header.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
include/exec/memopidx.h | 55 +
include/tcg/tcg.h | 39 +
2 files changed, 56 insertions(+), 38
On 2021-09-30 at 11:30 -04, Vivek Goyal wrote...
> Daemon specifies size of notification buffer needed and that should be
> done using config space.
>
> Only ->notify_buf_size value of config space comes from daemon. Rest of
> it is filled by qemu device emulation code.
>
> Signed-off-by: Vivek
From: Vladimir Sementsov-Ogievskiy
- options & flags is common pair for open-like functions, let's use it
- add a comment that specifies use of @options
Signed-off-by: Vladimir Sementsov-Ogievskiy
Message-Id: <20210920115538.264372-4-vsement...@virtuozzo.com>
Signed-off-by: Kevin Wolf
---
From: John Snow
Mostly uninteresting stuff. Move the test injections under a function
named main() so that the variables used during that process aren't in
the global scope.
Signed-off-by: John Snow
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Hanna Reitz
Reviewed-by: Vladimir
Right now, we cannot load some binary file if it is bigger than the
machine's ram size. This limitation only occurs when loading a
binary file: we can load a corresponding elf file without this
limitation.
This is an issue for machines that have small ram or do not use the
ram_size feature at
On Wed, Oct 06, 2021 at 10:03:25PM +1100, Gavin Shan wrote:
> Hi Drew,
>
> On 10/6/21 9:35 PM, Andrew Jones wrote:
> > On Wed, Oct 06, 2021 at 06:22:08PM +0800, Gavin Shan wrote:
> > > The following option is used to specify the distance map. It's
> > > possible the option isn't provided by user.
There are some warnings and errors that we either miss or
are new in pylint. Anyways, test 297 of qemu-iotests fails
because of that, so we need to fix it.
All these fixes involve just indentation or additional spaces
added.
Emanuele Giuseppe Esposito (2):
pylint: fix errors and warnings from
Rename size and make it int64_t to correspond to modern block layer,
which always uses int64_t for offset and bytes (not in blk layer yet,
which is a task for following commits).
All callers pass int or unsigned int.
So, for bytes in [0, INT_MAX] nothing is changed, for negative bytes we
now
1. Convert bytes in BlkAioEmAIOCB:
aio->bytes is only passed to already int64_t interfaces, and set in
blk_aio_prwv, which is updated here.
2. For all updated functions parameter type becomes wider so callers
are safe.
3. In blk_aio_prwv we only store bytes to BlkAioEmAIOCB, which is
Let's drop hand maid coroutine wrappers and use coroutine wrapper
generation like in block/io.c.
Now, blk_foo() functions are written in same way as blk_co_foo() ones,
but wrap blk_do_foo() instead of blk_co_do_foo().
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/coroutines.h| 30
On Mon, Oct 04 2021, "Michael S. Tsirkin" wrote:
> On Mon, Oct 04, 2021 at 05:50:44PM +0200, Cornelia Huck wrote:
>> On Mon, Oct 04 2021, "Michael S. Tsirkin" wrote:
>>
>> > On Mon, Oct 04, 2021 at 04:33:21PM +0200, Cornelia Huck wrote:
>> >> On Mon, Oct 04 2021, "Michael S. Tsirkin" wrote:
From: John Snow
We can circumvent the '__main__' redefinition problem by passing
--scripts-are-modules. Take mypy out of the loop per-filename and check
everything in one go: it's quite a bit faster.
Signed-off-by: John Snow
Reviewed-by: Hanna Reitz
Reviewed-by: Philippe Mathieu-Daudé
From: John Snow
We need to import subpackages from the qemu namespace package; importing
the namespace package alone doesn't bring the subpackages with it --
unless someone else (like iotests.py) imports them too.
Adjust the imports.
Signed-off-by: John Snow
Reviewed-by: Philippe
We updated blk_do_pdiscard() and its wrapper blk_co_pdiscard(). Both
functions are updated so that parameter type becomes wider, so all
callers should be OK with it.
Look at blk_do_pdiscard(): bytes passed only to
blk_check_byte_request() and bdrv_co_pdiscard(), which already has
int64_t bytes
On 06/10/2021 13:24, Laurent Vivier wrote:
This is where it becomes a bit trickier, since technically booting Linux with
-kernel you can use
any supported values as long as everything fits in the video RAM which is why
there isn't currently
a hard-coded list :)
We need the list of
On Wed, Oct 6, 2021 at 6:13 AM Paolo Bonzini wrote:
> On 23/09/21 02:49, John Snow wrote:
> > This is a wrapper around the async QMPClient that mimics the old,
> > synchronous QEMUMonitorProtocol class. It is designed to be
> > interchangeable with the old implementation.
> >
> > It does not,
On 06/10/21 16:24, John Snow wrote:
I had plans at one point to make a sync.py, but with an interface that
matched async QMP itself more closely. I spent some time trying to
research how to make a "magic" sync wrapper around async QMP, and hit a
few trouble spots. I've still got the patch,
On Wed, Oct 06, 2021 at 03:17:08PM +0200, Vladimir Sementsov-Ogievskiy wrote:
> For both updated functions type of bytes becomes wider, so all callers
> should be OK with it.
>
> blk_co_preadv() only pass its arguments to blk_do_preadv().
>
> blk_do_preadv() pass bytes to:
>
> -
From: Vladimir Sementsov-Ogievskiy
- use ERRP_GUARD(): function calls error_prepend(), so it must use
ERRP_GUARD(), otherwise error_prepend() would not be called when
passed errp is error_fatal
- drop error propagation, handle return code instead
- for symmetry, do error_prepend() for
From: Vladimir Sementsov-Ogievskiy
Use bdrv_new_open_driver_opts() instead of complicated bdrv_open().
Among other extra things bdrv_open() also check for white-listed
formats, which we don't want for internal node creation: currently
backup doesn't work when copy-before-write filter is not
On 10/6/21 11:38, Paolo Bonzini wrote:
> qemu-iotests run qemu-storage-daemon, make sure it is up to date.
>
> Signed-off-by: Paolo Bonzini
> ---
> tests/Makefile.include | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/coroutines.h | 3 +++
scripts/block-coroutine-wrapper.py | 12 ++--
2 files changed, 13 insertions(+), 2 deletions(-)
diff --git a/block/coroutines.h b/block/coroutines.h
index 514d169d23..35a6c49857 100644
---
Function is updated so that parameter type becomes wider, so all
callers should be OK with it.
Look at blk_co_copy_range() itself: bytes passed only to
blk_check_byte_request() and bdrv_co_copy_range(), which already has
int64_t bytes parameter, so we are OK.
Note that requests exceeding INT_MAX
We convert blk_do_pwritev_part() and some wrappers:
blk_co_pwritev_part(), blk_co_pwritev(), blk_co_pwrite_zeroes().
All functions are converted so that parameter type becomes wider, so
all callers should be OK with it.
Look at blk_do_pwritev_part() body:
bytes is passed to:
-
* Michael S. Tsirkin (m...@redhat.com) wrote:
> On Wed, Oct 06, 2021 at 09:43:52AM +0100, Dr. David Alan Gilbert wrote:
> > * Michael S. Tsirkin (m...@redhat.com) wrote:
> > > On Wed, Oct 06, 2021 at 09:28:50AM +0100, Dr. David Alan Gilbert wrote:
> > > > To me it feels the same as the distinction
They are rightly values in the same enumeration.
Reviewed-by: David Hildenbrand
Signed-off-by: Richard Henderson
---
tcg/s390x/tcg-target.h | 28 +++-
1 file changed, 7 insertions(+), 21 deletions(-)
diff --git a/tcg/s390x/tcg-target.h b/tcg/s390x/tcg-target.h
index
For usadd, we only have to consider overflow. Since ~B + B == -1,
the maximum value for A that saturates is ~B.
For ussub, we only have to consider underflow. The minimum value
that saturates to 0 from A - B is B.
Signed-off-by: Richard Henderson
---
tcg/tcg-op-vec.c | 37
We (will) often have the complete MemOpIdx handy, so use that.
Reviewed-by: Peter Maydell
Reviewed-by: Alistair Francis
Signed-off-by: Richard Henderson
---
trace/mem.h | 32 +-
accel/tcg/cputlb.c| 12 --
accel/tcg/user-exec.c
Reviewed-by: David Hildenbrand
Signed-off-by: Richard Henderson
---
tcg/s390x/tcg-target.c.inc | 72 +++---
1 file changed, 68 insertions(+), 4 deletions(-)
diff --git a/tcg/s390x/tcg-target.c.inc b/tcg/s390x/tcg-target.c.inc
index d80f25e48e..586a4b5587 100644
Signed-off-by: Richard Henderson
---
tcg/s390x/tcg-target-con-set.h | 1 +
tcg/s390x/tcg-target.h | 2 +-
tcg/s390x/tcg-target.c.inc | 20
3 files changed, 22 insertions(+), 1 deletion(-)
diff --git a/tcg/s390x/tcg-target-con-set.h
Signed-off-by: Richard Henderson
---
tcg/s390x/tcg-target.c.inc | 122 -
1 file changed, 119 insertions(+), 3 deletions(-)
diff --git a/tcg/s390x/tcg-target.c.inc b/tcg/s390x/tcg-target.c.inc
index 586a4b5587..f59250872b 100644
---
On 2021-09-30 at 11:30 -04, Vivek Goyal wrote...
> As of now we don't support fcntl(F_SETLKW) and if we see one, we return
> -EOPNOTSUPP.
>
> Change that by accepting these requests and returning a reply
> immediately asking caller to wait. Once lock is available, send a
> notification to the
On 2021-09-30 at 11:30 -04, Vivek Goyal wrote...
> So far we did not have the notion of cross queue traffic. That is, we
> get request on a queue and send back response on same queue. So if a
> request be being processed and at the same time a stop queue request
> comes in, we wait for all
On Wed, Oct 06, 2021 at 03:17:10PM +0200, Vladimir Sementsov-Ogievskiy wrote:
> We updated blk_do_pdiscard() and its wrapper blk_co_pdiscard(). Both
> functions are updated so that parameter type becomes wider, so all
> callers should be OK with it.
>
> Look at blk_do_pdiscard(): bytes passed
When a packet has 2 stores, either both commit or neither commit.
At the beginning of gen_commit_packet, we check for multiple stores.
If there are multiple stores, call a helper that will probe each of
them before proceeding with the commit.
Note that we don't call the probe helper for packets
On 10/5/21 18:44, Paolo Bonzini wrote:
> Meson 0.57 allows passing external programs and dependency objects
> to summary(). Use this to show library versions and paths in the
> summary.
>
> Signed-off-by: Paolo Bonzini
> ---
> meson.build | 112
From: Philippe Mathieu-Daudé
The gen_pred_cancel() function, introduced in commit a646e99cb90
(Hexagon macros) doesn't use the 'one' TCG temporary; remove it.
Reviewed-by: Richard Henderson
Reviewed-by: Taylor Simpson
Signed-off-by: Philippe Mathieu-Daudé
Message-Id:
On 10/6/21 18:49, Philippe Mathieu-Daudé wrote:
> nvme_create_queue_pair() allocates resources with qemu_vfio_dma_map(),
> but we never release them. Do it in nvme_free_queue() which is called
> from nvme_free_queue_pair().
>
> Reported by valgrind:
>
> ==252858== 520,192 bytes in 1 blocks are
Commit 962104f0448 ("hw/ppc: moved hcalls that depend on softmmu")
introduced a lot of unnecessary #include directives. Remove them.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/ppc/spapr_softmmu.c | 15 ---
1 file changed, 15 deletions(-)
diff --git a/hw/ppc/spapr_softmmu.c
1 - 100 of 312 matches
Mail list logo
