Re: [PATCH 01/17] ppc/pnv: use PHB4 obj in pnv_pec_stk_pci_xscom_ops

2022-01-14 Thread Cédric Le Goater
On 1/13/22 20:29, Daniel Henrique Barboza wrote: The current relationship between PnvPhb4PecStack and PnvPHB4 objects is overly complex. Recent work done in pnv_phb4.c and pnv_phb4_pec.c shows that the stack obj role in the overall design is more of a placeholder for its 'phb' object, having no

Re: [PATCH 04/17] ppc/pnv: move intbar to PnvPHB4

2022-01-14 Thread Cédric Le Goater
On 1/13/22 20:29, Daniel Henrique Barboza wrote: This MemoryRegion can also be moved in a single step. Signed-off-by: Daniel Henrique Barboza Reviewed-by: Cédric Le Goater Thanks, C. --- hw/pci-host/pnv_phb4.c | 18 +- include/hw/pci-host/pnv_phb4.h | 2 +-

Re: [PATCH 08/17] ppc/pnv: change pnv_pec_stk_update_map() to use PnvPHB4

2022-01-14 Thread Cédric Le Goater
On 1/13/22 20:29, Daniel Henrique Barboza wrote: stack->nest_regs_mr wasn't migrated to PnvPHB4 together with phb->nest_regs[] in the previous patch. We were unable to cleanly convert its write MemoryRegionOps, pnv_pec_stk_nest_xscom_write(), to use PnvPHB4 instead of PnvPhb4PecStack due to

Re: [PATCH 05/17] ppc/pnv: change pnv_phb4_update_regions() to use PnvPHB4

2022-01-14 Thread Cédric Le Goater
On 1/13/22 20:29, Daniel Henrique Barboza wrote: The function does not rely on stack for anything it does anymore. This is also one less instance of 'stack->phb' that we need to worry about. Signed-off-by: Daniel Henrique Barboza Reviewed-by: Cédric Le Goater Thanks, C. ---

Re: [PATCH 10/17] ppc/pnv: move phb_regs_mr to PnvPHB4

2022-01-14 Thread Cédric Le Goater
On 1/13/22 20:29, Daniel Henrique Barboza wrote: After recent changes, this MemoryRegion can be migrated to PnvPHB4 without too much trouble. Signed-off-by: Daniel Henrique Barboza Reviewed-by: Cédric Le Goater Thanks, C. --- hw/pci-host/pnv_phb4.c | 6 +++---

Re: [PATCH 16/17] ppc/pnv: remove PnvPhb4PecStack object

2022-01-14 Thread Cédric Le Goater
On 1/13/22 20:29, Daniel Henrique Barboza wrote: All the complexity that was scattered between PnvPhb4PecStack and PnvPHB4 are now centered in the PnvPHB4 device. PnvPhb4PecStack does not serve any purpose in the current code base. Signed-off-by: Daniel Henrique Barboza Reviewed-by: Cédric

Re: [PATCH 15/17] ppc/pnv: convert pec->stacks[] into pec->phbs[]

2022-01-14 Thread Cédric Le Goater
On 1/13/22 20:29, Daniel Henrique Barboza wrote: This patch changes the design of the PEC device to use PHB4s instead of PecStacks. After all the recent changes, PHB4s now contain all the information needed for their proper functioning, not relying on PecStack in any capacity. All changes are

Re: [PATCH 2/2] docker: add msitools to Fedora/mingw cross

2022-01-14 Thread Philippe Mathieu-Daudé via
On 14/1/22 09:43, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau That should help catch build issues/regressions with wixl. Signed-off-by: Marc-André Lureau --- tests/docker/dockerfiles/fedora-win32-cross.docker | 1 + tests/docker/dockerfiles/fedora-win64-cross.docker | 1 +

Re: [PATCH 11/17] ppc/pnv: introduce PnvPHB4 'phb_number' property

2022-01-14 Thread Cédric Le Goater
On 1/14/22 12:29, Daniel Henrique Barboza wrote: On 1/14/22 07:46, Cédric Le Goater wrote: On 1/13/22 20:29, Daniel Henrique Barboza wrote: One of the remaining dependencies we have on the PnvPhb4PecStack object is the stack->stack_no property. This is set as the position the stack occupies

Re: [PATCH 26/30] bsd-user/signal.c: tswap_siginfo

2022-01-14 Thread Peter Maydell
On Sun, 9 Jan 2022 at 16:56, Warner Losh wrote: > > Convert siginfo from targer to host. > > Signed-off-by: Stacey Son > Signed-off-by: Kyle Evans > Signed-off-by: Warner Losh > --- > bsd-user/signal.c | 34 ++ > 1 file changed, 34 insertions(+) > > diff --git

Re: [PATCH 27/30] bsd-user/signal.c: process_pending_signals

2022-01-14 Thread Peter Maydell
On Sun, 9 Jan 2022 at 16:57, Warner Losh wrote: > > Process the currently queued signals. > > Signed-off-by: Stacey Son > Signed-off-by: Kyle Evans > Signed-off-by: Warner Losh > --- > bsd-user/signal.c | 34 ++ > 1 file changed, 34 insertions(+) > > diff --git

Re: [PATCH 0/2] Introduce printer subsystem and USB printer device

2022-01-14 Thread Gerd Hoffmann
Hi, > This patchset introduces: > > 1) Skeleton of QEMU printer subsystem with a dummy builtin driver. > > 2) USB printer device emulation, with definitions in the extension of > IPP-over- >USB [3]. > > WIP: > > 1) QEMU printer subsystem interfaces, which will be finalized with a

Re: [PULL V3 00/13] Net patches

2022-01-14 Thread Peter Maydell
On Fri, 14 Jan 2022 at 09:19, Jason Wang wrote: > > > 在 2022/1/14 下午1:08, Jason Wang 写道: > > The following changes since commit f8d75e10d3e0033a0a29a7a7e4777a4fbc17a016: > > > >Merge remote-tracking branch 'remotes/legoater/tags/pull-ppc-20220112' > > into staging (2022-01-13 11:18:24 +)

Re: [PATCH 06/17] ppc/pnv: move mmbar0/mmbar1 and friends to PnvPHB4

2022-01-14 Thread Cédric Le Goater
On 1/13/22 20:29, Daniel Henrique Barboza wrote: These 2 MemoryRegions, together with mmio(0|1)_base and mmio(0|1)_size variables, are used together in the same functions. We're better of moving them all in a single step. Signed-off-by: Daniel Henrique Barboza Reviewed-by: Cédric Le Goater

Re: [PATCH 12/17] ppc/pnv: introduce PnvPHB4 'pec' property

2022-01-14 Thread Cédric Le Goater
On 1/13/22 20:29, Daniel Henrique Barboza wrote: This property will track the owner PEC of this PHB. For now it's redundant since we can retrieve the PEC via phb->stack->pec but it will not be redundant when we get rid of the stack device. Signed-off-by: Daniel Henrique Barboza Reviewed-by:

Re: [PATCH 13/17] ppc/pnv: remove stack pointer from PnvPHB4

2022-01-14 Thread Cédric Le Goater
On 1/13/22 20:29, Daniel Henrique Barboza wrote: This pointer was being used for two reasons: pnv_phb4_update_regions() was using it to access the PHB and phb4_realize() was using it as a way to determine if the PHB was user created. We can determine if the PHB is user created via phb->pec,

Re: [PATCH 11/17] ppc/pnv: introduce PnvPHB4 'phb_number' property

2022-01-14 Thread Cédric Le Goater
On 1/13/22 20:29, Daniel Henrique Barboza wrote: One of the remaining dependencies we have on the PnvPhb4PecStack object is the stack->stack_no property. This is set as the position the stack occupies in the pec->stacks[] array. We need a way to report this same value in the PnvPHB4. This patch

Re: [PATCH 14/17] ppc/pnv: move default_phb_realize() to pec_realize()

2022-01-14 Thread Cédric Le Goater
On 1/13/22 20:29, Daniel Henrique Barboza wrote: This is the last step before making the PEC device uses PHB4s directly. Move the current pnv_pec_stk_default_phb_realize() call to pec_realize(), renaming the function to pnv_pec_default_phb_realize(), and set the PHB attributes using the PEC

Re: [PATCH] Mark remaining global TypeInfo instances as const

2022-01-14 Thread Philippe Mathieu-Daudé via
On 13/1/22 18:10, Bernhard Beschow wrote: More than 1k of TypeInfo instances are already marked as const. Mark the remaining ones, too. Signed-off-by: Bernhard Beschow --- hw/core/generic-loader.c | 2 +- hw/core/guest-loader.c | 2 +- hw/display/bcm2835_fb.c| 2 +-

Re: [PATCH 4/6] migration: Add ram-only capability

2022-01-14 Thread Daniel P . Berrangé
On Fri, Jan 14, 2022 at 12:22:13PM +0100, Markus Armbruster wrote: > Nikita Lapshin writes: > > > If this capability is enabled migration stream > > will have RAM section only. > > > > Signed-off-by: Nikita Lapshin > > [...] > > > diff --git a/qapi/migration.json b/qapi/migration.json > >

Re: [PATCH 1/4] tests: acpi: manually pad OEM_ID/OEM_TABLE_ID for test_oem_fields() test

2022-01-14 Thread Igor Mammedov
On Wed, 12 Jan 2022 08:44:19 -0500 "Michael S. Tsirkin" wrote: > On Wed, Jan 12, 2022 at 08:03:29AM -0500, Igor Mammedov wrote: > > The next commit will revert OEM fields padding with whitespace to > > padding with '\0' as it was before [1]. As result test_oem_fields() will > > fail due to

Re: [PATCH v6 10/23] target/riscv: Implement AIA CSRs for 64 local interrupts on RV32

2022-01-14 Thread Frank Chang
Anup Patel 於 2021年12月30日 週四 下午8:55寫道: > From: Anup Patel > > The AIA specification adds new CSRs for RV32 so that RISC-V hart can > support 64 local interrupts on both RV32 and RV64. > > Signed-off-by: Anup Patel > Signed-off-by: Anup Patel > Reviewed-by: Alistair Francis > --- >

Re: [PATCH 06/30] bsd-user/arm/target_arch_cpu.h: Correct code pointer

2022-01-14 Thread Peter Maydell
On Fri, 14 Jan 2022 at 06:38, Warner Losh wrote: > > > > On Thu, Jan 13, 2022 at 10:15 AM Peter Maydell > wrote: >> >> On Sun, 9 Jan 2022 at 16:26, Warner Losh wrote: >> > >> > The code has moved in FreeBSD since the emulator was started, update the >> > comment to reflect that change. Remove

Re max ISA serial ports

2022-01-14 Thread Ani Sinha
I have a question re the following commit : commit def337ffda34d331404bd7f1a42726b71500df22 Author: Peter Maydell Date: Fri Apr 20 15:52:46 2018 +0100 serial-isa: Use MAX_ISA_SERIAL_PORTS instead of MAX_SERIAL_PORTS Does this mean that this limit of 4 slots qemu / hypervisor specific or

Re: [PATCH 00/17] remove PnvPhb4PecStack from Powernv9

2022-01-14 Thread Cédric Le Goater
On 1/13/22 20:29, Daniel Henrique Barboza wrote: Hi, After all the done enabling pnv-phb4 user devices, it became clear that the stack object is just a container of the PHB and its resources than something that needs to be maintained by its own. Removing the PnvPhb4PecStack object promotes a

Re: [PATCH 02/17] ppc/pnv: move PCI registers to PnvPHB4

2022-01-14 Thread Cédric Le Goater
On 1/13/22 20:29, Daniel Henrique Barboza wrote: Previous patch changed pnv_pec_stk_pci_xscom_read() and pnv_pec_stk_pci_xscom_write() to use a PnvPHB4 opaque, making it easier to move both pci_regs[] and the pci_regs_mr MemoryRegion to the PnvHB4 object. Signed-off-by: Daniel Henrique Barboza

Re: [PATCH 03/17] ppc/pnv: move phbbar to PnvPHB4

2022-01-14 Thread Cédric Le Goater
On 1/13/22 20:29, Daniel Henrique Barboza wrote: This MemoryRegion is simple enough to be moved in a single step. A 'stack->phb' pointer had to be introduced in pnv_pec_stk_update_map() because this function isn't ready to be fully converted to use a PnvPHB4 pointer instead. This will be dealt

Re: [PATCH 07/17] ppc/pnv: move nest_regs[] to PnvPHB4

2022-01-14 Thread Cédric Le Goater
On 1/13/22 20:29, Daniel Henrique Barboza wrote: stack->nest_regs[] is used in several XSCOM functions and it's one of the main culprits of having to deal with stack->phb pointers around the code. Sure, we're having to add 2 extra stack->phb pointers to ease nest_regs[] migration to PnvPHB4.

Re: Re max ISA serial ports

2022-01-14 Thread Peter Maydell
On Fri, 14 Jan 2022 at 10:31, Ani Sinha wrote: > > I have a question re the following commit : > > commit def337ffda34d331404bd7f1a42726b71500df22 > Author: Peter Maydell > Date: Fri Apr 20 15:52:46 2018 +0100 > > serial-isa: Use MAX_ISA_SERIAL_PORTS instead of MAX_SERIAL_PORTS > > > Does

Re: [PATCH 09/17] ppc/pnv: move nest_regs_mr to PnvPHB4

2022-01-14 Thread Cédric Le Goater
On 1/13/22 20:29, Daniel Henrique Barboza wrote: We're now able to cleanly move nest_regs_mr to the PnvPHB4 device. One thing of notice here is the need to use a phb->stack->pec pointer because pnv_pec_stk_nest_xscom_write requires a PEC object. Another thing that can be noticed in the use of

Re: [PULL v5 00/18] Build system and KVM changes for 2021-12-23

2022-01-14 Thread Peter Maydell
On Wed, 12 Jan 2022 at 15:23, Paolo Bonzini wrote: > > The following changes since commit b37778b840f6dc6d1bbaf0e8e0641b3d48ad77c5: > > linux-user: Fix clang warning for nios2-linux-user code (2022-01-12 > 09:22:01 +) > > are available in the Git repository at: > >

Re: [PATCH 17/17] ppc/pnv: rename pnv_pec_stk_update_map()

2022-01-14 Thread Cédric Le Goater
On 1/13/22 20:29, Daniel Henrique Barboza wrote: This function does not use 'stack' anymore. Rename it to pnv_pec_phb_update_map(). Signed-off-by: Daniel Henrique Barboza Reviewed-by: Cédric Le Goater Thanks, C. --- hw/pci-host/pnv_phb4.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH v2 2/2] qapi/block: Restrict vhost-user-blk to CONFIG_VHOST_USER_BLK_SERVER

2022-01-14 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > When building QEMU with --disable-vhost-user and using introspection, > query-qmp-schema lists vhost-user-blk even though it's not actually > available: > > { "execute": "query-qmp-schema" } > { > "return": [ > ... > { >

Re: [PATCH V2 for-6.2 2/2] block/rbd: workaround for ceph issue #53784

2022-01-14 Thread Ilya Dryomov
On Thu, Jan 13, 2022 at 3:44 PM Peter Lieven wrote: > > librbd had a bug until early 2022 that affected all versions of ceph that > supported fast-diff. This bug results in reporting of incorrect offsets > if the offset parameter to rbd_diff_iterate2 is not object aligned. > > This patch works

Re: [PATCH V2 for-6.2 0/2] fixes for bdrv_co_block_status

2022-01-14 Thread Ilya Dryomov
On Thu, Jan 13, 2022 at 3:44 PM Peter Lieven wrote: > > V1->V2: > Patch 1: Treat a hole just like an unallocated area. [Ilya] > Patch 2: Apply workaround only for pre-Quincy librbd versions and > ensure default striping and non child images. [Ilya] > > Peter Lieven (2): > block/rbd:

Re: [PATCH 23/30] bsd-user/signal.c: sigset manipulation routines.

2022-01-14 Thread Peter Maydell
On Sun, 9 Jan 2022 at 16:53, Warner Losh wrote: > > target_sigemptyset: resets a set to having no bits set > qemu_sigorset: computes the or of two sets > target_sigaddset: adds a signal to a set > target_sigismember: returns true when signal is a member > host_to_target_sigset_internal:

Re: [PATCH 1/2] build-sys: fix undefined ARCH error

2022-01-14 Thread Philippe Mathieu-Daudé via
On 14/1/22 09:43, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau ../qga/meson.build:76:4: ERROR: Key ARCH is not in the dictionary. Fixes commit 823eb013 ("configure, meson: move ARCH to meson.build") Signed-off-by: Marc-André Lureau --- qga/meson.build | 2 +- 1 file

Re: [PATCH 4/6] migration: Add ram-only capability

2022-01-14 Thread Markus Armbruster
Nikita Lapshin writes: > If this capability is enabled migration stream > will have RAM section only. > > Signed-off-by: Nikita Lapshin [...] > diff --git a/qapi/migration.json b/qapi/migration.json > index d53956852c..626fc59d14 100644 > --- a/qapi/migration.json > +++ b/qapi/migration.json

Re: [PATCH 11/17] ppc/pnv: introduce PnvPHB4 'phb_number' property

2022-01-14 Thread Daniel Henrique Barboza
On 1/14/22 07:46, Cédric Le Goater wrote: On 1/13/22 20:29, Daniel Henrique Barboza wrote: One of the remaining dependencies we have on the PnvPhb4PecStack object is the stack->stack_no property. This is set as the position the stack occupies in the pec->stacks[] array. We need a way to

Re: [PATCH v5 02/14] hw/core/machine: Introduce CPU cluster topology support

2022-01-14 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Hi, > > On 12/28/21 10:22, Yanan Wang wrote: [...] >> diff --git a/qapi/machine.json b/qapi/machine.json >> index edeab6084b..ff0ab4ca20 100644 >> --- a/qapi/machine.json >> +++ b/qapi/machine.json >> @@ -1404,7 +1404,9 @@ >> # >> # @dies: number of dies per

Re: [PATCH v2 2/3] migration: Add canary to VMSTATE_END_OF_LIST

2022-01-14 Thread Philippe Mathieu-Daudé via
On 13/1/22 20:44, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" We fairly regularly forget VMSTATE_END_OF_LIST markers off descriptions; given that the current check is only for ->name being NULL, sometimes we get unlucky and the code apparently works and no one spots the

Re: [PATCH 24/30] bsd-user/signal.c: setup_frame

2022-01-14 Thread Peter Maydell
On Sun, 9 Jan 2022 at 16:36, Warner Losh wrote: > > setup_frame sets up a signalled stack frame. Associated routines to > extract the pointer to the stack frame and to support alternate stacks. > > Signed-off-by: Stacey Son > Signed-off-by: Kyle Evans > Signed-off-by: Warner Losh > --- >

Re: [PATCH 25/30] bsd-user/signal.c: handle_pending_signal

2022-01-14 Thread Peter Maydell
On Sun, 9 Jan 2022 at 16:47, Warner Losh wrote: > > Handle a queued signal. > > Signed-off-by: Stacey Son > Signed-off-by: Kyle Evans > Signed-off-by: Warner Losh > +static void handle_pending_signal(CPUArchState *cpu_env, int sig, > + struct

Re: [PATCH] Mark remaining global TypeInfo instances as const

2022-01-14 Thread Thomas Huth
On 13/01/2022 18.10, Bernhard Beschow wrote: More than 1k of TypeInfo instances are already marked as const. Mark the remaining ones, too. Signed-off-by: Bernhard Beschow --- hw/core/generic-loader.c | 2 +- hw/core/guest-loader.c | 2 +- hw/display/bcm2835_fb.c| 2 +-

[PATCH] hw/arm/virt: Default enable the virtualization option(VHE) on A64FX

2022-01-14 Thread Shuuichirou Ishii
At A64FX specification, VHE is enabled by default, so the virtualization option should be enabled when -cpu a64fx is specified. Signed-off-by: Shuuichirou Ishii --- hw/arm/virt.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index b45b52c90e..56acf5cc7e

Re: [PATCH 3/3] intel-iommu: PASID support

2022-01-14 Thread Peter Xu
On Fri, Jan 14, 2022 at 03:22:16PM +0800, Jason Wang wrote: > On Fri, Jan 14, 2022 at 3:13 PM Peter Xu wrote: > > > > On Fri, Jan 14, 2022 at 01:58:07PM +0800, Jason Wang wrote: > > > > > Right, but I think you meant to do this only when scalable mode is > > > > > disabled. > > > > > > > > Yes

Re: [PATCH v13 2/7] net/vmnet: add vmnet backends to qapi/net

2022-01-14 Thread Akihiko Odaki
Hi, Thank you for fixing the feature availability check. I decided to just check the series thoroughly before adding Reviewed-By, and unfortunately ended up finding minor memory leaks and style problems. I'm sorry for adding comments so late. Particulalry, his patch has several 2-space

Re: [PATCH v13 6/7] net/vmnet: update qemu-options.hx

2022-01-14 Thread Akihiko Odaki
The corresponding change for hmp-commands.hx is missing (Look for hmp_netdev_add). Regards, Akihiko Odaki On 2022/01/14 2:22, Vladislav Yaroshchuk wrote: Signed-off-by: Vladislav Yaroshchuk --- qemu-options.hx | 25 + 1 file changed, 25 insertions(+) diff --git

Re: [PATCH 4/6] tests/qtest/vhost-user-blk-test: Setup MSIx to avoid error on aarch64

2022-01-14 Thread Thomas Huth
On 10/01/2022 22.19, Eric Auger wrote: When run on ARM, basic and indirect tests currently fail with the following error: ERROR:../tests/qtest/libqos/virtio.c:224:qvirtio_wait_used_elem: assertion failed (got_desc_idx == desc_idx): (50331648 == 0) Bail out!

Re: [PATCH 3/6] tests/qtest/libqos: Skip hotplug tests if pci root bus is not hotpluggable

2022-01-14 Thread Thomas Huth
On 10/01/2022 22.19, Eric Auger wrote: ARM does not not support hotplug on pcie.0. Add a flag on the bus which tells if devices can be hotplugged and skip hotplug tests if the bus cannot be hotplugged. This is a temporary solution to enable the other pci tests on aarch64. Signed-off-by: Eric

Re: [PATCH v3 6/6] MAINTAINERS: add myself as CanoKey maintainer

2022-01-14 Thread Hongren (Zenithal) Zheng
On Fri, Jan 14, 2022 at 02:12:12AM +0800, Hongren (Zenithal) Zheng wrote: > +F: docs/canokey.txt I forgot to change this line, I will change it in the next version along with other requested changes.

Re: [PATCH 1/2] tpm: CRB: Use ram_device for "tpm-crb-cmd" region

2022-01-14 Thread Eric Auger
Hi Stefan, On 1/13/22 4:38 PM, Stefan Berger wrote: > On 1/13/22 09:40, Eric Auger wrote: > >> Hi Stefan, >> >> On 1/13/22 3:06 PM, Stefan Berger wrote: >>> On 1/13/22 05:37, Eric Auger wrote: Representing the CRB cmd/response buffer as a standard RAM region causes some trouble when the

Re: [PATCH v13 3/7] net/vmnet: implement shared mode (vmnet-shared)

2022-01-14 Thread Akihiko Odaki
On 2022/01/14 2:22, Vladislav Yaroshchuk wrote: Interaction with vmnet.framework in different modes differs only on configuration stage, so we can create common `send`, `receive`, etc. procedures and reuse them. vmnet.framework supports iov, but writing more than one iov into vmnet interface

[PATCH 1/2] build-sys: fix undefined ARCH error

2022-01-14 Thread marcandre . lureau
From: Marc-André Lureau ../qga/meson.build:76:4: ERROR: Key ARCH is not in the dictionary. Fixes commit 823eb013 ("configure, meson: move ARCH to meson.build") Signed-off-by: Marc-André Lureau --- qga/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 5/6] tests/qtest/vhost-user-blk-test: Factorize vq setup code

2022-01-14 Thread Thomas Huth
On 10/01/2022 22.19, Eric Auger wrote: The vq setup code is repeated several times and can be easily factorized. Signed-off-by: Eric Auger --- tests/qtest/vhost-user-blk-test.c | 33 +++ 1 file changed, 16 insertions(+), 17 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 2/3] intel-iommu: drop VTDBus

2022-01-14 Thread Jason Wang
在 2022/1/14 上午10:32, Jason Wang 写道: dressSpace *as)   /* GHashTable functions */   static gboolean vtd_uint64_equal(gconstpointer v1, gconstpointer v2)   { -    return *((const uint64_t *)v1) == *((const uint64_t *)v2); +    const struct vtd_as_key *key1 = v1; +    const struct vtd_as_key

Re: [PULL V3 00/13] Net patches

2022-01-14 Thread Jason Wang
在 2022/1/14 下午1:08, Jason Wang 写道: The following changes since commit f8d75e10d3e0033a0a29a7a7e4777a4fbc17a016: Merge remote-tracking branch 'remotes/legoater/tags/pull-ppc-20220112' into staging (2022-01-13 11:18:24 +) are available in the git repository at:

Re: [PATCH 3/3] intel-iommu: PASID support

2022-01-14 Thread Jason Wang
On Fri, Jan 14, 2022 at 3:13 PM Peter Xu wrote: > > On Fri, Jan 14, 2022 at 01:58:07PM +0800, Jason Wang wrote: > > > > Right, but I think you meant to do this only when scalable mode is > > > > disabled. > > > > > > Yes IMHO it will definitely suite for !scalable case since that's exactly > >

Re: [PATCH] hw/arm/virt: Default enable the virtualization option(VHE) on A64FX

2022-01-14 Thread Andrew Jones
On Fri, Jan 14, 2022 at 04:24:37PM +0900, Shuuichirou Ishii wrote: > At A64FX specification, VHE is enabled by default, so > the virtualization option should be enabled when -cpu a64fx > is specified. > > Signed-off-by: Shuuichirou Ishii > --- > hw/arm/virt.c | 6 ++ > 1 file changed, 6

Re: [PATCH 1/6] tests/qtest/vhost-user-test.c: Use vhostforce=on

2022-01-14 Thread Thomas Huth
On 10/01/2022 22.19, Eric Auger wrote: -netdev vhost-user,vhostforce is deprecated and vhostforce=on should be used instead. Signed-off-by: Eric Auger --- tests/qtest/vhost-user-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qtest/vhost-user-test.c

[PATCH 2/2] docker: add msitools to Fedora/mingw cross

2022-01-14 Thread marcandre . lureau
From: Marc-André Lureau That should help catch build issues/regressions with wixl. Signed-off-by: Marc-André Lureau --- tests/docker/dockerfiles/fedora-win32-cross.docker | 1 + tests/docker/dockerfiles/fedora-win64-cross.docker | 1 + 2 files changed, 2 insertions(+) diff --git

Re: [PATCH v13 5/7] net/vmnet: implement bridged mode (vmnet-bridged)

2022-01-14 Thread Akihiko Odaki
On 2022/01/14 2:22, Vladislav Yaroshchuk wrote: Signed-off-by: Vladislav Yaroshchuk --- net/vmnet-bridged.m | 105 +--- 1 file changed, 100 insertions(+), 5 deletions(-) diff --git a/net/vmnet-bridged.m b/net/vmnet-bridged.m index

Re: [PATCH 3/3] intel-iommu: PASID support

2022-01-14 Thread Jason Wang
On Fri, Jan 14, 2022 at 3:45 PM Peter Xu wrote: > > On Fri, Jan 14, 2022 at 03:22:16PM +0800, Jason Wang wrote: > > On Fri, Jan 14, 2022 at 3:13 PM Peter Xu wrote: > > > > > > On Fri, Jan 14, 2022 at 01:58:07PM +0800, Jason Wang wrote: > > > > > > Right, but I think you meant to do this only

[PULL 14/20] edid: set default resolution to 1280x800 (WXGA)

2022-01-14 Thread Gerd Hoffmann
From: Daniel P. Berrangé Currently QEMU defaults to a resolution of 1024x768 when exposing EDID info to the guest OS. The EDID default info is important as this will influence what resolution many guest OS will configure the screen with on boot. It can also potentially influence what resolution

Re: [PATCH 2/6] tests/qtest/libqos/pci: Introduce pio_limit

2022-01-14 Thread Thomas Huth
On 10/01/2022 22.19, Eric Auger wrote: At the moment the IO space limit is hardcoded to QPCI_PIO_LIMIT = 0x1. When accesses are performed to a bar, the base address of this latter is compared against the limit to decide whether we perform an IO or a memory access. On ARM, we cannot keep

Re: [PATCH 6/6] tests/qtest/libqos: Add pci-arm and add a pci-arm producer in arm-virt machine

2022-01-14 Thread Thomas Huth
On 10/01/2022 22.19, Eric Auger wrote: Up to now the virt-machine node contains a virtio-mmio node. However no driver produces any PCI interface node. Hence, PCI tests cannot be run with aarch64 binary. Add a GPEX driver node that produces a pci interface node. This latter then can be consumed

Re: [PATCH 3/3] linux-user: Return void from queue_signal()

2022-01-14 Thread Philippe Mathieu-Daudé via
On 14/1/22 16:37, Peter Maydell wrote: The linux-user queue_signal() function always returns 1, and none of its callers check the return value. Give it a void return type instead. The return value is a leftover from the old pre-2016 linux-user signal handling code, which really did have a

Re: [PATCH 1/1] virtio: fix the condition for iommu_platform not supported

2022-01-14 Thread Halil Pasic
On Thu, 13 Jan 2022 20:54:52 +0100 Halil Pasic wrote: > > > This is the very reason for which commit 7ef7e6e3b ("vhost: correctly > > > turn on VIRTIO_F_IOMMU_PLATFORM") for, which fences _F_ACCESS_PLATFORM > > > form the vhost device that does not need it, because on the vhost > > > interface

Re: [PATCH v3 05/19] block/block-copy: add block_copy_reset()

2022-01-14 Thread Hanna Reitz
On 22.12.21 18:40, Vladimir Sementsov-Ogievskiy wrote: Split block_copy_reset() out of block_copy_reset_unallocated() to be used separately later. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/block-copy.h | 1 + block/block-copy.c | 21 + 2

[PATCH v2 1/8] ppc/pnv: introduce PnvPHB4 'pec' property

2022-01-14 Thread Daniel Henrique Barboza
This property will track the owner PEC of this PHB. For now it's redundant since we can retrieve the PEC via phb->stack->pec but it will not be redundant when we get rid of the stack device. Reviewed-by: Cédric Le Goater Signed-off-by: Daniel Henrique Barboza --- hw/pci-host/pnv_phb4.c

[PATCH v2 3/8] ppc/pnv: remove stack pointer from PnvPHB4

2022-01-14 Thread Daniel Henrique Barboza
This pointer was being used for two reasons: pnv_phb4_update_regions() was using it to access the PHB and phb4_realize() was using it as a way to determine if the PHB was user created. We can determine if the PHB is user created via phb->pec, introduced in the previous patch, and

[PATCH v2 2/8] ppc/pnv: reduce stack->stack_no usage

2022-01-14 Thread Daniel Henrique Barboza
'stack->stack_no' represents the order that a stack appears in its PEC. Its primary use is in XSCOM address space calculation in pnv_phb4_xscom_realize() when calculating the memory region offset. This attribute is redundant with phb->phb_id, which is calculated via pnv_phb4_pec_get_phb_id()

Re: [PATCH 10/30] bsd-user/signal.c: Implement signal_init()

2022-01-14 Thread Warner Losh
On Thu, Jan 13, 2022 at 12:28 PM Peter Maydell wrote: > On Sun, 9 Jan 2022 at 16:29, Warner Losh wrote: > > > > Initialize the signal state for the emulator. Setup a set of sane > > default signal handlers, mirroring the host's signals. For fatal signals > > (those that exit by default),

Re: [PATCH v3 23/31] iotests: switch to AQMP

2022-01-14 Thread Eric Blake
On Mon, Jan 10, 2022 at 06:29:02PM -0500, John Snow wrote: > Simply import the type defition from the new location. definition > > Signed-off-by: John Snow > Reviewed-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Beraldo Leal > --- > tests/qemu-iotests/iotests.py | 2 +- > 1 file changed,

[PATCH v2 2/9] target/s390x: add zpci-interp to cpu models

2022-01-14 Thread Matthew Rosato
The zpci-interp feature is used to specify whether zPCI interpretation is to be used for this guest. Signed-off-by: Matthew Rosato --- target/s390x/cpu_features_def.h.inc | 1 + target/s390x/gen-features.c | 2 ++ target/s390x/kvm/kvm.c | 1 + 3 files changed, 4

[PATCH] hw/riscv: spike: Allow using binary firmware as bios

2022-01-14 Thread Anup Patel
Currently, we have to use OpenSBI firmware ELF as bios for the spike machine because the HTIF console requires ELF for parsing "fromhost" and "tohost" symbols. The latest OpenSBI can now optionally pick-up HTIF register address from HTIF DT node so using this feature spike machine can now use

[PATCH v2 7/9] s390x/pci: use I/O Address Translation assist when interpreting

2022-01-14 Thread Matthew Rosato
Allow the underlying kvm host to handle the Refresh PCI Translation instruction intercepts. Reviewed-by: Pierre Morel Signed-off-by: Matthew Rosato --- hw/s390x/s390-pci-bus.c | 6 ++-- hw/s390x/s390-pci-inst.c | 51 ++-- hw/s390x/s390-pci-vfio.c

[PATCH v2 9/9] s390x/pci: let intercept devices have separate PCI groups

2022-01-14 Thread Matthew Rosato
Let's use the reserved pool of simulated PCI groups to allow intercept devices to have separate groups from interpreted devices as some group values may be different. If we run out of simulated PCI groups, subsequent intercept devices just get the default group. Furthermore, if we encounter any

[PATCH v2 5/8] ppc/pnv: remove PnvPhb4PecStack::stack_no

2022-01-14 Thread Daniel Henrique Barboza
pnv_pec_default_phb_realize() stopped using it after the previous patch and no one else is using it. Signed-off-by: Daniel Henrique Barboza --- hw/pci-host/pnv_phb4_pec.c | 2 -- include/hw/pci-host/pnv_phb4.h | 3 --- 2 files changed, 5 deletions(-) diff --git a/hw/pci-host/pnv_phb4_pec.c

Re: [Virtio-fs] [PATCH v2] virtiofsd: Do not support blocking flock

2022-01-14 Thread Vivek Goyal
On Thu, Jan 13, 2022 at 04:32:49PM +0100, Sebastian Hasler wrote: > With the current implementation, blocking flock can lead to > deadlock. Thus, it's better to return EOPNOTSUPP if a user attempts > to perform a blocking flock request. > > Signed-off-by: Sebastian Hasler Reviewed-by: Vivek

Re: [PATCH 08/30] bsd-user/arm/target_arch_cpu.h: Implement data faults

2022-01-14 Thread Peter Maydell
On Fri, 14 Jan 2022 at 18:14, Warner Losh wrote: > > > > On Thu, Jan 13, 2022 at 10:40 AM Peter Maydell > wrote: >> >> On Sun, 9 Jan 2022 at 16:29, Warner Losh wrote: >> > >> > Update for the richer set of data faults that are now possible. Copied >> > largely from linux-user/arm/cpu_loop.c >>

[PATCH] linux-user: Fix comment typo in arm cpu_loop code

2022-01-14 Thread Peter Maydell
Fix a typo in a comment in the arm cpu_loop code. Signed-off-by: Peter Maydell --- linux-user/arm/cpu_loop.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/linux-user/arm/cpu_loop.c b/linux-user/arm/cpu_loop.c index f153ab503a8..032e1ffddfb 100644 ---

[PATCH v2 8/9] s390x/pci: use dtsm provided from vfio capabilities for interpreted devices

2022-01-14 Thread Matthew Rosato
When using the IOAT assist via interpretation, we should advertise what the host driver supports, not QEMU. Reviewed-by: Pierre Morel Signed-off-by: Matthew Rosato --- hw/s390x/s390-pci-vfio.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/s390x/s390-pci-vfio.c

[PATCH v2 6/9] s390x/pci: enable adapter event notification for interpreted devices

2022-01-14 Thread Matthew Rosato
Use the associated vfio feature ioctl to enable adapter event notification and forwarding for devices when requested. This feature will be set up with or without firmware assist based upon the 'intassist' setting. Signed-off-by: Matthew Rosato --- hw/s390x/s390-pci-bus.c | 24

Re: [PATCH 1/2] accel/tcg: Optimize jump cache flush during tlb range flush

2022-01-14 Thread Idan Horowitz
Alex Bennée wrote: > > > For multi-patch series please include a cover letter which is the parent > of all the patches. This is the default for git-send-email. > Sorry, I will do so from now on. > > The code itself looks fine but what sort of improvements are we talking > about here? What

Re: [PATCH v3 04/19] block/copy-before-write: add bitmap open parameter

2022-01-14 Thread Hanna Reitz
On 22.12.21 18:40, Vladimir Sementsov-Ogievskiy wrote: This brings "incremental" mode to copy-before-write filter: user can specify bitmap so that filter will copy only "dirty" areas. Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/block-core.json | 10 +-

Re: [PATCH 08/30] bsd-user/arm/target_arch_cpu.h: Implement data faults

2022-01-14 Thread Warner Losh
On Thu, Jan 13, 2022 at 10:40 AM Peter Maydell wrote: > On Sun, 9 Jan 2022 at 16:29, Warner Losh wrote: > > > > Update for the richer set of data faults that are now possible. Copied > > largely from linux-user/arm/cpu_loop.c > > > > Signed-off-by: Warner Losh > > --- > >

Re: [PATCH 09/30] bsd-user/signal.c: implement abstract target / host signal translation

2022-01-14 Thread Warner Losh
On Thu, Jan 13, 2022 at 10:45 AM Peter Maydell wrote: > On Sun, 9 Jan 2022 at 16:29, Warner Losh wrote: > > > > Implement host_to_target_signal and target_to_host_signal. > > > > Signed-off-by: Stacey Son > > Signed-off-by: Kyle Evans > > Signed-off-by: Warner Losh > > --- > >

[PATCH v2 0/9] s390x/pci: zPCI interpretation support

2022-01-14 Thread Matthew Rosato
For QEMU, the majority of the work in enabling instruction interpretation is handled via new VFIO ioctls to SET the appropriate interpretation and interrupt forwarding modes, and to GET the function handle to use for interpretive execution. This series implements these new ioctls, as well as

Re: [PATCH 1/2] accel/tcg: Optimize jump cache flush during tlb range flush

2022-01-14 Thread Idan Horowitz
Idan Horowitz wrote: > > cbnz x9, 0x5168abc8 > I forgot to include the addresses of the instructions, making this jump undecipherable, here's the snippet again but with addresses this time: 0x5168abb0 movkx0, #0x0 0x5168abb4 movkx0, #0x0, lsl #16 0x5168abb8 movkx0, #0xff80, lsl

Re: [PATCH v2 3/9] fixup: force interp off for QEMU machine 6.2 and older

2022-01-14 Thread Matthew Rosato
On 1/14/22 3:38 PM, Matthew Rosato wrote: Double-check I'm doing this right + test. Argh... This should have been squashed into the preceding patch 'target/s390x: add zpci-interp to cpu models' Signed-off-by: Matthew Rosato --- hw/s390x/s390-virtio-ccw.c | 1 + 1 file changed, 1

Re: [PATCH 4/6] migration: Add ram-only capability

2022-01-14 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Fri, Jan 14, 2022 at 12:22:13PM +0100, Markus Armbruster wrote: >> Nikita Lapshin writes: >> >> > If this capability is enabled migration stream >> > will have RAM section only. >> > >> > Signed-off-by: Nikita Lapshin >> >> [...] >> >> > diff --git

Re: [PATCH 2/2] hw/i386: support loading OVMF using -bios too

2022-01-14 Thread Michael S. Tsirkin
On Thu, Jan 13, 2022 at 04:55:11PM +, Daniel P. Berrangé wrote: > Traditionally the OVMF firmware has been loaded using the pflash > mechanism. This is because it is usually provided as a pair of > files, one read-only containing the code and one writable to > provided persistence of

[PATCH v2 3/9] fixup: force interp off for QEMU machine 6.2 and older

2022-01-14 Thread Matthew Rosato
Double-check I'm doing this right + test. Signed-off-by: Matthew Rosato --- hw/s390x/s390-virtio-ccw.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c index 84e3e63c43..e02fe11b07 100644 --- a/hw/s390x/s390-virtio-ccw.c +++

[PATCH v2 4/9] s390x/pci: enable for load/store intepretation

2022-01-14 Thread Matthew Rosato
Use the associated vfio feature ioctl to enable interpretation for devices when requested. As part of this process, we must use the host function handle rather than a QEMU-generated one -- this is provided as part of the ioctl payload. Signed-off-by: Matthew Rosato --- hw/s390x/s390-pci-bus.c

Re: [PATCH] linux-user: Remove stale "not threadsafe" comments

2022-01-14 Thread Peter Maydell
On Fri, 14 Jan 2022 at 15:50, Peter Maydell wrote: > > In linux-user/signal.c we have two FIXME comments claiming that > parts of the signal-handling code are not threadsafe. These are > very old, as they were first introduced in commit 624f7979058 > in 2008. Since then we've radically overhauled

Re: [PATCH v3 03/19] block/block-copy: block_copy_state_new(): add bitmap parameter

2022-01-14 Thread Hanna Reitz
On 22.12.21 18:40, Vladimir Sementsov-Ogievskiy wrote: This will be used in the following commit to bring "incremental" mode to copy-before-write filter. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/block-copy.h | 2 +- block/block-copy.c | 14 --

[PATCH v2 8/8] ppc/pnv: rename pnv_pec_stk_update_map()

2022-01-14 Thread Daniel Henrique Barboza
This function does not use 'stack' anymore. Rename it to pnv_pec_phb_update_map(). Reviewed-by: Cédric Le Goater Signed-off-by: Daniel Henrique Barboza --- hw/pci-host/pnv_phb4.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/pci-host/pnv_phb4.c

Re: [PATCH] linux-user: Fix comment typo in arm cpu_loop code

2022-01-14 Thread Warner Losh
On Fri, Jan 14, 2022 at 11:25 AM Peter Maydell wrote: > Fix a typo in a comment in the arm cpu_loop code. > > Signed-off-by: Peter Maydell > --- > linux-user/arm/cpu_loop.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Warner Losh > diff --git

[PATCH v2 7/8] ppc/pnv: remove PnvPhb4PecStack object

2022-01-14 Thread Daniel Henrique Barboza
All the complexity that was scattered between PnvPhb4PecStack and PnvPHB4 are now centered in the PnvPHB4 device. PnvPhb4PecStack does not serve any purpose in the current code base. Reviewed-by: Cédric Le Goater Signed-off-by: Daniel Henrique Barboza --- hw/pci-host/pnv_phb4_pec.c | 33

  1   2   >