Re: [PATCH] hw/pci-host/i440fx: Remove unused parameter from i440fx_init()

2022-06-20 Thread Mark Cave-Ayland
On 19/06/2022 22:44, B wrote: Am 12. Juni 2022 19:28:00 UTC schrieb Bernhard Beschow : pi440fx_state is an out-parameter which is never read by the caller. Signed-off-by: Bernhard Beschow Ping --- hw/i386/pc_piix.c| 3 --- hw/pci-host/i440fx.c | 4 +---

Re: [PATCH 4/9] error-report: simplify print_loc()

2022-06-20 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Pass the program name as "prefix" argument to print_loc() if printing > with "details". This allows to get rid of monitor_cur() call in > print_loc(). > > Signed-off-by: Marc-André Lureau > --- > util/error-report.c | 8

[PATCH 4/8] hw/loongarch: Add LoongArch acpi support

2022-06-20 Thread Xiaojuan Yang
Signed-off-by: Xiaojuan Yang --- hw/loongarch/Kconfig| 2 + hw/loongarch/acpi-build.c | 620 hw/loongarch/loongson3.c| 78 - hw/loongarch/meson.build| 4 + include/hw/loongarch/virt.h | 13 + include/hw/pci-host/ls7a.h | 5 + 6

[PATCH 6/8] hw/loongarch: Fix loongarch ipi device

2022-06-20 Thread Xiaojuan Yang
Signed-off-by: Xiaojuan Yang --- hw/intc/loongarch_ipi.c | 85 ++--- hw/loongarch/loongson3.c| 5 +- include/hw/intc/loongarch_ipi.h | 8 ++-- 3 files changed, 65 insertions(+), 33 deletions(-) diff --git a/hw/intc/loongarch_ipi.c

[PATCH 0/8] Add some functions for LoongArch

2022-06-20 Thread Xiaojuan Yang
In order to start the latest community BIOS and kernel of LoongArch, we have added the following patches. This series add some functions for LoongArch, and fix some errors. Add bios, kernel, fdt, smbios and acpi options support. The kernel file: *

Re: [PATCH v4 1/4] QIOChannelSocket: Introduce assert and reduce ifdefs to improve readability

2022-06-20 Thread Juan Quintela
Leonardo Bras wrote: > During implementation of MSG_ZEROCOPY feature, a lot of #ifdefs were > introduced, particularly at qio_channel_socket_writev(). > > Rewrite some of those changes so it's easier to read. > > Also, introduce an assert to help detect incorrect zero-copy usage is when > it's

Re: [RFC PATCH 01/12] configure: Add iovisor/ubpf project as a submodule for QEMU

2022-06-20 Thread Thomas Huth
On 20/06/2022 11.29, Zhang, Chen wrote: -Original Message- From: Thomas Huth Sent: Monday, June 20, 2022 4:47 PM To: Daniel P. Berrangé ; Zhang, Chen Cc: Jason Wang ; qemu-dev ; Paolo Bonzini ; Eduardo Habkost ; Eric Blake ; Markus Armbruster ; Peter Maydell ; Laurent Vivier ; Yuri

[PATCH v18 10/13] target/loongarch: remove unused include hw/loader.h

2022-06-20 Thread Song Gao
Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson --- target/loongarch/cpu.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target/loongarch/cpu.c b/target/loongarch/cpu.c index 0013582a3a..bf163a8dce 100644 --- a/target/loongarch/cpu.c +++

[RFC PATCH v3 07/11] net: dgram: make dgram_dst generic

2022-06-20 Thread Laurent Vivier
dgram_dst is a sockaddr_in structure. To be able to use it with unix socket, use a pointer to a generic sockaddr structure. Signed-off-by: Laurent Vivier Reviewed-by: Stefano Brivio --- net/dgram.c | 76 +++-- 1 file changed, 45 insertions(+), 31

[PATCH v2 01/21] io: add a QIOChannelNull equivalent to /dev/null

2022-06-20 Thread Daniel P . Berrangé
This is for code which needs a portable equivalent to a QIOChannelFile connected to /dev/null. Signed-off-by: Daniel P. Berrangé --- include/io/channel-null.h | 55 +++ io/channel-null.c | 237 ++ io/meson.build| 1 +

[PATCH v2 02/21] migration: switch to use QIOChannelNull for dummy channel

2022-06-20 Thread Daniel P . Berrangé
This removes one further custom impl of QEMUFile, in favour of a QIOChannel based impl. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrangé --- migration/ram.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index

[PATCH v2 00/21] migration: remove QEMUFileOps concept and assume use of QIOChannel

2022-06-20 Thread Daniel P . Berrangé
Quite a while ago now, the majority of QEMUFile implementations were switched over to use QIOChannel APIs, but a couple remained. The newish multifd code is directly using QIOChannel, only calling in to QEMUFile for the VMState transfer and for rate limiting purposes. This series finishes the

[PATCH v2 11/21] migration: stop passing 'opaque' parameter to QEMUFile hooks

2022-06-20 Thread Daniel P . Berrangé
The only user of the hooks is RDMA which provides a QIOChannel backed impl of QEMUFile. It can thus use the qemu_file_get_ioc() method. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé --- migration/qemu-file.c | 8 migration/qemu-file.h | 14 ++

[PATCH v2 09/21] migration: introduce a QIOChannel impl for BlockDriverState VMState

2022-06-20 Thread Daniel P . Berrangé
Introduce a QIOChannelBlock class that exposes the BlockDriverState VMState region for I/O. This is kept in the migration/ directory rather than io/, to avoid a mutual dependancy between block/ <-> io/ directories. Also the VMState should only be used by the migration code. Reviewed-by: Daniel

[PATCH v2 18/21] migration: remove the QEMUFileOps 'get_buffer' callback

2022-06-20 Thread Daniel P . Berrangé
This directly implements the get_buffer logic using QIOChannel APIs. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé --- migration/qemu-file-channel.c | 29 - migration/qemu-file.c | 18 -- migration/qemu-file.h

Re: [RFC PATCH v3 02/11] net: remove the @errp argument of net_client_inits()

2022-06-20 Thread Markus Armbruster
Laurent Vivier writes: > The only caller passes _fatal, so use this directly in the function. > > It's what we do for -blockdev, -device, and -object. > > Signed-off-by: Laurent Vivier Reviewed-by: Markus Armbruster

[PATCH 2/8] hw/loongarch: Add -kernel and -initrd options support

2022-06-20 Thread Xiaojuan Yang
Signed-off-by: Xiaojuan Yang --- hw/loongarch/loongson3.c | 125 ++- 1 file changed, 110 insertions(+), 15 deletions(-) diff --git a/hw/loongarch/loongson3.c b/hw/loongarch/loongson3.c index 1e2c69dd8e..638280c4e7 100644 --- a/hw/loongarch/loongson3.c +++

Re: [PATCH qemu v2 2/2] ppc/spapr: Implement H_WATCHDOG

2022-06-20 Thread Alexey Kardashevskiy
On 6/20/22 16:23, Cédric Le Goater wrote: On 6/20/22 05:13, Alexey Kardashevskiy wrote: On 6/18/22 21:01, Cédric Le Goater wrote: On 6/17/22 08:07, Alexey Kardashevskiy wrote: The new PAPR 2.12 defines a watchdog facility managed via the new H_WATCHDOG hypercall. This adds H_WATCHDOG

[PATCH v18 06/13] scripts: add loongarch64 binfmt config

2022-06-20 Thread Song Gao
Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson --- scripts/qemu-binfmt-conf.sh | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh index 9cb723f443..1f4e2cd19d 100755 ---

[PATCH v18 05/13] linux-user: Add LoongArch cpu_loop support

2022-06-20 Thread Song Gao
Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson --- linux-user/loongarch64/cpu_loop.c | 96 + linux-user/loongarch64/target_cpu.h | 34 ++ 2 files changed, 130 insertions(+) create mode 100644

[PATCH v18 03/13] linux-user: Add LoongArch elf support

2022-06-20 Thread Song Gao
Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- linux-user/elfload.c| 91 + linux-user/loongarch64/target_elf.h | 12 2 files changed, 103 insertions(+) create mode

[PATCH v18 13/13] target/loongarch: Update README

2022-06-20 Thread Song Gao
Add linux-user emulation introduction Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson --- target/loongarch/README | 39 +-- 1 file changed, 37 insertions(+), 2 deletions(-) diff --git a/target/loongarch/README

Re: [RFC PATCH 01/12] configure: Add iovisor/ubpf project as a submodule for QEMU

2022-06-20 Thread Daniel P . Berrangé
On Mon, Jun 20, 2022 at 09:29:05AM +, Zhang, Chen wrote: > > > > > On 20/06/2022 10.11, Daniel P. Berrangé wrote: > > > On Mon, Jun 20, 2022 at 05:59:06AM +, Zhang, Chen wrote: > > >> > > >> > > >>> On Fri, Jun 17, 2022 at 03:36:19PM +0800, Zhang Chen wrote: > > Make iovisor/ubpf

RE: [RFC PATCH 01/12] configure: Add iovisor/ubpf project as a submodule for QEMU

2022-06-20 Thread Zhang, Chen
> -Original Message- > From: Daniel P. Berrangé > Sent: Monday, June 20, 2022 6:01 PM > To: Zhang, Chen > Cc: Thomas Huth ; Jason Wang > ; qemu-dev ; Paolo > Bonzini ; Eduardo Habkost ; > Eric Blake ; Markus Armbruster > ; Peter Maydell ; Laurent > Vivier ; Yuri Benditovich > ; Andrew

[RFC PATCH v3 06/11] net: stream: add unix socket

2022-06-20 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Stefano Brivio --- net/stream.c | 106 +++ 1 file changed, 99 insertions(+), 7 deletions(-) diff --git a/net/stream.c b/net/stream.c index 12fc26b9f4c7..dca50508ed84 100644 --- a/net/stream.c +++

[PATCH v2 05/21] migration: rename 'pos' field in QEMUFile to 'bytes_processed'

2022-06-20 Thread Daniel P . Berrangé
The field name 'pos' gives the misleading impression that the QEMUFile objects are seekable. This is not the case, as in general we just have an opaque stream. The users of this method are only interested in the total bytes processed. This switches to a new name that reflects the intended usage.

[PATCH v2 03/21] migration: remove unreachble RDMA code in save_hook impl

2022-06-20 Thread Daniel P . Berrangé
The QEMUFile 'save_hook' callback has a 'size_t size' parameter. The RDMA impl of this has logic that takes different actions depending on whether the value is zero or non-zero. It has commented out logic that would have taken further actions if the value was negative. The only place where the

Re: [PATCH 3/4] slirp: Add mfr-id to -netdev options

2022-06-20 Thread Markus Armbruster
Peter Delevoryas writes: > This lets you set the manufacturer's ID for a slirp netdev, which can be > queried from the guest through the Get Version ID NC-SI command. For > example, by setting the manufacturer's ID to 0x8119: > > wget >

Re: [PATCH 3/9] error-report: introduce "detailed" variable

2022-06-20 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Let's use a more explicit variable "detailed" instead of calling > monitor_cur() multiple times. > > Signed-off-by: Marc-André Lureau > --- > util/error-report.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >

Re: [PATCH qemu v2 1/2] ppc: Define SETFIELD for the ppc target

2022-06-20 Thread Alexey Kardashevskiy
On 6/20/22 16:17, Cédric Le Goater wrote: On 6/20/22 05:37, Alexey Kardashevskiy wrote: On 6/18/22 02:50, Daniel Henrique Barboza wrote: On 6/17/22 03:07, Alexey Kardashevskiy wrote: It keeps repeating, move it to the header. This uses __builtin_ctzl() to allow using the macros in

Re: [PATCH v3 1/2] hw: m25p80: add WP# pin and SRWD bit for write protection

2022-06-20 Thread Francisco Iglesias
Hi Iris, On [2022 Jun 17] Fri 15:02:45, Iris Chen wrote: > Signed-off-by: Iris Chen > --- > Thanks everyone for your comments. This is a v3 patch that addresses all > suggestions (moving write_enable to decode_new_cmd). > I am waiting on some feedback from Dan's (dz4l...@gmail.com) patch >

Re: [RFC PATCH v2 3/8] qapi: net: add stream and dgram netdevs

2022-06-20 Thread Laurent Vivier
On 15/06/2022 13:46, Markus Armbruster wrote: Laurent Vivier writes: On 13/05/2022 13:44, Markus Armbruster wrote: Laurent Vivier writes: Copied from socket netdev file and modified to use SocketAddress to be able to introduce new features like unix socket. "udp" and "mcast" are squashed

[PATCH v18 09/13] target/loongarch: Fix helper_asrtle_d/asrtgt_d raise wrong exception

2022-06-20 Thread Song Gao
Raise EXCCODE_BCE instead of EXCCODE_ADEM for helper_asrtle_d/asrtgt_d. Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson --- target/loongarch/cpu.c | 2 ++ target/loongarch/op_helper.c | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff

[PATCH v18 00/13] Add LoongArch linux-user emulation support

2022-06-20 Thread Song Gao
Hi All, This series adds support linux-user emulation. As the LoongArch kernel had merged into 5.19-rc1, you can see the latest kernel at https://kernel.org Need review patch: 0002-linux-user-Add-LoongArch-signal-support.patch V18: - Update signal.c, add set fpu_context'magic, update

[PATCH v18 07/13] target/loongarch: remove badaddr from CPULoongArch

2022-06-20 Thread Song Gao
We can use CSR_BADV to replace badaddr. Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson --- target/loongarch/cpu.h | 2 -- target/loongarch/gdbstub.c | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/target/loongarch/cpu.h

Re: [PATCH v4 4/4] migration: Change zero_copy_send from migration parameter to migration capability

2022-06-20 Thread Juan Quintela
Leonardo Bras wrote: > When originally implemented, zero_copy_send was designed as a Migration > paramenter. > > But taking into account how is that supposed to work, and how > the difference between a capability and a parameter, it only makes sense > that zero-copy-send would work better as a

[PATCH v18 11/13] target/loongarch: Adjust functions and structure to support user-mode

2022-06-20 Thread Song Gao
Some functions and member of the structure are different with softmmu-mode So we need adjust them to support user-mode. Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson --- target/loongarch/cpu.c| 21 ++-

qemu-ga guest-exec & SELinux

2022-06-20 Thread Marc-André Lureau
Hi! https://bugzilla.redhat.com/show_bug.cgi?id=2093355 ("AVCs when trying to execute a command through qemu-ga ("guest-exec" command)") describes an issue with fedora/rhel SELinux rules, where some program executions are denied. qemu-ga has "virt_qemu_ga_t" context, and is not allowed to

Re: [RFC PATCH 12/12] test/qtest: Add ubpf basic test case

2022-06-20 Thread Thomas Huth
On 20/06/2022 11.31, Zhang, Chen wrote: -Original Message- From: Thomas Huth Sent: Friday, June 17, 2022 5:34 PM To: Zhang, Chen ; Jason Wang ; qemu-dev ; Paolo Bonzini ; Daniel P. Berrangé ; Eduardo Habkost ; Eric Blake ; Markus Armbruster Cc: Peter Maydell ; Laurent Vivier ; Yuri

Re: qemu-ga guest-exec & SELinux

2022-06-20 Thread Daniel P . Berrangé
On Mon, Jun 20, 2022 at 01:44:05PM +0400, Marc-André Lureau wrote: > Hi! > > https://bugzilla.redhat.com/show_bug.cgi?id=2093355 ("AVCs when trying to > execute a command through qemu-ga ("guest-exec" command)") describes an > issue with fedora/rhel SELinux rules, where some program executions

[RFC PATCH v3 00/11] qapi: net: add unix socket type support to netdev backend

2022-06-20 Thread Laurent Vivier
"-netdev socket" only supports inet sockets. It's not a complex task to add support for unix sockets, but the socket netdev parameters are not defined to manage well unix socket parameters. As discussed in: "socket.c added support for unix domain socket datagram transport"

[RFC PATCH v3 01/11] net: introduce convert_host_port()

2022-06-20 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Stefano Brivio --- include/qemu/sockets.h | 2 ++ net/net.c | 62 ++ 2 files changed, 34 insertions(+), 30 deletions(-) diff --git a/include/qemu/sockets.h b/include/qemu/sockets.h index

Re: [PATCH] hw:m25p80: Add STATE_STANDBY command state

2022-06-20 Thread Francisco Iglesias
Hi Dan, On [2022 Jun 14] Tue 13:02:05, Dan Zhang wrote: > HW normally will switch it to stand by mode when receive incorrect > command. > i.e. Macronix MX66L1G45G data sheet section 8 DEVICE OPERATION described > ``` > 2. When an incorrect command is written to this device, it enters > standby

Re: TCG development tools?

2022-06-20 Thread Thomas Huth
On 19/06/2022 05.34, Kenneth Adam Miller wrote: Hello all, Suppose I am wanting to implement and test for the TCG. Is there any set of interactive binaries or other things that I could use to work with it? Could I open a shell to it?  Perhaps feed it specific byte sequences for tests to

[PATCH 3/8] hw/loongarch: Add LoongArch smbios support

2022-06-20 Thread Xiaojuan Yang
Signed-off-by: Xiaojuan Yang --- hw/loongarch/Kconfig| 1 + hw/loongarch/loongson3.c| 38 + include/hw/loongarch/virt.h | 1 + 3 files changed, 40 insertions(+) diff --git a/hw/loongarch/Kconfig b/hw/loongarch/Kconfig index

[PATCH 8/8] target/loongarch: Fix csrwr timer clear

2022-06-20 Thread Xiaojuan Yang
Signed-off-by: Xiaojuan Yang --- target/loongarch/csr_helper.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/loongarch/csr_helper.c b/target/loongarch/csr_helper.c index 24a9389364..7e02787895 100644 --- a/target/loongarch/csr_helper.c +++ b/target/loongarch/csr_helper.c @@ -81,7

[PATCH 7/8] target/loongarch: Fix vector size of exception entry address

2022-06-20 Thread Xiaojuan Yang
Signed-off-by: Xiaojuan Yang --- target/loongarch/cpu.c | 4 1 file changed, 4 insertions(+) diff --git a/target/loongarch/cpu.c b/target/loongarch/cpu.c index 401d3fd30a..d1a87e8e1c 100644 --- a/target/loongarch/cpu.c +++ b/target/loongarch/cpu.c @@ -219,6 +219,10 @@ static void

[PATCH 1/8] hw/loongarch: Add default bios startup support

2022-06-20 Thread Xiaojuan Yang
Signed-off-by: Xiaojuan Yang --- hw/loongarch/fw_cfg.c | 33 +++ hw/loongarch/fw_cfg.h | 15 +++ hw/loongarch/loongson3.c| 81 - include/hw/loongarch/virt.h | 7 4 files changed, 135 insertions(+), 1 deletion(-) create

Re: [PATCH v4 3/4] migration: zero-copy flush only at the end of bitmap scanning

2022-06-20 Thread Juan Quintela
Leonardo Bras wrote: > When sending memory pages with MSG_ZEROCOPY, it's necessary to flush > to make sure all dirty pages are sent before a future version of them > happens to be sent. > > Currently, the flush happens every time at the end of ram_save_iterate(), > which usually happens around

Re: [PATCH 1/8] hw/loongarch: Add default bios startup support

2022-06-20 Thread chen huacai
Hi, Xiaojuan, On Mon, Jun 20, 2022 at 4:21 PM Xiaojuan Yang wrote: > > Signed-off-by: Xiaojuan Yang > --- > hw/loongarch/fw_cfg.c | 33 +++ > hw/loongarch/fw_cfg.h | 15 +++ > hw/loongarch/loongson3.c| 81 - >

[RFC PATCH v3 03/11] qapi: net: introduce a way to bypass qemu_opts_parse_noisily()

2022-06-20 Thread Laurent Vivier
As qemu_opts_parse_noisily() flattens the QAPI structures ("type" field of Netdev structure can collides with "type" field of SocketAddress), we introduce a way to bypass qemu_opts_parse_noisily() and use directly visit_type_Netdev() to parse the backend parameters. More details from Markus:

RE: [RFC PATCH 01/12] configure: Add iovisor/ubpf project as a submodule for QEMU

2022-06-20 Thread Zhang, Chen
> -Original Message- > From: Thomas Huth > Sent: Monday, June 20, 2022 5:44 PM > To: Zhang, Chen ; Daniel P. Berrangé > > Cc: Jason Wang ; qemu-dev de...@nongnu.org>; Paolo Bonzini ; Eduardo > Habkost ; Eric Blake ; Markus > Armbruster ; Peter Maydell > ; Laurent Vivier ; Yuri >

[RFC PATCH v3 11/11] net: stream: move to QIO

2022-06-20 Thread Laurent Vivier
Use QIOChannel, QIOChannelSocket and QIONetListener. Signed-off-by: Laurent Vivier --- net/stream.c | 475 ++- 1 file changed, 165 insertions(+), 310 deletions(-) diff --git a/net/stream.c b/net/stream.c index dca50508ed84..d976fc37b60b 100644

[PATCH v2 10/21] migration: convert savevm to use QIOChannelBlock for VMState

2022-06-20 Thread Daniel P . Berrangé
With this change, all QEMUFile usage is backed by QIOChannel at last. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé --- migration/savevm.c | 42 -- 1 file changed, 4 insertions(+), 38 deletions(-) diff --git a/migration/savevm.c

Re: [RFC v2] Adding block layer APIs resembling Linux ZoneBlockDevice ioctls.

2022-06-20 Thread Stefan Hajnoczi
On Mon, Jun 20, 2022 at 07:11:40PM +0900, Damien Le Moal wrote: > On 6/20/22 16:55, Stefan Hajnoczi wrote: > > On Mon, Jun 20, 2022 at 11:36:11AM +0800, Sam Li wrote: > >> +uint32_t nr_zones; > > > > Should this really be limited to 32-bit? For example, take 256 MB zones, > > then the max

Re: [RFC PATCH v2 3/8] qapi: net: add stream and dgram netdevs

2022-06-20 Thread Markus Armbruster
Laurent Vivier writes: > On 15/06/2022 13:46, Markus Armbruster wrote: >> Laurent Vivier writes: >> >>> On 13/05/2022 13:44, Markus Armbruster wrote: Laurent Vivier writes: > Copied from socket netdev file and modified to use SocketAddress > to be able to introduce new

[PATCH qemu v6 05/10] target/riscv: rvv: Add mask agnostic for vector integer comparison instructions

2022-06-20 Thread ~eopxd
From: Yueh-Ting (eop) Chen Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li --- target/riscv/insn_trans/trans_rvv.c.inc | 1 + target/riscv/vector_helper.c| 10 ++ 2 files changed, 11 insertions(+) diff --git

Re: [PATCH 2/9] error-report: misc comment fix

2022-06-20 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > --- > util/error-report.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/util/error-report.c b/util/error-report.c > index 5edb2e604061..98f242b75bbf 100644 > ---

Re: [PATCH v2 3/9] ppc/pnv: use dev->parent_bus->parent to get the PHB

2022-06-20 Thread Mark Cave-Ayland
On 18/06/2022 12:01, Daniel Henrique Barboza wrote: It is not advisable to execute an object_dynamic_cast() to poke into bus->qbus.parent and follow it up with a C cast into the PnvPHB type we think we got. A better way is to access the PnvPHB object via a QOM macro accessing the existing

Re: [RFC PATCH 08/12] qapi: Add FilterUbpfProperties and qemu-options

2022-06-20 Thread Markus Armbruster
Zhang Chen writes: > Add filter-ubpf related QOM and qemu-options. > > Signed-off-by: Zhang Chen > --- > qapi/qom.json | 18 ++ > qemu-options.hx | 6 ++ > 2 files changed, 24 insertions(+) > > diff --git a/qapi/qom.json b/qapi/qom.json > index 6a653c6636..820a5218e8

Re: [RFC v2] Adding block layer APIs resembling Linux ZoneBlockDevice ioctls.

2022-06-20 Thread Stefan Hajnoczi
On Mon, Jun 20, 2022 at 11:36:11AM +0800, Sam Li wrote: Hi Sam, Is this version 2 of "[RFC v1] Add support for zoned device"? Please keep the email subject line the same (except for "v2", "v3", etc) so that it's clear which patch series this new version replaces. > Fix some mistakes before. It

[PATCH qemu] spapr/ddw: Reset DMA when the last non-default window is removed

2022-06-20 Thread Alexey Kardashevskiy
PAPR+/LoPAPR says: === The platform must restore the default DMA window for the PE on a call to the ibm,remove-pe-dma-window RTAS call when all of the following are true: a. The call removes the last DMA window remaining for the PE. b. The DMA window being removed is not the default window ===

[PATCH v18 01/13] linux-user: Add LoongArch generic header files

2022-06-20 Thread Song Gao
This includes: - sockbits.h - target_errno_defs.h - target_fcntl.h - termbits.h - target_resource.h - target_structs.h Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: WANG Xuerui ---

[PATCH v18 04/13] linux-user: Add LoongArch syscall support

2022-06-20 Thread Song Gao
Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- linux-user/loongarch64/syscall_nr.h | 312 linux-user/loongarch64/target_syscall.h | 48 linux-user/syscall_defs.h | 6

[PATCH v18 08/13] target/loongarch: Fix missing update CSR_BADV

2022-06-20 Thread Song Gao
loongarch_cpu_do_interrupt() should update CSR_BADV for some EXCCODE. Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson --- target/loongarch/cpu.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/target/loongarch/cpu.c

Re: [PATCH 5/8] hw/loongarch: Add fdt support

2022-06-20 Thread chen huacai
Hi, Xiaojuan, On Mon, Jun 20, 2022 at 4:11 PM Xiaojuan Yang wrote: > > Signed-off-by: Xiaojuan Yang > --- > hw/loongarch/loongson3.c| 136 +++- > include/hw/loongarch/virt.h | 4 ++ > target/loongarch/cpu.c | 1 + > target/loongarch/cpu.h | 3

Re: [RFC v2] Adding block layer APIs resembling Linux ZoneBlockDevice ioctls.

2022-06-20 Thread Damien Le Moal
On 6/20/22 16:55, Stefan Hajnoczi wrote: > On Mon, Jun 20, 2022 at 11:36:11AM +0800, Sam Li wrote: > > Hi Sam, > Is this version 2 of "[RFC v1] Add support for zoned device"? Please > keep the email subject line the same (except for "v2", "v3", etc) so > that it's clear which patch series this

Re: [PATCH 45/50] lasips2: use qdev gpio for output IRQ

2022-06-20 Thread Peter Maydell
On Sat, 11 Jun 2022 at 16:44, Mark Cave-Ayland wrote: > > On 10/06/2022 08:17, Mark Cave-Ayland wrote: > > > On 09/06/2022 12:18, Peter Maydell wrote: > >> If you find yourself #defining names for IRQ lines then this is > >> probably a sign you should be using named GPIO lines :-) > > > > Yeah

[RFC PATCH v3 10/11] qemu-sockets: introduce socket_uri()

2022-06-20 Thread Laurent Vivier
Format a string URI from a SocketAddress. Original code from hmp-cmds.c:SocketAddress_to_str() Replace 'tcp:' by 'inet:' (because 'inet' can be also 'udp'). Replace 'tcp:' by 'vsock:' with vsock socket type. Signed-off-by: Laurent Vivier --- include/qemu/sockets.h | 2 +- monitor/hmp-cmds.c

[RFC PATCH v3 09/11] net: dgram: add unix socket

2022-06-20 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Stefano Brivio --- net/dgram.c | 65 ++--- 1 file changed, 62 insertions(+), 3 deletions(-) diff --git a/net/dgram.c b/net/dgram.c index c0cf0410792e..9f20bdbc163c 100644 --- a/net/dgram.c +++

Re: New "IndustryStandard" fw_cfg?

2022-06-20 Thread Gerd Hoffmann
Hi, > Ovmf can interpret the existence of an opt/ovmf/unaccepted_memory file > I think "false" can mean either accept all memory or "do what you need > to" and negotiate if the memory map boot service can create unaccepted > memory entries. Whichever appears supported. > Then "true" can be "do

[PATCH v2 21/21] migration: remove the QEMUFileOps abstraction

2022-06-20 Thread Daniel P . Berrangé
Now that all QEMUFile callbacks are removed, the entire concept can be deleted. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé --- migration/channel.c | 4 +-- migration/colo.c | 5 ++-- migration/meson.build | 1 - migration/migration.c

[PATCH v2 07/21] migration: rename qemu_update_position to qemu_file_credit_transfer

2022-06-20 Thread Daniel P . Berrangé
The qemu_update_position method name gives the misleading impression that it is changing the current file offset. Most of the files are just streams, however, so there's no concept of a file offset in the general case. What this method is actually used for is to report on the number of bytes that

[PATCH v2 20/21] migration: remove the QEMUFileOps 'get_return_path' callback

2022-06-20 Thread Daniel P . Berrangé
This directly implements the get_return_path logic using QIOChannel APIs. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé --- migration/qemu-file-channel.c | 16 migration/qemu-file.c | 22 ++ migration/qemu-file.h | 6

[PATCH v2 08/21] migration: rename qemu_file_update_transfer to qemu_file_acct_rate_limit

2022-06-20 Thread Daniel P . Berrangé
The qemu_file_update_transfer name doesn't give a clear guide on what its purpose is, and how it differs from the qemu_file_credit_transfer method. The latter is specifically for accumulating for total migration traffic, while the former is specifically for accounting in thue rate limit

[PATCH qemu v6 08/10] target/riscv: rvv: Add mask agnostic for vector mask instructions

2022-06-20 Thread ~eopxd
From: Yueh-Ting (eop) Chen Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li --- target/riscv/insn_trans/trans_rvv.c.inc | 3 +++ target/riscv/vector_helper.c| 11 +++ 2 files changed, 14 insertions(+) diff --git

Re: [RFC PATCH 01/12] configure: Add iovisor/ubpf project as a submodule for QEMU

2022-06-20 Thread Daniel P . Berrangé
On Mon, Jun 20, 2022 at 05:59:06AM +, Zhang, Chen wrote: > > > > -Original Message- > > From: Daniel P. Berrangé > > Sent: Friday, June 17, 2022 4:05 PM > > To: Zhang, Chen > > Cc: Jason Wang ; qemu-dev > de...@nongnu.org>; Paolo Bonzini ; Eduardo > > Habkost ; Eric Blake ; Markus

Re: [RFC PATCH 01/12] configure: Add iovisor/ubpf project as a submodule for QEMU

2022-06-20 Thread Thomas Huth
On 20/06/2022 10.11, Daniel P. Berrangé wrote: On Mon, Jun 20, 2022 at 05:59:06AM +, Zhang, Chen wrote: -Original Message- From: Daniel P. Berrangé Sent: Friday, June 17, 2022 4:05 PM To: Zhang, Chen Cc: Jason Wang ; qemu-dev ; Paolo Bonzini ; Eduardo Habkost ; Eric Blake ;

Re: [PATCH v4 2/4] QIOChannelSocket: Fix zero-copy send so socket flush works

2022-06-20 Thread Juan Quintela
Leonardo Bras wrote: > Somewhere between v6 and v7 the of the zero-copy-send patchset a crucial > part of the flushing mechanism got missing: incrementing zero_copy_queued. > > Without that, the flushing interface becomes a no-op, and there is no > guarantee the buffer is really sent. > > This

RE: [RFC PATCH 01/12] configure: Add iovisor/ubpf project as a submodule for QEMU

2022-06-20 Thread Zhang, Chen
> -Original Message- > From: Thomas Huth > Sent: Monday, June 20, 2022 4:47 PM > To: Daniel P. Berrangé ; Zhang, Chen > > Cc: Jason Wang ; qemu-dev de...@nongnu.org>; Paolo Bonzini ; Eduardo > Habkost ; Eric Blake ; Markus > Armbruster ; Peter Maydell > ; Laurent Vivier ; Yuri >

RE: [RFC PATCH 12/12] test/qtest: Add ubpf basic test case

2022-06-20 Thread Zhang, Chen
> -Original Message- > From: Thomas Huth > Sent: Friday, June 17, 2022 5:34 PM > To: Zhang, Chen ; Jason Wang > ; qemu-dev ; Paolo > Bonzini ; Daniel P. Berrangé > ; Eduardo Habkost ; Eric > Blake ; Markus Armbruster > Cc: Peter Maydell ; Laurent Vivier > ; Yuri Benditovich ; > Andrew

[PATCH v18 12/13] default-configs: Add loongarch linux-user support

2022-06-20 Thread Song Gao
This patch adds loongarch64 linux-user default configs file. Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson Reviewed-by: WANG Xuerui --- configs/targets/loongarch64-linux-user.mak | 3 +++ 1 file changed, 3 insertions(+) create mode 100644

[RFC PATCH v3 05/11] net: stream: Don't ignore EINVAL on netdev socket connection

2022-06-20 Thread Laurent Vivier
From: Stefano Brivio Other errors are treated as failure by net_stream_client_init(), but if connect() returns EINVAL, we'll fail silently. Remove the related exception. Signed-off-by: Stefano Brivio [lvivier: applied to net/stream.c] Signed-off-by: Laurent Vivier Reviewed-by: Daniel P.

[RFC PATCH v3 02/11] net: remove the @errp argument of net_client_inits()

2022-06-20 Thread Laurent Vivier
The only caller passes _fatal, so use this directly in the function. It's what we do for -blockdev, -device, and -object. Signed-off-by: Laurent Vivier --- include/net/net.h | 2 +- net/net.c | 20 +++- softmmu/vl.c | 2 +- 3 files changed, 9 insertions(+), 15

Re: Building tools on unsupported cpu/arch

2022-06-20 Thread Thomas Huth
On 30/04/2022 16.11, Michael Tokarev wrote: Hello! Previously, it was possible to build qemu tools (such as qemu-img, or qemu-ga) on an unsupported cpu/architecture.  In a hackish way, by specifying --enable-tcg-interpreter on the ./configure line. Today (with 7.0), it does not work anymore,

[PATCH v2 04/21] migration: rename rate limiting fields in QEMUFile

2022-06-20 Thread Daniel P . Berrangé
This renames the following QEMUFile fields * bytes_xfer -> rate_limit_used * xfer_limit -> rate_limit_max The intent is to make it clear that 'bytes_xfer' is specifically related to rate limiting of data and applies to data queued, which need not have been transferred on the wire yet if a

[PATCH v2 12/21] migration: hardcode assumption that QEMUFile is backed with QIOChannel

2022-06-20 Thread Daniel P . Berrangé
The only callers of qemu_fopen_ops pass 'true' for the 'has_ioc' parameter, so hardcode this assumption in QEMUFile, by passing in the QIOChannel object as a non-opaque parameter. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé --- migration/qemu-file-channel.c | 4 ++--

[PATCH v2 17/21] migration: remove the QEMUFileOps 'close' callback

2022-06-20 Thread Daniel P . Berrangé
This directly implements the close logic using QIOChannel APIs. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé --- migration/qemu-file-channel.c | 12 migration/qemu-file.c | 12 ++-- migration/qemu-file.h | 10 -- 3 files

[PATCH] new snapshot/restore mechanism for fuzzing

2022-06-20 Thread Richard Liu
- create a document outlining specifications for a virtual device to manage snapshot/restore mechanism for fuzzing Signed-off-by: Richard Liu --- docs/devel/snapshot.rst | 26 ++ 1 file changed, 26 insertions(+) create mode 100644 docs/devel/snapshot.rst diff --git

Re: [PATCH v5 2/5] i386/pc: create pci-host qdev prior to pc_memory_init()

2022-06-20 Thread Mark Cave-Ayland
On 16/06/2022 14:21, Reviewed-by: Igor Mammedov wrote: On Fri, 20 May 2022 11:45:29 +0100 Joao Martins wrote: At the start of pc_memory_init() we usually pass a range of 0..UINT64_MAX as pci_memory, when really its 2G (i440fx) or 32G (q35). To get the real user value, we need to get pci-host

Re: [PATCH v2 2/2] ui/gtk: a new array param monitor to specify the target displays

2022-06-20 Thread Markus Armbruster
Dongwon Kim writes: > New integer array parameter, 'monitor' is for specifying the target > displays where individual QEMU windows are placed upon launching. > > The array contains a series of numbers representing the monitor where > QEMU windows are placed. > > Numbers in the array are mapped

[PATCH 5/8] hw/loongarch: Add fdt support

2022-06-20 Thread Xiaojuan Yang
Signed-off-by: Xiaojuan Yang --- hw/loongarch/loongson3.c| 136 +++- include/hw/loongarch/virt.h | 4 ++ target/loongarch/cpu.c | 1 + target/loongarch/cpu.h | 3 + 4 files changed, 141 insertions(+), 3 deletions(-) diff --git

[PATCH v18 02/13] linux-user: Add LoongArch signal support

2022-06-20 Thread Song Gao
Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang --- linux-user/loongarch64/signal.c| 342 + linux-user/loongarch64/target_signal.h | 13 + 2 files changed, 355 insertions(+) create mode 100644 linux-user/loongarch64/signal.c create mode 100644

RE: [RFC PATCH 08/12] qapi: Add FilterUbpfProperties and qemu-options

2022-06-20 Thread Zhang, Chen
> -Original Message- > From: Markus Armbruster > Sent: Monday, June 20, 2022 3:45 PM > To: Zhang, Chen > Cc: Jason Wang ; qemu-dev de...@nongnu.org>; Paolo Bonzini ; Daniel > P.Berrangé ; Eduardo Habkost > ; Eric Blake ; Peter Maydell > ; Thomas Huth ; Laurent > Vivier ; Yuri

[RFC PATCH v3 04/11] qapi: net: add stream and dgram netdevs

2022-06-20 Thread Laurent Vivier
Copied from socket netdev file and modified to use SocketAddress to be able to introduce new features like unix socket. "udp" and "mcast" are squashed into dgram netdev, multicast is detected according to the IP address type. "listen" and "connect" modes are managed by stream netdev. An optional

[RFC PATCH v3 08/11] net: dgram: move mcast specific code from net_socket_fd_init_dgram()

2022-06-20 Thread Laurent Vivier
It is less complex to manage special cases directly in net_dgram_mcast_init() and net_dgram_udp_init(). Signed-off-by: Laurent Vivier Reviewed-by: Stefano Brivio --- net/dgram.c | 143 +++- 1 file changed, 73 insertions(+), 70 deletions(-) diff

Re: [RFC PATCH 01/12] configure: Add iovisor/ubpf project as a submodule for QEMU

2022-06-20 Thread Daniel P . Berrangé
On Mon, Jun 20, 2022 at 10:29:14AM +, Zhang, Chen wrote: > > > > -Original Message- > > From: Thomas Huth > > Sent: Monday, June 20, 2022 5:44 PM > > To: Zhang, Chen ; Daniel P. Berrangé > > > > Cc: Jason Wang ; qemu-dev > de...@nongnu.org>; Paolo Bonzini ; Eduardo > > Habkost ;

Re: proposed 7.1 release schedule

2022-06-20 Thread Peter Maydell
On Mon, 23 May 2022 at 16:08, Richard Henderson wrote: > > On 5/23/22 02:53, Peter Maydell wrote: > > I just put some proposed dates into the 7.1 schedule page: > > https://wiki.qemu.org/Planning/7.1#Release_Schedule > > > > * 2022-07-12 Softfreeze > > * 2022-07-19 Hardfreeze. Tag rc0 > > *

Re: Building tools on unsupported cpu/arch

2022-06-20 Thread Michael Tokarev
20.06.2022 13:31, Thomas Huth write: On 30/04/2022 16.11, Michael Tokarev wrote: Hello! Previously, it was possible to build qemu tools (such as qemu-img, or qemu-ga) on an unsupported cpu/architecture.  In a hackish way, by specifying --enable-tcg-interpreter on the ./configure line. Today

[PATCH v2 06/21] migration: rename qemu_ftell to qemu_file_total_transferred

2022-06-20 Thread Daniel P . Berrangé
The name 'ftell' gives the misleading impression that the QEMUFile objects are seekable. This is not the case, as in general we just have an opaque stream. The users of this method are only interested in the total bytes processed. This switches to a new name that reflects the intended usage.

  1   2   3   4   >