Issues related to the polling system on Windows

2022-08-23 Thread Clément Chigot
Hi all, I've been struggling with a bug which seems to be linked to several issues in the polling system on Windows hosts. When connecting gdb to a qemu-system (it happens with all the emulations I've tried), I've discovered that sometimes a latency appears. It happens with all the commands but

Re: [PATCH 4/4] hw/nvme: add MSI-x mask handlers for irqfd

2022-08-23 Thread Jinhao Fan
On 8/16/2022 6:46 PM, Klaus Jensen wrote: Did qtest work out for you for testing? If so, it would be nice to add a simple test case as well. Since MSI-x masking handlers are only implemented for IO queues, if we want to use qtest we need to implement utilities for controller initialization

Re: [PATCH v5 2/9] parallels: Fix data_end field value in parallels_co_check()

2022-08-23 Thread Alexander Ivanov
On 23.08.2022 09:38, Vladimir Sementsov-Ogievskiy wrote: On 8/22/22 12:05, Alexander Ivanov wrote: Make data_end pointing to the end of the last cluster if a leak was fixed. Otherwise set the file size to data_end. Signed-off-by: Alexander Ivanov ---   block/parallels.c | 10 +-   1

Re: [PATCH v5 1/9] parallels: Out of image offset in BAT leads to image inflation

2022-08-23 Thread Vladimir Sementsov-Ogievskiy
On 8/23/22 12:34, Denis V. Lunev wrote: On 23.08.2022 08:58, Vladimir Sementsov-Ogievskiy wrote: On 8/22/22 12:05, Alexander Ivanov wrote: data_end field in BDRVParallelsState is set to the biggest offset present in BAT. If this offset is outside of the image, any further write will create the

Re: [PATCH v5 1/9] parallels: Out of image offset in BAT leads to image inflation

2022-08-23 Thread Denis V. Lunev
On 23.08.2022 11:47, Vladimir Sementsov-Ogievskiy wrote: On 8/23/22 12:34, Denis V. Lunev wrote: On 23.08.2022 08:58, Vladimir Sementsov-Ogievskiy wrote: On 8/22/22 12:05, Alexander Ivanov wrote: data_end field in BDRVParallelsState is set to the biggest offset present in BAT. If this offset

Re: [PATCH 4/4] hw/nvme: add MSI-x mask handlers for irqfd

2022-08-23 Thread Klaus Jensen
On Aug 11 23:37, Jinhao Fan wrote: > When irqfd is enabled, we bypass QEMU's irq emulation and let KVM to > directly assert the irq. However, KVM is not aware of the device's MSI-x > masking status. Add MSI-x mask bookkeeping in NVMe emulation and > detach the corresponding irqfd when the certain

Re: [PATCH 7/7] vdpa: Use ring hwaddr at vhost_vdpa_svq_unmap_ring

2022-08-23 Thread Eugenio Perez Martin
On Tue, Aug 23, 2022 at 8:40 AM Jason Wang wrote: > > > 在 2022/8/20 00:53, Eugenio Pérez 写道: > > Reduce code duplication. > > > > Signed-off-by: Eugenio Pérez > > > Acked-by: Jason Wang > > (In the future, we need to look for other cases where a function may use > only a partial of DMAMap.) >

[PULL 1/1] scsi-generic: Fix emulated block limits VPD page

2022-08-23 Thread Kevin Wolf
Commits 01ef8185b80 amd 24b36e9813e updated the way that the maximum transfer length is calculated for patching block limits VPD page in an INQUIRY response. The same updates also need to be made for the case where the host device does not support the block limits VPD page at all and we emulate

[PULL 2/6] tests/qtest/migration-test: Only wait for serial output where migration succeeds

2022-08-23 Thread Alex Bennée
From: Thomas Huth Waiting for the serial output can take a couple of seconds - and since we're doing a lot of migration tests, this time easily sums up to multiple minutes. But if a test is supposed to fail, it does not make much sense to wait for the source to be in the right state first, so we

Re: [PATCH] gdbstub: only send stop-reply upon request

2022-08-23 Thread Peter Maydell
On Tue, 23 Aug 2022 at 16:07, Matheus Tavares Bernardino wrote: > > The GDB remote serial protocol[1] specifies that the communication > between GDB and the stub is driven by GDB: > > The host (GDB) sends commands, and the target (the debugging > stub incorporated in your program) sends a

Re: [PATCH v8 02/12] s390x/cpu_topology: CPU topology objects and structures

2022-08-23 Thread Pierre Morel
On 8/23/22 15:30, Thomas Huth wrote: On 20/06/2022 16.03, Pierre Morel wrote: We use new objects to have a dynamic administration of the CPU topology. The highest level object in this implementation is the s390 book and in this first implementation of CPU topology for S390 we have a single

Re: [PATCH] hw/nvme: Abort copy command when format is one while pif is zero

2022-08-23 Thread Klaus Jensen
On Aug 25 22:53, Francis Pravin Antony Michael Raj wrote: > As per the NVMe command set specification section-3.2.2, > If: > i) The namespace is formatted to use 16b Guard Protection Information > (i.e., pif = 0) and > ii) The Descriptor Format is not cleared to 0h > Then the copy command

Re: [qemu-web PATCH] Add signing pubkey for python-qemu-qmp package

2022-08-23 Thread John Snow
On Tue, Aug 23, 2022, 5:16 AM Andrea Bolognani wrote: > On Thu, Aug 18, 2022 at 12:53:58PM -0400, John Snow wrote: > > Add the pubkey currently used for signing PyPI releases of qemu.qmp to a > > stable location where it can be referenced by e.g. Fedora RPM specfiles. > > > > At present, the key

Re: [PATCH v5 1/3] Update linux headers to 6.0-rc1

2022-08-23 Thread Daniel P . Berrangé
On Mon, Aug 22, 2022 at 05:00:03PM +0200, Michal Prívozník wrote: > On 8/17/22 04:08, Chenyi Qiang wrote: > > commit 568035b01cfb107af8d2e4bd2fb9aea22cf5b868 > > > > Signed-off-by: Chenyi Qiang > > --- > > include/standard-headers/asm-x86/bootparam.h | 7 +- > >

[PULL 5/6] tests/qtest/migration-test: Remove duplicated test_postcopy from the test plan

2022-08-23 Thread Alex Bennée
From: Thomas Huth test_postcopy() is currently run twice - which is just a waste of resources and time. The commit d1a27b169b2d that introduced the duplicate talked about renaming the "postcopy/unix" test, but apparently it forgot to remove the old entry. Let's do that now. Fixes: d1a27b169b

[PULL 4/6] tests/migration/i386: Speed up the i386 migration test (when using TCG)

2022-08-23 Thread Alex Bennée
From: Thomas Huth When KVM is not available, the i386 migration test also runs in a rather slow fashion, since the guest code takes a couple of seconds to print the "B"s on the serial console, and the migration test has to wait for this each time. Let's increase the frequency here, too, so that

[PATCH 0/2] target/arm: armv7m_load_kernel() improvements

2022-08-23 Thread Peter Maydell
Two small patches to armv7m_load_kernel(). The first is just getting rid of some dead code, that I noticed while working on the function. The second is to make boards pass armv7m_load_kernel() the base address for loading guest (non-ELF) binaries. At the moment we assume all M-profile boards

Re: [PATCH v7 00/14] KVM: mm: fd-based approach for supporting KVM guest private memory

2022-08-23 Thread Sean Christopherson
On Tue, Aug 23, 2022, David Hildenbrand wrote: > On 19.08.22 05:38, Hugh Dickins wrote: > > On Fri, 19 Aug 2022, Sean Christopherson wrote: > >> On Thu, Aug 18, 2022, Kirill A . Shutemov wrote: > >>> On Wed, Aug 17, 2022 at 10:40:12PM -0700, Hugh Dickins wrote: > On Wed, 6 Jul 2022, Chao Peng

Re: [PATCH 03/14] accel/tcg: Suppress auto-invalidate in probe_access_internal

2022-08-23 Thread Richard Henderson
On 8/23/22 08:19, Richard Henderson wrote: On 8/23/22 02:19, David Hildenbrand wrote: 1) s390_probe_access() documents to "With nonfault=1, return the PGM_ exception that would have been injected into the guest; return 0 if no exception was detected." But in case of CONFIG_USER_ONLY, we return

Re: Teensy 4.1 Implementation

2022-08-23 Thread Peter Maydell
On Tue, 23 Aug 2022 at 15:00, Shiny Saana wrote: > From experimentation and dissasembly on the ROM, (located in 0x0020_), > the very first int (converted to BE) is "0x2020_1000" , which is located to > "OCRAM2", also referred as "ROM RAM" by the documentation, and the next int > is

[PULL 6/6] qemu-options: try and clarify preferred block semantics

2022-08-23 Thread Alex Bennée
Try to correct any confusion about QEMU's Byzantine disk options by laying out the preferred "modern" options as-per: " (best: -device + -blockdev, 2nd obsolete syntax: -device + -drive, 3rd obsolete syntax: -drive, 4th obsolete syntax: -hdNN)" Signed-off-by: Alex Bennée Acked-by:

KVM call for agenda for 2022-09-06

2022-08-23 Thread Juan Quintela
Hi First of all, I am adding Please, send any topic that you are interested in covering. At the end of Monday I will send an email with the agenda or the cancellation of the call, so hurry up. After discussions on the QEMU Summit, we are going to have always open a KVM call where you can

[PATCH 1/2] target/arm: Remove useless TARGET_BIG_ENDIAN check in armv7m_load_kernel()

2022-08-23 Thread Peter Maydell
Arm system emulation targets always have TARGET_BIG_ENDIAN clear, so there is no need to have handling in armv7m_load_kernel() for the case when it is defined. Remove the unnecessary code. Side notes: * our M-profile implementation is always little-endian (that is, it makes the IMPDEF choice

Re: Teensy 4.1 Implementation

2022-08-23 Thread Shiny Saana
> Your board code should be setting the init-nsvtor property on > the armv7m object to 0x0020, if it isn't already. I'm going to add that property right away! > Yes, this would be in line with the way we use -kernel on other > M-profile board models. Got it! Thank you for correcting my

[PATCH 2/2] target/arm: Make boards pass base address to armv7m_load_kernel()

2022-08-23 Thread Peter Maydell
Currently armv7m_load_kernel() takes the size of the block of memory where it should load the initial guest image, but assumes that it should always load it at address 0. This happens to be true of all our M-profile boards at the moment, but it isn't guaranteed to always be so: M-profile CPUs can

Re: [PATCH v3 1/1] os-posix: asynchronous teardown for shutdown on Linux

2022-08-23 Thread Daniel P . Berrangé
On Fri, Aug 12, 2022 at 09:26:23AM +0200, Claudio Imbrenda wrote: > On Thu, 11 Aug 2022 23:05:52 -0300 > Murilo Opsfelder Araújo wrote: > > > On 8/11/22 11:02, Daniel P. Berrangé wrote: > > [...] > > >>> Hmm, I was hoping you could just use SIGKILL to guarantee that this > > >>> gets killed off.

[PATCH] docs/devel/testing: fix minor typo

2022-08-23 Thread Matheus Tavares Bernardino
Signed-off-by: Matheus Tavares Bernardino --- docs/devel/testing.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst index 3f6ebd5073..f35f117d95 100644 --- a/docs/devel/testing.rst +++ b/docs/devel/testing.rst @@ -297,7 +297,7

Re: [PATCH 03/14] accel/tcg: Suppress auto-invalidate in probe_access_internal

2022-08-23 Thread Richard Henderson
On 8/23/22 02:19, David Hildenbrand wrote: 1) s390_probe_access() documents to "With nonfault=1, return the PGM_ exception that would have been injected into the guest; return 0 if no exception was detected." But in case of CONFIG_USER_ONLY, we return the flags returned by s390_probe_access(),

Re: [PATCH v5 18/18] s390x: pv: Add dump support

2022-08-23 Thread Steffen Eiden
On 8/11/22 14:11, Janosch Frank wrote: Sometimes dumping a guest from the outside is the only way to get the data that is needed. This can be the case if a dumping mechanism like KDUMP hasn't been configured or data needs to be fetched at a specific point. Dumping a protected guest from the

[PULL 1/6] tests/avocado: push default timeout to QemuBaseTest

2022-08-23 Thread Alex Bennée
All of the QEMU tests eventually end up derrived from this class. Move the default timeout from LinuxTest to ensure we catch them all. As 15 minutes is fairly excessive we drop the default down to 2 minutes which is a more reasonable target for tests to aim for. Signed-off-by: Alex Bennée

[PULL 3/6] tests/migration/aarch64: Speed up the aarch64 migration test

2022-08-23 Thread Alex Bennée
From: Thomas Huth The migration tests spend a lot of time waiting for a sign of live of the guest on the serial console. The aarch64 migration code only outputs "B"s every couple of seconds (at least it takes more than 4 seconds between each characeter on my x86 laptop). There are a lot of

Re: [PATCH v5 1/9] parallels: Out of image offset in BAT leads to image inflation

2022-08-23 Thread Vladimir Sementsov-Ogievskiy
On 8/23/22 16:50, Alexander Ivanov wrote: On 23.08.2022 11:58, Vladimir Sementsov-Ogievskiy wrote: On 8/23/22 12:20, Denis V. Lunev wrote: On 23.08.2022 09:23, Alexander Ivanov wrote: On 23.08.2022 08:58, Vladimir Sementsov-Ogievskiy wrote: On 8/22/22 12:05, Alexander Ivanov wrote:

Re: [PATCH 1/2] block: pass OnOffAuto instead of bool to block_acct_setup()

2022-08-23 Thread Vladimir Sementsov-Ogievskiy
On 8/23/22 12:57, Denis V. Lunev wrote: We would have one more place for block_acct_setup() calling, which should not corrupt original value. Signed-off-by: Denis V. Lunev CC: Peter Krempa CC: Markus Armbruster CC: John Snow CC: Kevin Wolf CC: Hanna Reitz CC: Vladimir Sementsov-Ogievskiy

[PULL 0/1] Block layer patches

2022-08-23 Thread Kevin Wolf
The following changes since commit ba58ccbef60338d0b7334c714589a6423a3e7f91: Merge tag 'for-7.1-hppa' of https://github.com/hdeller/qemu-hppa into staging (2022-08-19 09:35:29 -0700) are available in the Git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you to fetch

[PATCH] gdbstub: only send stop-reply upon request

2022-08-23 Thread Matheus Tavares Bernardino
The GDB remote serial protocol[1] specifies that the communication between GDB and the stub is driven by GDB: The host (GDB) sends commands, and the target (the debugging stub incorporated in your program) sends a response. This is further emphasized by Embecosm's "Howto: GDB Remote

Re: [PATCH v5 17/18] s390x: Add KVM PV dump interface

2022-08-23 Thread Steffen Eiden
On 8/11/22 14:11, Janosch Frank wrote: Let's add a few bits of code which hide the new KVM PV dump API from us via new functions. Signed-off-by: Janosch Frank --- hw/s390x/pv.c | 51 +++ include/hw/s390x/pv.h | 8 +++ 2 files changed,

[PULL for 7.1 0/6] testing and doc updates

2022-08-23 Thread Alex Bennée
The following changes since commit ba58ccbef60338d0b7334c714589a6423a3e7f91: Merge tag 'for-7.1-hppa' of https://github.com/hdeller/qemu-hppa into staging (2022-08-19 09:35:29 -0700) are available in the Git repository at: https://github.com/stsquad/qemu.git

Re: [PATCH] gdbstub: only send stop-reply upon request

2022-08-23 Thread Matheus Tavares Bernardino
On Thu, Aug 32, 2022 at 1:39 PM Matheus Tavares Bernardino wrote: > > --- > gdbstub.c | 22 +- > 1 file changed, 21 insertions(+), 1 deletion(-) Please ignore this patch. This version is broken, I'm working on a new one. Sorry for the noise.

Re: [PATCH v8 08/12] s390x/cpu_topology: implementing numa for the s390x topology

2022-08-23 Thread Pierre Morel
On 7/22/22 14:08, Janis Schoetterl-Glausch wrote: On 7/21/22 13:41, Pierre Morel wrote: On 7/21/22 10:16, Janis Schoetterl-Glausch wrote: On 7/21/22 09:58, Pierre Morel wrote: ...snip... You are right, numa is redundant for us as we specify the topology using the core-id. The

Re: [PATCH 2/2] block: add missed block_acct_setup with new block device init procedure

2022-08-23 Thread Vladimir Sementsov-Ogievskiy
On 8/23/22 12:57, Denis V. Lunev wrote: Commit 5f76a7aac156ca75680dad5df4a385fd0b58f6b1 is looking harmless from the first glance, but it has changed things a lot. 'libvirt' uses it to detect that it should follow new initialization way and this changes things considerably. With this procedure

Re: [PATCH v5 1/9] parallels: Out of image offset in BAT leads to image inflation

2022-08-23 Thread Denis V. Lunev
On 23.08.2022 09:23, Alexander Ivanov wrote: On 23.08.2022 08:58, Vladimir Sementsov-Ogievskiy wrote: On 8/22/22 12:05, Alexander Ivanov wrote: data_end field in BDRVParallelsState is set to the biggest offset present in BAT. If this offset is outside of the image, any further write will

Re: [PATCH 1/1] hw/i2c/aspeed: Fix old reg slave receive

2022-08-23 Thread Klaus Jensen
On Aug 20 15:57, Peter Delevoryas wrote: > I think when Klaus ported his slave mode changes from the original patch > series to the rewritten I2C module, he changed the behavior of the first > byte that is received by the slave device. > > What's supposed to happen is that the AspeedI2CBus's

Re: [PATCH v5 1/9] parallels: Out of image offset in BAT leads to image inflation

2022-08-23 Thread Denis V. Lunev
On 23.08.2022 08:58, Vladimir Sementsov-Ogievskiy wrote: On 8/22/22 12:05, Alexander Ivanov wrote: data_end field in BDRVParallelsState is set to the biggest offset present in BAT. If this offset is outside of the image, any further write will create the cluster at this offset and/or the

Re: [PATCH 1/1] MAINTAINERS: add tree to keep parallels format driver changes

2022-08-23 Thread Denis V. Lunev
On 23.08.2022 11:42, Vladimir Sementsov-Ogievskiy wrote: On 8/23/22 11:40, Denis V. Lunev wrote: Parallels driver changes are driving by me for now. At least we need to get functionally complete check and repair procedure for now. This would be a good educational task for new people from

Re: [PATCH v5 1/9] parallels: Out of image offset in BAT leads to image inflation

2022-08-23 Thread Denis V. Lunev
On 22.08.2022 11:05, Alexander Ivanov wrote: data_end field in BDRVParallelsState is set to the biggest offset present in BAT. If this offset is outside of the image, any further write will create the cluster at this offset and/or the image will be truncated to this offset on close. This is

Re: [PATCH v7 4/8] block: add block layer APIs resembling Linux ZonedBlockDevice ioctls

2022-08-23 Thread Stefan Hajnoczi
On Tue, Aug 23, 2022 at 12:12:44PM +0800, Sam Li wrote: > Stefan Hajnoczi 于2022年8月23日周二 08:49写道: > > On Tue, Aug 16, 2022 at 02:25:18PM +0800, Sam Li wrote: > > > +static int handle_aiocb_zone_report(void *opaque) { > > > +#if defined(CONFIG_BLKZONED) > > > +RawPosixAIOData *aiocb = opaque; >

Re: [PATCH for-7.1?] scsi-generic: Fix emulated block limits VPD page

2022-08-23 Thread Stefan Hajnoczi
On Mon, 22 Aug 2022 at 08:54, Kevin Wolf wrote: > > Commits 01ef8185b80 amd 24b36e9813e updated the way that the maximum > transfer length is calculated for patching block limits VPD page in an > INQUIRY response. > > The same updates also need to be made for the case where the host device > does

Re: [PATCH 1/1] MAINTAINERS: add tree to keep parallels format driver changes

2022-08-23 Thread Vladimir Sementsov-Ogievskiy
On 8/23/22 11:40, Denis V. Lunev wrote: Parallels driver changes are driving by me for now. At least we need to get functionally complete check and repair procedure for now. This would be a good educational task for new people from Virtuozzo. Signed-off-by: Denis V. Lunev CC: Vladimir

Re: [PATCH v5 1/9] parallels: Out of image offset in BAT leads to image inflation

2022-08-23 Thread Vladimir Sementsov-Ogievskiy
On 8/23/22 10:59, Vladimir Sementsov-Ogievskiy wrote: On 8/23/22 10:23, Alexander Ivanov wrote: On 23.08.2022 08:58, Vladimir Sementsov-Ogievskiy wrote: On 8/22/22 12:05, Alexander Ivanov wrote: data_end field in BDRVParallelsState is set to the biggest offset present in BAT. If this offset

Re: [PATCH v5 1/9] parallels: Out of image offset in BAT leads to image inflation

2022-08-23 Thread Denis V. Lunev
On 23.08.2022 11:58, Vladimir Sementsov-Ogievskiy wrote: On 8/23/22 12:20, Denis V. Lunev wrote: On 23.08.2022 09:23, Alexander Ivanov wrote: On 23.08.2022 08:58, Vladimir Sementsov-Ogievskiy wrote: On 8/22/22 12:05, Alexander Ivanov wrote: data_end field in BDRVParallelsState is set to the

Re: [PATCH v7 6/8] config: add check to block layer

2022-08-23 Thread Stefan Hajnoczi
On Tue, Aug 23, 2022 at 12:25:23PM +0800, Sam Li wrote: > Stefan Hajnoczi 于2022年8月23日周二 08:54写道: > > > > On Tue, Aug 16, 2022 at 02:25:20PM +0800, Sam Li wrote: > > > Putting zoned/non-zoned BlockDrivers on top of each other is not > > > allowed. > > > > > > Signed-off-by: Sam Li > > >

Re: [PATCH] target/s390x: Fix CLFIT and CLGIT immediate size

2022-08-23 Thread David Hildenbrand
On 17.08.22 18:15, Ilya Leoshkevich wrote: > I2 is 16 bits, not 32. > > Found by running valgrind's none/tests/s390x/traps. > > Fixes: 1c2687518235 ("target-s390: Implement COMPARE AND TRAP") > Signed-off-by: Ilya Leoshkevich > --- > target/s390x/tcg/insn-data.def | 4 ++-- > 1 file changed, 2

Re: [PATCH v5 4/9] parallels: Use generic infrastructure for BAT writing in parallels_co_check()

2022-08-23 Thread Denis V. Lunev
On 22.08.2022 11:05, Alexander Ivanov wrote: BAT is written in the context of conventional operations over the image inside bdrv_co_flush() when it calls parallels_co_flush_to_os() callback. Thus we should not modify BAT array directly, but call parallels_set_bat_entry() helper and

[PATCH v4 0/2] block: add missed block_acct_setup with new block device init procedure

2022-08-23 Thread Denis V. Lunev
Commit 5f76a7aac156ca75680dad5df4a385fd0b58f6b1 is looking harmless from the first glance, but it has changed things a lot. 'libvirt' uses it to detect that it should follow new initialization way and this changes things considerably. With this procedure followed, blockdev_init() is not called

[PATCH 2/2] block: add missed block_acct_setup with new block device init procedure

2022-08-23 Thread Denis V. Lunev
Commit 5f76a7aac156ca75680dad5df4a385fd0b58f6b1 is looking harmless from the first glance, but it has changed things a lot. 'libvirt' uses it to detect that it should follow new initialization way and this changes things considerably. With this procedure followed, blockdev_init() is not called

Re: [PATCH v2] s390x/cpumodel: add stfl197 processor-activity-instrumentation extension 1

2022-08-23 Thread Thomas Huth
On 27/07/2022 15.51, Christian Borntraeger wrote: Add stfle 197 (processor-activity-instrumentation extension 1) to the gen16 default model and fence it off for 7.1 and older. Signed-off-by: Christian Borntraeger Reviewed-by: David Hildenbrand --- v1->v2: - this is on top of "hw: Add compat

Re: [PATCH v8 02/12] s390x/cpu_topology: CPU topology objects and structures

2022-08-23 Thread Thomas Huth
On 20/06/2022 16.03, Pierre Morel wrote: We use new objects to have a dynamic administration of the CPU topology. The highest level object in this implementation is the s390 book and in this first implementation of CPU topology for S390 we have a single book. The book is built as a SYSBUS bridge

Re: Teensy 4.1 Implementation

2022-08-23 Thread Shiny Saana
Thank you again for your time! I didn't know at all about the generic loader!! It feels to me that it will definitely be very useful in loading the Teensy image. (To give more background: the Teensy-Arduinon toolchain first compiles an .elf and then convert that to an Intex hex file. We can

Re: [PATCH for-7.2 v2 10/20] hw/ppc: set machine->fdt in spapr machine

2022-08-23 Thread Alexey Kardashevskiy
On 22/08/2022 20:30, Daniel Henrique Barboza wrote: On 8/22/22 00:29, Alexey Kardashevskiy wrote: On 22/08/2022 13:05, David Gibson wrote: On Fri, Aug 19, 2022 at 06:42:34AM -0300, Daniel Henrique Barboza wrote: On 8/18/22 23:11, Alexey Kardashevskiy wrote: On 05/08/2022 19:39,

Re: [PATCH v2] ci: Upgrade msys2 release to 20220603

2022-08-23 Thread Thomas Huth
On 22/08/2022 16.39, 罗勇刚(Yonggang Luo) wrote: After digging, it seems to be a memory issue, cirrus also uses 8gb, that's rather weird... If it's a memory issue, it might help to remove the "-j2" from the invocation of "make", so that only one file is compiled at once...? Thomas

Re: [PATCH v5 2/9] parallels: Fix data_end field value in parallels_co_check()

2022-08-23 Thread Denis V. Lunev
On 22.08.2022 11:05, Alexander Ivanov wrote: Make data_end pointing to the end of the last cluster if a leak was fixed. Otherwise set the file size to data_end. Signed-off-by: Alexander Ivanov --- block/parallels.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git

Re: [PATCH v5 7/9] parallels: Move check of leaks to a separate function

2022-08-23 Thread Denis V. Lunev
On 22.08.2022 11:05, Alexander Ivanov wrote: We will add more and more checks so we need a better code structure in parallels_co_check. Let each check performs in a separate loop in a separate helper. Signed-off-by: Alexander Ivanov --- block/parallels.c | 87

Re: [PATCH v5 1/9] parallels: Out of image offset in BAT leads to image inflation

2022-08-23 Thread Vladimir Sementsov-Ogievskiy
On 8/23/22 12:20, Denis V. Lunev wrote: On 23.08.2022 09:23, Alexander Ivanov wrote: On 23.08.2022 08:58, Vladimir Sementsov-Ogievskiy wrote: On 8/22/22 12:05, Alexander Ivanov wrote: data_end field in BDRVParallelsState is set to the biggest offset present in BAT. If this offset is outside

[PATCH 1/2] block: pass OnOffAuto instead of bool to block_acct_setup()

2022-08-23 Thread Denis V. Lunev
We would have one more place for block_acct_setup() calling, which should not corrupt original value. Signed-off-by: Denis V. Lunev CC: Peter Krempa CC: Markus Armbruster CC: John Snow CC: Kevin Wolf CC: Hanna Reitz CC: Vladimir Sementsov-Ogievskiy --- block/accounting.c | 22

Re: [PATCH for-7.2 v2 2/2] ppc/pnv: fix QOM parenting of user creatable root ports

2022-08-23 Thread Frederic Barrat
On 19/08/2022 11:47, Daniel Henrique Barboza wrote: User creatable root ports are being parented by the 'peripheral' or the 'peripheral-anon' container. This happens because this is the regular QOM schema for sysbus devices that are added via the command line. Let's make this QOM hierarchy

Re: [PATCH v7 06/12] multifd: Make flags field thread local

2022-08-23 Thread Juan Quintela
Leonardo Bras Soares Passos wrote: > On Fri, Aug 19, 2022 at 7:03 AM Juan Quintela wrote: >> >> Leonardo Brás wrote: >> > On Tue, 2022-08-02 at 08:39 +0200, Juan Quintela wrote: >> >> Use of flags with respect to locking was incensistant. For the >> >> sending side: >> >> - it was set to 0

Re: [PATCH 03/14] accel/tcg: Suppress auto-invalidate in probe_access_internal

2022-08-23 Thread David Hildenbrand
On 23.08.22 01:57, Richard Henderson wrote: > When PAGE_WRITE_INV is set when calling tlb_set_page, > we immediately set TLB_INVALID_MASK in order to force > tlb_fill to be called on the next lookup. Here in > probe_access_internal, we have just called tlb_fill > and eliminated true misses, thus

Re: [PATCH 3/7] util: make a copy of iova_tree_remove_parameter

2022-08-23 Thread Eugenio Perez Martin
On Tue, Aug 23, 2022 at 8:18 AM Jason Wang wrote: > > > 在 2022/8/20 00:53, Eugenio Pérez 写道: > > It's convenient to call iova_tree_remove from a map returned from > > iova_tree_find or iova_tree_find_iova. > > > The looks like a hint of the defect of current API. > > > > With the current code

Re: [PATCH v5 7/9] parallels: Move check of leaks to a separate function

2022-08-23 Thread Alexander Ivanov
On 23.08.2022 11:40, Denis V. Lunev wrote: On 22.08.2022 11:05, Alexander Ivanov wrote: We will add more and more checks so we need a better code structure in parallels_co_check. Let each check performs in a separate loop in a separate helper. Signed-off-by: Alexander Ivanov ---  

Re: [PATCH v5 1/9] parallels: Out of image offset in BAT leads to image inflation

2022-08-23 Thread Alexander Ivanov
On 23.08.2022 11:58, Vladimir Sementsov-Ogievskiy wrote: On 8/23/22 12:20, Denis V. Lunev wrote: On 23.08.2022 09:23, Alexander Ivanov wrote: On 23.08.2022 08:58, Vladimir Sementsov-Ogievskiy wrote: On 8/22/22 12:05, Alexander Ivanov wrote: data_end field in BDRVParallelsState is set to

[PATCH 1/1] MAINTAINERS: add tree to keep parallels format driver changes

2022-08-23 Thread Denis V. Lunev
Parallels driver changes are driving by me for now. At least we need to get functionally complete check and repair procedure for now. This would be a good educational task for new people from Virtuozzo. Signed-off-by: Denis V. Lunev CC: Vladimir Sementsov-Ogievskiy CC: Stefan Hajnoczi ---

Re: [PATCH v5 1/9] parallels: Out of image offset in BAT leads to image inflation

2022-08-23 Thread Alexander Ivanov
On 23.08.2022 11:20, Denis V. Lunev wrote: On 23.08.2022 09:23, Alexander Ivanov wrote: On 23.08.2022 08:58, Vladimir Sementsov-Ogievskiy wrote: On 8/22/22 12:05, Alexander Ivanov wrote: data_end field in BDRVParallelsState is set to the biggest offset present in BAT. If this offset is

Re: [PATCH v5 1/3] Update linux headers to 6.0-rc1

2022-08-23 Thread Chenyi Qiang
On 8/22/2022 11:00 PM, Michal Prívozník wrote: On 8/17/22 04:08, Chenyi Qiang wrote: commit 568035b01cfb107af8d2e4bd2fb9aea22cf5b868 Signed-off-by: Chenyi Qiang --- include/standard-headers/asm-x86/bootparam.h | 7 +- include/standard-headers/drm/drm_fourcc.h | 73 +++-

Re: [PATCH for-7.2 v2 1/2] ppc/pnv: consolidate pnv_parent_*_fixup() helpers

2022-08-23 Thread Frederic Barrat
On 19/08/2022 11:47, Daniel Henrique Barboza wrote: We have 2 helpers that amends the QOM and parent bus of a given object, repectively. These 2 helpers are called together, and not by accident. Due to QOM internals, doing an object_unparent() will result in the device being removed from its

Re: [PATCH 2/4] hw/nvme: add option to (de)assert irq with eventfd

2022-08-23 Thread Klaus Jensen
On Aug 11 23:37, Jinhao Fan wrote: > When the new option 'irq-eventfd' is turned on, the IO emulation code > signals an eventfd when it want to (de)assert an irq. The main loop > eventfd handler does the actual irq (de)assertion. This paves the way > for iothread support since QEMU's interrupt

Re: [RFC v4 00/11] blkio: add libblkio BlockDriver

2022-08-23 Thread Vladimir Sementsov-Ogievskiy
On 8/23/22 01:23, Stefan Hajnoczi wrote: The remainder of the patch series reworks the existing QEMU bdrv_register_buf() API so virtio-blk emulation efficiently map guest RAM for libblkio - some libblkio drivers require that I/O buffer memory is pre-registered (think VFIO, vhost, etc). Hi! So

[PATCH v2 1/7] vdpa: Skip the maps not in the iova tree

2022-08-23 Thread Eugenio Pérez
Next patch will skip the registering of dma maps that the vdpa device rejects in the iova tree. We need to consider that here or we cause a SIGSEGV accessing result. Reported-by: Lei Yang Signed-off-by: Eugenio Pérez Acked-by: Jason Wang --- hw/virtio/vhost-vdpa.c | 4 1 file changed, 4

[PATCH v2 4/7] vdpa: Remove SVQ vring from iova_tree at shutdown

2022-08-23 Thread Eugenio Pérez
Although the device will be reset before usage, the right thing to do is to clean it. Reported-by: Lei Yang Fixes: 34e3c94eda ("vdpa: Add custom IOTLB translations to SVQ") Signed-off-by: Eugenio Pérez --- v2: * Call vhost_iova_tree_remove with the map as value. * report_error on

[PATCH v2 7/7] vdpa: Use ring hwaddr at vhost_vdpa_svq_unmap_ring

2022-08-23 Thread Eugenio Pérez
Reduce code duplication. Signed-off-by: Eugenio Pérez Acked-by: Jason Wang --- hw/virtio/vhost-vdpa.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c index e208dd000e..23ae5ef48b 100644 ---

[PATCH v10 06/12] vhost_net: Add NetClientInfo stop callback

2022-08-23 Thread Eugenio Pérez
Used by the backend to perform actions after the device is stopped. In particular, vdpa net use it to unmap CVQ buffers to the device, cleaning the actions performed in prepare(). Signed-off-by: Eugenio Pérez Acked-by: Jason Wang --- v9: Replace performend by performed in patch message ---

[PATCH v10 04/12] vhost: Do not depend on !NULL VirtQueueElement on vhost_svq_flush

2022-08-23 Thread Eugenio Pérez
Since QEMU will be able to inject new elements on CVQ to restore the state, we need not to depend on a VirtQueueElement to know if a new element has been used by the device or not. Instead of check that, check if there are new elements only using used idx on vhost_svq_flush. Signed-off-by:

[PATCH 2/2] target/s390x: Align __excp_addr in s390_probe_access

2022-08-23 Thread Richard Henderson
Per the comment in s390_cpu_record_sigsegv, the saved address is always page aligned. Signed-off-by: Richard Henderson --- target/s390x/tcg/mem_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/s390x/tcg/mem_helper.c b/target/s390x/tcg/mem_helper.c index

[PATCH 1/2] Revert "target/s390x: Use probe_access_flags in s390_probe_access"

2022-08-23 Thread Richard Henderson
This reverts commit db9aab5783a2fb62250e12f0c4cfed5e1778c189. This patch breaks the contract of s390_probe_access, in that it no longer returns an exception code, nor set __excp_addr. Reported-by: David Hildenbrand Signed-off-by: Richard Henderson --- target/s390x/tcg/mem_helper.c | 18

Re: [PATCH 0/2] target/arm: armv7m_load_kernel() improvements

2022-08-23 Thread Richard Henderson
On 8/23/22 09:04, Peter Maydell wrote: Two small patches to armv7m_load_kernel(). The first is just getting rid of some dead code, that I noticed while working on the function. The second is to make boards pass armv7m_load_kernel() the base address for loading guest (non-ELF) binaries. At the

Re: [PATCH v4 1/1] os-posix: asynchronous teardown for shutdown on Linux

2022-08-23 Thread Daniel P . Berrangé
On Fri, Aug 12, 2022 at 03:34:53PM +0200, Claudio Imbrenda wrote: > This patch adds support for asynchronously tearing down a VM on Linux. > > When qemu terminates, either naturally or because of a fatal signal, > the VM is torn down. If the VM is huge, it can take a considerable > amount of time

[PATCH v2 5/7] vdpa: Make SVQ vring unmapping return void

2022-08-23 Thread Eugenio Pérez
Nothing actually reads the return value, but an error in cleaning some entries could cause device stop to abort, making a restart impossible. Better ignore explicitely the return value. Reported-by: Lei Yang Fixes: 34e3c94eda ("vdpa: Add custom IOTLB translations to SVQ") Signed-off-by: Eugenio

[PATCH v2 0/7] vDPA shadow virtqueue iova tree fixes.

2022-08-23 Thread Eugenio Pérez
Collection of iova tree fixes detected preparing live migration with real devices and multiqueue. These cannot be triggered in simple setups (vdpa_sim_net, no display, no device reset with different features) but it's possible to trigger them with real devices or if the kernel fails some step

[PATCH v2 2/7] vdpa: do not save failed dma maps in SVQ iova tree

2022-08-23 Thread Eugenio Pérez
If a map fails for whatever reason, it must not be saved in the tree. Otherwise, qemu will try to unmap it in cleanup, leaving to more errors. Fixes: 34e3c94eda ("vdpa: Add custom IOTLB translations to SVQ") Reported-by: Lei Yang Signed-off-by: Eugenio Pérez Acked-by: Jason Wang ---

Re: [PATCH 8/9] hw/isa/vt82c686: QOM'ify RTC creation

2022-08-23 Thread Bernhard Beschow
On Tue, Aug 23, 2022 at 2:20 AM BALATON Zoltan wrote: > On Tue, 23 Aug 2022, Bernhard Beschow wrote: > > Signed-off-by: Bernhard Beschow > > --- > > hw/isa/vt82c686.c | 12 +++- > > 1 file changed, 11 insertions(+), 1 deletion(-) > > > > diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c

Re: [PATCH] audio: exit(1) if audio backend failed to be found or initialized

2022-08-23 Thread Volker Rümelin
From: Marc-André Lureau If you specify a known backend but it isn't compiled in, or failed to initialize, you get a simple warning and the "none" backend as a fallback, and QEMU runs happily: $ qemu-system-x86_64 -audiodev id=audio,driver=dsound audio: Unknown audio driver `dsound' audio:

Re: [PATCH v13 3/6] target/riscv: Add few cache related PMU events

2022-08-23 Thread Alistair Francis
On Wed, Aug 24, 2022 at 5:19 AM Atish Kumar Patra wrote: > > > > On Mon, Aug 22, 2022 at 5:38 PM Alistair Francis wrote: >> >> On Wed, Aug 17, 2022 at 9:24 AM Atish Patra wrote: >> > >> > From: Atish Patra >> > >> > Qemu can monitor the following cache related PMU events through >> > tlb_fill

Re: [PATCH v9 1/3] hw/intc: Move mtimer/mtimecmp to aclint

2022-08-23 Thread Alistair Francis
On Thu, Aug 11, 2022 at 4:57 AM Atish Patra wrote: > > Historically, The mtime/mtimecmp has been part of the CPU because > they are per hart entities. However, they actually belong to aclint > which is a MMIO device. > > Move them to the ACLINT device. This also emulates the real hardware > more

Re: [PATCH 1/2] target/arm: Remove useless TARGET_BIG_ENDIAN check in armv7m_load_kernel()

2022-08-23 Thread Richard Henderson
On 8/23/22 09:04, Peter Maydell wrote: Arm system emulation targets always have TARGET_BIG_ENDIAN clear, so there is no need to have handling in armv7m_load_kernel() for the case when it is defined. Remove the unnecessary code. Side notes: * our M-profile implementation is always

[PATCH 0/2] target/s390x: s390_probe_access fixes

2022-08-23 Thread Richard Henderson
First, as pointed out by David; second by inspection. I really wish there were a better way to structure this, but alas, I don't see any alternatives that aren't just different but similar amounts of ugly. r~ Richard Henderson (2): Revert "target/s390x: Use probe_access_flags in

[PATCH v2 3/7] util: accept iova_tree_remove_parameter by value

2022-08-23 Thread Eugenio Pérez
It's convenient to call iova_tree_remove from a map returned from iova_tree_find or iova_tree_find_iova. With the current code this is not possible, since we will free it, and then we will try to search for it again. Fix it making accepting the map by value, forcing a copy of the argument. Not

[PATCH v10 02/12] vhost: use SVQ element ndescs instead of opaque data for desc validation

2022-08-23 Thread Eugenio Pérez
Since we're going to allow SVQ to add elements without the guest's knowledge and without its own VirtQueueElement, it's easier to check if an element is a valid head checking a different thing than the VirtQueueElement. Signed-off-by: Eugenio Pérez Acked-by: Jason Wang ---

[PATCH v10 09/12] vdpa: extract vhost_vdpa_net_cvq_add from vhost_vdpa_net_handle_ctrl_avail

2022-08-23 Thread Eugenio Pérez
So we can reuse it to inject state messages. Signed-off-by: Eugenio Pérez Acked-by: Jason Wang -- v7: * Remove double free error v6: * Do not assume in buffer sent to the device is sizeof(virtio_net_ctrl_ack) v5: * Do not use an artificial !NULL VirtQueueElement * Use only out size instead of

Re: [PATCH 7/9] hw/isa/vt82c686: QOM'ify ac97 and mc97 creation

2022-08-23 Thread Bernhard Beschow
On Tue, Aug 23, 2022 at 2:44 AM BALATON Zoltan wrote: > On Tue, 23 Aug 2022, Bernhard Beschow wrote: > > Resolves duplicate code in the boards. > > > > Signed-off-by: Bernhard Beschow > > --- > > hw/isa/vt82c686.c | 16 > > hw/mips/fuloong2e.c | 4 > > hw/ppc/pegasos2.c

Re: [PATCH v13 3/6] target/riscv: Add few cache related PMU events

2022-08-23 Thread Atish Kumar Patra
On Mon, Aug 22, 2022 at 5:38 PM Alistair Francis wrote: > On Wed, Aug 17, 2022 at 9:24 AM Atish Patra wrote: > > > > From: Atish Patra > > > > Qemu can monitor the following cache related PMU events through > > tlb_fill functions. > > > > 1. DTLB load/store miss > > 3. ITLB prefetch miss > > >

Re: [RFC v4 11/11] virtio-blk: use BDRV_REQ_REGISTERED_BUF optimization hint

2022-08-23 Thread Stefan Hajnoczi
On Tue, Aug 23, 2022 at 10:01:59AM +0200, David Hildenbrand wrote: > On 23.08.22 00:24, Stefan Hajnoczi wrote: > > Register guest RAM using BlockRAMRegistrar and set the > > BDRV_REQ_REGISTERED_BUF flag so block drivers can optimize memory > > accesses in I/O requests. > > > > This is for

  1   2   3   >