Il sab 27 ago 2022, 01:46 Richard Henderson
ha scritto:
> +#define PACK_WIDTH (4 << SHIFT)
>
> Incorrect for AVX, it was correct with the ifdef in v1.
> Perhaps just (SHIFT ? 8 : 4)?
>
That's intentional, the AVX patches change it to an #ifndef that AVX
overrides. For now the purpose of the
Add an option "iothread=x" to do emulation in a seperate iothread.
This improves the performance because QEMU's main loop is responsible
for a lot of other work while iothread is dedicated to NVMe emulation.
Moreover, emulating in iothread brings the potential of polling on
SQ/CQ doorbells, which
The Tulip NIC can be used to trigger an endless recursion when its
descriptors are set up to its own MMIO address space. Fix it by
limiting the DMA accesses to normal memory.
Fixes: CVE-2022-2962
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1171
Signed-off-by: Thomas Huth
---
Resending this patch now that 7.1 is released (well done).
> On 4 Aug 2022, at 2:27 pm, Elliot Nunn wrote:
>
> Implement dpy_cursor_define() and dpy_mouse_set() on macOS.
>
> The main benefit is from dpy_cursor_define: in absolute pointing mode, the
> host can redraw the cursor on the guest's
On 15/08/2022 09.26, Milica Lazarevic wrote:
The return type of typedef disassembly_function is changed to
const char * instead of std::string. Therefore, for every particular
disassembly_function function signature is changed.
For example:
- static std::string ABS_D(uint64 instruction) {...} is
On 15/08/2022 09.26, Milica Lazarevic wrote:
The free() function is called for every string allocated using the
strdup() function to prevent memory leaking.
The implementation of the several functions working with dynamically
allocated strings is slightly changed so we can free those strings.
On 15/08/2022 09.26, Milica Lazarevic wrote:
Change enums to typedef enums to keep naming clear
Signed-off-by: Milica Lazarevic
---
disas/nanomips.cpp | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/disas/nanomips.cpp b/disas/nanomips.cpp
index
Use KVM's irqfd to send interrupts when possible. This approach is
thread safe. Moreover, it does not have the inter-thread communication
overhead of plain event notifiers since handler callback are called
in the same system call as irqfd write.
Signed-off-by: Jinhao Fan
Signed-off-by: Klaus
When the new option 'irq-eventfd' is turned on, the IO emulation code
signals an eventfd when it want to (de)assert an irq. The main loop
eventfd handler does the actual irq (de)assertion. This paves the way
for iothread support since QEMU's interrupt emulation is not thread
safe.
Asserting and
On 15/08/2022 09.26, Milica Lazarevic wrote:
Renamed the following functions by adding a suffix:
- copy to copy_ui and copy_i
- IMMEDIATE to IMMEDIATE_UI and IMMEDIATE_I
Calls to copy and IMMEDIATE functions are replaced based on the type of
arguments.
Disassemble function that calls the other
On 15/08/2022 09.26, Milica Lazarevic wrote:
Since there's no support for exception handling in C, the try-catch
blocks have been deleted, and throw clauses are replaced. When a runtime
error happens, we're printing out the error message. Disassembling of
the current instruction interrupts. This
On 15/08/2022 09.26, Milica Lazarevic wrote:
Changed the type of the table parameter in Disassemble function:
- from const Pool *
- to const struct Pool *
Signed-off-by: Milica Lazarevic
---
disas/nanomips.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Add AioContext polling handlers for NVMe SQ and CQ. By employing polling,
the latency of NVMe IO emulation is greatly reduced. The SQ polling
handler checks for updates on the SQ tail shadow doorbell buffer. The CQ
polling handler is an empty function because we procatively polls the CQ
head
The KVM_DIRTY_GFN_F_DIRTY flag ensures that the entry is valid. If
the read of the fields are not ordered after the read of the flag,
QEMU might see stale values.
Cc: Peter Xu
Cc: Gavin Shan
Signed-off-by: Paolo Bonzini
---
accel/kvm/kvm-all.c | 6 +-
1 file changed, 5 insertions(+), 1
On 15/08/2022 09.26, Milica Lazarevic wrote:
Modifier static has been added to the remaining functions that shouldn't
be used outside of the nanomips disassembler.
Signed-off-by: Milica Lazarevic
---
disas/nanomips.cpp | 8
1 file changed, 4 insertions(+), 4 deletions(-)
On 15/08/2022 09.26, Milica Lazarevic wrote:
Replaced argument passing by reference with passing by address.
Signed-off-by: Milica Lazarevic
---
disas/nanomips.cpp | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/disas/nanomips.cpp b/disas/nanomips.cpp
index
On 15/08/2022 09.26, Milica Lazarevic wrote:
Now that everything has been converted to C code the nanomips.cpp file
has been renamed. Therefore, meson.build file is also changed.
Signed-off-by: Milica Lazarevic
---
disas/meson.build | 2 +-
disas/{nanomips.cpp =>
at 11:34 PM, Keith Busch wrote:
> On Fri, Aug 26, 2022 at 11:12:04PM +0800, Jinhao Fan wrote:
>> Use KVM's irqfd to send interrupts when possible. This approach is
>> thread safe. Moreover, it does not have the inter-thread communication
>> overhead of plain event notifiers since handler
This series of performance enhancements brings iothread and polling
capabilities to qemu-nvme. The first two patches implements support
for irqfd, which solves thread safety problems for interrupt emulation
outside the main loop thread. The third patch adds support for
emulating NVMe IO queues in
Thomas Huth writes:
> On 26/08/2022 19.21, Alex Bennée wrote:
>> Update to the latest stable Debian. While we are at it flatten into a
>> single dockerfile as we do not need anything from the base image to
>> build the toolchain. This is used to build both the nios and
>> microblaze
From: Alex Bennée
The previous calculation fell over when I tried to create a 8gb Pi 4
because the values were only 32 bit. However the quirk of the Pi
hardware is the vcram can only appear in the first 1gb of address
space. This also limits where the initial kernel and DTB can be
loaded (notice
On Fri, Aug 26, 2022 at 9:23 PM Marc-André Lureau
wrote:
>
> Hi
>
> On Fri, Aug 26, 2022 at 5:16 PM Bin Meng wrote:
>>
>> On Thu, Aug 25, 2022 at 3:59 PM Marc-André Lureau
>> wrote:
>> >
>> > Hi
>> >
>> > On Wed, Aug 24, 2022 at 1:43 PM Bin Meng wrote:
>> > >
>> > > From: Xuzhou Cheng
>> > >
Reviewed-by: Michael Rolnik
On Fri, Aug 26, 2022 at 11:55 PM Richard Henderson <
richard.hender...@linaro.org> wrote:
> We cannot deliver two interrupts simultaneously;
> the first interrupt handler must execute first.
>
> Signed-off-by: Richard Henderson
> ---
> target/avr/helper.c | 9
Hi, Alberto,
On Fri, Aug 26, 2022 at 05:09:27PM +0100, Alberto Faria wrote:
> Apply cache->xlat to addr before passing it to
> flatview_(read|write)_continue(), to convert it from the
> MemoryRegionCache's address space to the FlatView's.
Any bug encountered? It'll be great to add more
Hi, Emanuele,
On Fri, Aug 26, 2022 at 04:07:01PM +0200, Emanuele Giuseppe Esposito wrote:
>
>
> Am 22/08/2022 um 16:10 schrieb Peter Xu:
> > On Thu, Aug 18, 2022 at 09:55:20PM -0300, Leonardo Bras Soares Passos wrote:
> >> On Thu, Aug 18, 2022 at 5:05 PM Peter Xu wrote:
> >>>
> >>> On Tue, Aug
Reviewed-by: Michael Rolnik
On Fri, Aug 26, 2022 at 11:55 PM Richard Henderson <
richard.hender...@linaro.org> wrote:
> There is no need to go through cc->tcg_ops when
> we know what value that must have.
>
> Signed-off-by: Richard Henderson
> ---
> target/avr/helper.c | 5 ++---
> 1 file
Reviewed-by: Michael Rolnik
On Fri, Aug 26, 2022 at 11:55 PM Richard Henderson <
richard.hender...@linaro.org> wrote:
> This bit is not saved across interrupts, so we must
> delay delivering the interrupt until the skip has
> been processed.
>
> Resolves:
Reviewed-by: Michael Rolnik
On Fri, Aug 26, 2022 at 11:55 PM Richard Henderson <
richard.hender...@linaro.org> wrote:
> Fixes https://gitlab.com/qemu-project/qemu/-/issues/1118
>
> r~
>
> Richard Henderson (3):
> target/avr: Call avr_cpu_do_interrupt directly
> target/avr: Only execute one
On Fri, Aug 26, 2022 at 10:13:47AM -0400, Peter Xu wrote:
> On Fri, Aug 26, 2022 at 03:53:09PM +0200, Emanuele Giuseppe Esposito wrote:
> > What do you mean "will empty all regions with those listeners"?
> > But yes theoretically vhost-vdpa and physmem have commit callbacks that
> > are
29 matches
Mail list logo
