Re: [PATCH v2] block: Refactor get_tmp_filename()

2022-09-27 Thread Markus Armbruster
Bin Meng writes: > On Mon, Sep 26, 2022 at 6:13 PM Markus Armbruster wrote: >> >> Bin Meng writes: >> >> > From: Bin Meng >> > >> > At present there are two callers of get_tmp_filename() and they are >> > inconsistent. >> > >> > One does: >> > >> > /* TODO: extra byte is a hack to ensure

[PULL v2 11/22] target/riscv: Check the correct exception cause in vector GDB stub

2022-09-27 Thread Alistair Francis
From: Frank Chang After RISCVException enum is introduced, riscv_csrrw_debug() returns RISCV_EXCP_NONE to indicate there's no error. RISC-V vector GDB stub should check the result against RISCV_EXCP_NONE instead of value 0. Otherwise, 'E14' packet would be incorrectly reported for vector CSRs

[PULL v2 03/22] docs/system: clean up code escape for riscv virt platform

2022-09-27 Thread Alistair Francis
From: Alex Bennée The example code is rendered slightly mangled due to missing code block. Properly escape the code block and add shell prompt and qemu to fit in with the other examples on the page. Signed-off-by: Alex Bennée Reviewed-by: Alistair Francis Message-Id:

[PULL v2 16/22] target/riscv: debug: Restrict the range of tselect value can be written

2022-09-27 Thread Alistair Francis
From: Frank Chang The value of tselect CSR can be written should be limited within the range of supported triggers number. Signed-off-by: Frank Chang Reviewed-by: Bin Meng Signed-off-by: Bin Meng Reviewed-by: LIU Zhiwei Message-Id: <20220909134215.1843865-5-bmeng...@gmail.com>

Re: [PATCH v2] block: Refactor get_tmp_filename()

2022-09-27 Thread Markus Armbruster
Bin Meng writes: > Hi Markus, > > On Tue, Sep 27, 2022 at 2:22 PM Markus Armbruster wrote: >> >> Bin Meng writes: >> >> > On Mon, Sep 26, 2022 at 6:13 PM Markus Armbruster >> > wrote: >> >> >> >> Bin Meng writes: >> >> >> >> > From: Bin Meng >> >> > >> >> > At present there are two callers

[PATCH v2 3/4] target/loongarch: Fix fnm{sub/add}_{s/d} set wrong flags

2022-09-27 Thread Song Gao
Signed-off-by: Song Gao --- target/loongarch/insn_trans/trans_farith.c.inc | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/target/loongarch/insn_trans/trans_farith.c.inc b/target/loongarch/insn_trans/trans_farith.c.inc index 65ad2ffab8..7bb3f41aee 100644 ---

[PULL 1/8] e1000e: set RX desc status with DD flag in a separate operation

2022-09-27 Thread Jason Wang
From: Ding Hui Like commit 034d00d48581 ("e1000: set RX descriptor status in a separate operation"), there is also same issue in e1000e, which would cause lost packets or stop sending packets to VM with DPDK. Do similar fix in e1000e. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/402

[PULL 10/24] ui/console: fix three double frees in png_save()

2022-09-27 Thread Gerd Hoffmann
From: Volker Rümelin The png_destroy_write_struct() function frees all memory used by libpng. Don't use the glib auto cleanup mechanism to free the memory allocated by libpng again. For the pixman image, use only the auto cleanup mechanism and remove the qemu_pixman_image_unref() function call

[PULL 16/24] usbnet: Add missing usb_wakeup() call in usbnet_receive()

2022-09-27 Thread Gerd Hoffmann
From: Michael Brown usbnet_receive() does not currently wake up the USB endpoint, leading to a dead RX datapath when used with a host controller such as xHCI that relies on being woken up. Fix by adding a call to usb_wakeup() at the end of usbnet_receive(). Signed-off-by: Michael Brown

[PULL 06/24] ui/clipboard: fix serial priority

2022-09-27 Thread Gerd Hoffmann
From: Marc-André Lureau The incoming grab event should have a higher serial. See also "vdagent: introduce VD_AGENT_CAP_CLIPBOARD_GRAB_SERIAL": https://gitlab.freedesktop.org/spice/spice-protocol/-/commit/045a6978d6dbbf7046affc5c321fa8177c8cce56 This is only a relevant fix for the -display dbus,

Should we maybe move Cirrus-CI jobs away from Gitlab again?

2022-09-27 Thread Thomas Huth
Hi all, now that Gitlab is giving us pressure on the amount of free CI minutes, I wonder whether we should maybe move the Cirrus-CI jobs out of the gitlab-CI dashboard again? We could add the jobs to our .cirrus-ci.yml file instead, like we did it in former times... Big advantage would

[PULL 15/24] hcd-xhci: drop operation with secondary stream arrays enabled

2022-09-27 Thread Gerd Hoffmann
From: Qiang Liu The abort() in xhci_find_stream() can be triggered via enabling the secondary stream arrays by setting linear stream array (LSA) bit (in endpoint context) to 0. We may show warnings and drop this operation. Fixes: 024426acc0a2 ("usb-xhci: usb3 streams") Reported-by: Qiang Liu

Re: [PATCH v2 4/4] virtio-gpu: Don't require udmabuf when blob support is enabled

2022-09-27 Thread Gerd Hoffmann
On Mon, Sep 26, 2022 at 09:32:40PM +0300, Dmitry Osipenko wrote: > On 9/23/22 15:32, Gerd Hoffmann wrote: > > On Tue, Sep 13, 2022 at 12:50:22PM +0200, Antonio Caggiano wrote: > >> From: Dmitry Osipenko > >> > >> Host blobs don't need udmabuf, it's only needed by guest blobs. The host > >> blobs

[PULL 2/3] target/m68k: use M68K_FEATURE_MOVEFROMSR_PRIV feature for move_from_sr privilege check

2022-09-27 Thread Laurent Vivier
From: Mark Cave-Ayland Now that M68K_FEATURE_M68000 has been renamed to M68K_FEATURE_M68K it is easier to see that the privilege exception check is wrong: it is currently only generated for ColdFire CPUs when in fact it should also be generated for Motorola CPUs from the 68010 onwards.

[PULL v2 10/22] hw/riscv: opentitan: Expose the resetvec as a SoC property

2022-09-27 Thread Alistair Francis
From: Alistair Francis On the OpenTitan hardware the resetvec is fixed at the start of ROM. In QEMU we don't run the ROM code and instead just jump to the next stage. This means we need to be a little more flexible about what the resetvec is. This patch allows us to set the resetvec from the

[PULL v2 18/22] target/riscv: debug: Create common trigger actions function

2022-09-27 Thread Alistair Francis
From: Frank Chang Trigger actions are shared among all triggers. Extract to a common function. Signed-off-by: Frank Chang Reviewed-by: Bin Meng Signed-off-by: Bin Meng Reviewed-by: LIU Zhiwei [bmeng: handle the DBG_ACTION_NONE case] Signed-off-by: Bin Meng Message-Id:

[PULL v2 20/22] target/riscv: debug: Add initial support of type 6 trigger

2022-09-27 Thread Alistair Francis
From: Frank Chang Type 6 trigger is similar to a type 2 trigger, but provides additional functionality and should be used instead of type 2 in newer implementations. Signed-off-by: Frank Chang Reviewed-by: Bin Meng Signed-off-by: Bin Meng Message-Id:

[PATCH v2 0/4] Fix some loongarch tcg bugs

2022-09-27 Thread Song Gao
Hi, This series fix some bugs find from RISU test. v2: -remove patch5 div if x/0 set dividend to 0. Song Gao (4): target/loongarch: ftint_xxx insns set the result high 32bit 0x target/loongarch: bstrins.w need set dest register EXT_SIGN target/loongarch: Fix fnm{sub/add}_{s/d}

[PULL 5/8] vdpa: validate MQ CVQ commands

2022-09-27 Thread Jason Wang
From: Eugenio Pérez So we are sure we can update the device model properly before sending to the device. Signed-off-by: Eugenio Pérez Signed-off-by: Jason Wang --- net/vhost-vdpa.c | 9 + 1 file changed, 9 insertions(+) diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index

Re: [PATCH 1/3] hw/misc: sifive_e_aon: Support the watchdog timer of HiFive 1 rev b.

2022-09-27 Thread Frank Chang
Reviewed-by: Frank Chang On Thu, Sep 22, 2022 at 4:41 PM Tommy Wu wrote: > The watchdog timer is in the always-on domain device of HiFive 1 rev b, > so this patch added the AON device to the sifive_e machine. This patch > only implemented the functionality of the watchdog timer. > >

[PULL 4/8] vdpa: Add vhost_vdpa_net_load_mq

2022-09-27 Thread Jason Wang
From: Eugenio Pérez Same way as with the MAC, restore the expected number of queues at device's start. Signed-off-by: Eugenio Pérez Signed-off-by: Jason Wang --- net/vhost-vdpa.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/net/vhost-vdpa.c

[PULL 05/24] ui: add some vdagent related traces

2022-09-27 Thread Gerd Hoffmann
From: Marc-André Lureau This helps debugging clipboard serial sync issues. Signed-off-by: Marc-André Lureau Message-Id: <20220912102455.111765-2-marcandre.lur...@redhat.com> [ kraxel: code style fix ] Signed-off-by: Gerd Hoffmann --- ui/clipboard.c | 11 +-- ui/vdagent.c| 4

[PULL 11/24] hw/usb/hcd-xhci: Check whether DMA accesses fail

2022-09-27 Thread Gerd Hoffmann
From: Thomas Huth If a guest sets up bad descriptors, it could force QEMU to access non-existing memory regions. Thus we should check the return value of dma_memory_read/write() to make sure that these errors don't go unnoticed. Signed-off-by: Thomas Huth Message-Id:

Re: [RFC PATCH] ast2600: Fix CPU features

2022-09-27 Thread Cédric Le Goater
On 9/27/22 03:49, Joel Stanley wrote: On Mon, 26 Sept 2022 at 07:05, Cédric Le Goater wrote: On 9/26/22 08:26, Cédric Le Goater wrote: Currently, the CPU features exposed to the AST2600 QEMU machines are : half thumb fastmult vfp edsp neon vfpv3 tls vfpv4 idiva idivt vfpd32 lpae

Re: [PATCH v3 00/12] linux-user: Add more syscalls, enhance tracing & logging enhancements

2022-09-27 Thread Helge Deller
On 9/27/22 09:32, Laurent Vivier wrote: Le 18/09/2022 à 21:45, Helge Deller a écrit : Here is a bunch of patches for linux-user. Most of them add missing syscalls and enhance the tracing/logging. Some of the patches are target-hppa specific. I've tested those on productive hppa debian buildd

[PULL 24/24] virtio-gpu: update scanout if there is any area covered by the rect

2022-09-27 Thread Gerd Hoffmann
From: Dongwon Kim The scanout is currently updated only if the whole rect is inside the scanout space. This is not a correct condition because the scanout should be updated even a small area in the scanout space is covered by the rect. Cc: Gerd Hoffmann Signed-off-by: Dongwon Kim Reviewed-by:

[PULL 18/24] usbnet: Detect short packets as sent by the xHCI controller

2022-09-27 Thread Gerd Hoffmann
From: Michael Brown The xHCI controller will ignore the endpoint MTU and so may deliver packets of any length. Detect short packets as being any packet that has a length of zero or a length that is not a multiple of the MTU. Signed-off-by: Michael Brown Message-Id:

[PATCH 2/2] linux-user: Add parameters of getrandom() syscall for strace

2022-09-27 Thread Helge Deller
Signed-off-by: Helge Deller --- linux-user/strace.list | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/strace.list b/linux-user/strace.list index 31a2ccd76d..9bb234a584 100644 --- a/linux-user/strace.list +++ b/linux-user/strace.list @@ -358,7 +358,7 @@ {

Re: [PATCH] qemu-nbd: set timeout to qemu-nbd socket

2022-09-27 Thread luzhipeng
在 2022/9/26 20:44, Vladimir Sementsov-Ogievskiy 写道: On 9/26/22 14:34, Denis V. Lunev wrote: On 9/26/22 12:05, Vladimir Sementsov-Ogievskiy wrote: [+ Den] On 9/25/22 16:53, luzhipeng wrote: From: lu zhipeng Prevent the NBD socket stuck all the time, So set timeout. Signed-off-by: lu

[PULL v2 02/22] hw/ssi: ibex_spi: update reg addr

2022-09-27 Thread Alistair Francis
From: Wilfred Mallawa Updates the `EVENT_ENABLE` register to offset `0x34` as per OpenTitan spec [1]. [1] https://docs.opentitan.org/hw/ip/spi_host/doc/#Reg_event_enable Signed-off-by: Wilfred Mallawa Reviewed-by: Alistair Francis Message-Id:

[PULL 0/3] M68k for 7.2 patches

2022-09-27 Thread Laurent Vivier
tags/m68k-for-7.2-pull-request for you to fetch changes up to 2cfa963126fe77fac034a43f986b2bf3e8fe6a4f: m68k: align bootinfo strings and data to 4 bytes (2022-09-26 23:37:22 +0200) M68k pull request 20220927 Align bootinfo tags fix

Re: [PATCH v2 1/3] hw/watchdog: wdt_ibex_aon.c: Implement the watchdog for the OpenTitan

2022-09-27 Thread Thomas Huth
Hi Tyler! On 27/09/2022 01.03, Tyler Ng wrote: Hi Thomas, On Thu, Sep 22, 2022 at 9:17 AM Thomas Huth > wrote: On 22/09/2022 17.58, Tyler Ng wrote: > This commit adds most of an implementation of the OpenTitan Always-On > Timer. The documentation for

[PULL v2 07/22] target/riscv: remove fixed numbering from GDB xml feature files

2022-09-27 Thread Alistair Francis
From: Andrew Burgess The fixed register numbering in the various GDB feature files for RISC-V only exists because these files were originally copied from the GDB source tree. However, the fixed numbering only exists in the GDB source tree so that GDB, when it connects to a target that doesn't

[PULL v2 17/22] target/riscv: debug: Introduce tinfo CSR

2022-09-27 Thread Alistair Francis
From: Frank Chang tinfo.info: One bit for each possible type enumerated in tdata1. If the bit is set, then that type is supported by the currently selected trigger. Signed-off-by: Frank Chang Reviewed-by: Bin Meng Signed-off-by: Bin Meng Reviewed-by: LIU Zhiwei Message-Id:

[PULL v2 08/22] target/riscv: Set the CPU resetvec directly

2022-09-27 Thread Alistair Francis
From: Alistair Francis Instead of using our properties to set a config value which then might be used to set the resetvec (depending on your timing), let's instead just set the resetvec directly in the env struct. This allows us to set the reset vec from the command line with: -global

[PULL v2 12/22] hw/riscv/sifive_e: Fix inheritance of SiFiveEState

2022-09-27 Thread Alistair Francis
From: Bernhard Beschow SiFiveEState inherits from SysBusDevice while it's TypeInfo claims it to inherit from TYPE_MACHINE. This is an inconsistency which can cause undefined behavior such as memory corruption. Change SiFiveEState to inherit from MachineState since it is registered as a machine.

[PULL 3/8] vdpa: extract vhost_vdpa_net_load_mac from vhost_vdpa_net_load

2022-09-27 Thread Jason Wang
From: Eugenio Pérez Since there may be many commands we need to issue to load the NIC state, let's split them in individual functions Signed-off-by: Eugenio Pérez Signed-off-by: Jason Wang --- net/vhost-vdpa.c | 62 1 file changed, 40

[PULL 8/8] virtio: del net client if net_init_tap_one failed

2022-09-27 Thread Jason Wang
From: lu zhipeng If the net tap initializes successful, but failed during network card hot-plugging, the net-tap will remains, so cleanup. Signed-off-by: lu zhipeng Signed-off-by: Jason Wang --- net/tap.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git

Re: [PATCH v6 3/5] module: add Error arguments to module_load and module_load_qom

2022-09-27 Thread Markus Armbruster
Claudio Fontana writes: > On 9/26/22 12:38, Kevin Wolf wrote: >> Am 24.09.2022 um 01:21 hat Claudio Fontana geschrieben: >>> improve error handling during module load, by changing: >>> >>> bool module_load(const char *prefix, const char *lib_name); >>> void module_load_qom(const char *type); >>>

[PULL 03/24] Revert "main-loop: Disable block backend global state assertion on Cocoa"

2022-09-27 Thread Gerd Hoffmann
From: Akihiko Odaki This reverts commit 47281859f66bdab1974fb122cab2cbb4a1c9af7f. Signed-off-by: Akihiko Odaki Reviewed-by: Emanuele Giuseppe Esposito Reviewed-by: Peter Maydell Reviewed-by: Paolo Bonzini Message-Id: <20220819132756.74641-3-akihiko.od...@gmail.com> Signed-off-by: Gerd

[PULL 22/24] audio: remove abort() in audio_bug()

2022-09-27 Thread Gerd Hoffmann
From: Volker Rümelin Commit ab32b78cd1 "audio: Simplify audio_bug() removing old code" introduced abort() in audio_bug() for regular builds. audio_bug() was never meant to abort QEMU for the following reasons. - There's code in audio_bug() that expects audio_bug() gets called more than

[PULL 21/24] Revert "audio: Log context for audio bug"

2022-09-27 Thread Gerd Hoffmann
From: Volker Rümelin This reverts commit 8e30d39bade3010387177ca23dbc2244352ed4a3. Revert commit 8e30d39bad "audio: Log context for audio bug" to make error propagation work again. Signed-off-by: Volker Rümelin Message-Id: <20220917131626.7521-1-vr_q...@t-online.de> Signed-off-by: Gerd

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-09-27 Thread Ani Sinha
On Sun, Sep 18, 2022 at 1:58 AM Michael S. Tsirkin wrote: > > On Fri, Sep 16, 2022 at 09:30:42PM +0530, Ani Sinha wrote: > > On Thu, Jul 28, 2022 at 12:08 AM Ani Sinha wrote: > > > > > > > > > > > > On Mon, 25 Jul 2022, Ani Sinha wrote: > > > > > > > > > > > > > > > On Sat, 16 Jul 2022, Michael

Re: [PATCH v2 1/2] linux-user: Introduce stubs for ELF AT_BASE_PLATFORM

2022-09-27 Thread Laurent Vivier
Le 03/08/2022 à 12:30, Jiaxun Yang a écrit : AT_BASE_PLATFORM is a elf auxiliary vector pointing to a string to pass some architecture information. See getauxval(3) man-page. Signed-off-by: Jiaxun Yang Reviewed-by: Philippe Mathieu-Daudé --- linux-user/elfload.c | 29

Re: [PATCH v6 3/5] module: add Error arguments to module_load and module_load_qom

2022-09-27 Thread Claudio Fontana
On 9/27/22 09:54, Markus Armbruster wrote: > Claudio Fontana writes: > >> On 9/26/22 12:38, Kevin Wolf wrote: >>> Am 24.09.2022 um 01:21 hat Claudio Fontana geschrieben: improve error handling during module load, by changing: bool module_load(const char *prefix, const char

Re: [PATCH] linux-user: Don't assume 0 is not a valid host timer_t value

2022-09-27 Thread Laurent Vivier
Le 25/07/2022 à 13:00, Peter Maydell a écrit : For handling guest POSIX timers, we currently use an array g_posix_timers[], whose entries are a host timer_t value, or 0 for "this slot is unused". When the guest calls the timer_create syscall we look through the array for a slot containing 0,

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-09-27 Thread Daniel P . Berrangé
On Tue, Sep 27, 2022 at 01:43:15PM +0530, Ani Sinha wrote: > On Sun, Sep 18, 2022 at 1:58 AM Michael S. Tsirkin wrote: > > > > On Fri, Sep 16, 2022 at 09:30:42PM +0530, Ani Sinha wrote: > > > On Thu, Jul 28, 2022 at 12:08 AM Ani Sinha wrote: > > > > > > > > > > > > > > > > On Mon, 25 Jul 2022,

Re: [PATCH v3 42/54] chardev/char-file: Add FILE_SHARE_WRITE when opening the file for win32

2022-09-27 Thread Marc-André Lureau
Hi On Mon, Sep 26, 2022 at 7:05 PM Bin Meng wrote: > On Mon, Sep 26, 2022 at 9:27 PM Marc-André Lureau > wrote: > > > > Hi > > > > On Sun, Sep 25, 2022 at 4:35 PM Bin Meng wrote: > >> > >> From: Xuzhou Cheng > >> > >> The combination of GENERIC_WRITE and FILE_SHARE_READ options does not > >>

Re: [PATCH v2 04/11] qtest: make read/write operation appear to be from CPU

2022-09-27 Thread Thomas Huth
On 26/09/2022 15.38, Alex Bennée wrote: The point of qtest is to simulate how running code might interact with the system. However because it's not a real system we have places in the code which especially handle check qtest_enabled() before referencing current_cpu. Now we can encode these

[PATCH v2 3/3] hw/intc: Fix LoongArch ipi device emulation

2022-09-27 Thread Xiaojuan Yang
In ipi_send function, it should not to set irq before writing data to dest cpu iocsr space, as the irq will trigger after data writing. Signed-off-by: Xiaojuan Yang --- hw/intc/loongarch_ipi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/intc/loongarch_ipi.c b/hw/intc/loongarch_ipi.c

[PULL v2 00/22] riscv-to-apply queue

2022-09-27 Thread Alistair Francis
/alistair23/qemu.git tags/pull-riscv-to-apply-20220927 for you to fetch changes up to a3ab69f9f6c000481c439923d16416b8941d5b37: target/riscv: rvv-1.0: vf[w]redsum distinguish between ordered/unordered (2022-09-27 11:23:57 +1000

[PULL 3/3] m68k: align bootinfo strings and data to 4 bytes

2022-09-27 Thread Laurent Vivier
From: "Jason A. Donenfeld" Various tools, such as kexec-tools and m68k-bootinfo, expect each bootinfo entry to be aligned to 4 bytes, not 2 bytes. So adjust the padding to fill this out as such. Also, break apart the padding additions from the other field length additions, so that it's more

[PULL v2 01/22] hw/ssi: ibex_spi: fixup typos in ibex_spi_host

2022-09-27 Thread Alistair Francis
From: Wilfred Mallawa This patch fixes up minor typos in ibex_spi_host Signed-off-by: Wilfred Mallawa Reviewed-by: Alistair Francis Reviewed-by: Andrew Jones Message-Id: <20220823061201.132342-2-wilfred.mall...@opensource.wdc.com> Signed-off-by: Alistair Francis --- hw/ssi/ibex_spi_host.c

[PULL v2 19/22] target/riscv: debug: Check VU/VS modes for type 2 trigger

2022-09-27 Thread Alistair Francis
From: Frank Chang Type 2 trigger cannot be fired in VU/VS modes. Signed-off-by: Frank Chang Reviewed-by: Bin Meng Signed-off-by: Bin Meng Message-Id: <20220909134215.1843865-8-bmeng...@gmail.com> Signed-off-by: Alistair Francis --- target/riscv/debug.c | 10 ++ 1 file changed, 10

[PULL 6/8] virtio-net: Update virtio-net curr_queue_pairs in vdpa backends

2022-09-27 Thread Jason Wang
From: Eugenio Pérez It was returned as error before. Instead of it, simply update the corresponding field so qemu can send it in the migration data. Signed-off-by: Eugenio Pérez Acked-by: Si-Wei Liu Signed-off-by: Jason Wang --- hw/net/virtio-net.c | 17 ++--- 1 file changed, 6

Re: [PATCH 3/3] tests/qtest: sifive-e-aon-watchdog-test.c : Add QTest of watchdog of sifive_e

2022-09-27 Thread Frank Chang
Reviewed-by: Frank Chang On Thu, Sep 22, 2022 at 4:42 PM Tommy Wu wrote: > Add some simple tests of the watchdog timer in the always-on domain device > of HiFive 1 rev b. > > Signed-off-by: Tommy Wu > --- > tests/qtest/meson.build | 3 + >

[PATCH v2 4/4] target/loongarch: flogb_{s/d} add set float_flag_divbyzero

2022-09-27 Thread Song Gao
if fj ==0 or fj == INT32_MIN/INT64_MIN, LoongArch host set fcsr cause exception FP_DIV0, So we need set exception flags float_flagdivbyzero if fj ==0. Signed-off-by: Song Gao --- target/loongarch/fpu_helper.c | 14 ++ 1 file changed, 14 insertions(+) diff --git

Re: [PATCH 0/7] linux-user fixes for hppa target - part 2

2022-09-27 Thread Laurent Vivier
Le 24/09/2022 à 13:44, Helge Deller a écrit : Some additional patches for linux-user, which mostly target the hppa platform. This series is on top of my previous posted patch series. Please review. Helge Helge Deller (7): linux-user: Fix TARGET_PROT_SEM for XTENSA linux-user: Add proper

[PULL 7/8] vdpa: Allow MQ feature in SVQ

2022-09-27 Thread Jason Wang
From: Eugenio Pérez Finally enable SVQ with MQ feature. Signed-off-by: Eugenio Pérez Signed-off-by: Jason Wang --- net/vhost-vdpa.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index c6cbe2f..4bc3fd0 100644 --- a/net/vhost-vdpa.c +++

[PULL 09/24] ui/vdagent: fix serial reset of guest agent

2022-09-27 Thread Gerd Hoffmann
From: Marc-André Lureau In order to reset the guest agent, we send CLOSED & OPENED events. They are correctly received by the guest kernel. However, they might not be noticed by the guest agent process, as the IO task (poll() for example) might be wake up after both CLOSED & OPENED have been

[PULL 17/24] usbnet: Accept mandatory USB_CDC_SET_ETHERNET_PACKET_FILTER request

2022-09-27 Thread Gerd Hoffmann
From: Michael Brown The USB_CDC_SET_ETHERNET_PACKET_FILTER request is mandatory for CDC-ECM devices. Accept this request, ignoring the actual filter value (to match the existing behaviour for RNDIS). Signed-off-by: Michael Brown Message-Id: <20220906183053.3625472-3-mc...@ipxe.org>

Re: [PATCH v3 00/12] linux-user: Add more syscalls, enhance tracing & logging enhancements

2022-09-27 Thread Laurent Vivier
Le 27/09/2022 à 10:56, Helge Deller a écrit : On 9/27/22 09:32, Laurent Vivier wrote: Le 18/09/2022 à 21:45, Helge Deller a écrit : Here is a bunch of patches for linux-user. Most of them add missing syscalls and enhance the tracing/logging. Some of the patches are target-hppa specific. I've

Re: [PATCH v9 05/16] qapi: net: add stream and dgram netdevs

2022-09-27 Thread Markus Armbruster
Laurent Vivier writes: > Copied from socket netdev file and modified to use SocketAddress > to be able to introduce new features like unix socket. > > "udp" and "mcast" are squashed into dgram netdev, multicast is detected > according to the IP address type. > "listen" and "connect" modes are

Re: [PATCH v3 1/5] msmouse: Handle mouse reset

2022-09-27 Thread Marc-André Lureau
Hi On Sun, Sep 11, 2022 at 10:39 PM Arwed Meyer wrote: > Detect mouse reset via RTS or DTR line: > Don't send or process anything while in reset. > When coming out of reset, send ID sequence first thing. > This allows msmouse to be detected by common mouse drivers. > > Resolves:

Re: [PATCH] linux-user/s390x: Save/restore fpc when handling a signal

2022-09-27 Thread Laurent Vivier
Le 17/08/2022 à 14:39, Ilya Leoshkevich a écrit : Linux kernel does this in fpregs_store() and fpregs_load(), so qemu-user should do this as well. Found by running valgrind's none/tests/s390x/test_sig. Signed-off-by: Ilya Leoshkevich --- linux-user/s390x/signal.c | 2 ++ 1 file changed, 2

Re: [PATCH] gtk: Add show_menubar=on|off command line option.

2022-09-27 Thread Markus Armbruster
Please post revisions in a new thread (not in reply to anything), and with a subject like [PATCH v2]. You can use "git format-patch -v2" to get such subjects. Bryce Mills writes: > The patch adds "show_menubar" command line option for GTK UI similar to > "show_tabs". This option allows to hide

Re: [PATCH v2] block: Refactor get_tmp_filename()

2022-09-27 Thread Bin Meng
Hi Markus, On Tue, Sep 27, 2022 at 2:22 PM Markus Armbruster wrote: > > Bin Meng writes: > > > On Mon, Sep 26, 2022 at 6:13 PM Markus Armbruster wrote: > >> > >> Bin Meng writes: > >> > >> > From: Bin Meng > >> > > >> > At present there are two callers of get_tmp_filename() and they are > >>

[PULL v2 05/22] target/riscv: fix csr check for cycle{h}, instret{h}, time{h}, hpmcounter3-31{h}

2022-09-27 Thread Alistair Francis
From: Weiwei Li - modify check for mcounteren to work in all less-privilege mode - modify check for scounteren to work only when S mode is enabled - distinguish the exception type raised by check for scounteren between U and VU mode Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang

Re: [PATCH 2/3] hw/riscv: sifive_e: Support the watchdog timer of HiFive 1 rev b.

2022-09-27 Thread Frank Chang
Reviewed-by: Frank Chang On Thu, Sep 22, 2022 at 4:41 PM Tommy Wu wrote: > Create the AON device when we realize the sifive_e machine. > This patch only implemented the functionality of the watchdog timer, > not all the functionality of the AON device. > > Signed-off-by: Tommy Wu > --- >

[PULL 12/24] hcd-ohci: Drop ohci_service_iso_td() if ed->head & OHCI_DPTR_MASK is zero

2022-09-27 Thread Gerd Hoffmann
From: Qiang Liu An abort happens in ohci_frame_boundary() when ohci->done is 0 [1]. ``` c static void ohci_frame_boundary(void *opaque) { // ... if (ohci->done_count == 0 && !(ohci->intr_status & OHCI_INTR_WD)) { if (!ohci->done) abort();

[PULL 23/24] hw/display/ati_2d: Fix buffer overflow in ati_2d_blt (CVE-2021-3638)

2022-09-27 Thread Gerd Hoffmann
From: Philippe Mathieu-Daudé When building QEMU with DEBUG_ATI defined then running with '-device ati-vga,romfile="" -d unimp,guest_errors -trace ati\*' we get: ati_mm_write 4 0x16c0 DP_CNTL <- 0x1 ati_mm_write 4 0x146c DP_GUI_MASTER_CNTL <- 0x2 ati_mm_write 4 0x16c8 DP_MIX <- 0xff

[PULL 20/24] audio: Add sndio backend

2022-09-27 Thread Gerd Hoffmann
From: Alexandre Ratchov sndio is the native API used by OpenBSD, although it has been ported to other *BSD's and Linux (packages for Ubuntu, Debian, Void, Arch, etc.). Signed-off-by: Brad Smith Signed-off-by: Alexandre Ratchov Reviewed-by: Volker Rümelin Tested-by: Volker Rümelin

[PULL 02/24] ui/cocoa: Run qemu_init in the main thread

2022-09-27 Thread Gerd Hoffmann
From: Akihiko Odaki This work is based on: https://patchew.org/QEMU/20220317125534.38706-1-philippe.mathieu.da...@gmail.com/ Simplify the initialization dance by running qemu_init() in the main thread before the Cocoa event loop starts. The secondary thread only runs only qemu_main_loop() and

Re: [PATCH 3/8] linux-user: Implement FUTEX_WAKE_BITSET

2022-09-27 Thread Laurent Vivier
Le 29/08/2022 à 04:10, Richard Henderson a écrit : Signed-off-by: Richard Henderson --- linux-user/syscall.c | 1 + 1 file changed, 1 insertion(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 8fbd5a9556..8bf4b79a9e 100644 --- a/linux-user/syscall.c +++

[PATCH v2 0/3] Add memmap and fix bugs for LoongArch

2022-09-27 Thread Xiaojuan Yang
This series add memmap table and fix extioi, ipi device emulation for LoongArch virt machine. Changes for v2: 1. Adjust the position of 'PLATFORM' element in memmap table Changes for v1: 1. Add memmap table for LoongArch virt machine 2. Fix LoongArch extioi function 3. Fix LoongArch ipi device

[PATCH v2 2/3] hw/intc: Fix LoongArch extioi function

2022-09-27 Thread Xiaojuan Yang
1.When cpu read or write extioi COREISR reg, it should access the reg belonged to itself, so the index of 's->coreisr' is current cpu number. 2.Remove the unused extioi system memory region and we only support the extioi iocsr memory region now. Signed-off-by: Xiaojuan Yang ---

[PATCH v2 1/3] hw/loongarch: Add memmap for LoongArch virt machine

2022-09-27 Thread Xiaojuan Yang
Using memmap table for loongarch virt machine type, this method comes from arm/riscv architectures. Signed-off-by: Xiaojuan Yang --- hw/loongarch/acpi-build.c | 46 ++-- hw/loongarch/fw_cfg.c | 5 +- hw/loongarch/virt.c | 138 ++--

[PULL v2 06/22] target/riscv: remove fflags, frm, and fcsr from riscv-*-fpu.xml

2022-09-27 Thread Alistair Francis
From: Andrew Burgess While testing some changes to GDB's handling for the RISC-V registers fcsr, fflags, and frm, I spotted that QEMU includes these registers twice in the target description it sends to GDB, once in the fpu feature, and once in the csr feature. Right now things basically work

[PATCH v2 1/4] target/loongarch: ftint_xxx insns set the result high 32bit 0xffffffff

2022-09-27 Thread Song Gao
we just set high 32bit 0x as the other float instructions do. Signed-off-by: Song Gao --- target/loongarch/fpu_helper.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/target/loongarch/fpu_helper.c b/target/loongarch/fpu_helper.c index

[PULL v2 13/22] target/riscv: debug: Determine the trigger type from tdata1.type

2022-09-27 Thread Alistair Francis
From: Frank Chang Current RISC-V debug assumes that only type 2 trigger is supported. To allow more types of triggers to be supported in the future (e.g. type 6 trigger, which is similar to type 2 trigger with additional functionality), we should determine the trigger type from tdata1.type.

[PULL v2 21/22] target/riscv: rvv-1.0: Simplify vfwredsum code

2022-09-27 Thread Alistair Francis
From: Yang Liu Remove duplicate code by wrapping vfwredsum_vs's OP function. Signed-off-by: Yang Liu Reviewed-by: Alistair Francis Reviewed-by: Frank Chang Message-Id: <20220817074802.20765-1-liuyan...@iscas.ac.cn> Signed-off-by: Alistair Francis --- target/riscv/vector_helper.c | 56

[PULL 2/8] vdpa: Make VhostVDPAState cvq_cmd_in_buffer control ack type

2022-09-27 Thread Jason Wang
From: Eugenio Pérez This allows to simplify the code. Rename to status while we're at it. Signed-off-by: Eugenio Pérez Signed-off-by: Jason Wang --- net/vhost-vdpa.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/net/vhost-vdpa.c

[PULL 00/24] Kraxel 20220927 patches

2022-09-27 Thread Gerd Hoffmann
/kraxel-20220927-pull-request for you to fetch changes up to 49a99ecb2290571b2e3f464c13e9c73b87ca91c4: virtio-gpu: update scanout if there is any area covered by the rect (2022-09-27 07:32:31 +0200) usb: make usbnet work with xhci

Re: [PATCH] linux-user: fix bug about missing signum convert of sigqueue

2022-09-27 Thread Laurent Vivier
Le 05/09/2022 à 19:54, Richard Henderson a écrit : On 8/31/22 05:10, fa...@mail.ustc.edu.cn wrote:  From 4ebe8a67ed7c4b1220957b2b67a62ba60e0e80ec Mon Sep 17 00:00:00 2001 From: fanwenjie Date: Wed, 31 Aug 2022 11:55:25 +0800 Subject: [PATCH] linux-user: fix bug about missing signum convert of

[PULL 08/24] ui/clipboard: reset the serial state on reset

2022-09-27 Thread Gerd Hoffmann
From: Marc-André Lureau Not only we have to reset the vdagent clipboards serial state, but also the current QEMU clipboards info serial (the value is currently used by qemu_clipboard_check_serial, only used by -display dbus). Signed-off-by: Marc-André Lureau Message-Id:

Re: [PATCH v3 5/5] serial: Allow unaligned i/o access

2022-09-27 Thread Marc-André Lureau
On Sun, Sep 11, 2022 at 10:46 PM Arwed Meyer wrote: > Unaligned i/o access on serial UART works on real PCs. > This is used for example by FreeDOS CTMouse driver. Without this it > can't reset and detect serial mice. > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/77 > Signed-off-by:

[PULL 14/24] usb/msd: add usb_msd_fatal_error() and fix guest-triggerable assert

2022-09-27 Thread Gerd Hoffmann
Add handler for fatal errors. Moves device into error state where it stops responding until the guest resets it. Guest can send illegal requests where scsi command and usb packet transfer directions are inconsistent. Use the new usb_msd_fatal_error() function instead of assert() in that case.

Re: [PATCH v2] Revert "intel_iommu: Fix irqchip / X2APIC configuration checks"

2022-09-27 Thread Igor Mammedov
On Mon, 26 Sep 2022 11:32:06 -0400 Peter Xu wrote: > It's true that when vcpus<=255 we don't require the length of 32bit APIC > IDs. However here since we already have EIM=ON it means the hypervisor > will declare the VM as x2apic supported (e.g. VT-d ECAP register will have > EIM bit 4 set),

[PULL 13/24] usb/msd: move usb_msd_packet_complete()

2022-09-27 Thread Gerd Hoffmann
Change ordering to avoid adding forward declarations in following patches. Fix comment code style while being at it. No functional change. Signed-off-by: Gerd Hoffmann Message-Id: <20220830063827.813053-2-kra...@redhat.com> --- hw/usb/dev-storage.c | 26 ++ 1 file

Re: [patch v0] qapi/qmp: Add timestamps to qmp command responses.

2022-09-27 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Mon, Sep 26, 2022 at 12:59:40PM +0300, Denis Plotnikov wrote: >> Add "start" & "end" timestamps to qmp command responses. >> It's disabled by default, but can be enabled with 'timestamp=on' >> monitor's parameter, e.g.: >> -chardev

[PULL 1/3] target/m68k: increase size of m68k CPU features from uint32_t to uint64_t

2022-09-27 Thread Laurent Vivier
From: Mark Cave-Ayland There are already 32 feature bits in use, so change the size of the m68k CPU features to uint64_t (along with the associated m68k_feature() functions) to allow up to 64 feature bits to be used. At the same time make use of the BIT_ULL() macro when reading/writing the CPU

[PULL v2 15/22] target/riscv: debug: Introduce tdata1, tdata2, and tdata3 CSRs

2022-09-27 Thread Alistair Francis
From: Frank Chang Replace type2_trigger_t with the real tdata1, tdata2, and tdata3 CSRs, which allows us to support more types of triggers in the future. Signed-off-by: Frank Chang Reviewed-by: Bin Meng Signed-off-by: Bin Meng Reviewed-by: LIU Zhiwei Message-Id:

[PULL v2 09/22] hw/riscv: opentitan: Fixup resetvec

2022-09-27 Thread Alistair Francis
From: Alistair Francis The resetvec for the OpenTitan machine ended up being set to an out of date value, so let's fix that and bump it to the correct start address (after the boot ROM) Fixes: bf8803c64d75 "hw/riscv: opentitan: bump opentitan version" Signed-off-by: Alistair Francis

[PULL v2 22/22] target/riscv: rvv-1.0: vf[w]redsum distinguish between ordered/unordered

2022-09-27 Thread Alistair Francis
From: Yang Liu Starting with RVV1.0, the original vf[w]redsum_vs instruction was renamed to vf[w]redusum_vs. The distinction between ordered and unordered is also more consistent with other instructions, although there is no difference in implementation between the two for QEMU. Signed-off-by:

[PULL v2 14/22] target/riscv: debug: Introduce build_tdata1() to build tdata1 register content

2022-09-27 Thread Alistair Francis
From: Frank Chang Introduce build_tdata1() to build tdata1 register content, which can be shared among all types of triggers. Signed-off-by: Frank Chang Reviewed-by: Bin Meng Signed-off-by: Bin Meng Reviewed-by: LIU Zhiwei [bmeng: moved RV{32,64}_DATA_MASK definition to this patch]

[PULL 0/8] Net patches

2022-09-27 Thread Jason Wang
The following changes since commit 99d6b11b5b44d7dd64f4cb1973184e40a4a174f8: Merge tag 'pull-target-arm-20220922' of https://git.linaro.org/people/pmaydell/qemu-arm into staging (2022-09-26 13:38:26 -0400) are available in the git repository at: https://github.com/jasowang/qemu.git

[PATCH v2 2/4] target/loongarch: bstrins.w need set dest register EXT_SIGN

2022-09-27 Thread Song Gao
Signed-off-by: Song Gao --- target/loongarch/insn_trans/trans_bit.c.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/loongarch/insn_trans/trans_bit.c.inc b/target/loongarch/insn_trans/trans_bit.c.inc index 9337714ec4..33e94878fd 100644 ---

Re: [PATCH v3 00/12] linux-user: Add more syscalls, enhance tracing & logging enhancements

2022-09-27 Thread Laurent Vivier
Le 18/09/2022 à 21:45, Helge Deller a écrit : Here is a bunch of patches for linux-user. Most of them add missing syscalls and enhance the tracing/logging. Some of the patches are target-hppa specific. I've tested those on productive hppa debian buildd servers (running qemu-user). Thanks!

[PULL 04/24] meson: Allow to enable gtk and sdl while cocoa is enabled

2022-09-27 Thread Gerd Hoffmann
From: Akihiko Odaki As ui/cocoa does no longer override main(), ui/gtk and ui/sdl can be enabled even ui/cocoa is enabled. Signed-off-by: Akihiko Odaki Reviewed-by: Peter Maydell Reviewed-by: Paolo Bonzini Message-Id: <20220819132756.74641-4-akihiko.od...@gmail.com> Signed-off-by: Gerd

[PULL 19/24] usbnet: Report link-up via interrupt endpoint in CDC-ECM mode

2022-09-27 Thread Gerd Hoffmann
From: Michael Brown Signed-off-by: Michael Brown Message-Id: <20220906183053.3625472-5-mc...@ipxe.org> Signed-off-by: Gerd Hoffmann --- hw/usb/dev-network.c | 27 +-- 1 file changed, 21 insertions(+), 6 deletions(-) diff --git a/hw/usb/dev-network.c

  1   2   3   4   5   >