Re: [PATCH v4] linux-user: Fix /proc/cpuinfo output for hppa

2023-01-30 Thread Laurent Vivier
Le 27/01/2023 à 21:10, Helge Deller a écrit : The hppa architectures provides an own output for the emulated /proc/cpuinfo file. Some userspace applications count (even if that's not the recommended way) the number of lines which start with "processor:" and assume that this number then reflects

[PATCH v3] migration: Remove res_compatible parameter

2023-01-30 Thread Juan Quintela
It was only used for RAM, and in that case, it means that this amount of data was sent for memory. Just delete the field in all callers. [Rest of the pages on the vfio series are already on my previous pull request] Signed-off-by: Juan Quintela --- include/migration/register.h | 27

Re: [PATCH v1 2/2] virtio-net: virtio_net_flush_tx() check for per-queue reset

2023-01-30 Thread Jason Wang
On Mon, Jan 30, 2023 at 4:03 PM Xuan Zhuo wrote: > > On Mon, 30 Jan 2023 15:49:36 +0800, Jason Wang wrote: > > On Mon, Jan 30, 2023 at 1:32 PM Michael S. Tsirkin wrote: > > > > > > On Mon, Jan 30, 2023 at 10:15:12AM +0800, Xuan Zhuo wrote: > > > > On Sun, 29 Jan 2023 07:15:47 -0500, "Michael S.

Re: [PATCH] linux-user: move target_flat.h to target subdirs

2023-01-30 Thread Laurent Vivier
Le 29/01/2023 à 01:46, Mike Frysinger a écrit : This makes target_flat.h behave like every other target_xxx.h header. It also makes it actually work -- while the current header says adding a header to the target subdir overrides the common one, it doesn't. This is for two reasons: * meson.build

Re: [PATCH v3 09/14] RISC-V: Adding T-Head MemIdx extension

2023-01-30 Thread LIU Zhiwei
On 2023/1/25 5:21, Richard Henderson wrote: On 1/24/23 09:59, Christoph Muellner wrote: +/* XTheadMemIdx */ + +/* + * Load with memop from indexed address and add (imm5 << imm2) to rs1. + * If !preinc, then the load address is rs1. + * If  preinc, then the load address is rs1 + (imm5) <<

Re: [PATCH qemu v3] x86: don't let decompressed kernel image clobber setup_data

2023-01-30 Thread Daniel P . Berrangé
On Sat, Jan 28, 2023 at 06:15:03AM -0500, Michael S. Tsirkin wrote: > On Mon, Jan 23, 2023 at 06:37:21AM -0600, Jason A. Donenfeld wrote: > > On Mon, Jan 23, 2023 at 6:12 AM Michael S. Tsirkin wrote: > > > > > > On Sun, Jan 22, 2023 at 08:21:30PM -0800, Eric Biggers wrote: > > > > Hi Michael, > >

[PATCH v4 07/16] hw/9pfs: Update helper qemu_stat_rdev()

2023-01-30 Thread Bin Meng
As Windows host does not have stat->st_rdev field, we use the first 3 characters of the root path to build a device id. Co-developed-by: Guohuai Shi Signed-off-by: Bin Meng --- hw/9pfs/9p-util.h | 22 +++--- hw/9pfs/9p-util-win32.c | 18 ++ hw/9pfs/9p.c

[PATCH v4 16/16] meson.build: Turn on virtfs for Windows

2023-01-30 Thread Bin Meng
From: Guohuai Shi Enable virtfs configuration option for Windows host. Signed-off-by: Guohuai Shi Signed-off-by: Bin Meng --- meson.build | 10 +- fsdev/meson.build | 1 + hw/9pfs/meson.build | 8 +--- 3 files changed, 11 insertions(+), 8 deletions(-) diff --git

[PATCH v4 11/16] hw/9pfs: Add Linux error number definition

2023-01-30 Thread Bin Meng
From: Guohuai Shi When using 9p2000.L protocol, the errno should use the Linux errno. Currently magic numbers with comments are used. Replace these with macros for future expansion. Signed-off-by: Guohuai Shi Signed-off-by: Bin Meng --- hw/9pfs/9p-linux-errno.h | 151

[PATCH v4 15/16] tests/qtest: virtio-9p-test: Adapt the case for win32

2023-01-30 Thread Bin Meng
From: Guohuai Shi Windows does not provide the getuid() API. Let's create a local one and return a fixed value 0 as the uid for testing. Co-developed-by: Xuzhou Cheng Signed-off-by: Guohuai Shi Signed-off-by: Bin Meng Reviewed-by: Thomas Huth --- tests/qtest/libqos/virtio-9p-client.h | 7

[PATCH v4 06/16] hw/9pfs: Support getting current directory offset for Windows

2023-01-30 Thread Bin Meng
From: Guohuai Shi On Windows 'struct dirent' does not have current directory offset. Update qemu_dirent_off() to support Windows. While we are here, add a build time check to error out if a new host does not implement this helper. Signed-off-by: Guohuai Shi Signed-off-by: Bin Meng ---

[PATCH v4 14/16] hw/9pfs: Update synth fs driver for Windows

2023-01-30 Thread Bin Meng
From: Guohuai Shi Adapt synth fs driver for Windows in preparation to running qtest 9p testing on Windows. Signed-off-by: Guohuai Shi Signed-off-by: Bin Meng Reviewed-by: Philippe Mathieu-Daudé --- hw/9pfs/9p-synth.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[PATCH v4 10/16] hw/9pfs: Update v9fs_set_fd_limit() for Windows

2023-01-30 Thread Bin Meng
From: Guohuai Shi Use _getmaxstdio() to set the fd limit on Windows. Signed-off-by: Guohuai Shi Signed-off-by: Bin Meng --- hw/9pfs/9p.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c index 2497a06f43..b55d0bc400

[PATCH v2 01/11] migration: Update atomic stats out of the mutex

2023-01-30 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/multifd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/migration/multifd.c b/migration/multifd.c index 000ca4d4ec..20a81cd7f2 100644 --- a/migration/multifd.c +++ b/migration/multifd.c @@ -432,8 +432,8 @@ static int

[PATCH v2 04/11] multifd: Count the number of bytes sent correctly

2023-01-30 Thread Juan Quintela
Current code asumes that all pages are whole. That is not true for example for compression already. Fix it for creating a new field ->sent_bytes that includes it. All ram_counters are used only from the migration thread, so we have two options: - put a mutex and fill everything when we sent it

[PATCH v2 03/11] multifd: We already account for this packet on the multifd thread

2023-01-30 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/multifd.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/migration/multifd.c b/migration/multifd.c index 49fa76e5e1..61cafe4c76 100644 --- a/migration/multifd.c +++ b/migration/multifd.c @@ -622,10 +622,7 @@ int multifd_send_sync_main(QEMUFile

Re: [PATCH v3 12/14] RISC-V: Add initial support for T-Head C906

2023-01-30 Thread LIU Zhiwei
On 2023/1/25 5:26, Richard Henderson wrote: On 1/24/23 09:59, Christoph Muellner wrote: +++ b/target/riscv/cpu.h @@ -27,6 +27,7 @@   #include "qom/object.h"   #include "qemu/int128.h"   #include "cpu_bits.h" +#include "cpu_vendorid.h" I don't see that this ID is required for all users of

[PATCH v4 02/16] hw/9pfs: Implement Windows specific utilities functions for 9pfs

2023-01-30 Thread Bin Meng
From: Guohuai Shi Windows POSIX API and MinGW library do not provide the NO_FOLLOW flag, and do not allow opening a directory by POSIX open(). This causes all xxx_at() functions cannot work directly. However, we can provide Windows handle based functions to emulate xxx_at() functions (e.g.:

[PATCH v4 05/16] hw/9pfs: Update the local fs driver to support Windows

2023-01-30 Thread Bin Meng
From: Guohuai Shi Update the 9p 'local' file system driver to support Windows, including open, read, write, close, rename, remove, etc. All security models are supported. The mapped (mapped-xattr) security model is implemented using NTFS Alternate Data Stream (ADS) so the 9p export path shall

[PATCH v4 13/16] fsdev: Disable proxy fs driver on Windows

2023-01-30 Thread Bin Meng
From: Guohuai Shi We don't plan to support 'proxy' file system driver for 9pfs on Windows. Disable it for Windows build. Signed-off-by: Guohuai Shi Signed-off-by: Bin Meng --- fsdev/qemu-fsdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fsdev/qemu-fsdev.c b/fsdev/qemu-fsdev.c

[PATCH v4 04/16] hw/9pfs: Implement Windows specific xxxdir() APIs

2023-01-30 Thread Bin Meng
From: Guohuai Shi This commit implements Windows specific xxxdir() APIs for safety directory access. Signed-off-by: Guohuai Shi Signed-off-by: Bin Meng --- hw/9pfs/9p-util.h | 6 + hw/9pfs/9p-util-win32.c | 296 2 files changed, 302

[PATCH v4 03/16] hw/9pfs: Replace the direct call to xxxdir() APIs with a wrapper

2023-01-30 Thread Bin Meng
From: Guohuai Shi xxxdir() APIs are not safe on Windows host. For future extension to Windows, let's replace the direct call to xxxdir() APIs with a wrapper. Signed-off-by: Guohuai Shi Signed-off-by: Bin Meng --- hw/9pfs/9p-util.h | 14 ++ hw/9pfs/9p-local.c | 12 ++--

[PATCH v4 00/16] hw/9pfs: Add 9pfs support for Windows

2023-01-30 Thread Bin Meng
At present there is no Windows support for 9p file system. This series adds initial Windows support for 9p file system. 'local' file system backend driver is supported on Windows, including open, read, write, close, rename, remove, etc. All security models are supported. The mapped (mapped-xattr)

[PATCH v4 01/16] hw/9pfs: Add missing definitions for Windows

2023-01-30 Thread Bin Meng
From: Guohuai Shi Some definitions currently used by the 9pfs codes are only available on POSIX platforms. Let's add our own ones in preparation to adding 9pfs support for Windows. Signed-off-by: Guohuai Shi Signed-off-by: Bin Meng --- fsdev/file-op-9p.h | 33

[PATCH v4 12/16] hw/9pfs: Translate Windows errno to Linux value

2023-01-30 Thread Bin Meng
From: Guohuai Shi Some of Windows error numbers have different value from Linux ones. For example, ENOTEMPTY is defined to 39 in Linux, but is defined to 41 in Windows. So deleting a directory from a Linux guest on top of QEMU from a Windows host complains: # rmdir tmp rmdir: 'tmp': Unknown

[PATCH v4 08/16] hw/9pfs: Add a helper qemu_stat_blksize()

2023-01-30 Thread Bin Meng
As Windows host does not have stat->st_blksize field, we use the one we calculated in init_win32_root_directory(). Add a helper qemu_stat_blksize() and use it to avoid direct access to stat->st_blksize. Co-developed-by: Guohuai Shi Signed-off-by: Bin Meng --- hw/9pfs/9p-util.h | 13

[PATCH v4 09/16] hw/9pfs: Disable unsupported flags and features for Windows

2023-01-30 Thread Bin Meng
From: Guohuai Shi Some flags and features are not supported on Windows, like mknod, readlink, file mode, etc. Update the codes for Windows. Signed-off-by: Guohuai Shi Signed-off-by: Bin Meng --- hw/9pfs/9p.c | 45 ++--- 1 file changed, 38

[PATCH v2 02/11] migration: Make multifd_bytes atomic

2023-01-30 Thread Juan Quintela
In the spirit of: commit 394d323bc3451e4d07f13341cb8817fac8dfbadd Author: Peter Xu Date: Tue Oct 11 17:55:51 2022 -0400 migration: Use atomic ops properly for page accountings Signed-off-by: Juan Quintela --- migration/ram.h | 1 + migration/migration.c | 4 ++--

[PATCH v2 09/11] multifd: Support for zero pages transmission

2023-01-30 Thread Juan Quintela
This patch adds counters and similar. Logic will be added on the following patch. Signed-off-by: Juan Quintela --- Added counters for duplicated/non duplicated pages. Removed reviewed by from David. Add total_zero_pages --- migration/multifd.h| 17 - migration/multifd.c

[PATCH v2 00/11] Multifd zero page support

2023-01-30 Thread Juan Quintela
Based on top of my next branch. - Rebased on top of latest upstream - Redo a lot of the packet accounting still not completely perfect, but much better than what is upstream Still working continuing on that. Please review. [v2] - rebased on top of latest upstream - lots of minor fixes - start

[PATCH v2 07/11] multifd: Prepare to send a packet without the mutex held

2023-01-30 Thread Juan Quintela
We do the send_prepare() and the fill of the head packet without the mutex held. It will help a lot for compression and later in the series for zero pages. Notice that we can use p->pages without holding p->mutex because p->pending_job == 1. Signed-off-by: Juan Quintela ---

[PATCH v2 11/11] So we use multifd to transmit zero pages.

2023-01-30 Thread Juan Quintela
Signed-off-by: Juan Quintela --- - Check zero_page property before using new code (Dave) --- migration/migration.c | 3 +-- migration/ram.c | 32 +++- 2 files changed, 32 insertions(+), 3 deletions(-) diff --git a/migration/migration.c

[PATCH v2 10/11] multifd: Zero pages transmission

2023-01-30 Thread Juan Quintela
This implements the zero page dection and handling. Signed-off-by: Juan Quintela --- Add comment for offset (dave) Use local variables for offset/block to have shorter lines --- migration/multifd.h | 5 + migration/multifd.c | 45 +++-- 2 files

[PATCH v2 06/11] multifd: Make flags field thread local

2023-01-30 Thread Juan Quintela
Use of flags with respect to locking was incensistant. For the sending side: - it was set to 0 with mutex held on the multifd channel. - MULTIFD_FLAG_SYNC was set with mutex held on the migration thread. - Everything else was done without the mutex held on the multifd channel. On the reception

[PATCH v2 08/11] multifd: Add capability to enable/disable zero_page

2023-01-30 Thread Juan Quintela
We have to enable it by default until we introduce the new code. Signed-off-by: Juan Quintela --- Change it to a capability. As capabilities are off by default, have to change MULTIFD_ZERO_PAGE to MAIN_ZERO_PAGE, so it is false for default, and true for older versions. ---

[PATCH v2 05/11] migration: Make ram_save_target_page() a pointer

2023-01-30 Thread Juan Quintela
We are going to create a new function for multifd latest in the series. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index

Re: [PATCH v2] linux-user: Improve strace output of personality() and sysinfo()

2023-01-30 Thread Laurent Vivier
Le 27/01/2023 à 21:18, Helge Deller a écrit : Make the strace look nicer for those two syscalls. Signed-off-by: Helge Deller -- v2: use TARGET_ABI_FMT_lx instead of %p in personality output as suggested by Philippe Mathieu-Daudé and Laurent Vivier diff --git a/linux-user/strace.list

Re: [PATCH v4] linux-user: Fix /proc/cpuinfo output for hppa

2023-01-30 Thread Laurent Vivier
Le 27/01/2023 à 21:10, Helge Deller a écrit : The hppa architectures provides an own output for the emulated /proc/cpuinfo file. Some userspace applications count (even if that's not the recommended way) the number of lines which start with "processor:" and assume that this number then reflects

Re: [PATCH 2/2] tcg: use QTree instead of GTree

2023-01-30 Thread Daniel P . Berrangé
On Sun, Jan 29, 2023 at 05:38:08PM -0500, Emilio Cota wrote: > On Wed, Jan 25, 2023 at 15:58:25 +, Daniel P. Berrangé wrote: > > On Wed, Jan 11, 2023 at 12:34:29PM +, Daniel P. Berrangé wrote: > > > On Tue, Jan 10, 2023 at 10:55:36PM -0500, Emilio Cota wrote: > > > > qemu-user can hang in

Re: [PATCH v2] linux-user: Improve strace output of pread64() and pwrite64()

2023-01-30 Thread Laurent Vivier
Le 27/01/2023 à 21:58, Helge Deller a écrit : Make the strace look nicer for those two syscalls. Signed-off-by: Helge Deller --- v2: Use regpairs_aligned() and target_offset64(), noticed by Laurent Vivier diff --git a/linux-user/strace.c b/linux-user/strace.c index 82dc1a1e20..379536f5c9

Re: [PATCH v2 08/11] multifd: Add capability to enable/disable zero_page

2023-01-30 Thread Markus Armbruster
Juan Quintela writes: > We have to enable it by default until we introduce the new code. > > Signed-off-by: Juan Quintela The subject doesn't quite match the patch to the QAPI schema. It claims "capability to enable/disable zero_page", but ... > --- > > Change it to a capability. As

unable to use "-net user" argument after building from master branch

2023-01-30 Thread Neal Elliott
hello,              I'm unable to use the "-net user" argument with the compiled "qemu-system-x86_64" binary. I get an error: "qemu-system-x86_64: -net user: network backend 'user' is not compiled into this binary" I don't know what I'm missing when I used the configure script with the

Re: [PATCH v2] linux-user: Fix SO_ERROR return code of getsockopt()

2023-01-30 Thread Laurent Vivier
Le 27/01/2023 à 21:25, Helge Deller a écrit : Add translation for the host error return code of: getsockopt(19, SOL_SOCKET, SO_ERROR, [ECONNREFUSED], [4]) = 0 This fixes the testsuite of the cockpit debian package with a hppa-linux guest on a x86-64 host. Signed-off-by: Helge Deller ---

[PULL 2/5] migration: No save_live_pending() method uses the QEMUFile parameter

2023-01-30 Thread Juan Quintela
So remove it everywhere. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- include/migration/register.h | 2 +- migration/savevm.h | 2 +- hw/s390x/s390-stattrib.c | 3 +-- hw/vfio/migration.c| 2 +- migration/block-dirty-bitmap.c | 2 +-

[PULL 3/5] migration: Split save_live_pending() into state_pending_*

2023-01-30 Thread Juan Quintela
We split the function into to: - state_pending_estimate: We estimate the remaining state size without stopping the machine. - state pending_exact: We calculate the exact amount of remaining state. The only "device" that implements different functions for _estimate() and _exact() is ram.

[PULL 0/5] Next patches

2023-01-30 Thread Juan Quintela
The following changes since commit 13356edb87506c148b163b8c7eb0695647d00c2a: Merge tag 'block-pull-request' of https://gitlab.com/stefanha/qemu into staging (2023-01-24 09:45:33 +) are available in the Git repository at: https://gitlab.com/juan.quintela/qemu.git tags/next-pull-request

[PULL 4/5] migration: Remove unused threshold_size parameter

2023-01-30 Thread Juan Quintela
Until previous commit, save_live_pending() was used for ram. Now with the split into state_pending_estimate() and state_pending_exact() it is not needed anymore, so remove them. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- include/migration/register.h | 2 --

[PULL 5/5] migration: simplify migration_iteration_run()

2023-01-30 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/migration.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index 594a42f085..644c61e91d 100644 --- a/migration/migration.c

[PULL 1/5] migration: Fix migration crash when target psize larger than host

2023-01-30 Thread Juan Quintela
From: Peter Xu Commit d9e474ea56 overlooked the case where the target psize is even larger than the host psize. One example is Alpha has 8K page size and migration will start to crash the source QEMU when running Alpha migration on x86. Fix it by detecting that case and set host start/end just

Re: [PATCH v2] linux-user: Improve strace output of personality() and sysinfo()

2023-01-30 Thread Laurent Vivier
Le 27/01/2023 à 21:18, Helge Deller a écrit : Make the strace look nicer for those two syscalls. Signed-off-by: Helge Deller -- v2: use TARGET_ABI_FMT_lx instead of %p in personality output as suggested by Philippe Mathieu-Daudé and Laurent Vivier diff --git a/linux-user/strace.list

Re: [PATCH 0/3] Misc sm501 clean ups

2023-01-30 Thread Daniel Henrique Barboza
On 1/28/23 23:43, BALATON Zoltan wrote: On Mon, 23 Jan 2023, Philippe Mathieu-Daudé wrote: On 21/1/23 21:35, BALATON Zoltan wrote: Some small trivial clean ups I've found while looking at this file. BALATON Zoltan (3):    hw/display/sm501: Remove parenthesis around consant macro

Re: [PATCH v1 2/2] virtio-net: virtio_net_flush_tx() check for per-queue reset

2023-01-30 Thread Xuan Zhuo
On Mon, 30 Jan 2023 15:49:36 +0800, Jason Wang wrote: > On Mon, Jan 30, 2023 at 1:32 PM Michael S. Tsirkin wrote: > > > > On Mon, Jan 30, 2023 at 10:15:12AM +0800, Xuan Zhuo wrote: > > > On Sun, 29 Jan 2023 07:15:47 -0500, "Michael S. Tsirkin" > > > wrote: > > > > On Sun, Jan 29, 2023 at

Re: Crash in RTC

2023-01-30 Thread Konstantin Kostiuk
ping On Wed, Aug 24, 2022 at 5:37 PM Konstantin Kostiuk wrote: > Hi Michael and Paolo, > > I write to you as maintainers of mc146818rtc.c. I am working on bug > https://bugzilla.redhat.com/show_bug.cgi?id=2054781 > and reproduced it on the current master branch. > > I added some print at line

Re: [PATCH v3 08/14] RISC-V: Adding T-Head MemPair extension

2023-01-30 Thread LIU Zhiwei
On 2023/1/30 13:43, Richard Henderson wrote: On 1/29/23 16:03, LIU Zhiwei wrote: Thanks. It's a bug. We should load all memory addresses to  local TCG temps first. Do you think we should probe all the memory addresses for the store pair instructions? If so, can we avoid the use of a helper

Re: [PATCH v1 2/2] virtio-net: virtio_net_flush_tx() check for per-queue reset

2023-01-30 Thread Jason Wang
On Mon, Jan 30, 2023 at 1:50 PM Michael S. Tsirkin wrote: > > On Mon, Jan 30, 2023 at 11:53:18AM +0800, Jason Wang wrote: > > On Mon, Jan 30, 2023 at 11:42 AM Xuan Zhuo > > wrote: > > > > > > On Mon, 30 Jan 2023 11:01:40 +0800, Jason Wang > > > wrote: > > > > On Sun, Jan 29, 2023 at 3:44 PM

Re: [PATCH v2] linux-user: Fix SO_ERROR return code of getsockopt()

2023-01-30 Thread Laurent Vivier
Le 27/01/2023 à 21:25, Helge Deller a écrit : Add translation for the host error return code of: getsockopt(19, SOL_SOCKET, SO_ERROR, [ECONNREFUSED], [4]) = 0 This fixes the testsuite of the cockpit debian package with a hppa-linux guest on a x86-64 host. Signed-off-by: Helge Deller ---

Re: [PATCH v9 01/58] include: import Xen public headers to include/standard-headers/

2023-01-30 Thread Thomas Huth
On 28/01/2023 09.10, David Woodhouse wrote: From: Joao Martins There are already some partial headers in include/hw/xen/interface/ which will be removed once we migrate users to the new location. To start with, define __XEN_TOOLS__ in hw/xen/xen.h to ensure that any internal definitions

Re: unable to use "-net user" argument after building from master branch

2023-01-30 Thread Bin Meng
On Mon, Jan 30, 2023 at 6:01 PM Neal Elliott wrote: > > hello, > I'm unable to use the "-net user" argument with the compiled > "qemu-system-x86_64" binary. I get an error: "qemu-system-x86_64: -net user: > network backend 'user' is not compiled into this binary" > > I don't know

[PATCH 01/11] ui/dbus: unregister clipboard on connection close

2023-01-30 Thread marcandre . lureau
From: Marc-André Lureau Fixes unregistration with p2p connections, since they don't have an associated name owner. Signed-off-by: Marc-André Lureau --- ui/dbus-clipboard.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/ui/dbus-clipboard.c

[PATCH 02/11] audio/dbus: there are no sender for p2p mode

2023-01-30 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- audio/audio_int.h | 2 +- audio/dbusaudio.c | 6 -- ui/dbus.c | 2 +- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/audio/audio_int.h b/audio/audio_int.h index e87ce014a0..38864bfbbd 100644 ---

[PATCH 05/11] meson: ensure dbus-display generated code is built before other units

2023-01-30 Thread marcandre . lureau
From: Marc-André Lureau It's simply by luck that dbus-display header is built first before the other units using it. With sourceset, I can't find an easier way out than declaring an extra dependency for dbus-display1 generate code. Signed-off-by: Marc-André Lureau --- ui/meson.build | 6

[PATCH 00/11] ui: dbus & misc fixes

2023-01-30 Thread marcandre . lureau
From: Marc-André Lureau Hi, Here is a collection of fixes for UI related-stuff. Mostly it's improving/fixing -display dbus. Thanks for the reviews! Marc-André Lureau (11): ui/dbus: unregister clipboard on connection close audio/dbus: there are no sender for p2p mode ui/dbus: set mouse

[PATCH 03/11] ui/dbus: set mouse is-absolute during console creation

2023-01-30 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- ui/dbus-console.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/ui/dbus-console.c b/ui/dbus-console.c index 898a4ac8a5..241797b7e9 100644 --- a/ui/dbus-console.c +++ b/ui/dbus-console.c @@ -410,15

[PATCH 04/11] ui/dbus: update the display when switching surface

2023-01-30 Thread marcandre . lureau
From: Marc-André Lureau This seems to be the expected behaviour. Signed-off-by: Marc-André Lureau --- ui/dbus-listener.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ui/dbus-listener.c b/ui/dbus-listener.c index f9fc8eda51..620d9450cc 100644 --- a/ui/dbus-listener.c +++

[PATCH 06/11] ui: rename cursor_{put->unref}

2023-01-30 Thread marcandre . lureau
From: Marc-André Lureau The naming is more conventional in QEMU. Signed-off-by: Marc-André Lureau --- include/ui/console.h| 2 +- hw/display/qxl-render.c | 4 ++-- hw/display/qxl.c| 2 +- hw/display/vmware_vga.c | 4 ++-- ui/cursor.c | 2 +- ui/dbus-listener.c | 2

RE: [PATCH v1 1/1] virtio-block: switch to blk_get_max_hw_transfer

2023-01-30 Thread Or Ozeri
> -Original Message- > From: Kevin Wolf > Sent: Friday, 13 January 2023 13:45 > To: Ilya Dryomov > Cc: Or Ozeri ; qemu-devel@nongnu.org; > dupad...@redhat.com; to.my.troc...@gmail.com; qemu- > bl...@nongnu.org; Danny Harnik ; Stefan Hajnoczi > ; Paolo Bonzini > Subject: [EXTERNAL] Re:

Re: [PATCH 0/3] Vhost-user: replace _SLAVE_ with _BACKEND_

2023-01-30 Thread Maxime Coquelin
On 1/30/23 12:08, Michael S. Tsirkin wrote: On Mon, Jan 30, 2023 at 11:45:45AM +0100, Maxime Coquelin wrote: This series continues the work done to get rid of harmful language in the Vhost-user specification. I prefer a positive "switch to a more inclusive terminology". To consider if you

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

2023-01-30 Thread Daniel P . Berrangé
On Mon, Jan 30, 2023 at 11:47:02AM +, Peter Maydell wrote: > On Mon, 30 Jan 2023 at 11:44, Thomas Huth wrote: > > > > Testing 32-bit host OS support takes a lot of precious time during the QEMU > > contiguous integration tests, and considering that many OS vendors stopped > > shipping 32-bit

Re: [PATCH 6/6] gitlab-ci.d/buildtest: Disintegrate the build-coroutine-sigaltstack job

2023-01-30 Thread Thomas Huth
On 30/01/2023 11.58, Daniel P. Berrangé wrote: On Mon, Jan 30, 2023 at 11:44:46AM +0100, Thomas Huth wrote: We can get rid of the build-coroutine-sigaltstack job by moving the configure flags that should be tested here to other jobs: Move --with-coroutine=sigaltstack to the

Re: [RFC v6 2/4] virtio-blk: add zoned storage emulation for zoned devices

2023-01-30 Thread Daniel P . Berrangé
On Sun, Jan 29, 2023 at 06:39:49PM +0800, Sam Li wrote: > This patch extends virtio-blk emulation to handle zoned device commands > by calling the new block layer APIs to perform zoned device I/O on > behalf of the guest. It supports Report Zone, four zone oparations (open, > close, finish,

Re: [PATCH v4 04/19] bsd-user: Clean up includes

2023-01-30 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Fri, Jan 27, 2023 at 10:01:57AM -0500, Michael S. Tsirkin wrote: >> On Fri, Jan 27, 2023 at 02:54:30PM +, Peter Maydell wrote: >> > On Thu, 19 Jan 2023 at 14:42, Warner Losh wrote: >> > > >> > > Also, why didn't you move sys/resource.h and other such files

Re: [RFC v4 2/3] tests/qtest/cxl-test: whitespace, line ending cleanup

2023-01-30 Thread Jonathan Cameron via
On Thu, 5 Jan 2023 14:38:07 + Jonathan Cameron wrote: > On Mon, 28 Nov 2022 10:01:56 -0500 > Gregory Price wrote: > > > Defines are starting to exceed line length limits, align them for > > cleanliness before making modifications. > > > > Signed-off-by: Gregory Price > > Hi Gregory, >

[PATCH v5 07/20] hw/cxl: Clean up includes

2023-01-30 Thread Markus Armbruster
Clean up includes so that qemu/osdep.h is included first in .c, and not in .h, and headers which it implies are not included manually. This commit was created with scripts/clean-includes. Signed-off-by: Markus Armbruster Reviewed-by: Michael S. Tsirkin --- include/hw/cxl/cxl_component.h | 2

[PATCH v5 01/20] scripts/clean-includes: Fully skip / ignore files

2023-01-30 Thread Markus Armbruster
When clean-includes claims to skip or ignore a file, only the part that sanitizes use of qemu/osdep.h skips the file. The part that looks for duplicate #include does not, and neither does committing to Git. The latter can get unrelated stuff included in the commit, but only if you run

[PATCH v2 6/9] igb: respect E1000_VMOLR_RSSE

2023-01-30 Thread Sriram Yagnaraman
RSS for VFs is only enabled if VMOLR[n].RSSE is set. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 89650fcfd4..b41b1a5d21 100644 --- a/hw/net/igb_core.c +++

[PATCH v4 09/28] e1000: Use memcpy to intialize registers

2023-01-30 Thread Akihiko Odaki
Use memcpy instead of memmove to initialize registers. The initial register templates and register table instances will never overlap. Signed-off-by: Akihiko Odaki --- hw/net/e1000.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/net/e1000.c b/hw/net/e1000.c index

[PATCH v4 13/28] e1000: Configure ResettableClass

2023-01-30 Thread Akihiko Odaki
This is part of recent efforts of refactoring e1000 and e1000e. DeviceClass's reset member is deprecated so migrate to ResettableClass. There is no behavioral difference. Signed-off-by: Akihiko Odaki Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé --- hw/net/e1000.c | 13

[PATCH] softmmu: Use memmove in flatview_write_continue

2023-01-30 Thread Akihiko Odaki
We found a case where the source passed to flatview_write_continue() may overlap with the destination when fuzzing igb, a new proposed network device with sanitizers. igb uses pci_dma_map() to get Tx packet, and pci_dma_write() to write Rx buffer. While pci_dma_write() is usually used to write

[PATCH 4/6] gitlab-ci.d/buildtest: Merge the --without-default-* jobs

2023-01-30 Thread Thomas Huth
Let's safe some CI minutes by merging these two jobs. We can now also drop "--disable-capstone" since the capstone submodule has been removed a while ago. We should rather tes --disable-fdt now to test a compilation without the "dtc" submodule (for this we have to drop i386-softmmu from the target

[PATCH 3/6] tests/qtest/display-vga-test: Add proper checks if a device is available

2023-01-30 Thread Thomas Huth
display-vga-test currently tries to guess the usable VGA devices according to the target architecture that is used for the test. This of course does not work if QEMU has been built with the "--without-default-devices" configure switch. To fix this, use the qtest_has_device() function for the

[PATCH 2/3] libvhost-user: Adopt new backend naming

2023-01-30 Thread Maxime Coquelin
In order to get rid of harmful language, the Vhost-user specification changed features and requests naming from _SLAVE_ to _BACKEND_. This patch adopts the new naming convention. Signed-off-by: Maxime Coquelin --- subprojects/libvhost-user/libvhost-user.c | 20 ++--

[PATCH 0/3] Vhost-user: replace _SLAVE_ with _BACKEND_

2023-01-30 Thread Maxime Coquelin
This series continues the work done to get rid of harmful language in the Vhost-user specification. While the spec texts were changed to replace slave with backend, the protocol features and messages names hadn't been changed. This series renames remaining occurences in the spec and make use of

[PATCH 1/3] docs: vhost-user: replace _SLAVE_ with _BACKEND_

2023-01-30 Thread Maxime Coquelin
Backend's message and protocol features names were still using "_SLAVE_" naming. For consistency with the new naming convention and to get rid of the remaining harmful language, replace it with _BACKEND_. Signed-off-by: Maxime Coquelin --- docs/interop/vhost-user.rst | 40

[PATCH 1/6] gitlab-ci.d/buildtest: Remove ppc-softmmu from the clang-system job

2023-01-30 Thread Thomas Huth
We are also compile-testing ppc64-softmmu with clang in the "tsan-build" job, and ppc64-softmmu covers pretty much the same code as ppc-softmmu, so we should not lose much test coverage here by removing ppc-softmmu from the "clang-system" job. Signed-off-by: Thomas Huth ---

Re: [PATCH 2/3] libvhost-user: Adopt new backend naming

2023-01-30 Thread Michael S. Tsirkin
On Mon, Jan 30, 2023 at 11:45:47AM +0100, Maxime Coquelin wrote: > In order to get rid of harmful language, the Vhost-user > specification changed features and requests naming from > _SLAVE_ to _BACKEND_. let's drop "to get rid of the remaining harmful language" as don't get rid of it.

[PATCH 07/11] ui: rename cursor_{get->ref}, return it

2023-01-30 Thread marcandre . lureau
From: Marc-André Lureau The naming is more conventional in QEMU code, and allows to simplify some code. Signed-off-by: Marc-André Lureau --- include/ui/console.h | 2 +- ui/cursor.c | 3 ++- ui/dbus-listener.c | 3 +-- ui/spice-display.c | 4 ++-- ui/vnc.c | 3 +-- 5

[PATCH 10/11] ui: set cursor position upon listener registration

2023-01-30 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- ui/console.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/ui/console.c b/ui/console.c index 3fc8bf2fbc..6f87158c2d 100644 --- a/ui/console.c +++ b/ui/console.c @@ -94,6 +94,7 @@ struct QemuConsole { QemuUIInfo

[PATCH 11/11] ui/sdl: get the GL context from the window

2023-01-30 Thread marcandre . lureau
From: Marc-André Lureau There is no guarantee to have a current GL context here. The current code seems to rely on the renderer using a GL backend, and to set a current GL context. But this is not always the case, for example if the renderer backend is DirectX. This change is enough to fix

[PATCH 08/11] ui: keep current cursor with QemuConsole

2023-01-30 Thread marcandre . lureau
From: Marc-André Lureau Keeping the current cursor around is useful, not only for VNC, but for other displays. Let's move it down, see the following patches for other usages. Signed-off-by: Marc-André Lureau --- include/ui/console.h | 1 + ui/vnc.h | 1 - ui/console.c | 8

[PATCH 09/11] ui: set cursor upon listener registration

2023-01-30 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- ui/console.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ui/console.c b/ui/console.c index 4e88941165..3fc8bf2fbc 100644 --- a/ui/console.c +++ b/ui/console.c @@ -1661,6 +1661,9 @@ void

[RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

2023-01-30 Thread Thomas Huth
Testing 32-bit host OS support takes a lot of precious time during the QEMU contiguous integration tests, and considering that many OS vendors stopped shipping 32-bit variants of their OS distributions and most hardware from the past >10 years is capable of 64-bit, keeping the 32-bit support alive

Re: [PATCH] hw/usb/core: fix inconsistent ep and pid (UBS_TOKEN_SETUP)

2023-01-30 Thread Qiang Liu
Hi all, I'm sure this patch will prevent the assertion failure due to the inconsistent ep and pid (UBS_TOKEN_SETUP) ( https://lists.gnu.org/archive/html/qemu-devel/2021-06/msg07179.html). For UHCI (https://gitlab.com/qemu-project/qemu/-/issues/119) and OHCI (

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

2023-01-30 Thread Thomas Huth
On 30/01/2023 13.01, Daniel P. Berrangé wrote: On Mon, Jan 30, 2023 at 11:47:02AM +, Peter Maydell wrote: On Mon, 30 Jan 2023 at 11:44, Thomas Huth wrote: Testing 32-bit host OS support takes a lot of precious time during the QEMU contiguous integration tests, and considering that many

Re: Re: Please review a important patch abort fix setting of CPUX86State::gdt::base

2023-01-30 Thread fanwj--- via
1. "The memcpy is definitely wrong, because you're casting a guest address into a host address, which is incorrect. You have to use g2h()." There is no need to use g2h(), Because there are both guest address whether source or dest memory. refer to "linux-user/i386/cpu_loop.c"

[PATCH v5 14/20] riscv: Clean up includes

2023-01-30 Thread Markus Armbruster
Clean up includes so that qemu/osdep.h is included first in .c, and not in .h, and headers which it implies are not included manually. This commit was created with scripts/clean-includes. Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis

[PATCH v5 05/20] bsd-user: Clean up includes

2023-01-30 Thread Markus Armbruster
Clean up includes so that qemu/osdep.h is included first in .c, and not in .h, and headers which it implies are not included manually. This commit was created with scripts/clean-includes. Signed-off-by: Markus Armbruster Reviewed-by: Warner Losh Reviewed-by: Michael S. Tsirkin ---

[PATCH v5 15/20] block: Clean up includes

2023-01-30 Thread Markus Armbruster
Clean up includes so that qemu/osdep.h is included first in .c, and not in .h, and headers which it implies are not included manually. This commit was created with scripts/clean-includes. Signed-off-by: Markus Armbruster Reviewed-by: Michael S. Tsirkin Reviewed-by: Eric Blake ---

[PATCH v5 10/20] qga: Clean up includes

2023-01-30 Thread Markus Armbruster
Clean up includes so that qemu/osdep.h is included first in .c, and not in .h, and headers which it implies are not included manually. This commit was created with scripts/clean-includes. Signed-off-by: Markus Armbruster Reviewed-by: Konstantin Kostiuk Reviewed-by: Michael S. Tsirkin ---

[PATCH v2 4/9] igb: add ICR_RXDW

2023-01-30 Thread Sriram Yagnaraman
IGB uses RXDW ICR bit to indicate that rx descriptor has been written back. This is the same as RXT0 bit in older HW. Signed-off-by: Sriram Yagnaraman --- hw/net/e1000x_regs.h | 4 hw/net/igb_core.c| 28 ++-- 2 files changed, 18 insertions(+), 14 deletions(-)

Re: [PATCH 4/6] gitlab-ci.d/buildtest: Merge the --without-default-* jobs

2023-01-30 Thread Fabiano Rosas
Thomas Huth writes: > Let's safe some CI minutes by merging these two jobs. We can now > also drop "--disable-capstone" since the capstone submodule has > been removed a while ago. We should rather tes --disable-fdt now > to test a compilation without the "dtc" submodule (for this we > have to

  1   2   3   4   5   >