Re: Example output for query-vcpu-dirty-limit

2023-03-24 Thread Hyman Huang
在 2023/3/23 18:40, Markus Armbruster 写道: query-vcpu-dirty-limit's doc comment has an example, but it shows only input, no output: ## # @query-vcpu-dirty-limit: # # Returns information about virtual CPU dirty page rate limits, if any. # # Since: 7.1 # #

Re: [PATCH v4 1/2] target/riscv: separate priv from mmu_idx

2023-03-24 Thread Wu, Fei
On 3/24/2023 10:37 AM, Richard Henderson wrote: > On 3/23/23 18:20, Wu, Fei wrote: >> I lack some background here, why should tb_flags be preferred if env has >> the same info? Then for reading from tb_flags, we need to add it to >> tb_flags first. > > We read from tb_flags in translate because

Re: [PATCH v4 1/2] target/riscv: separate priv from mmu_idx

2023-03-24 Thread Richard Henderson
On 3/23/23 18:20, Wu, Fei wrote: I lack some background here, why should tb_flags be preferred if env has the same info? Then for reading from tb_flags, we need to add it to tb_flags first. We read from tb_flags in translate because that proves we've added the data to tb_flags for the TB

Re: [PATCH 1/3] docs: Add support for TPM devices over I2C bus

2023-03-24 Thread Ninad Palsule
Hello Cedric, Joel helped me to configure the device and we are able to configure tpm device on ast2600-evb. I will include this example in the documentation. # uname -a Linux ast2600-evb 6.1.15 #1 SMP Thu Mar 23 20:48:29 CDT 2023 armv7l GNU/Linux # cat /etc/os-release NAME=Buildroot

Re: [PATCH v10 9/9] KVM: Enable and expose KVM_MEM_PRIVATE

2023-03-24 Thread Xiaoyao Li
On 3/24/2023 10:10 AM, Chao Peng wrote: On Wed, Mar 22, 2023 at 05:41:31PM -0700, Isaku Yamahata wrote: On Wed, Mar 08, 2023 at 03:40:26PM +0800, Chao Peng wrote: On Wed, Mar 08, 2023 at 12:13:24AM +, Ackerley Tng wrote: Chao Peng writes: On Sat, Jan 14, 2023 at 12:01:01AM +,

[PATCH v3 2/3] TPM TIS: Add support for TPM devices over I2C bus

2023-03-24 Thread Ninad Palsule
Qemu already supports devices attached to ISA and sysbus. This drop adds support for the I2C bus attached TPM devices. This commit includes changes for the common code. - Added support for the new checksum registers which are required for the I2C support. The checksum calculation is handled in

[PATCH v5 1/2] target/riscv: separate priv from mmu_idx

2023-03-24 Thread Fei Wu
Currently it's assumed the 2 low bits of mmu_idx map to privilege mode, this assumption won't last as we are about to add more mmu_idx. Here an individual priv field is added into TB_FLAGS. Signed-off-by: Fei Wu --- target/riscv/cpu.h | 2 +-

[PATCH v5 0/2] target/riscv: reduce MSTATUS_SUM overhead

2023-03-24 Thread Fei Wu
v4 -> v5: * add priv to tb_flags v3 -> v4: * seperate priv from mmu_idx * use index 2 for S+SUM mmu_idx * no tlb_flush for MPRV / MPP changes Fei Wu (2): target/riscv: separate priv from mmu_idx target/riscv: reduce overhead of MSTATUS_SUM change target/riscv/cpu.h

Re: [PATCH v15 4/4] vhost-vdpa: Add support for vIOMMU.

2023-03-24 Thread Jason Wang
On Fri, Mar 24, 2023 at 11:00 AM Cindy Lu wrote: > > On Fri, Mar 24, 2023 at 10:49 AM Jason Wang wrote: > > > > On Thu, Mar 23, 2023 at 4:41 PM Cindy Lu wrote: > > > > > > On Thu, Mar 23, 2023 at 11:47 AM Jason Wang wrote: > > > > > > > > On Tue, Mar 21, 2023 at 10:24 PM Cindy Lu wrote: > > >

[PATCH v3 3/3] New I2C: Add support for TPM devices over I2C bus

2023-03-24 Thread Ninad Palsule
Qemu already supports devices attached to ISA and sysbus. This drop adds support for the I2C bus attached TPM devices. I2C model only supports TPM2 protocol. This commit includes changes for the common code. - Added I2C emulation model. Logic was added in the model to temporarily cache the data

[PATCH v3 1/3] docs: Add support for TPM devices over I2C bus

2023-03-24 Thread Ninad Palsule
This is a documentation change for I2C TPM device support. Qemu already supports devices attached to ISA and sysbus. This drop adds support for the I2C bus attached TPM devices. Signed-off-by: Ninad Palsule --- V2: Incorporated Stephen's review comments - Added example in the document. ---

Re: [PATCH for 8.0] hw/net/net_tx_pkt: Align l3_hdr

2023-03-24 Thread Jason Wang
On Thu, Mar 23, 2023 at 4:53 PM Akihiko Odaki wrote: > > Hi Jason, > > I have sent some patches for igb and packet abstractions. They are fixes > intended to be included in 8.0 so please have a look at them. I gave some comments and If possible please post them with a series then Sriram can

Re: [PATCH v10 0/9] KVM: mm: fd-based approach for supporting KVM

2023-03-24 Thread Chao Peng
On Wed, Mar 22, 2023 at 08:27:37PM -0500, Michael Roth wrote: > On Tue, Feb 21, 2023 at 08:11:35PM +0800, Chao Peng wrote: > > > Hi Sean, > > > > > > We've rebased the SEV+SNP support onto your updated UPM base support > > > tree and things seem to be working okay, but we needed some fixups on >

Re: [PATCH 1/3] docs: Add support for TPM devices over I2C bus

2023-03-24 Thread Cédric Le Goater
On 3/24/23 06:11, Ninad Palsule wrote: Hello Cedric, Joel helped me to configure the device and we are able to configure tpm device on ast2600-evb. I will include this example in the documentation. # uname -a Linux ast2600-evb 6.1.15 #1 SMP Thu Mar 23 20:48:29 CDT 2023 armv7l GNU/Linux # cat

Re: [PATCH] scsi/lsi53c895a: restrict DMA engine to memory regions (CVE-2023-0330)

2023-03-24 Thread Alexander Bulekov
On 230324 1200, Mauro Matteo Cascella wrote: > On Fri, Mar 17, 2023 at 10:59 PM Philippe Mathieu-Daudé > wrote: > > > > On 17/3/23 19:18, Karl Heubaum wrote: > > > Did this CVE fix fall in the cracks during the QEMU 8.0 merge window? > > > > The patch isn't reviewed, and apparently almost no

[PATCH 1/8] target/riscv: Remove redundant call to riscv_cpu_virt_enabled

2023-03-24 Thread Weiwei Li
The assignment is done under the condition riscv_cpu_virt_enabled()=true. Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- target/riscv/cpu_helper.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c index

[PATCH v18 3/8] block: add block layer APIs resembling Linux ZonedBlockDevice ioctls

2023-03-24 Thread Sam Li
Add zoned device option to host_device BlockDriver. It will be presented only for zoned host block devices. By adding zone management operations to the host_block_device BlockDriver, users can use the new block layer APIs including Report Zone and four zone management operations (open, close,

[PATCH 0/4] Fix tb flags use

2023-03-24 Thread LIU Zhiwei
We have found two places that misuse the fields from env. The patch set fixes two of them. The first is virt_enabled. And another is vstart. And for easy moving the tb flag fields, I also make the FS and VS in tb flags positions changable. LIU Zhiwei (4): target/riscv: Extract virt enabled

Re: [PATCH 2/4] target/riscv: Add a general status enum for extensions

2023-03-24 Thread LIU Zhiwei
On 2023/3/24 20:53, liweiwei wrote: On 2023/3/24 13:59, LIU Zhiwei wrote: The pointer masking is the only extension that directly use status. The vector or float extension uses the status in an indirect way. Replace the pointer masking extension special status fields with the general

[PULL 7/8] cirrus-ci: Remove MSYS2 jobs duplicated with gitlab-ci

2023-03-24 Thread Thomas Huth
From: Philippe Mathieu-Daudé - Various developers are reluctant to git Cirrus-CI the permissions requested to access their GitHub account. - When we use the cirrus-run script to trigger Cirrus-CI job from GitLab-CI, the GitLab-CI job is restricted to a 1h timeout (often not enough). -

Re: [PATCH v4 06/10] migration: Introduce dirty-limit capability

2023-03-24 Thread Markus Armbruster
Hyman Huang writes: > 在 2023/3/24 20:11, Markus Armbruster 写道: >> huang...@chinatelecom.cn writes: >> >>> From: Hyman Huang(黄勇) >>> >>> Introduce migration dirty-limit capability, which can >>> be turned on before live migration and limit dirty >>> page rate durty live migration. >>> >>>

Re: [PATCH v3 1/1] util/async-teardown: wire up query-command-line-options

2023-03-24 Thread Thomas Huth
On 24/03/2023 18.45, Claudio Imbrenda wrote: The recently introduced -async-teardown commandline option was not wired up properly and did not show up in the output of the QMP command query-command-line-options. This means that libvirt will have no way to discover whether the feature is

Re: [PATCH v2] hw/ide: replace TABs with space

2023-03-24 Thread Thomas Huth
On 15/03/2023 05.32, Yeqi Fu wrote: Bring the block files in line with the QEMU coding style, with spaces for indentation. This patch partially resolves the issue 371. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/371 Signed-off-by: Yeqi Fu --- hw/ide/cmd646.c | 28 +--

[PATCH v18 0/8] Add support for zoned device

2023-03-24 Thread Sam Li
Zoned Block Devices (ZBDs) devide the LBA space to block regions called zones that are larger than the LBA size. It can only allow sequential writes, which reduces write amplification in SSD, leading to higher throughput and increased capacity. More details about ZBDs can be found at:

Re: [PATCH 4/4] target/riscv: Add a tb flags field for vstart

2023-03-24 Thread liweiwei
On 2023/3/24 13:59, LIU Zhiwei wrote: Once we mistook the vstart directly from the env->vstart. As env->vstart is not a constant, we should record it in the tb flags if we want to use it in translation. Reported-by: Richard Henderson Signed-off-by: LIU Zhiwei --- Reviewed-by: Weiwei Li

Re: [PATCH 2/4] target/riscv: Add a general status enum for extensions

2023-03-24 Thread liweiwei
On 2023/3/24 13:59, LIU Zhiwei wrote: The pointer masking is the only extension that directly use status. The vector or float extension uses the status in an indirect way. Replace the pointer masking extension special status fields with the general status. Signed-off-by: LIU Zhiwei ---

[PATCH 6/8] target/riscv: Fix format for indentation

2023-03-24 Thread Weiwei Li
Fix identation problems, and try to use the same indentation strategy in the same file. Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- target/riscv/arch_dump.c| 4 +- target/riscv/cpu.c | 4 +- target/riscv/cpu_helper.c | 15

Re: [PULL 02/10] pci-bridge/cxl_downstream: Add a CXL switch downstream port

2023-03-24 Thread Thomas Huth
On 07/12/2022 14.26, Thomas Huth wrote: On 07/12/2022 14.21, Jonathan Cameron wrote: On Mon, 05 Dec 2022 14:59:39 + Alex Bennée wrote: Jonathan Cameron via writes: On Mon, 5 Dec 2022 10:54:03 + Jonathan Cameron via wrote: On Sun, 4 Dec 2022 08:23:55 +0100 Thomas Huth wrote: On

Re: [PATCH] scsi/lsi53c895a: restrict DMA engine to memory regions (CVE-2023-0330)

2023-03-24 Thread Mauro Matteo Cascella
On Fri, Mar 17, 2023 at 10:59 PM Philippe Mathieu-Daudé wrote: > > On 17/3/23 19:18, Karl Heubaum wrote: > > Did this CVE fix fall in the cracks during the QEMU 8.0 merge window? > > The patch isn't reviewed, and apparently almost no active contributor > understand this device enough to be sure

[PATCH v18 7/8] block: add some trace events for new block layer APIs

2023-03-24 Thread Sam Li
Signed-off-by: Sam Li Reviewed-by: Stefan Hajnoczi Reviewed-by: Dmitry Fomichev --- block/file-posix.c | 3 +++ block/trace-events | 2 ++ 2 files changed, 5 insertions(+) diff --git a/block/file-posix.c b/block/file-posix.c index 5fa80933c9..65efe5147e 100644 --- a/block/file-posix.c +++

Re: Example output for query-vcpu-dirty-limit

2023-03-24 Thread Markus Armbruster
This will do nicely, thanks!

Re: [PATCH v11 4/5] target/riscv: smstateen check for fcsr

2023-03-24 Thread liweiwei
On 2022/11/21 07:35, Alistair Francis wrote: On Sun, Oct 16, 2022 at 11:09 PM Mayuresh Chitale wrote: If smstateen is implemented and sstateen0.fcsr is clear then the floating point operations must return illegal instruction exception or virtual instruction trap, if relevant. Signed-off-by:

Re: [PATCH v3 3/3] New I2C: Add support for TPM devices over I2C bus

2023-03-24 Thread Stefan Berger
On 3/23/23 23:02, Ninad Palsule wrote: Qemu already supports devices attached to ISA and sysbus. This drop adds support for the I2C bus attached TPM devices. I2C model only supports TPM2 protocol. This commit includes changes for the common code. - Added I2C emulation model. Logic was added

[PATCH 3/4] target/riscv: Encode the FS and VS on a normal way for tb flags

2023-03-24 Thread LIU Zhiwei
Reuse the MSTATUS_FS and MSTATUS_VS for the tb flags positions is not a normal way. It will make us change the tb flags layout difficult. And even worse, if we want to keep tb flags for a same extension togather without a hole. Signed-off-by: LIU Zhiwei --- target/riscv/cpu.h

[PATCH 2/4] target/riscv: Add a general status enum for extensions

2023-03-24 Thread LIU Zhiwei
The pointer masking is the only extension that directly use status. The vector or float extension uses the status in an indirect way. Replace the pointer masking extension special status fields with the general status. Signed-off-by: LIU Zhiwei --- target/riscv/cpu.c | 2 +-

[PATCH v18 5/8] config: add check to block layer

2023-03-24 Thread Sam Li
Putting zoned/non-zoned BlockDrivers on top of each other is not allowed. Signed-off-by: Sam Li Reviewed-by: Stefan Hajnoczi Reviewed-by: Hannes Reinecke Reviewed-by: Dmitry Fomichev --- block.c | 19 +++ block/file-posix.c | 12

Re: [PATCH 3/3] New I2C: Add support for TPM devices over I2C bus

2023-03-24 Thread Cédric Le Goater
On 3/23/23 23:32, Ninad Palsule wrote: On 3/23/23 3:37 AM, Cédric Le Goater wrote: On 3/23/23 04:01, Ninad Palsule wrote: Qemu already supports devices attached to ISA and sysbus. This drop adds support for the I2C bus attached TPM devices. I2C model only supports TPM2 protocol. This commit

Re: [PATCH 3/6] target/ppc: Fix instruction loading endianness in alignment interrupt

2023-03-24 Thread Fabiano Rosas
Hi Nick, > powerpc ifetch endianness depends on MSR[LE] so it has to byteswap > after cpu_ldl_code(). This corrects DSISR bits in alignment > interrupts when running in little endian mode. > Just a thought, we have these tests that perhaps could have caught this:

[PATCH 1/4] target/riscv: Extract virt enabled state from tb flags

2023-03-24 Thread LIU Zhiwei
Virt enabled state is not a constant. So we should put it into tb flags. Thus we can use it like a constant condition at translation phase. Reported-by: Richard Henderson Signed-off-by: LIU Zhiwei --- target/riscv/cpu.h| 2 ++ target/riscv/cpu_helper.c | 2 ++

Re: [PATCH for-8.1 v4 15/25] target/riscv/cpu.c: split RVG code from validate_set_extensions()

2023-03-24 Thread liweiwei
On 2023/3/23 06:19, Daniel Henrique Barboza wrote: We can set all RVG related extensions during realize time, before validate_set_extensions() itself. Put it in a separated function so the validate function already uses the updated state. Note that we're setting both cfg->ext_N and

[RFC PATCH] tests/avocado: Test Xen guest support under KVM

2023-03-24 Thread Alex Bennée
From: David Woodhouse Exercise guests with a few different modes for interrupt delivery. In particular we want to cover: • Xen event channel delivery via GSI to the I/O APIC • Xen event channel delivery via GSI to the i8259 PIC • MSIs routed to PIRQ event channels • GSIs routed to PIRQ

Re: [PATCH 4/4] target/riscv: Add a tb flags field for vstart

2023-03-24 Thread Richard Henderson
On 3/23/23 22:59, LIU Zhiwei wrote: Once we mistook the vstart directly from the env->vstart. As env->vstart is not a constant, we should record it in the tb flags if we want to use it in translation. Reported-by: Richard Henderson Signed-off-by: LIU Zhiwei --- target/riscv/cpu.h

[PATCH v9 5/5] docs/zoned-storage:add zoned emulation use case

2023-03-24 Thread Sam Li
Add the documentation about the example of using virtio-blk driver to pass the zoned block devices through to the guest. Signed-off-by: Sam Li --- docs/devel/zoned-storage.rst | 17 + 1 file changed, 17 insertions(+) diff --git a/docs/devel/zoned-storage.rst

[PATCH v18 6/8] qemu-iotests: test new zone operations

2023-03-24 Thread Sam Li
The new block layer APIs of zoned block devices can be tested by: $ tests/qemu-iotests/check zoned Run each zone operation on a newly created null_blk device and see whether it outputs the same zone information. Signed-off-by: Sam Li Reviewed-by: Stefan Hajnoczi ---

Re: [qemu-web PATCH v2] add post about plans for Python venvs

2023-03-24 Thread Thomas Huth
On 23/03/2023 09.40, Paolo Bonzini wrote: This post details the design that John Snow and I are planning for QEMU 8.1. The purpose is to detect possible inconsistencies in the build environment, that could happen on enterprise distros once Python 3.6 support is dropped. Signed-off-by: Paolo

Re: [PATCH v4 1/2] target/riscv: separate priv from mmu_idx

2023-03-24 Thread Wu, Fei
On 3/24/2023 9:02 AM, Wu, Fei wrote: > On 3/23/2023 11:53 PM, Richard Henderson wrote: >> On 3/22/23 19:44, Fei Wu wrote: >>> Currently it's assumed the 2 low bits of mmu_idx map to privilege mode, >>> this assumption won't last as we are about to add more mmu_idx. >>> >>> Signed-off-by: Fei Wu

Re: [PATCH v9 5/5] docs/zoned-storage:add zoned emulation use case

2023-03-24 Thread Sam Li
Sam Li 于2023年3月24日周五 18:54写道: > > Add the documentation about the example of using virtio-blk driver > to pass the zoned block devices through to the guest. > > Signed-off-by: Sam Li > --- > docs/devel/zoned-storage.rst | 17 + > 1 file changed, 17 insertions(+) > > diff --git

[PATCH v9 0/5] Add zoned storage emulation to virtio-blk driver

2023-03-24 Thread Sam Li
This patch adds zoned storage emulation to the virtio-blk driver. The patch implements the virtio-blk ZBD support standardization that is recently accepted by virtio-spec. The link to related commit is at https://github.com/oasis-tcs/virtio-spec/commit/b4e8efa0fa6c8d844328090ad15db65af8d7d981

[PATCH v18 5/8] config: add check to block layer

2023-03-24 Thread Sam Li
Putting zoned/non-zoned BlockDrivers on top of each other is not allowed. Signed-off-by: Sam Li Reviewed-by: Stefan Hajnoczi Reviewed-by: Hannes Reinecke Reviewed-by: Dmitry Fomichev --- block.c | 19 +++ block/file-posix.c | 12

Re: [PATCH] hw/xen: Simplify emulated Xen platform init

2023-03-24 Thread Paul Durrant
On 10/03/2023 10:54, David Woodhouse wrote: From: David Woodhouse I initially put the basic platform init (overlay pages, grant tables, event channels) into mc->kvm_type because that was the earliest place that could sensibly test for xen_mode==XEN_EMULATE. The intent was to do this early

Re: [PATCH for-8.1 v4 18/25] target/riscv: error out on priv failure for RVH

2023-03-24 Thread liweiwei
On 2023/3/23 06:19, Daniel Henrique Barboza wrote: riscv_cpu_disable_priv_spec_isa_exts(), at the end of riscv_cpu_validate_set_extensions(), will disable cpu->cfg.ext_h and cpu->cfg.ext_v if priv_ver check fails. This check can be done in riscv_cpu_validate_misa_ext(). The difference here is

[PULL 0/8] Misc patches for QEMU 8.0-rc2

2023-03-24 Thread Thomas Huth
The following changes since commit 60ca584b8af0de525656f959991a440f8c191f12: Merge tag 'pull-for-8.0-220323-1' of https://gitlab.com/stsquad/qemu into staging (2023-03-22 17:58:12 +) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags/pull-request-2023-03-24

[PATCH v9 3/5] block: add accounting for zone append operation

2023-03-24 Thread Sam Li
Taking account of the new zone append write operation for zoned devices, BLOCK_ACCT_ZONE_APPEND enum is introduced as other I/O request type (read, write, flush). Signed-off-by: Sam Li --- block/qapi-sysemu.c| 11 ++ block/qapi.c | 18 ++ hw/block/virtio-blk.c

Re: [PATCH] qtests: avoid printing comments before g_test_init()

2023-03-24 Thread Thomas Huth
On 23/03/2023 19.31, Juan Quintela wrote: Daniel P. Berrangé wrote: The TAP protocol version line must be the first thing printed on stdout. The migration test failed that requirement in certain scenarios: # Skipping test: Userfault not available (builtdtime) TAP version 13 # random

[PULL 2/2] hw/xenpv: Initialize Xen backend operations

2023-03-24 Thread Anthony PERARD via
From: David Woodhouse As the Xen backend operations were abstracted out into a function table to allow for internally emulated Xen support, we missed the xen_init_pv() code path which also needs to install the operations for the true Xen libraries. Add the missing call to

Adding default config options to the tuxrun baseline kernels and enabling sshd

2023-03-24 Thread Alex Bennée
Hi guys, I've been working with David on adding testing for the new KVM Xen guest functionality and had a couple of questions. His original test is based on fedora and is fairly comprehensive: https://git.infradead.org/users/dwmw2/qemu.git/commitdiff/48f78f9bb860dca446e20d6ed8db3aa9d857505f

[qemu-web PATCH] fix cases where the left column becomes too large

2023-03-24 Thread Paolo Bonzini
On the blogs page, long lines under a tag will make the left column overlap the sidebar. Fix it in the CSS. Signed-off-by: Paolo Bonzini --- _includes/assets.html| 2 +- assets/css/skel-noscript.css | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH v18 4/8] raw-format: add zone operations to pass through requests

2023-03-24 Thread Sam Li
raw-format driver usually sits on top of file-posix driver. It needs to pass through requests of zone commands. Signed-off-by: Sam Li Reviewed-by: Stefan Hajnoczi Reviewed-by: Damien Le Moal Reviewed-by: Hannes Reinecke Reviewed-by: Dmitry Fomichev --- block/raw-format.c | 17

[PATCH for 8.0 4/4] hw/net/net_tx_pkt: Align l3_hdr

2023-03-24 Thread Akihiko Odaki
Align the l3_hdr member of NetTxPkt by defining it as a union of ip_header, ip6_header, and an array of octets. Fixes: e263cd49c7 ("Packet abstraction for VMWARE network devices") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1544 Signed-off-by: Akihiko Odaki --- hw/net/net_tx_pkt.c |

Re: [PATCH] ui/spice: fix compilation on win32

2023-03-24 Thread Thomas Huth
On 22/03/2023 08.52, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau qemu_close_to_socket() renaming left-over. Fixes: https://gitlab.com/qemu-project/qemu/-/issues/1553 Fixes: commit e40283d9a ("ui/spice: fix SOCKET handling regression") Signed-off-by: Marc-André Lureau ---

Re: [PULL v2 18/18] ui/dbus: restrict opengl to gbm-enabled config

2023-03-24 Thread Fabiano Rosas
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > We can enable EGL later for non-GBM hosts. > > Signed-off-by: Marc-André Lureau > Reviewed-by: Daniel P. Berrangé > --- > ui/dbus-listener.c | 10 +- > ui/dbus.c | 12 +++- > 2 files changed, 16

Re: [PULL 0/1] xen queue

2023-03-24 Thread Anthony PERARD via
On Thu, Mar 23, 2023 at 10:01:59AM +, Anthony PERARD wrote: > The following changes since commit 60ca584b8af0de525656f959991a440f8c191f12: > > Merge tag 'pull-for-8.0-220323-1' of https://gitlab.com/stsquad/qemu into > staging (2023-03-22 17:58:12 +) > > are available in the Git

[PATCH 7/8] target/riscv: Fix format for comments

2023-03-24 Thread Weiwei Li
Fix formats for multi-lines comments. Add spaces around single line comments(after "/*" and before "*/"). Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- target/riscv/arch_dump.c| 3 +- target/riscv/cpu.c | 2 +- target/riscv/cpu.h

Re: [PULL 0/1] xen queue

2023-03-24 Thread Peter Maydell
On Fri, 24 Mar 2023 at 13:47, Anthony PERARD wrote: > > On Thu, Mar 23, 2023 at 10:01:59AM +, Anthony PERARD wrote: > > The following changes since commit 60ca584b8af0de525656f959991a440f8c191f12: > > > > Merge tag 'pull-for-8.0-220323-1' of https://gitlab.com/stsquad/qemu into > > staging

Re: [PATCH v18 0/8] Add support for zoned device

2023-03-24 Thread Philippe Mathieu-Daudé
Hi Sam, On 24/3/23 10:05, Sam Li wrote: Zoned Block Devices (ZBDs) devide the LBA space to block regions called zones that are larger than the LBA size. It can only allow sequential writes, which reduces write amplification in SSD, leading to higher throughput and increased capacity. More

[PATCH 1/1] nbd/server: push pending frames after sending reply

2023-03-24 Thread Florian Westphal
qemu-nbd doesn't set TCP_NODELAY on the tcp socket. Kernel waits for more data and avoids transmission of small packets. Without TLS this is barely noticeable, but with TLS this really shows. Booting a VM via qemu-nbd on localhost (with tls) takes more than 2 minutes on my system. tcpdump shows

Re: [PATCH v17 6/8] qemu-iotests: test new zone operations

2023-03-24 Thread Sam Li
Stefan Hajnoczi 于2023年3月24日周五 03:31写道: > > On Thu, Mar 23, 2023 at 01:08:32PM +0800, Sam Li wrote: > > The new block layer APIs of zoned block devices can be tested by: > > $ tests/qemu-iotests/check zoned > > Run each zone operation on a newly created null_blk device > > and see whether it

Re: [PATCH 4/6] target/ppc: Alignment faults do not set DSISR in ISA v3.0 onward

2023-03-24 Thread Fabiano Rosas
Nicholas Piggin writes: > This optional behavior was removed from the ISA in v3.0, see > Summary of Changes preface: > > Data Storage Interrupt Status Register for Alignment Interrupt: > Simplifies the Alignment interrupt by remov- ing the Data Storage > Interrupt Status Register (DSISR)

Re: [PATCH for-8.1 v4 22/25] target/riscv: use misa_ext val in riscv_cpu_validate_extensions()

2023-03-24 Thread liweiwei
On 2023/3/23 06:20, Daniel Henrique Barboza wrote: Similar to what we did with riscv_cpu_validate_misa_ext(), let's read all MISA bits from a misa_ext val instead of reading from the cpu->cfg object. This will allow write_misa() to use riscv_cpu_validate_extensions(). Signed-off-by: Daniel

Re: [PATCH 1/4] target/riscv: Extract virt enabled state from tb flags

2023-03-24 Thread liweiwei
On 2023/3/24 13:59, LIU Zhiwei wrote: Virt enabled state is not a constant. So we should put it into tb flags. Thus we can use it like a constant condition at translation phase. Reported-by: Richard Henderson Signed-off-by: LIU Zhiwei --- Reviewed-by: Weiwei Li Weiwei L

Re: [RESEND PATCH 2/2] hw/cxl: Fix incorrect reset of commit and associated clearing of committed.

2023-03-24 Thread Jonathan Cameron via
On Wed, 22 Mar 2023 16:21:26 + Fan Ni wrote: > On Wed, Mar 22, 2023 at 10:33:00AM +, Jonathan Cameron wrote: > > The hardware clearing the commit bit is not spec compliant. > > Clearing of committed bit when commit is cleared is not specifically > > stated in the CXL spec, but is the

Re: [PATCH 1/4] target/riscv: Extract virt enabled state from tb flags

2023-03-24 Thread Richard Henderson
On 3/23/23 22:59, LIU Zhiwei wrote: Virt enabled state is not a constant. So we should put it into tb flags. Thus we can use it like a constant condition at translation phase. Reported-by: Richard Henderson Signed-off-by: LIU Zhiwei --- target/riscv/cpu.h| 2 ++

Re: qapi: [RFC] Doc comment convention for @arg: sections

2023-03-24 Thread Peter Maydell
On Fri, 24 Mar 2023 at 12:05, Markus Armbruster wrote: > > Peter Maydell writes: > > > On Thu, 23 Mar 2023 at 14:48, Markus Armbruster wrote: > >> > >> The QAPI schema doc comment language provides special syntax for command > >> and event arguments, struct and union members, alternate

Re: [PATCH 5/8] target/riscv: Remove redundant parentheses

2023-03-24 Thread Richard Henderson
On 3/24/23 05:38, Weiwei Li wrote: Remove redundant parentheses in get_physical_address. Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- target/riscv/cpu_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [PATCH 4/8] target/riscv: Remove check on RVH for riscv_cpu_set_virt_enabled

2023-03-24 Thread Richard Henderson
On 3/24/23 05:38, Weiwei Li wrote: In current implementation, riscv_cpu_set_virt_enabled is only called when RVH is enabled. Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- target/riscv/cpu_helper.c | 4 1 file changed, 4 deletions(-) Perhaps assert, or assert under

[PATCH v9 1/5] include: update virtio_blk headers to v6.3-rc1

2023-03-24 Thread Sam Li
Use scripts/update-linux-headers.sh to update headers to 6.3-rc1. Signed-off-by: Sam Li Reviewed-by: Stefan Hajnoczi Reviewed-by: Dmitry Fomichev --- include/standard-headers/drm/drm_fourcc.h| 12 +++ include/standard-headers/linux/ethtool.h | 48 -

Re: qapi: [RFC] Doc comment convention for @arg: sections

2023-03-24 Thread Markus Armbruster
Peter Maydell writes: > On Fri, 24 Mar 2023 at 12:05, Markus Armbruster wrote: >> >> Peter Maydell writes: >> >> > On Thu, 23 Mar 2023 at 14:48, Markus Armbruster wrote: >> >> >> >> The QAPI schema doc comment language provides special syntax for command >> >> and event arguments, struct and

Re: [PATCH for-8.1 v4 24/25] target/riscv: update cpu->cfg misa bits in commit_cpu_cfg()

2023-03-24 Thread liweiwei
On 2023/3/23 06:20, Daniel Henrique Barboza wrote: write_misa() is able to use the same validation workflow riscv_cpu_realize() uses. But it's still not capable of updating cpu->cfg misa props yet. We have no way of blocking future (and current) code from checking env->misa_ext (via

[PULL 8/8] Revert "docs/about/deprecated: Deprecate 32-bit arm hosts for system emulation"

2023-03-24 Thread Thomas Huth
This reverts commit 1d0a8eba38c028ea02c6e0b68f0a4c9a3cbf. The commit made the wrong assumption that 64-bit distros are most common these days on arm devices, but as Liviu Ionescu pointed out, the recommended OS for the very popular Raspberry Pi boards is still the 32-bit variant, and thus

[PULL 1/2] accel/xen: Fix DM state change notification in dm_restrict mode

2023-03-24 Thread Anthony PERARD via
From: David Woodhouse When dm_restrict is set, QEMU isn't permitted to update the XenStore node to indicate its running status. Previously, the xs_write() call would fail but the failure was ignored. However, in refactoring to allow for emulated XenStore operations, a new call to xs_open() was

Re: [PATCH] Change the default for Mixed declarations.

2023-03-24 Thread Alex Bennée
Daniel P. Berrangé writes: > On Tue, Feb 14, 2023 at 05:07:38PM +0100, Juan Quintela wrote: >> Hi >> >> I want to enter a discussion about changing the default of the style >> guide. >> >> There are several reasons for that: >> - they exist since C99 (i.e. all supported compilers support

Re: [PATCH v3 3/3] New I2C: Add support for TPM devices over I2C bus

2023-03-24 Thread Cédric Le Goater
Hello Ninad, On 3/24/23 04:02, Ninad Palsule wrote: Qemu already supports devices attached to ISA and sysbus. This drop adds support for the I2C bus attached TPM devices. I2C model only supports TPM2 protocol. This commit includes changes for the common code. - Added I2C emulation model. Logic

[PULL 5/8] ui/spice: fix compilation on win32

2023-03-24 Thread Thomas Huth
From: Marc-André Lureau qemu_close_to_socket() renaming left-over. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1553 Fixes: commit e40283d9a ("ui/spice: fix SOCKET handling regression") Reported-by: Jintao Yin Signed-off-by: Marc-André Lureau Message-Id:

Re: [PATCH v3 2/3] TPM TIS: Add support for TPM devices over I2C bus

2023-03-24 Thread Stefan Berger
On 3/23/23 23:02, Ninad Palsule wrote: Qemu already supports devices attached to ISA and sysbus. This drop adds support for the I2C bus attached TPM devices. This commit includes changes for the common code. - Added support for the new checksum registers which are required for the I2C

Re: [PATCH for-8.1 v4 23/25] target/riscv: rework write_misa()

2023-03-24 Thread liweiwei
On 2023/3/23 06:20, Daniel Henrique Barboza wrote: write_misa() must use as much common logic as possible. We want to open code just the bits that are exclusive to the CSR write operation and TCG internals. Rewrite write_misa() to work as follows: - mask the write using misa_ext_mask to

[PATCH v9 4/5] virtio-blk: add some trace events for zoned emulation

2023-03-24 Thread Sam Li
Signed-off-by: Sam Li Reviewed-by: Stefan Hajnoczi --- hw/block/trace-events | 7 +++ hw/block/virtio-blk.c | 12 2 files changed, 19 insertions(+) diff --git a/hw/block/trace-events b/hw/block/trace-events index 2c45a62bd5..34be8b9135 100644 --- a/hw/block/trace-events +++

[PULL 1/8] hw/ide: replace TABs with space

2023-03-24 Thread Thomas Huth
From: Yeqi Fu Bring the block files in line with the QEMU coding style, with spaces for indentation. This patch partially resolves the issue 371. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/371 Signed-off-by: Yeqi Fu Message-Id: <20230315043229.62100-1-fufuyqqq...@gmail.com>

Re: [PATCH] Change the default for Mixed declarations.

2023-03-24 Thread Philippe Mathieu-Daudé
On 23/3/23 20:00, Daniel P. Berrangé wrote: On Tue, Feb 14, 2023 at 05:07:38PM +0100, Juan Quintela wrote: Hi I want to enter a discussion about changing the default of the style guide. There are several reasons for that: - they exist since C99 (i.e. all supported compilers support them) -

Re: [PATCH v2 2/4] target/riscv: Add a general status enum for extensions

2023-03-24 Thread Richard Henderson
On 3/24/23 07:30, LIU Zhiwei wrote: The pointer masking is the only extension that directly use status. The vector or float extension uses the status in an indirect way. Replace the pointer masking extension special status fields with the general status. Signed-off-by: LIU Zhiwei --- v1->v2:

Re: [PATCH v2 3/4] target/riscv: Encode the FS and VS on a normal way for tb flags

2023-03-24 Thread Richard Henderson
On 3/24/23 07:30, LIU Zhiwei wrote: Reuse the MSTATUS_FS and MSTATUS_VS for the tb flags positions is not a normal way. It will make it hard to change the tb flags layout. And even worse, if we want to keep tb flags for a same extension togather without a hole. Signed-off-by: LIU Zhiwei

Re: [PATCH v2 4/4] target/riscv: Add a tb flags field for vstart

2023-03-24 Thread Richard Henderson
On 3/24/23 07:30, LIU Zhiwei wrote: Once we mistook the vstart directly from the env->vstart. As env->vstart is not a constant, we should record it in the tb flags if we want to use it in translation. Reported-by: Richard Henderson Signed-off-by: LIU Zhiwei Reviewed-by: Weiwei Li ---

Re: Adding default config options to the tuxrun baseline kernels and enabling sshd

2023-03-24 Thread Alex Bennée
Remi Duraffort writes: > Hello Alex, > > Le ven. 24 mars 2023 à 12:02, Alex Bennée a écrit : > > Hi guys, > > I've been working with David on adding testing for the new KVM Xen guest > functionality and had a couple of questions. His original test is based > on fedora and is fairly

Re: [PATCH] qtests: avoid printing comments before g_test_init()

2023-03-24 Thread Juan Quintela
Thomas Huth wrote: > On 23/03/2023 19.31, Juan Quintela wrote: >> Daniel P. Berrangé wrote: >>> The TAP protocol version line must be the first thing printed on >>> stdout. The migration test failed that requirement in certain >>> scenarios: >>> >>># Skipping test: Userfault not available

Re: [PATCH v5 1/2] target/riscv: separate priv from mmu_idx

2023-03-24 Thread Richard Henderson
On 3/23/23 22:41, Fei Wu wrote: @@ -762,7 +764,7 @@ static int get_physical_address(CPURISCVState *env, hwaddr *physical, * (riscv_cpu_do_interrupt) is correct */ MemTxResult res; MemTxAttrs attrs = MEMTXATTRS_UNSPECIFIED; -int mode = mmu_idx & TB_FLAGS_PRIV_MMU_MASK; +

Re: [PATCH for 8.0] igb: Fix DMA requester specification for Tx packet

2023-03-24 Thread Jason Wang
On Thu, Mar 16, 2023 at 8:29 PM Akihiko Odaki wrote: > > igb used to specify the PF as DMA requester when reading Tx packets. > This made Tx requests from VFs to be performed on the address space of > the PF, defeating the purpose of SR-IOV. Add some logic to change the > requester depending on

Re: [RFC QEMU PATCH 08/18] virtio-gpu: Initialize Venus

2023-03-24 Thread Huang Rui
On Thu, Mar 16, 2023 at 07:14:47AM +0800, Dmitry Osipenko wrote: > On 3/13/23 18:55, Huang Rui wrote: > > On Mon, Mar 13, 2023 at 01:51:03AM +0800, Dmitry Osipenko wrote: > >> On 3/12/23 12:22, Huang Rui wrote: > >>> From: Antonio Caggiano > >>> > >>> Request Venus when initializing VirGL. > >>>

Re: [PATCH v3 3/3] New I2C: Add support for TPM devices over I2C bus

2023-03-24 Thread Stefan Berger
On 3/24/23 04:24, Cédric Le Goater wrote: Hello Ninad, + +/* + * Convert little endian byte stream into local formated + * unsigned integer + */ +static inline uint32_t tpm_i2c_le_bytes_to_uint(TPMStateI2C *i2cst) +{ +    uint32_t data = 0; +    int  i; + +    assert(i2cst->offset <=

[PATCH 0/8] target/riscv: Simplification for RVH related check and code style fix

2023-03-24 Thread Weiwei Li
This patchset tries to simplify the RVH related check and fix some code style problems, such as problems for indentation, multi-line comments and lines with over 80 characters. The port is available here: https://github.com/plctlab/plct-qemu/tree/plct-cleanup-upstream Weiwei Li (8):

[PATCH 4/8] target/riscv: Remove check on RVH for riscv_cpu_set_virt_enabled

2023-03-24 Thread Weiwei Li
In current implementation, riscv_cpu_set_virt_enabled is only called when RVH is enabled. Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- target/riscv/cpu_helper.c | 4 1 file changed, 4 deletions(-) diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c index

[PATCH 5/8] target/riscv: Remove redundant parentheses

2023-03-24 Thread Weiwei Li
Remove redundant parentheses in get_physical_address. Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- target/riscv/cpu_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c index 3862e7b677..de2d4a8c1d

  1   2   >