[PATCH v2 46/90] target/sparc: Split out ldst functions with asi pre-computed

2023-10-17 Thread Richard Henderson
As an intermediate step in decodetree conversion, create new functions passing in DisasASI and not insn. Signed-off-by: Richard Henderson --- target/sparc/translate.c | 215 ++- 1 file changed, 123 insertions(+), 92 deletions(-) diff --git

[PATCH v2 40/90] target/sparc: Convert remaining v8 coproc insns to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 11 +++ target/sparc/translate.c | 32 ++-- 2 files changed, 17 insertions(+), 26 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index 0c1517f024..bdbf6d987c

[PATCH v2 21/90] target/sparc: Move RDASR, STBAR, MEMBAR to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 22 +++ target/sparc/translate.c | 360 -- 2 files changed, 253 insertions(+), 129 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index 4d09c102f1..b3291ea771

[PATCH v2 76/90] target/sparc: Move FSMULD to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 1 + target/sparc/translate.c | 43 +-- 2 files changed, 24 insertions(+), 20 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index 0f7d898071..96d9139d21

[PATCH v2 35/90] target/sparc: Move UDIV, SDIV to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 4 +++ target/sparc/translate.c | 66 ++- 2 files changed, 41 insertions(+), 29 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index a2512d8d47..7d1afb2a87

[PATCH v2 30/90] target/sparc: Move ADDC to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 2 ++ target/sparc/translate.c | 41 +++ 2 files changed, 39 insertions(+), 4 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index 4005ce3df7..abcee27fd4

[PATCH v2 78/90] target/sparc: Move gen_fop_FD insns to decodetree

2023-10-17 Thread Richard Henderson
Move FdTOs, FdTOi, FxTOs. Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 3 +++ target/sparc/translate.c | 51 +-- 2 files changed, 30 insertions(+), 24 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index

[PATCH v2 62/90] target/sparc: Move BMASK to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 2 ++ target/sparc/translate.c | 22 +- 2 files changed, 15 insertions(+), 9 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index 8bd57f620a..6f136e0602 100644 ---

[PATCH v2 39/90] target/sparc: Move POPC to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 1 + target/sparc/translate.c | 55 ++- 2 files changed, 9 insertions(+), 47 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index a61d10be5a..0c1517f024 100644

[PATCH v2 77/90] target/sparc: Move FDMULQ to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 1 + target/sparc/translate.c | 41 +-- 2 files changed, 23 insertions(+), 19 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index 96d9139d21..a98b3b2bdd

[PATCH v2 75/90] target/sparc: Move gen_fop_QQQ insns to decodetree

2023-10-17 Thread Richard Henderson
Move FADDq, FSUBq, FMULq, FDIVq. Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 4 +++ target/sparc/translate.c | 52 +++ 2 files changed, 30 insertions(+), 26 deletions(-) diff --git a/target/sparc/insns.decode

[PATCH v2 71/90] target/sparc: Move gen_fop_DD insns to decodetree

2023-10-17 Thread Richard Henderson
Move FSQRTd, FxTOd, FdTOx. Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 3 +++ target/sparc/translate.c | 50 +-- 2 files changed, 30 insertions(+), 23 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode

[PATCH v2 25/90] target/sparc: Move WRASR to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 33 +++- target/sparc/translate.c | 353 +- 2 files changed, 226 insertions(+), 160 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index c2d8b0dbbe..6acf0f9403

[PATCH v2 89/90] target/sparc: Convert FZERO, FONE to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 5 +++ target/sparc/translate.c | 69 +++ 2 files changed, 45 insertions(+), 29 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index c9fe45adff..22d7e7fc09

[PATCH v2 28/90] target/sparc: Move WRTBR, WRHPR to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 9 target/sparc/translate.c | 110 +++--- 2 files changed, 65 insertions(+), 54 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index 56c04f01a5..49270705c7

[PATCH v2 90/90] target/sparc: Remove disas_sparc_legacy

2023-10-17 Thread Richard Henderson
All instructions are now converted. Signed-off-by: Richard Henderson --- target/sparc/translate.c | 145 +-- 1 file changed, 1 insertion(+), 144 deletions(-) diff --git a/target/sparc/translate.c b/target/sparc/translate.c index ba41cfda3d..c458de2103 100644

[PATCH v2 80/90] target/sparc: Move FqTOs, FqTOi to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 2 ++ target/sparc/translate.c | 48 +-- 2 files changed, 28 insertions(+), 22 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index 1965084fb8..d890d97f12

[PATCH v2 42/90] target/sparc: Move FLUSH, SAVE, RESTORE to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 4 target/sparc/translate.c | 35 +-- 2 files changed, 29 insertions(+), 10 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index 060ee79db0..9c4c493630 100644

[PATCH v2 84/90] target/sparc: Move FMOVq, FNEGq, FABSq to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 3 + target/sparc/translate.c | 140 +- 2 files changed, 50 insertions(+), 93 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index 0bb5b3fca6..23db453617

[PATCH v2 81/90] target/sparc: Move FqTOd, FqTOx to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 2 ++ target/sparc/translate.c | 49 +-- 2 files changed, 29 insertions(+), 22 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index d890d97f12..249f03a075

[PATCH v2 11/90] target/sparc: Move CALL to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 1 + target/sparc/translate.c | 33 - 2 files changed, 17 insertions(+), 17 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index 5811a679db..a5f5d2681e 100644 ---

Re: [PATCH v2 1/2] ppc/pnv: Add an I2C controller model

2023-10-17 Thread Cédric Le Goater
On 10/16/23 22:55, Miles Glenn wrote: On Fri, 2023-10-13 at 10:58 +0200, Philippe Mathieu-Daudé wrote: Hi Glenn, Cédric, On 12/10/23 22:08, Glenn Miles wrote: From: Cédric Le Goater The more recent IBM power processors have an embedded I2C controller that is accessible by software via the

Re: [RFC PATCH 0/5] virtio-net: Introduce LM early load

2023-10-17 Thread Yajun Wu
Ping. On 9/18/2023 12:49 PM, Yajun Wu wrote: This series of patches aims to minimize the downtime during live migration of a virtio-net device with a vhost-user backend. In the case of hardware virtual Data Path Acceleration (vDPA) implementation, the hardware configuration, which includes

Re: [PATCH] vhost-user: Fix protocol feature bit conflict

2023-10-17 Thread Viresh Kumar
On 17-10-23, 10:14, Hanna Czenczek wrote: > On 17.10.23 09:53, Viresh Kumar wrote: > > On 17-10-23, 09:51, Hanna Czenczek wrote: > > > Not that I’m really opposed to that, but I don’t see the problem with just > > > doing that in the same work that makes qemu actually use this flag, > > > exactly

RE: [PATCH v2 17/27] backends/iommufd: Introduce the iommufd object

2023-10-17 Thread Duan, Zhenzhong
Hi Markus, >-Original Message- >From: Markus Armbruster >Sent: Monday, October 16, 2023 6:01 PM >Subject: Re: [PATCH v2 17/27] backends/iommufd: Introduce the iommufd object > >Zhenzhong Duan writes: > >> From: Eric Auger >> >> Introduce an iommufd object which allows the interaction

[PULL 14/38] migration: Create migrate_rdma()

2023-10-17 Thread Juan Quintela
Helper to say if we are doing a migration over rdma. Reviewed-by: Peter Xu Reviewed-by: Li Zhijian Signed-off-by: Juan Quintela Message-ID: <20231011203527.9061-2-quint...@redhat.com> --- migration/migration.h | 2 ++ migration/options.h | 1 + migration/migration.c | 1 +

[PULL 32/38] migration/ram: Remove RAMState from xbzrle_cache_zero_page

2023-10-17 Thread Juan Quintela
From: Fabiano Rosas 'rs' is not used in that function. It's a leftover from commit 9360447d34 ("ram: Use MigrationStats for statistics"). Reviewed-by: Peter Xu Signed-off-by: Fabiano Rosas Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Message-ID:

[PULL 01/38] migration: refactor migration_completion

2023-10-17 Thread Juan Quintela
From: Wei Wang Current migration_completion function is a bit long. Refactor the long implementation into different subfunctions: - migration_completion_precopy: completion code related to precopy - migration_completion_postcopy: completion code related to postcopy Rename

Re: [RFC PATCH v3 09/78] hw/acpi/aml-build.c: add fallthrough pseudo-keyword

2023-10-17 Thread Ani Sinha
> On 13-Oct-2023, at 2:15 PM, Emmanouil Pitsidianakis > wrote: > > In preparation of raising -Wimplicit-fallthrough to 5, replace all > fall-through comments with the fallthrough attribute pseudo-keyword. > > Signed-off-by: Emmanouil Pitsidianakis What was wrong with QEMU_FALLTHROUGH?

Re: [PATCH] hw/display: fix memleak from virtio_add_resource

2023-10-17 Thread Albert Esteve
On Fri, Oct 6, 2023 at 10:41 PM Matheus Tavares Bernardino < quic_mathb...@quicinc.com> wrote: > When the given uuid is already present in the hash table, > virtio_add_resource() does not add the passed VirtioSharedObject. In > this case, free it in the callers to avoid leaking memory. This fixed

[PATCH v2 12/90] target/sparc: Move BPcc and Bicc to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 4 ++ target/sparc/translate.c | 120 +++--- 2 files changed, 64 insertions(+), 60 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index a5f5d2681e..15cd975f4e

[PATCH v2 20/90] target/sparc: Move Tcc to decodetree

2023-10-17 Thread Richard Henderson
Use the new delay_exceptionv function in the implementation. Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 2 + target/sparc/translate.c | 143 +- 2 files changed, 66 insertions(+), 79 deletions(-) diff --git a/target/sparc/insns.decode

[PATCH v2 16/90] target/sparc: Merge gen_fcond with only caller

2023-10-17 Thread Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/sparc/translate.c | 22 -- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/target/sparc/translate.c b/target/sparc/translate.c index 61a75b5fab..cc19f0606e 100644 ---

[PATCH v2 34/90] target/sparc: Move UDIVX, SDIVX to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 2 ++ target/sparc/translate.c | 23 ++- 2 files changed, 16 insertions(+), 9 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index 64f5885e67..a2512d8d47 100644 ---

[PATCH v2 10/90] target/sparc: Define AM_CHECK for sparc32

2023-10-17 Thread Richard Henderson
Define as false, which allows some ifdef removal. Signed-off-by: Richard Henderson --- target/sparc/translate.c | 21 + 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/target/sparc/translate.c b/target/sparc/translate.c index 080bc5f8a2..9eb2b7e52f 100644 ---

[PATCH v2 19/90] target/sparc: Move SETHI to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 6 + target/sparc/translate.c | 50 --- 2 files changed, 21 insertions(+), 35 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index 9ab3f2eb82..f6f5401b10

[PATCH v2 33/90] target/sparc: Move SUBC to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 2 ++ target/sparc/translate.c | 28 2 files changed, 26 insertions(+), 4 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index c114a13f1d..64f5885e67 100644 ---

[PATCH v2 17/90] target/sparc: Merge gen_branch_[an] with only caller

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/translate.c | 73 +--- 1 file changed, 30 insertions(+), 43 deletions(-) diff --git a/target/sparc/translate.c b/target/sparc/translate.c index cc19f0606e..9188196657 100644 --- a/target/sparc/translate.c +++

[PATCH v2 38/90] target/sparc: Move MOVcc, MOVR to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 4 ++ target/sparc/translate.c | 103 +- 2 files changed, 51 insertions(+), 56 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index fe0eacd779..a61d10be5a

[PATCH v2 18/90] target/sparc: Pass DisasCompare to advance_jump_cond

2023-10-17 Thread Richard Henderson
Fold the condition into the branch or movcond when possible. Signed-off-by: Richard Henderson --- target/sparc/translate.c | 32 +--- 1 file changed, 13 insertions(+), 19 deletions(-) diff --git a/target/sparc/translate.c b/target/sparc/translate.c index

[PATCH v2 67/90] target/sparc: Move gen_ne_fop_DDD insns to decodetree

2023-10-17 Thread Richard Henderson
Move FMUL8x16, FMUL8x16AU, FMUL8x16AL, FMUL8SUx16, FMUL8ULx16, FMULD8SUx16, FMULD8ULx16, FPMERGE, FEXPAND, FANDNOT1d, FANDNOT2d, FANDd, FNANDd, FNORd, FORNOT1d, FORNOT2d, FORd, FPADD16d, FPADD32d, FPSUB16d, FPSUB32d, FXNORd, FXORd. Signed-off-by: Richard Henderson --- target/sparc/insns.decode

[PATCH v2 48/90] target/sparc: Move simple integer load/store to decodetree

2023-10-17 Thread Richard Henderson
Move LDUW, LDUB, LDUH, LDD, LDSW, LDSB, LDSH, LDX, STW, STB, STH, STD, STX. Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 22 + target/sparc/translate.c | 196 +++--- 2 files changed, 142 insertions(+), 76 deletions(-) diff --git

[PATCH v2 54/90] target/sparc: Split out fp ldst functions with asi precomputed

2023-10-17 Thread Richard Henderson
Take the operation size from the MemOp instead of a separate parameter. Signed-off-by: Richard Henderson --- target/sparc/translate.c | 136 ++- 1 file changed, 78 insertions(+), 58 deletions(-) diff --git a/target/sparc/translate.c

[PATCH v2 72/90] target/sparc: Move FSQRTq to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 1 + target/sparc/translate.c | 39 +++ 2 files changed, 24 insertions(+), 16 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index fa95ca056a..7fdd8e37d1

[PATCH v2 05/90] configs: Enable MTTCG for sparc, sparc64

2023-10-17 Thread Richard Henderson
This will be of small comfort to sparc64, because both sun4u and sun4v board models force max_cpus = 1. But it does enable actual smp for sparc32 sun4m. Signed-off-by: Richard Henderson --- configs/targets/sparc-softmmu.mak | 1 + configs/targets/sparc64-softmmu.mak | 1 + 2 files changed, 2

[PATCH v2 79/90] target/sparc: Move FiTOd, FsTOd, FsTOx to decodetree

2023-10-17 Thread Richard Henderson
Note that gen_ne_fop_DF was incorrectly named and does pass env. The two sets of helpers should have been unified. Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 3 ++ target/sparc/translate.c | 67 --- 2 files changed, 30 insertions(+),

[PATCH v2 24/90] target/sparc: Move RDTBR, FLUSHW to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 5 + target/sparc/translate.c | 23 +++ 2 files changed, 16 insertions(+), 12 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index bab80514ba..c2d8b0dbbe 100644 ---

[PATCH v2 61/90] target/sparc: Move ADDRALIGN* to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 3 +++ target/sparc/translate.c | 56 ++- 2 files changed, 34 insertions(+), 25 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index 07a84b109c..8bd57f620a

[PATCH v2 58/90] target/sparc: Merge LDFSR, LDXFSR implementations

2023-10-17 Thread Richard Henderson
Combine the helper to a single set_fsr(). Perform the mask and merge inline. Signed-off-by: Richard Henderson --- target/sparc/helper.h | 3 +-- target/sparc/fop_helper.c | 17 ++-- target/sparc/translate.c | 42 --- 3 files changed, 16

[PATCH v2 53/90] target/sparc: Move PREFETCH, PREFETCHA to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 8 ++-- target/sparc/translate.c | 14 ++ 2 files changed, 16 insertions(+), 6 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index 8e6a24e094..86108679eb 100644 ---

[PATCH v2 57/90] target/sparc: Move LDFSR, STFSR to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 4 + target/sparc/translate.c | 152 +++--- 2 files changed, 64 insertions(+), 92 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index fa9c8d3d8b..42eb807e21

[PATCH v2 88/90] target/sparc: Move FPACK16, FPACKFIX to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 2 ++ target/sparc/translate.c | 55 --- 2 files changed, 42 insertions(+), 15 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index 0a0c5b2505..c9fe45adff

[PATCH v2 52/90] target/sparc: Move CASA, CASXA to decodetree

2023-10-17 Thread Richard Henderson
Remove gen_cas_asi, gen_casx_asi. Rename gen_cas_asi0 to gen_cas_asi. Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 7 target/sparc/translate.c | 71 +++ 2 files changed, 35 insertions(+), 43 deletions(-) diff --git

[PATCH v2 32/90] target/sparc: Move UMUL, SMUL to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 4 target/sparc/translate.c | 23 +-- 2 files changed, 9 insertions(+), 18 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index d9474d2a20..c114a13f1d 100644 ---

[PATCH v2 29/90] target/sparc: Move basic arithmetic to decodetree

2023-10-17 Thread Richard Henderson
Move ADD, AND, OR, XOR, SUB, ANDN, ORN, XORN. Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 20 - target/sparc/translate.c | 183 +- 2 files changed, 99 insertions(+), 104 deletions(-) diff --git a/target/sparc/insns.decode

[PATCH v2 83/90] target/sparc: Move FdTOq, FxTOq to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 2 ++ target/sparc/translate.c | 47 ++- 2 files changed, 28 insertions(+), 21 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index 0b54384af7..0bb5b3fca6

[PATCH v2 70/90] target/sparc: Move gen_fop_FF insns to decodetree

2023-10-17 Thread Richard Henderson
Move FSQRTs, FiTOs, FsTOi. Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 3 +++ target/sparc/translate.c | 47 --- 2 files changed, 27 insertions(+), 23 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode

[PATCH v2 60/90] target/sparc: Move ARRAY* to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 4 +++ target/sparc/translate.c | 54 --- 2 files changed, 37 insertions(+), 21 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index fb104e77d1..07a84b109c

[PATCH v2 63/90] target/sparc: Move FMOVS, FNEGS, FABSS, FSRC*S, FNOT*S to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 13 ++ target/sparc/translate.c | 92 +-- 2 files changed, 62 insertions(+), 43 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index 6f136e0602..d591efb0f9

[PATCH v2 43/90] target/sparc: Move DONE, RETRY to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 3 ++ target/sparc/translate.c | 99 +++ 2 files changed, 40 insertions(+), 62 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index 9c4c493630..dface4a9dd

[PATCH v2 68/90] target/sparc: Move PDIST to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 1 + target/sparc/translate.c | 41 +-- 2 files changed, 23 insertions(+), 19 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index 197d6a0db3..64a7b3bd0b

[PATCH 14/20] target/sparc: Merge advance_jump_uncond_{never, always} into advance_jump_cond

2023-10-17 Thread Richard Henderson
Handle these via TCG_COND_{ALWAYS,NEVER}. Allow dc->npc to be variable, using gen_mov_pc_npc. Signed-off-by: Richard Henderson --- target/sparc/translate.c | 73 1 file changed, 29 insertions(+), 44 deletions(-) diff --git a/target/sparc/translate.c

Re: [PATCH] vhost-user: Fix protocol feature bit conflict

2023-10-17 Thread Viresh Kumar
On 17-10-23, 09:51, Hanna Czenczek wrote: > Not that I’m really opposed to that, but I don’t see the problem with just > doing that in the same work that makes qemu actually use this flag, exactly > because it’s just a -1/+1 change. > > I can send a v2, but should I do the same for libvhost-user

Re: [PATCH v2 00/10] riscv: RVA22U64 profile support

2023-10-17 Thread Andrew Jones
On Tue, Oct 17, 2023 at 01:55:47PM +1000, Alistair Francis wrote: > On Mon, Oct 16, 2023 at 7:03 PM Andrew Jones wrote: > > > > On Thu, Oct 12, 2023 at 04:07:50PM -0300, Daniel Henrique Barboza wrote: > > > > > > > > > On 10/11/23 00:01, Alistair Francis wrote: > > > > On Sat, Oct 7, 2023 at

Re: [PATCH qemu v2 1/1] Switch memory management calls to new coding conventions

2023-10-17 Thread Michael Tokarev
03.10.2023 15:45, ~h0lyalg0rithm wrote: From: Suraj Shirvankar Signed-off-by: Suraj Shirvankar --- contrib/elf2dmp/addrspace.c | 4 ++-- contrib/elf2dmp/main.c | 6 +++--- contrib/elf2dmp/pdb.c | 16 contrib/elf2dmp/qemu_elf.c | 4 ++-- 4 files changed,

[PULL 10/38] tests/qtest/migration: Add a test for the analyze-migration script

2023-10-17 Thread Juan Quintela
From: Fabiano Rosas Add a smoke test that migrates to a file and gives it to the script. It should catch the most annoying errors such as changes in the ram flags. After code has been merged it becomes way harder to figure out what is causing the script to fail, the person making the change is

[PULL 00/38] Migration 20231017 patches

2023-10-17 Thread Juan Quintela
The following changes since commit 800485762e6564e04e2ab315132d477069562d91: Merge tag 'python-pull-request' of https://gitlab.com/jsnow/qemu into staging (2023-10-16 12:37:48 -0400) are available in the Git repository at: https://gitlab.com/juan.quintela/qemu.git tags/migration-20231017

[PULL 03/38] migration: Allow user to specify available switchover bandwidth

2023-10-17 Thread Juan Quintela
From: Peter Xu Migration bandwidth is a very important value to live migration. It's because it's one of the major factors that we'll make decision on when to switchover to destination in a precopy process. This value is currently estimated by QEMU during the whole live migration process by

[PULL 13/38] migration: Non multifd migration don't care about multifd flushes

2023-10-17 Thread Juan Quintela
RDMA was having trouble because migrate_multifd_flush_after_each_section() can only be true or false, but we don't want to send any flush when we are not in multifd migration. CC: Fabiano Rosas Reviewed-by: Li Zhijian Reviewed-by: Peter Xu Signed-off-by: Juan Quintela Message-ID:

[PULL 04/38] migration: fix RAMBlock add NULL check

2023-10-17 Thread Juan Quintela
From: Dmitry Frolov qemu_ram_block_from_host() may return NULL, which will be dereferenced w/o check. Usualy return value is checked for this function. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Dmitry Frolov Reviewed-by: Fabiano Rosas Reviewed-by: Peter

[PULL 11/38] tests/qtest: migration-test: Add tests for file-based migration

2023-10-17 Thread Juan Quintela
From: Fabiano Rosas Add basic tests for file-based migration. Note that we cannot use test_precopy_common because that routine expects it to be possible to run the migration live. With the file transport there is no live migration because we must wait for the source to finish writing the

[PULL 19/38] migration/rdma: Create rdma_control_save_page()

2023-10-17 Thread Juan Quintela
The only user of ram_control_save_page() and save_page() hook was rdma. Just move the function to rdma.c, rename it to rdma_control_save_page(). Reviewed-by: Peter Xu Reviewed-by: Li Zhijian Signed-off-by: Juan Quintela Message-ID: <20231011203527.9061-7-quint...@redhat.com> ---

[PULL 29/38] multifd: fix counters in multifd_send_thread

2023-10-17 Thread Juan Quintela
From: Elena Ufimtseva Previous commit cbec7eb76879d419e7dbf531ee2506ec0722e825 "migration/multifd: Compute transferred bytes correctly" removed accounting for packet_len in non-rdma case, but the next_packet_size only accounts for pages, not for the header packet (normal_pages * PAGE_SIZE) that

[PULL 05/38] migration: Add the configuration vmstate to the json writer

2023-10-17 Thread Juan Quintela
From: Nikolay Borisov Make the migration json writer part of MigrationState struct, allowing the 'configuration' object be serialized to json. This will facilitate the parsing of the 'configuration' object in the next patch that fixes analyze-migration.py for arm. Signed-off-by: Nikolay

[PULL 02/38] migration: Use g_autofree to simplify ram_dirty_bitmap_reload()

2023-10-17 Thread Juan Quintela
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Markus Armbruster Reviewed-by: Fabiano Rosas Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Message-ID: <20231011023627.86691-1-phi...@linaro.org> --- migration/ram.c | 17 ++--- 1 file

[PULL 37/38] migration/multifd: Unify multifd_send_thread error paths

2023-10-17 Thread Juan Quintela
From: Fabiano Rosas The preferred usage of the Error type is to always set both the return code and the error when a failure happens. As all code called from the send thread follows this pattern, we'll always have the return code and the error set at the same time. Aside from the convention, in

[PULL 24/38] migration/rdma: Use i as for index instead of idx

2023-10-17 Thread Juan Quintela
Once there, all the uses are local to the for, so declare the variable inside the for statement. Reviewed-by: Fabiano Rosas Reviewed-by: Li Zhijian Signed-off-by: Juan Quintela Message-ID: <20231011203527.9061-12-quint...@redhat.com> --- migration/rdma.c | 49

[PULL 33/38] migration/ram: Stop passing QEMUFile around in save_zero_page

2023-10-17 Thread Juan Quintela
From: Fabiano Rosas We don't need the QEMUFile when we're already passing the PageSearchStatus. Reviewed-by: Peter Xu Signed-off-by: Fabiano Rosas Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Message-ID: <20231011184604.32364-5-faro...@suse.de> --- migration/ram.c | 11

Re: [PATCH v26 01/21] qapi: machine.json: change docs regarding CPU topology

2023-10-17 Thread Markus Armbruster
Nina Schoetterl-Glausch writes: > Clarify roles of different architectures. > Also change things a bit in anticipation of additional members being > added. > > Suggested-by: Markus Armbruster > Signed-off-by: Nina Schoetterl-Glausch > --- > qapi/machine.json | 58

Re: [PATCH v2 1/3] hw/pci: Add all Data Object Types defined in PCIe r6.0

2023-10-17 Thread Jonathan Cameron via
On Tue, 17 Oct 2023 15:21:53 +1000 Alistair Francis wrote: > Add all of the defined protocols/features from the PCIe-SIG r6.0 > "Table 6-32 PCI-SIG defined Data Object Types (Vendor ID = 0001h)" > table. > > Signed-off-by: Alistair Francis Reviewed-by: Jonathan Cameron If you feel like

[PATCH v2 15/90] target/sparc: Merge gen_cond with only caller

2023-10-17 Thread Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/sparc/translate.c | 23 --- 1 file changed, 8 insertions(+), 15 deletions(-) diff --git a/target/sparc/translate.c b/target/sparc/translate.c index a05cb59cd6..61a75b5fab 100644 ---

[PATCH v2 08/90] target/sparc: Remove sparcv7 cpu features

2023-10-17 Thread Richard Henderson
The oldest supported cpu is the microsparc 1; all other cpus use CPU_DEFAULT_FEATURES. Remove the features that must always be present for sparcv7: FLOAT, SWAP, FLUSH, FSQRT, FMUL. Signed-off-by: Richard Henderson --- linux-user/sparc/target_syscall.h | 6 +- target/sparc/cpu.h

[PATCH v2 27/90] target/sparc: Move WRWIM, WRPR to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 21 +++ target/sparc/translate.c | 350 +++--- 2 files changed, 235 insertions(+), 136 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index 850b5d58d0..56c04f01a5

[PATCH v2 69/90] target/sparc: Move gen_gsr_fop_DDD insns to decodetree

2023-10-17 Thread Richard Henderson
Move FPACK32, FALIGNDATA, BSHUFFLE. Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 3 ++ target/sparc/translate.c | 101 -- 2 files changed, 55 insertions(+), 49 deletions(-) diff --git a/target/sparc/insns.decode

[PATCH v2 26/90] target/sparc: Move WRPSR, SAVED, RESTORED to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 10 +++ target/sparc/translate.c | 61 ++- 2 files changed, 38 insertions(+), 33 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index 6acf0f9403..850b5d58d0

[PATCH v2 64/90] target/sparc: Move FMOVD, FNEGD, FABSD, FSRC*D, FNOT*D to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 7 +++ target/sparc/translate.c | 91 +-- 2 files changed, 56 insertions(+), 42 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index d591efb0f9..91988e2978

[PATCH v2 01/90] target/sparc: Clear may_lookup for npc == DYNAMIC_PC

2023-10-17 Thread Richard Henderson
With pairs of jmp+rett, pc == DYNAMIC_PC_LOOKUP and npc == DYNAMIC_PC. Make sure that we exit for interrupts. Cc: qemu-sta...@nongnu.org Fixes: 633c42834c7 ("target/sparc: Introduce DYNAMIC_PC_LOOKUP") Tested-by: Mark Cave-Ayland Signed-off-by: Richard Henderson --- target/sparc/translate.c |

[PATCH v2 74/90] target/sparc: Move gen_fop_DDD insns to decodetree

2023-10-17 Thread Richard Henderson
Move FADDd, FSUBd, FMULd, FDIVd. Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 4 +++ target/sparc/translate.c | 55 --- 2 files changed, 32 insertions(+), 27 deletions(-) diff --git a/target/sparc/insns.decode

[PATCH 02/20] target/sparc: Split psr and xcc into components

2023-10-17 Thread Richard Henderson
Step in removing CC_OP: change the representation of CC_OP_FLAGS. The 8 bits are distributed between 6 variables, which should make it easy to keep up to date. The code within cc_helper.c is quite ugly but is only temporary. Signed-off-by: Richard Henderson --- linux-user/sparc/target_cpu.h |

[PATCH 13/20] target/sparc: Merge gen_branch2 into advance_pc

2023-10-17 Thread Richard Henderson
The function had only one caller. Canonicalize the cpu_cond test to TCG_COND_NE, the "natural" sense of its value. Signed-off-by: Richard Henderson --- target/sparc/translate.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git

[PATCH 06/20] target/sparc: Remove CC_OP_SUB, CC_OP_SUBX, CC_OP_TSUB

2023-10-17 Thread Richard Henderson
These are all related and implementable with common code. Signed-off-by: Richard Henderson --- target/sparc/cpu.h | 3 - target/sparc/cc_helper.c | 59 -- target/sparc/translate.c | 226 ++- 3 files changed, 54 insertions(+), 234 deletions(-)

[PATCH 04/20] target/sparc: Remove CC_OP_LOGIC

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/cpu.h | 1 - target/sparc/cc_helper.c | 19 target/sparc/translate.c | 97 +--- 3 files changed, 40 insertions(+), 77 deletions(-) diff --git a/target/sparc/cpu.h b/target/sparc/cpu.h index

[PATCH 09/20] target/sparc: Remove DisasCompare.is_bool

2023-10-17 Thread Richard Henderson
Since we're going to feed cpu_cond to another comparison, we don't reqire a boolean value -- anything non-zero is sufficient. Signed-off-by: Richard Henderson --- target/sparc/translate.c | 22 +++--- 1 file changed, 7 insertions(+), 15 deletions(-) diff --git

Re: [PATCH] guest-agent: improve help for --allow-rpcs and --block-rpcs

2023-10-17 Thread Konstantin Kostiuk
Reviewed-by: Konstantin Kostiuk On Fri, Oct 13, 2023 at 6:53 PM Angel M. Villegas wrote: > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1757 > > Updates to qga help output and documentation for --allow-rpcs and > --blocks-rpcs > > Signed-off-by: Angel M. Villegas > --- >

Re: [RFC PATCH v3 60/78] qga: add fallthrough pseudo-keyword

2023-10-17 Thread Konstantin Kostiuk
Reviewed-by: Konstantin Kostiuk On Fri, Oct 13, 2023 at 11:50 AM Emmanouil Pitsidianakis < manos.pitsidiana...@linaro.org> wrote: > In preparation of raising -Wimplicit-fallthrough to 5, replace all > fall-through comments with the fallthrough attribute pseudo-keyword. > > Signed-off-by:

[PATCH v2 00/90] target/sparc: Convert to decodetree

2023-10-17 Thread Richard Henderson
While doing some other testing the other day, I noticed my sparc64 chroot running particularly slowly. I think I know what the problem is there, but fixing that was going to be particularly ugly with the existing sparc translator. So I've converted the translator to something more managable.

[PATCH v2 36/90] target/sparc: Move TADD, TSUB, MULS to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 5 + target/sparc/translate.c | 47 +-- 2 files changed, 26 insertions(+), 26 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index 7d1afb2a87..18e2372928

[PATCH v2 22/90] target/sparc: Move RDPSR, RDHPR to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 10 target/sparc/translate.c | 112 -- 2 files changed, 80 insertions(+), 42 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index b3291ea771..8b05b9d8f1

[PATCH v2 23/90] target/sparc: Move RDWIM, RDPR to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 22 +++ target/sparc/translate.c | 360 +++--- 2 files changed, 244 insertions(+), 138 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index 8b05b9d8f1..bab80514ba

[PATCH v2 04/90] target/sparc: Set TCG_GUEST_DEFAULT_MO

2023-10-17 Thread Richard Henderson
Always use TSO, per the Oracle 2015 manual. This is slightly less restrictive than the TCG_MO_ALL default, and happens to match the i386 model, which will eliminate a few extra barriers on that host. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/sparc/cpu.h |

  1   2   3   4   5   6   >