Re: [Qemu-devel] [RFC PATCH 0/3] Fix UST backend for LTTng 2.x

2013-10-01 Thread Alex Bennée
LTTng 2.0 Userspace Tracer (development files) ii liblttng-ust0 2.0.2-0ubuntu1 LTTng 2.0 Userspace Tracer (libraries) -- Alex Bennée

Re: [Qemu-devel] [PULL 0/1] seabios update to 1.7.3.2

2013-10-01 Thread Alex Bennée
this as I was testing my Travis patches. Perhaps the .gitmodules should always refer to the canonical upstream repo? -- Alex Bennée

Re: [Qemu-devel] [Build bug] Problem checking out submodules

2013-10-01 Thread Alex Bennée
7149af13dd5600b27dac90235e60ff91d0468636 Author: Alex Bennée a...@bennee.com Date: Tue Oct 1 16:51:38 2013 +0100 .gitmodules: use upstream SeaBIOS repo to fix submodule init Currently master is broken as the wanted commit doesn't exist in qemu's mirror of SeaBIOS. diff --git a/.gitmodules

Re: [Qemu-devel] [Build bug] Problem checking out submodules

2013-10-01 Thread Alex Bennée
l...@redhat.com writes: On 10/01/2013 04:37 PM, Alex Bennée wrote: l...@redhat.com writes: Hello: In the daily qemu.git autotest run, I started to see the following problem while checking out the qemu.git tree and checking out the submodules: Oh I just noticed that. Is this Stefan's

Re: [Qemu-devel] [PATCH 2/2] .gitmodules: use upstream SeaBIOS repo to fix submodule init

2013-10-03 Thread Alex Bennée
peter.mayd...@linaro.org writes: On 3 October 2013 17:58, alex.ben...@linaro.org wrote: From: Alex Bennée a...@bennee.com Currently master is broken as the wanted commit doesn't exist in qemu's mirror of SeaBIOS. snip This is wrong. QEMU's submodules should all point to git.qemu.org

Re: [Qemu-devel] [PATCH] target-arm: Implement ARMv8 VSEL instruction.

2013-10-03 Thread Alex Bennée
constant is used twice and should it ever be changed there is a risk of one being missed (although conceivably thumb encoding could be different?). I appreciate the disassembler code is already a mass of magic constants so it's not a major thing for me. Cheers, -- Alex Bennée

Re: [Qemu-devel] [PULL 8/8] tcg-arm: Move the tlb addend load earlier

2013-10-03 Thread Alex Bennée
r...@twiddle.net writes: There are free scheduling slots between the sequence of comparison instructions. This requires changing the register in use to avoid conflict with those compares. Signed-off-by: Richard Henderson r...@twiddle.net snip Looks good to me. Reviewed-by: Alex Bennée

Re: [Qemu-devel] [PULL 4/8] tcg-arm: Use QEMU_BUILD_BUG_ON to verifyconstraints on tlbb

2013-10-03 Thread Alex Bennée
r...@twiddle.net writes: One of the two constraints we already checked via #if, but the tlb offset distance was only checked at runtime. Signed-off-by: Richard Henderson r...@twiddle.net snip Reviewed-by: Alex Bennée a...@bennee.com -- Alex Bennée

Re: [Qemu-devel] [PATCH] qemu-char: Fix potential out of bounds accessto local arrayss

2013-10-03 Thread Alex Bennée
Reviewed-by: Alex Bennée a...@bennee.com -- Alex Bennée

Re: [Qemu-devel] [RFC PATCH v2 0/3] Fix UST backend for LTTng 2.x

2013-10-07 Thread Alex Bennée
.. Perhaps a few simple examples could be added to the document so people can at least confirm everything is working as it should be. Otherwise I'm happy. Reviewed-by: Alex Bennée a...@bennee.com Mohamad Mohamad Gebai (3): Fix configure script for LTTng 2.x Modified the tracetool framework

Re: [Qemu-devel] [PATCH] configure: create fsdev/ directory

2013-10-12 Thread Alex Bennée
with the following error: snip Isn't this the sort of think Make dependencies are for? -- Alex Bennée

Re: [Qemu-devel] [RFC PATCH v3 4/5] Update documentation for LTTng ust tracing

2013-10-15 Thread Alex Bennée
probes but has only been tested with -- Alex Bennée

Re: [Qemu-devel] [PATCH v2 1/1] integrator: fix Linux boot failure by emulating dbg

2013-10-15 Thread Alex Bennée
peter.mayd...@linaro.org writes: On 16 September 2013 13:50, alex.ben...@linaro.org wrote: From: Alex Bennée a...@bennee.com Commit 9b8c69243 broke the ability to boot the kernel as the value returned by unassigned_mem_read returned non-zero and left the kernel looping forever waiting

Re: [Qemu-devel] [RFC PATCH v3 4/5] Update documentation for LTTng ust tracing

2013-10-16 Thread Alex Bennée
/distro specific? -- Alex Bennée

Re: [Qemu-devel] [RFC PATCH v3 2/5] Modified the tracetool framework for LTTng 2.x.

2013-10-16 Thread Alex Bennée
to avoid getting a warning. Signed-off-by: Mohamad Gebai mohamad.ge...@polymtl.ca snip Reviewed-by: Alex Bennée a...@bennee.com -- Alex Bennée

Re: [Qemu-devel] [RFC PATCH v3 1/5] Fix configure script for LTTng 2.x

2013-10-16 Thread Alex Bennée
-by: Alex Bennée a...@bennee.com -- Alex Bennée

Re: [Qemu-devel] [RFC PATCH v3 3/5] Adapt Makefiles to the new LTTng ust interface.

2013-10-16 Thread Alex Bennée
worth. Reviewed-by: Alex Bennée a...@bennee.com -- Alex Bennée

Re: [Qemu-devel] [RFC PATCH v3 5/5] Add ust generated files to .gitignore

2013-10-16 Thread Alex Bennée
mohamad.ge...@gmail.com writes: Signed-off-by: Mohamad Gebai mohamad.ge...@polymtl.ca snip Reviewed-by: Alex Bennée a...@bennee.com -- Alex Bennée

Re: [Qemu-devel] [PATCH 18/18] bsd-user: add arm, mips and mips64 options to configure target-listt

2013-10-16 Thread Alex Bennée
if there is no special config for a given build target? -- Alex Bennée

Re: [Qemu-devel] [PATCH 00/18] bsd-user: Add system call and mips/armsupport..

2013-10-16 Thread Alex Bennée
all these shim calls? -- Alex Bennée

Re: [Qemu-devel] [PATCH 04/18] bsd-user: move target arch and host OSdependent code out of main.cc

2013-10-16 Thread Alex Bennée
] = retval2; +} It's a shame ARM hasn't got some un-ambigious #define's for registers snip More #if 0's +#if 0 +case EXCP0B_NOSEG: +case EXCP0C_STACK: snip -- Alex Bennée

Re: [Qemu-devel] [RFC PATCH v3 4/5] Update documentation for LTTng ust tracing

2013-10-17 Thread Alex Bennée
mohamad.ge...@polymtl.ca writes: On 13-10-16 08:05 AM, Alex Bennée wrote: Running this gives me: quote UST events: - None /quote Before or after running qemu. What is the mechanism lttng expects to find out all these events? Either the user should belong the group tracing

[Qemu-devel] [RESEND PULL v5 0/0] .travis.yml: basic compile and check recipies

2013-10-17 Thread Alex Bennée
changes up to 90878d2c083629a4ee99b2d03158838b35e218c3: .travis.yml | 69 + 1 file changed, 69 insertions(+) create mode 100644 .travis.yml Alex Bennée (1): .travis.yml

[Qemu-devel] [PATCH] integrator: fix Linux boot failure by emulating dbg

2013-10-17 Thread Alex Bennée
From: Alex Bennée a...@bennee.com Commit 9b8c69243 broke the ability to boot the kernel as the value returned by unassigned_mem_read returned non-zero and left the kernel looping forever waiting for it to change (see integrator_led_set in the kernel code). Relying on a varying implementation

Re: [Qemu-devel] [PATCH] integrator: fix Linux boot failure by emulating dbg

2013-10-17 Thread Alex Bennée
peter.mayd...@linaro.org writes: On 17 October 2013 17:12, Alex Bennée alex.ben...@linaro.org wrote: From: Alex Bennée a...@bennee.com Commit 9b8c69243 broke the ability to boot the kernel as the value snip Commit message, comment, overlength lines, lack of Copyright line still all

Re: [Qemu-devel] [PATCH v4 0/5] Fix UST backend for LTTng 2.x

2013-10-18 Thread Alex Bennée
mohamad.ge...@gmail.com writes: Version 4 * Update documentation Good stuff. I notice you haven't added my Reviewed-by tags to your commits. See http://wiki.qemu.org/Contribute/SubmitAPatch. Anyway it all looks good to me. Reviewed-by: Alex Bennée a...@bennee.com -- Alex Bennée

Re: [Qemu-devel] [PATCH v3] integrator: fix Linux boot failure by emulating dbg region

2013-10-18 Thread Alex Bennée
something? Nope, I obviously had thoughts of tracking the actual LED/Switch state and never added it in. +} IntegratorDebugState; Looks good otherwise. thanks -- PMM -- Alex Bennée

Re: [Qemu-devel] [PATCH v3] integrator: fix Linux boot failure by emulating dbg region

2013-10-18 Thread Alex Bennée
peter.mayd...@linaro.org writes: On 18 October 2013 12:45, alex.ben...@linaro.org wrote: From: Alex Bennée a...@bennee.com Commit 9b8c69243 (since reverted) broke the ability to boot the kernel as the value returned by unassigned_mem_read returned non-zero and left the kernel looping

Re: [Qemu-devel] Watching Resource consumption of guest from Qemu ?

2013-10-18 Thread Alex Bennée
it until the next event it has to deal with. -- Alex Bennée

Re: [Qemu-devel] [PATCH_v2 9/9] target-openrisc: Correct carry flagcheck of l.addc and l.addic test casess

2013-10-22 Thread Alex Bennée
targets need to be built somehow. Cheers, -- Alex Bennée

Re: [Qemu-devel] [PATCH for-1.7] configure: Explicitly set ARFLAGS sowe can build with GNU Make 4.00

2013-10-22 Thread Alex Bennée
peter.mayd...@linaro.org writes: Our rules.mak adds '-rR' to MAKEFLAGS to indicate that we will be explicitly specifying everything and not relying on any default variables or rules. s/sowe/so we/ Otherwise good. Reviewed-by: Alex Bennée a...@bennee.com -- Alex Bennée

Re: [Qemu-devel] [PATCH v4 1/5] Fix configure script for LTTng 2.x

2013-10-22 Thread Alex Bennée
? On my 12.04 system (with the lttng PPA) it works fine: $pkg-config --libs lttng-ust -llttng-ust -ldl $pkg-config --cflags lttng-ust -I/usr/include/x86_64-linux-gnu Is there a bug raised with the Ubuntu upstream to fix their stable LTTNG package? -- Alex Bennée

Re: [Qemu-devel] [PATCH_v2 9/9] target-openrisc: Correct carry flagcheck of l.addc and l.addic test casess

2013-10-22 Thread Alex Bennée
tests depending on Cross Compile support. -- Alex Bennée

Re: [Qemu-devel] [PATCH v5 4/5] Update documentation for LTTng ust tracing

2013-10-25 Thread Alex Bennée
mohamad.ge...@gmail.com writes: Signed-off-by: Mohamad Gebai mohamad.ge...@polymtl.ca All looks good to me now. Reviewed-by: Alex Bennée a...@bennee.com -- Alex Bennée

Re: [Qemu-devel] [PATCH 01/19] Add New softfloat Routines for VSX

2013-10-25 Thread Alex Bennée
these softfloat functions against unintentional breakage? It would certainly be worthwhile as soon as multiple arches use these functions as float errors are often subtle and hard to track down. -- Alex Bennée

Re: [Qemu-devel] [PATCH 01/19] Add New softfloat Routines for VSX

2013-10-25 Thread Alex Bennée
peter.mayd...@linaro.org writes: On 25 October 2013 12:34, Alex Bennée alex.ben...@linaro.org wrote: Is it worth adding some sort of test into make check to defend these softfloat functions against unintentional breakage? It would certainly be worthwhile as soon as multiple arches use

Re: [Qemu-devel] [PATCH v5 1/5] Fix configure script for LTTng 2.x

2013-10-25 Thread Alex Bennée
mohamad.ge...@gmail.com writes: Signed-off-by: Mohamad Gebai mohamad.ge...@polymtl.ca --- snip Tested on Ubuntu 12.04 with and without the LTTNG PPA and seems to work well enough. Reviewed-by: Alex Bennée a...@bennee.com -- Alex Bennée

Re: [Qemu-devel] [PATCH v5 1/5] Fix configure script for LTTng 2.x

2013-10-25 Thread Alex Bennée
mohamad.ge...@polymtl.ca writes: Signed-off-by: Mohamad Gebai mohamad.ge...@polymtl.ca --- snip Tested on Ubuntu 12.04 with and without the LTTNG PPA and seems to work well enough. Reviewed-by: Alex Bennée a...@bennee.com Yes, the bug is actually only in the Ubuntu package (missing

Re: [Qemu-devel] [PATCH v4] integrator: fix Linux boot failure by emulating dbg region

2013-10-26 Thread Alex Bennée
these unused fields. I've done so and added that slightly-edited patch to target-arm.next. Doh, sorry about that. Thanks. thanks -- PMM -- Alex Bennée

[Qemu-devel] Checking the state of arm64-linux-user

2013-10-29 Thread Alex Bennée
of issues while building. They are mostly -Werror bits and pieces which I can work through but as it doesn't build with the default QEMU build options I thought I'd better check if that is the correct latest/greatest version of the patch set. Regards, -- Alex Bennée

Re: [Qemu-devel] Checking the state of arm64-linux-user

2013-10-29 Thread Alex Bennée
peter.mayd...@linaro.org writes: On 29 October 2013 18:20, Alex Bennée alex.ben...@linaro.org wrote: I'm currently at Linaro Connect and am looking at running the arm64 stuff through Peter's risu tool and getting an idea of the instruction coverage. Alex pointed me to: https://github.com

Re: [Qemu-devel] [PATCH] .travis.yml: basic compile and check recipes

2013-09-18 Thread Alex Bennée
stefa...@gmail.com writes: Looks useful. To get more code coverage, flesh out the build environment: Thanks. Am I dreaming or are there some system image tests somewhere as well? -- Alex Bennée

Re: [Qemu-devel] [PATCH v2 1/1] integrator: fix Linux boot failure by emulating dbg

2013-09-18 Thread Alex Bennée
afaer...@suse.de writes: Am 18.09.2013 16:31, schrieb alex.ben...@linaro.org: Looks okay in general, some minor nits below: Thanks, I shall hopefully get those sorted out in the next week. -- Alex Bennée

Re: [Qemu-devel] [PATCH] .travis.yml: basic compile and check recipes

2013-09-19 Thread Alex Bennée
stefa...@gmail.com writes: On Wed, Sep 18, 2013 at 03:35:07PM +0100, Alex Bennée wrote: stefa...@gmail.com writes: Looks useful. To get more code coverage, flesh out the build environment: Thanks. Am I dreaming or are there some system image tests somewhere as well? Anthony

Re: [Qemu-devel] [PATCH 2/2] block: qemu-iotests for vhdx, read sample dynamic imagee

2013-09-20 Thread Alex Bennée
;-) I'm currently pondering what the best way of supporting system images (i.e. kernel+rootfs) would be to make system regression testing easier. Unfortunately those images would be far too large to carry in the repo although there may be some sub-module annex type thing I could try. -- Alex Bennée

Re: [Qemu-devel] [PATCH 2/2] block: qemu-iotests for vhdx, read sample dynamic imagee

2013-09-20 Thread Alex Bennée
kw...@redhat.com writes: Am 20.09.2013 um 11:10 hat Alex Bennée geschrieben: jc...@redhat.com writes: snip I'm currently pondering what the best way of supporting system images (i.e. kernel+rootfs) would be to make system regression testing easier. Unfortunately those images would

Re: [Qemu-devel] ChrEMU - Virtualization in the Browser

2013-09-23 Thread Alex Bennée
your use case is? Aside from an exercise in porting I don't know what else is to gain from going to NaCL. That's no reason not to try of course! -- Alex Bennée

Re: [Qemu-devel] [PATCH v2 0/0] .travis and minor compile fixes

2013-09-24 Thread Alex Bennée
the Travis tests then the branch should probably not be merged. -- Alex Bennée

Re: [Qemu-devel] [PATCH 3/3] block/stream.c: ensure copy always set

2013-09-24 Thread Alex Bennée
stefa...@redhat.com writes: On Mon, Sep 23, 2013 at 05:07:30PM +0100, alex.ben...@linaro.org wrote: From: Alex Bennée a...@bennee.com This only showed up when compiling with --enable-trace-backend=stderr|ftrace at which point the compiler complains with the following: nsip Stefan Weil

Re: [Qemu-devel] [PATCH] .travis.yml: basic compile and check recipes

2013-09-25 Thread Alex Bennée
of stable API. I hunted around a bit trying to get it working but realised the script needs fixing up as well so gave up. Really ust just needs to be ripped out for now unless someone else wants to dig into to supporting multiple versions painlessly. -- Alex Bennée

Re: [Qemu-devel] [PATCH] trace: drop LTTng Userspace Tracer backend

2013-09-26 Thread Alex Bennée
by: Alex Bennée a...@bennee.com -- Alex Bennée

Re: [Qemu-devel] [RFC PATCH v2 6/6] hw: arm_gic_kvm: Add KVM VGIC save/restore logic

2013-09-27 Thread Alex Bennée
aren't to be used else where? snip -- Alex Bennée

Re: [Qemu-devel] [PATCH v5 0/5] Fix UST backend for LTTng 2.x

2013-11-04 Thread Alex Bennée
to this or can it be merged into your maintainer tree? -- Alex Bennée

Re: [Qemu-devel] [PATCH v3 1/2] linux-user: create target_structsheader to place ipc_perm and shmid_dss

2013-11-04 Thread Alex Bennée
munging is common is there not an argument for having a common header for this case? -- Alex Bennée

Re: [Qemu-devel] [PATCH v3 1/2] linux-user: create target_structsheader to place ipc_perm and shmid_dss

2013-11-05 Thread Alex Bennée
petar.jovano...@imgtec.com writes: From: Alex Bennée [alex.ben...@linaro.org] snip There is an awful lot of similarity between a lot of the structures while not being totally identical. Given the syscall munging is common is there not an argument

Re: [Qemu-devel] [PATCH] integrator/cp: add support for REFCNTregisterr

2013-11-05 Thread Alex Bennée
time I ran it I found it had regressed also ;-) -- Alex Bennée

Re: [Qemu-devel] [PATCH for-1.8 61/61] target-i386: Deconstruct thecpu_T arrayy

2013-11-07 Thread Alex Bennée
? -- Alex Bennée

Re: [Qemu-devel] [RFC] target-arm: provide skeleton for a64 insn decoding

2013-11-12 Thread Alex Bennée
patch has been started during Linaro Connect by me and Alex Bennee. snip With the proviso of Richard's decode comment you can add: Reviewed-by: Alex Bennée a...@bennee.com Signed-of-by: Alex Bennée a...@bennee.com -- Alex Bennée

Re: [Qemu-devel] [PATCH] qemu-img: set nocow flag to new file

2013-11-14 Thread Alex Bennée
should probably warn the user about that. -- Alex Bennée

Re: [Qemu-devel] [PATCH 02/13] target-arm: A64: add support for logical (shifted register)

2013-12-06 Thread Alex Bennée
(register) canonical for ORR (rn=31 shift_amount=0), and MVN (register) canonical for ORN (rn=31 shift_amount=0), and both therefore also worth a special case? I suspect I'm being overly cheeky to expect the optimiser to detect and optimise for that case as the ZR is a const ;-) Cheers, -- Alex

Re: [Qemu-devel] save compiled qemu traces.

2013-12-09 Thread Alex Bennée
to do some performance analysis and come up with some numbers before you made that assumption. Cheers, -- Alex Bennée QEMU/KVM Hacker for Linaro

Re: [Qemu-devel] save compiled qemu traces.

2013-12-10 Thread Alex Bennée
thought Xin was talking about caching translations between invocations of QEMU. I suspect address space randomisation would be another wrinkle in the side of any such scheme though. thanks -- PMM -- Alex Bennée QEMU/KVM Hacker for Linaro

Re: [Qemu-devel] [PATCH 2/9] target-arm: A64: add support for ldp (load pair)

2013-12-10 Thread Alex Bennée
ldst patches did get a little gnarly thanks to the structure of the original decoder and I wanted to avoid things like imm fields being optionally chopped apart depending on the decode. -- Alex Bennée QEMU/KVM Hacker for Linaro

Re: [Qemu-devel] [PATCH 1/9] target-arm: A64: add support for stp (store pair)

2013-12-10 Thread Alex Bennée
better as tcg_gen_addi_i64(tcg_addr, tcg_addr, (postindex ? offset : 0) - (1 size)); I'm not so sure it's easier to follow despite my general proclivity for ternary operator. ? r~ -- Alex Bennée QEMU/KVM Hacker for Linaro

Re: [Qemu-devel] [PATCH 3/9] target-arm: A64: add support for ld/st unsigned imm

2013-12-10 Thread Alex Bennée
r...@twiddle.net writes: On 12/09/2013 10:12 AM, Peter Maydell wrote: From: Alex Bennée alex.ben...@linaro.org snip +static TCGv_i64 read_cpu_reg_sp(DisasContext *s, int reg, int sf) +{ +TCGv_i64 v = new_tmp_a64(s); +if (sf) { +tcg_gen_mov_i64(v, cpu_X[reg

Re: [Qemu-devel] [PATCH 4/9] target-arm: A64: add support for ld/st with reg offset

2013-12-10 Thread Alex Bennée
r...@twiddle.net writes: On 12/09/2013 10:12 AM, Peter Maydell wrote: From: Alex Bennée alex.ben...@linaro.org This adds support for the load/store forms using a register offset. snip +/* + * C3.3.10 Load/store (register offset) + * + * 31 30 29 27 26 25 24 23 22 21 20 16 15 13

Re: [Qemu-devel] [PATCH 2/9] target-arm: A64: add support for ldp (load pair)

2013-12-10 Thread Alex Bennée
r...@twiddle.net writes: On 12/10/2013 05:59 AM, Alex Bennée wrote: +if (extend is_signed) { +g_assert(size 3); +tcg_gen_ext32u_i64(dest, dest); +} Is it worth noticing in size==2 !extend that is_signed can be forced false to avoid the extra extension

Re: [Qemu-devel] [PATCH] qemu-img: set nocow flag to new file

2013-12-10 Thread Alex Bennée
to issue a warning (when not --quiet) when it detects creation of an image on a partition where performance may not be as expected due to COW behaviour. Cheers, -- Alex Bennée QEMU/KVM Hacker for Linaro

Re: [Qemu-devel] Qemu on android

2013-12-11 Thread Alex Bennée
the information? The hard dependency on glib has been in quite some time (e18df14185e817ba735bce57ecdef9a55fb3d093) so I don't think you can build without it. However it should be possible to build glib for android and bundle it with your qemu if needed. Thanks, Tervel -- Alex Bennée QEMU/KVM

Re: [Qemu-devel] [PATCH 4/9] target-arm: A64: add support for ld/st with reg offset

2013-12-11 Thread Alex Bennée
r...@twiddle.net writes: On 12/10/2013 06:16 AM, Alex Bennée wrote: However my preference unless there is a strong objection would be to clean that up in later patches. For one thing the more instructions each patch handles the longer it takes to run the instruction validation on the rather

Re: [Qemu-devel] [PATCH v2 1/8] target-arm: A64: add support for ld/st pair

2013-12-12 Thread Alex Bennée
catch. I suspect it never hits though (or risu doesn't generate enough unallocated versions). -- Alex Bennée QEMU/KVM Hacker for Linaro

Re: [Qemu-devel] [PATCH] target-sh4: Use new qemu_ld/st opcodes

2013-12-13 Thread Alex Bennée
-memidx); +tcg_gen_qemu_st_i32(REG(B7_4), addr, ctx-memidx, MO_TEUL); tcg_temp_free(addr); snip There seems to be a fix of tabs and spaces in that patch. -- Alex Bennée QEMU/KVM Hacker for Linaro

[Qemu-devel] Enabling Travis for the QEMU Mirror?

2013-12-18 Thread Alex Bennée
,then Service Hooks and selecting Travis. Basically you just need to go to http://travis-ci.org and click the Sign in with GitHub link and your up and running. It's super easy. -- Alex Bennée QEMU/KVM Hacker for Linaro

Re: [Qemu-devel] Enabling Travis for the QEMU Mirror?

2013-12-18 Thread Alex Bennée
peter.mayd...@linaro.org writes: On 18 December 2013 11:32, Alex Bennée alex.ben...@linaro.org wrote: Now we have a .travis.yml merged into master can we enable Travis to run in the QEMU mirror on github (https://github.com/qemu/qemu)? I'm happy to talk who ever controls that repo through

Re: [Qemu-devel] [PATCH 2/3] target-arm: A64: fix TLB flush instructions

2014-07-25 Thread Alex Bennée
Peter Maydell writes: On 24 July 2014 16:52, Alex Bennée alex.ben...@linaro.org wrote: +/* See: D4.7.2 TLB maintenance requirements and the TLB maintenance instructions + * Page D4-1736 (DDI0487A.b) For TLB maintenance instructions that + * take an address, the maintenance of VA[63:56

Re: [Qemu-devel] [questions] about qemu log

2014-07-25 Thread Alex Bennée
/path/to/unique/file/name.log Or am I misunderstanding what you want? -- Alex Bennée

[Qemu-devel] [PATCH v2 4/5] scripts/make_device_config.sh: inline includes

2014-07-30 Thread Alex Bennée
their config include arm-softmmu.mak # we explicitly disable ones that require old ARMv5 support CONFIG_ARMV5_BOARDS=n Signed-off-by: Alex Bennée alex.ben...@linaro.org diff --git a/scripts/make_device_config.sh b/scripts/make_device_config.sh index 7242707..b0d0b51 100644 --- a/scripts

[Qemu-devel] [PATCH v2 0/5] AArch64 TLB performance improvements

2014-07-30 Thread Alex Bennée
Hi, Not too much has changed: * added a review tag * fixed up review comments * added some notes about benchmark results * added a patch to disable ARMv5 in AArch64 build The most important thing is I've measured a 25-30% improvement in kernel and android boot time. Alex Bennée (5

[Qemu-devel] [PATCH v2 3/5] target-arm: A64: fix use 12 bit page tables for AArch64

2014-07-30 Thread Alex Bennée
. Signed-off-by: Alex Bennée alex.ben...@linaro.org --- v2: - fix AArch64 references - add benchmark notes to commit msg diff --git a/target-arm/cpu.h b/target-arm/cpu.h index c83f249..83df513 100644 --- a/target-arm/cpu.h +++ b/target-arm/cpu.h @@ -1051,11 +1051,18 @@ bool

[Qemu-devel] [PATCH v2 2/5] target-arm: A64: fix TLB flush instructions

2014-07-30 Thread Alex Bennée
According to the ARM ARM we weren't correctly flushing the TLB entries where bits 63:56 didn't match bit 55 of the virtual address. This exposed a problem when we switched QEMU's internal TARGET_PAGE_BITS to 12 for aarch64. Signed-off-by: Alex Bennée alex.ben...@linaro.org Reviewed-by: Peter

[Qemu-devel] [PATCH v2 5/5] target-arm: A64: disable a bunch of ARMv5 machines

2014-07-30 Thread Alex Bennée
If you attempt to run a system image which uses 1k pages in the qemu-system-aarch64 build it will fail thanks to the change to 12 bit pages. The boards are still available for the qemu-system-arm build. Signed-off-by: Alex Bennée alex.ben...@linaro.org diff --git a/default-configs/aarch64

[Qemu-devel] [PATCH v2 1/5] target-arm: don't hardcode mask values in arm_cpu_handle_mmu_fault

2014-07-30 Thread Alex Bennée
Otherwise we break quickly when we change TARGET_PAGE_SIZE. Signed-off-by: Alex Bennée alex.ben...@linaro.org diff --git a/target-arm/helper.c b/target-arm/helper.c index a0e57cd..aa5d267 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -4029,8 +4029,8 @@ int

[Qemu-devel] [PATCH v3 6/9] qemu-log: support simple pid substitution in logfile

2014-07-31 Thread Alex Bennée
When debugging stuff that occurs over several forks it would be useful not to keep overwriting the one logfile you've set-up. This allows a simple %d to be included once in the logfile parameter which is substituted with getpid(). Signed-off-by: Alex Bennée alex.ben...@linaro.org Reviewed

[Qemu-devel] [PATCH v3 1/9] tcg: add ability to dump /tmp/perf-pid.map files

2014-07-31 Thread Alex Bennée
This allows the perf tool to map samples to each individual translation block. This could be expanded for user space but currently it gives enough information to find any hotblocks by other means. Signed-off-by: Alex Bennée alex.ben...@linaro.org --- v2: - hoist up into translate-all.c

[Qemu-devel] [PATCH v3 9/9] target-arm: dfilter support for in_asm, op, opt_op

2014-07-31 Thread Alex Bennée
Each individual architecture needs to use the qemu_log_in_addr_range() feature for enabling in_asm and marking blocks for op/opt_op output. Signed-off-by: Alex Bennée alex.ben...@linaro.org diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c index 33b5025..56b8534 100644

[Qemu-devel] [PATCH v3 7/9] qemu-log: new option -dfilter to limit output

2014-07-31 Thread Alex Bennée
-0x9000,0xffc8+0x200,... Then logging code can use the new qemu_log_in_addr_range() function to decide if it will output logging information for the given range. Signed-off-by: Alex Bennée alex.ben...@linaro.org v2 - More clean-ups to the documentation v3 - re-base - use GArray

[Qemu-devel] [PATCH v3 8/9] qemu-log: dfilter-ise exec, out_asm, and op_opt

2014-07-31 Thread Alex Bennée
This ensures the code generation debug code will honour -dfilter if set. For the exec tracing I've added a new inline macro for efficiency's sake. I've not touched CPU_LOG_TB_OP as this is buried in each individual target. Signed-off-by: Alex Bennée alex.ben...@linaro.org v2

[Qemu-devel] [PATCH v3 3/9] qemu-log: correct help text for -d cpu

2014-07-31 Thread Alex Bennée
This doesn't just dump CPU state on translation but on every block entrance. Signed-off-by: Alex Bennée alex.ben...@linaro.org diff --git a/qemu-log.c b/qemu-log.c index 797f2af..35bbb56 100644 --- a/qemu-log.c +++ b/qemu-log.c @@ -105,7 +105,7 @@ const QEMULogItem qemu_log_items

[Qemu-devel] [PATCH v3 2/9] tcg: light re-factor and pass down TranslationBlock

2014-07-31 Thread Alex Bennée
to compliment the tc_ptr (and the subject pc, block size). This is set on code generation and then accessed directly by all the people that need it. I've also cleaned up some comments and removed un-used return variables. Signed-off-by: Alex Bennée alex.ben...@linaro.org --- v1 - checkpatch fixes diff

[Qemu-devel] [PATCH v3 0/9] qemu-log dfilter and perf.map changes

2014-07-31 Thread Alex Bennée
chain flag - move perf.map stuff up into translate-all.c - include prolog/epilog in the perf.map dump - include tc_size in TranslationBlock - cleaned up documentation of the -dfilter params - used GArray instead of GList for debug_regions Alex Bennée (7): tcg: add ability to dump /tmp

[Qemu-devel] [PATCH v3 4/9] qemu-log: Avoid function call for disabled qemu_log_mask logging

2014-07-31 Thread Alex Bennée
From: Peter Maydell peter.mayd...@linaro.org Make qemu_log_mask() a macro which only calls the function to do the actual work if the logging is enabled. This avoids making a function call in possible fast paths where logging is disabled. Signed-off-by: Peter Maydell peter.mayd...@linaro.org

[Qemu-devel] [PATCH v3 5/9] qemu-log: Improve the exec TB execution logging

2014-07-31 Thread Alex Bennée
[ffcdce70] Trace 0x7fb7cc8235d0 [ffcdce70] Abandoned execution of TB chain before 0x7fb7cc8235d0 [ffcdce70] Trace 0x7fb7cc8235d0 [ffcdce70] Trace 0x7fb7cc822fd0 [ffcdd52c] Signed-off-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Alex Bennée alex.ben...@linaro.org

Re: [Qemu-devel] [RFC PATCH v3 15/49] softmmu: fixing usage of cpu_st/ld* from helpers

2014-07-31 Thread Alex Bennée
the glue magic (not your fault ;-) we have in QEMU. However wouldn't it be simpler for the helper pre-amble code to ensure the subject pc is updated in the CPU environment? Can QEMU only rectify the processor state from a TranlationBlock tc address? -- Alex Bennée

Re: [Qemu-devel] [RFC PATCH v3 16/49] target-i386: update fp status fix

2014-07-31 Thread Alex Bennée
); cpu_watchpoint_remove_all(cs, BP_CPU); -- Alex Bennée

Re: [Qemu-devel] [RFC PATCH v3 22/49] cpu: invent instruction count for accurate replay

2014-07-31 Thread Alex Bennée
{ +replay_state.skipping_instruction = 1; +} I'm not quite following what instructions_count means here. Is it an actual count of instructions executed? Can you add a comment to the header where it's defined? -- Alex Bennée

Re: [Qemu-devel] [PATCH v2 1/3] trace: teach lttng backend to use format strings

2014-08-01 Thread Alex Bennée
Alex Bennée writes: This makes the UST backend pay attention to the format string arguments that are defined when defining payload data. With this you can now ensure integers are reported in hex mode if you want. snip Ping Stefan, can this one at least be slurped up into your tracing tree

[Qemu-devel] [PATCH v3 1/2] trace: teach lttng backend to use format strings

2014-08-01 Thread Alex Bennée
This makes the UST backend pay attention to the format string arguments that are defined when defining payload data. With this you can now ensure integers are reported in hex mode if you want. Signed-off-by: Alex Bennée alex.ben...@linaro.org --- v2 - remove silly debug statements v3 - fix

[Qemu-devel] [PATCH v3 2/2] trace: add some tcg tracing support

2014-08-01 Thread Alex Bennée
complete tracing at the expense of performance. Signed-off-by: Alex Bennée alex.ben...@linaro.org --- v2 - rebase v3: - checkpatch clean-ups - add sign-off - disable exec_tb by default diff --git a/cpu-exec.c b/cpu-exec.c index 38e5f02..d209568 100644 --- a/cpu-exec.c +++ b/cpu-exec.c

[Qemu-devel] [PATCH v3 0/2] a few simple trace fixes

2014-08-01 Thread Alex Bennée
Hi Stefan, I've re-based these two on tracing-next. Otherwise now changes from the last post. Alex Bennée (2): trace: teach lttng backend to use format strings trace: add some tcg tracing support cpu-exec.c | 6 ++ scripts/tracetool/__init__.py

[Qemu-devel] [PATCH v4 0/2] a few simple trace fixes

2014-08-01 Thread Alex Bennée
Hi Stefan, As v3 posted earlier today but with a format string fix which didn't show up in the ust build I tested it on Alex Bennée (2): trace: teach lttng backend to use format strings trace: add some tcg tracing support cpu-exec.c | 6 ++ scripts

  1   2   3   4   5   6   7   8   9   10   >