[Qemu-devel] [RFC] Add a stp file for usage from build directory

2013-05-26 Thread Alon Levy
For systemtap the location of the process being tapped is crucial, so the existing stp file requires installation to use. A new file providing qemu.local prefixed probes lets scripts run without an install step. Signed-off-by: Alon Levy al...@redhat.com --- Makefile.target | 13 - 1

Re: [Qemu-devel] [RFC] Add a stp file for usage from build directory

2013-05-28 Thread Alon Levy
On Mon, 2013-05-27 at 08:32 +0200, Paolo Bonzini wrote: Il 27/05/2013 04:19, Alon Levy ha scritto: For systemtap the location of the process being tapped is crucial, so the existing stp file requires installation to use. A new file providing qemu.local prefixed probes lets scripts run

Re: [Qemu-devel] [RFC] Add a stp file for usage from build directory

2013-05-28 Thread Alon Levy
On Tue, 2013-05-28 at 14:18 +0200, Paolo Bonzini wrote: Il 28/05/2013 14:09, Alon Levy ha scritto: + --probe-prefix=qemu.local \ Why change the prefix? It was one way to verify I was using the correct file. I'll change it back. But in general does it make sense for you

Re: [Qemu-devel] [RFC] Add a stp file for usage from build directory

2013-05-28 Thread Alon Levy
Il 28/05/2013 14:33, Alon Levy ha scritto: On Tue, 2013-05-28 at 14:18 +0200, Paolo Bonzini wrote: Il 28/05/2013 14:09, Alon Levy ha scritto: + --probe-prefix=qemu.local \ Why change the prefix? It was one way to verify I was using the correct file. I'll change

Re: [Qemu-devel] [RFC] Add a stp file for usage from build directory

2013-05-28 Thread Alon Levy
On Tue, 2013-05-28 at 09:25 -0400, Alon Levy wrote: Il 28/05/2013 14:33, Alon Levy ha scritto: On Tue, 2013-05-28 at 14:18 +0200, Paolo Bonzini wrote: Il 28/05/2013 14:09, Alon Levy ha scritto: + --probe-prefix=qemu.local \ Why change the prefix? Actually the problem

[Qemu-devel] [PATCH] Add a stp file for usage from build directory

2013-05-28 Thread Alon Levy
-I $(TARGET_DIR) .. Signed-off-by: Alon Levy al...@redhat.com --- Makefile.target | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/Makefile.target b/Makefile.target index ce4391f..54687e2 100644 --- a/Makefile.target +++ b/Makefile.target @@ -35,7 +35,7

[Qemu-devel] [PATCH v2] Add a stp file for usage from build directory

2013-05-28 Thread Alon Levy
, usable without installation To use: stap -I $(TARGET_DIR) ... Signed-off-by: Alon Levy al...@redhat.com --- Makefile.target | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/Makefile.target b/Makefile.target index ce4391f

[Qemu-devel] [PATCH] libcacard/vscclient: fix leakage of socket on error paths

2013-05-31 Thread Alon Levy
Spotted by Coverity. Signed-off-by: Alon Levy al...@redhat.com --- libcacard/vscclient.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c index ac23647..9fcc548 100644 --- a/libcacard/vscclient.c +++ b/libcacard/vscclient.c

Re: [Qemu-devel] [PATCH] libcacard/vscclient: fix leakage of socket on error paths

2013-05-31 Thread Alon Levy
Spotted by Coverity. Self NACK. I'll send a more complete patch, and use closesocket. Signed-off-by: Alon Levy al...@redhat.com --- libcacard/vscclient.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c index

[Qemu-devel] [PATCH 1/5] oslib-posix: add qemu_pipe_non_block

2013-06-04 Thread Alon Levy
Used by the followin patch. Signed-off-by: Alon Levy al...@redhat.com --- include/qemu-common.h | 1 + util/oslib-posix.c| 19 +++ 2 files changed, 20 insertions(+) diff --git a/include/qemu-common.h b/include/qemu-common.h index cb82ef3..c24d75c 100644 --- a/include/qemu

[Qemu-devel] [PATCH 2/5] use qemu_pipe_non_block

2013-06-04 Thread Alon Levy
This fixes six instances of unchecked fcntl return status, spotted by Coverity. Signed-off-by: Alon Levy al...@redhat.com --- hw/display/qxl.c| 10 +++--- hw/usb/ccid-card-emulated.c | 8 +++- 2 files changed, 6 insertions(+), 12 deletions(-) diff --git a/hw/display/qxl.c b

[Qemu-devel] [PATCH 4/5] libcacard/vreader.c: fix possible NULL dereference

2013-06-04 Thread Alon Levy
: var_deref_op: Dereferencing null pointer response. Signed-off-by: Alon Levy al...@redhat.com --- libcacard/vreader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libcacard/vreader.c b/libcacard/vreader.c index 5793d73..60eb43b 100644 --- a/libcacard/vreader.c +++ b/libcacard/vreader.c

[Qemu-devel] [PATCH 3/5] libcacard/vscclient: fix leakage of socket on error paths

2013-06-04 Thread Alon Levy
Spotted by Coverity. Signed-off-by: Alon Levy al...@redhat.com --- libcacard/vscclient.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c index ac23647..5180d29 100644 --- a/libcacard/vscclient.c +++ b/libcacard

[Qemu-devel] [PATCH 5/5] libcacard/vscclient.c: fix use of uninitialized variable

2013-06-04 Thread Alon Levy
Found by Coverity. Signed-off-by: Alon Levy al...@redhat.com --- libcacard/vscclient.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c index 5180d29..4275c23 100644 --- a/libcacard/vscclient.c +++ b/libcacard/vscclient.c @@ -645,7

Re: [Qemu-devel] [PATCH 2/5] use qemu_pipe_non_block

2013-06-04 Thread Alon Levy
On 4 June 2013 21:23, Alon Levy al...@redhat.com wrote: --- a/hw/display/qxl.c +++ b/hw/display/qxl.c @@ -1797,15 +1797,11 @@ static void qxl_send_events(PCIQXLDevice *d, uint32_t events) static void init_pipe_signaling(PCIQXLDevice *d) { -if (pipe(d-pipe) 0

Re: [Qemu-devel] [PATCH 2/5] use qemu_pipe_non_block

2013-06-04 Thread Alon Levy
Il 04/06/2013 22:23, Alon Levy ha scritto: This fixes six instances of unchecked fcntl return status, spotted by Coverity. I think we're just assuming that they cannot fail... I don't think we need the previous patch and this one, unless they help porting stuff to Windows

Re: [Qemu-devel] [PATCH 1/5] oslib-posix: add qemu_pipe_non_block

2013-06-04 Thread Alon Levy
On 06/04/2013 02:23 PM, Alon Levy wrote: Used by the followin patch. s/followin/following/ Thanks. +int qemu_pipe_non_block(int pipefd[2]) +{ +int ret; + +ret = qemu_pipe(pipefd); qemu_pipe() already uses pipe2() when available; it seems like it would be nicer

Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/5] oslib-posix: add qemu_pipe_non_block

2013-06-12 Thread Alon Levy
05.06.2013 00:23, Alon Levy wrote: [PATCH 1/5] oslib-posix: add qemu_pipe_non_block [PATCH 2/5] use qemu_pipe_non_block [PATCH 3/5] libcacard/vscclient: fix leakage of socket on error paths [PATCH 4/5] libcacard/vreader.c: fix possible NULL dereference [PATCH 5/5] libcacard

Re: [Qemu-devel] [PATCH] qxl: replace pipe signaling with bottom half

2013-10-30 Thread Alon Levy
it up. Signed-off-by: Gerd Hoffmann kra...@redhat.com Reviewed-by: Alon Levy al...@redhat.com --- hw/display/qxl.c | 33 +++-- hw/display/qxl.h | 3 +-- 2 files changed, 4 insertions(+), 32 deletions(-) diff --git a/hw/display/qxl.c b/hw/display/qxl.c

Re: [Qemu-devel] [PATCH 0/2] Try to fix problem with emulated smartcards where invalid PIN succeeds

2013-09-08 Thread Alon Levy
I started writing a blog post yesterday about virtualized smartcards here: https://blogs.gnome.org/halfline/2013/09/08/another-smartcard-post/ and while testing what I was writing I noticed an invalid PIN worked when it shouldn't have. It turns out that typing a valid PIN once in one

Re: [Qemu-devel] [PATCH 1/1] spice: fix display initialization

2013-07-30 Thread Alon Levy
qxl-vga goes unnoticed. Fix that by adding a check in the spice interface registration so we'll notice the qxl card no matter how it is created. https://bugzilla.redhat.com/show_bug.cgi?id=981094 Reviewed-by: Alon Levy al...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com

[Qemu-devel] [PATCH] libcacard/vreader: remove never used define

2013-08-06 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- libcacard/vreader.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libcacard/vreader.c b/libcacard/vreader.c index 60eb43b..fd1a9ac 100644 --- a/libcacard/vreader.c +++ b/libcacard/vreader.c @@ -21,8 +21,6 @@ #include vevent.h #include cac.h

Re: [Qemu-devel] [PATCH 05/21] char: add qemu_chr_fe_event()

2013-11-18 Thread Alon Levy
On 11/18/2013 02:25 PM, Marc-André Lureau wrote: From: Marc-André Lureau marcandre.lur...@redhat.com The patch description is incomplete, or the patch should be split - this patch also implements qemu_chr_fe_event for spiceport. Signed-off-by: Marc-André Lureau marcandre.lur...@redhat.com

Re: [Qemu-devel] [Spice-devel] [PATCH 20/21] spice-core: allow an interface to be in AIO context

2013-11-18 Thread Alon Levy
On 11/18/2013 02:25 PM, Marc-André Lureau wrote: The Spice block driver must be able complete operations within a AIO context only. Spice is currently only running within the main loop, and doesn't allow the block driver to complete operations, such as flush during migration. This patch

[Qemu-devel] [PATCH] make screendump an async command

2013-06-13 Thread Alon Levy
, with the linux qxl driver you get garbage still, just not out of date garbage. Signed-off-by: Alon Levy al...@redhat.com --- hmp.c | 2 +- hw/display/qxl-render.c | 1 + hw/display/vga.c | 1 + include/qapi/qmp/qerror.h | 6 + include/ui/console.h | 10

Re: [Qemu-devel] [PATCH] make screendump an async command

2013-06-13 Thread Alon Levy
Il 13/06/2013 15:27, Alon Levy ha scritto: This fixes the broken screendump behavior for qxl devices in native mode since 81fb6f1504fb9ef71f2382f44af34756668296e8. Note: due to QAPI not generating async commands yet I had to remove the schema screendump definition. Related RHBZ

Re: [Qemu-devel] [PATCH] make screendump an async command

2013-06-14 Thread Alon Levy
Hi, Note: due to QAPI not generating async commands yet I had to remove the schema screendump definition. Hmm, that will break libvirt I suspect. Guess this one has to wait until QAPI gained proper async command support. It doesn't break anything. I've tested, and here is the QMP

Re: [Qemu-devel] [PATCH] make screendump an async command

2013-06-14 Thread Alon Levy
Hi, Note: due to QAPI not generating async commands yet I had to remove the schema screendump definition. Hmm, that will break libvirt I suspect. Guess this one has to wait until QAPI gained proper async command support. It doesn't break anything. I've tested, To clarify, I

Re: [Qemu-devel] [PATCH] make screendump an async command

2013-06-14 Thread Alon Levy
On Fri, 2013-06-14 at 13:21 -0500, Anthony Liguori wrote: Alon Levy al...@redhat.com writes: This fixes the broken screendump behavior for qxl devices in native mode since 81fb6f1504fb9ef71f2382f44af34756668296e8. Note: due to QAPI not generating async commands yet I had to remove

Re: [Qemu-devel] [PATCH] make screendump an async command

2013-06-17 Thread Alon Levy
On Mon, 2013-06-17 at 08:06 +0200, Gerd Hoffmann wrote: Hi, Why is QXL unable to do a synchronous screendump? Lazy rendering. By default spice-server doesn't render anything, it just sends over all drawing ops to the client who does the actual rendering for the user. qemu can kick

Re: [Qemu-devel] [PATCH] spice: flip streaming video mode to off by default

2013-12-02 Thread Alon Levy
what it thinks is a video stream. Turn off video detection by default to avoid these artifacts. Reviewed-by: Alon Levy al...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/spice-core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ui/spice-core.c b/ui/spice

Re: [Qemu-devel] [PATCH v2] libcacard: Fix compilation for older versions of glib (bug #1258168)

2013-12-08 Thread Alon Levy
On 12/05/2013 08:41 PM, Stefan Weil wrote: See https://bugs.launchpad.net/bugs/1258168 libcacard/vscclient.c: In function 'do_socket_read': libcacard/vscclient.c:410: warning: implicit declaration of function 'g_warn_if_reached' libcacard/vscclient.c:410: warning: nested extern declaration

[Qemu-devel] [PULL] libcacard fixes

2013-12-09 Thread Alon Levy
Anthony, The following changes since commit a1d22a367d5780c9553b2cd5a24f665534ce6ed6: target-cris: Use new qemu_ld/st opcodes (2013-12-08 09:36:02 +0100) are available in the git repository at: git://people.freedesktop.org/~alon/qemu libcacard_ccid.4 for you to fetch changes up to

[Qemu-devel] [PULL] libcacard: Fix compilation for older versions of glib (bug #1258168)

2013-12-09 Thread Alon Levy
From: Stefan Weil s...@weilnetz.de See https://bugs.launchpad.net/bugs/1258168 libcacard/vscclient.c: In function 'do_socket_read': libcacard/vscclient.c:410: warning: implicit declaration of function 'g_warn_if_reached' libcacard/vscclient.c:410: warning: nested extern declaration of

Re: [Qemu-devel] [PATCH] monitor: add usb_detach

2010-10-10 Thread Alon Levy
didn't need it right now, my device attaches itself based on a external event. Regards, Anthony Liguori On 10/05/2010 09:40 AM, Alon Levy wrote: Signed-off-by: Alon Levyal...@redhat.com --- qemu-monitor.hx | 17 + sysemu.h|1 + vl.c

Re: [Qemu-devel] [PATCH] monitor: add usb_detach

2010-10-11 Thread Alon Levy
- Gerd Hoffmann kra...@redhat.com wrote: On 10/10/10 13:12, Alon Levy wrote: - Anthony Liguorianth...@codemonkey.ws wrote: How is this different than usb_del? Is it that it detaches it but does not delete the device? yes. There is no usb_attach command because

[Qemu-devel] [PATCH 0/2] usb-ccid device (v2)

2010-10-12 Thread Alon Levy
causes the updated vscclient to connect to one port higher on the same host. will add monitor commands in a separate patch. tested with current setup. Alon Levy (2): usb-ccid: add CCID device. add configure option. usb-ccid: add CCID device (device itself) Makefile.objs |1

[Qemu-devel] [PATCH 1/2] usb-ccid: add CCID device. add configure option.

2010-10-12 Thread Alon Levy
This patch adds the configure option --enable-smartcard, adds hw/usb-ccid.c to Makefile.objs, and adds the documentation. Only an empty hw/usb-ccid.c is provided (couldn't add an empty file so added initial comment only). Signed-off-by: Alon Levy al...@redhat.com --- Makefile.objs |1

[Qemu-devel] [PATCH 2/2] usb-ccid: add CCID device (device itself)

2010-10-12 Thread Alon Levy
home) written by Robert Relyea rrel...@redhat.com [2] http://www.usb.org/developers/devclass_docs/DWG_Smart-Card_CCID_Rev110. Signed-off-by: Alon Levy al...@redhat.com --- hw/usb-ccid.c | 1363 + 1 files changed, 1363 insertions(+), 0

Re: [Qemu-devel] [PATCH 0/2] usb-ccid device (v2)

2010-10-12 Thread Alon Levy
- Anthony Liguori anth...@codemonkey.ws wrote: On 10/12/2010 07:58 AM, Alon Levy wrote: This patch adds a new device, it is described in full in the second patch intro and also in the documentation in docs. In brief it provides a standard smart card reader device. The first

Re: [Qemu-devel] [PATCH 0/2] usb-ccid device (v2)

2010-10-12 Thread Alon Levy
- Anthony Liguori anth...@codemonkey.ws wrote: On 10/12/2010 11:03 AM, Alon Levy wrote: - Anthony Liguorianth...@codemonkey.ws wrote: On 10/12/2010 07:58 AM, Alon Levy wrote: This patch adds a new device, it is described in full in the second patch

Re: [Qemu-devel] [PATCH 0/2] usb-ccid device (v2)

2010-10-12 Thread Alon Levy
- Anthony Liguori anth...@codemonkey.ws wrote: On 10/12/2010 11:43 AM, Alon Levy wrote: - Anthony Liguorianth...@codemonkey.ws wrote: On 10/12/2010 11:03 AM, Alon Levy wrote: - Anthony Liguorianth...@codemonkey.ws wrote: On 10/12/2010 07:58

Re: [Qemu-devel] [PATCH 0/2] usb-ccid device (v2)

2010-10-13 Thread Alon Levy
- Anthony Liguori anth...@codemonkey.ws wrote: On 10/12/2010 12:09 PM, Alon Levy wrote: The smart card is not being migrated. It is running on the client machine, which is not being migrated/shutdown (same as vncviewer isn't migrated). Ok, let's look at this compared

Re: [Qemu-devel] Re: [PATCH] [RFC] Add support for a USB audio device model

2010-10-14 Thread Alon Levy
- H. Peter Anvin h...@zytor.com wrote: On 10/14/2010 06:51 AM, Mike Snitzer wrote: Was just wondering if you've been able to put some time to the rate-matching issues? Has this usb-audio patch evolved and I'm just missing it? Thanks for doing this work! Mike The sad

[Qemu-devel] [PATCH 0/2] usb-ccid (v3)

2010-10-17 Thread Alon Levy
. tested with current setup. Alon Levy (2): usb-ccid: add CCID bus ccid: add passthru card device Makefile.objs |1 + configure | 12 + hw/ccid-card-passthru.c | 284 ++ hw/ccid.h | 34 ++ hw/usb-ccid.c | 1349

[Qemu-devel] [PATCH 2/2] ccid: add passthru card device

2010-10-17 Thread Alon Levy
For the client side utility vscclient, see libcac_card: libcac_card http://cgit.freedesktop.org/~alon/cac_card (temporary home) written by Robert Relyea rrel...@redhat.com Signed-off-by: Alon Levy al...@redhat.com --- Makefile.objs |2 +- hw/ccid-card-passthru.c | 284

[Qemu-devel] [PATCH 1/2] usb-ccid: add CCID bus

2010-10-17 Thread Alon Levy
-Card_CCID_Rev110. Signed-off-by: Alon Levy al...@redhat.com --- Makefile.objs |1 + configure | 12 + hw/ccid.h | 34 ++ hw/usb-ccid.c | 1349 + 4 files changed, 1396 insertions(+), 0 deletions(-) create mode 100644 hw/ccid.h create

[Qemu-devel] [PATCH 0/1] ccid emulated card (v1, for usb-ccid v3)

2010-10-18 Thread Alon Levy
-smartcard configure: dependency on libcac_card if --enable-smartcard hw/usb-ccid.c: added a TODO note hw/ccid-card-passthru.c: removed does-nothing print method. Alon Levy (1): add ccid-card-emulated device Makefile.objs |2 +- configure | 20 ++ hw/ccid-card

[Qemu-devel] [PATCH 1/1] add ccid-card-emulated device

2010-10-18 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- Makefile.objs |2 +- configure | 20 ++ hw/ccid-card-emulated.c | 497 +++ hw/ccid-card-passthru.c |6 - hw/usb-ccid.c |2 + 5 files changed, 520 insertions

[Qemu-devel] [PATCH 1/3] qdev: make qdev_find_recursive public

2010-10-19 Thread Alon Levy
--- hw/qdev.c |2 +- hw/qdev.h |1 + 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index 35858cb..d669a9d 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -477,7 +477,7 @@ static BusState *qbus_find_recursive(BusState *bus, const char *name, return

[Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v2)

2010-10-19 Thread Alon Levy
usb_device_by_id Alon Levy (3): qdev: make qdev_find_recursive public usb: add public usb_device_by_id monitor: add usb_attach and usb_detach hmp-commands.hx | 34 ++ hw/qdev.c |2 +- hw/qdev.h |1 + hw/usb-bus.c| 16 hw/usb.h

[Qemu-devel] [PATCH 2/3] usb: add public usb_device_by_id

2010-10-19 Thread Alon Levy
--- hw/usb-bus.c | 16 hw/usb.h |1 + 2 files changed, 17 insertions(+), 0 deletions(-) diff --git a/hw/usb-bus.c b/hw/usb-bus.c index b692503..d732bd3 100644 --- a/hw/usb-bus.c +++ b/hw/usb-bus.c @@ -189,6 +189,22 @@ int usb_device_detach(USBDevice *dev) return

[Qemu-devel] [PATCH 3/3] monitor: add usb_attach and usb_detach

2010-10-19 Thread Alon Levy
--- hmp-commands.hx | 34 ++ sysemu.h|2 ++ vl.c| 31 +++ 3 files changed, 67 insertions(+), 0 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 81999aa..660205c 100644 --- a/hmp-commands.hx

[Qemu-devel] [PATCH 0/1] ccid emulated card (v2, for usb-ccid v3)

2010-10-19 Thread Alon Levy
/cac_card/ hw/ccid-card-emulated.c: new device Makefile.objs: add ccid-card-emulated.o if --enable-smartcard configure: dependency on libcac_card if --enable-smartcard hw/usb-ccid.c: added a TODO note hw/ccid-card-passthru.c: removed does-nothing print method. Alon Levy (1): add ccid-card

[Qemu-devel] [PATCH 1/1] add ccid-card-emulated device (v2)

2010-10-19 Thread Alon Levy
changes from v1: remove stale comments, use only c-style comments bugfix, forgot to set recv_len change reader name to 'Virtual Reader' Signed-off-by: Alon Levy al...@redhat.com --- Makefile.objs |2 +- configure | 20 ++ hw/ccid-card-emulated.c | 495

Re: [Qemu-devel] [PATCH 2/3] usb: add public usb_device_by_id

2010-10-19 Thread Alon Levy
- Gerd Hoffmann kra...@redhat.com wrote: +USBDevice *usb_device_by_id(const char* id) +{ +USBBus *bus; +DeviceState *qdev; +USBDevice *dev; + +QTAILQ_FOREACH(bus,busses, next) { +qdev = qdev_find_recursive(bus-qbus, id); +if (qdev != NULL) {

[Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3)

2010-10-21 Thread Alon Levy
calling qdev_find_recursive 3. adds the commands that use usb_device_by_id Alon Levy (3): qdev: make qdev_find_recursive public usb: add public usb_device_by_id monitor: add usb_attach and usb_detach (v2) configure |9 + hmp-commands.hx | 38

[Qemu-devel] [PATCH 2/3] usb: add public usb_device_by_id

2010-10-21 Thread Alon Levy
--- hw/usb-bus.c | 16 hw/usb.h |1 + 2 files changed, 17 insertions(+), 0 deletions(-) diff --git a/hw/usb-bus.c b/hw/usb-bus.c index b692503..d732bd3 100644 --- a/hw/usb-bus.c +++ b/hw/usb-bus.c @@ -189,6 +189,22 @@ int usb_device_detach(USBDevice *dev) return

[Qemu-devel] [PATCH 1/3] qdev: make qdev_find_recursive public

2010-10-21 Thread Alon Levy
--- hw/qdev.c |2 +- hw/qdev.h |1 + 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index 35858cb..d669a9d 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -477,7 +477,7 @@ static BusState *qbus_find_recursive(BusState *bus, const char *name, return

[Qemu-devel] [PATCH 0/2] add optional root to info qtree

2010-10-21 Thread Alon Levy
strings, so monitor_parse_command will check the arguments for the do_info sub command do_info_qtree. Alon Levy (2): monitor: add sub_args_type for second level parameters monitor info qtree: add optional bus id hmp-commands.hx |1 + hw/qdev.c | 17 ++--- hw/qdev.h

[Qemu-devel] [PATCH 3/3] monitor: add usb_attach and usb_detach (v2)

2010-10-21 Thread Alon Levy
v1-v2 changes: * fixed help text (consistent name for parameter) * added configure flag, also enabled with --enable-debug --- configure |9 + hmp-commands.hx | 38 ++ sysemu.h|4 vl.c| 33

[Qemu-devel] [PATCH 1/2] monitor: add sub_args_type for second level parameters

2010-10-21 Thread Alon Levy
--- hmp-commands.hx |1 + monitor.c | 13 - 2 files changed, 13 insertions(+), 1 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 3014b17..289fbcb 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -1158,6 +1158,7 @@ ETEXI .args_type =

[Qemu-devel] [PATCH 2/2] monitor info qtree: add optional bus id

2010-10-21 Thread Alon Levy
--- hw/qdev.c | 17 ++--- hw/qdev.h |2 +- monitor.c | 34 +- 3 files changed, 44 insertions(+), 9 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index d669a9d..e6cf7af 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -774,10 +774,21 @@ static void

Re: [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3)

2010-10-21 Thread Alon Levy
On Thu, Oct 21, 2010 at 08:13:19AM -0500, Anthony Liguori wrote: On 10/21/2010 08:03 AM, Gerd Hoffmann wrote: On 10/21/10 08:36, Alon Levy wrote: v2-v3 changes: * add configure parameter * fix docs v2 message: This patchset uses id like device_del for attaching/detaching usb devices

Re: [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3)

2010-10-21 Thread Alon Levy
On Thu, Oct 21, 2010 at 08:13:19AM -0500, Anthony Liguori wrote: On 10/21/2010 08:03 AM, Gerd Hoffmann wrote: On 10/21/10 08:36, Alon Levy wrote: v2-v3 changes: * add configure parameter * fix docs v2 message: This patchset uses id like device_del for attaching/detaching usb devices

Re: [Qemu-devel] [PATCH 3/3] monitor: add usb_attach and usb_detach

2010-10-21 Thread Alon Levy
On Wed, Oct 20, 2010 at 02:24:20PM -0200, Luiz Capitulino wrote: On Tue, 19 Oct 2010 15:35:01 +0200 Gerd Hoffmann kra...@redhat.com wrote: Hi, +.help = attach USB device 'bus.addr', +...@item usb_attach @var{devname} /me sees a mismatch here. There is

Re: [Qemu-devel] [PATCH 1/2] usb-ccid: add CCID bus

2010-10-23 Thread Alon Levy
On Fri, Oct 22, 2010 at 03:49:38PM +0200, Markus Armbruster wrote: Alon Levy al...@redhat.com writes: A CCID device is a smart card reader. It is a USB device, defined at [1]. This patch introduces the usb-ccid device that is a ccid bus. Next patches will introduce two card types

[Qemu-devel] [PATCH 0/4] usb-ccid (v4)

2010-10-24 Thread Alon Levy
. will add monitor commands in a separate patch. tested with current setup. Alon Levy (4): usb-ccid: add CCID bus ccid: add passthru card device add ccid-card-emulated device (v2) ccid: add docs Makefile.objs |1 + configure | 32 ++ docs/ccid.txt | 133

[Qemu-devel] [PATCH 2/4] ccid: add passthru card device

2010-10-24 Thread Alon Levy
For the client side utility vscclient, see libcac_card: libcac_card http://cgit.freedesktop.org/~alon/cac_card (temporary home) written by Robert Relyea rrel...@redhat.com Signed-off-by: Alon Levy al...@redhat.com --- Makefile.objs |2 +- hw/ccid-card-passthru.c | 278

[Qemu-devel] [PATCH 1/4] usb-ccid: add CCID bus

2010-10-24 Thread Alon Levy
-Card_CCID_Rev110. Signed-off-by: Alon Levy al...@redhat.com --- Makefile.objs |1 + configure | 12 + hw/ccid.h | 34 ++ hw/usb-ccid.c | 1346 + 4 files changed, 1393 insertions(+), 0 deletions(-) create mode 100644 hw/ccid.h create

[Qemu-devel] [PATCH 4/4] ccid: add docs

2010-10-24 Thread Alon Levy
--- docs/ccid.txt | 133 + 1 files changed, 133 insertions(+), 0 deletions(-) create mode 100644 docs/ccid.txt diff --git a/docs/ccid.txt b/docs/ccid.txt new file mode 100644 index 000..5eac611 --- /dev/null +++ b/docs/ccid.txt @@

[Qemu-devel] [PATCH 3/4] add ccid-card-emulated device (v2)

2010-10-24 Thread Alon Levy
changes from v1: remove stale comments, use only c-style comments bugfix, forgot to set recv_len change reader name to 'Virtual Reader' Signed-off-by: Alon Levy al...@redhat.com --- Makefile.objs |2 +- configure | 20 ++ hw/ccid-card-emulated.c | 495

Re: [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3)

2010-10-25 Thread Alon Levy
: On 10/21/10 08:36, Alon Levy wrote: v2-v3 changes: * add configure parameter * fix docs v2 message: This patchset uses id like device_del for attaching/detaching usb devices. The first two patches ready the way: 1. makes qdev_find_recursive non static and in qdev.h 2. adds

[al...@redhat.com: [Qemu-devel] [PATCH 0/2] add optional root to info qtree]

2010-10-27 Thread Alon Levy
bump. Doesn't anyone find it useful to view only a part of the whole qtree? Is there some easy way to do this with current qemu monitor? - Forwarded message from Alon Levy al...@redhat.com - Date: Thu, 21 Oct 2010 08:37:18 +0200 From: Alon Levy al...@redhat.com To: qemu-devel@nongnu.org

Re: [Qemu-devel] Re: [PATCH] Implement a virtio GPU transport

2010-11-01 Thread Alon Levy
- Anthony Liguori anth...@codemonkey.ws wrote: On 10/29/2010 06:18 AM, Rusty Russell wrote: Fixed - updated patch tested and attached. OK. FWIW, I think this is an awesome idea. Paravirtual OpenGL or the actual proposed implementation? Have you looked at the actual code?

Re: [Qemu-devel] Re: [PATCH] Implement a virtio GPU transport

2010-11-04 Thread Alon Levy
On Wed, Nov 03, 2010 at 06:03:50PM +, Ian Molton wrote: On 01/11/10 13:28, Anthony Liguori wrote: On 11/01/2010 06:53 AM, Alon Levy wrote: While we (speaking as part of the SPICE developers) want to have the same support in our virtual GPU for 3d as we have for 2d, we just don't

Re: [Qemu-devel] [PATCH 1/4] usb-ccid: add CCID bus

2010-11-09 Thread Alon Levy
On Tue, Nov 09, 2010 at 11:11:21AM +0100, Markus Armbruster wrote: Alon Levy al...@redhat.com writes: A CCID device is a smart card reader. It is a USB device, defined at [1]. This patch introduces the usb-ccid device that is a ccid bus. Next patches will introduce two card types

[Qemu-devel] [PATCH 2/4] ccid: add passthru card device

2010-11-09 Thread Alon Levy
For the client side utility vscclient, see libcac_card: libcac_card http://cgit.freedesktop.org/~alon/cac_card (temporary home) written by Robert Relyea rrel...@redhat.com Signed-off-by: Alon Levy al...@redhat.com --- Makefile.objs |2 +- hw/ccid-card-passthru.c | 278

[Qemu-devel] [PATCH 1/4] usb-ccid: add CCID bus

2010-11-09 Thread Alon Levy
-Card_CCID_Rev110. Signed-off-by: Alon Levy al...@redhat.com --- Makefile.objs |1 + configure | 12 + hw/ccid.h | 34 ++ hw/usb-ccid.c | 1342 + 4 files changed, 1389 insertions(+), 0 deletions(-) create mode 100644 hw/ccid.h create

[Qemu-devel] [PATCH 4/4] ccid: add docs

2010-11-09 Thread Alon Levy
--- docs/ccid.txt | 133 + 1 files changed, 133 insertions(+), 0 deletions(-) create mode 100644 docs/ccid.txt diff --git a/docs/ccid.txt b/docs/ccid.txt new file mode 100644 index 000..5eac611 --- /dev/null +++ b/docs/ccid.txt @@

[Qemu-devel] [PATCH 2/4] ccid: add passthru card device

2010-11-09 Thread Alon Levy
For the client side utility vscclient, see libcac_card: libcac_card http://cgit.freedesktop.org/~alon/cac_card (temporary home) written by Robert Relyea rrel...@redhat.com Signed-off-by: Alon Levy al...@redhat.com --- Makefile.objs |2 +- hw/ccid-card-passthru.c | 277

Re: [Qemu-devel] [PATCH 0/4] usb-ccid (v5)

2010-11-09 Thread Alon Levy
NACK self. Forgot the statics. On Tue, Nov 09, 2010 at 01:40:07PM +0200, Alon Levy wrote: This patchset adds three new devices, usb-ccid, ccid-card-passthru and ccid-card-emulated, providing a CCID bus, a simple passthru protocol implementing card requiring a client, and a standalone emulated

[Qemu-devel] [PATCH 1/4] usb-ccid: add CCID bus

2010-11-09 Thread Alon Levy
-Card_CCID_Rev110. Signed-off-by: Alon Levy al...@redhat.com --- Makefile.objs |1 + configure | 12 + hw/ccid.h | 34 ++ hw/usb-ccid.c | 1342 + 4 files changed, 1389 insertions(+), 0 deletions(-) create mode 100644 hw/ccid.h create

[Qemu-devel] [PATCH 0/4] usb-ccid (v6)

2010-11-09 Thread Alon Levy
. will add monitor commands in a separate patch. tested with current setup. Alon Levy (4): usb-ccid: add CCID bus ccid: add passthru card device add ccid-card-emulated device (v2) ccid: add docs Makefile.objs |1 + configure | 33 ++ docs/ccid.txt | 133

[Qemu-devel] [PATCH 3/4] add ccid-card-emulated device (v2)

2010-11-09 Thread Alon Levy
changes from v1: remove stale comments, use only c-style comments bugfix, forgot to set recv_len change reader name to 'Virtual Reader' Signed-off-by: Alon Levy al...@redhat.com --- Makefile.objs |2 +- configure | 21 ++ hw/ccid-card-emulated.c | 495

[Qemu-devel] [PATCH 0/4] usb-ccid (v5)

2010-11-09 Thread Alon Levy
* added a message to tell client qemu has migrated to ip:port * for lack of monitor commands ip:port are 0:0, which causes the updated vscclient to connect to one port higher on the same host. will add monitor commands in a separate patch. tested with current setup. Alon Levy (4): usb

[Qemu-devel] [PATCH 4/4] ccid: add docs

2010-11-09 Thread Alon Levy
--- docs/ccid.txt | 133 + 1 files changed, 133 insertions(+), 0 deletions(-) create mode 100644 docs/ccid.txt diff --git a/docs/ccid.txt b/docs/ccid.txt new file mode 100644 index 000..5eac611 --- /dev/null +++ b/docs/ccid.txt @@

[Qemu-devel] [PATCH 3/4] add ccid-card-emulated device (v2)

2010-11-09 Thread Alon Levy
changes from v1: remove stale comments, use only c-style comments bugfix, forgot to set recv_len change reader name to 'Virtual Reader' Signed-off-by: Alon Levy al...@redhat.com --- Makefile.objs |2 +- configure | 21 ++ hw/ccid-card-emulated.c | 492

Re: [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3)

2010-11-10 Thread Alon Levy
On Wed, Nov 10, 2010 at 04:49:38PM +0100, Markus Armbruster wrote: Sorry for coming so late to this thread... Alon Levy al...@redhat.com writes: On Thu, Oct 21, 2010 at 08:13:19AM -0500, Anthony Liguori wrote: On 10/21/2010 08:03 AM, Gerd Hoffmann wrote: On 10/21/10 08:36, Alon Levy

Re: [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3)

2010-11-11 Thread Alon Levy
On Thu, Nov 11, 2010 at 11:29:36AM +0100, Markus Armbruster wrote: Alon Levy al...@redhat.com writes: On Wed, Nov 10, 2010 at 04:49:38PM +0100, Markus Armbruster wrote: Sorry for coming so late to this thread... Alon Levy al...@redhat.com writes: On Thu, Oct 21, 2010 at 08:13

Re: [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3)

2010-11-11 Thread Alon Levy
On Thu, Nov 11, 2010 at 04:03:14PM +0100, Markus Armbruster wrote: [snip] Agree. Summary so far: 1. usb_{attach,detach} looks like yet another special-purpose command where a general command would make sense, namely device_{attach,detach}. We have a few of those, e.g. usb_add

Re: [Qemu-devel] [PATCH 0/4] usb-ccid (v6)

2010-11-17 Thread Alon Levy
ping? On Tue, Nov 09, 2010 at 02:22:06PM +0200, Alon Levy wrote: This patchset adds three new devices, usb-ccid, ccid-card-passthru and ccid-card-emulated, providing a CCID bus, a simple passthru protocol implementing card requiring a client, and a standalone emulated card. v5-v6 changes

[Qemu-devel] usb-ccid notes for today's meeting

2010-11-23 Thread Alon Levy
Hi, I've compiled the list of objections from the previous round of talks between Anthony and {Robert and I}, with our answers, for reference in todays talk (sorry about late send). Notes for KVM meeting. Points raised by anthony: 1. How does the smart card state get migrated? 2. How do

[Qemu-devel] [PATCH 2/6] ccid: add passthru card device

2010-11-25 Thread Alon Levy
For the client side utility vscclient, see libcac_card: libcac_card http://cgit.freedesktop.org/~alon/cac_card (temporary home) written by Robert Relyea rrel...@redhat.com Signed-off-by: Alon Levy al...@redhat.com --- Makefile.objs |2 +- hw/ccid-card-passthru.c | 277

[Qemu-devel] [PATCH 0/6] usb-ccid (v7)

2010-11-25 Thread Alon Levy
client qemu has migrated to ip:port * for lack of monitor commands ip:port are 0:0, which causes the updated vscclient to connect to one port higher on the same host. will add monitor commands in a separate patch. tested with current setup. Alon Levy (5): usb-ccid: add CCID bus ccid: add

[Qemu-devel] [PATCH 4/6] libcaccard: update configure to build and use internal libcaccard

2010-11-25 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- Makefile|6 -- Makefile.objs |5 + Makefile.target |2 ++ configure | 24 libcaccard/Makefile | 18 ++ 5 files changed, 53 insertions(+), 2 deletions

[Qemu-devel] [PATCH 5/6] add ccid-card-emulated device (v2)

2010-11-25 Thread Alon Levy
changes from v1: remove stale comments, use only c-style comments bugfix, forgot to set recv_len change reader name to 'Virtual Reader' Signed-off-by: Alon Levy al...@redhat.com --- Makefile.objs |2 +- hw/ccid-card-emulated.c | 492

[Qemu-devel] [PATCH 1/6] usb-ccid: add CCID bus

2010-11-25 Thread Alon Levy
-Card_CCID_Rev110. Signed-off-by: Alon Levy al...@redhat.com --- Makefile.objs |1 + configure | 12 + hw/ccid.h | 34 ++ hw/usb-ccid.c | 1342 + 4 files changed, 1389 insertions(+), 0 deletions(-) create mode 100644 hw/ccid.h create

Re: [Qemu-devel] [PATCH 4/6] libcaccard: update configure to build and use internal libcaccard

2010-11-28 Thread Alon Levy
On Fri, Nov 26, 2010 at 06:50:07PM +, Blue Swirl wrote: On Thu, Nov 25, 2010 at 4:22 PM, Alon Levy al...@redhat.com wrote: Signed-off-by: Alon Levy al...@redhat.com ---  Makefile            |    6 --  Makefile.objs       |    5 +  Makefile.target     |    2 ++  configure

Re: [Qemu-devel] [PATCH 1/6] usb-ccid: add CCID bus

2010-11-28 Thread Alon Levy
On Fri, Nov 26, 2010 at 07:05:02PM +, Blue Swirl wrote: On Thu, Nov 25, 2010 at 4:22 PM, Alon Levy al...@redhat.com wrote: ... +/* 6.2.6 RDR_to_PC_SlotStatus definitions */ +enum { +    CLOCK_STATUS_RUNNING = 0, +    /* 0 - Clock Running, 1 - Clock stopped in State L, 2 - H

  1   2   3   4   5   6   7   8   9   10   >