proving stdvga to support basic 2d accel isn't that much effort. I
> think it is worth doing it, even when it is obsoleted by a redesigned /
> rewritten qxl2 some day.
I think we're pretty much in agreement here. I think if we improve
stdvga by making it a virtio device, then it becomes pretty easy to
eventually make it qxl2.
Regards,
Anthony Liguori
>
> cheers,
> Gerd
for irqfd: add a parameter to
> virtio_queue_set_host_notifier_fd_handler and in that case only set
> the notifier, not the handler.
>
> Cc: Stefan Hajnoczi
> Signed-off-by: Paolo Bonzini
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> hw/virtio-pci.c | 14 +++---
> hw/virtio.c | 7 +-
in_addr_t isn't available on mingw32. Just use an unsigned long instead. I
considered typedef'ing in_addr_t on mingw32 but this would potentially be
brittle if mingw32 did introduce the type.
Cc: Jan Kiszka
Signed-off-by: Anthony Liguori
---
slirp/main.h |2 +-
slirp/slir
Kevin Wolf writes:
> The following changes since commit 26b9b5fe17cc1b6be2e8bf8b9d16094f420bb8ad:
>
> virtio: fix vhost handling (2012-08-06 14:01:44 -0500)
>
> are available in the git repository at:
> http://repo.or.cz/r/qemu/kevin.git for-anthony
Pulled. Thanks.
Gerd Hoffmann writes:
> Hi,
>
> This is the usb patch queue, pretty small this time,
> carrying a little fix for usb-storage.
>
> please pull,
> Gerd
Pulled. Thanks.
Regards,
Anthony Liguori
>
> Gerd Hoffmann (2):
> usb-storage: improve debu
Paolo Bonzini writes:
> This will be needed as soon as process_incoming_migration will set
> handlers on the file. The patch may be removed if
...?
Regards,
Anthony Liguori
>
> Signed-off-by: Paolo Bonzini
> ---
> savevm.c | 3 +++
> 1 file modificato, 3 inserzion
on
>
> qemu-system-ppcemb mac99
> qemu-system-ppcemb g3beige
> qemu-system-ppcemb prep
> Unable to find PowerPC CPU definition
>
> qemu-system-xtensaeb lx60
> qemu-system-xtensaeb lx200
> qemu-system-xtensaeb sim
> Unable to find CPU definition
to push that! :)
>
I will be without a proper email client for 24 hours so I'll keep this
brief for now. What Ben et al are trying to model is something that exists
outside of the model of virtual hardware that QOM is designed for. Since
they are trying to model something that exists
esting.
> - roll out seabios release by end of august, so it can be included
> into qemu 1.2
We really would need a SeaBIOS release by no later than August 21st to
do this. The 1.2 release is on September 1st but we're in hard freeze
starting on August 15th. I wouldn't wan
Eduardo Habkost writes:
> On Thu, Aug 09, 2012 at 10:02:22PM +0100, Peter Maydell wrote:
>> On 9 August 2012 20:25, Eduardo Habkost wrote:
>> > On Fri, Aug 03, 2012 at 03:42:39PM -0500, Anthony Liguori wrote:
>> >> Peter Maydell writes:
>> >> > For
Luiz Capitulino writes:
> On Fri, 27 Jul 2012 08:37:13 -0500
> Anthony Liguori wrote:
>
>> This can be used in conjunction with qom-list-types to determine the
>> supported
>> set of devices and their parameters.
>>
>> Signed-off-by: Anthony Ligu
Luiz Capitulino writes:
> On Fri, 27 Jul 2012 08:37:14 -0500
> Anthony Liguori wrote:
>
>> We've had a cycle to tweak. It is time to commit to supporting them.
>
> qmp_qom_get() and qpm_qom_set() still use the legacy monitor interface, can't
> we convert it
Luiz Capitulino writes:
> On Fri, 27 Jul 2012 08:37:15 -0500
> Anthony Liguori wrote:
>
>> This provides the same output as -M ? but in a structured way.
>>
>> Signed-off-by: Anthony Liguori
>> ---
>> qapi-schema.json | 28 +
Eduardo Habkost writes:
> On Fri, Jul 27, 2012 at 08:37:18AM -0500, Anthony Liguori wrote:
>> Signed-off-by: Anthony Liguori
>> ---
>> target-i386/cpu.c | 22 ++
>> 1 files changed, 22 insertions(+), 0 deletions(-)
>>
>> diff --git
Luiz Capitulino writes:
> On Fri, 10 Aug 2012 09:41:20 -0500
> Anthony Liguori wrote:
>
>> Luiz Capitulino writes:
>>
>> > On Fri, 27 Jul 2012 08:37:15 -0500
>> > Anthony Liguori wrote:
>> >
>> >> This provides the same output
This lets us provide a default implementation of a symbol which targets can
override.
Signed-off-by: Anthony Liguori
---
compiler.h |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/compiler.h b/compiler.h
index 736e770..f76921e 100644
--- a/compiler.h
+++ b/compiler.h
This can be used in conjunction with qom-list-types to determine the supported
set of devices and their parameters.
Signed-off-by: Anthony Liguori
---
qapi-schema.json | 28
qmp-commands.hx |7 +++
qmp.c| 50
implement this command if it makes sense for them.
Signed-off-by: Anthony Liguori
---
v1 -> v2
- rename query-cpudefs -> query-cpu-definitions
---
qapi-schema.json | 23 +++
qmp-commands.hx |6 ++
qmp.c|6 ++
3 files changed, 35 inse
Signed-off-by: Anthony Liguori
---
v1 -> v2
- rename query-cpudefs -> query-cpu-definitions
---
target-ppc/translate_init.c | 26 ++
1 files changed, 26 insertions(+), 0 deletions(-)
diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
index 5
Eduardo Habkost writes:
> On Fri, Aug 10, 2012 at 09:43:21AM -0500, Anthony Liguori wrote:
>> Eduardo Habkost writes:
>>
>> > On Fri, Jul 27, 2012 at 08:37:18AM -0500, Anthony Liguori wrote:
>> >> Signed-off-by: Anthony Liguori
>&
This provides the same output as -M ? but in a structured way.
Signed-off-by: Anthony Liguori
---
qapi-schema.json | 28
qmp-commands.hx |6 ++
vl.c | 31 +++
3 files changed, 65 insertions(+), 0 deletions
We've had a cycle to tweak. It is time to commit to supporting them.
Signed-off-by: Anthony Liguori
---
qapi-schema.json | 19 ---
1 files changed, 4 insertions(+), 15 deletions(-)
diff --git a/qapi-schema.json b/qapi-schema.json
index 191a889..a938c8d 100644
--- a
This series implements the necessary commands to implements danpb's idea to
remove -help parsing in libvirt. We would introduce all of these commands in
1.2 and then change the -help output starting in 1.3.
Here is Dan's plan from a previous thread:
Basically I'd sum up my new idea as "just u
This is just a rebase of this series that I posted back in June.
Andreas had a different approach involving a #define but I think doing a full
split ends up being nicer. For instance, the recently added thread information
is only relevant to cpu-softmmu so we can limit that entirely to cpu-softmm
y splitting out qdev.h along the same lines that we
previously split the C file. Then cpu.h just needs to include qdev-core.h
Signed-off-by: Anthony Liguori
Signed-off-by: Anthony Liguori
---
hw/irq.h |2 +
hw/mc146818rtc.c |1 +
hw/qdev-addr.c |1 +
hw/qdev-core
volve
independently.
We also need to push a qdev_init_nofail() into all callers of cpu_init(). This
is needed eventually anyway so might as well do this now.
Signed-off-by: Anthony Liguori
---
Makefile.objs |6 ---
hw/armv7m.c |1 +
hw/axis_de
Eduardo Habkost writes:
> On Fri, Aug 10, 2012 at 11:37:30AM -0500, Anthony Liguori wrote:
>> Eduardo Habkost writes:
>> >> > - add machine-type-specific cpudef compatibility changes?
>> >>
>> >> I think we've discussed this in IRC. I don&#
Signed-off-by: Anthony Liguori
---
v1 -> v2
- rename query-cpudefs -> query-cpu-definitions
---
target-i386/cpu.c | 22 ++
1 files changed, 22 insertions(+), 0 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 880cfea..6d5d0d6 100644
--- a/targe
Eric Blake writes:
> On 08/10/2012 10:04 AM, Anthony Liguori wrote:
>> We've had a cycle to tweak. It is time to commit to supporting them.
>>
>> Signed-off-by: Anthony Liguori
>> ---
>> qapi-schema.json | 19 ---
>> 1
Eduardo Habkost writes:
> On Fri, Aug 10, 2012 at 12:00:44PM -0500, Anthony Liguori wrote:
>> The line between linux-user and softmmu is not very well defined right now.
>> linux-user really don't want to include devices and making CpuState a child
>> of
>> D
ithub and which let me setup a
mirror from qemu.org that pushes every 30 minutes to github.
It should be active now. I can also add other people to the github
organization.
Regards,
Anthony Liguori
>
> -- PMM
i-next
>
> for you to fetch changes up to 5222aaf223e52961cabeb7cabc579892ccd8bc59:
>
> scsi-disk: add support for the UNMAP command (2012-08-09 15:04:09 +0200)
Pulled. Thanks.
Regards,
Anthony Liguori
>
>
&g
ny
Pulled. Thanks.
Regards,
Anthony Liguori
>
> Avi Kivity (1):
> virtio-blk: fix use-after-free while handling scsi commands
>
> Jason Baron (2):
> ahci: Fix ahci cdrom read corruptions for reads > 128k
> ahci: Fix sglist memleak in ahci_dma_rw_buf()
>
>
l-patches
>
> for you to fetch changes up to b90372ad2a69a9cdad2a40766eb46f0a89d98535:
>
> target-arm: Fix typos in comments (2012-08-10 14:37:28 +0100)
Pulled. Thanks.
Regards,
Anthony Liguori
>
>
> Dunrong H
1/01/2007
/sys/class/dmi/id/bios_version=Bochs
Guest fingerprint changed for pc-1.0!
Need to make this a qdev-visible feature and then add compatibility
properties for all of the old machine types.
Regards,
Anthony Liguori
> ---
> hw/virtio-blk.c | 16 ++--
> hw/virti
r_pci.c
> @@ -36,16 +36,18 @@ static PCIDevice *find_dev(sPAPREnvironment *spapr,
> uint64_t buid, uint32_t config_addr)
> {
> int devfn = (config_addr >> 8) & 0xFF;
> -sPAPRPHBState *phb;
> +sPAPRPHBState *sphb;
>
> - QLIST
a few Reviewed-by's too for this series before it goes
in. I expect they won't be hard to get but I also expect it will take a
few more revisions of this series to get there.
Regards,
Anthony Liguori
>
> This series is also available at:
>
> git://github.com/awill
Peter Maydell writes:
> On 10 August 2012 17:04, Anthony Liguori wrote:
>> This lets us provide a default implementation of a symbol which targets can
>> override.
>>
>> Signed-off-by: Anthony Liguori
>
> I'm sure you'll be thrilled to hear tha
at up this
afternoon and send it out today.
We can debate the merits of this sort of thing in the style guide.
Regards,
Anthony Liguori
>
> -->
>
> From: Andreas Färber
>
> piix: minor code simplification
>
> There's no need to deal with qdev internals in piix
to ask for < 1MB unless they know what they're
doing. If it's truly a mistake, then asking for 2MB is just as much of
a mistake because no real guest will run with 2MB of memory anyway (you
can't even load a kernel).
So if we're just going for theoritical correctness, we ought to do it
the Right Way which is fixing the CMOS values and putting the check in
SeaBIOS.
Regards,
Anthony Liguori
guys pick this up through uq/master?
Regards,
Anthony Liguori
>
> On 8 August 2012 13:34, Peter Maydell wrote:
>> Ping?
>>
>> patchwork url: http://patchwork.ozlabs.org/patch/173202/
>>
>> -- PMM
>>
>> On 25 July 2012 16:29, Peter Maydell wr
Signed-off-by: Anthony Liguori
---
docs/qom-style-guide.md | 489 +++
1 files changed, 489 insertions(+), 0 deletions(-)
create mode 100644 docs/qom-style-guide.md
diff --git a/docs/qom-style-guide.md b/docs/qom-style-guide.md
new file mode 100644
lt for sandbox.enable=off but for 1.3,
will switch it to 'on' for the default.
By making it QemuOpts, we can actually disable/enable through the global
configuration file which is a really nice touch.
If you can make those changes and resubmit tomorrow, we can include it
for the 1.2 release
Jan Kiszka writes:
> On 2012-08-13 15:58, Avi Kivity wrote:
>> On 08/13/2012 04:27 PM, Anthony Liguori wrote:
>>
>>> Thanks for pushing this forward! Hopefully this will finally kill off
>>> qemu-kvm.git for good.
>>
>> No, it won't. vfio re
Alex Williamson writes:
> On Mon, 2012-08-13 at 08:27 -0500, Anthony Liguori wrote:
>> Alex Williamson writes:
>>
>> > VFIO kernel support was just merged into Linux, so I'd like to
>> > formally propose inclusion of the QEMU vfio-pci driver for
>> &
Luiz Capitulino writes:
> On Mon, 13 Aug 2012 14:16:58 -0300
> Luiz Capitulino wrote:
>
>> On Fri, 10 Aug 2012 11:04:08 -0500
>> Anthony Liguori wrote:
>>
>> > This series implements the necessary commands to implements danpb's idea to
>> > re
"Michael S. Tsirkin" writes:
> On Mon, Aug 13, 2012 at 01:46:46PM -0500, Anthony Liguori wrote:
>> +typedef struct MyType MyType;
>> +
>> +struct MyType
>> +{
>
> This seems to violate our style:should be
>
>> +struct MyType
Avi Kivity writes:
> Please pull from:
>
> git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master
Pulled. Thanks.
Regards,
Anthony Liguori
>
> This is mostly Peter's kvm_irqchip_in_kern
t;> @@ -824,6 +826,10 @@ for opt do
>>;;
>>--disable-guest-agent) guest_agent="no"
>>;;
>> + --disable-vfio-pci) vfio_pci="no"
>> + ;;
>> + --enable-vfio-pci) vfio_pci="yes"
>> + ;;
>
> Do we need thi
ry:
>
> git://repo.or.cz/qemu/qmp-unstable.git queue/qmp
>
Pulled. Thanks.
Regards,
Anthony Liguori
> Anthony Liguori (7):
> qmp: introduce device-list-properties command
> qapi: mark QOM commands stable
> qapi: add query-machines command
> c
Juan Quintela writes:
> [Resent with PULL request instead of PATCH, sorry for the inconvenience]
>
> Hi
>
> This includes xbzrle series (v12) That were reviewed by Erik and Luiz.
>
> Anthony, please apply.
Pulled. Thanks.
Regards,
Anthony Liguori
>
> Later, Juan
t; thanks
> -- PMM
>
Pulled. Thanks.
Regards,
Anthony Liguori
> The following changes since commit 33e95c6328a3149a52615176617997c4f8f7088b:
>
> qom: Reimplement Interfaces (2012-08-13 11:20:41 +0200)
>
> are available in the git repository at:
>
> git://git.linaro
ly is) or should it fail
> gracefully?
Are you calling set via object_property_set_[str,int,bool,...]?
Why don't you add a terminal error to those functions if setting fails and errp
is NULL.
Regards,
Anthony Liguori
>
> Whats the best meachinism for creating a no_fail version of
To be replaced with live block copy.
Signed-off-by: Anthony Liguori
---
migration.c |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/migration.c b/migration.c
index 653a3c1..babccf4 100644
--- a/migration.c
+++ b/migration.c
@@ -482,10 +482,19 @@ void qmp_migrate
Stefan Hajnoczi writes:
> The last pull request from 19 July was not merged. Here it is rebased on
> qemu.git/master with two additional fixes from Stefan Weil.
I'm not sure what you mean:
commit 903f650b0c77827f8d92b35f61419401d648df1e
Merge: 61dc008 90a147a
Author: Anthony Li
a "panic-device" should cover other OSes is also
> something to consider. Even for Linux, is "panic" the only case which
> should be reported via the mechanism? What about oopses without panic?
>
> Is the mechanism general enough for supporting new events, etc.
Hi,
I
Marcelo Tosatti writes:
> On Tue, Aug 14, 2012 at 01:53:01PM -0500, Anthony Liguori wrote:
>> Marcelo Tosatti writes:
>>
>> > On Tue, Aug 14, 2012 at 05:55:54PM +0300, Yan Vugenfirer wrote:
>> >>
>> >> On Aug 14, 2012, at 1:42 PM, Jan Kiszka wro
Luiz Capitulino writes:
> On Tue, 14 Aug 2012 08:32:31 -0500
> Anthony Liguori wrote:
>
>> To be replaced with live block copy.
>>
>> Signed-off-by: Anthony Liguori
>> ---
>> migration.c |9 +
>> 1 files changed, 9 insertions(+), 0 d
Huck
Hi,
Have you written an appendix for the virtio specification for
virtio-ccw? I think it would be good to include in this series for the
purposes of review.
Regards,
Anthony Liguori
> ---
> arch/s390/include/asm/irq.h | 1 +
> arch/s390/kernel/irq.c| 1 +
> dr
Marcelo Tosatti writes:
> On Tue, Aug 14, 2012 at 02:35:34PM -0500, Anthony Liguori wrote:
>> Marcelo Tosatti writes:
>>
>> > On Tue, Aug 14, 2012 at 01:53:01PM -0500, Anthony Liguori wrote:
>> >> Marcelo Tosatti writes:
>> >>
>> >>
mingw32 seems to want the declaration to also carry the weak attribute.
Strangely, gcc on Linux absolutely does not want the declaration to be marked
as weak. This may not be the right fix, but it seems to do the trick.
Signed-off-by: Anthony Liguori
---
arch_init.h |4
Andreas Färber writes:
> Am 10.08.2012 19:00, schrieb Anthony Liguori:
>> The line between linux-user and softmmu is not very well defined right now.
>> linux-user really don't want to include devices and making CpuState a child
>> of
>> DeviceState would re
t;
> git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master
Pulled. Thanks.
Regards,
Anthony Liguori
>
> Jan Kiszka (3):
> kvm: i8254: Cache kernel clock offset in KVMPITState
> kvm: i8254: Finish time conversion fix
> kvmvapic: Disable if
or.cz/r/qemu/kevin.git for-anthony
>
Pulled. Thanks.
Regards,
Anthony Liguori
> Corey Bryant (7):
> qemu-char: Add MSG_CMSG_CLOEXEC flag to recvmsg
> qapi: Introduce add-fd, remove-fd, query-fdsets
> block: Prevent detection of /dev/fdset/ as floppy
> block: Co
Stefan Hajnoczi writes:
> The last pull request for QEMU 1.2!
>
> The following changes since commit 03834e22abafbc8dc4052d46a5ccd6dd135a54a3:
>
> Merge remote-tracking branch 'origin/master' into staging (2012-08-14
> 15:19:50 -0500)
>
Pulled. Thanks.
R
drive and the controller, right? Not sure about cdrom...
This is a valid critique and suggests that more review is needed.
Given that, I won't pick this up today. But let's not throw around
Nacks without justification.
Regards,
Anthony Liguori
>
> -- PMM
information
from.
I think this probably needs to wait until 1.3 (assuming it's even the
right interface).
Regards,
Anthony Liguori
>
> --
> Eric Blake ebl...@redhat.com+1-919-301-3266
> Libvirt virtualization library http://libvirt.org
Markus Armbruster writes:
> Anthony Liguori writes:
>
>> Peter Maydell writes:
>>
>>> On 15 August 2012 20:25, Alexander Graf wrote:
>>>> On 15.08.2012, at 21:17, Markus Armbruster wrote:
>>>>
>>>>> We create a number of
Peter Maydell writes:
> On 15 August 2012 20:58, Anthony Liguori wrote:
>> Peter Maydell writes:
>>> On 15 August 2012 20:25, Alexander Graf wrote:
>>>> Nack from my POV. Too late for 1.2. Better get this in early for 1.3.
>>
>> No, it's not
Alexander Graf writes:
> Hi Blue / Aurelien,
>
> This is my current patch queue for s390. Please pull.
>
Pulled. Thanks.
Regards,
Anthony Liguori
> Alex
>
>
> The following changes since commit 03834e22abafbc8dc4052d46a5ccd6dd135a54a3:
> Anthony Liguori
Alexander Graf writes:
> Hi Blue / Aurelien,
>
> This is my current patch queue for ppc. Please pull.
>
Pulled. Thanks.
Regards,
Anthony Liguori
> Alex
>
>
> The following changes since commit 03834e22abafbc8dc4052d46a5ccd6dd135a54a3:
> Anthony Liguori (1):
>
From: Eduardo Otubo
Signed-off-by: Eduardo Otubo
Signed-off-by: Anthony Liguori
---
v1:
- I added a syscall struct using priority levels as described in the
libseccomp man page. The priority numbers are based to the frequency
they appear in a sample strace from a regular qemu guest run
From: Eduardo Otubo
Adding basic options to the configure script to use libseccomp or not.
The default is set to 'no'. If the flag --enable-libseccomp is used, the
script will check for its existence using pkg-config.
Signed-off-by: Eduardo Otubo
Signed-off-by: Anthony Liguori
--
From: Eduardo Otubo
Signed-off-by: Eduardo Otubo
Signed-off-by: Anthony Liguori
---
v1:
- Full seccomp calls and data included in vl.c
v1 -> v2:
- Full seccomp calls and data removed from vl.c and put into separate
qemu-seccomp.[ch] file.
---
vl.c | 13 +
1 files chan
Hi,
I attempted to apply Eduardo's seccomp patches and ran into a number of
problems. In the interest of time, I thought it would be easier for me to fix
them and just respin the series myself.
I've tested this as best I can--I don't have a seccomp capable kernel. But
since the option is availa
From: Eduardo Otubo
Signed-off-by: Eduardo Otubo
Signed-off-by: Anthony Liguori
---
v7 -> v8
- Parse options correctly (aliguori)
---
qemu-config.c | 14 ++
qemu-config.h |1 +
qemu-options.hx | 10 ++
vl.c|
ding on what
feature bits are exposed to the guest. So my guess is that the odd
combination of CPUID bits that are exposed to the guest is confusing the
kernel.
Can you post dmesg from the host kernel? Perhaps there's instruction
emulation failing in the host KVM? That would manifest in strange
behavior in the guest.
Regards,
Anthony Liguori
>
> Alan
object_finalize(void *data)
> @@ -385,8 +383,9 @@ Object *object_new(const char *typename)
>
> void object_delete(Object *obj)
> {
> +object_unparent(obj);
> +g_assert(obj->ref == 1);
> object_unref(obj);
> -g_assert(obj->ref == 0);
> g_free(obj);
> }
This won't work with composition. object_delete() is never called for
child<> objects.
Regards,
Anthony Liguori
>
>>> > @@ -8,6 +8,7 @@
>>> >*/
>>> > #include
>>> >
>>> > +#include "hw/irq.h"
>>> > #include "qemu-common.h"
>>> >
>>> > /* xen-machine.c */
>>> > diff --git a
you expect it to mean.
We're going to most likely fix TARGET_PHYS_ADDR_BITS to 64 real soon.
Why did you include this field? What information are you looking to get
from QEMU and what decisions do you plan to make with it?
Regards,
Anthony Liguori
>
> Signed-off-by: Daniel P. Berrange
"Daniel P. Berrange" writes:
> On Mon, Aug 20, 2012 at 04:48:24PM -0500, Anthony Liguori wrote:
>> "Daniel P. Berrange" writes:
>>
>> > From: "Daniel P. Berrange"
>> >
>> > Add a 'query-target' QAPI command
before the change takes effect.
>
> Why haven't we applied yet the patch to do that unconditionally?
>
> http://permalink.gmane.org/gmane.comp.emulators.qemu/162828
Can you ping the actual patch... Gmane seems to be down right now.
Regards,
Anthony Liguori
>
> Paolo
Paolo Bonzini writes:
> Il 20/08/2012 19:58, Anthony Liguori ha scritto:
>> Michael Tokarev writes:
>>
>>> On 08.08.2012 17:09, Michael Tokarev wrote:
>>> []
>>>> Something similar should be applied to 1.1-stable. FWIW, some
>>>> change
gt;> > > > +
>> > > > +##
>> > > > +# @TargetInfo:
>> > > > +#
>> > > > +# Information describing the QEMU target.
>> > > > +#
>> > > > +# @arch: the name of the target architecture (eg "x86_64&q
#x27;, '*ram': 'MigrationStats',
>> '*disk': 'MigrationStats',
>> - '*xbzrle-cache': 'XBZRLECacheStats'} }
>> + '*xbzrle-cache': 'XBZRLECacheStats',
>> + 'total-time': 'int'} }
>
> Anthony - are you planning on taking this series for 1.2?
No. This is a new feature and we're past freeze.
> If we don't
> get this patch in on time, then taking this for 1.3 would result in
> changing released QMP interface (right now, there has been no release
> with the field in the wrong type).
Ack. We need to preserve compat with the 1.2 interface.
Regards,
Anthony Liguori
>
> --
> Eric Blake ebl...@redhat.com+1-919-301-3266
> Libvirt virtualization library http://libvirt.org
'return': { u'arch': u'x86_64' }}
Signed-off-by: Daniel P. Berrange
Signed-off-by: Anthony Liguori
---
v1 -> v2 (aliguori)
- remove 'bits' field
- switch command to return an enum
---
arch_init.c | 11 ++
del() to add a notifier to the object that calls
object_unparent() and object_unref.
6) Rename DeviceState::unplug to DeviceState::request_unplug
7) Take Ping Fan's patch + another patch to add a reference count in
object_property_add_link
Regards,
Anthony Liguori
>
> Paolo
7;t care about any of the VM setup parts ? This would
> be more like what my old patches did which mapped monitors commands
> onto '-query-X' command line args, bypassing VM setup, but still
> using normal QMP monitor interaction.
>
> Any other suggestions on how to reliably ge
Armbruster
Signed-off-by: Anthony Liguori
---
hw/Makefile.objs |2 ++
hw/null-machine.c | 40
2 files changed, 42 insertions(+), 0 deletions(-)
create mode 100644 hw/null-machine.c
diff --git a/hw/Makefile.objs b/hw/Makefile.objs
index 7f57ed5..6dfebd2
Paolo Bonzini writes:
> Il 21/08/2012 21:06, Anthony Liguori ha scritto:
>> Paolo Bonzini writes:
>>
>>> Il 21/08/2012 18:39, ronnie sahlberg ha scritto:
>>>> In
>>>> net_socket_update_fd_handler()
>>>>
>>>> shouldnt yo
Eric Blake writes:
> On 08/22/2012 02:24 PM, Anthony Liguori wrote:
>> This allows any QEMU binary to be executed with:
>>
>> $QEMU_BINARY -qmp stdio
>
> Don't you mean:
>
> $QEMU_BINARY -M none -qmp stdio
I did, thanks.
>
> I agree with includ
Hi Paolo,
Paolo Bonzini writes:
> Il 22/08/2012 18:36, Anthony Liguori ha scritto:
>> We can fix this by adding an extra reference in add_link but this
>> creates yet another problem with hotplug. Specificially, qdev_free()
>> asserts that ref > 0 because there is now a
Paolo Bonzini writes:
> Il 22/08/2012 23:41, Anthony Liguori ha scritto:
>>
>> (1) should drop the floating reference and the reference held by the
>> container. That's what I meant by calling object_unparent in
>> qmp_device_del.
>>
>> (2)
Peter Maydell writes:
> On 22 August 2012 21:24, Anthony Liguori wrote:
>> This allows any QEMU binary to be executed with:
>>
>> $QEMU_BINARY -qmp stdio
>
> ...presumably you mean -qmp stdio -M none ?
>
>>
>> Without errors from missing options that
Peter Maydell writes:
> On 22 August 2012 23:42, Anthony Liguori wrote:
>> Peter Maydell writes:
>>> How about documenting this machine (and its purpose) somewhere?
>>
>> Okay, but where? I don't know an obvious place.
>
> If we hadn't got
Andreas Färber writes:
> Am 23.08.2012 00:42, schrieb Anthony Liguori:
>> Peter Maydell writes:
>>
>>> On 22 August 2012 21:24, Anthony Liguori wrote:
>>>
>>> We seem to be about evenly split about whether machine_init()
>>> should have a
ies'}" | qemu-system-x86_64 -M none -qmp stdio
We can fix this for the monitor by moving the parser initialization to init.
The remaining state that is set in OPEN appears harmless.
Reported-by: Daniel Berrange
Signed-off-by: Anthony Liguori
---
monitor.c |4 +++-
1 files changed
nt
> - json_message_parser_init
> - json_lexer_init
>
>
> The problem arises if you try to feed data to QEMU before the bottom
> half has run. There is a race where qemu_chr_be_write can be called
> to process input, before the qemu_chr_generic_open_bh has been
> invoked.
The char layer reall
Reported-by: Michael Roth
Signed-off-by: Anthony Liguori
---
monitor.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/monitor.c b/monitor.c
index b188582..b17b1bb 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4946,13 +4946,13 @@ void monitor_init(CharDriverState *chr
It's also pretty useful when doing security certifications.
Regards,
Anthony Liguori
>
> Example Makefile for out of tree modules:
> #v+
> DEVICENAME=pcnet2
>
> hw-obj-y=pcnet-pci.o
> hw-obj-y+=pcnet.o
>
> include rules.mak
>
> .PHONY: all
>
> QEMU_CF
1 - 100 of 10201 matches
Mail list logo
