[Qemu-devel] [PATCH v1] block/vxhs: Add Veritas HyperScale VxHS block device support

2016-10-25 Thread Ashish Mittal
;:""}]}' Sample command line using URI syntax: qemu-img convert -f raw -O raw -n /var/lib/nova/instances/_base/0c5eacd5ebea5ed914b6a3e7b18f1ce734c386ad vxhs://192.168.0.1:/%7Bc6718f6b-0401-441d-a8c3-1f0064d75ee0%7D Signed-of

[Qemu-devel] [PATCH v2] block/vxhs: Add Veritas HyperScale VxHS block device support

2016-10-26 Thread Ashish Mittal
;:""}]}' Sample command line using URI syntax: qemu-img convert -f raw -O raw -n /var/lib/nova/instances/_base/0c5eacd5ebea5ed914b6a3e7b18f1ce734c386ad vxhs://192.168.0.1:/%7Bc6718f6b-0401-441d-a8c3-1f0064d75ee0%7D Signed-off-by: Ashish Mittal --- v2 changelog: (1) Chan

Re: [Qemu-devel] [PATCH v2] block/vxhs: Add Veritas HyperScale VxHS block device support

2016-10-27 Thread ashish mittal
a separate patch as they are > a pre-requisite for any new block driver. > I guess what Madhav meant was that this patch (v2) is missing the QAPI changes, and we will provide those in the next version ASAP. Regards, Ashish On Thu, Oct 27, 2016 at 12:29 AM, Daniel P. Berrange wrote: >

[Qemu-devel] [PATCH v3] block/vxhs: Add Veritas HyperScale VxHS block device support

2016-10-28 Thread Ashish Mittal
rt":""}}' Sample command line using the URI syntax: qemu-img convert -f raw -O raw -n /var/lib/nova/instances/_base/0c5eacd5ebea5ed914b6a3e7b18f1ce734c386ad vxhs://192.168.0.1:/%7Bc6718f6b-0401-441d-a8c3-1f0064d75ee0%7D Signed-off-by: Ashish Mittal --- v3 changelog: (1

Re: [Qemu-devel] [PATCH v2] block/vxhs: Add Veritas HyperScale VxHS block device support

2016-10-28 Thread ashish mittal
I have submitted v3 with the QAPI schema changes. Regards, Ashish On Thu, Oct 27, 2016 at 2:38 AM, ashish mittal wrote: > Hi Daniel, > >>> >I think this version still does not address Daniel's concerns regarding a >>> >QAPI schema for vxhs. >>> >&g

Re: [Qemu-devel] [PATCH v3] block/vxhs: Add Veritas HyperScale VxHS block device support

2016-10-28 Thread ashish mittal
Hi Eric, On Fri, Oct 28, 2016 at 7:44 AM, Eric Blake wrote: > On 10/28/2016 02:44 AM, Ashish Mittal wrote: >> This patch adds support for a new block device type called "vxhs". >> Source code for the qnio library that this code loads can be downloaded from: >>

[Qemu-devel] [PATCH v4] This patch adds support for a new block device type called "vxhs".

2016-10-28 Thread Ashish Mittal
-img convert -f raw -O raw -n /var/lib/nova/instances/_base/0c5eacd5ebea5ed914b6a3e7b18f1ce734c386ad vxhs://192.168.0.1:/c6718f6b-0401-441d-a8c3-1f0064d75ee0 Signed-off-by: Ashish Mittal --- v4 changelog: (1) Incorporated v3 review comments on QAPI changes. (2) Added refcounting for device open/

Re: [Qemu-devel] [PATCH v4] This patch adds support for a new block device type called "vxhs".

2016-10-31 Thread ashish mittal
Thanks! Will fix these in the next patch! On Mon, Oct 31, 2016 at 12:05 PM, Eric Blake wrote: > On 10/29/2016 01:47 AM, Ashish Mittal wrote: >> Source code for the qnio library that this code loads can be downloaded from: >> https://github.com/MittalAshish/libqnio.git >

Re: [Qemu-devel] [PATCH v3] block/vxhs: Add Veritas HyperScale VxHS block device support

2016-10-31 Thread ashish mittal
>> >> +## >> >> +{ 'struct': 'BlockdevOptionsVxHS', >> >> + 'data': { 'vdisk_id': 'str', >> >> +'server': 'InetSocketAddress' } } >> > >> > Is there any way to use a Unix socket, or is this server ONLY accessible >> > over IPv4/IPv6? >> > >> >> Right now we support IPv4 only. > > IMHO

[Qemu-devel] [PATCH v5] block/vxhs.c Add support for a new block device type called "vxhs"

2016-10-31 Thread Ashish Mittal
-img convert -f raw -O raw -n /var/lib/nova/instances/_base/0c5eacd5ebea5ed914b6a3e7b18f1ce734c386ad vxhs://192.168.0.1:/c6718f6b-0401-441d-a8c3-1f0064d75ee0 Signed-off-by: Ashish Mittal --- v5 changelog: (1) Incorporated v4 review comments. v4 changelog: (1) Incorporated v3 review comments on

Re: [Qemu-devel] [PATCH v4] This patch adds support for a new block device type called "vxhs".

2016-10-31 Thread ashish mittal
Thanks Jeff! All of the review comments have been addressed in v5. On Mon, Oct 31, 2016 at 2:55 PM, Jeff Cody wrote: > On Fri, Oct 28, 2016 at 11:47:11PM -0700, Ashish Mittal wrote: >> Source code for the qnio library that this code loads can be downloaded from: >> htt

Re: [Qemu-devel] [PATCH v5] block/vxhs.c Add support for a new block device type called "vxhs"

2016-11-01 Thread ashish mittal
:07 AM, Daniel P. Berrange wrote: > On Mon, Oct 31, 2016 at 11:34:58PM -0700, Ashish Mittal wrote: >> Source code for the qnio library that this code loads can be downloaded >> from: >> https://github.com/MittalAshish/libqnio.git > > Your patch is unable to compil

Re: [Qemu-devel] [PATCH v5] block/vxhs.c Add support for a new block device type called "vxhs"

2016-11-01 Thread ashish mittal
@rhel72ga-build-upstream qemu] 2016-11-01 09:48:13$ Thanks! On Tue, Nov 1, 2016 at 9:27 AM, Daniel P. Berrange wrote: > On Tue, Nov 01, 2016 at 09:09:31AM -0700, ashish mittal wrote: >> Hi Daniel, >> >> Thanks for pointing that out. I had done a fresh configure and make >>

Re: [Qemu-devel] [PATCH v3] block/vxhs: Add Veritas HyperScale VxHS block device support

2016-11-02 Thread ashish mittal
On Wed, Nov 2, 2016 at 7:13 AM, Eric Blake wrote: > On 11/02/2016 04:57 AM, Kevin Wolf wrote: IMHO it should allow use of UNIX sockets, as its possible to have SSH setup a tunnel to a IP server, and expose the endpoint via a UNIX socket. So even if your reference server only support

[Qemu-devel] [PATCH v5 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-09-07 Thread Ashish Mittal
quot;"},{"host":"172.172.17.2","port":""}]}' Sample command line using URI syntax: qemu-img convert -f raw -O raw -n /var/lib/nova/instances/_base/0c5eacd5ebea5ed914b6a3e7b18f1ce734c386ad vxhs://192.168.0.1:/%7Bc6718f6b-0401-441d-a8c3

Re: [Qemu-devel] [PATCH v4 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-09-07 Thread ashish mittal
, 2016 at 11:56:30PM -0700, Ashish Mittal wrote: >> This patch adds support for a new block device type called "vxhs". >> Source code for the library that this code loads can be downloaded from: >> https://github.com/MittalAshish/libqnio.git >> >> Sample com

Re: [Qemu-devel] vxhs caching behaviour (was: [PATCH v4 RFC] block/vxhs: Initial commit to add) Veritas HyperScale VxHS block device support

2016-09-08 Thread ashish mittal
Hi Kevin, By design, our writeback cache is on non-volatile SSD device. We do async writes to this cache and also maintain a persistent index map of the data written. This gives us the capability to recover write-back cache if needed. Thanks, Ashish On Thu, Sep 8, 2016 at 7:20 AM, Kevin Wolf wr

Re: [Qemu-devel] [PATCH v4 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-09-08 Thread ashish mittal
. Will change accordingly. I also completely agree on the discussion of libqnio calling a qemu function. Will check on the best way to resolve that and get back. Thanks, Ashish On Thu, Sep 8, 2016 at 7:00 AM, Jeff Cody wrote: > On Wed, Sep 07, 2016 at 03:32:47PM -0700, ashish mittal wrote: >

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-11-23 Thread ashish mittal
On the topic of protocol security - Would it be enough for the first patch to implement only authentication and not encryption? On Wed, Nov 23, 2016 at 12:25 AM, Ketan Nilangekar wrote: > +Nitin Jerath from Veritas. > > > > > On 11/18/16, 7:06 PM, "Daniel P. Berrange" wrote: > >>On Fri, Nov 18,

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-11-29 Thread ashish mittal
> > On Thu, Nov 24, 2016 at 05:44:37AM +, Ketan Nilangekar >> wrote: >> > > > On 11/24/16, 4:07 AM, "Paolo Bonzini" >> wrote: >> > > > >On 23/11/2016 23:09, ashish mittal wrote

[Qemu-devel] [PATCH v6 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-09-20 Thread Ashish Mittal
quot;"},{"host":"172.172.17.2","port":""}]}' Sample command line using URI syntax: qemu-img convert -f raw -O raw -n /var/lib/nova/instances/_base/0c5eacd5ebea5ed914b6a3e7b18f1ce734c386ad vxhs://192.168.0.1:/%7Bc6718f6b-0401-441d-a

Re: [Qemu-devel] [PATCH v4 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-09-20 Thread ashish mittal
questions soon. Regards, Ashish On Thu, Sep 8, 2016 at 4:15 PM, ashish mittal wrote: >>> Yes, qemu_iio_ioctl(VDISK_AIO_FLUSH) is only a place-holder at present >>> in case we later want to add some functionality to it. I have now >>> added a comment to this af

Re: [Qemu-devel] [PATCH v6 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-09-20 Thread ashish mittal
On Tue, Sep 20, 2016 at 10:53 PM, Jeff Cody wrote: > On Tue, Sep 20, 2016 at 06:07:45PM -0700, Ashish Mittal wrote: >> This patch adds support for a new block device type called "vxhs". >> Source code for the library that this code loads can be downloaded from: >>

Re: [Qemu-devel] [PATCH v6 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-09-21 Thread ashish mittal
libqnio source has been updated. qemu changes should now build properly. https://github.com/MittalAshish/libqnio.git I will work on the other suggestions and get back. Regards, Ashish On Wed, Sep 21, 2016 at 8:03 AM, Paolo Bonzini wrote: > > > On 21/09/2016 03:07, Ashish Mit

[Qemu-devel] [PATCH v6 0/2] block/vxhs: Add Veritas HyperScale VxHS block device support

2016-11-07 Thread Ashish Mittal
HyperScale storage service. This library (libqnio) has been open sourced and is available on github here: https://github.com/MittalAshish/libqnio Ashish Mittal (2): block/vxhs.c: Add support for a new block device type called "vxhs" block/vxhs.c: Add qemu-iotests for new block device

[Qemu-devel] [PATCH v6 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2016-11-07 Thread Ashish Mittal
-img convert -f raw -O raw -n /var/lib/nova/instances/_base/0c5eacd5ebea5ed914b6a3e7b18f1ce734c386ad vxhs://192.168.0.1:/c6718f6b-0401-441d-a8c3-1f0064d75ee0 Signed-off-by: Ashish Mittal --- v6 changelog: (1) Added qemu-iotests for VxHS as a new patch in the series. (2) Replaced release

[Qemu-devel] [PATCH v6 2/2] block/vxhs.c: Add qemu-iotests for new block device type "vxhs"

2016-11-07 Thread Ashish Mittal
These changes use a vxhs test server that is a part of the following repository: https://github.com/MittalAshish/libqnio.git Signed-off-by: Ashish Mittal --- v6 changelog: (1) Added iotests for VxHS block device. tests/qemu-iotests/common| 6 ++ tests/qemu-iotests/common.config

Re: [Qemu-devel] [PATCH v4] This patch adds support for a new block device type called "vxhs".

2016-11-07 Thread ashish mittal
On Fri, Nov 4, 2016 at 6:04 AM, Stefan Hajnoczi wrote: > Please keep using "block/vxhs: Add Veritas HyperScale VxHS block device > support" as the cover letter email subject. This way tools are able to > automatically mark old versions of this patch series as obsolete. Sent out the new set of pa

Re: [Qemu-devel] [PATCH v4] This patch adds support for a new block device type called "vxhs".

2016-11-08 Thread ashish mittal
On Mon, Nov 7, 2016 at 5:52 PM, Fam Zheng wrote: > On Mon, 11/07 17:39, ashish mittal wrote: >> I guess the email subject of the individual patches is OK to >> change? > > Yes, that is fine, as long as it doesn't burden incremental reviewing > unnecessarily. > OK. Thanks!

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-11-14 Thread ashish mittal
Will look into these ASAP. On Mon, Nov 14, 2016 at 7:05 AM, Stefan Hajnoczi wrote: > On Wed, Sep 28, 2016 at 10:45 PM, Stefan Hajnoczi wrote: >> On Tue, Sep 27, 2016 at 09:09:49PM -0700, Ashish Mittal wrote: >> >> Review of .bdrv_open() and .bdrv_aio_writev() code paths. &

Re: [Qemu-devel] [PATCH v3 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-11-15 Thread ashish mittal
Hi Stefan, I had replied to the QEMUBH suggestion in the email below. Regards, Ashish On Tue, Aug 23, 2016 at 3:22 PM, ashish mittal wrote: > Thanks Stefan, I will look at block/quorum.c. > > I have sent V4 of the patch with a reworked parsing logic for both > JSON and URI. Both

Re: [Qemu-devel] [PATCH v6 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2016-11-15 Thread ashish mittal
Thanks for concluding on this. I will rearrange the qnio_api.h header accordingly as follows: +#include "qemu/osdep.h" +#include<=== after osdep.h +#include "block/block_int.h" +#include "qapi/qmp/qerror.h" +#include "qapi/qmp/qdict.h" +#include "qapi/qmp/qstring.h" +#include "trace.h" +#incl

Re: [Qemu-devel] [PATCH v6 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2016-11-15 Thread ashish mittal
On Mon, Nov 14, 2016 at 7:07 AM, Stefan Hajnoczi wrote: > On Mon, Nov 07, 2016 at 04:59:44PM -0800, Ashish Mittal wrote: >> Source code for the qnio library that this code loads can be downloaded from: >> https://github.com/MittalAshish/libqnio.git >> >> Sample command

Re: [Qemu-devel] [PATCH v3 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-11-15 Thread ashish mittal
Thank you. Will work with this. On Tue, Nov 15, 2016 at 12:48 PM, Stefan Hajnoczi wrote: > On Tue, Nov 15, 2016 at 11:02:34AM -0800, ashish mittal wrote: >> I had replied to the QEMUBH suggestion in the email below. >> >> Regards, >> Ashish >> >> On Tue,

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-11-15 Thread ashish mittal
Hi Stefan On Wed, Sep 28, 2016 at 2:45 PM, Stefan Hajnoczi wrote: > On Tue, Sep 27, 2016 at 09:09:49PM -0700, Ashish Mittal wrote: > > Review of .bdrv_open() and .bdrv_aio_writev() code paths. > > The big issues I see in this driver and libqnio: > > 1. Showstoppers like br

Re: [Qemu-devel] [PATCH v6 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2016-11-16 Thread ashish mittal
On Wed, Nov 16, 2016 at 3:27 AM, Stefan Hajnoczi wrote: > On Wed, Nov 16, 2016 at 9:49 AM, Fam Zheng wrote: >> On Wed, 11/16 10:04, Markus Armbruster wrote: >>> ashish mittal writes: >>> >>> > Thanks for concluding on this. >>> > >>

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-02-23 Thread ashish mittal
trace_vxhs_get_creds(user, password); +qdict_del(backing_options, str); +ret = -EINVAL; +goto out; +} +trace_vxhs_get_creds(user, password); + s->vdisk_hostinfo.host = g_strdup(server_host_opt); s->vdisk_hostinfo.port = g_ascii_strtoll(qemu_opt_get(tcp_op

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-02-24 Thread ashish mittal
el(backing_options, str); +ret = -EINVAL; +goto out; +} + +/* check if we got password via the --object argument */ +password = qcrypto_secret_lookup_as_utf8(secretid, &local_err); +if (local_err != NULL) { +trace_vxhs_get_creds(user, secretid, password); +

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-02-28 Thread ashish mittal
On Mon, Feb 27, 2017 at 1:22 AM, Daniel P. Berrange wrote: > On Fri, Feb 24, 2017 at 03:30:21PM -0800, ashish mittal wrote: >> Thanks! >> >> I hope the following is in line with what you suggested - > > Yes, that looks suitable for password auth > Thanks! >>

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-09-30 Thread ashish mittal
Hi Stefan, others, Thank you for all the review comments. On Wed, Sep 28, 2016 at 4:13 AM, Stefan Hajnoczi wrote: > On Tue, Sep 27, 2016 at 09:09:49PM -0700, Ashish Mittal wrote: >> +vxhs_bdrv_init(const char c) "Registering VxHS AIO driver%c" > > Why do several trac

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-10-11 Thread ashish mittal
Oct 4, 2016 at 9:02 PM, Jeff Cody wrote: > On Wed, Sep 28, 2016 at 12:13:32PM +0100, Stefan Hajnoczi wrote: >> On Tue, Sep 27, 2016 at 09:09:49PM -0700, Ashish Mittal wrote: > > [...] > >> > +/* >> > + * This is called by QEMU when a flush gets triggered from wi

[Qemu-devel] [PATCH RFC] Addition of Veritas HyperScale VxHS block device support

2016-08-01 Thread Ashish Mittal
vxhs type vdisk and read/write to it. (4) Source code for the new network IO library (libqnio) that we use has been open sourced and can be downloaded from: https://github.com/MittalAshish/libqnio.git Ashish Mittal (1): block/vxhs: Initial commit to add Veritas HyperScale VxHS block device

[Qemu-devel] [PATCH RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-08-01 Thread Ashish Mittal
This patch adds support for a new block device type called "vxhs". Source code for the library that this code loads can be downloaded from: https://github.com/MittalAshish/libqnio.git Signed-off-by: Ashish Mittal --- block/Makefile.objs |1 + block/vxhs.c

[Qemu-devel] [PATCH RFC] Addition of Veritas HyperScale VxHS block device support

2016-08-01 Thread Ashish Mittal
vxhs type vdisk and read/write to it. (4) Source code for the new network IO library (libqnio) that we use has been open sourced and can be downloaded from: https://github.com/MittalAshish/libqnio.git Ashish Mittal (1): block/vxhs: Initial commit to add Veritas HyperScale VxHS block device

[Qemu-devel] [PATCH RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-08-01 Thread Ashish Mittal
This patch adds support for a new block device type called "vxhs". Source code for the library that this code loads can be downloaded from: https://github.com/MittalAshish/libqnio.git Signed-off-by: Ashish Mittal --- block/Makefile.objs |1 + block/vxhs.c

Re: [Qemu-devel] [PATCH v11 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-04-12 Thread ashish mittal
On Tue, Apr 11, 2017 at 12:47 PM, Jeff Cody wrote: > On Mon, Apr 03, 2017 at 08:48:08PM -0700, Ashish Mittal wrote: >> Source code for the qnio library that this code loads can be downloaded from: >> https://github.com/VeritasHyperScale/libqnio.git >> >> Sample com

Re: [Qemu-devel] [PATCH v11 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-04-19 Thread ashish mittal
On Wed, Apr 19, 2017 at 9:27 AM, Stefan Hajnoczi wrote: > On Mon, Apr 03, 2017 at 08:48:08PM -0700, Ashish Mittal wrote: >> Source code for the qnio library that this code loads can be downloaded from: >> https://github.com/VeritasHyperScale/libqnio.git >> >> Sample com

Re: [Qemu-devel] [PATCH v11 0/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-04-20 Thread ashish mittal
Thanks Jeff! On Thu, Apr 20, 2017 at 8:03 AM, Jeff Cody wrote: > On Mon, Apr 03, 2017 at 08:48:07PM -0700, Ashish Mittal wrote: >> - Veritas HyperScale block driver in QEMU is designed to provide an >> accelerated >> IO path from KVM virtual machines to Veritas Hyper

Re: [Qemu-devel] [PATCH v6 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-01-31 Thread ashish mittal
t would it would be possible to use: +file.host=192.168.0.1,file.port= Similar to how NBD (see commit id 'a1674fd9') and SSH (see commit id 'bc225b1b5') are handled. /==/ If this proposal looks OK to the community, then I will make this u

Re: [Qemu-devel] [PATCH v6 2/2] block/vxhs.c: Add qemu-iotests for new block device type "vxhs"

2017-02-07 Thread ashish mittal
I plan to submit v7 soon, therefore going over any unanswered emails at this time. On Tue, Nov 8, 2016 at 12:44 PM, Jeff Cody wrote: > On Mon, Nov 07, 2016 at 04:59:45PM -0800, Ashish Mittal wrote: >> These changes use a vxhs test server that is a part of the following >> repos

Re: [Qemu-devel] [PATCH v3 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2017-02-07 Thread ashish mittal
6 at 12:51 PM, ashish mittal wrote: > Thank you. Will work with this. > > On Tue, Nov 15, 2016 at 12:48 PM, Stefan Hajnoczi wrote: >> On Tue, Nov 15, 2016 at 11:02:34AM -0800, ashish mittal wrote: >>> I had replied to the QEMUBH suggestion in the email below. >>>

[Qemu-devel] [PATCH v7 2/2] block/vxhs.c: Add qemu-iotests for new block device type "vxhs"

2017-02-07 Thread Ashish Mittal
From: Ashish Mittal These changes use a vxhs test server that is a part of the following repository: https://github.com/VeritasHyperScale/libqnio.git Signed-off-by: Ashish Mittal --- v7 changelog: (1) No changes. v6 changelog: (1) Added iotests for VxHS block device. tests/qemu-iotests

[Qemu-devel] [PATCH v7 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-02-07 Thread Ashish Mittal
From: Ashish Mittal Source code for the qnio library that this code loads can be downloaded from: https://github.com/VeritasHyperScale/libqnio.git Sample command line using JSON syntax: ./x86_64-softmmu/qemu-system-x86_64 -name instance-0008 -S -vnc 0.0.0.0:0 -k en-us -vga cirrus -device

Re: [Qemu-devel] [PATCH v6 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-02-08 Thread ashish mittal
... I was looking for a simplification and generation of only what's required. You can continue using the server syntax - perhaps just leave a note/comment in the code indicating the decision point and move on. On Thu, Feb 2, 2017 at 2:08 AM, Stefan Hajnoczi wrote: > On Tue, Jan 31, 2017 at 05:55:

Re: [Qemu-devel] [PATCH v7 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-02-08 Thread ashish mittal
On Wed, Feb 8, 2017 at 2:35 PM, Ketan Nilangekar wrote: > > > On 2/8/17, 2:21 PM, "Jeff Cody" wrote: > > On Tue, Feb 07, 2017 at 08:18:13PM -0800, Ashish Mittal wrote: > > From: Ashish Mittal > > > > Source code for the qnio library tha

[Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-02-08 Thread Ashish Mittal
From: Ashish Mittal Source code for the qnio library that this code loads can be downloaded from: https://github.com/VeritasHyperScale/libqnio.git Sample command line using JSON syntax: ./x86_64-softmmu/qemu-system-x86_64 -name instance-0008 -S -vnc 0.0.0.0:0 -k en-us -vga cirrus -device

[Qemu-devel] [PATCH v8 2/2] block/vxhs.c: Add qemu-iotests for new block device type "vxhs"

2017-02-08 Thread Ashish Mittal
From: Ashish Mittal These changes use a vxhs test server that is a part of the following repository: https://github.com/VeritasHyperScale/libqnio.git Signed-off-by: Ashish Mittal --- v8/v7 changelog: (1) No changes. v6 changelog: (1) Added iotests for VxHS block device. tests/qemu-iotests

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-02-09 Thread ashish mittal
On Wed, Feb 8, 2017 at 10:29 PM, Jeff Cody wrote: > On Wed, Feb 08, 2017 at 09:23:33PM -0800, Ashish Mittal wrote: >> From: Ashish Mittal >> >> Source code for the qnio library that this code loads can be downloaded from: >> https://github.com/VeritasHyperScale/libqn

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-02-09 Thread ashish mittal
On Thu, Feb 9, 2017 at 6:32 AM, Jeff Cody wrote: > On Thu, Feb 09, 2017 at 01:24:58AM -0800, ashish mittal wrote: >> On Wed, Feb 8, 2017 at 10:29 PM, Jeff Cody wrote: >> > On Wed, Feb 08, 2017 at 09:23:33PM -0800, Ashish Mittal wrote: >> >> From: Ashish Mittal &

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-02-09 Thread ashish mittal
On Thu, Feb 9, 2017 at 8:50 AM, Jeff Cody wrote: > On Thu, Feb 09, 2017 at 08:14:38AM -0800, ashish mittal wrote: >> On Thu, Feb 9, 2017 at 6:32 AM, Jeff Cody wrote: >> > On Thu, Feb 09, 2017 at 01:24:58AM -0800, ashish mittal wrote: >> >> On Wed, Feb 8, 2017

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-02-09 Thread ashish mittal
On Thu, Feb 9, 2017 at 10:08 AM, ashish mittal wrote: > On Thu, Feb 9, 2017 at 8:50 AM, Jeff Cody wrote: >> On Thu, Feb 09, 2017 at 08:14:38AM -0800, ashish mittal wrote: >>> On Thu, Feb 9, 2017 at 6:32 AM, Jeff Cody wrote: >>> > On Thu, Feb 09, 2017 at 01:24:5

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-02-09 Thread ashish mittal
On Thu, Feb 9, 2017 at 10:45 AM, ashish mittal wrote: > On Thu, Feb 9, 2017 at 10:08 AM, ashish mittal wrote: >> On Thu, Feb 9, 2017 at 8:50 AM, Jeff Cody wrote: >>> On Thu, Feb 09, 2017 at 08:14:38AM -0800, ashish mittal wrote: >>>> On Thu, Feb 9, 2017 at 6:32 A

Re: [Qemu-devel] [PATCH v6 2/2] block/vxhs.c: Add qemu-iotests for new block device type "vxhs"

2017-02-13 Thread ashish mittal
gt; > > > On Mon, Feb 13, 2017 at 01:37:25PM +, Stefan Hajnoczi wrote: > > > On Tue, Feb 07, 2017 at 03:12:36PM -0800, ashish mittal wrote: > > > > On Tue, Nov 8, 2016 at 12:44 PM, Jeff Cody > wrote: > > > > &g

Re: [Qemu-devel] [PATCH v6 2/2] block/vxhs.c: Add qemu-iotests for new block device type "vxhs"

2017-02-14 Thread ashish mittal
On Tue, Feb 14, 2017 at 10:12 AM, Jeff Cody wrote: > On Mon, Nov 07, 2016 at 04:59:45PM -0800, Ashish Mittal wrote: >> These changes use a vxhs test server that is a part of the following >> repository: >> https://github.com/MittalAshish/libqnio.git >> >

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-02-14 Thread ashish mittal
On Tue, Feb 14, 2017 at 12:51 PM, Jeff Cody wrote: > On Thu, Feb 09, 2017 at 01:24:58AM -0800, ashish mittal wrote: >> On Wed, Feb 8, 2017 at 10:29 PM, Jeff Cody wrote: >> > On Wed, Feb 08, 2017 at 09:23:33PM -0800, Ashish Mittal wrote: >> >> From: Ashish Mittal &

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-02-14 Thread ashish mittal
On Tue, Feb 14, 2017 at 2:34 PM, ashish mittal wrote: > On Tue, Feb 14, 2017 at 12:51 PM, Jeff Cody wrote: >> On Thu, Feb 09, 2017 at 01:24:58AM -0800, ashish mittal wrote: >>> On Wed, Feb 8, 2017 at 10:29 PM, Jeff Cody wrote: >>> > On Wed, Feb 08, 2017 at 09:23:3

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-02-15 Thread ashish mittal
Thanks! Will change accordingly in the next patch. On Tue, Feb 14, 2017 at 7:54 PM, Jeff Cody wrote: > On Tue, Feb 14, 2017 at 07:02:32PM -0800, ashish mittal wrote: >> On Tue, Feb 14, 2017 at 2:34 PM, ashish mittal wrote: >> > On Tue, Feb 14, 2017 at 12:51 PM, Jeff Cody w

Re: [Qemu-devel] [PATCH v7 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-02-15 Thread ashish mittal
On Mon, Feb 13, 2017 at 6:57 AM, Stefan Hajnoczi wrote: > On Tue, Feb 07, 2017 at 08:18:13PM -0800, Ashish Mittal wrote: >> +static int vxhs_parse_uri(const char *filename, QDict *options) >> +{ >> +URI *uri = NULL; >> +char *hoststr, *portstr; >> +

Re: [Qemu-devel] [PATCH v7 2/2] block/vxhs.c: Add qemu-iotests for new block device type "vxhs"

2017-02-15 Thread ashish mittal
On Mon, Feb 13, 2017 at 6:43 AM, Stefan Hajnoczi wrote: > On Tue, Feb 07, 2017 at 08:18:14PM -0800, Ashish Mittal wrote: >> diff --git a/tests/qemu-iotests/common.config >> b/tests/qemu-iotests/common.config >> index f6384fb..c7a80c0 100644 >> --- a/tests/qemu-iot

Re: [Qemu-devel] [PATCH v7 2/2] block/vxhs.c: Add qemu-iotests for new block device type "vxhs"

2017-02-15 Thread ashish mittal
Sorry, pressed the "send" button instead of "expand text" on the previous email ... On Mon, Feb 13, 2017 at 6:43 AM, Stefan Hajnoczi wrote: > On Tue, Feb 07, 2017 at 08:18:14PM -0800, Ashish Mittal wrote: >> diff --git a/tests/qemu-iotests/common.config >>

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-02-16 Thread ashish mittal
Hi, I am getting the following error with checkpatch.pl ERROR: externs should be avoided in .c files #78: FILE: block/vxhs.c:28: +QemuUUID qemu_uuid __attribute__ ((weak)); Is there any way to get around this, or does it mean that I would have to add a vxhs.h just for this one entry? Thanks, As

[Qemu-devel] [PATCH v9 2/2] block/vxhs.c: Add qemu-iotests for new block device type "vxhs"

2017-02-19 Thread Ashish Mittal
These changes use a vxhs test server that is a part of the following repository: https://github.com/VeritasHyperScale/libqnio.git Signed-off-by: Ashish Mittal --- v9 changelog: (1) Dropped second argument to set_prog_path(). We will pick up the test server location from the user's PAT

[Qemu-devel] [PATCH v9 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-02-19 Thread Ashish Mittal
ample command line using URI syntax: qemu-img convert -f raw -O raw -n /var/lib/nova/instances/_base/0c5eacd5ebea5ed914b6a3e7b18f1ce734c386ad vxhs://192.168.0.1:/c6718f6b-0401-441d-a8c3-1f0064d75ee0 Signed-off-by: Ashish Mittal --- v9 changelog: (1) Fixes for all the review comments from v8. I have left the definition

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-02-20 Thread ashish mittal
On Mon, Feb 20, 2017 at 3:02 AM, Stefan Hajnoczi wrote: > On Sat, Feb 18, 2017 at 12:30:31AM +, Ketan Nilangekar wrote: >> On 2/17/17, 1:42 PM, "Jeff Cody" wrote: >> >> On Thu, Feb 16, 2017 at 02:24:19PM -0800, ashish mittal wrote: >> >

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-03-05 Thread ashish mittal
On Wed, Mar 1, 2017 at 1:18 AM, Daniel P. Berrange wrote: > On Tue, Feb 28, 2017 at 02:51:39PM -0800, ashish mittal wrote: >> On Mon, Feb 27, 2017 at 1:22 AM, Daniel P. Berrange >> wrote: > >> >> +ret = -EINVAL; >> >> +goto out

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-03-07 Thread ashish mittal
range wrote: > On Sun, Mar 05, 2017 at 04:26:05PM -0800, ashish mittal wrote: >> On Wed, Mar 1, 2017 at 1:18 AM, Daniel P. Berrange >> wrote: >> > >> > Yes, that's how other parts of QEMU deal with SSL >> > >> > NB, QEMU needs to pass 3 path

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-03-08 Thread ashish mittal
On Wed, Mar 8, 2017 at 5:04 AM, Ketan Nilangekar wrote: > > >> On Mar 8, 2017, at 1:13 AM, Daniel P. Berrange wrote: >> >>> On Tue, Mar 07, 2017 at 05:27:55PM -0800, ashish mittal wrote: >>> Thanks! There is one more input I need some help with! >>>

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-03-10 Thread ashish mittal
On Wed, Mar 8, 2017 at 10:11 AM, Daniel P. Berrange wrote: > On Wed, Mar 08, 2017 at 09:59:32AM -0800, ashish mittal wrote: >> On Wed, Mar 8, 2017 at 5:04 AM, Ketan Nilangekar >> wrote: >> > >> > >> >> On Mar 8, 2017, at 1:13 AM, Daniel P. Berran

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-03-16 Thread ashish mittal
On Mon, Mar 13, 2017 at 2:57 AM, Daniel P. Berrange wrote: > On Tue, Mar 07, 2017 at 05:27:55PM -0800, ashish mittal wrote: >> Thanks! There is one more input I need some help with! >> >> VxHS network library opens a fixed number of connection channels to a >> given hos

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-03-17 Thread ashish mittal
On Thu, Mar 16, 2017 at 5:29 PM, ashish mittal wrote: > On Mon, Mar 13, 2017 at 2:57 AM, Daniel P. Berrange > wrote: >> On Tue, Mar 07, 2017 at 05:27:55PM -0800, ashish mittal wrote: >>> Thanks! There is one more input I need some help with! >>> >>> VxHS

[Qemu-devel] [PATCH v2 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-08-07 Thread Ashish Mittal
to) review comments from Stefan. Signed-off-by: Ashish Mittal --- block/Makefile.objs |2 + block/trace-events | 40 ++ block/vxhs.c| 1199 +++ block/vxhs.h| 294 + configure | 50 +++ 5 files changed, 1585

Re: [Qemu-devel] [PATCH RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-08-08 Thread ashish mittal
Hi Christopher, We are working on a sample server implementation, and will add it to libqnio soon. Thanks, Ashish On Mon, Aug 8, 2016 at 12:46 AM, Christoph Hellwig wrote: > On Sun, Jul 31, 2016 at 04:52:16PM -0700, Ashish Mittal wrote: > > This patch adds support for a new block de

[Qemu-devel] [PATCH v3 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-08-13 Thread Ashish Mittal
08 -S -vnc 0.0.0.0:0 -k en-us -vga cirrus -device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x5 -msg timestamp=on 'json:{"driver":"vxhs","vdisk_id":"{c3e9095a-a5ee-4dce-afeb-2a59fb387410}","server":[{"host":"172.172.17.4

Re: [Qemu-devel] [PATCH v3 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-08-15 Thread ashish mittal
>> +/* >> + * Convert the json formatted command line into qapi. >> +*/ >> + >> +static int vxhs_parse_json(BlockdevOptionsVxHS *conf, >> + QDict *options, Error **errp) >> +{ ... >> +errno = EINVAL; >> +return -errno; >> +} > > Ewww this is really horrible

Re: [Qemu-devel] [PATCH v3 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-08-17 Thread ashish mittal
rser changes, etc. The second patch just does the QEMU driver integration & unit tests. ... // Regards, Ashish On Wed, Aug 17, 2016 at 4:22 AM, Paolo Bonzini wrote: > > > On 15/08/2016 18:29, ashish mittal wrote: >>>> +/* >>>> + * Convert

Re: [Qemu-devel] [PATCH v3 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-08-20 Thread ashish mittal
h is pretty straightforward, but not very helpful. Could somebody please suggest a sample implementation (other than gluster.c) that parses a list of server like options in the json format? Thanks, Ashish On Wed, Aug 17, 2016 at 2:58 PM, ashish mittal wrote: > Thanks Paolo, and everyon

[Qemu-devel] [PATCH v4 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-08-23 Thread Ashish Mittal
quot;"},{"host":"172.172.17.2","port":""}]}' Sample command line using URI syntax: qemu-img convert -f raw -O raw -n /var/lib/nova/instances/_base/0c5eacd5ebea5ed914b6a3e7b18f1ce734c386ad vxhs://192.168.0.1:/%7Bc6718f6b-0401-441d-a8c

Re: [Qemu-devel] [PATCH v3 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-08-23 Thread ashish mittal
wrote: > On Sat, Aug 20, 2016 at 11:42:22AM -0700, ashish mittal wrote: >> I'm trying to understand how I can parse a json command line having >> multiple server list (InetSocketAddressList) without the QemuOpts -> >> QDict -> QAPI conversion that I am curren

Re: [Qemu-devel] [PATCH v3 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-08-23 Thread ashish mittal
Hi Daniel, In V4 of the patch: On Mon, Aug 15, 2016 at 3:20 AM, Daniel P. Berrange wrote: >> + * Convert the json formatted command line into qapi. >> +*/ >> + >> +static int vxhs_parse_json(BlockdevOptionsVxHS *conf, >> + QDict *options, Error **errp) >> +{ >>

Re: [Qemu-devel] [PATCH v3 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-08-23 Thread ashish mittal
Hi Kevin, Changed per your suggestion in V4 patch. Please review when you get some time. Thanks, Ashish On Mon, Aug 15, 2016 at 3:47 AM, Kevin Wolf wrote: > Am 15.08.2016 um 12:20 hat Daniel P. Berrange geschrieben: >> On Sat, Aug 13, 2016 at 09:35:12PM -0700, Ashish Mit

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-03-22 Thread ashish mittal
On Mon, Mar 20, 2017 at 5:55 AM, Daniel P. Berrange wrote: > On Fri, Mar 17, 2017 at 06:44:56PM -0700, ashish mittal wrote: >> On Thu, Mar 16, 2017 at 5:29 PM, ashish mittal wrote: >> > On Mon, Mar 13, 2017 at 2:57 AM, Daniel P. Berrange >> > wrote: >> >

[Qemu-devel] [PATCH v10 2/2] block/vxhs.c: Add qemu-iotests for new block device type "vxhs"

2017-03-26 Thread Ashish Mittal
These changes use a vxhs test server that is a part of the following repository: https://github.com/VeritasHyperScale/libqnio.git Signed-off-by: Ashish Mittal --- v10 changelog: (1) Redirect o/p of "$QEMU_VXHS -d $TEST_DIR" to /dev/null v9 changelog: (1) Dropped second a

[Qemu-devel] [PATCH v10 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-03-26 Thread Ashish Mittal
vxhs,endpoint=client -c 'read -v 66000 2.5k' 'json:{"server.host": "127.0.0.1", "server.port": "", "vdisk-id": "/test.raw", "driver": "vxhs", "tls-creds":"tls0"}' Signed-off-by:

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-03-26 Thread ashish mittal
On Wed, Mar 22, 2017 at 5:03 PM, ashish mittal wrote: > On Mon, Mar 20, 2017 at 5:55 AM, Daniel P. Berrange > wrote: >> On Fri, Mar 17, 2017 at 06:44:56PM -0700, ashish mittal wrote: >>> On Thu, Mar 16, 2017 at 5:29 PM, ashish mittal wrote: >>> > On Mon,

Re: [Qemu-devel] [PATCH v10 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-03-27 Thread ashish mittal
On Mon, Mar 27, 2017 at 8:56 AM, Eric Blake wrote: > On 03/26/2017 09:50 PM, Ashish Mittal wrote: >> Source code for the qnio library that this code loads can be downloaded from: >> https://github.com/VeritasHyperScale/libqnio.git > > When sending a multi-patch series, pleas

Re: [Qemu-devel] [PATCH v10 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-03-27 Thread ashish mittal
On Mon, Mar 27, 2017 at 10:27 AM, Stefan Hajnoczi wrote: > On Sun, Mar 26, 2017 at 07:50:35PM -0700, Ashish Mittal wrote: > > Have you tested live migration? > > If live migration is not supported then a migration blocker should be > added using migrate_add_blocker(). >

Re: [Qemu-devel] [PATCH v10 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-03-29 Thread ashish mittal
hen send v11 series if everyone okays the diff? Regards, Ashish On Tue, Mar 28, 2017 at 10:03 AM, Jeff Cody wrote: > On Sun, Mar 26, 2017 at 07:50:35PM -0700, Ashish Mittal wrote: >> Source code for the qnio library that this code loads can be downloaded from: >> https://github.com/Ve

Re: [Qemu-devel] [PATCH v10 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-03-31 Thread ashish mittal
On Mon, Mar 27, 2017 at 6:04 PM, ashish mittal wrote: > On Mon, Mar 27, 2017 at 10:27 AM, Stefan Hajnoczi wrote: >> On Sun, Mar 26, 2017 at 07:50:35PM -0700, Ashish Mittal wrote: >> >> Have you tested live migration? >> >> If live migration is not supported t

Re: [Qemu-devel] [PATCH v10 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-04-03 Thread ashish mittal
On Mon, Apr 3, 2017 at 8:11 AM, Stefan Hajnoczi wrote: > On Fri, Mar 31, 2017 at 11:25:02AM -0700, ashish mittal wrote: >> On Mon, Mar 27, 2017 at 6:04 PM, ashish mittal wrote: >> > On Mon, Mar 27, 2017 at 10:27 AM, Stefan Hajnoczi >> > wrote: >> >> O

[Qemu-devel] [PATCH v11 0/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-04-03 Thread Ashish Mittal
HyperScale storage service. This library (libvxhs) has been open sourced and is available on github here: https://github.com/VeritasHyperScale/libqnio.git Ashish Mittal (2): block/vxhs.c: Add support for a new block device type called "vxhs" block/vxhs.c: Add qemu-iotests for new block d

  1   2   >