[Qemu-devel] [PATCH v2 0/9] x86 AREG0 conversion

2012-08-07 Thread Blue Swirl
s 1.2 material. Blue Swirl (9): x86: avoid AREG0 for FPU helpers x86: avoid AREG0 for condition code helpers x86: avoid AREG0 for integer helpers x86: avoid AREG0 for SVM helpers x86: avoid AREG0 for SMM helpers x86: use wrappers for memory access helpers x86: avoid AREG0 for misc he

[Qemu-devel] [PATCH v2 2/9] x86: avoid AREG0 for condition code helpers

2012-08-07 Thread Blue Swirl
Add an explicit CPUX86State parameter instead of relying on AREG0. Signed-off-by: Blue Swirl --- target-i386/Makefile.objs |1 - target-i386/cc_helper.c | 199 +-- target-i386/cc_helper_template.h| 36 +++--- target-i386/helper.h

[Qemu-devel] [PATCH v2 3/9] x86: avoid AREG0 for integer helpers

2012-08-07 Thread Blue Swirl
Add an explicit CPUX86State parameter instead of relying on AREG0. Signed-off-by: Blue Swirl --- target-i386/Makefile.objs |1 - target-i386/helper.h| 50 +- target-i386/int_helper.c| 36 +- target-i386

[Qemu-devel] [PATCH v2 4/9] x86: avoid AREG0 for SVM helpers

2012-08-07 Thread Blue Swirl
Add an explicit CPUX86State parameter instead of relying on AREG0. Signed-off-by: Blue Swirl --- target-i386/Makefile.objs |1 - target-i386/helper.h | 22 +++--- target-i386/svm_helper.c | 181 ++--- target-i386/translate.c | 21

[Qemu-devel] [PATCH v2 7/9] x86: avoid AREG0 for misc helpers

2012-08-07 Thread Blue Swirl
Add an explicit CPUX86State parameter instead of relying on AREG0. Signed-off-by: Blue Swirl --- target-i386/Makefile.objs |1 - target-i386/helper.h | 40 target-i386/misc_helper.c | 77 + target-i386/translate.c

[Qemu-devel] [PATCH v2 8/9] x86: avoid AREG0 in segmentation helpers

2012-08-07 Thread Blue Swirl
Add an explicit CPUX86State parameter instead of relying on AREG0. Rename remains of op_helper.c to seg_helper.c. Signed-off-by: Blue Swirl --- target-i386/Makefile.objs |1 - target-i386/helper.h | 38 target-i386/seg_helper.c | 217

Re: [Qemu-devel] [PATCH v5 1/2] qemu: Add a config option for GlusterFS as block backend

2012-08-07 Thread Blue Swirl
On Tue, Aug 7, 2012 at 8:00 AM, Bharata B Rao wrote: > qemu: Add a config option for GlusterFS as block backend > > From: Bharata B Rao > > GlusterFS support in QEMU depends on libgfapi, libgfrpc and > libgfxdr provided by GlusterFS. > > Signed-off-by: Bharata B Rao > --- > > configure | 34 +

Re: [Qemu-devel] [RFC/PATCH 1/1] USB code fenced for s390

2012-08-07 Thread Blue Swirl
On Tue, Aug 7, 2012 at 12:26 PM, Peter Maydell wrote: > On 7 August 2012 13:19, Christian Borntraeger wrote: >> +#if defined(TARGET_HAS_USB) && (TARGET_HAS_USB == 1) >> /* init USB devices */ >> if (usb_enabled) { >> if (foreach_device_config(DEV_USB, usb_parse) < 0) >>

Re: [Qemu-devel] [RFC V2 01/10] quorum: Create quorum.c, add QuorumSingleAIOCB and QuorumAIOCB.

2012-08-07 Thread Blue Swirl
On Tue, Aug 7, 2012 at 1:44 PM, Benoît Canet wrote: > Signed-off-by: Benoit Canet > --- > block/Makefile.objs |1 + > block/quorum.c | 44 > 2 files changed, 45 insertions(+) > create mode 100644 block/quorum.c > > diff --git a/block/Makef

[Qemu-devel] [PATCH v2 9/9] x86: switch to AREG0 free mode

2012-08-07 Thread Blue Swirl
Add an explicit CPUX86State parameter instead of relying on AREG0. Remove temporary wrappers and switch to AREG0 free mode. Signed-off-by: Blue Swirl --- configure |2 +- cpu-all.h | 22 ++ target-i386/Makefile.objs |2 - target-i386/cpu.h

Re: [Qemu-devel] [RFC V2 03/10] quorum: Add quorum_open().

2012-08-07 Thread Blue Swirl
On Tue, Aug 7, 2012 at 1:44 PM, Benoît Canet wrote: > Signed-off-by: Benoit Canet > --- > block/quorum.c | 62 > > 1 file changed, 62 insertions(+) > > diff --git a/block/quorum.c b/block/quorum.c > index e0405b6..de58ab8 100644 > --- a

[Qemu-devel] [PATCH v2 5/9] x86: avoid AREG0 for SMM helpers

2012-08-07 Thread Blue Swirl
Add an explicit CPUX86State parameter instead of relying on AREG0. Signed-off-by: Blue Swirl --- target-i386/Makefile.objs |1 - target-i386/helper.h |2 +- target-i386/smm_helper.c | 14 -- target-i386/translate.c |2 +- 4 files changed, 6 insertions(+), 13

Re: [Qemu-devel] [RFC V2 04/10] quorum: Add quorum_close().

2012-08-07 Thread Blue Swirl
On Tue, Aug 7, 2012 at 1:44 PM, Benoît Canet wrote: > Signed-off-by: Benoit Canet > --- > block/quorum.c | 12 > 1 file changed, 12 insertions(+) > > diff --git a/block/quorum.c b/block/quorum.c > index de58ab8..9da0432 100644 > --- a/block/quorum.c > +++ b/block/quorum.c > @@ -10

[Qemu-devel] [PATCH v2 6/9] x86: use wrappers for memory access helpers

2012-08-07 Thread Blue Swirl
Switch to wrapped versions of memory access functions. Signed-off-by: Blue Swirl --- target-i386/cpu.h| 10 ++ target-i386/mem_helper.c | 10 ++ target-i386/seg_helper.c | 209 +++--- 3 files changed, 126 insertions(+), 103 deletions(-) diff

Re: [Qemu-devel] [PATCH 3/5] s390: Add new channel I/O based virtio transport.

2012-08-07 Thread Blue Swirl
On Tue, Aug 7, 2012 at 2:52 PM, Cornelia Huck wrote: > Add a new virtio transport that uses channel commands to perform > virtio operations. > > Add a new machine type s390-ccw that uses this virtio-ccw transport > and make it the default machine for s390. > > Signed-off-by: Cornelia Huck > --- >

Re: [Qemu-devel] [PATCH 2/5] s390: Virtual channel subsystem support.

2012-08-07 Thread Blue Swirl
On Tue, Aug 7, 2012 at 2:52 PM, Cornelia Huck wrote: > Provide a mechanism for qemu to provide fully virtual subchannels to > the guest. In the KVM case, this relies on the kernel's css support. > The !KVM case is not yet supported. > > Signed-off-by: Cornelia Huck > --- > hw/s390x/Makefile.objs

Re: [Qemu-devel] For all targets and machine types: "start to monitor" smoke test

2012-08-07 Thread Blue Swirl
On Tue, Aug 7, 2012 at 7:26 PM, Markus Armbruster wrote: > Very basic smoke test: start QEMU with -monitor stdio, quit immediately. > Wouldn't it be nice if that worked for all targets and machine types? > > Many targets have mandatory options (fun oxymoron), such as -kernel or > -pflash. Can't s

Re: [Qemu-devel] [RFC 14/15] i386: topology & APIC ID utility functions (v2)

2012-08-08 Thread Blue Swirl
opo_apicid_for_cpu() > - Rename __make_apicid() to topo_make_apicid() > - Spaces around operators on test-x86-cpuid.c, as requested by >Blue Swirl > - Make test-x86-cpuid a target-specific test > > Cc: Blue Swirl Looks OK. Would it make sense to add a quick fuzzing test (cal

Re: [Qemu-devel] [PATCH v8 5/6] introduce a new qom device to deal with panicked event

2012-08-08 Thread Blue Swirl
On Wed, Aug 8, 2012 at 2:47 AM, Wen Congyang wrote: > If the target is x86/x86_64, the guest's kernel will write 0x01 to the > port KVM_PV_EVENT_PORT when it is panciked. This patch introduces a new > qom device kvm_pv_ioport to listen this I/O port, and deal with panicked > event according to pan

Re: [Qemu-devel] [PATCH 3/5] s390: Add new channel I/O based virtio transport.

2012-08-08 Thread Blue Swirl
On Wed, Aug 8, 2012 at 8:28 AM, Cornelia Huck wrote: > On Tue, 7 Aug 2012 20:47:22 + > Blue Swirl wrote: > > >> > diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c >> > new file mode 100644 >> > index 000..8a90c3a >> > --- /dev/nu

Re: [Qemu-devel] Is it possible to detect guest OS modifying pte inside QEMU?

2012-08-08 Thread Blue Swirl
On Wed, Aug 8, 2012 at 8:33 AM, 陳韋任 (Wei-Ren Chen) wrote: > On Wed, Aug 08, 2012 at 09:05:18AM +0100, Peter Maydell wrote: >> On 8 August 2012 08:38, 陳韋任 (Wei-Ren Chen) wrote: >> > Just for research, we are studying if we can leave the guest page >> > table walk to underlying hardware rather th

Re: [Qemu-devel] [PATCH 2/5] s390: Virtual channel subsystem support.

2012-08-08 Thread Blue Swirl
On Wed, Aug 8, 2012 at 8:17 AM, Cornelia Huck wrote: > On Tue, 7 Aug 2012 21:00:59 + > Blue Swirl wrote: > > >> > diff --git a/hw/s390x/css.c b/hw/s390x/css.c >> > new file mode 100644 >> > index 000..7941c44 >> > --- /dev/nu

Re: [Qemu-devel] [PATCH 04/15] memory: MemoryRegion topology must be stable when updating

2012-08-08 Thread Blue Swirl
On Wed, Aug 8, 2012 at 6:25 AM, Liu Ping Fan wrote: > From: Liu Ping Fan > > Using mem_map_lock to protect among updaters. So we can get the intact > snapshot of mem topology -- FlatView & radix-tree. > > Signed-off-by: Liu Ping Fan > --- > exec.c |3 +++ > memory.c | 22 +++

Re: [Qemu-devel] [PATCH 08/15] memory: introduce PhysMap to present snapshot of toploygy

2012-08-08 Thread Blue Swirl
On Wed, Aug 8, 2012 at 6:25 AM, Liu Ping Fan wrote: > From: Liu Ping Fan > > PhysMap contain the flatview and radix-tree view, they are snapshot > of system topology and should be consistent. With PhysMap, we can > swap the pointer when updating and achieve the atomic. > > Signed-off-by: Liu Ping

Re: [Qemu-devel] [PATCH 09/15] memory: prepare flatview and radix-tree for rcu style access

2012-08-08 Thread Blue Swirl
On Wed, Aug 8, 2012 at 6:25 AM, Liu Ping Fan wrote: > From: Liu Ping Fan > > Flatview and radix view are all under the protection of pointer. > And this make sure the change of them seem to be atomic! > > The mr accessed by radix-tree leaf or flatview will be reclaimed > after the prev PhysMap no

Re: [Qemu-devel] For all targets and machine types: "start to monitor" smoke test

2012-08-08 Thread Blue Swirl
On Wed, Aug 8, 2012 at 7:39 AM, Markus Armbruster wrote: > Blue Swirl writes: > >> On Tue, Aug 7, 2012 at 7:26 PM, Markus Armbruster wrote: >>> Very basic smoke test: start QEMU with -monitor stdio, quit immediately. >>> Wouldn't it be nice if that worke

Re: [Qemu-devel] [PATCH 2/5] s390: Virtual channel subsystem support.

2012-08-08 Thread Blue Swirl
On Wed, Aug 8, 2012 at 7:34 PM, Peter Maydell wrote: > On 8 August 2012 20:16, Blue Swirl wrote: >> On Wed, Aug 8, 2012 at 8:17 AM, Cornelia Huck >> wrote: >>> On Tue, 7 Aug 2012 21:00:59 + >>> Blue Swirl wrote: >>>> Please use more descr

Re: [Qemu-devel] Is it possible to detect guest OS modifying pte inside QEMU?

2012-08-09 Thread Blue Swirl
On Thu, Aug 9, 2012 at 3:15 AM, 陳韋任 (Wei-Ren Chen) wrote: > Hi Blue, > >> > You mean like what KVM does for shadow page table? I think we should >> > mprotect the QEMU virtual memory which is allocated as a guest page >> > table by the guest OS, right? If so, how do we know what (QEMU) virtual >

Re: [Qemu-devel] [PATCH 04/15] memory: MemoryRegion topology must be stable when updating

2012-08-09 Thread Blue Swirl
On Thu, Aug 9, 2012 at 7:28 AM, liu ping fan wrote: > On Thu, Aug 9, 2012 at 3:17 AM, Blue Swirl wrote: >> On Wed, Aug 8, 2012 at 6:25 AM, Liu Ping Fan wrote: >>> From: Liu Ping Fan >>> >>> Using mem_map_lock to protect among updaters. So we can get the

Re: [Qemu-devel] [qemu-devel] [PATCH V2 0/3] [RFC] libqblock draft code v2

2012-08-09 Thread Blue Swirl
On Thu, Aug 9, 2012 at 10:10 AM, Wenchao Xia wrote: > This patch intrudce libqblock API, libqblock-test is used as a test case. > > V2: > Using struct_size and [xxx]_new [xxx]_free to keep ABI. > Using embbed structure to class format options in image creating. > Format specific options we

Re: [Qemu-devel] [qemu-devel] [PATCH V2 2/3] [RFC] libqblock-API design

2012-08-09 Thread Blue Swirl
On Thu, Aug 9, 2012 at 10:12 AM, Wenchao Xia wrote: > This patch is the API design. > > Signed-off-by: Wenchao Xia > --- > libqblock.c | 670 > +++ > libqblock.h | 447 +++ > 2 files changed, 1117 in

Re: [Qemu-devel] [qemu-devel] [PATCH V2 3/3] [RFC] libqblock-test case.

2012-08-09 Thread Blue Swirl
On Thu, Aug 9, 2012 at 10:12 AM, Wenchao Xia wrote: > This file simulate the caller to test the library. > > Signed-off-by: Wenchao Xia > --- > libqblock-test.c | 197 > ++ Please move this to test/ and build with other tests. > 1 files c

Re: [Qemu-devel] [PATCH] handle device help before accelerator set up

2012-08-09 Thread Blue Swirl
On Thu, Aug 9, 2012 at 1:23 PM, Bruce Rogers wrote: > A command line device probe using just -device "?" gets processed > after qemu-kvm initializes the accelerator. If /dev/kvm is not > present, the accelerator check will fail (kvm is defaulted to on), > which causes libvirt to not be set up to h

Re: [Qemu-devel] [PATCH 1/3] net: notify iothread after flushing queue

2012-08-09 Thread Blue Swirl
On Thu, Aug 9, 2012 at 2:45 PM, Paolo Bonzini wrote: > virtio-net has code to flush the queue and notify the iothread > whenever new receive buffers are added by the guest. That is > fine, and indeed we need to do the same in all other drivers. > However, notifying the iothread should be work for

Re: [Qemu-devel] [PATCH 00/19] unicore32: Add unicore32-softmmu support

2012-08-09 Thread Blue Swirl
dded in PKUnity-3 SoC, so we add necessary puv3 > devices simulation codes together. > Only minimal system control modules are simulated, to make linux kernel > boot and busybox run in initramfs. > > Thanks Andreas Farber, Blue Swirl, Chen Weiren and Dunrong Huang for > their pric

Re: [Qemu-devel] [PATCH 22/23] sparc: Suppress unused default drives

2012-08-09 Thread Blue Swirl
On Thu, Aug 9, 2012 at 1:31 PM, Markus Armbruster wrote: > Cc: Blue Swirl Acked-by: Blue Swirl > > Suppress default floppy drive for machines leon3_generic, SS-600MP, > SS-1000, SS-2000. > > Suppress default CD-ROM drive for machine leon3_generic. > > Suppress d

Re: [Qemu-devel] [PATCH v3 0/4] esp: add Tekram DC-390 emulation (PC SCSI adapter)

2012-08-09 Thread Blue Swirl
On Sat, Aug 4, 2012 at 7:10 PM, Hervé Poussineau wrote: > This patch cleans up esp SCSI adapter emulation, by moving to > a new file the esp PCI emulation (patches 1 to 3). > Patch 4 adds a DC-390 emulation, which is not compiled on sparc. > > You're now able to install MS Windows NT 3.1 (which do

Re: [Qemu-devel] [PATCH] MIPS: Correct FCR0 initialization

2012-08-09 Thread Blue Swirl
->cpu_model->CP0_SRSConf4_rw_bitmask; >>> > env->CP0_SRSConf4 = env->cpu_model->CP0_SRSConf4; >>> > +env->active_fpu.fcr0 = env->cpu_model->CP1_fcr0; >>> >>> Reviewed-by: Richard Henderson > >> What are the plans for this patch

Re: [Qemu-devel] [PATCH] target-xtensa: make default CPU depend on target endianness

2012-08-09 Thread Blue Swirl
Thanks, applied. On Wed, Aug 8, 2012 at 10:07 AM, Max Filippov wrote: > This makes usable default for -cpu option both for qemu-system-xtensa > and qemu-system-xtensaeb fixing the following error: > > $ qemu-system-xtensaeb -M sim > Unable to find CPU definition > > Signed-off-by: Max Fil

Re: [Qemu-devel] [PATCH] target-xtensa: make 'sim' to be the default machine

2012-08-09 Thread Blue Swirl
Thanks, applied. On Wed, Aug 8, 2012 at 11:31 PM, Max Filippov wrote: > This fixes the following error: > > $ qemu-system-xtensa -cpu help > Segmentation fault > > Signed-off-by: Max Filippov > --- > hw/xtensa_sim.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff

Re: [Qemu-devel] [Qemu-devel for-1.2] qemu_rearm_alarm_timer: do not call rearm if the next deadline is INT64_MAX

2012-08-09 Thread Blue Swirl
Thanks, applied. On Thu, Aug 9, 2012 at 3:35 PM, Andreas Färber wrote: > Am 27.07.2012 19:00, schrieb Andreas Färber: >> Am 12.06.2012 10:24, schrieb Andreas Färber: >>> Am 29.05.2012 15:35, schrieb Stefano Stabellini: qemu_rearm_alarm_timer partially duplicates the code in qemu_next_al

Re: [Qemu-devel] [PATCH 0/4 v2] target-i386: move tcg intialization inside CPU object

2012-08-09 Thread Blue Swirl
Thanks, applied all. On Mon, Jul 23, 2012 at 7:46 AM, Igor Mammedov wrote: > ping. > > On 06/25/2012 03:55 PM, Igor Mammedov wrote: >> >> v2: >>- drop usage of prev_debug_excp_handler consistently in all users >>- split from reset patches to avoid confusion of inter-dependency >> >> Comp

Re: [Qemu-devel] [PATCH v2] handle device help before accelerator set up

2012-08-09 Thread Blue Swirl
Thanks, applied. On Thu, Aug 9, 2012 at 6:47 PM, Bruce Rogers wrote: > A command line device probe using just -device "?" gets processed > after qemu-kvm initializes the accelerator. If /dev/kvm is not > present, the accelerator check will fail (kvm is defaulted to on), > which causes libvirt to

Re: [Qemu-devel] [PATCH 11/11] configure: Check for -Werror causing failures when compiling tests

2012-08-09 Thread Blue Swirl
On Thu, Aug 9, 2012 at 6:24 PM, Peter Maydell wrote: > On 4 August 2012 18:57, Blue Swirl wrote: >> On Sat, Jul 28, 2012 at 1:48 PM, Peter Maydell >> wrote: >>> On 28 July 2012 13:31, Blue Swirl wrote: >>>> I'm getting this error, probably because n

[Qemu-devel] [PATCH] configure: fix double check tests with Clang

2012-08-09 Thread Blue Swirl
ned-off-by: Blue Swirl --- configure |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/configure b/configure index d8ec050..c2955f8 100755 --- a/configure +++ b/configure @@ -2255,7 +2255,7 @@ cat > $TMPC < #include #include -int main(void) { return preadv =

Re: [Qemu-devel] [qemu-devel] [PATCH V2 0/3] [RFC] libqblock draft code v2

2012-08-11 Thread Blue Swirl
On Fri, Aug 10, 2012 at 8:04 AM, Wenchao Xia wrote: >Thanks for your review, sorry I have forgot some fixing you > mentioned before, will correct them this time. > > 于 2012-8-10 1:12, Blue Swirl 写道: > >> On Thu, Aug 9, 2012 at 10:10 AM, Wenchao Xia >> wrote: >

Re: [Qemu-devel] [RFC 01/20] target-i386: return Error from cpu_x86_find_by_name()

2012-08-11 Thread Blue Swirl
On Fri, Aug 10, 2012 at 11:22 AM, Igor Mammedov wrote: > it will allow to use property setters there later. > > Signed-off-by: Igor Mammedov > --- > target-i386/cpu.c | 18 +++--- > 1 file changed, 15 insertions(+), 3 deletions(-) > > diff --git a/target-i386/cpu.c b/target-i386/cpu.

Re: [Qemu-devel] [PATCH v9 5/7] block: Convert close calls to qemu_close

2012-08-11 Thread Blue Swirl
On Sat, Aug 11, 2012 at 1:14 PM, Corey Bryant wrote: > This patch converts all block layer close calls, that correspond > to qemu_open calls, to qemu_close. > > Signed-off-by: Corey Bryant > --- > v5: > -This patch is new in v5. (kw...@redhat.com, ebl...@redhat.com) > > v6-v9: > -No changes > >

Re: [Qemu-devel] [PATCH] w64: Fix compiler warning [-Wformat]

2012-08-11 Thread Blue Swirl
On Fri, Aug 10, 2012 at 7:45 PM, Stefan Weil wrote: > Glib2 uses __printf__ in macro G_GNUC_PRINTF for printf like > functions. For MinGW, we want __gnu_printf__ because we use > POSIX format specifiers instead of the MS format specifiers. I get these warnings from glib: CCtrace/control.o I

Re: [Qemu-devel] [PATCHv2 00/19] unicore32: Add unicore32-softmmu support

2012-08-11 Thread Blue Swirl
SoC, so we add necessary puv3 > devices simulation codes together. > Only minimal system control modules are simulated, to make linux kernel > boot and busybox run in initramfs. > > Thanks Andreas Farber, Blue Swirl, Chen Weiren and Dunrong Huang for > their priceless adv

Re: [Qemu-devel] [PATCH] Makefile: add qapi.py dependencies

2012-08-11 Thread Blue Swirl
On Fri, Aug 10, 2012 at 1:08 PM, Stefan Hajnoczi wrote: > Commit 427a1a2cb1d35b83b6302886f46289f6d617134d ("qapi: avoid reserved > keywords") modifies qapi.py, which is used by qapi-types.py and other > Python scripts. Because Makefile has no dependencies for qapi.py the > qapi code generator wil

Re: [Qemu-devel] [PATCH] exec.c: fix dirty bitmap reallocation

2012-08-11 Thread Blue Swirl
Thanks, applied. On Fri, Aug 10, 2012 at 2:45 PM, Igor Mitsyanko wrote: > For each newly created RAM block, dirty bitmap is reallocated with g_realloc, > which doesn't > make any promises on initial content of new extra data in returned buffer. In > theory, > we initialize this new data with cp

[Qemu-devel] [PATCH v2] configure: fix double check tests with Clang

2012-08-11 Thread Blue Swirl
ned-off-by: Blue Swirl --- v1->v2: remove void * casts. --- configure |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/configure b/configure index 12fdc22..f0dbc03 100755 --- a/configure +++ b/configure @@ -2256,7 +2256,7 @@ cat > $TMPC < #include #incl

Re: [Qemu-devel] [PATCH 11/11] configure: Check for -Werror causing failures when compiling tests

2012-08-11 Thread Blue Swirl
Thanks, applied. On Wed, Jul 18, 2012 at 2:10 PM, Peter Maydell wrote: > Add support for checking whether test case code can compile without > warnings, by recompiling each successful test with -Werror. If the > -Werror version doesn't pass, we bail out. This gives us the same > level of visibil

Re: [Qemu-devel] [PATCH v2] configure: fix double check tests with Clang

2012-08-11 Thread Blue Swirl
On Sat, Aug 11, 2012 at 5:44 PM, Peter Maydell wrote: > On 11 August 2012 16:11, Blue Swirl wrote: >> Configuring with Clang compiler with -Werror would not work after >> improved checks: >> /tmp/qemu-conf--25992-.c:4:32: error: self-comparison always evaluates >> to t

Re: [Qemu-devel] [PATCH 1/2] avoid asprintf (not available on mingw64)

2012-08-12 Thread Blue Swirl
On Fri, Aug 10, 2012 at 2:18 PM, Markus Armbruster wrote: > Gerd Hoffmann writes: > >> Signed-off-by: Gerd Hoffmann >> --- >> hw/msix.c |5 ++--- >> 1 files changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/hw/msix.c b/hw/msix.c >> index 800fc32..04345f2 100644 >> --- a/hw/msix.c

Re: [Qemu-devel] [RFC-v2 1/6] msix: Work-around for vhost-scsi with KVM in-kernel MSI injection

2012-08-13 Thread Blue Swirl
On Mon, Aug 13, 2012 at 8:35 AM, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > This is required to get past the following assert with: > > commit 1523ed9e1d46b0b54540049d491475ccac7e6421 > Author: Jan Kiszka > Date: Thu May 17 10:32:39 2012 -0300 > > virtio/vhost: Add support

Re: [Qemu-devel] [RFC-v2 3/6] vhost-scsi: add -vhost-scsi host device for use with tcm-vhost

2012-08-13 Thread Blue Swirl
On Mon, Aug 13, 2012 at 8:35 AM, Nicholas A. Bellinger wrote: > From: Stefan Hajnoczi > > This patch adds a new type of host device that drives the vhost_scsi > device. The syntax to add vhost-scsi is: > > qemu -vhost-scsi id=vhost-scsi0,wwpn=...,tpgt=123 > > The virtio-scsi emulated device wi

Re: [Qemu-devel] [PATCH 1/2] virtio-block: support auto-sensing of block sizes

2012-08-13 Thread Blue Swirl
On Mon, Aug 13, 2012 at 8:40 AM, Jens Freimann wrote: > From: Einar Lueck > > Virtio-blk does not impose fixed block sizes for access to > backing devices. This patch introduces support for auto > lookup of the block sizes of the backing block device. This > automatic lookup needs to be enabled e

Re: [Qemu-devel] [qemu-devel] [PATCH V2 0/3] [RFC] libqblock draft code v2

2012-08-13 Thread Blue Swirl
On Mon, Aug 13, 2012 at 11:27 AM, Wenchao Xia wrote: > 于 2012-8-11 20:18, Blue Swirl 写道: > >> On Fri, Aug 10, 2012 at 8:04 AM, Wenchao Xia >> wrote: >>> >>> Thanks for your review, sorry I have forgot some fixing you >>> mentioned before, will cor

Re: [Qemu-devel] Funny -m arguments can crash

2012-08-13 Thread Blue Swirl
On Mon, Aug 13, 2012 at 2:10 PM, Gleb Natapov wrote: > On Mon, Aug 13, 2012 at 05:04:30PM +0300, Avi Kivity wrote: >> On 08/13/2012 05:02 PM, Gleb Natapov wrote: >> >> >> IMO we need to fix CMOS reporting. >> >> >> >> (technically we shouldn't touch CMOS NVRAM at all; seabios should >> >> discover

Re: [Qemu-devel] [PATCH 0/3] VFIO-based PCI device assignment for QEMU 1.2

2012-08-13 Thread Blue Swirl
oifd support I've proposed >>> > for KVM enable an accelerated patch for this through KVM. I'd >>> > like to get this base driver in first and enable the remaining >>> > support in-tree. >>> > >>> > I've split this vers

Re: [Qemu-devel] [qemu-devel] [PATCH V2 0/3] [RFC] libqblock draft code v2

2012-08-14 Thread Blue Swirl
On Tue, Aug 14, 2012 at 8:52 AM, Wenchao Xia wrote: > 于 2012-8-14 4:00, Blue Swirl 写道: > >> On Mon, Aug 13, 2012 at 11:27 AM, Wenchao Xia >> wrote: >>> >>> 于 2012-8-11 20:18, Blue Swirl 写道: >>> >>>> On Fri, Aug 10, 2012 at 8:04 AM, Wencha

Re: [Qemu-devel] [PATCH 03/10] linux-user: Move target_to_host_errno_table[] setup out of ioctl loop

2012-08-14 Thread Blue Swirl
On Tue, Aug 14, 2012 at 9:40 AM, Peter Maydell wrote: > The code to initialise the target_to_host_errno_table[] array was > accidentally inside the loop through checking and initialising all > the supported ioctls. This was harmless but meant that we reinitialised the > array several hundred times

Re: [Qemu-devel] [PATCH 2/2] pc: Fix RTC CMOS info on RAM for ram_size < 1MiB

2012-08-14 Thread Blue Swirl
On Tue, Aug 14, 2012 at 11:58 AM, Markus Armbruster wrote: > pc_cmos_init() always claims 640KiB base memory, and ram_size - 1MiB > extended memory. The latter can underflow to "lots of extended > memory". Fix both, and clean up some. > > Note: SeaBIOS currently requires 1MiB of RAM, and doesn't

Re: [Qemu-devel] Qemu memory operations

2012-08-14 Thread Blue Swirl
On Tue, Aug 14, 2012 at 11:58 AM, Prathmesh Kallurkar wrote: > Sorry friends for the misleading instructions in the previous mail. > > cmp ecx, [r12+0x4] > mov r10b, [r13+0x0] > mov byte [rax+0xf], 0x0 > mov byte [rax+rdx], 0x0 > > It seems all the above instructions are getting covered with t

Re: [Qemu-devel] [RFC V3 0/9] Quorum disk image corruption resiliency

2012-08-14 Thread Blue Swirl
fix typos > squash two first commits > > afärber: Modify the Makefile on first commit > > bcanet: move function prototype of quorum.c one patch down > > in v3: > > Blue Swirl: change char * to uint8_t * in QuorumSingleAIOCB > > Eric Blake: Add escaping of the :

Re: [Qemu-devel] [RFC V3 7/9] quorum: Add quorum_co_flush().

2012-08-14 Thread Blue Swirl
On Tue, Aug 14, 2012 at 2:14 PM, Benoît Canet wrote: > Signed-off-by: Benoit Canet > --- > block/quorum.c | 16 > 1 file changed, 16 insertions(+) > > diff --git a/block/quorum.c b/block/quorum.c > index 0a6647f..86962b4 100644 > --- a/block/quorum.c > +++ b/block/quorum.c > @

Re: [Qemu-devel] [PATCH 03/10] linux-user: Move target_to_host_errno_table[] setup out of ioctl loop

2012-08-14 Thread Blue Swirl
On Tue, Aug 14, 2012 at 6:38 PM, Peter Maydell wrote: > On 14 August 2012 19:27, Blue Swirl wrote: >> On Tue, Aug 14, 2012 at 9:40 AM, Peter Maydell >> wrote: >>> The code to initialise the target_to_host_errno_table[] array was >>> accidentally ins

Re: [Qemu-devel] [PULL for-1.2 00/10] linux-user queue

2012-08-14 Thread Blue Swirl
On Tue, Aug 14, 2012 at 9:40 AM, Peter Maydell wrote: > Hi. This is a collection of recent linux-user patches: > * my minor fixes for complaints about ioctl mismatches > * Jing Huang's fixes for running ping > * Meador's guest space probing patches > * and some minor fixes from Mike Frysinger

Re: [Qemu-devel] [PATCH 16/20] qidl: Add documentation

2012-08-18 Thread Blue Swirl
On Tue, Aug 14, 2012 at 10:20 PM, Peter Maydell wrote: > On 14 August 2012 23:15, Michael Roth wrote: >> On Tue, Aug 14, 2012 at 08:41:56PM +0100, Peter Maydell wrote: >>> On 14 August 2012 17:27, Michael Roth wrote: >>> > +In our *SerialDevice* example, the *CharDriverState* pointer reflects >

Re: [Qemu-devel] [PATCH] linux-user: fix emulation of getdents

2012-08-18 Thread Blue Swirl
On Thu, Aug 16, 2012 at 9:20 PM, Dmitry V. Levin wrote: > In case when TARGET_ABI_BITS == 32 && HOST_LONG_BITS == 64, the last > byte of the target dirent structure (aka d_type byte) was never copied > from the native dirent structure, thus breaking everything that relies > on valid d_type value,

Re: [Qemu-devel] [PATCH 2/2] ISCSI: Force scsi-generic for MMC with blank disks

2012-08-18 Thread Blue Swirl
On Fri, Aug 17, 2012 at 2:36 AM, Ronnie Sahlberg wrote: > There is no bdrv_* API for the commands for burning a blank MMC disk > so when iSCSI LUNs are specified and the LUN is a MMC device with > 0 available blocks. This is a blank disk so force scsi generic. > > This allows the guest to talk dir

Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-18 Thread Blue Swirl
On Fri, Aug 17, 2012 at 3:39 PM, Alon Levy wrote: > Revision bumped to 4 for new IO support, enabled for spice-server >= > 0.11.1. New io enabled iff spice-server >= 0.11.1 && spice-protocol >= > 0.12.0. > > On migration reissue spice_qxl_monitors_config_async. > > RHBZ: 770842 > > Signed-off-by:

Re: [Qemu-devel] Qemu phone modem emulation

2012-08-18 Thread Blue Swirl
On Fri, Aug 17, 2012 at 7:26 PM, Eric Koldeweij wrote: > Hello all, > > I am currently working on a serial telephone modem emulation implementation > for Qemu. My question is if it would be a good idea to offer it for > inclusion in the qemu main trunk when it's ready. These are the requirements >

Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-18 Thread Blue Swirl
On Sat, Aug 18, 2012 at 4:16 PM, Alon Levy wrote: > On Sat, Aug 18, 2012 at 02:31:32PM +0000, Blue Swirl wrote: >> On Fri, Aug 17, 2012 at 3:39 PM, Alon Levy wrote: >> > Revision bumped to 4 for new IO support, enabled for spice-server >= >> > 0.11.1. New io enab

Re: [Qemu-devel] [PATCH v2 0/2] two little build fixes

2012-08-18 Thread Blue Swirl
On Mon, Aug 13, 2012 at 11:05 AM, Gerd Hoffmann wrote: > Hi, > > Patch #1 uses g_strdup_printf now, #2 is unchanged. Thanks, applied both. > > cheers, > Gerd > > Gerd Hoffmann (2): > Avoid asprintf() which is not available on mingw > scsi: fix warning > > hw/msix.c |8 ++-- >

Re: [Qemu-devel] [PATCH v3 0/2] Fix two bugs related to ram_size

2012-08-18 Thread Blue Swirl
On Wed, Aug 15, 2012 at 11:12 AM, Markus Armbruster wrote: > There are more, but let's start with these two. Thanks, applied both. > > v1 -> v3: > * Use QEMU_ALIGN_UP (Avi) > * Cover size overflow > * Coding style (Blue) > > Markus Armbruster (2): > vl: Round argument of -m up to multiple of 8

[Qemu-devel] [PATCH] monitor: avoid declaring unused variables

2012-08-18 Thread Blue Swirl
itor.c:2574: warning: unused variable 'mon_fdset_fd' /src/qemu/monitor.c:2573: warning: unused variable 'mon_fdset' Signed-off-by: Blue Swirl --- monitor.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/monitor.c b/monitor.c index ce42466..480f58

Re: [Qemu-devel] [PATCH v2] linux-user: fix emulation of getdents

2012-08-19 Thread Blue Swirl
n valid d_type value, e.g. glob(3). > > Signed-off-by: Dmitry V. Levin Acked-by: Blue Swirl > --- > linux-user/syscall.c | 8 > linux-user/syscall_defs.h | 3 ++- > 2 files changed, 6 insertions(+), 5 deletions(-) > > diff --git a/linux-user/syscall.c b/l

Re: [Qemu-devel] [PATCH v2] pl190: fix read of VECTADDR

2012-08-19 Thread Blue Swirl
On Sun, Aug 19, 2012 at 10:59 AM, Brendan Fennell wrote: > > Signed-off-by: Brendan Fennell > --- > hw/pl190.c |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/hw/pl190.c b/hw/pl190.c > index cb50afb..eddb531 100644 > --- a/hw/pl190.c > +++ b/hw/pl190.c > @@ -120,7

Re: [Qemu-devel] memory: could we add extra input param for memory_region_init_io()?

2012-08-19 Thread Blue Swirl
On Sun, Aug 19, 2012 at 12:03 PM, Peter Maydell wrote: > On 19 August 2012 12:23, Peter Maydell wrote: >> Ideally, yes, but qemu is full of devices that haven't yet made the leap >> to QOM. >> >> omap1 is particularly tricky because I don't actually have any test images >> for it, so refactoring

Re: [Qemu-devel] [PATCH 1/5] move qemu_irq typedef out of cpu-common.h

2012-08-20 Thread Blue Swirl
On Mon, Aug 20, 2012 at 11:13 AM, Igor Mammedov wrote: > On Mon, 20 Aug 2012 06:41:04 +0200 > Stefan Weil wrote: > >> Am 20.08.2012 01:39, schrieb Igor Mammedov: >> > it's necessary for making CPU child of DEVICE without >> > causing circular header deps. >> > >> > Signed-off-by: Igor Mammedov >

Re: [Qemu-devel] [RFC V4 3/9] quorum: Add quorum_open() and quorum_close().

2012-08-20 Thread Blue Swirl
On Mon, Aug 20, 2012 at 11:47 AM, Benoît Canet wrote: > Valid quorum resources look like: > quorum:threshold/total:path/to/image_1: ... :path/to/image_total > > '\' can escape the ':' character. > > Signed-off-by: Benoit Canet > --- > block/quorum.c | 110 >

Re: [Qemu-devel] [PATCH v9 5/5] (temp) FORTIFY_SOURCES hack

2012-08-20 Thread Blue Swirl
On Mon, Aug 20, 2012 at 1:26 PM, Alon Levy wrote: > --- > .gitmodules| 3 +++ > compiler.h | 7 +++ > spice-protocol | 1 + > 3 files changed, 11 insertions(+) > create mode 16 spice-protocol > > diff --git a/.gitmodules b/.gitmodules > index eca876f..ba6844b 100644 > --- a/.gitm

Re: [Qemu-devel] [PATCH v9 3/5] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-20 Thread Blue Swirl
On Mon, Aug 20, 2012 at 1:26 PM, Alon Levy wrote: > Revision bumped to 4 for new IO support, enabled for spice-server >= > 0.11.1. New io enabled iff revision is 4. Revision can be set to 4, and > defaults to 4, iff spice-server >= 0.11.1 && spice-protocol >= > 0.12.0. > > This io calls the corres

Re: [Qemu-devel] [PATCH v2] configure: properly check if -lrt and -lm is needed

2012-08-20 Thread Blue Swirl
On Mon, Aug 20, 2012 at 12:43 PM, Peter Maydell wrote: > On 16 August 2012 14:22, Natanael Copa wrote: >> Fixes build against uClibc. >> >> uClibc provides 2 versions of clock_gettime(), one with realtime >> support and one without (this is so you can avoid linking in -lrt >> unless actually need

Re: [Qemu-devel] [PATCH] monitor: avoid declaring unused variables

2012-08-20 Thread Blue Swirl
On Mon, Aug 20, 2012 at 3:08 PM, Luiz Capitulino wrote: > On Sat, 18 Aug 2012 20:14:54 + > Blue Swirl wrote: > >> Some variables are only used on !win32, declare >> them only when used. >> >> This avoids a warning in mingw32 build: >> CCi386-softm

Re: [Qemu-devel] [PATCH v2] configure: properly check if -lrt and -lm is needed

2012-08-21 Thread Blue Swirl
On Tue, Aug 21, 2012 at 6:10 AM, Natanael Copa wrote: > On Mon, 20 Aug 2012 19:53:22 + > Blue Swirl wrote: > >> >> - Do not remove the explicit add of -lm unless Haiku. This was due >> >>to >> >> http://www.mail-archive.com/qemu-devel@non

Re: [Qemu-devel] Dump guest page table inside QEMU makes system hang

2012-08-21 Thread Blue Swirl
On Tue, Aug 21, 2012 at 7:21 AM, 陳韋任 (Wei-Ren Chen) wrote: > Hi all, > > I want to dump guest page table when guest writes to cr3, > the code snipt below, > > --- > uint32_t pgd[1024][1024]; // guest page table > static void dump_guest_pgtable(target_ulong cr3) > { > int i, j; > uint32_t

Re: [Qemu-devel] [PATCH 1/2 v1] blkdrv: Add queue limits parameters for sg block drive

2012-08-21 Thread Blue Swirl
On Tue, Aug 21, 2012 at 8:23 AM, Cong Meng wrote: > This patch adds some queue limit parameters into block drive. And inits them > for sg block drive. Some interfaces are also added for accessing them. > > Signed-off-by: Cong Meng > --- > block/raw-posix.c | 58 > +

Re: [Qemu-devel] [RFC 5/8] split qdev into a core and code used only by qemu-system-*

2012-08-21 Thread Blue Swirl
On Tue, Aug 21, 2012 at 3:42 PM, Eduardo Habkost wrote: > This also makes it visible what are the parts of qdev that we may want > to split more cleanly (as they are using #ifdefs, now). Nice. > > There are basically two parts that are specific to qemu-system-*, but > are still inside qdev.c (bu

Re: [Qemu-devel] [PATCH v8 5/6] introduce a new qom device to deal with panicked event

2012-08-25 Thread Blue Swirl
On Wed, Aug 22, 2012 at 7:30 AM, Wen Congyang wrote: > At 08/09/2012 03:01 AM, Blue Swirl Wrote: >> On Wed, Aug 8, 2012 at 2:47 AM, Wen Congyang wrote: >>> If the target is x86/x86_64, the guest's kernel will write 0x01 to the >>> port KVM_PV_EVENT_PORT when it is

Re: [Qemu-devel] [Qemu-ppc] [PATCH v9 1/1] Add USB option in machine options

2012-08-25 Thread Blue Swirl
On Wed, Aug 22, 2012 at 10:31 AM, Li Zhang wrote: > When -usb option is used, global varible usb_enabled is set. > And all the plafrom will create one USB controller according > to this variable. In fact, global varibles make code hard > to read. > > So this patch is to remove global variable usb_

Re: [Qemu-devel] [PATCH V5 2/2] qemu-img: Add json output option to the info command.

2012-08-25 Thread Blue Swirl
On Thu, Aug 23, 2012 at 12:42 PM, Benoît Canet wrote: > This option --output=[human|json] make qemu-img info output on > human or JSON representation at the choice of the user. > > example: > { > "snapshots": [ > { > "vm-clock-nsec": 637102488, > "name": "vm-201

Re: [Qemu-devel] [PATCH RFC 1/2] Parse the cpu entitlement from the qemu commandline.

2012-08-25 Thread Blue Swirl
On Thu, Aug 23, 2012 at 11:15 PM, Michael Wolf wrote: > The cpu entitlement value will be passed to qemu as part of the cpu > parameters. > Add cpu_parse to read this value from the commandline. > > Signed-off-by: Michael Wolf > --- > qemu-options.hx |7 +-- > vl.c| 23 +++

Re: [Qemu-devel] Get host virtual address corresponding to guest physical address?

2012-08-25 Thread Blue Swirl
On Fri, Aug 24, 2012 at 3:14 AM, 陳韋任 (Wei-Ren Chen) wrote: > Hi all, > > I would like to know if there is a function in QEMU which converts > a guest physical address into corresponding host virtual address. I > guess cpu_physical_memory_map (exec.c) can do the job, but I have a > few questions.

Re: [Qemu-devel] [PATCH 03/10] qom: export object_property_is_child, object_property_is_link

2012-08-25 Thread Blue Swirl
On Fri, Aug 24, 2012 at 9:49 AM, Liu Ping Fan wrote: > From: Liu Ping Fan > > qdev will use them to judge how to remove the bus and device's > reference. So export them in object.h > > Signed-off-by: Liu Ping Fan > --- > include/qemu/object.h |3 +++ > qom/object.c |4 ++-- > 2

Re: [Qemu-devel] [PATCH 2/5] softmmu templates: optionally pass CPUState to memory access functions

2012-08-25 Thread Blue Swirl
On Fri, Aug 24, 2012 at 3:05 PM, Aurelien Jarno wrote: > On Sun, Mar 11, 2012 at 10:24:03PM +0000, Blue Swirl wrote: >> Optionally, make memory access helpers take a parameter for CPUState >> instead of relying on global env. >> >> On most targets, perform simple mov

Re: [Qemu-devel] [PATCH 2/5] softmmu templates: optionally pass CPUState to memory access functions

2012-08-25 Thread Blue Swirl
On Fri, Aug 24, 2012 at 6:53 PM, Aurelien Jarno wrote: > On Fri, Aug 24, 2012 at 08:43:32PM +0200, Andreas Färber wrote: >> Am 24.08.2012 20:05, schrieb Aurelien Jarno: >> > On Fri, Aug 24, 2012 at 05:52:29PM +0200, Andreas Färber wrote: >> >> Not opposed to changing the argument order, but given

  1   2   3   4   5   6   7   8   9   10   >