Sorry for the noise, is there any more comment for this patch?
Without this patch, ignore shared capabilities can not be used on arm64
B.R.
Catherine
On Tue, 16 Apr 2019 at 10:51, Peter Xu wrote:
> On Mon, Apr 08, 2019 at 04:42:13AM -0400, Catherine Ho wrote:
> > Commit 182
Hi Paolo and Eduardo
I digged into the put msr assertion bug a little more, and seems I
found the root cause.
Please have a review.
Best regards.
Catherine
On Fri, 6 Dec 2019 at 18:25, Catherine Ho wrote:
>
> Commit 1389309c811b ("KVM: nVMX: expose VMX capabilities for nested
>
arget/i386/kvm.c:2932: kvm_put_msrs: Assertion `ret ==
cpu->kvm_msr_buf->nmsrs' failed.
This fixes it by skipping kvm_msr_entry_add when kvm_vmx_basic is 0
Cc: Paolo Bonzini
Signed-off-by: Catherine Ho
---
target/i386/kvm.c |7 ++-
1 files changed, 6 insertions(+), 1 delet
i386/kvm.c:2932: kvm_put_msrs: Assertion `ret ==
cpu->kvm_msr_buf->nmsrs' failed.
This fixes it by relaxing the condition.
Cc: Paolo Bonzini
Signed-off-by: Catherine Ho
---
target/i386/kvm.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/target/i386/kvm.c b/targe
Hi Paolo
[sorry to resend it, seems to reply it incorrectly]
On Wed, 4 Dec 2019 at 19:23, Paolo Bonzini wrote:
> On 04/12/19 09:50, Catherine Ho wrote:
> > Commit 20a78b02d315 ("target/i386: add VMX features") unconditionally
> > add vmx msr entry although older host k
Hi Paolo
On Wed, 4 Dec 2019 at 21:53, Paolo Bonzini wrote:
>
> On 04/12/19 14:33, Catherine Ho wrote:
> > Hi Paolo
> > [sorry to resend it, seems to reply it incorrectly]
> >
> > On Wed, 4 Dec 2019 at 19:23, Paolo Bonzini > <mailto:pbonz...@redhat.com>
Hi Paolo
Ping, is any other comment I hadn't addressed?
Cheers
Catherine
On Thu, 6 Jun 2019 at 02:31, Dr. David Alan Gilbert
wrote:
> Paolo, can you take this one please.
>
> * Catherine Ho (catherine.h...@gmail.com) wrote:
> > Commit 18269069c310 ("migration
cache=none means to bypass host cache. So we can't remove O_DIRECT flag in
unconditionally in update_open_flags();
Signed-off-by: Catherine Ho
---
tools/virtiofsd/passthrough_ll.c | 16 ++--
1 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/tools/virt
cache=none means to bypass host cache. So we can't remove O_DIRECT flag in
unconditionally in update_open_flags();
Signed-off-by: Catherine Ho
---
v2: Fix to keep flags unchanged if cache=none, otherwise changed the file
without O_DIRECT incorrectly.
tools/virtiofsd/passthrough_ll.c |
Ping :)
---
B.R.
Catherine
On Sat, 11 Apr 2020 at 16:41, Catherine Ho wrote:
>
> cache=none means to bypass host cache. So we can't remove O_DIRECT flag in
> unconditionally in update_open_flags();
>
> Signed-off-by: Catherine Ho
> ---
> v2: Fix to keep flags unchange
for supporting 2nd time, 3rd time... incoming restoring?
B.R.
Catherine
On Wed, 27 Mar 2019 at 08:45, Catherine Ho wrote:
> Hi all, thanks for the comments, I am digging into another potential
> error in the
> ignore-shared live migration. After that, I will send out the v2 asap
> B.R.
&
On Tue, 2 Apr 2019 at 15:47, Catherine Ho wrote:
> Hi Peter Maydell
>
> On Tue, 2 Apr 2019 at 11:05, Peter Maydell
> wrote:
>
>> On Tue, 2 Apr 2019 at 09:57, Catherine Ho
>> wrote:
>> > The root cause is the used idx is moved forward after 1st time
&
Hi Peter Maydell
On Tue, 2 Apr 2019 at 11:05, Peter Maydell wrote:
> On Tue, 2 Apr 2019 at 09:57, Catherine Ho
> wrote:
> > The root cause is the used idx is moved forward after 1st time incoming,
> and in 2nd time incoming,
> > the last_avail_idx will be incorrectly re
On Tue, 2 Apr 2019 at 15:58, Peter Xu wrote:
> On Tue, Apr 02, 2019 at 03:47:16PM +0800, Catherine Ho wrote:
> > Hi Peter Maydell
> >
> > On Tue, 2 Apr 2019 at 11:05, Peter Maydell
> wrote:
> >
> > > On Tue, 2 Apr 2019 at 09:57, Catherine Ho
> > &g
On Tue, 2 Apr 2019 at 20:37, Peter Xu wrote:
> On Tue, Apr 02, 2019 at 05:06:15PM +0800, Catherine Ho wrote:
> > On Tue, 2 Apr 2019 at 15:58, Peter Xu wrote:
> >
> > > On Tue, Apr 02, 2019 at 03:47:16PM +0800, Catherine Ho wrote:
> > > > Hi Peter Maydell
>
On Tue, 2 Apr 2019 at 22:17, Catherine Ho wrote:
>
>
> On Tue, 2 Apr 2019 at 20:37, Peter Xu wrote:
>
>> On Tue, Apr 02, 2019 at 05:06:15PM +0800, Catherine Ho wrote:
>> > On Tue, 2 Apr 2019 at 15:58, Peter Xu wrote:
>> >
>> > > On Tue, Apr
has been stored in memory backend file.
Fixes: commit 18269069c310 ("migration: Introduce ignore-shared capability")
Signed-off-by: Catherine Ho
Suggested-by: Yury Kotov
---
hw/core/loader.c | 15 +++
include/exec/cpu-common.h | 1 +
migration/ram.c | 2 +-
3
Hi Peter Xu
On Wed, 3 Apr 2019 at 10:25, Peter Xu wrote:
> On Tue, Apr 02, 2019 at 11:30:01AM -0400, Catherine Ho wrote:
> > Commit 18269069c310 ("migration: Introduce ignore-shared capability")
> > addes ignore-shared capability to bypass the shared ramblock (e,g,
&
Hi Peter Xu
On Thu, 4 Apr 2019 at 12:25, Peter Xu wrote:
> On Wed, Apr 03, 2019 at 11:21:47PM +0800, Catherine Ho wrote:
> > Hi Peter Xu
> >
> > On Wed, 3 Apr 2019 at 10:25, Peter Xu wrote:
> >
> > > On Tue, Apr 02, 2019 at 11:30:01AM -0400, Catherine H
Hi Peter Xu
On Thu, 4 Apr 2019 at 12:25, Peter Xu wrote:
> On Wed, Apr 03, 2019 at 11:21:47PM +0800, Catherine Ho wrote:
> > Hi Peter Xu
> >
> > On Wed, 3 Apr 2019 at 10:25, Peter Xu wrote:
> >
> > > On Tue, Apr 02, 2019 at 11:30:01AM -0400, Catherine H
ity")
Suggested-by: Yury Kotov
Suggested-by: Peter Xu
Signed-off-by: Catherine Ho
---
hw/core/loader.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/hw/core/loader.c b/hw/core/loader.c
index fe5cb24122..946bb8ff00 100644
--- a/hw/core/loader.c
+++ b/hw/core/loader.c
@@ -1087,6 +10
he 2nd time
incoming.
Thus it gives a warning and the users can run the qemu if they really
want to do it.
Signed-off-by: Catherine Ho
---
backends/hostmem-file.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/backends/hostmem-file.c b/backends/hostmem-file.c
index 37ac6445d
Hi Peter Xu
On Mon, 8 Apr 2019 at 11:25, Peter Xu wrote:
> On Sun, Apr 07, 2019 at 10:19:05PM -0400, Catherine Ho wrote:
> > Currently it is not forbidden to use "-object
> memory-backend-file,share=on"
> > and together with "-incoming". But after incoming
ity")
Suggested-by: Yury Kotov
Suggested-by: Peter Xu
Signed-off-by: Catherine Ho
---
hw/core/loader.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/hw/core/loader.c b/hw/core/loader.c
index fe5cb24122..040109464b 100644
--- a/hw/core/loader.c
+++ b/hw/core/loader.c
@@ -1087,6 +10
he 2nd time
incoming.
Thus it gives a warning and the users can run the qemu if they really
want to do it.
Signed-off-by: Catherine Ho
---
backends/hostmem-file.c | 12
1 file changed, 12 insertions(+)
diff --git a/backends/hostmem-file.c b/backends/hostmem-file.c
index 37ac6445d
Hi Igor
On Mon, 8 Apr 2019 at 18:35, Igor Mammedov wrote:
> On Sun, 7 Apr 2019 22:19:05 -0400
> Catherine Ho wrote:
>
> > Currently it is not forbidden to use "-object
> memory-backend-file,share=on"
> > and together with "-incoming". But after in
Hi Dr. David
On Wed, 10 Apr 2019 at 22:59, Dr. David Alan Gilbert
wrote:
> * Catherine Ho (catherine.h...@gmail.com) wrote:
> > Hi Igor
> >
> >
> > On Mon, 8 Apr 2019 at 18:35, Igor Mammedov wrote:
> >
> > > On Sun, 7 Apr 2019 22:19:05 -0400
> >
Hi Dr. David
On Thu, 11 Apr 2019 at 00:57, Dr. David Alan Gilbert
wrote:
> * Catherine Ho (catherine.h...@gmail.com) wrote:
> > Hi Dr. David
> >
> > On Wed, 10 Apr 2019 at 22:59, Dr. David Alan Gilbert <
> dgilb...@redhat.com>
> > wrote:
> >
> > &
Ping, thanks
B.R.
Catherine
On Mon, 8 Apr 2019 at 16:43, Catherine Ho wrote:
> Commit 18269069c310 ("migration: Introduce ignore-shared capability")
> addes ignore-shared capability to bypass the shared ramblock (e,g,
> membackend + numa node). It does good to live migrat
Without this patch, gcc might mess up the Input/Output registers and
cause unpredictable error.
Fixes: 1ec182c33379 ("target/arm: Convert to HAVE_CMPXCHG128")
Signed-off-by: Catherine Ho
---
Resend: sent previous patch before subscribing maillist
include/qemu/atomic128.h | 2
Without this patch, gcc might up the Input/Output registers and
cause unpredictable error.
Fixes: 1ec182c33379 ("target/arm: Convert to HAVE_CMPXCHG128")
Signed-off-by: Catherine Ho
---
include/qemu/atomic128.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/in
ive_high, env->exclusive_val);
newv = int128_make128(new_hi, new_lo);
Fixes: 1ec182c33379 ("target/arm: Convert to HAVE_CMPXCHG128")
Signed-off-by: Catherine Ho
---
I didn't see any obvious real error case here, so set it as RFC
target/arm/helper-a64.c | 4 ++--
1 file change
oming_migration), this logic should be reserved.
Fixes: commit 18269069c310 ("migration: Introduce ignore-shared capability")
Signed-off-by: Catherine Ho
Suggested-by: Yury Kotov
---
exec.c| 4
include/exec/cpu-common.h | 1 +
include/qemu/option.h | 1 +
migr
Thanks, Peter
See my comments below, please
On Thu, 21 Mar 2019 at 14:10, Peter Xu wrote:
>
> On Wed, Mar 20, 2019 at 04:05:58PM +0800, chenxi He wrote:
> > On Wed, 20 Mar 2019 at 13:07, Peter Xu wrote:
> > >
> > > On Tue, Mar 19, 2019 at 11:49:22AM -0400, Cath
Hi all, thanks for the comments, I am digging into another potential
error in the
ignore-shared live migration. After that, I will send out the v2 asap
B.R.
Catherine
On Mon, 25 Mar 2019 at 11:39, Peter Xu wrote:
>
> On Fri, Mar 22, 2019 at 10:12:11AM +, Dr. David Alan Gilbert wrote:
>
> [..
35 matches
Mail list logo
