On 01/28/2016 12:05 AM, Stefan Hajnoczi wrote:
On Wed, Jan 13, 2016 at 05:18:27PM +0800, Changlong Xie wrote:
diff --git a/blockjob.c b/blockjob.c
index 80adb9d..0c8edfe 100644
--- a/blockjob.c
+++ b/blockjob.c
@@ -533,3 +533,14 @@ void block_job_txn_add_job(BlockJobTxn *txn, BlockJob *job
On 01/27/2016 10:04 PM, Stefan Hajnoczi wrote:
On Wed, Jan 13, 2016 at 05:18:28PM +0800, Changlong Xie wrote:
From: Wen Congyang
When opening BDS, we need to create backup jobs for
image-fleecing.
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off
On 01/28/2016 11:15 PM, Stefan Hajnoczi wrote:
On Thu, Jan 28, 2016 at 09:13:24AM +0800, Wen Congyang wrote:
On 01/27/2016 10:46 PM, Stefan Hajnoczi wrote:
On Wed, Jan 13, 2016 at 05:18:31PM +0800, Changlong Xie wrote:
+static void secondary_do_checkpoint(BDRVReplicationState *s, Error **errp
On 02/02/2016 11:20 PM, Eric Blake wrote:
On 01/13/2016 02:18 AM, Changlong Xie wrote:
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
docs/block-replication.txt | 229
t;: [{"driver": "raw", "file": {"driver": "file", "filename": "/root/colo/bugzilla.raw"}}, {"driver": "replication", "mode": "primary", "file": {"port":
"8889&q
On 02/04/2016 05:07 PM, Dr. David Alan Gilbert wrote:
* Changlong Xie (xiecl.f...@cn.fujitsu.com) wrote:
On 02/01/2016 09:18 AM, Wen Congyang wrote:
On 01/29/2016 06:47 PM, Dr. David Alan Gilbert wrote:
* Wen Congyang (we...@cn.fujitsu.com) wrote:
On 01/29/2016 06:07 PM, Dr. David Alan
Signed-off-by: Wen Congyang
Signed-off-by: Changlong Xie
---
block/quorum.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/block/quorum.c b/block/quorum.c
index a5ae4b8..0965277 100644
--- a/block/quorum.c
+++ b/block/quorum.c
@@ -295,6 +295,9 @@ static void quorum_aio_cb(void *opaque
On 02/04/2016 08:24 PM, Kevin Wolf wrote:
Am 04.02.2016 um 11:19 hat Changlong Xie geschrieben:
Signed-off-by: Wen Congyang
Signed-off-by: Changlong Xie
---
block/quorum.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/block/quorum.c b/block/quorum.c
index a5ae4b8..0965277 100644
Signed-off-by: Wen Congyang
Signed-off-by: Changlong Xie
---
block/quorum.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/block/quorum.c b/block/quorum.c
index a5ae4b8..11cc60b 100644
--- a/block/quorum.c
+++ b/block/quorum.c
@@ -286,7 +286,8 @@ static void quorum_aio_cb
From: Wen Congyang
Some programs that add a dependency on it will use
the block layer directly.
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Jeff Cody
---
block/Makefile.objs | 2
From: Wen Congyang
Auto complete mirror job in background to prevent from
blocking synchronously
Signed-off-by: Wen Congyang
Signed-off-by: Changlong Xie
---
block/mirror.c| 13 +
blockdev.c| 2 +-
include/block/block_int.h | 3 ++-
qemu-img.c
From: Wen Congyang
We need to access the parent BDS to get the root BDS.
Signed-off-by: Wen Congyang
Signed-off-by: Changlong Xie
---
block.c | 1 +
include/block/block_int.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/block.c b/block.c
index 70ab625..c18b462
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
block/Makefile.objs | 1 +
block/replication.c | 594
2 files changed, 595 insertions(+)
create mode
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: Changlong Xie
---
block.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/block.c b/block.c
index a285de5..70ab625 100644
--- a/block.c
+++ b/block.c
@@ -1279,6 +1279,24 @@ void bdrv_set_backing_hd
1. Redesign the secondary qemu(use image-fleecing)
2. Use Error objects to return error message
3. Address the comments from Max Reitz and Eric Blake
Changlong Xie (1):
Introduce new APIs to do replication operation
Wen Congyang (8):
unblock backup operations in backing file
Store parent B
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
Reviewed-by: Eric Blake
---
qapi/block-core.json | 20 ++--
1 file changed, 18 insertions(+), 2 deletions(-)
diff --git a/qapi/block-core.json b
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
block/backup.c| 15 +++
include/block/block_int.h | 2 ++
2 files changed, 17 insertions(+)
diff --git a/block/backup.c b/block
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
Makefile.objs| 1 +
qapi/block-core.json | 13
replication.c| 94
replication.h| 53
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
docs/block-replication.txt | 238 +
1 file changed, 238 insertions(+)
create mode 100644 docs/block
On 02/15/2016 08:57 AM, Hailiang Zhang wrote:
On 2016/2/5 12:18, Changlong Xie wrote:
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
Makefile.objs| 1 +
qapi/block-core.json | 13
replication.c
On 02/11/2016 02:02 AM, Max Reitz wrote:
On 25.12.2015 10:22, Changlong Xie wrote:
From: Wen Congyang
The new QMP command name is x-blockdev-change. It's just for adding/removing
quorum's child now, and doesn't support all kinds of children, all kinds of
operations, nor all bl
On 02/05/2016 11:46 PM, Eric Blake wrote:
On 02/04/2016 07:25 PM, Changlong Xie wrote:
Signed-off-by: Wen Congyang
Signed-off-by: Changlong Xie
---
block/quorum.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/block/quorum.c b/block/quorum.c
index a5ae4b8..11cc60b
Hi all
It seems no any review during the long Spring festival. Ping :)
Thanks
-Xie
On 02/05/2016 12:17 PM, Changlong Xie wrote:
Block replication is a very important feature which is used for
continuous checkpoints(for example: COLO).
You can get the detailed information about
) vote_count < max: do nothing
Signed-off-by: Wen Congyang
Signed-off-by: Changlong Xie
---
block/quorum.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/block/quorum.c b/block/quorum.c
index a5ae4b8..e431ff4 100644
--- a/block/quorum.c
+++ b/block/quo
end_request: I/O error, dev vda, sector 11159960
[xxx] Aborting journal on device vda3-8
[xxx] EXT4-fs error (device vda3): ext4_journal_start_sb:327: Detected abort
journal
[xxx] EXT4-fs (vda3): Remounting filesystem read-only
[Ref] http://lists.nongnu.org/archive/html/qemu-devel/2016-01/msg
On 02/16/2016 01:10 AM, Eric Blake wrote:
On 02/15/2016 02:52 AM, Changlong Xie wrote:
Before:
1) vote_count > max: winner = candidate, update max
2) vote_count <= max: do nothing
Current:
1) vote_count > max: winner = candidate, update max
2) vote_count = max: compare the value of wi
end_request: I/O error, dev vda, sector 11159960
[xxx] Aborting journal on device vda3-8
[xxx] EXT4-fs error (device vda3): ext4_journal_start_sb:327: Detected abort
journal
[xxx] EXT4-fs (vda3): Remounting filesystem read-only
[Ref] http://lists.nongnu.org/archive/html/qemu-devel/2016-01/msg0
vda3-8
EXT4-fs error (device vda3): ext4_journal_start_sb:327: Detected abort journal
EXT4-fs (vda3): Remounting filesystem read-only
Signed-off-by: Wen Congyang
Signed-off-by: Changlong Xie
---
block/quorum.c | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a
On 02/09/2016 01:06 AM, Alberto Garcia wrote:
On Fri 22 Jan 2016 09:02:10 PM CET, "Dr. David Alan Gilbert"
wrote:
In general, what do you do to make sure that the data in a new
Quorum child is consistent with that of the rest of the array?
Quorum can have more than one child when it starts.
ChangLog:
v9~v10:
1. Rebase to the newest codes
2. Address comments from Berto and Max, update the documents in block-core.json
and qmp-commands.hx
3. Remove redundant codes in quorum_add_child() and quorum_del_child()
v8:
1. Rebase to the newest codes
2. Address the comments from Eric Blake
v
From: Wen Congyang
In some cases, we want to take a quorum child offline, and take
another child online.
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
Reviewed-by: Eric Blake
Reviewed-by: Alberto Garcia
---
block.c
: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
blockdev.c | 54
qapi/block-core.json | 32 +++
qmp-commands.hx | 50
3 fil
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
block.c | 8 ++--
block/quorum.c| 122 +-
include/block/block.h | 4 ++
3 files
On 12/15/2015 04:22 PM, zhanghailiang wrote:
During the time of VM's running, PVM may dirty some pages, we will transfer
PVM's dirty pages to SVM and store them into SVM's RAM cache at next checkpoint
time. So, the content of SVM's RAM cache will always be some with PVM's memory
"some" => "same"
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: Changlong Xie
---
block.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/block.c b/block.c
index e90b6cf..12b5231 100644
--- a/block.c
+++ b/block.c
@@ -1275,6 +1275,24 @@ void bdrv_set_backing_hd
From: Wen Congyang
Auto complete mirror job in background to prevent from
blocking synchronously
Signed-off-by: Wen Congyang
Signed-off-by: Changlong Xie
---
block/mirror.c| 13 +
blockdev.c| 2 +-
include/block/block_int.h | 3 ++-
qemu-img.c
Block replication is a very important feature which is used for
continuous checkpoints(for example: COLO).
You can get the detailed information about block replication from here:
http://wiki.qemu.org/Features/BlockReplication
Usage:
Please refer to docs/block-replication.txt
This patch series is
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
Reviewed-by: Eric Blake
---
qapi/block-core.json | 20 ++--
1 file changed, 18 insertions(+), 2 deletions(-)
diff --git a/qapi/block-core.json b
From: Wen Congyang
When opening BDS, we need to create backup jobs for
image-fleecing.
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Jeff Cody
---
block/Makefile.objs | 2 +-
1 file
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
Reviewed-by: Jeff Cody
---
block/backup.c | 14 ++
blockjob.c | 11 +++
include/block/blockjob.h | 12
3
From: Wen Congyang
We need to access the parent BDS to get the root BDS.
Signed-off-by: Wen Congyang
Signed-off-by: Changlong Xie
---
block.c | 1 +
include/block/block_int.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/block.c b/block.c
index 12b5231..33d3427
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
docs/block-replication.txt | 229 +
1 file changed, 229 insertions(+)
create mode 100644 docs/block
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
block/Makefile.objs | 1 +
block/replication-comm.c | 66 +
block/replication.c | 590
It seems i missed someone in CC list, add them.
Thanks
-Xie
On 01/13/2016 05:18 PM, Changlong Xie wrote:
Block replication is a very important feature which is used for
continuous checkpoints(for example: COLO).
You can get the detailed information about block replication from here
On 01/20/2016 08:04 AM, Eric Blake wrote:
On 01/13/2016 02:18 AM, Changlong Xie wrote:
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
block/Makefile.objs | 1 +
block/replication-comm.c
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
block.c | 8 ++--
block/quorum.c| 122 +-
include/block/block.h | 4 ++
3 files
If quorum's child is broken, we can use mirror job to replace it.
But sometimes, the user only need to remove the broken child, and
add it later when the problem is fixed.
ChangLog:
v9:
1. Rebase to the newest codes
2. Remove redundant codes in quorum_add_child() and quorum_del_child()
3. Fix typo
From: Wen Congyang
In some cases, we want to take a quorum child offline, and take
another child online.
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
Reviewed-by: Eric Blake
Reviewed-by: Alberto Garcia
---
block.c
: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
blockdev.c | 54
qapi/block-core.json | 23 ++
qmp-commands.hx | 47 +
3 files changed, 124 inse
From: Wen Congyang
We need to access the parent BDS to get the root BDS.
Signed-off-by: Wen Congyang
Signed-off-by: Changlong Xie
---
block.c | 1 +
include/block/block_int.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/block.c b/block.c
index 1589c0d..c9c913e
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
Reviewed-by: Jeff Cody
---
block/backup.c | 14 ++
blockjob.c | 11 +++
include/block/blockjob.h | 12
3
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: Changlong Xie
---
block.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/block.c b/block.c
index b9e99da..1589c0d 100644
--- a/block.c
+++ b/block.c
@@ -1275,6 +1275,24 @@ void bdrv_set_backing_hd
From: Wen Congyang
When opening BDS, we need to create backup jobs for
image-fleecing.
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Jeff Cody
---
block/Makefile.objs | 2 +-
1 file
Block replication is a very important feature which is used for
continuous checkpoints(for example: COLO).
You can get the detailed information about block replication from here:
http://wiki.qemu.org/Features/BlockReplication
Usage:
Please refer to docs/block-replication.txt
This patch series is
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
Reviewed-by: Eric Blake
---
qapi/block-core.json | 20 ++--
1 file changed, 18 insertions(+), 2 deletions(-)
diff --git a/qapi/block-core.json b
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
Reviewed-by: Alberto Garcia
---
block/quorum.c | 78 ++
1 file changed, 78 insertions(+)
diff --git a
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
Cc: Luiz Capitulino
Cc: Michael Roth
Reviewed-by: Paolo Bonzini
---
block.c | 43 +++
include/block
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
docs/block-replication.txt | 227 +
1 file changed, 227 insertions(+)
create mode 100644 docs/block
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
block/Makefile.objs | 1 +
block/replication.c | 545
2 files changed, 546 insertions(+)
create mode
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
block.c | 83 +++
include/block/block.h | 4 +++
2 files changed, 87 insertions(+)
diff --git a
On 02/20/2016 10:28 PM, Max Reitz wrote:
On 19.02.2016 12:24, Alberto Garcia wrote:
On Fri 19 Feb 2016 09:26:53 AM CET, Wen Congyang wrote:
If quorum has two children(A, B). A do flush sucessfully, but B
flush failed. We MUST choice A as winner rather than just pick
anyone of them. Otherwise
: I/O error, dev vda, sector 11159960
Aborting journal on device vda3-8
EXT4-fs error (device vda3): ext4_journal_start_sb:327: Detected abort journal
EXT4-fs (vda3): Remounting filesystem read-only
Signed-off-by: Wen Congyang
Signed-off-by: Changlong Xie
---
block/quorum.c | 17 -
1
ChangLog:
v3:
*Note* that, the codes logic is different from what we talked in v2. I just
keep flush interface the same logic as quorum read/write, and think it's
reasoned.
[Ref] http://lists.nongnu.org/archive/html/qemu-devel/2016-01/msg05342.htm
Changlong Xie (1):
quorum: modify vote
On 02/22/2016 05:02 PM, Dr. David Alan Gilbert wrote:
* Changlong Xie (xiecl.f...@cn.fujitsu.com) wrote:
On 02/20/2016 10:28 PM, Max Reitz wrote:
On 19.02.2016 12:24, Alberto Garcia wrote:
On Fri 19 Feb 2016 09:26:53 AM CET, Wen Congyang wrote:
If quorum has two children(A, B). A do flush
On 02/22/2016 06:34 PM, Kevin Wolf wrote:
Am 22.02.2016 um 10:02 hat Dr. David Alan Gilbert geschrieben:
* Changlong Xie (xiecl.f...@cn.fujitsu.com) wrote:
On 02/20/2016 10:28 PM, Max Reitz wrote:
On 19.02.2016 12:24, Alberto Garcia wrote:
On Fri 19 Feb 2016 09:26:53 AM CET, Wen Congyang
On 02/22/2016 10:33 PM, Alberto Garcia wrote:
On Mon 22 Feb 2016 10:50:37 AM CET, Changlong Xie wrote:
-winner = quorum_get_vote_winner(&error_votes);
-result = winner->value.l;
-
+if (success_count >= s->threshold)
+result = 0;
+else {
+
devel/2016-01/msg05342.htm
Changlong Xie (2):
qmp event: Add QUORUM_FLUSH_ERROR
quorum: modify vote rules for flush operation
block/quorum.c | 24 +++-
docs/qmp-events.txt | 18 ++
qapi/event.json | 16
3 files changed, 53 inser
Signed-off-by: Wen Congyang
Signed-off-by: Changlong Xie
---
block/quorum.c | 5 +
docs/qmp-events.txt | 18 ++
qapi/event.json | 16
3 files changed, 39 insertions(+)
diff --git a/block/quorum.c b/block/quorum.c
index f78d4cb..d3c3958 100644
: I/O error, dev vda, sector 11159960
Aborting journal on device vda3-8
EXT4-fs error (device vda3): ext4_journal_start_sb:327: Detected abort journal
EXT4-fs (vda3): Remounting filesystem read-only
Signed-off-by: Wen Congyang
Signed-off-by: Changlong Xie
---
block/quorum.c | 19 ++---
cc: Markus Armbruster
On 02/23/2016 05:01 PM, Changlong Xie wrote:
Signed-off-by: Wen Congyang
Signed-off-by: Changlong Xie
---
block/quorum.c | 5 +
docs/qmp-events.txt | 18 ++
qapi/event.json | 16
3 files changed, 39 insertions(+)
diff
Ping again ...
Thanks
-Xie
On 02/05/2016 12:17 PM, Changlong Xie wrote:
Block replication is a very important feature which is used for
continuous checkpoints(for example: COLO).
You can get the detailed information about block replication from here:
http://wiki.qemu.org/Features
On 02/23/2016 10:05 PM, Alberto Garcia wrote:
On Tue 23 Feb 2016 02:45:49 PM CET, Eric Blake wrote:
Commit message should say why we need a third event, rather than
reusing either of the other two (my guess: because you don't have a
location, and don't want to modify the existing two to report
* that, the codes logic is different from what we talked in v2.
I just keep flush interface the same logic as quorum read/write, and think
it's reasoned.
[Ref] http://lists.nongnu.org/archive/html/qemu-devel/2016-01/msg05342.htm
Changlong Xie (3):
docs: fix invalid node name in qmp event
: I/O error, dev vda, sector 11159960
Aborting journal on device vda3-8
EXT4-fs error (device vda3): ext4_journal_start_sb:327: Detected abort journal
EXT4-fs (vda3): Remounting filesystem read-only
Cc: Dr. David Alan Gilbert
Cc: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: Changlon
Introduce QuorumOpType, and make QUORUM_REPORT_BAD compatible
with it.
Cc: Dr. David Alan Gilbert
Cc: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: Changlong Xie
---
block/quorum.c | 28 +++-
docs/qmp-events.txt | 8
qapi/block.json | 16
Cc: Dr. David Alan Gilbert
Cc: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: Changlong Xie
---
docs/qmp-events.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/qmp-events.txt b/docs/qmp-events.txt
index 52eb7e2..f96e120 100644
--- a/docs/qmp-events.txt
On 02/25/2016 09:12 AM, Eric Blake wrote:
On 02/24/2016 05:50 PM, Wen Congyang wrote:
+- "type": Quorum operation type (json-string, optional)
I don't think 'type' needs to be optional, after all. Just always
output it.
If we output read/write type, old libvirt will ignore the rea
On 02/24/2016 08:35 PM, Alberto Garcia wrote:
On Wed 24 Feb 2016 11:11:54 AM CET, Changlong Xie wrote:
-static void quorum_report_bad(QuorumAIOCB *acb, char *node_name, int ret)
+static void quorum_report_bad(QuorumOpType type, QuorumAIOCB *acb,
+ char *node_name
Cc: Dr. David Alan Gilbert
Cc: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: Changlong Xie
Reviewed-by: Alberto Garcia
---
docs/qmp-events.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/qmp-events.txt b/docs/qmp-events.txt
index b6e8937..afb5e20 100644
Introduce QUORUM_FLUSH_ERROR event to notify flush failure.
v3:
1. *Note* that, the codes logic is different from what we talked in v2.
I just keep flush interface the same logic as quorum read/write, and think
it's reasoned.
[Ref] http://lists.nongnu.org/archive/html/qemu-devel/2016-01/msg05342.htm
C
: I/O error, dev vda, sector 11159960
Aborting journal on device vda3-8
EXT4-fs error (device vda3): ext4_journal_start_sb:327: Detected abort journal
EXT4-fs (vda3): Remounting filesystem read-only
Cc: Dr. David Alan Gilbert
Cc: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: Changlon
Introduce QuorumOpType, and make QUORUM_REPORT_BAD compatible
with it.
Cc: Dr. David Alan Gilbert
Cc: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: Changlong Xie
---
block/quorum.c | 17 -
docs/qmp-events.txt | 11 ++-
qapi/block.json | 16
On 02/25/2016 06:57 PM, Alberto Garcia wrote:
On Thu 25 Feb 2016 06:33:08 AM CET, Changlong Xie
wrote:
+Read/Write operation:
{ "event": "QUORUM_REPORT_BAD",
- "data": { "node-name": "node0", "sector-num": 345435, "sector
Cc: Dr. David Alan Gilbert
Cc: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: Changlong Xie
Reviewed-by: Alberto Garcia
---
docs/qmp-events.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/qmp-events.txt b/docs/qmp-events.txt
index 4e3eb9e..d6b9aea 100644
: I/O error, dev vda, sector 11159960
Aborting journal on device vda3-8
EXT4-fs error (device vda3): ext4_journal_start_sb:327: Detected abort journal
EXT4-fs (vda3): Remounting filesystem read-only
Cc: Dr. David Alan Gilbert
Cc: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: Changlon
html/qemu-devel/2016-01/msg05342.html
Changlong Xie (3):
docs: fix invalid node name in qmp event
qmp event: Refactor QUORUM_REPORT_BAD
quorum: modify vote rules for flush operation
block/quorum.c | 38 --
docs/qmp-events.txt | 11 ++-
Introduce QuorumOpType, and make QUORUM_REPORT_BAD compatible
with it.
Cc: Dr. David Alan Gilbert
Cc: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: Changlong Xie
---
block/quorum.c | 17 -
docs/qmp-events.txt | 11 ++-
qapi/block.json | 16
On 03/06/2016 01:27 AM, Max Reitz wrote:
Sorry that I wasn't so pedantic last time; or maybe I should rather be
sorry that I'm so pedantic this time.
Hi Max
Welcome all your comments : )
On 16.02.2016 10:37, Changlong Xie wrote:
From: Wen Congyang
In some cases, we want
On 03/06/2016 02:13 AM, Max Reitz wrote:
On 16.02.2016 10:37, Changlong Xie wrote:
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
block.c | 8 ++--
block/quorum.c| 122
On 03/06/2016 02:33 AM, Max Reitz wrote:
On 16.02.2016 10:37, Changlong Xie wrote:
From: Wen Congyang
The new QMP command name is x-blockdev-change. It's just for adding/removing
quorum's child now, and doesn't support all kinds of children, all kinds of
operations, nor all bl
On 03/08/2016 12:02 AM, Eric Blake wrote:
On 03/05/2016 11:13 AM, Max Reitz wrote:
+index = atoi(child->name + 9);
Optional: Assert absence of an error:
Indeed, atoi() is worthless, because it cannot do error detection.
unsigned long index;
char *endptr;
index = strtoul(child->name
On 03/08/2016 12:02 AM, Max Reitz wrote:
On 07.03.2016 17:02, Eric Blake wrote:
On 03/05/2016 11:13 AM, Max Reitz wrote:
+index = atoi(child->name + 9);
Optional: Assert absence of an error:
Indeed, atoi() is worthless, because it cannot do error detection.
unsigned long index;
char
On 03/05/2016 12:13 AM, Stefan Hajnoczi wrote:
On Fri, Feb 05, 2016 at 12:18:06PM +0800, Changlong Xie wrote:
diff --git a/replication.h b/replication.h
new file mode 100644
index 000..faea649
--- /dev/null
+++ b/replication.h
@@ -0,0 +1,53 @@
+/*
+ * Replication filter
+ *
+ * Copyright (c
On 03/05/2016 01:39 AM, Stefan Hajnoczi wrote:
On Fri, Feb 05, 2016 at 12:18:07PM +0800, Changlong Xie wrote:
+static void replication_start(ReplicationState *rs, ReplicationMode mode,
+ Error **errp)
+{
+BlockDriverState *bs = rs->opa
On 03/05/2016 01:53 AM, Stefan Hajnoczi wrote:
On Fri, Feb 05, 2016 at 12:18:07PM +0800, Changlong Xie wrote:
+static void secondary_do_checkpoint(BDRVReplicationState *s, Error **errp)
+{
+Error *local_err = NULL;
+int ret;
+
+if (!s->secondary_disk->bs->job) {
+e
On 03/05/2016 01:39 AM, Stefan Hajnoczi wrote:
On Fri, Feb 05, 2016 at 12:18:07PM +0800, Changlong Xie wrote:
+static void replication_start(ReplicationState *rs, ReplicationMode mode,
+ Error **errp)
+{
+BlockDriverState *bs = rs->opa
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
block.c | 8 ++--
block/quorum.c| 123 +-
include/block/block.h | 4 ++
3 files
ChangLog:
v10~v11:
1. Rebase to the newest codes
2. Address comment from Max
Don't use contractions in error messages,
p1: Remove R-Bs, and use "BdrvChild *child" in bdrv_del_child
p2: Fix error logic in get_new_child_index/remove_child_index, and prefect
child->name parsing
p3: Make bdrv_find_chil
From: Wen Congyang
In some cases, we want to take a quorum child offline, and take
another child online.
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
block.c | 49
: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
blockdev.c | 55
qapi/block-core.json | 32 ++
qmp-commands.hx | 54 +++
3 fil
1 - 100 of 362 matches
Mail list logo
