Re: [Qemu-devel] [PATCH 01/18] smbios: Add a function to directly add an entry

2012-08-06 Thread Corey Minyard
On 08/02/2012 04:05 PM, Anthony Liguori wrote: Corey Minyard writes: On 08/02/2012 01:32 PM, Anthony Liguori wrote: Corey Minyard writes: On 08/01/2012 09:40 PM, Anthony Liguori wrote: Corey Minyard writes: On 08/01/2012 08:15 PM, Kevin O'Connor wrote: Well, I should also probabl

Re: [Qemu-devel] First shot at adding IPMI to qemu

2012-07-10 Thread Corey Minyard
On 07/10/2012 04:35 AM, Paolo Bonzini wrote: Il 09/07/2012 21:17, miny...@acm.org ha scritto: I had asked about getting an IPMI device into qemu and received some interest, and it's useful to me, so I've done some work to add it. The following patch set has a set of patches to add an IPMI KCS de

Re: [Qemu-devel] [PATCH 4/9] Add a base IPMI interface

2012-07-10 Thread Corey Minyard
On 07/10/2012 04:17 AM, Daniel P. Berrange wrote: On Mon, Jul 09, 2012 at 02:17:04PM -0500, miny...@acm.org wrote: diff --git a/qemu-options.hx b/qemu-options.hx index 125a4da..823f6bc 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -2204,6 +2204,41 @@ Three button serial mouse. Configure

Re: [Qemu-devel] [PATCH 5/9] IPMI: Add a PC ISA type structure

2012-07-10 Thread Corey Minyard
On 07/10/2012 04:33 AM, Paolo Bonzini wrote: Here, you should add a "normal" chardev property so that people can use -chardev and -device to create the IPMI interface. The device can be created like this: -chardev ...,id=charipmi -device ipmi,interface=kcs,chardev=charipmi If the chardev i

Re: [Qemu-devel] [PATCH 00/16 v4] Add an IPMI device to qemu

2012-10-04 Thread Corey Minyard
On 09/18/2012 03:00 PM, miny...@acm.org wrote: I haven't pushed on the SEABIOS changes for IPMI, and the changes for qemu for BIOS support are quite small, anyway. So I've separated out those changes; here's the driver without BIOS table support. -corey I haven't seen any comments on this. I

Re: [Qemu-devel] Third shot at adding IPMI to qemu

2012-09-10 Thread Corey Minyard
On 09/10/2012 09:48 AM, Andreas Färber wrote: Am 19.07.2012 20:53, schrieb miny...@acm.org: Ok, everything passes through checkpatch without an error now. I have added some tests to verify basic operation of the device, and I've hacked in some documentation, though I'm not sure if it's in the p

Re: [Qemu-devel] [PATCH 4/6] qemu-char: set socket filename to disconnected when not connected

2014-09-22 Thread Corey Minyard
On 09/22/2014 03:06 AM, Paolo Bonzini wrote: > Il 22/09/2014 01:04, miny...@acm.org ha scritto: >> From: Corey Minyard >> >> This way we can tell if the socket is connected or not. It also splits >> the string conversions out into separate functions to make this more

Re: [Qemu-devel] [PATCH 4/6] qemu-char: set socket filename to disconnected when not connected

2014-09-22 Thread Corey Minyard
On 09/22/2014 08:25 AM, Paolo Bonzini wrote: > Il 22/09/2014 15:15, Corey Minyard ha scritto: >>>> Why move this from qemu_chr_finish_socket_connection to tcp_chr_connect? >>>> Perhaps move this part of the patch earlier, either just before or just >>>> afte

Re: [Qemu-devel] [PATCH 1/6] qemu-char: Make the filename size for a chardev a #define

2014-09-22 Thread Corey Minyard
On 09/22/2014 12:20 PM, Peter Maydell wrote: > On 22 September 2014 09:59, wrote: >> From: Corey Minyard >> >> Signed-off-by: Corey Minyard >> Reviewed-by: Paolo Bonzini > Wouldn't it be better to just drop the max-size restriction > by using g_strdup_p

Re: [Qemu-devel] [PATCH 5/6] qemu-char: Add reconnecting to client sockets

2014-09-22 Thread Corey Minyard
On 09/22/2014 03:24 PM, Eric Blake wrote: > On 09/21/2014 05:04 PM, miny...@acm.org wrote: >> From: Corey Minyard >> >> Adds a "reconnect" option to socket backends that gives a reconnect >> timeout. This only applies to client sockets. If the other end

Re: [Qemu-devel] [PATCH 5/6] qemu-char: Add reconnecting to client sockets

2014-10-01 Thread Corey Minyard
I haven't heard anything about these patches. Is there anything I need to do to get them included? Thanks, -corey On 09/25/2014 03:07 PM, miny...@acm.org wrote: > From: Corey Minyard > > Adds a "reconnect" option to socket backends that gives a reconnect > tim

Re: [Qemu-devel] [PATCH 5/6] qemu-char: Add reconnecting to client sockets

2014-10-01 Thread Corey Minyard
On 10/01/2014 02:10 PM, Eric Blake wrote: > On 09/25/2014 02:07 PM, miny...@acm.org wrote: >> From: Corey Minyard >> >> Adds a "reconnect" option to socket backends that gives a reconnect >> timeout. This only applies to client sockets. If the other end

Re: [Qemu-devel] [PATCH 5/6] qemu-char: Add reconnecting to client sockets

2014-10-03 Thread Corey Minyard
On 10/03/2014 05:22 PM, Paolo Bonzini wrote: > Il 02/10/2014 18:17, miny...@acm.org ha scritto: >> +if (!qemu_chr_open_socket_fd(chr, &err)) { >> +error_report("Unable to connect to char device %s\n", chr->label); >> +qemu_chr_socket_restart_timer(chr); >> +} > Can you pleas

Re: [Qemu-devel] [PATCH 1/2] qemu-char: Fix reconnect socket error reporting

2014-10-06 Thread Corey Minyard
On 10/06/2014 01:36 PM, Eric Blake wrote: > On 10/06/2014 11:59 AM, miny...@acm.org wrote: >> From: Corey Minyard >> >> If reconnect was set, errors wouldn't always be reported. >> Fix that and also only report a connect error once until a >> connection has b

Re: [Qemu-devel] [PATCH 3/3] qemu-sockets: Add error to non-blocking connect handler

2014-10-09 Thread Corey Minyard
On 10/09/2014 05:07 AM, Paolo Bonzini wrote: >> +error_setg_errno(&err, errno, "Error connecting to socket"); >> > closesocket(s->fd); >> > s->fd = rc; >> > } > This is missing above this hunk: > > diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c > index e6a9644

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-21 Thread Corey Minyard
Look at drivers/char/ipmi/ipmi_msghandler.c. It has code to send panic event over IMPI. The code is pretty complex. Of course if we a going to implement something more complex than simple hypercall for panic notification we better do something more interesting with it than just saying "panic hap

Re: [Qemu-devel] [PATCH] qemu-char: Allow a chardev to reconnect if disconnected

2014-04-10 Thread Corey Minyard
On 04/10/2014 06:43 AM, arei.gong...@huawei.com wrote: > From: Huangweidong > > Allow a socket chardev reconnect if the connection drops while in use. > > Signed-off-by: Huangweidong > Signed-off-by: Gonglei > --- > This patch is modified according to corey's patch. Some changes below: > 1. IMO

Re: [Qemu-devel] 【Question】About "Add an IPMI device to QEMU" patches

2014-02-27 Thread Corey Minyard
There have been some legal issues around this. Implementing IPMI requires that you sign an adopter's agreement and submit it to the IPMI group. We are not sure what that means for an open-source project. So I'm kind of in a holding pattern until I get something back from the IPMI group. I've su

Re: [Qemu-devel] [PATCH 00/20] Add an IPMI device to QEMU

2013-11-05 Thread Corey Minyard
On 11/05/2013 07:56 AM, Michael S. Tsirkin wrote: > On Wed, May 29, 2013 at 05:07:56PM -0500, miny...@acm.org wrote: >> I have finally gotten some time to work on this, this series of >> patches adds an IPMI interface to qemu. The changes are roughly: >> >> patches 01-05 - Add the capability to ha

Re: [Qemu-devel] [PATCH 00/20] Add an IPMI device to QEMU

2013-11-05 Thread Corey Minyard
On 11/05/2013 10:09 AM, Andreas Färber wrote: > Hi, > > Am 05.11.2013 14:56, schrieb Michael S. Tsirkin: >> On Wed, May 29, 2013 at 05:07:56PM -0500, miny...@acm.org wrote: >>> I have finally gotten some time to work on this, this series of >>> patches adds an IPMI interface to qemu. The changes a

[Qemu-devel] [PATCH 00/16] Add an IPMI device to QEMU

2013-11-12 Thread Corey Minyard
There are two (sets of) patches to the general code beyond the IPMI device addition. One set adds an option to qemu-char net devices to automatically try to reconnect if the connection disconnects. This lets the IPMI device connect to a remote BMC and recover if that BMC fails. The other set all

[Qemu-devel] [PATCH 04/16] qemu-char: Close fd at end of file

2013-11-12 Thread Corey Minyard
The chardev backends that used qemu_chr_open_fd did not get their file descriptors closed at end of file or when the chardev was closed. This could result in a file descriptor leak. Signed-off-by: Corey Minyard --- qemu-char.c | 35 +-- 1 file changed, 29

[Qemu-devel] [PATCH 03/16] qemu-char: remove free of chr from win_stdio_close

2013-11-12 Thread Corey Minyard
This will result in a double free on close, because it's freed in qemu_chr_delete() right after calling the close function. Signed-off-by: Corey Minyard --- qemu-char.c | 1 - 1 file changed, 1 deletion(-) diff --git a/qemu-char.c b/qemu-char.c index 23d7647..935066d 100644 --- a/qemu-c

[Qemu-devel] [PATCH 14/16] pc: Postpone adding ACPI and SMBIOS to fw_cfg

2013-11-12 Thread Corey Minyard
Postpone the addition of the ACPI and SMBIOS tables until after device initialization. This allows devices to add entries to these tables. Signed-off-by: Corey Minyard --- hw/i386/pc.c | 38 ++ 1 file changed, 30 insertions(+), 8 deletions(-) diff --git a

[Qemu-devel] [PATCH 01/16] qemu-char: Allocate CharDriverState in qemu_chr_new_from_opts

2013-11-12 Thread Corey Minyard
This allocates the CharDriverState structure and passes it in to the open routine. This allows a coming option to automatically attempt to reconnect a chardev if the connection fails. The chardev has to be kept around so a reconnect can be done on it. Signed-off-by: Corey Minyard --- backends

[Qemu-devel] [PATCH 05/16] Add a base IPMI interface

2013-11-12 Thread Corey Minyard
Add the basic IPMI types and infrastructure to QEMU. Low-level interfaces and simulation interfaces will register with this; it's kind of the go-between to tie them together. Signed-off-by: Corey Minyard --- default-configs/i386-softmmu.mak | 1 + default-configs/x86_64-softmmu.mak

[Qemu-devel] [PATCH 07/16] ipmi: Add a KCS low-level interface

2013-11-12 Thread Corey Minyard
This provides the simulation of the KCS hardware interface. Signed-off-by: Corey Minyard --- default-configs/i386-softmmu.mak | 1 + default-configs/x86_64-softmmu.mak | 1 + hw/ipmi/Makefile.objs | 1 + hw/ipmi/ipmi_kcs.c | 345

[Qemu-devel] [PATCH 06/16] ipmi: Add a PC ISA type structure

2013-11-12 Thread Corey Minyard
This provides the base infrastructure to tie IPMI low-level interfaces into a PC ISA bus. Signed-off-by: Corey Minyard --- default-configs/i386-softmmu.mak | 1 + default-configs/x86_64-softmmu.mak | 1 + hw/ipmi/Makefile.objs | 1 + hw/ipmi/isa_ipmi.c | 148

[Qemu-devel] [PATCH 11/16] ipmi: Add tests

2013-11-12 Thread Corey Minyard
Test the KCS interface with a local BMC and a BT interface with an external BMC. Signed-off-by: Corey Minyard --- tests/Makefile| 4 + tests/ipmi-bt-test.c | 440 ++ tests/ipmi-kcs-test.c | 294 + 3 files

[Qemu-devel] [PATCH 08/16] ipmi: Add a BT low-level interface

2013-11-12 Thread Corey Minyard
This provides the simulation of the BT hardware interface for IPMI. Signed-off-by: Corey Minyard --- default-configs/i386-softmmu.mak | 1 + default-configs/x86_64-softmmu.mak | 1 + hw/ipmi/Makefile.objs | 1 + hw/ipmi/ipmi_bt.c | 367

[Qemu-devel] [PATCH 15/16] smbios: Add a function to directly add an entry

2013-11-12 Thread Corey Minyard
There was no way to directly add a table entry to the SMBIOS table, even though the BIOS supports this. So add a function to do this. This is in preparation for the IPMI handler adding it's SMBIOS table entry. Signed-off-by: Corey Minyard --- hw/i386/smbios.c

[Qemu-devel] [PATCH 16/16] ipmi: Add SMBIOS table entry

2013-11-12 Thread Corey Minyard
Add an IPMI table entry to the SMBIOS. --- hw/ipmi/isa_ipmi.c | 29 + include/hw/i386/smbios.h | 14 ++ 2 files changed, 43 insertions(+) diff --git a/hw/ipmi/isa_ipmi.c b/hw/ipmi/isa_ipmi.c index b38c846..e40ca90 100644 --- a/hw/ipmi/isa_ipmi.c +++ b

[Qemu-devel] [PATCH 12/16] ipmi: Add documentation

2013-11-12 Thread Corey Minyard
Add some basic documentation for the IPMI device. Signed-off-by: Corey Minyard --- qemu-options.hx | 35 +++ 1 file changed, 35 insertions(+) diff --git a/qemu-options.hx b/qemu-options.hx index 5bcfaa0..500d7c8 100644 --- a/qemu-options.hx +++ b/qemu-options.hx

[Qemu-devel] [PATCH 13/16] ipmi: Add migration capability to the IPMI device.

2013-11-12 Thread Corey Minyard
Signed-off-by: Corey Minyard io_length = 3; memory_region_init_io(&s->io, OBJECT(s), &ipmi_bt_io_ops, bt, "ipmi-bt", 3); +vmstate_register(NULL, 0, &vmstate_ipmi_bt, bt); return 0; } diff --git a/hw/ipmi/ipmi_extern.c b/hw/ipmi/ipmi_extern.c index 1cd7

[Qemu-devel] [PATCH 09/16] ipmi: Add a local BMC simulation

2013-11-12 Thread Corey Minyard
This provides a minimal local BMC, basically enough to comply with the spec and provide a complete watchdog timer (including a sensor, SDR, and event). Signed-off-by: Corey Minyard --- default-configs/i386-softmmu.mak |1 + default-configs/x86_64-softmmu.mak |1 + hw/ipmi

[Qemu-devel] [PATCH 02/16] qemu-char: Allow a chardev to reconnect if disconnected

2013-11-12 Thread Corey Minyard
Allow a socket that connects to reconnect on a periodic basis if it fails to connect at startup or if the connection drops while in use. Signed-off-by: Corey Minyard --- include/sysemu/char.h | 3 ++ qemu-char.c | 88 --- qemu

[Qemu-devel] [PATCH 10/16] ipmi: Add an external connection simulation interface

2013-11-12 Thread Corey Minyard
This adds an interface for IPMI that connects to a remote BMC over a chardev (generally a TCP socket). The OpenIPMI lanserv simulator describes this interface, see that for interface details. Signed-off-by: Corey Minyard --- default-configs/i386-softmmu.mak | 1 + default-configs/x86_64

Re: [Qemu-devel] [PATCH 02/16] qemu-char: Allow a chardev to reconnect if disconnected

2013-11-12 Thread Corey Minyard
On 11/12/2013 10:43 AM, Eric Blake wrote: > On 11/12/2013 09:33 AM, Corey Minyard wrote: >> Allow a socket that connects to reconnect on a periodic basis if it >> fails to connect at startup or if the connection drops while in use. >> >> Signed-off-by: Corey Minyard

Re: [Qemu-devel] [PATCH 02/16] qemu-char: Allow a chardev to reconnect if disconnected

2013-11-13 Thread Corey Minyard
On 11/13/2013 02:55 AM, Gerd Hoffmann wrote: > Hi, > >> Allow a socket that connects to reconnect on a periodic basis if it >> fails to connect at startup or if the connection drops while in use. >> +chr->backend = i; >> +chr->recon_time = qemu_opt_get_number(opts, "reconnect", 0); >> +

Re: [Qemu-devel] [PATCH 11/16] ipmi: Add tests

2013-11-13 Thread Corey Minyard
test.o > tests/endianness-test$(EXESUF): tests/endianness-test.o > tests/fdc-test$(EXESUF): tests/fdc-test.o > tests/ide-test$(EXESUF): tests/ide-test.o $(libqos-pc-obj-y) > +tests/ipmi-kcs-test$(EXESUF): tests/ipmi-kcs-test.o > +tests/ipmi-bt-test$(EXESUF): tests/ipmi-bt-test.o &

Re: [Qemu-devel] [PATCH 15/16] smbios: Add a function to directly add an entry

2013-11-13 Thread Corey Minyard
On 11/13/2013 08:37 AM, Bret Ketchum wrote: > > Don't know if it matters much but this patch cannot be applied > without the prototype definition in 16/16. Thanks, I'll fix this. -corey > > > On Tue, Nov 12, 2013 at 10:33 AM, Corey Minyard <mailto:miny...@acm

Re: [Qemu-devel] [PATCH 14/16] pc: Postpone adding ACPI and SMBIOS to fw_cfg

2013-11-14 Thread Corey Minyard
On 11/14/2013 01:30 AM, Michael S. Tsirkin wrote: > On Tue, Nov 12, 2013 at 10:33:13AM -0600, Corey Minyard wrote: >> Postpone the addition of the ACPI and SMBIOS tables until after >> device initialization. This allows devices to add entries to these >> tables. >> >

Re: [Qemu-devel] [PATCH 02/16] qemu-char: Allow a chardev to reconnect if disconnected

2013-11-14 Thread Corey Minyard
On 11/14/2013 01:32 AM, Michael S. Tsirkin wrote: > On Tue, Nov 12, 2013 at 11:08:07AM -0600, Corey Minyard wrote: >> On 11/12/2013 10:43 AM, Eric Blake wrote: >>> On 11/12/2013 09:33 AM, Corey Minyard wrote: >>>> Allow a socket that connects to reconnect on a peri

Re: [Qemu-devel] [PATCH 14/16] pc: Postpone adding ACPI and SMBIOS to fw_cfg

2013-11-14 Thread Corey Minyard
On 11/14/2013 07:38 AM, Michael S. Tsirkin wrote: > On Thu, Nov 14, 2013 at 07:28:00AM -0600, Corey Minyard wrote: >> On 11/14/2013 01:30 AM, Michael S. Tsirkin wrote: >>> On Tue, Nov 12, 2013 at 10:33:13AM -0600, Corey Minyard wrote: >>>> Postpone the addition of th

Re: [Qemu-devel] [PATCH 16/16] ipmi: Add SMBIOS table entry

2013-11-14 Thread Corey Minyard
On 11/14/2013 01:46 AM, Michael S. Tsirkin wrote: > BTW you included this: > > Cc: qemu-devel@nongnu.org, Andreas Färber , > Bret Ketchum , > Corey Minyard > > the last address: cminy...@mvista.com is bouncing. > That's actually not the one bouncin

Re: [Qemu-devel] [PATCH 2/7] qemu-char: Allow a chardev to reconnect if disconnected

2014-03-06 Thread Corey Minyard
On 03/06/2014 12:47 AM, Weidong Huang wrote: > escape sequences. > > +@option{reconnect} specifies that if the client socket does not connect at > +startup, or if the client socket is closed for some reason (like the other > +end exited), wait the given number of seconds and attempt to reconnect

Re: [Qemu-devel] [PATCH 2/7] qemu-char: Allow a chardev to reconnect if disconnected

2014-03-06 Thread Corey Minyard
On 03/06/2014 01:43 AM, Michael S. Tsirkin wrote: > > +@option{reconnect} specifies that if the client socket does not connect at > +startup, or if the client socket is closed for some reason (like the other > +end exited), wait the given number of seconds and attempt to reconnect. > + > TCP and

Re: [Qemu-devel] [PATCH 15/16] ipmi: Add ACPI table entries for BMCs

2015-02-19 Thread Corey Minyard
On 02/18/2015 08:54 PM, Benjamin Herrenschmidt wrote: > On Fri, 2014-12-12 at 13:15 -0600, miny...@acm.org wrote: >> From: Corey Minyard >> >> Use the new ACPI table construction tools to create an ACPI >> entry for IPMI. > Same question as for the smbios busines

Re: [Qemu-devel] QEMU IPMI support

2015-04-04 Thread Corey Minyard
rote: > Hi Corey, > > Yes please, setting up a git repo on git hub with IPMI support would be a > tremendous help. > > Thank you, > Joel > > -----Original Message- > From: Corey Minyard [mailto:tcminy...@gmail.com] On Behalf Of Corey Minyard > Sent: Friday, Ap

Re: [Qemu-devel] QEMU IPMI support

2015-04-07 Thread Corey Minyard
On 04/04/2015 09:02 PM, Corey Minyard wrote: > Ok, done. It's at https://github.com/cminyard/qemu on github. There > are two branches at the moment, stable-2.2-ipmi is based on the 2.2 > release and will not rebase. master-ipmi-rebase will rebase on master > as it moves. &

Re: [Qemu-devel] QEMU IPMI support

2015-04-07 Thread Corey Minyard
On 04/07/2015 07:24 AM, Longever, Joseph wrote: > Hi Corey, > > Thanks so much for the support. I pulled down the 2.2-ipmi stable snapshot > and everything compiled with no issues. > > Could you help confirm my configuration? Can you send your complete configuration file and startup command file

Re: [Qemu-devel] [PATCH 16/16] ipmi: Add a thread to better simulate a BMC

2014-12-15 Thread Corey Minyard
On 12/15/2014 03:11 PM, Paolo Bonzini wrote: > > On 12/12/2014 20:15, miny...@acm.org wrote: >> +if (s->threaded_bmc) { >> +qemu_mutex_init(&s->lock); >> +qemu_cond_init(&s->waker); >> +qemu_thread_create(&s->thread, "ipmi-bmc", ipmi_thread, s, 0); >> +} >> + >> +

Re: [Qemu-devel] [PATCH 10/15] smbios: Add a function to directly add an entry

2015-04-12 Thread Corey Minyard
On 04/12/2015 11:05 AM, Michael S. Tsirkin wrote: > On Tue, Apr 07, 2015 at 02:51:39PM -0500, miny...@acm.org wrote: >> From: Corey Minyard >> >> There was no way to directly add a table entry to the SMBIOS table, >> even though the BIOS supports this. So add a functio

Re: [Qemu-devel] [PATCH 14/15] acpi: Add hooks for adding things to the SSDT table

2015-04-12 Thread Corey Minyard
On 04/12/2015 11:17 AM, Michael S. Tsirkin wrote: > On Tue, Apr 07, 2015 at 02:51:43PM -0500, miny...@acm.org wrote: >> From: Corey Minyard >> >> This way devices can tie in when then SSDT is built and can add their >> own entries. This didn't seem to fit any

Re: [Qemu-devel] [PATCH 14/15] acpi: Add hooks for adding things to the SSDT table

2015-04-13 Thread Corey Minyard
On 04/13/2015 08:44 AM, Paolo Bonzini wrote: > > On 13/04/2015 03:30, Corey Minyard wrote: >>> Hmm, I don't see patch 15/15 so I don't know how this is used. >> Yeah, I resent and I don't know what's happened. All the others were >> sent exactly t

Re: [Qemu-devel] [PATCH 10/15] smbios: Add a function to directly add an entry

2015-04-13 Thread Corey Minyard
On 04/13/2015 02:00 AM, Michael S. Tsirkin wrote: > On Sun, Apr 12, 2015 at 08:26:46PM -0500, Corey Minyard wrote: >> On 04/12/2015 11:05 AM, Michael S. Tsirkin wrote: >>> On Tue, Apr 07, 2015 at 02:51:39PM -0500, miny...@acm.org wrote: >>>> From: Corey Minyard

Re: [Qemu-devel] [PATCH 10/15] smbios: Add a function to directly add an entry

2015-04-14 Thread Corey Minyard
On 04/14/2015 01:31 AM, Michael S. Tsirkin wrote: > On Mon, Apr 13, 2015 at 06:40:46PM +0200, Paolo Bonzini wrote: >> >> On 13/04/2015 18:34, Corey Minyard wrote: >>>>> I made this the same as the ACPI code, which you have to have as a >>>>> callback if

Re: [Qemu-devel] Add an IPMI device to qemu

2015-04-22 Thread Corey Minyard
Sure, it's available on https://github.com/cminyard/qemu.git, the stable-2.2-ipmi branch for now. I'm currently reworking these patches based upon feedback from the qemu maintainers. -corey On 04/22/2015 04:30 PM, Noel Burton-Krahn wrote: > Hi Corey, > > I saw your patches for getting IPMI into

Re: [Qemu-devel] Add an IPMI device to qemu

2015-04-23 Thread Corey Minyard
On 04/22/2015 07:25 PM, Noel Burton-Krahn wrote: > OK, I've build qemu and openipmi. I'm simulating a system where a > central control node boots from USB, then uses IPMI to boot a cluster > of slave nodes and provisions them by tftpboot. If I understand > correctly, I'll be running one ipmi_sim

Re: [Qemu-devel] [PATCH 00/17] Update to adding an IPMI device to qemu

2015-04-24 Thread Corey Minyard
On 04/24/2015 04:38 AM, Paolo Bonzini wrote: > > On 24/04/2015 00:57, miny...@acm.org wrote: >> The major changes from last time are: >> >> * Don't use callbacks for adding firmware tables, provide binary >> blobs instead. >> >> * Add the SSDT as a separate table. >> >> * Modify the BIOS tests to

Re: [Qemu-devel] Add an IPMI device to qemu

2015-04-24 Thread Corey Minyard
> control node is connected to both networks and provides dhcp > > controller node1 node2 ... > IPMI eth0 - ipmi0 ipmi0 > DATA eth1 - eth0 - eth0 > > I'm using veth pairs with one end in a bridge for the ipmi interfaces > and tap devices f

Re: [Qemu-devel] [PATCH 00/17] Update to adding an IPMI device to qemu

2015-04-27 Thread Corey Minyard
ch would absolve you from any recompense. On Thu, Mar 6, 2014 at 6:48 PM, Corey Minyard mailto:miny...@acm.org>> wrote: On 03/06/2014 06:02 AM, Bret Ketchum wrote: > > > What needs to be done to unstick the IPMI patches? Are you waiting > on something from

Re: [Qemu-devel] [PATCH 02/17] ipmi: Add a PC ISA type structure

2015-05-15 Thread Corey Minyard
On 05/13/2015 09:52 AM, Paolo Bonzini wrote: > > On 11/05/2015 21:58, Corey Minyard wrote: >> I've debated this in my mind since I've been learning more about >> qemu. Some of the bmc properties are being passed in to the interface >> and passed on to the bmc. Pl

Re: [Qemu-devel] [PATCH 5/8] ipmi: add ACPI power and GUID commands

2016-01-21 Thread Corey Minyard
On 01/17/2016 08:16 AM, Michael S. Tsirkin wrote: On Sun, Jan 17, 2016 at 02:04:32PM +0200, Marcel Apfelbaum wrote: On 01/05/2016 07:29 PM, Cédric Le Goater wrote: Signed-off-by: Cédric Le Goater --- hw/ipmi/ipmi_bmc_sim.c | 55 ++ 1 file chan

Re: [Qemu-devel] [PATCH v2 2/9] ipmi: replace goto by a return statement

2016-01-22 Thread Corey Minyard
, but the code does look a lot neater this way. Reviewed-by: Corey Minyard Signed-off-by: Cédric Le Goater --- hw/ipmi/ipmi_bmc_sim.c | 140 +++-- 1 file changed, 41 insertions(+), 99 deletions(-) diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipm

Re: [Qemu-devel] [PATCH v2 8/9] ipmi: add ACPI power and GUID commands

2016-01-22 Thread Corey Minyard
On 01/21/2016 11:18 AM, Cédric Le Goater wrote: Signed-off-by: Cédric Le Goater --- Changes since v1: - added ACPI to command names. Thanks. Acked-by: Corey Minyard hw/ipmi/ipmi_bmc_sim.c | 49 + 1 file changed, 49 insertions

Re: [Qemu-devel] [PATCH] ipmi: do not take/drop iothread lock

2016-01-26 Thread Corey Minyard
On 01/26/2016 10:21 AM, Michael S. Tsirkin wrote: On Tue, Jan 26, 2016 at 05:15:53PM +0100, Paolo Bonzini wrote: This is not necessary and actually causes a hang; it was probably copied and pasted from KVM code, that is one of the very few places that run outside iothread lock. Signed-off-by: P

Re: [Qemu-devel] [PATCH v4 17/17] ipmi: Add a force off function

2015-11-13 Thread Corey Minyard
On 11/13/2015 03:15 AM, Daniel P. Berrange wrote: > On Thu, Nov 12, 2015 at 01:02:33PM -0600, miny...@acm.org wrote: >> From: Corey Minyard >> >> Allow the IPMI interface to request a forced power off. >> >> Signed-off-by: Corey Minyard >> --- >> h

Re: [Qemu-devel] [PATCH v4 17/17] ipmi: Add a force off function

2015-11-13 Thread Corey Minyard
On 11/13/2015 07:23 AM, Paolo Bonzini wrote: > > On 13/11/2015 14:22, Corey Minyard wrote: >> On 11/13/2015 03:15 AM, Daniel P. Berrange wrote: >>> On Thu, Nov 12, 2015 at 01:02:33PM -0600, miny...@acm.org wrote: >>>> From: Corey Minyard >>>> >

Re: [Qemu-devel] [PATCH v4 02/17] Add a base IPMI interface

2015-11-18 Thread Corey Minyard
I haven't heard any more comments on this series, should I resubmit with the one shutdown change? -corey On Nov 12, 2015 1:02 PM, wrote: > From: Corey Minyard > > Add the basic IPMI types and infrastructure to QEMU. Low-level > interfaces and simulation interfaces will r

Re: [Qemu-devel] [PATCH v4 03/17] ipmi: Add a local BMC simulation

2015-11-24 Thread Corey Minyard
on the power systems, and it makes sense to extend this for that application. > On 11/12/2015 08:02 PM, miny...@acm.org wrote: >> From: Corey Minyard >> >> This provides a minimal local BMC, basically enough to comply with the >> spec and provide a complete watchdog

Re: [Qemu-devel] [PATCH 0/8] ipmi: a couple of enhancements to the BMC simulator (round 2)

2016-02-09 Thread Corey Minyard
h the renaming of sdr (fru is your option): Acked-by: Corey Minyard for all patches. Oh, and I assume you need to add documentation for the properties to qemu-options.hx. -corey Based on e4a096b1cd43 and also available here : https://github.com/legoater/qemu/commits/ipmi Thanks, C. Céd

Re: [Qemu-devel] [PATCH 0/8] ipmi: a couple of enhancements to the BMC simulator (round 2)

2016-02-10 Thread Corey Minyard
On 02/10/2016 08:05 AM, Cédric Le Goater wrote: Hello Corey, On 02/09/2016 07:25 PM, Corey Minyard wrote: On 02/09/2016 06:13 AM, Cédric Le Goater wrote: The first patches are cleanups and prepare ground for an extension of the BMC simulator providing a SDR loader using a file. A simple FRU

Re: [Qemu-devel] [PATCH 6/8] ipmi: provide support for FRUs

2016-02-15 Thread Corey Minyard
On 02/15/2016 12:40 PM, Marcel Apfelbaum wrote: On 02/15/2016 07:17 PM, Cédric Le Goater wrote: On 02/14/2016 10:25 AM, Marcel Apfelbaum wrote: On 02/09/2016 02:13 PM, Cédric Le Goater wrote: This patch provides a simple FRU support for the BMC simulator. FRUs are loaded from a file which name

Re: [Qemu-devel] [PATCH 4/8] ipmi: add FRU support

2016-01-08 Thread Corey Minyard
On 01/05/2016 11:29 AM, Cédric Le Goater wrote: This patch provides a simplistic FRU support for the IPMI BMC simulator. The FRU area contains 32 entries * 256 bytes which should be enough to start some simulation. Signed-off-by: Cédric Le Goater --- hw/ipmi/ipmi_bmc_sim.c | 119

Re: [Qemu-devel] [PATCH 5/8] ipmi: add ACPI power and GUID commands

2016-01-08 Thread Corey Minyard
On 01/05/2016 11:29 AM, Cédric Le Goater wrote: Signed-off-by: Cédric Le Goater --- hw/ipmi/ipmi_bmc_sim.c | 55 ++ 1 file changed, 55 insertions(+) diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c index 60586a67104e..c3a06d0ac7e4 1

Re: [Qemu-devel] [PATCH 6/8] ipmi: add SET_SENSOR_READING command (tentative try)

2016-01-08 Thread Corey Minyard
Acked-by: Corey Minyard This looks good. Though this file is getting uncomfortably large, I may have to look at splitting it up. -corey On 01/05/2016 11:30 AM, Cédric Le Goater wrote: SET_SENSOR_READING is a complex IPMI command (IPMI spec : "35.17 Set Sensor Reading And Event S

Re: [Qemu-devel] [PATCH 7/8] ipmi: introduce an ipmi_bmc_init_sensor() API

2016-01-08 Thread Corey Minyard
The way the SDR and sensors are handled currently in the code I wrote is far from ideal, it's not scalable. In my mind, the BMC in qemu would never be a very elaborate one, you would use an external BMC for that. There are a couple of issues to deal with here: We need support for SDRs besides

Re: [Qemu-devel] [PATCH 1/8] ipmi: fix SDR length value

2016-01-08 Thread Corey Minyard
On 01/06/2016 02:14 AM, Cédric Le Goater wrote: On 01/05/2016 08:59 PM, Eric Blake wrote: On 01/05/2016 10:29 AM, Cédric Le Goater wrote: [meta-comment] Your messages were not marked in-reply-to: the 0/8 cover letter, but came through as separate threads. This makes it harder to follow, especi

Re: [Qemu-devel] [PATCH 3/8] ipmi: add GET_SYS_RESTART_CAUSE chassis command

2016-01-08 Thread Corey Minyard
Acked-by: Corey Minyard On 01/05/2016 11:29 AM, Cédric Le Goater wrote: This is a simulator. Just return an unknown cause (0). Signed-off-by: Cédric Le Goater --- hw/ipmi/ipmi_bmc_sim.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/hw/ipmi

Re: [Qemu-devel] [PATCH 2/8] ipmi: add get and set SENSOR_TYPE commands

2016-01-08 Thread Corey Minyard
Acked-by: Corey Minyard I agree with Greg's comments, too. -corey On 01/05/2016 11:29 AM, Cédric Le Goater wrote: Signed-off-by: Cédric Le Goater --- hw/ipmi/ipmi_bmc_sim.c | 51 -- 1 file changed, 49 insertions(+), 2 deletions(-)

Re: [Qemu-devel] [PATCH 13/16] IPMI: Add an external connection simulation interface

2013-04-03 Thread Corey Minyard
4:00, miny...@acm.org wrote: >> From: Corey Minyard >> >> This adds an interface for IPMI that connects to a remote >> BMC over a chardev (generally a TCP socket). The OpenIPMI >> lanserv simulator describes this interface, see that for >> interface details.

Re: [Qemu-devel] Adding an IPMI BMC device to KVM

2012-05-07 Thread Corey Minyard
I think we are getting a little out of hand here, and we are mixing up concepts :). There are lots of things IPMI *can* do (including serial access, VGA snooping, LAN access, etc.) but I don't see any value it that. The main thing here is to emulate the interface to the guest. OOB management

Re: [Qemu-devel] Adding an IPMI BMC device to KVM

2012-05-07 Thread Corey Minyard
ding basic management would be easy. -corey Dave On Mon, May 07, 2012 at 01:07:45PM -0500, Corey Minyard wrote: I think we are getting a little out of hand here, and we are mixing up concepts :). There are lots of things IPMI *can* do (including serial access, VGA snooping, LAN access, etc.) but I

Re: [Qemu-devel] Adding an IPMI BMC device to KVM

2012-05-18 Thread Corey Minyard
On 05/18/2012 08:08 AM, Stefan Hajnoczi wrote: On Mon, May 7, 2012 at 3:30 PM, Anthony Liguori wrote: On 05/06/2012 09:39 AM, Avi Kivity wrote: On 05/06/2012 05:35 PM, Anthony Liguori wrote: So what's really the use case here? Would an IPMI -> libvirt bridge get you what you need? I really

Re: [Qemu-devel] Adding an IPMI BMC device to KVM

2012-05-18 Thread Corey Minyard
On 05/18/2012 08:08 AM, Stefan Hajnoczi wrote: On Mon, May 7, 2012 at 3:30 PM, Anthony Liguori wrote: On 05/06/2012 09:39 AM, Avi Kivity wrote: On 05/06/2012 05:35 PM, Anthony Liguori wrote: So what's really the use case here? Would an IPMI -> libvirt bridge get you what you need? I really

Re: [Qemu-devel] Cant make the IPMI simulator work, help needed.

2015-06-04 Thread Corey Minyard
o simulate the IPMI simulator for test purposes but was > failing somehow.. > I see lot of help being given in this forum , especially Corey > Minyard. Thank you. > I am new to IPMI and QEMU, but followed the threads and was able to > fix up to some point. Right now struck and not able

Re: [Qemu-devel] Cant make the IPMI simulator work, help needed.

2015-06-08 Thread Corey Minyard
I'll add that to the CC. > > This work is still not completely there, so it will be changing, > but it > should work as is. > > On 06/02/2015 05:58 AM, RamakrishnaDeepak Battu wrote: > > Hi, > > > > I am trying to simulate the IPM

Re: [Qemu-devel] [PATCH v3 14/16] acpi: Add a way for devices to add ACPI tables

2015-07-13 Thread Corey Minyard
On 07/09/2015 03:25 AM, Igor Mammedov wrote: > On Wed, 8 Jul 2015 22:39:24 +0200 > Paolo Bonzini wrote: > >> >> On 08/07/2015 21:26, Igor Mammedov wrote: This was suggested by Michael, so I think you should read the reviews of earlier versions first. >>> That is basically the same as hoo

Re: [Qemu-devel] [PATCH 01/16] smbios: Add a function to directly add an entry

2012-07-15 Thread Corey Minyard
I messed up and didn't get an introduction for these patches. So here goes. These patches are for adding an IPMI interface to QEMU. It adds a KCS and BT interface; it should be easy to add a SMIC interface if anyone wants that, but it's not often used. For simulation of an IPMI management c

Re: [Qemu-devel] [PATCH 01/16] smbios: Add a function to directly add an entry

2012-07-16 Thread Corey Minyard
On 07/16/2012 10:46 AM, Eric Blake wrote: On 07/15/2012 02:24 PM, miny...@acm.org wrote: From: Corey Minyard There was no way to directly add a table entry to the SMBIOS table, even though the BIOS supports this. So add a function to do this. This is in preparation for the IPMI handler

Re: [Qemu-devel] [PATCH 10/16] qom: release previous object when setting

2012-07-16 Thread Corey Minyard
On 07/16/2012 01:24 AM, Paolo Bonzini wrote: Il 15/07/2012 22:25, miny...@acm.org ha scritto: From: Corey Minyard When setting an object, if you don't release the previous object that was there, it may become unusable. This change allows a chardev to be removed from one object's

Re: [Qemu-devel] [PATCH 12/16] IPMI: Add a PC ISA type structure

2012-07-16 Thread Corey Minyard
On 07/16/2012 02:16 AM, Paolo Bonzini wrote: Il 15/07/2012 22:25, miny...@acm.org ha scritto: +/* Clear the property from this device so we can put it elsewhere */ +chr = isa->chr; +qdev_prop_set_chr(&dev->qdev, "chardev", NULL); + +if (chr) { + bdev = qdev_create(NULL, "ip

Re: [Qemu-devel] Third shot at adding IPMI to qemu

2012-07-30 Thread Corey Minyard
I haven't heard anything on this. Any comments or movement on this set of patches? Thanks, -corey On 07/19/2012 01:53 PM, miny...@acm.org wrote: Ok, everything passes through checkpatch without an error now. I have added some tests to verify basic operation of the device, and I've hacked in

Re: [Qemu-devel] Third shot at adding IPMI to qemu

2012-07-30 Thread Corey Minyard
On 07/30/2012 09:05 AM, Andreas Färber wrote: Am 30.07.2012 15:34, schrieb Corey Minyard: I haven't heard anything on this. FWIW you did hear from Paolo. :) Yes, I did, I apologize. I think I meant to say "recently". Any comments or movement on this set of patches? For a

Re: [Qemu-devel] [PATCH 09/18] qdev: Add a pre-firmware init capability

2012-07-30 Thread Corey Minyard
On 07/30/2012 09:36 AM, Andreas Färber wrote: Am 19.07.2012 20:53, schrieb miny...@acm.org: From: Corey Minyard Some devices may need to do some firmware-type initialization before the firmware itself is initialized. For instance, any device that adds SMBIOS table entries (like IPMI) will

Re: [Qemu-devel] [PATCH 01/18] smbios: Add a function to directly add an entry

2012-07-30 Thread Corey Minyard
On 07/30/2012 10:37 AM, Anthony Liguori wrote: miny...@acm.org writes: From: Corey Minyard There was no way to directly add a table entry to the SMBIOS table, even though the BIOS supports this. So add a function to do this. This is in preparation for the IPMI handler adding it's S

Re: [Qemu-devel] [PATCH 12/18] IPMI: Add a PC ISA type structure

2012-07-30 Thread Corey Minyard
On 07/30/2012 08:45 AM, Andreas Färber wrote: Am 19.07.2012 20:53, schrieb miny...@acm.org: From: Corey Minyard + +static Property ipmi_isa_properties[] = { +DEFINE_PROP_STRING("interface", ISAIPMIDevice, interface), +DEFINE_PROP_HEX32("iobase", ISAIP

Re: [Qemu-devel] [PATCH 01/18] smbios: Add a function to directly add an entry

2012-07-30 Thread Corey Minyard
On 07/30/2012 12:25 PM, Anthony Liguori wrote: Corey Minyard writes: On 07/30/2012 10:37 AM, Anthony Liguori wrote: miny...@acm.org writes: From: Corey Minyard There was no way to directly add a table entry to the SMBIOS table, even though the BIOS supports this. So add a function to do

Re: [Qemu-devel] [PATCH 01/18] smbios: Add a function to directly add an entry

2012-08-01 Thread Corey Minyard
On 08/01/2012 08:15 PM, Kevin O'Connor wrote: This approach, unfortunately, leads to extra code and "double handling" of infomation. The ultimate consumer of the data wants a binary struct which looks like: struct smbios_type_38 { struct smbios_structure_header header; u8 interface_t

  1   2   3   4   5   >