Re: [Qemu-devel] [PATCH v3 00/32] implement vNVDIMM

On Tue, Oct 13, 2015 at 9:03 PM, Xiao Guangrong wrote: >> Label-less DIMMs are tested as part of the unit test [1] and the >> "memmap=nn!ss" kernel parameter that registers a persistent-memory >> address range without a DIMM. What error do you see when label >>

Re: [Qemu-devel] [PATCH v4 27/33] nvdimm acpi: save arg3 for NVDIMM device _DSM method

On Mon, Oct 19, 2015 at 2:19 PM, Michael S. Tsirkin <m...@redhat.com> wrote: > On Mon, Oct 19, 2015 at 10:29:50AM -0700, Dan Williams wrote: >> On Mon, Oct 19, 2015 at 12:09 AM, Michael S. Tsirkin <m...@redhat.com> wrote: >> > On Mon, Oct 19, 2015 at 12:04:48PM +0800

Re: [Qemu-devel] [PATCH v4 27/33] nvdimm acpi: save arg3 for NVDIMM device _DSM method

On Mon, Oct 19, 2015 at 12:09 AM, Michael S. Tsirkin wrote: > On Mon, Oct 19, 2015 at 12:04:48PM +0800, Xiao Guangrong wrote: > I mean don't use ASL to comment C. It's not more readable. > Describe why the code is the way it is. Use variables by preference, > C does not have

Re: [Qemu-devel] [PATCH v3 00/32] implement vNVDIMM

On Sat, Oct 10, 2015 at 8:52 PM, Xiao Guangrong wrote: [..] > == Test == > In host > 1) create memory backed file, e.g # dd if=zero of=/tmp/nvdimm bs=1G count=10 > 2) append "-object memory-backend-file,share,id=mem1, >mem-path=/tmp/nvdimm -device

Re: [Qemu-devel] [PATCH v3 00/32] implement vNVDIMM

On Sun, Oct 11, 2015 at 9:33 PM, Xiao Guangrong <guangrong.x...@linux.intel.com> wrote: > > > On 10/11/2015 05:17 AM, Dan Williams wrote: >> >> On Sat, Oct 10, 2015 at 8:52 PM, Xiao Guangrong >> <guangrong.x...@linux.intel.com> wrote: >> [..] >>

Re: [Qemu-devel] [PATCH v3 23/32] nvdimm: build ACPI NFIT table

On Sat, Oct 10, 2015 at 8:52 PM, Xiao Guangrong wrote: > NFIT is defined in ACPI 6.0: 5.2.25 NVDIMM Firmware Interface Table (NFIT) > > Currently, we only support PMEM mode. Each device has 3 structures: > - SPA structure, defines the PMEM region info > > - MEM DEV

Re: [Qemu-devel] [PATCH v3 00/32] implement vNVDIMM

On Mon, Oct 12, 2015 at 10:49 PM, Xiao Guangrong <guangrong.x...@linux.intel.com> wrote: > > > On 10/13/2015 11:38 AM, Dan Williams wrote: >> >> On Mon, Oct 12, 2015 at 8:14 PM, Xiao Guangrong >> <guangrong.x...@linux.intel.com> wrote: >>>

Re: [Qemu-devel] [PATCH v3 00/32] implement vNVDIMM

On Mon, Oct 12, 2015 at 8:14 PM, Xiao Guangrong <guangrong.x...@linux.intel.com> wrote: > On 10/13/2015 12:36 AM, Dan Williams wrote: >> Static namespaces can be emitted without a label. Linux needs this to >> support existing "label-less" bare metal NVDIMMs. >

Re: [Qemu-devel] [PATCH v2 06/11] nvdimm acpi: initialize the resource used by NVDIMM ACPI

On Fri, Feb 19, 2016 at 12:08 AM, Michael S. Tsirkin wrote: > On Thu, Feb 18, 2016 at 11:05:23AM +0100, Igor Mammedov wrote: >> On Thu, 18 Feb 2016 12:03:36 +0800 >> Xiao Guangrong wrote: >> >> > On 02/18/2016 01:26 AM, Michael S. Tsirkin wrote:

Re: [Qemu-devel] [PATCH 00/15] NVDIMM: introduce nvdimm label support

On Thu, Mar 17, 2016 at 3:04 AM, Stefan Hajnoczi wrote: > On Thu, Mar 17, 2016 at 04:32:46PM +0800, Xiao Guangrong wrote: >> This patchset is against commit d4207b223eef3 (fw-cfg: support writeable >> blobs) on pci branch of Michael's git tree and can be found at: >>

Re: [Qemu-devel] [PATCH v2 0/8] nvdimm: hotplug support

On Thu, Aug 18, 2016 at 8:46 PM, Xiao Guangrong <guangrong.x...@linux.intel.com> wrote: > > > On 08/19/2016 11:40 AM, Xiao Guangrong wrote: >> >> >> >> On 08/19/2016 02:54 AM, Vishal Verma wrote: >>> >>> On 08/18, Dan Williams wrote:

Re: [Qemu-devel] DAX can not work on virtual nvdimm device

On Fri, Aug 19, 2016 at 4:19 AM, Xiao Guangrong wrote: > > Hi Dan, > > Recently, Redhat reported that nvml test suite failed on QEMU/KVM, > more detailed info please refer to: >https://bugzilla.redhat.com/show_bug.cgi?id=1365721 > > The reason for this bug is

Re: [Qemu-devel] [PATCH v2 0/8] nvdimm: hotplug support

[ adding Vishal who implemented the kernel side of nvdimm hotplug support ] On Thu, Aug 11, 2016 at 11:54 PM, Xiao Guangrong wrote: > This patchset is against commit c597dc90fbcd6 (virtio-net: allow increasing > rx queue siz) on pci branch of Michael's git tree

Re: [Qemu-devel] DAX can not work on virtual nvdimm device

On Mon, Aug 29, 2016 at 11:53 PM, Xiao Guangrong wrote: > > > On 08/30/2016 03:30 AM, Ross Zwisler wrote: > >> >> Can you please verify that you are using "usable" memory for your memmap? >> All >> the details are here: >> >> >>

Re: [Qemu-devel] [ndctl PATCH 0/8] dimm label space initialization support

On Wed, Oct 19, 2016 at 11:42 AM, Eric Blake <ebl...@redhat.com> wrote: > On 10/19/2016 11:47 AM, Dan Williams wrote: >> The 4.9 kernel added support for sub-dividing PMEM. With this kernel >> patch [1] on top of that baseline, the PMEM-sub-division support can be >> e

Re: [Qemu-devel] [ndctl PATCH 0/8] dimm label space initialization support

On Wed, Oct 19, 2016 at 12:41 PM, Dan Williams <dan.j.willi...@intel.com> wrote: > On Wed, Oct 19, 2016 at 11:42 AM, Eric Blake <ebl...@redhat.com> wrote: >> On 10/19/2016 11:47 AM, Dan Williams wrote: >>> The 4.9 kernel added support for sub-dividing PMEM. With th

Re: [Qemu-devel] [ndctl PATCH 0/8] dimm label space initialization support

On Wed, Oct 19, 2016 at 4:46 PM, Eric Blake <ebl...@redhat.com> wrote: > On 10/19/2016 04:29 PM, Dan Williams wrote: >> On Wed, Oct 19, 2016 at 12:41 PM, Dan Williams <dan.j.willi...@intel.com> >> wrote: >>> On Wed, Oct 19, 2016 at 11:42 AM, Eric Blake <

[Qemu-devel] [ndctl PATCH] ndctl: revert glob support for dimm commands

characters to simply rely on shell expansion of the form nmem{X..Y}, if available. Reported-by: Eric Blake <ebl...@redhat.com> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- ndctl/builtin-dimm.c | 70 +- 1 file changed, 1

Re: [Qemu-devel] [ndctl PATCH 0/8] dimm label space initialization support

On Thu, Oct 20, 2016 at 12:32 PM, Vishal Verma <vishal.l.ve...@intel.com> wrote: > On 10/19, Dan Williams wrote: >> The 4.9 kernel added support for sub-dividing PMEM. With this kernel >> patch [1] on top of that baseline, the PMEM-sub-division support can be >> enabled

[Qemu-devel] [PATCH 1/2] libnvdimm: allow a platform to force enable label support

regions the labels have a purpose. Arrange for the labels to be honored when we find an existing / valid namespace index block. Cc: <qemu-devel@nongnu.org> Cc: Haozhong Zhang <haozhong.zh...@intel.com> Cc: Xiao Guangrong <guangrong.x...@linux.intel.com> Signed-off-by: Dan Wil

[Qemu-devel] [PATCH 0/2] libnvdimm: dynamic label support

/ disable the pmem region 2/ write a valid namespace index block to the label area 3/ re-enable the region and create a namespace See the man page for the "ndctl init-labels" command. --- Dan Williams (2): libnvdimm: allow a platform to force enable label support tools/test

Re: [Qemu-devel] [PATCH] acpi: fix assert failure caused by commit 35c5a52d

mmDsmIn, arg3). > > Signed-off-by: Haozhong Zhang <haozhong.zh...@intel.com> > Reported-by: Dan Williams <dan.j.willi...@intel.com> Thanks! Tested-by: Dan Williams <dan.j.willi...@intel.com>

[Qemu-devel] [ndctl PATCH 0/8] dimm label space initialization support

otherwise unrelated to the rest of the set. [1]: https://patchwork.kernel.org/patch/9384741/ [2]: http://pmem.io/documents/NVDIMM_DSM_Interface_Example-V1.2.pdf --- Dan Williams (8): libndctl: fix error returns for unsigned apis ndctl: consolidate label commands into a single file

[Qemu-devel] [ndctl PATCH 7/8] ndctl: init-labels command

a valid namespace label index block. The 'ndctl init-labels' command writes an empty namespace label index block to convert the pmem region to labelled mode, or otherwise repair a label area. Cc: <qemu-devel@nongnu.org> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- D

Re: [Qemu-devel] [RFC PATCH 0/4] nvdimm: enable flush hint address structure

[ adding Christoph ] On Tue, Apr 11, 2017 at 1:41 AM, Haozhong Zhang wrote: > On 04/06/17 20:02 +0800, Xiao Guangrong wrote: >> >> >> On 04/06/2017 05:43 PM, Stefan Hajnoczi wrote: >> > On Fri, Mar 31, 2017 at 04:41:43PM +0800, Haozhong Zhang wrote: >> > > This patch

Re: [Qemu-devel] [RFC PATCH 0/4] nvdimm: enable flush hint address structure

On Thu, Apr 6, 2017 at 2:43 AM, Stefan Hajnoczi wrote: > On Fri, Mar 31, 2017 at 04:41:43PM +0800, Haozhong Zhang wrote: >> This patch series constructs the flush hint address structures for >> nvdimm devices in QEMU. >> >> It's of course not for 2.9. I send it out early in

Re: [Qemu-devel] [RFC PATCH 0/4] nvdimm: enable flush hint address structure

On Tue, Apr 11, 2017 at 7:56 AM, Dan Williams <dan.j.willi...@intel.com> wrote: > [ adding Christoph ] > > On Tue, Apr 11, 2017 at 1:41 AM, Haozhong Zhang > <haozhong.zh...@intel.com> wrote: >> On 04/06/17 20:02 +0800, Xiao Guangrong wrote: >>> >>> &

Re: [Qemu-devel] [RFC PATCH 0/4] nvdimm: enable flush hint address structure

[ adding xfs and fsdevel ] On Fri, Apr 21, 2017 at 6:56 AM, Stefan Hajnoczi wrote: [..] >> >>> If the vNVDIMM device is based on the regular file, i think >> >>> fsync is the bottleneck rather than this mmio-virtualization. :( >> >>> >> >> >> >> Yes, fsync() on the regular

Re: [Qemu-devel] [RFC PATCH 4/4] nvdimm acpi: build flush hint address structure if required

On Thu, Apr 6, 2017 at 3:13 AM, Stefan Hajnoczi wrote: > On Fri, Mar 31, 2017 at 04:41:47PM +0800, Haozhong Zhang wrote: >> >> Add an boolean option 'flush-hint' to device 'nvdimm'. If it's on, a >> flush hint address structure will be constructed for each nvdimm >> device. >

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

On Fri, Jul 21, 2017 at 8:58 AM, Stefan Hajnoczi wrote: > On Fri, Jul 21, 2017 at 09:29:15AM -0400, Pankaj Gupta wrote: >> >> > > A] Problems to solve: >> > > -- >> > > >> > > 1] We are considering two approaches for 'fake DAX flushing interface'. >> > > >> >

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

On Tue, Jul 25, 2017 at 7:27 AM, Pankaj Gupta <pagu...@redhat.com> wrote: > >> Subject: Re: KVM "fake DAX" flushing interface - discussion >> >> On Mon 24-07-17 08:06:07, Pankaj Gupta wrote: >> > >> > > On Sun 23-07-17 13:10:34, Dan Will

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

[ adding Ross and Jan ] On Sun, Jul 23, 2017 at 7:04 AM, Rik van Riel <r...@redhat.com> wrote: > On Sat, 2017-07-22 at 12:34 -0700, Dan Williams wrote: >> On Fri, Jul 21, 2017 at 8:58 AM, Stefan Hajnoczi <stefa...@redhat.com >> > wrote: >> > >> > Ma

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

On Mon, Jul 24, 2017 at 5:37 AM, Jan Kara <j...@suse.cz> wrote: > On Mon 24-07-17 08:06:07, Pankaj Gupta wrote: >> >> > On Sun 23-07-17 13:10:34, Dan Williams wrote: >> > > On Sun, Jul 23, 2017 at 11:10 AM, Rik van Riel <r...@redhat.com> wrote: >&

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

On Mon, Jul 24, 2017 at 8:48 AM, Jan Kara <j...@suse.cz> wrote: > On Mon 24-07-17 08:10:05, Dan Williams wrote: >> On Mon, Jul 24, 2017 at 5:37 AM, Jan Kara <j...@suse.cz> wrote: [..] >> This approach would turn into a full fsync on the host. The question >> i

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

On Sun, Jul 23, 2017 at 11:10 AM, Rik van Riel <r...@redhat.com> wrote: > On Sun, 2017-07-23 at 09:01 -0700, Dan Williams wrote: >> [ adding Ross and Jan ] >> >> On Sun, Jul 23, 2017 at 7:04 AM, Rik van Riel <r...@redhat.com> >> wrote: >> > >>

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

On Wed, Jul 26, 2017 at 2:27 PM, Rik van Riel wrote: > On Wed, 2017-07-26 at 09:47 -0400, Pankaj Gupta wrote: >> > >> Just want to summarize here(high level): >> >> This will require implementing new 'virtio-pmem' device which >> presents >> a DAX address range(like pmem) to

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

On Wed, Jul 26, 2017 at 4:46 PM, Rik van Riel <r...@redhat.com> wrote: > On Wed, 2017-07-26 at 14:40 -0700, Dan Williams wrote: >> On Wed, Jul 26, 2017 at 2:27 PM, Rik van Riel <r...@redhat.com> >> wrote: >> > On Wed, 2017-07-26 at 09:47 -0400, Pankaj Gupta wro

Re: [Qemu-devel] [RFC] virtio-mem: paravirtualized memory

On Fri, Jul 28, 2017 at 4:09 AM, David Hildenbrand wrote: > Btw, I am thinking about the following addition to the concept: > > 1. Add a type to each virtio-mem device. > > This describes the type of the memory region we expose to the guest. > Initially, we could have RAM and

Re: [Qemu-devel] QEMU NVDIMM as type 7 in e820 table

On Fri, Jul 28, 2017 at 12:45 PM, Ross Zwisler <ross.zwis...@linux.intel.com> wrote: > On Fri, Jul 28, 2017 at 11:11:10AM -0700, Dan Williams wrote: >> On Fri, Jul 28, 2017 at 11:04 AM, Ross Zwisler [..] > [ Adding Linda & Toshi to see if they have an opinion. ] > >

Re: [Qemu-devel] QEMU NVDIMM as type 7 in e820 table

On Fri, Jul 28, 2017 at 11:04 AM, Ross Zwisler wrote: > I've been using the virtualized NVDIMM support in QEMU for testing, and I > noticed that the physical addresses used by the virtual NVDIMMs aren't present > in the guest's e820 table. > > Here is the e820 table

Re: [Qemu-devel] KVM "fake DAX" device flushing

[ adding nvdimm mailing list ] On Wed, May 10, 2017 at 8:56 AM, Pankaj Gupta wrote: > We are sharing initial project proposal for > 'KVM "fake DAX" device flushing' project for feedback. > Got the idea during discussion with 'Rik van Riel'. > > Also, request answers to

Re: [Qemu-devel] KVM "fake DAX" device flushing

On Thu, May 11, 2017 at 11:17 AM, Stefan Hajnoczi wrote: > On Wed, May 10, 2017 at 09:26:00PM +0530, Pankaj Gupta wrote: >> We are sharing initial project proposal for >> 'KVM "fake DAX" device flushing' project for feedback. >> Got the idea during discussion with 'Rik van

Re: [Qemu-devel] [PATCH] nvdimm acpi: fix region format interface code

On Wed, Jun 7, 2017 at 11:50 PM, Haozhong Zhang wrote: > On 06/08/17 14:40 +0800, Xiao Guangrong wrote: >> >> >> On 06/08/2017 01:06 PM, Haozhong Zhang wrote: >> > On 06/08/17 11:07 +0800, Xiao Guangrong wrote: >> > > >> > > >> > > On 06/07/2017 04:06 PM, Haozhong Zhang

Re: [Qemu-devel] [RESEND PATCH 1/2] nvdimm: warn if the backend is not a DAX device

On Thu, May 25, 2017 at 9:30 PM, Haozhong Zhang <haozhong.zh...@intel.com> wrote: > On 05/25/17 20:34 -0700, Dan Williams wrote: >> On Thu, May 25, 2017 at 7:32 PM, Haozhong Zhang >> <haozhong.zh...@intel.com> wrote: >> > Applications in Linux guest tha

Re: [Qemu-devel] [RESEND PATCH 2/2] hostmem-file: add an attribute 'align' to set its alignment

On Fri, May 26, 2017 at 12:16 AM, Haozhong Zhang wrote: > On 05/26/17 07:05 +, Marc-André Lureau wrote: >> Hi >> >> On Fri, May 26, 2017 at 10:51 AM Haozhong Zhang >> wrote: >> >> > On 05/26/17 06:39 +, Marc-André Lureau wrote: >> > >

Re: [Qemu-devel] [RESEND PATCH 1/2] nvdimm: warn if the backend is not a DAX device

On Fri, May 26, 2017 at 7:38 AM, Daniel P. Berrange <berra...@redhat.com> wrote: > On Thu, May 25, 2017 at 08:34:23PM -0700, Dan Williams wrote: >> On Thu, May 25, 2017 at 7:32 PM, Haozhong Zhang >> <haozhong.zh...@intel.com> wrote: >> > Applications in L

Re: [Qemu-devel] [RESEND PATCH 2/2] hostmem-file: add an attribute 'align' to set its alignment

On Fri, May 26, 2017 at 11:55 AM, Eduardo Habkost <ehabk...@redhat.com> wrote: > On Fri, May 26, 2017 at 07:24:26AM -0700, Dan Williams wrote: >> On Fri, May 26, 2017 at 12:16 AM, Haozhong Zhang >> <haozhong.zh...@intel.com> wrote: >> > On 05/26/17 07:05 +000

Re: [Qemu-devel] [RESEND PATCH 1/2] nvdimm: warn if the backend is not a DAX device

t;haozhong.zh...@intel.com> > Message-id: capcyv4hv2-zw8smcrtd0p_86kgr3dhovne+6t5sy2u7wxg3...@mail.gmail.com > --- > Cc: "Michael S. Tsirkin" <m...@redhat.com> > Cc: Igor Mammedov <imamm...@redhat.com> > Cc: Xiao Guangrong <guangrong.x...@gmail.com> &

Re: [Qemu-devel] [RESEND PATCH 1/2] nvdimm: warn if the backend is not a DAX device

On Tue, May 30, 2017 at 2:20 AM, Daniel P. Berrange <berra...@redhat.com> wrote: > On Fri, May 26, 2017 at 08:25:20AM -0700, Dan Williams wrote: >> On Fri, May 26, 2017 at 7:38 AM, Daniel P. Berrange <berra...@redhat.com> >> wrote: >> > On Thu, May 25, 2017 at

Re: [Qemu-devel] [RESEND PATCH 1/2] nvdimm: warn if the backend is not a DAX device

[ adding linux-fsdevel ] On Thu, Jun 1, 2017 at 5:00 AM, Xiao Guangrong wrote: > > > On 05/26/2017 10:32 AM, Haozhong Zhang wrote: > >> +static void nvdimm_check_dax(HostMemoryBackend *hostmem) >> +{ >> +char *mem_path = >> +

Re: [Qemu-devel] [RESEND PATCH 2/2] hostmem-file: add an attribute 'align' to set its alignment

On Tue, May 30, 2017 at 5:17 AM, Paolo Bonzini <pbonz...@redhat.com> wrote: > > > On 26/05/2017 16:24, Dan Williams wrote: >>> For DAX device only, QEMU can figure out the proper alignment by >>> itself. However, I'm not sure whether there are other non-DA

Re: [Qemu-devel] [PATCH v2 2/4] nvdimm: warn if the backend is not a DAX device

On Tue, Jun 6, 2017 at 12:22 AM, Haozhong Zhang wrote: > Applications in Linux guest that use device-dax never trigger flush > that can be trapped by KVM/QEMU. Meanwhile, if the host backend is not > device-dax, QEMU cannot guarantee the persistence of guest writes. >

Re: [Qemu-devel] [RFC 2/2] KVM: add virtio-pmem driver

On Mon, Oct 16, 2017 at 7:47 AM, Stefan Hajnoczi wrote: > On Fri, Oct 13, 2017 at 06:48:15AM -0400, Pankaj Gupta wrote: >> > On Thu, Oct 12, 2017 at 09:20:26PM +0530, Pankaj Gupta wrote: >> > > +static blk_qc_t virtio_pmem_make_request(struct request_queue *q, >> > > +

Re: [Qemu-devel] [RFC 2/2] KVM: add virtio-pmem driver

On Fri, Oct 13, 2017 at 2:44 AM, Stefan Hajnoczi wrote: > On Thu, Oct 12, 2017 at 09:20:26PM +0530, Pankaj Gupta wrote: [..] >> +#ifndef REQ_FLUSH >> +#define REQ_FLUSH REQ_PREFLUSH >> +#endif > > Is this out-of-tree kernel module compatibility stuff that can be > removed?

Re: [Qemu-devel] [RFC 1/2] pmem: Move reusable code to base header files

On Thu, Oct 12, 2017 at 8:50 AM, Pankaj Gupta wrote: > This patch moves common code to base header files > so that it can be used for both ACPI pmem and VIRTIO pmem > drivers. More common code needs to be moved out in future > based on functionality required for

Re: [Qemu-devel] [RFC 2/2] KVM: add virtio-pmem driver

On Thu, Oct 12, 2017 at 8:50 AM, Pankaj Gupta wrote: > This patch adds virtio-pmem driver for KVM guest. > Guest reads the persistent memory range information > over virtio bus from Qemu and reserves the range > as persistent memory. Guest also allocates a block >

Re: [Qemu-devel] [RFC 2/2] KVM: add virtio-pmem driver

On Thu, Oct 12, 2017 at 2:25 PM, Pankaj Gupta wrote: > >> > This patch adds virtio-pmem driver for KVM guest. >> > Guest reads the persistent memory range information >> > over virtio bus from Qemu and reserves the range >> > as persistent memory. Guest also allocates

Re: [Qemu-devel] [RFC 2/2] KVM: add virtio-pmem driver

On Thu, Oct 12, 2017 at 3:52 PM, Pankaj Gupta wrote: > Dan, > > I have a query regarding below patch [*]. My assumption is its halted > because of memory hotplug restructuring work? Anything I am missing > here? > > [*]

Re: [Qemu-devel] [RFC] KVM "fake DAX" device flushing

On Wed, Oct 11, 2017 at 11:51 AM, Pankaj Gupta wrote: > We are sharing the prototype version of 'fake DAX' flushing > interface for the initial feedback. This is still work in progress > and not yet ready for merging. > > Protoype right now just implements basic functionality

Re: [Qemu-devel] [RFC 2/2] KVM: add virtio-pmem driver

On Wed, Oct 18, 2017 at 6:03 AM, Stefan Hajnoczi wrote: > On Tue, Oct 17, 2017 at 04:30:41AM -0400, Pankaj Gupta wrote: >> >> > > Are you saying do it as existing i.e ACPI pmem like interface? >> > > The reason we have created this new driver is exiting pmem driver >> > > does

Re: [Qemu-devel] [RFC 2/2] KVM: add virtio-pmem driver

On Thu, Oct 19, 2017 at 1:01 AM, Christoph Hellwig <h...@infradead.org> wrote: > On Wed, Oct 18, 2017 at 08:51:37AM -0700, Dan Williams wrote: >> This use case is not "Persistent Memory". Persistent Memory is >> something you can map and make persistent wit

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

On Fri, Nov 24, 2017 at 4:40 AM, Pankaj Gupta wrote: [..] > 1] Expose vNVDIMM memory range to KVM guest. > >- Add flag in ACPI NFIT table for this new memory type. Do we need NVDIMM > spec > changes for this? Not a flag, but a new "Address Range Type GUID". See

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

On Wed, Nov 22, 2017 at 8:05 PM, Xiao Guangrong wrote: > > > On 11/22/2017 02:19 AM, Rik van Riel wrote: > >> We can go with the "best" interface for what >> could be a relatively slow flush (fsync on a >> file on ssd/disk on the host), which requires >> that the

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

On Tue, Nov 21, 2017 at 10:19 AM, Rik van Riel <r...@redhat.com> wrote: > On Fri, 2017-11-03 at 14:21 +0800, Xiao Guangrong wrote: >> On 11/03/2017 12:30 AM, Dan Williams wrote: >> > >> > Good point, I was assuming that the mmio flush interface would be >>

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

On Thu, Nov 2, 2017 at 1:50 AM, Xiao Guangrong wrote: [..] >> Yes, the GUID will specifically identify this range as "Virtio Shared >> Memory" (or whatever name survives after a bikeshed debate). The >> libnvdimm core then needs to grow a new region type that mostly

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

> On 11/01/2017 12:25 PM, Dan Williams wrote: [..] >> It's not persistent memory if it requires a hypercall to make it >> persistent. Unless memory writes can be made durable purely with cpu >> instructions it's dangerous for it to be treated as a PMEM range. >> Conside

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

On Sun, Nov 5, 2017 at 11:57 PM, Pankaj Gupta wrote: > > >> [..] >> >> Yes, the GUID will specifically identify this range as "Virtio Shared >> >> Memory" (or whatever name survives after a bikeshed debate). The >> >> libnvdimm core then needs to grow a new region type that

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

On Tue, Oct 31, 2017 at 12:13 AM, Xiao Guangrong <xiaoguangrong.e...@gmail.com> wrote: > > > On 07/27/2017 08:54 AM, Dan Williams wrote: > >>> At that point, would it make sense to expose these special >>> virtio-pmem areas to the guest in a slightly differe

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

On Tue, Oct 31, 2017 at 8:43 PM, Xiao Guangrong <xiaoguangrong.e...@gmail.com> wrote: > > > On 10/31/2017 10:20 PM, Dan Williams wrote: >> >> On Tue, Oct 31, 2017 at 12:13 AM, Xiao Guangrong >> <xiaoguangrong.e...@gmail.com> wrote: >>> >&g

Re: [Qemu-devel] Questions about vNVDIMM on qemu/KVM

On Thu, May 24, 2018 at 12:19 AM, Yasunori Goto wrote: >> On Tue, May 22, 2018 at 10:08 PM, Yasunori Goto >> wrote: >> > Hello, >> > >> > I'm investigating status of vNVDIMM on qemu/KVM, >> > and I have some questions about it. I'm glad if anyone

Re: [Qemu-devel] Questions about vNVDIMM on qemu/KVM

On Tue, May 22, 2018 at 10:08 PM, Yasunori Goto wrote: > Hello, > > I'm investigating status of vNVDIMM on qemu/KVM, > and I have some questions about it. I'm glad if anyone answer them. > > In my understanding, qemu/KVM has a feature to show NFIT for guest, > and it will

Re: [Qemu-devel] [RFC PATCH 1/1] nvdimm: let qemu requiring section alignment of pmem resource.

On Mon, Jun 11, 2018 at 9:26 AM, Stefan Hajnoczi wrote: > On Mon, Jun 11, 2018 at 06:54:25PM +0800, Zhang Yi wrote: >> Nvdimm driver use Memory hot-plug APIs to map it's pmem resource, >> which at a section granularity. >> >> When QEMU emulated the vNVDIMM device, decrease the label-storage, >>

Re: [Qemu-devel] [qemu PATCH v4 3/4] nvdimm, acpi: support NFIT platform capabilities

On Tue, Jun 5, 2018 at 9:42 AM, Ross Zwisler wrote: > On Tue, Jun 05, 2018 at 06:25:27PM +0300, Michael S. Tsirkin wrote: >> On Mon, May 21, 2018 at 10:32:02AM -0600, Ross Zwisler wrote: >> > Add a machine command line option to allow the user to control the Platform >> > Capabilities Structure

Re: [Qemu-devel] [qemu PATCH v4 3/4] nvdimm, acpi: support NFIT platform capabilities

On Tue, Jun 5, 2018 at 3:07 PM, Ross Zwisler wrote: > On Tue, Jun 05, 2018 at 09:37:25PM +0300, Michael S. Tsirkin wrote: >> On Tue, Jun 05, 2018 at 11:15:00AM -0700, Dan Williams wrote: >> > On Tue, Jun 5, 2018 at 9:42 AM, Ross Zwisler >> > wrote: >> > > O

Re: [Qemu-devel] [qemu PATCH v4 3/4] nvdimm, acpi: support NFIT platform capabilities

On Wed, Jun 6, 2018 at 4:20 PM, Elliott, Robert (Persistent Memory) wrote: > >> > Okay, we can move to the symbolic names. Do you want them to be that >> long, or >> > would: >> > >> > nvdimm-cap-cpu >> > nvdimm-cap-mem-ctrl >> > nvdimm-cap-mirroring >> >> Wait, why is mirroring part of this? >

Re: [Qemu-devel] [RFC v2 2/2] pmem: device flush over VIRTIO

On Thu, Apr 26, 2018 at 9:40 AM, Pankaj Gupta wrote: > >> >> On Wed, Apr 25, 2018 at 04:54:14PM +0530, Pankaj Gupta wrote: >> > This patch adds functionality to perform >> > flush from guest to hosy over VIRTIO >> > when 'ND_REGION_VIRTIO'flag is set on >> > nd_negion. Flag is

Re: [Qemu-devel] [RFC 2/2] KVM: add virtio-pmem driver

On Fri, Oct 20, 2017 at 1:00 AM, Christoph Hellwig <h...@infradead.org> wrote: > On Thu, Oct 19, 2017 at 11:21:26AM -0700, Dan Williams wrote: >> The difference is that nvdimm_flush() is not mandatory, and that the >> platform will automatically perform the sam

Re: [Qemu-devel] [RFC 2/2] KVM: add virtio-pmem driver

On Fri, Oct 20, 2017 at 9:06 AM, Christoph Hellwig <h...@infradead.org> wrote: > On Fri, Oct 20, 2017 at 08:05:09AM -0700, Dan Williams wrote: >> Right, that's the same recommendation I gave. >> >> https://lists.gnu.org/archive/html/qemu-devel/2017-07/msg08404

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

On Fri, Jan 12, 2018 at 10:23 PM, Pankaj Gupta wrote: > > Hello Dan, > >> Not a flag, but a new "Address Range Type GUID". See section "5.2.25.2 >> System Physical Address (SPA) Range Structure" in the ACPI 6.2A >> specification. Since it is a GUID we could define a Linux

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

On Thu, Jan 18, 2018 at 8:53 AM, David Hildenbrand wrote: > On 24.11.2017 13:40, Pankaj Gupta wrote: >> >> Hello, >> >> Thank you all for all the useful suggestions. >> I want to summarize the discussions so far in the >> thread. Please see below: >> > >> We can go with

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

On Thu, Jan 18, 2018 at 10:54 AM, Pankaj Gupta wrote: > >> >> >> I'd like to emphasize again, that I would prefer a virtio-pmem only >> >> solution. >> >> >> >> There are architectures out there (e.g. s390x) that don't support >> >> NVDIMMs - there is no HW interface to expose

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

On Thu, Jan 18, 2018 at 9:48 AM, David Hildenbrand wrote: >>> I'd like to emphasize again, that I would prefer a virtio-pmem only >>> solution. >>> >>> There are architectures out there (e.g. s390x) that don't support >>> NVDIMMs - there is no HW interface to expose any such

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

On Thu, Jan 18, 2018 at 11:51 AM, David Hildenbrand wrote: > >>> 1] Existing pmem driver & virtio for region discovery: >>> - >>> Use existing pmem driver which is tightly coupled with concepts of >>> namespaces, labels

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

On Thu, Jan 18, 2018 at 11:36 AM, Pankaj Gupta wrote: > >> >> On Thu, Jan 18, 2018 at 10:54 AM, Pankaj Gupta wrote: >> > >> >> >> >> >> I'd like to emphasize again, that I would prefer a virtio-pmem only >> >> >> solution. >> >> >> >> >> >> There are

Re: [Qemu-devel] [PATCH v4 0/6] nvdimm: support MAP_SYNC for memory-backend-file

On Tue, Jan 30, 2018 at 10:02 PM, Haozhong Zhang wrote: > Linux 4.15 introduces a new mmap flag MAP_SYNC, which can be used to > guarantee the write persistence to mmap'ed files supporting DAX (e.g., > files on ext4/xfs file system mounted with '-o dax'). Wait, MAP_SYNC

Re: [Qemu-devel] [PATCH v4 0/6] nvdimm: support MAP_SYNC for memory-backend-file

On Wed, Jan 31, 2018 at 4:02 PM, Haozhong Zhang <haozhong.zh...@intel.com> wrote: > On 01/31/18 14:25 -0800, Dan Williams wrote: >> On Tue, Jan 30, 2018 at 10:02 PM, Haozhong Zhang >> <haozhong.zh...@intel.com> wrote: >> > Linux 4.15 introduces a new m

Re: [Qemu-devel] [PATCH v4 0/6] nvdimm: support MAP_SYNC for memory-backend-file

On Wed, Jan 31, 2018 at 4:24 PM, Haozhong Zhang <haozhong.zh...@intel.com> wrote: > On 01/31/18 16:08 -0800, Dan Williams wrote: >> On Wed, Jan 31, 2018 at 4:02 PM, Haozhong Zhang >> <haozhong.zh...@intel.com> wrote: >> > On 01/31/18 14:25 -0800, Dan Willia

Re: [Qemu-devel] [PATCH v4 0/6] nvdimm: support MAP_SYNC for memory-backend-file

[ adding Michal and lsf-pci ] On Wed, Jan 31, 2018 at 7:02 PM, Dan Williams <dan.j.willi...@intel.com> wrote: > On Wed, Jan 31, 2018 at 6:29 PM, Haozhong Zhang > <haozhong.zh...@intel.com> wrote: >> + vfio maintainer Alex Williamson in case my understanding of vfio is &

Re: [Qemu-devel] [PATCH v4 0/6] nvdimm: support MAP_SYNC for memory-backend-file

On Wed, Jan 31, 2018 at 6:29 PM, Haozhong Zhang <haozhong.zh...@intel.com> wrote: > + vfio maintainer Alex Williamson in case my understanding of vfio is > incorrect. > > On 01/31/18 16:32 -0800, Dan Williams wrote: >> On Wed, Jan 31, 2018 at 4:24 PM, Haozhong Zhang >

Re: [Qemu-devel] [PATCH v2 7/8] migration/ram: ensure write persistence on loading compressed pages to PMEM

On Wed, Feb 7, 2018 at 5:24 AM, Dr. David Alan Gilbert wrote: > * Haozhong Zhang (haozhong.zh...@intel.com) wrote: >> On 02/07/18 13:03 +, Dr. David Alan Gilbert wrote: >> > * Haozhong Zhang (haozhong.zh...@intel.com) wrote: >> > > On 02/07/18 11:54 +, Dr. David Alan

Re: [Qemu-devel] [PATCH v2 7/8] migration/ram: ensure write persistence on loading compressed pages to PMEM

On Wed, Feb 7, 2018 at 10:08 AM, Dr. David Alan Gilbert <dgilb...@redhat.com> wrote: > * Dan Williams (dan.j.willi...@intel.com) wrote: >> On Wed, Feb 7, 2018 at 5:24 AM, Dr. David Alan Gilbert >> <dgilb...@redhat.com> wrote: >> > * Haozhong Zhang (haozhong.zh

Re: [Qemu-devel] [PATCH v2 7/8] migration/ram: ensure write persistence on loading compressed pages to PMEM

On Wed, Feb 7, 2018 at 10:37 AM, Dr. David Alan Gilbert <dgilb...@redhat.com> wrote: > * Dan Williams (dan.j.willi...@intel.com) wrote: >> On Wed, Feb 7, 2018 at 10:08 AM, Dr. David Alan Gilbert >> <dgilb...@redhat.com> wrote: >> > * Dan Williams (dan.j.willi...

Re: [Qemu-devel] [PATCH] hw/acpi-build: build SRAT memory affinity structures for NVDIMM

On Tue, Feb 20, 2018 at 6:10 AM, Igor Mammedov wrote: > On Sat, 17 Feb 2018 14:31:35 +0800 > Haozhong Zhang wrote: > >> ACPI 6.2A Table 5-129 "SPA Range Structure" requires the proximity >> domain of a NVDIMM SPA range must match with corresponding

Re: [Qemu-devel] [PATCH] hw/acpi-build: build SRAT memory affinity structures for NVDIMM

On Wed, Feb 21, 2018 at 5:55 AM, Igor Mammedov <imamm...@redhat.com> wrote: > On Tue, 20 Feb 2018 17:17:58 -0800 > Dan Williams <dan.j.willi...@intel.com> wrote: > >> On Tue, Feb 20, 2018 at 6:10 AM, Igor Mammedov <imamm...@redhat.com> wrote: >> > On Sat

Re: [Qemu-devel] [RFC v2 1/2] virtio: add pmem driver

On Wed, Apr 25, 2018 at 4:24 AM, Pankaj Gupta wrote: > This patch adds virtio-pmem driver for KVM > guest. Minor nit, please expand your changelog line wrapping to 72 columns. > > Guest reads the persistent memory range > information from Qemu over VIRTIO and registers > it

Re: [Qemu-devel] [RFC v2 2/2] pmem: device flush over VIRTIO

On Wed, Apr 25, 2018 at 4:24 AM, Pankaj Gupta wrote: > This patch adds functionality to perform > flush from guest to hosy over VIRTIO > when 'ND_REGION_VIRTIO'flag is set on > nd_negion. Flag is set by 'virtio-pmem' > driver. > > Signed-off-by: Pankaj Gupta

Re: [Qemu-devel] [RFC v2 1/2] virtio: add pmem driver

[ adding Jeff directly since he has also been looking at infrastructure to track when MAP_SYNC should be disabled ] On Wed, Apr 25, 2018 at 7:21 AM, Dan Williams <dan.j.willi...@intel.com> wrote: > On Wed, Apr 25, 2018 at 4:24 AM, Pankaj Gupta <pagu...@redhat.com> wrote: >> T

Re: [Qemu-devel] RFC: altering the NVDIMM acpi table

On Mon, Apr 23, 2018 at 1:35 PM, Schmauss, Erik wrote: > Hello, > > I work on ACPICA and we have recently made changes to the behavior of > the Linux AML interpreter to match other OS implementations. After > sending the patches to upstream Linux, we have identified that

Re: [Qemu-devel] [PATCH v2 5/7] ACPICA: Integrate package handling with module-level code

On Mon, Apr 16, 2018 at 5:05 PM, Schmauss, Erik <erik.schma...@intel.com> wrote: > >> -Original Message- >> From: linux-acpi-ow...@vger.kernel.org [mailto:linux-acpi- >> ow...@vger.kernel.org] On Behalf Of Dan Williams >> Sent: Monday, April 16, 2

Re: [Qemu-devel] [PATCH v2 5/7] ACPICA: Integrate package handling with module-level code

On Mon, Apr 16, 2018 at 4:15 PM, Schmauss, Erik wrote: > [ trimming ] >> >> Rafael, we may want to hold back on the module-level code changes >> >> (the patches below) for rc1. Between this and the strange _TSS issue, >> >> it seems like there are a few more things to

  1   2   >