On Fri, Apr 06, 2018 at 03:36:03PM +0300, Oleksandr Andrushchenko wrote:
> On 04/06/2018 02:57 PM, Gerd Hoffmann wrote:
> > Hi,
> >
> >>>I fail to see any common ground for xen-zcopy and udmabuf ...
> >>Does the above mean you can assume that xen-zcopy and udmabuf
> >>can co-exist as two
On Tue, Apr 10, 2018 at 09:37:53AM +0300, Oleksandr Andrushchenko wrote:
> On 04/06/2018 09:57 PM, Dongwon Kim wrote:
> >On Fri, Apr 06, 2018 at 03:36:03PM +0300, Oleksandr Andrushchenko wrote:
> >>On 04/06/2018 02:57 PM, Gerd Hoffmann wrote:
> >>> Hi,
> &g
(changed subject and decoupling from udmabuf thread)
On Wed, Apr 11, 2018 at 08:59:32AM +0300, Oleksandr Andrushchenko wrote:
> On 04/10/2018 08:26 PM, Dongwon Kim wrote:
> >On Tue, Apr 10, 2018 at 09:37:53AM +0300, Oleksandr Andrushchenko wrote:
> >>On 04/06/2018 09:57 PM,
Hi Gerd,
Our goal is to block virtio-gpu driver running on the guest from writing
on the buffer that hasn't been completely blitted yet. If we do
graphic_hw_gl_block, it will block the next commands from being processed but
won't stop the guest fill the scanout buffers and send commands, I think.
An old esurface should be destroyed and set to be NULL when doing
un-tab and re-tab so that a new esurface an context can be created
for the window widget that those will be bound to.
Signed-off-by: Dongwon Kim
Signed-off-by: Khairul Anuar Romli
---
ui/gtk.c | 16
1 file
gd_draw_event shouldn't try to repaint if surface does not exist
for the VC.
Signed-off-by: Dongwon Kim
---
ui/gtk.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/ui/gtk.c b/ui/gtk.c
index bfb95f3b4b..0a38deedc7 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -756,6 +756,9 @@ static gboolean
Making the vc->gfx.ectx current before handling textures
associated with it
Signed-off-by: Dongwon Kim
---
ui/gtk-egl.c | 8
1 file changed, 8 insertions(+)
diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c
index 2a2e6d3a17..32516b806c 100644
--- a/ui/gtk-egl.c
+++ b/ui/gtk-egl.c
@@ -12
eb_fb_blit needs more parameters which describe x and y offsets and width
and height of the actual scanout to specify the size and cordination of
partial image to blit in the guest fb in case the guest fb contains multiple
display outputs.
Signed-off-by: Dongwon Kim
---
hw/display/virtio-gpu
surfaces but
not in case of blob-resource (zero copy).
This code change lets the qemu split this one large surface data into multiple
in case of blob-resource as well so that each sub frame then can be blitted
properly to each scanout.
Signed-off-by: Dongwon Kim
---
hw/display/virtio-gpu-udmabuf.c | 19
If guest fb is backed by dmabuf (blob-resource), the texture bound to the
old context needs to be recreated in case the egl is re-initialized (e.g.
new window for vc is created in case of detaching/reattaching of the tab)
Signed-off-by: Dongwon Kim
---
ui/gtk-egl.c | 4
1 file changed, 4
iteration and the flag.
Cc: Gerd Hoffmann
Cc: Vivek Kasireddy
Signed-off-by: Dongwon Kim
---
hw/display/virtio-gpu-udmabuf.c | 3 ++
include/ui/console.h| 3 ++
ui/gtk-egl.c| 44 +++
ui/gtk-gl-area.c| 53
This series fixes several problems happening while doing VC untab/tab.
Dongwon Kim (4):
ui/gtk-egl: un-tab and re-tab should destroy egl surface and context
ui/gtk-egl: make sure the right context is set as the current
ui/gtk: gd_draw_event returns FALSE when no cairo surface is bound
ui
Making the vc->gfx.ectx current before handling texture
associated with it
Cc: Gerd Hoffmann
Signed-off-by: Dongwon Kim
---
ui/gtk-egl.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c
index 72ce5e1f8f..7c9629d6cc 100644
--- a/ui/gtk-egl.c
+++ b/ui/
An old esurface should be destroyed and set to be NULL when doing
un-tab and re-tab so that a new esurface an context can be created
for the window widget that those will be bound to.
Cc: Gerd Hoffmann
Signed-off-by: Dongwon Kim
Signed-off-by: Khairul Anuar Romli
---
ui/gtk.c | 16
ure
(Vivek Kasireddy)
Cc: Gerd Hoffmann
Signed-off-by: Dongwon Kim
---
ui/gtk-egl.c | 4
1 file changed, 4 insertions(+)
diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c
index 7c9629d6cc..8c55ed18fb 100644
--- a/ui/gtk-egl.c
+++ b/ui/gtk-egl.c
@@ -142,6 +142,10 @@ void gd_egl_refr
gd_draw_event shouldn't try to repaint if surface does not exist
for the VC.
Cc: Gerd Hoffmann
Signed-off-by: Dongwon Kim
---
ui/gtk.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/ui/gtk.c b/ui/gtk.c
index 92df3d4c5c..5346c331f4 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -778,6 +778,9
On Fri, Sep 17, 2021 at 12:02:02PM +0200, Gerd Hoffmann wrote:
> Hi,
>
> > +bool draw_submitted;
> > +QemuMutex mutex;
>
> Why the mutex? I think all the code runs while holding the BQL so it
> should be serialized.
Guest drawing process using blob is serialized
Cc: Vivek Kasireddy
Signed-off-by: Dongwon Kim
---
ui/egl-helpers.c | 25 +
1 file changed, 21 insertions(+), 4 deletions(-)
diff --git a/ui/egl-helpers.c b/ui/egl-helpers.c
index 385a3fa752..3a88245b67 100644
--- a/ui
width and
height
Cc: Gerd Hoffmann
Cc: Vivek Kasireddy
Signed-off-by: Dongwon Kim
---
hw/display/virtio-gpu-udmabuf.c | 22 ++
hw/display/virtio-gpu.c | 4 ++--
include/hw/virtio/virtio-gpu.h | 5 +++--
include/ui/console.h| 4
4 files changed
msg
Cc: Gerd Hoffmann
Cc: Vivek Kasireddy
Signed-off-by: Dongwon Kim
---
hw/display/virtio-gpu-udmabuf.c | 2 +-
include/ui/console.h| 1 +
ui/gtk-egl.c| 40 ++-
ui/gtk-gl-area.c| 49 -
4
On Fri, Sep 17, 2021 at 12:02:02PM +0200, Gerd Hoffmann wrote:
> Hi,
>
> > +bool draw_submitted;
> > +QemuMutex mutex;
>
> Why the mutex? I think all the code runs while holding the BQL so it
> should be serialized.
Gerd, I did more experiment and verified mutex is actually not
The code should check the opposite condition of res->iov because it will be null
if virtio_gpu_create_mapping_iov fails and actually this checking is not even
required because checking on ret covers all failing cases.
Signed-off-by: Dongwon Kim
---
hw/display/virtio-gpu.c | 2 +-
1 file chan
closing fence_fd for the current dmabuf.
Cc: Gerd Hoffmann
Cc: Vivek Kasireddy
Signed-off-by: Dongwon Kim
---
ui/gtk.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ui/gtk.c b/ui/gtk.c
index 7abe1a69d8..2a3a9db13f 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -589,11 +589,11
will make the Qemu
window full-screened on the targetted monitor.
Cc: Gerd Hoffmann
Cc: Vivek Kasireddy
Cc: sweeaun
Cc: Khairul Anuar Romli
Signed-off-by: Dongwon Kim
---
qapi/ui.json| 7 ++-
qemu-options.hx | 2 +-
ui/gtk.c| 10 ++
3 files changed, 17 insertions(+), 2
: Khairul Anuar Romli
Signed-off-by: Dongwon Kim
---
qapi/ui.json| 6 +-
qemu-options.hx | 2 +-
ui/gtk.c| 8
3 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/qapi/ui.json b/qapi/ui.json
index d7567ac866..9dc1ad284f 100644
--- a/qapi/ui.json
+++ b/qapi/ui.json
From: Satyeshwar Singh
Previously, the large modes (>1080p) that were generated by Qemu in its EDID
were all 50 Hz. If we provide them to a Guest OS and the user selects
one of these modes, then the OS by default only gets 50 FPS. This is
especially true for Windows OS. With this patch, we are
ue, Nov 02, 2021 at 02:51:54PM +0100, Gerd Hoffmann wrote:
> On Mon, Jul 26, 2021 at 02:59:49PM -0700, Dongwon Kim wrote:
> > When guest is running Linux/X11 with extended multiple displays mode
> > enabled,
> > the guest shares one scanout resource each time containing whole
Making the vc->gfx.ectx current before handling texture
associated with it
Cc: Gerd Hoffmann
Signed-off-by: Dongwon Kim
---
ui/gtk-egl.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c
index 72ce5e1f8f..7c9629d6cc 100644
--- a/ui/gtk-egl.c
+++ b/ui/
ure
(Vivek Kasireddy)
Cc: Gerd Hoffmann
Signed-off-by: Dongwon Kim
---
ui/gtk-egl.c | 4
1 file changed, 4 insertions(+)
diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c
index 7c9629d6cc..8c55ed18fb 100644
--- a/ui/gtk-egl.c
+++ b/ui/gtk-egl.c
@@ -142,6 +142,10 @@ void gd_egl_refr
An old esurface should be destroyed and set to be NULL when doing
un-tab and re-tab so that a new esurface an context can be created
for the window widget that those will be bound to.
v2: enabling opengl specific routines only when CONFIG_OPENGL is set
Cc: Gerd Hoffmann
Signed-off-by: Dongwon
gd_draw_event shouldn't try to repaint if surface does not exist
for the VC.
Cc: Gerd Hoffmann
Signed-off-by: Dongwon Kim
---
ui/gtk.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/ui/gtk.c b/ui/gtk.c
index 8da673c18c..d2892ea6b4 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -778,6 +778,9
(previously position/size
parameters were given to egl_fb_blit separately)
(Vivek Kasireddy)
changed the commit message as there is no interface change to egl_fb_blit
Cc: Gerd Hoffmann
Cc: Vivek Kasireddy
Signed-off-by: Dongwon Kim
---
ui/egl-helpers.c | 25
An old esurface should be destroyed and set to be NULL when doing
un-tab and re-tab so that a new esurface an context can be created
for the window widget that those will be bound to.
v2: enabling opengl specific routines only when CONFIG_OPENGL is set
Cc: Gerd Hoffmann
Signed-off-by: Dongwon
width and
height
v3: updating stub function of virtio_gpu_update_dmabuf to match the type
Cc: Gerd Hoffmann
Cc: Vivek Kasireddy
Signed-off-by: Dongwon Kim
---
hw/display/virtio-gpu-udmabuf-stubs.c | 3 ++-
hw/display/virtio-gpu-udmabuf.c | 22 ++
hw/display/virtio
ure
(Vivek Kasireddy)
Cc: Gerd Hoffmann
Signed-off-by: Dongwon Kim
---
ui/gtk-egl.c | 4
1 file changed, 4 insertions(+)
diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c
index 2164995098..f2026e4b5c 100644
--- a/ui/gtk-egl.c
+++ b/ui/gtk-egl.c
@@ -155,6 +155,10 @@ void gd_egl_refr
Making the vc->gfx.ectx current before handling texture
associated with it
Cc: Gerd Hoffmann
Signed-off-by: Dongwon Kim
---
ui/gtk-egl.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c
index e912b20075..2164995098 100644
--- a/ui/gtk-egl.c
+++ b/ui/
gd_draw_event shouldn't try to repaint if surface does not exist
for the VC.
Cc: Gerd Hoffmann
Signed-off-by: Dongwon Kim
---
ui/gtk.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/ui/gtk.c b/ui/gtk.c
index 8da673c18c..d2892ea6b4 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -778,6 +778,9
021 at 05:41:10PM -0700, Dongwon Kim wrote:
> > I double-checked the patch and also tried to build with --disable-opengl
> > but couldn't find any issue. Can you please give me some hint? Like
> > build errors you saw. What are changed by the patch are pretty much
> > limi
On Tue, Jul 20, 2021 at 03:42:16PM +0200, Thomas Huth wrote:
> On 19/07/2021 23.41, Dongwon Kim wrote:
> > With "detach-all=on" for display, all VCs are detached from the beginning.
> > This is useful when there are multiple displays assigned to a guest OS.
>
&g
fb in case the guest fb contains multiple
> > display outputs.
> >
> > Signed-off-by: Dongwon Kim
> > ---
> > hw/display/virtio-gpu-udmabuf.c | 4 ++--
> > include/ui/egl-helpers.h| 2 +-
> > ui/egl-headless.c | 2 +-
>
t; > multiple
> > in case of blob-resource as well so that each sub frame then can be blitted
> > properly to each scanout.
> >
> > Signed-off-by: Dongwon Kim
> > ---
> > hw/display/virtio-gpu-udmabuf.c | 19 +++
> > hw/displ
With "detach-all=on" for display, all VCs are detached from the beginning.
This is useful when there are multiple displays assigned to a guest OS.
Signed-off-by: Dongwon Kim
Signed-off-by: Khairul Anuar Romli
---
qapi/ui.json | 4 +++-
ui/gtk.c | 7 +++
2 files changed, 10
Specify location and size of detached window based on top level window's
location and size info when detachment happens.
Signed-off-by: Dongwon Kim
---
ui/gtk.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/ui/gtk.c b/ui/gtk.c
index a07e5a049e..9b4e85624a 100644
--- a/ui
. Berrangé wrote:
> On Mon, Jul 26, 2021 at 03:25:49PM -0700, Dongwon Kim wrote:
> > With a display option, "show-fps=on", qemu adds a status bar and print
> > following performance numbers on the bar,
> >
> > ups = update per seconds - the rate the guest scanout is
With "detach-all=on" for display, all VCs are detached from the beginning.
This is useful when there are multiple displays assigned to a guest OS.
v2: Move "detach-all" option to under DisplayGTK as it's GTK specific
(Thomas Huth)
Signed-off-by: Dongwon Kim
Signed-o
position and size
parameters programmed in dmabuf structure (previously position/size
parameters were given to egl_fb_blit separately)
(Vivek Kasireddy)
changed the commit message as there is no interface change to egl_fb_blit
Signed-off-by: Dongwon Kim
---
include/ui/egl-helpers.h
width and
height
Signed-off-by: Dongwon Kim
---
hw/display/virtio-gpu-udmabuf.c | 21 ++---
hw/display/virtio-gpu.c | 4 ++--
include/hw/virtio/virtio-gpu.h | 5 +++--
include/ui/console.h| 4
stubs/virtio-gpu-udmabuf.c | 3 ++-
5 files changed
d to count # frames
and calculate ups and fps every 100 frames or guest scanout updates.
Signed-off-by: Dongwon Kim
---
include/ui/console.h | 4 +++-
include/ui/gtk.h | 2 ++
qapi/ui.json | 6 +-
ui/console.c | 6 ++
ui/gtk.c
For FPS calculation, gd_gl_frame_counter is called at every
draw(gtk-gl-area) or swap(gtk-egl) activity.
Signed-off-by: Dongwon Kim
---
ui/gtk-egl.c | 2 ++
ui/gtk-gl-area.c | 1 +
2 files changed, 3 insertions(+)
diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c
index 2a2e6d3a17..ac56f5b9f4 100644
dpy_gl_frame_counter needs to be called for guest scanout frame count
to calculate and display the performance figure - ups, the guest FB
update per seconds.
Signed-off-by: Dongwon Kim
---
hw/display/virtio-gpu.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/display/virtio-gpu.c b/hw
: sweeaun
Cc: Khairul Anuar Romli
Signed-off-by: Dongwon Kim
---
qapi/ui.json| 6 +-
qemu-options.hx | 2 +-
ui/gtk.c| 8
3 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/qapi/ui.json b/qapi/ui.json
index d7567ac866..c2c677bb1c 100644
--- a/qapi/ui.json
When turning on or off full-screen menu, all detached windows should
be full-screened or un-full-screened altogether.
Cc: Marc-André Lureau
Signed-off-by: Dongwon Kim
---
ui/gtk.c | 44 ++--
1 file changed, 34 insertions(+), 10 deletions(-)
diff --git
Scale factor needs to be applied when calculating width/height of the
GTK windows.
Cc: Marc-André Lureau
Signed-off-by: Dongwon Kim
---
ui/gtk-egl.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c
index a1060fd80f..45c7544337
hich would be useful if someone wants to directly full-screen individual
guest scanouts to host's physical displays.
Dongwon Kim (2):
ui/gtk: detach VCS for additional guest displays
ui/gtk: a new array param monitor to specify the target displays
qapi/ui.json| 7 ++-
qemu-options.hx |
detached window, 2nd detached window, Main window]
Usage example: -display gtk,monitor.0=0,monitor.1=1.
Cc: Daniel P. Berrangé
Cc: Markus Armbruster
Cc: Philippe Mathieu-Daudé
Cc: Paolo Bonzini
Cc: Gerd Hoffmann
Cc: Vivek Kasireddy
Signed-off-by: Dongwon Kim
---
qapi/ui.json| 7
Dropping this.
New series with suggested changes from reviewers can be found at
https://lists.nongnu.org/archive/html/qemu-devel/2022-05/msg06245.html
On Thu, Apr 28, 2022 at 04:13:01PM -0700, Dongwon Kim wrote:
> This patch series introduces two new gtk optional parameters, monitor
> and
Kasireddy
Signed-off-by: Dongwon Kim
---
ui/gtk.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/ui/gtk.c b/ui/gtk.c
index c57c36749e..abfcf48547 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -2304,6 +2304,8 @@ static void gtk_display_init(DisplayState *ds,
DisplayOptions
Hi Markus,
On Mon, Jun 20, 2022 at 09:07:04AM +0200, Markus Armbruster wrote:
> Dongwon Kim writes:
>
> > New integer array parameter, 'monitor' is for specifying the target
> > displays where individual QEMU windows are placed upon launching.
> >
> > The arra
On Thu, Jun 30, 2022 at 05:19:26PM +0200, Markus Armbruster wrote:
> Dongwon Kim writes:
>
> > New integer array parameter, 'monitor' is for specifying the target
> > monitors where individual GTK windows are placed upon launching.
> >
> > Monitor numbers in the arr
Thanks, yeah, I will remove '-' and resubmitt the patch.
On Fri, Jul 01, 2022 at 11:58:48AM +0200, Gerd Hoffmann wrote:
> Hi,
>
> > > +# @monitor: Array of numbers, each of which represents physical
> > > +# monitor where GTK window containing a given VC will be
> > > +#
making sure detached window's size same as original surface size
Dongwon Kim (2):
ui/gtk: detach VCS for additional guest displays (v4)
ui/gtk: a new array param monitor to specify the target displays (v4)
qapi/ui.json| 9 -
qemu-options.hx | 3 ++-
ui/gtk.c| 41 ++
Signed-off-by: Dongwon Kim
---
ui/gtk.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/ui/gtk.c b/ui/gtk.c
index 2a791dd2aa..e6878c3209 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -1361,6 +1361,11 @@ static void gd_menu_untabify(GtkMenuItem *item, void
*opaque
in the region
of corresponding monitors.
Usage: -display gtk,monitor.=,..
ex)-display gtk,monitor.0=1,monitor.1=0
Cc: Daniel P. Berrangé
Cc: Markus Armbruster
Cc: Philippe Mathieu-Daudé
Cc: Paolo Bonzini
Cc: Gerd Hoffmann
Cc: Vivek Kasireddy
Signed-off-by: Dongwon Kim
---
qapi/ui.json
-by: Dongwon Kim
---
ui/gtk.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/ui/gtk.c b/ui/gtk.c
index 2a791dd2aa..e6878c3209 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -1361,6 +1361,11 @@ static void gd_menu_untabify(GtkMenuItem *item, void
*opaque
: Daniel P. Berrangé
Cc: Markus Armbruster
Cc: Philippe Mathieu-Daudé
Cc: Paolo Bonzini
Cc: Gerd Hoffmann
Cc: Vivek Kasireddy
Signed-off-by: Dongwon Kim
---
qapi/ui.json| 9 -
qemu-options.hx | 3 ++-
ui/gtk.c| 31 +--
3 files changed, 39
d Hoffmann)
- making sure detached window's size same as original surface size
(Daniel P. Berrangé)
Dongwon Kim (2):
ui/gtk: detach VCS for additional guest displays (v3)
ui/gtk: a new array param monitor to specify the target displays (v3)
qapi/ui.json| 7 ++-
qemu-options.hx |
mary guest display so we won't need n_gfx_vcs
(Gerd Hoffmann)
- making sure detached window's size same as original surface size
(Daniel P. Berrangé)
Dongwon Kim (2):
ui/gtk: detach VCS for additional guest displays (v2)
ui/gtk: a new array param monitor to specify the target displays (
detached window, 2nd detached window, Main window]
Usage example: -display gtk,monitor.0=0,monitor.1=1.
Cc: Daniel P. Berrangé
Cc: Markus Armbruster
Cc: Philippe Mathieu-Daudé
Cc: Paolo Bonzini
Cc: Gerd Hoffmann
Cc: Vivek Kasireddy
Signed-off-by: Dongwon Kim
---
qapi/ui.json| 7
-off-by: Dongwon Kim
---
ui/gtk.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/ui/gtk.c b/ui/gtk.c
index 2a791dd2aa..e6878c3209 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -1361,6 +1361,11 @@ static void gd_menu_untabify(GtkMenuItem *item, void
*opaque
On Tue, Jul 19, 2022 at 01:15:26PM +0200, Gerd Hoffmann wrote:
> On Fri, May 06, 2022 at 10:09:30AM -0700, Dongwon Kim wrote:
> > On Fri, May 06, 2022 at 11:53:22AM +0400, Marc-André Lureau wrote:
> > > Hi
> > >
> > > On Fri, May 6, 2022 at 1:46 AM Dongwon Kim
because the first virtual console (vc[0])
is always in graphic mode so we can simply detach all other graphic mode
virtual consoles.
- making sure detached window's size same as original surface size
Dongwon Kim (2):
ui/gtk: detach VCs for additional guest displays
ui/gtk: a new a
in the region
of corresponding monitors.
Usage: -display gtk,monitor.=,..
ex)-display gtk,monitor.0=1,monitor.1=0
Cc: Daniel P. Berrangé
Cc: Markus Armbruster
Cc: Philippe Mathieu-Daudé
Cc: Paolo Bonzini
Cc: Gerd Hoffmann
Cc: Vivek Kasireddy
Signed-off-by: Dongwon Kim
---
qapi/ui.json
Signed-off-by: Dongwon Kim
---
ui/gtk.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/ui/gtk.c b/ui/gtk.c
index 2a791dd2aa..e6878c3209 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -1361,6 +1361,11 @@ static void gd_menu_untabify(GtkMenuItem *item, void
*opaque
On Tue, Jul 12, 2022 at 08:11:08AM +0200, Markus Armbruster wrote:
> Dongwon Kim writes:
>
> > New integer array parameter, 'monitor' is for specifying the target
> > monitors where individual GTK windows are placed upon launching.
> >
> > Monitor numbers in the arr
On Fri, May 06, 2022 at 05:34:21PM +0100, Daniel P. Berrangé wrote:
> On Tue, May 03, 2022 at 04:33:48PM -0700, Dongwon Kim wrote:
> > I saw windows, especially, third and fourth ones are 1/4 size of
> > the first when detached regardless of resolutions.
> >
> > And
On Fri, May 06, 2022 at 11:53:22AM +0400, Marc-André Lureau wrote:
> Hi
>
> On Fri, May 6, 2022 at 1:46 AM Dongwon Kim wrote:
>
> > It only needs to update the scanouts containing the rect area
> > coming with the resource-flush request from the guest.
> >
> >
ened
on monitor 0.)
v2: update Since version to 7.1
Cc: Philippe Mathieu-Daudé
Cc: Paolo Bonzini
Cc: Gerd Hoffmann
Cc: Vivek Kasireddy
Signed-off-by: Dongwon Kim
---
qapi/ui.json | 5 -
ui/gtk.c | 47 ---
2 files changed, 48 insertions(+
: Gerd Hoffmann
Cc: Vivek Kasireddy
Signed-off-by: Dongwon Kim
---
qapi/ui.json| 6 +-
qemu-options.hx | 2 +-
ui/gtk.c| 8
3 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/qapi/ui.json b/qapi/ui.json
index 059302a5ef..ddcea7349b 100644
--- a/qapi/ui.json
en
multiple displays (max_output = n) are assigned to the guest os and
each guest display needs to be full-screened to certain physical monitor.
This can be achieved when these new parameters are properly configured
together with existing full-screen option set to true.
Dongwon Kim (3):
ui/gt
Specify location and size of detached window based on top level
window's location and size info when detachment happens.
Cc: Philippe Mathieu-Daudé
Cc: Paolo Bonzini
Cc: Gerd Hoffmann
Cc: Vivek Kasireddy
Signed-off-by: Dongwon Kim
---
ui/gtk.c | 13 +
1 file changed, 13
On Tue, May 03, 2022 at 10:12:43AM +0100, Daniel P. Berrangé wrote:
> On Thu, Apr 28, 2022 at 04:13:03PM -0700, Dongwon Kim wrote:
> > With "detach-all=on" for display, QEMU starts with all VC windows
> > detached automatically.
> >
> > If used with "ful
and make
sure all detached windows are not overlapped each other.
On Tue, May 03, 2022 at 10:17:46AM +0100, Daniel P. Berrangé wrote:
> On Thu, Apr 28, 2022 at 04:13:04PM -0700, Dongwon Kim wrote:
> > Specify location and size of detached window based on top level
> > window's locatio
On Tue, May 03, 2022 at 10:15:13AM +0100, Daniel P. Berrangé wrote:
> On Thu, Apr 28, 2022 at 04:13:02PM -0700, Dongwon Kim wrote:
> > Introducing a new integer parameter to specify the monitor where the
> > Qemu window is placed upon launching.
> >
> > Monitor
but it keeps getting error saying
Invalid parameter type, expected 'array'.
Do you know how to pass this arg?
Thanks,
DW
On Tue, May 03, 2022 at 10:15:13AM +0100, Daniel P. Berrangé wrote:
> On Thu, Apr 28, 2022 at 04:13:02PM -0700, Dongwon Kim wrote:
> > Introducing a new integer
It only needs to update the scanouts containing the rect area
coming with the resource-flush request from the guest.
Cc: Gerd Hoffmann
Cc: Vivek Kasireddy
Signed-off-by: Dongwon Kim
---
hw/display/virtio-gpu.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/display/virtio-gpu.c b/hw
Hoffmann
Signed-off-by: Dongwon Kim
---
ui/gtk-egl.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c
index b5bffbab25..35f917ceb1 100644
--- a/ui/gtk-egl.c
+++ b/ui/gtk-egl.c
@@ -195,6 +195,9 @@ void gd_egl_switch(DisplayChangeListener *dcl,
if (resized
: Daniel P. Berrangé
Cc: Markus Armbruster
Cc: Philippe Mathieu-Daudé
Cc: Marc-André Lureau
Cc: Thomas Huth
Cc: Vivek Kasireddy
Signed-off-by: Dongwon Kim
---
ui/gtk.c | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/ui/gtk.c b/ui/gtk.c
index a1fb42f34d
nactivated or
untabified window is closed. If set to 'false', QEMU will stop scheduling
render events until it is visible again.
Cc: Gerd Hoffmann
Cc: Daniel P. Berrangé
Cc: Markus Armbruster
Cc: Philippe Mathieu-Daudé
Cc: Marc-André Lureau
Cc: Thomas Huth
Cc: Vivek Kasireddy
Signed-off-by: D
Add a callback for window-state-event that resets vc->gfx.visible when
associated window is minimized and vice versa.
Cc: Gerd Hoffmann
Cc: Daniel P. Berrangé
Cc: Markus Armbruster
Cc: Philippe Mathieu-Daudé
Cc: Marc-André Lureau
Cc: Thomas Huth
Cc: Vivek Kasireddy
Signed-off-by: Dong
er vc->gfx was added to indicate the visibilty
status of VC for the mechanism. And resizing VC to 0 was used to
inactivate the scanout , which eventually makes the guest display
shown as disconnected on the guest's side.
Dongwon Kim (3):
ui/gtk: skip drawing guest scanout when associated VC is i
uld not schedule any redundant draw event in case draw_submitted is
already set in gd_egl_fluch/gd_gl_area_scanout_flush.
Cc: Gerd Hoffmann
Cc: Vivek Kasireddy
Signed-off-by: Dongwon Kim
---
ui/gtk-egl.c | 2 +-
ui/gtk-gl-area.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
dif
The scanout is currently updated only if the whole rect is inside the
scanout space. This is not a correct condition because the scanout should
be updated even a small area in the scanout space is covered by the rect.
Cc: Gerd Hoffmann
Signed-off-by: Dongwon Kim
---
hw/display/virtio-gpu.c | 7
: Vivek Kasireddy
Signed-off-by: Dongwon Kim
---
ui/gtk-egl.c | 2 +-
ui/gtk-gl-area.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c
index d59b8cd7d7..b0356d1969 100644
--- a/ui/gtk-egl.c
+++ b/ui/gtk-egl.c
@@ -238,7 +238,6 @@ void
Skip refresh if a new dmabuf (guest scanout frame) has already been
submitted and ready to be drawn because the scanout will be updated
with new frame anyway.
Cc: Gerd Hoffmann
Cc: Marc-André Lureau
Cc: Vivek Kasireddy
Signed-off-by: Dongwon Kim
---
ui/gtk-egl.c | 4
ui/gtk-gl
d Hoffmann
Cc: Daniel P. Berrangé
Cc: Markus Armbruster
Cc: Philippe Mathieu-Daudé
Cc: Marc-André Lureau
Signed-off-by: Vivek Kasireddy
Signed-off-by: Dongwon Kim
---
include/ui/gtk.h | 1 +
qapi/ui.json | 26 -
qemu-options.hx | 5 +-
ui/gtk.c
Lureau
Cc: Vivek Kasireddy
Signed-off-by: Dongwon Kim
---
hw/display/virtio-gpu-udmabuf.c | 12 ++--
include/ui/console.h| 4 ++--
ui/dbus-listener.c | 8
ui/egl-helpers.c| 8
ui/gtk-egl.c| 8
ui/gtk
-by: Dongwon Kim
---
hw/display/virtio-gpu-udmabuf.c | 8
include/ui/console.h| 4 ++--
ui/dbus-listener.c | 4 ++--
ui/egl-helpers.c| 4 ++--
ui/gtk-egl.c| 4 ++--
ui/gtk-gl-area.c| 4 ++--
6 files changed, 14 insertions
rted-by: Volker Rümelin
Cc: Gerd Hoffmann
Cc: Marc-André Lureau
Cc: Vivek Kasireddy
Signed-off-by: Dongwon Kim
---
ui/gtk-egl.c | 1 +
ui/gtk-gl-area.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c
index 4c29ac10d0..a1060fd80f 100644
--- a/ui/gtk-egl
pe Mathieu-Daudé
Cc: Marc-André Lureau
Signed-off-by: Vivek Kasireddy
Signed-off-by: Dongwon Kim
---
include/ui/gtk.h | 1 +
qapi/ui.json | 11 +-
qemu-options.hx | 5 +-
ui/gtk.c | 271 +++
4 files changed, 263 insertions(+), 25
alse' when
the window is inactivated or closed. When invisible, QEMU will skip any of
draw events.
Cc: Gerd Hoffmann
Cc: Daniel P. Berrangé
Cc: Markus Armbruster
Cc: Philippe Mathieu-Daudé
Cc: Marc-André Lureau
Cc: Vivek Kasireddy
Signed-off-by: Dongwon Kim
---
include/ui/gtk.h | 1 +
ui/gtk-egl.
1 - 100 of 193 matches
Mail list logo