[Qemu-devel] Postcopy codebase status?

2013-12-11 Thread Dr. David Alan Gilbert
. Dave -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

[Qemu-devel] [Bug 1259499] Re: QEmu 1.7.0 cannot restore a 1.6.0 live snapshot made in qemu-system-x86_64

2013-12-13 Thread Dr. David Alan Gilbert
Hi Francois, I've managed to reproduce this, in my log file (/var/log/libvirt/qemu/machinename.log) I see: Unknown ramblock :02.0/qxl.vram, cannot accept migration qemu: warning: error while loading state for instance 0x0 of device 'ram' qemu-system-x86_64: Error -22 while loading VM state

[Qemu-devel] [Bug 1259499] Re: QEmu 1.7.0 cannot restore a 1.6.0 live snapshot made in qemu-system-x86_64

2013-12-13 Thread Dr. David Alan Gilbert
Hi Francois, I've done some more digging. It looks like the problem you've hit is related to the same one that's fixed by: http://lists.gnu.org/archive/html/qemu-devel/2013-11/msg00513.html however that only fixes older restores ; there is a work around which is to pass to QEMU: -global

[Qemu-devel] [Bug 883136] Re: qemu on ARM hosts aborts on startup because makecontext() always fails

2011-12-21 Thread Dr. David Alan Gilbert
. David Alan Gilbert (davidgil-uk) ** Attachment added: Start of a set of context routines https://bugs.launchpad.net/qemu-linaro/+bug/883136/+attachment/2642884/+files/allcontext.S -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU

[Qemu-devel] [Bug 883136] Re: qemu on ARM hosts aborts on startup because makecontext() always fails

2011-12-23 Thread Dr. David Alan Gilbert
OK, here is a eglibc patch that adds the context routines; seems to pass Stefan's magic coroutine test, pass all the context specific tests in eglibc and boots a debian image on qemu. (Not run a full eglibc test run yet). Dave ** Attachment added: eglibc patch for ARM context routines

[Qemu-devel] [Bug 887883] Re: Coverity scan revealed defects

2011-12-30 Thread Dr. David Alan Gilbert
I believe the ARM ones are bogus (although some could be clearer and simulataneously clear some of the warnings): Error: DEADCODE: *** IFDEF dependent hw/arm_gic.c:409: dead_error_condition: On this path, the condition irq 16 cannot be true. *** ifdef'd - only true if NVIC defined

[Qemu-devel] [Bug 883133] Re: qemu on ARM hosts asserts due to code buffer/libc heap conflict

2011-12-09 Thread Dr. David Alan Gilbert
** Changed in: qemu-linaro Assignee: (unassigned) = Dr. David Alan Gilbert (davidgil-uk) ** Changed in: qemu-linaro Status: New = In Progress -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net

[Qemu-devel] [PATCH] ARM - Remove fixed map code buffer restriction

2011-12-12 Thread Dr. David Alan Gilbert
-by: Dr. David Alan Gilbert david.gilb...@linaro.org --- exec.c |4 +--- tcg/arm/tcg-target.c | 31 --- 2 files changed, 13 insertions(+), 22 deletions(-) diff --git a/exec.c b/exec.c index 6b92198..ef83da1 100644 --- a/exec.c +++ b/exec.c @@ -497,9

[Qemu-devel] [Bug 883133] Re: qemu on ARM hosts asserts due to code buffer/libc heap conflict

2011-12-15 Thread Dr. David Alan Gilbert
Fix pushed into QEMU upstream today. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/883133 Title: qemu on ARM hosts asserts due to code buffer/libc heap conflict Status in QEMU: New Status in

[Qemu-devel] [PATCH] Fix last sector write on sd card

2011-07-25 Thread Dr. David Alan Gilbert
When writing the last sector of an SD card using WRITE_MULTIPLE_BLOCK QEmu throws an error saying that we've run off the end, and leaves itself in the wrong state. Tested on ARM Vexpress model. Signed-off-by: Dr. David Alan Gilbert david.gilb...@linaro.org --- Don't throw address error

[Qemu-devel] [PATCH] Fix for soc-dma type code

2011-08-02 Thread Dr. David Alan Gilbert
Hi, I was looking at trying to get soc_dma to call a fifo routine using soc_dma_port_add_fifo_in and hit a few problems that are fixed by the following patch. 1) Where there are two entries matching an address (i.e. a fifo registered for both input and output) soc_dma_lookup finds the last

[Qemu-devel] [Bug 823902] [NEW] multithreaded ARM seg/longjmp causes uninitialized stack frame due to0d10193870b5a81c3bce13a602a5403c3a55cf6c

2011-08-10 Thread Dr. David Alan Gilbert
Public bug reported: Hi, I've got an ARM multithreaded test program that I wrote as a gcc testcase (attached) that fails on QEmu, firefox from Ubuntu ARM maverick also fails in the same way. The failure is either a seg fault or '*** longjmp causes uninitialized stack frame ***:

[Qemu-devel] [Bug 823902] Re: multithreaded ARM seg/longjmp causes uninitialized stack frame due to0d10193870b5a81c3bce13a602a5403c3a55cf6c

2011-08-10 Thread Dr. David Alan Gilbert
Test built from source from this set of patches: http://gcc.gnu.org/ml/gcc-patches/2011-07/msg02235.html ** Attachment added: Multithreaded armv7 test binary, uses ldrexd/strexd https://bugs.launchpad.net/qemu/+bug/823902/+attachment/2265952/+files/di-ll64-syncmulti-armv7 -- You received

[Qemu-devel] [Bug 823902] Re: multithreaded ARM seg/longjmp causes uninitialized stack frame due to0d10193870b5a81c3bce13a602a5403c3a55cf6c

2011-08-10 Thread Dr. David Alan Gilbert
Note this needs the 64bit ARM sync patches for gcc to build ** Attachment added: Multithreaded test source https://bugs.launchpad.net/qemu/+bug/823902/+attachment/2265957/+files/di-sync-multithread.c -- You received this bug notification because you are a member of qemu- devel-ml, which is

[Qemu-devel] [Bug 823902] Re: multithreaded ARM seg/longjmp causes uninitialized stack frame due to0d10193870b5a81c3bce13a602a5403c3a55cf6c

2011-08-10 Thread Dr. David Alan Gilbert
2b41f... is a disaster on 64bit - 1 out of 10 pass; most of the others fail with: qemu/user-exec.c:99: handle_cpu_signal: Assertion `({ unsigned long __guest = (unsigned long)(address) - guest_base; __guest (1ul 32); })' failed. which I think is a segfault at host address 0 or there about.

[Qemu-devel] [PATCH] linux-user: Implement new ARM 64 bit cmpxchg kernel helper

2011-08-31 Thread Dr. David Alan Gilbert
it can map a page * Populate page with kernel helper version Signed-off-by: Dr. David Alan Gilbert david.gilb...@linaro.org diff --git a/linux-user/elfload.c b/linux-user/elfload.c index 04e8e6e..8677bba 100644 --- a/linux-user/elfload.c +++ b/linux-user/elfload.c @@ -332,6 +332,49 @@ enum

[Qemu-devel] [PATCH] Make cpu_single_env thread local (Linux only for now)

2011-10-03 Thread Dr. David Alan Gilbert
run ARM userspace firefox. Signed-off-by: Dr. David Alan Gilbert david.gilb...@linaro.org diff --git a/cpu-all.h b/cpu-all.h index 42a5fa0..d895ee6 100644 --- a/cpu-all.h +++ b/cpu-all.h @@ -334,7 +334,13 @@ void cpu_dump_statistics(CPUState *env, FILE *f, fprintf_function cpu_fprintf, void

Re: [Qemu-devel] [PATCH 1/3] loader: add support for resizeable blobs

2014-07-28 Thread Dr. David Alan Gilbert
); +fw_cfg_add_file_callback(s, filename, NULL, NULL, data, len, len); } static void fw_cfg_machine_ready(struct Notifier *n, void *data) -- MST -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: [Qemu-devel] [PATCH 1/3] loader: add support for resizeable blobs

2014-07-29 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: On Mon, Jul 28, 2014 at 05:52:27PM +0100, Dr. David Alan Gilbert wrote: * Michael S. Tsirkin (m...@redhat.com) wrote: Support resizeable blobs: we allocate more memory than currently available in the blob, which can later be filled

[Qemu-devel] PO files; make install changing stuff in source dir

2014-07-30 Thread Dr. David Alan Gilbert
not just directly after rebases. Dave (who knows nothing about po files) -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: [Qemu-devel] [PATCH 4/7] a trivial code change for more idiomatic writing style

2014-07-31 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: On 31 July 2014 14:55, Dr. David Alan Gilbert dgilb...@redhat.com wrote: * arei.gong...@huawei.com (arei.gong...@huawei.com) wrote: --- a/qdev-monitor.c +++ b/qdev-monitor.c @@ -694,7 +694,7 @@ void qmp_device_del(const char *id, Error

Re: [Qemu-devel] [RFC PATCH 04/17] COLO info: use colo info to tell migration target colo is enabled

2014-08-01 Thread Dr. David Alan Gilbert
(); +if (colo_supported()) { +colo_info_mig_init(); +} /* open the virtual block devices */ if (snapshot) -- 1.9.1 -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: [Qemu-devel] [RFC PATCH 05/17] COLO save: integrate COLO checkpointed save into qemu migration

2014-08-01 Thread Dr. David Alan Gilbert
, MIG_STATE_COLO, MIG_STATE_COMPLETED); +} I thought migrate_set_state only changed the state if the old state matched the 1st value - i.e. I think it'll only change to COMPLETED if the state is COLO; so I don't think you need the if. Dave -- Dr. David Alan Gilbert / dgilb...@redhat.com

Re: [Qemu-devel] [RFC PATCH 07/17] COLO buffer: implement colo buffer as well as QEMUFileOps based on it

2014-08-01 Thread Dr. David Alan Gilbert
) return true; } +/* colo buffer */ + +#define COLO_BUFFER_BASE_SIZE (1000*1000*4ULL) +#define COLO_BUFFER_MAX_SIZE (1000*1000*1000*10ULL) Powers of 2 are nicer! Dave -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: [Qemu-devel] [RFC PATCH 10/17] COLO ctl: introduce is_slave() and is_master()

2014-08-01 Thread Dr. David Alan Gilbert
; +} + /* * return: * 0: start a checkpoint -- 1.9.1 -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: [Qemu-devel] [RFC PATCH 11/17] COLO ctl: implement colo checkpoint protocol

2014-08-01 Thread Dr. David Alan Gilbert
= dev_hotplug; -- 1.9.1 -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: [Qemu-devel] [RFC PATCH 15/17] COLO save: reuse migration bitmap under colo checkpoint

2014-08-01 Thread Dr. David Alan Gilbert
(MigrationState *s) void colo_process_incoming_checkpoints(QEMUFile *f) { } + +bool is_master(void) +{ +return false; +} + +bool is_slave(void) +{ +return false; +} -- 1.9.1 -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: [Qemu-devel] [RFC PATCH 13/17] COLO ctl: implement colo save

2014-08-01 Thread Dr. David Alan Gilbert
(); +ret = 0; out: +/* resume master */ +qemu_mutex_lock_iothread(); +vm_start(); +qemu_mutex_unlock_iothread(); + return ret; } -- 1.9.1 -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: [Qemu-devel] [RFC PATCH 16/17] COLO ram cache: implement colo ram cache on slaver

2014-08-01 Thread Dr. David Alan Gilbert
= false; Probably better as 'ram_cache_needs_flush' Dave -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: [Qemu-devel] [RFC PATCH v3 04/49] fdc: adding vmstate for save/restore

2014-08-01 Thread Dr. David Alan Gilbert
= vmstate_fdc_result_timer, +.needed = fdc_result_timer_needed, +} , { +/* empty */ +} } }; -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: [Qemu-devel] [RFC PATCH 00/17] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service

2014-08-01 Thread Dr. David Alan Gilbert
/migration/migration-colo.h create mode 100644 migration-colo-comm.c create mode 100644 migration-colo.c create mode 100644 stubs/migration-colo.c -- 1.9.1 -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: [Qemu-devel] qemu live migration error from 2.0 to 2.1

2014-08-06 Thread Dr. David Alan Gilbert
to newer QEMU versions easily (just don't go with dev versions because things are often broken in them). -M pc is special, don't use that if you want to be able to migrate Dave -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: [Qemu-devel] [PATCH RFC v2 01/12] QEMUSizedBuffer/QEMUFile

2014-08-06 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: On 07/25/2014 09:39 AM, Sanidhya Kashyap wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com Stefan Berger's to create a QEMUFile that goes to a memory buffer; Missing something. Maybe you meant: This is based on Stefan Berger's patch

Re: [Qemu-devel] [PATCH 1/2] QEMUSizedBuffer based QEMUFile

2014-08-07 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: On 08/06/2014 11:30 AM, Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com This is based on Stefan and Joel's patch that creates a QEMUFile that goes to a memory buffer; from: http://lists.gnu.org/archive/html

Re: [Qemu-devel] [PATCH 00/46] Postcopy implementation

2014-08-11 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: On 07/10/2014 05:29 AM, Dr. David Alan Gilbert wrote: * Paolo Bonzini (pbonz...@redhat.com) wrote: Il 07/07/2014 16:02, Dr. David Alan Gilbert ha scritto: Could you have instead a migrate_start_postcopy command, and leave the policy to management

Re: [Qemu-devel] [RFC PATCH v3 1/6] QEMUSizedBuffer/QEMUFile

2014-08-11 Thread Dr. David Alan Gilbert
wrong). I guess the choice is to allow it to return NULL, tidying up and offering the chance sometime in the future of tidying up the other allocators. Dave Best regards, -Gonglei -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: [Qemu-devel] [PATCH v2 00/43] Postcopy implementation

2014-08-12 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: On 2014/8/11 22:29, Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbertdgilb...@redhat.com Hi Dave, I want to test your patches, but i failed to 'git am' them to the new qemu-2.1 source. I want to know if you has a git

Re: [Qemu-devel] ????: [PATCH v2 06/43] Return path: socket_writev_buffer:?Block even on non-blocking fd's

2014-08-12 Thread Dr. David Alan Gilbert
* chenliang (T) (chenlian...@huawei.com) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com The return path uses a non-blocking fd so as not to block waiting for the (possibly broken) destination to finish returning a message, however we still want outbound data to behave

Re: [Qemu-devel] [PATCH v5 1/6] generic function between migration and bitmap dump

2014-08-12 Thread Dr. David Alan Gilbert
); + #endif #endif -- 1.9.3 -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: [Qemu-devel] [PATCH v5 2/6] BitmapLog: bitmap dump code

2014-08-12 Thread Dr. David Alan Gilbert
) } if (incoming) { +qemu_process_set(QEMU_PROCESS_MIGRATION); Error *local_err = NULL; qemu_start_incoming_migration(incoming, local_err); if (local_err) { -- 1.9.3 -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: [Qemu-devel] [PATCH v5 3/6] BitmapLog: get the information about the parameters

2014-08-12 Thread Dr. David Alan Gilbert
) { QEMUFile *f; -- 1.9.3 -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: [Qemu-devel] [PATCH v5 6/6] BitmapLog: python script for extracting bitmap from a binary file

2014-08-12 Thread Dr. David Alan Gilbert
(args.infile), 'rb') + +dump_bitmap(infile, args.draw); + +infile.close() + +if __name__ == '__main__': +main() -- 1.9.3 -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: [Qemu-devel] [PATCH v5 6/6] BitmapLog: python script for extracting bitmap from a binary file

2014-08-12 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: * Sanidhya Kashyap (sanidhya.ii...@gmail.com) wrote: The file not only extracts the bitmap from the file but also draws the figure if required. Currently, figure is drawn for all the bitmaps. Later, I'll make the change to draw

Re: [Qemu-devel] Microcheckpointing: Memory-VCPU / Disk State consistency

2014-08-14 Thread Dr. David Alan Gilbert
, but then the only difference from microcheckpointing at that point is the secondary doing a wasteful copy and sending the packets across; it seems it should be easy to disable those if it knew that a resync was going to happen. Dave - Michael -- Dr. David Alan Gilbert / dgilb...@redhat.com

[Qemu-devel] [Bug 1259499] Re: QEmu 1.7.0 cannot restore a 1.6.0 live snapshot made in qemu-system-x86_64

2013-12-23 Thread Dr. David Alan Gilbert
Yes, my understanding of the bug is that 1.7+ should load your 1.3.x images and then snapshots taken on 1.7.x should be OK into the future. I don't think there's currently a way of fixing those 1.6.0 snapshots; that workaround will let you load them in 1.7, but I think if you were then to take a

Re: [Qemu-devel] [RFC PATCH 00/16] visitor+BER migration format

2014-03-26 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: On Tue, Mar 25, 2014 at 08:17:11PM +, Dr. David Alan Gilbert (git) wrote: snip 5) At the moment you select BER output format by setting an environment variable ( export QEMUMIGFORMAT=BER ) , I need to put more thought

Re: [Qemu-devel] [PATCH v2 1/1] Make qemu_peek_buffer loop until it gets it's data

2014-03-26 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: Dr. David Alan Gilbert (git) dgilb...@redhat.com writes: From: Dr. David Alan Gilbert dgilb...@redhat.com Make qemu_peek_buffer repatedly call fill_buffer until it gets all the data it requires, or until there is an error

[Qemu-devel] Ping: [PATCH 0/1] configure time fix for thread naming on old glibc

2014-03-26 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (git) (dgilb...@redhat.com) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com Peter was preferring configure time detection of pthread_setname_np to guard against my recent breaking of builds on old libc. I've tested this on: Fedora 20 - modern glibc

Re: [Qemu-devel] [PATCH v4 2/9] qmp: Add dirty-bitmap-add and dirty-bitmap-remove

2014-03-27 Thread Dr. David Alan Gilbert
Hi Fam, Could you make this something like block-dirty-bitmap - the RAM migration also has a dirty bitmap, and it would just make it clearer. Dave -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: [Qemu-devel] [PATCH] migration: Fix possible bug for migrate cancel

2014-03-28 Thread Dr. David Alan Gilbert
it wants to give up and use the version on the source that's still paused. Dave -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: [Qemu-devel] [PATCH v4 7/8] migration: optimize xbzrle by reducing data copy

2014-03-28 Thread Dr. David Alan Gilbert
-- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: [Qemu-devel] [PATCH] xbzrle: don't check the value in the vm ram repeatedly

2014-03-31 Thread Dr. David Alan Gilbert
or go over the end of the page (I think this means we have to be careful of those byte loops within the word-at-a-time cases) 3) The page that ends up in our xbzrle cache must match the destination page, since the next cycle of xbzrle will use it as reference. Dave -- Dr. David

Re: [Qemu-devel] [PATCH v4 01/30] vmstate: reduce code duplication

2014-03-31 Thread Dr. David Alan Gilbert
= *(void **)base_addr + field-start; } Hmm, shouldn't those last 3 lines be deleted as well - the logic is now in vmstate_base_addr? Dave -- MST -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: [Qemu-devel] [PATCH v4 27/30] vmxnet3: validate interrupt indices coming from guest

2014-03-31 Thread Dr. David Alan Gilbert
. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: [Qemu-devel] [PATCH v4 29/30] vmxnet3: validate queues configuration coming from quest

2014-03-31 Thread Dr. David Alan Gilbert
); +vmxnet3_validate_queues(s); qdescr_table_pa = VMXNET3_READ_DRV_SHARED64(s-drv_shmem, devRead.misc.queueDescPA); -- MST -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: [Qemu-devel] [PATCH v2 1/2] xbzrle: don't check the value in the vm ram repeatedly

2014-03-31 Thread Dr. David Alan Gilbert
* arei.gong...@huawei.com (arei.gong...@huawei.com) wrote: From: ChenLiang chenlian...@huawei.com xbzrle_encode_buffer checks the value in the vm ram repeatedly. It is risk if runs xbzrle_encode_buffer on changing data. And it is not necessary. Reported-by: Dr. David Alan Gilbert dgilb

Re: [Qemu-devel] [PATCH v4 28/30] vmxnet3: validate interrupt indices read on migration

2014-03-31 Thread Dr. David Alan Gilbert
); + When you repost to fix the other stuff, why not merge this with what is currently #30. Dave -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: [Qemu-devel] [PATCH v4 13/30] stellaris_enet: avoid buffer overrun on incoming migration

2014-03-31 Thread Dr. David Alan Gilbert
related to the current packet in-flight; although I've not quite convinced myself about what is supposed to happen at the end of the packet (which is why I say rx_fifo might point just at? the end. Dave return 0; } -- MST -- Dr. David Alan Gilbert / dgilb...@redhat.com

Re: [Qemu-devel] [PATCH v4 05/30] virtio-net: out-of-bounds buffer write on load

2014-04-01 Thread Dr. David Alan Gilbert
-mac_table.in_use = 0; } -- MST -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: [Qemu-devel] [PATCH v4 14/30] stellaris_enet: avoid buffer overrun on incoming migration (part 2)

2014-04-01 Thread Dr. David Alan Gilbert
- but there again the 'DATA' write case is pretty hairy. Dave for (i = 0; i 31; i++) { s-rx[i].len = qemu_get_be32(f); -- MST -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: [Qemu-devel] [PATCH v4 15/30] stellaris_enet: avoid buffer orerrun on incoming migration (part 3)

2014-04-01 Thread Dr. David Alan Gilbert
bytes. Dave v = qemu_get_be32(f); /* How many bytes does data use in tx fifo. */ sz = s-tx_frame_len == -1 ? 2 : 4; -- MST -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: [Qemu-devel] [PATCH v4 27/30] vmxnet3: validate interrupt indices coming from guest

2014-04-01 Thread Dr. David Alan Gilbert
* Dmitry Fleytman (dmi...@daynix.com) wrote: On Mar 31, 2014, at 18:45 PM, Dr. David Alan Gilbert dgilb...@redhat.com wrote: * Michael S. Tsirkin (m...@redhat.com) wrote: From: Dmitry Fleytman dmi...@daynix.com CVE-2013-4544 Signed-off-by: Dmitry Fleytman dmi...@daynix.com

Re: [Qemu-devel] [PATCH v4 03/30] vmstate: add VMSTATE_VALIDATE

2014-04-01 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: Validate state using VMS_ARRAY with num = 0 and VMS_MUST_EXIST Signed-off-by: Michael S. Tsirkin m...@redhat.com Reviewed-by: Dr. David Alan Gilbert dgilb...@redhat.com --- include/migration/vmstate.h | 8 1 file changed, 8

Re: [Qemu-devel] [PATCH v4 10/30] hw/pci/pcie_aer.c: fix buffer overruns on invalid state load

2014-04-01 Thread Dr. David Alan Gilbert
...@redhat.com Reviewed-by: Dr. David Alan Gilbert dgilb...@redhat.com --- hw/pci/pcie_aer.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/hw/pci/pcie_aer.c b/hw/pci/pcie_aer.c index 991502e..535be2c 100644 --- a/hw/pci/pcie_aer.c +++ b/hw/pci/pcie_aer.c @@ -795,6

Re: [Qemu-devel] [PATCH v4 23/30] zaurus: fix buffer overrun on invalid state load

2014-04-01 Thread Dr. David Alan Gilbert
for gpio_level and gpio_dir. Reviewed-by: Dr. David Alan Gilbert dgilb...@redhat.com (Without much understanding of the actual, apparently undocumented hardware) To fix, limit to 16 bit. Reported-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/gpio

Re: [Qemu-devel] [PATCH v4 27/30] vmxnet3: validate interrupt indices coming from guest

2014-04-01 Thread Dr. David Alan Gilbert
(Failed to initialize MSI, error %d, res); -- MST -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: [Qemu-devel] [PATCH v4 27/30] vmxnet3: validate interrupt indices coming from guest

2014-04-01 Thread Dr. David Alan Gilbert
* Dmitry Fleytman (dmi...@daynix.com) wrote: On Apr 1, 2014, at 14:33 PM, Dr. David Alan Gilbert dgilb...@redhat.com wrote: * Michael S. Tsirkin (m...@redhat.com) wrote: From: Dmitry Fleytman dmi...@daynix.com CVE-2013-4544 Signed-off-by: Dmitry Fleytman dmi...@daynix.com

Re: [Qemu-devel] [PATCH v4 5/8] XBZRLE: optimize XBZRLE to decrease the cache misses

2014-04-01 Thread Dr. David Alan Gilbert
-- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: [Qemu-devel] [PATCH 1/5] hw/net/stellaris_enet: Restructure tx_fifo code to avoid buffer overrun

2014-04-01 Thread Dr. David Alan Gilbert
hardware, which has a number of ways it can be configured to trigger sending the packet, some of which we don't implement. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Reviewed-by: Dr. David Alan Gilbert dgilb...@redhat.com --- hw/net/stellaris_enet.c | 10 ++ 1 file

Re: [Qemu-devel] [PATCH 2/5] hw/net/stellaris_enet: Correct handling of packet padding

2014-04-01 Thread Dr. David Alan Gilbert
. Fix this bug. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Reviewed-by: Dr. David Alan Gilbert dgilb...@redhat.com --- hw/net/stellaris_enet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/stellaris_enet.c b/hw/net/stellaris_enet.c index bd844cd

Re: [Qemu-devel] [PATCH 3/5] hw/net/stellaris_enet: Rewrite tx fifo handling code

2014-04-01 Thread Dr. David Alan Gilbert
= qemu_get_be32(f); s-tx_fifo_len = qemu_get_be32(f); qemu_get_buffer(f, s-tx_fifo, sizeof(s-tx_fifo)); for (i = 0; i 31; i++) { You should probably increment the migration state version number to 2. Dave -- 1.9.0 -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: [Qemu-devel] [PATCH 4/5] hw/net/stellaris_enet: Correctly implement the TR and THR registers

2014-04-01 Thread Dr. David Alan Gilbert
. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: [Qemu-devel] [PATCH 3/5] hw/net/stellaris_enet: Rewrite tx fifo handling code

2014-04-01 Thread Dr. David Alan Gilbert
(resend reply - the mail gru got some of the 1st one) * Peter Maydell (peter.mayd...@linaro.org) wrote: On 1 April 2014 18:26, Dr. David Alan Gilbert dgilb...@redhat.com wrote: * Peter Maydell (peter.mayd...@linaro.org) wrote: The datasheet is clear that the frame length written to the DATA

Re: [Qemu-devel] [PATCH 5/5] hw/net/stellaris_enet: Fix debug format strings

2014-04-01 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: Fix various debug format strings which were incorrect for the data type, so that building with debug enabled is possible. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Reviewed-by: Dr. David Alan Gilbert dgilb...@redhat.com --- hw

Re: [Qemu-devel] [PATCH 3/5] hw/net/stellaris_enet: Rewrite tx fifo handling code

2014-04-01 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: On 1 April 2014 18:45, Dr. David Alan Gilbert dgilb...@redhat.com wrote: (resend reply - the mail gru got some of the 1st one) * Peter Maydell (peter.mayd...@linaro.org) wrote: You should probably increment the migration state version

Re: [Qemu-devel] [PATCH 3/5] hw/net/stellaris_enet: Rewrite tx fifo handling code

2014-04-01 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: On 1 April 2014 18:26, Dr. David Alan Gilbert dgilb...@redhat.com wrote: * Peter Maydell (peter.mayd...@linaro.org) wrote: The datasheet is clear that the frame length written to the DATA register is actually stored in the TX FIFO

Re: [Qemu-devel] Unresponsive linux guest once migrated

2014-04-02 Thread Dr. David Alan Gilbert
your qemu command line look like? 7) How exactly are you migrating? 8) You talk about having to wait a few hours to trigger it - do you have a more exact description of a test? 9) Is there any output from qemu stderr/stdout in your qemu logs? Dave -- Dr. David Alan Gilbert / dgilb

Re: [Qemu-devel] Unresponsive linux guest once migrated

2014-04-02 Thread Dr. David Alan Gilbert
/stdout in your qemu logs? Nothing unusual. From QEMU point of view guest is up and running. Only its OS is hanged (but not panicked, there is no backtrace, oops or BUG on its screen). Dave -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: [Qemu-devel] [PATCH v2 3/7] hw/net/stellaris_enet: Rewrite tx fifo handling code

2014-04-02 Thread Dr. David Alan Gilbert
...@linaro.org Reviewed-by: Dr. David Alan Gilbert dgilb...@redhat.com --- -register_savevm(dev, stellaris_enet, -1, 1, +register_savevm(dev, stellaris_enet, -1, 2, stellaris_enet_save, stellaris_enet_load, s); return 0; Note that as well as inc'ing that you would

Re: [Qemu-devel] [PATCH v2 4/7] hw/net/stellaris_enet: Correctly implement the TR and THR registers

2014-04-02 Thread Dr. David Alan Gilbert
Reviewed-by: Dr. David Alan Gilbert dgilb...@redhat.com --- hw/net/stellaris_enet.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/hw/net/stellaris_enet.c b/hw/net/stellaris_enet.c index 47787fd..db6e43e 100644 --- a/hw/net/stellaris_enet.c +++ b/hw

Re: [Qemu-devel] [PATCH] qemu-thread-posix: Fix build against older glibc version

2014-04-02 Thread Dr. David Alan Gilbert
* Ed Maste (ema...@freebsd.org) wrote: On 11 March 2014 12:13, Dr. David Alan Gilbert dgilb...@redhat.com wrote: Except pthread_setname_np is not portable and was previously ifdef'd _GNU_SOURCE anyway, and the parameters on other OSs maybe different (freebsd has got a 3rd parameter

Re: [Qemu-devel] [PATCH v2 6/7] hw/net/stellaris_enet: Get rid of rx_fifo pointer

2014-04-02 Thread Dr. David Alan Gilbert
reasonable to skip these version inc's; it doesn't seem to make sense to inc a version by 3 in one small patchset. Reviewed-by: Dr. David Alan Gilbert dgilb...@redhat.com -- 1.9.0 -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: [Qemu-devel] [PATCH v2 7/7] hw/net/stellaris_enet: Convert to vmstate

2014-04-02 Thread Dr. David Alan Gilbert
, void *opaque) -{ Good :-) Dave -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: [Qemu-devel] process naming not working when using a config file

2014-04-02 Thread Dr. David Alan Gilbert
list. Thanks again for reporting it. Dave -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: [Qemu-devel] [PATCH v4 5/8] XBZRLE: optimize XBZRLE to decrease the cache misses

2014-04-03 Thread Dr. David Alan Gilbert
= ++cache-max_item_age; +it-it_age = current_age; it-it_addr = addr; return 0; -- 1.7.12.4 -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: [Qemu-devel] [PATCH v5 02/24] vmstate: add VMS_MUST_EXIST

2014-04-04 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: Michael S. Tsirkin m...@redhat.com wrote: Can be used to verify a required field exists or validate state in some other way. Signed-off-by: Michael S. Tsirkin m...@redhat.com Reviewed-by: Dr. David Alan Gilbert dgilb...@redhat.com What

Re: [Qemu-devel] [RFC PATCH v2 10/12] mc: expose tunable parameter for checkpointing frequency

2014-04-04 Thread Dr. David Alan Gilbert
are going - and some care is needed with it since (as we found with the xbzrle cache size) we get fun due to the use being in a different thread. Dave -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: [Qemu-devel] [PATCH 00/35] pc: ACPI memory hotplug

2014-04-04 Thread Dr. David Alan Gilbert
like this (i.e. no memory would be allocated in the normal way) 2) Does something stop it being invoked during a migration? Dave -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: [Qemu-devel] [PATCH v5 00/10] migration: Optimizate the xbzrle and fix one corruption issue

2014-04-04 Thread Dr. David Alan Gilbert
-- xbzrle.c | 48 ++-- 10 files changed, 144 insertions(+), 130 deletions(-) -- 1.7.12.4 -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: [Qemu-devel] For 2.0? Re: [PATCH v5 00/10] migration: Optimizate the xbzrle and fix one corruption issue

2014-04-04 Thread Dr. David Alan Gilbert
++-- 10 files changed, 144 insertions(+), 130 deletions(-) -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: [Qemu-devel] [PATCH v5 07/10] xbzrle: don't check the value in the vm ram repeatedly

2014-04-04 Thread Dr. David Alan Gilbert
* arei.gong...@huawei.com (arei.gong...@huawei.com) wrote: From: ChenLiang chenlian...@huawei.com xbzrle_encode_buffer checks the value in the vm ram repeatedly. It is risk if runs xbzrle_encode_buffer on changing data. And it is not necessary. Reported-by: Dr. David Alan Gilbert dgilb

Re: [Qemu-devel] [PATCH v5 08/10] xbzrle: check 8 bytes at a time after an concurrency scene

2014-04-04 Thread Dr. David Alan Gilbert
change the comparison? (What do other people think - I was thinking that would just be better since it would be symmetric?) Dave +} +} } } -- 1.7.12.4 -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: [Qemu-devel] [PATCH v5 09/10] migration: optimize xbzrle by reducing data copy

2014-04-04 Thread Dr. David Alan Gilbert
. Reviewed-by: Dr. David Alan Gilbert dgilb...@redhat.com --- arch_init.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/arch_init.c b/arch_init.c index 84a4bd3..94b62e2 100644 --- a/arch_init.c +++ b/arch_init.c @@ -373,11 +373,8 @@ static int save_xbzrle_page

Re: [Qemu-devel] [Qemu-trivial] [PATCH v4] scripts: add sample model file for Coverity Scan

2014-04-07 Thread Dr. David Alan Gilbert
the qemu sources. Dave -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: [Qemu-devel] [PATCH 03/97] vmstate: return error in case of error

2014-04-07 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: If there is an error while loading a field, we should stop reading and not continue with the rest of fields. Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Dr. David Alan Gilbert dgilb...@redhat.com --- vmstate.c | 3 +++ 1

Re: [Qemu-devel] [PATCH 80/97] vmstate: Create VMSTATE_SYNTHETIC

2014-04-07 Thread Dr. David Alan Gilbert
), VMSTATE_UINT32_ARRAY(env.banked_r13, ARMCPU, 6), -- 1.9.0 -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: [Qemu-devel] [PATCH 96/97] vmstate: Rename VMS_VBUFFER to VMST_VBUFFER_INT32 for consintency

2014-04-07 Thread Dr. David Alan Gilbert
-flags VMS_VBUFFER_INT32) { size = *(int32_t *)(opaque+field-size_offset); } else if (field-flags VMS_VBUFFER_UINT32) { size = *(uint32_t *)(opaque+field-size_offset); -- 1.9.0 -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: [Qemu-devel] [PATCH for 2.1 00/97] VMState simplification (massive)

2014-04-07 Thread Dr. David Alan Gilbert
, vmstate_5_plus); I'm not sure if I like this; while I'm OK with the idea of changing the implementation of VMSTATE_INT64_V to use that function trick internally, it seems like we're discouraging providing easy to parse/record versionining info out of the tree. Dave -- Dr. David Alan Gilbert / dgilb

Re: [Qemu-devel] [PATCH v4 1/1] Make qemu_peek_buffer loop until it gets it's data

2014-04-08 Thread Dr. David Alan Gilbert
* (chenliang0...@icloud.com) wrote: ?? 2014??4??810:29??Dr. David Alan Gilbert (git) dgilb...@redhat.com ?? From: Dr. David Alan Gilbert dgilb...@redhat.com Make qemu_peek_buffer repeatedly call fill_buffer until it gets all the data it requires, or until

Re: [Qemu-devel] [PATCH v4 1/1] Make qemu_peek_buffer loop until it gets it's data

2014-04-09 Thread Dr. David Alan Gilbert
* (chenliang0...@icloud.com) wrote: * (chenliang0...@icloud.com) wrote: ?? 2014??4??810:29??Dr. David Alan Gilbert (git) dgilb...@redhat.com ?? From: Dr. David Alan Gilbert dgilb...@redhat.com Make qemu_peek_buffer repeatedly call fill_buffer until

  1   2   3   4   5   6   7   8   9   10   >