On Sat, May 25, 2013 at 08:25:49AM +0200, Paolo Bonzini wrote:
Il 25/05/2013 03:21, Bandan Das ha scritto:
There is one user-visible effect: -cpu ...,enforce will stop failing
because of missing KVM support for CPUID_EXT_MONITOR. But that's exactly
the point: there's no point in having CPU
On Mon, May 27, 2013 at 02:21:36PM +0200, Paolo Bonzini wrote:
Il 27/05/2013 14:09, Eduardo Habkost ha scritto:
On Sat, May 25, 2013 at 08:25:49AM +0200, Paolo Bonzini wrote:
Il 25/05/2013 03:21, Bandan Das ha scritto:
There is one user-visible effect: -cpu ...,enforce will stop failing
On Mon, May 27, 2013 at 03:14:25PM +0200, Paolo Bonzini wrote:
Il 27/05/2013 15:07, Eduardo Habkost ha scritto:
Changing TCG to KVM should not change hardware
if you use -cpu ...,enforce, so it is right that it fails when
starting with KVM.
Changing between KVM and TCG _does_ change
mechanism and
clear procedure to update CPUID values of existing CPU models in QEMU.
Eduardo Habkost (3):
pc: create pc-*-1.6 machine-types
target-i386: update model values on Conroe/Penryn/Nehalem CPU models
target-i386: set level=4 on Conroe/Penryn/Nehalem
hw/i386/pc_piix.c| 18
instruction anyway because it is reported as available on CPUID, making
it crash.
This patch sets appropriate model values that correspond to real Conroe,
Penryn, and Nehalem CPUs.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
Testing: those family/model values have been in use on Red Hat
The CPUID level value on Conroe, Penryn, and Nehalem are too low. This
causes at least one known problem: the -smp threads option doesn't
work as expect if level is 4, because thread count information is
provided to the guest on CPUID[EAX=4,ECX=2].EAX
Signed-off-by: Eduardo Habkost ehabk
Some CPU model fixes are going to be included and they will require
compatibility properties in the pc-*-1.5 machine-types.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
hw/i386/pc_piix.c | 14 --
hw/i386/pc_q35.c | 12 +++-
2 files changed, 23 insertions(+), 3
(CCing libvirt people)
On Tue, May 28, 2013 at 06:48:52PM +0200, Andreas Färber wrote:
Am 28.05.2013 18:46, schrieb Paolo Bonzini:
Il 28/05/2013 18:34, Bandan Das ha scritto:
Eduardo Habkost ehabk...@redhat.com writes:
On Mon, May 27, 2013 at 02:21:36PM +0200, Paolo Bonzini wrote:
Il
On Thu, May 30, 2013 at 05:57:21PM +0800, Wanlong Gao wrote:
Use mbind to pin guest numa node memory to host nodes manually.
If we are not able to pin memory to host node, we may meet the
cross node memory access performance regression.
With this patch, we can add manual pinning host
On Wed, Jun 05, 2013 at 11:58:25AM +0800, Wanlong Gao wrote:
Add monitor command mem-nodes to show the huge mapped
memory nodes locations.
This is for machine consumption, so we need a QMP command.
(qemu) info mem-nodes
/proc/14132/fd/13: 2ac0-2aaaeac0: node0
On Wed, Jun 05, 2013 at 07:57:42AM -0500, Anthony Liguori wrote:
Wanlong Gao gaowanl...@cn.fujitsu.com writes:
Add monitor command mem-nodes to show the huge mapped
memory nodes locations.
(qemu) info mem-nodes
/proc/14132/fd/13: 2ac0-2aaaeac0: node0
On Wed, Jun 05, 2013 at 07:04:59PM +0200, Andreas Färber wrote:
Am 05.06.2013 16:39, schrieb Igor Mammedov:
On Wed, 05 Jun 2013 15:29:08 +0200
Andreas Färber afaer...@suse.de wrote:
Am 05.06.2013 15:18, schrieb Igor Mammedov:
It's a rebase of v7 on current qom-cpu tree, since then some
On Wed, Jun 05, 2013 at 07:29:46PM +0200, Andreas Färber wrote:
Am 05.06.2013 19:17, schrieb Eduardo Habkost:
On Wed, Jun 05, 2013 at 07:04:59PM +0200, Andreas Färber wrote:
Am 05.06.2013 16:39, schrieb Igor Mammedov:
On Wed, 05 Jun 2013 15:29:08 +0200
Andreas Färber afaer...@suse.de
On Thu, Jun 06, 2013 at 05:30:16PM +0800, Wanlong Gao wrote:
On 06/05/2013 11:54 PM, Eduardo Habkost wrote:
On Wed, Jun 05, 2013 at 07:57:42AM -0500, Anthony Liguori wrote:
Wanlong Gao gaowanl...@cn.fujitsu.com writes:
Add monitor command mem-nodes to show the huge mapped
memory nodes
On Wed, Jun 05, 2013 at 07:57:11PM +0100, Peter Maydell wrote:
On 5 June 2013 19:31, Eduardo Habkost ehabk...@redhat.com wrote:
On Wed, Jun 05, 2013 at 07:29:46PM +0200, Andreas Färber wrote:
Am 05.06.2013 19:17, schrieb Eduardo Habkost:
We have had this discussion before, and I remember
On Tue, Jun 11, 2013 at 03:22:13PM +0800, Wanlong Gao wrote:
On 06/05/2013 09:46 PM, Eduardo Habkost wrote:
On Wed, Jun 05, 2013 at 11:58:25AM +0800, Wanlong Gao wrote:
Add monitor command mem-nodes to show the huge mapped
memory nodes locations.
This is for machine consumption, so
On Sat, Sep 28, 2013 at 12:49:04PM +0200, Borislav Petkov wrote:
On Fri, Sep 27, 2013 at 11:21:34AM -0300, Eduardo Habkost wrote:
The problem here is that requested_features doesn't include just
the explicit +flag flags, but any flag included in the CPU model
definition. See the -cpu n270
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
savevm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/savevm.c b/savevm.c
index 2f631d4..208e7c2 100644
--- a/savevm.c
+++ b/savevm.c
@@ -1729,7 +1729,8 @@ int vmstate_load_state(QEMUFile *f, const
VMStateDescription
that doesn't have max_version_id set.
One possible use case for this is the the cpu section, where the xsave CPU
state could be made optional by moving it to a xsave section, and then revert
version_id back to 11 while still accepting version_id==12 migration data.
Eduardo Habkost (5):
savevm
This will allow us to load data that has a high version_id, while using
a lower version_id when saving.
Useful in case we need to revert vmstate changes but keep compatibility
with QEMU versions that had a higher version_id.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
include
This makes the code more readable, making each condition that makes a
field be skipped much more visible, and reduces one level of indentation
in the code.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
savevm.c | 156 ---
1
This will make it easier to add code that skips some fields, by simply
using continue.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
savevm.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/savevm.c b/savevm.c
index 208e7c2..9562669 100644
--- a/savevm.c
This will allow fields to have version_id vmsd-version_id, to allow
us to support loading data with higher version_id.
This patch alone is not useful by itself, but it will be useful when
introducing the max_version_id field to VMStateDescription.
Signed-off-by: Eduardo Habkost ehabk
On Tue, Oct 15, 2013 at 10:01:12AM +0200, Markus Armbruster wrote:
Eduardo Habkost ehabk...@redhat.com writes:
This makes the code more readable, making each condition that makes a
field be skipped much more visible, and reduces one level of indentation
in the code.
Signed-off
by default for all machine types
including 1.7 as it was never exposed/used by guest.
And properly remove/cleanup it during 1.8 development cycle.
Signed-off-by: Igor Mammedov imamm...@redhat.com
Reviewed-by: Eduardo Habkost ehabk...@redhat.com
--
Eduardo
On Wed, Oct 30, 2013 at 01:56:39PM +0100, arm...@redhat.com wrote:
From: Markus Armbruster arm...@redhat.com
Put it in QEMUMachineInitArgs, so I don't have to touch every board.
Signed-off-by: Markus Armbruster arm...@redhat.com
Reviewed-by: Eduardo Habkost ehabk...@redhat.com
--
Eduardo
from QEMUMachine desc and
name.
Take care to do this only for new machine types, of course.
Signed-off-by: Markus Armbruster arm...@redhat.com
Reviewed-by: Eduardo Habkost ehabk...@redhat.com
--
Eduardo
On Wed, Oct 30, 2013 at 04:18:16PM +0200, Michael S. Tsirkin wrote:
On Wed, Oct 30, 2013 at 01:56:40PM +0100, arm...@redhat.com wrote:
From: Markus Armbruster arm...@redhat.com
Currently, we get SeaBIOS defaults: manufacturer Bochs, product Bochs,
no version. Best SeaBIOS can do, but we
On Wed, Oct 30, 2013 at 09:22:38PM +0100, Markus Armbruster wrote:
Michael S. Tsirkin m...@redhat.com writes:
On Wed, Oct 30, 2013 at 04:18:37PM +0100, Markus Armbruster wrote:
Michael S. Tsirkin m...@redhat.com writes:
On Wed, Oct 30, 2013 at 12:29:16PM -0200, Eduardo Habkost wrote
of member name, because
that has always been ABI.
Signed-off-by: Markus Armbruster arm...@redhat.com
Reviewed-by: Eduardo Habkost ehabk...@redhat.com
--
Eduardo
On Mon, Sep 02, 2013 at 07:09:47PM +0200, Benoît Canet wrote:
Signed-off-by: Benoit Canet ben...@irqsave.net
Reviewed-by: Eduardo Habkost ehabk...@redhat.com
Thanks.
Do you have an idea on how QEMU could reflect the real host clock frequency
to the guest when the host cpu
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
include/hw/i386/pc.h | 8
target-i386/cpu.c| 4 ++--
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index 7fb04d8..195e962 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw
On Wed, Sep 11, 2013 at 11:53:46PM +0200, Andreas Färber wrote:
Am 11.09.2013 10:37, schrieb Igor Mammedov:
On Wed, 11 Sep 2013 10:25:58 +0200
Andreas Färber afaer...@suse.de wrote:
Am 11.09.2013 10:22, schrieb Igor Mammedov:
On Tue, 10 Sep 2013 17:48:59 -0300
Eduardo Habkost ehabk
On Thu, Sep 12, 2013 at 11:42:17AM +0300, Michael S. Tsirkin wrote:
On Thu, Sep 12, 2013 at 11:23:46AM +0300, Gal Hammer wrote:
Hi,
I've notice that the virtio-serial Windows' driver doesn't use MSI-X
vectors when running using upstream qemu or
qemu-kvm-1.2.2-13.fc18.x86_64. The same
On Fri, Sep 13, 2013 at 12:03:40AM +0300, Michael S. Tsirkin wrote:
On Thu, Sep 12, 2013 at 04:45:01PM -0300, Eduardo Habkost wrote:
On Thu, Sep 12, 2013 at 11:42:17AM +0300, Michael S. Tsirkin wrote:
On Thu, Sep 12, 2013 at 11:23:46AM +0300, Gal Hammer wrote:
Hi,
I've notice
xsave needs level = 13, and qemu64 has level=4. Try -cpu
qemu64,+xsave,+avx,level=13.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1042561
Title:
Guest has no xsave feature with parameter -cpu
On Wed, Sep 18, 2013 at 04:41:45PM +0200, Andrew Jones wrote:
I don't know yet if want this feature on by default, so for now I'm
just adding support for -cpu ...,+kvm_pv_unhalt.
Signed-off-by: Andrew Jones drjo...@redhat.com
Reviewed-by: Eduardo Habkost ehabk...@redhat.com
---
target
On Wed, Sep 18, 2013 at 04:41:44PM +0200, Andrew Jones wrote:
Signed-off-by: Andrew Jones drjo...@redhat.com
Reviewed-by: Eduardo Habkost ehabk...@redhat.com
---
linux-headers/asm-x86/kvm_para.h | 1 +
linux-headers/linux/kvm.h| 1 +
linux-headers/linux/kvm_para.h | 1
Hi,
I would like to get your opinion on this:
Currently we have x2apic enabled only on SandyBridge and Haswell CPU
models because we try to keep the CPU models closer to real CPUs.
However, x2apic improves performance by reducing the overhead of APIC
accesses, and KVM can emulate it
(CCing Paolo, as he was involved in the previous discussion about TCG vs
KVM CPU models)
On Thu, Sep 19, 2013 at 01:50:58PM +0200, Andreas Färber wrote:
Hi,
Am 18.09.2013 22:39, schrieb Eduardo Habkost:
Hi,
I would like to get your opinion on this:
Currently we have x2apic enabled
and silently disabled by QEMU when initializing the
CPU.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
hw/i386/pc_piix.c | 9 +
hw/i386/pc_q35.c | 9 +
target-i386/cpu.c | 37 +++--
3 files changed, 37 insertions(+), 18 deletions(-)
diff
(CCing qemu-devel and libvir-list)
On Sun, Sep 22, 2013 at 04:44:55PM +0200, Borislav Petkov wrote:
From: Borislav Petkov b...@suse.de
Add support for the KVM_GET_EMULATED_CPUID ioctl and leave feature bits
enabled, when requested by userspace, if kvm emulates them.
Signed-off-by:
On Sun, Sep 22, 2013 at 04:44:50PM +0200, Borislav Petkov wrote:
From: Borislav Petkov b...@suse.de
Add a kvm ioctl which states which system functionality kvm emulates.
The format used is that of CPUID and we return the corresponding CPUID
bits set for which we do emulate functionality.
On Tue, Sep 24, 2013 at 01:04:14PM +0300, Gleb Natapov wrote:
On Tue, Sep 24, 2013 at 11:57:00AM +0200, Borislav Petkov wrote:
On Mon, September 23, 2013 6:28 pm, Eduardo Habkost wrote:
On Sun, Sep 22, 2013 at 04:44:50PM +0200, Borislav Petkov wrote:
From: Borislav Petkov b...@suse.de
On Thu, Sep 26, 2013 at 08:55:24PM +0200, Borislav Petkov wrote:
On Thu, Sep 26, 2013 at 11:19:15AM -0300, Eduardo Habkost wrote:
Then we may have a problem: some CPU models already have movbe
included (e.g. Haswell), and patch 6/6 will make -cpu Haswell get
movbe enabled even
On Thu, Sep 26, 2013 at 10:32:06PM +0200, Borislav Petkov wrote:
On Thu, Sep 26, 2013 at 04:20:59PM -0300, Eduardo Habkost wrote:
Please point me to the code that does this, because I don't see it on
patch 6/6.
@@ -1850,7 +1850,14 @@ static void filter_features_for_kvm(X86CPU *cpu
The series conflict with the current X86CPU static properties series from Igor,
so it may need to be rebased in case Igor's patches get included first.
Eduardo Habkost (2):
i386: pass X86CPU object to cpu_x86_find_by_name()
i386: disable PMU passthrough mode by default
include/hw/i386/pc.h
This will help us change the initialization code to not require carrying
some intermediate values in a x86_def_t struct (and eventually kill the
x86_def_t struct entirely).
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
target-i386/cpu.c | 5 +++--
1 file changed, 3 insertions(+), 2
. different number of PMU counters).
This patch adds a pmu-passthrough property to X86CPU, and set it to
true only on -cpu host, or on pc-*-1.5 and older machine-types.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
include/hw/i386/pc.h | 4
target-i386/cpu-qom.h | 7 +++
target-i386
On Tue, Jul 23, 2013 at 11:18:03AM +0200, Paolo Bonzini wrote:
Il 22/07/2013 21:25, Eduardo Habkost ha scritto:
Bug description: QEMU currently gets all bits from GET_SUPPORTED_CPUID
for CPUID leaf 0xA and passes them directly to the guest. This makes
the guest ABI depend on host kernel
On Tue, Jul 23, 2013 at 08:01:29AM +0200, Igor Mammedov wrote:
On Mon, 22 Jul 2013 16:25:35 -0300
Eduardo Habkost ehabk...@redhat.com wrote:
Bug description: QEMU currently gets all bits from GET_SUPPORTED_CPUID
for CPUID leaf 0xA and passes them directly to the guest. This makes
On Tue, Jul 23, 2013 at 05:09:02PM +0200, Paolo Bonzini wrote:
Il 23/07/2013 16:13, Eduardo Habkost ha scritto:
On Tue, Jul 23, 2013 at 11:18:03AM +0200, Paolo Bonzini wrote:
Il 22/07/2013 21:25, Eduardo Habkost ha scritto:
Bug description: QEMU currently gets all bits from
On Tue, Jul 23, 2013 at 06:23:08PM +0200, Paolo Bonzini wrote:
Il 23/07/2013 17:40, Eduardo Habkost ha scritto:
On Tue, Jul 23, 2013 at 05:09:02PM +0200, Paolo Bonzini wrote:
Il 23/07/2013 16:13, Eduardo Habkost ha scritto:
On Tue, Jul 23, 2013 at 11:18:03AM +0200, Paolo Bonzini wrote:
Il
On Tue, Jul 23, 2013 at 09:43:06PM +0200, Paolo Bonzini wrote:
Il 23/07/2013 19:41, Eduardo Habkost ha scritto:
On Tue, Jul 23, 2013 at 06:23:08PM +0200, Paolo Bonzini wrote:
Il 23/07/2013 17:40, Eduardo Habkost ha scritto:
On Tue, Jul 23, 2013 at 05:09:02PM +0200, Paolo Bonzini wrote:
Il
On Wed, Jul 24, 2013 at 03:21:48PM +0200, Paolo Bonzini wrote:
Il 24/07/2013 15:15, Eduardo Habkost ha scritto:
On Tue, Jul 23, 2013 at 09:43:06PM +0200, Paolo Bonzini wrote:
Il 23/07/2013 19:41, Eduardo Habkost ha scritto:
On Tue, Jul 23, 2013 at 06:23:08PM +0200, Paolo Bonzini wrote:
Il
On Tue, Jul 23, 2013 at 05:19:03PM +0100, Daniel P. Berrange wrote:
On Tue, Jul 23, 2013 at 06:11:35PM +0200, Jiri Denemark wrote:
Since QEMU and kvm may filter some host CPU features or add efficiently
emulated features, asking QEMU binary for host CPU data provides
better results when we
On Tue, Jul 23, 2013 at 07:32:46PM +0200, Jiri Denemark wrote:
On Tue, Jul 23, 2013 at 19:28:38 +0200, Jiri Denemark wrote:
On Tue, Jul 23, 2013 at 17:32:42 +0100, Daniel Berrange wrote:
On Tue, Jul 23, 2013 at 06:11:33PM +0200, Jiri Denemark wrote:
---
src/qemu/qemu_monitor.c
On Wed, Jul 24, 2013 at 11:03:03AM +0100, Daniel P. Berrange wrote:
On Tue, Jul 23, 2013 at 07:28:38PM +0200, Jiri Denemark wrote:
On Tue, Jul 23, 2013 at 17:32:42 +0100, Daniel Berrange wrote:
On Tue, Jul 23, 2013 at 06:11:33PM +0200, Jiri Denemark wrote:
---
On Thu, Jul 25, 2013 at 10:45:10AM +0100, Daniel P. Berrange wrote:
On Wed, Jul 24, 2013 at 03:25:19PM -0300, Eduardo Habkost wrote:
On Tue, Jul 23, 2013 at 07:32:46PM +0200, Jiri Denemark wrote:
On Tue, Jul 23, 2013 at 19:28:38 +0200, Jiri Denemark wrote:
On Tue, Jul 23, 2013 at 17:32
On Thu, Jul 25, 2013 at 11:14:16AM +0200, Andreas Färber wrote:
Am 24.07.2013 20:25, schrieb Eduardo Habkost:
In addition to the -cpu host KVM initialization problem, this is an
additional problem with the current interfaces provided by QEMU:
1) libvirt needs to query data that depend
On Thu, Jul 25, 2013 at 04:09:18PM +0200, Andreas Färber wrote:
Am 25.07.2013 16:00, schrieb Eduardo Habkost:
libvirt
needs a way to find out how exactly -machine foo-1.0 -cpu bar looks
different from -machine foo-1.1 -cpu bar,
Why? (What's the actual use case?)
libvirt API allows
On Fri, Jul 26, 2013 at 02:31:24PM +0200, Andreas Färber wrote:
Am 25.07.2013 20:02, schrieb Eduardo Habkost:
On Thu, Jul 25, 2013 at 04:09:18PM +0200, Andreas Färber wrote:
Am 25.07.2013 16:00, schrieb Eduardo Habkost:
libvirt
needs a way to find out how exactly -machine foo-1.0 -cpu bar
On Fri, Jul 26, 2013 at 06:19:16PM +0200, Andreas Färber wrote:
Am 22.07.2013 21:25, schrieb Eduardo Habkost:
The series conflict with the current X86CPU static properties series from
Igor,
so it may need to be rebased in case Igor's patches get included first.
Eduardo Habkost (2
a mode where the PMU CPUID bits are stable and configurable.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
Cc: Paolo Bonzini pbonz...@redhat.com
---
include/hw/i386/pc.h | 4
target-i386/cpu-qom.h | 7 +++
target-i386/cpu.c | 11 ++-
3 files changed, 21 insertions(+), 1
Changes v1 - v2:
* compat property is now named pmu instead of pmu-passthrough
Eduardo Habkost (2):
i386: pass X86CPU object to cpu_x86_find_by_name()
i386: disable PMU CPUID leaves by default
include/hw/i386/pc.h | 4
target-i386/cpu-qom.h | 7 +++
target-i386/cpu.c | 16
This will help us change the initialization code to not require carrying
some intermediate values in a x86_def_t struct (and eventually kill the
x86_def_t struct entirely).
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
target-i386/cpu.c | 5 +++--
1 file changed, 3 insertions(+), 2
On Tue, Jul 23, 2013 at 06:31:45PM +0200, Juan Quintela wrote:
Hi
Please, send any topic that you are interested in covering.
* libvirt requirements for:
* Checking which CPU features are exposed/required by each CPU model
+ machine-type
* Checking which CPU features are
On Sun, Mar 31, 2013 at 01:02:22PM +0200, Aurelien Jarno wrote:
The PCLMULQDQ instruction has been introduced on the Westmere CPU.
Reviewed-by: Richard Henderson r...@twiddle.net
Reviewed-by: Edgar E. Iglesias edgar.igles...@gmail.com
Signed-off-by: Aurelien Jarno aurel...@aurel32.net
---
commit 41cb383f42d0cb51d8e3e25e3ecebc954dd4196f made a guest-visible
change by adding the PCLMULQDQ bit to Westmere without adding
compatibility code to keep the ABI older machine-types. This patch fixes
it by adding the missing compat code.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
On Fri, Aug 09, 2013 at 04:47:53PM +0200, Andreas Färber wrote:
Am 09.08.2013 16:11, schrieb Eduardo Habkost:
commit 41cb383f42d0cb51d8e3e25e3ecebc954dd4196f made a guest-visible
change by adding the PCLMULQDQ bit to Westmere without adding
compatibility code to keep the ABI older machine
On Thu, Aug 08, 2013 at 12:29:07PM -0700, Christoffer Dall wrote:
On Thu, Aug 08, 2013 at 08:05:11PM +0100, Peter Maydell wrote:
On 8 August 2013 19:39, Christoffer Dall christoffer.d...@linaro.org
wrote:
FWIW, from the kernel point of view I'd much prefer to return this is
the type of
options rather than from the host CPUID.
It also turns out that this unsyncing makes Windows Server 2012R2 fail
to boot.
Tested-by: Peter Lieven p...@kamp.de
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Reviewed-by: Eduardo Habkost ehabk...@redhat.com
Probably bits 25-14 of EAX will also
subclasses.
Instead of requiring the kvm_arch_get_supported_cpuid() results to be stored in
the class struct for host (thus requiring KVM initialization hacks).
Eduardo Habkost (8):
target-i386: kvm_cpu_fill_host(): Kill unused code
target-i386: kvm_cpu_fill_host(): No need to check level
Those host_cpuid() calls are useless. They are leftovers from when the
old code using host_cpuid() was removed.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
target-i386/cpu.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 864c80e
Now that the kvm_cpu_fill_host() code is simplified, we can simply set
the feature word array using a simple loop.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
target-i386/cpu.c | 23 +++
1 file changed, 7 insertions(+), 16 deletions(-)
diff --git a/target-i386
() will return 0 if no entry is returned
by the kernel for the requested leaf.
This will simplify the kvm_cpu_fill_host() code a little.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
target-i386/cpu.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/target-i386/cpu.c b
it will be set to 0 CPU vendor
is not Centaur.
This will simplify the kvm_cpu_fill_host() code a little.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
target-i386/cpu.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
);
* kvm_arch_get_supported_cpuid() will return 0 if no entry is returned
by the kernel for the requested leaf.
This will simplify the kvm_cpu_fill_host() code a little.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
target-i386/cpu.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git
We don't need the ft[] array on kvm_check_features_against_host()
anymore, as we can simply use the feature_word_info[] array, that has
everything we need.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
target-i386/cpu.c | 41 -
1 file changed, 8
Reorder the code so all the code that sets x86_cpu_def-features is at
the end of the function.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
target-i386/cpu.c | 24 +---
1 file changed, 9 insertions(+), 15 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386
. Eventually they should become a single
function.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
target-i386/cpu.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 6c540c6..048d87f 100644
--- a/target-i386/cpu.c
+++ b
The compiler is capable of eliminating the KVM-specific function calls
as long as the calling function has an assert(kvm_enabled()) line, so we
don't need to wrap all KVM-specific inside #ifdefs.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
target-i386/cpu.c | 13 ++---
1 file
-email-ehabk...@redhat.com
http://article.gmane.org/gmane.comp.emulators.qemu/243013
Eduardo Habkost (7):
target-i386: Eliminate CONFIG_KVM #ifdefs
target-i386: Don't change x86_def_t struct on cpu_x86_register()
target-i386: Move KVM default-vendor hack to instance_init
target-i386: Rename
As eventually the x86_def_t data is going to be provided by the CPU
class, it's better to not touch it, and handle the special cases on the
X86CPU object itself.
Current behavior of the code should stay exactly the same.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
target-i386/cpu.c
There isn't any kind of registration involved in cpu_x86_register()
anymore: it is simply looking up a CPU model name and loading the model
definition data into the X86CPU object. Rename it to x86_cpu_load_def()
to reflect what it does.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
As the new X86CPU subclass code is going to change lots of the code
invoving x86_def_t, let's rename the struct to match coding style first.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
target-i386/cpu.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions
As we will initialize the X86CPU fields on instance_init eventually,
move the code that initializes the X86CPU data based on the CPU model
name closer to the object_new() call.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
target-i386/cpu.c | 10 +-
1 file changed, 5 insertions
each X86CPUDefinition field to lists of
per-class property defaults.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
This version is closer to the version sent by Andrea and then later
resubmitted by Igor as [RFC v5] target-i386: Slim conversion to X86CPU
subclasses + KVM subclasses
As we will not have a cpu_x86_find_by_name() function anymore,
move the KVM default-vendor hack to instance_init.
Unfortunately we can't move that code to class_init because it depends
on KVM being initialized.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
target-i386/cpu.c | 32
This series separates the QEMUFile and VMState code from savevm.c, and adds a
few unit tests to the VMState code.
Eduardo Habkost (9):
qemu-file: Make a few functions non-static
migration: Move QEMU_VM_* defines to migration/migration.h
savevm: Convert all tabs to spaces
savevm.c: Coding
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
I am submitting this as a separate patch because I don't know if this
will be the preferred way of breaking that line.
---
savevm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/savevm.c b/savevm.c
index 66b8b5e
The VMState code will be moved to vmstate.c and it uses some of the
QEMU_VM_* constants, so move it to a header.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
include/migration/migration.h | 11 +++
savevm.c | 11 ---
2 files changed, 11 insertions
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
savevm.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/savevm.c b/savevm.c
index 46643f1..3cdd5f2 100644
--- a/savevm.c
+++ b/savevm.c
@@ -53,7 +53,7 @@
#define ARP_OP_REQUEST_REV 0x3
static int
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
Makefile.objs | 1 +
qemu-file.c | 826 ++
savevm.c | 820 -
3 files changed, 827 insertions(+), 820 deletions(-)
create
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
savevm.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/savevm.c b/savevm.c
index 8eeb5ef..a2c2173 100644
--- a/savevm.c
+++ b/savevm.c
@@ -166,7 +166,9 @@ static QEMUFile *qemu_fopen_bdrv(BlockDriverState *bs
This will allow unit tests to be written for VMState code without
pulling dependencies from the savevm code.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
Makefile.objs | 1 +
savevm.c | 645 -
vmstate.c | 650
* Basic load/save tests
* Tests for loading older versions
* Tests for .field_exists() handling
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
tests/.gitignore | 1 +
tests/Makefile | 4 +
tests/test-vmstate.c | 357 +++
3
On Thu, Nov 28, 2013 at 03:13:39PM +0100, Andreas Färber wrote:
Am 28.11.2013 15:01, schrieb Eduardo Habkost:
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
savevm.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/savevm.c b/savevm.c
index
On Thu, Jul 04, 2013 at 05:53:08PM +0800, Wanlong Gao wrote:
From: Bandan Das b...@redhat.com
This allows us to use the cpus property multiple times
to specify multiple cpu (ranges) to the -numa option :
-numa node,cpus=1,cpus=2,cpus=4
or
-numa node,cpus=1-3,cpus=5
Note that after
On Thu, Jul 04, 2013 at 05:53:07PM +0800, Wanlong Gao wrote:
[...]
Bandan Das (1):
NUMA: Support multiple CPU ranges on -numa option
Wanlong Gao (9):
NUMA: Add numa_info structure to contain numa nodes info
NUMA: Add Linux libnuma detection
NUMA: parse guest numa nodes memory
1 - 100 of 11343 matches
Mail list logo
