[Qemu-devel] [Bug 1814352] [NEW] SIOCGIFNAME takes a struct ifreq not an integer

2019-02-01 Thread Erik Kline
Public bug reported: The ioctl SIOCGIFNAME takes a pointer to a struct ifreq, not an integer. This leads to if_indextoname() not correctly returning interface names (well, not if they're longer than 4 characters including the trailing NULL ;-). This is observed on v3.1.0. The following one-line

Re: [Qemu-devel] [Bug 1814352] Re: SIOCGIFNAME takes a struct ifreq not an integer

2019-04-09 Thread Erik Kline
Sure. Looking at HEAD, and even the surrounding the lines, I think I should have tried STRUCT_short_ifreq instead of STRUCT_int_ifreq, though I'm not sure what the real difference would be. I'll try to test internally with the _short_ version and if that works send that. -- You received this

Re: [Qemu-devel] [PATCH] The ioctl(SIOCGIFNAME) call requires a struct ifreq.

2019-05-09 Thread Erik Kline
Anything else I need to do? On Wed, 24 Apr 2019 at 02:10, Peter Maydell wrote: > On Tue, 23 Apr 2019 at 23:28, Erik Kline via Qemu-devel > wrote: > > > > Signed-off-by: Erik Kline > > Buglink: https://bugs.launchpad.net/qemu/+bug/1814352 > > --- > > li

[Qemu-devel] [Bug 1814352] Re: SIOCGIFNAME takes a struct ifreq not an integer

2019-05-10 Thread Erik Kline
Thank you, all. ** Changed in: qemu Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1814352 Title: SIOCGIFNAME takes a struct ifreq not an integer Status

[Qemu-devel] [Bug 1814352] Re: SIOCGIFNAME takes a struct ifreq not an integer

2019-05-10 Thread Erik Kline
https://git.qemu.org/?p=qemu.git;a=commit;h=43330b7169ae76222472a4b20c7f4db9d8880527 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1814352 Title: SIOCGIFNAME takes a struct ifreq not an integer

[Qemu-devel] [Bug 1814352] Re: SIOCGIFNAME takes a struct ifreq not an integer

2019-04-29 Thread Erik Kline
Please let me know if further work or another patch submission is required. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1814352 Title: SIOCGIFNAME takes a struct ifreq not an integer Status in

[Qemu-devel] [Bug 1814352] Re: SIOCGIFNAME takes a struct ifreq not an integer

2019-05-06 Thread Erik Kline
Please let me know if further work or another patch submission is required. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1814352 Title: SIOCGIFNAME takes a struct ifreq not an integer Status in

[Qemu-devel] [Bug 1814352] Re: SIOCGIFNAME takes a struct ifreq not an integer

2019-04-23 Thread Erik Kline
Patch sent to the list. Apologies for the delay. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1814352 Title: SIOCGIFNAME takes a struct ifreq not an integer Status in QEMU: Confirmed Bug

[Qemu-devel] [Bug 1814352] Re: SIOCGIFNAME takes a struct ifreq not an integer

2019-08-15 Thread Erik Kline
Released as part of v4.1.0. ** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1814352 Title: SIOCGIFNAME takes a struct ifreq not an

Re: [RFC PATCH 06/21] contrib/gitdm: Add Google to the domain map

2020-10-05 Thread Erik Kline
LGTM Acked-by: Erik Kline On Sun, Oct 4, 2020 at 11:04 AM Philippe Mathieu-Daudé wrote: > > There is a number of contributors from this domain, > add its own entry to the gitdm domain map. > > Cc: Andrew Oates > Cc: Catalin Patulea > Cc: Christian Svensson > Cc: Da

[Qemu-devel] [PATCH] The ioctl(SIOCGIFNAME) call requires a struct ifreq.

2019-04-23 Thread Erik Kline via Qemu-devel
Signed-off-by: Erik Kline Buglink: https://bugs.launchpad.net/qemu/+bug/1814352 --- linux-user/ioctls.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/ioctls.h b/linux-user/ioctls.h index ae8951625f..37501f575c 100644 --- a/linux-user/ioctls.h +++ b/linux-user