Re: [Qemu-devel] seabios for qemu 1.5

2013-05-27 Thread Gerd Hoffmann
Hi, | commit 11a7234491cb2a027b0fa5e82af38a3e78b44c80 | Author: Kevin O'Connor ke...@koconnor.net | Date: Tue Mar 5 17:52:21 2013 +0800 | | Cache boot-fail-wait to avoid romfile access after POST. | | Memory allocated with malloc_tmp() can't be used after the POST phase. |

Re: [Qemu-devel] [Bug 1180924] [NEW] fails to handle a usb serial port with a specific vendorid

2013-05-27 Thread Gerd Hoffmann
Hi, (this is what the documentation says about how I shoud add a usb device which has a serial port interface and which has a specific vendor id, I used the documentation located here: http://qemu.weilnetz.de/qemu-doc.html ), it says char device redirected to /dev/pts/something (label

Re: [Qemu-devel] [PATCH 2/4] acpi/gpe: expand bits of gpe register

2013-05-27 Thread Gerd Hoffmann
On 05/24/13 04:02, li guang wrote: 在 2013-05-24五的 10:24 +0900,Isaku Yamahata写道: On Wed, May 22, 2013 at 01:37:41PM +0800, li guang wrote: 在 2013-05-22三的 14:28 +0900,Isaku Yamahata写道: Why? And it breaks pointer operation like the fact is I can't guess why gpe-sts is defined uint8_t but the

Re: [Qemu-devel] [PATCH 2/4] acpi/gpe: expand bits of gpe register

2013-05-27 Thread Gerd Hoffmann
On 05/24/13 04:02, li guang wrote: 在 2013-05-24五的 10:24 +0900,Isaku Yamahata写道: On Wed, May 22, 2013 at 01:37:41PM +0800, li guang wrote: 在 2013-05-22三的 14:28 +0900,Isaku Yamahata写道: Why? And it breaks pointer operation like the fact is I can't guess why gpe-sts is defined uint8_t but the

Re: [Qemu-devel] [PATCH 0/4] debugcon: fix some bugs when DEBUG_DEBUGCON

2013-05-27 Thread Gerd Hoffmann
On 05/24/13 04:47, liguang wrote: when enable DEBUG_DEBUGCON, there are some message printing bugs, so fix them. I'd suggest to either simply remove the debug printfs or turn them into tracepoints. cheers, Gerd

Re: [Qemu-devel] [PATCH 0/4] debugcon: fix some bugs when DEBUG_DEBUGCON

2013-05-27 Thread Gerd Hoffmann
On 05/28/13 02:31, li guang wrote: 在 2013-05-27一的 11:13 +0200,Gerd Hoffmann写道: On 05/24/13 04:47, liguang wrote: when enable DEBUG_DEBUGCON, there are some message printing bugs, so fix them. I'd suggest to either simply remove the debug printfs or turn them into tracepoints. sorry, why

[Qemu-devel] [PATCH 2/2] chardev: fix info chardev output

2013-05-28 Thread Gerd Hoffmann
Fill unset CharDriverState-filename with the backend name, so 'info chardev' will return at least the chardev type. Don't touch it in case the chardev init function filled it already, like the socket+pty chardevs do for example. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- qemu-char.c

[Qemu-devel] [PULL 0/2] chardev: fix info chardev output

2013-05-28 Thread Gerd Hoffmann
at: git://git.kraxel.org/qemu chardev.6 for you to fetch changes up to 60d95386abf1f5f37ded6a812d12ac458df2491b: chardev: fix info chardev output (2013-05-27 12:47:28 +0200) Gerd Hoffmann (2): Revert chardev: Get filename

[Qemu-devel] [PATCH 1/2] Revert chardev: Get filename for new qapi backend

2013-05-28 Thread Gerd Hoffmann
Does not handle chardevs created via chardev-add monitor command. This reverts commit 2b220025993e76d4116781ca91a4fabc5ad9c722. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- qemu-char.c |2 -- 1 file changed, 2 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 4f8382e..f825294

Re: [Qemu-devel] [PATCH 1/3] qemu_chr_new_from_opts: do not overwrite existing chr-filename

2013-05-28 Thread Gerd Hoffmann
On 05/27/13 20:13, Stefano Stabellini wrote: Set the new filename only if it hasn't been already set (for example by qemu_chr_open_pty). This fixes a regression that prevents Xen HVM domains from booting. It was introduced by: commit 2b220025993e76d4116781ca91a4fabc5ad9c722 Author: Lei

Re: [Qemu-devel] [PATCH 2/2] chardev: fix info chardev output

2013-05-28 Thread Gerd Hoffmann
On 05/28/13 08:34, Gerd Hoffmann wrote: Fill unset CharDriverState-filename with the backend name, so 'info chardev' will return at least the chardev type. Don't touch it in case the chardev init function filled it already, like the socket+pty chardevs do for example. Signed-off-by: Gerd

[Qemu-devel] [PATCH 1/2] Revert chardev: Get filename for new qapi backend

2013-05-28 Thread Gerd Hoffmann
Does not handle chardevs created via chardev-add monitor command. This reverts commit 2b220025993e76d4116781ca91a4fabc5ad9c722. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- qemu-char.c |2 -- 1 file changed, 2 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 4f8382e..f825294

[Qemu-devel] [PATCH 2/2] chardev: fix info chardev output

2013-05-28 Thread Gerd Hoffmann
Fill unset CharDriverState-filename with the backend name, so 'info chardev' will return at least the chardev type. Don't touch it in case the chardev init function filled it already, like the socket+pty chardevs do for example. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- qemu-char.c

[Qemu-devel] [PULL 0/2] chardev: fix info chardev output

2013-05-28 Thread Gerd Hoffmann
at: git://git.kraxel.org/qemu chardev.6 for you to fetch changes up to 60d95386abf1f5f37ded6a812d12ac458df2491b: chardev: fix info chardev output (2013-05-27 12:47:28 +0200) Gerd Hoffmann (2): Revert chardev: Get filename

[Qemu-devel] [PULL 0/2] update seabios to release 1.7.2.2

2013-05-28 Thread Gerd Hoffmann
+) are available in the git repository at: git://git.kraxel.org/qemu seabios-1.7.2.2 for you to fetch changes up to 6683d7bc2759e9da8b5c4907a9de85d500933ffb: update seabios to release 1.7.2.2 (2013-05-28 12:19:02 +0200) Gerd

[Qemu-devel] [PATCH 2/2] update seabios to release 1.7.2.2

2013-05-28 Thread Gerd Hoffmann
git shortlog from 1.7.2.1 Asias He (2): virtio-scsi: Pack struct virtio_scsi_{req_cmd,resp_cmd} virtio-scsi: Set _DRIVER_OK flag before scsi target scanning Kevin O'Connor (1): Cache boot-fail-wait to avoid romfile access after POST. Signed-off-by: Gerd Hoffmann kra

[Qemu-devel] [PATCH 1/2] Revert roms: switch oldnoconfig to olddefconfig

2013-05-28 Thread Gerd Hoffmann
This reverts commit a5519b42cfd6c00e9f8b31c5aad7682e7a9f1181. Breaks make bios in roms/ as the kconfig version in seabios doesn't support olddefconfig. Must have been be totally untested. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- roms/configure-seabios.sh |2 +- 1 file changed, 1

Re: [Qemu-devel] [SeaBIOS] [PULL 0/2] chardev: fix info chardev output

2013-05-28 Thread Gerd Hoffmann
On 05/28/13 12:27, Gerd Hoffmann wrote: Hi, Tiny series, first reverting the broken patch from Lei Li, then fixing it for real. Oops, scratch that. Resent an old series due to 'git send-email 00*.patch' in the wrong directory. sorry, Gerd

Re: [Qemu-devel] [PATCH] Fix usage of USB_DEV_FLAG_IS_HOST flag.

2013-05-28 Thread Gerd Hoffmann
Hi, Looks good. Anthony? Can you pick it for 1.5 directly? I don't have any other pending usb bits for 1.5 at the moment. Reviewed-by: Gerd Hoffmann kra...@redhat.com cheers, Gerd Ping, looks like this hasn't managed to land in master yet and just wanted to make sure

Re: [Qemu-devel] [PATCH] host-libusb: Correct test for USB packet state

2013-05-28 Thread Gerd Hoffmann
On 05/21/13 15:45, Ed Maste wrote: On 7 May 2013 10:06, Ed Maste ema...@freebsd.org wrote: USB_RET_ASYNC is -6, so inflight was always false. Ping. I believe the if (inflight) block in usb_host_req_abort() can never be executed in the current code. Patch added to usb patch queue. thanks,

Re: [Qemu-devel] [coreboot] [SeaBIOS] SeaBIOS v1.7.2.2 stable release

2013-05-29 Thread Gerd Hoffmann
On 05/29/13 02:08, Kevin O'Connor wrote: On Mon, May 27, 2013 at 05:11:46PM +0400, Michael Tokarev wrote: 27.05.2013 16:59, Kevin O'Connor wrote: A new stable release of SeaBIOS (version 1.7.2.2) has been tagged. This release contains bug fixes. The release is available via git: git clone

Re: [Qemu-devel] [SeaBIOS] KVM call agenda for 2013-05-28

2013-05-29 Thread Gerd Hoffmann
On 05/29/13 01:53, Kevin O'Connor wrote: On Thu, May 23, 2013 at 03:41:32PM +0300, Michael S. Tsirkin wrote: Juan is not available now, and Anthony asked for agenda to be sent early. So here comes: Agenda for the meeting Tue, May 28: - Generating acpi tables I didn't see any meeting

Re: [Qemu-devel] [SeaBIOS] KVM call agenda for 2013-05-28

2013-05-29 Thread Gerd Hoffmann
Hi, possible complexity of having to regenerate tables on a vm reboot, Why tables should be regenerated at reboot? I remember hotplug being mentioned in the call. Hmm? Which hotplugged component needs acpi table updates to work properly? And what is the point of hotplugging if you

Re: [Qemu-devel] [SeaBIOS] KVM call agenda for 2013-05-28

2013-05-30 Thread Gerd Hoffmann
Hi, Raised that QOM interface should be sufficient. Agree on this one. Ideally the acpi table generation code should be able to gather all information it needs from the qom tree, so it can be a standalone C file instead of being scattered over all qemu. Ack. So my basic argument is

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-30 Thread Gerd Hoffmann
Hi, Why should this be true? Shouldn't we be allowed to increase the amount of memory the guest has across reboots? That's equivalent to adding another DIMM after power off. poweroff is equivalent to exiting qemu, not to guest reset. Not generating tables on reset does limit what we can

Re: [Qemu-devel] [PATCH v2 2/5] pci: store PCI hole ranges in guestinfo structure

2013-05-30 Thread Gerd Hoffmann
Hi, +} else { +guest_info-pci_info.w64.begin = 0x1ULL + above_4g_mem_size; +guest_info-pci_info.w64.end = guest_info-pci_info.w64.begin + +(0x1ULL 62); Doesn't this give unaligned windows? +/* Set PCI window size the way seabios has always

Re: [Qemu-devel] [PATCH v2 2/5] pci: store PCI hole ranges in guestinfo structure

2013-05-30 Thread Gerd Hoffmann
On 05/30/13 14:19, Michael S. Tsirkin wrote: On Thu, May 30, 2013 at 02:16:13PM +0200, Gerd Hoffmann wrote: Hi, +} else { +guest_info-pci_info.w64.begin = 0x1ULL + above_4g_mem_size; +guest_info-pci_info.w64.end = guest_info-pci_info.w64.begin

Re: [Qemu-devel] [PATCH v2 2/5] pci: store PCI hole ranges in guestinfo structure

2013-05-30 Thread Gerd Hoffmann
Hi, I see. I'll figure out the details and add a comment to this end. But that's for the 32 bit window - I don't see it playing with mtrrs for the 64 bit ranges. So I'm guessing alignment isn't needed there, right? mtrr's are a 32bit thing anyway IIRC. I still would place the 64bit

Re: [Qemu-devel] [SeaBIOS] KVM call agenda for 2013-05-28

2013-05-31 Thread Gerd Hoffmann
Hi, I guess -bios would load coreboot. Coreboot would siphon the data necessary for ACPI table building through the current (same) fw_cfg bottleneck, build the tables, Yes. load the boot firmware (SeaBIOS or OVMF or something else -- not sure how to configure that), The coreboot rom has

Re: [Qemu-devel] [SeaBIOS] KVM call agenda for 2013-05-28

2013-05-31 Thread Gerd Hoffmann
On 05/31/13 10:13, Peter Stuge wrote: Kevin O'Connor wrote: one possible way forward would be to split the current SeaBIOS rom into two roms: qvmloader and seabios. The qvmloader would do the qemu specific platform init (pci init, smm init, mtrr init, bios tables) and then load and run the

Re: [Qemu-devel] [PATCH 2/2] chardev: fix info chardev output

2013-05-31 Thread Gerd Hoffmann
Hi, Without this patch the returned message for query-chardev is: { return: [ { filename: pty:/dev/pts/8, label: charserial0 }, { filename: unix:/var/lib/libvirt/qemu/qemu-git.monitor,server, label:

Re: [Qemu-devel] [SeaBIOS] KVM call agenda for 2013-05-28

2013-06-02 Thread Gerd Hoffmann
On 06/01/13 01:01, Jordan Justen wrote: On Fri, May 31, 2013 at 2:32 AM, Gerd Hoffmann kra...@redhat.com wrote: Hi, I guess -bios would load coreboot. Coreboot would siphon the data necessary for ACPI table building through the current (same) fw_cfg bottleneck, build the tables, Yes

[Qemu-devel] [PATCH 3/7] pci: add VMSTATE_MSIX

2013-06-03 Thread Gerd Hoffmann
Using a trick cut+pasted from vmstate_scsi_device to wind up msix_save and msix_load. Signed-off-by: Gerd Hoffmann kra...@redhat.com Acked-by: Michael S. Tsirkin m...@redhat.com --- hw/pci/msix.c | 33 + include/hw/pci/msix.h | 11 +++ 2 files

[Qemu-devel] [PATCH 4/7] xhci: add XHCISlot-addressed

2013-06-03 Thread Gerd Hoffmann
Preparing for live-migration support, post_load will need that. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/hcd-xhci.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 8813bdf..ac683ce 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb

[Qemu-devel] [PULL 0/7] usb patch queue

2013-06-03 Thread Gerd Hoffmann
state Gerd Hoffmann (5): pci: add VMSTATE_MSIX xhci: add XHCISlot-addressed xhci: add xhci_alloc_epctx xhci: add xhci_init_epctx xhci: add live migration support Michael Marineau (1): Fix usage of USB_DEV_FLAG_IS_HOST flag. hw/pci/msix.c | 33

[Qemu-devel] [PATCH 1/7] Fix usage of USB_DEV_FLAG_IS_HOST flag.

2013-06-03 Thread Gerd Hoffmann
From: Michael Marineau m...@marineau.org USB_DEV_FLAG_IS_HOST is the bit number, not value. Booting with a Fitbit Base Station USB dongle was triggering this assert. Signed-off-by: Michael Marineau m...@marineau.org Cc: qemu-sta...@nongnu.org Signed-off-by: Gerd Hoffmann kra...@redhat.com

[Qemu-devel] [PATCH 5/7] xhci: add xhci_alloc_epctx

2013-06-03 Thread Gerd Hoffmann
Factor out endpoint context allocation to a separate function. xhci live migration will need that too, in post_load. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/hcd-xhci.c | 32 +--- 1 file changed, 21 insertions(+), 11 deletions(-) diff --git a/hw

[Qemu-devel] [PATCH 2/7] host-libusb: Correct test for USB packet state

2013-06-03 Thread Gerd Hoffmann
From: Ed Maste ema...@freebsd.org USB_RET_ASYNC is -6, so inflight was always false. Signed-off-by: Ed Maste ema...@freebsd.org Cc: qemu-sta...@nongnu.org Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/host-libusb.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH 6/7] xhci: add xhci_init_epctx

2013-06-03 Thread Gerd Hoffmann
Factor out endpoint context initialization to a separate function. xhci live migration will need that too, in post_load. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/hcd-xhci.c | 43 +-- 1 file changed, 25 insertions(+), 18 deletions

[Qemu-devel] [PATCH 7/7] xhci: add live migration support

2013-06-03 Thread Gerd Hoffmann
With all preparing pieces in place we can finally drop in the vmstate structs and the postload function. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/hcd-xhci.c | 164 - 1 file changed, 163 insertions(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [PATCH v2] gtk: don't use g_object_unref on GdkCursor

2013-06-04 Thread Gerd Hoffmann
On 06/03/13 23:14, Anthony Liguori wrote: -g_object_unref(cursor); +gdk_cursor_unref(cursor); Reviewed-by: Gerd Hoffmann kra...@redhat.com cheers, Gerd

Re: [Qemu-devel] gtk UI doesn't correctly byte swap 32-bit framebuffer on qemu-system-ppc little-endian host

2013-06-04 Thread Gerd Hoffmann
? No, but asking pixman to do it is easy, see attached patch. cheers, Gerd From 488a5fa74c6112364885c4ab4c369cb1ed096c64 Mon Sep 17 00:00:00 2001 From: Gerd Hoffmann kra...@redhat.com Date: Tue, 4 Jun 2013 09:36:52 +0200 Subject: [PATCH] gtk: add support for surface conversion Also use

Re: [Qemu-devel] kFreeBSD and USB support

2013-06-06 Thread Gerd Hoffmann
Hi, This effectively disables host usb support for kFreeBSD. And since I guess the kernel headers are the same on regular FreeBSD, I think the same issue happens on regular FreeBSD too, that is, host usb does not work there as well. What is the status of this situation now? I have no

Re: [Qemu-devel] [PATCH v5 0/5] usb: QOM realize support for SysBus EHCI and FUSBH200

2013-06-06 Thread Gerd Hoffmann
On 06/06/13 15:41, Andreas Färber wrote: Hello Gerd, v5 is a clean automatic rebase, as requested earlier. Patch series added to usb patch queue. thanks, Gerd

Re: [Qemu-devel] [PATCH v2 2/2] audio/intel-hda: QOM casting sweep

2013-06-06 Thread Gerd Hoffmann
On 06/06/13 07:34, peter.crosthwa...@xilinx.com wrote: From: Peter Crosthwaite peter.crosthwa...@xilinx.com Define and use standard QOM cast macro. Remove usages of DO_UPCAST and direct - style casting. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Reviewed-by: Gerd

Re: [Qemu-devel] [PATCH v2 1/2] audio/intel-hda: Fix Inheritance hierachy

2013-06-06 Thread Gerd Hoffmann
implementation functions. Went for option B, with a common base class. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Reviewed-by: Gerd Hoffmann kra...@redhat.com cheers, Gerd

Re: [Qemu-devel] [PATCH 2/2] usb/host-libusb: Fix building with libusb git master code

2013-06-06 Thread Gerd Hoffmann
On 06/06/13 16:39, Hans de Goede wrote: The next libusb release will deprecate libusb_get_port_path, and since we compile with -Werror, this breaks the build. Patch added to usb patch queue. thanks, Gerd

Re: [Qemu-devel] [PATCH 1/2] device_tree: Fix build with latest libfdt

2013-06-06 Thread Gerd Hoffmann
On 06/06/13 16:39, Hans de Goede wrote: We override libfdt_env.h with our own copy, and the latest libfdt expects libfdt_env.h to define fdt##_t types. Looks sane to me, but I'll leave that to the fdt experts ... cheers, Gerd

[Qemu-devel] [PATCH] fix Coverity scan SIGN_EXTENSION error

2013-06-06 Thread Gerd Hoffmann
Cc: Markus Armbruster arm...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/display/qxl-render.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/display/qxl-render.c b/hw/display/qxl-render.c index f511a62..269b1a7 100644 --- a/hw/display/qxl-render.c

[Qemu-devel] [PATCH] console: nicer initial screen

2013-06-06 Thread Gerd Hoffmann
initialized yet by the guest. You can see this in action when starting qemu with '-S'. Also when booting ovmf in qemu (which needs a few moments to initialize itself before it initializes the vga). Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/console.c | 19 +++ 1 file

[Qemu-devel] [PATCH 2/2] fbdev: add monitor command to enable/disable

2013-06-06 Thread Gerd Hoffmann
This patch adds a fbdev monitor command to enable/disable the fbdev display at runtime to both qmp and hmp. qmp: framebuffer-display enable=on|off scale=on|off device=/dev/fbn hmp: framebuffer-display on|off Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hmp-commands.hx | 15

[Qemu-devel] [PATCH 1/2] fbdev: add linux framebuffer display driver.

2013-06-06 Thread Gerd Hoffmann
to it (usually requires root privileges to open /dev/ttynr). Signed-off-by: Gerd Hoffmann kra...@redhat.com --- configure | 12 + include/sysemu/sysemu.h |1 + include/ui/console.h|4 + qemu-options.hx |4 +- trace-events| 14 + ui

Re: [Qemu-devel] RFH: boot from virtio cdrom?

2013-06-07 Thread Gerd Hoffmann
On 06/06/13 17:10, Philipp Hahn wrote: Hello, I'm using libvirt to manage my VMs and configured one VM to boot from a CDROM connected via virtio. This does neither work with QEMU-1.1.2 nor with QEMU-1.5; neither with SeaBIOS is 1.7.0 nor 1.7.2. Doesn't work with virtio-blk, virtio-scsi can

Re: [Qemu-devel] [Qemu-trivial] [PATCH] ioport/memory: check that both .read and .write callbacks are defined

2013-06-09 Thread Gerd Hoffmann
Hi, Maybe instead (or in addition to), we should provide a dummy read or write functions -- instead of fixing each such occurence to use its own dummy function Makes sense, especially for write where we can just ignore what the guest attempts to write. Not sure we can have a generic

Re: [Qemu-devel] [PATCH] chardev: add baud parameter for serial host device

2013-06-09 Thread Gerd Hoffmann
On 06/08/13 23:49, Peter Wu wrote: When QEMU starts, it always changes the serial port parameters including baud rate. This confused my guest which thought it was outputting at 9600 baud while it was in fact changed to 115200. After this patch, I can use `-serial /dev/ttyS0,baud=9600` to

Re: [Qemu-devel] [PATCH] chardev: add baud parameter for serial host device

2013-06-10 Thread Gerd Hoffmann
On 06/10/13 10:42, Peter Wu wrote: On Monday 10 June 2013 07:56:01 Gerd Hoffmann wrote: On 06/08/13 23:49, Peter Wu wrote: When QEMU starts, it always changes the serial port parameters including baud rate. This confused my guest which thought it was outputting at 9600 baud while

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-10 Thread Gerd Hoffmann
Hi, * Use of glib's GArray makes it much easier to build up tables in code without need for iasl and code patching Nice. Design: - each bus gets assigned a number 0-255 - generated ACPI code writes this number to a new BSEL register, then uses existing

Re: [Qemu-devel] [PATCH] spice: Add -spice disable-agent-file-transfer cmdline option (rhbz#961850)

2013-06-10 Thread Gerd Hoffmann
On 06/08/13 15:37, Hans de Goede wrote: Signed-off-by: Hans de Goede hdego...@redhat.com Patch added to spice patch queue. thanks, Gerd

Re: [Qemu-devel] [PATCH] console: nicer initial screen

2013-06-11 Thread Gerd Hoffmann
Hi, This patch adds a text line to the in initial DisplaySurface, notifying the user that the display isn't initialized yet by the guest. Dunno if I said this in the previous posting, but what about just blitting an image? Why? And which one? This text isn't internationalized. We can

Re: [Qemu-devel] [PATCH 1/2] fbdev: add linux framebuffer display driver.

2013-06-11 Thread Gerd Hoffmann
Hi, +static QEMUCursor *ptr_cursor; +static pixman_image_t *ptr_image; +static intptr_refresh; +static intpx, py, pw, ph; +static intmx, my, mon; + +/* options */ +static int

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-11 Thread Gerd Hoffmann
Hi, Portability: - Non x86 (or any Linux) platforms don't need any of this code. They can keep happily using SHPC the way they always did. Hmm. Is is possible to write a SHPC driver in AML? I think it would be alot better to have one guest/host interface for pci bridge

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-11 Thread Gerd Hoffmann
Hi, Yes and not just because of windows guests. ACPI spec is also very explicit that native hotplug is an optional feature. Test suites such as WHQL are known to test spec compliance. /me looks a bit surprised. This pretty much implies that any shpc bridge needs a second interface to the

Re: [Qemu-devel] [PATCH 1/2] fbdev: add linux framebuffer display driver.

2013-06-12 Thread Gerd Hoffmann
On 06/11/13 08:12, Gerd Hoffmann wrote: Hi, +static QEMUCursor *ptr_cursor; +static pixman_image_t *ptr_image; +static intptr_refresh; +static intpx, py, pw, ph; +static intmx, my, mon

[Qemu-devel] [PATCH] console: Hook QemuConsoles into qom tree

2013-06-12 Thread Gerd Hoffmann
Put them named console[$index] below /backend, so you can list inspect them via QMP. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/console.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/ui/console.c b/ui/console.c index 1a9ea93..07d4d63 100644 --- a/ui/console.c

[Qemu-devel] [PATCH] console: extend screendump monitor cmd

2013-06-12 Thread Gerd Hoffmann
Add an optional device parameter to the screendump command. https://bugzilla.redhat.com/show_bug.cgi?id=903910 Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hmp-commands.hx |6 +++--- hmp.c|3 ++- qapi-schema.json |4 +++- qmp-commands.hx |3 ++- ui/console.c

Re: [Qemu-devel] [PATCH] console: extend screendump monitor cmd

2013-06-12 Thread Gerd Hoffmann
Hi, -{ 'command': 'screendump', 'data': {'filename': 'str'} } +{ 'command': 'screendump', 'data': {'filename': 'str', +'*device' : 'str'} } We can't add new optional parameters to QMP commands because it's currently impossible for mngt apps to discover

Re: [Qemu-devel] [Qemu-trivial] [PATCH] pci-ohci: Add missing 'break' in ohci_service_td

2013-09-30 Thread Gerd Hoffmann
Hi, While the actual interesting change (adding break) looks correct, and the whole thing is trivial indeed, this area has a maintainer, -- Cc'ing Gerd for this. If he's okay I'll pick it up. Patch is fine. Acked-by: Gerd Hoffmann kra...@gmail.com cheers, Gerd

Re: [Qemu-devel] [PATCH v6 00/26] qemu: generate acpi tables for the guest

2013-09-30 Thread Gerd Hoffmann
On So, 2013-09-29 at 13:58 +0300, Michael S. Tsirkin wrote: This code can also be found here: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git acpi Reviewed-and-tested-by: Gerd Hoffmann kra...@redhat.com cheers, Gerd

[Qemu-devel] [PATCH 1/9] roms: add 'make clean'

2013-09-30 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- roms/Makefile | 7 +++ 1 file changed, 7 insertions(+) diff --git a/roms/Makefile b/roms/Makefile index 7a228ae..b646060 100644 --- a/roms/Makefile +++ b/roms/Makefile @@ -75,3 +75,10 @@ efi-rom-%: ipxe/src/config/local/general.h ipxe/src

[Qemu-devel] [PULL 0/9] roms: various build improvements

2013-09-30 Thread Gerd Hoffmann
) Gerd Hoffmann (9): roms: add 'make clean' roms: enable parallel builds for 'make lgplvgabios' roms: build lgplvgabios isavga variant roms: parallel ipxe builds roms: rewrite scripts/refresh-pxe-roms.sh roms

[Qemu-devel] [PATCH 5/9] roms: rewrite scripts/refresh-pxe-roms.sh

2013-09-30 Thread Gerd Hoffmann
Just use the Makefile in roms/ Signed-off-by: Gerd Hoffmann kra...@redhat.com --- scripts/refresh-pxe-roms.sh | 80 - 1 file changed, 6 insertions(+), 74 deletions(-) diff --git a/scripts/refresh-pxe-roms.sh b/scripts/refresh-pxe-roms.sh index 14d5860

[Qemu-devel] [PATCH 6/9] roms: add rules to build slof

2013-09-30 Thread Gerd Hoffmann
Add some logic to detect cross compilers. Add support for make slof, which should JustWork[tm] if you are on a ppx64 machine or have a ppc64 cross compiler installed somewhere in your path. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- roms/Makefile | 22 ++ 1 file

[Qemu-devel] [PATCH 8/9] roms: enable parallel seabios / seavgabios builds

2013-09-30 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- roms/Makefile | 29 ++- roms/{config.vga.cirrus = config.vga-cirrus} | 0 roms/{config.vga.isavga = config.vga-isavga} | 0 roms/{config.vga.qxl = config.vga-qxl} | 0 roms

[Qemu-devel] [PATCH 7/9] roms: enable ipxe cross builds

2013-09-30 Thread Gerd Hoffmann
--- roms/Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/roms/Makefile b/roms/Makefile index 5fcc77d..1966f04 100644 --- a/roms/Makefile +++ b/roms/Makefile @@ -31,6 +31,7 @@ find-cross-gcc = $(firstword $(wildcard $(patsubst %ld,%gcc,$(call find-cross-ld find-cross-prefix =

[Qemu-devel] [PATCH 2/9] roms: enable parallel builds for 'make lgplvgabios'

2013-09-30 Thread Gerd Hoffmann
Recurse into vgabios once, adjust dependencies, call make using $(MAKE) $(MAKEFLAGS) so jobserver mode works. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- roms/Makefile | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/roms/Makefile b/roms/Makefile index b646060

[Qemu-devel] [PATCH 4/9] roms: parallel ipxe builds

2013-09-30 Thread Gerd Hoffmann
Enable parallel ipxe builds. Reduce the recursive make calls. Call recursive make properly using $(MAKE) $(MAKEFLAGS). Signed-off-by: Gerd Hoffmann kra...@redhat.com --- roms/Makefile | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/roms/Makefile b/roms

[Qemu-devel] [PATCH 9/9] roms: add support for building sgabios

2013-09-30 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- roms/Makefile | 9 + 1 file changed, 9 insertions(+) diff --git a/roms/Makefile b/roms/Makefile index 6994873..10d5a65 100644 --- a/roms/Makefile +++ b/roms/Makefile @@ -50,6 +50,7 @@ default: @echo bios -- update

[Qemu-devel] [PATCH 3/9] roms: build lgplvgabios isavga variant

2013-09-30 Thread Gerd Hoffmann
Add logic to also build+install the isavga vgabios variant. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- roms/Makefile | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/roms/Makefile b/roms/Makefile index 6d4330f..11d7837 100644 --- a/roms/Makefile +++ b/roms

[Qemu-devel] [PULL 0/1] seabios update to 1.7.3.2

2013-09-30 Thread Gerd Hoffmann
at: git://git.kraxel.org/qemu seabios-1.7.3.2 for you to fetch changes up to 1cf9412b3b583b59a1ac131609cbf673662ee7eb: update seabios from 1.7.2.2 to 1.7.3.2 (2013-09-30 11:18:02 +0200) Gerd Hoffmann (1): update seabios

[Qemu-devel] [RfC PATCH 0/2] seabios: going to 256k size

2013-09-30 Thread Gerd Hoffmann
128k (will less features), one 256k (full featured). Machine types 1.7+ will use the 256k bios while older machine types will continue to use the 128k sized one. Series applies on top of the roms: various build improvements pull request sent out earlier today. Comments? cheers, Gerd Gerd

[Qemu-devel] [PATCH 1/2] roms: build two seabios binaries

2013-09-30 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- roms/Makefile| 7 --- roms/config.seabios | 1 - roms/config.seabios-128k | 5 + roms/config.seabios-256k | 3 +++ 4 files changed, 12 insertions(+), 4 deletions(-) delete mode 100644 roms/config.seabios create mode

[Qemu-devel] [PATCH 2/2] machine type dependant bios

2013-09-30 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/i386/pc_piix.c| 1 + hw/i386/pc_q35.c | 1 + hw/i386/pc_sysfw.c | 4 ++-- include/hw/i386/pc.h | 2 ++ 4 files changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 907792b..35188a5 100644

Re: [Qemu-devel] [PATCH 1/2] roms: build two seabios binaries

2013-09-30 Thread Gerd Hoffmann
diff --git a/roms/config.seabios-128k b/roms/config.seabios-128k new file mode 100644 index 000..23ca812 --- /dev/null +++ b/roms/config.seabios-128k @@ -0,0 +1,5 @@ +# for qemu machine types 1.6 + older +# need to turn off features (xhci) to make it fit into 128k

Re: [Qemu-devel] Attaching PCI devices to the PCIe root complex

2013-09-30 Thread Gerd Hoffmann
Hi, Yes but, same as in the initial design, it really makes it user's problem. So we'd have virtio-net-pci-conventional virtio-net-pci-express virtio-net-pci-integrated All this while users just really want to say virtio (that's the expert user, what most people want is for guest

[Qemu-devel] [PATCH] turn firmware image filename into a machine option

2013-10-01 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/alpha/dp264.c| 2 +- hw/arm/highbank.c | 8 hw/i386/pc.c| 6 -- hw/i386/pc_piix.c | 3 ++- hw/i386/pc_q35.c| 3 ++- hw/i386/pc_sysfw.c | 8 +--- hw/lm32/milkymist.c | 8

Re: [Qemu-devel] [PATCH] turn firmware image filename into a machine option

2013-10-01 Thread Gerd Hoffmann
On Di, 2013-10-01 at 19:55 +0900, Peter Maydell wrote: On 1 October 2013 18:39, Gerd Hoffmann kra...@redhat.com wrote: Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/alpha/dp264.c| 2 +- hw/arm/highbank.c | 8 hw/i386/pc.c| 6 -- hw

Re: [Qemu-devel] [PATCH] turn firmware image filename into a machine option

2013-10-01 Thread Gerd Hoffmann
Hi, -bios we're stuck with because it's a legacy option, What is legacy about it? Well, the x86-centric name of course. Thats why the machine option is named 'firmware' instead. It also doesn't use QemuOpts, which is fixed by this patch. Anything else? Why is this a machine option

Re: [Qemu-devel] [PATCH] turn firmware image filename into a machine option

2013-10-01 Thread Gerd Hoffmann
--- a/hw/arm/highbank.c +++ b/hw/arm/highbank.c @@ -250,15 +250,15 @@ static void calxeda_init(QEMUMachineInitArgs *args, enum cxmachines machine) sysram = g_new(MemoryRegion, 1); memory_region_init_ram(sysram, NULL, highbank.sysram, 0x8000);

Re: [Qemu-devel] [PATCH] turn firmware image filename into a machine option

2013-10-01 Thread Gerd Hoffmann
On Di, 2013-10-01 at 14:20 +0200, Andreas Färber wrote: Hi, Am 01.10.2013 14:16, schrieb Gerd Hoffmann: -bios we're stuck with because it's a legacy option, What is legacy about it? Well, the x86-centric name of course. Thats why the machine option is named 'firmware' instead

Re: [Qemu-devel] [PATCH] turn firmware image filename into a machine option

2013-10-01 Thread Gerd Hoffmann
Hi, SLOF is what is loaded from the very beginning, it configures PCI, cooks the device tree and boots the guest system (directly or via yaboot/grub, from disk, network or ram). Normal firmware, as usual. It knows all the details about the machine so the guest system (linux) does not need

Re: [Qemu-devel] [PATCH] turn firmware image filename into a machine option

2013-10-01 Thread Gerd Hoffmann
On Di, 2013-10-01 at 22:00 +0900, Peter Maydell wrote: On 1 October 2013 21:16, Gerd Hoffmann kra...@redhat.com wrote: Hi, -bios we're stuck with because it's a legacy option, What is legacy about it? The fact that we've had it since forever, it was introduced for a specific x86

Re: [Qemu-devel] [PULL 0/1] seabios update to 1.7.3.2

2013-10-01 Thread Gerd Hoffmann
On Di, 2013-10-01 at 17:21 +0100, Alex Bennée wrote: kra...@redhat.com writes: Hi, New seabios release is out, here comes the update for qemu. please pull, Gerd This has broken qemu/master as the sub-project commit: ece025f5980bae88fa677bc9c0d24d2e580e205d Doesn't exist

[Qemu-devel] [PULL 0/1] chardev: handle qmp_chardev_add(KIND_MUX) failure

2013-10-02 Thread Gerd Hoffmann
://git.kraxel.org/qemu chardev.8 for you to fetch changes up to ee6ee83de29923483b4905b35f18abf5333f6ea9: chardev: handle qmp_chardev_add(KIND_MUX) failure (2013-10-01 10:16:04 +0200) Gerd Hoffmann (1): chardev: handle

[Qemu-devel] [PATCH 1/1] chardev: handle qmp_chardev_add(KIND_MUX) failure

2013-10-02 Thread Gerd Hoffmann
Cc: Markus Armbruster arm...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- qemu-char.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/qemu-char.c b/qemu-char.c index f7f5464..2ca34cd 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -3271,7 +3271,12

Re: [Qemu-devel] [PATCH RFC v2 7/9] hw: set interrupts using pci irq wrappers

2013-10-07 Thread Gerd Hoffmann
On Mi, 2013-10-02 at 15:41 +0300, Marcel Apfelbaum wrote: --- a/hw/usb/hcd-uhci.c +++ b/hw/usb/hcd-uhci.c @@ -381,7 +381,7 @@ static void uhci_update_irq(UHCIState *s) } else { level = 0; } -qemu_set_irq(s-dev.irq[s-irq_pin], level); +pci_set_irq(s-dev, level);

Re: [Qemu-devel] [PATCH 1/7] usb: remove old usb-host code

2013-10-07 Thread Gerd Hoffmann
On Mi, 2013-10-02 at 15:14 +0200, Jan Kiszka wrote: On 2013-09-19 11:34, Gerd Hoffmann wrote: The usb-host code has been rewritten for qemu 1.5 to use libusb, the old code has been left in as temporary fallback. Now we are two releases further out, targeting the 1.7 release. No major

Re: [Qemu-devel] [PATCH 2/2] q35: add cpu hotplug support

2013-10-07 Thread Gerd Hoffmann
On Fr, 2013-10-04 at 15:20 +0200, Igor Mammedov wrote: On Wed, 21 Aug 2013 13:01:32 +0200 Gerd Hoffmann kra...@redhat.com wrote: Hi, +#define ICH9_PROC_BASE 0xaf00 +#define ICH9_PROC_LEN 32 No, please don't. It makes it impossible to assign the 0xa000 - 0xafff I/O port

Re: [Qemu-devel] [PATCH] spice: replace use of deprecated API

2013-10-07 Thread Gerd Hoffmann
On Fr, 2013-10-04 at 13:10 +0200, Marc-André Lureau wrote: hose API are deprecated since 0.11, and qemu depends on 0.12 already. Added to spice patch queue. thanks, Gerd

Re: [Qemu-devel] [PATCH 03/13] usb-host-libusb: Detach kernel drivers earlier

2013-10-09 Thread Gerd Hoffmann
On Di, 2013-10-08 at 21:58 +0200, Hans de Goede wrote: If we detach the kernel drivers on the first set_config, then they will be still attached when the device gets its initial reset. Causing the drivers to re-initialize the device after the reset, dirtying the device state. @@ -1051,7

Re: [Qemu-devel] [PATCH 1/7] usb: remove old usb-host code

2013-10-09 Thread Gerd Hoffmann
Hi, Only very recent distros fulfill the need of = 1.0.13, so you naturally fall back to this code. I just realized that even the factory build of OpenSUSE is still on libusb-1.0.9. Current Ubuntu versions are on 1.0.12 at best. Didn't check others so far. Ouch. The 1.0.13 release

  1   2   3   4   5   6   7   8   9   10   >