On 19.08.21 20:22, Klaus Kiwi wrote:
On Thu, Aug 19, 2021 at 7:27 AM Hanna Reitz <mailto:hre...@redhat.com>> wrote:
This post explains when FUSE block exports are useful, how they work,
and that it is fun to export an image file on its own path so it looks
like your i
-by: Hanna Reitz
On 19.08.21 18:23, Stefan Hajnoczi wrote:
On Thu, Aug 19, 2021 at 12:25:01PM +0200, Hanna Reitz wrote:
This post explains when FUSE block exports are useful, how they work,
and that it is fun to export an image file on its own path so it looks
like your image file (in whatever format
On 24.07.21 15:38, Vladimir Sementsov-Ogievskiy wrote:
There is no conflict and no dependency if we have parallel writes to
different subclusters of one cluster when cluster itself is already
allocated. So, relax extra dependency.
Measure performance:
First, prepare build/qemu-img-old and
On 20.08.21 23:24, Eric Blake wrote:
On Thu, Aug 19, 2021 at 12:25:01PM +0200, Hanna Reitz wrote:
This post explains when FUSE block exports are useful, how they work,
and that it is fun to export an image file on its own path so it looks
like your image file (in whatever format
On 22.08.21 15:18, Thomas Huth wrote:
On 20/08/2021 09.56, Hanna Reitz wrote:
On 19.08.21 18:23, Stefan Hajnoczi wrote:
On Thu, Aug 19, 2021 at 12:25:01PM +0200, Hanna Reitz wrote:
This post explains when FUSE block exports are useful, how they work,
and that it is fun to export an image file
On 16.08.21 21:44, Vivek Goyal wrote:
On Wed, Aug 11, 2021 at 08:41:18AM +0200, Hanna Reitz wrote:
[..]
But given the inotify complications, there’s really a good reason we should
use mountinfo.
It’s a bit tricky because our sandboxing prevents easy access to mountinfo,
but if that’s
On 16.08.21 23:38, Eric Blake wrote:
On Thu, Aug 12, 2021 at 10:41:44AM +0200, Hanna Reitz wrote:
As we have attempted before
(https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg06451.html,
"file-posix: Cache lseek result for data regions";
https://lists.nongnu.org/archive/html/
'fuse'
Reported-by: Qing Wang
Signed-off-by: Philippe Mathieu-Daudé
---
storage-daemon/qemu-storage-daemon.c | 2 ++
1 file changed, 2 insertions(+)
Reviewed-by: Hanna Reitz
On 24.08.21 10:53, Vladimir Sementsov-Ogievskiy wrote:
19.08.2021 19:37, Hanna Reitz wrote:
On 24.07.21 15:38, Vladimir Sementsov-Ogievskiy wrote:
[...]
+import itertools
+from lark import Lark
+
+grammar = """
+start: ( text | column_switch | row_switch )+
+
+column_s
/block/block-copy.h | 3 +++
block/block-copy.c | 49 ++
2 files changed, 32 insertions(+), 20 deletions(-)
Reviewed-by: Hanna Reitz
| 2 +-
3 files changed, 3 insertions(+), 5 deletions(-)
Reviewed-by: Hanna Reitz
pylint proposes using `[]` instead of `list()` and `{}` instead of
`dict()`, because it is faster. That seems simple enough, so heed its
advice.
Signed-off-by: Hanna Reitz
---
tests/qemu-iotests/iotests.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/qemu
-dict-literal). This series cleans up that rest.
Hanna Reitz (2):
iotests: Fix unspecified-encoding pylint warnings
iotests: Fix use-{list,dict}-literal warnings
tests/qemu-iotests/297| 2 +-
tests/qemu-iotests/iotests.py | 12 +++-
2 files changed, 8 insertions(+), 6 deletions
As of recently, pylint complains when `open()` calls are missing an
`encoding=` specified. Everything we have should be UTF-8 (and in fact,
everything should be UTF-8, period (exceptions apply)), so use that.
Signed-off-by: Hanna Reitz
---
tests/qemu-iotests/297| 2 +-
tests/qemu
On 20.07.21 19:33, John Snow wrote:
GitLab: https://gitlab.com/jsnow/qemu/-/commits/python-package-iotest
CI: https://gitlab.com/jsnow/qemu/-/pipelines/340144191
I’ll take the liberty of applying patches 1 and 2 to my block-next
branch, because, well, they fix some of the 297 errors I’m
On 24.08.21 10:38, Vladimir Sementsov-Ogievskiy wrote:
Hi all!
v8:
06: add Hanna's r-b
07: keep is_fleecing detection in _new() function
08,17,18: add Hanna's r-b
19: wording, s/6.1/6.2/, add Markus's a-b
25: new
29: add John's r-b
34: new
Patches without r-b: 07, 25, 34
Thanks! I’ve
+++---
1 file changed, 7 insertions(+), 3 deletions(-)
Reviewed-by: Hanna Reitz
On 28.08.21 00:03, Fabrice Fontaine wrote:
Include linux/fs.h to avoid the following build failure on uclibc or
musl raised since version 6.0.0:
../block/export/fuse.c: In function 'fuse_lseek':
../block/export/fuse.c:641:19: error: 'SEEK_HOLE' undeclared (first use in this
function)
641 |
On 01.09.21 12:05, Vladimir Sementsov-Ogievskiy wrote:
06.08.2021 12:38, Max Reitz wrote:
Finalizing the job may cause its AioContext to change. This is noted by
job_exit(), which points at job_txn_apply() to take this fact into
account.
However, job_completed() does not necessarily invoke
: https://gitlab.com/qemu-project/qemu/-/issues/418
Suggested-by: Hanna Reitz
Signed-off-by: Viktor Prutyanov
Tested-by: Helge Konetzka
---
v2:
- fix indentation in raw_reopen_prepare
- free rs if raw_reopen_prepare fails
v3:
- restore suggested-by field missed in v2
v4
On 24.08.21 10:38, Vladimir Sementsov-Ogievskiy wrote:
Give a good name to test file.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
---
tests/qemu-iotests/{222 => tests/image-fleecing} | 0
tests/qemu-iotests/{222.out => tests/image-fleecing.out} | 0
2 files
On 24.08.21 10:38, Vladimir Sementsov-Ogievskiy wrote:
The main consumer of cluster-size is block-copy. Let's calculate it
here instead of passing through backup-top.
We are going to publish copy-before-write filter soon, so it will be
created through options. But we don't want for now to make
On 01.09.21 12:20, Vladimir Sementsov-Ogievskiy wrote:
06.08.2021 12:38, Max Reitz wrote:
Callers should be able to specify whether they want job_cancel_sync() to
force-cancel the job or not.
In fact, almost all invocations do not care about consistency of the
result and just want the job to
-off-by: Fabrice Fontaine
Message-Id: <20210827220301.272887-1-fontaine.fabr...@gmail.com>
Signed-off-by: Hanna Reitz
---
block/export/fuse.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/block/export/fuse.c b/block/export/fuse.c
index fc7b07d2b5..2e3bf8270b 100644
--- a/block/exp
On 01.09.21 15:34, Vladimir Sementsov-Ogievskiy wrote:
A kind of ping:)
Seems that never landed into master?
Yes, that’s true…
I was waiting for John (CC-ed) to send v3 of
https://lists.nongnu.org/archive/html/qemu-block/2021-07/msg00611.html,
because in
On 01.09.21 13:04, Vladimir Sementsov-Ogievskiy wrote:
06.08.2021 12:38, Max Reitz wrote:
@@ -726,7 +726,7 @@ static void replication_stop(ReplicationState
*rs, bool failover, Error **errp)
* disk, secondary disk in backup_job_completed().
*/
if (s->backup_job)
On 01.09.21 14:47, Vladimir Sementsov-Ogievskiy wrote:
01.09.2021 15:37, Hanna Reitz wrote:
On 24.08.21 10:38, Vladimir Sementsov-Ogievskiy wrote:
Give a good name to test file.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
---
tests/qemu-iotests/{222 => tests/im
gievskiy
Message-Id: <20210809090114.64834-11-eespo...@redhat.com>
Signed-off-by: Hanna Reitz
---
tests/qemu-iotests/check | 7 ---
tests/qemu-iotests/iotests.py | 11 +++
tests/qemu-iotests/testenv.py | 1 +
3 files changed, 16 insertions(+), 3 deletions(-)
diff --git a/tests/qemu-
Message-Id: <20210809090114.64834-5-eespo...@redhat.com>
Signed-off-by: Hanna Reitz
---
docs/devel/testing.rst | 8
1 file changed, 8 insertions(+)
diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst
index 8a9cda33a5..8359f2ae37 100644
--- a/docs/devel/testing.rst
+++ b/docs/devel/testi
.
Signed-off-by: Emanuele Giuseppe Esposito
Message-Id: <20210809090114.64834-9-eespo...@redhat.com>
Signed-off-by: Hanna Reitz
---
tests/qemu-iotests/common.qemu | 7 ++-
tests/qemu-iotests/common.rc | 8 +++-
2 files changed, 13 insertions(+), 2 deletions(-)
diff --git a/test
the
environment variable.
Signed-off-by: Emanuele Giuseppe Esposito
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
Message-Id: <20210809090114.64834-6-eespo...@redhat.com>
Signed-off-by: Hanna Reitz
---
tests/qemu-iotests/check | 6 +-
tests/qemu-iotests/iote
From: Mao Zhongyi
Signed-off-by: Mao Zhongyi
Message-Id: <20210802062507.347555-1-maozhon...@cmss.chinamobile.com>
Signed-off-by: Hanna Reitz
---
block/monitor/block-hmp-cmds.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/block/monitor/block-hmp-cm
From: Emanuele Giuseppe Esposito
If -gdb and -valgrind are both defined, return an error.
Signed-off-by: Emanuele Giuseppe Esposito
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
Message-Id: <20210809090114.64834-14-eespo...@redhat.com>
Signed-off-by: Hanna
From: Emanuele Giuseppe Esposito
Signed-off-by: Emanuele Giuseppe Esposito
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
Message-Id: <20210809090114.64834-10-eespo...@redhat.com>
Signed-off-by: Hanna Reitz
---
docs/devel/testing.rst | 11 +++
1 file chang
Esposito
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
Message-Id: <20210809090114.64834-13-eespo...@redhat.com>
Signed-off-by: Hanna Reitz
---
tests/qemu-iotests/iotests.py | 11 +++
1 file changed, 11 insertions(+)
diff --git a/tests/qemu-iotests/iotests.py b/test
want to avoid extra rebase conflicts to simplify review of the
following version.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Hanna Reitz
Message-Id: <20210824083856.17408-9-vsement...@virtuozzo.com>
Signed-off-by: Hanna Reitz
---
block/copy-before-write.h | 1 -
block/backup.c
From: Emanuele Giuseppe Esposito
Signed-off-by: Emanuele Giuseppe Esposito
Reviewed-by: Max Reitz
Reviewed-by: Vladimir Sementsov-Ogievskiy
Message-Id: <20210809090114.64834-15-eespo...@redhat.com>
Signed-off-by: Hanna Reitz
---
docs/devel/testing.rst | 6 ++
1 file chan
ow2).
Cc: Max Reitz
Cc: Kevin Wolf
Signed-off-by: Stefan Hajnoczi
Message-Id: <20210726122839.822900-1-stefa...@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Hanna Reitz
---
block/raw-format.c | 21 -
1 file changed, 20 insertions(+), 1 deletion
ed-off-by: Hanna Reitz
---
block/copy-before-write.c | 29 ++---
1 file changed, 14 insertions(+), 15 deletions(-)
diff --git a/block/copy-before-write.c b/block/copy-before-write.c
index a4fee645fd..d7f1833efa 100644
--- a/block/copy-before-write.c
+++ b/block/copy-before-w
From: Emanuele Giuseppe Esposito
Signed-off-by: Emanuele Giuseppe Esposito
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
Message-Id: <20210809090114.64834-17-eespo...@redhat.com>
Signed-off-by: Hanna Reitz
---
docs/devel/testing.rst | 4
1 file changed, 4 inse
of not doing it, I am not aware of them at present.
Signed-off-by: John Snow
Message-Id: <20210720173336.1876937-2-js...@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Hanna Reitz
---
tests/qemu-iotests/iotests.py | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff
From: Vladimir Sementsov-Ogievskiy
Add function to transactionally replace bs inside BdrvChild.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
Message-Id: <20210824083856.17408-2-vsement...@virtuozzo.com>
Signed-off-by: Hanna Reitz
---
include/block/block.
Message-Id: <20210824083856.17408-13-vsement...@virtuozzo.com>
Signed-off-by: Hanna Reitz
---
block/copy-before-write.c | 39 ++-
1 file changed, 22 insertions(+), 17 deletions(-)
diff --git a/block/copy-before-write.c b/block/copy-before-write.c
entsov-Ogievskiy
Reviewed-by: Max Reitz
Message-Id: <20210824083856.17408-17-vsement...@virtuozzo.com>
Signed-off-by: Hanna Reitz
---
block/copy-before-write.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/block/copy-before-write.c b/block/copy-before-w
Reviewed-by: Max Reitz
Message-Id: <20210824083856.17408-14-vsement...@virtuozzo.com>
Signed-off-by: Hanna Reitz
---
block/copy-before-write.c | 33 +++--
1 file changed, 11 insertions(+), 22 deletions(-)
diff --git a/block/copy-before-write.c b/block/copy-before-w
From: Vladimir Sementsov-Ogievskiy
One more step closer to .bdrv_open(): use options instead of plain
arguments. Move to bdrv_open_child() calls, native for drive open
handlers.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Hanna Reitz
Message-Id: <20210824083856.17408-19-vsem
/error-report.h include to block/block-copy.c]
Signed-off-by: Hanna Reitz
---
block/copy-before-write.h | 1 -
include/block/block-copy.h | 5 +--
block/backup.c | 62 ++
block/block-copy.c | 52 +++-
block/copy-
Sementsov-Ogievskiy
Reviewed-by: Max Reitz
Message-Id: <20210824083856.17408-21-vsement...@virtuozzo.com>
Signed-off-by: Hanna Reitz
---
block/block-copy.c | 18 +++---
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/block/block-copy.c b/block/block-copy.c
mir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
Message-Id: <20210824083856.17408-22-vsement...@virtuozzo.com>
Signed-off-by: Hanna Reitz
---
block/copy-before-write.c | 60 ++-
1 file changed, 28 insertions(+), 32 deletions(-)
diff --git a/block/copy-befor
passing dict directly, simplifying interface, and giving a way to
satisfy mypy.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
Reviewed-by: John Snow
Message-Id: <20210824083856.17408-25-vsement...@virtuozzo.com>
Signed-off-by: Hanna Reitz
---
python/qemu/machine/mach
: <20210824083856.17408-34-vsement...@virtuozzo.com>
Signed-off-by: Hanna Reitz
---
tests/qemu-iotests/tests/image-fleecing | 50 +-
tests/qemu-iotests/tests/image-fleecing.out | 72 +
2 files changed, 107 insertions(+), 15 deletions(-)
diff --git a/test
: <20210824083856.17408-24-vsement...@virtuozzo.com>
Signed-off-by: Hanna Reitz
---
python/qemu/machine/machine.py | 18 --
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/python/qemu/machine/machine.py b/python/qemu/machine/machine.py
index 8b935813e9..3fde73cf10 100644
--- a/
From: Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
Acked-by: Markus Armbruster
Message-Id: <20210824083856.17408-23-vsement...@virtuozzo.com>
Signed-off-by: Hanna Reitz
---
qapi/block-core.json | 25 +++--
1 file c
From: Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
Reviewed-by: John Snow
Message-Id: <20210824083856.17408-30-vsement...@virtuozzo.com>
Signed-off-by: Hanna Reitz
---
tests/qemu-iotests/iotests.py | 5 +++--
1 file changed, 3 inse
Sementsov-Ogievskiy
Reviewed-by: Max Reitz
Message-Id: <20210824083856.17408-27-vsement...@virtuozzo.com>
Signed-off-by: Hanna Reitz
---
tests/qemu-iotests/222 | 20 +++-
tests/qemu-iotests/297 | 2 +-
2 files changed, 12 insertions(+), 10 deletions(-)
diff --git a/test
From: Vladimir Sementsov-Ogievskiy
The file use both single and double quotes for strings. Let's be
consistent.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
Message-Id: <20210824083856.17408-28-vsement...@virtuozzo.com>
Signed-off-by: Hanna Reitz
---
tests/qemu-i
ree days ago at time of writing.
See: https://github.com/PyCQA/pylint/pull/4474
Signed-off-by: John Snow
Reviewed-by: Vladimir Sementsov-Ogievskiy
Acked-by: John Snow
Reviewed-by: Max Reitz
Message-Id: <20210809090114.64834-3-eespo...@redhat.com>
Signed-off-by: Hanna Reitz
---
python/setu
ed-off-by: Hanna Reitz
---
python/qemu/machine/machine.py | 7 +--
python/qemu/machine/qtest.py | 5 +++--
tests/qemu-iotests/iotests.py | 3 ++-
3 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/python/qemu/machine/machine.py b/python/qemu/machine/machine.py
index 971ed7e8c6..14c4
The following changes since commit ec397e90d21269037280633b6058d1f280e27667:
Merge remote-tracking branch
'remotes/alistair/tags/pull-riscv-to-apply-20210901-2' into staging (2021-09-01
08:33:02 +0100)
are available in the Git repository at:
https://github.com/XanClic/qemu.git
From: Emanuele Giuseppe Esposito
Signed-off-by: Emanuele Giuseppe Esposito
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
Message-Id: <20210809090114.64834-8-eespo...@redhat.com>
Signed-off-by: Hanna Reitz
---
tests/qemu-iotests/iotests.py | 3 ++-
1 file chan
From: Emanuele Giuseppe Esposito
Signed-off-by: Emanuele Giuseppe Esposito
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Reviewed-by: Max Reitz
Acked-by: John Snow
Message-Id: <20210809090114.64834-4-eespo...@redhat.com>
Signed-off-by: Hanna Reitz
---
pytho
Message-Id: <20210809090114.64834-12-eespo...@redhat.com>
Signed-off-by: Hanna Reitz
---
tests/qemu-iotests/iotests.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index 6aa1dc48ba..26c580f9e7
From: Emanuele Giuseppe Esposito
Attaching gdbserver implies that the qmp socket
should wait indefinitely for an answer from QEMU.
Signed-off-by: Emanuele Giuseppe Esposito
Reviewed-by: Max Reitz
Message-Id: <20210809090114.64834-7-eespo...@redhat.com>
Signed-off-by: Hanna Reitz
---
com>
Signed-off-by: Hanna Reitz
---
include/hw/qdev-properties.h | 1 +
hw/core/qdev-properties.c| 6 +++---
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h
index 0ef97d60ce..f7925f67d0 100644
--- a/include/h
8-8-vsement...@virtuozzo.com>
Reviewed-by: Hanna Reitz
Signed-off-by: Hanna Reitz
---
include/block/block-copy.h | 3 +++
block/block-copy.c | 49 ++
2 files changed, 32 insertions(+), 20 deletions(-)
diff --git a/include/block/block-copy.h b/include
From: Vladimir Sementsov-Ogievskiy
Add function to change bs inside blk.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
Message-Id: <20210824083856.17408-3-vsement...@virtuozzo.com>
Signed-off-by: Hanna Reitz
---
include/sysemu/block-backend.h | 1 +
block
Sementsov-Ogievskiy
Reviewed-by: Max Reitz
Message-Id: <20210809090114.64834-16-eespo...@redhat.com>
Signed-off-by: Hanna Reitz
---
python/qemu/machine/machine.py | 9 ++---
tests/qemu-iotests/check | 4 +++-
tests/qemu-iotests/iotests.py | 8
tests/qemu-iotests/test
-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
Message-Id: <20210824083856.17408-11-vsement...@virtuozzo.com>
Signed-off-by: Hanna Reitz
---
block/copy-before-write.c | 8 +---
tests/qemu-iotests/283.out | 2 +-
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/bloc
com>
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Hanna Reitz
---
tests/qemu-iotests/iotests.py | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index 2ad7a15c8b..4c8971d946 100644
--- a/test
unconditionally: because we are
going to implement new more efficient fleecing scheme which will not
rely on backing feature.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Hanna Reitz
Message-Id: <20210824083856.17408-7-vsement...@virtuozzo.com>
Signed-off-by: Hanna Reitz
---
ed-off-by: Hanna Reitz
---
hw/core/qdev-properties-system.c | 43 +++-
1 file changed, 31 insertions(+), 12 deletions(-)
diff --git a/hw/core/qdev-properties-system.c b/hw/core/qdev-properties-system.c
index 2760c21f11..e71f5d64d1 100644
--- a/hw/core/qdev-properties-sy
hild to file child. And
this is even more reasonable than renaming: for now all public
filters are file-child based.
So, it's a risky change, but risk seems small and good interface worth
it.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
Message-Id: <202108240838
commit.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
Message-Id: <20210824083856.17408-15-vsement...@virtuozzo.com>
Signed-off-by: Hanna Reitz
---
block/copy-before-write.c | 69 +++
1 file changed, 41 insertions(+), 28 deletions(-)
From: Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Hanna Reitz
Message-Id: <20210824083856.17408-18-vsement...@virtuozzo.com>
Signed-off-by: Hanna Reitz
---
block/copy-before-write.h | 1 -
block/backup.c| 2 +-
block/copy-before-w
From: Vladimir Sementsov-Ogievskiy
bdrv_attach_child() do bdrv_unref() on failure, so we shouldn't do it
by hand here.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
Message-Id: <20210824083856.17408-12-vsement...@virtuozzo.com>
Signed-off-by: Hanna Reitz
---
bloc
, and then backup modifies it.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
Message-Id: <20210824083856.17408-20-vsement...@virtuozzo.com>
Signed-off-by: Hanna Reitz
---
block/backup.c| 16 +++-
block/copy-before-write.c | 4
2 files chang
From: Vladimir Sementsov-Ogievskiy
The only caller pass copy_range and compress both false. Let's just
drop these arguments.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Message-Id: <20210824083856.17408-35-vsement...@virtuozzo.com>
Reviewed-by: Hanna Reitz
Signed-off-by: Hanna
viewed-by: Hanna Reitz
Signed-off-by: Hanna Reitz
---
python/qemu/machine/machine.py | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/python/qemu/machine/machine.py b/python/qemu/machine/machine.py
index 6ec18570d9..a7081b1845 100644
--- a/python/qemu/machine/mach
-project/qemu/-/issues/418
Suggested-by: Hanna Reitz
Signed-off-by: Viktor Prutyanov
Tested-by: Helge Konetzka
Message-Id: <20210825173625.19415-1-viktor.prutya...@phystech.edu>
Signed-off-by: Hanna Reitz
---
block/file-win32.c | 101 -
1 file c
From: Vladimir Sementsov-Ogievskiy
Give a good name to test file.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
Message-Id: <20210824083856.17408-29-vsement...@virtuozzo.com>
[hreitz: Adjust .gitlab-ci.d/buildtest.yml]
Signed-off-by: Hanna Reitz
---
.gitla
Sementsov-Ogievskiy
Reviewed-by: Max Reitz
Message-Id: <20210824083856.17408-31-vsement...@virtuozzo.com>
Signed-off-by: Hanna Reitz
---
tests/qemu-iotests/tests/image-fleecing | 12
tests/qemu-iotests/tests/image-fleecing.out | 2 +-
2 files changed, 9 insertions
08-32-vsement...@virtuozzo.com>
Signed-off-by: Hanna Reitz
---
tests/qemu-iotests/tests/image-fleecing | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/tests/qemu-iotests/tests/image-fleecing
b/tests/qemu-iotests/tests/image-fleecing
index 961941bb27..e
ed-off-by: Hanna Reitz
---
tests/qemu-iotests/tests/image-fleecing | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/tests/qemu-iotests/tests/image-fleecing
b/tests/qemu-iotests/tests/image-fleecing
index ec4ef5f3f6..e210c00d28 100755
--- a/tests/qemu-iotests/tests
: https://gitlab.com/qemu-project/qemu/-/issues/418
Suggested-by: Hanna Reitz
Signed-off-by: Viktor Prutyanov
Tested-by: Helge Konetzka
---
v2:
- fix indentation in raw_reopen_prepare
- free rs if raw_reopen_prepare fails
v3:
- restore suggested-by field missed in v2
v4
On 19.08.21 13:09, Philippe Mathieu-Daudé wrote:
On 8/19/21 1:00 PM, Hanna Reitz wrote:
On 19.08.21 12:37, Philippe Mathieu-Daudé wrote:
On 8/19/21 12:25 PM, Hanna Reitz wrote:
This post explains when FUSE block exports are useful, how they work,
and that it is fun to export an image file
:
$ qemu-img convert -f raw -O raw -t none foo.img /mnt/tmp/foo.img
qemu-img: Could not open '/mnt/tmp/foo.img': Cannot get 'write'
permission without 'resize': Image size is not a multiple of request
alignment
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1994266
Signed-off-by: Hanna Reitz
On 19.08.21 12:37, Philippe Mathieu-Daudé wrote:
On 8/19/21 12:25 PM, Hanna Reitz wrote:
This post explains when FUSE block exports are useful, how they work,
and that it is fun to export an image file on its own path so it looks
like your image file (in whatever format it was) is a raw image
On 19.08.21 16:31, Jose R. Ziviani wrote:
Hello Hanna,
On Thu, Aug 19, 2021 at 12:12:00PM +0200, Hanna Reitz wrote:
We cannot write to images opened with O_DIRECT unless we allow them to
be resized so they are aligned to the sector size: Since 9c60a5d1978,
bdrv_node_refresh_perm() ensures
On 26.07.21 14:28, Stefan Hajnoczi wrote:
The following command-line fails due to a permissions conflict:
$ qemu-storage-daemon \
--blockdev driver=nvme,node-name=nvme0,device=:08:00.0,namespace=1 \
--blockdev driver=raw,node-name=l1-1,file=nvme0,offset=0,size=1073741824
\
: https://gitlab.com/qemu-project/qemu/-/issues/418
Suggested-by: Hanna Reitz
Signed-off-by: Viktor Prutyanov
---
v2:
- fix indentation in raw_reopen_prepare
- free rs if raw_reopen_prepare fails
v3:
- restore suggested-by field missed in v2
block/file-win32.c | 90
On 02.08.21 08:25, Mao Zhongyi wrote:
Signed-off-by: Mao Zhongyi
---
block/monitor/block-hmp-cmds.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
Thanks, applied to my block-next branch for 6.2:
https://github.com/XanClic/qemu/commits/block-next
Hanna
On 18.08.21 15:32, Vivek Goyal wrote:
On Tue, Aug 17, 2021 at 08:14:46PM -0400, Vivek Goyal wrote:
On Tue, Aug 17, 2021 at 03:45:19PM -0400, Vivek Goyal wrote:
On Tue, Aug 17, 2021 at 10:27:16AM +0200, Hanna Reitz wrote:
On 16.08.21 21:44, Vivek Goyal wrote:
On Wed, Aug 11, 2021 at 08:41
On 24.07.21 15:38, Vladimir Sementsov-Ogievskiy wrote:
Add simple grammar-parsing template benchmark.
This doesn’t really say much, and FWIW, for like ten minutes I thought
this would do something completely different than it did (while I was
trying to parse the help text).
(I thought this
297 so far does not check the named tests, which reside in the tests/
directory (i.e. full path tests/qemu-iotests/tests). Fix it.
Thanks to the previous two commits, all named tests pass its scrutiny,
so we do not have to add anything to SKIP_FILES.
Signed-off-by: Hanna Reitz
Reviewed
169 and 199 have been renamed and moved to tests/ (commit a44be0334be:
"iotests: rename and move 169 and 199 tests"), so we can drop them from
the skip list.
Signed-off-by: Hanna Reitz
Reviewed-by: Willian Rampazzo
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Kevin Wolf
The AbnormalShutdown exception class is not in qemu.machine, but in
qemu.machine.machine. (qemu.machine.AbnormalShutdown was enough for
Python to find it in order to run this test, but pylint complains about
it.)
Signed-off-by: Hanna Reitz
---
tests/qemu-iotests/tests/mirror-top-perms | 2
ays put two empty lines after a function
- f'exec: cat > /dev/null' does not need to be an f-string
Fix them.
Signed-off-by: Hanna Reitz
---
tests/qemu-iotests/tests/migrate-bitmaps-test | 43 +++
1 file changed, 25 insertions(+), 18 deletions(-)
diff --git a/tests/qemu-iotes
:[down] 'mirror-top-perms: Fix AbnormalShutdown path'
005/5:[] [--] 'iotests/297: Cover tests/'
Hanna Reitz (5):
iotests/297: Drop 169 and 199 from the skip list
migrate-bitmaps-postcopy-test: Fix pylint warnings
migrate-bitmaps-test: Fix pylint warnings
mirror-top-perms: Fix
-by: Hanna Reitz
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
.../tests/migrate-bitmaps-postcopy-test | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test
b/tests/qemu-iotests/tests/migrate-bitmaps-postcopy
1 - 100 of 1120 matches
Mail list logo
