[Qemu-devel] [PATCH v3 0/4] esp: add Tekram DC-390 emulation (PC SCSI adapter)

2012-08-04 Thread Hervé Poussineau
thout installing MS-DOS first! Changes v2->v3: - move esp PCI emulation to a new file - do not compile esp PCI emulation on sparc - (DC-390 patch is left unchanged) Changes v1->v2: - use QOM casts - add const on TypeInfo structure - remove rom filename Hervé Poussineau (4): esp: move some def

[Qemu-devel] [PATCH v3 1/4] esp: move some definitions to header file

2012-08-04 Thread Hervé Poussineau
These will be used by next commits. Signed-off-by: Hervé Poussineau --- hw/esp.c | 125 -- hw/esp.h | 119 +++ 2 files changed, 127 insertions(+), 117 deletions(-) diff --git a

[Qemu-devel] [PATCH v3 3/4] Revert "pci: add some stubs"

2012-08-04 Thread Hervé Poussineau
This reverts commit 0883c5159f1df05d8761014f65451c3c3b77ebcf. Those stubs were only used by PCI ESP emulation, which is now not compiled on architectures which have no PCI bus support. Signed-off-by: Hervé Poussineau --- hw/pci-stub.c | 15 --- 1 file changed, 15 deletions

[Qemu-devel] [PATCH v3 2/4] esp: move PCI emulation to a new file esp-pci.c

2012-08-04 Thread Hervé Poussineau
sparc machines loose ability to instanciate PCI ESP SCSI adapter, which is not a big loose as they don't have PCI bus support. Signed-off-by: Hervé Poussineau --- default-configs/pci.mak |1 + hw/Makefile.objs|1 + hw/esp-pci.c|

[Qemu-devel] [PATCH v3 4/4] esp: add Tekram DC-390 emulation (PC SCSI adapter)

2012-08-04 Thread Hervé Poussineau
(using DC390 driver) - hard disk and cdrom boot Signed-off-by: Hervé Poussineau --- hw/esp-pci.c | 124 +- 1 file changed, 123 insertions(+), 1 deletion(-) diff --git a/hw/esp-pci.c b/hw/esp-pci.c index f633a18..170e007 100644 --- a/hw/esp

[Qemu-devel] [FOR 1.2] Re: [PATCH v3 0/4] esp: add Tekram DC-390 emulation (PC SCSI adapter)

2012-08-09 Thread Hervé Poussineau
Ping. Hervé Poussineau a écrit : This patch cleans up esp SCSI adapter emulation, by moving to a new file the esp PCI emulation (patches 1 to 3). Patch 4 adds a DC-390 emulation, which is not compiled on sparc. You're now able to install MS Windows NT 3.1 (which does not support IDE c

Re: [Qemu-devel] [PATCH for-1.2 1/3] prep: Include devices for ppc64 as well

2012-08-15 Thread Hervé Poussineau
Andreas Färber a écrit : Allows running qemu-system-ppc64 -M prep for consistency. Signed-off-by: Andreas Färber Cc: Markus Armbruster Cc: Alexander Graf Acked-by: Hervé Poussineau

Re: [Qemu-devel] [PATCH 16/23] mips_jazz: Suppress unused default drives

2012-08-15 Thread Hervé Poussineau
Markus Armbruster a écrit : Cc: Hervé Poussineau Suppress default SD card drive for machines magnum, pica61. Signed-off-by: Markus Armbruster --- Acked-by: Hervé Poussineau

Re: [Qemu-devel] [PATCH v3 5/9] fdc: add CCR (Configuration Control Register) write register

2012-01-27 Thread Hervé Poussineau
Markus Armbruster a écrit : Hervé Poussineau writes: DIR and CCR registers share the same address ; DIR is read-only while CCR is write-only Looks like guest writes to CCR are silently ignored before this patch. Is that correct? Yes. Impact? CCR is only used to program media rate

Re: [Qemu-devel] [PATCH v3 1/9] fdc: take side count into account

2012-01-27 Thread Hervé Poussineau
Markus Armbruster a écrit : Hervé Poussineau writes: Floppies can be simple or double-sided. However, current code was only taking the common case into account (ie 2 sides). Impact? This repairs single-sided floppies Are single sided floppies broken before the patch? How? Yes. For

Re: [Qemu-devel] [PATCH v3 5/9] fdc: add CCR (Configuration Control Register) write register

2012-01-31 Thread Hervé Poussineau
Markus Armbruster a écrit : Hervé Poussineau writes: Markus Armbruster a écrit : Hervé Poussineau writes: DIR and CCR registers share the same address ; DIR is read-only while CCR is write-only Looks like guest writes to CCR are silently ignored before this patch. Is that correct? Yes

Re: [Qemu-devel] [PATCH v3 0/9] Misc fixes for floppy emulation

2012-01-31 Thread Hervé Poussineau
Hi, Markus Armbruster a écrit : Looks sane, except for the migration of media rate. See my reply to 7/9. I'm not very fluent with requirements for store/save/migration compatibility things, so can someone knowing them can look at the migration of media rate problem? Paolo? Markus reply i

Re: [Qemu-devel] [PATCH v3 1/9] fdc: take side count into account

2012-01-31 Thread Hervé Poussineau
Hi, Markus Armbruster a écrit : Are single sided floppies broken before the patch? How? Yes. For head > 0, wrong sector number is calculated, so data is read/written at wrong place on underlying block device. Fortunately, mostly nobody is still using single-sided floppies (only some 360 kB flo

[Qemu-devel] [PATCH v2 0/3] jazz-led: qdev conversion

2012-02-01 Thread Hervé Poussineau
Following patches update jazz-led emulation to current Qemu standards: - use trace framework to report events - convert to qdev Changes v1 -> v2: - rebased Hervé Poussineau (3): jazz-led: use trace framework jazz-led: convert to qdev jazz-led: compile it only twice Makefile.o

[Qemu-devel] [PATCH v2 1/3] jazz-led: use trace framework

2012-02-01 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/jazz_led.c | 26 +- trace-events |4 2 files changed, 13 insertions(+), 17 deletions(-) diff --git a/hw/jazz_led.c b/hw/jazz_led.c index f8a2182..1af9268 100644 --- a/hw/jazz_led.c +++ b/hw/jazz_led.c @@ -26,17 +26,7

[Qemu-devel] [PATCH v2 3/3] jazz-led: compile it only twice

2012-02-01 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- Makefile.objs|1 + Makefile.target |1 - default-configs/mips-softmmu.mak |1 + default-configs/mips64-softmmu.mak |1 + default-configs/mips64el-softmmu.mak |1 + default-configs/mipsel

[Qemu-devel] [PATCH v2 2/3] jazz-led: convert to qdev

2012-02-01 Thread Hervé Poussineau
Some simplifications in I/O functions are possible because Jazz LED only registers one byte of I/O. Signed-off-by: Hervé Poussineau --- hw/jazz_led.c | 153 +++ hw/mips.h |3 - hw/mips_jazz.c |2 +- 3 files changed, 65

Re: [Qemu-devel] [PATCH 0/3] jazz-led: qdev conversion

2012-02-01 Thread Hervé Poussineau
Anthony Liguori a écrit : On 01/23/2012 04:34 AM, Hervé Poussineau wrote: Following patches update jazz-led emulation to current Qemu standards: - use trace framework to report events - convert to qdev This is going to need to be rebased. I'd suggest waiting until next week when the nex

[Qemu-devel] [PATCH] ide: fix compilation errors when DEBUG_IDE is set

2012-02-06 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/ide/pci.c |2 +- hw/ide/piix.c |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/ide/pci.c b/hw/ide/pci.c index 246dd57..88c0942 100644 --- a/hw/ide/pci.c +++ b/hw/ide/pci.c @@ -336,7 +336,7 @@ static uint64_t

[Qemu-devel] [PATCH v4 05/11] fdc: add CCR (Configuration Control Register) write register

2012-02-06 Thread Hervé Poussineau
DIR and CCR registers share the same address ; DIR is read-only while CCR is write-only CCR register is used to change media transfer rate, which will be checked in following changes. Signed-off-by: Hervé Poussineau --- hw/fdc.c | 22 ++ 1 files changed, 22 insertions

[Qemu-devel] [PATCH v4 01/11] fdc: take side count into account

2012-02-06 Thread Hervé Poussineau
ace on underlying device. Fortunately, only some 360 kB floppies are single-sided, so this bug was probably not seen much. Signed-off-by: Hervé Poussineau --- hw/fdc.c | 17 +++-- 1 files changed, 11 insertions(+), 6 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index f575a2c..cd47

[Qemu-devel] [PATCH v4 06/11] block: add a transfer rate for floppy types

2012-02-06 Thread Hervé Poussineau
Floppies must be read at a specific transfer rate, depending of its own format. Update floppy description table to include required transfer rate. Signed-off-by: Hervé Poussineau --- block.c | 74 - block.h | 10 +++- hw

[Qemu-devel] [PATCH v4 11/11] fdc: DIR (Digital Input Register) should return status of current drive...

2012-02-06 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/fdc.c | 10 +++--- 1 files changed, 3 insertions(+), 7 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index 1928284..cc2813f 100644 --- a/hw/fdc.c +++ b/hw/fdc.c @@ -216,6 +216,7 @@ static void fdctrl_reset_fifo(FDCtrl *fdctrl); static int

[Qemu-devel] [PATCH v4 07/11] pc: add 1.1 machine type

2012-02-06 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/pc_piix.c | 11 ++- 1 files changed, 10 insertions(+), 1 deletions(-) diff --git a/hw/pc_piix.c b/hw/pc_piix.c index c06f1b5..400c6b6 100644 --- a/hw/pc_piix.c +++ b/hw/pc_piix.c @@ -371,9 +371,17 @@ static void pc_xen_hvm_init(ram_addr_t

[Qemu-devel] [PATCH v4 09/11] fdc: check if media rate is correct before doing any transfer

2012-02-06 Thread Hervé Poussineau
The programmed rate has to be the same as the required rate for the floppy format ; if that's not the case, the transfer should abort. This check can be disabled by using the 'check_media_rate' property. Save media rate value only if media rate check is enabled. Signed-off-by: H

[Qemu-devel] [PATCH v4 08/11] fdc: add a 'check media rate' property. Not used yet

2012-02-06 Thread Hervé Poussineau
Set it to true for current Qemu versions, and false for previous ones Signed-off-by: Hervé Poussineau --- hw/fdc.c |3 +++ hw/pc_piix.c | 36 2 files changed, 39 insertions(+), 0 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index 7c675f6..af007ae

[Qemu-devel] [PATCH v4 04/11] fdc: handle read-only floppies (abort early on write commands)

2012-02-06 Thread Hervé Poussineau
A real floppy doesn't attempt to write to read-only media either. Signed-off-by: Hervé Poussineau --- hw/fdc.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index 49b8c97..060ca84 100644 --- a/hw/fdc.c +++ b/hw/fdc.c @@ -300,6 +

[Qemu-devel] [PATCH v4 10/11] fdc: fix seek command, which shouldn't check tracks

2012-02-06 Thread Hervé Poussineau
The seek command just sends step pulses to the drive and doesn't care if there is a medium inserted of if it is banging the head against the drive. Signed-off-by: Hervé Poussineau --- hw/fdc.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/fdc.c b/hw/

[Qemu-devel] [PATCH v4 03/11] fdc: most control commands do not generate interrupts

2012-02-06 Thread Hervé Poussineau
In fact, only three control commands generate an interrupt: read_id, recalibrate and seek Signed-off-by: Hervé Poussineau --- hw/fdc.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index 34ea830..49b8c97 100644 --- a/hw/fdc.c +++ b/hw

[Qemu-devel] [PATCH v4 00/11] Misc fixes for floppy emulation

2012-02-06 Thread Hervé Poussineau
led Changes v2->v3: - removed patch changing controller stepping to 0 - fixed out of bound access after bad seek command Changes v1->v2: - updated commit messages - added missing 'break' and braces Hervé Poussineau (11): fdc: take side count into account fdc: set busy bit when start

[Qemu-devel] [PATCH v4 02/11] fdc: set busy bit when starting a command

2012-02-06 Thread Hervé Poussineau
This bit must be active while a command is currently executed. Signed-off-by: Hervé Poussineau --- hw/fdc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index cd479f0..34ea830 100644 --- a/hw/fdc.c +++ b/hw/fdc.c @@ -1446,7 +1446,6 @@ static void

[Qemu-devel] [PATCH v3 0/3] jazz-led: QOM conversion

2012-02-07 Thread Hervé Poussineau
Following patches update jazz-led emulation to current Qemu standards: - use trace framework to report events - remove usage of old_mmio API - convert to QOM Changes v2 -> v3: - rebased Changes v1 -> v2: - rebased Hervé Poussineau (3): jazz-led: use trace framework jazz-led: convert

[Qemu-devel] [PATCH v3 2/3] jazz-led: convert to QOM

2012-02-07 Thread Hervé Poussineau
Some simplifications in I/O functions are possible because Jazz LED only registers one byte of I/O. Signed-off-by: Hervé Poussineau --- hw/jazz_led.c | 157 hw/mips.h |3 - hw/mips_jazz.c |2 +- 3 files changed, 69

[Qemu-devel] [PATCH v3 3/3] jazz-led: compile it only twice

2012-02-07 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- Makefile.objs|1 + Makefile.target |1 - default-configs/mips-softmmu.mak |1 + default-configs/mips64-softmmu.mak |1 + default-configs/mips64el-softmmu.mak |1 + default-configs/mipsel

[Qemu-devel] [PATCH v3 1/3] jazz-led: use trace framework

2012-02-07 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/jazz_led.c | 26 +- trace-events |4 2 files changed, 13 insertions(+), 17 deletions(-) diff --git a/hw/jazz_led.c b/hw/jazz_led.c index f8a2182..1af9268 100644 --- a/hw/jazz_led.c +++ b/hw/jazz_led.c @@ -26,17 +26,7

Re: [Qemu-devel] [PATCH v4 00/11] Misc fixes for floppy emulation

2012-02-14 Thread Hervé Poussineau
Hervé Poussineau a écrit : Here are misc fixes done by VirtualBox team. With these patches, floppy emulation is now good enough to run Xenix. Changes v3->v4: - added pc-1.1 machine type - disable media transfer rate check on older machine types - save/restore media transfer rate when me

[Qemu-devel] [PATCH v4 0/3] jazz-led: QOM conversion

2012-02-17 Thread Hervé Poussineau
Following patches update jazz-led emulation to current Qemu standards: - use trace framework to report events - remove usage of old_mmio API - convert to QOM Changes v3 -> v4: - rebased Changes v2 -> v3: - rebased Changes v1 -> v2: - rebased Hervé Poussineau (3): jazz-led:

[Qemu-devel] [PATCH v4 2/3] jazz-led: convert to QOM

2012-02-17 Thread Hervé Poussineau
Some simplifications in I/O functions are possible because Jazz LED only registers one byte of I/O. Signed-off-by: Hervé Poussineau --- hw/jazz_led.c | 159 +--- hw/mips.h |3 - hw/mips_jazz.c |2 +- 3 files changed, 71

[Qemu-devel] [PATCH v4 1/3] jazz-led: use trace framework

2012-02-17 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/jazz_led.c | 26 +- trace-events |4 2 files changed, 13 insertions(+), 17 deletions(-) diff --git a/hw/jazz_led.c b/hw/jazz_led.c index f8a2182..1af9268 100644 --- a/hw/jazz_led.c +++ b/hw/jazz_led.c @@ -26,17 +26,7

[Qemu-devel] [PATCH 3/7] serial: add windows inf file for the pci card to docs

2012-10-17 Thread Hervé Poussineau
> Signed-off-by: Gerd Hoffmann --- docs/qemupciserial.inf | 109 1 files changed, 109 insertions(+), 0 deletions(-) create mode 100644 docs/qemupciserial.inf [...] Did you try to add emulation of a PCI serial card natively recognized by Windo

[Qemu-devel] Resource reporting for VGA cards

2012-10-22 Thread Hervé Poussineau
Hello, I'm trying to add support for a S3 PCI VGA card to QEMU. It currently works on some non-x86 systems. However, on x86, it seems that the card is correctly detected, but there is no display at all; I think it is due to bad framebuffer address detection. There is some resource differences

Re: [Qemu-devel] Resource reporting for VGA cards

2012-10-23 Thread Hervé Poussineau
Hi, Gerd Hoffmann a écrit : On 10/22/12 21:43, Hervé Poussineau wrote: Hello, I'm trying to add support for a S3 PCI VGA card to QEMU. It currently works on some non-x86 systems. However, on x86, it seems that the card is correctly detected, but there is no display at all; I think it is d

[Qemu-devel] [PATCH 0/7] esp: add AMD PCscsi emulation

2012-06-24 Thread Hervé Poussineau
for functions related to PCI emulation - add missing break - fix DMA start for Select and Transfer Information commands Hervé Poussineau (9): esp: execute select commands immediately when it is a non-dma command esp: delay Transfer Information command if dma is not enabled esp: implement Disa

[Qemu-devel] [PATCH 2/9] esp: delay Transfer Information command if dma is not enabled

2012-06-24 Thread Hervé Poussineau
The same mechanism is already in place for some select commands. Signed-off-by: Hervé Poussineau --- hw/esp.c |5 + 1 file changed, 5 insertions(+) diff --git a/hw/esp.c b/hw/esp.c index aff8de6..ac91f00 100644 --- a/hw/esp.c +++ b/hw/esp.c @@ -435,6 +435,11 @@ static void handle_ti

[Qemu-devel] [PATCH 5/9] esp: support future change of chip_id

2012-06-24 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/esp.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/esp.c b/hw/esp.c index 85078e0..a1f5b8a 100644 --- a/hw/esp.c +++ b/hw/esp.c @@ -50,6 +50,7 @@ struct ESPState { uint8_t wregs[ESP_REGS]; qemu_irq irq

[Qemu-devel] [PATCH 6/9] esp: use hba_private field instead of a complex cast

2012-06-24 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/esp.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/esp.c b/hw/esp.c index a1f5b8a..d9dd2aa 100644 --- a/hw/esp.c +++ b/hw/esp.c @@ -186,7 +186,7 @@ static void esp_dma_enable(void *opaque, int irq, int level) static

[Qemu-devel] [PATCH 3/9] esp: implement Disable selection command

2012-06-24 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/esp.c |6 ++ trace-events |1 + 2 files changed, 7 insertions(+) diff --git a/hw/esp.c b/hw/esp.c index ac91f00..985a2ee 100644 --- a/hw/esp.c +++ b/hw/esp.c @@ -117,6 +117,7 @@ struct ESPState { #define CMD_SELATN 0x42 #define

[Qemu-devel] [PATCH 4/9] esp: implement Reset ATN command

2012-06-24 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/esp.c |4 trace-events |1 + 2 files changed, 5 insertions(+) diff --git a/hw/esp.c b/hw/esp.c index 985a2ee..85078e0 100644 --- a/hw/esp.c +++ b/hw/esp.c @@ -113,6 +113,7 @@ struct ESPState { #define CMD_MSGACC 0x12 #define CMD_PAD

[Qemu-devel] [PATCH 9/9] esp: add AMD PCscsi emulation (PCI SCSI adapter)

2012-06-24 Thread Hervé Poussineau
The PCI version is supported in lots of Operating Systems, and has been successfully tested on: - MS DOS 6.22 with MS Windows 3.11 - MS Windows 98 SE - MS Windows NT 3.1 - MS Windows NT 4.0 Signed-off-by: Hervé Poussineau --- default-configs/i386-softmmu.mak |1 + hw/esp.c

[Qemu-devel] [PATCH 7/9] esp: split esp code into generic chip emulation and sysbus layer

2012-06-24 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/esp.c | 162 -- 1 file changed, 95 insertions(+), 67 deletions(-) diff --git a/hw/esp.c b/hw/esp.c index d9dd2aa..796cdc1 100644 --- a/hw/esp.c +++ b/hw/esp.c @@ -44,12 +44,9 @@ typedef struct

[Qemu-devel] [PATCH 1/9] esp: execute select commands immediately when it is a non-dma command

2012-06-24 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/esp.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/esp.c b/hw/esp.c index 8d73e56..aff8de6 100644 --- a/hw/esp.c +++ b/hw/esp.c @@ -270,7 +270,7 @@ static void handle_satn(ESPState *s) uint8_t buf[32]; int len

[Qemu-devel] [PATCH 8/9] esp: use trace framework instead of stderr output

2012-06-24 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/esp.c | 13 ++--- trace-events |3 +++ 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/hw/esp.c b/hw/esp.c index 796cdc1..ec40d93 100644 --- a/hw/esp.c +++ b/hw/esp.c @@ -26,6 +26,7 @@ #include "scsi.h" #incl

Re: [Qemu-devel] [PATCH 1/5] i82378: Remove bogus MMIO coalescing

2012-06-25 Thread Hervé Poussineau
: Andreas Färber CC: Hervé Poussineau Signed-off-by: Jan Kiszka --- hw/i82378.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) Acked-by: Hervé Poussineau

[Qemu-devel] [PATCH 1/2] debugexit: support for custom exit port (e.g LGPL'ed VGA BIOS port 0x501)

2012-07-06 Thread Hervé Poussineau
Add generic support for simple I/O port which, when written to, cause QEMU to exit with the given written value. There is no vmstate associated with the debugging port, simply because the entire interface is a single, stateless, write-only port. Signed-off-by: Hervé Poussineau --- hw

[Qemu-devel] [PATCH 2/2] pc: remove DEBUG_BIOS define and QEMU exit I/O ports

2012-07-06 Thread Hervé Poussineau
=debugcon QEMU exit (which can be guest trigged) can be replaced by: -device isa-debugexit,iobase=0x501 -device isa-debugexit,iobase=0x501,access-size=2 -device isa-debugexit,iobase=0x502,access-size=2 Signed-off-by: Hervé Poussineau --- Anthony, this patch is a follow-up of a patch I sent in

[Qemu-devel] [PATCH v3 02/10] esp: delay Transfer Information command if dma is not enabled

2012-07-09 Thread Hervé Poussineau
The same mechanism is already in place for some select commands. Signed-off-by: Hervé Poussineau --- hw/esp.c |5 + 1 file changed, 5 insertions(+) diff --git a/hw/esp.c b/hw/esp.c index aff8de6..ac91f00 100644 --- a/hw/esp.c +++ b/hw/esp.c @@ -435,6 +435,11 @@ static void handle_ti

[Qemu-devel] [PATCH v3 00/10] esp: add AMD PCscsi emulation

2012-07-09 Thread Hervé Poussineau
ges v1 -> v2: - use qemu_log_mask(LOG_UNIMP, ...) instead of error_report() - use prefix esp_pci_* for functions related to PCI emulation - add missing break - fix DMA start for Select and Transfer Information commands Hervé Poussineau (10): esp: execute select commands immediately when it is

[Qemu-devel] [PATCH v3 08/10] esp: use trace framework instead of stderr output

2012-07-09 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/esp.c | 13 ++--- trace-events |3 +++ 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/hw/esp.c b/hw/esp.c index 796cdc1..ec40d93 100644 --- a/hw/esp.c +++ b/hw/esp.c @@ -26,6 +26,7 @@ #include "scsi.h" #incl

[Qemu-devel] [PATCH v3 09/10] pci: add some stubs

2012-07-09 Thread Hervé Poussineau
Cc: Michael S. Tsirkin Signed-off-by: Hervé Poussineau --- hw/pci-stub.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/hw/pci-stub.c b/hw/pci-stub.c index 134c448..e083191 100644 --- a/hw/pci-stub.c +++ b/hw/pci-stub.c @@ -34,6 +34,21 @@ static void pci_error_message

[Qemu-devel] [PATCH v3 10/10] esp: add AMD PCscsi emulation (PCI SCSI adapter)

2012-07-09 Thread Hervé Poussineau
) Signed-off-by: Hervé Poussineau --- default-configs/i386-softmmu.mak |1 + hw/esp.c | 366 ++ hw/pci_ids.h |1 + trace-events | 12 ++ 4 files changed, 380 insertions(+) diff --git a

[Qemu-devel] [PATCH v3 01/10] esp: execute select commands immediately when it is a non-dma command

2012-07-09 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/esp.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/esp.c b/hw/esp.c index 8d73e56..aff8de6 100644 --- a/hw/esp.c +++ b/hw/esp.c @@ -270,7 +270,7 @@ static void handle_satn(ESPState *s) uint8_t buf[32]; int len

[Qemu-devel] [PATCH v3 07/10] esp: split esp code into generic chip emulation and sysbus layer

2012-07-09 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/esp.c | 162 -- 1 file changed, 95 insertions(+), 67 deletions(-) diff --git a/hw/esp.c b/hw/esp.c index d9dd2aa..796cdc1 100644 --- a/hw/esp.c +++ b/hw/esp.c @@ -44,12 +44,9 @@ typedef struct

[Qemu-devel] [PATCH v3 04/10] esp: implement Reset ATN command

2012-07-09 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/esp.c |4 trace-events |1 + 2 files changed, 5 insertions(+) diff --git a/hw/esp.c b/hw/esp.c index 985a2ee..85078e0 100644 --- a/hw/esp.c +++ b/hw/esp.c @@ -113,6 +113,7 @@ struct ESPState { #define CMD_MSGACC 0x12 #define CMD_PAD

[Qemu-devel] [PATCH v3 06/10] esp: use hba_private field instead of a complex cast

2012-07-09 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/esp.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/esp.c b/hw/esp.c index a1f5b8a..d9dd2aa 100644 --- a/hw/esp.c +++ b/hw/esp.c @@ -186,7 +186,7 @@ static void esp_dma_enable(void *opaque, int irq, int level) static

[Qemu-devel] [PATCH v3 05/10] esp: support future change of chip_id

2012-07-09 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/esp.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/esp.c b/hw/esp.c index 85078e0..a1f5b8a 100644 --- a/hw/esp.c +++ b/hw/esp.c @@ -50,6 +50,7 @@ struct ESPState { uint8_t wregs[ESP_REGS]; qemu_irq irq

[Qemu-devel] [PATCH v3 03/10] esp: implement Disable selection command

2012-07-09 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/esp.c |6 ++ trace-events |1 + 2 files changed, 7 insertions(+) diff --git a/hw/esp.c b/hw/esp.c index ac91f00..985a2ee 100644 --- a/hw/esp.c +++ b/hw/esp.c @@ -117,6 +117,7 @@ struct ESPState { #define CMD_SELATN 0x42 #define

Re: [Qemu-devel] [PATCH 01/19] openpic: Remove unused code

2012-12-08 Thread Hervé Poussineau
;ing Hervé just to be sure. The BeBox has an i82378 (sitting on its MPC105), using i8259 PICs. But even if there were something using them, this is most definitely the wrong way to model variations nowadays. :) Alex, did you find out what was broken about it? Andreas Acked-by: Hervé Poussineau

Re: [Qemu-devel] [PATCH 1/2] hw: add isa-debug-exit device v3

2012-12-13 Thread Hervé Poussineau
Andreas Färber a écrit : Am 13.12.2012 15:48, schrieb Lucas Meneghel Rodrigues: From: Gerd Hoffmann When present it makes qemu exit on any write. Mapped to port 0x501 by default. Without this patch Anthony doesn't allow me to remove the bochs bios debug ports because his test suite uses this.

[Qemu-devel] [RFC 3/8] uhci: do not use old_portio-style callbacks

2012-12-23 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/usb/hcd-uhci.c | 43 +-- 1 file changed, 33 insertions(+), 10 deletions(-) diff --git a/hw/usb/hcd-uhci.c b/hw/usb/hcd-uhci.c index d053791..cc47635 100644 --- a/hw/usb/hcd-uhci.c +++ b/hw/usb/hcd-uhci.c

[Qemu-devel] [RFC 0/8] Remove old_portio usage

2012-12-23 Thread Hervé Poussineau
I/O address space can be removed from architectures which don't have it (MIPS, PowerPC...), and commits like a178274efabcbbc5d44805b51def874e47051325 ("PPC: pseries: Remove hack for PIO window") can be reapplied. Hervé Poussineau (8): pc: disable bochs bios debug port

[Qemu-devel] [RFC 1/8] pc: disable bochs bios debug ports (do not apply!)

2012-12-23 Thread Hervé Poussineau
This patch must not be applied as-is. Some patches to use MemoryRegion have already been sent to mailing list, but none has been applied yet. --- hw/pc.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/pc.c b/hw/pc.c index b11e7c4..7f98955 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -524

[Qemu-devel] [RFC 8/8] memory: remove old_portio-style callbacks support

2012-12-23 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- memory.c | 44 memory.h |4 2 files changed, 48 deletions(-) diff --git a/memory.c b/memory.c index 7419853..ea3bb8a 100644 --- a/memory.c +++ b/memory.c @@ -365,21 +365,6 @@ static void

[Qemu-devel] [RFC 6/8] isa: use memory regions instead of portio_list_* functions

2012-12-23 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/isa-bus.c | 127 -- hw/isa.h |2 +- 2 files changed, 125 insertions(+), 4 deletions(-) diff --git a/hw/isa-bus.c b/hw/isa-bus.c index 144a88e..d22f432 100644 --- a/hw/isa-bus.c +++ b/hw/isa

[Qemu-devel] [RFC 7/8] ioport: remove now useless portio_list_* functions

2012-12-23 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- ioport.c | 121 -- ioport.h | 19 -- 2 files changed, 140 deletions(-) diff --git a/ioport.c b/ioport.c index 6e4ca0d..05f8026 100644 --- a/ioport.c +++ b/ioport.c @@ -329,124 +329,3

[Qemu-devel] [RFC 4/8] acpi-piix4: do not use old_portio-style callbacks

2012-12-23 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/acpi_piix4.c | 91 --- 1 file changed, 40 insertions(+), 51 deletions(-) diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c index 0b5b0d3..22704af 100644 --- a/hw/acpi_piix4.c +++ b/hw/acpi_piix4.c

[Qemu-devel] [RFC 2/8] xen_platform: do not use old_portio-style callbacks

2012-12-23 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/xen_platform.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/hw/xen_platform.c b/hw/xen_platform.c index a54e7a2..ad7cb06 100644 --- a/hw/xen_platform.c +++ b/hw/xen_platform.c @@ -280,7 +280,8 @@ static void

[Qemu-devel] [RFC 5/8] vga/qxl: do not use portio_list_init/portio_list_add

2012-12-23 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/qxl.c |4 +--- hw/vga.c |8 ++-- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 96887c4..7982524 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -2048,7 +2048,6 @@ static int qxl_init_primary(PCIDevice *dev

[Qemu-devel] [PATCH] Remove forward declaration of non-existant variable

2013-02-10 Thread Hervé Poussineau
This variable has been removed 5 years ago in 970ac5a3082428dca91171f270dcd95d6f4b2636. Signed-off-by: Hervé Poussineau --- include/sysemu/sysemu.h |1 - 1 file changed, 1 deletion(-) diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h index 1d9599e..ae49088 100644 --- a

[Qemu-devel] [PATCH] ide: log error when trying to use ATAPI overlapping features

2013-02-10 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/ide/core.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index 3743dc3..f0ab1a8 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -1394,8 +1394,10 @@ void ide_exec_cmd(IDEBus *bus, uint32_t val

Re: [Qemu-devel] [PATCH] (RFC) target-ppc: Remove vestigial PowerPC 620 support

2013-02-11 Thread Hervé Poussineau
Andreas Färber a écrit : Am 11.02.2013 05:50, schrieb David Gibson: The PowerPC 620 was the very first 64-bit PowerPC implementation, but hardly anyone ever actually used the chips. qemu notionally supports the 620, but since we don't actually have code to implement the segment table, the suppo

Re: [Qemu-devel] [PATCH] ide: log error when trying to use ATAPI overlapping features

2013-02-11 Thread Hervé Poussineau
Peter Maydell a écrit : On 10 February 2013 22:12, Hervé Poussineau wrote: --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -1394,8 +1394,10 @@ void ide_exec_cmd(IDEBus *bus, uint32_t val) break; case WIN_PACKETCMD: /* overlapping commands not supported */ -if (s

[Qemu-devel] [PATCH] xhci: fix bad print specifier

2013-02-21 Thread Hervé Poussineau
This fixes the following compilation error: hw/usb/hcd-xhci.c:1156:17: error: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 4 has type ‘unsigned int’ Signed-off-by: Hervé Poussineau --- hw/usb/hcd-xhci.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[Qemu-devel] [PATCH 0/8] fdc: fix FD_SR0_SEEK flag + implement VERIFY

2012-09-06 Thread Hervé Poussineau
Attached patches have 3 goals: - patches 1-4 fix the NT 3.1 floppy driver problem. - patches 5-6 implement the VERIFY command - patches 7-8 are some simple cleanup Hervé Poussineau (6): fdc: use status0 field instead of a local variable fdc: fix false FD_SR0_SEEK fdc: implement VERIFY

[Qemu-devel] [PATCH 6/8] fdc-tests: add tests for VERIFY command

2012-09-06 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- tests/fdc-test.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/tests/fdc-test.c b/tests/fdc-test.c index b825959..4783b08 100644 --- a/tests/fdc-test.c +++ b/tests/fdc-test.c @@ -50,6 +50,7 @@ enum

Re: [Qemu-devel] [PATCH 2/3] fdc: Fix false FD_SR0_SEEK

2012-09-06 Thread Hervé Poussineau
Kevin Wolf a écrit : fdctrl_start/stop_transfer() used to set FD_SR0_SEEK no matter if there actually was a seek or not. This is obviously wrong. fdctrl_start_transfer() has this information because it performs the seek itself. fdctrl_stop_transfer() gets status0 passed and callers already take

[Qemu-devel] [PATCH 5/8] fdc: implement VERIFY command

2012-09-06 Thread Hervé Poussineau
VERIFY command is like a READ command, except that read data is not transfered by DMA. As DMA engine is not used, so we have to start data transfer ourselves. Signed-off-by: Hervé Poussineau --- hw/fdc.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) diff

[Qemu-devel] [PATCH 2/8] fdc: use status0 field instead of a local variable

2012-09-06 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/fdc.c | 29 - 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index 78ae064..d8bffb6 100644 --- a/hw/fdc.c +++ b/hw/fdc.c @@ -327,7 +327,7 @@ static void fdctrl_reset(FDCtrl *fdctrl, int

[Qemu-devel] [PATCH 1/8] fdc: Remove status0 parameter from fdctrl_set_fifo()

2012-09-06 Thread Hervé Poussineau
implied seek can result in st0 = 0, but still triggers the interrupt. Signed-off-by: Kevin Wolf Signed-off-by: Hervé Poussineau --- hw/fdc.c | 33 - 1 file changed, 16 insertions(+), 17 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index 08830c1..78ae064 100644

[Qemu-devel] [PATCH 8/8] fdc: fix typo in zero constant

2012-09-06 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/fdc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/fdc.c b/hw/fdc.c index 9c2bad2..e087694 100644 --- a/hw/fdc.c +++ b/hw/fdc.c @@ -1248,7 +1248,7 @@ static void fdctrl_start_transfer(FDCtrl *fdctrl, int direction

[Qemu-devel] [PATCH 4/8] fdc: fix false FD_SR0_SEEK

2012-09-06 Thread Hervé Poussineau
fdctrl_start/stop_transfer() used to set FD_SR0_SEEK no matter if there actually was a seek or not. This is obviously wrong. fdctrl_seek_to_next_sect() has this information because it performs the seek itself. Cc: Kevin Wolf Signed-off-by: Hervé Poussineau --- hw/fdc.c | 13

[Qemu-devel] [PATCH 3/8] fdc-test: Check READ ID

2012-09-06 Thread Hervé Poussineau
From: Kevin Wolf ST0 shouldn't include 0x20 (FD_SR0_SEEK) after READ ID. Signed-off-by: Kevin Wolf Signed-off-by: Hervé Poussineau --- tests/fdc-test.c | 66 ++ 1 file changed, 66 insertions(+) diff --git a/tests/fdc-test.c b/test

[Qemu-devel] [PATCH 7/8] fdc: remove double affectation of FD_MSR_CMDBUSY flag

2012-09-06 Thread Hervé Poussineau
FD_MSR_CMDBUSY flag is already set in fdctrl_write_data(), just before calling the command handler (fdctrl_start_transfer() here). Signed-off-by: Hervé Poussineau --- hw/fdc.c |1 - 1 file changed, 1 deletion(-) diff --git a/hw/fdc.c b/hw/fdc.c index 551160e..9c2bad2 100644 --- a/hw/fdc.c

[Qemu-devel] [PATCH v2 3/3] slirp: Implement TFTP Blocksize option

2012-09-10 Thread Hervé Poussineau
present or less than 512 bytes. Signed-off-by: Hervé Poussineau --- slirp/tftp.c | 40 1 file changed, 32 insertions(+), 8 deletions(-) diff --git a/slirp/tftp.c b/slirp/tftp.c index 75c9030..e02a29b 100644 --- a/slirp/tftp.c +++ b/slirp/tftp.c @@ -120,

[Qemu-devel] [PATCH v2 2/3] slirp: Handle more than 65535 blocks in TFTP transfers

2012-09-10 Thread Hervé Poussineau
RFC 1350 does not mention block count roll-over. However, a lot of TFTP servers implement it to be able to transmit big files, so do it also. Current block size is 512 bytes, so TFTP files were limited to 32 MB. Signed-off-by: Hervé Poussineau Reviewed-by: Aurelien Jarno --- slirp/tftp.c

[Qemu-devel] [PATCH v2 1/3] slirp: improve TFTP performance

2012-09-10 Thread Hervé Poussineau
When transfering a file, keep it open during the whole transfer, instead of opening/closing it for each block. Signed-off-by: Hervé Poussineau Reviewed-by: Aurelien Jarno --- slirp/tftp.c | 32 ++-- slirp/tftp.h |1 + 2 files changed, 19 insertions(+), 14

[Qemu-devel] [PATCH v2 0/3] slirp: tftp server improvements

2012-09-10 Thread Hervé Poussineau
rebased - updated with Aurélien Jarno remarks - improved commit messages Hervé Poussineau (3): slirp: improve TFTP performance slirp: Handle more than 65535 blocks in TFTP transfers slirp: Implement TFTP Blocksize option slirp/tftp.

Re: [Qemu-devel] [PATCH 2/2] pc: remove DEBUG_BIOS define and QEMU exit I/O ports

2012-09-11 Thread Hervé Poussineau
Andreas Färber a écrit : Am 01.08.2012 17:48, schrieb Hervé Poussineau: Anthony Liguori a écrit : Hervé Poussineau writes: Anthony Liguori a écrit : On 07/06/2012 04:53 PM, Hervé Poussineau wrote: QEMU exit (which can be guest triggered) can be replaced by: -device isa-debugexit,iobase

[Qemu-devel] [PATCH v3 0/2] slirp: tftp server improvements

2012-09-12 Thread Hervé Poussineau
rebased - updated with Aurélien Jarno remarks - improved commit messages Changes v2 -> v3 - removed patch 1/3, already applied to slirp queue - updated with Jan Kiszka remarks Hervé Poussineau (2): slirp: Handle more than 65535 blocks in TFTP transfers slirp: Implement TFTP Blocksize option s

[Qemu-devel] [PATCH v3 2/2] slirp: Implement TFTP Blocksize option

2012-09-12 Thread Hervé Poussineau
present or less than 512 bytes. Signed-off-by: Hervé Poussineau --- slirp/tftp.c | 42 +- 1 file changed, 33 insertions(+), 9 deletions(-) diff --git a/slirp/tftp.c b/slirp/tftp.c index c6a5df2..37b0387 100644 --- a/slirp/tftp.c +++ b/slirp/tftp.c @@ -120,

[Qemu-devel] [PATCH v3 1/2] slirp: Handle more than 65535 blocks in TFTP transfers

2012-09-12 Thread Hervé Poussineau
RFC 1350 does not mention block count roll-over. However, a lot of TFTP servers implement it to be able to transmit big files, so do it also. Current block size is 512 bytes, so TFTP files were limited to 32 MB. Signed-off-by: Hervé Poussineau --- slirp/tftp.c | 24

  1   2   3   4   5   6   7   8   9   10   >