Re: [Qemu-devel] [PATCH v17 07/10] ACPI: Add APEI GHES table generation support

2019-06-06 Thread Jonathan Cameron
On Tue, 14 May 2019 04:18:20 -0700 Dongjiu Geng wrote: > This implements APEI GHES Table generation via fw_cfg blobs. > Now it only support GPIO-Signal and ARMv8 SEA two types of GHESv2 error > source. Afterwards, we can extend the supported types if needed. For the > CPER section type,

Re: [Qemu-devel] [PATCH v17 10/10] target-arm: kvm64: handle SIGBUS signal from kernel or KVM

2019-06-06 Thread Jonathan Cameron
On Tue, 14 May 2019 04:18:23 -0700 Dongjiu Geng wrote: > Add SIGBUS signal handler. In this handler, it checks the SIGBUS type, > translates the host VA delivered by host to guest PA, then fill this PA > to guest APEI GHES memory, then notify guest according to the SIGBUS type. > > If guest

[Qemu-devel] [RFC PATCH 6/7] misc: CCIX endpoint function

2019-06-25 Thread Jonathan Cameron
of a CCIX layer switch. Signed-off-by: Jonathan Cameron --- hw/misc/Kconfig | 5 ++ hw/misc/Makefile.objs | 1 + hw/misc/ccix-ep.c | 112 ++ 3 files changed, 118 insertions(+) diff --git a/hw/misc/Kconfig b/hw/misc/Kconfig index 385e1b0cec

[Qemu-devel] [RFC PATCH 4/7] pci-bridge: CCIX capable PCIE/CCIX switch upstream port.

2019-06-25 Thread Jonathan Cameron
call them. 2) Create a library for the code that is shared. 3) Don't worry too much about it as it's likely they will diverge overtime as we extend the CCIX driver. Signed-off-by: Jonathan Cameron --- hw/pci-bridge/Kconfig | 5 + hw/pci-bridge/Makefile.objs | 1 + hw/pci-bridge

[Qemu-devel] [RFC PATCH 0/7] qemu: CCIX pcie config space emulation

2019-06-25 Thread Jonathan Cameron
ted portion of the CCIX specification and will give CCIX propery copyright attribution by including the following copyright notice with the cited part of the CCIX specification: "© 2019 CCIX CONSORTIUM, INC. ALL RIGHTS RESERVED." Jonathan Cameron (7): Temp: Add the PCI_EXT_ID_DVSEC defi

[Qemu-devel] [RFC PATCH 3/7] pci: CCIX config space emulation library.

2019-06-25 Thread Jonathan Cameron
functions so are not covered by this patch set). Signed-off-by: Jonathan Cameron --- hw/pci/Kconfig |3 + hw/pci/Makefile.objs |1 + hw/pci/ccix_lib.c| 1299 ++ include/hw/misc/ccix.h | 28 + include/hw/pci/pci_ids.h |2 + 5

[Qemu-devel] [RFC PATCH 1/7] Temp: Add the PCI_EXT_ID_DVSEC definition to the qemu pci_regs.h copy.

2019-06-25 Thread Jonathan Cameron
This hasn't yet been added to the linux kernel tree, so for purposes of this RFC just add it locally. Signed-off-by: Jonathan Cameron --- include/standard-headers/linux/pci_regs.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/standard-headers/linux/pci_regs.h b

[Qemu-devel] [RFC PATCH 7/7] Temp: Add to ARM64 makefiles for testing

2019-06-25 Thread Jonathan Cameron
Signed-off-by: Jonathan Cameron --- default-configs/arm-softmmu.mak | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak index 3158e1a10a..d5d4c8ecf1 100644 --- a/default-configs/arm-softmmu.mak +++ b/default

[Qemu-devel] [RFC PATCH 5/7] pci-bridge: CCIX capable PCIE/CCIX switch downstream port

2019-06-25 Thread Jonathan Cameron
Note that this is simply emulation of the configuration space. Has the same issue with cut and paste code as the upstream port driver. Solution likely to be the same. Signed-off-by: Jonathan Cameron --- hw/pci-bridge/Makefile.objs | 2 +- hw/pci-bridge/ccix_downstream.c | 222

[Qemu-devel] [RFC PATCH 2/7] pci: Add Huawei vendor ID and Huawei Emulated CCIX Device IDs.

2019-06-25 Thread Jonathan Cameron
These device IDs have been allocated for emulated only devices, giving us more flexibility than would be possible by emulating real devices. They will be used for the CCIX PCIe configuration space emulation modules that follow. Signed-off-by: Jonathan Cameron --- include/hw/pci/pci_ids.h | 5

Re: [Qemu-devel] [PATCH v5 6/8] hmat acpi: Build Memory Subsystem Address Range Structure(s) in ACPI HMAT

2019-06-27 Thread Jonathan Cameron
On Fri, 14 Jun 2019 23:56:24 +0800 Tao Xu wrote: > From: Liu Jingqi > > HMAT is defined in ACPI 6.2: 5.2.27 Heterogeneous Memory Attribute Table > (HMAT). > The specification references below link: > http://www.uefi.org/sites/default/files/resources/ACPI_6_2.pdf > > It describes the memory

Re: [Qemu-devel] [PULL 33/34] roms: Add OpenSBI version 0.3

2019-06-28 Thread Jonathan Cameron
On Thu, 27 Jun 2019 08:20:10 -0700 Palmer Dabbelt wrote: > From: Alistair Francis > > Add OpenSBI version 0.3 as a git submodule and as a prebult binary. > > Signed-off-by: Alistair Francis > Reviewed-by: Bin Meng > Tested-by: Bin Meng > Signed-off-by: Palmer Dabbelt I sent a late bug

Re: [Qemu-devel] [PATCH v6 07/14] hmat acpi: Build System Locality Latency and Bandwidth Information Structure(s)

2019-07-09 Thread Jonathan Cameron
orrespond to rated latency and bandwidth for the platform. > The software could use this information as hint for optimization. > > Signed-off-by: Liu Jingqi > Signed-off-by: Tao Xu I think you've missed one of the 6.3 changes. Otherwise a few nitpicks but looks good to me. Review

Re: [Qemu-devel] [PATCH v6 06/14] hmat acpi: Build Memory Proximity Domain Attributes Structure(s)

2019-07-09 Thread Jonathan Cameron
ain Attributes by memory > subsystem and its associativity with processor proximity domain as well as > hint for memory usage. > > Signed-off-by: Liu Jingqi > Signed-off-by: Tao Xu Looks good to me. Thanks for changing to 6.3. Reviewed-by: Jonathan Cameron > ---

Re: [Qemu-devel] [PATCH v6 08/14] hmat acpi: Build Memory Side Cache Information Structure(s)

2019-07-09 Thread Jonathan Cameron
e this information to effectively place > the data in memory to maximize the performance of the system > memory that use the memory side cache. > > Signed-off-by: Liu Jingqi > Signed-off-by: Tao Xu There is what I'll call a paste 'splurge' inline. Otherwise looks goo

Re: [Qemu-devel] [PULL 33/34] roms: Add OpenSBI version 0.3

2019-07-01 Thread Jonathan Cameron
On Fri, 28 Jun 2019 09:12:45 -0700 Alistair Francis wrote: > On Fri, Jun 28, 2019 at 2:47 AM Jonathan Cameron > wrote: > > > > On Thu, 27 Jun 2019 08:20:10 -0700 > > Palmer Dabbelt wrote: > > > > > From: Alistair Francis > > >

Re: [Qemu-devel] [PATCH v1 4/5] roms: Add OpenSBI version 0.3

2019-06-27 Thread Jonathan Cameron
On Mon, 24 Jun 2019 15:11:57 -0700 Alistair Francis wrote: > Add OpenSBI version 0.3 as a git submodule and as a prebult binary. > > Signed-off-by: Alistair Francis Hi Alistair, Looks like a cut and paste buglet in the Makefile for the roms. Jonathan > > diff --git a/roms/Makefile

Re: [Qemu-devel] [RFC PATCH 0/7] qemu: CCIX pcie config space emulation

2019-08-19 Thread Jonathan Cameron
On Fri, 16 Aug 2019 13:59:02 +0100 Peter Maydell wrote: > On Tue, 25 Jun 2019 at 12:28, Jonathan Cameron > wrote: > > > > CCIX topologies are 'layered' on top of PCIe tree topologies. > > This is done primarily by allowing a single CCIX device to appear as >

Re: [Qemu-devel] [RFC PATCH 0/7] qemu: CCIX pcie config space emulation

2019-08-06 Thread Jonathan Cameron
CCIX Consortium, Inc. (CCIX) to > you and other parties that are paticipating (the "participants") in > qemu with the understanding that the participants will use CCIX's > name and trademark only when this patch is used in association with > qemu. > > CCIX is also dist

Re: [PATCH v22 4/9] ACPI: Build Hardware Error Source Table

2020-02-05 Thread Jonathan Cameron
On Wed, 8 Jan 2020 19:32:18 +0800 Dongjiu Geng wrote: > This patch builds Hardware Error Source Table(HEST) via fw_cfg blobs. > Now it only supports ARMv8 SEA, a type of Generic Hardware Error > Source version 2(GHESv2) error source. Afterwards, we can extend > the supported types if needed. For

Re: [PATCH v7 00/41] target/arm: Implement ARMv8.1-VHE

2020-04-01 Thread Jonathan Cameron
On Tue, 31 Mar 2020 11:59:13 -0700 Richard Henderson wrote: > On 3/31/20 8:33 AM, Jonathan Cameron wrote: > > Just wondering if there are any known issues with this? > > Nope. It works for me. > Can you give us any more details. > Unfortunately not a lot more to ad

Re: [PATCH v7 00/41] target/arm: Implement ARMv8.1-VHE

2020-03-31 Thread Jonathan Cameron
On Fri, 7 Feb 2020 11:52:46 + Peter Maydell wrote: > On Thu, 6 Feb 2020 at 10:54, Richard Henderson > wrote: > > > > Version 7 has one more tweak to the vhe tlb flushing > > that Peter asked for. All patches have reviews. > > > > > > > > Applied to target-arm.next, thanks. Hi Peter /

Re: [PATCH v7 00/41] target/arm: Implement ARMv8.1-VHE

2020-03-31 Thread Jonathan Cameron
On Tue, 31 Mar 2020 16:33:24 +0100 Jonathan Cameron wrote: > On Fri, 7 Feb 2020 11:52:46 + > Peter Maydell wrote: > > > On Thu, 6 Feb 2020 at 10:54, Richard Henderson > > wrote: > > > > > > Version 7 has one more tweak to the vhe tlb flushing &

Re: [PATCH v7 00/41] target/arm: Implement ARMv8.1-VHE

2020-04-01 Thread Jonathan Cameron
On Wed, 1 Apr 2020 11:45:22 +0100 Jonathan Cameron wrote: > On Tue, 31 Mar 2020 11:59:13 -0700 > Richard Henderson wrote: > > > On 3/31/20 8:33 AM, Jonathan Cameron wrote: > > > Just wondering if there are any known issues with this? > > > > Nope.

Re: [PATCH v2] hw/arm/virt enable support for virtio-mem

2020-11-25 Thread Jonathan Cameron
On Tue, 24 Nov 2020 20:17:35 +0100 David Hildenbrand wrote: > On 24.11.20 19:11, Jonathan Cameron wrote: > > On Mon, 9 Nov 2020 20:47:09 +0100 > > David Hildenbrand wrote: > > > > +CC Eric based on similar query in other branch of the thread. > > > &g

Re: [PATCH v2] hw/arm/virt enable support for virtio-mem

2020-11-25 Thread Jonathan Cameron
On Wed, 25 Nov 2020 16:54:53 +0100 David Hildenbrand wrote: > > 64k guest on 4k host with 512MiB block size seems fine. > > If there are any places anyone thinks need particular poking I'd > appreciate a hint :) > >>> > >>> If things seem to work for now, that's

Re: [PATCH v2] hw/arm/virt enable support for virtio-mem

2020-11-24 Thread Jonathan Cameron
On Mon, 9 Nov 2020 20:47:09 +0100 David Hildenbrand wrote: +CC Eric based on similar query in other branch of the thread. > On 05.11.20 18:43, Jonathan Cameron wrote: > > Basically a cut and paste job from the x86 support with the exception of > > needing a larger block size as t

Re: [PATCH v2] hw/arm/virt enable support for virtio-mem

2020-12-02 Thread Jonathan Cameron
On Wed, 2 Dec 2020 05:02:57 -0500 "Michael S. Tsirkin" wrote: > On Wed, Nov 25, 2020 at 02:56:59PM +0000, Jonathan Cameron wrote: > > Cool. I'll run a few more comprehensive tests then send out the > > trivial patch to enable the kernel option + v2 of the

Re: CXL support in QEMU

2020-12-16 Thread Jonathan Cameron
On Wed, 16 Dec 2020 10:53:34 +0100 Thomas Huth wrote: > On 16/12/2020 06.05, Prashant V Agarwal wrote: > > Hi, > > Is there a way to know the support plans for CXL protocol in QEMU? > > I see that there is side branch development going on: > > > >

Re: [RFC PATCH 04/25] hw/cxl/device: Introduce a CXL device (8.2.8)

2020-11-16 Thread Jonathan Cameron
On Tue, 10 Nov 2020 21:47:03 -0800 Ben Widawsky wrote: > A CXL device is a type of CXL component. Conceptually, a CXL device > would be a leaf node in a CXL topology. From an emulation perspective, > CXL devices are the most complex and so the actual implementation is > reserved for discrete

Re: [RFC PATCH 06/25] hw/cxl/device: Add device status (8.2.8.3)

2020-11-16 Thread Jonathan Cameron
On Tue, 10 Nov 2020 21:47:05 -0800 Ben Widawsky wrote: > This implements the CXL device status registers from 8.2.8.3.1 in the > CXL 2.0 specification. It is capability ID 0001h. > > Signed-off-by: Ben Widawsky It does some other stuff it shouldn't as well. Please tidy that up before v2. A

Re: [RFC PATCH 07/25] hw/cxl/device: Implement basic mailbox (8.2.8.4)

2020-11-16 Thread Jonathan Cameron
On Tue, 10 Nov 2020 21:47:06 -0800 Ben Widawsky wrote: > This is the beginning of implementing mailbox support for CXL 2.0 > devices. > > Signed-off-by: Ben Widawsky Mostly patch set cleanup suggestions rather than anything meaningful in here. Thanks, Jonathan > --- >

Re: [RFC PATCH 03/25] hw/cxl/component: Introduce CXL components (8.1.x, 8.2.5)

2020-11-16 Thread Jonathan Cameron
On Tue, 10 Nov 2020 21:47:02 -0800 Ben Widawsky wrote: > A CXL 2.0 component is any entity in the CXL topology. All components > have a analogous function in PCIe. Except for the CXL host bridge, all > have a PCIe config space that is accessible via the common PCIe > mechanisms. CXL components

Re: [RFC PATCH 05/25] hw/cxl/device: Implement the CAP array (8.2.8.1-2)

2020-11-16 Thread Jonathan Cameron
On Tue, 10 Nov 2020 21:47:04 -0800 Ben Widawsky wrote: > This implements all device MMIO up to the first capability .That > includes the CXL Device Capabilities Array Register, as well as all of > the CXL Device Capability Header Registers. The latter are filled in as > they are implemented in

Re: [RFC PATCH 08/25] hw/cxl/device: Add memory devices (8.2.8.5)

2020-11-16 Thread Jonathan Cameron
On Tue, 10 Nov 2020 21:47:07 -0800 Ben Widawsky wrote: > Memory devices implement extra capabilities on top of CXL devices. This > adds support for that. > > Signed-off-by: Ben Widawsky > --- > hw/cxl/cxl-device-utils.c | 48 - >

Re: [RFC PATCH 12/25] acpi/pci: Consolidate host bridge setup

2020-11-16 Thread Jonathan Cameron
On Tue, 10 Nov 2020 21:47:11 -0800 Ben Widawsky wrote: > This cleanup will make it easier to add support for CXL to the mix. > > Signed-off-by: Ben Widawsky Nice looking change. Minor comment inline. > --- > hw/i386/acpi-build.c | 31 +-- > 1 file changed, 17

Re: [RFC PATCH 11/25] hw/pxb: Allow creation of a CXL PXB (host bridge)

2020-11-16 Thread Jonathan Cameron
On Tue, 10 Nov 2020 21:47:10 -0800 Ben Widawsky wrote: > This works like adding a typical pxb device, except the name is > 'pxb-cxl' instead of 'pxb-pcie'. An example command line would be as > follows: > -device pxb-cxl,id=cxl.0,bus="pcie.0",bus_nr=1 > > A CXL PXB is backward compatible with

Re: [RFC PATCH 15/25] acpi/pxb/cxl: Reserve host bridge MMIO

2020-11-16 Thread Jonathan Cameron
On Tue, 10 Nov 2020 21:47:14 -0800 Ben Widawsky wrote: > For all host bridges, reserve MMIO space with _CRS. The MMIO for the > host bridge lives in a magically hard coded space in the system's > physical address space. The standard mechanism to tell the OS about > regions which can't be used

Re: [RFC PATCH 22/25] acpi/cxl: Create the CEDT (9.14.1)

2020-11-16 Thread Jonathan Cameron
On Tue, 10 Nov 2020 21:47:21 -0800 Ben Widawsky wrote: > The CXL Early Discovery Table is defined in the CXL 2.0 specification as > a way for the OS to get CXL specific information from the system > firmware. > > As of CXL 2.0 spec, only 1 sub structure is defined, the CXL Host Bridge >

Re: [RFC PATCH 00/25] Introduce CXL 2.0 Emulation

2020-11-16 Thread Jonathan Cameron
/device: Add a memory device (8.2.8.5) > hw/cxl/device: Implement MMIO HDM decoding (8.2.5.12) > acpi/cxl: Add _OSC implementation (9.14.2) > acpi/cxl: Create the CEDT (9.14.1) > Temp: acpi/cxl: Add ACPI0017 (CEDT awareness) > WIP: i386/cxl: Initialize a host bridge > qtest/cxl: A

Re: [RFC PATCH 00/25] Introduce CXL 2.0 Emulation

2020-11-17 Thread Jonathan Cameron
On Mon, 16 Nov 2020 10:06:26 -0800 Ben Widawsky wrote: > On 20-11-16 17:21:07, Jonathan Cameron wrote: > > On Tue, 10 Nov 2020 21:46:59 -0800 > > Ben Widawsky wrote: > > > > > Introduce emulation of Compute Express Link 2.0, which was

Re: [RFC PATCH 04/25] hw/cxl/device: Introduce a CXL device (8.2.8)

2020-11-17 Thread Jonathan Cameron
On Mon, 16 Nov 2020 13:11:16 -0800 Ben Widawsky wrote: > On 20-11-16 13:07:56, Jonathan Cameron wrote: > > On Tue, 10 Nov 2020 21:47:03 -0800 > > Ben Widawsky wrote: > > > > > A CXL device is a type of CXL component. Conceptually, a CXL device > > >

Re: [RFC PATCH 11/25] hw/pxb: Allow creation of a CXL PXB (host bridge)

2020-11-17 Thread Jonathan Cameron
On Mon, 16 Nov 2020 14:01:40 -0800 Ben Widawsky wrote: > On 20-11-16 16:44:09, Jonathan Cameron wrote: > > On Tue, 10 Nov 2020 21:47:10 -0800 > > Ben Widawsky wrote: > > > > > This works like adding a typical pxb device, except the name is > > > 'pxb

Re: [RFC PATCH 03/25] hw/cxl/component: Introduce CXL components (8.1.x, 8.2.5)

2020-11-17 Thread Jonathan Cameron
On Mon, 16 Nov 2020 11:19:36 -0800 Ben Widawsky wrote: > On 20-11-16 12:03:52, Jonathan Cameron wrote: > > On Tue, 10 Nov 2020 21:47:02 -0800 > > Ben Widawsky wrote: > > > > > A CXL 2.0 component is any entity in the CXL topology. All components > >

Re: [RFC PATCH 06/25] hw/cxl/device: Add device status (8.2.8.3)

2020-11-17 Thread Jonathan Cameron
On Mon, 16 Nov 2020 13:18:41 -0800 Ben Widawsky wrote: > On 20-11-16 13:16:08, Jonathan Cameron wrote: > > On Tue, 10 Nov 2020 21:47:05 -0800 > > Ben Widawsky wrote: > > > > > This implements the CXL device status registers from 8.2.8.3.1 in the > > >

Re: [RFC PATCH 08/25] hw/cxl/device: Add memory devices (8.2.8.5)

2020-11-17 Thread Jonathan Cameron
On Mon, 16 Nov 2020 13:45:05 -0800 Ben Widawsky wrote: > On 20-11-16 16:37:22, Jonathan Cameron wrote: > > On Tue, 10 Nov 2020 21:47:07 -0800 > > Ben Widawsky wrote: > > > > > Memory devices implement extra capabilities on top of CXL de

Re: [RFC PATCH v3 13/13] hw/arm/virt-acpi-build: Enable cpu and cache topology

2020-11-09 Thread Jonathan Cameron
On Mon, 9 Nov 2020 11:04:52 +0800 Ying Fang wrote: > A helper struct AcpiCacheOffset is introduced to describe the offset > of three level caches. The cache hierarchy is built according to > ACPI spec v6.3 5.2.29.2. Let's enable CPU cache topology now. > > Signed-off-by: Ying Fang > --- >

Re: [RFC PATCH v3 10/13] target/arm/cpu: Add cpu cache description for arm

2020-11-09 Thread Jonathan Cameron
On Mon, 9 Nov 2020 11:04:49 +0800 Ying Fang wrote: > Add the CPUCacheInfo structure to hold cpu cache information for ARM cpus. > A classic three level cache topology is used here. The default cache > capacity is given and userspace can overwrite these values. > > Signed-off-by: Ying Fang I

[PATCH v2] hw/arm/virt enable support for virtio-mem

2020-11-05 Thread Jonathan Cameron
(build will fail due no defined block size). If there is a more elegant way to do this, please point me in the right direction. [1] https://lore.kernel.org/linux-mm/20191212171137.13872-1-da...@redhat.com/ Signed-off-by: Jonathan Cameron --- default-configs/devices/aarch64-softmmu.mak | 1 + hw/arm

[PATCH] hw/arm/virt enable support for virtio-mem

2020-11-05 Thread Jonathan Cameron
(build will fail due no defined block size). If there is a more elegant way to do this, please point me in the right direction. [1] https://lore.kernel.org/linux-mm/20191212171137.13872-1-da...@redhat.com/ Signed-off-by: Jonathan Cameron --- default-configs/devices/aarch64-softmmu.mak | 1 + hw/arm

Re: [RFC PATCH v2 07/32] hw/cxl/device: Implement basic mailbox (8.2.8.4)

2021-01-06 Thread Jonathan Cameron
On Tue, 5 Jan 2021 08:52:58 -0800 Ben Widawsky wrote: > This is the beginning of implementing mailbox support for CXL 2.0 > devices. > > v2: Use register alignment helper (Ben) > Minor cleanups (Jonathan) > Rename error codes to match spec (Jonathan) > Update cap count from 1 to 2

Re: [RFC PATCH v2 05/32] hw/cxl/device: Implement the CAP array (8.2.8.1-2)

2021-01-06 Thread Jonathan Cameron
On Tue, 5 Jan 2021 08:52:56 -0800 Ben Widawsky wrote: > This implements all device MMIO up to the first capability .That > includes the CXL Device Capabilities Array Register, as well as all of > the CXL Device Capability Header Registers. The latter are filled in as > they are implemented in

Re: [RFC PATCH v2 05/32] hw/cxl/device: Implement the CAP array (8.2.8.1-2)

2021-01-06 Thread Jonathan Cameron
On Wed, 6 Jan 2021 08:49:48 -0800 Ben Widawsky wrote: > On 21-01-06 13:28:05, Jonathan Cameron wrote: > > On Tue, 5 Jan 2021 08:52:56 -0800 > > Ben Widawsky wrote: > > > > > This implements all device MMIO up to the first capability .That > > > inc

Re: [Linuxarm] Re: [RFC PATCH v2 07/32] hw/cxl/device: Implement basic mailbox (8.2.8.4)

2021-01-06 Thread Jonathan Cameron
On Wed, 6 Jan 2021 13:21:23 + Jonathan Cameron wrote: > On Tue, 5 Jan 2021 08:52:58 -0800 > Ben Widawsky wrote: > > > This is the beginning of implementing mailbox support for CXL 2.0 > > devices. > > > > v2: Use register alignment helper (Ben)

Re: [RFC PATCH v2 00/32] CXL 2.0 Support

2021-01-08 Thread Jonathan Cameron
xl: Reserve host bridge MMIO > hw/pxb/cxl: Add "windows" for host bridges > hw/cxl/rp: Add a root port > hw/cxl/device: Add a memory device (8.2.8.5) > hw/cxl/device: Implement MMIO HDM decoding (8.2.5.12) > acpi/cxl: Add _OSC implementation (9.14.2) > te

[RFC PATCH 0/4] hw/cxl/ + /hw/pci/: PCI DOE + CXL CDAT emulation

2021-02-01 Thread Jonathan Cameron
avaialble. Jonathan Cameron (4): include/standard-headers/linux/pci_regs: temp hack to add necessary DOE definitions. hw/pci/pcie_doe: Introduce utility functions for PCIe DOE hw/cxl/cxl-cdat: Initial CDAT implementation for use by CXL devices hw/mem/cxl_type3: Enabled DOE mailbox for access

[RFC PATCH 1/4] include/standard-headers/linux/pci_regs: temp hack to add necessary DOE definitions.

2021-02-01 Thread Jonathan Cameron
Signed-off-by: Jonathan Cameron --- include/standard-headers/linux/pci_regs.h | 33 ++- 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/include/standard-headers/linux/pci_regs.h b/include/standard-headers/linux/pci_regs.h index e709ae8235..7e852d3dd0 100644

[RFC PATCH 4/4] hw/mem/cxl_type3: Enabled DOE mailbox for access to CDAT

2021-02-01 Thread Jonathan Cameron
command line parameters. Signed-off-by: Jonathan Cameron --- hw/mem/cxl_type3.c | 49 ++-- include/hw/cxl/cxl.h | 1 + 2 files changed, 48 insertions(+), 2 deletions(-) diff --git a/hw/mem/cxl_type3.c b/hw/mem/cxl_type3.c index dee5a8884b..3449f02090 100644

[RFC PATCH 3/4] hw/cxl/cxl-cdat: Initial CDAT implementation for use by CXL devices

2021-02-01 Thread Jonathan Cameron
firmware or an OS. Signed-off-by: Jonathan Cameron --- hw/cxl/cxl-cdat.c | 252 ++ hw/cxl/meson.build| 1 + include/hw/cxl/cxl_cdat.h | 101 +++ 3 files changed, 354 insertions(+) diff --git a/hw/cxl/cxl-cdat.c b/hw/cxl/cxl-cdat.c

[RFC PATCH 1/3] hw/pci-host/gpex-acpi: Add support for dsdt construction for pxb-cxl

2021-02-01 Thread Jonathan Cameron
This adds code to instantiate the slightly extended ACPI root port description in DSDT as per the CXL 2.0 specification. Basically a cut and paste job from the i386/pc code. Signed-off-by: Jonathan Cameron --- hw/pci-host/gpex-acpi.c | 22 +++--- 1 file changed, 19 insertions

[RFC PATCH 3/3] hw/cxl/cxl-device-utils: Allow incorrect read lengths

2021-02-01 Thread Jonathan Cameron
. Not-signed-off-by: Jonathan Cameron --- hw/cxl/cxl-device-utils.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/cxl/cxl-device-utils.c b/hw/cxl/cxl-device-utils.c index d0d0a47122..52dd03384a 100644 --- a/hw/cxl/cxl-device-utils.c +++ b/hw/cxl/cxl-device-utils.c @@ -181,11

[RFC PATCH 0/3] hw/arm/virt: CXL enablement including gpex-acpi

2021-02-01 Thread Jonathan Cameron
/qemu To actually get the memory appropriately exposed to the OS a few additional changes are needed as discussed in thread https://lore.kernel.org/qemu-devel/20210128174009.7...@huawei.com/ I will rebase this on future versions of Ben's series as needed. Jonathan Cameron (3): hw/pci-host

[RFC PATCH 2/4] hw/pci/pcie_doe: Introduce utility functions for PCIe DOE

2021-02-01 Thread Jonathan Cameron
This implements the ECN to the PCI 5.0 specification available at https://members.pcisig.com/wg/PCI-SIG/document/14143 Does not currently support interrupts. Note that currently no attempt is made to clean up allocated memory. Signed-off-by: Jonathan Cameron --- hw/pci/meson.build | 2

[RFC PATCH 2/3] hw/arm/virt: Basic CXL enablement on pci_expander_bridge instances pxb-cxl

2021-02-01 Thread Jonathan Cameron
Code based on i386/pc enablement. There is a small amount of directly cut and paste code so it may make sense to unify that at some stage. Signed-off-by: Jonathan Cameron --- hw/arm/Kconfig | 1 + hw/arm/virt-acpi-build.c | 27 +++ hw/arm/virt.c

Re: [RFC PATCH 3/3] hw/cxl/cxl-device-utils: Allow incorrect read lengths

2021-02-03 Thread Jonathan Cameron
On Wed, 3 Feb 2021 08:10:32 -0800 Ben Widawsky wrote: > On 21-02-01 23:26:55, Jonathan Cameron wrote: > > This is currently needed to avoid an issue in the Linux RFC > > in which a read is issued that is not a multiple of DW. > > On arm64 that results in byte reads b

Re: [RFC PATCH 2/4] hw/pci/pcie_doe: Introduce utility functions for PCIe DOE

2021-02-03 Thread Jonathan Cameron
On Tue, 2 Feb 2021 09:54:11 -0800 Ben Widawsky wrote: > This was a bit more complicated than I was anticipating :-) > > On 21-02-01 23:16:27, Jonathan Cameron wrote: > > This implements the ECN to the PCI 5.0 specification available at > > https://members.pcisig.com/wg/P

Re: [RFC PATCH 0/4] hw/cxl/ + /hw/pci/: PCI DOE + CXL CDAT emulation

2021-02-03 Thread Jonathan Cameron
On Mon, 1 Feb 2021 23:16:25 +0800 Jonathan Cameron wrote: > Whilst I know others are working on an implementation of at least some of > this, a desire to work on the kernel user of this required an > implementation so I threw this together in the meantime and am sending > it out

Re: [RFC PATCH v2 24/32] hw/cxl/device: Add a memory device (8.2.8.5)

2021-01-28 Thread Jonathan Cameron
On Wed, 27 Jan 2021 13:26:45 -0800 Ben Widawsky wrote: > On 21-01-27 22:03:12, Igor Mammedov wrote: > > On Tue, 5 Jan 2021 08:53:15 -0800 > > Ben Widawsky wrote: > > > > > A CXL memory device (AKA Type 3) is a CXL component that contains some > > > combination of volatile and persistent

Re: [RFC] Set addresses for memory devices [CXL]

2021-01-28 Thread Jonathan Cameron
On Wed, 27 Jan 2021 21:20:21 -0800 Dan Williams wrote: > On Wed, Jan 27, 2021 at 7:52 PM Ben Widawsky wrote: > > > > Hi list, Igor. > > > > I wanted to get some ideas on how to better handle this. Per the recent > > discussion [1], it's become clear that there needs to be more thought put > >

Re: [RFC PATCH v2 24/32] hw/cxl/device: Add a memory device (8.2.8.5)

2021-01-28 Thread Jonathan Cameron
On Thu, 28 Jan 2021 08:58:01 -0800 Ben Widawsky wrote: > On 21-01-28 08:51:51, Ben Widawsky wrote: > > On 21-01-28 07:14:44, Ben Widawsky wrote: > > > On 21-01-28 07:03:18, Ben Widawsky wrote: > > > > On 21-01-28 10:25:38, Jonathan Cameron wrote: > >

Re: [RFC PATCH v3 07/31] hw/cxl/device: Add cheap EVENTS implementation (8.2.9.1)

2021-02-02 Thread Jonathan Cameron
On Mon, 1 Feb 2021 16:59:24 -0800 Ben Widawsky wrote: > Using the previously implemented stubbed helpers, it is now possible to > easily add the missing, required commands to the implementation. > > Signed-off-by: Ben Widawsky comment inline. Otherwise LGTM. > --- > hw/cxl/cxl-mailbox-utils.c

Re: [RFC PATCH v3 02/31] hw/cxl/component: Introduce CXL components (8.1.x, 8.2.5)

2021-02-02 Thread Jonathan Cameron
On Mon, 1 Feb 2021 16:59:19 -0800 Ben Widawsky wrote: > A CXL 2.0 component is any entity in the CXL topology. All components > have a analogous function in PCIe. Except for the CXL host bridge, all > have a PCIe config space that is accessible via the common PCIe > mechanisms. CXL components

Re: [RFC PATCH v3 04/31] hw/cxl/device: Implement the CAP array (8.2.8.1-2)

2021-02-02 Thread Jonathan Cameron
On Mon, 1 Feb 2021 16:59:21 -0800 Ben Widawsky wrote: > This implements all device MMIO up to the first capability. That > includes the CXL Device Capabilities Array Register, as well as all of > the CXL Device Capability Header Registers. The latter are filled in as > they are implemented in

Re: [RFC PATCH v3 10/31] hw/pxb: Use a type for realizing expanders

2021-02-02 Thread Jonathan Cameron
On Mon, 1 Feb 2021 16:59:27 -0800 Ben Widawsky wrote: > This opens up the possibility for more types of expanders (other than > PCI and PCIe). We'll need this to create a CXL expander. > > Signed-off-by: Ben Widawsky Minor suggestion inline but nothing important if you don't want to change it.

Re: [RFC PATCH v3 14/31] acpi/pci: Consolidate host bridge setup

2021-02-02 Thread Jonathan Cameron
On Mon, 1 Feb 2021 16:59:31 -0800 Ben Widawsky wrote: > This cleanup will make it easier to add support for CXL to the mix. > > Signed-off-by: Ben Widawsky One trivial but up to you on whether you think it's worth changing. > --- > hw/i386/acpi-build.c | 31 +-- >

Re: [RFC PATCH v3 05/31] hw/cxl/device: Implement basic mailbox (8.2.8.4)

2021-02-02 Thread Jonathan Cameron
On Mon, 1 Feb 2021 16:59:22 -0800 Ben Widawsky wrote: > This is the beginning of implementing mailbox support for CXL 2.0 > devices. The implementation recognizes when the doorbell is rung, > handles the command/payload, clears the doorbell while returning error > codes and data. > > Generally

Re: [RFC PATCH v3 16/31] hw/pci: Plumb _UID through host bridges

2021-02-02 Thread Jonathan Cameron
On Mon, 1 Feb 2021 16:59:33 -0800 Ben Widawsky wrote: > Currently, QEMU makes _UID equivalent to the bus number (_BBN). While > there is nothing wrong with doing it this way, CXL spec has a heavy > reliance on _UID to identify host bridges and there is no link to the > bus number. Having a

Re: [RFC PATCH v3 03/31] hw/cxl/device: Introduce a CXL device (8.2.8)

2021-02-02 Thread Jonathan Cameron
self a headache again Reviewed-by: Jonathan Cameron > --- > include/hw/cxl/cxl.h| 1 + > include/hw/cxl/cxl_device.h | 155 > 2 files changed, 156 insertions(+) > create mode 100644 include/hw/cxl/cxl_device.h > > diff --git a/

Re: [Linuxarm] Re: [RFC PATCH 3/4] hw/cxl/cxl-cdat: Initial CDAT implementation for use by CXL devices

2021-02-02 Thread Jonathan Cameron
On Tue, 2 Feb 2021 10:49:23 -0800 Ben Widawsky wrote: > On 21-02-01 23:16:28, Jonathan Cameron wrote: > > CDAT is an ACPI like format defined by the CXL consortium. It is > > available from > > > > https://www.uefi.org/node/4093 > > > > Here support for

Re: [RFC PATCH v3 17/31] hw/cxl/component: Implement host bridge MMIO (8.2.5, table 142)

2021-02-02 Thread Jonathan Cameron
On Mon, 1 Feb 2021 16:59:34 -0800 Ben Widawsky wrote: > CXL host bridges themselves may have MMIO. Since host bridges don't have > a BAR they are treated as special for MMIO. > > Signed-off-by: Ben Widawsky > > -- > > It's arbitrarily chosen here to pick 0xD000 as the base for the host >

Re: [RFC PATCH v3 17/31] hw/cxl/component: Implement host bridge MMIO (8.2.5, table 142)

2021-02-02 Thread Jonathan Cameron
On Tue, 2 Feb 2021 11:45:05 -0800 Ben Widawsky wrote: > On 21-02-02 19:21:35, Jonathan Cameron wrote: > > On Mon, 1 Feb 2021 16:59:34 -0800 > > Ben Widawsky wrote: > > > > > CXL host bridges themselves may have MMIO. Since host bridges don't have > >

Re: [PATCH v6 cxl2.0-v6-doe 4/6] cxl/compliance: CXL Compliance Data Object Exchange implementation

2021-06-15 Thread Jonathan Cameron
On Thu, 10 Jun 2021 09:16:20 -0400 Chris Browy wrote: > From: hchkuo > > The Data Object Exchange implementation of CXL Compliance Mode is > referring to "Compute Express Link (CXL) Specification, Rev. 2.0, Oct. > 2020". > > The data structure of CXL compliance request and response is added

Re: [PATCH v6 cxl2.0-v6-doe 5/6] cxl/cdat: CXL CDAT Data Object Exchange implementation

2021-06-16 Thread Jonathan Cameron
; > Signed-off-by: hchkuo > Signed-off-by: Chris Browy A few comments inline, but I'm happy with this either way. Reviewed-by: Jonathan Cameron > --- > hw/cxl/cxl-cdat.c | 139 ++ > hw/cxl/meson.build | 1 + > hw/m

Re: [PATCH v6 cxl2.0-v6-doe 6/6] test/cdat: CXL CDAT test data

2021-06-16 Thread Jonathan Cameron
On Thu, 10 Jun 2021 09:16:44 -0400 Chris Browy wrote: > From: hchkuo > > Pre-built CDAT table for testing, contains one CDAT header and six > CDAT entries: DSMAS, DSLBIS, DSMSCIS, DSIS, DSEMTS, and SSLBIS > respectively. > > Signed-off-by: hchkuo > Signed-off-by: Chris Browy I can't apply

Re: [PATCH v6 cxl2.0-v6-doe 2/6] include/hw/pci: headers for PCIe DOE

2021-06-15 Thread Jonathan Cameron
ned-off-by: Chris Browy Reviewed-by: Jonathan Cameron > --- > include/hw/pci/pci_ids.h | 3 +++ > include/hw/pci/pcie_regs.h | 4 > 2 files changed, 7 insertions(+) > > diff --git a/include/hw/pci/pci_ids.h b/include/hw/pci/pci_ids.h > index 95f92d98e9..2656009cfe 100644

Re: [PATCH v6 cxl2.0-v6-doe 1/6] standard-headers/linux/pci_regs: PCI header from Linux kernel

2021-06-15 Thread Jonathan Cameron
an be > removed then. > > Signed-off-by: hchkuo > Signed-off-by: Chris Browy Hopefully we'll get some traction on the kernel support next cycle as doesn't look like we'll get the reviews to move it forward this time. This is indeed part of what we are proposing there so FWIW Re

Re: [PATCH v6 cxl2.0-v6-doe 3/6] hw/pci: PCIe Data Object Exchange implementation

2021-06-15 Thread Jonathan Cameron
ig(), false will be returned if pci_config_read() > offset is not within DOE capability range. In pcie_doe_write_config(), > the function will be early returned if not within the related DOE range. > > Signed-off-by: hchkuo > Signed-off-by: Chris Browy A few comments inline

Re: RFC: Memory region accesses where .valid.min_access_size < .impl.min_access_size

2021-05-13 Thread Jonathan Cameron
On Thu, 13 May 2021 14:36:27 +0200 Philippe Mathieu-Daudé wrote: > On 5/13/21 2:23 PM, Peter Maydell wrote: > > On Thu, 13 May 2021 at 12:49, Jonathan Cameron > > wrote: > >> My initial suggestion was to fix this by adding the relatively > >> simple code neede

RFC: Memory region accesses where .valid.min_access_size < .impl.min_access_size

2021-05-13 Thread Jonathan Cameron
Hi All, Cc list is a bit of guess, so please add anyone else who might be interested in this topic. This came up in discussion of the CXL emulation series a while back and I've finally gotten around to looking more closely at it (having carried a local hack in the meantime).

Re: RFC: Memory region accesses where .valid.min_access_size < .impl.min_access_size

2021-05-14 Thread Jonathan Cameron
On Fri, 14 May 2021 11:35:57 +0930 "Andrew Jeffery" wrote: > On Thu, 13 May 2021, at 22:30, Jonathan Cameron wrote: > > On Thu, 13 May 2021 14:36:27 +0200 > > Philippe Mathieu-Daudé wrote: > > > > > On 5/13/21 2:23 PM, Peter Maydell wrote: > &

Re: [PATCH v1 QEMU CXL modifications for openspdm 0/1] Testing PCIe DOE in QEMU CXL/PCIe Device using openspdm

2021-06-29 Thread Jonathan Cameron
On Fri, 25 Jun 2021 20:02:03 -0400 Chris Browy wrote: > This patch series provides an implementation of the the Data Object Exchange > (DOE) for Component Measurement and Authentication (CMA) of the Security > Protocol and Data Model (SPDM). > > This patch is based on > [1] [PATCH v1 openspdm

Re: [PATCH v5 cxl2.0-v3-doe 2/6] include/hw/pci: headers for PCIe DOE

2021-04-28 Thread Jonathan Cameron
On Mon, 26 Apr 2021 13:16:43 -0400 Chris Browy wrote: > From: hchkuo > > Macros for the vender ID of PCI-SIG and the size of PCIe Data Object > Exchange. The PCI SIG vendor ID is a little tricky to track down as it's only called out indirectly in PCI specs. In a similar fashion to what Bjorn

Re: [PATCH v5 cxl2.0-v3-doe 3/6] hw/pci: PCIe Data Object Exchange implementation

2021-04-28 Thread Jonathan Cameron
the From on this series - otherwise the DCO chain is a little unclear. Subject to a few things I've commented on inline... Reviewed-by: Jonathan Cameron > --- > MAINTAINERS | 7 + > hw/pci/meson.build| 1 + > hw/pci/pcie_doe.c | 374 +++

Re: [PATCH v5 cxl2.0-v3-doe 4/6] cxl/compliance: CXL Compliance Data Object Exchange implementation

2021-04-28 Thread Jonathan Cameron
looking a bit odd it doesn't matter so I'll leave it up to you on whether you want to fix it. Reviewed-by: Jonathan Cameron > --- > hw/mem/cxl_type3.c | 147 > include/hw/cxl/cxl_compliance.h | 293 > include/hw/cx

Re: [PATCH v5 cxl2.0-v3-doe 5/6] cxl/cdat: CXL CDAT Data Object Exchange implementation

2021-04-28 Thread Jonathan Cameron
On Mon, 26 Apr 2021 13:36:02 -0400 Chris Browy wrote: > From: hchkuo > > The Data Object Exchange implementation of CXL Coherent Device Attribute > Table (CDAT). This implementation is referring to "Coherent Device > Attribute Table Specification, Rev. 1.02, Oct. 2020" and "Compute > Express

Re: [RFC PATCH v1 01/01] PCIe DOE for PCIe and CXL 2.0

2021-02-08 Thread Jonathan Cameron
... > > > > >> > > Just like you we feel what's most important is to have DOE supported so > that > UEFI and Linux kernel and drivers can progress. We're also contributing > to > writing compliance tests for the CXL Compliance Software Development WG. >

Re: [RFC PATCH v1 01/01] PCIe DOE for PCIe and CXL 2.0

2021-02-05 Thread Jonathan Cameron
nintended attachment. Please ignore. Thanks, Jonathan > > Best Regards, > Chris > > > On 2/3/21, 12:19 PM, "Jonathan Cameron" wrote: > > On Tue, 2 Feb 2021 15:43:28 -0500 > Chris Browy wrote: > > Hi Chris, > > Whilst

Re: [RFC PATCH v3 17/31] hw/cxl/component: Implement host bridge MMIO (8.2.5, table 142)

2021-02-02 Thread Jonathan Cameron
On Tue, 2 Feb 2021 13:03:57 -0800 Ben Widawsky wrote: > On 21-02-02 20:43:38, Jonathan Cameron wrote: > > On Tue, 2 Feb 2021 11:45:05 -0800 > > Ben Widawsky wrote: > > > > > On 21-02-02 19:21:35, Jonathan Cameron wrote: > > > > On Mon, 1 Feb 2021

Re: [RFC PATCH v3 05/31] hw/cxl/device: Implement basic mailbox (8.2.8.4)

2021-02-11 Thread Jonathan Cameron
On Tue, 2 Feb 2021 14:58:30 + Jonathan Cameron wrote: > On Mon, 1 Feb 2021 16:59:22 -0800 > Ben Widawsky wrote: > > > This is the beginning of implementing mailbox support for CXL 2.0 > > devices. The implementation recognizes when the doorbell is rung, > >

Re: [RFC PATCH v3 00/31] CXL 2.0 Support

2021-02-11 Thread Jonathan Cameron
e > > is > > definitely the HDM programming which has received limited (but not 0) > > testing in > > the Linux driver. > > > > Jonathan Cameron has gotten this patch series working on ARM [2], and added > > some > > much sought after functiona

  1   2   3   4   5   6   7   8   9   10   >