Re: [Qemu-devel] [PATCH v4 2/8] block: add basic backup support to block driver

2013-05-22 Thread Kevin Wolf
Am 16.05.2013 um 10:36 hat Stefan Hajnoczi geschrieben: From: Dietmar Maurer diet...@proxmox.com backup_start() creates a block job that copies a point-in-time snapshot of a block device to a target block device. We call backup_do_cow() for each write during backup. That function reads

Re: [Qemu-devel] [PATCH v4 3/8] block: add drive-backup QMP command

2013-05-22 Thread Kevin Wolf
Am 16.05.2013 um 10:36 hat Stefan Hajnoczi geschrieben: @drive-backup Start a point-in-time copy of a block device to a new destination. The status of ongoing drive-backup operations can be checked with query-block-jobs where the BlockJobInfo.type field has the value 'backup'. The

Re: [Qemu-devel] [PATCH v4 2/8] block: add basic backup support to block driver

2013-05-22 Thread Kevin Wolf
Am 22.05.2013 um 11:54 hat Paolo Bonzini geschrieben: Il 22/05/2013 11:38, Kevin Wolf ha scritto: + +DPRINTF(brdv_co_backup_cow done C% PRId64 \n, start); +} + +out: +if (bounce_buffer) { +qemu_vfree(bounce_buffer); +} + +cow_request_end

Re: [Qemu-devel] [PATCH v4 0/8] block: drive-backup live backup command

2013-05-22 Thread Kevin Wolf
tests/qemu-iotests/055 create mode 100644 tests/qemu-iotests/055.out Commented on patches 2, 3 and 4. The others are: Reviewed-by: Kevin Wolf kw...@redhat.com

Re: [Qemu-devel] [PATCH v4 4/8] qemu-iotests: add 055 drive-backup test case

2013-05-22 Thread Kevin Wolf
Am 16.05.2013 um 10:36 hat Stefan Hajnoczi geschrieben: Testing drive-backup is similar to image streaming and drive mirroring. This test case is based on 041. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- tests/qemu-iotests/055 | 230

Re: [Qemu-devel] QMP interface for drive-add (or even blockdev-add)

2013-05-22 Thread Kevin Wolf
Am 16.05.2013 um 21:05 hat Eric Blake geschrieben: On 05/16/2013 02:24 AM, Kevin Wolf wrote: Okay, let's take a step back here. The idea was more or less that you can specify each BlockDriverState by itself in the end, like this: { execute: blockdev-add, data: { id: my_file, driver

Re: [Qemu-devel] [PATCH v4 2/8] block: add basic backup support to block driver

2013-05-22 Thread Kevin Wolf
Am 22.05.2013 um 15:58 hat Stefan Hajnoczi geschrieben: On Wed, May 22, 2013 at 11:56:45AM +0200, Kevin Wolf wrote: Am 22.05.2013 um 11:54 hat Paolo Bonzini geschrieben: Il 22/05/2013 11:38, Kevin Wolf ha scritto: + +DPRINTF(brdv_co_backup_cow done C% PRId64 \n, start

Re: [Qemu-devel] RFC: Full introspection support for QMP

2013-05-22 Thread Kevin Wolf
Am 22.05.2013 um 15:40 hat Amos Kong geschrieben: Hi all, We already have query-command-line-options to query details of command-line options. As we discussed in the list, we also need full introspection of QMP (command). The qmp-events also need to be dumped, we can define events in

Re: [Qemu-devel] RFC: Full introspection support for QMP

2013-05-23 Thread Kevin Wolf
Am 22.05.2013 um 18:14 hat Anthony Liguori geschrieben: Kevin Wolf kw...@redhat.com writes: Am 22.05.2013 um 15:40 hat Amos Kong geschrieben: Hi all, We already have query-command-line-options to query details of command-line options. As we discussed in the list, we also need full

Re: [Qemu-devel] RFC: Full introspection support for QMP

2013-05-23 Thread Kevin Wolf
Am 23.05.2013 um 14:08 hat Anthony Liguori geschrieben: Kevin Wolf kw...@redhat.com writes: Am 22.05.2013 um 18:14 hat Anthony Liguori geschrieben: Kevin Wolf kw...@redhat.com writes: For example, libvirt wants to query which block drivers it can use. It doesn't really matter

Re: [Qemu-devel] RFC: Full introspection support for QMP

2013-05-23 Thread Kevin Wolf
Am 23.05.2013 um 15:52 hat Anthony Liguori geschrieben: Kevin Wolf kw...@redhat.com writes: Am 23.05.2013 um 14:08 hat Anthony Liguori geschrieben: Kevin Wolf kw...@redhat.com writes: There are two things here: the schema and the generated code. The generated code can and should

Re: [Qemu-devel] QMP interface for drive-add (or even blockdev-add)

2013-05-23 Thread Kevin Wolf
Am 23.05.2013 um 13:57 hat Stefan Hajnoczi geschrieben: On Wed, May 22, 2013 at 03:53:05PM +0200, Kevin Wolf wrote: Am 16.05.2013 um 21:05 hat Eric Blake geschrieben: On 05/16/2013 02:24 AM, Kevin Wolf wrote: The other thing that I'm not sure about is whether we should teach QAPI

Re: [Qemu-devel] [PATCH 1/7] vnvram: VNVRAM bdrv support

2013-05-24 Thread Kevin Wolf
Am 23.05.2013 um 19:44 hat Corey Bryant geschrieben: Provides low-level VNVRAM functionality that reads and writes data, such as an entry's binary blob, to a drive image using the block driver. Signed-off-by: Corey Bryant cor...@linux.vnet.ibm.com +/* + * Increase the drive size if it's

Re: [Qemu-devel] [PATCH 1/7] vnvram: VNVRAM bdrv support

2013-05-24 Thread Kevin Wolf
Am 24.05.2013 um 17:33 hat Corey Bryant geschrieben: On 05/24/2013 09:06 AM, Kevin Wolf wrote: Am 23.05.2013 um 19:44 hat Corey Bryant geschrieben: Provides low-level VNVRAM functionality that reads and writes data, such as an entry's binary blob, to a drive image using the block driver

Re: [Qemu-devel] [PATCH V3 1/4] block: drop bs_snapshots global variable

2013-05-27 Thread Kevin Wolf
Am 25.05.2013 um 05:09 hat Wenchao Xia geschrieben: From: Stefan Hajnoczi stefa...@redhat.com The bs_snapshots global variable points to the BlockDriverState which will be used to save vmstate. This is really a savevm.c concept but was moved into block.c:bdrv_snapshots() when it became

Re: [Qemu-devel] [PATCH V3 1/4] block: drop bs_snapshots global variable

2013-05-27 Thread Kevin Wolf
Am 25.05.2013 um 05:09 hat Wenchao Xia geschrieben: From: Stefan Hajnoczi stefa...@redhat.com The bs_snapshots global variable points to the BlockDriverState which will be used to save vmstate. This is really a savevm.c concept but was moved into block.c:bdrv_snapshots() when it became

Re: [Qemu-devel] [PATCH V3 0/4] qapi and snapshot code clean up in block layer

2013-05-27 Thread Kevin Wolf
. 2 better info dumping function to get rid of buffer, avoid string truncation. Posted comments on patch 1 and 4. Patches 2 and 3 are: Reviewed-by: Kevin Wolf kw...@redhat.com

Re: [Qemu-devel] [PATCH V3 4/4] block: dump snapshot and image info to specified output

2013-05-27 Thread Kevin Wolf
Am 27.05.2013 um 17:02 hat Luiz Capitulino geschrieben: On Sat, 25 May 2013 11:09:45 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: bdrv_snapshot_dump() and bdrv_image_info_dump() do not dump to a buffer now, some internal buffers are still used for format control, which have no

Re: [Qemu-devel] [PATCH] block: add read only to whitelist

2013-05-28 Thread Kevin Wolf
Am 28.05.2013 um 08:44 hat Fam Zheng geschrieben: We may want to include a driver in the whitelist for read only tasks such as diagnosing or exporting guest data (with libguestfs as a good example). This patch introduces the magic prefix ^ to include a driver to the whitelist, but only enables

Re: [Qemu-devel] [PATCH] ide: Set BSY bit during FLUSH

2013-05-28 Thread Kevin Wolf
Am 28.05.2013 um 10:18 hat Andreas Färber geschrieben: The implementation of the ATA FLUSH command invokes a flush at the block layer, which may on raw files on POSIX entail a synchronous fdatasync(). This may in some cases take so long that the SLES 11 SP1 guest driver reports I/O errors and

Re: [Qemu-devel] [PATCH] ide: Set BSY bit during FLUSH

2013-05-28 Thread Kevin Wolf
Am 28.05.2013 um 10:46 hat Andreas Färber geschrieben: Am 28.05.2013 10:27, schrieb Kevin Wolf: Am 28.05.2013 um 10:18 hat Andreas Färber geschrieben: The implementation of the ATA FLUSH command invokes a flush at the block layer, which may on raw files on POSIX entail a synchronous

Re: [Qemu-devel] [PATCH] ide: Set BSY bit during FLUSH

2013-05-28 Thread Kevin Wolf
Am 28.05.2013 um 11:24 hat Paolo Bonzini geschrieben: Il 28/05/2013 11:18, Kevin Wolf ha scritto: The other part why I haven't sent a fix yet is that I don't have a test case for it. Temporarily add a sleep(31) in qemu_fdatasync()? I was lazy in testing with -snapshot to not corrupt

Re: [Qemu-devel] [PATCH] qemu-iotests: fix 054 cluster size help output

2013-05-28 Thread Kevin Wolf
Am 28.05.2013 um 11:19 hat Stefan Hajnoczi geschrieben: Commit f3f4d2c09b9cf46903ba38425ec46c44185162bd added a hint to increase the cluster size when a large image cannot be created. Test 054 now has outdated output and fails because the golden output does not match. This patch updates the

Re: [Qemu-devel] [PATCH] ide: Set BSY bit during FLUSH

2013-05-28 Thread Kevin Wolf
Am 28.05.2013 um 11:48 hat Paolo Bonzini geschrieben: Il 28/05/2013 11:36, Kevin Wolf ha scritto: Am 28.05.2013 um 11:24 hat Paolo Bonzini geschrieben: Il 28/05/2013 11:18, Kevin Wolf ha scritto: The other part why I haven't sent a fix yet is that I don't have a test case

Re: [Qemu-devel] [PATCH] NVMe: Initial commit

2013-05-28 Thread Kevin Wolf
Am 26.05.2013 um 22:41 hat Keith Busch geschrieben: On Mon, 27 May 2013, Kevin Wolf wrote: Am 10.04.2013 um 22:16 hat Keith Busch geschrieben: Initial commit for emulated nvme pci storage device. Implements the minimum from the specification to work with existing drivers. Cc: Keith Busch

[Qemu-devel] [PATCH 00/16] Make qemu-io commands available in the monitor

2013-05-28 Thread Kevin Wolf
This is a prerequisite for some kind of tests. It involves reorganising the qemu-io code so that the command part can be separated and doesn't pollute the global namespace any more, so we can link it with qemu. Kevin Wolf (16): qemu-io: Remove unused args_command cutils: Support 'P' and 'E

[Qemu-devel] [PATCH 03/16] qemu-io: Make cvtnum() a wrapper around strtosz_suffix()

2013-05-28 Thread Kevin Wolf
No reason to implement the same thing multiple times. A nice side effect is that fractional numbers like 0.5M can be used in qemu-io now. Signed-off-by: Kevin Wolf kw...@redhat.com --- cmd.c | 37 - cmd.h | 1 - qemu-io.c | 6 ++ 3 files changed

[Qemu-devel] [PATCH 04/16] qemu-io: Handle cvtnum() errors in 'alloc'

2013-05-28 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com --- qemu-io.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/qemu-io.c b/qemu-io.c index 8a719a8..b4f56fc 100644 --- a/qemu-io.c +++ b/qemu-io.c @@ -1596,7 +1596,10 @@ static int alloc_f(int argc, char **argv) int ret

[Qemu-devel] [PATCH 01/16] qemu-io: Remove unused args_command

2013-05-28 Thread Kevin Wolf
The original intention seems to be something with handling multiple images at once, but this has never been implemented and the only function ever registered is implemented to make everything behave like a global command. Just do that unconditionally now. Signed-off-by: Kevin Wolf kw

[Qemu-devel] [PATCH 08/16] qemu-io: Move 'help' function

2013-05-28 Thread Kevin Wolf
No reason to treat it different from other commands. Move it to qemu-io-cmds.c, adapt the coding style and register it like any other command. Signed-off-by: Kevin Wolf kw...@redhat.com --- cmd.c | 79 -- cmd.h | 1

[Qemu-devel] [PATCH 11/16] qemu-io: Move functions for registering and running commands

2013-05-28 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com --- cmd.c | 113 - cmd.h | 11 +--- qemu-io-cmds.c | 192 ++--- qemu-io.c | 10 +-- 4 files changed, 148 insertions(+), 178 deletions(-) diff

[Qemu-devel] [PATCH 02/16] cutils: Support 'P' and 'E' suffixes in strtosz()

2013-05-28 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com --- include/qemu-common.h | 2 ++ monitor.c | 8 qemu-img.c | 10 ++ tests/qemu-iotests/049.out | 8 util/cutils.c | 4 5 files changed, 20 insertions(+), 12 deletions

[Qemu-devel] [PATCH 14/16] qemu-io: Interface cleanup

2013-05-28 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com --- cmd.h | 48 include/qemu-io.h | 46 ++ qemu-io-cmds.c| 14 +++--- qemu-io.c | 7 +++ 4 files changed, 56 insertions

[Qemu-devel] [PATCH 10/16] qemu-io: Move qemu_strsep() to cutils.c

2013-05-28 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com --- cmd.c | 21 - include/qemu-common.h | 1 + util/cutils.c | 21 + 3 files changed, 22 insertions(+), 21 deletions(-) diff --git a/cmd.c b/cmd.c index 8496e74..f6bf2c5 100644 --- a/cmd.c

[Qemu-devel] [PATCH 15/16] qemu-io: Use the qemu version for -V

2013-05-28 Thread Kevin Wolf
Always printing 0.0.1 and never updating the version number wasn't very useful. qemu-io is released with qemu, so using the same version number makes most sense. Signed-off-by: Kevin Wolf kw...@redhat.com --- qemu-io.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/qemu

[Qemu-devel] [PATCH 09/16] qemu-io: Move 'quit' function

2013-05-28 Thread Kevin Wolf
This one only makes sense in the context of the qemu-io tool, so move it to qemu-io.c. Adapt coding style and register it like other commands. Signed-off-by: Kevin Wolf kw...@redhat.com --- cmd.c | 29 - cmd.h | 2 -- qemu-io.c | 17 - 3 files

[Qemu-devel] [PATCH 16/16] Make qemu-io commands available in the monitor

2013-05-28 Thread Kevin Wolf
The QMP version is flagged with a __org.qemu.debug- prefix in order to reinforce the statement that qemu-io is for testing and debugging only, with no API guarantees. The HMP version is simply called 'qemu-io' for convenience. Signed-off-by: Kevin Wolf kw...@redhat.com --- Makefile | 2

[Qemu-devel] [PATCH 12/16] qemu-io: Move command_loop() and friends

2013-05-28 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com --- cmd.c | 139 -- cmd.h | 9 qemu-io.c | 139 ++ 3 files changed, 139 insertions(+), 148 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 05/16] qemu-io: Don't use global bs in command implementations

2013-05-28 Thread Kevin Wolf
Am 28.05.2013 um 17:27 hat Kevin Wolf geschrieben: Pass in the BlockDriverState to the command handlers instead of using the global variable. This is an important step to make the commands usable outside of qemu-io. Signed-off-by: Kevin Wolf kw...@redhat.com @@ -1793,7 +1808,7 @@ static

[Qemu-devel] [PATCH 13/16] qemu-io: Move remaining helpers from cmd.c

2013-05-28 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com --- Makefile | 2 +- cmd.c | 139 - cmd.h | 14 -- qemu-io-cmds.c | 104 ++ 4 files changed, 105 insertions(+), 154 deletions

[Qemu-devel] [PATCH 05/16] qemu-io: Don't use global bs in command implementations

2013-05-28 Thread Kevin Wolf
Pass in the BlockDriverState to the command handlers instead of using the global variable. This is an important step to make the commands usable outside of qemu-io. Signed-off-by: Kevin Wolf kw...@redhat.com --- cmd.c | 6 ++- cmd.h | 8 ++- qemu-io.c | 165

[Qemu-devel] [PATCH 07/16] qemu-io: Factor out qemuio_command

2013-05-28 Thread Kevin Wolf
It's duplicated code. Move it to qemu-io-cmds.c because it's not dependent on any static data of the qemu-io tool. Signed-off-by: Kevin Wolf kw...@redhat.com --- cmd.c | 43 +-- cmd.h | 3 ++- qemu-io-cmds.c | 24

Re: [Qemu-devel] [PATCH 16/16] Make qemu-io commands available in the monitor

2013-05-29 Thread Kevin Wolf
Am 28.05.2013 um 18:07 hat Eric Blake geschrieben: On 05/28/2013 09:27 AM, Kevin Wolf wrote: The QMP version is flagged with a __org.qemu.debug- prefix in order to reinforce the statement that qemu-io is for testing and debugging only, with no API guarantees. Correct use of naming

Re: [Qemu-devel] [PATCH v2] block: add block driver read only whitelist

2013-05-29 Thread Kevin Wolf
Am 29.05.2013 um 10:41 hat Fam Zheng geschrieben: We may want to include a driver in the whitelist for read only tasks such as diagnosing or exporting guest data (with libguestfs as a good example). This patch introduces a readonly whitelist option, and for backward compatibility, the old

Re: [Qemu-devel] [PATCH 2/4] qemu-iotests: make cancel_and_wait() common

2013-05-29 Thread Kevin Wolf
by wait_ready_and_cancel(), which uses the new wait_ready() and cancel_and_wait() underneath. Suggested-by: Kevin Wolf kw...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041 index ff89427..c4ce75e 100755 --- a/tests/qemu-iotests

Re: [Qemu-devel] [PATCH 0/4] qemu-iotests: reduce iotests.py code duplication

2013-05-29 Thread Kevin Wolf
Am 28.05.2013 um 17:11 hat Stefan Hajnoczi geschrieben: Tests 030 and 041 are written in Python and use the iotests.py module. Push common code down into iotests.py. My 'drive-backup' series takes advantage will take advantage of this - kwolf pointed out that earlier revisions were

Re: [Qemu-devel] [PATCH v2] block: add block driver read only whitelist

2013-05-29 Thread Kevin Wolf
Am 29.05.2013 um 10:41 hat Fam Zheng geschrieben: We may want to include a driver in the whitelist for read only tasks such as diagnosing or exporting guest data (with libguestfs as a good example). This patch introduces a readonly whitelist option, and for backward compatibility, the old

[Qemu-devel] [PATCH 3/3] ide-test: Add FLUSH CACHE test case

2013-05-29 Thread Kevin Wolf
This checks in particular that BSY is set while the flush request is in flight. Signed-off-by: Kevin Wolf kw...@redhat.com --- tests/ide-test.c | 40 1 file changed, 40 insertions(+) diff --git a/tests/ide-test.c b/tests/ide-test.c index 365e995..5744462

[Qemu-devel] [PATCH 0/3] ide: Set BSY bit during FLUSH

2013-05-29 Thread Kevin Wolf
The test case depends on the qemu-io series I sent yesterday. ([PATCH 00/16] Make qemu-io commands available in the monitor) Andreas Färber (1): ide: Set BSY bit during FLUSH Kevin Wolf (2): blkdebug: Add BLKDBG_FLUSH_TO_OS/DISK events ide-test: Add FLUSH CACHE test case block.c

[Qemu-devel] [PATCH 2/3] ide: Set BSY bit during FLUSH

2013-05-29 Thread Kevin Wolf
Färber afaer...@suse.de Signed-off-by: Kevin Wolf kw...@redhat.com --- hw/ide/core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/ide/core.c b/hw/ide/core.c index c7a8041..bf1ff18 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -795,6 +795,8 @@ static void ide_flush_cb(void *opaque, int

Re: [Qemu-devel] [PATCH v3] block: add block driver read only whitelist

2013-05-29 Thread Kevin Wolf
Am 29.05.2013 um 13:35 hat Fam Zheng geschrieben: We may want to include a driver in the whitelist for read only tasks such as diagnosing or exporting guest data (with libguestfs as a good example). This patch introduces a readonly whitelist option, and for backward compatibility, the old

Re: [Qemu-devel] [PATCH 0/4] qemu-iotests: reduce iotests.py code duplication

2013-05-29 Thread Kevin Wolf
Am 28.05.2013 um 17:11 hat Stefan Hajnoczi geschrieben: Tests 030 and 041 are written in Python and use the iotests.py module. Push common code down into iotests.py. My 'drive-backup' series takes advantage will take advantage of this - kwolf pointed out that earlier revisions were

[Qemu-devel] [PATCH 1/3] blkdebug: Add BLKDBG_FLUSH_TO_OS/DISK events

2013-05-29 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c | 8 block/blkdebug.c | 3 +++ include/block/block.h | 3 +++ 3 files changed, 10 insertions(+), 4 deletions(-) diff --git a/block.c b/block.c index 3f87489..52a2101 100644 --- a/block.c +++ b/block.c @@ -3307,13

Re: [Qemu-devel] [PATCH 2/3] ide: Set BSY bit during FLUSH

2013-05-29 Thread Kevin Wolf
Am 29.05.2013 um 13:50 hat Andreas Färber geschrieben: Am 29.05.2013 13:34, schrieb Kevin Wolf: From: Andreas Färber afaer...@suse.de The implementation of the ATA FLUSH command invokes a flush at the block layer, which may on raw files on POSIX entail a synchronous fdatasync

Re: [Qemu-devel] [PATCH 06/16] qemu-io: Split off commands to qemu-io-cmds.c

2013-06-04 Thread Kevin Wolf
Am 29.05.2013 um 22:29 hat Eric Blake geschrieben: On 05/28/2013 09:27 AM, Kevin Wolf wrote: This is the implementation of all qemu-io commands that make sense to be called from the qemu monitor, i.e. everything except open, close and quit. Signed-off-by: Kevin Wolf kw...@redhat.com

Re: [Qemu-devel] [PATCH 16/16] Make qemu-io commands available in the monitor

2013-06-04 Thread Kevin Wolf
Am 29.05.2013 um 19:51 hat Luiz Capitulino geschrieben: On Wed, 29 May 2013 10:13:42 +0200 Kevin Wolf kw...@redhat.com wrote: Am 28.05.2013 um 18:07 hat Eric Blake geschrieben: On 05/28/2013 09:27 AM, Kevin Wolf wrote: The QMP version is flagged with a __org.qemu.debug- prefix

Re: [Qemu-devel] [PATCH 08/16] qemu-io: Move 'help' function

2013-06-04 Thread Kevin Wolf
Am 29.05.2013 um 23:25 hat Eric Blake geschrieben: On 05/28/2013 09:27 AM, Kevin Wolf wrote: No reason to treat it different from other commands. Move it to qemu-io-cmds.c, adapt the coding style and register it like any other command. Signed-off-by: Kevin Wolf kw...@redhat.com

[Qemu-devel] [PULL 01/10] qemu-iotests: fix 054 cluster size help output

2013-06-04 Thread Kevin Wolf
. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- tests/qemu-iotests/054.out | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/054.out b/tests/qemu-iotests/054.out index 0b2fe30..2f357c2 100644 --- a/tests/qemu

[Qemu-devel] [PULL 02/10] block: add block driver read only whitelist

2013-06-04 Thread Kevin Wolf
,raw,file,qed \ --block-drv-ro-whitelist=vmdk Signed-off-by: Fam Zheng f...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c | 43 +++ blockdev.c| 4 ++-- configure | 20

[Qemu-devel] [PULL 03/10] qemu-iotests: make assert_no_active_block_jobs() common

2013-06-04 Thread Kevin Wolf
From: Stefan Hajnoczi stefa...@redhat.com Tests 030 and 041 both use query-block-jobs to check whether any block jobs are active. Make this code common so that 'drive-backup' and other new feature tests will be able to reuse it. Suggested-by: Kevin Wolf kw...@redhat.com Signed-off-by: Stefan

[Qemu-devel] [PULL 04/10] qemu-iotests: make cancel_and_wait() common

2013-06-04 Thread Kevin Wolf
(), which uses the new wait_ready() and cancel_and_wait() underneath. Suggested-by: Kevin Wolf kw...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- tests/qemu-iotests/030| 15 --- tests/qemu-iotests/041| 58

[Qemu-devel] [PULL 06/10] qemu-iotests: make create_image() common

2013-06-04 Thread Kevin Wolf
From: Stefan Hajnoczi stefa...@redhat.com Both 030 and 041 use create_image(). Move it to iotests.py. Also drop ImageStreamingTestCase since the class now has no methods. Suggested-by: Kevin Wolf kw...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Kevin Wolf kw

[Qemu-devel] [PULL 05/10] qemu-iotests: make compare_images() common

2013-06-04 Thread Kevin Wolf
and is more efficient, switch to it. This function will be reused by the 'drive-backup' test case. Suggested-by: Kevin Wolf kw...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- tests/qemu-iotests/041| 41

[Qemu-devel] [PULL 10/10] block: dump snapshot and image info to specified output

2013-06-04 Thread Kevin Wolf
be used by both qemu and qemu-img with correct parameter specified. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qapi.c | 66 include/block/qapi.h | 6 +++-- qemu-img.c

[Qemu-devel] [PULL 09/10] block: move qmp and info dump related code to block/qapi.c

2013-06-04 Thread Kevin Wolf
block.h and snapshot.h are at the same level in include path, block_int.h and qapi.h will both include them. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c | 185

[Qemu-devel] [PULL 00/10] Block patches

2013-06-04 Thread Kevin Wolf
The following changes since commit 171392406d8e230d62e5ebf4805f71460854b8ec: gtk: don't use g_object_unref on GdkCursor (2013-06-03 16:14:05 -0500) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony for you to fetch changes up to

Re: [Qemu-devel] [PATCH 16/16] Make qemu-io commands available in the monitor

2013-06-04 Thread Kevin Wolf
Am 04.06.2013 um 14:40 hat Luiz Capitulino geschrieben: On Tue, 4 Jun 2013 12:08:23 +0200 Kevin Wolf kw...@redhat.com wrote: Am 29.05.2013 um 19:51 hat Luiz Capitulino geschrieben: On Wed, 29 May 2013 10:13:42 +0200 Kevin Wolf kw...@redhat.com wrote: Am 28.05.2013 um 18:07 hat

[Qemu-devel] [PULL 08/10] block: move snapshot code in block.c to block/snapshot.c

2013-06-04 Thread Kevin Wolf
style errors reported by check script. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c | 100 -- block/Makefile.objs | 1 + block/snapshot.c | 157

[Qemu-devel] [PULL 07/10] block: drop bs_snapshots global variable

2013-06-04 Thread Kevin Wolf
xiaw...@linux.vnet.ibm.com Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c | 28 include/block/block.h | 1 - savevm.c | 19 +++ 3 files changed, 15 insertions

Re: [Qemu-devel] [PATCH V3 0/4] qapi and snapshot code clean up in block layer

2013-06-04 Thread Kevin Wolf
Am 25.05.2013 um 05:09 hat Wenchao Xia geschrieben: These patches are the common part of my hmp/qmp block query series and Pavel's qmp snapshot command converion series. It mainly does following things: 1 move snapshot related code to block/snapshot.c, qmp and info dumping code to

Re: [Qemu-devel] [PATCH v2] blockdev: reset werror/rerror on drive_del

2013-06-05 Thread Kevin Wolf
. I/O may still be submitted to the drive after drive_del if the guest does not process the PCI hot unplug notification. Reported-by: Dafna Ron d...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Reviewed-by: Kevin Wolf kw...@redhat.com

[Qemu-devel] [PATCH v2 01/16] qemu-io: Remove unused args_command

2013-06-05 Thread Kevin Wolf
The original intention seems to be something with handling multiple images at once, but this has never been implemented and the only function ever registered is implemented to make everything behave like a global command. Just do that unconditionally now. Signed-off-by: Kevin Wolf kw

[Qemu-devel] [PATCH v2 02/16] cutils: Support 'P' and 'E' suffixes in strtosz()

2013-06-05 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- include/qemu-common.h | 2 ++ monitor.c | 8 qemu-img.c | 10 ++ tests/qemu-iotests/049.out | 8 util/cutils.c | 4 5

[Qemu-devel] [PATCH v2 00/16] Make qemu-io commands available in the monitor

2013-06-05 Thread Kevin Wolf
This is a prerequisite for some kind of tests. It involves reorganising the qemu-io code so that the command part can be separated and doesn't pollute the global namespace any more, so we can link it with qemu. v2: - Drop the QMP command, make it HMP only - Minor review comments like typos Kevin

[Qemu-devel] [PATCH v2 03/16] qemu-io: Make cvtnum() a wrapper around strtosz_suffix()

2013-06-05 Thread Kevin Wolf
No reason to implement the same thing multiple times. A nice side effect is that fractional numbers like 0.5M can be used in qemu-io now. Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- cmd.c | 37 - cmd.h | 1

[Qemu-devel] [PATCH v2 04/16] qemu-io: Handle cvtnum() errors in 'alloc'

2013-06-05 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- qemu-io.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/qemu-io.c b/qemu-io.c index 8a719a8..b4f56fc 100644 --- a/qemu-io.c +++ b/qemu-io.c @@ -1596,7 +1596,10 @@ static int

[Qemu-devel] [PATCH v2 15/16] qemu-io: Use the qemu version for -V

2013-06-05 Thread Kevin Wolf
Always printing 0.0.1 and never updating the version number wasn't very useful. qemu-io is released with qemu, so using the same version number makes most sense. Signed-off-by: Kevin Wolf kw...@redhat.com --- qemu-io.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/qemu

[Qemu-devel] [PATCH v2 11/16] qemu-io: Move functions for registering and running commands

2013-06-05 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- cmd.c | 113 - cmd.h | 11 +--- qemu-io-cmds.c | 192 ++--- qemu-io.c | 10 +-- 4 files changed

[Qemu-devel] [PATCH v2 10/16] qemu-io: Move qemu_strsep() to cutils.c

2013-06-05 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- cmd.c | 21 - include/qemu-common.h | 1 + util/cutils.c | 21 + 3 files changed, 22 insertions(+), 21 deletions(-) diff --git a/cmd.c b/cmd.c

[Qemu-devel] [PATCH v2 13/16] qemu-io: Move remaining helpers from cmd.c

2013-06-05 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com --- Makefile | 2 +- cmd.c | 139 - cmd.h | 14 -- qemu-io-cmds.c | 104 ++ 4 files changed, 105 insertions(+), 154 deletions

[Qemu-devel] [PATCH v2 07/16] qemu-io: Factor out qemuio_command

2013-06-05 Thread Kevin Wolf
It's duplicated code. Move it to qemu-io-cmds.c because it's not dependent on any static data of the qemu-io tool. Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- cmd.c | 43 +-- cmd.h | 3

[Qemu-devel] [PATCH v2 09/16] qemu-io: Move 'quit' function

2013-06-05 Thread Kevin Wolf
This one only makes sense in the context of the qemu-io tool, so move it to qemu-io.c. Adapt coding style and register it like other commands. Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- cmd.c | 29 - cmd.h | 2

[Qemu-devel] [PATCH v2 14/16] qemu-io: Interface cleanup

2013-06-05 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com --- cmd.h | 48 include/qemu-io.h | 46 ++ qemu-io-cmds.c| 14 +++--- qemu-io.c | 7 +++ 4 files changed, 56 insertions

[Qemu-devel] [PATCH v2 08/16] qemu-io: Move 'help' function

2013-06-05 Thread Kevin Wolf
No reason to treat it different from other commands. Move it to qemu-io-cmds.c, adapt the coding style and register it like any other command. Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- cmd.c | 79

[Qemu-devel] [PATCH v2 16/16] Make qemu-io commands available in HMP

2013-06-05 Thread Kevin Wolf
It was decided to not make this command available in QMP in order to make clear that this is not supposed to be a stable API and should be used only for testing and debugging purposes. Signed-off-by: Kevin Wolf kw...@redhat.com --- Makefile| 2 +- Makefile.objs | 1 + hmp-commands.hx

Re: [Qemu-devel] [PATCH 05/16] qemu-io: Don't use global bs in command implementations

2013-06-05 Thread Kevin Wolf
Am 05.06.2013 um 14:28 hat Stefan Hajnoczi geschrieben: On Tue, May 28, 2013 at 05:27:25PM +0200, Kevin Wolf wrote: Pass in the BlockDriverState to the command handlers instead of using the global variable. This is an important step to make the commands usable outside of qemu-io

[Qemu-devel] [PATCH v2 05/16] qemu-io: Don't use global bs in command implementations

2013-06-05 Thread Kevin Wolf
Pass in the BlockDriverState to the command handlers instead of using the global variable. This is an important step to make the commands usable outside of qemu-io. Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- cmd.c | 6 ++- cmd.h | 8

[Qemu-devel] [PATCH v2 12/16] qemu-io: Move command_loop() and friends

2013-06-05 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com --- cmd.c | 139 -- cmd.h | 9 qemu-io.c | 139 ++ 3 files changed, 139 insertions(+), 148 deletions(-) diff --git

[Qemu-devel] [PATCH v2 2/4] ide-test: Add enum value for DEV

2013-06-05 Thread Kevin Wolf
Get rid of the magic number. Signed-off-by: Kevin Wolf kw...@redhat.com --- tests/ide-test.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/ide-test.c b/tests/ide-test.c index 365e995..1c31a2e 100644 --- a/tests/ide-test.c +++ b/tests/ide-test.c @@ -64,6 +64,7

[Qemu-devel] [PATCH v2 4/4] ide-test: Add FLUSH CACHE test case

2013-06-05 Thread Kevin Wolf
This checks in particular that BSY is set while the flush request is in flight. Signed-off-by: Kevin Wolf kw...@redhat.com --- tests/ide-test.c | 40 1 file changed, 40 insertions(+) diff --git a/tests/ide-test.c b/tests/ide-test.c index 1c31a2e..828e71a

[Qemu-devel] [PATCH v2 0/4] ide: Set BSY bit during FLUSH

2013-06-05 Thread Kevin Wolf
Still depends on the qemu-io series ([PATCH v2 00/16] Make qemu-io commands available in the monitor) v2: - Dropped unnecessary hunk in the actual fix - Avoid magic number 0x10 and change the preexisting case Andreas Färber (1): ide: Set BSY bit during FLUSH Kevin Wolf (3): blkdebug: Add

[Qemu-devel] [PATCH v2 3/4] ide: Set BSY bit during FLUSH

2013-06-05 Thread Kevin Wolf
Färber afaer...@suse.de Signed-off-by: Kevin Wolf kw...@redhat.com --- hw/ide/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ide/core.c b/hw/ide/core.c index c7a8041..9926d92 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -814,6 +814,7 @@ void ide_flush_cache(IDEState *s

Re: [Qemu-devel] [PATCH 1/2] nvram: Add TPM NVRAM implementation

2013-06-05 Thread Kevin Wolf
Am 05.06.2013 um 15:28 hat Corey Bryant geschrieben: + +if (rwr-rc == 0) { +rwr-rc = rwr-num_sectors; +*rwr-blob_r = g_malloc(rwr-size); +memcpy(*rwr-blob_r, buf, rwr-size); Use bdrv_pread()/bdrv_pwrite() for byte-granularity I/O instead of duplicating the

Re: [Qemu-devel] [PATCH V19 6/8] add debug event for add-cow

2013-06-05 Thread Kevin Wolf
Am 30.05.2013 um 12:00 hat Dongxu Wang geschrieben: From: Dong Xu Wang wdon...@linux.vnet.ibm.com Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com Signed-off-by: Dongxu Wang wdon...@linux.vnet.ibm.com One of these should surely be enough? --- block/blkdebug.c | 3 +++

[Qemu-devel] [PATCH v2 1/4] blkdebug: Add BLKDBG_FLUSH_TO_OS/DISK events

2013-06-05 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c | 8 block/blkdebug.c | 3 +++ include/block/block.h | 3 +++ 3 files changed, 10 insertions(+), 4 deletions(-) diff --git a/block.c b/block.c index 3f616de..79ad33d 100644 --- a/block.c +++ b/block.c @@ -3186,13

Re: [Qemu-devel] [PATCH 2/2] sheepdog: support 'qemu-img snapshot -a'

2013-06-06 Thread Kevin Wolf
Am 06.06.2013 um 13:57 hat Liu Yuan geschrieben: Just call sd_create_branch() to rollback the image is good enough Cc: qemu-devel@nongnu.org Cc: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp Cc: Kevin Wolf kw...@redhat.com Cc: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Liu Yuan

Re: [Qemu-devel] [PATCH 1/2] sheepdog: fix snapshot tag initialization

2013-06-06 Thread Kevin Wolf
Am 06.06.2013 um 13:57 hat Liu Yuan geschrieben: This is an old and obvious bug. We should pass snapshot_id to the tag. Or simple command like 'qemu-img snapshot -a tag sheepdog:image' will fail Cc: qemu-devel@nongnu.org Cc: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp Cc: Kevin Wolf kw

Re: [Qemu-devel] [PATCH 2/2] sheepdog: support 'qemu-img snapshot -a'

2013-06-07 Thread Kevin Wolf
Am 06.06.2013 um 15:09 hat Liu Yuan geschrieben: On 06/06/2013 08:46 PM, Kevin Wolf wrote: Am 06.06.2013 um 13:57 hat Liu Yuan geschrieben: Just call sd_create_branch() to rollback the image is good enough Cc: qemu-devel@nongnu.org Cc: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp Cc

Re: [Qemu-devel] [PATCH 2/2] sheepdog: support 'qemu-img snapshot -a'

2013-06-07 Thread Kevin Wolf
Am 07.06.2013 um 15:48 hat Liu Yuan geschrieben: On 06/07/2013 03:31 PM, Kevin Wolf wrote: Am 06.06.2013 um 15:09 hat Liu Yuan geschrieben: On 06/06/2013 08:46 PM, Kevin Wolf wrote: Am 06.06.2013 um 13:57 hat Liu Yuan geschrieben: Only when the write comes from VM, we do the following

Re: [Qemu-devel] [PATCH 2/2] sheepdog: support 'qemu-img snapshot -a'

2013-06-07 Thread Kevin Wolf
Am 07.06.2013 um 18:14 hat Liu Yuan geschrieben: On 06/07/2013 11:22 PM, Kevin Wolf wrote: Am 07.06.2013 um 15:48 hat Liu Yuan geschrieben: On 06/07/2013 03:31 PM, Kevin Wolf wrote: Am 06.06.2013 um 15:09 hat Liu Yuan geschrieben: On 06/06/2013 08:46 PM, Kevin Wolf wrote: Am 06.06.2013

  1   2   3   4   5   6   7   8   9   10   >