Re: [Qemu-devel] [RFC PATCH v4 1/3] Mediated device Core driver

2016-06-05 Thread Kirti Wankhede
On 6/3/2016 2:27 PM, Dong Jia wrote: > On Wed, 25 May 2016 01:28:15 +0530 > Kirti Wankhede <kwankh...@nvidia.com> wrote: > > > ...snip... > >> +struct phy_device_ops { >> +struct module *owner; >> +const struct attribute_group **dev_attr_gr

Re: [Qemu-devel] [RFC PATCH v4 1/3] Mediated device Core driver

2016-05-26 Thread Kirti Wankhede
Thanks Alex. I'll consider all the nits and fix those in next version of patch. More below: On 5/26/2016 4:09 AM, Alex Williamson wrote: > On Wed, 25 May 2016 01:28:15 +0530 > Kirti Wankhede <kwankh...@nvidia.com> wrote: > ... >> + >> +config MDEV >> +

[Qemu-devel] [PATCH 2/3] VFIO driver for mediated PCI device

2016-06-20 Thread Kirti Wankhede
region information from vendor driver. - trap and emulate PCI config space and BAR region. - Send interrupt configuration information to vendor driver. - mmap mappable region with invalidate mapping and fault on access to remap pfn. Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Sign

[Qemu-devel] [RFC PATCH v5 0/3] Add Mediated device support

2016-06-20 Thread Kirti Wankhede
with mmap region fault handler, EPT is not correctly populated with the information provided by remap_pfn_range() inside fault handler. - mmap invalidation mechanism will be added once above issue gets resolved. Tested: - Single vGPU VM - Multiple vGPU VMs on same GPU Thanks, Kirti Kirti

[Qemu-devel] [PATCH 1/3] Mediated device Core driver

2016-06-20 Thread Kirti Wankhede
to validate remap pfn request. This registration interface should be used by vendor drivers to register each physical device to mdev core driver. Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: I73a5084574270b14541c529461ea2f03c292d

[Qemu-devel] [PATCH 3/3] VFIO Type1 IOMMU: Add support for mediated devices

2016-06-20 Thread Kirti Wankhede
the change to keep mediated domain structure out of domain_list. Tested by assigning below combinations of devices to a single VM: - GPU pass through only - vGPU device only - One GPU pass through and one vGPU device - two GPU pass through Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Sign

Re: [Qemu-devel] [PATCH 1/3] Mediated device Core driver

2016-06-24 Thread Kirti Wankhede
Alex, Thanks for taking closer look. I'll incorporate all the nits you suggested. On 6/22/2016 3:00 AM, Alex Williamson wrote: > On Mon, 20 Jun 2016 22:01:46 +0530 > Kirti Wankhede <kwankh...@nvidia.com> wrote: > ... >> + >> +config MDEV >> +tristate

Re: [Qemu-devel] [PATCH 2/3] VFIO driver for mediated PCI device

2016-06-24 Thread Kirti Wankhede
Thanks Alex. On 6/22/2016 4:18 AM, Alex Williamson wrote: > On Mon, 20 Jun 2016 22:01:47 +0530 > Kirti Wankhede <kwankh...@nvidia.com> wrote: > >> + >> +static int get_mdev_region_info(struct mdev_device *mdev, >> +struct

Re: [Qemu-devel] VFIO based vGPU(was Re: [Announcement] 2015-Q3 release of XenGT - a Mediated ...)

2016-01-27 Thread Kirti Wankhede
On 1/28/2016 3:28 AM, Alex Williamson wrote: On Thu, 2016-01-28 at 02:25 +0530, Kirti Wankhede wrote: On 1/27/2016 9:30 PM, Alex Williamson wrote: On Wed, 2016-01-27 at 13:36 +0530, Kirti Wankhede wrote: On 1/27/2016 1:36 AM, Alex Williamson wrote: On Tue, 2016-01-26 at 02:20 -0800, Neo

Re: [Qemu-devel] [RFC PATCH v1 1/1] vGPU core driver : to provide common interface for vGPU.

2016-02-01 Thread Kirti Wankhede
Resending this mail again, somehow my previous mail didn't reached every to everyone's inbox. On 2/2/2016 3:16 AM, Kirti Wankhede wrote: Design for vGPU Driver: Main purpose of vGPU driver is to provide a common interface for vGPU management that can be used by differnt GPU drivers

Re: [Qemu-devel] [RFC PATCH v1 1/1] vGPU core driver : to provide common interface for vGPU.

2016-02-03 Thread Kirti Wankhede
On 2/3/2016 11:26 AM, Tian, Kevin wrote: [...] * @vgpu_create:Called to allocate basic resouces in graphics * driver for a particular vgpu. * @dev: physical pci device structure on which vgpu *should

Re: [Qemu-devel] [RFC PATCH v1 1/1] vGPU core driver : to provide common interface for vGPU.

2016-02-02 Thread Kirti Wankhede
On 2/2/2016 1:12 PM, Tian, Kevin wrote: From: Kirti Wankhede [mailto:kwankh...@nvidia.com] Sent: Tuesday, February 02, 2016 9:48 AM Resending this mail again, somehow my previous mail didn't reached every to everyone's inbox. On 2/2/2016 3:16 AM, Kirti Wankhede wrote: Design for vGPU Driver

Re: [Qemu-devel] VFIO based vGPU(was Re: [Announcement] 2015-Q3 release of XenGT - a Mediated ...)

2016-01-27 Thread Kirti Wankhede
On 1/27/2016 9:30 PM, Alex Williamson wrote: On Wed, 2016-01-27 at 13:36 +0530, Kirti Wankhede wrote: On 1/27/2016 1:36 AM, Alex Williamson wrote: On Tue, 2016-01-26 at 02:20 -0800, Neo Jia wrote: On Mon, Jan 25, 2016 at 09:45:14PM +, Tian, Kevin wrote: From: Alex Williamson

[Qemu-devel] [RFC PATCH v2 2/3] VFIO driver for vGPU device

2016-02-23 Thread Kirti Wankhede
from GPU driver. - trap and emulate PCI config space and BAR region. - Send interrupt configuration information to GPU driver. - mmap mappable region with invalidate mapping and fault on access to remap pfn. Thanks, Kirti. Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: N

[Qemu-devel] [RFC PATCH v2 1/3] vGPU Core driver

2016-02-23 Thread Kirti Wankhede
equest. This registration interface should be used by GPU drivers to register each physical device to vGPU driver. Updated this patch with couple of more functions in GPU driver interface which were discussed during v1 version of this RFC. Thanks, Kirti. Signed-off-by: Kirti Wankhede &

[Qemu-devel] [RFC PATCH v2 3/3] VFIO: Type1 IOMMU mapping support for vGPU

2016-02-23 Thread Kirti Wankhede
in vfio_iommu_type1.c and with that will add API to unpin pages. This is for the reference to review the overall design of vGPU. Thanks, Kirti. Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> --- drivers/vgpu/Makefile|1 +

Re: [Qemu-devel] VFIO based vGPU(was Re: [Announcement] 2015-Q3 release of XenGT - a Mediated ...)

2016-01-27 Thread Kirti Wankhede
On 1/27/2016 1:36 AM, Alex Williamson wrote: On Tue, 2016-01-26 at 02:20 -0800, Neo Jia wrote: On Mon, Jan 25, 2016 at 09:45:14PM +, Tian, Kevin wrote: From: Alex Williamson [mailto:alex.william...@redhat.com] Hi Alex, Kevin and Jike, (Seems I shouldn't use attachment, resend it

Re: [Qemu-devel] [RFC PATCH v3 1/3] vGPU Core driver

2016-05-06 Thread Kirti Wankhede
On 5/6/2016 5:44 PM, Jike Song wrote: > On 05/05/2016 05:06 PM, Tian, Kevin wrote: >>> From: Kirti Wankhede >>> >>> >> + * @validate_map_request: Validate remap pfn request >>> >> + *

[Qemu-devel] [RFC PATCH v3 1/3] vGPU Core driver

2016-05-02 Thread Kirti Wankhede
equest. This registration interface should be used by GPU drivers to register each physical device to vGPU driver. Updated this patch with couple of more functions in GPU driver interface which were discussed during v1 version of this RFC. Thanks, Kirti. Signed-off-by: Kirti Wankhede &

[Qemu-devel] [RFC PATCH v3 2/3] VFIO driver for vGPU device

2016-05-02 Thread Kirti Wankhede
from GPU driver. - trap and emulate PCI config space and BAR region. - Send interrupt configuration information to GPU driver. - mmap mappable region with invalidate mapping and fault on access to remap pfn. Thanks, Kirti. Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: N

[Qemu-devel] [RFC PATCH v3 3/3] VFIO Type1 IOMMU change: to support with iommu and without iommu

2016-05-02 Thread Kirti Wankhede
only - vGPU device only - One GPU pass through and one vGPU device - two GPU pass through Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: I6e35e9fc7f14049226365e9ecef3814dc4ca1738 --- drivers/vfio/vfio_iommu_ty

[Qemu-devel] [RFC PATCH v3 0/3] Add vGPU support

2016-05-02 Thread Kirti Wankhede
Type1 IOMMU patch provide new set of APIs for guest page translation. What's left to do? VFIO driver for vGPU device doesn't support devices with MSI-X enabled. Please review. Thanks, Kirti Kirti Wankhede (3): vGPU Core driver VFIO driver for vGPU device VFIO Type1 IOMMU change: to support

Re: [Qemu-devel] [RFC PATCH v3 1/3] vGPU Core driver

2016-05-04 Thread Kirti Wankhede
Thanks Alex. >> +config VGPU_VFIO >> +tristate >> +depends on VGPU >> +default n >> + > > This is a little bit convoluted, it seems like everything added in this > patch is vfio agnostic, it doesn't necessarily care what the consumer > is. That makes me think we should only be

Re: [Qemu-devel] [RFC PATCH v3 3/3] VFIO Type1 IOMMU change: to support with iommu and without iommu

2016-05-05 Thread Kirti Wankhede
On 5/4/2016 4:13 AM, Alex Williamson wrote: > On Tue, 3 May 2016 00:10:41 +0530 > Kirti Wankhede <kwankh...@nvidia.com> wrote: > [..] >> + if (domain->vfio_iommu_api_only) >> + mm = domain->vmm_mm; >> + else >> +

Re: [Qemu-devel] [RFC PATCH v3 2/3] VFIO driver for vGPU device

2016-05-04 Thread Kirti Wankhede
On 5/5/2016 2:44 AM, Neo Jia wrote: On Wed, May 04, 2016 at 11:06:19AM -0600, Alex Williamson wrote: On Wed, 4 May 2016 03:23:13 + "Tian, Kevin" wrote: From: Alex Williamson [mailto:alex.william...@redhat.com] Sent: Wednesday, May 04, 2016 6:43 AM + +

Re: [Qemu-devel] [RFC PATCH v3 2/3] VFIO driver for vGPU device

2016-05-04 Thread Kirti Wankhede
On 5/4/2016 4:13 AM, Alex Williamson wrote: > On Tue, 3 May 2016 00:10:40 +0530 >> obj-$(CONFIG_VGPU)+= vgpu.o >> +obj-$(CONFIG_VGPU_VFIO) += vgpu_vfio.o > > This is where we should add a new Kconfig entry for VGPU_VFIO, nothing > in patch 1 has any vfio

Re: [Qemu-devel] [RFC PATCH v3 1/3] vGPU Core driver

2016-05-05 Thread Kirti Wankhede
On 5/5/2016 2:36 PM, Tian, Kevin wrote: From: Kirti Wankhede Sent: Wednesday, May 04, 2016 9:32 PM Thanks Alex. >> +config VGPU_VFIO >> +tristate >> +depends on VGPU >> +default n >> + > > This is a little bit convoluted, it seems li

Re: [Qemu-devel] [RFC PATCH v3 1/3] vGPU Core driver

2016-05-05 Thread Kirti Wankhede
On 5/5/2016 5:37 PM, Tian, Kevin wrote: From: Kirti Wankhede [mailto:kwankh...@nvidia.com] Sent: Thursday, May 05, 2016 6:45 PM On 5/5/2016 2:36 PM, Tian, Kevin wrote: From: Kirti Wankhede Sent: Wednesday, May 04, 2016 9:32 PM Thanks Alex. >> +config VGPU_VFIO >> +

[Qemu-devel] [RFC PATCH v4 0/3] Add Mediated device support[was: Add vGPU support]

2016-05-24 Thread Kirti Wankhede
devices with MSI-X enabled. Please review. Kirti Wankhede (3): Mediated device Core driver VFIO driver for mediated PCI device VFIO Type1 IOMMU: Add support for mediated devices drivers/vfio/Kconfig| 1 + drivers/vfio/Makefile | 1 + drivers/vfio/mdev

[Qemu-devel] [RFC PATCH v4 1/3] Mediated device Core driver

2016-05-24 Thread Kirti Wankhede
to validate remap pfn request. This registration interface should be used by vendor drivers to register each physical device to mdev core driver. Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: I88f4482f7608f40550a152c5f882b64271287

[Qemu-devel] [RFC PATCH v4 2/3] VFIO driver for mediated PCI device

2016-05-24 Thread Kirti Wankhede
region information from vendor driver. - trap and emulate PCI config space and BAR region. - Send interrupt configuration information to vendor driver. - mmap mappable region with invalidate mapping and fault on access to remap pfn. Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Sign

[Qemu-devel] [RFC PATCH v4 3/3] VFIO Type1 IOMMU: Add support for mediated devices

2016-05-24 Thread Kirti Wankhede
the change to keep mediated domain structure out of domain_list. Tested by assigning below combinations of devices to a single VM: - GPU pass through only - vGPU device only - One GPU pass through and one vGPU device - two GPU pass through Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Sign

Re: [Qemu-devel] [RFC PATCH v4 2/3] VFIO driver for mediated PCI device

2016-05-25 Thread Kirti Wankhede
On 5/25/2016 1:45 PM, Tian, Kevin wrote: >> From: Kirti Wankhede [mailto:kwankh...@nvidia.com] >> Sent: Wednesday, May 25, 2016 3:58 AM >> >> VFIO driver registers with MDEV core driver. MDEV core driver creates >> mediated device and calls probe routine of MPCI

Re: [Qemu-devel] [RFC PATCH v4 1/3] Mediated device Core driver

2016-05-25 Thread Kirti Wankhede
On 5/25/2016 1:25 PM, Tian, Kevin wrote: >> From: Kirti Wankhede [mailto:kwankh...@nvidia.com] >> Sent: Wednesday, May 25, 2016 3:58 AM >> ... >> + >> +config MDEV >> +tristate "Mediated device driver framework" > > Sorry not a na

Re: [Qemu-devel] [PATCH v6 3/4] vfio iommu: Add support for mediated devices

2016-08-11 Thread Kirti Wankhede
Thanks Alex. I'll take care of suggested nits and rename structures and function. On 8/10/2016 12:30 AM, Alex Williamson wrote: > On Thu, 4 Aug 2016 00:33:53 +0530 > Kirti Wankhede <kwankh...@nvidia.com> wrote: > ... >> >> +/* >> + * Pin a set of guest PFNs and

Re: [Qemu-devel] [PATCH v6 2/4] vfio: VFIO driver for mediated PCI device

2016-08-11 Thread Kirti Wankhede
On 8/11/2016 4:30 AM, Alex Williamson wrote: > On Thu, 11 Aug 2016 02:53:10 +0530 > Kirti Wankhede <kwankh...@nvidia.com> wrote: > >> On 8/10/2016 12:30 AM, Alex Williamson wrote: >>> On Thu, 4 Aug 2016 00:33:52 +0530 >>> Kirt

Re: [Qemu-devel] [PATCH v6 2/4] vfio: VFIO driver for mediated PCI device

2016-08-11 Thread Kirti Wankhede
On 8/11/2016 9:54 PM, Alex Williamson wrote: > On Thu, 11 Aug 2016 21:29:35 +0530 > Kirti Wankhede <kwankh...@nvidia.com> wrote: > >> On 8/11/2016 4:30 AM, Alex Williamson wrote: >>> On Thu, 11 Aug 2016 02:53:10 +0530 >>> Kirti Wankhede <kwankh...@nvid

[Qemu-devel] [PATCH v6 0/4] Add Mediated device support

2016-08-03 Thread Kirti Wankhede
: KVM: MMU: prepare to support mapping of VM_IO and VM_PFNMAP frames Tested: - Single vGPU VM - Multiple vGPU VMs on same GPU Thanks, Kirti Kirti Wankhede (4): vfio: Mediated device Core driver vfio: VFIO driver for mediated PCI device vfio iommu: Add support for mediated devices

[Qemu-devel] [PATCH v6 4/4] docs: Add Documentation for Mediated devices

2016-08-03 Thread Kirti Wankhede
Add file Documentation/vfio-mediated-device.txt that include details of mediated device framework. Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: I137dd646442936090d92008b115908b7b2c7bc5d --- Documentation/vfio-mediated-devi

[Qemu-devel] [PATCH v6 3/4] vfio iommu: Add support for mediated devices

2016-08-03 Thread Kirti Wankhede
. Accouting for mdev device is only done if there is no iommu capable domain in the container. Tested by assigning below combinations of devices to a single VM: - GPU pass through only - vGPU device only - One GPU pass through and one vGPU device - two GPU pass through Signed-off-by: Kirti

[Qemu-devel] [PATCH v6 1/4] vfio: Mediated device Core driver

2016-08-03 Thread Kirti Wankhede
unsigned long addr, unsigned long size) void mdev_del_phys_mapping(struct mdev_device *mdev, unsigned long addr) API to be used by vendor driver to invalidate mapping: int mdev_device_invalidate_mapping(struct mdev_device *mdev, unsigned long addr

[Qemu-devel] [PATCH v6 2/4] vfio: VFIO driver for mediated PCI device

2016-08-03 Thread Kirti Wankhede
, fault handler maps physical devices region. - Add and delete mappable region's physical mappings to mdev's mapping tracking logic. Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: I583f4734752971d3d112324d69e2508c88f359ec

Re: [Qemu-devel] [PATCH v6 2/4] vfio: VFIO driver for mediated PCI device

2016-08-12 Thread Kirti Wankhede
On 8/13/2016 2:55 AM, Alex Williamson wrote: > On Fri, 12 Aug 2016 23:27:01 +0530 > Kirti Wankhede <kwankh...@nvidia.com> wrote: > >> On 8/12/2016 12:13 AM, Alex Williamson wrote: >> >>> >>> TBH, I don't see how providing a default implementation

Re: [Qemu-devel] [PATCH v6 1/4] vfio: Mediated device Core driver

2016-08-12 Thread Kirti Wankhede
On 8/13/2016 2:46 AM, Alex Williamson wrote: > On Sat, 13 Aug 2016 00:14:39 +0530 > Kirti Wankhede <kwankh...@nvidia.com> wrote: > >> On 8/10/2016 12:30 AM, Alex Williamson wrote: >>> On Thu, 4 Aug 2016 00:33:51 +0530 >>> Kirti Wankhede <kwankh...@nvi

Re: [Qemu-devel] [PATCH v6 2/4] vfio: VFIO driver for mediated PCI device

2016-08-10 Thread Kirti Wankhede
On 8/10/2016 12:30 AM, Alex Williamson wrote: > On Thu, 4 Aug 2016 00:33:52 +0530 > Kirti Wankhede <kwankh...@nvidia.com> wrote: > ... >> + >> +switch (info.index) { >> +case VFIO_PCI_CONFIG_REGION_INDEX: >> +

Re: [Qemu-devel] [PATCH v6 2/4] vfio: VFIO driver for mediated PCI device

2016-08-12 Thread Kirti Wankhede
On 8/12/2016 12:13 AM, Alex Williamson wrote: > > TBH, I don't see how providing a default implementation of > validate_map_request() is useful. How many mediated devices are going > to want to identity map resources from the parent? Even if they do, it > seems we can only support a single

Re: [Qemu-devel] [PATCH v6 1/4] vfio: Mediated device Core driver

2016-08-12 Thread Kirti Wankhede
On 8/10/2016 12:30 AM, Alex Williamson wrote: > On Thu, 4 Aug 2016 00:33:51 +0530 > Kirti Wankhede <kwankh...@nvidia.com> wrote: > > This is used later by mdev_device_start() and mdev_device_stop() to get > the parent_device so it can call the start and stop ops cal

Re: [Qemu-devel] [PATCH 2/3] VFIO driver for mediated PCI device

2016-06-28 Thread Kirti Wankhede
On 6/25/2016 1:15 AM, Alex Williamson wrote: > On Sat, 25 Jun 2016 00:04:27 +0530 > Kirti Wankhede <kwankh...@nvidia.com> wrote: > >>>> + >>>> +static int mdev_get_irq_count(struct vfio_mdev *vmdev, int irq_type) >>>> +{ >>&g

Re: [Qemu-devel] [PATCH v6 1/4] vfio: Mediated device Core driver

2016-08-05 Thread Kirti Wankhede
On 8/4/2016 12:51 PM, Tian, Kevin wrote: >> From: Kirti Wankhede [mailto:kwankh...@nvidia.com] >> Sent: Thursday, August 04, 2016 3:04 AM >> >> >> 2. Physical device driver interface >> This interface provides vendor driver the set APIs to manage physical

Re: [Qemu-devel] [PATCH v6 4/4] docs: Add Documentation for Mediated devices

2016-08-05 Thread Kirti Wankhede
On 8/4/2016 1:01 PM, Tian, Kevin wrote: >> From: Kirti Wankhede [mailto:kwankh...@nvidia.com] >> Sent: Thursday, August 04, 2016 3:04 AM >> >> + >> +* mdev_supported_types: (read only) >> +List the current supported mediated device types and its details.

Re: [Qemu-devel] [PATCH 1/3] Mediated device Core driver

2016-06-30 Thread Kirti Wankhede
On 6/25/2016 1:10 AM, Alex Williamson wrote: > On Fri, 24 Jun 2016 23:24:58 +0530 > Kirti Wankhede <kwankh...@nvidia.com> wrote: > >> Alex, >> >> Thanks for taking closer look. I'll incorporate all the nits you suggested. >> >> On 6/22/2016 3:00

Re: [Qemu-devel] [PATCH 2/3] VFIO driver for mediated PCI device

2016-06-30 Thread Kirti Wankhede
On 6/29/2016 8:24 AM, Alex Williamson wrote: > On Wed, 29 Jun 2016 00:15:23 +0530 > Kirti Wankhede <kwankh...@nvidia.com> wrote: > >> On 6/25/2016 1:15 AM, Alex Williamson wrote: >>> On Sat, 25 Jun 2016 00:04:27 +0530 >>> Kirt

Re: [Qemu-devel] [PATCH 1/3] Mediated device Core driver

2016-06-30 Thread Kirti Wankhede
On 6/30/2016 12:42 PM, Jike Song wrote: > On 06/29/2016 09:51 PM, Xiao Guangrong wrote: >> On 06/21/2016 12:31 AM, Kirti Wankhede wrote: >>> + mutex_unlock(_devices.list_lock); >>> + return parent; >>> +} >>> + >>> +static int

Re: [Qemu-devel] [PATCH 1/3] Mediated device Core driver

2016-06-30 Thread Kirti Wankhede
On 6/29/2016 7:21 PM, Xiao Guangrong wrote: > > > On 06/21/2016 12:31 AM, Kirti Wankhede wrote: >> Design for Mediated Device Driver: ... >> +static int mdev_add_attribute_group(struct device *dev, >> +const struct attribute_group **g

Re: [Qemu-devel] [PATCH 3/3] VFIO Type1 IOMMU: Add support for mediated devices

2016-06-28 Thread Kirti Wankhede
On 6/22/2016 9:16 AM, Alex Williamson wrote: > On Mon, 20 Jun 2016 22:01:48 +0530 > Kirti Wankhede <kwankh...@nvidia.com> wrote: > >> >> struct vfio_iommu { >> struct list_headdomain_list; >> +struct vfio_domain *mediated_d

Re: [Qemu-devel] [RFC v6-based v1 0/5] refine mdev framework

2016-08-19 Thread Kirti Wankhede
On 8/18/2016 11:55 PM, Alex Williamson wrote: > On Thu, 18 Aug 2016 16:42:14 +0800 > Dong Jia wrote: > >> On Wed, 17 Aug 2016 03:09:10 -0700 >> Neo Jia wrote: >> >>> On Wed, Aug 17, 2016 at 04:58:14PM +0800, Dong Jia wrote: On Tue, 16 Aug

[Qemu-devel] [PATCH v7 3/4] vfio iommu: Add support for mediated devices

2016-08-24 Thread Kirti Wankhede
. Accouting for mdev device is only done if there is no iommu capable domain in the container. Tested by assigning below combinations of devices to a single VM: - GPU pass through only - vGPU device only - One GPU pass through and one vGPU device - two GPU pass through Signed-off-by: Kirti

[Qemu-devel] [PATCH v7 4/4] docs: Add Documentation for Mediated devices

2016-08-24 Thread Kirti Wankhede
Add file Documentation/vfio-mediated-device.txt that include details of mediated device framework. Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: I137dd646442936090d92008b115908b7b2c7bc5d Reviewed-on: http://git-master/r/1182

[Qemu-devel] [PATCH v7 1/4] vfio: Mediated device Core driver

2016-08-24 Thread Kirti Wankhede
. Locks to serialize above callbacks are removed. If required, vendor driver can have locks to serialize above APIs in their driver. Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: I73a5084574270b14541c529461ea2f

[Qemu-devel] [PATCH v7 0/4] Add Mediated device support

2016-08-24 Thread Kirti Wankhede
TODO: Need to handle the case in vfio_type1_iommu module that Alex pointed out in v6 review, that is, if the devices attached to the normal IOMMU API domain go away, need to re-establish accounting for local domain. Kirti Wankhede (4): vfio: Mediated device Core driver vfio: VFIO driver for medi

[Qemu-devel] [PATCH v7 2/4] vfio: VFIO driver for mediated devices

2016-08-24 Thread Kirti Wankhede
regions. Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: I583f4734752971d3d112324d69e2508c88f359ec Reviewed-on: http://git-master/r/1175706 Reviewed-by: Automatic_Commit_Validation_User --- drivers/vfio/mdev/Kconfig

Re: [Qemu-devel] [PATCH v7 0/4] Add Mediated device support

2016-09-02 Thread Kirti Wankhede
On 9/2/2016 10:55 PM, Paolo Bonzini wrote: > > > On 02/09/2016 19:15, Kirti Wankhede wrote: >> On 9/2/2016 3:35 PM, Paolo Bonzini wrote: >>> >>> my-vgpu >>> pci__86_00_0 >>> >>> >>>

Re: [Qemu-devel] [PATCH v7 0/4] Add Mediated device support

2016-09-02 Thread Kirti Wankhede
On 9/2/2016 3:35 PM, Paolo Bonzini wrote: > > > On 02/09/2016 07:21, Kirti Wankhede wrote: >> On 9/2/2016 10:18 AM, Michal Privoznik wrote: >>> Okay, maybe I'm misunderstanding something. I just thought that users >>> will consult libvirt's nodedev driver

Re: [Qemu-devel] [PATCH v7 0/4] Add Mediated device support

2016-09-03 Thread Kirti Wankhede
On 9/3/2016 3:18 AM, Paolo Bonzini wrote: > > > On 02/09/2016 20:33, Kirti Wankhede wrote: >> We could even do: >>>> >>>> echo $UUID1:$GROUPA > create >>>> >>>> where $GROUPA is the group ID of a previously created mdev de

Re: [Qemu-devel] [libvirt] [PATCH v7 0/4] Add Mediated device support

2016-09-03 Thread Kirti Wankhede
On 9/3/2016 6:37 PM, Paolo Bonzini wrote: > > > On 03/09/2016 13:56, John Ferlan wrote: >> On 09/02/2016 05:48 PM, Paolo Bonzini wrote: >>> On 02/09/2016 20:33, Kirti Wankhede wrote: >>>> We could even do: >>>>>> >>>>>>

Re: [Qemu-devel] [PATCH v7 4/4] docs: Add Documentation for Mediated devices

2016-09-03 Thread Kirti Wankhede
Adding Eric. Eric, This is the v7 version of patch. I'll incorporate changes that you suggested here. Kirti. On 8/25/2016 9:23 AM, Kirti Wankhede wrote: > Add file Documentation/vfio-mediated-device.txt that include details of > mediated device framework. > > Signed-off-by: Ki

Re: [Qemu-devel] [libvirt] [PATCH v7 0/4] Add Mediated device support

2016-09-03 Thread Kirti Wankhede
On 9/3/2016 5:27 AM, Laine Stump wrote: > On 09/02/2016 05:44 PM, Paolo Bonzini wrote: >> >> >> On 02/09/2016 22:19, John Ferlan wrote: >>> We don't have such a pool for GPU's (yet) - although I suppose they >>> could just become a class of storage pools. >>> >>> The issue being nodedev device

Re: [Qemu-devel] [libvirt] [PATCH v7 0/4] Add Mediated device support

2016-09-03 Thread Kirti Wankhede
On 9/3/2016 1:59 AM, John Ferlan wrote: > > > On 09/02/2016 02:33 PM, Kirti Wankhede wrote: >> >> On 9/2/2016 10:55 PM, Paolo Bonzini wrote: >>> >>> >>> On 02/09/2016 19:15, Kirti Wankhede wrote: >>>> On 9/2/201

Re: [Qemu-devel] [PATCH v7 0/4] Add Mediated device support

2016-09-06 Thread Kirti Wankhede
On 9/6/2016 11:10 PM, Alex Williamson wrote: > On Sat, 3 Sep 2016 22:04:56 +0530 > Kirti Wankhede <kwankh...@nvidia.com> wrote: > >> On 9/3/2016 3:18 AM, Paolo Bonzini wrote: >>> >>> >>> On 02/09/2016 20:33, Kirti Wankhede wrote: >>>

Re: [Qemu-devel] [PATCH v7 0/4] Add Mediated device support

2016-09-01 Thread Kirti Wankhede
Alex, Thanks for summarizing the discussion. On 8/31/2016 9:18 PM, Alex Williamson wrote: > On Wed, 31 Aug 2016 15:04:13 +0800 > Jike Song wrote: > >> On 08/31/2016 02:12 PM, Tian, Kevin wrote: From: Alex Williamson [mailto:alex.william...@redhat.com] Sent:

Re: [Qemu-devel] [PATCH v7 0/4] Add Mediated device support

2016-09-02 Thread Kirti Wankhede
On 9/2/2016 1:31 AM, Alex Williamson wrote: > On Thu, 1 Sep 2016 23:52:02 +0530 > Kirti Wankhede <kwankh...@nvidia.com> wrote: > >> Alex, >> Thanks for summarizing the discussion. >> >> On 8/31/2016 9:18 PM, Alex Williamson wrote: >>> On Wed,

Re: [Qemu-devel] [PATCH v7 0/4] Add Mediated device support

2016-09-01 Thread Kirti Wankhede
On 9/2/2016 10:18 AM, Michal Privoznik wrote: > On 01.09.2016 18:59, Alex Williamson wrote: >> On Thu, 1 Sep 2016 18:47:06 +0200 >> Michal Privoznik wrote: >> >>> On 31.08.2016 08:12, Tian, Kevin wrote: > From: Alex Williamson [mailto:alex.william...@redhat.com] >

Re: [Qemu-devel] [PATCH v7 0/4] Add Mediated device support

2016-09-07 Thread Kirti Wankhede
On 9/7/2016 2:58 AM, Alex Williamson wrote: > On Wed, 7 Sep 2016 01:05:11 +0530 > Kirti Wankhede <kwankh...@nvidia.com> wrote: > >> On 9/6/2016 11:10 PM, Alex Williamson wrote: >>> On Sat, 3 Sep 2016 22:04:56 +0530 >>> Kirti Wankhede <kwankh...@nvidia.c

Re: [Qemu-devel] [PATCH v7 1/4] vfio: Mediated device Core driver

2016-09-12 Thread Kirti Wankhede
On 9/12/2016 10:40 AM, Jike Song wrote: > On 09/10/2016 03:55 AM, Kirti Wankhede wrote: >> On 9/10/2016 12:12 AM, Alex Williamson wrote: >>> On Fri, 9 Sep 2016 23:18:45 +0530 >>> Kirti Wankhede <kwankh...@nvidia.com> wrote: >>> >>>> On 9/8/20

Re: [Qemu-devel] [PATCH v7 1/4] vfio: Mediated device Core driver

2016-09-09 Thread Kirti Wankhede
On 9/8/2016 1:39 PM, Jike Song wrote: > On 08/25/2016 11:53 AM, Kirti Wankhede wrote: >> +---+ >> | | >> | +---+ | mdev_register_driver() +--+ >> | | | +<

Re: [Qemu-devel] [PATCH v7 0/4] Add Mediated device support

2016-09-08 Thread Kirti Wankhede
On 9/8/2016 3:43 AM, Alex Williamson wrote: > On Wed, 7 Sep 2016 23:36:28 +0530 > Kirti Wankhede <kwankh...@nvidia.com> wrote: > >> On 9/7/2016 10:14 PM, Alex Williamson wrote: >>> On Wed, 7 Sep 2016 21:45:31 +0530 >>> Kirti Wankhede <kwankh...@nvidia.c

Re: [Qemu-devel] [PATCH v7 1/4] vfio: Mediated device Core driver

2016-09-09 Thread Kirti Wankhede
On 9/10/2016 12:12 AM, Alex Williamson wrote: > On Fri, 9 Sep 2016 23:18:45 +0530 > Kirti Wankhede <kwankh...@nvidia.com> wrote: > >> On 9/8/2016 1:39 PM, Jike Song wrote: >>> On 08/25/2016

Re: [Qemu-devel] [RFC v2] libvirt vGPU QEMU integration

2016-09-29 Thread Kirti Wankhede
7. Hot-plug It is same syntax to create a virtual device for hot-plug. >>> >>> How do groups work with hotplug? Can a device be creating into an >>> existing, running group? Can a device be removed from an existing, >>> running group?

Re: [Qemu-devel] [PATCH v7 3/4] vfio iommu: Add support for mediated devices

2016-09-29 Thread Kirti Wankhede
On 9/29/2016 7:47 AM, Jike Song wrote: > +Guangrong > > On 08/25/2016 11:53 AM, Kirti Wankhede wrote: ... >> +static long vfio_iommu_type1_pin_pages(void *iommu_data, >> + unsigned long *user_pfn, >> +

Re: [Qemu-devel] [RFC v2] libvirt vGPU QEMU integration

2016-09-29 Thread Kirti Wankhede
a...@redhat.com] >>>> Sent: Thursday, September 29, 2016 4:06 PM >>>> >>>> On Wed, Sep 28, 2016 at 12:48:33PM -0700, Neo Jia wrote: >>>>> On Tue, Sep 20, 2016 at 10:47:53AM +0100, Daniel P. Berrange wrote: >>>>>> On Tue, Sep 20, 2

Re: [Qemu-devel] [PATCH v7 3/4] vfio iommu: Add support for mediated devices

2016-09-30 Thread Kirti Wankhede
On 9/30/2016 8:40 AM, Jike Song wrote: > On 09/30/2016 10:58 AM, Jike Song wrote: >> On 09/29/2016 11:06 PM, Kirti Wankhede wrote: >>> >>> >>> On 9/29/2016 7:47 AM, Jike Song wrote: >>>> +Guangrong >>>> >>>> On 08/25

Re: [Qemu-devel] [RFC v2] libvirt vGPU QEMU integration

2016-10-06 Thread Kirti Wankhede
can have 'class' as optional attribute. So Intel don't have to >> provide 'class' attribute and they don't have to specify mandatory >> attributes of that class. We would provide 'class' attribute and provide >> mandatory attributes. > Thanks, Kirti On 10/3/2016 1:50 PM, Kirt

Re: [Qemu-devel] [RFC v2] libvirt vGPU QEMU integration

2016-09-20 Thread Kirti Wankhede
On 9/20/2016 8:13 PM, Alex Williamson wrote: > On Tue, 20 Sep 2016 19:51:58 +0530 > Kirti Wankhede <kwankh...@nvidia.com> wrote: > >> On 9/20/2016 3:06 AM, Alex Williamson wrote: >>> On Tue, 20 Sep 2016 02:05:52 +0530 >>> Kirti Wankhede <kwankh...

Re: [Qemu-devel] [RFC v2] libvirt vGPU QEMU integration

2016-09-20 Thread Kirti Wankhede
On 9/20/2016 10:06 PM, Daniel P. Berrange wrote: > On Tue, Sep 20, 2016 at 10:01:18PM +0530, Kirti Wankhede wrote: >> >> >> On 9/20/2016 8:44 PM, Daniel P. Berrange wrote: >>> On Tue, Sep 20, 2016 at 05:05:43PM +0200, Paolo Bonzini wrote: >>>> >>

Re: [Qemu-devel] [RFC v2] libvirt vGPU QEMU integration

2016-09-20 Thread Kirti Wankhede
On 9/20/2016 3:55 AM, Alex Williamson wrote: > On Mon, 19 Sep 2016 23:50:56 +0200 > Paolo Bonzini <pbonz...@redhat.com> wrote: > >> On 19/09/2016 23:36, Alex Williamson wrote: >>> On Tue, 20 Sep 2016 02:05:52 +0530 >>> Kirti Wankhede <kwan

Re: [Qemu-devel] [RFC v2] libvirt vGPU QEMU integration

2016-09-20 Thread Kirti Wankhede
On 9/20/2016 8:44 PM, Daniel P. Berrange wrote: > On Tue, Sep 20, 2016 at 05:05:43PM +0200, Paolo Bonzini wrote: >> >> >> On 20/09/2016 16:58, Daniel P. Berrange wrote: > As I've said in my earlier reply - libvirt will *NOT* support passing > arbitrary vendor specific parameters as a

Re: [Qemu-devel] [RFC v2] libvirt vGPU QEMU integration

2016-09-20 Thread Kirti Wankhede
On 9/20/2016 3:06 AM, Alex Williamson wrote: > On Tue, 20 Sep 2016 02:05:52 +0530 > Kirti Wankhede <kwankh...@nvidia.com> wrote: > >> Hi libvirt experts, >> >> Thanks for valuable input on v1 version of RFC. >> >> Quick brief, VFIO based mediated dev

Re: [Qemu-devel] [RFC v2] libvirt vGPU QEMU integration

2016-09-21 Thread Kirti Wankhede
On 9/20/2016 10:20 PM, Alex Williamson wrote: > On Tue, 20 Sep 2016 21:53:16 +0530 > Kirti Wankhede <kwankh...@nvidia.com> wrote: > >> On 9/20/2016 8:13 PM, Alex Williamson wrote: >>> On Tue, 20 Sep 2016 19:51:58 +0530 >>> Kirti Wankhede <kwankh...@nvi

Re: [Qemu-devel] [PATCH v7 1/4] vfio: Mediated device Core driver

2016-09-19 Thread Kirti Wankhede
On 9/12/2016 9:23 PM, Alex Williamson wrote: > On Mon, 12 Sep 2016 13:19:11 +0530 > Kirti Wankhede <kwankh...@nvidia.com> wrote: > >> On 9/12/2016 10:40 AM, Jike Song wrote: >>> On 09/10/2016 03:55 AM, Kirti Wankhede wrote: >>>> On 9/10/2016 12:12 AM

Re: [Qemu-devel] [PATCH v7 2/4] vfio: VFIO driver for mediated devices

2016-09-19 Thread Kirti Wankhede
On 9/20/2016 12:06 AM, Alex Williamson wrote: > On Mon, 19 Sep 2016 23:52:36 +0530 > Kirti Wankhede <kwankh...@nvidia.com> wrote: > >> On 8/26/2016 7:43 PM, Kirti Wankhede wrote: >>> * PGP Signed: 08/26/2016 at 07:15:44 AM, Decrypted >>> On 8/25/2016 2:5

Re: [Qemu-devel] [RFC v2] libvirt vGPU QEMU integration

2016-09-23 Thread Kirti Wankhede
On 9/23/2016 12:55 AM, Tian, Kevin wrote: >> From: Kirti Wankhede [mailto:kwankh...@nvidia.com] >> Sent: Wednesday, September 21, 2016 12:23 AM >>> >>>>> I have >>>>> a hard time believing that a given vendor can even allocate unique type >

Re: [Qemu-devel] [RFC v2] libvirt vGPU QEMU integration

2016-09-21 Thread Kirti Wankhede
> My concern is that a type id seems arbitrary but we're specifying that > it be unique. We already have something unique, the name. So why try > to make the type id unique as well? A vendor can accidentally create > their vendor driver so that a given name means something

Re: [Qemu-devel] [PATCH v7 2/4] vfio: VFIO driver for mediated devices

2016-09-19 Thread Kirti Wankhede
On 8/26/2016 7:43 PM, Kirti Wankhede wrote: > * PGP Signed: 08/26/2016 at 07:15:44 AM, Decrypted > On 8/25/2016 2:52 PM, Dong Jia wrote: >> On Thu, 25 Aug 2016 09:23:53 +0530 >>> + >>> +static ssize_t vfio_mdev_read(void *device_data, char __user *buf, >>>

Re: [Qemu-devel] [PATCH v7 1/4] vfio: Mediated device Core driver

2016-09-19 Thread Kirti Wankhede
On 9/19/2016 11:41 PM, Alex Williamson wrote: > On Mon, 19 Sep 2016 22:59:34 +0530 > Kirti Wankhede <kwankh...@nvidia.com> wrote: > >> On 9/12/2016 9:23 PM, Alex Williamson wrote: >>> On Mon, 12 Sep 2016 13:19:11 +0530 >>> Kirti Wankhede <kwankh...@nvid

[Qemu-devel] [RFC v2] libvirt vGPU QEMU integration

2016-09-19 Thread Kirti Wankhede
Hi libvirt experts, Thanks for valuable input on v1 version of RFC. Quick brief, VFIO based mediated device framework provides a way to virtualize their devices without SR-IOV, like NVIDIA vGPU, Intel KVMGT and IBM's channel IO. This framework reuses VFIO APIs for all the functionalities for

Re: [Qemu-devel] [PATCH v7 0/4] Add Mediated device support

2016-09-07 Thread Kirti Wankhede
On 9/7/2016 10:14 PM, Alex Williamson wrote: > On Wed, 7 Sep 2016 21:45:31 +0530 > Kirti Wankhede <kwankh...@nvidia.com> wrote: > >> On 9/7/2016 2:58 AM, Alex Williamson wrote: >>> On Wed, 7 Sep 2016 01:05:11 +0530 >>> Kirti Wankhede <kwankh...@nvidia

Re: [Qemu-devel] [PATCH v7 3/4] vfio iommu: Add support for mediated devices

2016-08-26 Thread Kirti Wankhede
Oh, that's the last minute change after running checkpatch.pl :( Thanks for catching that. I'll correct that. Thanks, Kirti On 8/25/2016 12:59 PM, Dong Jia wrote: > On Thu, 25 Aug 2016 09:23:54 +0530 > Kirti Wankhede <kwankh...@nvidia.com> wrote: > >> @@ -769,6 +

Re: [Qemu-devel] [PATCH v7 2/4] vfio: VFIO driver for mediated devices

2016-08-26 Thread Kirti Wankhede
On 8/25/2016 2:52 PM, Dong Jia wrote: > On Thu, 25 Aug 2016 09:23:53 +0530 > Kirti Wankhede <kwankh...@nvidia.com> wrote: > > [...] > > Dear Kirti, > > I just rebased my vfio-ccw patches to this series. > With a little fix, which was pointed it out in my reply

[Qemu-devel] [PATCH 1/1] Add simple sample driver for mediated device framework

2016-09-29 Thread Kirti Wankhede
Sample driver creates mdev device that simulates serial port over PCI card. Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> Signed-off-by: Neo Jia <c...@nvidia.com> Change-Id: I857f8f12f8b275f2498dfe8c628a5cdc7193b1b2 --- Documentation/mdev/Makefile

[Qemu-devel] [PATCH 0/1] Sample driver for mediated device framework

2016-09-29 Thread Kirti Wankhede
and how it is supposed to work. Kirti Wankhede (1): Add simple sample driver for mediated device framework Documentation/mdev/Makefile | 14 + Documentation/mdev/mtty.c | 1202 + Documentation/{ => mdev}/vfio-media

  1   2   3   4   5   6   7   8   9   >