On Thu, 2018-10-11 at 17:09 +0200, Gerd Hoffmann wrote:
> > > Ok. We probably should fix interface_client_monitors_config() to use
> > > the channel_id instead of qemu_console_get_head() then.
> >
> > It's not that simple. This would break the QXL with multiple monitors
> > per channel case.
>
ou can always send wrong data in a single function as well. I agree in
this regard a single function would be better but don't find it a big
issue. Note that the functions are called in different places in QEMU
too.
> >
> > Signed-off-by: Lukáš Hrázký
> > ---
> >
s(...)
> >
> > * The device display IDs (the IDs of the device's monitors that belong
> > to this QXL interface):
> > spice_qxl_monitor_set_device_display_id(...)
> >
> > Signed-off-by: Lukáš Hrázký
> > ---
> > hw/display/qxl.c | 8 +++
On Fri, 2018-10-12 at 11:27 +0200, Gerd Hoffmann wrote:
> On Thu, Oct 11, 2018 at 05:37:46PM +0200, Lukáš Hrázký wrote:
> > On Thu, 2018-10-11 at 17:09 +0200, Gerd Hoffmann wrote:
> > > > > Ok. We probably should fix interface_client_monitors_config() to use
> >
are present.
>
> Cc: spice-de...@lists.freedesktop.org
> Signed-off-by: Gerd Hoffmann
FWIW LGTM :)
With a small note below.
Reviewed-by: Lukáš Hrázký
> ---
> ui/spice-display.c | 26 ++
> 1 file changed, 22 insertions(+), 4 deletions(-)
>
> d
):
spice_qxl_monitor_set_device_display_id(...)
Signed-off-by: Lukáš Hrázký
---
hw/display/qxl.c | 8
ui/spice-core.c| 45 -
ui/spice-display.c | 5 +
3 files changed, 57 insertions(+), 1 deletion(-)
diff --git a/hw/display/qxl.c b/hw/display
device:
spice_qxl_monitor_set_device_display_id(...)
Signed-off-by: Lukáš Hrázký
---
server/red-qxl.c | 89
server/spice-qxl.h | 5 +++
server/spice-server.syms | 6 +++
3 files changed, 100 insertions(+)
diff --git a/server/red-qxl.c b
Hello,
sending version 2 of the RFC on the new QXL interface to identify the
graphics device monitors in the guest.
Still keeping it as RFC, I'd like to get this agreed upon but not merge
until the whole mechanism is implemented.
Gerd, I didn't split the QEMU patch, as I feel it kind of goes
Hello,
On Mon, 2018-10-22 at 13:46 +0200, Lukáš Hrázký wrote:
> Hello,
>
> On Thu, 2018-10-18 at 03:16 -0400, Frediano Ziglio wrote:
> > >
> > > Adds two functions to let QEMU provide information to identify graphics
> > > devices and their monitors in the
On Mon, 2018-11-05 at 07:52 +0100, Gerd Hoffmann wrote:
> > 2. Have a single function as follows:
> >
> > void spice_qxl_set_device_info(QXLInstance *instance,
> >const char *device_address,
> >uint32_t device_display_id_start,
> >
On Mon, 2018-11-05 at 03:46 -0500, Frediano Ziglio wrote:
> >
> > > 2. Have a single function as follows:
> > >
> > > void spice_qxl_set_device_info(QXLInstance *instance,
> > >const char *device_address,
> > >uint32_t
On Mon, 2018-11-05 at 14:08 +0100, Gerd Hoffmann wrote:
> On Mon, Nov 05, 2018 at 01:18:57PM +0100, Lukáš Hrázký wrote:
> > On Mon, 2018-11-05 at 07:52 +0100, Gerd Hoffmann wrote:
> > > > 2. Have a single function as follows:
> > > >
> > > > void sp
Hello,
On Thu, 2018-11-08 at 07:49 +0100, Gerd Hoffmann wrote:
> Hi,
>
> > + * The device_display_id_{start,count} denotes the sequence of device
> > display
> > + * IDs that map to the zero-based sequence of monitor IDs provided by
> > monitors
> > + * config on this interface. For example
Hello,
another version of the proposed API for monitor identification
information. Still not for merge yet, the plan is to merge when it's
complete.
Changes since v2:
* Merged the two API functions into one:
spice_qxl_set_device_info(QXLInstance *instance,
const
Replace it by spice_qxl_set_device_info. Note we can't use
monitors_count for what's stored in max_monitors, because monitors_count
denotes the length of the device_display_ids array, which
spice_qxl_set_max_monitors doesn't touch.
Signed-off-by: Lukáš Hrázký
---
server/red-qxl.c | 1
off-by: Lukáš Hrázký
---
server/red-qxl.c | 44 ++
server/spice-qxl.h | 46
server/spice-server.syms | 5 +
3 files changed, 95 insertions(+)
diff --git a/server/red-qxl.c b/server/red-qxl.c
index 97940
the deprecated spice_qxl_set_max_monitors, the new
interface function replaces it.
Signed-off-by: Lukáš Hrázký
---
hw/display/qxl.c | 14 -
include/ui/spice-display.h | 2 ++
ui/spice-core.c| 42 ++
ui/spice-display.c | 11
:
spice_qxl_device_monitor_add_display_id(...)
Signed-off-by: Lukáš Hrázký
---
server/red-qxl.c | 67
server/spice-qxl.h | 3 ++
server/spice-server.syms | 6
3 files changed, 76 insertions(+)
diff --git a/server/red-qxl.c b/server
):
spice_qxl_device_monitor_add_display_id(...)
Signed-off-by: Lukáš Hrázký
---
hw/display/qxl.c | 8
ui/spice-core.c| 45 -
ui/spice-display.c | 5 +
3 files changed, 57 insertions(+), 1 deletion(-)
diff --git a/hw/display/qxl.c b/hw/display/qxl.c
Hello,
this is a preliminary RFC on the new QXL interface to identify the
graphics device monitors in the guest. This interface adds two functions
that allow to set the device path (e.g. a PCI path) and the IDs of the
device's displays from QEMU to SPICE server. The server will forward
this
On Tue, 2018-10-09 at 14:33 -0500, Jonathon Jongsma wrote:
> On Tue, 2018-10-09 at 15:10 +0200, Lukáš Hrázký wrote:
> > Adds two functions to let QEMU provide information to identify
> > graphics
> > devices and their monitors in the guest:
> >
> > * device path
Hi Gerd,
On Wed, 2018-10-10 at 12:37 +0200, Gerd Hoffmann wrote:
> Hi,
>
> > > + * Sets the hardware (e.g. PCI) path of the graphics device
> > > represented by this QXL interface instance.
> >
> > So, this comment suggests that the caller might be able to provide a
> > path that is not a PCI
On Thu, 2018-10-11 at 14:27 +0200, Gerd Hoffmann wrote:
> > > So, if I remember correctly, Gerd recommended returning this value from
> > > the function. But I think it needs more explanation here. What exactly
> > > is a "monitor_id" supposed to represent? It is not used in your follow-
> > > up
On Thu, 2018-10-11 at 15:20 +0200, Gerd Hoffmann wrote:
> > The plan was (and still is) to limit the use cases to the following
> > two:
> >
> > * Legacy QXL on linux with multiple monitors per display channel, but
> > only this single display channel. Multiple display channels are not
> >
On Thu, 2018-10-11 at 15:43 +0200, Gerd Hoffmann wrote:
> Hi,
>
> > > How does all this monitors_config work currently in case multiple
> > > display channels are present?
> > >
> > > There is the QXLInterface->client_monitors_config() callback.
> > >
> > > There is the
off-by: Lukáš Hrázký
---
server/red-qxl.c | 44 ++
server/spice-qxl.h | 46
server/spice-server.syms | 5 +
3 files changed, 95 insertions(+)
diff --git a/server/red-qxl.c b/server/red-qxl.c
index 97940
On Wed, 2019-01-09 at 11:36 -0600, Jonathon Jongsma wrote:
> On Tue, 2019-01-08 at 16:26 +0100, Lukáš Hrázký wrote:
> > Adds a function to let QEMU provide information to identify graphics
> > devices and their monitors in the guest. The function
> > (spice_qxl_set_device_
Hello,
this is the final version of the new QXL interface to identify the
graphics device monitors in the guest. This interface adds a function
that allows to set the device path (e.g. a PCI path) and the IDs of the
device's displays from QEMU to SPICE server. The server will forward
this
the deprecated spice_qxl_set_max_monitors, the new
interface function replaces it.
Signed-off-by: Lukáš Hrázký
---
hw/display/qxl.c | 14 -
include/ui/spice-display.h | 2 ++
ui/spice-core.c| 42 ++
ui/spice-display.c | 11
Replace it by spice_qxl_set_device_info. Note we can't use
monitors_count for what's stored in max_monitors, because monitors_count
denotes the length of the device_display_ids array, which
spice_qxl_set_max_monitors doesn't touch.
Signed-off-by: Lukáš Hrázký
---
server/red-qxl.c | 1
the deprecated spice_qxl_set_max_monitors, the new
interface function replaces it.
Signed-off-by: Lukáš Hrázký
---
Hi,
Changes since v3:
* Fix comments according to patchew check script.
Cheers,
Lukas
hw/display/qxl.c | 14 ++-
include/ui/spice-display.h | 4
ui/spice-core.c
the deprecated spice_qxl_set_max_monitors, the new
interface function replaces it.
Signed-off-by: Lukáš Hrázký
---
Hi,
sorry about the noise, v4 still isn't passing the check. I didn't know
the check script is in the git tree. This one should pass.
Changes since v4:
* Really fix comments according
the deprecated spice_qxl_set_max_monitors, the new
interface function replaces it.
Signed-off-by: Lukáš Hrázký
---
Hi,
I've fixed the undefined reference by checking the parent_dev pointer
directly instead of through pci_bus_is_root(), that was the only
function needed that's not built with PCI_CONFIG=n
the deprecated spice_qxl_set_max_monitors, the new
interface function replaces it.
Signed-off-by: Lukáš Hrázký
---
Hello,
the spice part of the interface was merged to spice server, so this is
ready to merge now too.
The original series:
https://lists.freedesktop.org/archives/spice-devel/2019-January/046997
the deprecated spice_qxl_set_max_monitors, the new
interface function replaces it.
Signed-off-by: Lukáš Hrázký
---
Hello,
the spice part of the interface was merged to spice server, so this is
ready to merge now too.
The original series:
https://lists.freedesktop.org/archives/spice-devel/2019-January/046997
35 matches
Mail list logo
