[Qemu-devel] [ANNOUNCE] QEMU 4.0.0-rc2 is now available

2019-04-03 Thread Lukas Straub
Hello, The following Patch which fixes COLO is missing: https://lists.nongnu.org/archive/html/qemu-devel/2019-03/msg07909.html Regards, Lukas Straub

[Qemu-devel] [Bug 1824622] [NEW] Qemu 4.0.0-rc3 COLO Primary Crashes with "Assertion `event_unhandled_count > 0' failed."

2019-04-13 Thread Lukas Straub
e attached scripts to run Qemu, in my case both primary and secondary run on the same Host for testing purposes. See the files in the attached .tar.bz2 for more Info, they also contain a Coredump. Regards, Lukas Straub Configure CMDline: ./configure --target-list=x86_64-softmmu,i386-softmmu --en

[Qemu-devel] [Bug 1824622] Re: Qemu 4.0.0-rc3 COLO Primary Crashes with "Assertion `event_unhandled_count > 0' failed."

2019-04-13 Thread Lukas Straub
ange with 'd') reliably trigger the crash for me. I use the attached scripts to run Qemu, in my case both primary and secondary run on the same Host for testing purposes. See the files in the attached .tar.bz2 for more Info, they also contain a Coredump. Regards, Lukas Straub Configure

[Qemu-devel] [Bug 1824622] Re: Qemu 4.0.0-rc3 COLO Primary Crashes with "Assertion `event_unhandled_count > 0' failed."

2019-05-18 Thread Lukas Straub
h 0.1 second delay (change with 'd') reliably trigger the crash for me. I use the attached scripts to run Qemu, in my case both primary and secondary run on the same Host for testing purposes. See the files in the attached .tar.bz2 for more Info, they also contain a Coredump. Regards, Lukas S

[Qemu-devel] [PATCH v2] net/colo-compare.c: Fix a crash in COLO Primary.

2019-04-20 Thread Lukas Straub
From: Lukas Straub Because event_unhandled_count may be accessed concurrently, it needs to be protected by taking the lock. However the assert is outside the lock, probably causing it to read garbage and aborting Qemu erroneously. The Bug only happens when running Qemu in COLO mode. This Patch

[Qemu-devel] [PATCH] net/colo-compare.c: Fix a crash in COLO Primary.

2019-04-19 Thread Lukas Straub
From: Lukas Straub Fixes the following bug: https://bugs.launchpad.net/qemu/+bug/1824622 Signed-off-by: Lukas Straub --- net/colo-compare.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/colo-compare.c b/net/colo-compare.c index bf10526f05..fcb491121b 100644

Re: [Qemu-devel] [PATCH v2] net/colo-compare.c: Fix a crash in COLO Primary.

2019-05-06 Thread Lukas Straub
On Sat, 20 Apr 2019 19:14:25 +0200 Lukas Straub wrote: > From: Lukas Straub > Because event_unhandled_count may be accessed concurrently, it needs > to be protected by taking the lock. However the assert is outside the > lock, probably causing it to read garbage and aborting Qemu &

[Qemu-devel] [Bug 1824622] Re: Qemu 4.0.0-rc3 COLO Primary Crashes with "Assertion `event_unhandled_count > 0' failed."

2019-04-21 Thread Lukas Straub
a Coredump. Regards, Lukas Straub Configure CMDline: ./configure --target-list=x86_64-softmmu,i386-softmmu --enable-debug-info To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1824622/+subscriptions

[Qemu-devel] [PATCH 3/3] Document the qmp commands for continious replication

2019-08-14 Thread Lukas Straub
Signed-off-by: Lukas Straub --- docs/COLO-FT.txt | 185 +++ 1 file changed, 138 insertions(+), 47 deletions(-) diff --git a/docs/COLO-FT.txt b/docs/COLO-FT.txt index ad24680d13..c08bfbd3a8 100644 --- a/docs/COLO-FT.txt +++ b/docs/COLO-FT.txt

[Qemu-devel] [PATCH 0/3] colo: Add support for continious replication

2019-08-14 Thread Lukas Straub
Hello Everyone, These Patches add support for continious replication to colo. Please review. Regards, Lukas Straub Lukas Straub (3): Replication: Ignore requests after failover net/filter.c: Add Options to insert filters anywhere in the filter list Document the qmp commands for continious

[Qemu-devel] [PATCH 2/3] net/filter.c: Add Options to insert filters anywhere in the filter list

2019-08-14 Thread Lukas Straub
To switch the Secondary to Primary, we need to insert new filters before the filter-rewriter. Add the necessary options to insert filters anywhere in the filter list. Signed-off-by: Lukas Straub --- include/net/filter.h | 2 ++ net/filter.c | 73

[Qemu-devel] [PATCH 1/3] Replication: Ignore requests after failover

2019-08-14 Thread Lukas Straub
After failover, the Secondary side of replication shouldn't change state. Add the necessary checks to ignore requests after failover. Signed-off-by: Lukas Straub --- block/replication.c | 31 +++ 1 file changed, 27 insertions(+), 4 deletions(-) diff --git a/block

Re: [Qemu-devel] [PATCH v2 0/3] colo: Add support for continious replication

2019-08-16 Thread Lukas Straub
On Fri, 16 Aug 2019 01:51:20 + "Zhang, Chen" wrote: > > -Original Message- > > From: Lukas Straub [mailto:lukasstra...@web.de] > > Sent: Friday, August 16, 2019 3:48 AM > > To: Dr. David Alan Gilbert > > Cc: qemu-devel ; Zhang, Chen &g

[Qemu-devel] [PATCH v2 3/3] Update Documentation

2019-08-15 Thread Lukas Straub
Document the qemu command-line and qmp commands for continious replication Signed-off-by: Lukas Straub --- docs/COLO-FT.txt | 185 +++ 1 file changed, 138 insertions(+), 47 deletions(-) diff --git a/docs/COLO-FT.txt b/docs/COLO-FT.txt index

[Qemu-devel] [PATCH v2 0/3] colo: Add support for continious replication

2019-08-15 Thread Lukas Straub
Hello Everyone, These Patches add support for continious replication to colo. Please review. Regards, Lukas Straub v2: - fix email formating - fix checkpatch.pl warnings - fix patchew error - clearer commit messages Lukas Straub (3): Replication: Ignore requests after failover net

[Qemu-devel] [PATCH v2 1/3] Replication: Ignore requests after failover

2019-08-15 Thread Lukas Straub
) or BLOCK_REPLICATION_FAILOVER (failover in progres i.e. currently merging active and hidden images into the base image). Signed-off-by: Lukas Straub --- block/replication.c | 38 +++--- 1 file changed, 35 insertions(+), 3 deletions(-) diff --git a/block/replication.c b/block/replication.c

[Qemu-devel] [PATCH v2 2/3] net/filter.c: Add Options to insert filters anywhere in the filter list

2019-08-15 Thread Lukas Straub
ld be either "before" or "after" to specify where to insert the new filter relative to the one specified with position. Signed-off-by: Lukas Straub --- include/net/filter.h | 2 ++ net/filter.c | 71 +++- qemu-options.hx | 10

Re: [Qemu-devel] [PATCH v2 0/3] colo: Add support for continious replication

2019-08-15 Thread Lukas Straub
On Thu, 15 Aug 2019 19:57:37 +0100 "Dr. David Alan Gilbert" wrote: > * Lukas Straub (lukasstra...@web.de) wrote: > > Hello Everyone, > > These Patches add support for continious replication to colo. > > Please review. > > > OK, for those who haven'

[Qemu-devel] [PATCH v2 3/3] Update Documentation

2019-08-15 Thread Lukas Straub
Document the qemu command-line and qmp commands for continious replication Signed-off-by: Lukas Straub --- docs/COLO-FT.txt | 185 +++ 1 file changed, 138 insertions(+), 47 deletions(-) diff --git a/docs/COLO-FT.txt b/docs/COLO-FT.txt index

[Qemu-devel] [PATCH v2 2/3] net/filter.c: Add Options to insert filters anywhere in the filter list

2019-08-15 Thread Lukas Straub
ld be either "before" or "after" to specify where to insert the new filter relative to the one specified with position. Signed-off-by: Lukas Straub --- include/net/filter.h | 2 ++ net/filter.c | 71 +++- qemu-options.hx | 10

[Qemu-devel] [PATCH v2 1/3] Replication: Ignore requests after failover

2019-08-15 Thread Lukas Straub
) or BLOCK_REPLICATION_FAILOVER (failover in progres i.e. currently merging active and hidden images into the base image). Signed-off-by: Lukas Straub --- block/replication.c | 38 +++--- 1 file changed, 35 insertions(+), 3 deletions(-) diff --git a/block/replication.c b/block/replication.c

[Qemu-devel] [PATCH v2 0/3] colo: Add support for continious replication

2019-08-15 Thread Lukas Straub
Hello Everyone, These Patches add support for continious replication to colo. Please review. Regards, Lukas Straub v2: - fix email formating - fix checkpatch.pl warnings - fix patchew error - clearer commit messages Lukas Straub (3): Replication: Ignore requests after failover net

[Qemu-devel] [PATCH v3 3/4] net/filter.c: Add Options to insert filters anywhere in the filter list

2019-09-03 Thread Lukas Straub
ld be either "before" or "behind" to specify where to insert the new filter relative to the one specified with position. Signed-off-by: Lukas Straub --- include/net/filter.h | 2 ++ net/filter.c | 78 +++- qemu-options.hx | 1

[Qemu-devel] [PATCH v3 2/4] tests/test-replication.c: Add test for ignoring requests after failover

2019-09-03 Thread Lukas Straub
This simulates the case that happens when we resume COLO after failover. Signed-off-by: Lukas Straub --- tests/test-replication.c | 52 1 file changed, 52 insertions(+) diff --git a/tests/test-replication.c b/tests/test-replication.c index f085d1993a

[Qemu-devel] [PATCH v3 1/4] block/replication.c: Ignore requests after failover

2019-09-03 Thread Lukas Straub
) or BLOCK_REPLICATION_FAILOVER (failover in progres i.e. currently merging active and hidden images into the base image). Signed-off-by: Lukas Straub --- block/replication.c | 38 +++--- 1 file changed, 35 insertions(+), 3 deletions(-) diff --git a/block/replication.c b/block/replication.c

[Qemu-devel] [PATCH v3 0/4] colo: Add support for continious replication

2019-09-03 Thread Lukas Straub
which I will post when its ready. I have to say it's quite fun to randomly kill a Node, wait for resync and repeat and see how the VM stays alive all the time. :) Regards, Lukas Straub v3: - add test for replication changes - check if the filter to be inserted before/behind belongs to the same

[Qemu-devel] [PATCH v3 4/4] colo: Update Documentation for continious replication

2019-09-03 Thread Lukas Straub
Document the qemu command-line and qmp commands for continious replication Signed-off-by: Lukas Straub --- docs/COLO-FT.txt | 212 +++-- docs/block-replication.txt | 26 +++-- 2 files changed, 172 insertions(+), 66 deletions(-) diff --git a/docs/COLO

Re: [Qemu-devel] [PATCH v2 2/3] net/filter.c: Add Options to insert filters anywhere in the filter list

2019-09-02 Thread Lukas Straub
On Mon, 2 Sep 2019 11:43:57 + "Zhang, Chen" wrote: > > -Original Message- > > From: Lukas Straub > > Sent: Friday, August 23, 2019 2:21 PM > > To: Zhang, Chen > > Cc: qemu-devel ; Jason Wang > > ; Wen Congyang ; > > Xie Changlon

Re: [Qemu-devel] [PATCH v2 3/3] Update Documentation

2019-09-02 Thread Lukas Straub
. > > > > -Original Message- > > From: Lukas Straub > > Sent: Friday, August 16, 2019 2:49 AM > > To: qemu-devel > > Cc: Zhang, Chen ; Jason Wang > > ; Wen Congyang ; > > Xie Changlong > > Subject: [PATCH v2 3/3] Update Docume

Re: [Qemu-devel] [PATCH v2 2/3] net/filter.c: Add Options to insert filters anywhere in the filter list

2019-08-23 Thread Lukas Straub
On Fri, 23 Aug 2019 03:24:02 + "Zhang, Chen" wrote: > > -Original Message- > > From: Lukas Straub [mailto:lukasstra...@web.de] > > Sent: Friday, August 16, 2019 2:49 AM > > To: qemu-devel > > Cc: Zhang, Chen ; Jason Wang > > ; Wen Congya

[Qemu-devel] [PATCH v4 1/4] block/replication.c: Ignore requests after failover

2019-09-10 Thread Lukas Straub
) or BLOCK_REPLICATION_FAILOVER (failover in progres i.e. currently merging active and hidden images into the base image). Signed-off-by: Lukas Straub --- block/replication.c | 38 +++--- 1 file changed, 35 insertions(+), 3 deletions(-) diff --git a/block/replication.c b/block/replication.c

[Qemu-devel] [PATCH v4 0/4] colo: Add support for continious replication

2019-09-10 Thread Lukas Straub
which I will post when its ready. I have to say it's quite fun to randomly kill a Node, wait for resync and repeat and see how the VM stays alive all the time. :) Regards, Lukas Straub v4: - fix checkpatch.pl warnings v3: - add test for replication changes - check if the filter to be inserted

[Qemu-devel] [PATCH v4 3/4] net/filter.c: Add Options to insert filters anywhere in the filter list

2019-09-10 Thread Lukas Straub
ld be either "before" or "behind" to specify where to insert the new filter relative to the one specified with position. Signed-off-by: Lukas Straub --- include/net/filter.h | 2 ++ net/filter.c | 78 +++- qemu-options.hx | 1

[Qemu-devel] [PATCH v4 4/4] colo: Update Documentation for continious replication

2019-09-10 Thread Lukas Straub
Document the qemu command-line and qmp commands for continious replication Signed-off-by: Lukas Straub --- docs/COLO-FT.txt | 212 +++-- docs/block-replication.txt | 26 +++-- 2 files changed, 172 insertions(+), 66 deletions(-) diff --git a/docs/COLO

[Qemu-devel] [PATCH v4 2/4] tests/test-replication.c: Add test for ignoring requests after failover

2019-09-10 Thread Lukas Straub
This simulates the case that happens when we resume COLO after failover. Signed-off-by: Lukas Straub --- tests/test-replication.c | 52 1 file changed, 52 insertions(+) diff --git a/tests/test-replication.c b/tests/test-replication.c index f085d1993a

[Qemu-devel] [PATCH v5 0/4] colo: Add support for continuous replication

2019-09-15 Thread Lukas Straub
which I will post when its ready. I have to say it's quite fun to randomly kill a Node, wait for resync and repeat and see how the VM stays alive all the time. :) Regards, Lukas Straub v5: - change syntax for the position= parameter - fix spelling mistake v4: - fix checkpatch.pl warnings v3

[Qemu-devel] [PATCH v5 3/4] net/filter.c: Add Options to insert filters anywhere in the filter list

2019-09-15 Thread Lukas Straub
or it should be "id=" to specify the id of another filter. insert should be either "before" or "behind" to specify where to insert the new filter relative to the one specified with position. Signed-off-by: Lukas Straub --- incl

Re: [Qemu-devel] [PATCH v4 3/4] net/filter.c: Add Options to insert filters anywhere in the filter list

2019-09-15 Thread Lukas Straub
On Tue, 10 Sep 2019 20:12:45 + "Zhang, Chen" wrote: > > -Original Message- > > From: Lukas Straub > > Sent: Tuesday, September 10, 2019 6:15 PM > > To: qemu-devel > > Cc: Zhang, Chen ; Jason Wang > > ; Wen Congyang ; > > Xie

[Qemu-devel] [PATCH v5 4/4] colo: Update Documentation for continuous replication

2019-09-15 Thread Lukas Straub
Document the qemu command-line and qmp commands for continuous replication Signed-off-by: Lukas Straub --- docs/COLO-FT.txt | 212 +++-- docs/block-replication.txt | 28 +++-- 2 files changed, 173 insertions(+), 67 deletions(-) diff --git a/docs/COLO

[Qemu-devel] [PATCH v5 1/4] block/replication.c: Ignore requests after failover

2019-09-15 Thread Lukas Straub
) or BLOCK_REPLICATION_FAILOVER (failover in progres i.e. currently merging active and hidden images into the base image). Signed-off-by: Lukas Straub --- block/replication.c | 38 +++--- 1 file changed, 35 insertions(+), 3 deletions(-) diff --git a/block/replication.c b/block/replication.c

[Qemu-devel] [PATCH v5 2/4] tests/test-replication.c: Add test for ignoring requests after failover

2019-09-15 Thread Lukas Straub
This simulates the case that happens when we resume COLO after failover. Signed-off-by: Lukas Straub --- tests/test-replication.c | 52 1 file changed, 52 insertions(+) diff --git a/tests/test-replication.c b/tests/test-replication.c index f085d1993a