Re: [Qemu-devel] [PATCH 01/25] QMP: Rename query handlers

2010-12-07 Thread Miguel Di Ciurcio Filho
On Mon, Dec 6, 2010 at 4:23 PM, Luiz Capitulino lcapitul...@redhat.com wrote: Query handlers still carry their human monitor name. This commit renames all of them to a more QMP-like name. For example, do_info_version() is renamed to qmp_query_version(). - * do_info_balloon(): Balloon

Re: [Qemu-devel] git rm Changelog?

2011-01-25 Thread Miguel Di Ciurcio Filho
On Tue, Jan 25, 2011 at 12:35 PM, Anthony Liguori anth...@codemonkey.ws wrote: A wiki page (similar to what kernel newbies does) would be nice to supplement what's included in the release notes. There you go: http://wiki.qemu.org/Changelog/0.14 This is a first draft and I will try to keep

Re: [Qemu-devel] [ANNOUNCE] QEMU 0.14.0.tar.gz is available

2011-02-18 Thread Miguel Di Ciurcio Filho
On Thu, Feb 17, 2011 at 10:06 PM, Anthony Liguori anth...@codemonkey.ws wrote: The QEMU team is pleased to announce the availability of the 0.14.0 release. Download instructions are available at http://wiki.qemu.org/Download A detailed change log is available at

[Qemu-devel] [PATCH] monitor: make 'info snapshots' show only fully available snapshots

2010-07-27 Thread Miguel Di Ciurcio Filho
1.5M 2010-07-26 17:26:49 00:00:13.245 41.5M 2010-07-26 19:01:00 00:00:46.763 Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- savevm.c | 65 ++--- 1 files changed, 45 insertions(+), 20

Re: [Qemu-devel] [PATCH] monitor: make 'info snapshots' show only fully available snapshots

2010-07-28 Thread Miguel Di Ciurcio Filho
On Wed, Jul 28, 2010 at 12:38 PM, Markus Armbruster arm...@redhat.com wrote: Miguel Di Ciurcio Filho miguel.fi...@gmail.com writes: The output generated by 'info snapshots' shows only snapshots that exist on the block device that saves the VM state. This output can cause an user

[Qemu-devel] [PATCH 1/3] cleanup: bdrv_snaphost_find() returns zero or -ENOENT

2010-07-28 Thread Miguel Di Ciurcio Filho
The bdrv_snaphost_find() returns zero in case it finds an snapshot or -ENOENT in case it doesn't. Checking returning values as = zero doesn't make sense. Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- savevm.c |7 --- 1 files changed, 4 insertions(+), 3 deletions

[Qemu-devel] [PATCH 2/3] cleanup: del_existing_snapshots() must return the upstream error code

2010-07-28 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- savevm.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/savevm.c b/savevm.c index 6c6adb0..fb38e8a 100644 --- a/savevm.c +++ b/savevm.c @@ -1775,7 +1775,7 @@ static int del_existing_snapshots(Monitor *mon

[Qemu-devel] [PATCH 3/3] savevm: prevent snapshot overwriting and generate a default name

2010-07-28 Thread Miguel Di Ciurcio Filho
when using Windows. Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- qemu-monitor.hx |9 --- savevm.c| 59 -- 2 files changed, 40 insertions(+), 28 deletions(-) diff --git a/qemu-monitor.hx b/qemu-monitor.hx

[Qemu-devel] Re: [PATCH 3/3] savevm: prevent snapshot overwriting and generate a default name

2010-07-30 Thread Miguel Di Ciurcio Filho
On Fri, Jul 30, 2010 at 10:39 AM, Luiz Capitulino lcapitul...@redhat.com wrote: TODO: I have no clue on how to create a timestamp string when using Windows. So, what happens on windows? I've found some code in bdrv_snapshot_dump() that formats a timestamp when using Windows. I will use it as

Re: [Qemu-devel] [PATCH 2/3] cleanup: del_existing_snapshots() must return the upstream error code

2010-07-30 Thread Miguel Di Ciurcio Filho
On Fri, Jul 30, 2010 at 6:45 AM, Markus Armbruster arm...@redhat.com wrote: Why? I figure the next patch wants it, but if that's the reason, the commit message should state it. To better identify what happened and where, IMHO.

[Qemu-devel] Re: KVM call agenda for August 3

2010-08-02 Thread Miguel Di Ciurcio Filho
On Mon, Aug 2, 2010 at 8:46 PM, Juan Quintela quint...@redhat.com wrote: Please send in any agenda items you are interested in covering. I would like to briefly RFC about some snapshot issues that I have being dealing, for the conversion of savevm/loadvm to QMP. They are listed here:

[Qemu-devel] [RFC] qcow2: Add snapshot inherantance and uuid identification

2010-08-03 Thread Miguel Di Ciurcio Filho
and lvdisplay. One very simple, the other one show full information. * Better distinguish ids and names I would like to suggest split functions like bdrv_snapshot_find() to something more strict, like bdrv_snapshot_find_by_id() and bdrv_snapshot_find_by_name() Signed-off-by: Miguel Di Ciurcio Filho miguel.fi

Re: [Qemu-devel] [RFC] qcow2: Add snapshot inherantance and uuid identification

2010-08-04 Thread Miguel Di Ciurcio Filho
On Tue, Aug 3, 2010 at 5:55 PM, Blue Swirl blauwir...@gmail.com wrote: +    if (strlen(current_snapshot_id) 0) { +        pstrcpy(sn-parent_id_str, sizeof(sn-parent_id_str), current_snapshot_id); +    } else { +        pstrcpy(sn-parent_id_str, sizeof(sn-parent_id_str),

[Qemu-devel] [PATCH 3/3] savevm: prevent snapshot overwriting

2010-08-04 Thread Miguel Di Ciurcio Filho
without one Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- qemu-monitor.hx |7 --- savevm.c| 19 ++- 2 files changed, 18 insertions(+), 8 deletions(-) diff --git a/qemu-monitor.hx b/qemu-monitor.hx index 2af3de6..683ac73 100644 --- a/qemu-monitor.hx

[Qemu-devel] [PATCH 1/3] monitor: make 'info snapshots' show only fully available snapshots

2010-08-04 Thread Miguel Di Ciurcio Filho
1.5M 2010-07-26 17:26:49 00:00:13.245 41.5M 2010-07-26 19:01:00 00:00:46.763 Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- savevm.c | 59 +++ 1 files changed, 43 insertions(+), 16

[Qemu-devel] [PATCH 0/3] snapshots: various updates

2010-08-04 Thread Miguel Di Ciurcio Filho
of variables Regards, Miguel Miguel Di Ciurcio Filho (3): monitor: make 'info snapshots' show only fully available snapshots savevm: Generate a name when run without one savevm: prevent snapshot overwriting qemu-monitor.hx |7 ++-- savevm.c| 97

[Qemu-devel] [PATCH 2/3] savevm: Generate a name when run without one

2010-08-04 Thread Miguel Di Ciurcio Filho
this kind of internals to the user. Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- savevm.c | 29 - 1 files changed, 20 insertions(+), 9 deletions(-) diff --git a/savevm.c b/savevm.c index 9291cfb..025bee6 100644 --- a/savevm.c +++ b/savevm.c @@ -1799,8

[Qemu-devel] [PATCH 0/2] QMP: update 'query-version'

2010-08-09 Thread Miguel Di Ciurcio Filho
the entire string. Regards, Miguel --- Miguel Di Ciurcio Filho (2): QMP: update 'query-version' documentation QMP/monitor: update do_info_version() to output broken down version string monitor.c | 23 +++ qemu-monitor.hx | 16 ++-- 2 files changed, 33

[Qemu-devel] [PATCH 1/2] QMP: update 'query-version' documentation

2010-08-09 Thread Miguel Di Ciurcio Filho
Update the documentation of 'query-version' to output the string version broken down. Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- qemu-monitor.hx | 16 ++-- 1 files changed, 14 insertions(+), 2 deletions(-) diff --git a/qemu-monitor.hx b/qemu-monitor.hx index

[Qemu-devel] [PATCH 2/2] QMP/monitor: update do_info_version() to output broken down version string

2010-08-09 Thread Miguel Di Ciurcio Filho
This code was originally developed by Daniel P. Berrange berra...@redhat.com Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- monitor.c | 23 +++ 1 files changed, 19 insertions(+), 4 deletions(-) diff --git a/monitor.c b/monitor.c index c313d5a..e82c48f

Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments

2010-08-13 Thread Miguel Di Ciurcio Filho
On Thu, Aug 12, 2010 at 3:56 PM, malc av1...@comtv.ru wrote: While intentions of this are good, i believe this goes too far, i doubt that the proposed additions are enforcable and have no doubts that they will be widely ignored and at the same time provide more grounds for whining.

[Qemu-devel] Re: [RFC] qcow2: Add snapshot inherantance and uuid identification

2010-08-17 Thread Miguel Di Ciurcio Filho
On Tue, Aug 3, 2010 at 2:19 PM, Miguel Di Ciurcio Filho miguel.fi...@gmail.com wrote: As discussed on today's call, here is a prototype to support snapshots inherantance in qcow2 and to use uuid as identification mechanism. Bump. Just a friendly reminder of this RFC, now that everybody is back

Re: [Qemu-devel] [RFC] qed: Add QEMU Enhanced Disk format

2010-09-10 Thread Miguel Di Ciurcio Filho
On Fri, Sep 10, 2010 at 2:10 PM, Anthony Liguori anth...@codemonkey.ws wrote: Well, snapshots have an ID today (which is different from their name). Nobody stops you from putting a UUID there. Fully backwards compatible, no feature flag needed. I think Miguel was planning to actually do this.

Re: [Qemu-devel] Stable patch tracking

2010-09-13 Thread Miguel Di Ciurcio Filho
On Sun, Sep 12, 2010 at 11:02 AM, Avi Kivity a...@redhat.com wrote:  On 09/12/2010 03:42 PM, Avi Kivity wrote:  On 09/12/2010 03:04 PM, Anthony Liguori wrote: Can the captcha for logged in users be removed? Can you be more specific about what you're seeing? There should only be a captcha

[Qemu-devel] Bug in net/socket.c: info_str is overwritten

2010-05-06 Thread Miguel Di Ciurcio Filho
Hi there, I'm working on the conversion of the 'info network' command do QMP, and I think I've found some problems. Running qemu like this: qemu -net socket,listen=: In net/socket.c, the function net_socket_listen_init() [1] is called and a listening socket is created. There is nothing

Re: [Qemu-devel] [RFC] New Monitor command: 'info netdevices'

2010-05-14 Thread Miguel Di Ciurcio Filho
On Fri, May 14, 2010 at 6:46 AM, Markus Armbruster arm...@redhat.com wrote: There's also 3. Convert it anyway.  Clean up the mess.  Change the output. I agree. It seams to me that no one is concerned with any Monitor output change with this particular command. Plus, no one have shown any

[Qemu-devel] [PATCH] net: Remove dead code from net/socket.c

2010-05-14 Thread Miguel Di Ciurcio Filho
is dead. Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- net/socket.c |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/net/socket.c b/net/socket.c index 1c4e153..b72a2de 100644 --- a/net/socket.c +++ b/net/socket.c @@ -267,11 +267,6 @@ static

[Qemu-devel] Re: [PATCH] net: Remove dead code from net/socket.c

2010-05-14 Thread Miguel Di Ciurcio Filho
On Fri, May 14, 2010 at 2:03 PM, Jan Kiszka jan.kis...@siemens.com wrote: In both cases the info_str string is written inside net_socket_fd_init_(stream|dgram), and after that, it is overwritten on a subsequent snprintf() in net_socket_accept(). There is non-zero time window between

[Qemu-devel] [PATCH v4 10/10] monitor/net: introduce 'info netdevices' with QMP support

2010-05-18 Thread Miguel Di Ciurcio Filho
} }, { name:e1000.0, vlan:0, info:{ model:e1000, macaddr:52:54:00:12:34:56 } } ] } Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- monitor.c |8 ++ net.c | 79

[Qemu-devel] [PATCH v4 09/10] net: socket: introduce info_dict

2010-05-18 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- net/socket.c | 22 ++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --git a/net/socket.c b/net/socket.c index 1c4e153..5be1b54 100644 --- a/net/socket.c +++ b/net/socket.c @@ -28,6 +28,7 @@ #include

[Qemu-devel] [PATCH v4 08/10] net: slirp: introduce info_dict

2010-05-18 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- net/slirp.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/net/slirp.c b/net/slirp.c index b41c60a..a6e25ff 100644 --- a/net/slirp.c +++ b/net/slirp.c @@ -32,6 +32,9 @@ #include monitor.h

[Qemu-devel] [PATCH v4 06/10] net: vde: introduce info_dict

2010-05-18 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- net/vde.c | 11 ++- 1 files changed, 10 insertions(+), 1 deletions(-) diff --git a/net/vde.c b/net/vde.c index 0b46fa6..6a3d0ba 100644 --- a/net/vde.c +++ b/net/vde.c @@ -31,6 +31,9 @@ #include qemu-char.h #include

[Qemu-devel] [PATCH v4 04/10] net: xen: introduce info_dict

2010-05-18 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- hw/xen_nic.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/hw/xen_nic.c b/hw/xen_nic.c index 08055b8..1820059 100644 --- a/hw/xen_nic.c +++ b/hw/xen_nic.c @@ -321,6 +321,11 @@ static int net_init

[Qemu-devel] [PATCH v4 05/10] net: tap/tap-win32: introduce info_dict

2010-05-18 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- net/tap-win32.c |9 - net/tap.c | 18 +- 2 files changed, 25 insertions(+), 2 deletions(-) diff --git a/net/tap-win32.c b/net/tap-win32.c index 74348da..54c6725 100644 --- a/net/tap-win32.c

[Qemu-devel] [PATCH v4 02/10] net: introduce qemu_nic_format_info_dict and VLANClientState-info_dict

2010-05-18 Thread Miguel Di Ciurcio Filho
There is no standard format when formatting VLANClientState.info_str, so it is difficult to extract information and transmit it over QMP. This patch adds info_dict, a QDict to better handle the information of a NIC. Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- net.c | 17

[Qemu-devel] [PATCH v4 07/10] net: dump: introduce info_dict

2010-05-18 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- net/dump.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/net/dump.c b/net/dump.c index 6db7ecf..32514ad 100644 --- a/net/dump.c +++ b/net/dump.c @@ -26,6 +26,9 @@ #include qemu-common.h

[Qemu-devel] [PATCH v4 03/10] net: various devices: add qemu_format_nic_info_dict

2010-05-18 Thread Miguel Di Ciurcio Filho
These are simple one line additions of qemu_format_nic_info_dict. Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- hw/dp8393x.c|1 + hw/e1000.c |1 + hw/eepro100.c |2 ++ hw/lan9118.c|2 ++ hw/mcf_fec.c|1 + hw/mipsnet.c

[Qemu-devel] [PATCH v4 01/10] QObject API: introduce qdict_to_qstring() function

2010-05-18 Thread Miguel Di Ciurcio Filho
This is a helper function that converts a QDict to a QString, using the format: key1=value1 SEP key2=value2 SEP key3=value3 Handy for debugging and formating the Monitor output. Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- qdict.c | 55

[Qemu-devel] [PATCH v4 0/10] Introduce 'info netdevices' with QMP support

2010-05-18 Thread Miguel Di Ciurcio Filho
The VLANClientState structure has the member info_str, a simple string that is filled with information about NIC devices and used on monitor calls. There is no coherent formatting of this string by all the NIC devices, making it difficult to parse and represent this information over QMP. To make

Re: [Qemu-devel] [RFC] Bug Day - June 1st, 2010

2010-05-19 Thread Miguel Di Ciurcio Filho
On Wed, May 19, 2010 at 2:04 AM, Aurelien Jarno aurel...@aurel32.net wrote: The idea is nice, but would it be possible to hold this on a week-end, I personally won't be able to attend such thing on a day week. Or maybe holding that on two days: friday and saturday so that people can

[Qemu-devel] [PATCH] savevm: Really verify if a drive supports snapshots

2010-05-28 Thread Miguel Di Ciurcio Filho
option. The loadvm_state() function was updated too to enforce that when loading a VM at least all writable devices must support snapshots too. Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- block.c | 47 ++- block.h |2

[Qemu-devel] Re: [PATCH] savevm: Really verify if a drive supports snapshots

2010-05-29 Thread Miguel Di Ciurcio Filho
On Sat, May 29, 2010 at 3:06 AM, Markus Armbruster arm...@redhat.com wrote: I seem to remember that we came to the conclusion that bdrv_has_snapshot() isn't needed at all and should be dropped. Any user should be using bdrv_can_snapshot() instead as this is what they really want. Our

[Qemu-devel] [PATCH v2] savevm: Really verify if a drive supports snapshots

2010-05-29 Thread Miguel Di Ciurcio Filho
a VM at least all writable devices must support snapshots too. Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- block.c | 21 - block.h |1 + monitor.c |5 - savevm.c | 58 -- 4 files

Re: [Qemu-devel] [PATCH v2] savevm: Really verify if a drive supports snapshots

2010-05-31 Thread Miguel Di Ciurcio Filho
On Mon, May 31, 2010 at 6:59 AM, Kevin Wolf kw...@redhat.com wrote:  int bdrv_snapshot_create(BlockDriverState *bs,                           QEMUSnapshotInfo *sn_info)  {      BlockDriver *drv = bs-drv; -    if (!drv) -        return -ENOMEDIUM; -    if (!drv-bdrv_snapshot_create) -      

[Qemu-devel] [PATCH v3] savevm: Really verify if a drive supports snapshots

2010-06-03 Thread Miguel Di Ciurcio Filho
a VM at least all writable devices must support snapshots too. Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- block.c | 11 +++ block.h |1 + savevm.c | 58 -- 3 files changed, 48 insertions(+), 22

[Qemu-devel] [RFC] QMP: Introduce query-netdevices documentation

2010-06-04 Thread Miguel Di Ciurcio Filho
This introduces the protocol specification for querying information about network devices available on a VM and a new monitor command that show the same information. Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- qemu-monitor.hx | 69

[Qemu-devel] Re: [PATCH v3] savevm: Really verify if a drive supports snapshots

2010-06-04 Thread Miguel Di Ciurcio Filho
On Fri, Jun 4, 2010 at 2:28 PM, Kevin Wolf kw...@redhat.com wrote: @@ -1674,12 +1659,26 @@ void do_savevm(Monitor *mon, const QDict *qdict)  #endif      const char *name = qdict_get_try_str(qdict, name); +    /* Verify if there is a device that doesn't support snapshots and is writable */

[Qemu-devel] [PATCH v4] savevm: Really verify if a drive supports snapshots

2010-06-04 Thread Miguel Di Ciurcio Filho
a VM at least all writable devices must support snapshots too. Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- block.c | 11 +++ block.h |1 + savevm.c | 58 -- 3 files changed, 48 insertions(+), 22

[Qemu-devel] Re: [RFC] QMP: Introduce query-netdevices documentation

2010-06-07 Thread Miguel Di Ciurcio Filho
On Sun, Jun 6, 2010 at 12:50 PM, Avi Kivity a...@redhat.com wrote: +Each json-object contain the following: + +- device: device name (json-string) +- vlan: only present if the device is attached to a VLAN (json-int) +- info: json-object containing the following: +          - model: type of

[Qemu-devel] Re: [RFC] QMP: Introduce query-netdevices documentation

2010-06-07 Thread Miguel Di Ciurcio Filho
On Mon, Jun 7, 2010 at 10:48 AM, Anthony Liguori anth...@codemonkey.ws wrote: $ qemu -netdev tap,id=tap0 -device e1000,netdev=tap0 This makes a 1:1 relation. So clearly tap0 is a host device, e1000.0 will be a guest device, and they are connected. Yes.  I'd want separate queries for each,

Re: [Qemu-devel] [PATCH 16/19] Add a query-netdev command to QMP

2010-06-07 Thread Miguel Di Ciurcio Filho
On Mon, Jun 7, 2010 at 11:42 AM, Daniel P. Berrange berra...@redhat.com wrote: This adds a new QMP command called query-netdev to provide information about the available netdev backends in the QEMU binary. There is no existing '-netdev ?' support, but if there was, this would obsolete it Hi

[Qemu-devel] Re: [RFC] QMP: Introduce query-netdevices documentation

2010-06-07 Thread Miguel Di Ciurcio Filho
On Mon, Jun 7, 2010 at 11:48 AM, Anthony Liguori anth...@codemonkey.ws wrote: How about this small draft: Possible values for type: tap, user, vde and socket. The 'info' object contains all the parameters available via -netdev type,args. Notice: vlan is still there, unless the support for

Re: [Qemu-devel] Re: [RFC] QMP: Introduce query-netdevices documentation

2010-06-07 Thread Miguel Di Ciurcio Filho
On Mon, Jun 7, 2010 at 12:01 PM, Markus Armbruster arm...@redhat.com wrote:          {             device: user.0,             type: user,             info: {                net: 10.0.2.0,                netmask: 255.255.255.0             },          }, And this one's not connected to a

[Qemu-devel] [RFC] QMP: new query-snapshots command

2010-06-08 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- qemu-monitor.hx | 61 +++ 1 files changed, 61 insertions(+), 0 deletions(-) diff --git a/qemu-monitor.hx b/qemu-monitor.hx index f6a94f2..27bd3d7 100644 --- a/qemu-monitor.hx +++ b

[Qemu-devel] [PATCH v5] savevm: Really verify if a drive supports snapshots

2010-06-08 Thread Miguel Di Ciurcio Filho
a VM at least all writable devices must support snapshots too. Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- block.c | 17 + block.h |1 + savevm.c | 58 -- 3 files changed, 54 insertions(+), 22

[Qemu-devel] [PATCH 5/8] net: vde: introduce info_dict

2010-06-10 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- net/vde.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/net/vde.c b/net/vde.c index 0b46fa6..0fe7c09 100644 --- a/net/vde.c +++ b/net/vde.c @@ -31,6 +31,9 @@ #include qemu-char.h #include qemu

[Qemu-devel] [PATCH 7/8] net: slirp: introduce info_dict

2010-06-10 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- net/slirp.c | 17 - 1 files changed, 16 insertions(+), 1 deletions(-) diff --git a/net/slirp.c b/net/slirp.c index b41c60a..5735009 100644 --- a/net/slirp.c +++ b/net/slirp.c @@ -32,6 +32,10 @@ #include

[Qemu-devel] [PATCH 4/8] net: tap/tap-win32: introduce info_dict

2010-06-10 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- net/tap-win32.c |6 ++ net/tap.c | 20 2 files changed, 26 insertions(+), 0 deletions(-) diff --git a/net/tap-win32.c b/net/tap-win32.c index 74348da..3833592 100644 --- a/net/tap-win32.c +++ b

[Qemu-devel] [PATCH 1/8] QObject API: introduce qdict_to_qstring() function

2010-06-10 Thread Miguel Di Ciurcio Filho
This is a helper function that converts a QDict to a QString, using the format: key1=value1 SEP key2=value2 SEP key3=value3 Handy for debugging and formating the Monitor output. Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- qdict.c | 60

[Qemu-devel] [PATCH 6/8] net: socket: introduce info_dict

2010-06-10 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- net/socket.c | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/net/socket.c b/net/socket.c index 1c4e153..aad9eb8 100644 --- a/net/socket.c +++ b/net/socket.c @@ -28,6 +28,7 @@ #include

[Qemu-devel] [PATCH 8/8] monitor/net: introduce 'info netdev' with QMP support

2010-06-10 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- monitor.c |8 + net.c | 96 + net.h |2 + 3 files changed, 106 insertions(+), 0 deletions(-) diff --git a/monitor.c b/monitor.c index 15b53b9

[Qemu-devel] [PATCH 3/8] net: Introduce VLANClientState-info_dict

2010-06-10 Thread Miguel Di Ciurcio Filho
There is no standard format when formatting VLANClientState.info_str, so it is difficult to extract information and transmit it over QMP. This patch adds info_dict, a QDict to better handle this information. Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- net.h |1 + 1

[Qemu-devel] [PATCH 2/8] QMP: Introduce the documentation for query-netdev and info netdev

2010-06-10 Thread Miguel Di Ciurcio Filho
These commands show the information about active backend network devices. Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- qemu-monitor.hx | 53 + 1 files changed, 53 insertions(+), 0 deletions(-) diff --git a/qemu

[Qemu-devel] [PATCH 0/8] QMP: Introduce query-netdev

2010-06-10 Thread Miguel Di Ciurcio Filho
This series introduces the protocol specification for querying the backend network devices and a monitor command to show the same information. Patch 01 adds a new function qdict_to_qstring(). Patch 02 adds the documentation for query-netdev. Patch 03 adds a new QDict member to VLANClientState

Re: [Qemu-devel] [PATCH 2/8] QMP: Introduce the documentation for query-netdev and info netdev

2010-06-11 Thread Miguel Di Ciurcio Filho
On Fri, Jun 11, 2010 at 8:37 AM, Markus Armbruster arm...@redhat.com wrote: +- id: the device's ID, must be unique (json-string) +- vlan: QEMU's internal vlan identification. Only present if the device is +  attached to a VLAN (json-int, optional) +- peer: ID of the frontend device when on a

Re: [Qemu-devel] Re: [CFR 9/10] device_del command

2010-06-15 Thread Miguel Di Ciurcio Filho
On Tue, Jun 15, 2010 at 1:59 PM, Jan Kiszka jan.kis...@siemens.com wrote: Anthony Liguori wrote: device_del -- Remove a device. Arguments: - id: the device's ID (json-string) id should become device (I hope to send the corresponding patches this night). The idea is to not only

[Qemu-devel] [PATCH] monitor: Really show snapshot information about all devices

2010-06-15 Thread Miguel Di Ciurcio Filho
0 2010-05-26 21:51:09 00:00:08.844 3 0 2010-05-26 21:51:24 00:00:23.274 4 0 2010-05-26 21:53:17 00:00:03.595 Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- savevm.c | 46

[Qemu-devel] Re: [PATCH] monitor: Really show snapshot information about all devices

2010-06-16 Thread Miguel Di Ciurcio Filho
On Wed, Jun 16, 2010 at 9:40 AM, Kevin Wolf kw...@redhat.com wrote: If the human monitor was exactly what its name says, I'd happily apply this one (though I think it should be made clear from which image the VM state would be loaded). However, it isn't and I'm not sure if this wouldn't break

[Qemu-devel] Re: [PATCH 2/8] QMP: Introduce the documentation for query-netdev and info netdev

2010-06-16 Thread Miguel Di Ciurcio Filho
On Wed, Jun 16, 2010 at 2:39 PM, Luiz Capitulino lcapitul...@redhat.com wrote: +SQMP +query-netdev + + +Each device is represented by a json-object. The returned value is a json-array +of all devices. + +Each json-object contain the following: + +- id: the device's ID,

Re: [Qemu-devel] Re: [PATCH] monitor: Really show snapshot information about all devices

2010-06-16 Thread Miguel Di Ciurcio Filho
On Wed, Jun 16, 2010 at 12:22 PM, Chris Lalancette clala...@redhat.com wrote: I didn't mention in the commit, but I've looked at libvirt's source and it is not using 'info snapshots' AFAIK. Anthony, Dan, are you okay with the change then? Right, exactly as Miguel said, libvirt doesn't use

[Qemu-devel] [PATCH v2] monitor: Really show snapshot information about all devices

2010-06-17 Thread Miguel Di Ciurcio Filho
state. Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- savevm.c | 57 - 1 files changed, 32 insertions(+), 25 deletions(-) diff --git a/savevm.c b/savevm.c index 20354a8..5bc5fcd 100644 --- a/savevm.c +++ b/savevm.c

[Qemu-devel] [PATCH v2] QMP: Introduce the documentation for query-netdev and info netdev

2010-06-18 Thread Miguel Di Ciurcio Filho
These commands show the information about active backend network devices. Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- qemu-monitor.hx | 105 +++ 1 files changed, 105 insertions(+), 0 deletions(-) diff --git a/qemu

Re: [Qemu-devel] [PATCH v2] QMP: Introduce the documentation for query-netdev and info netdev

2010-06-18 Thread Miguel Di Ciurcio Filho
On Fri, Jun 18, 2010 at 5:28 PM, Anthony Liguori anth...@codemonkey.ws wrote: On 06/18/2010 11:26 AM, Miguel Di Ciurcio Filho wrote: These commands show the information about active backend network devices. Signed-off-by: Miguel Di Ciurcio Filhomiguel.fi...@gmail.com ---  qemu-monitor.hx

[Qemu-devel] Re: [PATCH v2] QMP: Introduce the documentation for query-netdev and info netdev

2010-06-21 Thread Miguel Di Ciurcio Filho
On Mon, Jun 21, 2010 at 11:42 AM, Luiz Capitulino lcapitul...@redhat.com wrote: +- info: json-object containing the configuration information about the device. +        - When type is tap, the following values might be available: +            - fd: available if connected to an already opened

[Qemu-devel] [PATCH v3] QMP: Introduce the documentation for query-netdev and info netdev

2010-06-21 Thread Miguel Di Ciurcio Filho
type is 'tap' - Reworded the explanation of 'peer' Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- qemu-monitor.hx | 96 +++ 1 files changed, 96 insertions(+), 0 deletions(-) diff --git a/qemu-monitor.hx b/qemu-monitor.hx

[Qemu-devel] Re: [PATCH v3] QMP: Introduce the documentation for query-netdev and info netdev

2010-06-22 Thread Miguel Di Ciurcio Filho
On Tue, Jun 22, 2010 at 10:06 AM, Luiz Capitulino lcapitul...@redhat.com wrote: On Mon, 21 Jun 2010 17:31:28 -0300 Miguel Di Ciurcio Filho miguel.fi...@gmail.com wrote: These commands show the information about active backend network devices. Changes from v2 --- - Got rid

[Qemu-devel] [PATCH 0/7] QMP: Introduce query-netdev

2010-06-23 Thread Miguel Di Ciurcio Filho
This series implement the previously discussed QMP command query-netdev. There is small change in the specification from the last version: when type is tap, the attribute sndbuf have been removed. sndbuf is not available on all platforms and most of the tap_set_sndbuf() implementations are stubs.

[Qemu-devel] [PATCH 1/7] QMP: Introduce the documentation for query-netdev and info netdev

2010-06-23 Thread Miguel Di Ciurcio Filho
These commands show the information about active backend network devices. Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- qemu-monitor.hx | 100 +++ 1 files changed, 100 insertions(+), 0 deletions(-) diff --git a/qemu

[Qemu-devel] [PATCH 2/7] QObject API: introduce qdict_to_qstring() function

2010-06-23 Thread Miguel Di Ciurcio Filho
This is a helper function that converts a QDict to a QString, using the format: key1=value1 SEP key2=value2 SEP key3=value3 Handy for debugging and formating the Monitor output. Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- qdict.c | 60

[Qemu-devel] [PATCH 3/7] net: Introduce VLANClientState-info_dict

2010-06-23 Thread Miguel Di Ciurcio Filho
There is no standard format when formatting VLANClientState.info_str, so it is difficult to extract information and transmit it over QMP. This patch adds info_dict, a QDict to better handle this information. Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- net.c |1 + net.h

[Qemu-devel] [PATCH 7/7] monitor/net: introduce 'info netdev' with QMP support

2010-06-23 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- monitor.c |8 +++ net.c | 70 + net.h |2 + 3 files changed, 80 insertions(+), 0 deletions(-) diff --git a/monitor.c b/monitor.c index 170b269

[Qemu-devel] [PATCH 4/7] net: tap/tap-win32: introduce info_dict

2010-06-23 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- net/tap-win32.c |7 +++ net/tap.c | 22 +- 2 files changed, 28 insertions(+), 1 deletions(-) diff --git a/net/tap-win32.c b/net/tap-win32.c index 74348da..5e58702 100644 --- a/net/tap-win32.c

[Qemu-devel] [PATCH 5/7] net: vde: introduce info_dict

2010-06-23 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- net/vde.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/net/vde.c b/net/vde.c index 0b46fa6..a8a5b03 100644 --- a/net/vde.c +++ b/net/vde.c @@ -31,6 +31,9 @@ #include qemu-char.h #include

[Qemu-devel] [PATCH 6/7] net: slirp: introduce info_dict

2010-06-23 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- net/slirp.c | 42 +++--- 1 files changed, 39 insertions(+), 3 deletions(-) diff --git a/net/slirp.c b/net/slirp.c index b41c60a..9549711 100644 --- a/net/slirp.c +++ b/net/slirp.c @@ -32,6

[Qemu-devel] [PATCH v2 0/7] QMP: Introduce query-netdev

2010-06-30 Thread Miguel Di Ciurcio Filho
This series implement the previously discussed QMP command query-netdev. Regards, changelog from v1 - - Fixed wrong usage of qemu_free() with vc-info_dict, now using QDECREF() - Fixed QString leak in netdev_iter() changelog from last protocol spec

[Qemu-devel] [PATCH v2 2/7] QObject API: introduce qdict_to_qstring() function

2010-06-30 Thread Miguel Di Ciurcio Filho
This is a helper function that converts a QDict to a QString, using the format: key1=value1 SEP key2=value2 SEP key3=value3 Handy for debugging and formating the Monitor output. Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- qdict.c | 60

[Qemu-devel] [PATCH v2 1/7] QMP: Introduce the documentation for query-netdev and info netdev

2010-06-30 Thread Miguel Di Ciurcio Filho
These commands show the information about active backend network devices. Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- qemu-monitor.hx | 100 +++ 1 files changed, 100 insertions(+), 0 deletions(-) diff --git a/qemu

[Qemu-devel] [PATCH v2 3/7] net: Introduce VLANClientState-info_dict

2010-06-30 Thread Miguel Di Ciurcio Filho
There is no standard format when formatting VLANClientState.info_str, so it is difficult to extract information and transmit it over QMP. This patch adds info_dict, a QDict to better handle this information. Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- net.c |1 + net.h

[Qemu-devel] [PATCH v2 4/7] net: tap/tap-win32: introduce info_dict

2010-06-30 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- net/tap-win32.c |7 +++ net/tap.c | 22 +- 2 files changed, 28 insertions(+), 1 deletions(-) diff --git a/net/tap-win32.c b/net/tap-win32.c index 74348da..5e58702 100644 --- a/net/tap-win32.c

[Qemu-devel] [PATCH v2 7/7] monitor/net: introduce 'info netdev' with QMP support

2010-06-30 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- monitor.c |8 +++ net.c | 71 + net.h |2 + 3 files changed, 81 insertions(+), 0 deletions(-) diff --git a/monitor.c b/monitor.c index 170b269

[Qemu-devel] [PATCH v2 5/7] net: vde: introduce info_dict

2010-06-30 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- net/vde.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/net/vde.c b/net/vde.c index 0b46fa6..a8a5b03 100644 --- a/net/vde.c +++ b/net/vde.c @@ -31,6 +31,9 @@ #include qemu-char.h #include

[Qemu-devel] [PATCH v2 6/7] net: slirp: introduce info_dict

2010-06-30 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- net/slirp.c | 42 +++--- 1 files changed, 39 insertions(+), 3 deletions(-) diff --git a/net/slirp.c b/net/slirp.c index b41c60a..9549711 100644 --- a/net/slirp.c +++ b/net/slirp.c @@ -32,6

[Qemu-devel] [PATCH 1/2] QMP: Introduce the documentation for query-qdm

2010-07-02 Thread Miguel Di Ciurcio Filho
--- qemu-monitor.hx | 68 +++ 1 files changed, 68 insertions(+), 0 deletions(-) diff --git a/qemu-monitor.hx b/qemu-monitor.hx index 9f62b94..5348899 100644 --- a/qemu-monitor.hx +++ b/qemu-monitor.hx @@ -2490,6 +2490,74 @@ STEXI show device

[Qemu-devel] [PATCH 0/2] QMP: Introduce query-qdm

2010-07-02 Thread Miguel Di Ciurcio Filho
This series introduces the documentation for the query-qdm command and the conversion of the monitor command 'info qdm' to QMP. The documentation and code are based on a patch previously sent to qemu-devel by Daniel P. Berrange: http://lists.gnu.org/archive/html/qemu-devel/2010-06/msg00931.html

[Qemu-devel] [PATCH 2/2] monitor: Convert 'info qdm' to QMP

2010-07-02 Thread Miguel Di Ciurcio Filho
Converts the 'info qdm' command to QMP, allowing the discovery of all devices known to the QEMU binary without relying on command line paramaters like -device ? and -device devtype,? This change does not modify the output of the 'info qdm' monitor command. Signed-off-by: Miguel Di Ciurcio Filho

[Qemu-devel] Re: [PATCH 1/2] QMP: Introduce the documentation for query-qdm

2010-07-05 Thread Miguel Di Ciurcio Filho
On Sun, Jul 4, 2010 at 2:14 AM, Avi Kivity a...@redhat.com wrote:  show device tree �...@item info qdm  show qdev device model list +ETEXI +SQMP +query-qdm +- + +Describe the capabilities of all devices registered with qdev. Why the name qdm? 'query-available-devices'

[Qemu-devel] Re: [PATCH 1/2] QMP: Introduce the documentation for query-qdm

2010-07-05 Thread Miguel Di Ciurcio Filho
On Mon, Jul 5, 2010 at 12:22 PM, Luiz Capitulino lcapitul...@redhat.com wrote: + +Describe the capabilities of all devices registered with qdev. + +The returned output is a list, each element is a json-object describing a single +device type. s/The returned output is a list/The returned

[Qemu-devel] [PATCH v2] QMP: Introduce the documentation for query-qdm

2010-07-09 Thread Miguel Di Ciurcio Filho
Changelog from v1 - - renamed props to properties - updated the examples - reworded the explanations of name and description - split type into a json-object, adding qmp and qdev - list all possible values for bus - list all possible values for qdev on type - list all possible

[Qemu-devel] QMP argument parser does not verify json type

2010-07-09 Thread Miguel Di Ciurcio Filho
Hi there, I've run QEMU like this: $ qemu -qmp tcp:localhost:3000,server,nowait -netdev type=tap,id=ndev1,vhost=on Then I run these commands over QMP: works: {execute: device_add, arguments: {driver: virtio-net-pci, csum: off, id: nic1, netdev: ndev1}} works: {execute: device_add, arguments:

[Qemu-devel] [PATCH 0/8] vlan cleanup

2010-07-12 Thread Miguel Di Ciurcio Filho
names. Regards, Miguel --- Miguel Di Ciurcio Filho (8): vlan cleanup: update documentation vlan cleanup: update options vlan cleanup: do not depend on socket and dump vlan cleanup: do not build socket and dump vlan cleanup: remove socket.h and socket.c vlan

  1   2   >