From: Peter Crosthwaite peter.crosthwa...@xilinx.com
This message was printing out the data in decimal only, which is not
very friendly to the debugging developer. Add hex variant in
parenthesis to make it consistent with other similar messages in this
module.
Signed-off-by: Peter Crosthwaite
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
The end of transfer check was occurring and potentially returning before
the interrupt flag was checked. This means the interrupt will be missed
if it occurs on the last packet. Fix by checking for the interrupt
before checking for the end
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
object_dynamic_cast_assert used to be tolerant of NULL objects and not
assert. It's clear from the implementation that this is the expected
behavior.
The preceding check of the cast cache dereferences obj however causing
a segfault. Fix
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
Currently QEMU provides a local clone of the file libfdt_env.h in
/include. This file is supposed to come with the libfdt package and is
only needed for broken installs of libfdt. Unfortunately, libfdt 1.3
stable is tagged with this bug so we
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
This unbreaks cross compile builds:
configure --target-list=i386-softmmu --cpu=i386
When building on a 64bit machine.
Reported-by: David Holsgrove david.holsgr...@xilinx.com
Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com
Hi Igor,
On Wed, May 22, 2013 at 11:37 PM, Igor Mitsyanko i.mitsya...@gmail.com wrote:
On 05/21/2013 10:50 AM, peter.crosthwa...@xilinx.com wrote:
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
the SD command ACMD41 can be used in a read only mode to query device
state without doing
Hi Igor,
On Thu, May 23, 2013 at 8:31 PM, Igor Mitsyanko i.mitsya...@gmail.com wrote:
On 05/23/2013 03:42 AM, Peter Crosthwaite wrote:
Hi Igor,
On Wed, May 22, 2013 at 11:37 PM, Igor Mitsyanko i.mitsya...@gmail.com
wrote:
On 05/21/2013 10:50 AM, peter.crosthwa...@xilinx.com wrote:
From
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
Fixes found in SD and SDHCI found doing some corner case testing.
Changed from v1:
Corrected ACMD41 patch.
Moved ACMD41 patch to back of series.
Peter Crosthwaite (5):
sd/sdhci.c: Only reset data_count on new commands
sd/sdhci: Fix
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
The data_count variable was being reset on every transfer, including
DMA transfer resumptions. This is incorrect, it should only be set
on a new command.
Manifests as a bug when using ADMA and there is a timer delay between
ADMA frames where
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
This interrupt is not risen after the last block is written to sd. It
is mutually exclusive with the end of transfer conditions. Fix.
Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com
Reviewed-by: Igor Mitsyanko i.mitsya
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
This message was printing out the data in decimal only, which is not
very friendly to the debugging developer. Add hex variant in
parenthesis to make it consistent with other similar messages in this
module.
Signed-off-by: Peter Crosthwaite
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
The end of transfer check was occurring and potentially returning before
the interrupt flag was checked. This means the interrupt will be missed
if it occurs on the last packet. Fix by checking for the interrupt
before checking for the end
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
QEMU models two (of the three) ACMD41 has two modes, inquiry and
first. The selection logic for which of the two is incorrect - it
compares != 0 for the entire argument value rather than only bits 23:0
as per the spec. Fix.
Signed-off
or use in
slave mode?)
Signed-off-by: Jean-Christophe DUBOIS j...@tribudubois.net
Reviewed-by: Peter Crosthwaite peter.crosthwa...@xilinx.com
---
Changes since v1:
* use QOM cast
* run checkpatch on code
* added restrictin on MemoryRegionOps
* use DeviceClass::realise as init
is also modified as buffers are
slightly different between coldfire and i.MX.
Signed-off-by: Jean-Christophe DUBOIS j...@tribudubois.net
Reviewed-by: Peter Crosthwaite peter.crosthwa...@xilinx.com
---
Changes since V1:
* none
Changes since v2:
* use QOM cast
* reworked
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
Hi All. This is a new scheme i've come up with handling device registers in a
data driven way. My motivation for this is to factor out a lot of the access
checking that seems to be replicated in every device. See P2 commit message for
further
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
Little macro that just gives you N ones (justified to LSB).
Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com
---
include/qemu/bitops.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/qemu/bitops.h b/include/qemu
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
This API provides some encapsulation of registers and factors our some
common functionality to common code. Bits of device state (usually MMIO
registers), often have all sorts of access restrictions and semantics
associated with them. This API
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
Add memory io handlers that glue the register API to the memory API.
Just translation functions at this stage. Although it does allow for
devices to be created without all-in-one mmio r/w handlers.
Signed-off-by: Peter Crosthwaite
From: Peter A. G. Crosthwaite peter.crosthwa...@petalogix.com
Minimal device model for devcfg module of Zynq. DMA capabilities and
interrupt generation supported.
Signed-off-by: Peter A. G. Crosthwaite peter.crosthwa...@petalogix.com
---
Changed since v2:
Some QOM styling updates.
Re-implemented
From: Peter A. G. Crosthwaite peter.crosthwa...@petalogix.com
Signed-off-by: Peter A. G. Crosthwaite peter.crosthwa...@petalogix.com
---
Changed since v1:
Added manual parenting of devcfg node (evil but needed for early access
to canonical path by devcfgs realize fn).
hw/arm/xilinx_zynq.c | 8
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
The ich6 and ich9 variants either need to inherit one from the other,
or both from a common base class, otherwise its not possible to create
a QOM cast macro for use by the shared implementation functions.
Went for option B, with a common base
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
Define and use standard QOM cast macro. Remove usages of DO_UPCAST and
direct - style casting.
Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com
---
hw/audio/intel-hda.c | 19 +++
1 file changed, 11 insertions
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
QEMU models two (of the three) ACMD41 has two modes, inquiry and
first. The selection logic for which of the two is incorrect - it
compares != 0 for the entire argument value rather than only bits 23:0
as per the spec. Fix.
Signed-off
Hi Peter,
On Wed, May 22, 2013 at 6:26 PM, Peter Maydell peter.mayd...@linaro.org wrote:
On 22 May 2013 08:47, Edgar E. Iglesias edgar.igles...@gmail.com wrote:
On Wed, May 22, 2013 at 11:50:22AM +1000, peter.crosthwa...@xilinx.com wrote:
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
Currently QEMU provides a local clone of the file libfdt_env.h in
/include. This file is supposed to come with the libfdt package and is
only needed for broken installs of libfdt. Now that we have submodule
dtc, just ignore these broken
Hi All,
I have a bit of a chicken and egg problem trying to refactor Jans AT24
I2C EEPROM model. I'm trying to migrate static class properties up to
the class level rather than down on the device property level (as we
did for EHCI in the sysbusification a while back). Problem is the
device model
Hi Andreas, Jan,
On Mon, May 27, 2013 at 11:40 PM, Andreas Färber afaer...@suse.de wrote:
Hi,
Am 27.05.2013 09:50, schrieb Peter Crosthwaite:
I have a bit of a chicken and egg problem trying to refactor Jans AT24
I2C EEPROM model. I'm trying to migrate static class properties up
these, rather than building unhelpful half-functional binaries.
Signed-off-by: Peter Maydell peter.mayd...@linaro.org
Reviewed-by: Peter Crosthwaite peter.crosthwa...@xilinx.com
---
configure | 20
1 file changed, 20 insertions(+)
diff --git a/configure b/configure
index
On Sat, May 25, 2013 at 1:26 AM, Peter Maydell peter.mayd...@linaro.org wrote:
Now that we know we're compiling with libfdt, we can remove the
CONFIG_FDT conditionals.
Signed-off-by: Peter Maydell peter.mayd...@linaro.org
Reviewed-by: Peter Crosthwaite peter.crosthwa...@xilinx.com
---
hw
On Sat, May 25, 2013 at 1:26 AM, Peter Maydell peter.mayd...@linaro.org wrote:
Now that we know we're compiling with libfdt we can remove the
CONFIG_FDT conditionals.
Signed-off-by: Peter Maydell peter.mayd...@linaro.org
Reviewed-by: Peter Crosthwaite peter.crosthwa...@xilinx.com
---
hw
Hi Paolo,
On Wed, May 29, 2013 at 6:51 PM, Paolo Bonzini pbonz...@redhat.com wrote:
Il 24/05/2013 07:49, peter.crosthwa...@xilinx.com ha scritto:
+static const MemoryRegionOps devcfg_reg_ops = {
+.read = register_read_memory_le,
+.write = register_write_memory_le,
+.endianness =
Hi Anthony,
On Thu, May 30, 2013 at 3:57 AM, Anthony Liguori anth...@codemonkey.ws wrote:
peter.crosthwa...@xilinx.com writes:
From: Peter A. G. Crosthwaite peter.crosthwa...@petalogix.com
Minimal device model for devcfg module of Zynq. DMA capabilities and
interrupt generation supported.
On Thu, May 30, 2013 at 3:08 AM, Paolo Bonzini pbonz...@redhat.com wrote:
Il 29/05/2013 19:04, Edgar E. Iglesias ha scritto:
+for (i = 0; i R_MAX; ++i) {
+RegisterInfo *r = s-regs_info[i];
+
+*r = (RegisterInfo) {
+.data = s-regs[i],
+
...@xilinx.com
wrote:
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
Currently QEMU provides a local clone of the file libfdt_env.h in
/include. This file is supposed to come with the libfdt package and is
So, this patch might be the right thing anyway, but the statement
above is entirely
Hi,
On Fri, May 31, 2013 at 7:54 PM, Paolo Bonzini pbonz...@redhat.com wrote:
Il 31/05/2013 11:44, Peter Maydell ha scritto:
On 31 May 2013 09:25, Paolo Bonzini pbonz...@redhat.com wrote:
Please don't. Fedora is not going to use the bundled dtc because of a
policy against bundling, and
Hi Anthony,
On Fri, May 31, 2013 at 5:41 AM, Anthony Liguori anth...@codemonkey.ws wrote:
Peter Crosthwaite peter.crosthwa...@xilinx.com writes:
[snip]
}
That's still possible using just the register API (Patch 2 content
only) and throwing away the memory API glue. I think its actually
Hi Peter,
On Sun, Jun 2, 2013 at 6:09 AM, Peter Cheung mcheun...@hotmail.com wrote:
i start my qemu by this
~/qemu/bin/qemu-system-x86_64 -hda hd10meg.img -gdb tcp::1234 -k en-us -S -m
256m
it was working before, but not for the latest code.
When was before and are you able to git bisect
Hi All,
On Sat, Jun 1, 2013 at 6:26 PM, Peter Maydell peter.mayd...@linaro.org wrote:
On 1 June 2013 06:22, David Gibson da...@gibson.dropbear.id.au wrote:
On Fri, May 31, 2013 at 10:25:55AM +0200, Paolo Bonzini wrote:
Fedora's dtc package doesn't include
libfdt_env.h.
Yeah, that makes
HI David,
On Sat, Jun 1, 2013 at 3:38 PM, David Gibson
da...@gibson.dropbear.id.au wrote:
On Fri, May 31, 2013 at 10:44:33AM +0100, Peter Maydell wrote:
On 31 May 2013 09:25, Paolo Bonzini pbonz...@redhat.com wrote:
Please don't. Fedora is not going to use the bundled dtc because of a
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
Some cosmetics, refactored to use util/fifo8 for the FIFO8, then
factored out some common code.
Tested as working on petalogix-ml605 machine model + Linux (has
coverage of serial fifo usage).
Peter Crosthwaite (3):
char/serial: cosmetic
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
Some cosmetic fixes to char/serial fixing some checkpatch errors.
Cc: qemu-triv...@nongnu.org
Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com
---
Needed for the next patch to pass checkpatch. Done as sep patch to not
obscure
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
Use the generic Fifo8 helper provided by QEMU, rather than re-implement
privately.
Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com
---
hw/char/serial.c | 98 +---
include/hw
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
These three lines are common to both FIFO and regular mode. Just factor
them out to outside the if rather than replicate the same lines inside
both if and else.
Cc: qemu-triv...@nongnu.org
Signed-off-by: Peter Crosthwaite peter.crosthwa
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
Some trivial fixes to memory API.
Peter Crosthwaite (3):
memory: Fix comment typo
memory: as_update_topology_pass: Improve comments
memory: render_memory_region: factor out fr constant setters
memory.c | 19 ---
1 file
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
s/ajacent/adjacent
Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com
---
memory.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/memory.c b/memory.c
index 5cb8f4a..60e033b 100644
--- a/memory.c
+++ b/memory.c
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
These comments we're a little difficult to read. First one had
incorrect parenthesis. The part about attributes changing is
really applicable to the region being 'in both' rather than 'in
new'
Second comment has an obscure parenthetic about
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
These 4 replicated lines set properties of fr that are constant over
the course of the function. Factor out their repeated setting (and also
guards against them being set multiple times in the loop below).
Signed-off-by: Peter Crosthwaite
Hi Peter and Peter :)
On Sun, Jun 2, 2013 at 7:27 PM, Peter Maydell peter.mayd...@linaro.org wrote:
On 2 June 2013 06:46, Peter Cheung mcheun...@hotmail.com wrote:
I just tried to compile the latest qemu on Fedora 18 64 bits,
it is also fail. When i press c in gdb, the qemu won't start
Hi Peter,
On Tue, Jun 4, 2013 at 1:21 AM, Peter Maydell peter.mayd...@linaro.org wrote:
On 8 May 2013 09:28, Jean-Christophe DUBOIS j...@tribudubois.net wrote:
This is using a ds1338 RTC chip on the i2c bus. This RTC
chip is not present on the real board.
Ideally this should work by the test
Hi Ed,
On Wed, May 29, 2013 at 11:58 PM, Ed Maste ema...@freebsd.org wrote:
Based on the datasheet at
http://www.micron.com/~/media/Documents/Products/Data%20Sheet/NOR%20Flash/Serial%20NOR/N25Q/n25q_32mb_1_8v_65nm.pdf
Signed-off-by: Ed Maste ema...@freebsd.org
---
hw/block/m25p80.c | 1 +
);
type_register_static(intel_hda_info_ich9);
type_register_static(hda_codec_device_type_info);
On Fri, May 24, 2013 at 4:23 PM, peter.crosthwa...@xilinx.com wrote:
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
The ich6 and ich9 variants either need to inherit one from the other,
or both from
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
The ich6 and ich9 variants either need to inherit one from the other,
or both from a common base class, otherwise its not possible to create
a QOM cast macro for use by the shared implementation functions.
Went for option B, with a common base
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
Define and use standard QOM cast macro. Remove usages of DO_UPCAST and
direct - style casting.
Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com
---
hw/audio/intel-hda.c | 19 +++
1 file changed, 11 insertions
Hi All,
Im running:
qemu-system-x86_64 -drive file=./qemu-pc/debian,if=scsi,bus=0 -m 2048
-soundhw hda
Drive is Aureliens debian squeeze desktop image:
http://people.debian.org/~aurel32/qemu/amd64/
QEMU configured as:
../qemu/configure --target-list=x86_64-softmmu --enable-kvm
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
Use qemu_set_irq rather than if-elsing qemu_irq_(lower|raise). No
functional change, just reduces verbosity.
Cc: qemu-triv...@nongnu.org
Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com
---
hw/intc/xilinx_intc.c | 6 +-
1
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
Various fixups to the Xilinx Interrupt controller following a review
against TRM and RTL descriptions.
Tested as working for microblazeel Linux.
Peter Crosthwaite (5):
intc/xilinx_intc: Use qemu_set_irq
intc/xilinx_intc: Don't clear
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
For level sensitive interrupts, ISR bits are cleared when the input pin
is lowered. This is incorrect. Only software can clear ISR bits (via
IAR or direct write to ISR with !MER(2)).
Signed-off-by: Peter Crosthwaite peter.crosthwa
email accidentally sent with cc supression, so cc qemu-trivial as intended.
On Fri, Jun 7, 2013 at 12:38 PM, peter.crosthwa...@xilinx.com wrote:
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
Use qemu_set_irq rather than if-elsing qemu_irq_(lower|raise). No
functional change, just
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
Acking a level sensitive interrupt should have no effect if the
interrupt pin is still asserted. The current implementation requires
and edge condition to occur for setting a level sensitive IRQ, which
means an ACK can clear a level sensitive
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
When the Hardware Interrupt Enable (HIE) bit is set, software cannot
change ISR. Add write guard accordingly.
Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com
---
hw/intc/xilinx_intc.c | 5 +
1 file changed, 5 insertions
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
This is a little strange. It is lowering the parent IRQ pin on input
when HIE is cleared. There is no such behaviour in the real hardware.
ISR changes based on interrupt pin state are already guarded on HIE
being set. So we can just delete
Ping!
We are stuck in limbo here and I would like to get either V1 or V2
(this patch) of this through.
Paolo,
If you are not happy with this patch, does V1 address your concerns
(which was its original intention).
Regards,
Peter
On Sun, Jun 2, 2013 at 9:13 AM, Peter Crosthwaite
peter.crosthwa
and NULL assignment accordingly.
[PC: Reworked commit message]
Signed-off-by: Wendy Liang jli...@xilinx.com
Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com
---
hw/dma/xilinx_axidma.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/dma/xilinx_axidma.c b/hw/dma
with entries for 64Mb parts.
Prodded by Peter Crosthwaite.
Signed-off-by: Ed Maste ema...@freebsd.org
---
hw/block/m25p80.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
index a927a6b..8c3b7f0 100644
--- a/hw/block
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
commit 1db8b5efe0c2b5000e50691eea61264a615f43de introduced an issue
where QEMU would segfault if you have an unattached Cadence UART.
Fix by guarding the flush-on-reset logic on there being a qemu_chr
attachment.
Reported-by: Soren Brinkmann
Hi Sebastian,
I'd like to get this merged with the fix I suggested. Are you able to
remake or ok if I ammend and resend your patch?
Regards,
Peter
On Tue, May 14, 2013 at 9:49 AM, Peter Crosthwaite
peter.crosthwa...@xilinx.com wrote:
Hi Sebastian,
Thanks for your contribution,
On Wed, May
Hi,
On Jun 7, 2013 11:04 AM, Paolo Bonzini pbonz...@redhat.com wrote:
Il 05/06/2013 05:50, Andreas Färber ha scritto:
Am 04.06.2013 20:51, schrieb Paolo Bonzini:
This series changes all PCI devices (the sole to support hotplug
_and_ use MemoryRegions) to do memory_region_del_subregion at
Hi Jeff,
On Sat, Jun 1, 2013 at 2:39 AM, Jeff Cody jc...@redhat.com wrote:
This is a git script that will iterate through every commit in a
specified range, and perform a configure and make. The intention of
this script is not to act as a check of code correctness, but to see if
any commit
Hi Andreas,
On Sat, Jun 8, 2013 at 4:18 AM, Andreas Färber afaer...@suse.de wrote:
VirtioDevice's DeviceClass::exit code cleaning up bus_name is no longer
overwritten by virtio-{blk,serial,net,scsi,balloon,rng} and vhost-scsi.
Note: VirtIOSCSI and VHostSCSI now perform some initializations
Hi Andreas,
On Sat, Jun 8, 2013 at 7:55 PM, Andreas Färber afaer...@suse.de wrote:
Hi,
Am 08.06.2013 04:22, schrieb Peter Crosthwaite:
On Sat, Jun 8, 2013 at 4:18 AM, Andreas Färber afaer...@suse.de wrote:
diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c
index dc6f4e4
Hi,
On Mon, Jun 10, 2013 at 3:27 PM, Gerd Hoffmann kra...@redhat.com wrote:
Hi,
Maybe instead (or in addition to), we should provide a dummy
read or write functions -- instead of fixing each such occurence
to use its own dummy function
Makes sense, especially for write where we can just
Hi,
On Sat, Jun 8, 2013 at 6:30 AM, Jeff Cody jc...@redhat.com wrote:
On Fri, Jun 07, 2013 at 11:51:36AM -0500, Anthony Liguori wrote:
Laszlo Ersek ler...@redhat.com writes:
On 06/07/13 16:44, Jeff Cody wrote:
Thanks. I can either do the above changes for a v2, or as follow on
Ping!
Any objections to this one going in? perhaps even via trivial queue?
Regards,
Peter
On Mon, Jun 3, 2013 at 3:11 PM, peter.crosthwa...@xilinx.com wrote:
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
Some cosmetics, refactored to use util/fifo8 for the FIFO8, then
factored out
Hi Andreas,
On Mon, Jun 10, 2013 at 9:49 PM, Andreas Färber afaer...@suse.de wrote:
Am 10.06.2013 12:23, schrieb Peter Crosthwaite:
Ping!
Any objections to this one going in? perhaps even via trivial queue?
No strong objection, but you are using an unusual 12-char indentation in
some
Hi Michael,
On Tue, Jun 11, 2013 at 1:29 AM, Michael Tokarev m...@tls.msk.ru wrote:
10.06.2013 19:17, Michael Tokarev пишет:
03.06.2013 09:12, peter.crosthwa...@xilinx.com wrote:
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
Some cosmetic fixes to char/serial fixing some checkpatch
Hi Michael,
On Tue, Jun 11, 2013 at 3:06 AM, Michael S. Tsirkin m...@redhat.com wrote:
On Mon, Jun 10, 2013 at 07:14:45PM +1000, Peter Crosthwaite wrote:
Hi,
On Mon, Jun 10, 2013 at 3:27 PM, Gerd Hoffmann kra...@redhat.com wrote:
Hi,
Maybe instead (or in addition to), we should
On Sat, Jun 8, 2013 at 8:36 AM, Michael Tokarev m...@tls.msk.ru wrote:
07.06.2013 06:39, Peter Crosthwaite wrote:
Use qemu_set_irq rather than if-elsing qemu_irq_(lower|raise). No
functional change, just reduces verbosity.
Thanks, applied to the trivial patches queue.
Thanks,
I need
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
The UART IRQ is edge sensitive, whereas the machine was registering it
as level sensitive. Fix.
Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com
---
hw/microblaze/petalogix_s3adsp1800_mmu.c | 2 +-
1 file changed, 1 insertion
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
Various fixups to the Xilinx Interrupt controller following a review
against TRM and RTL descriptions.
Tested as working for microblaze and microblazeel Linux.
change from v1:
Fixed S3ADSP UART interrupt - done first for bisectability
(Now
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
For level sensitive interrupts, ISR bits are cleared when the input pin
is lowered. This is incorrect. Only software can clear ISR bits (via
IAR or direct write to ISR with !MER(2)).
Signed-off-by: Peter Crosthwaite peter.crosthwa
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
Acking a level sensitive interrupt should have no effect if the
interrupt pin is still asserted. The current implementation requires
and edge condition to occur for setting a level sensitive IRQ, which
means an ACK can clear a level sensitive
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
When the Hardware Interrupt Enable (HIE) bit is set, software cannot
change ISR. Add write guard accordingly.
Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com
---
hw/intc/xilinx_intc.c | 5 +
1 file changed, 5 insertions
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
This is a little strange. It is lowering the parent IRQ pin on input
when HIE is cleared. There is no such behaviour in the real hardware.
ISR changes based on interrupt pin state are already guarded on HIE
being set. So we can just delete
Hi Hans,
On Fri, Jun 7, 2013 at 12:39 AM, Hans de Goede hdego...@redhat.com wrote:
We override libfdt_env.h with our own copy, and the latest libfdt expects
libfdt_env.h to define fdt##_t types.
This discussion is open on list, and AFAICT the consensus is to drop
qemus libfdt_env.h
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
There are a number of different cast implementations from various
stages of QEMU development out in device model land. This series cleans
up the ones involving TYPE_PCI_DEVICE to consistently use proper QOM
casts for both up and down casts
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
Define and use standard QOM cast macro. Remove usages of DO_UPCAST
and direct - style upcasting.
Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com
---
hw/net/rtl8139.c | 26 ++
1 file changed, 18
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
Define and use standard QOM cast macro. Remove usages of DO_UPCAST
and direct - style upcasting.
Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com
---
hw/net/e1000.c | 20 +---
1 file changed, 13 insertions(+), 7
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
Define and use standard QOM cast macro. Remove usages of DO_UPCAST
and direct - style upcasting.
Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com
---
hw/net/pcnet-pci.c | 14 +-
1 file changed, 9 insertions(+), 5
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
Define and use standard QOM cast macro. Remove usages of DO_UPCAST
and direct - style upcasting.
Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com
---
hw/usb/hcd-xhci.c | 19 +--
1 file changed, 13 insertions
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
Define and use standard QOM cast macro. Remove usages of DO_UPCAST
and direct - style upcasting.
Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com
---
hw/scsi/lsi53c895a.c | 26 --
1 file changed, 16
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
Define and use standard QOM cast macro. Remove usages of DO_UPCAST
and direct - style upcasting.
Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com
---
hw/scsi/megasas.c | 17 +++--
1 file changed, 11 insertions(+), 6
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
Define and use standard QOM cast macro. Remove usages of DO_UPCAST
and direct - style upcasting.
Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com
---
hw/scsi/esp-pci.c | 14 +-
1 file changed, 9 insertions(+), 5
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
Define and use standard QOM cast macro. Remove usages of DO_UPCAST
and direct - style upcasting.
Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com
---
hw/ide/ahci.h | 5 +
hw/ide/ich.c | 10 +-
2 files changed, 10
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
Use standard QOM cast macro. Remove usage of DO_UPCAST and
direct - style upcasting.
Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com
---
hw/ide/piix.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
Use standard QOM cast macro. Remove usages of DO_UPCAST
and direct - style upcasting.
Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com
---
hw/acpi/piix4.c | 31 +--
1 file changed, 17 insertions
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
Define and use standard QOM cast macro. Remove usages of DO_UPCAST
and direct - style upcasting.
Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com
---
hw/misc/pci-testdev.c | 11 ---
1 file changed, 8 insertions(+), 3
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
Use standard QOM cast macro. Remove usages of container_of() and
direct - style upcasting.
Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com
---
hw/virtio/virtio-pci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
Define and use standard QOM cast macro. Remove usages of DO_UPCAST and
direct - style casting.
Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com
---
hw/display/vmware_vga.c | 13 -
1 file changed, 8 insertions(+), 5
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
Define and use standard QOM cast macro. Remove usages of DO_UPCAST
and direct - style upcasting.
Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com
---
hw/xen/xen_platform.c | 28
1 file changed, 16
1 - 100 of 3890 matches
Mail list logo
