Re: [Qemu-devel] [PATCH] qemu-clock: add an alarm timer based on timerfd

2012-09-19 Thread Peter Portante
On Wed, Sep 19, 2012 at 10:27 AM, Jan Kiszka wrote: > Please turn of HTML in you mailer. It's very hard to parse your reply. > > On 2012-09-19 16:15, Peter Portante wrote: >> On Wed, Sep 19, 2012 at 3:44 AM, Jan Kiszka >> mailto:jan.kis...@siemens.com>> wrot

Re: [Qemu-devel] [PATCH] qemu-clock: add an alarm timer based on timerfd

2012-09-19 Thread Peter Portante
ch a fundamental > change, > >> I'd like to do some performance analysis before committing but wanted > to share > >> early. > > > > Looks good. I think Peter Portante tested something similar, and found > no big > > difference between the two. B

Re: [Qemu-devel] [PATCH] qemu-clock: add an alarm timer based on timerfd

2012-09-19 Thread Peter Portante
On Tue, Sep 18, 2012 at 4:37 PM, Anthony Liguori wrote: > timerfd is a new(ish) mechanism provided in the 2.6.25+ Linux kernels that > allows for a high resolution event timer signaled through a file > descriptor. > This patch adds an alarm timer implementation using timerfd. > > timerfd has a cou

[Qemu-devel] [PATCH 0/4] More whitespace and coding style clean ups ahead of future changes

2012-03-21 Thread Peter Portante
Hi Folks, Please forgive me if you find these changes are annoying, as I am trying to learn the ropes of patch submission with git ahead of making a real patch. While working on the code, I found that scripts/checkpatch.pl will flag lines that I am changing as not adhereing to the codeing standar

[Qemu-devel] [PATCH 3/4] And some final work to complete the coding style upgrade, missed by the previous commit.

2012-03-21 Thread Peter Portante
Signed-off-by: Peter Portante --- slirp/slirp.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/slirp/slirp.c b/slirp/slirp.c index 40f7523..fd28f17 100644 --- a/slirp/slirp.c +++ b/slirp/slirp.c @@ -457,7 +457,7 @@ void slirp_select_poll(fd_set *readfds, fd_set

[Qemu-devel] [PATCH] Whitespace clean up.

2012-03-21 Thread Peter Portante
Signed-off-by: Peter Portante --- block/raw-posix.c | 28 ++-- 1 files changed, 14 insertions(+), 14 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index 2d1bc13..719a590 100644 --- a/block/raw-posix.c +++ b/block/raw-posix.c @@ -112,7 +112,7

[Qemu-devel] [PATCH 4/4] Yet another missed use of tabs.

2012-03-21 Thread Peter Portante
Signed-off-by: Peter Portante --- slirp/slirp.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/slirp/slirp.c b/slirp/slirp.c index fd28f17..45a8de2 100644 --- a/slirp/slirp.c +++ b/slirp/slirp.c @@ -457,7 +457,7 @@ void slirp_select_poll(fd_set *readfds, fd_set

[Qemu-devel] [PATCH 2/4] More work to fix up the formatting and the whitespace of this module to conform to the coding standard.

2012-03-21 Thread Peter Portante
Signed-off-by: Peter Portante --- slirp/slirp.c | 381 +++-- 1 files changed, 205 insertions(+), 176 deletions(-) diff --git a/slirp/slirp.c b/slirp/slirp.c index ca0ff94..40f7523 100644 --- a/slirp/slirp.c +++ b/slirp/slirp.c @@ -295,15

[Qemu-devel] [PATCH 1/4] More whitespace cleanup in preparation for future commits.

2012-03-21 Thread Peter Portante
Signed-off-by: Peter Portante --- block_int.h |4 +- qemu-timer.c |6 +- slirp/slirp.c | 526 3 files changed, 268 insertions(+), 268 deletions(-) diff --git a/block_int.h b/block_int.h index b460c36..64e8b82 100644 --- a

[Qemu-devel] [PATCH] Small change to remove short 250us timeouts every other time through the wait loop.

2012-03-22 Thread Peter Portante
: Peter Portante --- qemu-timer.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index d7f56e5..b0845f1 100644 --- a/qemu-timer.c +++ b/qemu-timer.c @@ -472,16 +472,16 @@ void qemu_run_all_timers(void) { alarm_timer->pending

Re: [Qemu-devel] [PATCH] Small change to remove short 250us timeouts every other time through the wait loop.

2012-03-27 Thread Peter Portante
Should I resubmit the patch? Thanks, -peter On Mar 27, 2012, at 8:34 AM, Avi Kivity wrote: > On 03/22/2012 04:59 PM, Peter Portante wrote: >> Basically, the main wait loop calls qemu_run_all_timers() unconditionally. >> The >> first thing this routine used to do is to se

Re: [Qemu-devel] [PATCH 3/4] Enable qemu-timer dynticks for Solaris

2012-03-27 Thread Peter Portante
There exists a simple patch that changes the wait loop timer to use CLOCK_MONOTONIC. See https://github.com/portante/qemu/commit/35c92daa9784882153c6d8b0e15e8c8f181d6e8a . -peter On Tue, Mar 27, 2012 at 12:00 PM, Jan Kiszka wrote: > On 2012-03-27 17:52, Paolo Bonzini wrote: > > Il 27/03/2012 17

[Qemu-devel] [PATCH v2] qemu-timer.c: Remove 250us timeouts

2012-04-05 Thread Peter Portante
: Peter Portante --- qemu-timer.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index d7f56e5..b0845f1 100644 --- a/qemu-timer.c +++ b/qemu-timer.c @@ -472,16 +472,16 @@ void qemu_run_all_timers(void) { alarm_timer->pending

[Qemu-devel] [PATCH] Remove extra pthread switch

2012-04-20 Thread Peter Portante
>From the Department of the Redundancy Department: remove the extra pthread switch which might be there from the package config check for gthreads. Signed-off-by: Peter Portante --- configure | 11 ++- 1 files changed, 10 insertions(+), 1 deletions(-) diff --git a/configur

[Qemu-devel] [PATCH] Bug fix for #986241: spell env correctly

2012-04-20 Thread Peter Portante
Signed-off-by: Peter Portante --- hw/spapr_hcall.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/spapr_hcall.c b/hw/spapr_hcall.c index 634763e..94bb504 100644 --- a/hw/spapr_hcall.c +++ b/hw/spapr_hcall.c @@ -482,7 +482,7 @@ static target_ulong register_dtl

[Qemu-devel] [Bug 986241] [NEW] Misspelling of env parameter in deregister_dtl() [hw/spapr_hcall.c]

2012-04-20 Thread Peter Portante
Public bug reported: Looks like there is a simple misspelling of the env parameter, as "emv", in hw/spapr_hcall.c:485: static target_ulong deregister_dtl(CPUPPCState *emv, target_ulong addr) ** Affects: qemu Importance: Undecided Status: New -- You received this bug notificatio

Re: [Qemu-devel] [PATCH] Bug fix for #986241: spell env correctly

2012-04-22 Thread Peter Portante
On Sun, Apr 22, 2012 at 3:56 PM, Andreas Färber wrote: > Am 20.04.2012 17:44, schrieb Peter Portante: > > Signed-off-by: Peter Portante > > Fix itself looks okay, but author, maintainer and qemu-ppc were missing > in CC, and a better commit message would be: > > ---8&l

Re: [Qemu-devel] [PATCH] Bug fix for #986241: spell env correctly

2012-04-22 Thread Peter Portante
On Sun, Apr 22, 2012 at 9:40 PM, Peter Portante wrote: > On Sun, Apr 22, 2012 at 3:56 PM, Andreas Färber wrote: > >> Am 20.04.2012 17:44, schrieb Peter Portante: >> > Signed-off-by: Peter Portante >> >> Fix itself looks okay, but author, maintainer and qemu

Re: [Qemu-devel] [Qemu-ppc] [PATCH] Bug fix for #986241: spell env correctly

2012-04-22 Thread Peter Portante
On 04/22/2012 09:22 PM, David Gibson wrote: On Sun, Apr 22, 2012 at 09:56:09PM +0200, Andreas Färber wrote: Am 20.04.2012 17:44, schrieb Peter Portante: Signed-off-by: Peter Portante Fix itself looks okay, but author, maintainer and qemu-ppc were missing in CC, and a better commit message

Re: [Qemu-devel] [PATCH] Bug fix for #986241: spell env correctly

2012-04-23 Thread Peter Portante
On Sun, Apr 22, 2012 at 3:56 PM, Andreas Färber wrote: > Am 20.04.2012 17:44, schrieb Peter Portante: > > Signed-off-by: Peter Portante > > Fix itself looks okay, but author, maintainer and qemu-ppc were missing > in CC, and a better commit message would be: > > ---8&l

[Qemu-devel] [PATCH v2] pseries: Fix use of global CPU state

2012-04-23 Thread Peter Portante
ot;env" so that no build failure resulted. Fix the argument to read "env". Resolves LP#986241. Signed-off-by: Peter Portante --- hw/spapr_hcall.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/spapr_hcall.c b/hw/spapr_hcall.c index 634763e..94bb504

[Qemu-devel] [PATCH] xtensa, hw: remove unnecessary include of dyngen-exec.h

2012-04-25 Thread Peter Portante
Signed-off-by: Peter Portante --- hw/spapr_hcall.c |1 - xtensa-semi.c|1 - 2 files changed, 0 insertions(+), 2 deletions(-) diff --git a/hw/spapr_hcall.c b/hw/spapr_hcall.c index 94bb504..88c1fab 100644 --- a/hw/spapr_hcall.c +++ b/hw/spapr_hcall.c @@ -1,6 +1,5 @@ #include

Re: [Qemu-devel] [PATCH] xtensa, hw: remove unnecessary include of dyngen-exec.h

2012-04-25 Thread Peter Portante
On 04/25/2012 04:07 PM, Max Filippov wrote: On 04/25/2012 10:47 PM, Peter Portante wrote: Signed-off-by: Peter Portante --- hw/spapr_hcall.c |1 - xtensa-semi.c|1 - 2 files changed, 0 insertions(+), 2 deletions(-) diff --git a/hw/spapr_hcall.c b/hw/spapr_hcall.c index 94bb504

Re: [Qemu-devel] [PATCH] xtensa, hw: remove unnecessary include of dyngen-exec.h

2012-04-25 Thread Peter Portante
On 04/25/2012 04:30 PM, Andreas Färber wrote: Am 25.04.2012 20:47, schrieb Peter Portante: Signed-off-by: Peter Portante --- hw/spapr_hcall.c |1 - xtensa-semi.c|1 - 2 files changed, 0 insertions(+), 2 deletions(-) diff --git a/hw/spapr_hcall.c b/hw/spapr_hcall.c index 94bb504

Re: [Qemu-devel] [PATCH] xtensa, hw: remove unnecessary include of dyngen-exec.h

2012-04-25 Thread Peter Portante
On 04/25/2012 04:56 PM, Max Filippov wrote: On 04/26/2012 12:31 AM, Peter Portante wrote: On 04/25/2012 04:07 PM, Max Filippov wrote: On 04/25/2012 10:47 PM, Peter Portante wrote: Signed-off-by: Peter Portante --- hw/spapr_hcall.c | 1 - xtensa-semi.c | 1 - 2 files changed, 0 insertions(+), 2

[Qemu-devel] [PATCH] xtensa: remove unnecessary include of dyngen-exec.h

2012-04-25 Thread Peter Portante
--- xtensa-semi.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/xtensa-semi.c b/xtensa-semi.c index b7c8c34..1c8a19e 100644 --- a/xtensa-semi.c +++ b/xtensa-semi.c @@ -30,7 +30,6 @@ #include #include #include "cpu.h" -#include "dyngen-exec.h" #include "helper.h" #

[Qemu-devel] [PATCH] Remove extra -lrt switch

2012-04-27 Thread Peter Portante
Remove the extra -lrt switch which might be there from the package config check for gthreads. See also: e3c56761b465a4253871c32b06ebbc2d8b3fc3e1 for the extra pthread switch removal. Signed-off-by: Peter Portante --- configure | 11 ++- 1 files changed, 10 insertions(+), 1 deletions

Re: [Qemu-devel] [PATCH] Remove extra -lrt switch

2012-04-27 Thread Peter Portante
On Fri, Apr 27, 2012 at 1:43 PM, Peter Portante wrote: > Remove the extra -lrt switch which might be there from the package > config check for gthreads. > > See also: e3c56761b465a4253871c32b06ebbc2d8b3fc3e1 for the extra > pthread switch removal. > FYI: I am not trying to drib

Re: [Qemu-devel] [PATCH] Remove extra -lrt switch

2012-04-27 Thread Peter Portante
On 04/27/2012 02:14 PM, Peter Maydell wrote: On 27 April 2012 18:43, Peter Portante wrote: Remove the extra -lrt switch which might be there from the package config check for gthreads. See also: e3c56761b465a4253871c32b06ebbc2d8b3fc3e1 for the extra pthread switch removal. Signed-off-by

[Qemu-devel] [PATCH v2] Remove the extra -lrt switch

2012-04-27 Thread Peter Portante
The package config check for gthreads might have already placed a -lrt switch in LIBS earlier. Refactored the code from the pthread switch removal, from commit e3c56761b465a4253871c32b06ebbc2d8b3fc3e1, to make it work for the more general case. Signed-off-by: Peter Portante --- configure

Re: [Qemu-devel] KVM call agenda for May, Thrusday 1st

2012-04-30 Thread Peter Portante
On Mon, Apr 30, 2012 at 7:58 AM, Anthony Liguori wrote: > On 04/30/2012 04:17 AM, Juan Quintela wrote: > >> >> >> Hi >> >> Please send in any agenda items you are interested in covering. >> > > FYI, I won't be able to attend as I'll be at the LF End User Summit. > > Regards, > > Anthony Liguori >