Got it.
It looks more reasonable. Will be changed in V2.
Thanks,
Lei.
-Original Message-
From: Li Zhijian
Sent: Tuesday, September 22, 2020 2:58 PM
To: Rao, Lei ; Zhang, Chen ;
jasow...@redhat.com; quint...@redhat.com; dgilb...@redhat.com;
pbonz...@redhat.com
Cc: qemu-devel
Hi, Derek and Chen
ram_bulk_stage is false by default before Hailiang's patch.
For COLO, it does not seem to be used, so I think there is no need to reset it
to true.
Thanks,
Lei.
From: Derek Su
Sent: Tuesday, September 22, 2020 11:48 AM
To: Zhang, Chen
Cc: qemu-devel ; Rao, Lei
OK, you are right, I will change it in V2.
Thanks,
Lei.
-Original Message-
From: Lukas Straub
Sent: Thursday, January 21, 2021 3:21 AM
To: Rao, Lei
Cc: Zhang, Chen ; lizhij...@cn.fujitsu.com;
jasow...@redhat.com; zhang.zhanghaili...@huawei.com; quint...@redhat.com;
dgilb
_FINISH_MIGRATE)) {
runstate_set(RUN_STATE_POSTMIGRATE);
I will send the patch to community after more test.
Thanks,
Lei.
-Original Message-
From: Lukas Straub
Sent: Thursday, January 21, 2021 3:13 AM
To: Rao, Lei
Cc: Zhang, Chen ; lizhij...
a
checkpoint. This will ensure the success of doing a checkpoint and this has
nothing to do with auto-converge.
Thanks,
Lei.
-Original Message-
From: Dr. David Alan Gilbert
Sent: Wednesday, January 13, 2021 7:32 PM
To: Rao, Lei
Cc: Zhang, Chen ; lizhij...@cn.fujitsu.com;
jasow
is not defined in
runstate_transitions_def. this will cause QEMU crash. Although this is small
probability, it may still happen. By the way. Do you have any comments about
other patches?
Thanks,
Lei.
-Original Message-
From: Lukas Straub
Sent: Thursday, January 28, 2021 2:24 AM
To: Rao, Lei
Cc
It's been a long time since this bug, I will reproduce it to get the GDB stack,
but it may take some time.
Thanks,
Lei.
-Original Message-
From: Lukas Straub
Sent: Sunday, July 4, 2021 4:36 AM
To: Rao, Lei
Cc: Zhang, Chen ; lizhij...@cn.fujitsu.com;
jasow...@redhat.com
t;rp_state.from_dst_file), we set the from_dst_file = NULL;
Ways to reproduce bugs:
You can kill SVM, after executing the failover QMP command, immediately execute
the power off command in the guest, which will have a high probability to
reproduce this bug.
Thanks,
Lei.
-Original Messag
Hi, Dave
I think this set of patches is beneficial to upstream. Please check these
performance data. If you have any other ideas, please let me know.
Thanks
Lei.
-Original Message-
From: Rao, Lei
Sent: Friday, April 16, 2021 3:57 PM
To: dgilb...@redhat.com
Cc: qemu-devel@nongnu.org
-Original Message-
From: Dr. David Alan Gilbert
Sent: Friday, March 26, 2021 2:08 AM
To: Rao, Lei
Cc: Zhang, Chen ; lizhij...@cn.fujitsu.com;
jasow...@redhat.com; quint...@redhat.com; pbonz...@redhat.com;
lukasstra...@web.de; qemu-devel@nongnu.org
Subject: Re: [PATCH v4 09/10] Add
After testing, I think you are right.
Will remove the cpu_throttle_stop() in V4.
Thanks,
Lei.
-Original Message-
From: Dr. David Alan Gilbert
Sent: Thursday, March 25, 2021 12:40 AM
To: Rao, Lei
Cc: Zhang, Chen ; lizhij...@cn.fujitsu.com;
jasow...@redhat.com; quint...@redhat.com
How about redefine a function named packet_new_nocopy?
In comments, we can tell the caller don't release the buffer and the
packet_destroy will release it.
Thanks,
Lei.
-Original Message-
From: lizhij...@fujitsu.com
Sent: Friday, March 12, 2021 2:53 PM
To: Rao, Lei ; Zhang, Chen
, March 12, 2021 3:54 PM
To: Rao, Lei ; Zhang, Chen ;
jasow...@redhat.com; quint...@redhat.com; dgilb...@redhat.com;
pbonz...@redhat.com; lukasstra...@web.de
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH v2 08/10] Reduce the PVM stop time during Checkpoint
On 3/12/21 1:03 PM, leirao wrote:
> F
Oh, I understand what you mean, and will change it in V3.
Thanks,
Lei.
-Original Message-
From: lizhij...@fujitsu.com
Sent: Friday, March 12, 2021 6:23 PM
To: Rao, Lei ; Zhang, Chen ;
jasow...@redhat.com; quint...@redhat.com; dgilb...@redhat.com;
pbonz...@redhat.com; lukasstra
.
Thanks,
Lei.
-Original Message-
From: Lukas Straub
Sent: Sunday, February 14, 2021 6:52 PM
To: Rao, Lei
Cc: Zhang, Chen ; lizhij...@cn.fujitsu.com;
jasow...@redhat.com; zhang.zhanghaili...@huawei.com; quint...@redhat.com;
dgilb...@redhat.com; qemu-devel@nongnu.org
Subject: Re: [PATCH 07/10
If user executes the shutdown normally and QEMU crashes, I think this is
unacceptable.
Since we can avoid this situation, why not do it?
Thanks,
Lei.
-Original Message-
From: Lukas Straub
Sent: Sunday, February 14, 2021 7:46 PM
To: Rao, Lei
Cc: Zhang, Chen ; lizhij...@cn.fujitsu.com
The performance data has been added to the commit message in V6.
Thanks,
Lei.
-Original Message-
From: Dr. David Alan Gilbert
Sent: Monday, March 29, 2021 7:32 PM
To: Rao, Lei
Cc: Zhang, Chen ; lizhij...@cn.fujitsu.com;
jasow...@redhat.com; quint...@redhat.com; pbonz...@redhat.com
Hi, Dave
The performance data has added to the commit messages.
Do you have any other suggestions?
Thanks
Lei.
-Original Message-
From: Rao, Lei
Sent: Friday, April 9, 2021 11:21 AM
To: Zhang, Chen ; lizhij...@cn.fujitsu.com;
jasow...@redhat.com; quint...@redhat.com; dgilb
We found that the QIO channel coroutine could not be awakened in some
corner cases during our stress test for COLO.
The patch fixes as follow:
#0 0x7fad72e24bf6 in __ppoll (fds=0x5563d75861f0, nfds=1,
timeout=, sigmask=0x0) at ../sysdeps/unix/sysv/linux/ppoll.c:44
#1
-Original Message-
From: Daniel P. Berrangé
Sent: Wednesday, December 1, 2021 5:11 PM
To: Rao, Lei
Cc: Zhang, Chen ; ebl...@redhat.com;
vsement...@virtuozzo.com; kw...@redhat.com; hre...@redhat.com;
qemu-bl...@nongnu.org; qemu-devel@nongnu.org
Subject: Re: [PATCH] QIO: Add
When doing failover and checkpoint, some returns are missed in error
handling. Let's add it.
Signed-off-by: Lei Rao
---
migration/colo.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/migration/colo.c b/migration/colo.c
index 5f7071b3cd..014d3cba01 100644
---
On 12/24/2021 6:07 PM, lizhij...@fujitsu.com wrote:
On 24/12/2021 10:37, Rao, Lei wrote:
This patch is to improve the logic of QEMU main thread sleep code in
qemu_chr_write_buffer() where it can be blocked and can't run other
coroutines during COLO IO stress test.
Our approach is to put
This patch is to improve the logic of QEMU main thread sleep code in
qemu_chr_write_buffer() where it can be blocked and can't run other
coroutines during COLO IO stress test.
Our approach is to put filter_send() in a coroutine. In this way,
filter_send() will call qemu_coroutine_yield() in
This patch is to improve the logic of QEMU main thread sleep code in
qemu_chr_write_buffer() where it can be blocked and can't run other
coroutines during COLO IO stress test.
Our approach is to put filter_send() in a coroutine. In this way,
filter_send() will call qemu_coroutine_yield() in
The GDB statck is as follows:
(gdb) bt
0 __lll_lock_wait (futex=futex@entry=0x56211df20360, private=0) at
lowlevellock.c:52
1 0x7f263caf20a3 in __GI___pthread_mutex_lock (mutex=0x56211df20360) at
../nptl/pthread_mutex_lock.c:80
2 0x56211a757364 in qemu_mutex_lock_impl
The GDB statck is as follows:
(gdb) bt
0 __lll_lock_wait (futex=futex@entry=0x56211df20360, private=0) at
lowlevellock.c:52
1 0x7f263caf20a3 in __GI___pthread_mutex_lock (mutex=0x56211df20360) at
../nptl/pthread_mutex_lock.c:80
2 0x56211a757364 in qemu_mutex_lock_impl
OK，all files you mentioned will be modified in the next patch.
Thanks,
Lei.
-Original Message-
From: Markus Armbruster
Sent: Thursday, November 18, 2021 2:50 PM
To: Rao, Lei
Cc: Zhang, Chen ; zhang.zhanghaili...@huawei.com;
quint...@redhat.com; dgilb...@redhat.com; qemu-triv
From: "Rao, Lei"
The code to acquire bitmap_mutex is added in the commit of
"63268c4970a5f126cc9af75f3ccb8057abef5ec0". There is no
need to acquire bitmap_mutex in colo_flush_ram_cache(). This
is because the colo_flush_ram_cache only be called on the COLO
secondary VM, whic
From: "Rao, Lei"
When the PVM guest poweroff, the COLO thread may wait a semaphore
in colo_process_checkpoint().So, we should wake up the COLO thread
before migration shutdown.
Signed-off-by: Lei Rao
---
include/migration/colo.h | 1 +
migration/colo.c | 14 ++
OK, will be changed in V2.
Thanks,
Lei
-Original Message-
From: Juan Quintela
Sent: Wednesday, November 10, 2021 5:55 PM
To: Rao, Lei
Cc: Zhang, Chen ; zhang.zhanghaili...@huawei.com;
dgilb...@redhat.com; qemu-devel@nongnu.org
Subject: Re: [PATCH 1/2] Fixed a QEMU hang when guest
From: "Rao, Lei"
Signed-off-by: Lei Rao
---
docs/COLO-FT.txt | 106 ++---
docs/block-replication.txt | 52 +++---
2 files changed, 79 insertions(+), 79 deletions(-)
diff --git a/docs/COLO-FT.txt b/docs/COLO-FT
From: "Rao, Lei"
In commit 5024340745 "qapi/qom: Drop deprecated 'props' from
object-add" (v6.0.0), we also should update documents.
Signed-off-by: Lei Rao
---
docs/system/authz.rst | 26 ++
docs/throttle.txt | 8 +++-
docs/tools/qem
From: "Rao, Lei"
Signed-off-by: Lei Rao
---
docs/COLO-FT.txt | 106 ++---
docs/block-replication.txt | 52 +++---
2 files changed, 79 insertions(+), 79 deletions(-)
diff --git a/docs/COLO-FT.txt b/docs/COLO-FT
From: "Rao, Lei"
In commit 5024340745 "qapi/qom: Drop deprecated 'props' from
object-add" (v6.0.0), we also should update documents.
Signed-off-by: Lei Rao
---
docs/COLO-FT.txt| 16
docs/system/authz.rst | 26 ++
docs/thr
From: "Rao, Lei"
When the PVM guest poweroff, the COLO thread may wait a semaphore
in colo_process_checkpoint().So, we should wake up the COLO thread
before migration shutdown.
Signed-off-by: Lei Rao
---
include/migration/colo.h | 1 +
migration/colo.c
From: "Rao, Lei"
With the removal of deprecated 'props' from object-add in the commit of
"50243407457a9fb0ed17b9a9ba9fc9aee09495b1", we also should update COLO's
documents.
Signed-off-by: Lei Rao
---
docs/COLO-FT.txt | 16
1 file changed, 8 insertions(+),
Will be changed and sent separately.
Thanks,
Lei
-Original Message-
From: Juan Quintela
Sent: Wednesday, November 3, 2021 12:23 AM
To: Rao, Lei
Cc: Zhang, Chen ; lizhij...@cn.fujitsu.com;
jasow...@redhat.com; zhang.zhanghaili...@huawei.com; lukasstra...@web.de;
dgilb...@redhat.com
From: "Rao, Lei"
Remove some unnecessary code to improve the performance of
the filter-rewriter module.
Signed-off-by: Lei Rao
Reviewed-by: Zhang Chen
Reviewed-by: Juan Quintela
---
net/colo-compare.c| 2 +-
net/colo.c| 31 ---
From: "Rao, Lei"
When flushing memory from ram cache to ram during every checkpoint
on secondary VM, we can copy continuous chunks of memory instead of
4096 bytes per time to reduce the time of VM stop during checkpoint.
Signed-off-by: Lei Rao
Reviewed-by: Dr. David Alan Gilbert
From: "Rao, Lei"
Changes since v1-v6:
--Reset the state of the auto-converge counters at every checkpoint instead
of directly disabling.
--Remove cpu_throttle_stop from mig_throttle_counter_reset.
The series of patches include:
Reduced the PVM stop time during checkpoint.
From: "Rao, Lei"
if we don't reset the auto-converge counter,
it will continue to run with COLO running,
and eventually the system will hang due to the
CPU throttle reaching DEFAULT_MIGRATE_MAX_CPU_THROTTLE.
Signed-off-by: Lei Rao
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Lu
From: "Rao, Lei"
After the live migration, the related fd will be cleanup in
migration_incoming_state_destroy(). So, the qemu_close()
in colo_process_incoming_thread is not necessary.
Signed-off-by: Lei Rao
---
migration/colo.c | 5 -
1 file changed, 5 deletions(-)
diff --git a
From: "Rao, Lei"
This patch fixed as follows:
Thread 1 (Thread 0x7f34ee738d80 (LWP 11212)):
#0 __pthread_clockjoin_ex (threadid=139847152957184,
thread_return=0x7f30b1febf30, clockid=, abstime=,
block=) at pthread_join_common.c:145
#1 0x563401998e36 in qemu_thread_jo
From: "Rao, Lei"
The GDB statck is as follows:
Program terminated with signal SIGSEGV, Segmentation fault.
0 object_class_dynamic_cast (class=0x55c8f5d2bf50, typename=0x55c8f2f7379e
"qio-channel") at qom/object.c:832
if (type->class->interfaces &
From: "Rao, Lei"
Remove some unnecessary code to improve the performance of
the filter-rewriter module.
Signed-off-by: Lei Rao
Reviewed-by: Zhang Chen
---
net/colo-compare.c| 2 +-
net/colo.c| 31 ---
net/colo.h| 6 +++---
From: "Rao, Lei"
Signed-off-by: Lei Rao
Reviewed-by: Dr. David Alan Gilbert
---
migration/colo.c | 2 +-
net/colo-compare.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/migration/colo.c b/migration/colo.c
index 79fa1f6619..616dc00af7 100644
--- a/migrat
Changes since v1:
--Move the s->rp_state.from_dst_file = NULL behind qemu_close().
The series of patches include:
Fixed some bugs of qemu crash and segment fault.
Optimized the function of fill_connection_key.
Remove some unnecessary code to improve COLO.
Rao,
From: "Rao, Lei"
When we first stated the COLO, the last-mode is as follows:
{ "execute": "query-colo-status" }
{"return": {"last-mode": "primary", "mode": "primary", "reason": "none"}}
The la
From: "Rao, Lei"
This patch fixes the following:
qemu-system-x86_64: invalid runstate transition: 'shutdown' -> 'running'
Aborted (core dumped)
The gdb bt as following:
0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
1 0x7faa3d613859 in __GI_abort () at
On 12/2/2021 5:54 PM, Vladimir Sementsov-Ogievskiy wrote:
02.12.2021 11:53, Daniel P. Berrangé wrote:
On Thu, Dec 02, 2021 at 01:14:47PM +0800, Rao, Lei wrote:
Sorry, resending with correct indentation and quoting.
On 12/1/2021 10:27 PM, Vladimir Sementsov-Ogievskiy wrote:
01.12.2021 12
On 12/3/2021 9:26 AM, Rao, Lei wrote:
On 12/2/2021 5:54 PM, Vladimir Sementsov-Ogievskiy wrote:
02.12.2021 11:53, Daniel P. Berrangé wrote:
On Thu, Dec 02, 2021 at 01:14:47PM +0800, Rao, Lei wrote:
Sorry, resending with correct indentation and quoting.
On 12/1/2021 10:27 PM, Vladimir
On 12/13/2021 4:38 PM, Vladimir Sementsov-Ogievskiy wrote:
13.12.2021 11:02, Rao, Lei wrote:
On 12/3/2021 9:26 AM, Rao, Lei wrote:
On 12/2/2021 5:54 PM, Vladimir Sementsov-Ogievskiy wrote:
02.12.2021 11:53, Daniel P. Berrangé wrote:
On Thu, Dec 02, 2021 at 01:14:47PM +0800, Rao, Lei
On 12/13/2021 7:45 PM, Dr. David Alan Gilbert wrote:
* Rao, Lei (lei@intel.com) wrote:
Signed-off-by: Lei Rao
You don't say why you want to move it - it's just a trace, what's the
advantage?
I think it's not necessary to put trace code in the critical section.
So, moving it behind
There is no need to put some trace code in the critical section.
So, moving it behind qemu_mutex_unlock_iothread() can reduce the
lock time.
Signed-off-by: Lei Rao
---
migration/colo.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/migration/colo.c b/migration/colo.c
Sorry, resending with correct indentation and quoting.
On 12/1/2021 10:27 PM, Vladimir Sementsov-Ogievskiy wrote:
01.12.2021 12:48, Rao, Lei wrote:
-Original Message-
From: Daniel P. Berrangé
Sent: Wednesday, December 1, 2021 5:11 PM
To: Rao, Lei
Cc: Zhang, Chen ; ebl...@redhat.com
-Original Message-
From: Vladimir Sementsov-Ogievskiy
Sent: Wednesday, December 1, 2021 10:27 PM
To: Rao, Lei ; Daniel P. Berrangé
Cc: Zhang, Chen ; ebl...@redhat.com; kw...@redhat.com;
hre...@redhat.com; qemu-bl...@nongnu.org; qemu-devel@nongnu.org
Subject: Re: [PATCH] QIO: Add
Signed-off-by: Lei Rao
---
migration/colo.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/migration/colo.c b/migration/colo.c
index 2415325262..3ccacb29c8 100644
--- a/migration/colo.c
+++ b/migration/colo.c
@@ -683,8 +683,8 @@ static void
On 3/3/2022 10:05 PM, Rao, Lei wrote:
On 3/3/2022 5:25 PM, Vladimir Sementsov-Ogievskiy wrote:
03.03.2022 05:21, Rao Lei wrote:
During the stress test, the IO request coroutine has a probability that it
can't be awakened when the NBD server is killed.
The GDB statck is as follows:
(gdb
During the IO stress test, the IO request coroutine has a probability that is
can't be awakened when the NBD server is killed.
The GDB stack is as follows:
(gdb) bt
0 0x7f2ff990cbf6 in __ppoll (fds=0x55575de85000, nfds=1,
timeout=, sigmask=0x0) at ../sysdeps/unix/sysv/linux/ppoll.c:44
1
On 3/3/2022 5:25 PM, Vladimir Sementsov-Ogievskiy wrote:
03.03.2022 05:21, Rao Lei wrote:
During the stress test, the IO request coroutine has a probability that it
can't be awakened when the NBD server is killed.
The GDB statck is as follows:
(gdb) bt
0 0x7f2ff990cbf6 in __ppoll (fds
he IO request coroutine which is waiting for
>send_mutex
has yield in nbd_co_send_request(). When we kill nbd server, it will never be
wake up.
So, it is necessary to wake up the coroutine in nbd_channel_error().
Signed-off-by: Rao Lei
---
block/nbd.c | 1 +
1 file changed, 1 insertion(+)
diff -
61 matches
Mail list logo
