Re: [Qemu-devel] [PATCH v4 0/9] Add support for io_uring

2019-06-07 Thread Sergio Lopez
Aarushi Mehta writes: > This patch series adds support for the newly developed io_uring Linux AIO > interface. Linux io_uring is faster than Linux's AIO asynchronous I/O code, > offers efficient buffered asynchronous I/O support, the ability to do I/O > without performing a system call via polle

Re: [Qemu-devel] [PATCH v4 0/9] Add support for io_uring

2019-06-07 Thread Sergio Lopez
Stefan Hajnoczi writes: > On Fri, Jun 07, 2019 at 12:59:54PM +0200, Sergio Lopez wrote: >> I gave this version of the patchset a try, and found that IO hangs when >> the device is assigned to an IOThread. Sometimes is able to serve a few >> requests getting through the Gues

[Qemu-devel] [PATCH v2] mirror: Confirm we're quiesced only if the job is paused or cancelled

2019-03-07 Thread Sergio Lopez
ted by the mirror/commit job itself. The other block jobs shouldn't need any changes, as the default drained_poll() behavior is to only confirm it's quiesced if the job is not busy or completed. Signed-off-by: Sergio Lopez --- v2 - Fix typo (thanks to Eric Blake) --- block/mirror.c

Re: [Qemu-devel] [PATCH v2] mirror: Confirm we're quiesced only if the job is paused or cancelled

2019-03-08 Thread Sergio Lopez
Kevin Wolf writes: > Am 07.03.2019 um 19:54 hat Sergio Lopez geschrieben: >> While child_job_drained_begin() calls to job_pause(), the job doesn't >> actually transition between states until it runs again and reaches a >> pause point. This means bdrv_drained_begin()

[Qemu-devel] [PATCH v3] mirror: Confirm we're quiesced only if the job is paused or cancelled

2019-03-08 Thread Sergio Lopez
ted by the mirror/commit job itself. The other block jobs shouldn't need any changes, as the default drained_poll() behavior is to only confirm it's quiesced if the job is not busy or completed. Signed-off-by: Sergio Lopez --- v3 - mirror_exit_common: assert in_drain == true instead o

[Qemu-devel] Flatview rendering scalability issue

2019-03-11 Thread Sergio Lopez
Hi, Thanks to Q35/PCIe, we can now assign a large number of PCI devices to a single VM, but it seems that Flatview rendering scales poorly (worse than linear) when it has to deal with a large number of Memory Regions. I've measured to cost of the pci_default_write_config() call at virtio_write_co

Re: [Qemu-devel] Flatview rendering scalability issue

2019-03-11 Thread Sergio Lopez
Paolo Bonzini writes: > On 11/03/19 10:26, Sergio Lopez wrote: >> I guess this is a consequence of having to reset/rebuild the Flatview >> when altering the PCI BAR regions. >> >> Is this a known issue we're already working on? > > What version

Re: [Qemu-devel] Flatview rendering scalability issue

2019-03-11 Thread Sergio Lopez
Paolo Bonzini writes: > On 11/03/19 14:48, Sergio Lopez wrote: >>> The initialization is O(n^2) because the guest initializes one device at >>> a time, so you rebuild the FlatView first with 0 devices, then 1, then >>> 2, etc. This is very hard to fix, if at all p

Re: [Qemu-devel] [PATCH] intel-iommu: optimize nodmar memory regions

2019-03-13 Thread Sergio Lopez
Peter Xu writes: > Previously we have per-device system memory aliases when DMAR is > disabled by the system. It will slow the system down if there are > lots of devices especially when DMAR is disabled, because each of the > aliased system address space will contain O(N) slots, and rendering >

Re: [Qemu-devel] [PATCH] intel-iommu: optimize nodmar memory regions

2019-03-14 Thread Sergio Lopez
Paolo Bonzini writes: > On 13/03/19 12:45, Sergio Lopez wrote: >> >> Peter Xu writes: >> >>> Previously we have per-device system memory aliases when DMAR is >>> disabled by the system. It will slow the system down if there are >>> lots of d

[Qemu-devel] Combining synchronous and asynchronous IO

2019-03-14 Thread Sergio Lopez
Hi, Our current AIO path does a great job at unloading the work from the VM, and combined with IOThreads provides a good performance in most scenarios. But it also comes with its costs, in both a longer execution path and the need of the intervention of the scheduler at various points. There's on

[PATCH v9 01/15] hw/virtio: Factorize virtio-mmio headers

2019-10-15 Thread Sergio Lopez
Put QOM and main struct definition in a separate header file, so it can be accessed from other components. Signed-off-by: Sergio Lopez Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Michael S. Tsirkin --- include/hw/virtio/virtio-mmio.h | 73

[PATCH v9 00/15] Introduce the microvm machine type

2019-10-15 Thread Sergio Lopez
to factorize PVH-related functions. - Replace use of Linux's Zero Page with PVH (thanks Maran and Paolo). --- Sergio Lopez (15): hw/virtio: Factorize virtio-mmio headers hw/i386/pc: rename functions shared with non-PC machines hw/i386/pc: fix code style issues on functions that will be

[PATCH v9 03/15] hw/i386/pc: fix code style issues on functions that will be moved out

2019-10-15 Thread Sergio Lopez
Fix code style issues detected by checkpatch.pl on functions that will be moved out to x86.c. Signed-off-by: Sergio Lopez Reviewed-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 53 1 file changed, 29 insertions(+), 24 deletions(-) diff

[PATCH v9 06/15] hw/i386/pc: remove commented out code from x86_load_linux()

2019-10-15 Thread Sergio Lopez
Follow checkpatch.pl recommendation and remove commented out code from x86_load_linux(). Signed-off-by: Sergio Lopez Reviewed-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 13 - 1 file changed, 13 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 90c2263a33..612bfe9c95

[PATCH v9 02/15] hw/i386/pc: rename functions shared with non-PC machines

2019-10-15 Thread Sergio Lopez
_to_props -> x86_cpu_index_to_props pc_get_default_cpu_node_id -> x86_get_default_cpu_node_id pc_possible_cpu_arch_ids -> x86_possible_cpu_arch_ids old_pc_system_rom_init -> x86_system_rom_init Signed-off-by: Sergio Lopez Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathi

[PATCH v9 04/15] hw/i386/pc: replace use of strtol with qemu_strtol in x86_load_linux()

2019-10-15 Thread Sergio Lopez
Follow checkpatch.pl recommendation and replace the use of strtol with qemu_strtol in x86_load_linux(). Signed-off-by: Sergio Lopez --- hw/i386/pc.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 77e86bfc3d..c8608b8007 100644 --- a

[PATCH v9 15/15] MAINTAINERS: add microvm related files

2019-10-15 Thread Sergio Lopez
Add a new "Microvm" section under "X86 Machines" with the new files related to this machine type. Signed-off-by: Sergio Lopez Reviewed-by: Michael S. Tsirkin --- MAINTAINERS | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index fe

[PATCH v9 07/15] hw/i386/pc: move shared x86 functions to x86.c and export them

2019-10-15 Thread Sergio Lopez
Move x86 functions that will be shared between PC and non-PC machine types to x86.c, along with their helpers. Signed-off-by: Sergio Lopez Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Stefano Garzarella Reviewed-by: Michael S. Tsirkin --- include/hw

[PATCH v9 11/15] hw/intc/apic: reject pic ints if isa_pic == NULL

2019-10-15 Thread Sergio Lopez
In apic_accept_pic_intr(), reject PIC interruptions if a i8259 PIC has not been instantiated (isa_pic == NULL). Suggested-by: Paolo Bonzini Signed-off-by: Sergio Lopez Reviewed-by: Michael S. Tsirkin --- hw/intc/apic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw

[PATCH v9 05/15] hw/i386/pc: avoid an assignment in if condition in x86_load_linux()

2019-10-15 Thread Sergio Lopez
Follow checkpatch.pl recommendation and avoid an assignment in if condition in x86_load_linux(). Signed-off-by: Sergio Lopez Reviewed-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index

[PATCH v9 08/15] hw/i386: split PCMachineState deriving X86MachineState from it

2019-10-15 Thread Sergio Lopez
Split up PCMachineState and PCMachineClass and derive X86MachineState and X86MachineClass from them. This allows sharing code with non-PC x86 machine types. Signed-off-by: Sergio Lopez Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Michael S. Tsirkin

[PATCH v9 12/15] roms: add microvm-bios (qboot) as binary and git submodule

2019-10-15 Thread Sergio Lopez
ff-by: Sergio Lopez Reviewed-by: Stefano Garzarella Reviewed-by: Michael S. Tsirkin --- .gitmodules | 3 +++ pc-bios/bios-microvm.bin | Bin 0 -> 65536 bytes roms/Makefile| 6 ++ roms/qboot | 1 + 4 files changed, 10 insertions(+) create mode 1

[PATCH v9 09/15] hw/i386: make x86.c independent from PCMachineState

2019-10-15 Thread Sergio Lopez
As a last step into splitting PCMachineState and deriving X86MachineState from it, make the functions previously extracted from pc.c to x86.c independent from PCMachineState, using X86MachineState instead. Signed-off-by: Sergio Lopez Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe

[PATCH v9 10/15] fw_cfg: add "modify" functions for all types

2019-10-15 Thread Sergio Lopez
This allows to alter the contents of an already added item. Signed-off-by: Sergio Lopez Reviewed-by: Michael S. Tsirkin --- include/hw/nvram/fw_cfg.h | 42 +++ hw/nvram/fw_cfg.c | 29 +++ 2 files changed, 71 insertions

[PATCH v9 14/15] hw/i386: Introduce the microvm machine type

2019-10-15 Thread Sergio Lopez
stems, since it is optimized for both boot time and footprint. Signed-off-by: Sergio Lopez Reviewed-by: Michael S. Tsirkin --- default-configs/i386-softmmu.mak | 1 + include/hw/i386/microvm.h| 83 + hw/i386/microvm.c| 572 +++ hw/i386/Kc

[PATCH v9 13/15] docs/microvm.rst: document the new microvm machine type

2019-10-15 Thread Sergio Lopez
Document the new microvm machine type. Signed-off-by: Sergio Lopez Reviewed-by: Michael S. Tsirkin --- docs/microvm.rst | 98 1 file changed, 98 insertions(+) create mode 100644 docs/microvm.rst diff --git a/docs/microvm.rst b/docs/microvm.rst

[PATCH v10 01/15] hw/virtio: Factorize virtio-mmio headers

2019-10-16 Thread Sergio Lopez
Put QOM and main struct definition in a separate header file, so it can be accessed from other components. Signed-off-by: Sergio Lopez Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Michael S. Tsirkin --- include/hw/virtio/virtio-mmio.h | 73

[PATCH v10 00/15] Introduce the microvm machine type

2019-10-16 Thread Sergio Lopez
eeded NUMA-related callbacks (thanks Eduardo). - Add a patch to factorize PVH-related functions. - Replace use of Linux's Zero Page with PVH (thanks Maran and Paolo). --- Sergio Lopez (15): hw/virtio: Factorize virtio-mmio headers hw/i386/pc: rename functions shared with non-PC machin

[PATCH v10 03/15] hw/i386/pc: fix code style issues on functions that will be moved out

2019-10-16 Thread Sergio Lopez
Fix code style issues detected by checkpatch.pl on functions that will be moved out to x86.c. Signed-off-by: Sergio Lopez Reviewed-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 53 1 file changed, 29 insertions(+), 24 deletions(-) diff

[PATCH v10 15/15] MAINTAINERS: add microvm related files

2019-10-16 Thread Sergio Lopez
Add a new "microvm" section under "X86 Machines" with the new files related to this machine type. Signed-off-by: Sergio Lopez Reviewed-by: Michael S. Tsirkin Reviewed-by: Philippe Mathieu-Daudé --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff -

[PATCH v10 02/15] hw/i386/pc: rename functions shared with non-PC machines

2019-10-16 Thread Sergio Lopez
_to_props -> x86_cpu_index_to_props pc_get_default_cpu_node_id -> x86_get_default_cpu_node_id pc_possible_cpu_arch_ids -> x86_possible_cpu_arch_ids old_pc_system_rom_init -> x86_system_rom_init Signed-off-by: Sergio Lopez Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathi

[PATCH v10 04/15] hw/i386/pc: replace use of strtol with qemu_strtoui in x86_load_linux()

2019-10-16 Thread Sergio Lopez
Follow checkpatch.pl recommendation and replace the use of strtol with qemu_strtoui in x86_load_linux(). Signed-off-by: Sergio Lopez Reviewed-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c

[PATCH v10 12/15] roms: add microvm-bios (qboot) as binary and git submodule

2019-10-16 Thread Sergio Lopez
ff-by: Sergio Lopez Reviewed-by: Stefano Garzarella Reviewed-by: Michael S. Tsirkin --- .gitmodules | 3 +++ pc-bios/bios-microvm.bin | Bin 0 -> 65536 bytes roms/Makefile| 6 ++ roms/qboot | 1 + 4 files changed, 10 insertions(+) create mode 1

[PATCH v10 05/15] hw/i386/pc: avoid an assignment in if condition in x86_load_linux()

2019-10-16 Thread Sergio Lopez
Follow checkpatch.pl recommendation and avoid an assignment in if condition in x86_load_linux(). Signed-off-by: Sergio Lopez Reviewed-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index

[PATCH v10 13/15] docs/microvm.rst: document the new microvm machine type

2019-10-16 Thread Sergio Lopez
Document the new microvm machine type. Signed-off-by: Sergio Lopez Reviewed-by: Michael S. Tsirkin --- docs/microvm.rst | 98 1 file changed, 98 insertions(+) create mode 100644 docs/microvm.rst diff --git a/docs/microvm.rst b/docs/microvm.rst

[PATCH v10 06/15] hw/i386/pc: remove commented out code from x86_load_linux()

2019-10-16 Thread Sergio Lopez
Follow checkpatch.pl recommendation and remove commented out code from x86_load_linux(). Signed-off-by: Sergio Lopez Reviewed-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 13 - 1 file changed, 13 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 90c2263a33..612bfe9c95

[PATCH v10 10/15] fw_cfg: add "modify" functions for all types

2019-10-16 Thread Sergio Lopez
This allows to alter the contents of an already added item. Signed-off-by: Sergio Lopez Reviewed-by: Michael S. Tsirkin --- include/hw/nvram/fw_cfg.h | 42 +++ hw/nvram/fw_cfg.c | 29 +++ 2 files changed, 71 insertions

[PATCH v10 07/15] hw/i386/pc: move shared x86 functions to x86.c and export them

2019-10-16 Thread Sergio Lopez
Move x86 functions that will be shared between PC and non-PC machine types to x86.c, along with their helpers. Signed-off-by: Sergio Lopez Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Stefano Garzarella Reviewed-by: Michael S. Tsirkin --- include/hw

[PATCH v10 08/15] hw/i386: split PCMachineState deriving X86MachineState from it

2019-10-16 Thread Sergio Lopez
Split up PCMachineState and PCMachineClass and derive X86MachineState and X86MachineClass from them. This allows sharing code with non-PC x86 machine types. Signed-off-by: Sergio Lopez Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Michael S. Tsirkin

[PATCH v10 14/15] hw/i386: Introduce the microvm machine type

2019-10-16 Thread Sergio Lopez
since it is optimized for both boot time and footprint. Signed-off-by: Sergio Lopez Reviewed-by: Michael S. Tsirkin --- default-configs/i386-softmmu.mak | 1 + include/hw/i386/microvm.h| 83 + hw/i386/microvm.c| 572 +++ hw/i386/Kc

[PATCH v10 09/15] hw/i386: make x86.c independent from PCMachineState

2019-10-16 Thread Sergio Lopez
As a last step into splitting PCMachineState and deriving X86MachineState from it, make the functions previously extracted from pc.c to x86.c independent from PCMachineState, using X86MachineState instead. Signed-off-by: Sergio Lopez Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe

[PATCH v10 11/15] hw/intc/apic: reject pic ints if isa_pic == NULL

2019-10-16 Thread Sergio Lopez
In apic_accept_pic_intr(), reject PIC interruptions if a i8259 PIC has not been instantiated (isa_pic == NULL). Suggested-by: Paolo Bonzini Signed-off-by: Sergio Lopez Reviewed-by: Michael S. Tsirkin --- hw/intc/apic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw

Re: [PATCH v9 04/15] hw/i386/pc: replace use of strtol with qemu_strtol in x86_load_linux()

2019-10-16 Thread Sergio Lopez
Markus Armbruster writes: > Philippe Mathieu-Daudé writes: > >> Hi Sergio, >> >> On 10/15/19 1:23 PM, Sergio Lopez wrote: >>> Follow checkpatch.pl recommendation and replace the use of strtol with >>> qemu_strtol in x86_load_linux(). >> >>

Re: [PATCH v10 14/15] hw/i386: Introduce the microvm machine type

2019-10-16 Thread Sergio Lopez
Marc-André Lureau writes: > Hi > > On Wed, Oct 16, 2019 at 12:24 PM Sergio Lopez wrote: >> >> microvm is a machine type inspired by Firecracker and constructed >> after its machine model. >> >> It's a minimalist machine type without PCI nor ACPI

Re: [PATCH v10 13/15] docs/microvm.rst: document the new microvm machine type

2019-10-16 Thread Sergio Lopez
Marc-André Lureau writes: > Hi > > On Wed, Oct 16, 2019 at 12:19 PM Sergio Lopez wrote: >> >> Document the new microvm machine type. >> >> Signed-off-by: Sergio Lopez >> Reviewed-by: Michael S. Tsirkin >> --- >> docs/microvm.rst | 98 +++

Re: [PATCH v10 13/15] docs/microvm.rst: document the new microvm machine type

2019-10-17 Thread Sergio Lopez
Philippe Mathieu-Daudé writes: > Hi Sergio, > > On 10/16/19 12:12 PM, Sergio Lopez wrote: >> +Supported devices >> +- >> + >> +The microvm machine type supports the following devices: >> + >> +- ISA bus >> +- i8259 PIC (opti

Re: [PATCH v10 13/15] docs/microvm.rst: document the new microvm machine type

2019-10-17 Thread Sergio Lopez
Daniel P. Berrangé writes: > On Wed, Oct 16, 2019 at 12:12:40PM +0200, Sergio Lopez wrote: >> Document the new microvm machine type. >> >> Signed-off-by: Sergio Lopez >> Reviewed-by: Michael S. Tsirkin >> --- >> docs/microvm.rst | 98 +++

Re: [PATCH v10 13/15] docs/microvm.rst: document the new microvm machine type

2019-10-17 Thread Sergio Lopez
Philippe Mathieu-Daudé writes: > On 10/17/19 12:45 PM, Sergio Lopez wrote: >> >> Philippe Mathieu-Daudé writes: >> >>> Hi Sergio, >>> >>> On 10/16/19 12:12 PM, Sergio Lopez wrote: >>>> +Supported devices >>>> +--

[PATCH v11 00/15] Introduce the microvm machine type

2019-10-18 Thread Sergio Lopez
duardo). - Add a patch to factorize PVH-related functions. - Replace use of Linux's Zero Page with PVH (thanks Maran and Paolo). --- Sergio Lopez (15): hw/virtio: Factorize virtio-mmio headers hw/i386/pc: rename functions shared with non-PC machines hw/i386/pc: fix code style issue

[PATCH v11 01/15] hw/virtio: Factorize virtio-mmio headers

2019-10-18 Thread Sergio Lopez
Put QOM and main struct definition in a separate header file, so it can be accessed from other components. Signed-off-by: Sergio Lopez Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Michael S. Tsirkin --- include/hw/virtio/virtio-mmio.h | 73

[PATCH v11 02/15] hw/i386/pc: rename functions shared with non-PC machines

2019-10-18 Thread Sergio Lopez
_to_props -> x86_cpu_index_to_props pc_get_default_cpu_node_id -> x86_get_default_cpu_node_id pc_possible_cpu_arch_ids -> x86_possible_cpu_arch_ids old_pc_system_rom_init -> x86_system_rom_init Signed-off-by: Sergio Lopez Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathi

[PATCH v11 03/15] hw/i386/pc: fix code style issues on functions that will be moved out

2019-10-18 Thread Sergio Lopez
Fix code style issues detected by checkpatch.pl on functions that will be moved out to x86.c. Signed-off-by: Sergio Lopez Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Marc-André Lureau --- hw/i386/pc.c | 53 1 file changed, 29

[PATCH v11 04/15] hw/i386/pc: replace use of strtol with qemu_strtoui in x86_load_linux()

2019-10-18 Thread Sergio Lopez
Follow checkpatch.pl recommendation and replace the use of strtol with qemu_strtoui in x86_load_linux(). Signed-off-by: Sergio Lopez Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Marc-André Lureau --- hw/i386/pc.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a

[PATCH v11 10/15] fw_cfg: add "modify" functions for all types

2019-10-18 Thread Sergio Lopez
This allows to alter the contents of an already added item. Signed-off-by: Sergio Lopez Reviewed-by: Michael S. Tsirkin Reviewed-by: Marc-André Lureau --- include/hw/nvram/fw_cfg.h | 42 +++ hw/nvram/fw_cfg.c | 29 +++ 2

[PATCH v11 14/15] hw/i386: Introduce the microvm machine type

2019-10-18 Thread Sergio Lopez
since it is optimized for both boot time and footprint. Signed-off-by: Sergio Lopez Reviewed-by: Michael S. Tsirkin --- default-configs/i386-softmmu.mak | 1 + include/hw/i386/microvm.h| 71 hw/i386/microvm.c| 572 +++ hw/i386/Kc

[PATCH v11 05/15] hw/i386/pc: avoid an assignment in if condition in x86_load_linux()

2019-10-18 Thread Sergio Lopez
Follow checkpatch.pl recommendation and avoid an assignment in if condition in x86_load_linux(). Signed-off-by: Sergio Lopez Reviewed-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index

[PATCH v11 07/15] hw/i386/pc: move shared x86 functions to x86.c and export them

2019-10-18 Thread Sergio Lopez
Move x86 functions that will be shared between PC and non-PC machine types to x86.c, along with their helpers. Signed-off-by: Sergio Lopez Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Stefano Garzarella Reviewed-by: Michael S. Tsirkin --- include/hw

[PATCH v11 09/15] hw/i386: make x86.c independent from PCMachineState

2019-10-18 Thread Sergio Lopez
As a last step into splitting PCMachineState and deriving X86MachineState from it, make the functions previously extracted from pc.c to x86.c independent from PCMachineState, using X86MachineState instead. Signed-off-by: Sergio Lopez Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe

[PATCH v11 06/15] hw/i386/pc: remove commented out code from x86_load_linux()

2019-10-18 Thread Sergio Lopez
Follow checkpatch.pl recommendation and remove commented out code from x86_load_linux(). Signed-off-by: Sergio Lopez Reviewed-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 13 - 1 file changed, 13 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 90c2263a33..612bfe9c95

[PATCH v11 08/15] hw/i386: split PCMachineState deriving X86MachineState from it

2019-10-18 Thread Sergio Lopez
Split up PCMachineState and PCMachineClass and derive X86MachineState and X86MachineClass from them. This allows sharing code with non-PC x86 machine types. Signed-off-by: Sergio Lopez Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Michael S. Tsirkin

[PATCH v11 12/15] roms: add microvm-bios (qboot) as binary and git submodule

2019-10-18 Thread Sergio Lopez
ff-by: Sergio Lopez Reviewed-by: Stefano Garzarella Reviewed-by: Michael S. Tsirkin --- .gitmodules | 3 +++ pc-bios/bios-microvm.bin | Bin 0 -> 65536 bytes roms/Makefile| 6 ++ roms/qboot | 1 + 4 files changed, 10 insertions(+) create mode 1

[PATCH v11 13/15] docs/microvm.rst: document the new microvm machine type

2019-10-18 Thread Sergio Lopez
Document the new microvm machine type. Signed-off-by: Sergio Lopez Reviewed-by: Michael S. Tsirkin Reviewed-by: Marc-André Lureau --- docs/microvm.rst | 108 +++ 1 file changed, 108 insertions(+) create mode 100644 docs/microvm.rst diff --git a

[PATCH v11 11/15] hw/intc/apic: reject pic ints if isa_pic == NULL

2019-10-18 Thread Sergio Lopez
In apic_accept_pic_intr(), reject PIC interruptions if a i8259 PIC has not been instantiated (isa_pic == NULL). Suggested-by: Paolo Bonzini Signed-off-by: Sergio Lopez Reviewed-by: Michael S. Tsirkin --- hw/intc/apic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw

[PATCH v11 15/15] MAINTAINERS: add microvm related files

2019-10-18 Thread Sergio Lopez
Add a new "microvm" section under "X86 Machines" with the new files related to this machine type. Signed-off-by: Sergio Lopez Reviewed-by: Michael S. Tsirkin Reviewed-by: Philippe Mathieu-Daudé --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff -

Re: [PATCH 1/5] aio-posix: fix use after leaving scope in aio_poll()

2020-02-18 Thread Sergio Lopez
; --- > util/aio-posix.c | 20 > 1 file changed, 8 insertions(+), 12 deletions(-) Reviewed-by: Sergio Lopez signature.asc Description: PGP signature

Re: [PATCH 2/5] aio-posix: don't pass ns timeout to epoll_wait()

2020-02-19 Thread Sergio Lopez
a value in the wrong > units is still ugly. Pass a 0 timeout to epoll_wait() instead. > > Signed-off-by: Stefan Hajnoczi > --- > util/aio-posix.c | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Sergio Lopez signature.asc Description: PGP signature

Re: [PATCH 3/5] qemu/queue.h: add QLIST_SAFE_REMOVE()

2020-02-19 Thread Sergio Lopez
. > > Signed-off-by: Stefan Hajnoczi > --- > block.c | 5 + > chardev/spice.c | 4 +--- > include/qemu/queue.h | 14 ++ > 3 files changed, 16 insertions(+), 7 deletions(-) Reviewed-by: Sergio Lopez signature.asc Description: PGP signature

Re: [PATCH 4/5] aio-posix: make AioHandler deletion O(1)

2020-02-19 Thread Sergio Lopez
++--- > 3 files changed, 43 insertions(+), 19 deletions(-) Reviewed-by: Sergio Lopez signature.asc Description: PGP signature

Re: [PATCH 5/5] aio-posix: make AioHandler dispatch O(1) with epoll

2020-02-19 Thread Sergio Lopez
++-- > 1 file changed, 76 insertions(+), 30 deletions(-) Reviewed-by: Sergio Lopez signature.asc Description: PGP signature

Re: [PATCH 1/5] i386: conditionally compile more files

2019-12-12 Thread Sergio Lopez
Paolo Bonzini writes: > Signed-off-by: Paolo Bonzini > --- > hw/i386/Makefile.objs | 6 +++--- > hw/i386/kvm/Makefile.objs | 6 +- > 2 files changed, 8 insertions(+), 4 deletions(-) Reviewed-by: Sergio Lopez signature.asc Description: PGP signature

Re: [PATCH 2/5] fw_cfg: allow building without other devices

2019-12-12 Thread Sergio Lopez
c | 7 +++ > hw/i386/pc.c | 2 -- > 2 files changed, 7 insertions(+), 2 deletions(-) Reviewed-by: Sergio Lopez signature.asc Description: PGP signature

Re: [PATCH 3/5] x86: move more functions to X86MachineState and x86.c

2019-12-12 Thread Sergio Lopez
Paolo Bonzini writes: > These are needed by microvm too, so move them outside of PC-specific files. > > Signed-off-by: Paolo Bonzini > --- > hw/i386/pc.c | 99 - > hw/i386/x86.c | 101 > +

Re: [PATCH 4/5] pci-stub: add more MSI functions

2019-12-12 Thread Sergio Lopez
> 1 file changed, 27 insertions(+) Reviewed-by: Sergio Lopez signature.asc Description: PGP signature

Re: [PATCH 5/5] kvm: check before accessing PCMachineState fields

2019-12-12 Thread Sergio Lopez
Paolo Bonzini writes: > Signed-off-by: Paolo Bonzini > --- > roms/SLOF | 2 +- > target/i386/kvm.c | 11 +-- > 2 files changed, 10 insertions(+), 3 deletions(-) > > diff --git a/roms/SLOF b/roms/SLOF > index 8ebf2f5..bcc3c4e 16 > --- a/roms/SLOF > +++ b/roms/SLOF > @@ -1 +

Re: [PATCH] virtio-mmio: Clear v2 transport state on soft reset

2019-12-13 Thread Sergio Lopez
modern (v2) personality > (virtio-1)") > Signed-off-by: Jean-Philippe Brucker > --- > This fixes kexec of a Linux guest that uses the modern virtio-mmio > transport. > --- > hw/virtio/virtio-mmio.c | 14 ++ > 1 file changed, 14 insertions(+) LGTM, thanks! Reviewed-by: Sergio Lopez signature.asc Description: PGP signature

[PATCH v4 0/5] blockdev: avoid acquiring AioContext lock twice at do_drive_backup and do_blockdev_backup

2019-11-21 Thread Sergio Lopez
lease the context at drive_backup_prepare() instead of avoiding re-acquiring it at do_drive_baclup(). (thanks Max Reitz) - Convert a single patch into a two-patch series. --- Sergio Lopez (5): blockdev: fix coding style issues in drive_backup_prepare blockdev: unify qmp_drive_backup and drive-back

[PATCH v4 2/5] blockdev: unify qmp_drive_backup and drive-backup transaction paths

2019-11-21 Thread Sergio Lopez
ser's perspective, as the job gets paused and immediately resumed before starting the actual work. Signed-off-by: Sergio Lopez --- blockdev.c | 224 - 1 file changed, 100 insertions(+), 124 deletions(-) diff --git a/blockdev.c b/blockdev.c index

[PATCH v4 1/5] blockdev: fix coding style issues in drive_backup_prepare

2019-11-21 Thread Sergio Lopez
Fix a couple of minor coding style issues in drive_backup_prepare. Signed-off-by: Sergio Lopez --- blockdev.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/blockdev.c b/blockdev.c index 8e029e9c01..553e315972 100644 --- a/blockdev.c +++ b/blockdev.c @@ -3620,7

[PATCH v4 5/5] iotests: fix 141 after qmp_drive_backup with transactions

2019-11-21 Thread Sergio Lopez
qmp_drive_backup now creates and starts a transactions, which implies that the job will transition to pause and running twice. Fix test 141 to be aware of this change. Signed-off-by: Sergio Lopez --- tests/qemu-iotests/141.out | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/qemu

[PATCH v4 3/5] blockdev: unify qmp_blockdev_backup and blockdev-backup transaction paths

2019-11-21 Thread Sergio Lopez
ge is visible from the user's perspective, as the job gets paused and immediately resumed before starting the actual work. Signed-off-by: Sergio Lopez --- blockdev.c | 60 -- 1 file changed, 13 insertions(+), 47 deletions(-) diff --git a/bl

[PATCH v4 4/5] blockdev: honor bdrv_try_set_aio_context() context requirements

2019-11-21 Thread Sergio Lopez
bdrv_try_set_aio_context() requires that the old context is held, and the new context is not held. Fix all the occurrences where it's not done this way. Suggested-by: Max Reitz Signed-off-by: Sergio Lopez --- blockdev.c | 67 ++ 1

[PATCH v5 0/4] blockdev: avoid acquiring AioContext lock twice at do_drive_backup and do_blockdev_backup

2019-11-28 Thread Sergio Lopez
ments (thanks Max Reitz). - Release the context at drive_backup_prepare() instead of avoiding re-acquiring it at do_drive_baclup(). (thanks Max Reitz) - Convert a single patch into a two-patch series. --- Sergio Lopez (4): blockdev: fix coding style issues in drive_backup_prepa

[PATCH v5 4/4] blockdev: honor bdrv_try_set_aio_context() context requirements

2019-11-28 Thread Sergio Lopez
bdrv_try_set_aio_context() requires that the old context is held, and the new context is not held. Fix all the occurrences where it's not done this way. Suggested-by: Max Reitz Signed-off-by: Sergio Lopez --- blockdev.c | 72 ++ 1

[PATCH v5 2/4] blockdev: unify qmp_drive_backup and drive-backup transaction paths

2019-11-28 Thread Sergio Lopez
ser's perspective, as the job gets paused and immediately resumed before starting the actual work. Also fix tests 141, 185 and 219 to cope with the extra JOB_STATUS_CHANGE lines. Signed-off-by: Sergio Lopez --- blockdev.c | 224 + tests/qemu-iotes

[PATCH v5 1/4] blockdev: fix coding style issues in drive_backup_prepare

2019-11-28 Thread Sergio Lopez
Fix a couple of minor coding style issues in drive_backup_prepare. Signed-off-by: Sergio Lopez Reviewed-by: Max Reitz --- blockdev.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/blockdev.c b/blockdev.c index 8e029e9c01..553e315972 100644 --- a/blockdev.c +++ b

[PATCH v5 3/4] blockdev: unify qmp_blockdev_backup and blockdev-backup transaction paths

2019-11-28 Thread Sergio Lopez
ge is visible from the user's perspective, as the job gets paused and immediately resumed before starting the actual work. Signed-off-by: Sergio Lopez Reviewed-by: Max Reitz --- blockdev.c | 60 -- 1 file changed, 13 insertions(+), 47 deletion

Re: [PATCH v11 00/15] Introduce the microvm machine type

2019-12-02 Thread Sergio Lopez
Markus Armbruster writes: > Sergio Lopez writes: > >> microvm is a machine type inspired by Firecracker and constructed >> after its machine model. >> >> It's a minimalist machine type without PCI nor ACPI support, designed >> for short-lived guests

[Qemu-devel] [RFC] virtio-mmio: implement modern (v2) personality (virtio-1)

2019-07-29 Thread Sergio Lopez
he v2 personality is disabled, keeping the legacy behavior as default. Machine types willing to use v2, can enable it using MachineClass's compat_props. Signed-off-by: Sergio Lopez --- hw/virtio/virtio-mmio.c | 264 ++-- 1 file changed, 254 inserti

Re: [Qemu-devel] [RFC] virtio-mmio: implement modern (v2) personality (virtio-1)

2019-07-31 Thread Sergio Lopez
Andrea Bolognani writes: > On Mon, 2019-07-29 at 14:57 +0200, Sergio Lopez wrote: > [...] >> /* virtio-mmio device */ >> >> static Property virtio_mmio_properties[] = { >> DEFINE_PROP_BOOL("format_transport_address", VirtIOMMIOProxy, >>

Re: [Qemu-devel] [RFC] virtio-mmio: implement modern (v2) personality (virtio-1)

2019-07-31 Thread Sergio Lopez
Michael S. Tsirkin writes: > On Tue, Jul 30, 2019 at 03:14:00PM +0200, Cornelia Huck wrote: >> On Tue, 30 Jul 2019 14:17:48 +0200 >> Andrea Bolognani wrote: >> >> > On Tue, 2019-07-30 at 13:35 +0200, Cornelia Huck wrote: >> > > On Tue, 30 Jul 2019 12:25:30 +0200 >> > > Andrea Bolognani wrote:

Re: [Qemu-devel] [RFC] virtio-mmio: implement modern (v2) personality (virtio-1)

2019-07-31 Thread Sergio Lopez
Michael S. Tsirkin writes: > On Mon, Jul 29, 2019 at 02:57:55PM +0200, Sergio Lopez wrote: >> Implement the modern (v2) personality, according to the VirtIO 1.0 >> specification. >> >> Support for v2 among guests is not as widespread as it'd be >> desira

Re: [Qemu-devel] [RFC] virtio-mmio: implement modern (v2) personality (virtio-1)

2019-08-01 Thread Sergio Lopez
Laszlo Ersek writes: > On 07/29/19 14:57, Sergio Lopez wrote: >> Implement the modern (v2) personality, according to the VirtIO 1.0 >> specification. >> >> Support for v2 among guests is not as widespread as it'd be >> desirable. While the Linux dri

Re: [PATCH-for-6.2] hw/i386/microvm: Reduce annoying debug message in dt_setup_microvm()

2021-11-18 Thread Sergio Lopez
On Wed, Nov 17, 2021 at 06:43:31PM +0100, Philippe Mathieu-Daudé wrote: > Fixes: f5918a99283 ("microvm: add device tree support.") > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/i386/microvm-dt.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-

Re: SEV guest attestation

2021-11-24 Thread Sergio Lopez
On Wed, Nov 24, 2021 at 06:29:07PM +, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > On Wed, Nov 24, 2021 at 11:34:16AM -0500, Tyler Fanelli wrote: > > > Hi, > > > > > > We recently discussed a way for remote SEV guest attestation through QEMU. > > > My i

Re: SEV guest attestation

2021-11-25 Thread Sergio Lopez
On Thu, Nov 25, 2021 at 02:44:51PM +0200, Dov Murik wrote: > [+cc jejb, tobin, jim, hubertus] > > > On 25/11/2021 9:14, Sergio Lopez wrote: > > On Wed, Nov 24, 2021 at 06:29:07PM +, Dr. David Alan Gilbert wrote: > >> * Daniel P. Berrangé (berra...@redhat.com)

Re: [PATCH v3 2/6] ui: add the infrastructure to support MT events

2023-05-09 Thread Sergio Lopez
On Mon, Apr 17, 2023 at 12:57:08PM +0200, Markus Armbruster wrote: > Sergio Lopez writes: > > > Add the required infrastructure to support generating multitouch events. > > > > Signed-off-by: Sergio Lopez > > Reviewed-by: Marc-André Lureau > > --- > >

[PATCH v4 0/6] Implement virtio-multitouch and enable GTK3 to use it

2023-05-09 Thread Sergio Lopez
- Only send SYN_REPORT once, if needed (Marc-André). - Rebase and collect R-b. Sergio Lopez (6): virtio-input: generalize virtio_input_key_config() ui: add the infrastructure to support MT events virtio-input: add a virtio-mulitouch device virtio-input-pci: add virtio-multitouch-pci u

[PATCH v4 2/6] ui: add the infrastructure to support MT events

2023-05-09 Thread Sergio Lopez
Add the required infrastructure to support generating multitouch events. Signed-off-by: Sergio Lopez Reviewed-by: Marc-André Lureau --- include/ui/input.h| 3 +++ qapi/ui.json | 58 --- replay/replay-input.c | 18 ++ ui/input.c

[PATCH v4 3/6] virtio-input: add a virtio-mulitouch device

2023-05-09 Thread Sergio Lopez
any backends. The following patches will add a PCI-based multitouch device, some helpers in "ui" and will enable the GTK3 backend to transpose multi-touch events from the host to the guest. Signed-off-by: Sergio Lopez Reviewed-by: Marc-André Lureau --- hw/input/virtio-input-hid.c

  1   2   3   4   5   6   >