Re: [Qemu-devel] [PATCH for 2.13 1/2] Revert "spapr: Don't allow memory hotplug to memory less nodes"

2018-04-05 Thread Serhii Popovych
Bharata B Rao wrote: > On Thu, Apr 05, 2018 at 10:35:22AM -0400, Serhii Popovych wrote: >> This reverts commit b556854bd8524c26b8be98ab1bfdf0826831e793. >> >> Leave change @node type from uint32_t to to int from reverted commit >> because node < 0 is always fals

[Qemu-devel] [PATCH for 2.13 v2 2/2] Revert "spapr: Don't allow memory hotplug to memory less nodes"

2018-04-10 Thread Serhii Popovych
ous behavour where memory added to first non-empty node. Signed-off-by: Serhii Popovych <spopo...@redhat.com> --- hw/ppc/spapr.c | 22 -- 1 file changed, 22 deletions(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 3f61785..cd7a347 100644 --- a/hw/ppc/spapr.c +++

[Qemu-devel] [PATCH for 2.13 v2 1/2] spapr: Add ibm, max-associativity-domains property

2018-04-10 Thread Serhii Popovych
property for pSeries machines to let guest kernels detect maximum supported node configuration and benefit from kernel side change when hot-add memory to specific, possibly empty before, NUMA node. Signed-off-by: Serhii Popovych <spopo...@redhat.com> --- hw/ppc/spapr.c | 11 +++ 1 f

[Qemu-devel] [PATCH for 2.13 v2 0/2] target/ppc: Support adding memory to initially memory-less NUMA nodes

2018-04-10 Thread Serhii Popovych
t to revert noticing return to previous behaviour for guests without support for hot-add to empty node. - Drop max_cpus from topology in property due to vcpu id discontiguous allocations. Thanks to David Gibson for extra explanation. - Rebase to current state of master branch. Serhii P

[Qemu-devel] [PATCH for 2.13 2/2] spapr: Add ibm, max-associativity-domains property

2018-04-05 Thread Serhii Popovych
property for pSeries machines to let guest kernels detect maximum supported node configuration and benefit from kernel side change when hot-add memory to specific, possibly empty before, NUMA node. Signed-off-by: Serhii Popovych <spopo...@redhat.com> --- hw/ppc/spapr.c | 11 +++ 1 f

[Qemu-devel] [PATCH for 2.13 1/2] Revert "spapr: Don't allow memory hotplug to memory less nodes"

2018-04-05 Thread Serhii Popovych
This reverts commit b556854bd8524c26b8be98ab1bfdf0826831e793. Leave change @node type from uint32_t to to int from reverted commit because node < 0 is always false. Signed-off-by: Serhii Popovych <spopo...@redhat.com> --- hw/ppc/spapr.c | 22 -- 1 file changed, 22

[Qemu-devel] [PATCH for 2.13 0/2] target/ppc: Support adding memory to initially memory-less NUMA nodes

2018-04-05 Thread Serhii Popovych
rt commit b556854bd852 ("spapr: Don't allow memory hotplug to memory less nodes") to remove check for hot-add to memory-less node. See description messges for individual changes for more details. Serhii Popovych (2): Revert "spapr: Don't allow memory hotplug to memory less no

[Qemu-devel] [PATCH for 2.13 v3 0/2] target/ppc: Support adding memory to initially memory-less NUMA nodes

2018-04-11 Thread Serhii Popovych
o previous behaviour for guests without support for hot-add to empty node. - Drop max_cpus from topology in property due to vcpu id discontiguous allocations. Thanks to David Gibson for extra explanation. - Rebase to current state of master branch. Serhii Popovych (2): spapr: Add ibm,max-a

[Qemu-devel] [PATCH for 2.13 v3 2/2] Revert "spapr: Don't allow memory hotplug to memory less nodes"

2018-04-11 Thread Serhii Popovych
ous behavour where memory added to first non-empty node. Signed-off-by: Serhii Popovych <spopo...@redhat.com> --- hw/ppc/spapr.c | 22 -- 1 file changed, 22 deletions(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index c05bbad..1e7983c 100644 --- a/hw/ppc/spapr.c +++

[Qemu-devel] [PATCH for 2.13 v3 1/2] spapr: Add ibm, max-associativity-domains property

2018-04-11 Thread Serhii Popovych
property for pSeries machines to let guest kernels detect maximum supported node configuration and benefit from kernel side change when hot-add memory to specific, possibly empty before, NUMA node. Signed-off-by: Serhii Popovych <spopo...@redhat.com> --- hw/ppc/spapr.c | 10 ++ 1 f

Re: [Qemu-devel] [PATCH for 2.13 v3 1/2] spapr: Add ibm, max-associativity-domains property

2018-04-17 Thread Serhii Popovych
David Gibson wrote: > On Tue, Apr 17, 2018 at 09:28:42AM +0530, Bharata B Rao wrote: >> On Mon, Apr 16, 2018 at 07:47:29PM +0300, Serhii Popovych wrote: >>> Bharata B Rao wrote: >>>> On Wed, Apr 11, 2018 at 02:41:59PM -0400, Serhii Popovych wrote: >>>>>

[Qemu-devel] [PATCH for 2.13] spapr: Correct max associativity domains value for non-NUMA configs

2018-04-17 Thread Serhii Popovych
for non-NUMA guests. Fixes: c1df49a670ef ("spapr: Add ibm,max-associativity-domains property") Signed-off-by: Serhii Popovych <spopo...@redhat.com> --- hw/ppc/spapr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 7b2bc4e

Re: [Qemu-devel] [PATCH for 2.13 v3 1/2] spapr: Add ibm, max-associativity-domains property

2018-04-16 Thread Serhii Popovych
Bharata B Rao wrote: > On Wed, Apr 11, 2018 at 02:41:59PM -0400, Serhii Popovych wrote: >> Now recent kernels (i.e. since linux-stable commit a346137e9142 >> ("powerpc/numa: Use ibm,max-associativity-domains to discover possible >> nodes") >> support this p

Re: [Qemu-devel] [Qemu-ppc] [PATCH for 3.1] spapr: Fix ibm, max-associativity-domains property number of nodes

2018-11-20 Thread Serhii Popovych
Greg Kurz wrote: > On Mon, 19 Nov 2018 14:48:34 +0100 > Laurent Vivier wrote: > >> On 19/11/2018 14:27, Greg Kurz wrote: >>> On Mon, 19 Nov 2018 08:09:38 -0500 >>> Serhii Popovych wrote: >>> >>>> Laurent Vivier reported off by one with

[Qemu-devel] [PATCH for 3.1 v3] spapr: Fix ibm, max-associativity-domains property number of nodes

2018-11-22 Thread Serhii Popovych
ven though the guest can handle it, I'd prefer we put a '1' here for both the nb_numa_nodes == 0 and nb_numa_nodes == 1 case. This consolidates everything discussed previously on mailing list. Fixes: da9f80fbad21 ("spapr: Add ibm,max-associativity-domains property") Reported-by: Lau

Re: [Qemu-devel] [Qemu-ppc] [PATCH for 3.1] spapr: Fix ibm, max-associativity-domains property number of nodes

2018-11-19 Thread Serhii Popovych
Laurent Vivier wrote: > On 19/11/2018 14:27, Greg Kurz wrote: >> On Mon, 19 Nov 2018 08:09:38 -0500 >> Serhii Popovych wrote: >> >>> Laurent Vivier reported off by one with maximum number of NUMA nodes >>> provided by qemu-kvm being less by one than requir

[Qemu-devel] [PATCH for 3.1 v2] spapr: Fix ibm, max-associativity-domains property number of nodes

2018-11-19 Thread Serhii Popovych
;spapr: Add ibm,max-associativity-domains property") Reported-by: Laurent Vivier Signed-off-by: Serhii Popovych --- v2 Remove now unneeded ?: statement previously used to catch -1 as numa node causing Linux guests hanging on boot. hw/ppc/spapr.c | 2 +- 1 file changed, 1 insertion(+),

[Qemu-devel] [PATCH for 3.1] spapr: Fix ibm, max-associativity-domains property number of nodes

2018-11-19 Thread Serhii Popovych
;spapr: Add ibm,max-associativity-domains property") Reported-by: Laurent Vivier Signed-off-by: Serhii Popovych --- hw/ppc/spapr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 7afd1a1..843ae6c 100644 --- a/hw/ppc/spapr.c +++ b/hw/pp