Glib2 uses __printf__ in macro G_GNUC_PRINTF for printf like
functions. For MinGW, we want __gnu_printf__ because we use
POSIX format specifiers instead of the MS format specifiers.
Signed-off-by: Stefan Weil
---
configure |2 ++
1 file changed, 2 insertions(+)
diff --git a/configure b
One more...
Signed-off-by: Stefan Weil
---
scripts/simpletrace.py |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/simpletrace.py b/scripts/simpletrace.py
index 1e74e75..9fce4bb 100755
--- a/scripts/simpletrace.py
+++ b/scripts/simpletrace.py
@@ -71,7 +71,7 @@ def
It's still not good, but hopefully better than before.
Signed-off-by: Stefan Weil
---
ui/vnc-enc-zywrle.h |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ui/vnc-enc-zywrle.h b/ui/vnc-enc-zywrle.h
index 188e247..addee55 100644
--- a/ui/vnc-enc-zywrle.h
+++ b/ui/vn
Signed-off-by: Stefan Weil
---
docs/bootindex.txt |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/bootindex.txt b/docs/bootindex.txt
index 16083b3..803ebfc 100644
--- a/docs/bootindex.txt
+++ b/docs/bootindex.txt
@@ -1,4 +1,4 @@
-= Bootindex propery =
+= Bootindex
Signed-off-by: Stefan Weil
---
hw/versatilepb.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/versatilepb.c b/hw/versatilepb.c
index 4fd5d9b..7a92034 100644
--- a/hw/versatilepb.c
+++ b/hw/versatilepb.c
@@ -162,7 +162,7 @@ static int vpb_sic_init(SysBusDevice *dev
The patch also fixes the case of "written".
Signed-off-by: Stefan Weil
---
hw/imx_avic.c |4 ++--
hw/imx_timer.c |4 ++--
hw/kzm.c |2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/imx_avic.c b/hw/imx_avic.c
index 4f010e8..b1a8fe6 10064
These wrong spellings were detected by codespell:
* successully -> successfully
* alot -> a lot
* wanna -> want to
* infomation -> information
* occured -> occurred
Signed-off-by: Stefan Weil
---
docs/specs/ppc-spapr-hcalls.txt |2 +-
docs/usb2.txt
QEMU_PACKED results in a MinGW compiler warning when it is
used for single structure elements:
warning: 'gcc_struct' attribute ignored
Using QEMU_PACKED for the whole structure avoids the compiler warning
without changing the memory layout.
Signed-off-by: Stefan Weil
---
hw/sr
Am 11.08.2012 16:42, schrieb Blue Swirl:
On Fri, Aug 10, 2012 at 7:45 PM, Stefan Weil wrote:
Glib2 uses __printf__ in macro G_GNUC_PRINTF for printf like
functions. For MinGW, we want __gnu_printf__ because we use
POSIX format specifiers instead of the MS format specifiers.
I get these
Am 07.08.2012 13:17, schrieb Paolo Bonzini:
This patch series is part 2 in my EventNotifier/AIO improvements
for QEMU 1.2. It extends use of EventNotifier to the main loop
and AIO subsystems. A new API using EventNotifier is added to aio.c
and a new portable thread pool is introduced (based on
Signed-off-by: Stefan Weil
---
hw/framebuffer.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/framebuffer.c b/hw/framebuffer.c
index f4747cd..85a00a5 100644
--- a/hw/framebuffer.c
+++ b/hw/framebuffer.c
@@ -28,7 +28,7 @@ void framebuffer_update_display
Am 12.08.2012 00:03, schrieb Anthony Liguori:
Peter Maydell writes:
On 18 July 2012 10:28, Peter Maydell wrote:
On 12 March 2012 20:12, Stefan Weil wrote:
We also need more resources for technical maintenance of the
QEMU infrastructure. For example, the official mirror of the
QEMU git
memory_region_init(&dev->msix_exclusive_bar, name,
MSIX_EXCLUSIVE_BAR_SIZE);
-
-free(name);
+g_free(name);
ret = msix_init(dev, nentries, &dev->msix_exclusive_bar, bar_nr,
MSIX_EXCLUSIVE_BAR_TABLE_OFFSET, &dev->msix_exclusive_bar,
Reviewed-by: Stefan Weil
Am 11.08.2012 21:27, schrieb Stefan Weil:
Am 07.08.2012 13:17, schrieb Paolo Bonzini:
This patch series is part 2 in my EventNotifier/AIO improvements
for QEMU 1.2. It extends use of EventNotifier to the main loop
and AIO subsystems. A new API using EventNotifier is added to aio.c
and a new
asprintf is not available for all hosts. g_strdup_printf is
more portable and simplifies the code because if does not
need error handling.
The static variable does not need an explicit assignment to be NULL.
Cc: Stefan Hajnoczi
Signed-off-by: Stefan Weil
---
trace/simple.c | 14
gcc complains when a 32 bit pointer is casted to a 64 bit integer.
Cc: Stefan Hajnoczi
Signed-off-by: Stefan Weil
---
scripts/tracetool/backend/simple.py |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/scripts/tracetool/backend/simple.py
b/scripts/tracetool/backend
reference to
`_qmp_query_cpu_definitions'
Weak symbols obviously use a different name mangling, therefore
qmp_query_cpu_definitions
is not found by the linker.
Adding GCC_WEAK to the declaration of qmp_query_cpu_definitions in
generated file
qmp-commands.h fixes that.
Regards,
Stefan Weil
Am 15.08.2012 16:16, schrieb Stefan Hajnoczi:
On Fri, Aug 10, 2012 at 10:03:27PM +0200, Stefan Weil wrote:
QEMU_PACKED results in a MinGW compiler warning when it is
used for single structure elements:
warning: 'gcc_struct' attribute ignored
Using QEMU_PACKED for the whole struct
mips_r4k_init,
+.no_floppy = 1,
+.no_sdcard = 1,
};
static void mips_machine_init(void)
Reviewed-by: Stefan Weil
I'd prefer using 'true' instead of '1' (and changing the
variables to type bool), but that can be done later.
Regards,
Stefan W.
Am 15.08.2012 18:53, schrieb Luiz Capitulino:
On Wed, 15 Aug 2012 08:07:57 +0200
Stefan Weil wrote:
Am 13.08.2012 19:16, schrieb Luiz Capitulino:
On Fri, 10 Aug 2012 11:04:08 -0500
Anthony Liguori wrote:
This series implements the necessary commands to implements danpb's idea to
r
ld O_DSYNC be a good replacement here for an
undefined O_DIRECT? block/raw-posix.c does it like that.
What about defining O_NOATIME and O_DIRECT in qemu-common.h
when needed (like it is done for O_BINARY)?
But I don't want to delay 1.2, therefore
Reviewed-by: Stefan Weil
Regards,
Stefan W.
Ping?
Am 10.08.2012 22:03, schrieb Stefan Weil:
The patch also fixes the case of "written".
Signed-off-by: Stefan Weil
---
hw/imx_avic.c |4 ++--
hw/imx_timer.c |4 ++--
hw/kzm.c |2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/imx_a
Ping?
Am 10.08.2012 22:03, schrieb Stefan Weil:
These wrong spellings were detected by codespell:
* successully -> successfully
* alot -> a lot
* wanna -> want to
* infomation -> information
* occured -> occurred
Signed-off-by: Stefan Weil
---
docs/specs/ppc-spapr-hc
Macro XEN_HOST_PCI_RESOURCE_BUFFER_SIZE is only used locally,
so the change should be safe.
Signed-off-by: Stefan Weil
---
hw/xen-host-pci-device.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/xen-host-pci-device.c b/hw/xen-host-pci-device.c
index e7ff680
The function is called interface_release_resource.
Signed-off-by: Stefan Weil
---
ui/spice-display.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/spice-display.c b/ui/spice-display.c
index 3e8f0b3..277843c 100644
--- a/ui/spice-display.c
+++ b/ui/spice-display.c
also avoids calling function write with 0 bytes of data.
Signed-off-by: Stefan Weil
---
block/vdi.c | 25 -
1 file changed, 12 insertions(+), 13 deletions(-)
diff --git a/block/vdi.c b/block/vdi.c
index c4f1529..d80114a 100644
--- a/block/vdi.c
+++ b/block/vdi.c
@@ -628,7
-by: Stefan Weil
---
monitor.c |7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/monitor.c b/monitor.c
index 0c34934..0ea2c14 100644
--- a/monitor.c
+++ b/monitor.c
@@ -3524,12 +3524,13 @@ static int64_t expr_prod(Monitor *mon)
break;
case
l of your patches are still missing in QEMU git master.
As some of them fix real or potential bugs, they should be applied
(if possible to QEMU 1.2 which will be released soon).
The usual way to remind people of missing patches is to send
a reply mail with "ping". CC'ing Anthony Liguori also helps.
Regards,
Stefan Weil
-by: Stefan Weil
---
Please note that I don't have a test case which triggers the crash.
Regards,
Stefan Weil
console.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/console.c b/console.c
index 4525cc7..f5e8814 100644
--- a/console.c
+++ b/console.c
@@ -1087,7 +1087,7
int mon_fd_flags;
-#ifndef _WIN32
QLIST_FOREACH(mon_fdset, &mon_fdsets, next) {
if (mon_fdset->id != fdset_id) {
continue;
Reviewed-by: Stefan Weil
Am 17.08.2012 17:02, schrieb Luiz Capitulino:
On Fri, 17 Aug 2012 16:41:34 +0200
Markus Armbruster wrote:
Luiz Capitulino writes:
On Fri, 17 Aug 2012 16:10:12 +0200
Markus Armbruster wrote:
Stefan Weil writes:
ccc-analyzer reports these warnings:
monitor.c:3532:21: warning: Division
==by 0x29E85B: net_init_clients (net.c:1008)
==24534==by 0x296F40: main (vl.c:3463)
Signed-off-by: Stefan Weil
---
qapi/opts-visitor.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/qapi/opts-visitor.c b/qapi/opts-visitor.c
index a59d306..e048b6c 100644
--- a/qapi
Am 18.08.2012 22:51, schrieb Stefan Weil:
valgrind report:
==24534== 232 bytes in 2 blocks are definitely lost in loss record 1,245 of
1,601
==24534==at 0x4824F20: malloc (vg_replace_malloc.c:236)
==24534==by 0x293C88: malloc_and_trace (vl.c:2281)
==24534==by 0x489AD99: ??? (in
Am 20.08.2012 01:39, schrieb Igor Mammedov:
it's necessary for making CPU child of DEVICE without
causing circular header deps.
Signed-off-by: Igor Mammedov
---
hw/arm-misc.h |1 +
hw/bt.h |2 ++
hw/devices.h |2 ++
hw/irq.h |2 ++
hw/omap.h |1 +
hw/s
This allows using qemu_irq in the target specific cpu.h.
Signed-off-by: Stefan Weil
---
qemu-common.h |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/qemu-common.h b/qemu-common.h
index 74a99d3..88a515e 100644
--- a/qemu-common.h
+++ b/qemu-common.h
@@ -19,6 +19,8
with config.h (optionally)
and qemu-common.h.
* Don't include standard include files which are already
included in qemu-common.h
* Don't include qemu-common.h in *.h files.
Regards,
Stefan Weil
Am 20.08.2012 13:47, schrieb Igor Mammedov:
On Mon, 20 Aug 2012 06:52:51 +0200
Stefan Weil wrote:
I'd prefer if you could keep the following simple pattern:
* Start includes in *.c files with config.h (optionally)
and qemu-common.h.
Can't agree with you on this. I'd say th
Am 22.08.2012 17:32, schrieb Jan Kiszka:
On 2012-08-22 17:19, BALATON Zoltan wrote:
Division with round up is the correct way to compute this even if the
only case where division with round down gives incorrect result is
probably 15 bpp. This case was explicitely patched up in one of these
funct
arguments for format
[-Wformat-extra-args]
Signed-off-by: Stefan Weil
---
compiler.h |5 +
1 file changed, 5 insertions(+)
diff --git a/compiler.h b/compiler.h
index 07ba1f8..c734a71 100644
--- a/compiler.h
+++ b/compiler.h
@@ -44,6 +44,11 @@
/* Use gnu_printf when supported (qemu
Am 04.03.2012 08:21, schrieb Stefan Weil:
Commits b5dc7732e1cc2fb549e48b7b5d664f2c79628e2e and
be24bb4f3007c3e07cbf1934f7e781493d876ab7 optimized the code
and removed the correct setting of t0. Fix this.
gcc-4.7 detected this bug because parameter arg1 was unused
but set in set_HIT0_LO and
.
Signed-off-by: Stefan Weil
---
hw/megasas.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/megasas.c b/hw/megasas.c
index c35a15d..f2d6783 100644
--- a/hw/megasas.c
+++ b/hw/megasas.c
@@ -698,8 +698,8 @@ static int megasas_ctrl_get_info(MegasasState *s,
MegasasCmd
Clang reports this warning:
Null pointer passed as an argument to a 'nonnull' parameter
Signed-off-by: Stefan Weil
---
qemu-ga.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/qemu-ga.c b/qemu-ga.c
index 26671fe..7623079 100644
--- a/qemu-ga.c
+++ b
Am 24.08.2012 13:56, schrieb Stefan Hajnoczi:
On Fri, Aug 24, 2012 at 12:06 PM, Peter Maydell
wrote:
On 24 August 2012 11:54, Stefan Hajnoczi wrote:
On Mon, Aug 20, 2012 at 06:45:00AM +0200, Stefan Weil wrote:
This allows using qemu_irq in the target specific cpu.h.
Signed-off-by: Stefan
return s->raw_pallette[(offset - 0x200) >> 2];
+return s->raw_palette[(offset - 0x200) >> 2];
}
switch (offset >> 2) {
case 0: /* LCDTiming0 */
@@ -366,8 +366,8 @@ static void pl110_write(void *opaque, target_phys_addr_t
offset,
if
Am 23.01.2012 19:38, schrieb Jan Kiszka:
Forking an expr process for every byte of the input data slows down the
checksum calculation massively. Fix this while still remaining portable
by implementing the algorithm in awk.
Signed-off-by: Jan Kiszka
---
That "remaining portable" is an unproven c
Am 23.01.2012 20:19, schrieb Jan Kiszka:
On 2012-01-23 20:16, Stefan Weil wrote:
Am 23.01.2012 19:38, schrieb Jan Kiszka:
[snip]
What about replacing the whole script by a python script?
That would save about 6 more forks :-)
I think we have no python dependency in the build system yet
On 01/23/2012 02:32 PM, Jan Kiszka wrote:
On 2012-01-23 21:08, Anthony Liguori wrote:
I've been thinking that we could potentially rewrite a large chunk
(all?) of configure in python too since we have such a hard
dependency now.
[snip]
However, I will now write signrom.py. That's much shorte
Am 24.01.2012 08:22, schrieb Andreas Färber:
Am 23.01.2012 08:20, schrieb Peter A. G. Crosthwaite:
Added linux specific kernel dtb option. This option can be specified
to inject
an argument device tree blob (dtb) into linux.
Signed-off-by: Peter A. G. Crosthwaite
---
qemu-options.hx | 3 +++
v
Am 24.01.2012 16:25, schrieb Jan Kiszka:
On 2012-01-24 16:22, Eric Blake wrote:
On 01/24/2012 01:53 AM, Jan Kiszka wrote:
Now that we have a hard dependency on python anyway, we can replace the
slow shell script to calculate the option ROM checksum with a fast AND
portable python version. Teste
Am 25.10.2011 16:34, schrieb Dor Laor:
On 10/18/2011 03:03 PM, Anthony Liguori wrote:
Okay, let's get serious about it. I set up the following wiki page for
coordination:
http://wiki.qemu.org/Relicensing
Please get the appropriate approval at Red Hat, and follow the
ACK for *@redhat.com
in
Am 27.01.2012 13:47, schrieb Anthony Liguori:
On 01/27/2012 03:14 AM, Michael Tokarev wrote:
The amount of spam our wiki.qemu.org collects, is
increasing every day. It was easy several months
ago to manually delete these pages once a week to
keep wiki spam-free, now they sometimes manage to
re-
me.
Thanks,
/mjt
http://www.mediawiki.org/wiki/Special:Version shows the extensions
used by Mediawiki. Look for "Spam prevention" - there are lots of
extensions installed there for that purpose.
Cheers,
Stefan Weil
Am 27.01.2012 13:47, schrieb Anthony Liguori:
On 01/27/2012 03:14 AM, Michael Tokarev wrote:
The amount of spam our wiki.qemu.org collects, is
increasing every day. It was easy several months
ago to manually delete these pages once a week to
keep wiki spam-free, now they sometimes manage to
re-
This file only contains code from Red Hat, so it can use GPLv2+.
Tested with `git blame -M -C net/checksum.c`.
Signed-off-by: Stefan Weil
---
net/checksum.c |5 +
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/net/checksum.c b/net/checksum.c
index 264c23f..9919b2e 100644
includes BSD and Linux host systems.
* LINUX is a special case of POSIX needed for some Linux specific
files and directories.
* W32, W64 for a well known family of closed source operating systems.
I also added myself as a maintainer for W32, W64.
Signed-off-by: Stefan Weil
---
MAINTAINERS
n32_start_routine,
data, 0, &thread->tid);
Tested-by: Stefan Weil
Hi Bogdan,
I can confirm that your patch fixes a crash which otherwise makes
QEMU unusable on Windows hosts.
Could you please sign your patch with a Signed-off-by line including
yo
Here are some Malta patches from my local repository.
The first three patches try to clean the code for the flash based
BIOS memory. I wrote them because my local Malta test environment
runs the Malta emulation with a -kernel parameter, and testing of
flash code was not possible.
Patch 4 is inde
There is no reason why there should not be a flash memory when the
Malta emulation is started with a Linux kernel. When flash memory
is always available, the code is simpler, and it can be better tested.
Signed-off-by: Stefan Weil
---
hw/mips_malta.c | 54
The 8-LED array was already implemented in the first commit to Malta,
but this implementation was incomplete.
Signed-off-by: Stefan Weil
---
hw/mips_malta.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/mips_malta.c b/hw/mips_malta.c
index ce25690..90cfc9b 100644
It is sufficient to define the region alias once for all code branches.
Signed-off-by: Stefan Weil
---
hw/mips_malta.c | 21 ++---
1 files changed, 6 insertions(+), 15 deletions(-)
diff --git a/hw/mips_malta.c b/hw/mips_malta.c
index 64603ce..7586971 100644
--- a/hw
extension here.
Signed-off-by: Stefan Weil
---
hw/mips_malta.c | 19 +--
1 files changed, 13 insertions(+), 6 deletions(-)
diff --git a/hw/mips_malta.c b/hw/mips_malta.c
index e874efe..ce25690 100644
--- a/hw/mips_malta.c
+++ b/hw/mips_malta.c
@@ -55,6 +55,13 @@
#define
The parameters initrd_size and base are already included
in the info parameter, so there is no need to pass them
separately.
Signed-off-by: Stefan Weil
---
hw/arm_boot.c | 17 -
1 files changed, 8 insertions(+), 9 deletions(-)
diff --git a/hw/arm_boot.c b/hw/arm_boot.c
index
This patch was contributed by Bogdan Harjoc. I added some assertions.
Signed-off-by: Stefan Weil
---
qemu-thread-win32.c |9 +++--
1 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/qemu-thread-win32.c b/qemu-thread-win32.c
index fe9b931..3524c8b 100644
--- a/qemu-thread
Am 31.01.2012 15:48, schrieb Kevin Wolf:
Am 31.01.2012 15:40, schrieb Peter Maydell:
On 31 January 2012 13:35, Kevin Wolf wrote:
Am 27.01.2012 18:53, schrieb Stefan Weil:
+Hosts:
+--
+
+LINUX
+L: qemu-devel@nongnu.org
+S: Maintained
+F: linux-*
+F: linux-headers/
+
+POSIX
+L: qemu-devel
ch should pass checkpatch.pl (I think it did not because
of several violations of the QEMU coding style).
Unmodified existing code should not raise warnings from checkpatch.pl.
Regards,
Stefan Weil
Am 01.02.2012 23:16, schrieb Kenneth Salerno:
Another strange problem I've been having with newer builds from Git
lately is I can only execute qemu-system-*.exe correctly from within
gdb (i.e. "/usr/bin/gdb.exe ./i386-softmmu/qemu-system-i386.exe;
gdb>run -L ./pc-bios"). If I run qemu-system-*.
This is fixed with http://patchwork.ozlabs.org/patch/138690/.
** Changed in: qemu
Status: New => Fix Committed
** Changed in: qemu
Assignee: (unassigned) => Stefan Weil (ubuntu-weilnetz)
--
You received this bug notification because you are a member of qemu-
devel-ml, wh
Commit c3febae62b646b5bc7aa88b7cffa88160162a94e fixed this problem.
** Changed in: qemu
Status: New => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/589564
Title:
Windows host
Hi,
here are some w32 related patches which were already published
and reviewed on qemu-devel:
http://patchwork.ozlabs.org/patch/132797/
http://patchwork.ozlabs.org/patch/138690/
Regards,
Stefan Weil
The following changes since commit d34e8f6e9d3a396c3327aa9807c83f9e1f4a7bd7:
main-loop
The change in cpu.h is needed when HOST_LONG_BITS is defined in qemu-common.h.
Cc: Richard Henderson
Signed-off-by: Stefan Weil
---
target-alpha/cpu.h |1 +
target-alpha/translate.c |5 -
2 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/target-alpha/cpu.h b
Like the related macro TCG_TARGET_LONG, HOST_LONG_BITS can be determined
by the C preprocessor. It is also not used in Makefiles.
So there is no need to calculate it in configure, and it can be defined
in qemu-common.h.
Signed-off-by: Stefan Weil
---
configure | 12
qemu
Remove some include statements which are not needed.
Cc: Aurelien Jarno
Signed-off-by: Stefan Weil
---
target-mips/translate.c |7 ---
1 files changed, 0 insertions(+), 7 deletions(-)
diff --git a/target-mips/translate.c b/target-mips/translate.c
index d5b1c76..8361d88 100644
--- a
Remove some include statements which are not needed.
Signed-off-by: Stefan Weil
---
target-i386/helper.c|6 --
target-i386/op_helper.c |1 -
2 files changed, 0 insertions(+), 7 deletions(-)
diff --git a/target-i386/helper.c b/target-i386/helper.c
index 2586aff..87c6a8f 100644
The change in cpu.h is needed when HOST_LONG_BITS is defined in qemu-common.h.
Signed-off-by: Stefan Weil
---
target-s390x/cpu.h |3 +++
target-s390x/helper.c|5 -
target-s390x/translate.c |5 -
3 files changed, 3 insertions(+), 10 deletions(-)
diff --git a/target
Remove some include statements which are not needed.
Cc: Max Filippov
Signed-off-by: Stefan Weil
---
target-xtensa/core-dc232b.c |1 -
target-xtensa/core-fsf.c|1 -
target-xtensa/helper.c |1 -
3 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/target-xtensa
Remove some include statements which are not needed.
Cc: Alexander Graf
Signed-off-by: Stefan Weil
---
target-ppc/helper.c|6 --
target-ppc/translate.c |6 --
2 files changed, 0 insertions(+), 12 deletions(-)
diff --git a/target-ppc/helper.c b/target-ppc/helper.c
index
The change in cpu.h is needed when HOST_LONG_BITS is defined in qemu-common.h.
Signed-off-by: Stefan Weil
---
target-microblaze/cpu.h |3 +++
target-microblaze/helper.c|5 -
target-microblaze/mmu.c |4
target-microblaze/translate.c |8
4 files
The change in cpu.h is needed when HOST_LONG_BITS is defined in qemu-common.h.
Signed-off-by: Stefan Weil
---
target-unicore32/cpu.h|2 ++
target-unicore32/helper.c |4
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/target-unicore32/cpu.h b/target-unicore32
The change in cpu.h is needed when HOST_LONG_BITS is defined in qemu-common.h.
Cc: Edgar E. Iglesias
Signed-off-by: Stefan Weil
---
target-cris/cpu.h |3 +++
target-cris/helper.c|4
target-cris/mmu.c |5 -
target-cris/translate.c |7 ---
4 files
config.h was missing in cpu.h.
Cc: Michael Walle
Signed-off-by: Stefan Weil
---
target-lm32/cpu.h |1 +
target-lm32/helper.c|5 -
target-lm32/translate.c |8
3 files changed, 1 insertions(+), 13 deletions(-)
diff --git a/target-lm32/cpu.h b/target-lm32/cpu.h
Remove some include statements which are not needed.
Cc: Aurelien Jarno
Signed-off-by: Stefan Weil
---
target-sh4/translate.c |6 --
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/target-sh4/translate.c b/target-sh4/translate.c
index aacf96d..dd0ee4b 100644
--- a/target
config.h was missing in cpu.h.
Signed-off-by: Stefan Weil
---
target-m68k/cpu.h |1 +
target-m68k/helper.c|5 -
target-m68k/translate.c |6 --
3 files changed, 1 insertions(+), 11 deletions(-)
diff --git a/target-m68k/cpu.h b/target-m68k/cpu.h
index 0667f82
HOST_LONG_SIZE is simply the size of a pointer value.
There is no need for this macro.
Signed-off-by: Stefan Weil
---
cpu-defs.h |2 --
thunk.h|4 ++--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/cpu-defs.h b/cpu-defs.h
index 57a709b..4527cbf 100644
--- a/cpu
they are already in qemu-common.h
This also avoids potential errors when qemu-common.h is included without
a preceding config.h. Future code changes should be easier as soon as all
targets use a uniform include scheme.
The last patch finally achieves my initial goal.
Regards,
Stefan Weil
Remove some include statements which are not needed.
Cc: Peter Maydell
Signed-off-by: Stefan Weil
---
target-arm/helper.c |5 -
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/target-arm/helper.c b/target-arm/helper.c
index ea4f35f..e9e2a27 100644
--- a/target-arm
Am 02.02.2012 22:26, schrieb Alexander Graf:
On 02.02.2012, at 22:12, Stefan Weil wrote:
Remove some include statements which are not needed.
Are these redundant or do they just happen to be unnecessary because
of unused debug #ifdefs?
Alex
They are redundant because cpu.h includes
BRIDGE.
Signed-off-by: Stefan Weil
---
Was the .name = "helper" intentional? That name is rather unspecific.
Regards,
Stefan Weil
net.c | 19 ---
1 files changed, 16 insertions(+), 3 deletions(-)
diff --git a/net.c b/net.c
index 1944539..c34474f 100644
--- a/n
rough your net bridge helper series. Can you send a
patch for this? Stefan Weil may be able to help you figure out what's
needed here for win32.
Regards,
Anthony Liguori
Hi,
removing the bridge code for hosts which don't support it (quote from
Corey's commit: "this
Most MemoryRegionOps already had the const attribute.
This patch adds it to the remaining ones.
Signed-off-by: Stefan Weil
---
hw/cuda.c |2 +-
hw/ide/ahci.c |4 ++--
hw/ide/cmd646.c|6 +++---
hw/ide/macio.c |2 +-
hw/ide/piix.c |2 +-
hw/ide/via.c
@@ static int configure_accelerator(void)
const char *p = NULL;
char buf[10];
int i, ret;
-bool accel_initalised = 0;
+bool accel_initialised = 0;
bool init_failed = 0;
Reviewed-by: Stefan Weil
Fix a typo in a local function name.
Signed-off-by: Stefan Weil
---
hw/fmopl.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/fmopl.c b/hw/fmopl.c
index 734d2f4..f0a0234 100644
--- a/hw/fmopl.c
+++ b/hw/fmopl.c
@@ -733,7 +733,7 @@ INLINE void CSMKeyControll
Am 07.02.2012 19:22, schrieb malc:
This is a 32bit machine, the target is i386-softmmu, yet,
libhw32 is mostly empty and libhw64 is populated, furthermore[1]:
$ rm libhw64/ac97.o
$ make V=1
make BUILD_DIR=/home/malc/x/bld/qemu/master -C libhw64 V="1"
TARGET_DIR="libhw64/" all
make[1]: Entering
Makefile, Makefile.hw, Makefile.target and libcacard/Makefile
added GLIB_CFLAGS to QEMU_CFLAGS.
Makefile.objs does this, too, and is included by all other
Makefiles, so GLIB_CFLAGS were added twice (reported by malc).
Signed-off-by: Stefan Weil
---
Makefile |2 --
Makefile.hw
Am 10.02.2012 16:13, schrieb Zhi Yong Wu:
On Fri, Feb 10, 2012 at 10:41 PM, Daniel P. Berrange
wrote:
On Fri, Feb 10, 2012 at 10:34:13PM +0800, Zhi Yong Wu wrote:
From: Zhi Yong Wu
Signed-off-by: Zhi Yong Wu
---
oslib-posix.c |4 ++--
oslib-win32.c |4 ++--
2 files changed, 4 inser
The standard include files are already included in qemu-common.h.
malloc.h and alloca.h were needed for alloca() which was removed
from TCG code some years ago when switching from dyngen to TCG
(see commit 49516bc0d622112caac9df628caf19010fda8b67).
Signed-off-by: Stefan Weil
---
tcg/tcg.c
Am 13.02.2012 03:37, schrieb Zhi Yong Wu:
On Fri, Feb 10, 2012 at 11:53 PM, Stefan Weil wrote:
Am 10.02.2012 16:13, schrieb Zhi Yong Wu:
On Fri, Feb 10, 2012 at 10:41 PM, Daniel P. Berrange
wrote:
On Fri, Feb 10, 2012 at 10:34:13PM +0800, Zhi Yong Wu wrote:
From: Zhi Yong Wu
Signed
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/922131
Title:
QEMU v1.0-788-g3316364 crashes in win32 native environment
Status in QE
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/826363
Title:
qemu-img convert does not work with vdi files
Status in QEMU:
Fix Rel
}"
Hi,
this would be a workaround for a bug in glib-2.0.
If it requires ole32.dll, it should add it to glib-2.0.pc,
so pkg-config will add it to QEMU.
I never had problems caused by a missing ole32.dll.
Which MinGW do you use (native, cross, version),
and where did you get your glib-2.0 from? My
glib-2.0 has no reference to CoTaskMemFree.
Regards,
Stefan Weil
Am 15.02.2012 15:34, schrieb Anthony Liguori:
Please respond to this note with an '+1', or an Ack, to vote for this
icon.
+1 (if the license for this logo is compatible with QEMU)
1 - 100 of 4008 matches
Mail list logo
