Re: [Qemu-devel] [PATCH v15 23/26] sched: early boot clock

Pavel has a new email address, cc'd - steve On 11/6/2018 12:42 AM, Dominique Martinet wrote: > (added various kvm/virtualization lists in Cc as well as qemu as I don't > know who's "wrong" here) > > Pavel Tatashin wrote on Thu, Jul 19, 2018: >> Allow sched_clock() to be used before

Re: [PATCH V1 18/32] osdep: import MADV_DOEXEC

On 8/24/2020 6:30 PM, Alex Williamson wrote: > On Wed, 19 Aug 2020 17:52:26 -0400 > Steven Sistare wrote: >> On 8/17/2020 10:42 PM, Alex Williamson wrote: >>> On Mon, 17 Aug 2020 15:44:03 -0600 >>> Alex Williamson wrote: >>>> On Mon, 17 Aug 2020

Re: [PATCH V1 18/32] osdep: import MADV_DOEXEC

On 10/15/2020 4:36 PM, Alex Williamson wrote: > On Thu, 8 Oct 2020 12:32:35 -0400 > Steven Sistare wrote: >> On 8/24/2020 6:30 PM, Alex Williamson wrote: >>> On Wed, 19 Aug 2020 17:52:26 -0400 >>> Steven Sistare wrote: >>>> On 8/17/2020 10:42 PM, Ale

Re: [PATCH V1 30/32] vfio-pci: save and restore

On 8/20/2020 6:33 AM, Jason Zeng wrote: > On Wed, Aug 19, 2020 at 05:15:11PM -0400, Steven Sistare wrote: >> On 8/9/2020 11:50 PM, Jason Zeng wrote: >>> On Fri, Aug 07, 2020 at 04:38:12PM -0400, Steven Sistare wrote: >>>> On 8/6/2020 6:22 AM, Jason Zeng wrote: >

Re: [PATCH V1 18/32] osdep: import MADV_DOEXEC

On 8/17/2020 4:48 PM, Alex Williamson wrote: > On Mon, 17 Aug 2020 14:30:51 -0400 > Steven Sistare wrote: > >> On 7/30/2020 11:14 AM, Steve Sistare wrote: >>> Anonymous memory segments used by the guest are preserved across a re-exec >>> of qemu, mapped at th

Re: [PATCH V1 18/32] osdep: import MADV_DOEXEC

On 7/30/2020 11:14 AM, Steve Sistare wrote: > Anonymous memory segments used by the guest are preserved across a re-exec > of qemu, mapped at the same VA, via a proposed madvise(MADV_DOEXEC) option > in the Linux kernel. For the madvise patches, see: > >

Re: [PATCH V1 18/32] osdep: import MADV_DOEXEC

On 8/17/2020 10:42 PM, Alex Williamson wrote: > On Mon, 17 Aug 2020 15:44:03 -0600 > Alex Williamson wrote: > >> On Mon, 17 Aug 2020 17:20:57 -0400 >> Steven Sistare wrote: >> >>> On 8/17/2020 4:48 PM, Alex Williamson wrote: >>>> On Mon, 17 Au

Re: [PATCH V1 30/32] vfio-pci: save and restore

On 8/9/2020 11:50 PM, Jason Zeng wrote: > On Fri, Aug 07, 2020 at 04:38:12PM -0400, Steven Sistare wrote: >> On 8/6/2020 6:22 AM, Jason Zeng wrote: >>> Hi Steve, >>> >>> On Thu, Jul 30, 2020 at 08:14:34AM -0700, Steve Sistare wrote: >>

Re: [PATCH V1 14/32] savevm: VMS_RESTART and cprsave restart

On 9/11/2020 2:44 PM, Dr. David Alan Gilbert wrote: > * Steve Sistare (steven.sist...@oracle.com) wrote: >> Add the VMS_RESTART variant of vmstate, for use when upgrading qemu in place >> on the same host without a reboot. Invoke it using: >> cprsave restart >> >> VMS_RESTART supports guest

Re: [PATCH V1 04/32] savevm: HMP Command for cprsave

On 9/11/2020 12:57 PM, Dr. David Alan Gilbert wrote: > * Steve Sistare (steven.sist...@oracle.com) wrote: >> Enable HMP access to the cprsave QMP command. >> >> Usage: cprsave >> >> Signed-off-by: Maran Wilson >> Signed-off-by: Steve Sistare > > I realise that the current mode is currently

Re: [PATCH V1 15/32] vl: QEMU_START_FREEZE env var

On 9/11/2020 2:49 PM, Dr. David Alan Gilbert wrote: > * Steve Sistare (steven.sist...@oracle.com) wrote: >> For qemu upgrade and restart, we will re-exec() qemu with the same argv. >> However, qemu must start in a paused state and wait for the cprload command, >> and the original argv might not

Re: [PATCH V1 12/32] vl: pause option

On 9/11/2020 1:59 PM, Dr. David Alan Gilbert wrote: > * Steven Sistare (steven.sist...@oracle.com) wrote: >> On 7/30/2020 1:03 PM, Alex Bennée wrote: >>> >>> Steve Sistare writes: >>> >>>> Provide the -pause command-line parameter and the QEMU_

Re: [PATCH V1 32/32] vfio-pci: improved tracing

On 9/15/2020 2:49 PM, Dr. David Alan Gilbert wrote: > * Steve Sistare (steven.sist...@oracle.com) wrote: >> Print more info for existing trace points: >> trace_kvm_irqchip_add_msi_route. >> trace_pci_update_mappings_del >> trace_pci_update_mappings_add >> >> Add new trace points: >>

Re: [PATCH V1 08/32] savevm: HMP command for cprinfo

On 9/11/2020 1:27 PM, Dr. David Alan Gilbert wrote: > * Steve Sistare (steven.sist...@oracle.com) wrote: >> Enable HMP access to the cprinfo QMP command. >> >> Usage: cprinfo >> >> Signed-off-by: Steve Sistare > > As with Eric's comment on the qemp I don't think you need it; > for HMP alll you

Re: [PATCH V1 17/32] util: env var helpers

On 9/11/2020 3:00 PM, Dr. David Alan Gilbert wrote: > * Steve Sistare (steven.sist...@oracle.com) wrote: >> Add functions for saving fd's and ram extents in the environment via >> setenv, and for reading them back via getenv. >> >> Signed-off-by: Steve Sistare >> Signed-off-by: Mark Kanda > >

Re: [PATCH V1 22/32] char: qio_channel_socket_accept reuse fd

On 9/15/2020 1:33 PM, Dr. David Alan Gilbert wrote: > * Steve Sistare (steven.sist...@oracle.com) wrote: >> From: Mark Kanda >> >> Add an fd argument to qio_channel_socket_accept. If not -1, the channel >> uses that fd instead of accepting a new socket connection. All callers >> pass -1 in this

Re: [PATCH V1 11/32] cpu: disable ticks when suspended

On 9/11/2020 1:53 PM, Dr. David Alan Gilbert wrote: > * Steve Sistare (steven.sist...@oracle.com) wrote: >> After cprload, the guest console misbehaves. You must type 8 characters >> before any are echoed to the terminal. Qemu was not sending interrupts >> to the guest because the

Re: [PATCH V1 01/32] savevm: add vmstate handler iterators

On 9/11/2020 12:24 PM, Dr. David Alan Gilbert wrote: > Apologies for taking a while to get around to this, > > * Steve Sistare (steven.sist...@oracle.com) wrote: >> Provide the SAVEVM_FOREACH and SAVEVM_FORALL macros to loop over all save >> VM state handlers. The former will filter handlers

Re: [PATCH V1 09/32] savevm: prevent cprsave if memory is volatile

On 9/11/2020 1:35 PM, Dr. David Alan Gilbert wrote: > * Steve Sistare (steven.sist...@oracle.com) wrote: >> cprsave and cprload require that guest ram be backed by an externally >> visible shared file. Check that in cprsave. >> >> Signed-off-by: Steve Sistare >> --- >> exec.c|

Re: [PATCH V1 05/32] savevm: QMP command for cprload

On 9/11/2020 1:18 PM, Dr. David Alan Gilbert wrote: > * Steven Sistare (steven.sist...@oracle.com) wrote: >> On 7/30/2020 12:14 PM, Eric Blake wrote: >>> On 7/30/20 10:14 AM, Steve Sistare wrote: >>>> Provide the cprload QMP command.  The VM is created from the fil

Re: [PATCH V1 13/32] gdbstub: gdb support for suspended state

On 9/11/2020 2:41 PM, Dr. David Alan Gilbert wrote: > * Steve Sistare (steven.sist...@oracle.com) wrote: >> Modify the gdb server so a continue command appears to resume execution >> when in RUN_STATE_SUSPENDED. Do not print the next gdb prompt, but do not >> actually resume instruction fetch.

Re: [PATCH V1 03/32] savevm: QMP command for cprsave

On 9/11/2020 12:43 PM, Dr. David Alan Gilbert wrote: > * Steve Sistare (steven.sist...@oracle.com) wrote: >> To enable live reboot, provide the cprsave QMP command and the VMS_REBOOT >> vmstate-saving operation, which saves the state of the virtual machine in a >> simple file. >> >> Syntax: >>

Re: [PATCH V1 10/32] kvmclock: restore paused KVM clock

On 9/11/2020 1:50 PM, Dr. David Alan Gilbert wrote: > * Steve Sistare (steven.sist...@oracle.com) wrote: >> If the VM is paused when the KVM clock is serialized to a file, record >> that the clock is valid, so the value will be reused rather than >> overwritten after cprload with a new call to

Re: [PATCH V1 03/32] savevm: QMP command for cprsave

On 9/25/2020 2:43 PM, Steven Sistare wrote: > On 9/11/2020 12:43 PM, Dr. David Alan Gilbert wrote: >> * Steve Sistare (steven.sist...@oracle.com) wrote: >>> To enable live reboot, provide the cprsave QMP command and the VMS_REBOOT >>> vmstate-saving operation, which sav

Re: [PATCH V1 18/32] osdep: import MADV_DOEXEC

On 10/19/2020 12:33 PM, Steven Sistare wrote: > On 10/15/2020 4:36 PM, Alex Williamson wrote: >> On Thu, 8 Oct 2020 12:32:35 -0400 >> Steven Sistare wrote: >>> On 8/24/2020 6:30 PM, Alex Williamson wrote: >>>> On Wed, 19 Aug 2020 17:52:26 -0400 >>>>

Re: [PATCH V1 30/32] vfio-pci: save and restore

On 8/6/2020 6:22 AM, Jason Zeng wrote: > Hi Steve, > > On Thu, Jul 30, 2020 at 08:14:34AM -0700, Steve Sistare wrote: >> @@ -3182,6 +3207,51 @@ static Property vfio_pci_dev_properties[] = { >> DEFINE_PROP_END_OF_LIST(), >> }; >> >> +static int vfio_pci_post_load(void *opaque, int

Re: [PATCH V1 00/32] Live Update

Hi folks, any questions or comments on the vfio and pci changes in patch 30? Or on the means of preserving anonymous memory and re-exec'ing in patches 14 - 21? - Steve On 7/30/2020 11:14 AM, Steve Sistare wrote: > Improve and extend the qemu functions that save and restore VM state so a >

Re: [PATCH V1 12/32] vl: pause option

On 7/31/2020 6:07 AM, Daniel P. Berrangé wrote: > On Thu, Jul 30, 2020 at 02:11:19PM -0400, Steven Sistare wrote: >> On 7/30/2020 12:20 PM, Eric Blake wrote: >>> On 7/30/20 10:14 AM, Steve Sistare wrote: >>>> Provide the -pause command-line parameter and the QEMU_P

Re: [PATCH V1 00/32] Live Update

On 7/31/2020 4:53 AM, Daniel P. Berrangé wrote: > On Thu, Jul 30, 2020 at 02:48:44PM -0400, Steven Sistare wrote: >> On 7/30/2020 12:52 PM, Daniel P. Berrangé wrote: >>> On Thu, Jul 30, 2020 at 08:14:04AM -0700, Steve Sistare wrote: >>>> Improve and extend the qemu f

Re: [PATCH V1 00/32] Live Update

On 7/31/2020 11:52 AM, Daniel P. Berrangé wrote: > On Fri, Jul 31, 2020 at 11:27:45AM -0400, Steven Sistare wrote: >> On 7/31/2020 4:53 AM, Daniel P. Berrangé wrote: >>> On Thu, Jul 30, 2020 at 02:48:44PM -0400, Steven Sistare wrote: >>>> On 7/30/2020 12:5

Re: [PATCH V1 24/32] ui: save/restore vnc socket fds

On 7/31/2020 5:06 AM, Daniel P. Berrangé wrote: > On Thu, Jul 30, 2020 at 08:14:28AM -0700, Steve Sistare wrote: >> From: Mark Kanda >> >> Iterate through the VNC displays and save/restore the socket fds. > > This patch doesn't appear to do anything around the client state, so I > can't see how

Re: [PATCH V1 00/32] Live Update

On 7/30/2020 5:39 PM, Paolo Bonzini wrote: > On 30/07/20 21:09, Steven Sistare wrote: >>> please spell it out. Also, how does the functionality compare to >>> xen-save-devices-state and xen-load-devices-state? >> >> qmp_xen_save_devices_state serializes devic

Re: [PATCH V1 03/32] savevm: QMP command for cprsave

On 7/30/2020 12:12 PM, Eric Blake wrote: > On 7/30/20 10:14 AM, Steve Sistare wrote: >> To enable live reboot, provide the cprsave QMP command and the VMS_REBOOT >> vmstate-saving operation, which saves the state of the virtual machine in a >> simple file. >> >> Syntax: >>    {'command':'cprsave',

Re: [PATCH V1 12/32] vl: pause option

On 7/30/2020 12:20 PM, Eric Blake wrote: > On 7/30/20 10:14 AM, Steve Sistare wrote: >> Provide the -pause command-line parameter and the QEMU_PAUSE environment >> variable to briefly pause QEMU in main and allow a developer to attach gdb. >> Useful when the developer does not invoke QEMU

Re: [PATCH V1 12/32] vl: pause option

On 7/30/2020 1:03 PM, Alex Bennée wrote: > > Steve Sistare writes: > >> Provide the -pause command-line parameter and the QEMU_PAUSE environment >> variable to briefly pause QEMU in main and allow a developer to attach gdb. >> Useful when the developer does not invoke QEMU directly, such as

Re: [PATCH V1 00/32] Live Update

On 7/30/2020 1:49 PM, Dr. David Alan Gilbert wrote: > * Steve Sistare (steven.sist...@oracle.com) wrote: >> Improve and extend the qemu functions that save and restore VM state so a >> guest may be suspended and resumed with minimal pause time. qemu may be >> updated to a new version in between.

Re: [PATCH V1 00/32] Live Update

On 7/30/2020 1:15 PM, Paolo Bonzini wrote: > On 30/07/20 17:14, Steve Sistare wrote: >> The first set of patches adds the cprsave and cprload commands to save and >> restore VM state, and allow the host kernel to be updated and rebooted in >> between. The VM must create guest RAM in a persistent

Re: [PATCH V1 05/32] savevm: QMP command for cprload

On 7/30/2020 12:14 PM, Eric Blake wrote: > On 7/30/20 10:14 AM, Steve Sistare wrote: >> Provide the cprload QMP command.  The VM is created from the file produced >> by the cprsave command.  Guest RAM is restored in-place from the shared >> memory backend file, and guest block devices are used as

Re: [PATCH V1 07/32] savevm: QMP command for cprinfo

On 7/30/2020 12:17 PM, Eric Blake wrote: > On 7/30/20 10:14 AM, Steve Sistare wrote: >> Provide the cprinfo QMP command.  This returns a string with a space- >> separated list of modes supported by cprsave, and can be used by clients >> as a feature test to check if the running QEMU instance

Re: [PATCH V1 14/32] savevm: VMS_RESTART and cprsave restart

On 7/30/2020 12:22 PM, Eric Blake wrote: > On 7/30/20 10:14 AM, Steve Sistare wrote: >> Add the VMS_RESTART variant of vmstate, for use when upgrading qemu in place >> on the same host without a reboot.  Invoke it using: >>    cprsave restart >> >> VMS_RESTART supports guest ram mapped by private

Re: [PATCH V1 00/32] Live Update

On 7/30/2020 12:52 PM, Daniel P. Berrangé wrote: > On Thu, Jul 30, 2020 at 08:14:04AM -0700, Steve Sistare wrote: >> Improve and extend the qemu functions that save and restore VM state so a >> guest may be suspended and resumed with minimal pause time. qemu may be >> updated to a new version in

Re: [PATCH V2] vl: pause option

On 11/5/2020 9:55 AM, Steven Sistare wrote: > On 11/4/2020 4:40 PM, Alex Bennée wrote: >> Eric Blake writes: >>> On 11/2/20 9:50 AM, Steve Sistare wrote: >>>> Provide the -pause command-line parameter and the QEMU_PAUSE environment >>>> variable to pause

Re: [PATCH V2 05/22] vl: memfd-alloc option

On 1/6/2021 3:10 PM, Paolo Bonzini wrote: > Il mer 6 gen 2021, 17:37 Steven Sistare <mailto:steven.sist...@oracle.com>> ha scritto: > > Yes, I considered that, but there are other memory regions that cannot be > controlled > by the command line but which must be

Re: [PATCH V1] gdbstub: suspended state support

On 1/7/2021 7:40 AM, Alex Bennée wrote: > Steve Sistare writes: > >> Modify the gdb server so a continue command appears to resume execution >> when in RUN_STATE_SUSPENDED. Do not print the next gdb prompt, but do not >> actually resume instruction fetch. While in this "fake" running mode, a

Re: [PATCH V2] vl: pause option

On 11/4/2020 2:26 PM, Eric Blake wrote: > On 11/2/20 9:50 AM, Steve Sistare wrote: >> Provide the -pause command-line parameter and the QEMU_PAUSE environment >> variable to pause QEMU during process startup using SIGSTOP and allow a >> developer to attach a debugger, or observe the process using

Re: [PATCH V2] vl: pause option

On 11/5/2020 10:07 AM, Daniel P. Berrangé wrote: > On Thu, Nov 05, 2020 at 09:55:21AM -0500, Steven Sistare wrote: >> On 11/4/2020 4:40 PM, Alex Bennée wrote: >>> Eric Blake writes: >>>> On 11/2/20 9:50 AM, Steve Sistare wrote: >>>>> Provide the -pa

Re: [PATCH V2] vl: pause option

On 11/4/2020 4:40 PM, Alex Bennée wrote: > Eric Blake writes: >> On 11/2/20 9:50 AM, Steve Sistare wrote: >>> Provide the -pause command-line parameter and the QEMU_PAUSE environment >>> variable to pause QEMU during process startup using SIGSTOP and allow a >>> developer to attach a debugger, or

Re: [PATCH V2 18/22] chardev: cpr for sockets

On 1/5/2021 11:22 AM, Daniel P. Berrangé wrote: > On Tue, Jan 05, 2021 at 07:42:06AM -0800, Steve Sistare wrote: >> Define qio_channel_socket_reuse to initialize a channel based on an existing >> socket fd. Save accepted socket fds in the environment before cprsave, and >> look for fds in the

Re: [PATCH V2 05/22] vl: memfd-alloc option

On 1/5/2021 11:27 AM, Daniel P. Berrangé wrote: > On Tue, Jan 05, 2021 at 07:41:53AM -0800, Steve Sistare wrote: >> Allocate anonymous memory using memfd_create if the memfd-alloc option is >> set. >> >> Signed-off-by: Steve Sistare >> --- >> exec.c | 38

Re: [PATCH V3 12/22] vfio-pci: cpr part 1

On 5/24/2021 2:29 PM, Steven Sistare wrote: > On 5/21/2021 6:24 PM, Alex Williamson wrote:> On Fri, 7 May 2021 05:25:10 > -0700 >> Steve Sistare wrote: >> >>>[...] >>> diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c >>> index 7a4fb6c..f7ac9f03 100644

Re: [PATCH V3 00/22] Live Update [restart] : code replication

On 6/7/2021 2:08 PM, Steven Sistare wrote: > On 6/3/2021 3:36 PM, Dr. David Alan Gilbert wrote: >> * Steven Sistare (steven.sist...@oracle.com) wrote: >>> On 5/24/2021 6:39 AM, Dr. David Alan Gilbert wrote: >>>> * Steven Sistare (steven.sist...@oracle.com) wrote:

Re: [PATCH V3 00/22] Live Update [restart] : exec

On 6/7/2021 12:40 PM, Steven Sistare wrote: > On 6/3/2021 4:44 PM, Daniel P. Berrangé wrote: >> On Thu, Jun 03, 2021 at 08:36:42PM +0100, Dr. David Alan Gilbert wrote: >>> * Steven Sistare (steven.sist...@oracle.com) wrote: >>>> On 5/24/2021 6:39 AM, Dr. David Alan

Re: [PATCH V3 08/22] cpr: QMP interfaces

On 6/4/2021 9:59 AM, Eric Blake wrote: > On Fri, May 07, 2021 at 05:25:06AM -0700, Steve Sistare wrote: >> cprsave calls cprsave(). Syntax: >> { 'enum': 'CprMode', 'data': [ 'reboot', 'restart' ] } >> { 'command': 'cprsave', 'data': { 'file': 'str', 'mode': 'CprMode' } } >> >> cprload calls

Re: [PATCH V3 00/22] Live Update [restart] : exec

On 6/3/2021 4:44 PM, Daniel P. Berrangé wrote: > On Thu, Jun 03, 2021 at 08:36:42PM +0100, Dr. David Alan Gilbert wrote: >> * Steven Sistare (steven.sist...@oracle.com) wrote: >>> On 5/24/2021 6:39 AM, Dr. David Alan Gilbert wrote: >>>> * Steven Sistare (st

Re: [PATCH V3 00/22] Live Update [restart] : code replication

On 6/3/2021 3:36 PM, Dr. David Alan Gilbert wrote: > * Steven Sistare (steven.sist...@oracle.com) wrote: >> On 5/24/2021 6:39 AM, Dr. David Alan Gilbert wrote: >>> * Steven Sistare (steven.sist...@oracle.com) wrote: >>>> On 5/20/2021 9:13 AM, Dr. David Alan Gilber

Re: [PATCH V3 12/22] vfio-pci: cpr part 1

On 6/11/2021 2:15 PM, Steven Sistare wrote: > On 5/24/2021 2:29 PM, Steven Sistare wrote: >> On 5/21/2021 6:24 PM, Alex Williamson wrote:> On Fri, 7 May 2021 05:25:10 >> -0700 >>> Steve Sistare wrote: >>> >>>> [...] >>>> diff --git

Re: [PATCH V3 00/22] Live Update [reboot]

On 6/15/2021 3:14 PM, Dr. David Alan Gilbert wrote: > * Steven Sistare (steven.sist...@oracle.com) wrote: >> On 5/20/2021 9:00 AM, Dr. David Alan Gilbert wrote: >>> Hi Steven, >>> I'd like to split the discussion into reboot and restart, >>> so I can make

Re: [PATCH V3 06/22] vl: add helper to request re-exec

On 5/7/2021 10:31 AM, Eric Blake wrote: > On 5/7/21 7:25 AM, Steve Sistare wrote: >> Add a qemu_exec_requested() hook that causes the main loop to exit and >> re-exec qemu using the same initial arguments. If /usr/bin/qemu-exec >> exists, exec that instead. This is an optional site-specific

Re: [PATCH V3 00/22] Live Update

On 5/12/2021 12:42 PM, Stefan Hajnoczi wrote: > On Fri, May 07, 2021 at 05:24:58AM -0700, Steve Sistare wrote: >> Provide the cprsave and cprload commands for live update. These save and >> restore VM state, with minimal guest pause time, so that qemu may be updated >> to a new version in

Re: [PATCH V3 06/22] vl: add helper to request re-exec

On 5/12/2021 12:27 PM, Stefan Hajnoczi wrote: > On Fri, May 07, 2021 at 05:25:04AM -0700, Steve Sistare wrote: >> @@ -660,6 +673,16 @@ void qemu_system_debug_request(void) >> qemu_notify_event(); >> } >> >> +static void qemu_exec(void) >> +{ >> +const char *helper =

Re: [PATCH V3 16/22] chardev: cpr framework

On 5/7/2021 10:33 AM, Eric Blake wrote: > On 5/7/21 7:25 AM, Steve Sistare wrote: >> Add QEMU_CHAR_FEATURE_CPR for devices that support cpr. >> Add the chardev close_on_cpr option for devices that can be closed on cpr >> and reopened after exec. >> cpr is allowed only if either

Re: [PATCH V3 07/22] cpr

On 5/12/2021 12:19 PM, Stefan Hajnoczi wrote: > On Fri, May 07, 2021 at 05:25:05AM -0700, Steve Sistare wrote: >> To use the restart mode, qemu must be started with the memfd-alloc machine >> option. The memfd's are saved to the environment and kept open across exec, >> after which they are found

Re: [PATCH V3 00/22] Live Update

I will add to MAINTAINERS incrementally instead of at the end to make checkpatch happy. I will use qemu_strtol even though I thought the message "consider using qemu_strtol" was giving me a choice. You can't fight The Man when the man is a robot. - Steve On 5/7/2021 9:00 AM,

Re: [PATCH V3 00/22] Live Update

On 5/18/2021 5:57 AM, Dr. David Alan Gilbert wrote: > * Steven Sistare (steven.sist...@oracle.com) wrote: >> On 5/14/2021 7:53 AM, Stefan Hajnoczi wrote: >>> On Thu, May 13, 2021 at 04:21:15PM -0400, Steven Sistare wrote: >>>> On 5/12/2021 12:42 PM, Stefan Hajnoc

Re: [PATCH V3 00/22] Live Update

On 5/18/2021 9:39 AM, Stefan Hajnoczi wrote: > On Mon, May 17, 2021 at 01:10:01PM -0600, Alex Williamson wrote: >> On Mon, 17 May 2021 12:40:43 +0100 >> Stefan Hajnoczi wrote: >> >>> On Fri, May 14, 2021 at 11:15:18AM -0400, Steven Sistare wrote: >>>> O

Re: [PATCH V3 00/22] Live Update

On 5/18/2021 3:23 PM, Dr. David Alan Gilbert wrote: > * Steven Sistare (steven.sist...@oracle.com) wrote: >> On 5/18/2021 5:57 AM, Dr. David Alan Gilbert wrote: >>> * Steven Sistare (steven.sist...@oracle.com) wrote: >>>> On 5/14/2021 7:53 AM, Stefan Hajnoczi wro

Re: [PATCH V3 00/22] Live Update [restart]

On 5/20/2021 9:13 AM, Dr. David Alan Gilbert wrote: > On the 'restart' branch of questions; can you explain, > other than the passing of the fd's, why the outgoing side of > qemu's 'migrate exec:' doesn't work for you? I'm not sure what I should describe. Can you be more specific? Do you mean:

Re: [PATCH V3 00/22] Live Update [reboot]

On 5/20/2021 9:00 AM, Dr. David Alan Gilbert wrote: > Hi Steven, > I'd like to split the discussion into reboot and restart, > so I can make sure I understand them individually. > > So reboot mode; > Can you explain which parts of this series are needed for reboot mode; > I've managed to do a

Re: [PATCH V3 11/22] vfio-pci: refactor for cpr

On 5/19/2021 6:38 PM, Alex Williamson wrote: > On Fri, 7 May 2021 05:25:09 -0700 > Steve Sistare wrote: > >> Export vfio_address_spaces and vfio_listener_skipped_section. >> Add optional eventfd arg to vfio_add_kvm_msi_virq. >> Refactor vector use into a helper vfio_vector_init. >> All for use

Re: [PATCH V3 07/22] cpr

On 5/14/2021 7:28 AM, Stefan Hajnoczi wrote: > On Thu, May 13, 2021 at 04:21:02PM -0400, Steven Sistare wrote: >> On 5/12/2021 12:19 PM, Stefan Hajnoczi wrote: >>> On Fri, May 07, 2021 at 05:25:05AM -0700, Steve Sistare wrote: >>>> To use the restart mode, qemu must b

Re: [PATCH V3 00/22] Live Update

On 5/14/2021 7:53 AM, Stefan Hajnoczi wrote: > On Thu, May 13, 2021 at 04:21:15PM -0400, Steven Sistare wrote: >> On 5/12/2021 12:42 PM, Stefan Hajnoczi wrote: >>> On Fri, May 07, 2021 at 05:24:58AM -0700, Steve Sistare wrote: >>>> Provide the cprsave and cp

Re: [PATCH V3 12/22] vfio-pci: cpr part 1

On 5/21/2021 6:24 PM, Alex Williamson wrote:> On Fri, 7 May 2021 05:25:10 -0700 > Steve Sistare wrote: > >> Enable vfio-pci devices to be saved and restored across an exec restart >> of qemu. >> >> At vfio creation time, save the value of vfio container, group, and device >> descriptors in the

Re: [PATCH V3 13/22] vfio-pci: cpr part 2

On 5/21/2021 6:24 PM, Alex Williamson wrote: > On Fri, 7 May 2021 05:25:11 -0700 > Steve Sistare wrote: > >> Finish cpr for vfio-pci by preserving eventfd's and vector state. >> >> Signed-off-by: Steve Sistare >> --- >> hw/vfio/pci.c | 110 >>

Re: [PATCH V3 00/22] Live Update

send-email-steven.sist...@oracle.com - Steve On 5/19/2021 12:43 PM, Steven Sistare wrote: > Hi Michael, Marcel, > I hope you have time to review the pci and vfio-pci related patches in this > series. They are an essential part of the live update functionality. The > first 2 patches are

Re: [PATCH V3 00/22] Live Update [restart]

On 5/24/2021 6:39 AM, Dr. David Alan Gilbert wrote: > * Steven Sistare (steven.sist...@oracle.com) wrote: >> On 5/20/2021 9:13 AM, Dr. David Alan Gilbert wrote: >>> On the 'restart' branch of questions; can you explain, >>> other than the passing of the fd's, why the

Re: [PATCH V3 11/22] vfio-pci: refactor for cpr

On 5/21/2021 5:07 PM, Alex Williamson wrote: > On Fri, 21 May 2021 09:33:13 -0400 > Steven Sistare wrote: > >> On 5/19/2021 6:38 PM, Alex Williamson wrote: >>> On Fri, 7 May 2021 05:25:09 -0700 >>> Steve Sistare wrote: >>> >>>> Export

Re: [PATCH V4 00/25] Live Update

On 7/7/2021 8:31 AM, Marc-André Lureau wrote: > Hi Steve > > On Tue, Jul 6, 2021 at 8:58 PM Steve Sistare > wrote: > >[...] > It doesn't apply on master, could you rebase and resend? > thanks > -- > Marc-André Lureau Will do, sorry about that - steve

Re: [PATCH V5 01/25] qemu_ram_volatile

Will do for all comments - steve On 7/8/2021 8:01 AM, Marc-André Lureau wrote: > Hi > > On Wed, Jul 7, 2021 at 9:35 PM Steve Sistare > wrote: > > Add a function that returns true if any ram_list block represents > volatile memory. > >

Re: [PATCH V5 02/25] cpr: reboot mode

Will do for all - steve On 7/8/2021 8:25 AM, Marc-André Lureau wrote: > Hi > > On Wed, Jul 7, 2021 at 9:45 PM Steve Sistare > wrote: > > Provide the cprsave and cprload functions for live update.  These save and > restore VM state, with minimal guest

Re: [PATCH V5 05/25] as_flat_walk

Will do for all - steve On 7/8/2021 9:49 AM, Marc-André Lureau wrote: > Hi > > On Wed, Jul 7, 2021 at 9:28 PM Steve Sistare > wrote: > > Add an iterator over the sections of a flattened address space. > > Signed-off-by: Steve Sistare

Re: [PATCH V5 06/25] oslib: qemu_clr_cloexec

On 7/8/2021 9:58 AM, Marc-André Lureau wrote: > Hi > > On Wed, Jul 7, 2021 at 9:33 PM Steve Sistare > wrote: > > Define qemu_clr_cloexec, analogous to qemu_set_cloexec. > > Reviewed-by: Dr. David Alan Gilbert > >

Re: [PATCH V5 03/25] cpr: QMP interfaces for reboot

Will do for all. Good idea on schema introspection. - steve On 7/8/2021 9:27 AM, Marc-André Lureau wrote: > Hi > > On Wed, Jul 7, 2021 at 9:28 PM Steve Sistare > wrote: > > cprsave calls cprsave().  Syntax: >   { 'enum': 'CprMode', 'data': [ 'reboot'

Re: [PATCH V5 20/25] chardev: cpr framework

On 7/8/2021 12:03 PM, Marc-André Lureau wrote: > Hi > > On Wed, Jul 7, 2021 at 9:37 PM Steve Sistare > wrote: > > Add QEMU_CHAR_FEATURE_CPR for devices that support cpr. > Add the chardev close_on_cpr option for devices that can be closed on cpr >

Re: [PATCH V5 07/25] machine: memfd-alloc option

On 7/8/2021 10:20 AM, Marc-André Lureau wrote: > Hi > > On Wed, Jul 7, 2021 at 9:39 PM Steve Sistare > wrote: > > Allocate anonymous memory using memfd_create if the memfd-alloc machine > option is set. > > > Nice, I'd suggest you send this patch

Re: [PATCH V5 08/25] vl: add helper to request re-exec

On 7/8/2021 10:31 AM, Marc-André Lureau wrote: > Hi > > On Wed, Jul 7, 2021 at 9:46 PM Steve Sistare > wrote: > > Add a qemu_system_exec_request() hook that causes the main loop to exit > and > re-exec qemu using the specified arguments. > > > I

Re: [PATCH V5 11/25] cpr: restart mode

On 7/8/2021 11:54 AM, Marc-André Lureau wrote: > On Thu, Jul 8, 2021 at 7:43 PM Marc-André Lureau > wrote: > > Hi > > On Wed, Jul 7, 2021 at 9:31 PM Steve Sistare > wrote: > > Provide the cprsave restart

Re: [PATCH V5 10/25] util: env var helpers

On 7/8/2021 11:10 AM, Marc-André Lureau wrote: > Hi > > On Wed, Jul 7, 2021 at 9:30 PM Steve Sistare > wrote: > > Add functions for saving fd's and other values in the environment via > setenv, and for reading them back via getenv. > > > I understand

Re: [PATCH V5 12/25] cpr: QMP interfaces for restart

On 7/8/2021 11:49 AM, Marc-André Lureau wrote: > Hi > > On Wed, Jul 7, 2021 at 9:33 PM Steve Sistare > wrote: > > cprexec calls cprexec().  Syntax: >   { 'command': 'cprexec', 'data': { 'argv': [ 'str' ] } } > > Add the restart mode: >   {

Re: [PATCH V3 00/22] Live Update [reboot]

On 6/24/2021 11:05 AM, Steven Sistare wrote: > On 6/15/2021 3:14 PM, Dr. David Alan Gilbert wrote: >> * Steven Sistare (steven.sist...@oracle.com) wrote: >>> On 5/20/2021 9:00 AM, Dr. David Alan Gilbert wrote: >>>> Hi Steven, >>>> I'd like to split the d

Re: [PATCH V3 00/22] Live Update

Hi Michael, Marcel, I hope you have time to review the pci and vfio-pci related patches in this series. They are an essential part of the live update functionality. The first 2 patches are straightforward, just exposing functions for use in vfio. The last 2 patches are more substantial. -

Re: [PATCH V6 00/27] Live Update

id qmp_cpr_exec(strList *args, Error **errp) > return; > } > cpr_walk_fd(preserve_fd, 0); > -if (cpr_state_save(errp)) { > +if (cpr_state_save(cpr_active_mode, errp)) { > return; > } > vhost_dev_reset_all(); > @@ -173,4 +173,5 @@ vo

Re: [PATCH V6 18/27] vfio-pci: refactor for cpr

Thanks for reviewing, and sorry for the delayed response, I just returned from vacation. On 8/10/2021 12:53 PM, Alex Williamson wrote: > On Fri, 6 Aug 2021 14:43:52 -0700 > Steve Sistare wrote: > >> Export vfio_address_spaces and vfio_listener_skipped_section. >> Add optional name arg to

Re: [PATCH V6 00/27] Live Update

Hi Zheng, testing aarch64 is on our todo list. We will run this case and try to reproduce the failure. Thanks for the report. - Steve On 8/21/2021 4:54 AM, Zheng Chuan wrote: > Hi, steve > > It seems the VM will stuck after cpr-load on AArch64 environment？ > > My AArch64 environment and test

Re: [PATCH V6 19/27] vfio-pci: cpr part 1 (fd and dma)

On 8/10/2021 1:06 PM, Alex Williamson wrote: > On Fri, 6 Aug 2021 14:43:53 -0700 > Steve Sistare wrote: > >> Enable vfio-pci devices to be saved and restored across an exec restart >> of qemu. >> >> At vfio creation time, save the value of vfio container, group, and device >> descriptors in cpr

Re: [PATCH V5 20/25] chardev: cpr framework

On 7/12/2021 3:49 PM, Marc-André Lureau wrote: > Hi > > On Mon, Jul 12, 2021 at 11:20 PM Steven Sistare <mailto:steven.sist...@oracle.com>> wrote: > > On 7/8/2021 12:03 PM, Marc-André Lureau wrote: > > Hi > > > > On Wed, Jul 7, 2021 at

Re: [PATCH V5 10/25] util: env var helpers

On 7/12/2021 3:36 PM, Marc-André Lureau wrote: > Hi > > On Mon, Jul 12, 2021 at 11:19 PM Steven Sistare <mailto:steven.sist...@oracle.com>> wrote: > > On 7/8/2021 11:10 AM, Marc-André Lureau wrote: > > Hi > > > > On Wed, Jul 7, 2021 at

Re: [PATCH V6 00/27] Live Update

I forgot to mention in the changes list: I added a new mechanism to save fd values, in lieu of the environment. See [PATCH V6 13/27] cpr: preserve extra state - Steve On 8/6/2021 5:43 PM, Steve Sistare wrote: > Provide the cpr-save, cpr-exec, and cpr-load commands for live update. > These save

Re: [PATCH V5 17/25] vfio-pci: cpr part 2

On 7/28/2021 12:56 AM, Zheng Chuan wrote: > On 2021/7/20 2:38, Steven Sistare wrote: >> On 7/19/2021 2:10 PM, Alex Williamson wrote: >>> On Mon, 19 Jul 2021 13:44:08 -0400 >>> Steven Sistare wrote: >>> >>>> On 7/16/2021 4:51 PM, Alex Williamson

Re: [PATCH V5 16/25] vfio-pci: cpr part 1

On 7/28/2021 12:56 AM, Zheng Chuan wrote: > On 2021/7/8 1:20, Steve Sistare wrote: >> Enable vfio-pci devices to be saved and restored across an exec restart >> of qemu. >> >> [...] >> --- a/migration/cpr.c >> +++ b/migration/cpr.c >> @@ -31,6 +31,13 @@ >> #include "hw/virtio/vhost.h" >>

Re: [PATCH V5 00/25] Live Update [restart] : fork mode?

On 7/30/2021 9:10 AM, Zheng Chuan wrote: > Hi, Steve > I have saw the discussion about the fork+exec mode below: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg815956.html > > And I am still very curious and I want to discuss about the possibility to > support both fork+exec and exec in

  1   2   3   4   >