[PATCH v3 4/5] hw/misc: add MAX34451 device

2021-05-18 Thread Titus Rwantare
. Reviewed-by: Joel Stanley Reviewed-by: Hao Wu Signed-off-by: Titus Rwantare --- hw/misc/max34451.c | 716 hw/arm/Kconfig | 1 + hw/misc/Kconfig | 4 + hw/misc/meson.build | 1 + 4 files changed, 722 insertions(+) create mode 100644 hw

[PATCH v3 2/5] hw/misc: add ADM1272 device

2021-05-18 Thread Titus Rwantare
Reviewed-by: Joel Stanley Reviewed-by: Hao Wu Signed-off-by: Titus Rwantare --- hw/misc/adm1272.c | 543 hw/arm/Kconfig | 1 + hw/misc/Kconfig | 4 + hw/misc/meson.build | 1 + 4 files changed, 549 insertions(+) create mode 100644 hw

[PATCH v3 3/5] tests/qtest: add tests for ADM1272 device model

2021-05-18 Thread Titus Rwantare
Signed-off-by: Titus Rwantare Reviewed-by: Joel Stanley --- tests/qtest/adm1272-test.c | 445 + tests/qtest/meson.build| 1 + 2 files changed, 446 insertions(+) create mode 100644 tests/qtest/adm1272-test.c diff --git a/tests/qtest/adm1272-test.c b

[PATCH v3 5/5] tests/qtest: add tests for MAX34451 device model

2021-05-18 Thread Titus Rwantare
Signed-off-by: Titus Rwantare Reviewed-by: Joel Stanley --- tests/qtest/max34451-test.c | 336 tests/qtest/meson.build | 1 + 2 files changed, 337 insertions(+) create mode 100644 tests/qtest/max34451-test.c diff --git a/tests/qtest/max34451-test.c b

[PATCH v3 1/5] hw/i2c: add support for PMBus

2021-05-18 Thread Titus Rwantare
QEMU has support for SMBus devices, and PMBus is a more specific implementation of SMBus. The additions made in this commit makes it easier to add new PMBus devices to QEMU. https://pmbus.org/specification-archives/ Reviewed-by: Joel Stanley Reviewed-by: Hao Wu Signed-off-by: Titus Rwantare

[PATCH v3 0/5] Add support for PMBus in QEMU

2021-05-18 Thread Titus Rwantare
commented out code Since v1: - addressed Joel's comments - split out tests into their own patches Thanks for reviewing, Titus Rwantare Titus Rwantare (5): hw/i2c: add support for PMBus hw/misc: add ADM1272 device tests/qtest: add tests for ADM1272 device model hw/misc: add MAX34451 device

Re: [PATCH v3 1/5] hw/i2c: add support for PMBus

2021-05-18 Thread Titus Rwantare
I can add it. On Tue, 18 May 2021 at 15:37, Corey Minyard wrote: > > On Tue, May 18, 2021 at 11:45:23AM -0700, Titus Rwantare wrote: > > QEMU has support for SMBus devices, and PMBus is a more specific > > implementation of SMBus. The additions made in this commit makes it easi

Re: [PATCH v3 0/5] Add support for PMBus in QEMU

2021-05-18 Thread Titus Rwantare
That would be great. On Tue, 18 May 2021, 16:59 Corey Minyard, wrote: > > On Tue, May 18, 2021 at 03:50:57PM -0400, Titus Rwantare wrote: > > I would also like a directory for sensors. There are quite a few of > > those incoming. Any objections? > > None from me. I'll

Re: [PATCH v3 0/5] Add support for PMBus in QEMU

2021-05-18 Thread Titus Rwantare
I would also like a directory for sensors. There are quite a few of those incoming. Any objections? -Titus On Tue, 18 May 2021 at 15:45, Corey Minyard wrote: > > On Tue, May 18, 2021 at 11:45:22AM -0700, Titus Rwantare wrote: > > Hello, > > > > This patch series ad

[PATCH v5 2/5] hw/misc: add ADM1272 device

2021-07-08 Thread Titus Rwantare
Reviewed-by: Joel Stanley Reviewed-by: Hao Wu Signed-off-by: Titus Rwantare --- hw/misc/adm1272.c | 544 hw/arm/Kconfig | 1 + hw/misc/Kconfig | 4 + hw/misc/meson.build | 1 + 4 files changed, 550 insertions(+) create mode 100644 hw

[PATCH v5 0/5] Add support for PMBus in QEMU

2021-07-08 Thread Titus Rwantare
, Titus Rwantare Titus Rwantare (5): hw/i2c: add support for PMBus hw/misc: add ADM1272 device tests/qtest: add tests for ADM1272 device model hw/misc: add MAX34451 device tests/qtest: add tests for MAX34451 device model include/hw/i2c/pmbus_device.h | 517 +++ hw/i2c

[PATCH v5 3/5] tests/qtest: add tests for ADM1272 device model

2021-07-08 Thread Titus Rwantare
Signed-off-by: Titus Rwantare Reviewed-by: Joel Stanley --- tests/qtest/adm1272-test.c | 445 + tests/qtest/meson.build| 1 + 2 files changed, 446 insertions(+) create mode 100644 tests/qtest/adm1272-test.c diff --git a/tests/qtest/adm1272-test.c b

[PATCH v5 5/5] tests/qtest: add tests for MAX34451 device model

2021-07-08 Thread Titus Rwantare
Signed-off-by: Titus Rwantare Reviewed-by: Joel Stanley --- tests/qtest/max34451-test.c | 336 tests/qtest/meson.build | 1 + 2 files changed, 337 insertions(+) create mode 100644 tests/qtest/max34451-test.c diff --git a/tests/qtest/max34451-test.c b

[PATCH v5 5/5] tests/qtest: add tests for MAX34451 device model

2021-07-08 Thread Titus Rwantare
Signed-off-by: Titus Rwantare Reviewed-by: Joel Stanley --- tests/qtest/max34451-test.c | 336 tests/qtest/meson.build | 1 + 2 files changed, 337 insertions(+) create mode 100644 tests/qtest/max34451-test.c diff --git a/tests/qtest/max34451-test.c b

[PATCH v5 1/5] hw/i2c: add support for PMBus

2021-07-08 Thread Titus Rwantare
QEMU has support for SMBus devices, and PMBus is a more specific implementation of SMBus. The additions made in this commit makes it easier to add new PMBus devices to QEMU. https://pmbus.org/specification-archives/ Reviewed-by: Joel Stanley Reviewed-by: Hao Wu Signed-off-by: Titus Rwantare

[PATCH v5 0/5] Add support for PMBus in QEMU

2021-07-08 Thread Titus Rwantare
, Titus Rwantare Titus Rwantare (5): hw/i2c: add support for PMBus hw/misc: add ADM1272 device tests/qtest: add tests for ADM1272 device model hw/misc: add MAX34451 device tests/qtest: add tests for MAX34451 device model include/hw/i2c/pmbus_device.h | 517 +++ hw/i2c

[PATCH v5 2/5] hw/misc: add ADM1272 device

2021-07-08 Thread Titus Rwantare
Reviewed-by: Joel Stanley Reviewed-by: Hao Wu Signed-off-by: Titus Rwantare --- hw/misc/adm1272.c | 544 hw/arm/Kconfig | 1 + hw/misc/Kconfig | 4 + hw/misc/meson.build | 1 + 4 files changed, 550 insertions(+) create mode 100644 hw

[PATCH v5 3/5] tests/qtest: add tests for ADM1272 device model

2021-07-08 Thread Titus Rwantare
Signed-off-by: Titus Rwantare Reviewed-by: Joel Stanley --- tests/qtest/adm1272-test.c | 445 + tests/qtest/meson.build| 1 + 2 files changed, 446 insertions(+) create mode 100644 tests/qtest/adm1272-test.c diff --git a/tests/qtest/adm1272-test.c b

[PATCH v5 4/5] hw/misc: add MAX34451 device

2021-07-08 Thread Titus Rwantare
. Reviewed-by: Joel Stanley Reviewed-by: Hao Wu Signed-off-by: Titus Rwantare --- hw/misc/max34451.c | 775 hw/arm/Kconfig | 1 + hw/misc/Kconfig | 4 + hw/misc/meson.build | 1 + 4 files changed, 781 insertions(+) create mode 100644 hw

[PATCH v5 4/5] hw/misc: add MAX34451 device

2021-07-08 Thread Titus Rwantare
. Reviewed-by: Joel Stanley Reviewed-by: Hao Wu Signed-off-by: Titus Rwantare --- hw/misc/max34451.c | 775 hw/arm/Kconfig | 1 + hw/misc/Kconfig | 4 + hw/misc/meson.build | 1 + 4 files changed, 781 insertions(+) create mode 100644 hw

Re: [GIT PULL] I2C/IPMI bug fixes for QEMU 6.1

2021-07-08 Thread Titus Rwantare
I've sent out some patches using BIT_ULL(). Hopefully it's fixed. -Titus On Tue, 6 Jul 2021 at 18:00, Peter Maydell wrote: > > On Tue, 6 Jul 2021 at 22:45, Corey Minyard wrote: > > > > Hmm, it compiled for me, I wonder if there are some compiler > > differences, but I don't see how. > > I'd

[PATCH v5 1/5] hw/i2c: add support for PMBus

2021-07-08 Thread Titus Rwantare
QEMU has support for SMBus devices, and PMBus is a more specific implementation of SMBus. The additions made in this commit makes it easier to add new PMBus devices to QEMU. https://pmbus.org/specification-archives/ Reviewed-by: Joel Stanley Reviewed-by: Hao Wu Signed-off-by: Titus Rwantare

[PATCH v4 1/5] hw/i2c: add support for PMBus

2021-05-19 Thread Titus Rwantare
QEMU has support for SMBus devices, and PMBus is a more specific implementation of SMBus. The additions made in this commit makes it easier to add new PMBus devices to QEMU. https://pmbus.org/specification-archives/ Reviewed-by: Joel Stanley Reviewed-by: Hao Wu Signed-off-by: Titus Rwantare

[PATCH v4 2/5] hw/misc: add ADM1272 device

2021-05-19 Thread Titus Rwantare
Reviewed-by: Joel Stanley Reviewed-by: Hao Wu Signed-off-by: Titus Rwantare --- hw/misc/adm1272.c | 544 hw/arm/Kconfig | 1 + hw/misc/Kconfig | 4 + hw/misc/meson.build | 1 + 4 files changed, 550 insertions(+) create mode 100644 hw

[PATCH v4 0/5] Add support for PMBus in QEMU

2021-05-19 Thread Titus Rwantare
PMBusPage info to the vmsd has proven to be tricky, it's a TODO for now. Since v2: - bump for feedback - removed commented out code Since v1: - addressed Joel's comments - split out tests into their own patches Thanks for reviewing, Titus Rwantare Titus Rwantare (5): hw/i2c: add support

[PATCH v4 3/5] tests/qtest: add tests for ADM1272 device model

2021-05-19 Thread Titus Rwantare
Signed-off-by: Titus Rwantare Reviewed-by: Joel Stanley --- tests/qtest/adm1272-test.c | 445 + tests/qtest/meson.build| 1 + 2 files changed, 446 insertions(+) create mode 100644 tests/qtest/adm1272-test.c diff --git a/tests/qtest/adm1272-test.c b

[PATCH v4 4/5] hw/misc: add MAX34451 device

2021-05-19 Thread Titus Rwantare
. Reviewed-by: Joel Stanley Reviewed-by: Hao Wu Signed-off-by: Titus Rwantare --- hw/misc/max34451.c | 775 hw/arm/Kconfig | 1 + hw/misc/Kconfig | 4 + hw/misc/meson.build | 1 + 4 files changed, 781 insertions(+) create mode 100644 hw

[PATCH v4 5/5] tests/qtest: add tests for MAX34451 device model

2021-05-19 Thread Titus Rwantare
Signed-off-by: Titus Rwantare Reviewed-by: Joel Stanley --- tests/qtest/max34451-test.c | 336 tests/qtest/meson.build | 1 + 2 files changed, 337 insertions(+) create mode 100644 tests/qtest/max34451-test.c diff --git a/tests/qtest/max34451-test.c b

Re: [PATCH 1/3] hw/i2c: add support for PMBus

2021-05-04 Thread Titus Rwantare
Hi Phil, It looks big but the bulk of it is simple switch statements and definitions. Unless you mean you'd like it split despite that. Regards, Titus On Tue, 4 May 2021 at 16:49, Philippe Mathieu-Daudé wrote: > > Hi Titus, > > On 5/4/21 6:28 PM, Titus Rwantare wrote: > >

[PATCH v2 2/5] hw/misc: add ADM1272 device

2021-05-05 Thread Titus Rwantare
Reviewed-by: Hao Wu Signed-off-by: Titus Rwantare --- hw/misc/adm1272.c | 543 hw/arm/Kconfig | 1 + hw/misc/Kconfig | 4 + hw/misc/meson.build | 1 + 4 files changed, 549 insertions(+) create mode 100644 hw/misc/adm1272.c diff --git

[PATCH v2 3/5] tests/qtest: add tests for ADM1272 device model

2021-05-05 Thread Titus Rwantare
Signed-off-by: Titus Rwantare --- tests/qtest/adm1272-test.c | 445 + tests/qtest/meson.build| 1 + 2 files changed, 446 insertions(+) create mode 100644 tests/qtest/adm1272-test.c diff --git a/tests/qtest/adm1272-test.c b/tests/qtest/adm1272-test.c

[PATCH v2 0/5] Add support for PMBus in QEMU

2021-05-05 Thread Titus Rwantare
out tests into their own patches Thanks for reviewing, Titus Rwantare Titus Rwantare (5): hw/i2c: add support for PMBus hw/misc: add ADM1272 device tests/qtest: add tests for ADM1272 device model hw/misc: add MAX34451 device tests/qtest: add tests for MAX34451 device model include/hw

[PATCH v2 1/5] hw/i2c: add support for PMBus

2021-05-05 Thread Titus Rwantare
QEMU has support for SMBus devices, and PMBus is a more specific implementation of SMBus. The additions made in this commit makes it easier to add new PMBus devices to QEMU. https://pmbus.org/specification-archives/ Reviewed-by: Hao Wu Signed-off-by: Titus Rwantare --- include/hw/i2c

[PATCH v2 4/5] hw/misc: add MAX34451 device

2021-05-05 Thread Titus Rwantare
. Reviewed-by: Hao Wu Signed-off-by: Titus Rwantare --- hw/misc/max34451.c | 719 hw/arm/Kconfig | 1 + hw/misc/Kconfig | 4 + hw/misc/meson.build | 1 + 4 files changed, 725 insertions(+) create mode 100644 hw/misc/max34451.c diff --git

[PATCH v2 5/5] tests/qtest: add tests for MAX34451 device model

2021-05-05 Thread Titus Rwantare
Signed-off-by: Titus Rwantare --- tests/qtest/max34451-test.c | 336 tests/qtest/meson.build | 1 + 2 files changed, 337 insertions(+) create mode 100644 tests/qtest/max34451-test.c diff --git a/tests/qtest/max34451-test.c b/tests/qtest/max34451

[PATCH 1/3] hw/i2c: add support for PMBus

2021-05-04 Thread Titus Rwantare
QEMU has support for SMBus devices, and PMBus is a more specific implementation of SMBus. The additions made in this commit makes it easier to add new PMBus devices to QEMU. https://pmbus.org/specification-archives/ Reviewed-by: Hao Wu Signed-off-by: Titus Rwantare --- hw/arm/Kconfig

[PATCH 0/3] Add support for PMBus in QEMU

2021-05-04 Thread Titus Rwantare
devices make use of these fields and illustrate how to interface with the pmbus class. Datasheets for sensors: https://datasheets.maximintegrated.com/en/ds/MAX34451.pdf https://www.analog.com/media/en/technical-documentation/data-sheets/ADM1272.pdf Thanks for reviewing, Titus Rwantare Titus

[PATCH 3/3] hw/misc: add MAX34451 device

2021-05-04 Thread Titus Rwantare
. Reviewed-by: Hao Wu Signed-off-by: Titus Rwantare --- hw/arm/Kconfig | 1 + hw/misc/Kconfig | 4 + hw/misc/max34451.c | 727 hw/misc/meson.build | 1 + tests/qtest/max34451-test.c | 344 + tests

[PATCH 2/3] hw/misc: add ADM1272 device

2021-05-04 Thread Titus Rwantare
Reviewed-by: Hao Wu Signed-off-by: Titus Rwantare --- hw/arm/Kconfig | 1 + hw/misc/Kconfig| 4 + hw/misc/adm1272.c | 551 + hw/misc/meson.build| 1 + tests/qtest/adm1272-test.c | 453

Re: [PATCH] hw/misc: Add an iBT device model

2021-09-24 Thread Titus Rwantare
On Fri, 24 Sept 2021 at 03:55, Cédric Le Goater wrote: > > Hello Titus, > > On 9/24/21 10:42, Philippe Mathieu-Daudé wrote: > > On 9/24/21 01:48, Titus Rwantare wrote: > >> Hello all, > >> > >> I'd like some clarification on how the following code t

[RFC 0/1] hw/ipmi: add an aspeed IPMI iBT device model

2021-09-28 Thread Titus Rwantare
FC because of the missing IRQs and the need for other patches to get merged. Thank you all. Titus Rwantare (1): hw/ipmi: add an aspeed ipmi iBT device model hw/ipmi/ipmi_extern.h| 1 + include/hw/arm/aspeed_soc.h | 2 + include/hw/ipmi/aspeed_ibt.h | 77 + hw/arm/aspeed

[RFC 1/1] hw/ipmi: add an aspeed ipmi iBT device model

2021-09-28 Thread Titus Rwantare
Modifies [PATCH] hw/misc: Add an iBT device model posted by Cédric Le Goater, to use IPMIInterface. Signed-off-by: Titus Rwantare --- hw/ipmi/ipmi_extern.h| 1 + include/hw/arm/aspeed_soc.h | 2 + include/hw/ipmi/aspeed_ibt.h | 77 + hw/arm/aspeed_ast2600.c | 12

Re: [RFC 0/1] hw/ipmi: add an aspeed IPMI iBT device model

2021-09-29 Thread Titus Rwantare
On Tue, 28 Sept 2021 at 23:24, Cédric Le Goater wrote: > > Hello Titus, > > On 9/29/21 00:39, Titus Rwantare wrote: > > This patch follows the Handing IPMI for emulating BMC patch set by Hao Wu. > > Building on top of the work in [PATCH] hw/misc: Add an iBT device model

Re: [PATCH] hw/misc: Add an iBT device model

2021-09-23 Thread Titus Rwantare
Hello all, I'd like some clarification on how the following code transfers irqs back and forth: > b/hw/arm/aspeed_soc.c >+/* iBT */ >+if (!sysbus_realize(SYS_BUS_DEVICE(>ibt), errp)) { >+return; >+} >+memory_region_add_subregion(>lpc.iomem, >+

[PATCH 1/3] hw/sensor: add MAX31790 fan controller

2022-01-11 Thread Titus Rwantare
Signed-off-by: Titus Rwantare Reviewed-by: Hao Wu --- MAINTAINERS | 8 +- hw/arm/Kconfig| 1 + hw/sensor/Kconfig | 4 + hw/sensor/max31790_fan_ctrl.c | 454 ++ hw/sensor/meson.build

[PATCH 2/3] tests/qtest: add tests for MAX31790 fan controller

2022-01-11 Thread Titus Rwantare
Signed-off-by: Titus Rwantare Reviewed-by: Hao Wu --- tests/qtest/max31790_fan_ctrl-test.c | 171 +++ tests/qtest/meson.build | 1 + 2 files changed, 172 insertions(+) create mode 100644 tests/qtest/max31790_fan_ctrl-test.c diff --git a/tests/qtest

[PATCH 3/3] hw/arm: kudo add max31790 behind bus 1 switch at 75

2022-01-11 Thread Titus Rwantare
From: Patrick Venture Signed-off-by: Patrick Venture Reviewed-by: Titus Rwantare --- hw/arm/npcm7xx_boards.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/npcm7xx_boards.c b/hw/arm/npcm7xx_boards.c index 7d0f3148be..6fea2e161f 100644 --- a/hw/arm/npcm7xx_boards.c +++ b/hw/arm

Re: [PATCH v3 0/9] This patch series contains updates to PMBus in QEMU along with some PMBus device models for Renesas regulators. I have also added myself to MAINTAINERS as this code is in use daily,

2022-03-04 Thread Titus Rwantare
On Fri, 4 Mar 2022 at 13:43, Corey Minyard wrote: > > On Tue, Mar 01, 2022 at 05:50:44PM -0800, Titus Rwantare wrote: > > v2: > > - split PMBus commit with updates into individual fixes > > - renamed isl_pmbus[.ch] adding _vr for voltage regulators > > >

Re: [PATCH v3 2/9] hw/i2c: pmbus: guard against out of range accesses

2022-03-07 Thread Titus Rwantare
02:50, Titus Rwantare wrote: > > Signed-off-by: Titus Rwantare > > --- > > hw/i2c/pmbus_device.c | 41 - > > 1 file changed, 40 insertions(+), 1 deletion(-) > > > static uint8_t pmbus_receive_byte(SMBusDevice *sm

Re: [PATCH v3 3/9] hw/i2c: pmbus: add PEC unsupported warning

2022-03-07 Thread Titus Rwantare
Yes, fixed. On Fri, 4 Mar 2022 at 16:02, Philippe Mathieu-Daudé wrote: > > On 2/3/22 02:50, Titus Rwantare wrote: > > Signed-off-by: Titus Rwantare > > --- > > hw/i2c/pmbus_device.c | 5 + > > 1 file changed, 5 insertions(+) > > > > d

[PATCH v4 5/9] hw/i2c: pmbus: update MAINTAINERS

2022-03-07 Thread Titus Rwantare
add self to MAINTAINERS for the PMBus subsystem and related sensors, and set PMBus as maintained. Signed-off-by: Titus Rwantare Reviewed-by: Philippe Mathieu-Daudé --- MAINTAINERS | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index fa8adc2618

[PATCH v4 2/9] hw/i2c: pmbus: fix error returns and guard against out of range accesses

2022-03-07 Thread Titus Rwantare
Signed-off-by: Titus Rwantare Reviewed-by: Philippe Mathieu-Daudé --- hw/i2c/pmbus_device.c | 47 --- include/hw/i2c/pmbus_device.h | 2 ++ 2 files changed, 45 insertions(+), 4 deletions(-) diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c

[PATCH v4 7/9] hw/sensor: add Intersil ISL69260 device model

2022-03-07 Thread Titus Rwantare
Signed-off-by: Titus Rwantare Reviewed-by: Hao Wu Reviewed-by: Philippe Mathieu-Daudé --- MAINTAINERS | 3 + hw/arm/Kconfig | 1 + hw/sensor/Kconfig| 5 + hw/sensor/isl_pmbus_vr.c | 211 + hw/sensor

[PATCH v4 9/9] hw/sensor: add Renesas raa228000 device

2022-03-07 Thread Titus Rwantare
Signed-off-by: Titus Rwantare Reviewed-by: Hao Wu Reviewed-by: Philippe Mathieu-Daudé --- hw/sensor/isl_pmbus_vr.c | 50 ++ include/hw/sensor/isl_pmbus_vr.h | 1 + tests/qtest/isl_pmbus_vr-test.c | 72 3 files changed, 123

[PATCH v4 1/9] hw/i2c: pmbus: add registers

2022-03-07 Thread Titus Rwantare
- add the VOUT_MIN and STATUS_MFR registers Signed-off-by: Titus Rwantare Reviewed-by: Philippe Mathieu-Daudé --- hw/i2c/pmbus_device.c | 24 include/hw/i2c/pmbus_device.h | 3 +++ 2 files changed, 27 insertions(+) diff --git a/hw/i2c/pmbus_device.c b/hw

[PATCH v4 8/9] hw/sensor: add Renesas raa229004 PMBus device

2022-03-07 Thread Titus Rwantare
The Renesas RAA229004 is a PMBus Multiphase Voltage Regulator Signed-off-by: Titus Rwantare Reviewed-by: Hao Wu Reviewed-by: Philippe Mathieu-Daudé --- hw/sensor/isl_pmbus_vr.c | 18 ++ include/hw/sensor/isl_pmbus_vr.h | 1 + tests/qtest/isl_pmbus_vr-test.c | 8

[PATCH v4 4/9] hw/i2c: pmbus: refactor uint handling

2022-03-07 Thread Titus Rwantare
This change cleans up the inputs to pmbus_receive uint, the length of received data is contained in PMBusDevice state and doesn't need to be passed around. Signed-off-by: Titus Rwantare Reviewed-by: Philippe Mathieu-Daudé --- hw/i2c/pmbus_device.c | 18 +- 1 file changed, 9

[PATCH v4 6/9] hw/i2c: Added linear mode translation for pmbus devices

2022-03-07 Thread Titus Rwantare
From: Shengtan Mao Signed-off-by: Shengtan Mao Reviewed-by: Titus Rwantare Reviewed-by: Philippe Mathieu-Daudé --- hw/i2c/pmbus_device.c | 18 ++ include/hw/i2c/pmbus_device.h | 20 +++- 2 files changed, 37 insertions(+), 1 deletion(-) diff --git a/hw

[PATCH v4 3/9] hw/i2c: pmbus: add PEC unsupported warning

2022-03-07 Thread Titus Rwantare
Signed-off-by: Titus Rwantare --- hw/i2c/pmbus_device.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c index c7ec8e5499..ff644c1d4a 100644 --- a/hw/i2c/pmbus_device.c +++ b/hw/i2c/pmbus_device.c @@ -307,6 +307,11 @@ static uint8_t

[PATCH v4 0/9] Fixups for PMBus and new sensors

2022-03-07 Thread Titus Rwantare
returns Shengtan Mao (1): hw/i2c: Added linear mode translation for pmbus devices Titus Rwantare (8): hw/i2c: pmbus: add registers hw/i2c: pmbus: fix error returns and guard against out of range accesses hw/i2c: pmbus: add PEC unsupported warning hw/i2c: pmbus: refactor uint handling

[PATCH v2 6/9] hw/sensor: add Intersil ISL69260 device model

2022-03-01 Thread Titus Rwantare
Signed-off-by: Titus Rwantare Reviewed-by: Hao Wu --- MAINTAINERS | 3 + hw/arm/Kconfig| 1 + hw/sensor/Kconfig | 5 + hw/sensor/isl_pmbus.c | 210 ++ hw/sensor/meson.build | 1 + include/hw/sensor/isl_pmbus.h

[PATCH v2 8/9] hw/sensor: add Renesas raa228000 device

2022-03-01 Thread Titus Rwantare
Signed-off-by: Titus Rwantare Reviewed-by: Hao Wu --- hw/sensor/isl_pmbus.c | 50 ++ include/hw/sensor/isl_pmbus.h | 1 + tests/qtest/isl_pmbus-test.c | 78 +-- 3 files changed, 126 insertions(+), 3 deletions(-) diff --git a/hw

[PATCH v2 0/9] Fixups for PMBus and new sensors

2022-03-01 Thread Titus Rwantare
[.ch] adding _vr for voltage regulators Shengtan Mao (1): hw/i2c: Added linear mode translation for pmbus devices Titus Rwantare (8): hw/i2c: pmbus: add registers hw/i2c: pmbus: guard against out of range accesses hw/i2c: pmbus: add PEC unsupported warning hw/i2c: pmbus: refactor uint

[PATCH v2 9/9] hw/sensor: rename isl_pmbus to isl_pmbus_vr

2022-03-01 Thread Titus Rwantare
Signed-off-by: Titus Rwantare --- MAINTAINERS | 6 +- hw/arm/Kconfig| 2 +- hw/sensor/Kconfig | 2 +- hw/sensor/{isl_pmbus.c => isl_pmbus_vr.c} | 77 ++--- hw/sensor/meson.bu

Re: [PATCH v2 9/9] hw/sensor: rename isl_pmbus to isl_pmbus_vr

2022-03-01 Thread Titus Rwantare
The rename is from feedback in v1 by Peter. I did this in a separate patch as it's easier to merge, compared to editing the 4 commits affected by this. Titus On Tue, 1 Mar 2022 at 16:43, Corey Minyard wrote: > > On Tue, Mar 01, 2022 at 04:23:07PM -0800, Titus Rwantare wrote: > >

[PATCH v2 4/9] hw/i2c: pmbus: refactor uint handling and update MAINTAINERS

2022-03-01 Thread Titus Rwantare
Signed-off-by: Titus Rwantare --- MAINTAINERS | 10 ++ hw/i2c/pmbus_device.c | 18 +- 2 files changed, 19 insertions(+), 9 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index fa8adc2618..3601984b5d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3135,6

[PATCH v2 3/9] hw/i2c: pmbus: add PEC unsupported warning

2022-03-01 Thread Titus Rwantare
Signed-off-by: Titus Rwantare --- hw/i2c/pmbus_device.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c index 93c746bab3..6eeb0731d7 100644 --- a/hw/i2c/pmbus_device.c +++ b/hw/i2c/pmbus_device.c @@ -307,6 +307,11 @@ static uint8_t

[PATCH v2 1/9] hw/i2c: pmbus: add registers

2022-03-01 Thread Titus Rwantare
- add the VOUT_MIN and STATUS_MFR registers Signed-off-by: Titus Rwantare --- hw/i2c/pmbus_device.c | 24 include/hw/i2c/pmbus_device.h | 3 +++ 2 files changed, 27 insertions(+) diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c index 24f8f522d9

[PATCH v2 7/9] hw/sensor: add Renesas raa229004 PMBus device

2022-03-01 Thread Titus Rwantare
The Renesas RAA229004 is a PMBus Multiphase Voltage Regulator Signed-off-by: Titus Rwantare Reviewed-by: Hao Wu --- hw/sensor/isl_pmbus.c | 18 ++ include/hw/sensor/isl_pmbus.h | 1 + tests/qtest/isl_pmbus-test.c | 8 3 files changed, 27 insertions(+) diff

[PATCH v2 2/9] hw/i2c: pmbus: guard against out of range accesses

2022-03-01 Thread Titus Rwantare
Signed-off-by: Titus Rwantare --- hw/i2c/pmbus_device.c | 41 - 1 file changed, 40 insertions(+), 1 deletion(-) diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c index 07a45c99f9..93c746bab3 100644 --- a/hw/i2c/pmbus_device.c +++ b/hw/i2c

[PATCH v2 5/9] hw/i2c: Added linear mode translation for pmbus devices

2022-03-01 Thread Titus Rwantare
From: Shengtan Mao Signed-off-by: Shengtan Mao Reviewed-by: Titus Rwantare --- hw/i2c/pmbus_device.c | 18 ++ include/hw/i2c/pmbus_device.h | 20 +++- 2 files changed, 37 insertions(+), 1 deletion(-) diff --git a/hw/i2c/pmbus_device.c b/hw/i2c

[PATCH v3 2/9] hw/i2c: pmbus: guard against out of range accesses

2022-03-01 Thread Titus Rwantare
Signed-off-by: Titus Rwantare --- hw/i2c/pmbus_device.c | 41 - 1 file changed, 40 insertions(+), 1 deletion(-) diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c index 07a45c99f9..93c746bab3 100644 --- a/hw/i2c/pmbus_device.c +++ b/hw/i2c

[PATCH v3 0/9] This patch series contains updates to PMBus in QEMU along with some PMBus device models for Renesas regulators. I have also added myself to MAINTAINERS as this code is in use daily, whe

2022-03-01 Thread Titus Rwantare
Shengtan Mao (1): hw/i2c: Added linear mode translation for pmbus devices Titus Rwantare (8): hw/i2c: pmbus: add registers hw/i2c: pmbus: guard against out of range accesses hw/i2c: pmbus: add PEC unsupported warning hw/i2c: pmbus: refactor uint handling hw/i2c: pmbus: update MAINTAINERS

[PATCH v3 1/9] hw/i2c: pmbus: add registers

2022-03-01 Thread Titus Rwantare
- add the VOUT_MIN and STATUS_MFR registers Signed-off-by: Titus Rwantare --- hw/i2c/pmbus_device.c | 24 include/hw/i2c/pmbus_device.h | 3 +++ 2 files changed, 27 insertions(+) diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c index 24f8f522d9

[PATCH v3 8/9] hw/sensor: add Renesas raa229004 PMBus device

2022-03-01 Thread Titus Rwantare
The Renesas RAA229004 is a PMBus Multiphase Voltage Regulator Signed-off-by: Titus Rwantare Reviewed-by: Hao Wu --- hw/sensor/isl_pmbus_vr.c | 18 ++ include/hw/sensor/isl_pmbus_vr.h | 1 + tests/qtest/isl_pmbus_vr-test.c | 8 3 files changed, 27 insertions

[PATCH v3 6/9] hw/i2c: Added linear mode translation for pmbus devices

2022-03-01 Thread Titus Rwantare
From: Shengtan Mao Signed-off-by: Shengtan Mao Reviewed-by: Titus Rwantare --- hw/i2c/pmbus_device.c | 18 ++ include/hw/i2c/pmbus_device.h | 20 +++- 2 files changed, 37 insertions(+), 1 deletion(-) diff --git a/hw/i2c/pmbus_device.c b/hw/i2c

[PATCH v3 9/9] hw/sensor: add Renesas raa228000 device

2022-03-01 Thread Titus Rwantare
Signed-off-by: Titus Rwantare Reviewed-by: Hao Wu --- hw/sensor/isl_pmbus_vr.c | 50 include/hw/sensor/isl_pmbus_vr.h | 1 + tests/qtest/isl_pmbus_vr-test.c | 78 ++-- 3 files changed, 126 insertions(+), 3 deletions(-) diff --git a/hw

[PATCH v3 7/9] hw/sensor: add Intersil ISL69260 device model

2022-03-01 Thread Titus Rwantare
Signed-off-by: Titus Rwantare Reviewed-by: Hao Wu --- MAINTAINERS | 3 + hw/arm/Kconfig | 1 + hw/sensor/Kconfig| 5 + hw/sensor/isl_pmbus_vr.c | 211 + hw/sensor/meson.build| 1 + include/hw

[PATCH v3 5/9] hw/i2c: pmbus: update MAINTAINERS

2022-03-01 Thread Titus Rwantare
add self to MAINTAINERS for the PMBus subsystem and related sensors, and set PMBus as maintained. Signed-off-by: Titus Rwantare --- MAINTAINERS | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index fa8adc2618..3601984b5d 100644 --- a/MAINTAINERS +++ b

[PATCH v3 4/9] hw/i2c: pmbus: refactor uint handling

2022-03-01 Thread Titus Rwantare
This change cleans up the inputs to pmbus_receive uint, the length of received data is contained in PMBusDevice state and doesn't need to be passed around. Signed-off-by: Titus Rwantare --- hw/i2c/pmbus_device.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff

[PATCH v3 3/9] hw/i2c: pmbus: add PEC unsupported warning

2022-03-01 Thread Titus Rwantare
Signed-off-by: Titus Rwantare --- hw/i2c/pmbus_device.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c index 93c746bab3..6eeb0731d7 100644 --- a/hw/i2c/pmbus_device.c +++ b/hw/i2c/pmbus_device.c @@ -307,6 +307,11 @@ static uint8_t

Re: [PATCH 3/5] hw/sensor: add Intersil ISL69260 device model

2022-01-27 Thread Titus Rwantare
On Thu, 27 Jan 2022 at 11:39, Peter Maydell wrote: > > On Thu, 6 Jan 2022 at 23:19, Titus Rwantare wrote: > > > > +static uint8_t isl_pmbus_read_byte(PMBusDevice *pmdev) > > +{ > > +qemu_log_mask(LOG_GUEST_ERROR, > > + "%s: re

[PATCH 1/5] hw/i2c: pmbus updates

2022-01-06 Thread Titus Rwantare
- add vout min register - add PEC unsupported warning to pmbus_device class - guard against out of range pmbus page accesses Signed-off-by: Titus Rwantare Reviewed-by: Hao Wu --- MAINTAINERS | 12 - hw/i2c/pmbus_device.c | 88

[PATCH 0/5] Fixups for PMBus and new sensors

2022-01-06 Thread Titus Rwantare
This patch series contains updates to PMBus in QEMU along with some PMBus device models for Renesas regulators. I have also added myself to MAINTAINERS as this code is in use daily, where I am responsible for it. Shengtan Mao (1): hw/i2c: Added linear mode translation for pmbus devices Titus

[PATCH 3/5] hw/sensor: add Intersil ISL69260 device model

2022-01-06 Thread Titus Rwantare
Signed-off-by: Titus Rwantare Reviewed-by: Hao Wu --- MAINTAINERS | 3 + hw/arm/Kconfig| 1 + hw/sensor/Kconfig | 5 + hw/sensor/isl_pmbus.c | 210 +++ hw/sensor/meson.build | 1 + include/hw/sensor

[PATCH 2/5] hw/i2c: Added linear mode translation for pmbus devices

2022-01-06 Thread Titus Rwantare
From: Shengtan Mao Signed-off-by: Shengtan Mao Reviewed-by: Titus Rwantare --- hw/i2c/pmbus_device.c | 18 ++ include/hw/i2c/pmbus_device.h | 20 +++- 2 files changed, 37 insertions(+), 1 deletion(-) diff --git a/hw/i2c/pmbus_device.c b/hw/i2c

[PATCH 5/5] hw/misc: add Renesas raa228000 device

2022-01-06 Thread Titus Rwantare
Signed-off-by: Titus Rwantare Reviewed-by: Hao Wu --- hw/sensor/isl_pmbus.c | 50 ++ include/hw/sensor/isl_pmbus.h | 1 + tests/qtest/isl_pmbus-test.c | 78 +-- 3 files changed, 126 insertions(+), 3 deletions(-) diff --git a/hw

[PATCH 4/5] hw/sensor: add Renesas raa229004 PMBus device

2022-01-06 Thread Titus Rwantare
The Renesas RAA229004 is a PMBus Multiphase Voltage Regulator Signed-off-by: Titus Rwantare Reviewed-by: Hao Wu --- hw/sensor/isl_pmbus.c | 18 ++ include/hw/sensor/isl_pmbus.h | 1 + tests/qtest/isl_pmbus-test.c | 7 +++ 3 files changed, 26 insertions(+) diff

[PATCH v3 5/8] hw/sensor: add ADM1266 device model

2023-10-23 Thread Titus Rwantare
The ADM1266 is a cascadable super sequencer with margin control and fault recording. This commit adds basic support for its PMBus commands and models the identification registers that can be modified in a firmware update. Reviewed-by: Hao Wu Signed-off-by: Titus Rwantare --- hw/arm

[PATCH v3 1/8] hw/i2c: pmbus add support for block receive

2023-10-23 Thread Titus Rwantare
-by: Titus Rwantare --- hw/i2c/pmbus_device.c | 30 +- include/hw/i2c/pmbus_device.h | 7 +++ 2 files changed, 36 insertions(+), 1 deletion(-) diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c index cef51663d0..ea15490720 100644 --- a/hw/i2c

[PATCH v3 0/8] PMBus fixes and new functions

2023-10-23 Thread Titus Rwantare
: - Added fixes to PMBus: page resets and fault clearing Changes in v2: - Expanded commit descriptions - Added the ADM1266 device model that uses new functions Titus Rwantare (8): hw/i2c: pmbus add support for block receive hw/i2c: pmbus: add vout mode bitfields hw/i2c: pmbus: add

Re: [PATCH v3 0/8] PMBus fixes and new functions

2023-10-23 Thread Titus Rwantare
On Mon, 23 Oct 2023 at 12:16, Alex Bennée wrote: > You seem to have missed a number of tags from previous postings: > > > https://qemu.readthedocs.io/en/master/devel/submitting-a-patch.html#proper-use-of-reviewed-by-tags-can-aid-review > > (although I notice we only mention Reviewed-by in the

[PATCH v3 3/8] hw/i2c: pmbus: add fan support

2023-10-23 Thread Titus Rwantare
PMBus devices may integrate fans whose operation is configurable over PMBus. This commit allows the driver to read and write the fan control registers but does not model the operation of fans. Reviewed-by: Stephen Longfield Signed-off-by: Titus Rwantare --- hw/i2c/pmbus_device.c | 176

[PATCH v3 7/8] hw/i2c: pmbus: immediately clear faults on request

2023-10-23 Thread Titus Rwantare
The probing process of the generic pmbus driver generates faults to determine if functions are available. These faults were not always cleared resulting in probe failures. Signed-off-by: Titus Rwantare Reviewed-by: Patrick Venture --- hw/i2c/pmbus_device.c | 5 + 1 file changed, 5

[PATCH v3 8/8] hw/i2c: pmbus: reset page register for out of range reads

2023-10-23 Thread Titus Rwantare
. Signed-off-by: Titus Rwantare Reviewed-by: Hao Wu --- hw/i2c/pmbus_device.c | 18 +- tests/qtest/max34451-test.c | 24 2 files changed, 33 insertions(+), 9 deletions(-) diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c index 481e158380

[PATCH v3 6/8] tests/qtest: add tests for ADM1266

2023-10-23 Thread Titus Rwantare
The ADM1266 can have string fields written by the driver, so it's worth specifically testing. Reviewed-by: Hao Wu Signed-off-by: Titus Rwantare --- tests/qtest/adm1266-test.c | 123 + tests/qtest/meson.build| 1 + 2 files changed, 124 insertions

[PATCH v3 4/8] hw/i2c: pmbus: add VCAP register

2023-10-23 Thread Titus Rwantare
VCAP is a register for devices with energy storage capacitors. Reviewed-by: Benjamin Streb Signed-off-by: Titus Rwantare --- hw/i2c/pmbus_device.c | 8 include/hw/i2c/pmbus_device.h | 1 + 2 files changed, 9 insertions(+) diff --git a/hw/i2c/pmbus_device.c b/hw/i2c

[PATCH v3 2/8] hw/i2c: pmbus: add vout mode bitfields

2023-10-23 Thread Titus Rwantare
to scale the voltage readings. Reviewed-by: Hao Wu Signed-off-by: Titus Rwantare --- include/hw/i2c/pmbus_device.h | 8 1 file changed, 8 insertions(+) diff --git a/include/hw/i2c/pmbus_device.h b/include/hw/i2c/pmbus_device.h index 7dc00cc4d9..2e95164aa1 100644 --- a/include/hw/i2c

Re: [PATCH v3 0/8] PMBus fixes and new functions

2023-10-24 Thread Titus Rwantare
On Tue, 24 Oct 2023 at 04:50, Philippe Mathieu-Daudé wrote: > > On 24/10/23 12:06, Alex Bennée wrote: > > > A pull request is really just a GPG signed tag that you push to a repo. > > You can use the existing git tooling to create the cover letter for it. > > > > I've included my exact steps at

Re: [PATCH v2 0/7] Add Qualcomm BMC machines

2022-06-27 Thread Titus Rwantare
You can take them through the aspeed branch. Thanks. -Titus On Mon, 27 Jun 2022 at 09:33, Cédric Le Goater wrote: > > Hello Titus, > > On 6/27/22 17:46, Jae Hyun Yoo wrote: > > Hello, > > > > I'm sending a series to add Qualcomm BMC machines that are equipped with > > Aspeed AST2600 SoC. Also,

  1   2   >