Re: [Qemu-devel] [RFC v1 1/1] virtio-crypto: Allow disabling of cipher algorithms for virtio-crypto device

2018-06-18 Thread Viktor VM Mihajlovski
On 15.06.2018 17:10, Farhan Ali wrote: > > > On 06/15/2018 09:17 AM, Viktor VM Mihajlovski wrote: [...] >> >> With the current virtio-crypto backend functionality offered (CBC AES >> only) it may seem a bit over-engineered to offer a configuration option >> to re

Re: [Qemu-devel] [qemu-s390x] [PATCH v2 0/4] pc-bios/s390-ccw: Allow network booting via pxelinux.cfg

2018-06-13 Thread Viktor VM Mihajlovski
On 12.06.2018 08:17, Thomas Huth wrote: > On 11.06.2018 14:03, Viktor VM Mihajlovski wrote: [...] > > If you have the time to look at the traffic, could you please also check > the TFTP block size option that is negotiated at the beginning of the > TFTP transfer? If th

Re: [Qemu-devel] [RFC v1 1/1] virtio-crypto: Allow disabling of cipher algorithms for virtio-crypto device

2018-06-15 Thread Viktor VM Mihajlovski
On 14.06.2018 18:12, Farhan Ali wrote: > > > On 06/14/2018 11:10 AM, Daniel P. Berrangé wrote: >> On Thu, Jun 14, 2018 at 10:50:40AM -0400, Farhan Ali wrote: >>> >>> >>> On 06/14/2018 04:21 AM, Daniel P. Berrangé wrote: On Wed, Jun 13, 2018 at 07:28:08PM +0200, Halil Pasic wrote: >

Re: [Qemu-devel] [PATCH v2 0/4] pc-bios/s390-ccw: Allow network booting via pxelinux.cfg

2018-06-11 Thread Viktor VM Mihajlovski
On 07.06.2018 14:22, Thomas Huth wrote: > This patch series adds pxelinux.cfg-style network booting to the s390-ccw > firmware. The core pxelinux.cfg loading and parsing logic has recently > been merged to SLOF, so these patches now just have to make sure to call > the right functions to get the

Re: [Qemu-devel] [PATCH v2 0/4] pc-bios/s390-ccw: Allow network booting via pxelinux.cfg

2018-06-11 Thread Viktor VM Mihajlovski
On 11.06.2018 13:12, Thomas Huth wrote: > On 11.06.2018 11:08, Viktor VM Mihajlovski wrote: >> On 07.06.2018 14:22, Thomas Huth wrote: >>> This patch series adds pxelinux.cfg-style network booting to the s390-ccw >>> firmware. The core pxelinux.cfg loading and parsing

Re: [Qemu-devel] [PATCH 2/3] pc-bios/s390-ccw/net: Add support for pxelinux-style config files

2018-05-30 Thread Viktor VM Mihajlovski
On 30.05.2018 11:16, Thomas Huth wrote: > Since it is quite cumbersome to manually create a combined kernel with > initrd image for network booting, we now support loading via pxelinux > configuration files, too. In these files, the kernel, initrd and command > line parameters can be specified

Re: [Qemu-devel] [PATCH 3/3] s390: Do not pass inofficial IPL type to the guest

2018-04-06 Thread Viktor VM Mihajlovski
On 06.04.2018 11:28, Thomas Huth wrote: > On 05.04.2018 17:07, Viktor Mihajlovski wrote: >> IPL over a virtio-scsi device requires special handling not >> available in the real architecture. For this purpose the IPL >> type 0xFF has been chosen as means of communication between >> QEMU and the

Re: [Qemu-devel] [PATCH 3/3] s390: Do not pass inofficial IPL type to the guest

2018-04-05 Thread Viktor VM Mihajlovski
On 05.04.2018 17:11, David Hildenbrand wrote: > On 05.04.2018 17:07, Viktor Mihajlovski wrote: >> IPL over a virtio-scsi device requires special handling not >> available in the real architecture. For this purpose the IPL >> type 0xFF has been chosen as means of communication between >> QEMU and

Re: [Qemu-devel] [PATCH v1 for-2.13 3/4] pc-bios/s390-ccw/net: Add support for pxelinux-style config files

2018-04-19 Thread Viktor VM Mihajlovski
On 18.04.2018 14:31, Thomas Huth wrote: > Since it is quite cumbersome to manually create a combined kernel with > initrd image for network booting, we now support loading via pxelinux > configuration files, too. In these files, the kernel, initrd and command > line parameters can be specified

Re: [Qemu-devel] [PATCH v1 for-2.13 3/4] pc-bios/s390-ccw/net: Add support for pxelinux-style config files

2018-04-19 Thread Viktor VM Mihajlovski
On 19.04.2018 10:17, Thomas Huth wrote: > On 19.04.2018 09:41, Viktor VM Mihajlovski wrote: >> On 18.04.2018 14:31, Thomas Huth wrote: >>> Since it is quite cumbersome to manually create a combined kernel with >>> initrd image for network booting, we now s

Re: [Qemu-devel] [PATCH v1 for-2.13 4/4] pc-bios/s390-ccw/net: Add support for .INS config files

2018-04-19 Thread Viktor VM Mihajlovski
On 18.04.2018 14:31, Thomas Huth wrote: > The .INS config files can normally be found on CD-ROM ISO images, > so by supporting these files, it is now possible to boot directly > when the TFTP server is set up with the contents of such an CD-ROM > image. > > Signed-off-by: Thomas Huth

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 for-2.13 3/4] pc-bios/s390-ccw/net: Add support for pxelinux-style config files

2018-04-20 Thread Viktor VM Mihajlovski
On 19.04.2018 18:55, Thomas Huth wrote: > On 19.04.2018 14:40, Viktor VM Mihajlovski wrote: >> On 19.04.2018 10:17, Thomas Huth wrote: >>> On 19.04.2018 09:41, Viktor VM Mihajlovski wrote: >>>> On 18.04.2018 14:31, Thomas Huth wrote: >>>>> Since it is q

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 for-2.13 3/4] pc-bios/s390-ccw/net: Add support for pxelinux-style config files

2018-04-20 Thread Viktor VM Mihajlovski
On 20.04.2018 09:36, Thomas Huth wrote: > On 20.04.2018 08:53, Viktor VM Mihajlovski wrote: >> On 19.04.2018 18:55, Thomas Huth wrote: [...] >> Well, if we don't add another identifier, and I feel reluctant about it >> as well for the reasons you wrote, we may stick w

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 for-2.13 3/4] pc-bios/s390-ccw/net: Add support for pxelinux-style config files

2018-04-20 Thread Viktor VM Mihajlovski
On 20.04.2018 10:40, Thomas Huth wrote: > On 20.04.2018 09:54, Viktor VM Mihajlovski wrote: >> On 20.04.2018 09:36, Thomas Huth wrote: >>> On 20.04.2018 08:53, Viktor VM Mihajlovski wrote: >>>> On 19.04.2018 18:55, Thomas Huth wrote: >> [...] >>>>

Re: [Qemu-devel] [PATCH v3 0/3] pc-bios/s390-ccw: Some few network boot improvements

2018-04-25 Thread Viktor VM Mihajlovski
On 25.04.2018 11:08, Thomas Huth wrote: > Note: I've decided to removed the pxelinux.cfg patches from this series > for now, since full pxelinux support requires to parse some additional > DHCP options (see https://tools.ietf.org/html/rfc5071), and for this, the > SLOF libnet code needs to be

Re: [Qemu-devel] [PATCH 2/6] qapi: handle the riscv CpuInfoArch in query-cpus-fast

2018-04-25 Thread Viktor VM Mihajlovski
On 25.04.2018 09:48, Cornelia Huck wrote: > On Wed, 25 Apr 2018 08:44:15 +0200 > Markus Armbruster wrote: > >> Laszlo Ersek writes: >> >>> Commit 25fa194b7b11 added the @riscv enum constant to @CpuInfoArch (used >>> in both @CpuInfo and @CpuInfoFast -- the

Re: [Qemu-devel] [PATCH v2 2/4] pc-bios/s390-ccw/net: Add support for pxelinux-style config files

2018-04-24 Thread Viktor VM Mihajlovski
On 23.04.2018 09:58, Thomas Huth wrote: > Since it is quite cumbersome to manually create a combined kernel with > initrd image for network booting, we now support loading via pxelinux > configuration files, too. In these files, the kernel, initrd and command > line parameters can be specified

Re: [Qemu-devel] [PATCH v2 2/4] pc-bios/s390-ccw/net: Add support for pxelinux-style config files

2018-04-24 Thread Viktor VM Mihajlovski
On 24.04.2018 13:23, Thomas Huth wrote: > On 24.04.2018 13:07, Viktor VM Mihajlovski wrote: >> On 23.04.2018 09:58, Thomas Huth wrote: >>> Since it is quite cumbersome to manually create a combined kernel with >>> initrd image for network booting, we now s

Re: [Qemu-devel] [PATCH v2 2/4] pc-bios/s390-ccw/net: Add support for pxelinux-style config files

2018-04-24 Thread Viktor VM Mihajlovski
On 23.04.2018 09:58, Thomas Huth wrote: [...] > + > +static int net_try_pxelinux_cfgs(filename_ip_t *fn_ip) > +{ > +int rc, idx; > +char basedir[256]; > +int has_basedir; > + > +cfgbuf[sizeof(cfgbuf) - 1] = 0; /* Make sure that it is NUL-terminated > */ > + > +/* Did we get