Re: [Qemu-devel] [PATCH] e1000/rtl8139: update HMP NIC when every bit is written

On 11/07/2013 10:27 AM, Michael S. Tsirkin wrote: On Thu, Nov 07, 2013 at 07:33:57AM -0700, Alex Williamson wrote: On Thu, 2013-11-07 at 12:26 +0200, Michael S. Tsirkin wrote: On Thu, Nov 07, 2013 at 03:32:29PM +0800, Amos Kong wrote: On Thu, Nov 07, 2013 at 08:59:22AM +0200, Michael S.

Re: [Qemu-devel] [PATCH] e1000/rtl8139: update HMP NIC when every bit is written

On 11/07/2013 09:33 AM, Alex Williamson wrote: On Thu, 2013-11-07 at 12:26 +0200, Michael S. Tsirkin wrote: On Thu, Nov 07, 2013 at 03:32:29PM +0800, Amos Kong wrote: On Thu, Nov 07, 2013 at 08:59:22AM +0200, Michael S. Tsirkin wrote: On Tue, Nov 05, 2013 at 07:17:18PM +0800, Amos Kong wrote:

[Qemu-devel] [PATCH] qdev-properties-system.c: Allow vlan or netdev for -device, not both

a segmentation fault on exit in qemu_free_net_client. That patch treates the above command line options as invalid and generates an error at start-up. Signed-off-by: Vlad Yasevich vyase...@redhat.com --- hw/core/qdev-properties-system.c | 9 + 1 file changed, 9 insertions(+) diff --git

[Qemu-devel] [PATCH] virtio-net: Correctly store multicast filter entries

in the filter. The multicast addresses should be written after all the unicast addresses. Signed-off-by: Vlad Yasevich vyase...@redhat.com --- hw/net/virtio-net.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 22dbd05..94e8b68

Re: [Qemu-devel] [PATCH] virtio-net: Correctly store multicast filter entries

On 11/08/2013 11:07 AM, Vlad Yasevich wrote: Commit 921ac5d0f3a0df869db5ce4edf752f51d8b1596a virtio-net: remove layout assumptions for ctrl vq introduced a regression where the multicast address filter entries are written to the beginning of the mac table array, thus overwriting any

[Qemu-devel] [PATCH] e1000/rtl8139: update HMP NIC when every bit is written

to update HMP NIC info when every bit has been changed. It will be same as virtio-net. Signed-off-by: Vlad Yasevich vyase...@redhat.com --- hw/net/e1000.c | 17 - hw/net/rtl8139.c | 14 +- 2 files changed, 25 insertions(+), 6 deletions(-) diff --git a/hw/net/e1000.c

Re: [Qemu-devel] [PATCH] e1000/rtl8139: update HMP NIC when every bit is written

On 11/10/2013 07:11 AM, Michael S. Tsirkin wrote: On Fri, Nov 08, 2013 at 02:42:27PM -0500, Vlad Yasevich wrote: What about this approach? This only updates the monitory when all the bits have been written to. -vlad Thanks! Some comments below. -- 8 -- Subject: [PATCH] e1000/rtl8139

Re: [Qemu-devel] [PATCH] e1000/rtl8139: update HMP NIC when every bit is written

On 11/08/2013 10:43 PM, Amos Kong wrote: On Fri, Nov 08, 2013 at 02:42:27PM -0500, Vlad Yasevich wrote: What about this approach? This only updates the monitory when all the bits have been written to. Hi Vlad, Looks good to me. Using this patch, we don't need to care the writing order

Re: [Qemu-devel] [PATCH] virtio-net: don't update mac_table in error state

. Otherwise, looks good to me. Reviewed-by: Vlad Yasevich vyase...@redhat.com -vlad s = iov_to_buf(iov, iov_cnt, 0, mac_data.entries, sizeof(mac_data.entries)); @@ -629,19 +629,19 @@ static int virtio_net_handle_mac(VirtIONet *n, uint8_t cmd

Re: [Qemu-devel] [PATCH] e1000/rtl8139: update HMP NIC when every bit is written

On 11/10/2013 07:11 AM, Michael S. Tsirkin wrote: On Fri, Nov 08, 2013 at 02:42:27PM -0500, Vlad Yasevich wrote: What about this approach? This only updates the monitory when all the bits have been written to. -vlad Thanks! Some comments below. -- 8 -- Subject: [PATCH] e1000/rtl8139

Re: [Qemu-devel] [PATCH] e1000/rtl8139: update HMP NIC when every bit is written

On 11/13/2013 03:00 PM, Michael S. Tsirkin wrote: On Wed, Nov 13, 2013 at 11:21:18AM -0500, Vlad Yasevich wrote: On 11/10/2013 07:11 AM, Michael S. Tsirkin wrote: On Fri, Nov 08, 2013 at 02:42:27PM -0500, Vlad Yasevich wrote: What about this approach? This only updates the monitory when all

Re: [Qemu-devel] [PATCH v2] pc: add 1.8 machine type

On 11/14/2013 05:37 AM, Michael S. Tsirkin wrote: -#define PC_Q35_1_7_MACHINE_OPTIONS PC_Q35_MACHINE_OPTIONS +#define PC_Q35_1_8_MACHINE_OPTIONS PC_Q35_MACHINE_OPTIONS + +static QEMUMachine pc_q35_machine_v1_8 = { +PC_Q35_1_8_MACHINE_OPTIONS, +.name = pc-q35-1.8, +.alias = q35, +

Re: [Qemu-devel] [PATCH] net: move rxfilter_notify() to net.c

On 11/15/2013 10:27 AM, Stefan Hajnoczi wrote: On Tue, Nov 05, 2013 at 07:00:48PM +0800, Amos Kong wrote: @@ -545,7 +523,7 @@ static int virtio_net_handle_rx_mode(VirtIONet *n, uint8_t cmd, return VIRTIO_NET_ERR; } -rxfilter_notify(nc); +rxfilter_notify(nc,

[Qemu-devel] [PATCH] qom: Fix memory leak in object_property_set_link()

Save the result of the call to object_get_cannonical_path() so we can free it. Signed-off-by: Vlad Yasevich vyase...@redhat.com --- qom/object.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/qom/object.c b/qom/object.c index b617f26..21b6f87 100644 --- a/qom/object.c

Re: [Qemu-devel] [PATCH] qom: Fix memory leak in object_property_set_link()

On 11/15/2013 12:06 PM, Vlad Yasevich wrote: Save the result of the call to object_get_cannonical_path() so we can free it. Signed-off-by: Vlad Yasevich vyase...@redhat.com --- qom/object.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/qom/object.c b/qom/object.c

[Qemu-devel] [PATCH v2] qom: Fix memory leak in object_property_set_link()

Save the result of the call to object_get_cannonical_path() so we can free it. Signed-off-by: Vlad Yasevich vyase...@redhat.com --- v1-v2: Builds and works :) qom/object.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/qom/object.c b/qom/object.c index b617f26

Re: [Qemu-devel] [PATCH] virtio-net: fix the memory leak in rxfilter_notify()

On 11/18/2013 08:47 AM, Amos Kong wrote: object_get_canonical_path() returns a gchar*, it should be freeed by the caller. Signed-off-by: Amos Kong ak...@redhat.com Reviewed-by: Vlad Yasevich vyase...@redhat.com -vlad --- hw/net/virtio-net.c | 8 1 file changed, 4 insertions

Re: [Qemu-devel] [PATCH v2] virtio-net: fix the memory leak in rxfilter_notify()

On 11/18/2013 10:32 AM, Amos Kong wrote: object_get_canonical_path() returns a gchar*, it should be freeed by the caller. Signed-off-by: Amos Kong ak...@redhat.com Reviewed-by: Vlad Yasevich vyase...@redhat.com -vlad --- v2: put gchar *path inside rxfilter_notify_enabled block --- hw

Re: [Qemu-devel] [PATCH] e1000/rtl8139: update HMP NIC when every bit is written

On 11/18/2013 10:02 AM, Michael S. Tsirkin wrote: On Tue, Nov 05, 2013 at 07:17:18PM +0800, Amos Kong wrote: We currently just update the HMP NIC info when the last bit of macaddr is written. This assumes that guest driver will write all the macaddr from bit 0 to bit 5 when it changes the

Re: [Qemu-devel] [PATCH] e1000/rtl8139: update HMP NIC when every bit is written

On 11/18/2013 02:42 PM, Michael S. Tsirkin wrote: On Mon, Nov 18, 2013 at 12:33:20PM -0500, Vlad Yasevich wrote: On 11/18/2013 10:02 AM, Michael S. Tsirkin wrote: On Tue, Nov 05, 2013 at 07:17:18PM +0800, Amos Kong wrote: We currently just update the HMP NIC info when the last bit of macaddr

Re: [Qemu-devel] [PATCH for-1.7] Revert e1000/rtl8139: update HMP NIC when every bit is written

-by: Vlad Yasevich vyase...@redhat.com Cc: Amos Kong ak...@redhat.com Cc: Alex Williamson alex.william...@redhat.com Reviewed-by: Vlad Yasevich vyase...@redhat.com. -vlad --- hw/net/e1000.c | 2 +- hw/net/rtl8139.c | 5 - 2 files changed, 5 insertions(+), 2 deletions(-) diff --git

Re: [Qemu-devel] [PATCH for-1.7] Revert e1000/rtl8139: update HMP NIC when every bit is written

Reported-by: Vlad Yasevich vyase...@redhat.com Cc: Amos Kong ak...@redhat.com Cc: Alex Williamson alex.william...@redhat.com --- hw/net/e1000.c | 2 +- hw/net/rtl8139.c | 5 - 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/net/e1000.c b/hw/net/e1000.c index

Re: [Qemu-devel] [PATCH for-1.7] Revert e1000/rtl8139: update HMP NIC when every bit is written

On 11/18/2013 03:33 PM, Alex Williamson wrote: On Mon, 2013-11-18 at 15:09 -0500, Vlad Yasevich wrote: On 11/18/2013 02:58 PM, Alex Williamson wrote: On Mon, 2013-11-18 at 21:47 +0200, Michael S. Tsirkin wrote: This reverts commit cd5be5829c1ce87aa6b3a7806524fac07ac9a757. Digging

Re: [Qemu-devel] [PATCH for-1.7] Revert e1000/rtl8139: update HMP NIC when every bit is written

On 11/18/2013 04:33 PM, Alex Williamson wrote: On Mon, 2013-11-18 at 15:57 -0500, Vlad Yasevich wrote: On 11/18/2013 03:33 PM, Alex Williamson wrote: On Mon, 2013-11-18 at 15:09 -0500, Vlad Yasevich wrote: On 11/18/2013 02:58 PM, Alex Williamson wrote: On Mon, 2013-11-18 at 21:47 +0200

Re: [Qemu-devel] [PATCH for-1.7] Revert e1000/rtl8139: update HMP NIC when every bit is written

On 11/18/2013 05:40 PM, Alex Williamson wrote: On Mon, 2013-11-18 at 17:07 -0500, Vlad Yasevich wrote: On 11/18/2013 04:33 PM, Alex Williamson wrote: On Mon, 2013-11-18 at 15:57 -0500, Vlad Yasevich wrote: On 11/18/2013 03:33 PM, Alex Williamson wrote: On Mon, 2013-11-18 at 15:09 -0500, Vlad

[Qemu-devel] [RFC PATCH 2/2] rtl8139: update HMP only when the address is fully written

the mac address has been completely written. Simple set a flag whenever mac has changed and at the next transition of 9346 register from Write to Normal mode, we update the HMP. Signed-off-by: Vlad Yasevich vyase...@redhat.com --- hw/i386/pc_piix.c| 4 hw/i386/pc_q35.c | 4 hw

[Qemu-devel] [RFC PATCH 1/2] e1000: Use Address_Available bit as HW latch

of the Receive Address Register, so that we would not try to match received traffic to this address when it is not completely set. Signed-off-by: Vlad Yasevich vyase...@redhat.com --- hw/net/e1000.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/hw/net

[Qemu-devel] [PATCH] net: Update netdev peer on link change

will not configure the link-local IPv4 address, and when the link is turned on, the proper address address is configured. Signed-off-by: Vlad Yasevich vyase...@redhat.com --- net/net.c | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/net/net.c b/net

[Qemu-devel] [RFC PATCH 0/2] Update HMP only upon mac change completion.

, but rtl8139 isn't as nice. Please take a look and I'd like to hear your comments. Thanks -vlad Vlad Yasevich (2): e1000: Use Address_Available bit as HW latch rtl8139: update HMP only when the address is fully written hw/i386/pc_piix.c| 4 hw/i386/pc_q35.c | 4 hw/net/e1000.c

Re: [Qemu-devel] [PATCH for-1.7] qdev-properties-system.c: Allow vlan or netdev for -device, not both

On 11/11/2013 02:50 AM, Paolo Bonzini wrote: Il 11/11/2013 06:18, Jason Wang ha scritto: On 11/08/2013 10:13 AM, Vlad Yasevich wrote: It is currently possible to specify things like: -device e1000,netdev=foo,vlan=1 With this usage, whichever argument was specified last (vlan or netdev

Re: [Qemu-devel] [RFC PATCH 1/2] e1000: Use Address_Available bit as HW latch

On 11/22/2013 04:47 AM, Jason Wang wrote: On 11/22/2013 04:04 AM, Vlad Yasevich wrote: e1000 provides a E1000_RAH_AV bit on every complete write to the Receive Address Register. We can use this bit 2 ways: 1) To trigger HMP notifications. When the bit is set the mac address is fully

Re: [Qemu-devel] [PATCH v2 for 2.0] virtio-net: Do not filter VLANs without F_CTRL_VLAN

(tap_get_vhost_net(nc-peer), features); } + +if ((1 VIRTIO_NET_F_CTRL_VLAN) features) { +memset(n-vlans, 0, MAX_VLAN 3); +} else { +memset(n-vlans, 0xff, MAX_VLAN 3); +} } static int virtio_net_handle_rx_mode(VirtIONet *n, uint8_t cmd, Reviewed-by: Vlad

Re: [Qemu-devel] [PATCH] net: Update netdev peer on link change

On 04/02/2014 04:51 AM, Michael S. Tsirkin wrote: On Thu, Nov 21, 2013 at 09:05:51PM -0500, Vlad Yasevich wrote: When a link change occurs on a backend (like tap), we currently do not propage such change to the nic. As a result, when someone turns off a link on a tap device, for instance

Re: [Qemu-devel] [PATCH] net: Update netdev peer on link change

On 04/02/2014 06:46 AM, Yan Vugenfirer wrote: On Apr 2, 2014, at 11:51 AM, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Nov 21, 2013 at 09:05:51PM -0500, Vlad Yasevich wrote: When a link change occurs on a backend (like tap), we currently do not propage such change to the nic

Re: [Qemu-devel] [PATCH] net: Update netdev peer on link change

On 04/02/2014 11:03 AM, Michael S. Tsirkin wrote: On Wed, Apr 02, 2014 at 10:57:08AM -0400, Vlad Yasevich wrote: On 04/02/2014 06:46 AM, Yan Vugenfirer wrote: On Apr 2, 2014, at 11:51 AM, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Nov 21, 2013 at 09:05:51PM -0500, Vlad Yasevich wrote

Re: [Qemu-devel] [PATCH] net: Update netdev peer on link change

On 04/02/2014 11:29 AM, Michael S. Tsirkin wrote: On Wed, Apr 02, 2014 at 11:25:32AM -0400, Vlad Yasevich wrote: On 04/02/2014 11:03 AM, Michael S. Tsirkin wrote: On Wed, Apr 02, 2014 at 10:57:08AM -0400, Vlad Yasevich wrote: On 04/02/2014 06:46 AM, Yan Vugenfirer wrote: On Apr 2, 2014

Re: [Qemu-devel] [PATCH] virtio-net: only output the vlan table when VIRTIO_NET_F_CTRL_VLAN is negotiated

On 02/16/2014 09:27 PM, Amos Kong wrote: Stefan Fritsch just fixed a virtio-net driver bug [1], virtio-net won't filter out VLAN-tagged packets if VIRTIO_NET_F_CTRL_VLAN isn't negotiated. We should also not send the vlan table to management, this patch makes the vlan-talbe optional.

Re: [Qemu-devel] [PATCH] virtio-net: only output the vlan table when VIRTIO_NET_F_CTRL_VLAN is negotiated

revoke my R-b, on the following grounds: On 02/17/2014 08:27 AM, Vlad Yasevich wrote: On 02/16/2014 09:27 PM, Amos Kong wrote: Stefan Fritsch just fixed a virtio-net driver bug [1], virtio-net won't filter out VLAN-tagged packets if VIRTIO_NET_F_CTRL_VLAN isn't negotiated. We should also

Re: [Qemu-devel] [PATCH] virtio-net: only output the vlan table when VIRTIO_NET_F_CTRL_VLAN is negotiated

On 02/18/2014 05:06 AM, Michael S. Tsirkin wrote: On Mon, Feb 17, 2014 at 11:58:11AM -0500, Vlad Yasevich wrote: On 02/17/2014 11:56 AM, Eric Blake wrote: On 02/17/2014 09:52 AM, Eric Blake wrote: On 02/16/2014 07:27 PM, Amos Kong wrote: Stefan Fritsch just fixed a virtio-net driver bug [1

Re: [Qemu-devel] [PATCH v2] virtio-net: add a field to indicate if vlan table is used

On 02/20/2014 11:38 AM, Amos Kong wrote: Stefan Fritsch just fixed a virtio-net driver bug [1], virtio-net won't filter out VLAN-tagged packets if VIRTIO_NET_F_CTRL_VLAN isn't negotiated. This patch added a new field to @RxFilterInfo to indicate if management uses the vlan table. [1]

Re: [Qemu-devel] [Bug 1362755] [NEW] QEmu +2 does not route VLAN tagged packets, that are originated within the Hypervisor itself.

On 08/28/2014 02:40 PM, Thiago Martins wrote: Public bug reported: Guys, Trusty QEmu 2.0 Hypervisor fails to create a consistent virtual network. It does not route tagged VLAN packets. The have a been a bunch of rather recent changes to the kernel to support guest VLANs correctly. The

Re: [Qemu-devel] [Bug 1362755] [NEW] QEmu +2 does not route VLAN tagged packets, that are originated within the Hypervisor itself.

[ realized that the bug and reporter were non cc'd, updated cc list] On 08/28/2014 02:40 PM, Thiago Martins wrote: Public bug reported: Guys, Trusty QEmu 2.0 Hypervisor fails to create a consistent virtual network. It does not route tagged VLAN packets. The have a been a bunch of

Re: [Qemu-devel] [PATCH] net: Fix link state inter-dependencies between NIC and backend

On 04/02/2015 05:21 AM, Stefan Hajnoczi wrote: On Thu, Apr 02, 2015 at 08:11:15AM +0200, Michael S. Tsirkin wrote: On Wed, Apr 01, 2015 at 07:55:38PM -0400, Vladislav Yasevich wrote: Commit 02d38fcb2caa4454cf4ed728d5908c3cc9ba47be net: Update netdev peer on link change introduced a link

Re: [Qemu-devel] [Qemu-discuss] GRO not happening in VM with VxLAN

any device features # ethtool -k tap0 | grep -i tnl tx-udp_tnl-segmentation: off [fixed] On Tue, Jun 30, 2015 at 12:24 PM, Santosh R skrasta...@gmail.com wrote: On Mon, Jun 29, 2015 at 9:24 PM, Santosh R skrasta...@gmail.com wrote: On Mon, Jun 29, 2015 at 9:04 PM, Vlad Yasevich vyase

Re: [Qemu-devel] [Qemu-discuss] GRO not happening in VM with VxLAN

On 06/29/2015 01:46 AM, Santosh R wrote: All, I am testing VxLAN performance in VM. For this I am using below command to bring up the VM. # qemu-system-x86_64 -m 4096 -smp 4 -boot c -device virtio-net-pci,netdev=tap0,mac=00:11:22:33:44:55 -netdev tap,id=tap0,script=no,vhost=on -drive

Re: [Qemu-devel] [PATCH 2/2] rtl8139: correctly track full receive buffer in standard mode

On 08/26/2015 08:36 AM, Stefan Hajnoczi wrote: On Fri, Aug 21, 2015 at 02:59:25PM -0700, Vladislav Yasevich wrote: In standard operation mode, when the receive ring buffer is full, the buffer actually appears empty to the driver since the RxBufAddr (the location we wirte new data to) and

Re: [Qemu-devel] [PATCH 1/2] rtl8139: Do not consume the packet during overflow in standard mode.

On 08/26/2015 08:18 AM, Stefan Hajnoczi wrote: On Fri, Aug 21, 2015 at 02:59:24PM -0700, Vladislav Yasevich wrote: When operation in standard mode, we currently return the size of packet during buffer overflow. This consumes the overflow packet. Return 0 instead so we can re-process the

Re: [Qemu-devel] [PATCH v2 0/2] rtl8139: Fix buffer overflow in standard mode

On 08/26/2015 03:51 PM, Vladislav Yasevich wrote: When rtl8139 card is running in standard mode, it is very easy to overlflow and the receive buffer and get into a siutation where all packets are dropped. Simply reproduction case is to ping the guest from the host with 6500 byte packets.

Re: [Qemu-devel] [PATCH v3 2/2] rtl8139: correctly track full receive buffer in standard mode

On 08/31/2015 05:59 AM, Jason Wang wrote: > > > On 08/28/2015 10:06 PM, Vladislav Yasevich wrote: >> In standard operation mode, when the receive ring buffer >> is full, the buffer actually appears empty to the driver since >> the RxBufAddr (the location we wirte new data to) and RxBufPtr >>

Re: [Qemu-devel] [PATCH v3 2/2] rtl8139: correctly track full receive buffer in standard mode

On 08/31/2015 11:15 PM, Jason Wang wrote: > > > On 08/31/2015 10:24 PM, Vlad Yasevich wrote: >> On 08/31/2015 05:59 AM, Jason Wang wrote: >>> >>> On 08/28/2015 10:06 PM, Vladislav Yasevich wrote: >>>> In standard operation mode, when the receive

Re: [Qemu-devel] [PATCH] virtio-net: consolidate guest announcement with qemu_announce_self

On 03/29/2017 04:35 PM, Michael S. Tsirkin wrote: > On Wed, Mar 29, 2017 at 04:19:50PM -0400, Vladislav Yasevich wrote: >> virtio announcements seem to run on its own timer with it's own >> repetition loop and are invoked separately from qemu_announce_self. >> This patch consolidates announcements

Re: [Qemu-devel] [PATCH] virtio-net: consolidate guest announcement with qemu_announce_self

On 03/30/2017 04:24 AM, Dr. David Alan Gilbert wrote: > * Vladislav Yasevich (vyase...@redhat.com) wrote: >> virtio announcements seem to run on its own timer with it's own >> repetition loop and are invoked separately from qemu_announce_self. >> This patch consolidates announcements into a single

Re: [Qemu-devel] [PATCH] virtio-net: consolidate guest announcement with qemu_announce_self

On 03/30/2017 10:53 AM, Dr. David Alan Gilbert wrote: > * Vlad Yasevich (vyase...@redhat.com) wrote: >> On 03/30/2017 04:24 AM, Dr. David Alan Gilbert wrote: >>> * Vladislav Yasevich (vyase...@redhat.com) wrote: >>>> virtio announcements seem to run on its own timer

Re: [Qemu-devel] [PATCH] virtio-net: consolidate guest announcement with qemu_announce_self

On 03/30/2017 11:26 AM, Dr. David Alan Gilbert wrote: > * Vlad Yasevich (vyase...@redhat.com) wrote: >> On 03/30/2017 10:53 AM, Dr. David Alan Gilbert wrote: >>> * Vlad Yasevich (vyase...@redhat.com) wrote: >>>> On 03/30/2017 04:24 AM, Dr. David Alan Gilbert wro

Re: [Qemu-devel] [PATCH V2] migration: expose qemu_announce_self() via qmp

On 05/12/2017 03:24 PM, Dr. David Alan Gilbert wrote: > * Vlad Yasevich (vyase...@redhat.com) wrote: >> On 02/20/2017 07:16 PM, Germano Veit Michel wrote: >>> qemu_announce_self() is triggered by qemu at the end of migrations >>> to update the network regarding t

Re: [Qemu-devel] [PATCH V2] migration: expose qemu_announce_self() via qmp

On 02/20/2017 07:16 PM, Germano Veit Michel wrote: > qemu_announce_self() is triggered by qemu at the end of migrations > to update the network regarding the path to the guest l2addr. > > however it is also useful when there is a network change such as > an active bond slave swap. Essentially,

Re: [Qemu-devel] [PATCH v2] virtio_net: Bypass backends for MTU feature negotiation

to succeed. > > For compatibility purpose, this property is disabled for machine > types v2.9 and older. > > Cc: Aaron Conole <acon...@redhat.com> > Suggested-by: Michael S. Tsirkin <m...@redhat.com> > Signed-off-by: Maxime Coquelin <maxime.coque...@redhat.

Re: [Qemu-devel] [PATCH 03/12] migration: Switch to using announcement timer

On 05/26/2017 12:16 AM, Jason Wang wrote: > > > On 2017年05月25日 02:05, Vladislav Yasevich wrote: >> Switch qemu_announce_self and virtio annoucements to use >> the announcement timer framework. This makes sure that both >> timers use the same timeouts and number of annoucement attempts >> >>

Re: [Qemu-devel] [PATCH 01/12] migration: Introduce announce parameters

On 05/26/2017 12:03 AM, Jason Wang wrote: > > On 2017年05月25日 02:05, Vladislav Yasevich wrote: >> Add parameters that control RARP/GARP announcement timeouts. >> The parameters structure is added to the QAPI and a qmp command >> is added to set/get the parameter data. >> >> Based on work by "Dr.

Re: [Qemu-devel] [PATCH 06/12] qmp: Expose qemu_announce_self as a qmp command

On 05/26/2017 09:16 AM, Eric Blake wrote: > On 05/24/2017 01:05 PM, Vladislav Yasevich wrote: >> Add a qmp command that can trigger guest announcements. >> >> Based on work of Germano Veit Michel >> >> Signed-off-by: Vladislav Yasevich >> --- >>

Re: [Qemu-devel] [PATCH 01/12] migration: Introduce announce parameters

On 05/26/2017 09:08 AM, Eric Blake wrote: > On 05/24/2017 01:05 PM, Vladislav Yasevich wrote: >> Add parameters that control RARP/GARP announcement timeouts. >> The parameters structure is added to the QAPI and a qmp command >> is added to set/get the parameter data. >> >> Based on work by "Dr.

Re: [Qemu-devel] [PATCH 08/12] announce_timer: Add ability to reset an existing

On 05/30/2017 03:35 PM, Dr. David Alan Gilbert wrote: > * Vladislav Yasevich (vyase...@redhat.com) wrote: >> It is now potentially possible to issue annouce-self command in a tight >> loop. Instead of doing nother, we can reset the timeout pararameters, >> especially since each instance may

Re: [Qemu-devel] [PATCH 03/12] migration: Switch to using announcement timer

On 05/30/2017 03:19 PM, Dr. David Alan Gilbert wrote: > * Vladislav Yasevich (vyase...@redhat.com) wrote: >> Switch qemu_announce_self and virtio annoucements to use >> the announcement timer framework. This makes sure that both >> timers use the same timeouts and number of annoucement attempts

Re: [Qemu-devel] [PATCH 06/12] qmp: Expose qemu_announce_self as a qmp command

On 05/30/2017 10:14 AM, Daniel P. Berrange wrote: > On Wed, May 24, 2017 at 02:05:22PM -0400, Vladislav Yasevich wrote: >> Add a qmp command that can trigger guest announcements. >> >> Based on work of Germano Veit Michel >> >> Signed-off-by: Vladislav Yasevich

Re: [Qemu-devel] [PATCH 01/12] migration: Introduce announce parameters

On 05/30/2017 05:58 AM, Juan Quintela wrote: > Vladislav Yasevich wrote: >> Add parameters that control RARP/GARP announcement timeouts. >> The parameters structure is added to the QAPI and a qmp command >> is added to set/get the parameter data. >> >> Based on work by "Dr.

Re: [Qemu-devel] [PATCH 03/12] migration: Switch to using announcement timer

On 05/30/2017 06:10 AM, Juan Quintela wrote: > Vladislav Yasevich wrote: >> Switch qemu_announce_self and virtio annoucements to use >> the announcement timer framework. This makes sure that both >> timers use the same timeouts and number of annoucement attempts >> >> Based

Re: [Qemu-devel] [PATCH 06/12] qmp: Expose qemu_announce_self as a qmp command

On 05/30/2017 06:11 AM, Juan Quintela wrote: > Vladislav Yasevich wrote: >> Add a qmp command that can trigger guest announcements. >> >> Based on work of Germano Veit Michel >> >> Signed-off-by: Vladislav Yasevich >> --- >>

Re: [Qemu-devel] [PATCH 06/12] qmp: Expose qemu_announce_self as a qmp command

On 05/30/2017 10:24 AM, Juan Quintela wrote: > Vlad Yasevich <vyase...@redhat.com> wrote: >> On 05/30/2017 06:11 AM, Juan Quintela wrote: >>> Vladislav Yasevich <vyase...@redhat.com> wrote: >>>> Add a qmp command that can trigger guest announcements. >

Re: [Qemu-devel] [PATCH 09/12] hmp: add announce paraters info/set

On 05/30/2017 06:18 AM, Juan Quintela wrote: > Vladislav Yasevich wrote: >> Add HMP command to control and read annoucment parameters. >> >> Signed-off-by: Vladislav Yasevich > > Reviewed-by: Juan Quintela > > >> + cleanup: >> +

Re: [Qemu-devel] [PATCH v3 0/5] Fix handling of IPv4/IPv6 dual stack

c | 855 > + > util/qemu-sockets.c | 71 +++- > 5 files changed, 916 insertions(+), 21 deletions(-) > create mode 100644 tests/test-sockets-proto.c > Series Reviewed-by: Vlad Yasevich <vyase...@redhat.com> -vlad

Re: [Qemu-devel] [PATCH] virtio-net: consolidate guest announcement with qemu_announce_self

On 05/02/2017 06:41 AM, Dr. David Alan Gilbert wrote: > * Vlad Yasevich (vyase...@redhat.com) wrote: >> On 03/30/2017 11:26 AM, Dr. David Alan Gilbert wrote: >>> * Vlad Yasevich (vyase...@redhat.com) wrote: >>>> On 03/30/2017 10:53 AM, Dr. David Alan Gilbert wrote

Re: [Qemu-devel] [PATCH 01/12] migration: Introduce announce parameters

On 06/01/2017 03:02 AM, Jason Wang wrote: > > > On 2017年05月31日 02:57, Dr. David Alan Gilbert wrote: >> * Vlad Yasevich (vyase...@redhat.com) wrote: >>> On 05/26/2017 12:03 AM, Jason Wang wrote: >>>> On 2017å¹´05月25æ—¥ 02:05, Vladislav Yasevich wrote: >>