Hello Cleber!
On 10/16/2018 08:22 PM, Cleber Rosa wrote:
The host arch name is not always the target arch name, so it's
necessary to have a mapping.
The configure scripts contains what is the authoritative and failproof
mapping, but, reusing it is not straightforward, so it's replicated in
the
4_t
This change adds a regression test for that fix. It starts
QEMU with a 2GB dummy initrd, and check it evaluates the file
size correctly and prints accurate message.
Signed-off-by: Wainer dos Santos Moschetta
---
tests/acceptance/linux_initrd.py | 47
1 f
On 10/17/2018 05:05 PM, Eduardo Habkost wrote:
On Wed, Oct 17, 2018 at 04:43:15PM -0300, Murilo Opsfelder Araujo wrote:
On Wed, Oct 17, 2018 at 07:40:51PM +0100, Peter Maydell wrote:
On 17 October 2018 at 18:38, Cleber Rosa wrote:
On 10/17/18 12:29 PM, Eduardo Habkost wrote:
On Wed, Oct
make check-qtest-TARGET Run qtest tests for given target
I tested this patch series on Fedora 28 x86_64. It works fine except for
above issues, so once fixing them:
Acked-by: Wainer dos Santos Moschetta
+endif
+
+check-venv: $(TESTS_VENV_DIR)
+
# Consolidated targets
.PHONY: check-qap
Under review, the following patch adds acceptance tests for the initrd
option:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg567776.html
The test should be updated in case this series get merged. Maybe the
best would be to include those tests along with this series actually.
-
This adds tests for SMP option, by passing -smp with
various combinations of cpus, cores, threads, and sockets
values it checks that invalid topologies are not accepted
as well as missing values are correctly calculated.
Signed-off-by: Wainer dos Santos Moschetta
---
tests/acceptance
off-by: Wainer dos Santos Moschetta
Reviewed-by: Caio Carrara
Reviewed-by: Cleber Rosa
Reviewed-by: Eduardo Habkost
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
---
4_t
This change adds a regression test for that fix. It starts
QEMU with a 2GiB dummy initrd, and check it evaluates the file
size correctly and prints accurate message.
Signed-off-by: Wainer dos Santos Moschetta
Reviewed-by: Caio Carrara
Reviewed-by: Cleber Rosa
Reviewed-by: Eduardo Habk
ddress it in this patch (or I can send in a separate patch).
Overall, this patch series looks good for me. I tested patches 1, 2 and
4 on Fedora 29. So:
Tested-by: Wainer dos Santos Moschetta
- Wainer
+ @echo
@echo " $(MAKE) check-qtest-TARGET Run qtest tests for
"spec-ctrl",
"ssbd",
"3dnowprefetch",
"xsavec",
"xgetbv1",
"mpx",
"mpx",
"avx512f",
On 12/10/2018 02:46 PM, Eduardo Habkost wrote:
On Fri, Dec 07, 2018 at 05:14:17PM -0500, Wainer dos Santos Moschetta wrote:
The x86_cpu_class_check_missing_features() returns a list
of unavailable features compared to the host CPU. Currently it may
return empty strings for unamed features
ceed %" PRIu64 ", given %s\n",
- (uint64_t)BDRV_REQUEST_MAX_BYTES, argv[optind]);
+fprintf(stderr, "length cannot exceed %" PRIu64 ", given %s\n",
+(uint64_t)BDRV_REQUEST_MAX_BYTES, argv[optind]);
return -EINVAL;
}
if (bflag || cflag
files changed, 36 insertions(+), 7 deletions(-)
Side question: I didn't find on QEMU's user manual any reference to
deprecated features for CPU models. Does that information exists
somewhere? If not, should it be documented for the users?
Anyway,
Reviewed-by: Wainer dos Santos Moschetta
diff
On 12/11/2018 03:15 PM, Eric Blake wrote:
On 12/11/18 10:28 AM, Wainer dos Santos Moschetta wrote:
The x86_cpu_class_check_missing_features() returns a list
of unavailable features compared to the host CPU. Currently it may
return empty strings for unnamed features as well as duplicated
names
Signed-off-by: Richard Henderson
---
tests/libqtest.h | 8 +
tests/boot-serial-test.c | 16 +++--
tests/libqtest.c | 70 +---
3 files changed, 65 insertions(+), 29 deletions(-)
Reviewed-by: Wainer dos Santos Moschetta
diff
plemented the machine_get_kernel_irqchip() method,
which evaluates the kernel_irqchip_allowed, *_required, and
*_split fields to determine the value of kernel-irqchip. Note: we
assume there is not inconsistency on the value of those fields.
Then with this change in place, it works as expected:
qemu
Signed-off-by: Wainer dos Santos Moschetta
---
hw/core/machine.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/core/machine.c b/hw/core/machine.c
index 4439ea663f..a0beeeb2a9 100644
--- a/hw/core/machine.c
+++ b/hw/core/machine.c
@@ -591,7 +591,7 @@ static void
lf):
self.vm.add_args('-M', 'q35,accel=kvm,kernel-irqchip=split')
self.vm.launch()
self.assertEqual(self.get_kernel_irqchip(), 'split')
References:
[1] https://www.mail-archive.com/qemu-devel@nongnu.org/msg582840.html
Wainer dos Santos Moschetta (1):
hw/core: add qom gett
/qemu-sockets.c| 4 +-
109 files changed, 429 insertions(+), 429 deletions(-)
Reviewed-by: Wainer dos Santos Moschetta
On 12/13/2018 04:01 PM, Peter Maydell wrote:
On Thu, 13 Dec 2018 at 17:57, Wainer dos Santos Moschetta
wrote:
Eduardo Habkost pointed out a malformed block of comments on my
patch [1] that I had ran checkpatch.pl and no warn/error was
reported. Then I realized the script does not catch
On 12/11/2018 05:25 PM, Eduardo Habkost wrote:
Some downstream distributions of QEMU set host-phys-bits=on by
default. This worked very well for most use cases, because
phys-bits really didn't have huge consequences. The only
difference was on the CPUID data seen by guests, and on the
') is reported.
3. block doesn't end on its own line.
Example:
/*
* blah blah
* and blah */
References:
[1] https://www.mail-archive.com/qemu-devel@nongnu.org/msg580091.html
ps: last time I wrote Perl code was about 13 years ago. That remember me
of good times. :)
Wainer dos Santos Moschetta (1
line.
Signed-off-by: Wainer dos Santos Moschetta
---
scripts/checkpatch.pl | 32
1 file changed, 32 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 60f6f89a27..5abb579ed7 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
On 12/10/2018 04:10 PM, Igor Mammedov wrote:
Currently in the 1st case we store table body fetched from QEMU in
AcpiSdtTable::aml minus it's header but in the 2nd case when we
load reference aml from disk, it holds whole blob including header.
More over in the 1st case, we read header in
On 12/14/2018 07:48 AM, Paolo Bonzini wrote:
Since we're adding checkpatch rules to enforce 4-line multiline comment
format, i.e. with lone /* and */, this script can be run on existing
code so that the comment style does not become inconsistent within a
file.
The alternative to
On 12/14/2018 04:15 PM, Paolo Bonzini wrote:
On 14/12/18 19:06, Wainer dos Santos Moschetta wrote:
IIUC above block handles the lines between lead and trail. So it would
fix (but it doesn't) this:
# cat foo
/*
comment 1
comment 2
*/
# scripts/fix-multiline-comments.sh foo
/*
comment
"spec-ctrl",
"ssbd",
"3dnowprefetch",
"xsavec",
"xgetbv1",
"mpx",
"mpx",
"avx512f",
On 11/26/2018 08:56 PM, Eduardo Habkost wrote:
Remove the "apic initialization failed" prefix (it conveys no
useful information), replace "invalid" with "too large", and add
an error hint with two possible solutions for the problem.
Before:
$ qemu-system-x86_64 -machine q35 -smp 256
On 11/12/2018 02:31 PM, Eduardo Habkost wrote:
On Fri, Nov 09, 2018 at 02:58:00PM -0500, Wainer dos Santos Moschetta wrote:
This adds tests for SMP option, by passing -smp with
various combinations of cpus, cores, threads, and sockets
values it checks that invalid topologies are not accepted
-off-by: Thomas Huth
---
tests/Makefile.include | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/tests/Makefile.include b/tests/Makefile.include
index d87b403..9b26116 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
Reviewed-by: Wainer dos Santos
On 11/26/2018 10:58 AM, Caio Carrara wrote:
On Wed, Nov 21, 2018 at 01:39:00PM -0500, Wainer dos Santos Moschetta wrote:
QEMUMachine launches the VM with a monitor enabled, afterwards
a qmp connection is attempted on _post_launch(). In case
the QEMU process exits with an error, qmp.accept
.
Reported-by: Kevin Wolf
Signed-off-by: Eric Blake
Reviewed-by: Wainer dos Santos Moschetta
---
On Fedora, libvirt requires libtls-utils to be present, but not qemu.
I'm fine if Kevin wants to pick this up in a pull request related
to iotests in general; if not, I'll do a pull request
On 11/21/2018 11:41 AM, Cleber Rosa wrote:
Commit a22528b918 fixed an issue that is exposed by means of the
"set-numa-node" QMP command (introduced in f3be67812). This adds a
test that pretty much maps the steps documented on the fix.
Additionally, given that 'set-numa-node' is only allowed
On 11/21/2018 07:48 PM, Cleber Rosa wrote:
So that when binaries such as qemu-img are searched for, those in the
build tree will be favored. As a clarification, SRC_ROOT_DIR is
dependent on the location from where tests are executed, so they are
equal to the build directory if one is being
On 11/21/2018 01:56 PM, Caio Carrara wrote:
Hello Wainer and Eduardo,
On Tue, Nov 20, 2018 at 05:02:38PM -0200, Eduardo Habkost wrote:
On Tue, Nov 20, 2018 at 11:53:00AM -0500, Wainer dos Santos Moschetta wrote:
QEMUMachine launches the VM with a monitor enabled, afterwards
a qmp connection
On 11/12/2018 02:31 PM, Eduardo Habkost wrote:
On Fri, Nov 09, 2018 at 02:58:00PM -0500, Wainer dos Santos Moschetta wrote:
This adds tests for SMP option, by passing -smp with
various combinations of cpus, cores, threads, and sockets
values it checks that invalid topologies are not accepted
Added examples for the qom-list, qom-get, and qom-set
commands in qapi misc JSON file.
Signed-off-by: Wainer dos Santos Moschetta
---
qapi/misc.json | 36
1 file changed, 36 insertions(+)
diff --git a/qapi/misc.json b/qapi/misc.json
index 24d20a880a
On 03/27/2019 01:15 PM, Paolo Bonzini wrote:
On 27/03/19 17:05, Daniel P. Berrangé wrote:
On Wed, Mar 27, 2019 at 04:58:23PM +0100, Paolo Bonzini wrote:
On 27/03/19 16:30, Daniel P. Berrangé wrote:
Perhaps the VM test scripts should do a "HEAD" request for the image
every time to discover
On 03/22/2019 06:49 PM, Daniel Henrique Barboza wrote:
On 3/22/19 4:02 PM, no-re...@patchew.org wrote:
Patchew URL:
https://patchew.org/QEMU/20190322175241.5954-1-danielhb...@gmail.com/
Hi,
This series failed the docker-mingw@fedora build test. Please find
the testing commands and
Added description of variables missing on vm-test help.
Signed-off-by: Wainer dos Santos Moschetta
---
tests/vm/Makefile.include | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/tests/vm/Makefile.include b/tests/vm/Makefile.include
index 6f82676306..c59411bee0 100644
Changed the vm-test makefile to execute python scripts
with the interpreter configured on build. This allows to
run vm-test targets properly in Linux distros with Python 3
only support.
Signed-off-by: Wainer dos Santos Moschetta
---
tests/vm/Makefile.include | 4 ++--
1 file changed, 2
`make vm-build-centos` run docker-based tests on CentOS. The
created containers should have network otherwise some tests
fail. Also fixed the BUILD_SCRIPT template to correctly
evaluate "V=1" for verbose output.
Signed-off-by: Wainer dos Santos Moschetta
---
tests/vm/centos | 6 +++-
by using the sha256sum file stored on server. It
compares with the expected checksum and then abort the execution
on mismatch.
Signed-off-by: Wainer dos Santos Moschetta
---
tests/vm/basevm.py | 31 ++-
1 file changed, 30 insertions(+), 1 deletion(-)
diff --git a/tests
Fixed tests/vm/basevm.py to run with Python 3:
- hashlib.sha1() requires an binary encoded object.
- uses floor division ("//") (PEP 238).
- decode bytes to unicode when needed.
Signed-off-by: Wainer dos Santos Moschetta
---
tests/vm/basevm.py | 8
1 file changed, 4 insert
the server then it should equally be updated
the checksum on QEMU's side.
Patch 04:
Default network (NETWORK=1) backend is enough to have the docker-based tests
run properly. Note: `make docker-test-block@centos7` is broken inside the
CentOS VM and apparently on my host (Fedora 29 x86_64) too.
On 03/29/2019 06:20 AM, Peter Maydell wrote:
On Thu, 28 Mar 2019 at 21:29, Wainer dos Santos Moschetta
wrote:
On 03/28/2019 12:29 PM, Peter Maydell wrote:
The Raspberry Pi boards have a physical memory map which does
not allow for more than 1GB of RAM. Currently if the user tries
to ask
On 03/28/2019 12:29 PM, Peter Maydell wrote:
The Raspberry Pi boards have a physical memory map which does
not allow for more than 1GB of RAM. Currently if the user tries
to ask for more then we fail in a confusing way:
$ qemu-system-aarch64 --machine raspi3 -m 8G
Unexpected error in
On 02/21/2019 03:50 PM, Cleber Rosa wrote:
On 2/21/19 9:39 AM, Erik Skultety wrote:
Hi,
I'm starting this thread in order to continue with the ongoing efforts to
bring actual integration testing to libvirt. Currently, the status quo is that
we build libvirt (along with our unit test suite)
es changed, 114 insertions(+), 5 deletions(-)
create mode 100644 tests/acceptance/migration.py
Reviewed-by: Wainer dos Santos Moschetta
le.py | 1 -
tests/acceptance/linux_initrd.py | 1 -
tests/acceptance/version.py| 1 -
tests/acceptance/virtio_version.py | 1 -
tests/acceptance/vnc.py| 1 -
tests/requirements.txt | 2 +-
7 files changed, 1 insertion(+), 7 deletions(-)
)
create mode 100644 tests/acceptance/boot_linux.py
The make check-acceptance now finished with success in my system, that
does not have qemu-img installed at system-wide (fixed by patches 03 and
04).
Also the code looks good to me. So:
Reviewed-by: Wainer dos Santos Moschetta
Hi all,
On 03/14/2019 12:57 PM, Alex Bennée wrote:
Hi,
As we approach stabilisation for 4.0 I thought it would be worth doing a
review of the current state of CI and stimulate some discussion of where
it is working for us and what could be improved.
Testing in Build System
On 03/19/2019 09:48 AM, Alex Bennée wrote:
This is essentially a softmmu tweak so don't bother building
linux-user builds as well.
Signed-off-by: Alex Bennée
---
.travis.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Wainer dos Santos Moschetta
diff --git
the Travis timeout
limit.
Signed-off-by: Alex Bennée
---
.travis.yml | 23 +--
1 file changed, 17 insertions(+), 6 deletions(-)
Reviewed-by: Wainer dos Santos Moschetta
diff --git a/.travis.yml b/.travis.yml
index 980fc5c1eb..407fc25945 100644
--- a/.travis.yml
+++ b
-exclude at the same
time.
Signed-off-by: Alex Bennée
---
configure | 34 +++---
1 file changed, 31 insertions(+), 3 deletions(-)
Tested-by: Wainer dos Santos Moschetta
diff --git a/configure b/configure
index 7071f52584..c937aec851 100755
--- a/configure
+++ b
(-)
Reviewed-by: Wainer dos Santos Moschetta
diff --git a/.travis.yml b/.travis.yml
index 3fb3dab46e..2e06aee9d0 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -107,7 +107,7 @@ matrix:
- env:
-- CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr
--disable-brlapi --di
Apply double quotes and period punctuation uniformly.
Signed-off-by: Wainer dos Santos Moschetta
---
tests/docker/Makefile.include | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
index 60314d293a..c0e1bf57a3
the reference to source dir is wrong. So let's unset both BUILD_DIR
and SRC_DIR before calling the script, given it is executed from
the source dir already (as in Travis).
Signed-off-by: Wainer dos Santos Moschetta
---
tests/docker/travis | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests
.
Replaced yaml.load() with yaml.safe_load() so that quieting the
following deprecation warning:
https://github.com/yaml/pyyaml/wiki/PyYAML-yaml.load(input)-Deprecation
Signed-off-by: Wainer dos Santos Moschetta
---
tests/docker/travis.py | 11 +--
1 file changed, 5 insertions(+), 6
The `make docker-travis@IMAGE` is broken because:
1) travis.py fails to parse the current .travis.yml
2) The travis script does not get the correct reference
to the source directory. It is a regression introduced on
commit 05790dafef1.
Tested with `make docker-travis@ubuntu`.
Wainer dos Santos
On 01/28/2019 03:47 PM, Caio Carrara wrote:
From: Cleber Rosa
This is the simplest possible migration test, exercising the multi
VM capabilities of the test class.
Signed-off-by: Cleber Rosa
---
tests/acceptance/migration.py | 45 +++
1 file changed, 45
On 01/29/2019 09:30 AM, Caio Carrara wrote:
Hi, Wainer.
On Mon, Jan 28, 2019 at 05:42:24PM -0200, Wainer dos Santos Moschetta wrote:
On 01/28/2019 03:47 PM, Caio Carrara wrote:
This change adds the possibility to write acceptance tests with multi
virtual machine support. It's done keeping
not break by this change. I also
checked the example you provided on docs/devel/testing.rst works too.
So Tested-by: Wainer dos Santos Moschetta
Signed-off-by: Caio Carrara
---
docs/devel/testing.rst| 40 ++-
tests/acceptance/avocado_qemu/__init__.py | 25
initrd
CC: Wainer dos Santos Moschetta
CC: Caio Carrara
CC: Cleber Rosa
CC: Eduardo Habkost
CC: Philippe Mathieu-Daudé
Signed-off-by: Li Zhijian
---
V2: fix typos
---
tests/acceptance/linux_initrd.py | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
Reviewed
On 01/17/2019 04:56 PM, Cleber Rosa wrote:
Similar to the x86_64 + pc test, it boots a Linux kernel on a Malta
board and verify the serial is working.
If mips64el is a target being built, "make check-acceptance" will
automatically include this test by the use of the "arch:mips" tags.
Hi Cleber,
me again. :)
On 01/17/2019 04:56 PM, Cleber Rosa wrote:
The set_console() utility function traditionally adds a device either
based on the explicitly given device type, or based on the machine type,
a known good type of device.
But, for a number of machine types, it may be
On 01/17/2019 04:56 PM, Cleber Rosa wrote:
Just like the previous tests, boots a Linux kernel on a aarch64 target
using the virt machine.
One special option added is the CPU type, given that the kernel
selected fails to boot on the virt machine's default CPU (cortex-a15).
Signed-off-by:
Hi Cleber,
On 01/17/2019 04:56 PM, Cleber Rosa wrote:
It's useful to define the architecture that should be used in
situations such as:
* the intended target of the QEMU binary to be used on tests
* the architecture of code to be run within the QEMU binary, such
as a kernel image or a
Hi Cleber,
On 01/17/2019 04:56 PM, Cleber Rosa wrote:
This introduces a utility method that monitors the console device and
looks for either a message that signals the test success or failure.
Signed-off-by: Cleber Rosa
---
tests/acceptance/boot_linux_console.py | 30
that it does not check if the accelerator is enabled in the
host, so the help message's header was rewritten to emphasize
that. Also qtest is not displayed given that it is used for
internal testing purpose only.
Signed-off-by: Wainer dos Santos Moschetta
---
vl.c | 18 +-
1 file changed
tcg
---
Git: https://github.com/wainersm/qemu
Branch: accel_list
Travis: https://travis-ci.org/wainersm/qemu/builds/539366851
[1] https://www.mail-archive.com/qemu-devel@nongnu.org/msg491542.html
Wainer dos Santos Moschetta (1):
vl: make -accel help to list enabled accelerators only
vl.c | 18 +
::opt_name despite
that. Therefore, and given that none accelerator
implementation sets AccelClass::opt_name, let's
remove this attribute.
Signed-off-by: Wainer dos Santos Moschetta
---
include/sysemu/accel.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/sysemu/accel.h b/include/sysemu
as
fails on master too.)
Wainer dos Santos Moschetta (1):
accel: Remove unused AccelClass::opt_name attribute
include/sysemu/accel.h | 1 -
1 file changed, 1 deletion(-)
--
2.21.0
le changed, 3 deletions(-)
I was about to send a patch to remove it as well. :)
Reviewed-by: Wainer dos Santos Moschetta
diff --git a/tests/acceptance/migration.py b/tests/acceptance/migration.py
index 6115cf6c24..a44c1ae58f 100644
--- a/tests/acceptance/migration.py
+++ b/tests/acceptance/mi
(-)
Reviewed-by: Wainer dos Santos Moschetta
diff --git a/tests/acceptance/vnc.py b/tests/acceptance/vnc.py
index 675fd507ed..d32ae46685 100644
--- a/tests/acceptance/vnc.py
+++ b/tests/acceptance/vnc.py
@@ -45,7 +45,7 @@ class VncUnixSocket(Test):
self.socket_dir = tempfile.mkdtemp
On 06/07/2019 12:22 PM, Cleber Rosa wrote:
While running in parallel, the VNC tests that use a TCP port easily
collide. There's a number of possibilities to reduce the probability
of collisions, but none that completely prevents it from happening.
So, to avoid those collisions, and given
will advocate for the use QEMUMachine.command() instead of qmp(). The
former do some checks on the qmp response and raises a more gently
exception if something went wrong. This patch looks good to me though.
Reviewed-by: Wainer dos Santos Moschetta
+client = socket.socket
Hi Eduardo,
On 06/07/2019 06:15 PM, Eduardo Habkost wrote:
It will help us debug issues when tests fail.
Signed-off-by: Eduardo Habkost
---
.travis.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.travis.yml b/.travis.yml
index 75e017a5cf..82c74673e1 100644
---
easily obtainable on systems such as
Fedora 30.
Signed-off-by: Cleber Rosa
---
tests/requirements.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Wainer dos Santos Moschetta
diff --git a/tests/requirements.txt b/tests/requirements.txt
index 3ae0e29ad7..bd1f7590ed 100644
you cannot archive the log files in Travis,
otherwise that would be a nice option.
Reviewed-by: Wainer dos Santos Moschetta
@@ -226,6 +226,8 @@ matrix:
- env:
- CONFIG="--python=/usr/bin/python3
--target-list=x86_64-softmmu,mips-softmmu,mips64el-softmmu,aarch64-softmmu,ar
n)
I'm refactoring the acceptance tests which boot a Linux Kernel so that
they can share common functions. My latest implementation [1] was
re-based on this patch, and it would help manage my contribution if we
could merge this very soon.
Anyway, tested this patch on my Fedora 30 x86_64 mac
On 06/24/2019 03:03 PM, Eduardo Habkost wrote:
Any objections to this? I'm planning to merge it this week.
IMHO, 1+. So I don't have objections.
- Wainer
On Sat, Jun 08, 2019 at 08:34:46PM -0300, Eduardo Habkost wrote:
Changes v1 -> v2:
* I've decided to get rid of the status-message
| 3 +++
1 file changed, 3 insertions(+)
Reviewed-by: Wainer dos Santos Moschetta
diff --git a/tests/acceptance/cpu_queries.py b/tests/acceptance/cpu_queries.py
index e71edec39f..af47d2795a 100644
--- a/tests/acceptance/cpu_queries.py
+++ b/tests/acceptance/cpu_queries.py
@@ -18,6 +18,9
tly none arm target has a default machine type, unlike
others as x86_64 and ppc64. The 'virt' (alias) type represents a
generic ARM hardware, so let's specify it the default machine for
ARM emulation.
Signed-off-by: Wainer dos Santos Moschetta
---
hw/arm/virt.c | 1 +
1 file changed, 1 insert
any of aarch64 or arm. Note:
self.target_arch can end up None if qemu_bin is passed by
Avocado parameter and the filename doesn't match expected
format. In this case the test will fail.
Signed-off-by: Wainer dos Santos Moschetta
---
tests/acceptance/avocado_qemu/__init__.py |
On 07/01/2019 05:29 PM, Cleber Rosa wrote:
On Mon, Jul 01, 2019 at 03:34:51PM -0300, Eduardo Habkost wrote:
Agreed that kvm:tcg fallback I suggested isn't a good idea.
However, do we really want to require a separate test method to
be written just because we want to use a different
On 06/30/2019 02:51 PM, Cleber Rosa wrote:
On Fri, Jun 28, 2019 at 05:43:09PM -0300, Wainer dos Santos Moschetta wrote:
On 06/21/2019 11:38 AM, Cleber Rosa wrote:
On Fri, Jun 21, 2019 at 09:03:33AM +0200, Philippe Mathieu-Daudé wrote:
On 6/21/19 8:09 AM, Cleber Rosa wrote:
It's a fact
On 06/21/2019 07:07 PM, Cleber Rosa wrote:
On Fri, Jun 21, 2019 at 11:38:06AM -0400, Wainer dos Santos Moschetta wrote:
Hi all,
I'm still unsure this is the best solution. I tend to think that
any arch-independent test case (i.e. not tagged 'arch') should
be skipped on all arches except
On 06/24/2019 05:37 AM, Andrea Bolognani wrote:
On Sat, 2019-06-22 at 16:58 +0100, Peter Maydell wrote:
On Fri, 21 Jun 2019 at 20:04, Cleber Rosa wrote:
You can consider me biased (I do consider myself), but trying to wear
the hat of a user first interacting with QEMU, I would expect a
Hi Thomas,
On 04/24/2019 07:37 AM, Thomas Huth wrote:
People often forget to run the iotests before submitting patches or
pull requests - this is likely due to the fact that we do not run the
tests during our mandatory "make check" tests yet. Now that we've got
a new "ci" group of iotests that
Hello Thomas,
On 04/24/2019 07:37 AM, Thomas Huth wrote:
We are going to enable the qemu-iotests during "make check" again,
and for running the iotests, we need bash and gnu-sed.
Signed-off-by: Thomas Huth
---
.cirrus.yml | 4 ++--
.travis.yml | 1 +
2 files changed, 3 insertions(+), 2
Hi Eduardo,
On 04/23/2019 06:22 PM, Eduardo Habkost wrote:
This struct will be used to represent support and deprecation
status of QEMU features.
Signed-off-by: Eduardo Habkost
---
qapi/common.json | 24
1 file changed, 24 insertions(+)
diff --git
Hi Eduardo,
On 04/23/2019 06:22 PM, Eduardo Habkost wrote:
Export machine type deprecation information through the
query-machines QMP command. With this, libvirt and management
software will be able to show this information to users and/or
suggest changes to VM configuration to avoid
Hi Laszlo,
On 04/24/2019 06:07 AM, Laszlo Ersek wrote:
Hello Wainer,
(answering because I dislike ignoring emails without giving any feedback:)
I appreciated that! thanks!
On 04/23/19 21:28, Wainer dos Santos Moschetta wrote:
Ping. More reviews needed.
I've already got Philippe's
Ping. More reviews needed.
I've already got Philippe's reviewed-by, thanks!
- Wainer
On 03/29/2019 06:07 PM, Wainer dos Santos Moschetta wrote:
Hi all!
This series bundles the support to Python3, improvement to image caching, and
miscellaneous changes for the vm-test (`make vm-build
On 06/21/2019 11:38 AM, Cleber Rosa wrote:
On Fri, Jun 21, 2019 at 09:03:33AM +0200, Philippe Mathieu-Daudé wrote:
On 6/21/19 8:09 AM, Cleber Rosa wrote:
It's a fact that some tests may not be 100% reliable in all
environments. While it's a tough call to remove a useful test that
from the
On 06/21/2019 03:09 AM, Cleber Rosa wrote:
This fires a QEMU binary with SPICE enabled, and does a basic
handshake, doing a basic client/server interaction and protocol
validation.
Signed-off-by: Cleber Rosa
---
.travis.yml | 5 +++-
tests/Makefile.include| 6 +
m/wainersm/qemu/tree/acceptance_boot_linux
An alternate approach would be to extend Avocado by mimic the
avocado.utils.vmimage module [1], but rather have kernel providers.
[1]
https://avocado-framework.readthedocs.io/en/71.0/api/utils/avocado.utils.html#module-avocado.utils.vmimage
Anyway, the changes proposed on this patch looks good to me.
Reviewed-by: Wainer dos Santos Moschetta
Thanks,
Wainer
Until now the suite of acceptance tests doesn't exercise
QEMU with kvm enabled. So this introduces a simple test
that boots the Linux kernel and checks it boots on the
accelerator correctly.
Signed-off-by: Wainer dos Santos Moschetta
---
tests/acceptance/kvm.py | 58
elerator(s). It was implemented a
mechanism to check the given accelerator is available, and if not
then the test case is skipped.
Signed-off-by: Wainer dos Santos Moschetta
---
tests/acceptance/avocado_qemu/__init__.py | 5 ++
tests/acceptance/avocado_qemu/accel.py| 60 ++
1 - 100 of 595 matches
Mail list logo
