[Qemu-devel] [PATCH RFC] Addition of Veritas HyperScale VxHS block device support

a vxhs type vdisk and read/write to it. (4) Source code for the new network IO library (libqnio) that we use has been open sourced and can be downloaded from: https://github.com/MittalAshish/libqnio.git Ashish Mittal (1): block/vxhs: Initial commit to add Veritas HyperScale VxHS block device

[Qemu-devel] [PATCH RFC] Addition of Veritas HyperScale VxHS block device support

a vxhs type vdisk and read/write to it. (4) Source code for the new network IO library (libqnio) that we use has been open sourced and can be downloaded from: https://github.com/MittalAshish/libqnio.git Ashish Mittal (1): block/vxhs: Initial commit to add Veritas HyperScale VxHS block device

[Qemu-devel] [PATCH RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

This patch adds support for a new block device type called "vxhs". Source code for the library that this code loads can be downloaded from: https://github.com/MittalAshish/libqnio.git Signed-off-by: Ashish Mittal <ashish.mit...@veritas.com> --- block/Makefile.objs |1

[Qemu-devel] [PATCH RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

This patch adds support for a new block device type called "vxhs". Source code for the library that this code loads can be downloaded from: https://github.com/MittalAshish/libqnio.git Signed-off-by: Ashish Mittal <ashish.mit...@veritas.com> --- block/Makefile.objs |1

[Qemu-devel] [PATCH v3 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

08 -S -vnc 0.0.0.0:0 -k en-us -vga cirrus -device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x5 -msg timestamp=on 'json:{"driver":"vxhs","vdisk_id":"{c3e9095a-a5ee-4dce-afeb-2a59fb387410}","server":[{"host":"172.172.17.4"

Re: [Qemu-devel] [PATCH RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

Hi Christopher, We are working on a sample server implementation, and will add it to libqnio soon. Thanks, Ashish On Mon, Aug 8, 2016 at 12:46 AM, Christoph Hellwig <h...@lst.de> wrote: > On Sun, Jul 31, 2016 at 04:52:16PM -0700, Ashish Mittal wrote: > > This patch adds support

[Qemu-devel] [PATCH v2 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

to) review comments from Stefan. Signed-off-by: Ashish Mittal <ashish.mit...@veritas.com> --- block/Makefile.objs |2 + block/trace-events | 40 ++ block/vxhs.c| 1199 +++ block/vxhs.h| 294 + configure

Re: [Qemu-devel] [PATCH v3 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

>> +/* >> + * Convert the json formatted command line into qapi. >> +*/ >> + >> +static int vxhs_parse_json(BlockdevOptionsVxHS *conf, >> + QDict *options, Error **errp) >> +{ ... >> +errno = EINVAL; >> +return -errno; >> +} > > Ewww this is really horrible

Re: [Qemu-devel] [PATCH v6 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

92.168.0.1,file.port= Similar to how NBD (see commit id 'a1674fd9') and SSH (see commit id 'bc225b1b5') are handled. /==/ If this proposal looks OK to the community, then I will make this user interface change in the next VxHS qemu patch. Thanks, As

Re: [Qemu-devel] [PATCH v3 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

6 at 12:51 PM, ashish mittal <ashmit...@gmail.com> wrote: > Thank you. Will work with this. > > On Tue, Nov 15, 2016 at 12:48 PM, Stefan Hajnoczi <stefa...@gmail.com> wrote: >> On Tue, Nov 15, 2016 at 11:02:34AM -0800, ashish mittal wrote: >>> I had repli

Re: [Qemu-devel] [PATCH v6 2/2] block/vxhs.c: Add qemu-iotests for new block device type "vxhs"

I plan to submit v7 soon, therefore going over any unanswered emails at this time. On Tue, Nov 8, 2016 at 12:44 PM, Jeff Cody <jc...@redhat.com> wrote: > On Mon, Nov 07, 2016 at 04:59:45PM -0800, Ashish Mittal wrote: >> These changes use a vxhs test server that is a part o

Re: [Qemu-devel] [PATCH v6 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

1, 2017 at 05:55:47PM -0800, ashish mittal wrote: >> Hi, >> >> There has been some work going on on the VxHS libvirt patches and we >> are making good progress. >> >> A suggestion has been made on the libvirt community to check if we can >> chang

Re: [Qemu-devel] [PATCH v7 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Wed, Feb 8, 2017 at 2:35 PM, Ketan Nilangekar <ketan.nilange...@veritas.com> wrote: > > > On 2/8/17, 2:21 PM, "Jeff Cody" <jc...@redhat.com> wrote: > > On Tue, Feb 07, 2017 at 08:18:13PM -0800, Ashish Mittal wrote: > > Fro

[Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

From: Ashish Mittal <ashish.mit...@veritas.com> Source code for the qnio library that this code loads can be downloaded from: https://github.com/VeritasHyperScale/libqnio.git Sample command line using JSON syntax: ./x86_64-softmmu/qemu-system-x86_64 -name instance-0008 -S -vnc 0.0.0.

[Qemu-devel] [PATCH v8 2/2] block/vxhs.c: Add qemu-iotests for new block device type "vxhs"

From: Ashish Mittal <ashish.mit...@veritas.com> These changes use a vxhs test server that is a part of the following repository: https://github.com/VeritasHyperScale/libqnio.git Signed-off-by: Ashish Mittal <ashish.mit...@veritas.com> --- v8/v7 changelog: (1) No changes. v6 changelo

[Qemu-devel] [PATCH v7 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

From: Ashish Mittal <ashish.mit...@veritas.com> Source code for the qnio library that this code loads can be downloaded from: https://github.com/VeritasHyperScale/libqnio.git Sample command line using JSON syntax: ./x86_64-softmmu/qemu-system-x86_64 -name instance-0008 -S -vnc 0.0.0.

[Qemu-devel] [PATCH v7 2/2] block/vxhs.c: Add qemu-iotests for new block device type "vxhs"

From: Ashish Mittal <ashish.mit...@veritas.com> These changes use a vxhs test server that is a part of the following repository: https://github.com/VeritasHyperScale/libqnio.git Signed-off-by: Ashish Mittal <ashish.mit...@veritas.com> --- v7 changelog: (1) No changes. v6 changelo

Re: [Qemu-devel] [PATCH v7 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Mon, Feb 13, 2017 at 6:57 AM, Stefan Hajnoczi <stefa...@gmail.com> wrote: > On Tue, Feb 07, 2017 at 08:18:13PM -0800, Ashish Mittal wrote: >> +static int vxhs_parse_uri(const char *filename, QDict *options) >> +{ >> +URI *uri = NULL; >> +char *host

Re: [Qemu-devel] [PATCH v7 2/2] block/vxhs.c: Add qemu-iotests for new block device type "vxhs"

Sorry, pressed the "send" button instead of "expand text" on the previous email ... On Mon, Feb 13, 2017 at 6:43 AM, Stefan Hajnoczi <stefa...@gmail.com> wrote: > On Tue, Feb 07, 2017 at 08:18:14PM -0800, Ashish Mittal wrote: >> diff --git a/tests/qemu-iot

Re: [Qemu-devel] [PATCH v7 2/2] block/vxhs.c: Add qemu-iotests for new block device type "vxhs"

On Mon, Feb 13, 2017 at 6:43 AM, Stefan Hajnoczi <stefa...@gmail.com> wrote: > On Tue, Feb 07, 2017 at 08:18:14PM -0800, Ashish Mittal wrote: >> diff --git a/tests/qemu-iotests/common.config >> b/tests/qemu-iotests/common.config >> index f6384fb..c7a80c0 100644

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Mon, Feb 20, 2017 at 3:02 AM, Stefan Hajnoczi <stefa...@gmail.com> wrote: > On Sat, Feb 18, 2017 at 12:30:31AM +, Ketan Nilangekar wrote: >> On 2/17/17, 1:42 PM, "Jeff Cody" <jc...@redhat.com> wrote: >> >> On Thu, Feb 16, 2017 at 02:24:1

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

Hi, I am getting the following error with checkpatch.pl ERROR: externs should be avoided in .c files #78: FILE: block/vxhs.c:28: +QemuUUID qemu_uuid __attribute__ ((weak)); Is there any way to get around this, or does it mean that I would have to add a vxhs.h just for this one entry? Thanks,

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

ing_options, str); +ret = -EINVAL; +goto out; +} +trace_vxhs_get_creds(user, password); + s->vdisk_hostinfo.host = g_strdup(server_host_opt); s->vdisk_hostinfo.port = g_ascii_strtoll(qemu_opt_get(tcp_opts, Thanks, Ashish On Wed, Feb 22, 2017 at 6:44 AM, Jeff

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

t; +} + +/* check if we got password via the --object argument */ +password = qcrypto_secret_lookup_as_utf8(secretid, _err); +if (local_err != NULL) { +trace_vxhs_get_creds(user, secretid, password); +qdict_del(backing_options, str); +ret = -EINVAL; +got

[Qemu-devel] [PATCH v9 2/2] block/vxhs.c: Add qemu-iotests for new block device type "vxhs"

These changes use a vxhs test server that is a part of the following repository: https://github.com/VeritasHyperScale/libqnio.git Signed-off-by: Ashish Mittal <ashish.mit...@veritas.com> --- v9 changelog: (1) Dropped second argument to set_prog_path(). We will pick up the test server lo

[Qemu-devel] [PATCH v9 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

and line using URI syntax: qemu-img convert -f raw -O raw -n /var/lib/nova/instances/_base/0c5eacd5ebea5ed914b6a3e7b18f1ce734c386ad vxhs://192.168.0.1:/c6718f6b-0401-441d-a8c3-1f0064d75ee0 Signed-off-by: Ashish Mittal <ashish.mit...@veritas.com> --- v9 changelog: (1) Fixes for all the review comments from v8. I have

Re: [Qemu-devel] [PATCH v6 2/2] block/vxhs.c: Add qemu-iotests for new block device type "vxhs"

On Tue, Feb 14, 2017 at 10:12 AM, Jeff Cody <jc...@redhat.com> wrote: > On Mon, Nov 07, 2016 at 04:59:45PM -0800, Ashish Mittal wrote: >> These changes use a vxhs test server that is a part of the following >> repository: >> https://github.com/MittalAshish/libqnio.git

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Wed, Feb 8, 2017 at 10:29 PM, Jeff Cody <jc...@redhat.com> wrote: > On Wed, Feb 08, 2017 at 09:23:33PM -0800, Ashish Mittal wrote: >> From: Ashish Mittal <ashish.mit...@veritas.com> >> >> Source code for the qnio library that this code loads can be downl

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Thu, Feb 9, 2017 at 10:45 AM, ashish mittal <ashmit...@gmail.com> wrote: > On Thu, Feb 9, 2017 at 10:08 AM, ashish mittal <ashmit...@gmail.com> wrote: >> On Thu, Feb 9, 2017 at 8:50 AM, Jeff Cody <jc...@redhat.com> wrote: >>> On Thu, Feb 09, 2017 at 0

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Tue, Feb 14, 2017 at 12:51 PM, Jeff Cody <jc...@redhat.com> wrote: > On Thu, Feb 09, 2017 at 01:24:58AM -0800, ashish mittal wrote: >> On Wed, Feb 8, 2017 at 10:29 PM, Jeff Cody <jc...@redhat.com> wrote: >> > On Wed, Feb 08, 2017 at 09:23:33PM -0800, Ashish Mi

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Thu, Feb 9, 2017 at 6:32 AM, Jeff Cody <jc...@redhat.com> wrote: > On Thu, Feb 09, 2017 at 01:24:58AM -0800, ashish mittal wrote: >> On Wed, Feb 8, 2017 at 10:29 PM, Jeff Cody <jc...@redhat.com> wrote: >> > On Wed, Feb 08, 2017 at 09:23:33PM -0800, Ashish Mittal wr

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Thu, Feb 9, 2017 at 10:08 AM, ashish mittal <ashmit...@gmail.com> wrote: > On Thu, Feb 9, 2017 at 8:50 AM, Jeff Cody <jc...@redhat.com> wrote: >> On Thu, Feb 09, 2017 at 08:14:38AM -0800, ashish mittal wrote: >>> On Thu, Feb 9, 2017 at 6:32 AM, Jeff Cody <jc..

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Thu, Feb 9, 2017 at 8:50 AM, Jeff Cody <jc...@redhat.com> wrote: > On Thu, Feb 09, 2017 at 08:14:38AM -0800, ashish mittal wrote: >> On Thu, Feb 9, 2017 at 6:32 AM, Jeff Cody <jc...@redhat.com> wrote: >> > On Thu, Feb 09, 2017 at 01:24:58AM -0800, ashish mittal wr

Re: [Qemu-devel] [PATCH v3 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

pretty straightforward, but not very helpful. Could somebody please suggest a sample implementation (other than gluster.c) that parses a list of server like options in the json format? Thanks, Ashish On Wed, Aug 17, 2016 at 2:58 PM, ashish mittal <ashmit...@gmail.com> wrote: > Thanks Paol

Re: [Qemu-devel] [PATCH v3 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

just does the QEMU driver integration & unit tests. ... // Regards, Ashish On Wed, Aug 17, 2016 at 4:22 AM, Paolo Bonzini <pbonz...@redhat.com> wrote: > > > On 15/08/2016 18:29, ashish mittal wrote: >>>> +/* >>>> + * Conver

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Mon, Feb 27, 2017 at 1:22 AM, Daniel P. Berrange <berra...@redhat.com> wrote: > On Fri, Feb 24, 2017 at 03:30:21PM -0800, ashish mittal wrote: >> Thanks! >> >> I hope the following is in line with what you suggested - > > Yes, that looks suitable for password au

Re: [Qemu-devel] [PATCH v4 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

: > > On Mon, Aug 22, 2016 at 11:56:30PM -0700, Ashish Mittal wrote: >> This patch adds support for a new block device type called "vxhs". >> Source code for the library that this code loads can be downloaded from: >> https://github.com/MittalAshish/libqnio.g

Re: [Qemu-devel] [PATCH v4 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

l change accordingly. I also completely agree on the discussion of libqnio calling a qemu function. Will check on the best way to resolve that and get back. Thanks, Ashish On Thu, Sep 8, 2016 at 7:00 AM, Jeff Cody <jc...@redhat.com> wrote: > On Wed, Sep 07, 2016 at 03:32:47PM

Re: [Qemu-devel] vxhs caching behaviour (was: [PATCH v4 RFC] block/vxhs: Initial commit to add) Veritas HyperScale VxHS block device support

Hi Kevin, By design, our writeback cache is on non-volatile SSD device. We do async writes to this cache and also maintain a persistent index map of the data written. This gives us the capability to recover write-back cache if needed. Thanks, Ashish On Thu, Sep 8, 2016 at 7:20 AM, Kevin Wolf

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

That makes perfect sense. I will try and follow this method now onwards. Thanks! On Wed, Sep 28, 2016 at 7:18 PM, Jeff Cody <jc...@redhat.com> wrote: > On Tue, Sep 27, 2016 at 09:09:49PM -0700, Ashish Mittal wrote: >> This patch adds support for a new block device type called &q

Re: [Qemu-devel] [PATCH v6 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

libqnio source has been updated. qemu changes should now build properly. https://github.com/MittalAshish/libqnio.git I will work on the other suggestions and get back. Regards, Ashish On Wed, Sep 21, 2016 at 8:03 AM, Paolo Bonzini <pbonz...@redhat.com> wrote: > > > On 21/09/201

[Qemu-devel] [PATCH v6 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

"},{"host":"172.172.17.2","port":""}]}' Sample command line using URI syntax: qemu-img convert -f raw -O raw -n /var/lib/nova/instances/_base/0c5eacd5ebea5ed914b6a3e7b18f1ce734c386ad vxhs://192.168.0.1:/%7Bc6718f6b-0401-441d-a8c3-1f0064d75

Re: [Qemu-devel] [PATCH v4 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

questions soon. Regards, Ashish On Thu, Sep 8, 2016 at 4:15 PM, ashish mittal <ashmit...@gmail.com> wrote: >>> Yes, qemu_iio_ioctl(VDISK_AIO_FLUSH) is only a place-holder at present >>> in case we later want to add some functionality to it. I have now >>> added a co

Re: [Qemu-devel] [PATCH v6 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

On Tue, Sep 20, 2016 at 10:53 PM, Jeff Cody <jc...@redhat.com> wrote: > On Tue, Sep 20, 2016 at 06:07:45PM -0700, Ashish Mittal wrote: >> This patch adds support for a new block device type called "vxhs". >> Source code for the library that this code loads c

[Qemu-devel] [PATCH v5 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

"},{"host":"172.172.17.2","port":""}]}' Sample command line using URI syntax: qemu-img convert -f raw -O raw -n /var/lib/nova/instances/_base/0c5eacd5ebea5ed914b6a3e7b18f1ce734c386ad vxhs://192.168.0.1:/%7Bc6718f6b-0401-441d-a8c3-1f00

Re: [Qemu-devel] [PATCH v3 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

efa...@gmail.com> wrote: > On Sat, Aug 20, 2016 at 11:42:22AM -0700, ashish mittal wrote: >> I'm trying to understand how I can parse a json command line having >> multiple server list (InetSocketAddressList) without the QemuOpts -> >> QDict -> QAPI conversion that

Re: [Qemu-devel] [PATCH v3 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

Hi Daniel, In V4 of the patch: On Mon, Aug 15, 2016 at 3:20 AM, Daniel P. Berrange wrote: >> + * Convert the json formatted command line into qapi. >> +*/ >> + >> +static int vxhs_parse_json(BlockdevOptionsVxHS *conf, >> + QDict *options,

Re: [Qemu-devel] [PATCH v3 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

Hi Kevin, Changed per your suggestion in V4 patch. Please review when you get some time. Thanks, Ashish On Mon, Aug 15, 2016 at 3:47 AM, Kevin Wolf <kw...@redhat.com> wrote: > Am 15.08.2016 um 12:20 hat Daniel P. Berrange geschrieben: >> On Sat, Aug 13, 2016 at 09:35:12PM -0700

[Qemu-devel] [PATCH v4 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

"},{"host":"172.172.17.2","port":""}]}' Sample command line using URI syntax: qemu-img convert -f raw -O raw -n /var/lib/nova/instances/_base/0c5eacd5ebea5ed914b6a3e7b18f1ce734c386ad vxhs://192.168.0.1:/%7Bc6718f6b-0401-441d-a8c3-1f0064d75e

Re: [Qemu-devel] [PATCH v6 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

On Wed, Sep 21, 2016 at 8:03 AM, Paolo Bonzini <pbonz...@redhat.com> wrote: > > > On 21/09/2016 03:07, Ashish Mittal wrote: >> +int32_t vxhs_qnio_iio_writev(void *qnio_ctx, uint32_t rfd, struct iovec >> *iov, >> +

Re: [Qemu-devel] [PATCH v6 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

On Tue, Sep 20, 2016 at 10:53 PM, Jeff Cody <jc...@redhat.com> wrote: > On Tue, Sep 20, 2016 at 06:07:45PM -0700, Ashish Mittal wrote: >> This patch adds support for a new block device type called "vxhs". >> Source code for the library that this code loads c

[Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

"},{"host":"172.172.17.2","port":""}]}' Sample command line using URI syntax: qemu-img convert -f raw -O raw -n /var/lib/nova/instances/_base/0c5eacd5ebea5ed914b6a3e7b18f1ce734c386ad vxhs://192.168.0.1:/%7Bc6718f6b-0401-441d-a8c3-1f0

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

Hi Stefan, others, Thank you for all the review comments. On Wed, Sep 28, 2016 at 4:13 AM, Stefan Hajnoczi <stefa...@gmail.com> wrote: > On Tue, Sep 27, 2016 at 09:09:49PM -0700, Ashish Mittal wrote: >> +vxhs_bdrv_init(const char c) "Registering VxHS AIO driver%c" > &

[Qemu-devel] [PATCH v1] block/vxhs: Add Veritas HyperScale VxHS block device support

ot;"}]}' Sample command line using URI syntax: qemu-img convert -f raw -O raw -n /var/lib/nova/instances/_base/0c5eacd5ebea5ed914b6a3e7b18f1ce734c386ad vxhs://192.168.0.1:/%7Bc6718f6b-0401-441d-a8c3-1f0064d75ee0%7D Signed-off-by: Ashish Mittal <ashish.mit...

Re: [Qemu-devel] [PATCH v2] block/vxhs: Add Veritas HyperScale VxHS block device support

at.com> wrote: > On Wed, Oct 26, 2016 at 03:23:05PM -0700, Ashish Mittal wrote: >> This patch adds support for a new block device type called "vxhs". >> Source code for the library that this code loads can be downloaded from: >> https://github.com/MittalAshish/l

Re: [Qemu-devel] [PATCH v3] block/vxhs: Add Veritas HyperScale VxHS block device support

Hi Eric, On Fri, Oct 28, 2016 at 7:44 AM, Eric Blake <ebl...@redhat.com> wrote: > On 10/28/2016 02:44 AM, Ashish Mittal wrote: >> This patch adds support for a new block device type called "vxhs". >> Source code for the qnio library that this code loads c

Re: [Qemu-devel] [PATCH v4] This patch adds support for a new block device type called "vxhs".

On Fri, Nov 4, 2016 at 6:04 AM, Stefan Hajnoczi wrote: > Please keep using "block/vxhs: Add Veritas HyperScale VxHS block device > support" as the cover letter email subject. This way tools are able to > automatically mark old versions of this patch series as obsolete. Sent

[Qemu-devel] [PATCH v6 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

rt -f raw -O raw -n /var/lib/nova/instances/_base/0c5eacd5ebea5ed914b6a3e7b18f1ce734c386ad vxhs://192.168.0.1:/c6718f6b-0401-441d-a8c3-1f0064d75ee0 Signed-off-by: Ashish Mittal <ashish.mit...@veritas.com> --- v6 changelog: (1) Added qemu-iotests for VxHS as a new patch in the series. (2)

[Qemu-devel] [PATCH v6 0/2] block/vxhs: Add Veritas HyperScale VxHS block device support

HyperScale storage service. This library (libqnio) has been open sourced and is available on github here: https://github.com/MittalAshish/libqnio Ashish Mittal (2): block/vxhs.c: Add support for a new block device type called "vxhs" block/vxhs.c: Add qemu-iotests for new block device

[Qemu-devel] [PATCH v6 2/2] block/vxhs.c: Add qemu-iotests for new block device type "vxhs"

These changes use a vxhs test server that is a part of the following repository: https://github.com/MittalAshish/libqnio.git Signed-off-by: Ashish Mittal <ashish.mit...@veritas.com> --- v6 changelog: (1) Added iotests for VxHS block device. tests/qemu-iotests/common| 6 ++

Re: [Qemu-devel] [PATCH v4] This patch adds support for a new block device type called "vxhs".

On Mon, Nov 7, 2016 at 5:52 PM, Fam Zheng <f...@redhat.com> wrote: > On Mon, 11/07 17:39, ashish mittal wrote: >> I guess the email subject of the individual patches is OK to >> change? > > Yes, that is fine, as long as it doesn't burden incremental reviewing > unnecessarily. > OK. Thanks!

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

Will look into these ASAP. On Mon, Nov 14, 2016 at 7:05 AM, Stefan Hajnoczi <stefa...@gmail.com> wrote: > On Wed, Sep 28, 2016 at 10:45 PM, Stefan Hajnoczi <stefa...@gmail.com> wrote: >> On Tue, Sep 27, 2016 at 09:09:49PM -0700, Ashish Mittal wrote: >&

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

On the topic of protocol security - Would it be enough for the first patch to implement only authentication and not encryption? On Wed, Nov 23, 2016 at 12:25 AM, Ketan Nilangekar wrote: > +Nitin Jerath from Veritas. > > > > > On 11/18/16, 7:06 PM, "Daniel P.

Re: [Qemu-devel] [PATCH v6 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

Thanks for concluding on this. I will rearrange the qnio_api.h header accordingly as follows: +#include "qemu/osdep.h" +#include<=== after osdep.h +#include "block/block_int.h" +#include "qapi/qmp/qerror.h" +#include "qapi/qmp/qdict.h" +#include "qapi/qmp/qstring.h" +#include "trace.h"

Re: [Qemu-devel] [PATCH v6 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Wed, Nov 16, 2016 at 3:27 AM, Stefan Hajnoczi <stefa...@gmail.com> wrote: > On Wed, Nov 16, 2016 at 9:49 AM, Fam Zheng <f...@redhat.com> wrote: >> On Wed, 11/16 10:04, Markus Armbruster wrote: >>> ashish mittal <ashmit...@gmail.com> writes: >>> >&

Re: [Qemu-devel] [PATCH v3 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

Hi Stefan, I had replied to the QEMUBH suggestion in the email below. Regards, Ashish On Tue, Aug 23, 2016 at 3:22 PM, ashish mittal <ashmit...@gmail.com> wrote: > Thanks Stefan, I will look at block/quorum.c. > > I have sent V4 of the patch with a reworked parsing logic for both

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

Hi Stefan On Wed, Sep 28, 2016 at 2:45 PM, Stefan Hajnoczi <stefa...@gmail.com> wrote: > On Tue, Sep 27, 2016 at 09:09:49PM -0700, Ashish Mittal wrote: > > Review of .bdrv_open() and .bdrv_aio_writev() code paths. > > The big issues I see in this driver and libqnio: >

Re: [Qemu-devel] [PATCH v6 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Mon, Nov 14, 2016 at 7:07 AM, Stefan Hajnoczi <stefa...@gmail.com> wrote: > On Mon, Nov 07, 2016 at 04:59:44PM -0800, Ashish Mittal wrote: >> Source code for the qnio library that this code loads can be downloaded from: >> https://github.com/MittalAshish/libqnio.git >

Re: [Qemu-devel] [PATCH v3 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

Thank you. Will work with this. On Tue, Nov 15, 2016 at 12:48 PM, Stefan Hajnoczi <stefa...@gmail.com> wrote: > On Tue, Nov 15, 2016 at 11:02:34AM -0800, ashish mittal wrote: >> I had replied to the QEMUBH suggestion in the email below. >> >> Regards, >> Ashish &

Re: [Qemu-devel] [PATCH v4] This patch adds support for a new block device type called "vxhs".

Thanks Jeff! All of the review comments have been addressed in v5. On Mon, Oct 31, 2016 at 2:55 PM, Jeff Cody <jc...@redhat.com> wrote: > On Fri, Oct 28, 2016 at 11:47:11PM -0700, Ashish Mittal wrote: >> Source code for the qnio library that this code loads can be downloaded

[Qemu-devel] [PATCH v5] block/vxhs.c Add support for a new block device type called "vxhs"

rt -f raw -O raw -n /var/lib/nova/instances/_base/0c5eacd5ebea5ed914b6a3e7b18f1ce734c386ad vxhs://192.168.0.1:/c6718f6b-0401-441d-a8c3-1f0064d75ee0 Signed-off-by: Ashish Mittal <ashish.mit...@veritas.com> --- v5 changelog: (1) Incorporated v4 review comments. v4 changelog: (1) Incorp

Re: [Qemu-devel] [PATCH v3] block/vxhs: Add Veritas HyperScale VxHS block device support

>> >> +## >> >> +{ 'struct': 'BlockdevOptionsVxHS', >> >> + 'data': { 'vdisk_id': 'str', >> >> +'server': 'InetSocketAddress' } } >> > >> > Is there any way to use a Unix socket, or is this server ONLY accessible >> > over IPv4/IPv6? >> > >> >> Right now we support IPv4 only. > > IMHO

Re: [Qemu-devel] [PATCH v5] block/vxhs.c Add support for a new block device type called "vxhs"

:07 AM, Daniel P. Berrange <berra...@redhat.com> wrote: > On Mon, Oct 31, 2016 at 11:34:58PM -0700, Ashish Mittal wrote: >> Source code for the qnio library that this code loads can be downloaded >> from: >> https://github.com/MittalAshish/libqnio.git > > Your p

Re: [Qemu-devel] [PATCH v4] This patch adds support for a new block device type called "vxhs".

Thanks! Will fix these in the next patch! On Mon, Oct 31, 2016 at 12:05 PM, Eric Blake <ebl...@redhat.com> wrote: > On 10/29/2016 01:47 AM, Ashish Mittal wrote: >> Source code for the qnio library that this code loads can be downloaded from: >> https://github.com/Mit

Re: [Qemu-devel] [PATCH v5] block/vxhs.c Add support for a new block device type called "vxhs"

@rhel72ga-build-upstream qemu] 2016-11-01 09:48:13$ Thanks! On Tue, Nov 1, 2016 at 9:27 AM, Daniel P. Berrange <berra...@redhat.com> wrote: > On Tue, Nov 01, 2016 at 09:09:31AM -0700, ashish mittal wrote: >> Hi Daniel, >> >> Thanks for pointing that out. I had done a fresh c

Re: [Qemu-devel] [PATCH v2] block/vxhs: Add Veritas HyperScale VxHS block device support

I have submitted v3 with the QAPI schema changes. Regards, Ashish On Thu, Oct 27, 2016 at 2:38 AM, ashish mittal <ashmit...@gmail.com> wrote: > Hi Daniel, > >>> >I think this version still does not address Daniel's concerns regarding a >>> >QAPI schema for

[Qemu-devel] [PATCH v3] block/vxhs: Add Veritas HyperScale VxHS block device support

ot;:""}}' Sample command line using the URI syntax: qemu-img convert -f raw -O raw -n /var/lib/nova/instances/_base/0c5eacd5ebea5ed914b6a3e7b18f1ce734c386ad vxhs://192.168.0.1:/%7Bc6718f6b-0401-441d-a8c3-1f0064d75ee0%7D Signed-off-by: Ashish Mittal <ashish.mit...@veritas.com>

[Qemu-devel] [PATCH v4] This patch adds support for a new block device type called "vxhs".

rt -f raw -O raw -n /var/lib/nova/instances/_base/0c5eacd5ebea5ed914b6a3e7b18f1ce734c386ad vxhs://192.168.0.1:/c6718f6b-0401-441d-a8c3-1f0064d75ee0 Signed-off-by: Ashish Mittal <ashish.mit...@veritas.com> --- v4 changelog: (1) Incorporated v3 review comments on QAPI changes. (2) Added refco

Re: [Qemu-devel] [PATCH v3] block/vxhs: Add Veritas HyperScale VxHS block device support

On Wed, Nov 2, 2016 at 7:13 AM, Eric Blake wrote: > On 11/02/2016 04:57 AM, Kevin Wolf wrote: IMHO it should allow use of UNIX sockets, as its possible to have SSH setup a tunnel to a IP server, and expose the endpoint via a UNIX socket. So even if your reference

[Qemu-devel] [PATCH v2] block/vxhs: Add Veritas HyperScale VxHS block device support

ot;"}]}' Sample command line using URI syntax: qemu-img convert -f raw -O raw -n /var/lib/nova/instances/_base/0c5eacd5ebea5ed914b6a3e7b18f1ce734c386ad vxhs://192.168.0.1:/%7Bc6718f6b-0401-441d-a8c3-1f0064d75ee0%7D Signed-off-by: Ashish Mittal <ashish.mit...@veritas.com> --- v2

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

16 at 9:02 PM, Jeff Cody <jc...@redhat.com> wrote: > On Wed, Sep 28, 2016 at 12:13:32PM +0100, Stefan Hajnoczi wrote: >> On Tue, Sep 27, 2016 at 09:09:49PM -0700, Ashish Mittal wrote: > > [...] > >> > +/* >> > + * This is called by QEMU when a flush gets trig

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

1/24/16, 4:41 PM, "Stefan Hajnoczi" <stefa...@gmail.com> >> wrote: >> > > On Thu, Nov 24, 2016 at 05:44:37AM +, Ketan Nilangekar >> wrote: >> > > > On 11/24/16, 4:07 AM, "Paolo Bo

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

Hi, I am requesting feedback on the following design proposal for libqnio. This adds an access control mechanism between libqnio client and server. It is not a full client-server authentication model, and it is not intended to substitute an authentication mechanism. We wanted to check if the

Re: [Qemu-devel] [PATCH v10 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Mon, Mar 27, 2017 at 8:56 AM, Eric Blake <ebl...@redhat.com> wrote: > On 03/26/2017 09:50 PM, Ashish Mittal wrote: >> Source code for the qnio library that this code loads can be downloaded from: >> https://github.com/VeritasHyperScale/libqnio.git > > When sending a

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Wed, Mar 22, 2017 at 5:03 PM, ashish mittal <ashmit...@gmail.com> wrote: > On Mon, Mar 20, 2017 at 5:55 AM, Daniel P. Berrange <berra...@redhat.com> > wrote: >> On Fri, Mar 17, 2017 at 06:44:56PM -0700, ashish mittal wrote: >>> On Thu, Mar 16, 2017

[Qemu-devel] [PATCH v10 2/2] block/vxhs.c: Add qemu-iotests for new block device type "vxhs"

These changes use a vxhs test server that is a part of the following repository: https://github.com/VeritasHyperScale/libqnio.git Signed-off-by: Ashish Mittal <ashish.mit...@veritas.com> --- v10 changelog: (1) Redirect o/p of "$QEMU_VXHS -d $TEST_DIR" to /dev/null v9 change

[Qemu-devel] [PATCH v10 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

int=client -c 'read -v 66000 2.5k' 'json:{"server.host": "127.0.0.1", "server.port": "", "vdisk-id": "/test.raw", "driver": "vxhs", "tls-creds":"tls0"}' Signed-off-by: Ashish Mittal <ashish.mi

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Mon, Mar 20, 2017 at 5:55 AM, Daniel P. Berrange <berra...@redhat.com> wrote: > On Fri, Mar 17, 2017 at 06:44:56PM -0700, ashish mittal wrote: >> On Thu, Mar 16, 2017 at 5:29 PM, ashish mittal <ashmit...@gmail.com> wrote: >> > On Mon, Mar 13, 2017 at 2:57

Re: [Qemu-devel] [PATCH v10 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

hen send v11 series if everyone okays the diff? Regards, Ashish On Tue, Mar 28, 2017 at 10:03 AM, Jeff Cody <jc...@redhat.com> wrote: > On Sun, Mar 26, 2017 at 07:50:35PM -0700, Ashish Mittal wrote: >> Source code for the qnio library that this code loads can be downloaded

Re: [Qemu-devel] [PATCH v10 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Mon, Mar 27, 2017 at 10:27 AM, Stefan Hajnoczi <stefa...@gmail.com> wrote: > On Sun, Mar 26, 2017 at 07:50:35PM -0700, Ashish Mittal wrote: > > Have you tested live migration? > > If live migration is not supported then a migration blocker should be > added using migrate

Re: [Qemu-devel] [PATCH v10 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Mon, Mar 27, 2017 at 6:04 PM, ashish mittal <ashmit...@gmail.com> wrote: > On Mon, Mar 27, 2017 at 10:27 AM, Stefan Hajnoczi <stefa...@gmail.com> wrote: >> On Sun, Mar 26, 2017 at 07:50:35PM -0700, Ashish Mittal wrote: >> >> Have you tested live m

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Thu, Mar 16, 2017 at 5:29 PM, ashish mittal <ashmit...@gmail.com> wrote: > On Mon, Mar 13, 2017 at 2:57 AM, Daniel P. Berrange <berra...@redhat.com> > wrote: >> On Tue, Mar 07, 2017 at 05:27:55PM -0800, ashish mittal wrote: >>> Thanks! There i

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Mon, Mar 13, 2017 at 2:57 AM, Daniel P. Berrange <berra...@redhat.com> wrote: > On Tue, Mar 07, 2017 at 05:27:55PM -0800, ashish mittal wrote: >> Thanks! There is one more input I need some help with! >> >> VxHS network library opens a fixed number of connection

[Qemu-devel] [PATCH v11 0/2] block/vxhs.c: Add support for a new block device type called "vxhs"

HyperScale storage service. This library (libvxhs) has been open sourced and is available on github here: https://github.com/VeritasHyperScale/libqnio.git Ashish Mittal (2): block/vxhs.c: Add support for a new block device type called "vxhs" block/vxhs.c: Add qemu-iotests for new block d

[Qemu-devel] [PATCH v11 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

int=client -c 'read -v 66000 2.5k' 'json:{"server.host": "127.0.0.1", "server.port": "", "vdisk-id": "/test.raw", "driver": "vxhs", "tls-creds":"tls0"}' Signed-off-by: Ashish Mittal <ashish.mit..

[Qemu-devel] [PATCH v11 2/2] block/vxhs.c: Add qemu-iotests for new block device type "vxhs"

These changes use a vxhs test server that is a part of the following repository: https://github.com/VeritasHyperScale/libqnio.git Signed-off-by: Ashish Mittal <ashish.mit...@veritas.com> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> --- v11 changelog: (1) No changes. v10 c

Re: [Qemu-devel] [PATCH v10 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Mon, Apr 3, 2017 at 8:11 AM, Stefan Hajnoczi <stefa...@gmail.com> wrote: > On Fri, Mar 31, 2017 at 11:25:02AM -0700, ashish mittal wrote: >> On Mon, Mar 27, 2017 at 6:04 PM, ashish mittal <ashmit...@gmail.com> wrote: >> > On Mon, Mar 27, 2017 at 10:27 AM, Stefa

Re: [Qemu-devel] [PATCH v11 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Tue, Apr 11, 2017 at 12:47 PM, Jeff Cody <jc...@redhat.com> wrote: > On Mon, Apr 03, 2017 at 08:48:08PM -0700, Ashish Mittal wrote: >> Source code for the qnio library that this code loads can be downloaded from: >> https://github.com/VeritasHyperScale/libqnio.git >

Re: [Qemu-devel] [PATCH v11 0/2] block/vxhs.c: Add support for a new block device type called "vxhs"

Thanks Jeff! On Thu, Apr 20, 2017 at 8:03 AM, Jeff Cody <jc...@redhat.com> wrote: > On Mon, Apr 03, 2017 at 08:48:07PM -0700, Ashish Mittal wrote: >> - Veritas HyperScale block driver in QEMU is designed to provide an >> accelerated >> IO path from KVM virtual mac

Re: [Qemu-devel] [PATCH v11 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Wed, Apr 19, 2017 at 9:27 AM, Stefan Hajnoczi <stefa...@gmail.com> wrote: > On Mon, Apr 03, 2017 at 08:48:08PM -0700, Ashish Mittal wrote: >> Source code for the qnio library that this code loads can be downloaded from: >> https://github.com/VeritasHyperScale/libqnio.git

  1   2   >